Re: [slightly OT] Re: rediscovered: missing writer documentation

2012-07-06 Thread Cedric Bosdonnat
Hi Italo,

On Fri, 2012-07-06 at 00:28 +0200, Italo Vignoli wrote:
 More than pictures of old products, I look for old pictures of people
 who show that TDF project members were there before - or at the same
 time - of Apache OO members, or paraphernalia like Caolan's paper.

Hum... Would the Writer and Calc team easter eggs from old OOo versions
fit?

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Document conversion engine

2012-07-06 Thread Flavio Moringa
Hi Michael,

first of all thanks for replying.. I was thinking no one would :-)

From your reply I assume that testing the filters, and doing regression
tests is something I could do, maybe identifying the main conversion issues
in groups of documents and kind of creating a major conversion issues
table, and prioritizing those issues. Is there already something like that?

I know that you can convert documents through the command line, using
LibreOffice headless mode, and that can be something that's useful for
scripting automatic tests... although I know that sometimes the main
problems are visual and it's difficult to automatically detect the
problems...

Is there any kind of repository for documents that are candidates for
conversion testing? I mean documents which are known to have conversion
problems, and that are used to test improvements to the filters?

I would like very much to become more involved in improving the conversion
filters, since it seems to be a major problem in LibreOffice adoption, and
everything that can be done to help in that area would certainly boost
LibreOffice adoption specially in the enterprise world.

Thanks
Flávio

2012/7/5 Michael Stahl mst...@redhat.com

 hi Flavio,

 On 03/07/12 12:45, Flavio Moringa wrote:

  I chose as my masters dissertation investigation topic trying to improve
  the document conversion engine in LibreOffice (ex: converting docx to
  odt), and as such I would like to know who is working on the conversion
  engines and how can I help.

 the document conversion engines in LibreOffice are called Writer, Calc,
 Draw and Impress.  conversion from e.g. DOCX to ODT happens by importing
 the DOCX file with the DOCX import filter into Writer, and then
 exporting the document from Writer with the ODF export filter.

 there are also a few filters (such as XSLT filters, and writerperfect if
 i remember correctly) that use ODF as an intermediate format, i.e., they
 import by converting their format to ODF and then importing that into
 the LO application, and export the reverse way.

  I'm not a programmer, so what I'm interested in doing is something in
  the lines of investigating the main conversion problems, identifying the
  possible conversion flows, analysing the way the conversion flow is
  implemented in LibreOffice, and eventually trying to improve this flow
  somehow.

 it seems to me the main conversion problem is a lack of manpower to
 improve the filters.  oh, and more regression tests would be useful.




-- 
*Flávio Moringa*
Project Leader



Caixa Mágica Software
Energia Open Source
Rua Soeiro Pereira Gomes, Lote 1 - 4.º B,
Edifício Espanha, 1600-196 Lisboa - Portugal
Tel.: +351 217 921 260 Fax: +351 217 921 261
http://www.caixamagica.pt
https://twitter.com/flaviomoringa
https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa
http://pt.linkedin.com/in/flaviomoringa
http://people.caixamagica.pt/flaviomoringa
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Change in core[master]: fdo#42986 - UI wide screen format (16:10): Add Page size

2012-07-06 Thread Gerrit
From Ivan Timofeev timofeev@gmail.com:

Ivan Timofeev has submitted this change and it was merged.

Change subject: fdo#42986 - UI wide screen format (16:10): Add Page size
..


fdo#42986 - UI wide screen format (16:10): Add Page size

Change-Id: Ie769c9a65e85f91395b3495fadb6f5e688cbe9af
---
M cui/source/tabpages/page.cxx
M cui/source/tabpages/page.h
M cui/source/tabpages/page.src
M i18nutil/inc/i18nutil/paper.hxx
M i18nutil/source/utility/paper.cxx
5 files changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Ivan Timofeev: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/260
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie769c9a65e85f91395b3495fadb6f5e688cbe9af
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Andras Timar ati...@suse.com
Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Change in core[master]: fdo#42986 - UI wide screen format (16:10): Add Page size

2012-07-06 Thread Gerrit
From Ivan Timofeev timofeev@gmail.com:

Ivan Timofeev has posted comments on this change.

Change subject: fdo#42986 - UI wide screen format (16:10): Add Page size
..


Patch Set 1: Verified; Looks good to me, approved

Nice, why not :) Sadly it's too late for libreoffice-3-6, which is UI-frozen 
now.

--
To view, visit https://gerrit.libreoffice.org/260
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie769c9a65e85f91395b3495fadb6f5e688cbe9af
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Rob Snelders libreoff...@ertai.nl
Gerrit-Reviewer: Andras Timar ati...@suse.com
Gerrit-Reviewer: Ivan Timofeev timofeev@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 51324, which changed state.

Bug 51324 Summary: crash in 
xmloff.Impress.XMLContentImporter::com::sun::star::document::XImporter by CXX0X 
ABI incompatibilities
https://bugs.freedesktop.org/show_bug.cgi?id=51324

   What|Old Value   |New Value

 Resolution||NOTOURBUG
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: cui/source i18nutil/inc i18nutil/source

2012-07-06 Thread Ivan Timofeev
 cui/source/tabpages/page.cxx  |4 ++--
 cui/source/tabpages/page.h|1 +
 cui/source/tabpages/page.src  |1 +
 i18nutil/inc/i18nutil/paper.hxx   |5 +++--
 i18nutil/source/utility/paper.cxx |3 ++-
 5 files changed, 9 insertions(+), 5 deletions(-)

New commits:
commit b8c5f6577911ebb15ad7eb7f60ad5bb9d8d37f0b
Author: Rob Snelders programm...@ertai.nl
Date:   Thu Jul 5 20:45:15 2012 +0200

fdo#42986 - UI wide screen format (16:10): Add Page size

Change-Id: Ie769c9a65e85f91395b3495fadb6f5e688cbe9af

diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 0c5ea75..ecdc05f 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -997,7 +997,7 @@ IMPL_LINK( SvxPageDescPage, PaperSizeSelect_Impl, ListBox 
*, pBox )
 {
 // Draw: if paper format the margin shall be 1 cm
 long nTmp = 0;
-sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )|| ( 
PAPER_SCREEN_16_9 == ePaper));
+sal_Bool bScreen = (( PAPER_SCREEN_4_3 == ePaper )||( 
PAPER_SCREEN_16_9 == ePaper)||( PAPER_SCREEN_16_10 == ePaper));
 
 if ( !bScreen )
 // no margin if screen
@@ -1408,7 +1408,7 @@ int SvxPageDescPage::DeactivatePage( SfxItemSet* _pSet )
 sal_uInt16 nPos = aPaperSizeBox.GetSelectEntryPos();
 Paper ePaper = (Paper)(sal_uLong)aPaperSizeBox.GetEntryData( nPos );
 
-if ( ePaper != PAPER_SCREEN_4_3  ePaper != PAPER_SCREEN_16_9  
IsMarginOutOfRange() )
+if ( ePaper != PAPER_SCREEN_4_3  ePaper != PAPER_SCREEN_16_9  ePaper 
!= PAPER_SCREEN_16_10  IsMarginOutOfRange() )
 {
 if ( QueryBox( this, WB_YES_NO | WB_DEF_NO, aPrintRangeQueryText 
).Execute() == RET_NO )
 {
diff --git a/cui/source/tabpages/page.h b/cui/source/tabpages/page.h
index 58ebb4e..7630200 100644
--- a/cui/source/tabpages/page.h
+++ b/cui/source/tabpages/page.h
@@ -66,6 +66,7 @@
 #define PAPERSIZE_POSTCARD_JP   46
 #define PAPERSIZE_A656
 #define PAPERSIZE_SCREEN_16_9   78
+#define PAPERSIZE_SCREEN_16_10  79
 
 #endif
 
diff --git a/cui/source/tabpages/page.src b/cui/source/tabpages/page.src
index 0397b2d..0026f9a 100644
--- a/cui/source/tabpages/page.src
+++ b/cui/source/tabpages/page.src
@@ -470,6 +470,7 @@ StringArray RID_SVXSTRARY_PAPERSIZE_DRAW
  Dia Slide ; PAPERSIZE_DIA ;  ;
  Screen 4:3 ; PAPERSIZE_SCREEN_4_3 ;  ;
  Screen 16:9 ; PAPERSIZE_SCREEN_16_9 ;  ;
+ Screen 16:10 ; PAPERSIZE_SCREEN_16_10 ;  ;
  Japanese Postcard ; PAPERSIZE_POSTCARD_JP;  ;
 };
 };
diff --git a/i18nutil/inc/i18nutil/paper.hxx b/i18nutil/inc/i18nutil/paper.hxx
index 98b88bd..65ebb38 100644
--- a/i18nutil/inc/i18nutil/paper.hxx
+++ b/i18nutil/inc/i18nutil/paper.hxx
@@ -117,11 +117,12 @@ enum Paper
 PAPER_ARCHC,
 PAPER_ARCHD,
 PAPER_ARCHE,
-PAPER_SCREEN_16_9
+PAPER_SCREEN_16_9,
+PAPER_SCREEN_16_10
 };
 
 // defined for 'equal size' test with the implementation array
-#define NUM_PAPER_ENTRIES   (PAPER_SCREEN_16_9 - PAPER_A0 + 1)
+#define NUM_PAPER_ENTRIES   (PAPER_SCREEN_16_10 - PAPER_A0 + 1)
 
 // -
 // - Paper -
diff --git a/i18nutil/source/utility/paper.cxx 
b/i18nutil/source/utility/paper.cxx
index 8f4fb91..e67cf74 100644
--- a/i18nutil/source/utility/paper.cxx
+++ b/i18nutil/source/utility/paper.cxx
@@ -154,7 +154,8 @@ static PageDesc aDinTab[] =
 { IN2MM100( 18 ),IN2MM100( 24 ), ARCHC,  NULL },
 { IN2MM100( 24 ),IN2MM100( 36 ), ARCHD,  NULL },
 { IN2MM100( 36 ),IN2MM100( 48 ), ARCHE,  NULL },
-{ MM2MM100( 157.5),  MM2MM100( 280 ),NULL,  NULL } //Screen 16:9
+{ MM2MM100( 157.5),  MM2MM100( 280 ),NULL,  NULL }, //Screen 16:9
+{ MM2MM100( 175 ),   MM2MM100( 280 ),NULL,  NULL }  //Screen 16:10
 
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-6' - toolkit/source

2012-07-06 Thread Noel Power
 toolkit/source/controls/dialogcontrol.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit eae1d5d9664bb6ab9fedcf573bdfe6640b22fe4d
Author: Noel Power noel.po...@novell.com
Date:   Fri Jul 6 11:11:55 2012 +0100

fix dialog editor crasher fdo#51269

missing clone of AllDialogChildren property was the culprit here.

Change-Id: I6c5ee105003967429d5bf79639ae75fb7d90562a

diff --git a/toolkit/source/controls/dialogcontrol.cxx 
b/toolkit/source/controls/dialogcontrol.cxx
index 41633b5..51c0510 100644
--- a/toolkit/source/controls/dialogcontrol.cxx
+++ b/toolkit/source/controls/dialogcontrol.cxx
@@ -186,6 +186,19 @@ UnoControlDialogModel::UnoControlDialogModel( const 
Reference XMultiServiceFact
 UnoControlDialogModel::UnoControlDialogModel( const UnoControlDialogModel 
rModel )
 : ControlModelContainerBase( rModel )
 {
+// need to clone BASEPROPERTY_USERFORMCONTAINEES too
+Reference XNameContainer  xSrcNameCont( const_cast 
UnoControlDialogModel (rModel).getPropertyValue( GetPropertyName( 
BASEPROPERTY_USERFORMCONTAINEES ) ), UNO_QUERY );
+ReferenceXNameContainer  xNameCont( new SimpleNamedThingContainer 
XControlModel () );
+
+uno::Sequence rtl::OUString  sNames = xSrcNameCont-getElementNames();
+rtl::OUString* pName = sNames.getArray();
+rtl::OUString* pNamesEnd = pName + sNames.getLength();
+for ( ; pName != pNamesEnd; ++pName )
+{
+if ( xSrcNameCont-hasByName( *pName ) )
+xNameCont-insertByName( *pName, xSrcNameCont-getByName( *pName ) 
);
+}
+setFastPropertyValue_NoBroadcast( BASEPROPERTY_USERFORMCONTAINEES, 
makeAny( xNameCont ) );
 }
 
 UnoControlDialogModel::~UnoControlDialogModel()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[REVIEW 3-5] dialog editor crasher

2012-07-06 Thread Noel Power
please see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=60465d0608930500b35127c47946a9908354d7f4 
( note: already in 3.6 )


if someone thinks it's worth it this could be applied to 3.4 as well

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 4 commits - sfx2/inc sfx2/source

2012-07-06 Thread Michael Stahl
 sfx2/inc/sfx2/thumbnailviewitem.hxx  |2 +-
 sfx2/source/control/thumbnailview.cxx|6 ++
 sfx2/source/control/thumbnailviewacc.cxx |5 +++--
 3 files changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 23d947c947d90f4383f9744d5b65cd30afd8dd74
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 12:33:39 2012 +0200

ThumbnailView::SelectItem: -Werror=unused-but-set-variable

Change-Id: I90c626dd1285f725b3008399a71c1ef56887a970

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index 65b..3897f38 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -957,7 +957,6 @@ void ThumbnailView::SelectItem( sal_uInt16 nItemId )
 mnSelItemId = nItemId;
 
 bool bNewOut = IsReallyVisible()  IsUpdateMode();
-bool bNewLine = false;
 
 // if necessary scroll to the visible area
 if ( mbScroll  nItemId )
@@ -966,12 +965,10 @@ void ThumbnailView::SelectItem( sal_uInt16 nItemId )
 if ( nNewLine  mnFirstLine )
 {
 mnFirstLine = nNewLine;
-bNewLine = true;
 }
 else if ( nNewLine  (sal_uInt16)(mnFirstLine+mnVisLines-1) )
 {
 mnFirstLine = (sal_uInt16)(nNewLine-mnVisLines+1);
-bNewLine = true;
 }
 }
 
commit 2cc9e1614e410e5f70db420122bdbf0601252f89
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 12:31:08 2012 +0200

ThumbnailView::ImplEndTracking: -Werror=unused-parameter

Change-Id: Iae4be27a184be20db6f42194382347078d0fb6c2

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index 92938eb..65b 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -535,8 +535,9 @@ void ThumbnailView::ImplTracking( const Point rPos, bool 
bRepeat )
 }
 }
 
-void ThumbnailView::ImplEndTracking( const Point rPos, bool bCancel )
+void ThumbnailView::ImplEndTracking(const Point /*rPos*/, bool const 
/*bCancel*/)
 {
+//FIXME TODO
 }
 
 IMPL_LINK (ThumbnailView, OnFolderSelected, ThumbnailViewItem*, pItem)
diff --git a/sfx2/source/control/thumbnailviewacc.cxx 
b/sfx2/source/control/thumbnailviewacc.cxx
index 7fe5d42..48a6ce9 100644
--- a/sfx2/source/control/thumbnailviewacc.cxx
+++ b/sfx2/source/control/thumbnailviewacc.cxx
@@ -545,6 +545,7 @@ void SAL_CALL ThumbnailViewAcc::deselectAccessibleChild( 
sal_Int32 nChildIndex )
 // the specified child is currently selected.
 //FIXME TODOif (isAccessibleChildSelected(nChildIndex))
 //FIXME TODO;
+(void) nChildIndex;
 }
 
 sal_Int64 SAL_CALL ThumbnailViewAcc::getSomething( const uno::Sequence 
sal_Int8  rId ) throw( uno::RuntimeException )
commit 67f63a9057c3f3f3bc2aff807426fdf133963524
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 12:28:59 2012 +0200

ThumbnailViewAcc::deselectAccessibleChild: -Werror=empty-body

Change-Id: Ieed8eff3e3e39821ea7efd3d3b349af9b7088112

diff --git a/sfx2/source/control/thumbnailviewacc.cxx 
b/sfx2/source/control/thumbnailviewacc.cxx
index 680a469..7fe5d42 100644
--- a/sfx2/source/control/thumbnailviewacc.cxx
+++ b/sfx2/source/control/thumbnailviewacc.cxx
@@ -543,8 +543,8 @@ void SAL_CALL ThumbnailViewAcc::deselectAccessibleChild( 
sal_Int32 nChildIndex )
 const SolarMutexGuard aSolarGuard;
 // Because of the single selection we can reset the whole selection when
 // the specified child is currently selected.
-if (isAccessibleChildSelected(nChildIndex))
-;
+//FIXME TODOif (isAccessibleChildSelected(nChildIndex))
+//FIXME TODO;
 }
 
 sal_Int64 SAL_CALL ThumbnailViewAcc::getSomething( const uno::Sequence 
sal_Int8  rId ) throw( uno::RuntimeException )
commit 15f32aac7b874eee5f7b7ebe90f50c31ebd5efac
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 12:26:30 2012 +0200

ThumbnailViewItem: -Werror=non-virtual-dtor

Change-Id: Id5de82fd51e92473bf602216226fd432ec48bad5

diff --git a/sfx2/inc/sfx2/thumbnailviewitem.hxx 
b/sfx2/inc/sfx2/thumbnailviewitem.hxx
index e771db3..ac61170 100644
--- a/sfx2/inc/sfx2/thumbnailviewitem.hxx
+++ b/sfx2/inc/sfx2/thumbnailviewitem.hxx
@@ -71,7 +71,7 @@ struct ThumbnailViewItem
 
 ThumbnailViewItem (ThumbnailView rView, Window *pParent);
 
-~ThumbnailViewItem ();
+virtual ~ThumbnailViewItem ();
 
 bool isVisible () const { return mbVisible; }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sfx2/inc sfx2/source

2012-07-06 Thread Michael Stahl
 sfx2/inc/templatedlg.hxx|2 +-
 sfx2/source/doc/templatedlg.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bf744412213eb8b78d68e3ede9fa4ac77b4e0422
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 12:46:49 2012 +0200

SearchUpdateHdl: -Werror=unused-parameter

Change-Id: Iac43e6456fafc924143f3fc749863a56a0e7da12

diff --git a/sfx2/inc/templatedlg.hxx b/sfx2/inc/templatedlg.hxx
index 2efa11d..5fa51ae 100644
--- a/sfx2/inc/templatedlg.hxx
+++ b/sfx2/inc/templatedlg.hxx
@@ -64,7 +64,7 @@ private:
 
 DECL_LINK(OpenTemplateHdl, ThumbnailViewItem*);
 
-DECL_LINK(SearchUpdateHdl, Edit*);
+DECL_LINK(SearchUpdateHdl, void*);
 
 void OnTemplateImport ();
 void OnTemplateSearch ();
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 77f9032..8bf2c44 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -559,7 +559,7 @@ IMPL_LINK(SfxTemplateManagerDlg, OpenTemplateHdl, 
ThumbnailViewItem*, pItem)
 return 0;
 }
 
-IMPL_LINK (SfxTemplateManagerDlg, SearchUpdateHdl, Edit*, pEdit)
+IMPL_LINK_NOARG(SfxTemplateManagerDlg, SearchUpdateHdl)
 {
 // if the search view is hidden, hide the folder view and display search 
one
 if (!mpSearchView-IsVisible())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: framework/source

2012-07-06 Thread Ivan Timofeev
 framework/source/services/backingwindow.hxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 180a67252ef9076ad5ddcc69b5dd8e1bace67913
Author: Ivan Timofeev timofeev@gmail.com
Date:   Fri Jul 6 16:01:21 2012 +0400

update hardcoded borders according to the new Start Center images

Change-Id: I23174caacf26c37b4d63b7374c3a2a4a8d4124c3

diff --git a/framework/source/services/backingwindow.hxx 
b/framework/source/services/backingwindow.hxx
index 96eb909..071b8e0 100644
--- a/framework/source/services/backingwindow.hxx
+++ b/framework/source/services/backingwindow.hxx
@@ -130,10 +130,10 @@ namespace framework
 static const int nItemId_Extensions = 1;
 static const int nItemId_Info = 3;
 static const int nItemId_TplRep = 4;
-static const int nShadowTop = 32;
-static const int nShadowLeft = 35;
-static const int nShadowRight = 45;
-static const int nShadowBottom = 50;
+static const int nShadowTop = 37;
+static const int nShadowLeft = 38;
+static const int nShadowRight = 38;
+static const int nShadowBottom = 38;
 
 void loadImage( const ResId i_rId, PushButton i_rButton );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-6' - framework/source

2012-07-06 Thread Ivan Timofeev
 framework/source/services/backingwindow.hxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 3686e3702a5e3a97f1217435941c2d28a5a81bb0
Author: Ivan Timofeev timofeev@gmail.com
Date:   Fri Jul 6 16:01:21 2012 +0400

update hardcoded borders according to the new Start Center images

Change-Id: I23174caacf26c37b4d63b7374c3a2a4a8d4124c3
(cherry picked from commit 180a67252ef9076ad5ddcc69b5dd8e1bace67913)

diff --git a/framework/source/services/backingwindow.hxx 
b/framework/source/services/backingwindow.hxx
index 96eb909..071b8e0 100644
--- a/framework/source/services/backingwindow.hxx
+++ b/framework/source/services/backingwindow.hxx
@@ -130,10 +130,10 @@ namespace framework
 static const int nItemId_Extensions = 1;
 static const int nItemId_Info = 3;
 static const int nItemId_TplRep = 4;
-static const int nShadowTop = 32;
-static const int nShadowLeft = 35;
-static const int nShadowRight = 45;
-static const int nShadowBottom = 50;
+static const int nShadowTop = 37;
+static const int nShadowLeft = 38;
+static const int nShadowRight = 38;
+static const int nShadowBottom = 38;
 
 void loadImage( const ResId i_rId, PushButton i_rButton );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sw/source

2012-07-06 Thread Miklos Vajna
 sw/source/core/layout/frmtool.cxx  |9 +++--
 sw/source/core/layout/laycache.cxx |3 ---
 2 files changed, 3 insertions(+), 9 deletions(-)

New commits:
commit 9ff68a2848e82e817abc96fd862a488e016c7ec5
Author: Miklos Vajna vmik...@suse.cz
Date:   Fri Jul 6 14:16:55 2012 +0200

sw: InsertNewPage() should ignore GetFirstFmt() if it's shared

This allows to get rid of the ugly hack in
SwLayHelper::CheckInsertPage() and has the same effect.

Change-Id: I491eb617c42bbca3ca1676d7bf44795e947ce6f9

diff --git a/sw/source/core/layout/frmtool.cxx 
b/sw/source/core/layout/frmtool.cxx
index 1a61f72..7cb768e 100644
--- a/sw/source/core/layout/frmtool.cxx
+++ b/sw/source/core/layout/frmtool.cxx
@@ -2701,13 +2701,10 @@ SwPageFrm * InsertNewPage( SwPageDesc rDesc, SwFrm 
*pUpper,
 SwPageFrm *pRet;
 SwDoc *pDoc = ((SwLayoutFrm*)pUpper)-GetFmt()-GetDoc();
 SwFrmFmt *pFmt = 0;
-if (bFirst)
-{
+// rDesc can't know if the first page will be 'left' or 'right', so if
+// first is shared, let's ignore first here.
+if (bFirst  !rDesc.IsHeaderSharedFirst())
 pFmt = rDesc.GetFirstFmt();
-// If there is no first format, use what is relevant anyway.
-if (!pFmt)
-pFmt = bOdd ? rDesc.GetRightFmt() : rDesc.GetLeftFmt();
-}
 else
 pFmt = bOdd ? rDesc.GetRightFmt() : rDesc.GetLeftFmt();
 //Wenn ich kein FrmFmt fuer die Seite gefunden habe, muss ich eben
diff --git a/sw/source/core/layout/laycache.cxx 
b/sw/source/core/layout/laycache.cxx
index a05572a..ee6a02d 100644
--- a/sw/source/core/layout/laycache.cxx
+++ b/sw/source/core/layout/laycache.cxx
@@ -654,9 +654,6 @@ sal_Bool SwLayHelper::CheckInsertPage()
 }
 // If the page style is changing, we'll have a first page.
 bool bNextPageFirst = pDesc != rpPage-GetPageDesc();
-// Considering the page after the first page would be confusing.
-if (rpPage-GetPageDesc() == 
pDoc-GetPageDescFromPool(RES_POOLPAGE_FIRST))
-bNextPageFirst = false;
 ::InsertNewPage( (SwPageDesc)*pDesc, rpPage-GetUpper(),
  bNextPageOdd, bNextPageFirst, bInsertEmpty, 
sal_False, rpPage-GetNext() );
 if ( bEnd )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Review-3-6?] New artwork for 3.6

2012-07-06 Thread Ivan Timofeev

Hi there,

I don't know if that will affect particular builds (e.g. SUSE, RedHat 
etc) but I have pushed

cgit.freedesktop.org/libreoffice/core/commit/?id=180a67252ef9076ad5ddcc69b5dd8e1bace67913
to master and 3-6, which fixes the position of the new Start Center 
images. Just for the record. :)


Best Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: svtools/source vcl/inc vcl/source

2012-07-06 Thread Noel Power
 svtools/source/brwbox/ebbcontrols.cxx |   24 +++-
 vcl/inc/vcl/button.hxx|   15 +--
 vcl/source/control/button.cxx |   18 --
 3 files changed, 44 insertions(+), 13 deletions(-)

New commits:
commit a1345cd93a57ec7d9352f2c71ec2664332ce5e76
Author: Noel Power noel.po...@novell.com
Date:   Fri Jul 6 11:19:57 2012 +0100

fdo#51336 - change vcl checkbox no-label behaviour

Change-Id: I352c6041cc520dc76c302190dcf3a6945f5ac85f

diff --git a/svtools/source/brwbox/ebbcontrols.cxx 
b/svtools/source/brwbox/ebbcontrols.cxx
index 1d7b025..b0ab801 100644
--- a/svtools/source/brwbox/ebbcontrols.cxx
+++ b/svtools/source/brwbox/ebbcontrols.cxx
@@ -253,6 +253,28 @@ namespace svt
 //= CheckBoxControl
 //==
 //--
+
+class CBCntrlTriState : public TriStateBox
+{
+CBCntrlTriState( const CBCntrlTriState  );
+CBCntrlTriState operator= ( const CBCntrlTriState  );
+protected:
+virtual void ImplHandleHoriAlign( const Point rPos, const Size rSize,
+const Size rImageSize, Rectangle 
rStateRect )
+{
+WinBits nWinStyle = GetStyle();
+if ( nWinStyle  WB_CENTER )
+rStateRect.Left() = 
rPos.X()+((rSize.Width()-rImageSize.Width())/2);
+else if ( nWinStyle  WB_RIGHT )
+rStateRect.Left() = rPos.X()+rSize.Width()-rImageSize.Width();
+else
+rStateRect.Left() = rPos.X();
+}
+public:
+CBCntrlTriState( Window* pParent, WinBits nStyle = 0 ) : TriStateBox( 
pParent, nStyle ) {}
+CBCntrlTriState( Window* pParent, const ResId rResId ) : TriStateBox( 
pParent, rResId ) {}
+};
+
 CheckBoxControl::CheckBoxControl(Window* pParent, WinBits nWinStyle)
:Control(pParent, nWinStyle)
 {
@@ -267,7 +289,7 @@ namespace svt
 
 EnableChildTransparentMode();
 
-pBox = new TriStateBox(this,WB_CENTER|WB_VCENTER);
+pBox = new CBCntrlTriState(this,WB_CENTER|WB_VCENTER);
 pBox-EnableChildTransparentMode();
 pBox-SetPaintTransparent( sal_True );
 pBox-SetClickHdl( LINK( this, CheckBoxControl, OnClick ) );
diff --git a/vcl/inc/vcl/button.hxx b/vcl/inc/vcl/button.hxx
index 51b6034..64f7581 100644
--- a/vcl/inc/vcl/button.hxx
+++ b/vcl/inc/vcl/button.hxx
@@ -401,7 +401,6 @@ public:
 
 class VCL_DLLPUBLIC CheckBox : public Button
 {
-private:
 Rectangle   maStateRect;
 Rectangle   maMouseRect;
 TriStatemeState;
@@ -420,7 +419,7 @@ private:
 SAL_DLLPRIVATE void ImplDrawCheckBox( bool bLayout = false );
 SAL_DLLPRIVATE long ImplGetImageToTextDistance() const;
 SAL_DLLPRIVATE Size ImplGetCheckImageSize() const;
-
+private:
 // Copy assignment is forbidden and not implemented.
 SAL_DLLPRIVATE  CheckBox(const CheckBox );
 SAL_DLLPRIVATE  CheckBox operator= (const CheckBox );
@@ -428,15 +427,19 @@ private:
 protected:
 using Control::ImplInitSettings;
 using Window::ImplInit;
+// allows the behaviour of horizontal placement of the checbox image to be
+// overridden.
+virtual void ImplHandleHoriAlign( const Point rPos, const Size rSize,
+const Size rImageSize, Rectangle 
rStateRect );
 SAL_DLLPRIVATE void ImplInit( Window* pParent, WinBits nStyle );
 SAL_DLLPRIVATE void ImplLoadRes( const ResId rResId );
-SAL_DLLPRIVATE virtual void FillLayoutData() const;
-SAL_DLLPRIVATE virtual const Font
+   virtual void FillLayoutData() const;
+   virtual const Font
 GetCanonicalFont( const StyleSettings _rStyle 
) const;
-SAL_DLLPRIVATE virtual const Color
+   virtual const Color
 GetCanonicalTextColor( const StyleSettings 
_rStyle ) const;
 
-SAL_DLLPRIVATE virtual void ImplDrawCheckBoxState();
+   virtual void ImplDrawCheckBoxState();
 SAL_DLLPRIVATE const Rectangle GetStateRect() const { return maStateRect; 
}
 SAL_DLLPRIVATE const Rectangle GetMouseRect() const { return maMouseRect; 
}
 public:
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 6d5a8f9..e3ed723 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -3251,12 +3251,9 @@ void CheckBox::ImplDraw( OutputDevice* pDev, sal_uLong 
nDrawFlags,
 }
 else
 {
-if ( nWinStyle  WB_CENTER )
-rStateRect.Left() = 
rPos.X()+((rSize.Width()-rImageSize.Width())/2);
-else if ( nWinStyle  WB_RIGHT )
-rStateRect.Left() = rPos.X()+rSize.Width()-rImageSize.Width();
-else
-rStateRect.Left() = 

[Libreoffice-commits] .: vcl/inc vcl/source

2012-07-06 Thread Noel Power
 vcl/inc/vcl/button.hxx|4 
 vcl/source/control/button.cxx |   17 +++--
 2 files changed, 15 insertions(+), 6 deletions(-)

New commits:
commit 2bc2d09bba2e3f34e8ce13571de9ff7007e1c2b6
Author: Noel Power noel.po...@novell.com
Date:   Fri Jul 6 14:38:51 2012 +0100

additional fix for fdo#51336 for radiobuttons

Change-Id: Ib35d27962b2c63221e1967886236547b3b1047d6

diff --git a/vcl/inc/vcl/button.hxx b/vcl/inc/vcl/button.hxx
index 64f7581..9eb6088 100644
--- a/vcl/inc/vcl/button.hxx
+++ b/vcl/inc/vcl/button.hxx
@@ -313,6 +313,10 @@ private:
 protected:
 using Control::ImplInitSettings;
 using Window::ImplInit;
+// allows the behaviour of horizontal placement of the checbox image to be
+// overridden.
+virtual void ImplHandleHoriAlign( const Point rPos, const Size rSize,
+const Size rImageSize, Rectangle 
rStateRect );
 SAL_DLLPRIVATE void ImplInit( Window* pParent, WinBits nStyle );
 SAL_DLLPRIVATE void ImplLoadRes( const ResId rResId );
 
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index e3ed723..9ba7e8f 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -2124,6 +2124,14 @@ if ( bNativeOK == sal_False )
 
 // ---
 
+void RadioButton:: ImplHandleHoriAlign( const Point rPos, const Size 
/*rSize*/,
+const Size /*rImageSize*/, Rectangle 
rStateRect )
+{
+// align Checkbox image left ( always )
+rStateRect.Left() = rPos.X();
+}
+// ---
+
 void RadioButton::ImplDraw( OutputDevice* pDev, sal_uLong nDrawFlags,
 const Point rPos, const Size rSize,
 const Size rImageSize, Rectangle rStateRect,
@@ -2188,12 +2196,9 @@ void RadioButton::ImplDraw( OutputDevice* pDev, 
sal_uLong nDrawFlags,
 }
 else
 {
-if ( nWinStyle  WB_CENTER )
-rStateRect.Left() = 
rPos.X()+((rSize.Width()-rImageSize.Width())/2);
-else if ( nWinStyle  WB_RIGHT )
-rStateRect.Left() = rPos.X()+rSize.Width()-rImageSize.Width(); 
//-1;
-else
-rStateRect.Left() = rPos.X(); //+1;
+// allow specific handling of WB_CENTER, WB_LEFT  WB_RIGHT by
+// by subclasses
+ImplHandleHoriAlign( rPos, rSize, rImageSize, rStateRect );
 if ( nWinStyle  WB_VCENTER )
 rStateRect.Top() = 
rPos.Y()+((rSize.Height()-rImageSize.Height())/2);
 else if ( nWinStyle  WB_BOTTOM )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: REVIEW[3.6] was vcl checkbox behaviourRe: vcl checkbox behaviour

2012-07-06 Thread Noel Power

On 28/06/12 19:02, Jan Holesovsky wrote:

Hi Noel,

Noel Power píše v Čt 28. 06. 2012 v 13:36 +0100:

Actually the for quite a while spans to 
8ab086b6cc054501bfbf7ef6fa509c393691e860, the inital import of 
button.cxx to CVS :-( - it has been imported in 2000 with this already 
in place. Looking deeper, I thought that the 'alignment of checkboxes 
without text' behavior might make sense for the dialogs like Tools - 
Options - Load/Save - Microsoft Office and alike, where you'd want 
to center the checkbox; but it seems to me that it is actually 
SvLBoxButton that is used there, not CheckBox. So - can you in any way 
check if we are actually using this CheckBox feature anywhere in the 
UI? [Ie. if we construct a CheckBox without text, but with WB_CENTER 
or WB_RIGHT?] If we do not use it, I'd get rid of that [even in UNO 
controls and everywhere], as you proposed. Regards, Kendy 


I dug deeper, in the end I could only find CheckBoxControl 
http://opengrok.libreoffice.org/xref/core/svtools/inc/svtools/editbrowsebox.hxx#291 
which has a member pBox which is a TriStateBox ( which inherits from 
CheckBox ) that has no label and is aligned with WB_CENTER, This class 
is used quite abit in dbaccess and also in one place in sw ( and indeed 
depends on the behaviour mentioned )


For the moment I changed both radiobutton and checkbox as described, I 
introduced a new virtual to allow a subclass to modify the behaviour ( I 
already did that in CheckBoxControl ) I did this for both radiobutton 
and checkbox even though I didn't see any instances of RadioButton that 
use this functionality.


I think the only was to see if I missed something is to commit the 
changes ( which I did to master ) However I think there is a better 
chance of 3.6 highlighting some missed usecase, with that in mind I ask 
for a review here. ( note I am away for the next two weeks so if someone 
would approve this I would ask they commit it too :-) )


the changes in question are :
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1345cd93a57ec7d9352f2c71ec2664332ce5e76
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2bc2d09bba2e3f34e8ce13571de9ff7007e1c2b6

going forward I want to change both of these controls to accept some new 
parameter that would allow the position/alignment of the image within 
its bounding area  separate from WB_LEFT, WB_RIGHT  WB_CENTER which now 
only apply to the label ( if it exists )


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 36703, which changed state.

Bug 36703 Summary: Regressions with the new graphite2
https://bugs.freedesktop.org/show_bug.cgi?id=36703

   What|Old Value   |New Value

 Resolution||FIXED
 Status|REOPENED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 2 commits - svtools/source sw/qa sw/source

2012-07-06 Thread Michael Stahl
 svtools/source/control/ctrlbox.cxx |9 +++-
 sw/qa/complex/writer/CheckCrossReferences.java |   50 ++---
 sw/source/core/doc/number.cxx  |   35 ++---
 3 files changed, 54 insertions(+), 40 deletions(-)

New commits:
commit 3c6bc3cb6a673c552e2839e421656341151bf12e
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 16:11:25 2012 +0200

BorderWidthImpl: let's try if this is a better way to convert to int

Change-Id: Ib374998199afff347786764716646e73dd12de2a

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index 7dff33d..47d4553 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -326,7 +326,8 @@ long BorderWidthImpl::GetLine1( long nWidth ) const
 long const nConstant2 = (m_nFlags  CHANGE_LINE2) ? 0 : m_nRate2;
 long const nConstantD = (m_nFlags  CHANGE_DIST ) ? 0 : m_nRateGap;
 result = std::maxlong(0,
-static_castlong(m_nRate1 * nWidth) - (nConstant2 + nConstantD));
+static_castlong((m_nRate1 * nWidth) + 0.5)
+- (nConstant2 + nConstantD));
 }
 return result;
 }
@@ -339,7 +340,8 @@ long BorderWidthImpl::GetLine2( long nWidth ) const
 long const nConstant1 = (m_nFlags  CHANGE_LINE1) ? 0 : m_nRate1;
 long const nConstantD = (m_nFlags  CHANGE_DIST ) ? 0 : m_nRateGap;
 result = std::maxlong(0,
-static_castlong(m_nRate2 * nWidth) - (nConstant1 + nConstantD));
+static_castlong((m_nRate2 * nWidth) + 0.5)
+- (nConstant1 + nConstantD));
 }
 return result;
 }
@@ -352,7 +354,8 @@ long BorderWidthImpl::GetGap( long nWidth ) const
 long const nConstant1 = (m_nFlags  CHANGE_LINE1) ? 0 : m_nRate1;
 long const nConstant2 = (m_nFlags  CHANGE_LINE2) ? 0 : m_nRate2;
 result = std::maxlong(0,
-static_castlong(m_nRateGap * nWidth) - (nConstant1 + 
nConstant2));
+static_castlong((m_nRateGap * nWidth) + 0.5)
+- (nConstant1 + nConstant2));
 }
 
 // Avoid having too small distances (less than 0.1pt)
commit 190ca072fc1c8679c586867582c816d98016f343
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 15:57:32 2012 +0200

fdo#33960: fix cross reference number test failure

Change-Id: If50a09a14ad30fa3dcb587d6e59a5a0d161394b1

diff --git a/sw/qa/complex/writer/CheckCrossReferences.java 
b/sw/qa/complex/writer/CheckCrossReferences.java
index 77f3179..ad5831d 100644
--- a/sw/qa/complex/writer/CheckCrossReferences.java
+++ b/sw/qa/complex/writer/CheckCrossReferences.java
@@ -136,9 +136,9 @@ public class CheckCrossReferences {
 final String FldResult1 = *i*;
 final String FldResult2 = +b+*i*;
 final String FldResult3 = -1-+b+*i*;
-final String FldResult4 = 1.;
-final String FldResult5 =  1.;
-final String FldResult6 = A. 1.;
+final String FldResult4 = 1;
+final String FldResult5 = 1;
+final String FldResult6 = A.1;
 
 // variables for current field
 com.sun.star.text.XTextField xField = null;
@@ -162,33 +162,23 @@ public class CheckCrossReferences {
 checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_NO_CONTEXT, FldResult1 );
 checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_FULL_CONTEXT, FldResult3 );
 
-// The following tests currently fail due to a regression 
introduced
-// with the fix for
-// https://bugs.freedesktop.org/show_bug.cgi?id=33960 cross
-// reference to a list number, dot bug, see thread starting at
-// http://lists.freedesktop.org/archives/libreoffice/
-// 2011-September/017797.html [Libreoffice] fix for fdo#33960
-// 'cross reference to a list number, dot bug' makes
-// sw/qa/complex/writer fail:
-if (false) {
-xField = getNextField();
-xProps = getFieldProps( xField );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER, FldResult5 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_NO_CONTEXT, FldResult4 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_FULL_CONTEXT, FldResult6 );
-
-xField = getNextField();
-xProps = getFieldProps( xField );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER, FldResult4 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_NO_CONTEXT, FldResult4 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_FULL_CONTEXT, FldResult6 );
-
-

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - svtools/source sw/qa sw/source

2012-07-06 Thread Michael Stahl
 svtools/source/control/ctrlbox.cxx |9 +++-
 sw/qa/complex/writer/CheckCrossReferences.java |   50 ++---
 sw/source/core/doc/number.cxx  |   35 ++---
 3 files changed, 54 insertions(+), 40 deletions(-)

New commits:
commit cae7775794f87a3b179451cedc584958c6215432
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 16:11:25 2012 +0200

BorderWidthImpl: let's try if this is a better way to convert to int

Change-Id: Ib374998199afff347786764716646e73dd12de2a
(cherry picked from commit 3c6bc3cb6a673c552e2839e421656341151bf12e)

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index a1d8906..5665858 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -325,7 +325,8 @@ long BorderWidthImpl::GetLine1( long nWidth ) const
 long const nConstant2 = (m_nFlags  CHANGE_LINE2) ? 0 : m_nRate2;
 long const nConstantD = (m_nFlags  CHANGE_DIST ) ? 0 : m_nRateGap;
 result = std::maxlong(0,
-static_castlong(m_nRate1 * nWidth) - (nConstant2 + nConstantD));
+static_castlong((m_nRate1 * nWidth) + 0.5)
+- (nConstant2 + nConstantD));
 }
 return result;
 }
@@ -338,7 +339,8 @@ long BorderWidthImpl::GetLine2( long nWidth ) const
 long const nConstant1 = (m_nFlags  CHANGE_LINE1) ? 0 : m_nRate1;
 long const nConstantD = (m_nFlags  CHANGE_DIST ) ? 0 : m_nRateGap;
 result = std::maxlong(0,
-static_castlong(m_nRate2 * nWidth) - (nConstant1 + nConstantD));
+static_castlong((m_nRate2 * nWidth) + 0.5)
+- (nConstant1 + nConstantD));
 }
 return result;
 }
@@ -351,7 +353,8 @@ long BorderWidthImpl::GetGap( long nWidth ) const
 long const nConstant1 = (m_nFlags  CHANGE_LINE1) ? 0 : m_nRate1;
 long const nConstant2 = (m_nFlags  CHANGE_LINE2) ? 0 : m_nRate2;
 result = std::maxlong(0,
-static_castlong(m_nRateGap * nWidth) - (nConstant1 + 
nConstant2));
+static_castlong((m_nRateGap * nWidth) + 0.5)
+- (nConstant1 + nConstant2));
 }
 
 // Avoid having too small distances (less than 0.1pt)
commit a8651a4bf3031bdf16a84ddf774eaf699a617426
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 15:57:32 2012 +0200

fdo#33960: fix cross reference number test failure

(cherry picked from commit 190ca072fc1c8679c586867582c816d98016f343)

Conflicts:
sw/source/core/doc/number.cxx

Change-Id: If50a09a14ad30fa3dcb587d6e59a5a0d161394b1

diff --git a/sw/qa/complex/writer/CheckCrossReferences.java 
b/sw/qa/complex/writer/CheckCrossReferences.java
index 0f74a11..4f436ce 100644
--- a/sw/qa/complex/writer/CheckCrossReferences.java
+++ b/sw/qa/complex/writer/CheckCrossReferences.java
@@ -145,9 +145,9 @@ public class CheckCrossReferences {
 final String FldResult1 = *i*;
 final String FldResult2 = +b+*i*;
 final String FldResult3 = -1-+b+*i*;
-final String FldResult4 = 1.;
-final String FldResult5 =  1.;
-final String FldResult6 = A. 1.;
+final String FldResult4 = 1;
+final String FldResult5 = 1;
+final String FldResult6 = A.1;
 
 // variables for current field
 com.sun.star.text.XTextField xField = null;
@@ -171,33 +171,23 @@ public class CheckCrossReferences {
 checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_NO_CONTEXT, FldResult1 );
 checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_FULL_CONTEXT, FldResult3 );
 
-// The following tests currently fail due to a regression 
introduced
-// with the fix for
-// https://bugs.freedesktop.org/show_bug.cgi?id=33960 cross
-// reference to a list number, dot bug, see thread starting at
-// http://lists.freedesktop.org/archives/libreoffice/
-// 2011-September/017797.html [Libreoffice] fix for fdo#33960
-// 'cross reference to a list number, dot bug' makes
-// sw/qa/complex/writer fail:
-if (false) {
-xField = getNextField();
-xProps = getFieldProps( xField );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER, FldResult5 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_NO_CONTEXT, FldResult4 );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER_FULL_CONTEXT, FldResult6 );
-
-xField = getNextField();
-xProps = getFieldProps( xField );
-checkField( xField, xProps, 
com.sun.star.text.ReferenceFieldPart.NUMBER, FldResult4 );
-checkField( xField, xProps, 

[ANN] LibreOffice 3.6.0 Beta3 available

2012-07-06 Thread Thorsten Behrens
Dear Community,

The Document Foundation is happy to announce the third beta release of
LibreOffice 3.6.0. The upcoming 3.6.0 will be our fourth major release
in two years, and comes with a nice set of new features. Please be
aware that LibreOffice 3.6.0 Beta3 is not ready for production use,
you should continue to use LibreOffice 3.5.4 for that.

The release is available for Windows, Linux and Mac OS X from our QA
builds download page at

  http://www.libreoffice.org/download/pre-releases/

A note for Windows users: this beta release installs in parallel to
your current stable build, and thus can be easily tested alongside.

The (still growing) list of features for the upcoming 3.6.0 is on our
wiki - please help filling gaps there, e.g. by providing more
screenshots:

 http://wiki.documentfoundation.org/ReleaseNotes/3.6

Should you find bugs, please report them to the FreeDesktop Bugzilla:

  https://bugs.freedesktop.org

A good way to assess the beta quality is to run some specific manual
tests on it, our TCM wiki page has more details:

 
http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test

 (and the announcement mail: 
http://lists.freedesktop.org/archives/libreoffice/2011-December/022464.html)
 
For other ways to get involved with this exciting project - you can
e.g. contribute code:

  http://www.libreoffice.org/get-involved/developers/

translate LibreOffice to your language:

  http://wiki.documentfoundation.org/Translation_for_3.5

or help with funding our operations:

  http://challenge.documentfoundation.org/

A list of known issues and fixed bugs with 3.6.0 Beta3 is available
from our wiki:

  http://wiki.documentfoundation.org/Releases/3.6.0/Beta3

Please find the list of changes against LibreOffice 3.6.0 Beta2 here:

  
http://download.documentfoundation.org/libreoffice/src/bugfixes-libreoffice-3-6-release-3.6.0.0.beta3.log

Let us close again with a BIG Thank You! to all of you having
contributed to the LibreOffice project - this release would not have
been possible without your help.

Yours,

The Document Foundation Board of Directors

The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint


pgp6aybbahTEh.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Locating Backing Window Recent Documents Object

2012-07-06 Thread Ivan Timofeev

On 06.07.2012 19:17, Joel Madero wrote:

Someone else suggested there also but I'm not seeing anything that would
differentiate Open vs. Recent Documents on the backingwindow.


AFAIUI you are trying to extend the area, which is responsible for mouse 
clicks showing the menu. In this case the code you should modify is


  // if the separated dropdown symbol is hit,
  // execute the popup immediately
  if( ! ImplGetSymbolRect().IsInside( rMEvt.GetPosPixel() ) )
  {

The comment explains the current logic.

Or maybe I did not understand you...?

Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Locating Backing Window Recent Documents Object

2012-07-06 Thread Joel Madero
I'm trying to extend the area of the recent document drop down menu, none
of the other ones. I want to increase the size of that one and decrease the
size of the open dialog.


Joel

On Fri, Jul 6, 2012 at 8:33 AM, Ivan Timofeev timofeev@gmail.comwrote:

 On 06.07.2012 19:17, Joel Madero wrote:

 Someone else suggested there also but I'm not seeing anything that would
 differentiate Open vs. Recent Documents on the backingwindow.


 AFAIUI you are trying to extend the area, which is responsible for mouse
 clicks showing the menu. In this case the code you should modify is

   // if the separated dropdown symbol is hit,
   // execute the popup immediately
   if( ! ImplGetSymbolRect().IsInside( rMEvt.GetPosPixel() ) )
   {

 The comment explains the current logic.

 Or maybe I did not understand you...?

 Ivan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sfx2/source

2012-07-06 Thread Andras Timar
 sfx2/source/dialog/versdlg.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 1352d6ff9e8f321a970d91654c2242b34ef1505f
Author: Andras Timar ati...@suse.com
Date:   Fri Jul 6 17:38:29 2012 +0200

hide aDateTimeText when editing new version comment

Change-Id: I644adb0292272130587f8a19777c47bf8fd2887c

diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index b43c6fa..9a4fa8e 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -477,7 +477,10 @@ SfxViewVersionDialog_Impl::SfxViewVersionDialog_Impl ( 
Window *pParent, SfxVersi
 aEdit.SetReadOnly( sal_True );
 }
 else
+{
+aDateTimeText.Hide();
 aCloseButton.Hide();
+}
 }
 
 IMPL_LINK( SfxViewVersionDialog_Impl, ButtonHdl, Button*, pButton )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Locating Backing Window Recent Documents Object

2012-07-06 Thread Michael Meeks
Hi Joel,

On Fri, 2012-07-06 at 08:17 -0700, Joel Madero wrote:
 Someone else suggested there also but I'm not seeing anything that
 would differentiate Open vs. Recent Documents on the backingwindow. 

Having a link to the relevant bug / issue might be interesting :-)
Ivan's link is good:

framework/source/services/backingwindow.hxx:
MenuButton  maOpenButton;

framework/source/services/backingwindow.cxx:
maOpenButton.SetMenuMode( MENUBUTTON_MENUMODE_TIMED );
maOpenButton.SetSelectHdl( LINK( this, BackingWindow, SelectHdl ) );
maOpenButton.SetActivateHdl( LINK( this, BackingWindow, ActivateHdl ) );

The code is in:

vcl/source/control/menubtn.cxx, method MenuButton::MouseButtonDown

I assume 'Select' vs. 'Activate' are the different modes: pop-down, or
whatever here:

IMPL_LINK( BackingWindow, ActivateHdl, Button*, pButton )
{
if( pButton == maOpenButton )
prepareRecentFileMenu();
return 0;
}

Looks like the recent files list is not built until that is clicked.

Does that help ? :-)

And/or what's the root issue ?

Thanks for digging !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 3 commits - sfx2/source

2012-07-06 Thread Andras Timar
 sfx2/source/dialog/dialog.hrc  |1 +
 sfx2/source/dialog/versdlg.cxx |4 
 sfx2/source/dialog/versdlg.src |6 +-
 3 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit c24e9feaba790cef148b678137dec911eda08280
Author: Andras Timar ati...@suse.com
Date:   Fri Jul 6 17:52:34 2012 +0200

change dialog caption in view mode

Change-Id: I9dac5dd42b485265110c91e3472206517d7b8e1c

diff --git a/sfx2/source/dialog/dialog.hrc b/sfx2/source/dialog/dialog.hrc
index bc8332c..22f876b 100644
--- a/sfx2/source/dialog/dialog.hrc
+++ b/sfx2/source/dialog/dialog.hrc
@@ -55,6 +55,7 @@
 
 #define DLG_VERSIONS( RC_DIALOG_BEGIN + 69 )
 #define DLG_COMMENTS( RC_DIALOG_BEGIN + 70 )
+#define STR_VIEWVERSIONCOMMENT  ( RC_DIALOG_BEGIN + 71 )
 
 #define MSG_ERROR_WRONG_CONFIRM ( RC_DIALOG_BEGIN + 76 )
 
diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index 9a4fa8e..fd84899 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -475,6 +475,7 @@ SfxViewVersionDialog_Impl::SfxViewVersionDialog_Impl ( 
Window *pParent, SfxVersi
 aOKButton.Hide();
 aCancelButton.Hide();
 aEdit.SetReadOnly( sal_True );
+SetText( SfxResId( STR_VIEWVERSIONCOMMENT ) );
 }
 else
 {
diff --git a/sfx2/source/dialog/versdlg.src b/sfx2/source/dialog/versdlg.src
index ffe67d6..1c50b4f 100644
--- a/sfx2/source/dialog/versdlg.src
+++ b/sfx2/source/dialog/versdlg.src
@@ -185,3 +185,7 @@ String DLG_COMMENTS
 {
 Text [ en-US ] = Version comment ;
 };
+String STR_VIEWVERSIONCOMMENT
+{
+Text [ en-US ] = View Version Comment ;
+};
commit d50cbfe13f416eaab16159cb91038005800e2aa5
Author: Andras Timar ati...@suse.com
Date:   Fri Jul 6 17:38:29 2012 +0200

hide aDateTimeText when editing new version comment

Change-Id: I644adb0292272130587f8a19777c47bf8fd2887c

diff --git a/sfx2/source/dialog/versdlg.cxx b/sfx2/source/dialog/versdlg.cxx
index b43c6fa..9a4fa8e 100644
--- a/sfx2/source/dialog/versdlg.cxx
+++ b/sfx2/source/dialog/versdlg.cxx
@@ -477,7 +477,10 @@ SfxViewVersionDialog_Impl::SfxViewVersionDialog_Impl ( 
Window *pParent, SfxVersi
 aEdit.SetReadOnly( sal_True );
 }
 else
+{
+aDateTimeText.Hide();
 aCloseButton.Hide();
+}
 }
 
 IMPL_LINK( SfxViewVersionDialog_Impl, ButtonHdl, Button*, pButton )
commit 802a671216bcc1d6ba10bd9585fd9e260a2a4d79
Author: Andras Timar ati...@suse.com
Date:   Fri Jul 6 12:30:00 2012 +0200

remove space before colon in UI text

Change-Id: I1e207cc624388130bba3b1a383377a55f04872f2

diff --git a/sfx2/source/dialog/versdlg.src b/sfx2/source/dialog/versdlg.src
index 14f5a3e..ffe67d6 100644
--- a/sfx2/source/dialog/versdlg.src
+++ b/sfx2/source/dialog/versdlg.src
@@ -136,7 +136,7 @@ ModalDialog DLG_COMMENTS
 {
 Pos = MAP_APPFONT ( 6 , 6 ) ;
 Size = MAP_APPFONT ( 168 , 10 ) ;
-Text [ en-US ] = Date and time :  ;
+Text [ en-US ] = Date and time:  ;
 };
 FixedText FT_SAVEDBY
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: Locating Backing Window Recent Documents Object

2012-07-06 Thread Joel Madero
haha digging a ditch for myself ;) I think I now am following the logic of
MouseButtonDown but I'm still not seeing where it's being called (and where
rMEvt) is coming from. Basically where are the pixel ranges defined as
different actions (open vs. recent documents).

Here is a link to the bug (or enhancement depending on your opinion of it).

https://bugs.freedesktop.org/show_bug.cgi?id=47164


Thanks again for everyone's patience.


Joel

On Fri, Jul 6, 2012 at 8:42 AM, Michael Meeks michael.me...@suse.comwrote:

 Hi Joel,

 On Fri, 2012-07-06 at 08:17 -0700, Joel Madero wrote:
  Someone else suggested there also but I'm not seeing anything that
  would differentiate Open vs. Recent Documents on the backingwindow.

 Having a link to the relevant bug / issue might be interesting :-)
 Ivan's link is good:

 framework/source/services/backingwindow.hxx:
 MenuButton  maOpenButton;

 framework/source/services/backingwindow.cxx:
 maOpenButton.SetMenuMode( MENUBUTTON_MENUMODE_TIMED );
 maOpenButton.SetSelectHdl( LINK( this, BackingWindow, SelectHdl ) );
 maOpenButton.SetActivateHdl( LINK( this, BackingWindow, ActivateHdl )
 );

 The code is in:

 vcl/source/control/menubtn.cxx, method MenuButton::MouseButtonDown

 I assume 'Select' vs. 'Activate' are the different modes:
 pop-down, or
 whatever here:

 IMPL_LINK( BackingWindow, ActivateHdl, Button*, pButton )
 {
 if( pButton == maOpenButton )
 prepareRecentFileMenu();
 return 0;
 }

 Looks like the recent files list is not built until that is
 clicked.

 Does that help ? :-)

 And/or what's the root issue ?

 Thanks for digging !

 Michael.

 --
 michael.me...@suse.com  , Pseudo Engineer, itinerant idiot


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Change in core[master]: Replaced deprecated tools/String with OUString in ScMatrix

2012-07-06 Thread Soeren Moeller
I'm using
gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
on x86_64 GNU/Linux (Ubuntu 12.04 LTS), which runs in a virtual
machine (that hopefully shouldn't make a difference). Hopefully it
doesn't happen which the next patch.

Sören


2012/7/5 Eike Rathke er...@redhat.com:
 Hi Sören,

 On Thursday, 2012-07-05 16:30:39 +, Gerrit wrote:

 From Sören Möller soerenmoeller2...@gmail.com:

 Thanks for fixing the errors, it appears I compiled without --enable-werror 
 and didn't notice the warning on the first one. But I have no idea why I 
 didn't get an error on the second one.

 Indeed, that's odd. What platform/compiler/version do you use? Here
 x86_64 GNU/Linux with gcc 4.6.3

   Eike

 --
 LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
 GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[GERRIT DOWN FOR MAINTAINANCE] now

2012-07-06 Thread Robert Einsle

Hi List,

i will shutdown gerrit the next few Minutes to make an Update to gerrit 
2.4.2


I will report if gerrit is reachable again.

Thanks

Robert

--
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint

Robert Einsle r.ein...@documentfoundation.org
Admin Team / Infrastructure

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Document conversion engine

2012-07-06 Thread Robinson Tryon
On Fri, Jul 6, 2012 at 5:51 AM, Flavio Moringa 
flavio.mori...@caixamagica.pt wrote:


 I know that you can convert documents through the command line, using
 LibreOffice headless mode, and that can be something that's useful for
 scripting automatic tests... although I know that sometimes the main
 problems are visual and it's difficult to automatically detect the
 problems...


I think that we still need human eyes for the final comparison, however the
rest of the system could be automated a bit more -- e.g. we could put
sample docs in subdirectories named by bug# and add screenshots of the docs
as rendered in MS-Office; add in a script to have LO iterate over the
subdirectories and spit out screenshots of how it renders the original
files, and a little HTML GUI so that you can tab-through 2-ups of the
original rendering vs. LO's rendering, and you've got a decent tool for
testing improvements/regressions.

Is there any kind of repository for documents that are candidates for
 conversion testing? I mean documents which are known to have conversion
 problems, and that are used to test improvements to the filters?


I usually just search bugzilla for conversion or formatting :-) Even
documents attached to old bugs can be helpful, as they can serve as
regression tests.

I would like very much to become more involved in improving the conversion
 filters, since it seems to be a major problem in LibreOffice adoption, and
 everything that can be done to help in that area would certainly boost
 LibreOffice adoption specially in the enterprise world.


Yes, fidelity of document rendering is definitely one of the biggest
hurdles I've faced when encouraging people to try LO. Any improvements on
that front will be greatly appreciated!

--R
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 2 commits - sc/inc sc/source

2012-07-06 Thread Kohei Yoshida
 sc/inc/dpgroup.hxx   |2 +-
 sc/inc/dpsdbtab.hxx  |2 +-
 sc/inc/dpshttab.hxx  |2 +-
 sc/inc/dptabdat.hxx  |2 +-
 sc/source/core/data/dpgroup.cxx  |4 ++--
 sc/source/core/data/dpobject.cxx |   10 --
 sc/source/core/data/dpsdbtab.cxx |3 ++-
 sc/source/core/data/dpshttab.cxx |3 ++-
 sc/source/core/data/dptabres.cxx |1 -
 9 files changed, 18 insertions(+), 11 deletions(-)

New commits:
commit fad3a6bbddaf003d185d248d232e65b94939963b
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date:   Fri Jul 6 12:49:35 2012 -0400

Properly rehash row visibility when the layout dialog is dismissed.

Without this, changing the settings 'ignore empty rows' and 'identify
categories' in the dialog and pressing OK wouldn't work as expected.

Change-Id: Ib1f3bad5b6c3ddef08cd56d40abfe60da979d14f

diff --git a/sc/inc/dpgroup.hxx b/sc/inc/dpgroup.hxx
index 5d48af0..afa3933 100644
--- a/sc/inc/dpgroup.hxx
+++ b/sc/inc/dpgroup.hxx
@@ -182,7 +182,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 
 virtual sal_BoolIsBaseForGroup(long nDim) const;
 virtual longGetGroupBase(long nGroupDim) const;
diff --git a/sc/inc/dpsdbtab.hxx b/sc/inc/dpsdbtab.hxx
index a96b011..3a852ef 100644
--- a/sc/inc/dpsdbtab.hxx
+++ b/sc/inc/dpsdbtab.hxx
@@ -88,7 +88,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 };
 
 
diff --git a/sc/inc/dpshttab.hxx b/sc/inc/dpshttab.hxx
index 510105d..dc1ce1a 100644
--- a/sc/inc/dpshttab.hxx
+++ b/sc/inc/dpshttab.hxx
@@ -128,7 +128,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 };
 
 
diff --git a/sc/inc/dptabdat.hxx b/sc/inc/dptabdat.hxx
index f19a6ba..16b8ef3 100644
--- a/sc/inc/dptabdat.hxx
+++ b/sc/inc/dptabdat.hxx
@@ -154,7 +154,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData) = 0;
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow) = 0;
 virtual const ScDPCacheTable   GetCacheTable() const = 0;
-virtual void ClearCacheTable() = 0;
+virtual void ReloadCacheTable() = 0;
 
 // overloaded in ScDPGroupTableData:
 virtual sal_BoolIsBaseForGroup(long nDim) const;
diff --git a/sc/source/core/data/dpgroup.cxx b/sc/source/core/data/dpgroup.cxx
index 4a263df..232f7fc 100644
--- a/sc/source/core/data/dpgroup.cxx
+++ b/sc/source/core/data/dpgroup.cxx
@@ -784,9 +784,9 @@ const ScDPCacheTable ScDPGroupTableData::GetCacheTable() 
const
 return pSourceData-GetCacheTable();
 }
 
-void ScDPGroupTableData::ClearCacheTable()
+void ScDPGroupTableData::ReloadCacheTable()
 {
-pSourceData-ClearCacheTable();
+pSourceData-ReloadCacheTable();
 }
 
 void ScDPGroupTableData::FillGroupValues(vectorSCROW rItems, const 
vectorlong rDims)
diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index 569b8c6..1c7786a 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -499,6 +499,12 @@ void ScDPObject::CreateObjects()
 ScDPTableData* pData = GetTableData();
 if (pData)
 {
+if (pSaveData)
+// Make sure to transfer these flags to the table data
+// since they may have changed.
+pData-SetEmptyFlags(pSaveData-GetIgnoreEmptyRows(), 
pSaveData-GetRepeatIfEmpty());
+
+pData-ReloadCacheTable();
 ScDPSource* pSource = new ScDPSource( pData );
 xSource = pSource;
 }
@@ -709,8 +715,7 @@ void ScDPObject::SyncAllDimensionMembers()
 ScDPTableData* pData = GetTableData();
 // Refresh the cache wrapper since the cache may have changed.
 pData-SetEmptyFlags(pSaveData-GetIgnoreEmptyRows(), 
pSaveData-GetRepeatIfEmpty());
-

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - sc/inc sc/source

2012-07-06 Thread Kohei Yoshida
 sc/inc/dpgroup.hxx   |2 +-
 sc/inc/dpsdbtab.hxx  |2 +-
 sc/inc/dpshttab.hxx  |2 +-
 sc/inc/dptabdat.hxx  |2 +-
 sc/source/core/data/dpgroup.cxx  |4 ++--
 sc/source/core/data/dpobject.cxx |   10 --
 sc/source/core/data/dpsdbtab.cxx |3 ++-
 sc/source/core/data/dpshttab.cxx |3 ++-
 sc/source/core/data/dptabres.cxx |1 -
 9 files changed, 18 insertions(+), 11 deletions(-)

New commits:
commit 3a2863afd428958ea1ec78b4dc9971c73f704741
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date:   Fri Jul 6 12:49:35 2012 -0400

Properly rehash row visibility when the layout dialog is dismissed.

Without this, changing the settings 'ignore empty rows' and 'identify
categories' in the dialog and pressing OK wouldn't work as expected.

Change-Id: Ib1f3bad5b6c3ddef08cd56d40abfe60da979d14f

diff --git a/sc/inc/dpgroup.hxx b/sc/inc/dpgroup.hxx
index 219e2e3..1c36237 100644
--- a/sc/inc/dpgroup.hxx
+++ b/sc/inc/dpgroup.hxx
@@ -183,7 +183,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 
 virtual sal_BoolIsBaseForGroup(long nDim) const;
 virtual longGetGroupBase(long nGroupDim) const;
diff --git a/sc/inc/dpsdbtab.hxx b/sc/inc/dpsdbtab.hxx
index a96b011..3a852ef 100644
--- a/sc/inc/dpsdbtab.hxx
+++ b/sc/inc/dpsdbtab.hxx
@@ -88,7 +88,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 };
 
 
diff --git a/sc/inc/dpshttab.hxx b/sc/inc/dpshttab.hxx
index f3cf2fd..2892c52 100644
--- a/sc/inc/dpshttab.hxx
+++ b/sc/inc/dpshttab.hxx
@@ -130,7 +130,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData);
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow);
 virtual const ScDPCacheTable   GetCacheTable() const;
-virtual void ClearCacheTable();
+virtual void ReloadCacheTable();
 };
 
 
diff --git a/sc/inc/dptabdat.hxx b/sc/inc/dptabdat.hxx
index 03107de..fbe0787 100644
--- a/sc/inc/dptabdat.hxx
+++ b/sc/inc/dptabdat.hxx
@@ -156,7 +156,7 @@ public:
  
::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence 
::com::sun::star::uno::Any   rData) = 0;
 virtual voidCalcResults(CalcInfo rInfo, bool 
bAutoShow) = 0;
 virtual const ScDPCacheTable   GetCacheTable() const = 0;
-virtual void ClearCacheTable() = 0;
+virtual void ReloadCacheTable() = 0;
 
 // overloaded in ScDPGroupTableData:
 virtual sal_BoolIsBaseForGroup(long nDim) const;
diff --git a/sc/source/core/data/dpgroup.cxx b/sc/source/core/data/dpgroup.cxx
index 2959a65..91e9cce 100644
--- a/sc/source/core/data/dpgroup.cxx
+++ b/sc/source/core/data/dpgroup.cxx
@@ -789,9 +789,9 @@ const ScDPCacheTable ScDPGroupTableData::GetCacheTable() 
const
 return pSourceData-GetCacheTable();
 }
 
-void ScDPGroupTableData::ClearCacheTable()
+void ScDPGroupTableData::ReloadCacheTable()
 {
-pSourceData-ClearCacheTable();
+pSourceData-ReloadCacheTable();
 }
 
 void ScDPGroupTableData::FillGroupValues(vectorSCROW rItems, const 
vectorlong rDims)
diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index edd3bf2..c21dfb6 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -502,6 +502,12 @@ void ScDPObject::CreateObjects()
 ScDPTableData* pData = GetTableData();
 if (pData)
 {
+if (pSaveData)
+// Make sure to transfer these flags to the table data
+// since they may have changed.
+pData-SetEmptyFlags(pSaveData-GetIgnoreEmptyRows(), 
pSaveData-GetRepeatIfEmpty());
+
+pData-ReloadCacheTable();
 ScDPSource* pSource = new ScDPSource( pData );
 xSource = pSource;
 }
@@ -712,8 +718,7 @@ void ScDPObject::SyncAllDimensionMembers()
 ScDPTableData* pData = GetTableData();
 // Refresh the cache wrapper since the cache may have changed.
 pData-SetEmptyFlags(pSaveData-GetIgnoreEmptyRows(), 
pSaveData-GetRepeatIfEmpty());
-

Re: [GERRIT DOWN FOR MAINTAINANCE] finished

2012-07-06 Thread Robert Einsle

Hi,

gerrit update is finished, and running again.

Robert

Am 06.07.12 18:28, schrieb Robert Einsle:

Hi List,

i will shutdown gerrit the next few Minutes to make an Update to 
gerrit 2.4.2


I will report if gerrit is reachable again.

Thanks

Robert




--
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint

Robert Einsle r.ein...@documentfoundation.org
Admin Team / Infrastructure
Mobile: +49 175 5602901  Skype: reinsle

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: sfx2/source

2012-07-06 Thread Michael Meeks
 sfx2/source/doc/templatedlg.src |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 94d16ebac784e6d04e1274c728b880c7d79d1575
Author: Michael Meeks michael.me...@suse.com
Date:   Fri Jul 6 18:03:25 2012 +0100

revert change to missing image; please change back when it's added.

Change-Id: Icde577676e5ae55786dd2341291aad788bc40abc

diff --git a/sfx2/source/doc/templatedlg.src b/sfx2/source/doc/templatedlg.src
index f0ac332..08275ba 100644
--- a/sfx2/source/doc/templatedlg.src
+++ b/sfx2/source/doc/templatedlg.src
@@ -134,7 +134,7 @@ ModalDialog DLG_TEMPLATE_MANAGER
 {
 ImageBitmap = Bitmap
 {
-File = ln053.png;
+File = signet.png;
 };
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


EasyHack? Update service auto-download feature.

2012-07-06 Thread Thorsten Behrens
Hi there,

got poked today, why the auto-download feature of our update service
is disabled - well, it is since 2007, by way of this commit:

 commit 34c2d0fcfa948e7883ff4c9ccb25b1ac293da90d
 Author: Rüdiger Timm r...@openoffice.org
 Date:   Fri Jul 6 13:35:32 2007 +

INTEGRATION: CWS updchk06 (1.4.26); FILE MERGED
2007/06/25 05:48:20 obr 1.4.26.2: #i72386# DownloadThread added
2007/06/12 09:58:37 obr 1.4.26.1: #i72386# added support for version string

, so possibly the implementation is simply not 100% done - or just
untested? Anyone wants to play with it, code resides under
extensions/source/update/check, enable the stuff via
AutoDownloadEnabled in
extensions/source/update/check/org/openoffice/Office/Jobs.xcu

Cheers,

-- Thorsten


pgpTqucps4GIY.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: sfx2/source

2012-07-06 Thread Rafael Dominguez
 sfx2/source/doc/templatedlg.src |8 
 1 file changed, 8 deletions(-)

New commits:
commit 0a158923ac74714cecb47a977d553746a730bf7b
Author: Rafael Dominguez venccsra...@gmail.com
Date:   Fri Jul 6 13:41:36 2012 -0430

Remove unused image resource.

Change-Id: I789006f413b750d67e80fcedec9130f33275d74f

diff --git a/sfx2/source/doc/templatedlg.src b/sfx2/source/doc/templatedlg.src
index 08275ba..0a8f851 100644
--- a/sfx2/source/doc/templatedlg.src
+++ b/sfx2/source/doc/templatedlg.src
@@ -130,14 +130,6 @@ ModalDialog DLG_TEMPLATE_MANAGER
 TabStop = TRUE;
 };
 
-Image IMG_ONLINE_REPOSITORY
-{
-ImageBitmap = Bitmap
-{
-File = signet.png;
-};
-};
-
 Image IMG_CREATE_TEXT
 {
 ImageBitmap = Bitmap
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sfx2/inc

2012-07-06 Thread Michael Meeks
 sfx2/inc/sfx2/thumbnailview.hxx |   36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

New commits:
commit 4ec7d79efc462dbe3220576de8c3ad7c66e27807
Author: Michael Meeks michael.me...@suse.com
Date:   Fri Jul 6 19:58:08 2012 +0100

get visibility markup right for sfx2 not svt.

Change-Id: I52c8a26fc0ceff17cf843228ad57ca981a278cd9

diff --git a/sfx2/inc/sfx2/thumbnailview.hxx b/sfx2/inc/sfx2/thumbnailview.hxx
index 84ff537..291d7b0 100644
--- a/sfx2/inc/sfx2/thumbnailview.hxx
+++ b/sfx2/inc/sfx2/thumbnailview.hxx
@@ -10,7 +10,7 @@
 #ifndef THUMBNAILVIEW_HXX
 #define THUMBNAILVIEW_HXX
 
-#include svtools/svtdllapi.h
+#include sfx2/dllapi.h
 
 #include vector
 #include boost/function.hpp
@@ -169,7 +169,7 @@ public:
  *
  **/
 
-class SVT_DLLPUBLIC ThumbnailView : public Control
+class SFX2_DLLPUBLIC ThumbnailView : public Control
 {
 public:
 
@@ -295,23 +295,23 @@ protected:
 
 void CalculateItemPositions ();
 
-SVT_DLLPRIVATE void ImplInit();
-SVT_DLLPRIVATE void ImplInitSettings( bool bFont, bool 
bForeground, bool bBackground );
-SVT_DLLPRIVATE void ImplInitScrollBar();
-SVT_DLLPRIVATE void ImplDeleteItems();
-SVT_DLLPRIVATE void ImplDraw();
+SFX2_DLLPRIVATE void ImplInit();
+SFX2_DLLPRIVATE void ImplInitSettings( bool bFont, bool 
bForeground, bool bBackground );
+SFX2_DLLPRIVATE void ImplInitScrollBar();
+SFX2_DLLPRIVATE void ImplDeleteItems();
+SFX2_DLLPRIVATE void ImplDraw();
 using Window::ImplScroll;
-SVT_DLLPRIVATE bool ImplScroll( const Point rPos );
-SVT_DLLPRIVATE size_t   ImplGetItem( const Point rPoint, bool bMove = 
false ) const;
-SVT_DLLPRIVATE ThumbnailViewItem*ImplGetItem( size_t nPos );
-SVT_DLLPRIVATE ThumbnailViewItem*ImplGetFirstItem();
-SVT_DLLPRIVATE sal_uInt16  ImplGetVisibleItemCount() const;
-SVT_DLLPRIVATE ThumbnailViewItem*ImplGetVisibleItem( sal_uInt16 
nVisiblePos );
-SVT_DLLPRIVATE void ImplInsertItem( ThumbnailViewItem *const 
pItem, const size_t nPos );
-SVT_DLLPRIVATE voidImplFireAccessibleEvent( short nEventId, 
const ::com::sun::star::uno::Any rOldValue, const ::com::sun::star::uno::Any 
rNewValue );
-SVT_DLLPRIVATE bool ImplHasAccessibleListeners();
-SVT_DLLPRIVATE void ImplTracking( const Point rPos, bool bRepeat 
);
-SVT_DLLPRIVATE void ImplEndTracking( const Point rPos, bool 
bCancel );
+SFX2_DLLPRIVATE bool ImplScroll( const Point rPos );
+SFX2_DLLPRIVATE size_t   ImplGetItem( const Point rPoint, bool bMove 
= false ) const;
+SFX2_DLLPRIVATE ThumbnailViewItem*ImplGetItem( size_t nPos );
+SFX2_DLLPRIVATE ThumbnailViewItem*ImplGetFirstItem();
+SFX2_DLLPRIVATE sal_uInt16  ImplGetVisibleItemCount() const;
+SFX2_DLLPRIVATE ThumbnailViewItem*ImplGetVisibleItem( sal_uInt16 
nVisiblePos );
+SFX2_DLLPRIVATE void ImplInsertItem( ThumbnailViewItem *const 
pItem, const size_t nPos );
+SFX2_DLLPRIVATE voidImplFireAccessibleEvent( short nEventId, 
const ::com::sun::star::uno::Any rOldValue, const ::com::sun::star::uno::Any 
rNewValue );
+SFX2_DLLPRIVATE bool ImplHasAccessibleListeners();
+SFX2_DLLPRIVATE void ImplTracking( const Point rPos, bool bRepeat 
);
+SFX2_DLLPRIVATE void ImplEndTracking( const Point rPos, bool 
bCancel );
 DECL_DLLPRIVATE_LINK( ImplScrollHdl, ScrollBar* );
 DECL_DLLPRIVATE_LINK( ImplTimerHdl, void* );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: What is bibisect? And what is it doing in my office?

2012-07-06 Thread Robinson Tryon
On Mon, Jun 18, 2012 at 3:11 AM, Jan Holesovsky ke...@suse.cz wrote:

 Not at all - it is even possible to generate a zipped installation, that
 would be just unpacked, and checked into git; ie. nothing really hard to
 do.  But nobody has done that yet - are you interested?

Has anyone else started to implement this feature?

 If yes: The best would be to modify the tinbuild2 to be able also to
 commit the installation to a git repository, and push it to some
 repository.  We wouldn't get the same granularity as a dedicated
 bibisect build (with strict 64 commits interval), but still good enough,
 considering that we usually have 40-100 commits a day.

It's certainly good enough for Windows, where we don't have any
bibisect repos, but it would still be great on GNU/Linux so that we'd
have up-to-date bibisect that can be applied to any regressions that
pop up during beta testing.

 The tinbuild2 is here:

 http://cgit.freedesktop.org/libreoffice/contrib/buildbot/

 You probably want to hack somewhere here:

 http://cgit.freedesktop.org/libreoffice/contrib/buildbot/tree/bin/tinbuild_phases.sh#n85

 (making it part of the do_push() function).

Hmm. The buildbots are spread out in different locations, right? It
seems like the simplest thing would be to push the zipped install up
to the remote (source) server with something fault-tolerant like
rsync, compare a sha1 to make sure it got transfered properly, then
unzip and commit the files to the bibisect repo for that buildbot.
That would eliminate the need for each buildbot to have a local copy
of the bibisect repo.

--R
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Document conversion engine

2012-07-06 Thread Michael Meeks
Hi Flavio,

On Tue, 2012-07-03 at 11:45 +0100, Flavio Moringa wrote:
 my name is Flávio Moringa, I'm from Portugal and I'm starting my
 Masters Dissertation next September (Master in Open Source software -
 http://moss.dcti.iscte.pt ).

Welcome :-)

 I'm not a programmer, so what I'm interested in doing is something in
 the lines of investigating the main conversion problems, identifying
 the possible conversion flows, analysing the way the conversion flow
 is implemented in LibreOffice, and eventually trying to improve this
 flow somehow.

So - it will be hard to improve the flow without being a programmer I'm
afraid :-)

 From your reply I assume that testing the filters, and doing
 regression tests is something I could do, maybe identifying the main
 conversion issues in groups of documents and kind of creating a major
 conversion issues table, and prioritizing those issues. Is there
 already something like that?

There is a useful QA role in prioritising bug reports and
interoperability issues; we have a real problem with masses of bug
reports many of which could be duplicates. Having said that -
interoperability has many, many known feature / impedance mis-matches
that are non-trivial development problems to fix.

One thing that -would- be really useful, and that Microsoft have
internally, is an analysis tool for Microsoft's XML document formats -
such that we can get a good idea of which attributes are actually used
much. ie. by analysing and comparing a large corpus of documents out
there, we can answer questions such as:

should we implement surface charts, or 3D doughnut charts ?

given whatever amount of feature-development time we have - simply by
referring to the database of crunched XML files to work out which one is
used most.

It'd be nice to have that for ODF as well too of course for when we
have to make zero-sum back-compatibility decisions; but for
interoperability crunching those MS documents would be really good.

Is that something you could do ? a bit of perl, zip extraction, XML
parsing, etc. ?

Developers are -much- more likely to let themselves be lead by
objective statistics on real documents out there, rather than subjective
feelings of priority - which can prove rather controversial :-)

Thanks !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Locating Backing Window Recent Documents Object

2012-07-06 Thread Michael Meeks

On Fri, 2012-07-06 at 08:54 -0700, Joel Madero wrote:
 haha digging a ditch for myself ;) I think I now am following the
 logic of MouseButtonDown but I'm still not seeing where it's being
 called (and where rMEvt) is coming from. Basically where are the pixel
 ranges defined as different actions (open vs. recent documents).

rMEvt comes from the VCL - it will have the mouse event co-ordinates
correct; you don't want to change that bit :-)

 https://bugs.freedesktop.org/show_bug.cgi?id=47164 

For me this works fine:

if ( mnMenuMode  MENUBUTTON_MENUMODE_TIMED )
{
// if the separated dropdown symbol is hit,
// execute the popup immediately
if( ! ImplGetSymbolRect().IsInside( rMEvt.GetPosPixel() ) )

And my 'ImplGetSymbolRect()' method seems to return something sensible;
if you grok for 'SetSymbolRect' you can see what sets this.

long nDistance = (aInRect.GetHeight()  10) ? 2 : 1;
DecorationView aDecoView( pDev );
if( bMenuBtnSep )
{
long nX = aInRect.Left() - 2*nDistance;
Point aStartPt( nX, aInRect.Top()+nDistance );
Point aEndPt( nX, aInRect.Bottom()-nDistance );
aDecoView.DrawSeparator( aStartPt, aEndPt );
}
aDecoView.DrawSymbol( aInRect, SYMBOL_SPIN_DOWN, aColor, nStyle );
aInRect.Left() -= 2*nDistance;
ImplSetSymbolRect( aInRect );

Which already seems to nudge the left boundary further left so ... and
the way right-to-left works that should work in that mode too.

So - I don't really follow the bug; we could of course move the
separator further across and make that drop-down area larger with some
tweaks to the logic there, though that needs some UX input I think.

It seems (oddly, but ~normal for VCL) that most of the menubutton logic
lives in 'button.cxx' itself as special cases ;-) so best to poke there
really.

HTH !

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: sw/source

2012-07-06 Thread Michael Stahl
 sw/source/core/crsr/bookmrk.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit f2b6d71ccd04f41a849a0e5386f6619bfcc211da
Author: Michael Stahl mst...@redhat.com
Date:   Fri Jul 6 22:25:44 2012 +0200

fdo#38071: roll back change to MarkBase::IsCoveringPosition:

This change seems wrong as the end position is actually behind the
CH_TXT_ATR_FIELDEND; fortunately it is also unnecessary because
the change in MSWordExportBase::OutputTextNode is sufficient to
fix the crash.

Change-Id: I79d508b13ecc8d85c4e09149b44695436416ba6d

diff --git a/sw/source/core/crsr/bookmrk.cxx b/sw/source/core/crsr/bookmrk.cxx
index 211b559..6801d34 100644
--- a/sw/source/core/crsr/bookmrk.cxx
+++ b/sw/source/core/crsr/bookmrk.cxx
@@ -116,11 +116,12 @@ namespace sw { namespace mark
 }
 }
 
-//We consider the CH_TXT_ATR_FIELDSTART and CH_TXT_ATR_FIELDEND
-//themselves to be part of the covered range
+// For fieldmarks, the CH_TXT_ATR_FIELDSTART and CH_TXT_ATR_FIELDEND
+// themselves are part of the covered range. This is guaranteed by
+// TextFieldmark::InitDoc/lcl_AssureFieldMarksSet.
 bool MarkBase::IsCoveringPosition(const SwPosition rPos) const
 {
-return rPos = GetMarkStart()  rPos = GetMarkEnd();
+return GetMarkStart() = rPos  rPos  GetMarkEnd();
 }
 
 void MarkBase::SetMarkPos(const SwPosition rNewPos)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: sc/qa

2012-07-06 Thread Kohei Yoshida
 sc/qa/unit/ucalc.cxx |   89 +++
 1 file changed, 89 insertions(+)

New commits:
commit 2758492a670618262bd42e3b938f3fdf2e9141a2
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date:   Fri Jul 6 16:46:09 2012 -0400

New unit test for pivot table's handling of empty rows.

Change-Id: I1c922fd3d06aca49b98a933d82da478b22e74d4a

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index f317f52..46da7a0 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -167,6 +167,7 @@ public:
 void testPivotTableNormalGrouping();
 void testPivotTableNumberGrouping();
 void testPivotTableDateGrouping();
+void testPivotTableEmptyRows();
 
 void testSheetCopy();
 void testSheetMove();
@@ -234,6 +235,7 @@ public:
 CPPUNIT_TEST(testPivotTableNormalGrouping);
 CPPUNIT_TEST(testPivotTableNumberGrouping);
 CPPUNIT_TEST(testPivotTableDateGrouping);
+CPPUNIT_TEST(testPivotTableEmptyRows);
 CPPUNIT_TEST(testSheetCopy);
 CPPUNIT_TEST(testSheetMove);
 CPPUNIT_TEST(testExternalRef);
@@ -2688,6 +2690,93 @@ void Test::testPivotTableDateGrouping()
 m_pDoc-DeleteTab(0);
 }
 
+void Test::testPivotTableEmptyRows()
+{
+m_pDoc-InsertTab(0, OUString(Data));
+m_pDoc-InsertTab(1, OUString(Table));
+
+// Raw data
+const char* aData[][2] = {
+{ Name, Value },
+{ A, 1 },
+{ B, 2 },
+{ C, 3 },
+{ D, 4 },
+};
+
+// Dimension definition
+DPFieldDef aFields[] = {
+{ Name, sheet::DataPilotFieldOrientation_ROW, 0 },
+{ Value, sheet::DataPilotFieldOrientation_DATA, 
sheet::GeneralFunction_SUM },
+};
+
+ScAddress aPos(1,1,0);
+ScRange aDataRange = insertRangeData(m_pDoc, aPos, aData, 
SAL_N_ELEMENTS(aData));
+CPPUNIT_ASSERT_MESSAGE(failed to insert range data at correct position, 
aDataRange.aStart == aPos);
+
+// Extend the range downward to include some trailing empty rows.
+aDataRange.aEnd.IncRow(2);
+
+ScDPObject* pDPObj = createDPFromRange(
+m_pDoc, aDataRange, aFields, SAL_N_ELEMENTS(aFields), false);
+
+ScDPCollection* pDPs = m_pDoc-GetDPCollection();
+bool bSuccess = pDPs-InsertNewTable(pDPObj);
+
+CPPUNIT_ASSERT_MESSAGE(failed to insert a new pivot table object into 
document., bSuccess);
+CPPUNIT_ASSERT_MESSAGE(there should be only one data pilot table.,
+   pDPs-GetCount() == 1);
+pDPObj-SetName(pDPs-CreateNewName());
+
+ScRange aOutRange = refresh(pDPObj);
+
+{
+// Expected output table content.  0 = empty cell
+const char* aOutputCheck[][2] = {
+{ Name, 0 },
+{ A, 1 },
+{ B, 2 },
+{ C, 3 },
+{ D, 4 },
+{ (empty), 0 },
+{ Total Result, 10 },
+};
+
+bSuccess = checkDPTableOutput2(m_pDoc, aOutRange, aOutputCheck, 
Include empty rows);
+CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
+}
+
+// This time, ignore empty rows.
+ScDPSaveData* pSaveData = pDPObj-GetSaveData();
+CPPUNIT_ASSERT_MESSAGE(Save data doesn't exist., pSaveData);
+pSaveData-SetIgnoreEmptyRows(true);
+pDPObj-ClearTableData();
+aOutRange = refresh(pDPObj);
+
+{
+// Expected output table content.  0 = empty cell
+const char* aOutputCheck[][2] = {
+{ Name, 0 },
+{ A, 1 },
+{ B, 2 },
+{ C, 3 },
+{ D, 4 },
+{ Total Result, 10 },
+};
+
+bSuccess = checkDPTableOutput2(m_pDoc, aOutRange, aOutputCheck, 
Ignore empty rows);
+CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
+}
+
+pDPs-FreeTable(pDPObj);
+CPPUNIT_ASSERT_EQUAL_MESSAGE(There should be no more tables., 
pDPs-GetCount(), static_castsize_t(0));
+CPPUNIT_ASSERT_EQUAL_MESSAGE(There shouldn't be any more cache stored.,
+   pDPs-GetSheetCaches().size(), 
static_castsize_t(0));
+
+m_pDoc-DeleteTab(1);
+m_pDoc-DeleteTab(0);
+}
+
 void Test::testSheetCopy()
 {
 OUString aTabName(TestTab);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PATCH] Fix check for FRAME_DRAW_NWF and regression in CTRL_FRAME support

2012-07-06 Thread Ruslan Kabatsayev
Hello,

Commit 504e41016004fb2edebdb29a85d69084b1d6 breaks almost all the
support for CTRL_FRAME because of incorrect check for FRAME_DRAW_NWF.
It checks for it as if this were a single bit flag, but its value is
0x7, so it should be compared against its value after bitwise AND.

I'm attaching a patch which fixes this regression.

Regards,
Ruslan


0001-Fix-check-for-FRAME_DRAW_NWF-and-thus-reenable-CTRL_.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: avmedia/source cui/source mysqlc/source package/inc package/source scaddins/source sdext/source sfx2/inc sfx2/source sfx2/workben svx/inc svx/source

2012-07-06 Thread Takeshi Abe
 avmedia/source/viewer/mediaevent_impl.hxx |3 ---
 cui/source/customize/eventdlg.hxx |4 
 cui/source/factory/dlgfact.hxx|1 -
 cui/source/inc/SpellDialog.hxx|3 ---
 cui/source/inc/acccfg.hxx |1 +
 cui/source/inc/autocdlg.hxx   |1 -
 cui/source/inc/cfgutil.hxx|6 --
 cui/source/inc/cuicharmap.hxx |1 -
 cui/source/inc/cuigaldlg.hxx  |1 -
 cui/source/inc/hyphen.hxx |1 -
 cui/source/inc/macroass.hxx   |4 
 cui/source/inc/macropg.hxx|3 ---
 cui/source/inc/numpages.hxx   |1 -
 cui/source/inc/optdict.hxx|1 -
 cui/source/inc/optlingu.hxx   |1 -
 cui/source/inc/optpath.hxx|1 -
 cui/source/inc/paragrph.hxx   |1 -
 cui/source/inc/pastedlg.hxx   |1 -
 cui/source/options/optinet2.hxx   |2 --
 mysqlc/source/mysqlc_preparedstatement.hxx|1 -
 package/inc/ZipPackage.hxx|1 -
 package/inc/ZipPackageBuffer.hxx  |2 --
 package/inc/ZipPackageFolder.hxx  |2 --
 package/source/xstor/xfactory.hxx |2 --
 package/source/xstor/xstorage.hxx |5 -
 scaddins/source/analysis/analysis.hxx |1 -
 sdext/source/minimizer/impoptimizer.hxx   |3 ---
 sdext/source/pdfimport/sax/emitcontext.hxx|2 --
 sdext/source/pdfimport/tree/treevisiting.hxx  |3 ---
 sdext/source/presenter/PresenterCanvasHelper.hxx  |2 --
 sdext/source/presenter/PresenterController.hxx|1 -
 sdext/source/presenter/PresenterPaneBase.hxx  |1 -
 sdext/source/presenter/PresenterPaneBorderPainter.hxx |4 
 sdext/source/presenter/PresenterScreen.hxx|1 -
 sdext/source/presenter/PresenterTimer.hxx |2 --
 sdext/source/presenter/PresenterViewFactory.hxx   |2 --
 sfx2/inc/bitset.hxx   |2 --
 sfx2/inc/frmload.hxx  |2 --
 sfx2/inc/orgmgr.hxx   |1 -
 sfx2/source/dialog/filtergrouping.hxx |2 --
 sfx2/source/inc/appdata.hxx   |6 --
 sfx2/source/inc/docundomanager.hxx|5 -
 sfx2/source/inc/eventsupplier.hxx |1 -
 sfx2/source/inc/objshimp.hxx  |2 --
 sfx2/source/inc/preview.hxx   |3 ---
 sfx2/source/inc/sfxtypes.hxx  |3 ---
 sfx2/source/inc/versdlg.hxx   |1 -
 sfx2/source/menu/thessubmenu.hxx  |4 
 sfx2/source/view/impframe.hxx |1 -
 sfx2/source/view/viewimp.hxx  |1 -
 sfx2/workben/custompanel/ctp_factory.hxx  |2 --
 svx/inc/dragmt3d.hxx  |2 --
 svx/source/engine3d/helperminimaldepth3d.hxx  |1 -
 svx/source/gallery2/codec.hxx |1 -
 svx/source/inc/GraphCtlAccessibleContext.hxx  |1 -
 svx/source/inc/fmPropBrw.hxx  |1 -
 svx/source/inc/fmexch.hxx |2 --
 svx/source/inc/fmitems.hxx|6 --
 svx/source/inc/fmobj.hxx  |1 -
 svx/source/inc/fmpgeimp.hxx   |   13 -
 svx/source/inc/fmtextcontrolshell.hxx |1 -
 svx/source/inc/fmundo.hxx |8 
 svx/source/inc/fmvwimp.hxx|3 ---
 svx/source/inc/formcontroller.hxx |1 -
 svx/source/svdraw/svddrgm1.hxx|1 -
 svx/source/table/accessiblecell.hxx   |4 
 svx/source/tbxctrls/extrusioncontrols.hxx |4 
 svx/source/unodraw/shapeimpl.hxx  |2 --
 68 files changed, 1 insertion(+), 159 deletions(-)

New commits:
commit 79d386f00163968037673a5c4e616d0fc142086e
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Sat Jul 7 10:07:55 2012 +0900

removed unnecessary forward declarations of class

except moving 'class SfxStringItem' to cui/source/inc/acccfg.hxx

Change-Id: I11d3803ebcfa02658d376bacf28b3d6030ee9d1b

diff --git a/avmedia/source/viewer/mediaevent_impl.hxx 
b/avmedia/source/viewer/mediaevent_impl.hxx
index 9f282a9..048e6bd 100644
--- 

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 50911, which changed state.

Bug 50911 Summary: FILEOPEN impossible for any existing.ods
https://bugs.freedesktop.org/show_bug.cgi?id=50911

   What|Old Value   |New Value

 Resolution||DUPLICATE
 Status|REOPENED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Cppunit-1.13.0 released

2012-07-06 Thread Markus Mohrhard
Hey,

after we have no longer any build issues with cppunit I have now
officially tagged the 1.13.0 release of cppunit. I would like to thank
everybody who helped during this release.

The changes against the 1.12.1 release are:

- improved windows build experience (VisualStudio project files for
2005 to 2010).
- warning free code
- no auto_ptr in a header any more
- some old bugs fixed (sf#2185407, sf#2186611, sf#3123759, sf#2983798,
rhbz#641350, fdo#51317)

All other changes can be seen in the NEWS file and at
http://cgit.freedesktop.org/libreoffice/cppunit/log/

Please spread the news about our first cppunit release and encourage
people to provide bug report, patches and documentation.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] minutes of ESC call ...

2012-07-06 Thread Bjoern Michaelsen
Hi there,

On Thu, Jul 05, 2012 at 04:13:32PM +0100, Michael Meeks wrote:
   + firehose gerrit updates to the mailing list
 until complaints.
   + quite a number blocked by moderation
 AI:   + look at gerrit moderation issues / regex's (Thorsten)

This is solved now as you can see from the mails dropping onto the dev list. We
now have a tiny python script on the bot that fixes up the mail to also have
the dev-list in Cc: so that the fd.o greylists do not get upset. Incedentally,
that means we could tweak more haeders on those mails, but IMHO gerrit is doing
excellent work with the header tagging/metadata on its own.

Best,

Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 45355] CRASH if characters in text of BENGALI, TIBETAN, MALAYALAM, MARATHI, NEPALI, ORIYA, TAMIL, TELUGU, KHMER

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45355

--- Comment #21 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-05 22:42:33 PDT ---
Already [Reproducible] with 
parallel installation of MinGW Master LibO-dev 3.5.0beta2+  – WIN7 Home
Premium (64bit)  [Build ID: 18296b0-7f15fca-1fc8c06-ca8e46d] Win-x86@7-MinGW  
pull time 2011-12-26 21:38:56  - tinderbox: git sha1s 
and
Server installation of MSVC Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit)
ENGLISH UI [Build ID:  a286353-090bcba-3bf3b94] Win-x86@6 –
2011-12-02_22:36:35)

No crash, but unusable paste result with 3.5.5.3

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45355] CRASH if characters in text of BENGALI, TIBETAN, MALAYALAM, MARATHI, NEPALI, ORIYA, TAMIL, TELUGU, KHMER

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45355

--- Comment #22 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-05 22:44:05 PDT ---
@Nathan Wells:
http://wiki.documentfoundation.org/BugReport_Details#Version

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51766] CONFIGURATION: Cross-platform issue with Master Document sections

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51766

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||INVALID
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-05 22:59:45 PDT ---
Clone of Bug 51538

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51768] CONFIGURATION: Cross-platform issue with Master Document sections

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51768

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||INVALID
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-07-05 23:01:12 PDT ---
Clone of Bug 51538

@jmei...@worldimpact.org 
Can you tame your PC? Or should we block your account?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 48238] FORMATTING custom animation with sound - sound doesn't work

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48238

--- Comment #3 from bordfe...@web.de 2012-07-05 23:06:11 PDT ---
Problem still exists in 3.5.5.2.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51771] New: shrinking a jpg-graphic in a text anchored as character - surrounding text doesn't move

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51771

 Bug #: 51771
   Summary: shrinking a jpg-graphic in a text anchored as
character - surrounding text doesn't move
Classification: Unclassified
   Product: LibreOffice
   Version: 3.5.5.2 RC
  Platform: x86-64 (AMD64)
OS/Version: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: bordfe...@web.de


I inserted a jpg-graphic in a writer document. I chosed anchored as charakter.
If I shrink the graphic with the mouse the graphic becomes smaller correctly,
but the surrounding text stays in the same position of the graphic in original
size. If I increase the size of the graphic with the mouse the surrounding text
moves correctly.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34423] Functionality Request: Rotate Images in Writer

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34423

--- Comment #27 from glepp...@gmx.de 2012-07-05 23:34:46 PDT ---
For your information, Rotate Images in Writer is the absolute *Number 1* of
the TopTen for Enhancement Requests on the Documentfoudation Wiki. Please see:
http://wiki.documentfoundation.org/Vote_for_Enhancement#Top_Ten_of_Requests

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51253] EDITING: CRASH when undo leads to a deleted style

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51253

--- Comment #5 from Roman Eisele b...@eikota.de 2012-07-05 23:47:56 PDT ---
(In reply to comment #4)
 Can we mark this as resolved then?

No; it's fixed in AOO, but not (yet) in LibO -- just read comment #3 ;-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51772] New: general I/O error when opening a RTF file

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51772

 Bug #: 51772
   Summary: general I/O error when opening a RTF file
Classification: Unclassified
   Product: LibreOffice
   Version: 3.6.0.0.beta3
  Platform: All
OS/Version: Linux (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: jbf.fa...@orange.fr


Created attachment 63877
  -- https://bugs.freedesktop.org/attachment.cgi?id=63877
bugdoc with general I/O error with beta3

Step to reproduce:
- open the attached bugdoc with LO 3.5 or LO 3.6.0.0beta2 : OK
- open it with LO 3.6.0.0beta3 or master : general I/O error

So regression between beta2 and beta3.

Tested under Ubuntu 11.10 x86_64 with gnome-shell and Ubuntu 10.04 x86

Best regards. JBF

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51772] general I/O error when opening a RTF file

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51772

Jean-Baptiste Faure jbf.fa...@orange.fr changed:

   What|Removed |Added

   Keywords||regression

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51774] New: EDITING cycling through auto-input values with Ctrl-Tab broken

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51774

 Bug #: 51774
   Summary: EDITING cycling through auto-input values with
Ctrl-Tab broken
Classification: Unclassified
   Product: LibreOffice
   Version: 3.6.0.0.alpha1
  Platform: Other
OS/Version: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: Spreadsheet
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: c...@nouenoff.nl


New spreadsheet
Add apple in A1
Add ananas in A2
put cursor in A3
type a 
  ananas is offered
type Ctrl-Tab to get apple
  does not work

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51774] EDITING cycling through auto-input values with Ctrl-Tab broken

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51774

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 OS/Version|All |Linux (All)
 CC||c...@nouenoff.nl
   Keywords||regression

--- Comment #1 from Cor Nouws c...@nouenoff.nl 2012-07-06 00:32:01 PDT ---
was OK in 3.5.x
I test this on Linux

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51772] general I/O error when opening a RTF file

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51772

--- Comment #1 from pierre-yves samyn pierre-yves.sa...@laposte.net 
2012-07-06 00:35:23 PDT ---
I confirm with Windows 7 64bits  Version 3.6.0.0.beta3 (Build ID: 3e2b862)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51772] general I/O error when opening a RTF file

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51772

Jean-Baptiste Faure jbf.fa...@orange.fr changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51143] CONFIGURATION: crash if online update not installed

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51143

--- Comment #5 from pierre-yves samyn pierre-yves.sa...@laposte.net 
2012-07-06 00:42:34 PDT ---
Still occurs with Version 3.6.0.0.beta3 (Build ID: 3e2b862) Windows 7 64bits

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51775] New: LibreOffice crashes on startup after Java upgrade

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51775

 Bug #: 51775
   Summary: LibreOffice crashes on startup after Java upgrade
Classification: Unclassified
   Product: LibreOffice
   Version: 3.5 Daily
  Platform: x86 (IA32)
OS/Version: Windows (All)
Status: UNCONFIRMED
  Severity: critical
  Priority: medium
 Component: Installation
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: seatr...@gmail.com


Expected behaviour: detect and silently correct for an upgrade from Java 6.x to
Java 7.x
Actual Behaviour: fail to detect the change; crash without warning or
explanation on all subsequent startups.



A couple of days ago LO started crashing hard every time it was opened, in any
module: the Windows event log showed

Faulting application name: soffice.bin, version: 3.5.4.2, time stamp:
0x4fbc7fd1
Faulting module name: MSVCR90.dll, version: 9.0.30729.6161, time stamp:
0x4dace5b9
Exception code: 0xc417
Fault offset: 0x0002e9f4
Faulting process id: 0x1754
Faulting application start time: 0x01cd5a1a811603aa
Faulting application path: C:\Program Files\LibreOffice 3.5\program\soffice.bin
Faulting module path:
C:\Windows\WinSxS\x86_microsoft.vc90.crt_1fc8b3b9a1e18e3b_9.0.30729.6161_none_50934f2ebcb7eb57\MSVCR90.dll
Report Id: 656fdd56-c671-11e1-b9ee-001fd09f75e0

This happened every single time I tried to open it, wuth any file or in any
module, running 32 bit Windows 7, home edition, completely patched. 

Poking around on Google revealed the cause. If Oracle Java on Windows has been
updated to version 7 (as happens automatically), Libre Office 'loses' the
installation. The file 
C:\Users\{username}\AppData\Roaming\LibreOffice\3\user\config\javasettings_Windows_x86.xml

is not updated with the result that the program crashes hard and without
explanation every single time you try to open it. 

The workaround is to rename the user directory, and start LO up again. At this
point it reconstructs the user directory with a correct link to the new Java
installation in javasettings...xml. That can then be copied over to the old
user directory and then the whole lot recopied back, preserving the original
settings. But it is grotesque to expect normal users to do this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51775] LibreOffice crashes on startup after Java upgrade

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51775

seatr...@gmail.com changed:

   What|Removed |Added

   Priority|medium  |high

--- Comment #1 from seatr...@gmail.com 2012-07-06 00:45:03 PDT ---
upped importance to high since this will catch everyone running 3.5 on
Windows who upgrades their Java

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49672] RTF: Contents of new section not shown

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49672

f_rietv...@yahoo.com changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

--- Comment #7 from f_rietv...@yahoo.com 2012-07-06 00:56:31 PDT ---
Can someone please answer my question regarding what to do please? Thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 42742] FILEOPEN: Documents with linked images take a long time to load

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42742

--- Comment #7 from Yaytay jim.tal...@groupgti.com 2012-07-06 01:04:16 PDT ---
There isn't any VBA in the document.

My feeling is that you will solve the too long to import document problem by
resolving the issues with loading pictures.

A quick test with MS Word and Wireshark seems to indicate that it is 
1) Using some kind of cache (there are no network hits for the initial display
with the first picture).
2) Other pictures are downloaded only when displayed.
3) Each picture download takes 0.3s - 0.6s.
4) Some pictures are downloaded using an If-Modified-Since header and get a
304 Not Modified response in ~0.1s.

So the thing that makes MS Word so quick seems to be that it inherently uses
the IE cache, which may not be feasible for LO - but that only accounts for a
factor of 5-10 difference (so the early OOo results).

It seems to me that LO is doing something with the images that is making it
take a long time and download the image four times.

But this is all just analysis of the problem with inadequate information, the
thing that I actually need to be quicker is the complete open doc, save as
PDF cycle and any route you can take to achieve this is fine by me,

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51776] New: Page not in center when maximizing window

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51776

 Bug #: 51776
   Summary: Page not in center when maximizing window
Classification: Unclassified
   Product: LibreOffice
   Version: 3.6.0.0.beta2
  Platform: Other
OS/Version: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: reisi...@gmail.com


Created attachment 63878
  -- https://bugs.freedesktop.org/attachment.cgi?id=63878
Not working

When I maximize LibreOffice Writer, the page is not in the middle any more.

Further research done: If the width of the window is under a specific length
everything is OK, above not (See pic 1 and pic2).

The problem starts to occur with a with of 1701 pixels for sure.
IMHO it 100 works for everyone till 1683 pixels

= IMHO the problem starts to occur with a window width of 683-1701 px

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51776] Page not in center when maximizing window

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51776

--- Comment #1 from Florian Reisinger reisi...@gmail.com 2012-07-06 01:20:21 
PDT ---
Created attachment 63879
  -- https://bugs.freedesktop.org/attachment.cgi?id=63879
Working

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51776] Page not in center when maximizing window

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51776

--- Comment #2 from Florian Reisinger reisi...@gmail.com 2012-07-06 01:20:43 
PDT ---
PS: OS: Ubuntu 12.04 x64

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51776] Page not in center when having a specific screen width

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51776

Florian Reisinger reisi...@gmail.com changed:

   What|Removed |Added

Summary|Page not in center when |Page not in center when
   |maximizing window   |having a specific screen
   ||width

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51686] FORMATTING Background Colour No Fill and Font Colour Automatic cause LibreOffice to crash

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51686

Roman Eisele b...@eikota.de changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever Confirmed|1   |0

--- Comment #3 from Roman Eisele b...@eikota.de 2012-07-06 01:24:33 PDT ---
(In reply to comment #2)
 Thanks for your questions. [...]

Thank you very much for your additional testing! Well, your results make the
issue rather exiting: I should be able to reproduce the crash (we both use
the same LibreOffice and MacOS X version), but until now, I could not reproduce
it. I will do some more investigation and hope that I will find out ...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51759] LibO-Dev_3.6.0.0.beta2_Linux_x86-64_install-deb_en-US.tar.gz fails to start any application

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51759

Florian Reisinger reisi...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||reisi...@gmail.com
 Ever Confirmed|0   |1

--- Comment #1 from Florian Reisinger reisi...@gmail.com 2012-07-06 01:25:52 
PDT ---
Can't repoduce this

Can you please clear your user profile...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51759] LibO-Dev_3.6.0.0.beta2_Linux_x86-64_install-deb_en-US.tar.gz fails to open some file types

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51759

Florian Reisinger reisi...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
Summary|LibO-Dev_3.6.0.0.beta2_Linu |LibO-Dev_3.6.0.0.beta2_Linu
   |x_x86-64_install-deb_en-US. |x_x86-64_install-deb_en-US.
   |tar.gz fails to start any   |tar.gz fails to open some
   |application |file types

--- Comment #2 from Florian Reisinger reisi...@gmail.com 2012-07-06 01:29:25 
PDT ---
Ok, CRAH when opening .xlsx NOT .docx
.fodt .odt is OK

More research needed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51583] Printing fails

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51583

--- Comment #3 from Jürgen o...@oegym.de 2012-07-06 01:29:28 PDT ---
I tried to attach a bugtrace - but it seems that gdb crashed while debugging
... let's see if the report is helpful.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51583] Printing fails

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51583

--- Comment #4 from Jürgen o...@oegym.de 2012-07-06 01:30:07 PDT ---
Created attachment 63880
  -- https://bugs.freedesktop.org/attachment.cgi?id=63880
Bugtrace

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51777] New: FILEOPEN particular .HTML: TABLE borders invisible

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51777

 Bug #: 51777
   Summary: FILEOPEN particular .HTML: TABLE borders invisible
Classification: Unclassified
   Product: LibreOffice
   Version: 3.7.0.0.alpha0+ Master
  Platform: Other
OS/Version: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: libreoff...@bielefeldundbuss.de


Steps how to reproduce [Reproducible] with parallel installation of Master
LOdev  3.7.0.0.alpha0+   - WIN7 Home Premium (64bit) ENGLISH UI [Build ID:
c3dc9a3] (tinderbox: 2008R2@20, pull time 2012-07-05 08:52:02):

1. Download / Open attached sample360Beta2.html
   Expected: table borders shown around words Table
   Actual: no table borders visible

Please also compare PDF exports from 3.6.0.0.beta2 and Master

Borders are not lost, if you save document under new name from Master and open
with 3.6.0.0.beta borders still are visible.

This is not a general problem, works with a Writer document created from the
scratch and saved as .html

Worked fine at least until  Master LOdev  3.7.0.0.alpha0+   - WIN7 Home
Premium (64bit) ENGLISH UI [Build ID: 3985521] (tinderbox:
W2008R2@16-minimal_build, pull time 2012-06-24)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49672] RTF: Contents of new section not shown

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49672

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49672] RTF: Contents of new section not shown

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49672

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever Confirmed|1   |0

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51759] LibO-Dev_3.6.0.0.beta2_Linux_x86-64_install-deb_en-US.tar.gz fails to open some file types

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51759

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #3 from Cor Nouws c...@nouenoff.nl 2012-07-06 01:43:06 PDT ---
Irregularly I have a problem when I open a spreadsheet, that at the first
attempt the office crashes: property not found
(haven't found time yet to investigate, maybe already known ?)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38836] de-bloat internal ICU

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38836

--- Comment #7 from Eike Rathke er...@redhat.com 2012-07-06 02:09:04 PDT ---
There was someone working on it early this year or so, had some luck with
stripping down a bit the data libraries, but never came up with the final patch
(which would be just some makefile.mk hackery to pull a different tarball from
ext_sources) nor a verification whether the stripped down data actually worked
or not. Anyway, we'd have to redo things because in the mean time upgraded to
ICU 49 and data packages have to be assembled individually for each version.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45469] FILESAVE: export to PDF only exports first worksheet

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45469

--- Comment #6 from sasha.libreoff...@gmail.com 2012-07-06 02:22:34 PDT ---
Thanks for attachment. Reproduced.
In this attachment are no print ranges. Use Format-Print ranges-Edit for
fixing this error in document. Use entire sheet instead of none.

It is interesting, when page ranges are lost. If during saving/opening xls
format, then it resembles Bug 41593 and Bug 43281 or even Bug 51022.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 36149] CRASH hovering over Menu File Send if no JRE is available and MediaWiki Publisher installed

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36149

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 CC||fridrich.st...@bluewin.ch,
   ||michael.me...@novell.com

--- Comment #18 from Michael Meeks michael.me...@novell.com 2012-07-06 
02:42:25 PDT ---
Looks / sounds bad - prolly an un-caught / handled exception lurking somewhere.

Andras/Fridrich - can we get a stack-trace ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45355] CRASH if characters in text of BENGALI, TIBETAN, MALAYALAM, MARATHI, NEPALI, ORIYA, TAMIL, TELUGU, KHMER

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=45355

--- Comment #23 from Michael Meeks michael.me...@novell.com 2012-07-06 
02:43:49 PDT ---
I guess getting a drmemory trace on windows (if we can keep it alive that long)
may help us find the memory corruption (?)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51523] EDITING: Database Format TIME [HH]:MM:SS not working

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51523

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #12 from Lionel Elie Mamane lio...@mamane.lu 2012-07-06 02:44:39 
PDT ---
(In reply to comment #9)
 (In reply to comment #2)

 5) Are your fields of type DATE, DATETIME, TIMESTAMP, something else?
   Fields are of type TIME

That's your problem. SQL type TIME stores values between 00:00:00 and
23:59:59 (or possibly 23:59:60 if the implementation is that good that it
handles leap seconds; I doubt any implementation is that good). So it is not
the *format* that does not work, but you are using the wrong column type. What
you are trying to do is akin to trying to store 600 in a TINYINT column: it
will wrap around and *store* 88 because you are beyond the range handled by the
column.

Try with TIMESTAMP (Date/Time) type, it is hackish, but it seems to sorta-work
when the data is entered under date format (as e.g. 50:00:00), and only
formatted as [HH]:MM:SS later for printing / output.

I think your best bet right now is to use a float/real/double/decimal type for
the column, and format [HH]:MM:SS for output.

The true solution would be the INTERVAL column type, but it is not supported by
current version of LibO (and neither by the old embedded HSQLDB it uses) :-(

 and if not an embedded HSQL one (e.g. MySQL or
 PostgreSQL), then also attach the SQL script to run against the server to
 create the example database.
   Sorry but poor me as user don't know how :(

Your example is embedded HSQLDB, so no need for a SQL script (it is included in
the .odb).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51779] New: support for SQL datatype INTERVAL

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51779

 Bug #: 51779
   Summary: support for SQL datatype INTERVAL
Classification: Unclassified
   Product: LibreOffice
   Version: 3.5.4 release
  Platform: All
OS/Version: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Database
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: lio...@mamane.lu
CC: c...@nouenoff.nl, cw...@home.nl, ipla...@yahoo.co.uk,
lio...@mamane.lu
Depends on: 51523


+++ This bug was initially created as a clone of Bug #51523 +++

LibreOffice does not support the SQL INTERVAL datatype. That is the datatype to
store time *durations*, rather than a point in time (like DATE, TIME,
TIMESTAMP).

Our embedded HSQLDB 1.8 also does not support it, but that is no reason not to
support it cleanly when connecting to database backends that *do* support it.

Places that need to be changed:

1) offapi/com/sun/star/sdbc/DataType.idl needs a value for INTERVAL

2) connectivity/inc/connectivity/FValue.hxx: class ORowSetValue needs to be
adapted to handle values of that type. Also connectivity
source/commontools/FValue.cxx and undoubtedly many other places, such as
source/commontools/DateConversion.cxx, etc.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51523] EDITING: Database Format TIME [HH]:MM:SS not working

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51523

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Blocks||51779

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51779] support for SQL datatype INTERVAL

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51779

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

  Status Whiteboard||EasyHack
   ||DifficultyInteresting
   ||SkillCpp SkillSQL

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38811] default to SQLite not HSQLDB in Base

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38811

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

  Status Whiteboard|EasyHack|EasyHack
   |DifficultyInteresting   |DifficultyInteresting
   |SkillCpp|SkillCpp SkillSQL

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46259] re-write mysql connector to use the 'C' connector ...

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46259

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

  Status Whiteboard|EasyHack,DifficultyInterest |EasyHack
   |ing,SkillCpp,TopicCleanup   |DifficultyInteresting
   ||SkillCpp TopicCleanup
   ||SkillSQL

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46420] FILESAVE Footnotes are lost after saving as text

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46420

sasha.libreoff...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1

--- Comment #4 from sasha.libreoff...@gmail.com 2012-07-06 02:59:34 PDT ---
Thanks for attachment.
in 3.5.4 not implemented
in 3.6.beta1 also not implemented, but there is function File-Export with
variant Media Wiki, which exports footnotes inside of text. This may be used
as workaround.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51324] crash in xmloff.Impress.XMLContentImporter::com::sun::star::document::XImporter by CXX0X ABI incompatibilities

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51324

Michael Meeks michael.me...@novell.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||NOTOURBUG

--- Comment #24 from Michael Meeks michael.me...@novell.com 2012-07-06 
03:04:16 PDT ---
So - IMHO this is not a libreoffice bug :-) and should be closed NOTOURBUG ...

Of course, if we can add a configure check to catch systems that are compiled
with an older version of libstdc++ or somesuch that'd be great - we could
prolly compile a small file that did some sizeof() checks in configure.

But hopefully the issue has gone away...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 44446] LibreOffice 3.6 most annoying bugs

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 51324, which changed state.

Bug 51324 Summary: crash in 
xmloff.Impress.XMLContentImporter::com::sun::star::document::XImporter by CXX0X 
ABI incompatibilities
https://bugs.freedesktop.org/show_bug.cgi?id=51324

   What|Old Value   |New Value

 Resolution||NOTOURBUG
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38811] default to SQLite not HSQLDB in Base

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38811

--- Comment #25 from Michael Meeks michael.me...@novell.com 2012-07-06 
03:18:34 PDT ---
Lionel - should we open a new  cleaner bug with title:

create FireBird SQL connector

or something ? :-) and make that an easy hack ? this one is rather a long 
daunting read for an easy-hacker.

I guess we could close this bug too if sqlite is not the right solution :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51538] Linking address conflicts, Master Document sections not update

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51538

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #3 from Urmas davian...@gmail.com 2012-07-06 03:23:26 PDT ---
Presently the paths to linked documents are saved as
file:///Drive:/local_path/... even for mapped drives, which is, of course,
strange.

To OP: which 'crossplatform' solution will satisfy you?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 46872] [FORMATTING] Allow macro-less controls

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46872

--- Comment #3 from sasha.libreoff...@gmail.com 2012-07-06 03:29:35 PDT ---
Instructions:
1. Enable needed toolbar: View-Toolbars-Form controls
2. On this toolbar is button Design mode On/Off. When we create document with
forms, this button should be in pushed state. When we are finished with
creating forms, then we should click this button again for switch to user mode
of forms.

Create needed form controls in document
3. click button Design mode On/Off
4. Save document.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 48616] Please add 16:9 format presentation templates to the default installation set

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48616

Ivan Timofeev timofeev@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||WORKSFORME

--- Comment #1 from Ivan Timofeev timofeev@gmail.com 2012-07-06 03:31:58 
UTC ---
Version 3.6 has shiny new templates, which are 16:9 by default. BTW it is
possible to change slide format and all the presentation stuff scales
accordingly. For some reason that did not work before. :-\

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51775] LibreOffice crashes on startup after Java upgrade

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51775

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||DUPLICATE

--- Comment #2 from Urmas davian...@gmail.com 2012-07-06 03:39:06 PDT ---


*** This bug has been marked as a duplicate of bug 38913 ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 38913] CRASH when loading Danish dictionary at startup citing msvcr90.dll after upgrade

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38913

Urmas davian...@gmail.com changed:

   What|Removed |Added

 CC||seatr...@gmail.com

--- Comment #37 from Urmas davian...@gmail.com 2012-07-06 03:39:06 PDT ---
*** Bug 51775 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 51780] New: default to Firebird not HSQLDB in Base

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=51780

 Bug #: 51780
   Summary: default to Firebird not HSQLDB in Base
Classification: Unclassified
   Product: LibreOffice
   Version: unspecified
  Platform: Other
OS/Version: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Database
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: lio...@mamane.lu
CC: afriza...@gmail.com, bjoern.michael...@canonical.com,
glepp...@gmx.de, lio...@mamane.lu,
m...@foresightlinux.org, michael.me...@novell.com,
serval2...@yahoo.fr
Depends on: 38811


+++ This bug was initially created as a clone of Bug #38811 +++

Background: currently when creating an embedded database we default to the
Java-based HSQLDB database engine. That is somewhat unfortunate. It would be
better to default to an embedded FireBird provider - unfortunately we don't
have one. So - it needs writing - and then the default changing. See
[http://www.sqlite.org/c3ref/intro.html The SQLite C/C++ Interface].

Resources on the Firebird side:
Embedding:

http://www.firebirdsql.org/file/documentation/reference_manuals/user_manuals/html/qsg25-classic-or-super.html
 http://www.firebirdsql.org/manual/ufb-cs-embedded.html

http://www.firebirdsql.org/file/documentation/reference_manuals/user_manuals/html/qsg25-databases.html#qsg25-databases-connstrings-local
SQL Language:

http://www.firebirdsql.org/file/documentation/reference_manuals/reference_material/html/langrefupd25.html
API:
 examples/api in the FireBird sources
 sources of isql-fb program
 ...

Grr... It says
(http://www.firebirdsql.org/manual/ufb-cs-embedded.html#ufb-cs-embedded-linux)

 Finally, you can't just ship libfbembed.so with your application and
 use it to connect to local databases. Under Linux, you always need a
 properly installed server, be it Classic or Super.

That could be a problem, depending on what a properly installed server is.
Can we just ship it in LIBROFFICE_ROOT/program/fbserver? Or will it want config
files in /etc/ and that kind of things? To be investigated.

With HSQLDB, we override its access to files class so that it writes directly
into our in-memory and on-disk ZIP file structure (.odb file). Can we do
something similar with FireBird or will we have to use temporary files that are
copied into the .odb file at each .odb file save operation? In the latter
case, how to detect those have changed and activate the file save icon?

Resources on the LibreOffice side:

OpenOffice.org Developer's Guide at
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide,
and in particular these sections:

 * Writing Database Drivers:
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Database/Writing_Database_Drivers
 * About UNO:

http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/ProUNO/Professional_UNO

http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/WritingUNO/Writing_UNO_Components

http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/AdvUNO/Advanced_UNO


There is also a driver skeleton  in the SDK
documentation, and it has a file named How_to_write_my_own_driver.txt with a
more hands-on approach than the Developer's Guide, which gives more a
high-level overview and reference. In a git checkout of the source tree, it is
in odk/examples/DevelopersGuide/Database/DriverSkeleton

Also gleaned:

 * http://help.libreoffice.org/Common/Integrating_new_UNO_components

 * What classes/services/interfaces at a minimum have to be implemented?

See
http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Database/SDBC_Driver
for a functional minimum. After, you can add SDBCX services which provide added
features.

 * Are the code skeletons for the drivers usually auto-generated or written by
 hand?

The Database Driver Skeleton in the SDK seems to be written by hand, as it is
as is in the git sources.

 * Are there any existing unit tests for testing Base functionality with new
 drivers? If not, how were the existing drivers tested?

We currently don't have any, but that would be a fantastic opportunity to add
some :)

 * (a simple one) How will I set the default driver to SQLite in the source
 code?

Chase for embedded (and especially EMBEDDED_HSQLDB) in connectivity and
dbaccess directories of the source tree. That's the points where it currently
does something special for embedded HSQLDB, and where you'll have to do
something similar for embedded SQLite DB.



Let me introduce myself. I've started taking care of the PostgreSQL driver for
LibreOffice. That was also my first sizeable contribution to LibreOffice. As
such, I think:

 - I can be useful for you in the bootstrap phase sharing the things I
   learned while doing the PostgreSQL driver.

 - It would be useful for both 

[Libreoffice-bugs] [Bug 38811] default to SQLite not HSQLDB in Base

2012-07-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38811

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Blocks||51780

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   >