[PATCH] Change in core[libreoffice-4-0-0]: Add link to additional sdk-examples
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1819 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1819/1 Add link to additional sdk-examples Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72 (cherry picked from commit 664e559abd472bf2b427e2c01144ea39fb5bc02b) Reviewed-on: https://gerrit.libreoffice.org/1808 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com (cherry picked from commit 61ec20794324fc6d9c533f1347dbf1ababf38036) --- M odk/index.html M odk/index_online.html 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/odk/index.html b/odk/index.html index d3dfeb0..2a858f5 100644 --- a/odk/index.html +++ b/odk/index.html @@ -145,6 +145,13 @@ td class=content70A collection of examples in different programming languages (Java, Python, C++, Basic, OLE, CLI)./td /tr + tr valign=top +td class=content4img src=docs/images/arrow-1.gif/td +td colspan=2a href=https://gerrit.libreoffice.org/gitweb?p=sdk-examples.git;a=blob;f=README;hb=HEAD; title=link to the git repository README fileAdditional Examples/a/td +td class=content70A git repository with additional examples + from various contributors: codegit clone + https://gerrit.libreoffice.org/sdk-examples/code/td + /tr tr valign=middle tdimg class=nothing10 src=docs/images/nada.gif/td td colspan=3img class=line src=docs/images/sdk_line-1.gif/td diff --git a/odk/index_online.html b/odk/index_online.html index 032b699..76e6985 100644 --- a/odk/index_online.html +++ b/odk/index_online.html @@ -67,6 +67,13 @@ td class=content70A collection of examples in different programming languages (Java, Python, C++, Basic, OLE, CLI)./td /tr + tr valign=top +td class=content4img src=docs/images/arrow-1.gif/td +td colspan=2a href=https://gerrit.libreoffice.org/gitweb?p=sdk-examples.git;a=blob;f=README;hb=HEAD; title=link to the git repository README fileAdditional Examples/a/td +td class=content70A git repository with additional examples + from various contributors: codegit clone + https://gerrit.libreoffice.org/sdk-examples/code/td + /tr tr valign=middle tdimg class=nothing10 src=docs/images/nada.gif/td td colspan=3img class=line src=docs/images/sdk_line-1.gif/td -- To view, visit https://gerrit.libreoffice.org/1819 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0-0 Gerrit-Owner: Stephan Bergmann sberg...@redhat.com Gerrit-Reviewer: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - cui/source
cui/source/tabpages/chardlg.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 3f02531d4aaf270f452dd7e04f58a6b022df1af1 Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 23 10:48:43 2013 +0200 Use English Change-Id: I9c460c22a5c938851f7ce1db1527c0dadf09582b diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 7e0614f..a5b199e 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -81,8 +81,8 @@ using namespace ::com::sun::star; #define CLEARTITEM rSet.InvalidateItem(nWhich) #define LW_NORMAL 0 -#define LW_GESPERRT 1 -#define LW_SCHMAL 2 +#define LW_EXPANDED 1 +#define LW_CONDENSED 2 // static @@ -2755,7 +2755,7 @@ IMPL_LINK_NOARG(SvxCharPositionPage, KerningSelectHdl_Impl) m_pKerningFT-Enable(); m_pKerningMF-Enable(); -if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_CONDENSED ) { // Condensed - max value == 1/6 of the current font height SvxFont rFont = GetPreviewFont(); @@ -2790,7 +2790,7 @@ IMPL_LINK_NOARG(SvxCharPositionPage, KerningModifyHdl_Impl) long nKern = (short)m_pKerningMF-Denormalize( nVal ); // Condensed? - then negative -if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_CONDENSED ) nKern *= -1; SvxFont rFont = GetPreviewFont(); @@ -2854,7 +2854,7 @@ void SvxCharPositionPage::ActivatePage( const SfxItemSet rSet ) //the only thing that has to be checked is the max. allowed value for the //condense edit field -if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_CONDENSED ) { // Condensed - max value == 1/6 of the current font height SvxFont rFont = GetPreviewFont(); @@ -3003,11 +3003,11 @@ void SvxCharPositionPage::Reset( const SfxItemSet rSet ) if ( nKerning 0 ) { -m_pKerningLB-SelectEntryPos( LW_GESPERRT ); +m_pKerningLB-SelectEntryPos( LW_EXPANDED ); } else if ( nKerning 0 ) { -m_pKerningLB-SelectEntryPos( LW_SCHMAL ); +m_pKerningLB-SelectEntryPos( LW_CONDENSED ); nKerning = -nKerning; } else @@ -3178,13 +3178,13 @@ sal_Bool SvxCharPositionPage::FillItemSet( SfxItemSet rSet ) short nKerning = 0; SfxMapUnit eUnit = rSet.GetPool()-GetMetric( nWhich ); -if ( nPos == LW_GESPERRT || nPos == LW_SCHMAL ) +if ( nPos == LW_EXPANDED || nPos == LW_CONDENSED ) { long nTmp = static_castlong(m_pKerningMF-GetValue()); long nVal = LogicToLogic( nTmp, MAP_POINT, (MapUnit)eUnit ); nKerning = (short)m_pKerningMF-Denormalize( nVal ); -if ( nPos == LW_SCHMAL ) +if ( nPos == LW_CONDENSED ) nKerning *= - 1; } commit e37f024ce08f894e4bc926737d368806b3aea739 Author: Tor Lillqvist t...@iki.fi Date: Wed Jan 23 10:38:49 2013 +0200 When we have symbolic names why not use them consistently then Change-Id: Iec2e6dfa5b8bdc30e275862cf9f84e5f32818933 diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 9c35aff..7e0614f 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -2750,12 +2750,12 @@ IMPL_LINK( SvxCharPositionPage, FitToLineHdl_Impl, CheckBox*, pBox ) IMPL_LINK_NOARG(SvxCharPositionPage, KerningSelectHdl_Impl) { -if ( m_pKerningLB-GetSelectEntryPos() 0 ) +if ( m_pKerningLB-GetSelectEntryPos() LW_NORMAL ) { m_pKerningFT-Enable(); m_pKerningMF-Enable(); -if ( m_pKerningLB-GetSelectEntryPos() == 2 ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) { // Condensed - max value == 1/6 of the current font height SvxFont rFont = GetPreviewFont(); @@ -2790,7 +2790,7 @@ IMPL_LINK_NOARG(SvxCharPositionPage, KerningModifyHdl_Impl) long nKern = (short)m_pKerningMF-Denormalize( nVal ); // Condensed? - then negative -if ( m_pKerningLB-GetSelectEntryPos() == 2 ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) nKern *= -1; SvxFont rFont = GetPreviewFont(); @@ -2854,7 +2854,7 @@ void SvxCharPositionPage::ActivatePage( const SfxItemSet rSet ) //the only thing that has to be checked is the max. allowed value for the //condense edit field -if ( m_pKerningLB-GetSelectEntryPos() == 2 ) +if ( m_pKerningLB-GetSelectEntryPos() == LW_SCHMAL ) { // Condensed - max value == 1/6 of the current font height SvxFont rFont = GetPreviewFont(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - bin/lo-pack-sources
bin/lo-pack-sources | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 183f72485d67867792c2e4b966f0ebceab3d0a79 Author: Petr Mladek pmla...@suse.cz Date: Tue Jan 22 17:35:46 2013 +0100 lo-pack-sources: run NOCONFIGURE=1 ./autogen.sh instead of autoreconf autogen.sh runs the needed tools with the right include paths Change-Id: Ia253b19566eeda31a1190a4fa7c543f7ffb63bfb Reviewed-on: https://gerrit.libreoffice.org/1810 Reviewed-by: Miklos Vajna vmik...@suse.cz Tested-by: Miklos Vajna vmik...@suse.cz diff --git a/bin/lo-pack-sources b/bin/lo-pack-sources index 5341af5..de6a4be 100755 --- a/bin/lo-pack-sources +++ b/bin/lo-pack-sources @@ -131,15 +131,15 @@ sub generate_lo_module_changelog($$$) die Error: generating failed: $!\n; } -sub run_autoreconf($$) +sub run_autogen($$) { my ($dir, $module) = @_; -print Running autoreconf for $module...\n; +print Running autogen for $module...\n; system (cd $dir . -autoreconf -f -i . +NOCONFIGURE=1 ./autogen.sh . rm -rf autom4te.cache . -cd - /dev/null 21) die Error: autoreconf failed: $!\n; +cd - /dev/null 21) die Error: autogen failed: $!\n; } sub generate_sources_version_file($$) @@ -266,7 +266,7 @@ sub prepare_module_sources() # prepare sources my $temp_dir = copy_lo_module_to_tempdir($source_dir, $module, $lo_topdir_name); generate_lo_module_changelog($source_dir, $temp_dir/$lo_topdir_name, $module); -run_autoreconf($temp_dir/$lo_topdir_name, $module) if ($module eq 'core'); +run_autogen($temp_dir/$lo_topdir_name, $module) if ($module eq 'core'); generate_sources_version_file($temp_dir/$lo_topdir_name, $release_version) if ($module eq 'core'); return $temp_dir; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[libreoffice-4-0]: lo-pack-sources: run NOCONFIGURE=1 ./autogen.sh instead of a...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1810 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1810 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia253b19566eeda31a1190a4fa7c543f7ffb63bfb Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Petr Mladek pmla...@suse.cz Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - instsetoo_native/util solenv/inc
instsetoo_native/util/openoffice.lst | 40 +-- solenv/inc/minor.mk |4 +-- 2 files changed, 22 insertions(+), 22 deletions(-) New commits: commit 21df17a09ad63160e3a0769af62c84acf9c5af2c Author: Petr Mladek pmla...@suse.cz Date: Wed Jan 23 10:04:26 2013 +0100 bump product version to 4.0.0.2+, release number to 102 Change-Id: Ia2572a463e853f3a51ac5b2e9cd08e56d391543a diff --git a/instsetoo_native/util/openoffice.lst b/instsetoo_native/util/openoffice.lst index 632ae20..342a54c 100644 --- a/instsetoo_native/util/openoffice.lst +++ b/instsetoo_native/util/openoffice.lst @@ -4,7 +4,7 @@ Globals { variables { -UREPACKAGEVERSION 4.0.0.1 +UREPACKAGEVERSION 4.0.0.2 URELAYERVERSION 1 REFERENCEOOOMAJORMINOR 3.4 UNIXBASISROOTNAME libreoffice4.0 @@ -48,12 +48,12 @@ LibreOffice { PRODUCTNAME LibreOffice PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 4.0 USERDIRPRODUCTVERSION 4 -ABOUTBOXPRODUCTVERSION 4.0.0.1 +ABOUTBOXPRODUCTVERSION 4.0.0.2 ABOUTBOXPRODUCTVERSIONSUFFIX + BASEPRODUCTVERSION 4.0 PCPFILENAME libreoffice.pcp @@ -63,7 +63,7 @@ LibreOffice FILEFORMATNAME OpenOffice.org FILEFORMATVERSION 1.0 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION {buildid} LICENSENAME LGPL GLOBALFILEGID gid_File_Lib_Vcl @@ -98,13 +98,13 @@ LibreOffice_Dev { PRODUCTNAME LOdev PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 UNIXBASISROOTNAME lodev4.0 POSTVERSIONEXTENSION POSTVERSIONEXTENSIONUNIX BRANDPACKAGEVERSION 4.0 USERDIRPRODUCTVERSION 4 -ABOUTBOXPRODUCTVERSION 4.0.0.1 +ABOUTBOXPRODUCTVERSION 4.0.0.2 ABOUTBOXPRODUCTVERSIONSUFFIX + BASEPRODUCTVERSION 4.0 DEVELOPMENTPRODUCT 1 @@ -119,7 +119,7 @@ LibreOffice_Dev FILEFORMATNAME OpenOffice.org FILEFORMATVERSION 1.0 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION {buildid} LICENSENAME LGPL GLOBALFILEGID gid_File_Lib_Vcl @@ -157,9 +157,9 @@ URE { PRODUCTNAME URE PRODUCTVERSION 4.0 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION 1 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 BRANDPACKAGEVERSION 4.0 LICENSENAME LGPL NOVERSIONINDIRNAME 1 @@ -190,11 +190,11 @@ LibreOffice_SDK { PRODUCTNAME LibreOffice PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 POSTVERSIONEXTENSION SDK POSTVERSIONEXTENSIONUNIX sdk BRANDPACKAGEVERSION 4.0 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION {buildid} PACK_INSTALLED 1 DMG_VOLUMEEXTENSION SDK @@ -229,12 +229,12 @@ LibreOffice_Dev_SDK { PRODUCTNAME LOdev PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 UNIXBASISROOTNAME lodev4.0 POSTVERSIONEXTENSION SDK POSTVERSIONEXTENSIONUNIX sdk BRANDPACKAGEVERSION 4.0 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION {buildid} BASISPACKAGEPREFIX lodevbasis UREPACKAGEPREFIX lodev @@ -274,11 +274,11 @@ LibreOffice_Test { PRODUCTNAME LibreOffice PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 POSTVERSIONEXTENSION TEST POSTVERSIONEXTENSIONUNIX test BRANDPACKAGEVERSION 4.0 -PACKAGEVERSION 4.0.0.1 +PACKAGEVERSION 4.0.0.2 PACKAGEREVISION {buildid} PACK_INSTALLED 1 DMG_VOLUMEEXTENSION TEST @@ -313,12 +313,12 @@ LibreOffice_Dev_Test { PRODUCTNAME LOdev PRODUCTVERSION 4.0 -PRODUCTEXTENSION .0.1 +PRODUCTEXTENSION .0.2 UNIXBASISROOTNAME lodev4.0 POSTVERSIONEXTENSION TEST POSTVERSIONEXTENSIONUNIX test BRANDPACKAGEVERSION 4.0 -PACKAGEVERSION 4.0.0.1 +
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - librelogo/source
librelogo/source/LibreLogo/LibreLogo.py | 35 ++-- 1 file changed, 25 insertions(+), 10 deletions(-) New commits: commit a69529841d0252783194e81d5558b4926b76a05e Author: László Németh nem...@numbertext.org Date: Tue Jan 22 16:56:13 2013 +0100 librelogo: start selected text; am, eo transl. sup. Change-Id: I0f02c3db5ef5fc46e7dd163d9b3193be8fc78fdc Reviewed-on: https://gerrit.libreoffice.org/1814 Reviewed-by: Miklos Vajna vmik...@suse.cz Tested-by: Miklos Vajna vmik...@suse.cz diff --git a/librelogo/source/LibreLogo/LibreLogo.py b/librelogo/source/LibreLogo/LibreLogo.py index df5bdc0..556837d 100644 --- a/librelogo/source/LibreLogo/LibreLogo.py +++ b/librelogo/source/LibreLogo/LibreLogo.py @@ -25,7 +25,7 @@ else: __lngpath__ = unohelper.fileUrlToSystemPath(re.sub(program/(fundamental.ini|fundamentalrc)$, , urebootstrap)) __lngpath__ = __lngpath__ + share/Scripts/python/LibreLogo/.replace(/, os.sep) -__translang__ = ca|cs|de|dk|el|en|es|et|fr|hu|it|nl|no|pl|pt|ro|ru|se|sl # FIXME supported languages for language guessing, expand this list, according to the localizations +__translang__ = am|ca|cs|de|dk|el|en|eo|es|et|fr|hu|it|ja|nl|no|pl|pt|ro|ru|se|sl # FIXME supported languages for language guessing, expand this list, according to the localizations __lng__ = {} __docs__ = {} __prevcode__ = None @@ -568,16 +568,29 @@ def run(arg=None, arg2 = -1): with __lock__: __thread__ = 1 try: -__initialize__() -__setlang__() +__getdocument__() if arg2 == -1: -arg2 = _.doc.getText().getString() +try: +_.cursor = _.doc.getCurrentController().getViewCursor().getText().createTextCursor() # copy selection + _.cursor.gotoRange(_.doc.getCurrentController().getViewCursor(), False) +1/len(_.cursor.getString()) # exception, if zero length +except: +_.cursor = _.doc.getText().createTextCursorByRange(_.doc.getText().getStart()) +_.cursor.gotoEnd(True) +c = _.doc.Text.createTextCursor() # go to the first page +c.gotoStart(False) +_.doc.CurrentController.getViewCursor().gotoRange(c, False) +__initialize__() +__setlang__() +arg2 = _.cursor.getString() if len(arg2) 2: if MessageBox(_.doc.CurrentController.Frame.ContainerWindow, __l12n__(_.lng)['ERR_NOTAPROGRAM'], __l12n__(_.lng)['LIBRELOGO'], querybox, __YES_NO_CANCEL__) != 2: with __lock__: __thread__ = None return None -__gotoline__(1) +else: +__initialize__() +__setlang__() if __prevcode__ and __prevcode__ == arg2 and __prevlang__ == _.lng: __thread__ = LogoProgram(__prevcompiledcode__) else: @@ -1430,12 +1443,14 @@ def __compil__(s): return to_ascii(globs) + \n + result def __gotoline__(n): -__dispatcher__(.uno:Escape) -c = _.doc.Text.createTextCursor() -c.gotoStart(False) +_.cursor.collapseToStart() for i in range(1, n): -c.gotoNextParagraph(False) -_.doc.CurrentController.getViewCursor().gotoRange(c, False) +_.cursor.gotoNextParagraph(False) +try: +_.doc.CurrentController.getViewCursor().gotoRange(_.cursor, False) +except: +__dispatcher__(.uno:Escape) +_.doc.CurrentController.getViewCursor().gotoRange(_.cursor.getStart(), False) g_exportedScripts = left, right, goforward, gobackward, run, stop, home, clearscreen, commandline, __translate__ g_ImplementationHelper = unohelper.ImplementationHelper() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - bin/lo-pack-sources
bin/lo-pack-sources | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit fd19af10b4450cffdc055161e2df8ca5894bb24a Author: Petr Mladek pmla...@suse.cz Date: Tue Jan 22 17:35:46 2013 +0100 lo-pack-sources: run NOCONFIGURE=1 ./autogen.sh instead of autoreconf autogen.sh runs the needed tools with the right include paths Change-Id: Ia253b19566eeda31a1190a4fa7c543f7ffb63bfb Reviewed-on: https://gerrit.libreoffice.org/1810 Reviewed-by: Miklos Vajna vmik...@suse.cz Tested-by: Miklos Vajna vmik...@suse.cz diff --git a/bin/lo-pack-sources b/bin/lo-pack-sources index 5341af5..de6a4be 100755 --- a/bin/lo-pack-sources +++ b/bin/lo-pack-sources @@ -131,15 +131,15 @@ sub generate_lo_module_changelog($$$) die Error: generating failed: $!\n; } -sub run_autoreconf($$) +sub run_autogen($$) { my ($dir, $module) = @_; -print Running autoreconf for $module...\n; +print Running autogen for $module...\n; system (cd $dir . -autoreconf -f -i . +NOCONFIGURE=1 ./autogen.sh . rm -rf autom4te.cache . -cd - /dev/null 21) die Error: autoreconf failed: $!\n; +cd - /dev/null 21) die Error: autogen failed: $!\n; } sub generate_sources_version_file($$) @@ -266,7 +266,7 @@ sub prepare_module_sources() # prepare sources my $temp_dir = copy_lo_module_to_tempdir($source_dir, $module, $lo_topdir_name); generate_lo_module_changelog($source_dir, $temp_dir/$lo_topdir_name, $module); -run_autoreconf($temp_dir/$lo_topdir_name, $module) if ($module eq 'core'); +run_autogen($temp_dir/$lo_topdir_name, $module) if ($module eq 'core'); generate_sources_version_file($temp_dir/$lo_topdir_name, $release_version) if ($module eq 'core'); return $temp_dir; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - oox/inc
oox/inc/oox/vml/vmltextbox.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 65c487f5b34d18124e0786396930af3a03d0eace Author: LuboÅ¡ LuÅák l.lu...@suse.cz Date: Tue Dec 18 00:25:31 2012 +0100 class vs struct mismatch Apparently this was enough to cause a linking error with oox::vml::TextBox::TextBox on Windows. Signed-off-by: Petr Mladek pmla...@suse.cz diff --git a/oox/inc/oox/vml/vmltextbox.hxx b/oox/inc/oox/vml/vmltextbox.hxx index 4981443..1dc30ab 100644 --- a/oox/inc/oox/vml/vmltextbox.hxx +++ b/oox/inc/oox/vml/vmltextbox.hxx @@ -33,7 +33,7 @@ namespace com { namespace sun { namespace star { namespace oox { namespace vml { -class ShapeTypeModel; +struct ShapeTypeModel; // ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'refs/tags/libreoffice-4.0.0.2-buildfix1'
Tag 'libreoffice-4.0.0.2-buildfix1' created by Petr Mladek pmla...@suse.cz at 2013-01-23 09:32 -0800 Tag libreoffice-4.0.0.2-buildfix1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJQ/65AAAoJEPQ0oe+v7q6jFsIP/ifE/AlD68vljBokAr/7yX95 HN2aYZMX25QsJ5ttRO1Eb/iusBUu9Up2p8TnywP7GnWJjgjRyKsydSNRT9eSXfKF AvN63CCXLmtpl6JVIGvoD0/YcMNZUAS3Y3IeGg8OncoY6okk+pj+AYBEIVprFF8a rlNZXGuv/3bAzeaQ52c8HdTsucz3zSognHudSvAYXGotEJqy01tJHVjVKPWxFSb1 PufiyN3zV59UqrEbO9NRBqxrsb1DdyQn1+BFWyQ+8JizhyZniChYXhWbZLYBCc03 ib/e6JMGFSdIwY83H7+BBWqcafYRQr7iD11ZXp8DgyGmBXa8vjkZ5BFeOox+3JyH 9I93g0p5ksHqkopNhONNUY9D7ESwdnKzWQlL9Aa7Bc5aaprvEVf2Du+ge34WIr3H XAshu76XBOac5hnQ4jAclMrn4OqvoY6U9MdDx4Z3QuxPUUSSEdZ4gtwINhuOTtVm UX6NyvkKlGc7EAhAHWBpP6fM2XqnwgkYDEttRNYiMHWqos7F0kFiiAv2onTmk/5u vVSwVx9S6VcPo3ugUVQteVqMG7Clo5o6fY3atGQaN6fxMhPpHE1J9icakF1pppPU uNXJ2bdmJ4y55M0rbAXLOddm6tGHX45t9ncgcggPWqe7XE8IIRk7ehIb/NSNMrtA Th/V/HIsKEqV1rjIiAJ0 =uBR9 -END PGP SIGNATURE- Changes since libreoffice-4.0.0.2-2: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - build/win32 configure.ac src/lib
build/win32/libcdr.vcproj |4 ++-- build/win32/libcdr.vcxproj |4 ++-- configure.ac | 27 ++- src/lib/CDRDocument.cpp|2 +- src/lib/libcdr_utils.cpp | 33 ++--- 5 files changed, 41 insertions(+), 29 deletions(-) New commits: commit 2b7062a1a9405a652a36acb72befa0d9d6d06595 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 23 10:42:10 2013 +0100 Make ICU dependency optional (opt-out) diff --git a/build/win32/libcdr.vcproj b/build/win32/libcdr.vcproj index 7cf7334..8ee406e 100755 --- a/build/win32/libcdr.vcproj +++ b/build/win32/libcdr.vcproj @@ -42,7 +42,7 @@ Name=VCCLCompilerTool Optimization=0 AdditionalIncludeDirectories=$(LIBWPD_INCLUDE_DIR),$(LIBWPG_INCLUDE_DIR),$(LCMS2_INCLUDE_DIR),$(ZLIB_INCLUDE_DIR),$(ICU_INCLUDE_DIR) - PreprocessorDefinitions=_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS + PreprocessorDefinitions=_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING BasicRuntimeChecks=3 RuntimeLibrary=3 TreatWChar_tAsBuiltInType=false @@ -117,7 +117,7 @@ Optimization=2 InlineFunctionExpansion=1 AdditionalIncludeDirectories=$(LIBWPD_INCLUDE_DIR),$(LIBWPG_INCLUDE_DIR),$(LCMS2_INCLUDE_DIR),$(ZLIB_INCLUDE_DIR),$(ICU_INCLUDE_DIR) - PreprocessorDefinitions=NDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS + PreprocessorDefinitions=NDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING StringPooling=true RuntimeLibrary=2 EnableFunctionLevelLinking=true diff --git a/build/win32/libcdr.vcxproj b/build/win32/libcdr.vcxproj index 355ec43..46be0de 100755 --- a/build/win32/libcdr.vcxproj +++ b/build/win32/libcdr.vcxproj @@ -44,7 +44,7 @@ ClCompile OptimizationDisabled/Optimization AdditionalIncludeDirectories$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(LCMS2_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories - PreprocessorDefinitions_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)/PreprocessorDefinitions + PreprocessorDefinitions_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING;%(PreprocessorDefinitions)/PreprocessorDefinitions BasicRuntimeChecksEnableFastChecks/BasicRuntimeChecks RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary RuntimeTypeInfotrue/RuntimeTypeInfo @@ -75,7 +75,7 @@ OptimizationMaxSpeed/Optimization InlineFunctionExpansionOnlyExplicitInline/InlineFunctionExpansion AdditionalIncludeDirectories$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(LCMS2_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories - PreprocessorDefinitionsNDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)/PreprocessorDefinitions + PreprocessorDefinitionsNDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING;%(PreprocessorDefinitions)/PreprocessorDefinitions StringPoolingtrue/StringPooling RuntimeLibraryMultiThreadedDLL/RuntimeLibrary FunctionLevelLinkingtrue/FunctionLevelLinking diff --git a/configure.ac b/configure.ac index f5ec74f..8807a1a 100644 --- a/configure.ac +++ b/configure.ac @@ -62,18 +62,27 @@ PKG_CHECK_MODULES([ZLIB],[zlib],[],[ AC_SUBST(ZLIB_CFLAGS) AC_SUBST(ZLIB_LIBS) +AC_ARG_ENABLE([language-guessing], + [AS_HELP_STRING([--disable-language-guessing], [Disable language guessing using ICU])], + [enable_language_guessing=$enableval], + [enable_language_guessing=yes] +) + # # Find icu # -AC_PATH_PROG([ICU_CONFIG],[icu-config]) -AC_MSG_CHECKING([ICU installation]) -if ${ICU_CONFIG} --cflags /dev/null 21; then - ICU_CFLAGS=`${ICU_CONFIG} --cppflags-searchpath` - ICU_LIBS=`${ICU_CONFIG} --ldflags` - AC_MSG_RESULT([found]) -else - AC_MSG_ERROR([libicu config program icu-config not found]) -fi +AS_IF([test x$enable_language_guessing = xyes], [ + AC_PATH_PROG([ICU_CONFIG],[icu-config]) + AC_MSG_CHECKING([ICU installation]) + if ${ICU_CONFIG} --cflags /dev/null 21; then + ICU_CFLAGS=`${ICU_CONFIG} --cppflags-searchpath` + ICU_LIBS=`${ICU_CONFIG} --ldflags` + AC_MSG_RESULT([found]) + AC_DEFINE([ENABLE_LANGUAGE_GUESSING], [1], [Enable language guessing using ICU]) + else + AC_MSG_ERROR([libicu config program icu-config not
[Libreoffice-commits] .: oox/inc oox/source sd/source
oox/inc/oox/export/utils.hxx |1 oox/source/export/drawingml.cxx | 28 ++--- oox/source/export/shapes.cxx |2 sd/source/filter/eppt/pptx-epptooxml.cxx | 64 +++ 4 files changed, 47 insertions(+), 48 deletions(-) New commits: commit f2e6a55b803c4c7a200a4fbf8de342606d7d5939 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jan 23 10:46:09 2013 +0100 oox: kill no longer needed US() macro Change-Id: Id1cd194a5968aa8578d0f2fefb3c75e3d74a25f5 diff --git a/oox/inc/oox/export/utils.hxx b/oox/inc/oox/export/utils.hxx index f43faca..b491504 100644 --- a/oox/inc/oox/export/utils.hxx +++ b/oox/inc/oox/export/utils.hxx @@ -20,7 +20,6 @@ #ifndef _OOX_EXPORT_UTILS_HXX_ #define _OOX_EXPORT_UTILS_HXX_ -#define US(x) rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( x )) #define I32S(x) rtl::OString::valueOf( (sal_Int32) x ).getStr() #define I64S(x) rtl::OString::valueOf( (sal_Int64) x ).getStr() #define IS(x) rtl::OString::valueOf( x ).getStr() diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index a356102..94bf8a1 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -456,42 +456,42 @@ OUString DrawingML::WriteImage( const Graphic rGraphic ) switch ( aLink.GetType() ) { case GFX_LINK_TYPE_NATIVE_GIF: -sMediaType = US( image/gif ); +sMediaType = image/gif; pExtension = .gif; break; case GFX_LINK_TYPE_NATIVE_JPG: -sMediaType = US( image/jpeg ); +sMediaType = image/jpeg; pExtension = .jpeg; break; case GFX_LINK_TYPE_NATIVE_PNG: -sMediaType = US( image/png ); +sMediaType = image/png; pExtension = .png; break; case GFX_LINK_TYPE_NATIVE_TIF: -sMediaType = US( image/tiff ); +sMediaType = image/tiff; pExtension = .tiff; break; case GFX_LINK_TYPE_NATIVE_WMF: -sMediaType = US( image/x-wmf ); +sMediaType = image/x-wmf; pExtension = .wmf; break; case GFX_LINK_TYPE_NATIVE_MET: -sMediaType = US( image/x-met ); +sMediaType = image/x-met; pExtension = .met; break; case GFX_LINK_TYPE_NATIVE_PCT: -sMediaType = US( image/x-pict ); +sMediaType = image/x-pict; pExtension = .pct; break; default: { GraphicType aType = rGraphic.GetType(); if ( aType == GRAPHIC_BITMAP ) { GraphicConverter::Export( aStream, rGraphic, CVT_PNG ); -sMediaType = US( image/png ); +sMediaType = image/png; pExtension = .png; } else if ( aType == GRAPHIC_GDIMETAFILE ) { GraphicConverter::Export( aStream, rGraphic, CVT_EMF ); -sMediaType = US( image/x-emf ); +sMediaType = image/x-emf; pExtension = .emf; } else { OSL_TRACE( unhandled graphic type ); @@ -515,7 +515,7 @@ OUString DrawingML::WriteImage( const Graphic rGraphic ) xOutStream-closeOutput(); sRelId = mpFB-addRelation( mpFS-getOutputStream(), -US( http://schemas.openxmlformats.org/officeDocument/2006/relationships/image; ), + http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;, OUStringBuffer() .appendAscii( GetRelationCompPrefix() ) .appendAscii( media/image ) @@ -826,7 +826,7 @@ void DrawingML::WriteRunProperties( Reference XPropertySet rRun, sal_Bool bIs mAny = sURL; if( !sURL.isEmpty() ) { OUString sRelId = mpFB-addRelation( mpFS-getOutputStream(), - US( http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink; ), + http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink;, sURL, true ); mpFS-singleElementNS( XML_a, XML_hlinkClick, @@ -1029,12 +1029,12 @@ void DrawingML::WriteParagraphNumbering( Reference XPropertySet rXPropSet, sa if ( aPropName == NumberingType ) nNumberingType = *( (sal_Int16*)pValue ); else if ( aPropName == Prefix ) { -if( *(OUString*)pValue == US( ) ) ) +if( *(OUString*)pValue == )) bPBoth = true; } else if ( aPropName == Suffix ) { -if( *(OUString*)pValue == US( . ) ) +if( *(OUString*)pValue == .)
[Libreoffice-commits] .: src/lib
src/lib/CDRParser.cpp |5 + 1 file changed, 5 insertions(+) New commits: commit 1efc3cfb5e97e46ed19c39e8167c9fe06c2e21bf Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 23 10:51:58 2013 +0100 Stub extraction of encoding information from font name diff --git a/src/lib/CDRParser.cpp b/src/lib/CDRParser.cpp index 67080ec..c30d987 100644 --- a/src/lib/CDRParser.cpp +++ b/src/lib/CDRParser.cpp @@ -84,6 +84,10 @@ struct CDRStltRecord unsigned dropCapId; }; +static void processNameForEncoding(WPXString /* name */, unsigned short /* encoding */) +{ +} + } // anonymous namespace libcdr::CDRParser::CDRParser(const std::vectorWPXInputStream * externalStreams, libcdr::CDRCollector *collector) @@ -2332,6 +2336,7 @@ void libcdr::CDRParser::readFont(WPXInputStream *input, unsigned length) else break; } +processNameForEncoding(name, fontEncoding); } m_collector-collectFont(fontId, fontEncoding, name); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Where are the nightly builds for Linux?
On Tue, 2013-01-22 at 19:47 -0600, Steven P. Ulrick wrote: Hello, Everyone I hope that this is not too off topic, but I was wondering... Where are the nightly builds for Linux? The following three directories are now empty: http://dev-builds.libreoffice.org/daily/master/Linux-Fedora17-x86_64@4-gcc-4.7- dbgutil/ http://dev-builds.libreoffice.org/daily/master/Linux-x86_10-Release- Configuration/ http://dev-builds.libreoffice.org/daily/master/Linux-x86_64_11-Release- Configuration/ The Linux-*-Release-Configuration tinderboxes are quite slow. They are not able to build many branches in parallel. They are switched to the 4-0 branch these days. Linux-Fedora17-x86_64@4-gcc-4.7-dbgutil tinderbox is still running on master. I am not sure why it does not upload dailies. Thorsten? In other words, the three links quoted at the top of this message used to have nightly builds for Linux in them. Then, at some point after December, 24th, all of the nightly builds that had been in them were gone, and no new ones have appeared since then. This is especially dissapointing, since the last nightly build of LibreOffice that I installed had almost perfect integration with KDE. The buttons in all of the configuration windows respected my KDE choice of the Oxygen widget style! It would be great these nice KDE-related fixes in the 4-0 branch as well. Do you know what is the state there? Any help you can give me in solving this mystery is greatly appreciated. The number of tinderboxes is growing. I looking forward to have enough tinderboxes for each platform and branch. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANNOUNCE] libreoffice-4.0.0.2 tag created
On Tue, 2013-01-22 at 19:06 +0100, Petr Mladek wrote: Hi, there have been created the libreoffice-4.0.0.2 tag (aka rc2). The corresponding official builds will be available within next few days. Ah, the build failed on Windows. It has been fixed by the commit http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-0-0id=65c487f5b34d18124e0786396930af3a03d0eace The fix is included in the tag libreoffice-4.0.0.2-buildfix1 in the core repository. Also the refreshed main source tarball libreoffice-4.0.0.2.tar.xz can be found at http://dev-builds.libreoffice.org/pre-releases/src/. The submodules and the other source tarballs are not affected. I am sorry for any inconvenience. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: build/win32 configure.ac src/lib
build/win32/libcdr.vcproj |4 ++-- build/win32/libcdr.vcxproj |4 ++-- configure.ac | 12 ++-- src/lib/libcdr_utils.cpp |6 +++--- 4 files changed, 13 insertions(+), 13 deletions(-) New commits: commit cda00fa23d8519a11007e5240996ec5c5db27ac5 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 23 11:21:19 2013 +0100 More general configure option, since we will use icu for charset conversion too diff --git a/build/win32/libcdr.vcproj b/build/win32/libcdr.vcproj index 8ee406e..eb41309 100755 --- a/build/win32/libcdr.vcproj +++ b/build/win32/libcdr.vcproj @@ -42,7 +42,7 @@ Name=VCCLCompilerTool Optimization=0 AdditionalIncludeDirectories=$(LIBWPD_INCLUDE_DIR),$(LIBWPG_INCLUDE_DIR),$(LCMS2_INCLUDE_DIR),$(ZLIB_INCLUDE_DIR),$(ICU_INCLUDE_DIR) - PreprocessorDefinitions=_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING + PreprocessorDefinitions=_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;USE_ICU BasicRuntimeChecks=3 RuntimeLibrary=3 TreatWChar_tAsBuiltInType=false @@ -117,7 +117,7 @@ Optimization=2 InlineFunctionExpansion=1 AdditionalIncludeDirectories=$(LIBWPD_INCLUDE_DIR),$(LIBWPG_INCLUDE_DIR),$(LCMS2_INCLUDE_DIR),$(ZLIB_INCLUDE_DIR),$(ICU_INCLUDE_DIR) - PreprocessorDefinitions=NDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING + PreprocessorDefinitions=NDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;USE_ICU StringPooling=true RuntimeLibrary=2 EnableFunctionLevelLinking=true diff --git a/build/win32/libcdr.vcxproj b/build/win32/libcdr.vcxproj index 46be0de..4a4c679 100755 --- a/build/win32/libcdr.vcxproj +++ b/build/win32/libcdr.vcxproj @@ -44,7 +44,7 @@ ClCompile OptimizationDisabled/Optimization AdditionalIncludeDirectories$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(LCMS2_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories - PreprocessorDefinitions_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING;%(PreprocessorDefinitions)/PreprocessorDefinitions + PreprocessorDefinitions_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;USE_ICU;%(PreprocessorDefinitions)/PreprocessorDefinitions BasicRuntimeChecksEnableFastChecks/BasicRuntimeChecks RuntimeLibraryMultiThreadedDebugDLL/RuntimeLibrary RuntimeTypeInfotrue/RuntimeTypeInfo @@ -75,7 +75,7 @@ OptimizationMaxSpeed/Optimization InlineFunctionExpansionOnlyExplicitInline/InlineFunctionExpansion AdditionalIncludeDirectories$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(LCMS2_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories - PreprocessorDefinitionsNDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;ENABLE_LANGUAGE_GUESSING;%(PreprocessorDefinitions)/PreprocessorDefinitions + PreprocessorDefinitionsNDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;USE_ICU;%(PreprocessorDefinitions)/PreprocessorDefinitions StringPoolingtrue/StringPooling RuntimeLibraryMultiThreadedDLL/RuntimeLibrary FunctionLevelLinkingtrue/FunctionLevelLinking diff --git a/configure.ac b/configure.ac index 8807a1a..dc26908 100644 --- a/configure.ac +++ b/configure.ac @@ -62,23 +62,23 @@ PKG_CHECK_MODULES([ZLIB],[zlib],[],[ AC_SUBST(ZLIB_CFLAGS) AC_SUBST(ZLIB_LIBS) -AC_ARG_ENABLE([language-guessing], - [AS_HELP_STRING([--disable-language-guessing], [Disable language guessing using ICU])], - [enable_language_guessing=$enableval], - [enable_language_guessing=yes] +AC_ARG_WITH([icu], + [AS_HELP_STRING([--without-icu], [Disable the use of ICU])], + [with_icu=$enableval], + [with_icu=yes] ) # # Find icu # -AS_IF([test x$enable_language_guessing = xyes], [ +AS_IF([test x$with_icu = xyes], [ AC_PATH_PROG([ICU_CONFIG],[icu-config]) AC_MSG_CHECKING([ICU installation]) if ${ICU_CONFIG} --cflags /dev/null 21; then ICU_CFLAGS=`${ICU_CONFIG} --cppflags-searchpath` ICU_LIBS=`${ICU_CONFIG} --ldflags` AC_MSG_RESULT([found]) - AC_DEFINE([ENABLE_LANGUAGE_GUESSING], [1], [Enable language guessing using ICU]) + AC_DEFINE([USE_ICU], [1], [Enable the use of ICU]) else AC_MSG_ERROR([libicu config program icu-config not found]) fi], diff --git a/src/lib/libcdr_utils.cpp b/src/lib/libcdr_utils.cpp index
[Libreoffice-commits] .: solenv/bin
solenv/bin/exectest.pl | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) New commits: commit 409de33c5739db45b896935c79eba40b68e106ec Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 23 11:18:55 2013 +0100 In exectest.pl support commands prefixed by shell-style variable assignments ...and properly encode the command passed to Perl's open |..., which in turn apparently passes the command to the shell. Change-Id: I19ab8f677dced6c1421fd9b4910d8a84743c1506 diff --git a/solenv/bin/exectest.pl b/solenv/bin/exectest.pl index d504d62..06c9072 100644 --- a/solenv/bin/exectest.pl +++ b/solenv/bin/exectest.pl @@ -16,6 +16,13 @@ # the License at http://www.apache.org/licenses/LICENSE-2.0 . # +sub encode($) +{ +my ($arg) = @_; +$arg =~ s/'/'\\''/g; +return $arg +} + $#ARGV = 1 or die Usage: $0 input file|-SUCCESS|-FAILURE command arguments...; if ($ARGV[0] eq -SUCCESS) @@ -78,7 +85,22 @@ while (1) { { undef $title; } -open PIPE, | @ARGV or die cannot start process: $!; +my $prog = ''; +my $assigns = 1; +for ($i = 0; $i != scalar(@ARGV); ++$i) +{ +$prog .= ' ' unless $i == 0; +if ($assigns $ARGV[$i] =~ /^([A-Za-z_][A-Za-z0-9_]+)=(.*)$/) +{ +$prog .= $1 . =' . encode($2) . '; +} +else +{ +$prog .= ' . encode($ARGV[$i]) . '; +$assigns = 0; +} +} +open PIPE, | $prog or die cannot start process: $!; $open = 1; } elsif ($open $input) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Weird localization
On Tue, 2013-01-22 at 16:04 +, Caolán McNamara wrote: On Sat, 2013-01-19 at 20:23 -0500, James Cloos wrote: I'm not sure whether this is an upstream bug or Gentoo-specific, so it seemed best to talk about it here before I open a bugz report on it. I have lo 4.0.0.1 on an amd64 Gentoo box. The UI is, as it should be, in English except that one toolbar in draw, which identifies itself as Gdmath Addon if I move the bar to its own X window (via d-n-d) has tooltips auf Deutsch and the tools pop up dialogs where are all en Français. I don't think I've seen a bug quite like this one before -- it can't even decide *which* fremdsprach to use. :-/ Now that I see that this is an addon, is there a more-specific place to post a bug report? The toolbar was default on so I had presumed it to be (a new) part of the main release. As far as I know gdmath is not part of the usual build, nor does it appear to be an optional-to-bundle part of the normal build tree. So it either is an additional gentoo dependency or was installed as an add-on in some other way. Tomas told me privately that it was Gentoo specific bug. The 4.0 packages for Gentoo are still under development. This is a known problem. Anyway, if you want, you should enter it into the Gentoo bugzilla :-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Noel Power nopo...@novell.com changed: What|Removed |Added Depends on||59325 --- Comment #87 from Noel Power nopo...@novell.com --- adding bug #59325 it seems quite a serious regression -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/unx
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit e8e82bd2109b82ddd535cdac30303249c6b62942 Author: Abdulaziz A Alayed aala...@kacst.edu.sa Date: Tue Jan 22 11:43:30 2013 +0300 fdo#44582 fixing horizontal scroll bar in sub windows Change-Id: Ifea57dec77c5b23771684a1e46267f8431478075 Reviewed-on: https://gerrit.libreoffice.org/1806 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx index 736834a..e15fbfa 100644 --- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx @@ -1041,7 +1041,12 @@ sal_Bool GtkSalGraphics::getNativeControlRegion( ControlType nType, rNativeContentRegion.Right() = rNativeContentRegion.Left() + 1; if (!rNativeContentRegion.GetHeight()) rNativeContentRegion.Bottom() = rNativeContentRegion.Top() + 1; -returnVal = sal_True; + +returnVal = true; + +//See fdo#44582, Horizontal scrollbar in navigator window is broken +if ((nPart==PART_BUTTON_LEFT || nPart==PART_BUTTON_RIGHT) Application::GetSettings().GetLayoutRTL()) +returnVal = false; } if( (nType == CTRL_MENUBAR) (nPart == PART_ENTIRE_CONTROL) ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
vm2/gerrit configuration deployed
Hello, some of you know that I'm working heavily on creating a new master configuration for all TDF machines, including some self-written deployment scripts that will eventually be migrated to either Puppet or SALT. As I'm done some parts now, I've deployed the current configuration to vm2, which hosts gerrit. The configuration includes a base setup as well as Postfix+amavis+SpamAssassin+ClamAV+DKIM+SPF, so vm2 can now be considered in a consistent and stable state. I did not touch Apache, nor did I touch anything gerrit-related, so everything should work as expected. Just in case, I wanted to let you know, so if you discover some oddities, please feel free to poke hostmas...@documentfoundation.org Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Minutes - QA Call 01/11/2013
On Tue, 2013-01-22 at 07:52 -0800, Joel Madero wrote: There are quite a few issues with these new rules, mostly due to limitations with FDO but also because of situations we hadn't considered. All of this will be discussed on Friday and we'll hopefully have a final procedure down. One of the main issues is that FDO doesn't allow you to go from RESOLVED - WORKSFORME back to UNCONFIRMED. I see. This is quite a large problem as our QA team is using WFM quite a bit more these days as we work through UNCONFIRMED bugs but then a user says no no no it's still a problem! and then opens it back up as REOPENED, this is incorrect as REOPENED should only be used when a developer is assigned We could reconsider this statement. A bug in the state REOPENED might need triage as well. It is sometimes reopened a year after it is fixed because another user sees a similar problem. Sometimes it is better to open separate bug to solve the other problem and do not mess the original bugreport. Once the bug is triagged, we could move it to the state NEW as usual. Of course, the assigned or CCd developers might touch the reopened bug even before the QA team. This usually happen when the bug is reopened immediately after it is marked as FIXED. It is perfectly fine. Bug triagers do great job when preparing bugs for developers but it does not mean that developers could fix only triaged bugs ;-) and has said a patch fixed something and then a user says no that patch didn't fix my problem. Any bug that is unassigned but set to REOPENED is incorrectly marked -- and we're discussing how to handle these. This being said, there may be two options: 1) Ask Tollef to enable us to use UNVERIFIED after a bug is set to REOPENED Heh, I newer knew how to move bug back to UNCONFIRMED :-) IMHO, it should be easier. I am not sure what is the idea behind the current behavior. Please, add me into CC if you open a bug for this. 2) Ask use to change to NEEDINFO and then to UNVERIFIED - hassle It is not intuitive and confusing, so I would prefer to avoid it. 3) Something else that I haven't thought about A solution would be to reconsider the REOPENED bugs meaning as explained above :-) Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/source
vcl/source/gdi/bitmapex.cxx | 18 ++ 1 file changed, 18 insertions(+) New commits: commit e1669188e2832cf0cc1caf111f70aff7ba17757a Author: Thorsten Behrens tbehr...@suse.com Date: Wed Jan 23 11:42:55 2013 +0100 Fix fdo#59616 - ensure BitmapEx has same-sized subbitmaps Lots of code relies on the fact that the two bitmaps inside a BitmapEx actually have the same size. Enforce that convention during import. Change-Id: I436ccc33b06c627cd6347747d22c24bfaf7ca932 diff --git a/vcl/source/gdi/bitmapex.cxx b/vcl/source/gdi/bitmapex.cxx index 465ea1c..e7a4193 100644 --- a/vcl/source/gdi/bitmapex.cxx +++ b/vcl/source/gdi/bitmapex.cxx @@ -806,6 +806,24 @@ SvStream operator( SvStream rIStm, BitmapEx rBitmapEx ) if( !!aMask) { +// fdo#59616 enforce same size for both mask and content +if( aMask.GetSizePixel() != aBmp.GetSizePixel() ) +{ +Bitmap aNewMask; +const Size aNominalSize=aBmp.GetSizePixel(); +BitmapReadAccess aAcc(aMask); +if( aAcc.HasPalette() ) +aNewMask = Bitmap(aNominalSize, + aMask.GetBitCount(), + aAcc.GetPalette()); +else +aNewMask = Bitmap(aNominalSize, + aMask.GetBitCount()); +const Rectangle aCopyArea(Point(0,0), aNominalSize); +aNewMask.CopyPixel(aCopyArea, aCopyArea, aMask); +aMask = aNewMask; +} + // do we have an alpha mask? if( ( 8 == aMask.GetBitCount() ) aMask.HasGreyPalette() ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: setup_native/source
0 files changed New commits: commit bf8e8e8bd03647632ed0b55c2b983a4d16cee40e Author: Andras Timar ati...@suse.com Date: Wed Jan 23 12:30:42 2013 +0100 chmod 644 Change-Id: Idc06412b8be705ba0cd5695257fd961864e2ad6a diff --git a/setup_native/source/win32/customactions/tools/msiprop.hxx b/setup_native/source/win32/customactions/tools/msiprop.hxx old mode 100755 new mode 100644 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0-0' - odk/index.html odk/index_online.html
odk/index.html|7 +++ odk/index_online.html |7 +++ 2 files changed, 14 insertions(+) New commits: commit 3c5e84daea130c33b87342218e6b4f054696f087 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 22 14:24:31 2013 +0100 Add link to additional sdk-examples Change-Id: Ifcc3594273de3507ec9b208e9e762bed0f969d72 (cherry picked from commit 664e559abd472bf2b427e2c01144ea39fb5bc02b) Reviewed-on: https://gerrit.libreoffice.org/1808 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com (cherry picked from commit 61ec20794324fc6d9c533f1347dbf1ababf38036) Reviewed-on: https://gerrit.libreoffice.org/1819 Reviewed-by: Miklos Vajna vmik...@suse.cz diff --git a/odk/index.html b/odk/index.html index d3dfeb0..2a858f5 100644 --- a/odk/index.html +++ b/odk/index.html @@ -145,6 +145,13 @@ td class=content70A collection of examples in different programming languages (Java, Python, C++, Basic, OLE, CLI)./td /tr + tr valign=top +td class=content4img src=docs/images/arrow-1.gif/td +td colspan=2a href=https://gerrit.libreoffice.org/gitweb?p=sdk-examples.git;a=blob;f=README;hb=HEAD; title=link to the git repository README fileAdditional Examples/a/td +td class=content70A git repository with additional examples + from various contributors: codegit clone + https://gerrit.libreoffice.org/sdk-examples/code/td + /tr tr valign=middle tdimg class=nothing10 src=docs/images/nada.gif/td td colspan=3img class=line src=docs/images/sdk_line-1.gif/td diff --git a/odk/index_online.html b/odk/index_online.html index 032b699..76e6985 100644 --- a/odk/index_online.html +++ b/odk/index_online.html @@ -67,6 +67,13 @@ td class=content70A collection of examples in different programming languages (Java, Python, C++, Basic, OLE, CLI)./td /tr + tr valign=top +td class=content4img src=docs/images/arrow-1.gif/td +td colspan=2a href=https://gerrit.libreoffice.org/gitweb?p=sdk-examples.git;a=blob;f=README;hb=HEAD; title=link to the git repository README fileAdditional Examples/a/td +td class=content70A git repository with additional examples + from various contributors: codegit clone + https://gerrit.libreoffice.org/sdk-examples/code/td + /tr tr valign=middle tdimg class=nothing10 src=docs/images/nada.gif/td td colspan=3img class=line src=docs/images/sdk_line-1.gif/td ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cf2120872e37db6df4143d2693f39961e6d285c7 Author: Aurimas Fišeras auri...@members.fsf.org Date: Tue Jan 22 22:56:55 2013 +0200 Updated core Project: dictionaries 143afd75257fd4c4b44f09ee402ec8caa09011ba Update Lithuanian dictionary (1.3, 2013-01-20) Change-Id: I25940b19e77e7fc6165f9845238830d16ed87bf5 Reviewed-on: https://gerrit.libreoffice.org/1815 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com diff --git a/dictionaries b/dictionaries index c41681d..143afd7 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit c41681db324e6693e7730ac0f2c5de843d7c78cb +Subproject commit 143afd75257fd4c4b44f09ee402ec8caa09011ba ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8ec0a7c11f1745fc95c80af3422a7dc85109360f Author: Andras Timar ati...@suse.com Date: Wed Jan 23 12:37:07 2013 +0100 Updated core Project: dictionaries aeb40bcecda8f2e705db5035376a6047eb098825 diff --git a/dictionaries b/dictionaries index 143afd7..aeb40bc 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 143afd75257fd4c4b44f09ee402ec8caa09011ba +Subproject commit aeb40bcecda8f2e705db5035376a6047eb098825 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: lt_LT/AUTHORS
lt_LT/AUTHORS | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) New commits: commit aeb40bcecda8f2e705db5035376a6047eb098825 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 12:37:07 2013 +0100 converting file AUTHORS to Unix format Change-Id: I138b693cbb9002ab391c91bddba09a7b117c463e diff --git a/lt_LT/AUTHORS b/lt_LT/AUTHORS index 07900d5..6fab90a 100644 --- a/lt_LT/AUTHORS +++ b/lt_LT/AUTHORS @@ -1,19 +1,19 @@ -# This is the official list (in alphabetical order) of ispell-lt authors -# for copyright purposes. - -Albertas Agejevas a...@akl.lt -Aurimas Mikalauskas in...@crazy.lt -Dalius Tarvydas ma...@guru.lt -Eduardas KriÅ¡ÄiÅ«nas e...@katalogai.net -Gediminas Paulauskas mene...@delfi.lt -KÄstutis BiliÅ«nas ke...@kaunas.init.lt -KÄstutis SnieÅ¡ka sniek...@saule.pit.ktu.lt -Laimonas VÄbra laimonas.ve...@gmail.com -Linas Spraunius li...@operis.org -Mantas KriauÄiÅ«nas mo...@mail.lt -Marius Gedminas mged...@delfi.lt -RamÅ«nas LukaÅ¡eviÄius ramunas.lukasevic...@mail.lt -RiÄardas Äepas r...@richard.eu.org -Rimas Kudelis r...@akl.lt -Tomas Kuliavas to...@users.sourceforge.net - +# This is the official list (in alphabetical order) of ispell-lt authors +# for copyright purposes. + +Albertas Agejevas a...@akl.lt +Aurimas Mikalauskas in...@crazy.lt +Dalius Tarvydas ma...@guru.lt +Eduardas KriÅ¡ÄiÅ«nas e...@katalogai.net +Gediminas Paulauskas mene...@delfi.lt +KÄstutis BiliÅ«nas ke...@kaunas.init.lt +KÄstutis SnieÅ¡ka sniek...@saule.pit.ktu.lt +Laimonas VÄbra laimonas.ve...@gmail.com +Linas Spraunius li...@operis.org +Mantas KriauÄiÅ«nas mo...@mail.lt +Marius Gedminas mged...@delfi.lt +RamÅ«nas LukaÅ¡eviÄius ramunas.lukasevic...@mail.lt +RiÄardas Äepas r...@richard.eu.org +Rimas Kudelis r...@akl.lt +Tomas Kuliavas to...@users.sourceforge.net + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ef1bed7ec34809537d42b49a0e8581c3809ff93 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 12:40:30 2013 +0100 Updated core Project: dictionaries a392489288adb820663a793c38d144fea53033c2 diff --git a/dictionaries b/dictionaries index aeb40bc..a392489 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit aeb40bcecda8f2e705db5035376a6047eb098825 +Subproject commit a392489288adb820663a793c38d144fea53033c2 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: lt_LT/description.xml
lt_LT/description.xml |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) New commits: commit a392489288adb820663a793c38d144fea53033c2 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 12:40:30 2013 +0100 fix version number and display name for lt dictionary Change-Id: I385735f793e46bf79fb54f8693c872c42f16d332 diff --git a/lt_LT/description.xml b/lt_LT/description.xml index 05cefc9..bb09e03 100644 --- a/lt_LT/description.xml +++ b/lt_LT/description.xml @@ -1,9 +1,9 @@ ?xml version=1.0 encoding=UTF-8? description xmlns=http://openoffice.org/extensions/description/2006; xmlns:d=http://openoffice.org/extensions/description/2006; xmlns:xlink=http://www.w3.org/1999/xlink; -version value=1.3 / +version value=2013.01.20 / identifier value=org.openoffice.lt.hunspell.dictionaries / display-name -name lang=enLithuanian spelling dictionary/name +name lang=en-USLithuanian spelling dictionary, and hyphenation rules/name /display-name platform value=all / dependencies @@ -13,10 +13,5 @@ name xlink:href=https://launchpad.net/ispell-lt; lang=enAlbertas Agejevas and contributors/name name xlink:href=https://launchpad.net/ispell-lt; lang=ltAlbertas Agejevas ir bendradarbiai/name /publisher -registration -simple-license accept-by=admin suppress-on-update=true -license-text xlink:href=COPYING lang=en / -/simple-license -/registration /description ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fc4b3a04ada523805cc18c0f573e5efb0d34abf3 Author: Aurimas Fišeras auri...@members.fsf.org Date: Tue Jan 22 22:56:55 2013 +0200 Updated core Project: dictionaries fbc8cbe4fbf87a4e55a081261d94a31b213763fe diff --git a/dictionaries b/dictionaries index ea2435b..fbc8cbe 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit ea2435b34115035d7d5882968932b0f6a58d272a +Subproject commit fbc8cbe4fbf87a4e55a081261d94a31b213763fe ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/ui/docvw/edtwin2.cxx| 16 ++--- sw/source/ui/docvw/frmsidebarwincontainer.cxx |4 +-- sw/source/ui/docvw/srcedtw.cxx| 10 sw/source/ui/envelp/envfmt.cxx|8 +++--- sw/source/ui/envelp/envfmt.hxx|2 - sw/source/ui/envelp/envimg.cxx|6 ++--- sw/source/ui/envelp/label1.cxx| 26 +++--- sw/source/ui/envelp/labelcfg.cxx | 14 ++-- sw/source/ui/envelp/labfmt.cxx| 30 +- sw/source/ui/envelp/labfmt.hxx|8 +++--- sw/source/ui/envelp/labimg.cxx|4 +-- sw/source/ui/envelp/mailmrge.cxx |2 - 12 files changed, 65 insertions(+), 65 deletions(-) New commits: commit cd97df31f28d8941b53929493c9651fbfda46395 Author: Takeshi Abe t...@fixedpoint.jp Date: Wed Jan 23 21:08:35 2013 +0900 sal_Bool to bool Change-Id: I27471e2331ff4813850fc5d3ca398ae6e1d86758 diff --git a/sw/source/ui/docvw/edtwin2.cxx b/sw/source/ui/docvw/edtwin2.cxx index 6c0c454..78cbd7f 100644 --- a/sw/source/ui/docvw/edtwin2.cxx +++ b/sw/source/ui/docvw/edtwin2.cxx @@ -100,10 +100,10 @@ static void lcl_GetRedlineHelp( const SwRedline rRedl, String rTxt, sal_Bool b void SwEditWin::RequestHelp(const HelpEvent rEvt) { SwWrtShell rSh = rView.GetWrtShell(); -sal_Bool bQuickBalloon = 0 != (rEvt.GetMode() ( HELPMODE_QUICK | HELPMODE_BALLOON )); +bool bQuickBalloon = 0 != (rEvt.GetMode() ( HELPMODE_QUICK | HELPMODE_BALLOON )); if(bQuickBalloon rSh.GetViewOptions()-IsPreventTips()) return; -sal_Bool bWeiter = sal_True; +bool bWeiter = true; SET_CURR_SHELL(rSh); String sTxt; Point aPos( PixelToLogic( ScreenToOutputPixel( rEvt.GetMousePosPixel() ) )); @@ -380,7 +380,7 @@ void SwEditWin::RequestHelp(const HelpEvent rEvt) } } -bWeiter = sal_False; +bWeiter = false; } if( bWeiter ) { @@ -419,7 +419,7 @@ void SwEditWin::RequestHelp(const HelpEvent rEvt) Rectangle aRect(rEvt.GetMousePosPixel(), aTxtSize); Help::ShowQuickHelp(this, aRect, sTxt); } -bWeiter = sal_False; +bWeiter = false; } } @@ -438,7 +438,7 @@ void SwEditWin::RequestHelp(const HelpEvent rEvt) pObj = aVEvt.pObj; sTxt = pField-GetURL(); -bWeiter = sal_False; +bWeiter = false; } } if (bWeiter eHit == SDRHIT_TEXTEDIT) @@ -463,7 +463,7 @@ void SwEditWin::RequestHelp(const HelpEvent rEvt) if (pField ) { sTxt = ((const SvxURLField*) pField)-GetURL(); -bWeiter = sal_False; +bWeiter = false; } } } @@ -502,7 +502,7 @@ void SwEditWin::Paint(const Rectangle rRect) SwWrtShell* pWrtShell = GetView().GetWrtShellPtr(); if(!pWrtShell) return; -sal_Bool bPaintShadowCrsr = sal_False; +bool bPaintShadowCrsr = false; if( pShadCrsr ) { Rectangle aRect( pShadCrsr-GetRect()); @@ -515,7 +515,7 @@ void SwEditWin::Paint(const Rectangle rRect) // resides somewhat above, then everything is clipped outside // and we have to make the inner part at the end of the // Paint visible again. Otherwise Paint errors occur! -bPaintShadowCrsr = sal_True; +bPaintShadowCrsr = true; } } diff --git a/sw/source/ui/docvw/frmsidebarwincontainer.cxx b/sw/source/ui/docvw/frmsidebarwincontainer.cxx index dd906ed..0426de9d 100644 --- a/sw/source/ui/docvw/frmsidebarwincontainer.cxx +++ b/sw/source/ui/docvw/frmsidebarwincontainer.cxx @@ -42,7 +42,7 @@ namespace { struct SidebarWinOrder { -sal_Bool operator()( const SidebarWinKey rSidebarWinKeyA, +bool operator()( const SidebarWinKey rSidebarWinKeyA, const SidebarWinKey rSidebarWinKeyB ) const { return rSidebarWinKeyA rSidebarWinKeyB; @@ -67,7 +67,7 @@ namespace { struct FrmOrder { -sal_Bool operator()( const FrmKey rFrmKeyA, +bool operator()( const FrmKey rFrmKeyA, const FrmKey rFrmKeyB ) const { return rFrmKeyA rFrmKeyB; diff --git a/sw/source/ui/docvw/srcedtw.cxx b/sw/source/ui/docvw/srcedtw.cxx index 77fed41..9bf24bb 100644 --- a/sw/source/ui/docvw/srcedtw.cxx +++ b/sw/source/ui/docvw/srcedtw.cxx @@ -163,18 +163,18 @@ static void lcl_Highlight(const String rSource, SwTextPortions aPortionList) // now we still have to look for '' if(svtools::HTMLUNKNOWN != eFoundType) { -sal_Bool bFound = sal_False; +bool
[Libreoffice-commits] .: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5923e540d4eab0dc331ea439377ec1eb407400b9 Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Wed Jan 23 14:26:02 2013 +0100 docx export: use 'nil' instead of 'none' to express no border Word2007 writes nil too, and doesn't properly import none. Change-Id: I32147bbf8c94f8dcf079bcecad48ffaaf3aa1968 diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 0031b7f..6300ddd 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -1419,7 +1419,7 @@ static void impl_borderLine( FSHelperPtr pSerializer, sal_Int32 elementToken, co // OOXml also supports those types of borders, but we'll try to play with the first ones. // thickThinMediumGap, thickThinLargeGap, thickThinSmallGap // thinThickLargeGap, thinThickMediumGap, thinThickSmallGap -const char* pVal = none; +const char* pVal = nil; if ( pBorderLine !pBorderLine-isEmpty( ) ) { switch (pBorderLine-GetBorderLineStyle()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on|59303 | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/unx
vcl/unx/gtk/fpicker/SalGtkPicker.cxx |8 1 file changed, 8 deletions(-) New commits: commit 4aa908cf3a63bf4117357a8fbaeb2fd8dd5be310 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 23 15:33:28 2013 +0100 Unused #includes Change-Id: I624f35026b8ee847d70d429c61cd93d6a603d8b0 diff --git a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx index 9928143..6d5a9c6 100644 --- a/vcl/unx/gtk/fpicker/SalGtkPicker.cxx +++ b/vcl/unx/gtk/fpicker/SalGtkPicker.cxx @@ -23,19 +23,11 @@ #undef _LINUX_SOURCE_COMPAT #endif -#include com/sun/star/lang/DisposedException.hpp #include com/sun/star/lang/XMultiComponentFactory.hpp #include com/sun/star/uri/XExternalUriReferenceTranslator.hpp -#include com/sun/star/lang/SystemDependent.hpp -#include com/sun/star/awt/XSystemDependentWindowPeer.hpp -#include com/sun/star/awt/SystemDependentXWindow.hpp -#include com/sun/star/beans/NamedValue.hpp -#include com/sun/star/container/XNameAccess.hpp #include comphelper/processfactory.hxx -#include cppuhelper/interfacecontainer.h #include rtl/process.h #include osl/diagnose.h -#include com/sun/star/uno/Any.hxx #include osl/mutex.hxx #include vcl/svapp.hxx #include tools/urlobj.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - configure.ac src/lib
configure.ac |2 src/lib/libcdr_utils.cpp | 211 --- 2 files changed, 164 insertions(+), 49 deletions(-) New commits: commit fea15b833ed0057b1389aafd5fe8c57ed5eef918 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 23 15:35:19 2013 +0100 Bump version diff --git a/configure.ac b/configure.ac index dc26908..d0545e1 100644 --- a/configure.ac +++ b/configure.ac @@ -7,7 +7,7 @@ AC_PREREQ([2.65]) # m4_define([libcdr_version_major],[0]) m4_define([libcdr_version_minor],[0]) -m4_define([libcdr_version_micro],[9]) +m4_define([libcdr_version_micro],[10]) m4_define([libcdr_version],[libcdr_version_major.libcdr_version_minor.libcdr_version_micro]) # = commit 0cae5b7b126e9f4fb676e612735c67a801b08c05 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Wed Jan 23 15:35:04 2013 +0100 When using ICU, use it for character conversion too diff --git a/src/lib/libcdr_utils.cpp b/src/lib/libcdr_utils.cpp index ab9452a..53417a3 100644 --- a/src/lib/libcdr_utils.cpp +++ b/src/lib/libcdr_utils.cpp @@ -33,6 +33,8 @@ #ifdef USE_ICU #include unicode/ucsdet.h +#include unicode/ucnv.h +#include unicode/utypes.h #endif #define CDR_NUM_ELEMENTS(array) sizeof(array)/sizeof(array[0]) @@ -81,6 +83,34 @@ static unsigned short getEncodingFromICUName(const char *name) return 0xb1; if (strcmp(name, windows-1255) == 0) return 0xb1; + // JAPANESE + if (strcmp(name, Shift_JIS) == 0) +return 0x80; + if (strcmp(name, ISO-2022-JP) == 0) +return 0x80; + if (strcmp(name, EUC-JP) == 0) +return 0x80; + if (strcmp(name, windows-932) == 0) +return 0x80; + // KOREAN + if (strcmp(name, ISO-2022-KR) == 0) +return 0x81; + if (strcmp(name, EUC-KR) == 0) +return 0x81; + if (strcmp(name, windows-949) == 0) +return 0x81; + // CHINESE SIMPLIFIED + if (strcmp(name, ISO-2022-CN) == 0) +return 0x86; + if (strcmp(name, GB18030) == 0) +return 0x86; + if (strcmp(name, windows-936) == 0) +return 0x86; + // CHINESE TRADITIONAL + if (strcmp(name, Big5) == 0) +return 0x88; + if (strcmp(name, windows-950) == 0) +return 0x88; return 0; } @@ -121,6 +151,11 @@ static unsigned short getEncoding(const unsigned char *buffer, unsigned bufferLe static void _appendUCS4(WPXString text, unsigned ucs4Character) { + // Convert carriage returns to new line characters + // Writerperfect/LibreOffice will replace them by text:line-break + if (ucs4Character == 0x0d) +ucs4Character = (unsigned) '\n'; + unsigned char first; int len; if (ucs4Character 0x80) @@ -302,6 +337,8 @@ void libcdr::writeU8(WPXBinaryData buffer, const int value) void libcdr::appendCharacters(WPXString text, std::vectorunsigned char characters, unsigned short charset) { + if (!characters.size()) +return; static const unsigned short symbolmap [] = { 0x0020, 0x0021, 0x2200, 0x0023, 0x2203, 0x0025, 0x0026, 0x220D, // 0x20 .. @@ -334,6 +371,7 @@ void libcdr::appendCharacters(WPXString text, std::vectorunsigned char charac 0x23A0, 0x23A4, 0x23A5, 0x23A6, 0x23AB, 0x23AC, 0x23AD, 0x0020 // .. 0xFE }; +#ifndef USE_ICU static const unsigned short cp874map[] = { 0x20AC, 0x0020, 0x0020, 0x0020, 0x0020, 0x2026, 0x0020, 0x0020, @@ -533,70 +571,147 @@ void libcdr::appendCharacters(WPXString text, std::vectorunsigned char charac 0x0111, 0x00F1, 0x0323, 0x00F3, 0x00F4, 0x01A1, 0x00F6, 0x00F7, 0x00F8, 0x00F9, 0x00FA, 0x00FB, 0x00FC, 0x01B0, 0x20AB, 0x00FF }; +#endif #ifdef USE_ICU if (!charset characters.size()) charset = getEncoding(characters[0], characters.size()); #endif - for (std::vectorunsigned char::const_iterator iter = characters.begin(); - iter != characters.end(); ++iter) + if (charset == 0x02) // SYMBOL { uint32_t ucs4Character = 0; -if (*iter 0x20) - ucs4Character = 0x20; -else if (*iter = 0x20 *iter 0x7f) +for (std::vectorunsigned char::const_iterator iter = characters.begin(); + iter != characters.end(); ++iter) { - if (charset == 2) // SYMBOL -ucs4Character = symbolmap[*iter - 0x20]; + if (*iter 0x20) +ucs4Character = 0x20; else -ucs4Character = *iter; +ucs4Character = symbolmap[*iter - 0x20]; + _appendUCS4(text, ucs4Character); } -else if (*iter == 0x7f) - ucs4Character = 0x20; -else + } + else + { +#ifdef USE_ICU +UErrorCode status = U_ZERO_ERROR; +UConverter *conv = NULL; +switch (charset) { - switch (charset) +case 0x80: // SHIFTJIS + conv = ucnv_open(windows-932, status); + break; +case 0x81: // HANGUL + conv = ucnv_open(windows-949, status); + break; +case 0x86: // GB2312 + conv = ucnv_open(windows-936, status); + break; +case 0x88: // CHINESEBIG5 + conv = ucnv_open(windows-950, status); +case
[Libreoffice-commits] .: vote/include
vote/include/schema.sql | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) New commits: commit 0bdaa1b9f2cdb79a761065d52a5e02b61d0e2d29 Author: Thorsten Behrens tbehr...@suse.com Date: Wed Jan 23 15:39:27 2013 +0100 Update sql schema with our local habits diff --git a/vote/include/schema.sql b/vote/include/schema.sql index 68df66e..4388d50 100644 --- a/vote/include/schema.sql +++ b/vote/include/schema.sql @@ -1,3 +1,16 @@ + CREATE database elections; + + /* this user has elevated rights - not to be used from php */ + CREATE USER 'voting'@'localhost' IDENTIFIED BY 'secure_pw'; + GRANT SELECT,INSERT,UPDATE,DELETE,CREATE,DROP ON elections.* TO 'voting'@'localhost'; + + /* this user has lowest-possible rights - to be used from php */ + CREATE USER 'web'@'localhost' IDENTIFIED BY 'whatever'; + GRANT SELECT ON elections.* TO 'web'@'localhost'; + GRANT SELECT,INSERT ON elections.election_anon_tokens TO 'web'@'localhost'; + GRANT SELECT,INSERT ON elections.election_votes TO 'web'@'localhost'; + GRANT SELECT,DELETE ON elections.election_tmp_tokens TO 'web'@'localhost'; + CREATE TABLE `elections` ( `id` int(11) NOT NULL auto_increment, `type` enum('elections','referendum') NOT NULL default 'elections', @@ -25,9 +38,11 @@ ) ENGINE=InnoDB AUTO_INCREMENT=39 DEFAULT CHARSET=utf8; CREATE TABLE `election_tmp_tokens` ( + `id` int(11) NOT NULL auto_increment, `election_id` int(11) NOT NULL default '0', `member_id` int(11) NOT NULL default '0', `tmp_token` varchar(200) NOT NULL default '' + PRIMARY KEY (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; /* @@ -36,8 +51,6 @@ from members database we prepare anon tokens of course before a new election record should be created since its id is needed for anon_tokens and election_choices are to be inserted rest is handled by itself iirc -bolsh There's election_votes and foundationmembers too - I'm not sure if there's a join done between foundationmembers and the other tables */ CREATE TABLE `election_votes` ( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
How to force RTL layout in a non-RTL locale?
I'm trying to finish my patch, partially implemented here: https://gerrit.libreoffice.org/1785 Does anybody know how to set up my layout for RTL in order I can do my tests? If somebody could help me on to display a text with a certain (Y-coord) baseline, I'd be glad also. Regards, Rodolfo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/inc vcl/source
vcl/inc/sallayout.hxx|1 - vcl/source/gdi/sallayout.cxx | 26 -- 2 files changed, 27 deletions(-) New commits: commit 98f56121858b4bea54d056a073005a10648785c6 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 14:33:38 2013 + fdo#54629 MultiSalLayout::GetBoundRect always uses level 0 fallback font ...in X11SalGraphics::GetGlyphBoundRect In MultiSalLayout::GetBoundRect we loop through each fallback font and union each level's GetBoundRect to get the result, which seems reasonable, except that for each level that means a call to SalLayout::GetBoundRect which calls X11SalGraphics::GetGlyphBoundRect. Those sublevel SalLayouts don't know that they are sublevels so they never set the level bits on their glyphs. Which results in X11SalGraphics::GetGlyphBoundRect always searching for that glyph in the level 0 font, so there's a mismatch between the font the SalLayout's are created to use and the font that gets used. Now, SalLayout::GetBoundRect is a fairly simple thing, it just calls GetNextGlyphs 1 by 1 and X11SalGraphics::GetGlyphBoundRect on the result of that. So I *think* that if we remove the specialized MultiSalLayout::GetBoundRect in favour of the default implementation, then because MultiSalLayout::GetNextGlyphs is specialized to do-the-right-thing and set up the glyph ids correctly, then we bubble the ids down to X11SalGraphics::GetGlyphBoundRect correctly to get it to use the right font and we get the correct bounding size. defb4d60a2d22fd36a0ff3f077faa6a0932b45a4 defb4d60a2d22fd36a0ff3f077faa6a0932b45a4 Change-Id: Idefb4d60a2d22fd36a0ff3f077faa6a0932b45a4 diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx index c430097..e86ecdb 100644 --- a/vcl/inc/sallayout.hxx +++ b/vcl/inc/sallayout.hxx @@ -250,7 +250,6 @@ public: virtual int GetNextGlyphs( int nLen, sal_GlyphId* pGlyphIdxAry, Point rPos, int, sal_Int32* pGlyphAdvAry, int* pCharPosAry ) const; virtual boolGetOutline( SalGraphics, ::basegfx::B2DPolyPolygonVector ) const; -virtual boolGetBoundRect( SalGraphics, Rectangle ) const; // used only by OutputDevice::ImplLayout, TODO: make friend explicitMultiSalLayout( SalLayout rBaseLayout, diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx index d9c921d..7171f59 100644 --- a/vcl/source/gdi/sallayout.cxx +++ b/vcl/source/gdi/sallayout.cxx @@ -2080,30 +2080,4 @@ bool MultiSalLayout::GetOutline( SalGraphics rGraphics, return bRet; } -// --- - -bool MultiSalLayout::GetBoundRect( SalGraphics rGraphics, Rectangle rRect ) const -{ -bool bRet = false; - -Rectangle aRectangle; -for( int i = mnLevel; --i = 0; ) -{ -SalLayout rLayout = *mpLayouts[ i ]; -rLayout.DrawBase() = maDrawBase; -rLayout.DrawOffset() += maDrawOffset; -rLayout.InitFont(); -if( rLayout.GetBoundRect( rGraphics, aRectangle ) ) -{ -rRect.Union( aRectangle ); -bRet = true; -} -rLayout.DrawOffset() -= maDrawOffset; -} - -return bRet; -} - -// === - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58988, which changed state. Bug 58988 Summary: Copy and paste chart fails if the source sheet does not have the default name https://bugs.freedesktop.org/show_bug.cgi?id=58988 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: configure.ac
configure.ac | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) New commits: commit a5794f08635ef5f526e25c45542c9ac009a07757 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 16:02:25 2013 +0100 sort out msm finding/copying issues Change-Id: Id54b9a480b345b52f86c53f6a0a939c18807ec05 diff --git a/configure.ac b/configure.ac index c005756..7001d12 100644 --- a/configure.ac +++ b/configure.ac @@ -4959,11 +4959,7 @@ find_msms() fi msms=Microsoft_VC${VCVER}_CRT_x86.msm -if test -e $msmdir/Microsoft_VC${VCVER}_CRT_x64.msm; then -msms=$msms Microsoft_VC${VCVER}_CRT_x64.msm -else -AC_MSG_WARN([Failed to copy x64 merge modules, installation will lack the 64-bit Explorer extension]) -fi + if test $VCVER = 90; then if test -e $msmdir/policy_9_0_Microsoft_VC90_CRT_x86.msm; then msms=$msms policy_9_0_Microsoft_VC90_CRT_x86.msm @@ -4971,6 +4967,21 @@ find_msms() AC_MSG_ERROR([Merge modules not found]) fi fi + +if test $BUILD_X64 = TRUE; then +if test -e $msmdir/Microsoft_VC${VCVER}_CRT_x86_x64.msm; then +msms=$msms Microsoft_VC${VCVER}_CRT_x86_x64.msm +else +AC_MSG_ERROR([Failed to copy x64 merge modules]) +fi +if test $VCVER = 90; then +if test -e $msmdir/policy_9_0_Microsoft_VC90_CRT_x86_x64.msm; then +msms=$msms policy_9_0_Microsoft_VC90_CRT_x86_x64.msm +else +AC_MSG_ERROR([Merge modules not found]) +fi +fi +fi } find_msvc_dlls() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.ac
configure.ac | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 7a4275a142dcce310f63d50a0baa9fc067539580 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 23 16:11:02 2013 +0100 Adapt configure --help output ...to 75e32e150133511d8f098a253a56426ed0302cec default to --without-help and --without-myspell-dicts. Change-Id: I018b8033f3a9d485b5cf5a9392719748426de53b diff --git a/configure.ac b/configure.ac index 7001d12..d2810fd 100644 --- a/configure.ac +++ b/configure.ac @@ -1286,10 +1286,8 @@ AC_ARG_WITH(system-nss, [with_system_nss=$with_system_libs]) AC_ARG_WITH(myspell-dicts, -AS_HELP_STRING([--without-myspell-dicts], -[Removes myspell dictionaries from LibreOffice installation set, for - people building for specific distributions where the myspell dictionaries - are installed from other sources.]), +AS_HELP_STRING([--with-myspell-dicts], +[Adds myspell dictionaries to the LibreOffice installation set]), ,) AC_ARG_WITH(system-dicts, @@ -1711,8 +1709,8 @@ AC_ARG_WITH(jdk-home, ,) AC_ARG_WITH(help, -AS_HELP_STRING([--without-help], -[Disable the build of help.])) +AS_HELP_STRING([--with-help], +[Enable the build of help.])) AC_ARG_WITH(java, AS_HELP_STRING([--with-java], ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #200 from Petr Mladek pmla...@suse.cz --- (In reply to comment #199) Also nominate bug 55946, LO cannot properly read .docx cover pages. A good number of Word documents out there use cover pages, and LibreOffice needs to be able to display Word documents correctly to be at its best. It is one of more features that are missing in the import/export filters. Only one person is currently interested into this bug. SO, I would prefer to leave it out of MABs. Instread, I added Writer developers into CC, so they are aware of it. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/uiconfig
sw/uiconfig/swriter/ui/rowheight.ui | 139 1 file changed, 139 insertions(+) New commits: commit 7dbcd6e6926b0162ecc48f36bfe70bdf5f06d929 Author: Abdulelah Alarifi asalar...@kacst.edu.sa Date: Sat Jan 19 09:50:32 2013 +0300 Converted Table- Autofit- Row Height widget Change-Id: I9cc578ff3355e720181e68f252d678696ecfeed1 Reviewed-on: https://gerrit.libreoffice.org/1765 Tested-by: Caolán McNamara caol...@redhat.com Reviewed-by: Caolán McNamara caol...@redhat.com diff --git a/sw/uiconfig/swriter/ui/rowheight.ui b/sw/uiconfig/swriter/ui/rowheight.ui new file mode 100644 index 000..e3fc949 --- /dev/null +++ b/sw/uiconfig/swriter/ui/rowheight.ui @@ -0,0 +1,139 @@ +?xml version=1.0 encoding=UTF-8? +interface + !-- interface-requires gtk+ 3.0 -- + object class=GtkAction id=action1/ + object class=GtkDialog id=Row Height +property name=can_focusFalse/property +property name=border_width5/property +property name=type_hintdialog/property +child internal-child=vbox + object class=GtkBox id=dialog-vbox1 +property name=can_focusFalse/property +property name=spacing2/property +child internal-child=action_area + object class=GtkButtonBox id=dialog-action_area1 +property name=can_focusFalse/property +property name=orientationvertical/property +property name=layout_stylestart/property +child + object class=GtkButton id=ok +property name=labelgtk-ok/property +property name=visibleTrue/property +property name=can_focusTrue/property +property name=receives_defaultTrue/property +property name=use_stockTrue/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position0/property + /packing +/child +child + object class=GtkButton id=cancel +property name=labelgtk-cancel/property +property name=visibleTrue/property +property name=can_focusTrue/property +property name=receives_defaultTrue/property +property name=use_stockTrue/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position1/property + /packing +/child +child + object class=GtkButton id=help +property name=labelgtk-help/property +property name=visibleTrue/property +property name=can_focusTrue/property +property name=receives_defaultTrue/property +property name=use_stockTrue/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position2/property + /packing +/child + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=pack_typeend/property +property name=position0/property + /packing +/child +child + object class=GtkFrame id=frame1 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=label_xalign0/property +property name=shadow_typenone/property +child + object class=GtkAlignment id=alignment1 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=left_padding12/property +child + object class=GtkBox id=box1 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=orientationvertical/property +property name=spacing6/property +child + object class=GtkSpinButton id=spinbutton1 +property name=visibleTrue/property +property name=can_focusTrue/property +property name=invisible_charâ¢/property +property name=digits2/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position0/property + /packing +/child +child + object class=GtkCheckButton id=checkbutton1 +
[Libreoffice-commits] .: 6 commits - connectivity/inc connectivity/source dbaccess/source sal/inc
connectivity/inc/connectivity/sqlnode.hxx | 11 +- connectivity/source/parse/sqlbison.y | 13 ++ connectivity/source/parse/sqlnode.cxx | 31 -- dbaccess/source/ui/dlg/sqlmessage.cxx | 11 ++ dbaccess/source/ui/inc/sqlmessage.hxx | 12 ++ dbaccess/source/ui/querydesign/QueryDesignView.cxx|8 + dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx | 89 ++ dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx |2 sal/inc/sal/log-areas.dox |1 9 files changed, 123 insertions(+), 55 deletions(-) New commits: commit d931b994a4bd2f8fe72f351a7d628a44a35f4abe Author: Lionel Elie Mamane lio...@mamane.lu Date: Wed Jan 23 16:17:39 2013 +0100 show errors as errors, not warning Change-Id: I32e514fbfbd323b688b25b9e2165d0c76e3c4db5 diff --git a/dbaccess/source/ui/dlg/sqlmessage.cxx b/dbaccess/source/ui/dlg/sqlmessage.cxx index 9c3ecc8..c46035c 100644 --- a/dbaccess/source/ui/dlg/sqlmessage.cxx +++ b/dbaccess/source/ui/dlg/sqlmessage.cxx @@ -751,7 +751,16 @@ IMPL_LINK( OSQLMessageBox, ButtonClickHdl, Button *, /*pButton*/ ) //== OSQLWarningBox::OSQLWarningBox( Window* _pParent, const OUString _rMessage, WinBits _nStyle, const ::dbtools::SQLExceptionInfo* _pAdditionalErrorInfo ) -:OSQLMessageBox( _pParent, String( ModuleRes( STR_STAT_WARNING ) ), _rMessage, _nStyle, OSQLMessageBox::Warning, _pAdditionalErrorInfo ) +:OSQLMessageBox( _pParent, String( ModuleRes( STR_EXCEPTION_WARNING ) ), _rMessage, _nStyle, OSQLMessageBox::Warning, _pAdditionalErrorInfo ) +{ +} + +//== +// OSQLErrorBox +//== +OSQLErrorBox::OSQLErrorBox( Window* _pParent, const OUString _rMessage, WinBits _nStyle, +const ::dbtools::SQLExceptionInfo* _pAdditionalErrorInfo ) +:OSQLMessageBox( _pParent, String( ModuleRes( STR_EXCEPTION_ERROR ) ), _rMessage, _nStyle, OSQLMessageBox::Error, _pAdditionalErrorInfo ) { } diff --git a/dbaccess/source/ui/inc/sqlmessage.hxx b/dbaccess/source/ui/inc/sqlmessage.hxx index da36617..76d896f 100644 --- a/dbaccess/source/ui/inc/sqlmessage.hxx +++ b/dbaccess/source/ui/inc/sqlmessage.hxx @@ -119,6 +119,18 @@ public: const ::dbtools::SQLExceptionInfo* _pAdditionalErrorInfo = NULL ); }; +//== +// OSQLErrorBox +//== +class OSQLErrorBox : public OSQLMessageBox +{ +public: +OSQLErrorBox( Window* _pParent, + const OUString _rMessage, + WinBits _nStyle = WB_OK | WB_DEF_OK, + const ::dbtools::SQLExceptionInfo* _pAdditionalErrorInfo = NULL ); +}; + //. } // namespace dbaui //. diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx index 8897a5d..342a341 100644 --- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx +++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx @@ -633,7 +633,7 @@ sal_Bool OSelectionBrowseBox::fillColumnRef(const ::rtl::OUString _sColumnName, { String sErrorMsg(ModuleRes(RID_STR_FIELD_DOESNT_EXIST)); sErrorMsg.SearchAndReplaceAscii($name$,_sColumnName); -OSQLWarningBox( this, sErrorMsg ).Execute(); +OSQLErrorBox( this, sErrorMsg ).Execute(); bError = sal_True; } else @@ -739,7 +739,8 @@ sal_Bool OSelectionBrowseBox::saveField(String _sFieldName ,OTableFieldDescRef // something different which we have to check String sErrorMessage( ModuleRes( STR_QRY_COLUMN_NOT_FOUND ) ); sErrorMessage.SearchAndReplaceAscii($name$,_sFieldName); -OSQLWarningBox( this, sErrorMessage ).Execute(); +OSQLErrorBox( this, sErrorMessage ).Execute(); + return sal_True; } @@ -895,7 +896,7 @@ sal_Bool OSelectionBrowseBox::saveField(String _sFieldName ,OTableFieldDescRef { // the field could not be inserted String sErrorMessage( ModuleRes( RID_STR_FIELD_DOESNT_EXIST ) ); sErrorMessage.SearchAndReplaceAscii($name$,aSelEntry-GetField()); -OSQLWarningBox( this, sErrorMessage ).Execute(); +OSQLErrorBox( this, sErrorMessage ).Execute(); bError = sal_True; } } commit f1bde8cb0e00770e4f9a2e1cd2458906a7ec8a63 Author: Lionel Elie Mamane lio...@mamane.lu Date: Wed Jan 23 15:36:35 2013 +0100 fix handling of subqueries in query
[Libreoffice-commits] .: sw/AllLangResTarget_sw.mk sw/source sw/uiconfig sw/UI_swriter.mk
sw/AllLangResTarget_sw.mk |1 sw/UI_swriter.mk|1 sw/source/ui/inc/rowht.hxx |8 --- sw/source/ui/table/rowht.cxx| 39 + sw/source/ui/table/rowht.hrc| 25 -- sw/source/ui/table/rowht.src| 82 sw/uiconfig/swriter/ui/rowheight.ui | 23 -- 7 files changed, 35 insertions(+), 144 deletions(-) New commits: commit 83e5a76f0e8803646de26daa736a9d3353d4ae85 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 15:16:20 2013 + convert autofit width dialog to new .ui Change-Id: I81bc6e119019f9bd4f90ae4ed77fbb65455260cd diff --git a/sw/AllLangResTarget_sw.mk b/sw/AllLangResTarget_sw.mk index 7ba3c46..9fbfa31 100644 --- a/sw/AllLangResTarget_sw.mk +++ b/sw/AllLangResTarget_sw.mk @@ -152,7 +152,6 @@ $(eval $(call gb_SrsTarget_add_files,sw/res,\ sw/source/ui/smartmenu/stmenu.src \ sw/source/ui/table/chartins.src \ sw/source/ui/table/mergetbl.src \ -sw/source/ui/table/rowht.src \ sw/source/ui/table/table.src \ sw/source/ui/table/tabledlg.src \ sw/source/ui/uiview/pview.src \ diff --git a/sw/UI_swriter.mk b/sw/UI_swriter.mk index a35b38f..d410de6 100644 --- a/sw/UI_swriter.mk +++ b/sw/UI_swriter.mk @@ -39,6 +39,7 @@ $(eval $(call gb_UI_add_uifiles,modules/swriter,\ sw/uiconfig/swriter/ui/outlinepositionpage \ sw/uiconfig/swriter/ui/printoptionspage \ sw/uiconfig/swriter/ui/printeroptions \ + sw/uiconfig/swriter/ui/rowheight \ sw/uiconfig/swriter/ui/sortdialog \ sw/uiconfig/swriter/ui/splittable \ sw/uiconfig/swriter/ui/statisticsinfopage \ diff --git a/sw/source/ui/inc/rowht.hxx b/sw/source/ui/inc/rowht.hxx index c7743f0..a84bc60 100644 --- a/sw/source/ui/inc/rowht.hxx +++ b/sw/source/ui/inc/rowht.hxx @@ -28,12 +28,8 @@ class SwWrtShell; class SwTableHeightDlg : public SvxStandardDialog { - FixedLine aHeightFL; -MetricField aHeightEdit; -CheckBoxaAutoHeightCB; -OKButtonaOKBtn; -CancelButtonaCancelBtn; -HelpButton aHelpBtn; +MetricField*m_pHeightEdit; +CheckBox* m_pAutoHeightCB; SwWrtShell rSh; protected: diff --git a/sw/source/ui/table/rowht.cxx b/sw/source/ui/table/rowht.cxx index 2b1587b..9fec8f0 100644 --- a/sw/source/ui/table/rowht.cxx +++ b/sw/source/ui/table/rowht.cxx @@ -34,18 +34,14 @@ #include usrpref.hxx #include cmdid.h -#include rowht.hrc #include table.hrc - - - void SwTableHeightDlg::Apply() { -SwTwips nHeight = static_cast SwTwips (aHeightEdit.Denormalize(aHeightEdit.GetValue(FUNIT_TWIP))); +SwTwips nHeight = static_cast SwTwips (m_pHeightEdit-Denormalize(m_pHeightEdit-GetValue(FUNIT_TWIP))); SwFmtFrmSize aSz(ATT_FIX_SIZE, 0, nHeight); -SwFrmSize eFrmSize = (SwFrmSize) aAutoHeightCB.IsChecked() ? +SwFrmSize eFrmSize = (SwFrmSize) m_pAutoHeightCB-IsChecked() ? ATT_MIN_SIZE : ATT_FIX_SIZE; if(eFrmSize != aSz.GetHeightSizeType()) { @@ -54,37 +50,28 @@ void SwTableHeightDlg::Apply() rSh.SetRowHeight( aSz ); } -// CTOR / DTOR --- - - -SwTableHeightDlg::SwTableHeightDlg( Window *pParent, SwWrtShell rS ) : - -SvxStandardDialog(pParent, SW_RES(DLG_ROW_HEIGHT)), -aHeightFL(this, SW_RES(FL_HEIGHT)), -aHeightEdit(this, SW_RES(ED_HEIGHT)), -aAutoHeightCB(this, SW_RES(CB_AUTOHEIGHT)), -aOKBtn(this, SW_RES(BT_OK)), -aCancelBtn(this, SW_RES(BT_CANCEL)), -aHelpBtn( this, SW_RES( BT_HELP ) ), -rSh( rS ) +SwTableHeightDlg::SwTableHeightDlg(Window *pParent, SwWrtShell rS) +: SvxStandardDialog(pParent, RowHeightDialog, modules/swriter/ui/rowheight.ui) +, rSh( rS ) { -FreeResource(); +get(m_pHeightEdit, heightmf); +get(m_pAutoHeightCB, fit); FieldUnit eFieldUnit = SW_MOD()-GetUsrPref( 0 != PTR_CAST( SwWebDocShell, rSh.GetView().GetDocShell() ) )-GetMetric(); -::SetFieldUnit( aHeightEdit, eFieldUnit ); +::SetFieldUnit(*m_pHeightEdit, eFieldUnit); -aHeightEdit.SetMin(MINLAY, FUNIT_TWIP); -if(!aHeightEdit.GetMin()) -aHeightEdit.SetMin(1); +m_pHeightEdit-SetMin(MINLAY, FUNIT_TWIP); +if(!m_pHeightEdit-GetMin()) +m_pHeightEdit-SetMin(1); SwFmtFrmSize *pSz; rSh.GetRowHeight( pSz ); if ( pSz ) { long nHeight = pSz-GetHeight(); -aAutoHeightCB.Check(pSz-GetHeightSizeType() != ATT_FIX_SIZE); -aHeightEdit.SetValue(aHeightEdit.Normalize(nHeight), FUNIT_TWIP); +m_pAutoHeightCB-Check(pSz-GetHeightSizeType() != ATT_FIX_SIZE); +m_pHeightEdit-SetValue(m_pHeightEdit-Normalize(nHeight), FUNIT_TWIP); delete pSz; } diff --git a/sw/source/ui/table/rowht.hrc b/sw/source/ui/table/rowht.hrc deleted file mode 100644 index cddbe4f..000 ---
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e2ed38cbfdc75a49155444643d7123dead00170f Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 15:43:19 2013 + Updated core Project: help 2d030d074953cf178778c4afa2338915d4019e91 diff --git a/helpcontent2 b/helpcontent2 index 580967f..2d030d0 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 580967fb938b22bf06f5f9488318f254f65aee85 +Subproject commit 2d030d074953cf178778c4afa2338915d4019e91 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: source/text
source/text/swriter/01/05110100.xhp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 2d030d074953cf178778c4afa2338915d4019e91 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 15:43:19 2013 + update help ids for row height dialog .ui conversion diff --git a/source/text/swriter/01/05110100.xhp b/source/text/swriter/01/05110100.xhp index aa82aa6..fc1c288 100644 --- a/source/text/swriter/01/05110100.xhp +++ b/source/text/swriter/01/05110100.xhp @@ -31,20 +31,20 @@ /history /meta body -bookmark xml-lang=en-US branch=hid/.uno:SetRowHeight id=bm_id3310623 localize=false/!-- HID added by script -- -bookmark xml-lang=en-US branch=hid/.uno:SetRowHeight id=bm_id3154653 localize=false/ +bookmark xml-lang=en-US branch=hid/.uno:SetRowHeight id=bm_id3310623 localize=false/ +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/rowheight/RowHeightDialog id=bm_id3154653 localize=false/ paragraph role=heading id=hd_id3149871 xml-lang=en-US level=1 l10n=U oldref=1Row Height/paragraph paragraph role=paragraph id=par_id3149053 xml-lang=en-US l10n=U oldref=2variable id=hoehetextahelp hid=.uno:SetRowHeightChanges the height of the selected row(s)./ahelp /variable/paragraph section id=howtoget embed href=text/swriter/00/0405.xhp#hoehez/ /section -bookmark xml-lang=en-US branch=hid/sw:MetricField:DLG_ROW_HEIGHT:ED_HEIGHT id=bm_id3145823 localize=false/ +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/rowheight/heightmf id=bm_id3145823 localize=false/ paragraph role=heading id=hd_id3155625 xml-lang=en-US level=2 l10n=U oldref=3Height/paragraph -paragraph role=paragraph id=par_id3154554 xml-lang=en-US l10n=U oldref=4ahelp hid=SW:METRICFIELD:DLG_ROW_HEIGHT:ED_HEIGHTEnter the height that you want for the selected row(s)./ahelp/paragraph -bookmark xml-lang=en-US branch=hid/sw:CheckBox:DLG_ROW_HEIGHT:CB_AUTOHEIGHT id=bm_id3150019 localize=false/ +paragraph role=paragraph id=par_id3154554 xml-lang=en-US l10n=U oldref=4ahelp hid=modules/swriter/ui/rowheight/heightmfEnter the height that you want for the selected row(s)./ahelp/paragraph +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/rowheight/fit id=bm_id3150019 localize=false/ paragraph role=heading id=hd_id3149878 xml-lang=en-US level=3 l10n=U oldref=5Fit to size/paragraph -paragraph role=paragraph id=par_id3145244 xml-lang=en-US l10n=U oldref=6ahelp hid=SW:CHECKBOX:DLG_ROW_HEIGHT:CB_AUTOHEIGHTAutomatically adjusts the row height to match the contents of the cells./ahelp/paragraph +paragraph role=paragraph id=par_id3145244 xml-lang=en-US l10n=U oldref=6ahelp hid=modules/swriter/ui/rowheight/fitAutomatically adjusts the row height to match the contents of the cells./ahelp/paragraph paragraph role=note id=par_id3154646 xml-lang=en-US l10n=CHG oldref=7You can also right-click in a cell, and then choose link href=text/swriter/01/05110200.xhp name=Row - Optimal HeightemphRow - Optimal Height/emph/link./paragraph /body /helpdocument ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Issues building LibreOffice 4.0.0.1
On 01/23/2013 08:31 AM, Henrik /KaarPoSoft wrote: However, I get a few errors while building; patch attached. What would the build failures look like without that salhelper.patch applied? It looks suspicious that you should be the only one hit by that problem, so it might just be a symptom of some other problem instead (and, e.g., git grep -Flw salhelper chart2 does not turn up any -- direct -- dependency of e.g. chart2 on salhelper at least for the recent master repo I have at hand here). Depending on what you have in /opt, your autogen.lastrun's # Pick up dependencies in /opt CPPFLAGS=-I/opt/include LDFLAGS=-L/opt/lib LD_LIBRARY_PATH=/opt/lib could be the source of lots of trouble. Also some unittests fail, which I have then disabled. Further subsequenttest also fails. And the final product fails just after showing the splash screen. Your strace lines like 9579 08:05:59.537424 openat(AT_FDCWD, /opt/kaarpux/libreoffice-4.0.0.1/lib/libreoffice/program/../program/r, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = -1 ENOENT (No such file or directory) 9579 08:05:59.537514 open(dkten-US.res, O_RDONLY) = -1 ENOENT (No such file or directory) 9579 08:05:59.537672 access(/opt/kaarpux/libreoffice-4.0.0.1/lib/libreoffice/program/../progra, F_OK) = -1 ENOENT (No such file or directory) 9579 08:05:59.537725 access(/opt/kaarpux/libreoffice-4.0.0.1/lib/libreoffice/program/unorc, F_OK) = 0 9579 08:05:59.537767 access(/opt/kaarpux/libreoffice-4.0.0.1/lib/libreoffice/program/../program/boot, F_OK) = -1 ENOENT (No such file or directory) look oddly truncated. For example, there should be a .../program/boostraprc file that soffice.bin would indeed try to open early on. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/ui/view/drawview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bdb66834887ec58cd9c602841c185a6629b13d6b Author: Noel Power noel.po...@suse.com Date: Wed Jan 23 15:25:41 2013 + don't use ScDrawLayer::GetObjDataTab to get Anchor fix for fdo#59325 Seems ScDrawLayer::GetObjDataTab was used mistakenly thinking that only an anchor for that tab would be returned ( but actually whatever anchor is returned gets the tab set ) Change-Id: I5d240f80a9974f6e4032875ed00350c94621bde7 diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx index 48a5504..e249e8c 100644 --- a/sc/source/ui/view/drawview.cxx +++ b/sc/source/ui/view/drawview.cxx @@ -756,7 +756,7 @@ void ScDrawView::SyncForGrid( SdrObject* pObj ) ScSplitPos eWhich = pViewData-GetActivePart(); ScGridWindow* pGridWin = (ScGridWindow*)pViewData-GetActiveWin(); -ScDrawObjData* pData = ScDrawLayer::GetObjDataTab( pObj, nTab ); +ScDrawObjData* pData = ScDrawLayer::GetObjData( pObj ); if ( pGridWin ) { ScAddress aOldStt; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba446dd58a4ad324d242afcd5b28d3b4dff5a881 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 16:14:32 2013 + Updated core Project: help f96ff336fd0c754564e93da04d6531721ab745b5 diff --git a/helpcontent2 b/helpcontent2 index 2d030d0..f96ff33 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2d030d074953cf178778c4afa2338915d4019e91 +Subproject commit f96ff336fd0c754564e93da04d6531721ab745b5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: source/text
source/text/shared/01/05100200.xhp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit f96ff336fd0c754564e93da04d6531721ab745b5 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 16:14:32 2013 + update help ids split cells dialog .ui conversion actually, the pre .ui ids were all wrong from some previous move of this around, so this recovers this long lost help page. diff --git a/source/text/shared/01/05100200.xhp b/source/text/shared/01/05100200.xhp index 80e6280..e971735 100644 --- a/source/text/shared/01/05100200.xhp +++ b/source/text/shared/01/05100200.xhp @@ -29,7 +29,7 @@ body section id=zellenteilen bookmark xml-lang=en-US branch=hid/.uno:SplitCell id=bm_id3525727 localize=false/ -bookmark xml-lang=en-US branch=hid/.uno:SplitCell id=bm_id3147403 localize=false/ +bookmark xml-lang=en-US branch=hid/cui/ui/splitcellsdialog/SplitCellsDialog id=bm_id3147405 localize=false/ paragraph role=heading id=hd_id3154654 xml-lang=en-US level=1 l10n=U oldref=1link href=text/shared/01/05100200.xhp name=Split CellsSplit Cells/link/paragraph paragraph role=paragraph id=par_id3083451 xml-lang=en-US l10n=U oldref=2variable id=teilentextahelp hid=.uno:SplitCellSplits the cell or group of cells horizontally or vertically into the number of cells that you enter./ahelp /variable/paragraph @@ -60,16 +60,16 @@ /section !-- removed HID SW_NUMERICFIELD_DLG_SPLIT_ED_COUNT -- paragraph role=heading id=hd_id3154558 xml-lang=en-US level=2 l10n=U oldref=3Split cell into/paragraph -paragraph role=paragraph id=par_id3150021 xml-lang=en-US l10n=U oldref=4ahelp hid=SW:NUMERICFIELD:DLG_SPLIT:ED_COUNTEnter the number of rows or columns that you want to split the selected cell(s) into./ahelp/paragraph +paragraph role=paragraph id=par_id3150021 xml-lang=en-US l10n=U oldref=4ahelp hid=cui/ui/splitcellsdialog/countnfEnter the number of rows or columns that you want to split the selected cell(s) into./ahelp/paragraph paragraph role=heading id=hd_id3145249 xml-lang=en-US level=2 l10n=U oldref=5Direction/paragraph !-- removed HID SW_IMAGERADIOBUTTON_DLG_SPLIT_RB_HORZ -- paragraph role=heading id=hd_id3150568 xml-lang=en-US level=3 l10n=U oldref=7Horizontally/paragraph -paragraph role=paragraph id=par_id3153927 xml-lang=en-US l10n=U oldref=8ahelp hid=SW:IMAGERADIOBUTTON:DLG_SPLIT:RB_HORZSplits the selected cell(s) into the number of rows that you specify in the emphSplit cell into /emphbox./ahelp/paragraph +paragraph role=paragraph id=par_id3153927 xml-lang=en-US l10n=U oldref=8ahelp hid=cui/ui/splitcellsdialog/horiSplits the selected cell(s) into the number of rows that you specify in the emphSplit cell into /emphbox./ahelp/paragraph !-- removed HID SW_CHECKBOX_DLG_SPLIT_CB_PROP -- paragraph role=heading id=hd_id3147566 xml-lang=en-US level=3 l10n=U oldref=11Into equal proportions/paragraph -paragraph role=paragraph id=par_id3154638 xml-lang=en-US l10n=CHG oldref=12ahelp hid=SW_CHECKBOX_DLG_SPLIT_CB_PROPSplits cells into rows of equal height./ahelp/paragraph +paragraph role=paragraph id=par_id3154638 xml-lang=en-US l10n=CHG oldref=12ahelp hid=cui/ui/splitcellsdialog/propSplits cells into rows of equal height./ahelp/paragraph !-- removed HID SW_IMAGERADIOBUTTON_DLG_SPLIT_RB_VERT -- paragraph role=heading id=hd_id3150765 xml-lang=en-US level=3 l10n=U oldref=9Vertically/paragraph -paragraph role=paragraph id=par_id3145410 xml-lang=en-US l10n=U oldref=10ahelp hid=SW:IMAGERADIOBUTTON:DLG_SPLIT:RB_VERTSplits the selected cell(s) into the number of columns that you specify in the emphSplit cell into /emphbox./ahelp/paragraph +paragraph role=paragraph id=par_id3145410 xml-lang=en-US l10n=U oldref=10ahelp hid=cui/ui/splitcellsdialog/vertSplits the selected cell(s) into the number of columns that you specify in the emphSplit cell into /emphbox./ahelp/paragraph /body /helpdocument ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: cui/uiconfig
cui/uiconfig/ui/splitcellsdialog.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 817d14d5fb307df4f758a646d4d94735420a80ac Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 16:17:40 2013 + set mnemonic widget for a11y and non-guessing traversal Change-Id: If7983092a3842bf1841d8a19dc1776668c17d3f3 diff --git a/cui/uiconfig/ui/splitcellsdialog.ui b/cui/uiconfig/ui/splitcellsdialog.ui index cf08eae..9ead2fd 100644 --- a/cui/uiconfig/ui/splitcellsdialog.ui +++ b/cui/uiconfig/ui/splitcellsdialog.ui @@ -113,6 +113,7 @@ property name=can_focusFalse/property property name=label translatable=yes_Split cell into/property property name=use_underlineTrue/property +property name=mnemonic_widgetcountnf/property /object packing property name=left_attach0/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: pyuno/source
pyuno/source/loader/pythonloader.py |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit c2445b03f4d27bbd7e14c4322704ce89b582839b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 23 17:58:25 2013 +0100 fdo#59728: Fix encoding of .py files as UTF-8 for Python 3 ...where it could default to something like CP 1252 instead on Windows, while keeping backwards compatibility for now with running under Python 2 (where things apparently worked well with the original code). Change-Id: I0ddd06771a36e1cd2cc2ce78abd8bd667db7778f diff --git a/pyuno/source/loader/pythonloader.py b/pyuno/source/loader/pythonloader.py index 6d8ca97..3074d0f 100644 --- a/pyuno/source/loader/pythonloader.py +++ b/pyuno/source/loader/pythonloader.py @@ -90,7 +90,10 @@ class Loader( XImplementationLoader, XServiceInfo, unohelper.Base ): # read the file filename = unohelper.fileUrlToSystemPath( url ) -fileHandle = open( filename ) +if sys.version = '3': +fileHandle = open( filename, encoding='utf_8' ) +else: +fileHandle = open( filename ) src = fileHandle.read().replace(\r,) if not src.endswith( \n ): src = src + \n ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - pyuno/source
pyuno/source/loader/pythonloader.py |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 85e7a0f6cd9b311e6734e747b03ad0a736ff6dbd Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 23 17:58:25 2013 +0100 fdo#59728: Fix encoding of .py files as UTF-8 for Python 3 ...where it could default to something like CP 1252 instead on Windows, while keeping backwards compatibility for now with running under Python 2 (where things apparently worked well with the original code). Change-Id: I0ddd06771a36e1cd2cc2ce78abd8bd667db7778f (cherry picked from commit c2445b03f4d27bbd7e14c4322704ce89b582839b) Reviewed-on: https://gerrit.libreoffice.org/1829 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/pyuno/source/loader/pythonloader.py b/pyuno/source/loader/pythonloader.py index 0330a6e..de4d630 100644 --- a/pyuno/source/loader/pythonloader.py +++ b/pyuno/source/loader/pythonloader.py @@ -90,7 +90,10 @@ class Loader( XImplementationLoader, XServiceInfo, unohelper.Base ): # read the file filename = unohelper.fileUrlToSystemPath( url ) -fileHandle = open( filename ) +if sys.version = '3': +fileHandle = open( filename, encoding='utf_8' ) +else: +fileHandle = open( filename ) src = fileHandle.read().replace(\r,) if not src.endswith( \n ): src = src + \n ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Google developer account
Hi, based on today's board decision, I have just created a Google developer account, so we can publish in the Play store. The access is tied to the info@tdf Google account, but I can grant any other Google account access as well, it seems. I propose that one of the developers on board pings me with a list of names that need access. (I'm not regularly reading this list, so please Cc me :-) Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/doc/docdesc.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit da1398c503784086ecd0a10dd8e809069d649653 Author: Michael Stahl mst...@redhat.com Date: Wed Jan 23 19:23:14 2013 +0100 fdo#59428: SwDoc::ChgPageDesc: always copy to first-pagedesc ... otherwise the first page will not be updated on page style changes. (uncovered by commit c41675a7d13dac64540ad420f905e80dbcbc023d, which should have fixed this too) Change-Id: I04f75b2a8e8929767fb36dd7085c3a273f07c93a diff --git a/sw/source/core/doc/docdesc.cxx b/sw/source/core/doc/docdesc.cxx index 37b6566..1852b4c 100644 --- a/sw/source/core/doc/docdesc.cxx +++ b/sw/source/core/doc/docdesc.cxx @@ -296,12 +296,12 @@ void SwDoc::ChgPageDesc( sal_uInt16 i, const SwPageDesc rChged ) ((SwPageDesc)rChged).Mirror(); else { -// Or else transfer values from Master to Left and First. -::lcl_DescSetAttr( ((SwPageDesc)rChged).GetMaster(), - ((SwPageDesc)rChged).GetLeft() ); -::lcl_DescSetAttr( ((SwPageDesc)rChged).GetMaster(), - ((SwPageDesc)rChged).GetFirst() ); +// Or else transfer values from Master to Left +::lcl_DescSetAttr(rChged.GetMaster(), + const_castSwPageDesc(rChged).GetLeft()); } +::lcl_DescSetAttr(rChged.GetMaster(), + const_castSwPageDesc(rChged).GetFirst()); // Take over NumType. if( rChged.GetNumType().GetNumberingType() != pDesc-GetNumType().GetNumberingType() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Where are the nightly builds for Linux?
Steven P. Ulrick wrote: http://dev-builds.libreoffice.org/daily/master/Linux-Fedora17-x86_64 Back again, sorry for the interruption. It was NOT empty when I downloaded the above referenced version. Yeah, it gets cleansed after two weeks or so. My box took an xmas break. ;) Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Google developer account
On Wed, Jan 23, 2013 at 12:56 PM, Florian Effenberger flo...@documentfoundation.org wrote: Hi, based on today's board decision, I have just created a Google developer account, so we can publish in the Play store. The access is tied to the info@tdf Google account, but I can grant any other Google account access as well, it seems. I propose that one of the developers on board pings me with a list of names that need access. (I'm not regularly reading this list, so please Cc me :-) Hi Florian, Looks like the minutes from the board meeting haven't been posted yet -- could you please give us a quick rundown of what the board has decided? (Information about Android support has arguably been *the* hottest topic on the Ask.LO site) Thanks, --R ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sd/inc sd/source vcl/source
sd/inc/stlpool.hxx |3 ++ sd/source/core/drawdoc3.cxx | 49 +--- sd/source/core/stlpool.cxx | 18 sd/source/core/stlsheet.cxx | 16 -- vcl/source/gdi/bitmapex.cxx | 18 5 files changed, 95 insertions(+), 9 deletions(-) New commits: commit f9e83484ad766fe02589daaf00d46dee63c55d43 Author: David Tardon dtar...@redhat.com Date: Thu Jan 17 15:01:32 2013 +0100 rhbz#760765 copy custom styles on copy paste Change-Id: Icaacf3bc1a02a017692432aec36aba06d3f5dde5 Signed-off-by: Thorsten Behrens tbehr...@suse.com diff --git a/sd/inc/stlpool.hxx b/sd/inc/stlpool.hxx index 9e76c2a..4833dd8 100644 --- a/sd/inc/stlpool.hxx +++ b/sd/inc/stlpool.hxx @@ -80,6 +80,8 @@ public: voidCopyGraphicSheets(SdStyleSheetPool rSourcePool); voidCopyCellSheets(SdStyleSheetPool rSourcePool); voidCopyTableStyles(SdStyleSheetPool rSourcePool); +voidCopyGraphicSheets(SdStyleSheetPool rSourcePool, SdStyleSheetVector rCreatedSheets); +voidCopyCellSheets(SdStyleSheetPool rSourcePool, SdStyleSheetVector rCreatedSheets); voidCreatePseudosIfNecessary(); voidUpdateStdNames(); @@ -121,6 +123,7 @@ public: virtual void SAL_CALL release (void) throw (); protected: void CopySheets(SdStyleSheetPool rSourcePool, SfxStyleFamily eFamily ); +void CopySheets(SdStyleSheetPool rSourcePool, SfxStyleFamily eFamily, SdStyleSheetVector rCreatedSheets ); virtual SfxStyleSheetBase* Create(const String rName, SfxStyleFamily eFamily, sal_uInt16 nMask); virtual SfxStyleSheetBase* Create(const SdStyleSheet rStyle); diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx index 9909623..e2d7039 100644 --- a/sd/source/core/drawdoc3.cxx +++ b/sd/source/core/drawdoc3.cxx @@ -357,6 +357,26 @@ sal_Bool SdDrawDocument::InsertBookmark( return bOK; } +namespace +{ + +void +lcl_removeUnusedStyles(SfxStyleSheetBasePool* const pStyleSheetPool, SdStyleSheetVector rStyles) +{ +SdStyleSheetVector aUsedStyles; +aUsedStyles.reserve(rStyles.size()); +for (SdStyleSheetVector::const_iterator aIt(rStyles.begin()), aLast(rStyles.end()); aIt != aLast; ++aIt) +{ +if ((*aIt)-IsUsed()) +aUsedStyles.push_back(*aIt); +else +pStyleSheetPool-Remove((*aIt).get()); +} +rStyles = aUsedStyles; +} + +} + sal_Bool SdDrawDocument::InsertBookmarkAsPage( const std::vectorrtl::OUString rBookmarkList, std::vectorrtl::OUString *pExchangeList,// Liste der zu verwendenen Namen @@ -484,8 +504,8 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( /** * Die tatsaechlich benoetigten Vorlagen kopieren **/ -SdStyleSheetPool* pBookmarkStyleSheetPool = -(SdStyleSheetPool*) pBookmarkDoc-GetStyleSheetPool(); +SdStyleSheetPool* pBookmarkStyleSheetPool = dynamic_castSdStyleSheetPool*(pBookmarkDoc-GetStyleSheetPool()); +SdStyleSheetPool* pStyleSheetPool = dynamic_castSdStyleSheetPool*(GetStyleSheetPool()); // Wenn Vorlagen kopiert werden muessen, dann muessen auch die // MasterPages kopiert werden! @@ -498,7 +518,7 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( SdStyleSheetVector aCreatedStyles; String layoutName = *pIter; -((SdStyleSheetPool*)GetStyleSheetPool())-CopyLayoutSheets(layoutName, *pBookmarkStyleSheetPool,aCreatedStyles); +pStyleSheetPool-CopyLayoutSheets(layoutName, *pBookmarkStyleSheetPool,aCreatedStyles); if(!aCreatedStyles.empty()) { @@ -510,6 +530,18 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( } } +// Copy styles. This unconditionally copies all styles, even those +// that are not used in any of the inserted pages. The unused styles +// are then removed at the end of the function, where we also create +// undo records for the inserted styles. +SdStyleSheetVector aNewGraphicStyles; +pStyleSheetPool-CopyGraphicSheets(*pBookmarkStyleSheetPool, aNewGraphicStyles); +SdStyleSheetVector aNewCellStyles; +pStyleSheetPool-CopyCellSheets(*pBookmarkStyleSheetPool, aNewCellStyles); + +// TODO handle undo of table styles too +pStyleSheetPool-CopyTableStyles(*pBookmarkStyleSheetPool); + /** * Dokument einfuegen **/ @@ -910,6 +942,17 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( // Make absolutely sure no double masterpages are there RemoveUnnecessaryMasterPages(NULL, sal_True, sal_True); +// remove copied styles not used on any
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sd/inc sd/source
sd/inc/stlpool.hxx |3 ++ sd/source/core/drawdoc3.cxx | 49 +--- sd/source/core/stlpool.cxx | 18 sd/source/core/stlsheet.cxx | 16 -- 4 files changed, 77 insertions(+), 9 deletions(-) New commits: commit df27ce04e76177d0885ffb1ffe632f044b8ea27d Author: David Tardon dtar...@redhat.com Date: Thu Jan 17 15:01:32 2013 +0100 rhbz#760765 copy custom styles on copy paste Change-Id: Icaacf3bc1a02a017692432aec36aba06d3f5dde5 (cherry picked from commit 24578b804007d8c3201e5ed32b8485e1725c33c1) Signed-off-by: Thorsten Behrens tbehr...@suse.com diff --git a/sd/inc/stlpool.hxx b/sd/inc/stlpool.hxx index 2a7f82a..76ec285 100644 --- a/sd/inc/stlpool.hxx +++ b/sd/inc/stlpool.hxx @@ -89,6 +89,8 @@ public: voidCopyGraphicSheets(SdStyleSheetPool rSourcePool); voidCopyCellSheets(SdStyleSheetPool rSourcePool); voidCopyTableStyles(SdStyleSheetPool rSourcePool); +voidCopyGraphicSheets(SdStyleSheetPool rSourcePool, SdStyleSheetVector rCreatedSheets); +voidCopyCellSheets(SdStyleSheetPool rSourcePool, SdStyleSheetVector rCreatedSheets); voidCreatePseudosIfNecessary(); voidUpdateStdNames(); @@ -130,6 +132,7 @@ public: virtual void SAL_CALL release (void) throw (); protected: void CopySheets(SdStyleSheetPool rSourcePool, SfxStyleFamily eFamily ); +void CopySheets(SdStyleSheetPool rSourcePool, SfxStyleFamily eFamily, SdStyleSheetVector rCreatedSheets ); virtual SfxStyleSheetBase* Create(const String rName, SfxStyleFamily eFamily, sal_uInt16 nMask); virtual SfxStyleSheetBase* Create(const SdStyleSheet rStyle); diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx index a1d0f7b..34fcbcb 100644 --- a/sd/source/core/drawdoc3.cxx +++ b/sd/source/core/drawdoc3.cxx @@ -367,6 +367,26 @@ sal_Bool SdDrawDocument::InsertBookmark( return bOK; } +namespace +{ + +void +lcl_removeUnusedStyles(SfxStyleSheetBasePool* const pStyleSheetPool, SdStyleSheetVector rStyles) +{ +SdStyleSheetVector aUsedStyles; +aUsedStyles.reserve(rStyles.size()); +for (SdStyleSheetVector::const_iterator aIt(rStyles.begin()), aLast(rStyles.end()); aIt != aLast; ++aIt) +{ +if ((*aIt)-IsUsed()) +aUsedStyles.push_back(*aIt); +else +pStyleSheetPool-Remove((*aIt).get()); +} +rStyles = aUsedStyles; +} + +} + sal_Bool SdDrawDocument::InsertBookmarkAsPage( const std::vectorrtl::OUString rBookmarkList, std::vectorrtl::OUString *pExchangeList,// Liste der zu verwendenen Namen @@ -494,8 +514,8 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( /** * Die tatsaechlich benoetigten Vorlagen kopieren **/ -SdStyleSheetPool* pBookmarkStyleSheetPool = -(SdStyleSheetPool*) pBookmarkDoc-GetStyleSheetPool(); +SdStyleSheetPool* pBookmarkStyleSheetPool = dynamic_castSdStyleSheetPool*(pBookmarkDoc-GetStyleSheetPool()); +SdStyleSheetPool* pStyleSheetPool = dynamic_castSdStyleSheetPool*(GetStyleSheetPool()); // Wenn Vorlagen kopiert werden muessen, dann muessen auch die // MasterPages kopiert werden! @@ -508,7 +528,7 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( SdStyleSheetVector aCreatedStyles; String layoutName = *pIter; -((SdStyleSheetPool*)GetStyleSheetPool())-CopyLayoutSheets(layoutName, *pBookmarkStyleSheetPool,aCreatedStyles); +pStyleSheetPool-CopyLayoutSheets(layoutName, *pBookmarkStyleSheetPool,aCreatedStyles); if(!aCreatedStyles.empty()) { @@ -520,6 +540,18 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( } } +// Copy styles. This unconditionally copies all styles, even those +// that are not used in any of the inserted pages. The unused styles +// are then removed at the end of the function, where we also create +// undo records for the inserted styles. +SdStyleSheetVector aNewGraphicStyles; +pStyleSheetPool-CopyGraphicSheets(*pBookmarkStyleSheetPool, aNewGraphicStyles); +SdStyleSheetVector aNewCellStyles; +pStyleSheetPool-CopyCellSheets(*pBookmarkStyleSheetPool, aNewCellStyles); + +// TODO handle undo of table styles too +pStyleSheetPool-CopyTableStyles(*pBookmarkStyleSheetPool); + /** * Dokument einfuegen **/ @@ -920,6 +952,17 @@ sal_Bool SdDrawDocument::InsertBookmarkAsPage( // Make absolutely sure no double masterpages are there RemoveUnnecessaryMasterPages(NULL, sal_True, sal_True); +// remove copied
Re: [REVIEW: 4-0 3-6] impress doesn't copy custom styles
David Tardon wrote: when a slide that uses custom styles is copied to another presentation, the styles are not copied, possibly breaking the slide's layout. Commit 24578b804007d8c3201e5ed32b8485e1725c33c1 fixes that. I would like to get it into 3.6 and 4.0 (AFAICS it has never worked, so it is not a regression). Oh nice!! That is a lovely fix, thanks - pushed to -4-0 and -3-6. Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice Development [ Comments in .pptx ] (Annotations Issue)
Vinaya Mandke wrote: I am a trainee and have been assigned a project to debug and correct one bug of LiBo. Hi Vinaya, this is cool - great to have you looking into that! As of now I have identified this much:- - Comments folder with comment1.xml , CommentAuthors are getting created in the PPTx So this is an FileOpen issue - I have also identified that pptx opens and is handled from ../oox/source/ppt/presentationfragmenthandler.cxx (finalizeimport) - There are handlers for Notes, Layouts etc but none for Annotations. Yeah, that sounds about right. - Furthermore I have also identified that Annotations are considered as smarttags and are not exactly treated as part of the Presentation and hence have no data structures in the SlidePersistPtr I think this is rather missing than intended - As of now I can identify whether a slide has a comment in it or not using following in presentationfragmenthandler.cxx (finalizeimport) :- OUString aCommentFragmentPath = xSlideFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE( comment ) ); if ( !aCommentFragmentPath.isEmpty() ) { ... //comment present } Yeps. Furthermore:- - ../sd/source/core/annotations have a few incomplete implementations for the Annotations (Annotations.cxx AnnotationAccess.cxx etc) - In presentationfragmenthandler there needs to another handler for comments but I am stuck on how this can be implemented. I think the implementation in sd is complete enough to have export working - at least the ODF export seems to use it, check xmloff/source/draw/sdxmlexp.cxx's SdXMLExport::exportAnnotations(). So can you please guide how should I go about solving this issue ? I did not look too deep just yet, but maybe the above ptr could get you started? Indeed you'd need to implement your own fragment handler, best start with a smaller blueprint like LayoutFragmentHandler and add all needed tokens that you'll want to consume. HTH, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 4-0] [REVIEW[ 4-0-0 ] mab fdo#59325
for some reason I don't see that gerrit mailed the list for this one https://gerrit.libreoffice.org/#/c/1828/ please review for 4-0 ( and additional 2 review cherrypick for 4-0-0 ) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Ref-counting, smart ptrs, and COW (was: Re: Cppcheck: false positive in pptx-text.cxx ?)
Eike Rathke wrote: On Sunday, 2013-01-20 19:55:17 +0100, Markus Mohrhard wrote: Someone implemented here manualy ref counting. If you want to remove the warning you can replace the raw pointer + the ref counting variable with a boost::shared_ptr. While boost::shared_ptr is of course cleaner code, for mass objects it may add a runtime performance penalty if they are passed around a lot. For example I wouldn't change formula tokens to shared_ptr ... Yeah, because of atomic counters, and because of extra memory allocations. Here's some background on various kinds of smart ptrs: http://www.boost.org/doc/libs/1_35_0/doc/html/interprocess/interprocess_smart_ptr.html As an aside, for a number of basegfx objects, copy-on-write semantics are implemented via o3tl/inc/o3tl/cow_wrapper.hxx - see e.g. basegfx/inc/basegfx/tools/b2dclipstate.hxx for a simple example. At least for vcl stuff like Bitmaps, this template could be used instead of the hand-rolled versions. Cheers, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 17f038e3ee7e6ad98bf198311ce8eb241ccfb70d Author: Andras Timar ati...@suse.com Date: Wed Jan 23 22:07:51 2013 +0100 Updated core Project: dictionaries 0aeb113339d2bdeb0cb7fe3a9a2b1ae1c3fd9367 diff --git a/dictionaries b/dictionaries index a392489..0aeb113 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit a392489288adb820663a793c38d144fea53033c2 +Subproject commit 0aeb113339d2bdeb0cb7fe3a9a2b1ae1c3fd9367 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: lt_LT/description.xml
lt_LT/description.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0aeb113339d2bdeb0cb7fe3a9a2b1ae1c3fd9367 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 22:07:51 2013 +0100 change vesrion number to 1.3 by request of maintaners, fdo#59633 Change-Id: Iffe1fc2090ce55ca4e692e54f006f1056d14c06c diff --git a/lt_LT/description.xml b/lt_LT/description.xml index bb09e03..ddfcd2e 100644 --- a/lt_LT/description.xml +++ b/lt_LT/description.xml @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=UTF-8? description xmlns=http://openoffice.org/extensions/description/2006; xmlns:d=http://openoffice.org/extensions/description/2006; xmlns:xlink=http://www.w3.org/1999/xlink; -version value=2013.01.20 / +version value=1.3 / identifier value=org.openoffice.lt.hunspell.dictionaries / display-name name lang=en-USLithuanian spelling dictionary, and hyphenation rules/name ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 685e5b185e0772a9bae9f67c9c281fd1cc6e7019 Author: Andras Timar ati...@suse.com Date: Wed Jan 23 22:07:51 2013 +0100 Updated core Project: dictionaries 840f170138e5dd2237bb7170916ae305bb2536ad diff --git a/dictionaries b/dictionaries index fbc8cbe..840f170 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit fbc8cbe4fbf87a4e55a081261d94a31b213763fe +Subproject commit 840f170138e5dd2237bb7170916ae305bb2536ad ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - lt_LT/description.xml
lt_LT/description.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 840f170138e5dd2237bb7170916ae305bb2536ad Author: Andras Timar ati...@suse.com Date: Wed Jan 23 22:07:51 2013 +0100 change vesrion number to 1.3 by request of maintaners, fdo#59633 Change-Id: Iffe1fc2090ce55ca4e692e54f006f1056d14c06c Signed-off-by: Andras Timar ati...@suse.com diff --git a/lt_LT/description.xml b/lt_LT/description.xml index bb09e03..ddfcd2e 100644 --- a/lt_LT/description.xml +++ b/lt_LT/description.xml @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=UTF-8? description xmlns=http://openoffice.org/extensions/description/2006; xmlns:d=http://openoffice.org/extensions/description/2006; xmlns:xlink=http://www.w3.org/1999/xlink; -version value=2013.01.20 / +version value=1.3 / identifier value=org.openoffice.lt.hunspell.dictionaries / display-name name lang=en-USLithuanian spelling dictionary, and hyphenation rules/name ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2556007cd86f12edc2c4abcf35ae743418548479 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 21:13:29 2013 + Updated core Project: help a7662a33f70582067dd9dc303ec7228a28f36a12 diff --git a/helpcontent2 b/helpcontent2 index f96ff33..a7662a3 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit f96ff336fd0c754564e93da04d6531721ab745b5 +Subproject commit a7662a33f70582067dd9dc303ec7228a28f36a12 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: source/text
source/text/swriter/01/0606.xhp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit a7662a33f70582067dd9dc303ec7228a28f36a12 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 21:13:29 2013 + update help ids for outline numbering dialog .ui conversion diff --git a/source/text/swriter/01/0606.xhp b/source/text/swriter/01/0606.xhp index 9e72f13..f7999f2 100644 --- a/source/text/swriter/01/0606.xhp +++ b/source/text/swriter/01/0606.xhp @@ -30,7 +30,7 @@ /meta body bookmark xml-lang=en-US branch=hid/.uno:ChapterNumberingDialog id=bm_id6638326 localize=false/ -bookmark xml-lang=en-US branch=hid/.uno:ChapterNumberingDialog id=bm_id3154501 localize=false/paragraph role=heading id=hd_id3154561 xml-lang=en-US level=1 l10n=U oldref=1Outline Numbering/paragraph +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/outlinenumbering/OutlineNumberingDialog id=bm_id6154506 localize=false/paragraph role=heading id=hd_id3154561 xml-lang=en-US level=1 l10n=U oldref=1Outline Numbering/paragraph paragraph role=paragraph id=par_id3145246 xml-lang=en-US l10n=U oldref=2variable id=kapnumahelp hid=.uno:ChapterNumberingDialogSpecifies the number format and the hierarchy for chapter numbering in the current document./ahelp /variable/paragraph section id=howtoget @@ -42,13 +42,13 @@ emphField Shadings/emph./paragraph embed href=text/swriter/01/06060100.xhp#numerierung/ embed href=text/shared/01/06050600.xhp#position_s/ -bookmark xml-lang=en-US branch=hid/SW_HID_OUTLINE_FORM id=bm_id3147506 localize=false/paragraph role=heading id=hd_id3151168 xml-lang=en-US level=2 l10n=U oldref=56Format/paragraph -paragraph role=paragraph id=par_id3147512 xml-lang=en-US l10n=U oldref=57ahelp hid=HID_OUTLINE_FORMSaves or loads an outline number format. A saved outline number format is available to all text documents./ahelp/paragraph +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/outlinenumbering/user id=bm_id3147506 localize=false/paragraph role=heading id=hd_id3151168 xml-lang=en-US level=2 l10n=U oldref=56Format/paragraph +paragraph role=paragraph id=par_id3147512 xml-lang=en-US l10n=U oldref=57ahelp hid=modules/swriter/ui/outlinenumbering/userSaves or loads an outline number format. A saved outline number format is available to all text documents./ahelp/paragraph paragraph role=note id=par_id3150979 xml-lang=en-US l10n=U oldref=58The emphFormat/emph button is only available for outline numbering. For numbered or bulleted list styles, modify the Numbering Styles of the paragraphs./paragraph -bookmark xml-lang=en-US branch=hid/SW_HID_NUM_OUTL_NAMED_NUMS id=bm_id3154474 localize=false/paragraph role=heading id=hd_id3154572 xml-lang=en-US level=3 l10n=U oldref=59Untitled 1 - 9/paragraph -paragraph role=paragraph id=par_id3150350 xml-lang=en-US l10n=U oldref=60ahelp hid=HID_NUM_OUTL_NAMED_NUMSSelect the predefined numbering style that you want to assign to the selected outline level./ahelp/paragraph -bookmark xml-lang=en-US branch=hid/SW_HID_NUM_OUTL_NUM_SAVEAS id=bm_id3152958 localize=false/paragraph role=heading id=hd_id3153675 xml-lang=en-US level=3 l10n=U oldref=61Save As/paragraph -paragraph role=paragraph id=par_id3155892 xml-lang=en-US l10n=U oldref=62ahelp hid=HID_NUM_OUTL_NUM_SAVEASOpens a dialog where you can save the current settings for the selected outline level. You can then load these settings from another document./ahelp/paragraph +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/outlinenumbering/form1 id=bm_id3154474 localize=false/paragraph role=heading id=hd_id3154572 xml-lang=en-US level=3 l10n=U oldref=59Untitled 1 - 9/paragraph +paragraph role=paragraph id=par_id3150350 xml-lang=en-US l10n=U oldref=60ahelp hid=modules/swriter/ui/outlinenumbering/form1Select the predefined numbering style that you want to assign to the selected outline level./ahelp/paragraph +bookmark xml-lang=en-US branch=hid/modules/swriter/ui/outlinenumbering/saveas id=bm_id3152958 localize=false/paragraph role=heading id=hd_id3153675 xml-lang=en-US level=3 l10n=U oldref=61Save As/paragraph +paragraph role=paragraph id=par_id3155892 xml-lang=en-US l10n=U oldref=62ahelp hid=modules/swriter/ui/outlinenumbering/saveasOpens a dialog where you can save the current settings for the selected outline level. You can then load these settings from another document./ahelp/paragraph bookmark xml-lang=en-US branch=hid/sw:Edit:DLG_NUM_NAMES:ED_FORM id=bm_id3154191 localize=false/ bookmark xml-lang=en-US branch=hid/sw:ListBox:DLG_NUM_NAMES:LB_FORM id=bm_id3154194 localize=false/paragraph role=heading id=hd_id3149689 xml-lang=en-US level=3 l10n=U oldref=63Save As/paragraph paragraph role=paragraph id=par_id3154200 xml-lang=en-US l10n=U oldref=64ahelp hid=SW:LISTBOX:DLG_NUM_NAMES:LB_FORMClick a numbering style in the list, and then enter a name for the style. The numbers correspond to the outline level that the styles
[Libreoffice-commits] .: sw/source
sw/source/ui/misc/outline.cxx |8 1 file changed, 8 insertions(+) New commits: commit c3ea61ab29648bf93b3b4f809c7e98c40c1113f8 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 21:14:53 2013 + set all format-untitled X menu entries to the same helpid Change-Id: I1d112948f6e0595329f44e34d8d1cba37ae8fd6e diff --git a/sw/source/ui/misc/outline.cxx b/sw/source/ui/misc/outline.cxx index a5d1142..5038025 100644 --- a/sw/source/ui/misc/outline.cxx +++ b/sw/source/ui/misc/outline.cxx @@ -244,6 +244,14 @@ IMPL_LINK( SwOutlineTabDialog, FormHdl, Button *, pBtn ) if( pRules ) pFormMenu-SetItemText(pFormMenu-GetItemId(i), pRules-GetName()); } + +OString sHelpId(pFormMenu-GetHelpId(pFormMenu-GetItemId(form1))); +for (sal_Int32 i = 2; i = 9; ++i) +{ +OString sForm(form); +pFormMenu-SetHelpId(pFormMenu-GetItemId(sForm + OString::valueOf(i)), sHelpId); +} + pFormMenu-SetSelectHdl(LINK(this, SwOutlineTabDialog, MenuSelectHdl)); pFormMenu-Execute(pBtn, Rectangle(Point(0,0), pBtn-GetSizePixel()), POPUPMENU_EXECUTE_DOWN); return 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Tinderbox failure, Win-x86@6, MASTER, last success: 2013-01-23 14:20:35
On Wednesday 23 of January 2013, Andras Timar wrote: On 2013.01.23. 16:24, Tinderbox wrote: checking for a x64 compiler and libraries for 64-bit Explorer extensions... found So we set BUILD_X64 to TRUE. Later we will need 64-bit CRT files for these extensions. configure: error: Failed to copy x64 merge modules Error running configure at ./autogen.sh line 201. Configure did not find MSM file 64-bit CRT. Did you have it? microsoft_vc100_crt_x86_x64.msm No, it is not there. There is only Microsoft_VC100_CRT_x64.msm and Microsoft_VC100_CRT_x86.msm . Are you sure it should be _x86_x64? Also, you changed the warning to an error, but given the vague log message, I don't know if that's right or a mistake. Before my patch the 64-bit MSM file name was wrong in configure, therefore it was not copied to solver, and installer creation failed. Also it did not work in VC90 case. So why is this not said in the commit log message? As it is, there was no way to find out what your commit was actually about, other than the obvious. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/source
sc/source/ui/view/drawview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a6433b4a9c053b7088d52b216c7d7cf8d9cdfcd7 Author: Noel Power noel.po...@suse.com Date: Wed Jan 23 15:25:41 2013 + don't use ScDrawLayer::GetObjDataTab to get Anchor fix for fdo#59325 Seems ScDrawLayer::GetObjDataTab was used mistakenly thinking that only an anchor for that tab would be returned ( but actually whatever anchor is returned gets the tab set ) Change-Id: I5d240f80a9974f6e4032875ed00350c94621bde7 Reviewed-on: https://gerrit.libreoffice.org/1828 Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx index 2c13e34..6900932 100644 --- a/sc/source/ui/view/drawview.cxx +++ b/sc/source/ui/view/drawview.cxx @@ -765,7 +765,7 @@ void ScDrawView::SyncForGrid( SdrObject* pObj ) ScSplitPos eWhich = pViewData-GetActivePart(); ScGridWindow* pGridWin = (ScGridWindow*)pViewData-GetActiveWin(); -ScDrawObjData* pData = ScDrawLayer::GetObjDataTab( pObj, nTab ); +ScDrawObjData* pData = ScDrawLayer::GetObjData( pObj ); if ( pGridWin ) { ScAddress aOldStt; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: vm2/gerrit configuration deployed
On Wed, Jan 23, 2013 at 4:41 AM, Florian Effenberger flo...@documentfoundation.org wrote: Hello, some of you know that I'm working heavily on creating a new master configuration for all TDF machines, including some self-written deployment scripts that will eventually be migrated to either Puppet or SALT. As I'm done some parts now, I've deployed the current configuration to vm2, which hosts gerrit. The configuration includes a base setup as well as Postfix+amavis+SpamAssassin+ClamAV+DKIM+SPF, so vm2 can now be considered in a consistent and stable state. I did not touch Apache, nor did I touch anything gerrit-related, so everything should work as expected. Just in case, I wanted to let you know, so if you discover some oddities, please feel free to poke hostmas...@documentfoundation.org It seem that the mail system is rejecting some of gerrit's outgoing email... an overzealous spam filter maybe ? [2013-01-23 09:12:33,412] ERROR com.google.gerrit.server.git.MergeOp : Cannot send email for submitted patch set 1814 com.google.gerrit.server.mail.EmailException: Server localhost rejected body at com.google.gerrit.server.mail.SmtpEmailSender.send(SmtpEmailSender.java:185) at com.google.gerrit.server.mail.OutgoingEmail.send(OutgoingEmail.java:125) at com.google.gerrit.server.git.MergeOp$8.run(MergeOp.java:1527) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at com.google.gerrit.server.util.RequestScopePropagator$5.call(RequestScopePropagator.java:196) at com.google.gerrit.server.util.RequestScopePropagator$4.call(RequestScopePropagator.java:174) at com.google.inject.servlet.ServletScopes$3.call(ServletScopes.java:194) at com.google.gerrit.server.util.RequestScopePropagator$1.call(RequestScopePropagator.java:81) at com.google.gerrit.server.util.RequestScopePropagator$3.run(RequestScopePropagator.java:146) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:337) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: formula/inc sc/inc sc/source
formula/inc/formula/token.hxx |3 ++ sc/inc/cell.hxx |8 ++ sc/inc/formularesult.hxx |4 ++- sc/inc/token.hxx | 45 +- sc/source/core/data/cell.cxx |8 +++--- sc/source/core/data/cell2.cxx |9 +- sc/source/core/tool/cellform.cxx |2 + sc/source/core/tool/formularesult.cxx | 19 -- sc/source/core/tool/token.cxx |8 +++--- sc/source/filter/xml/xmlcelli.cxx | 14 +++--- 10 files changed, 86 insertions(+), 34 deletions(-) New commits: commit ae516fabd96a948b62c4d3a522555fc955750c3e Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Jan 24 00:32:41 2013 +0100 import inherited number formats with cached values, fdo#59724 Change-Id: I698f60daf4e591b57d8d99c130d2e524dc10c306 diff --git a/formula/inc/formula/token.hxx b/formula/inc/formula/token.hxx index b72234e..3a174d7 100644 --- a/formula/inc/formula/token.hxx +++ b/formula/inc/formula/token.hxx @@ -58,6 +58,9 @@ enum StackVarEnum // and/or string result and a formula // string to be compiled. +svHybridValueCell, // A temporary formula cell with an value +// and possibily a string representation + svExternalSingleRef, svExternalDoubleRef, svExternalName, diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx index 716b76f..d146a98 100644 --- a/sc/inc/cell.hxx +++ b/sc/inc/cell.hxx @@ -430,6 +430,7 @@ public: // display as empty string if formula::svEmptyCell result boolIsEmptyDisplayedAsString(); boolIsValue(); // also true if formula::svEmptyCell +boolIsHybridValueCell(); // for cells after import to deal with inherited number formats double GetValue(); double GetValueAlways(); // ignore errors rtl::OUString GetString(); @@ -493,6 +494,13 @@ public: const formula::FormulaGrammar::Grammar eGrammar ) { aResult.SetHybridFormula( r); eTempGrammar = eGrammar; } +/** + * For import only: use for formula cells that return a number + * formatted as some kind of string + */ +void SetHybridValueString( double nVal, const OUString r ) +{ aResult.SetHybridValueString( nVal, r ); } + void SetResultMatrix( SCCOL nCols, SCROW nRows, const ScConstMatrixRef pMat, formula::FormulaToken* pUL ) { aResult.SetMatrix(nCols, nRows, pMat, pUL); diff --git a/sc/inc/formularesult.hxx b/sc/inc/formularesult.hxx index 2128636..673bcdb 100644 --- a/sc/inc/formularesult.hxx +++ b/sc/inc/formularesult.hxx @@ -162,7 +162,7 @@ public: ScConstMatrixRef GetMatrix() const; /** Return formula string if type formula::svHybridCell, else empty string. */ -const String GetHybridFormula() const; +const OUString GetHybridFormula() const; /** Should only be used by import filters, best in the order SetHybridDouble(), SetHybridString(), or only SetHybridString() for @@ -179,6 +179,8 @@ public: SetHybridFormula() for formula string to be compiled later. */ SC_DLLPUBLIC void SetHybridFormula( const String rFormula ); +void SetHybridValueString( double nVal, const OUString rStr ); + SC_DLLPUBLIC void SetMatrix( SCCOL nCols, SCROW nRows, const ScConstMatrixRef pMat, formula::FormulaToken* pUL ); /** Get the const ScMatrixFormulaCellToken* if token is of that type, else diff --git a/sc/inc/token.hxx b/sc/inc/token.hxx index e08db6c..a540555 100644 --- a/sc/inc/token.hxx +++ b/sc/inc/token.hxx @@ -414,26 +414,37 @@ public: class SC_DLLPUBLIC ScHybridCellToken : public ScToken { private: -double fDouble; -String aString; -String aFormula; +double mfDouble; +String maString; +OUString maFormula; public: -ScHybridCellToken( double f, -const String rStr, -const String rFormula ) : -ScToken( formula::svHybridCell ), -fDouble( f ), aString( rStr ), -aFormula( rFormula ) {} -ScHybridCellToken( const ScHybridCellToken r ) : -ScToken( r ), fDouble( r.fDouble), -aString( r.aString), aFormula( r.aFormula) {} -const String GetFormula() const { return aFormula; } -virtual double GetDouble() const; -virtual const String GetString() const; -virtual booloperator==( const
[Libreoffice-commits] .: configure.ac
configure.ac |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 774dd42dd11142371e21c6842b53d72c13c2d0ef Author: Peter Foley pefol...@verizon.net Date: Wed Jan 23 19:12:37 2013 -0500 fix MSM name for x64 Change-Id: Idc81352de3d2a9550457e8f56fd819c0296fd2a8 diff --git a/configure.ac b/configure.ac index d2810fd..d8ef0d5 100644 --- a/configure.ac +++ b/configure.ac @@ -4967,8 +4967,8 @@ find_msms() fi if test $BUILD_X64 = TRUE; then -if test -e $msmdir/Microsoft_VC${VCVER}_CRT_x86_x64.msm; then -msms=$msms Microsoft_VC${VCVER}_CRT_x86_x64.msm +if test -e $msmdir/Microsoft_VC${VCVER}_CRT_x64.msm; then +msms=$msms Microsoft_VC${VCVER}_CRT_x64.msm else AC_MSG_ERROR([Failed to copy x64 merge modules]) fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/qa sc/source
sc/qa/unit/subsequent_filters-test.cxx |4 ++-- sc/source/core/tool/formularesult.cxx |6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) New commits: commit b1d0fd4f969976e2133f8eaa37c1fb8360c20f68 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Jan 24 01:18:59 2013 +0100 small improvement of the code Change-Id: I2ac599fa2897dc4fe3256b50300cb467c647e320 diff --git a/sc/source/core/tool/formularesult.cxx b/sc/source/core/tool/formularesult.cxx index 9139c9a..9602c44 100644 --- a/sc/source/core/tool/formularesult.cxx +++ b/sc/source/core/tool/formularesult.cxx @@ -268,9 +268,8 @@ bool ScFormulaResult::IsEmptyDisplayedAsString() const bool ScFormulaResult::IsValue() const { formula::StackVar sv = GetCellResultType(); -if( sv == formula::svHybridValueCell ) -return true; -return sv == formula::svDouble || sv == formula::svError || sv == formula::svEmptyCell; +return sv == formula::svDouble || sv == formula::svError +|| sv == formula::svEmptyCell || sv == formula::svHybridValueCell; } bool ScFormulaResult::IsMultiline() const @@ -335,7 +334,6 @@ double ScFormulaResult::GetDouble() const case formula::svHybridCell: case formula::svHybridValueCell: return mpToken-GetDouble(); -return mpToken-GetDouble(); case formula::svMatrixCell: { const ScMatrixCellResultToken* p = commit 0ab1b83271e8e0d1ee9fa2ade4bd1dda63c5f5f3 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu Jan 24 01:18:25 2013 +0100 disable these two tests for now Change-Id: I579694780b64e532b0e61017783bc4e72f8d2936 diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx index 72dabde..d934ce9 100644 --- a/sc/qa/unit/subsequent_filters-test.cxx +++ b/sc/qa/unit/subsequent_filters-test.cxx @@ -184,8 +184,8 @@ public: CPPUNIT_TEST(testHardRecalcODS); CPPUNIT_TEST(testFunctionsODS); CPPUNIT_TEST(testCachedFormulaResultsODS); -CPPUNIT_TEST(testVolatileFunctionsODS); -CPPUNIT_TEST(testCachedMatrixFormulaResultsODS); +//CPPUNIT_TEST(testVolatileFunctionsODS); +//CPPUNIT_TEST(testCachedMatrixFormulaResultsODS); CPPUNIT_TEST(testDatabaseRangesODS); CPPUNIT_TEST(testDatabaseRangesXLS); CPPUNIT_TEST(testDatabaseRangesXLSX); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sc/inc sc/source xmloff/source
sc/inc/unonames.hxx |1 + sc/source/ui/unoobj/chart2uno.cxx |8 +++- xmloff/source/chart/SchXMLTools.cxx | 30 +- 3 files changed, 33 insertions(+), 6 deletions(-) New commits: commit 043e30baedb42dbc8799003ea2ae7987a97871ca Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Wed Jan 23 22:18:05 2013 -0500 fdo#58562: Ensure internal data is always used when pasting to another doc. Without this, pasting a chart object from one Calc doc to another may occasionally incorrectly switch to range references *if* the destination document contains the right set of sheet names. With this fix, pasted chart objects always switch to internal cached data source when pasting to another document, while retaining range references when pasting within the same document. Change-Id: If1dbc854c5faae62f06ece155fad470b229ca0c7 diff --git a/sc/inc/unonames.hxx b/sc/inc/unonames.hxx index ca89837..9ab1856 100644 --- a/sc/inc/unonames.hxx +++ b/sc/inc/unonames.hxx @@ -652,6 +652,7 @@ #define SC_UNONAME_HIDDENVALUES HiddenValues #define SC_UNONAME_INCLUDEHIDDENCELLS IncludeHiddenCells #define SC_UNONAME_HIDDENVALUES HiddenValues +#define SC_UNONAME_USE_INTERNAL_DATA_PROVIDER UseInternalDataProvider // Solver #define SC_UNONAME_TIMEOUT Timeout diff --git a/sc/source/ui/unoobj/chart2uno.cxx b/sc/source/ui/unoobj/chart2uno.cxx index 5c2dc07..cd94ab9 100644 --- a/sc/source/ui/unoobj/chart2uno.cxx +++ b/sc/source/ui/unoobj/chart2uno.cxx @@ -77,7 +77,8 @@ const SfxItemPropertyMapEntry* lcl_GetDataProviderPropertyMap() { static SfxItemPropertyMapEntry aDataProviderPropertyMap_Impl[] = { -{MAP_CHAR_LEN(SC_UNONAME_INCLUDEHIDDENCELLS), 0, getBooleanCppuType(), 0, 0 }, +{ MAP_CHAR_LEN(SC_UNONAME_INCLUDEHIDDENCELLS), 0, getBooleanCppuType(), 0, 0 }, +{ MAP_CHAR_LEN(SC_UNONAME_USE_INTERNAL_DATA_PROVIDER), 0, getBooleanCppuType(), 0, 0 }, {0,0,0,0,0,0} }; return aDataProviderPropertyMap_Impl; @@ -2326,6 +2327,11 @@ uno::Any SAL_CALL ScChart2DataProvider::getPropertyValue( uno::Any aRet; if ( rPropertyName == SC_UNONAME_INCLUDEHIDDENCELLS ) aRet = m_bIncludeHiddenCells; +else if (rPropertyName == SC_UNONAME_USE_INTERNAL_DATA_PROVIDER) +{ +// This is a read-only property. +aRet = static_castsal_Bool(m_pDocument-PastingDrawFromOtherDoc()); +} else throw beans::UnknownPropertyException(); return aRet; diff --git a/xmloff/source/chart/SchXMLTools.cxx b/xmloff/source/chart/SchXMLTools.cxx index db3a7f8..2e469a4 100644 --- a/xmloff/source/chart/SchXMLTools.cxx +++ b/xmloff/source/chart/SchXMLTools.cxx @@ -377,14 +377,34 @@ Reference chart2::data::XDataSequence CreateDataSequence( return xRet; } -try +bool bUseInternal = false; +uno::Referencebeans::XPropertySet xPropSet(xDataProvider, uno::UNO_QUERY); +if (xPropSet.is()) { -xRet.set( xDataProvider-createDataSequenceByRangeRepresentation( lcl_ConvertRange( rRange, xDataProvider ))); -SchXMLTools::setXMLRangePropertyAtDataSequence( xRet, rRange ); +try +{ +sal_Bool bVal; +uno::Any any = xPropSet-getPropertyValue(UseInternalDataProvider); +if (any = bVal) +bUseInternal = static_castbool(bVal); +} +catch (const beans::UnknownPropertyException) +{ +// Do nothing +} } -catch( const lang::IllegalArgumentException ) + +if (!bUseInternal) { -OSL_FAIL( could not create data sequence ); +try +{ +xRet.set( xDataProvider-createDataSequenceByRangeRepresentation( lcl_ConvertRange( rRange, xDataProvider ))); +SchXMLTools::setXMLRangePropertyAtDataSequence( xRet, rRange ); +} +catch( const lang::IllegalArgumentException ) +{ +OSL_FAIL( could not create data sequence ); +} } if( !xRet.is() !xChartDoc-hasInternalDataProvider() !rRange.isEmpty() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Attach Help Content to Help Button
Hi All, I've made a help button for Impress (Insert - Animated Image), and I think I've found the correct help file http://opengrok.libreoffice.org/xref/help/source/text/simpress/01/0313.xhp I'm not sure how I link the help button to the help content. If someone could assist me that would be great. Thanks all Best Regards, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Is there a guideline on reviewing patches?
Hi, I am currently doing code review through the website at https://gerrit.libreoffice.org without being download the source code to compile, and then test run. I would like to know how could I download the patches in order for me to test at least one round on my local PC so that I could ensure the code is something what we want it to fix. But if something weird happen, how could I revert the patches code? THanks @! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Attach Help Content to Help Button
Hi Joel, On Thu, Jan 24, 2013 at 6:08 AM, Joel Madero jmadero@gmail.com wrote: Hi All, I've made a help button for Impress (Insert - Animated Image), and I think I've found the correct help file http://opengrok.libreoffice.org/xref/help/source/text/simpress/01/0313.xhp I'm not sure how I link the help button to the help content. If someone could assist me that would be great. Thanks all You need to insert a bookmark into the xhp file. For example: bookmark xml-lang=en-US branch=hid/sw:CheckBox:DLG_GLOSSARY:CB_INSERT_TIP id=bm_id3152778 localize=false/ You can find out what to write into the branch attribute, when you press the Help button and the corresponding empty page opens in WikiHelp. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Duplicate code? Call for #define xxx_PAGETYPE_xxx
Hi, I had a look at cui/source/tabpages/tpline.cxx and found two identical blocks in sal_Bool SvxLineTabPage::FillItemSet( SfxItemSet rAttrs ) around lines 767 and 871. Could someone confirm (and maybe explain) that this is intentional. And code like if( nDlgType != 0 || nPageType != 3 ) is difficult to read. There are constants defined in source/tabpages/numpages.cxx, e.g. #define NUM_PAGETYPE_BULLET 0 but I don't know if those match the ones used in tpline.cxx. Anybody who is knowing what is going on here willing to spend some #defines or clearify if those from numpages.cxx are valid? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[ANN] LibreOffice 4.0.0 RC2 test builds available
Hi *, for the upcoming new version 4.0.0, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 4.0.0, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#4.0_release Builds are now being uploaded to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try report *critical* bugs not yet in bugzilla here, so we can incorporate them into the release notes. Please note that it takes approximately 24 hours to populate the mirrors, so that's about the time we have to collect feedback. NOTE: This build is in a release configuration and _will_ replace your existing LibreOffice install on Windows. The list of fixed bugs relative to 4.0.0 RC1 is here: http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-0-0-release-4.0.0.2.log So playing with the areas touched there also greatly appreciated - and validation that those bugs are really fixed. Thanks a lot for your help, Fridrich ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] how to Build a locale with my own *.po
I have my own source(*.po) for a certain locale. Is it ok if I just put the source to the translation modules and rebuild the source to get my own build? 2013-01-23 jinl...@nfs.iscas.ac.cn ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] how to Build a locale with my own *.po
Hi, On Wed, Jan 23, 2013 at 8:54 AM, jinl...@nfs.iscas.ac.cn jinl...@nfs.iscas.ac.cn wrote: I have my own source(*.po) for a certain locale. Is it ok if I just put the source to the translation modules and rebuild the source to get my own build? You need to configure --with-lang=xxx, where xxx is your language code. Also make sure that you have your language code in solenv/inc/langlist.mk Best regards, Andras ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Minutes - QA Call 01/11/2013
On Tue, 2013-01-22 at 07:52 -0800, Joel Madero wrote: There are quite a few issues with these new rules, mostly due to limitations with FDO but also because of situations we hadn't considered. All of this will be discussed on Friday and we'll hopefully have a final procedure down. One of the main issues is that FDO doesn't allow you to go from RESOLVED - WORKSFORME back to UNCONFIRMED. I see. This is quite a large problem as our QA team is using WFM quite a bit more these days as we work through UNCONFIRMED bugs but then a user says no no no it's still a problem! and then opens it back up as REOPENED, this is incorrect as REOPENED should only be used when a developer is assigned We could reconsider this statement. A bug in the state REOPENED might need triage as well. It is sometimes reopened a year after it is fixed because another user sees a similar problem. Sometimes it is better to open separate bug to solve the other problem and do not mess the original bugreport. Once the bug is triagged, we could move it to the state NEW as usual. Of course, the assigned or CCd developers might touch the reopened bug even before the QA team. This usually happen when the bug is reopened immediately after it is marked as FIXED. It is perfectly fine. Bug triagers do great job when preparing bugs for developers but it does not mean that developers could fix only triaged bugs ;-) and has said a patch fixed something and then a user says no that patch didn't fix my problem. Any bug that is unassigned but set to REOPENED is incorrectly marked -- and we're discussing how to handle these. This being said, there may be two options: 1) Ask Tollef to enable us to use UNVERIFIED after a bug is set to REOPENED Heh, I newer knew how to move bug back to UNCONFIRMED :-) IMHO, it should be easier. I am not sure what is the idea behind the current behavior. Please, add me into CC if you open a bug for this. 2) Ask use to change to NEEDINFO and then to UNVERIFIED - hassle It is not intuitive and confusing, so I would prefer to avoid it. 3) Something else that I haven't thought about A solution would be to reconsider the REOPENED bugs meaning as explained above :-) Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Story Tip: The Top 50 Proprietary Programs that Drive You Crazy -- and Their Open Source Alternatives
Dear owner of http://blog.documentfoundation.org, Hello, my name is Jimmy Atkinson, and I'm the webmaster of WHdb.com, the Web Hosting Database. Earlier today, we published a feature list of 50 popular proprietary computer programs and their open source alternatives. We thought that you and your site's visitors might be interested in having a look. Check it out: http://whdb.com/blog/2008/the-top-50-proprietary-programs-that-drive-you-crazy-and-their-open-source-alternatives/ We would appreciate if you could link to our article if you find it of interest. Please feel free to e-mail me with any questions or suggestions for the list. Thanks, Jimmy Atkinson WHdb.com: Web Hosting Database P.S. If you would prefer to never hear from me again, please let me know in a reply to this e-mail. WHdb.com. 16 N Marengo Ave Ste 317, Pasadena CA 91101___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Story Tip: The Top 50 Proprietary Programs that Drive You Crazy -- and Their Open Source Alternatives
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Jimmy, I looked over your article. But LibreOffice is absent in your list. So if the document foundation would link to you, I'm not somebody who can say anything about that, then I think we should at least be named. Please remember that Apache OpenOffice is a different product, managed by Apache. - -- Greetings, Rob Snelders Op 23-01-13 18:53, Jimmy Atkinson schreef: Dear owner of http://blog.documentfoundation.org, Hello, my name is Jimmy Atkinson, and I'm the webmaster of WHdb.com, the Web Hosting Database. Earlier today, we published a feature list of 50 popular proprietary computer programs and their open source alternatives. We thought that you and your site's visitors might be interested in having a look. Check it out: http://whdb.com/blog/2008/the-top-50-proprietary-programs-that-drive-you-crazy-and-their-open-source-alternatives/ We would appreciate if you could link to our article if you find it of interest. Please feel free to e-mail me with any questions or suggestions for the list. Thanks, Jimmy Atkinson WHdb.com: Web Hosting Database P.S. If you would prefer to never hear from me again, please let me know in a reply to this e-mail. WHdb.com. 16 N Marengo Ave Ste 317, Pasadena CA 91101 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRAEzDAAoJEGs78UIq7mKy0uAIAIMNrGOz1gtsdJtIbDp0NssW U5rBb07FW4eVNIv8oYnFKbKo0AHetrvcUZUytJkybCY/GE1gOtbu+U5oZAUuDO3C MQJpd12zNfCBYmrkagLQsJJYTZlnX9QYdq0x5dbn62aO7ssY8u39PlLmJJk8ah0q 346l1SDRQEt3V6LSUDKWLHUcInHZrqgaX9myRrdkQuhedK9SD/dtvWmWkmbNjlkQ cK9851YegFiqwVNZ8ej5D+MmIkLMnvbE/x5AoThbFPiSy4Qwl+BFMnrpAY6cmqFJ VCeVqmwNtEG0Gz/NGAyrYBMhfLY5PY/TPIysbAlmSmdn40fOkJNe6CeItKNkjGE= =zHGN -END PGP SIGNATURE- ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 48871] UI: [ES] error ortografico (typo in spanish localisation)
https://bugs.freedesktop.org/show_bug.cgi?id=48871 Fitoschido fitosch...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |fitosch...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59728] Python 3 loads utf-8 encoded files as CP-1252 encoded files
https://bugs.freedesktop.org/show_bug.cgi?id=59728 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||aniste...@gmail.com, ||mst...@redhat.com, ||sberg...@redhat.com --- Comment #4 from Stephan Bergmann sberg...@redhat.com --- See the corresponding mail thread starting at http://lists.freedesktop.org/archives/libreoffice/2013-January/044413.html Python extension issue with LO 4 on Windows for further details. What's presumably needed is something like changing line 93 of pyuno/source/loader/pythonloader.py from fileHandle = open( filename ) to fileHandle = open( filename, encoding=utf_8 ) but that would probably break the compatibility with Python 2 we still try to abide by. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59731] EDITING: Reproducible crash in OpenOffice.org
https://bugs.freedesktop.org/show_bug.cgi?id=59731 --- Comment #4 from Rich Ercolani rerc...@pha.jhu.edu --- So, instructions for reproducing this. 1) Open one of the files 2) Open the other file 3) Drag-copy the slide from the PPT into the ODP 4) Attempt to quit without saving 5) Choose Save or Discard - it doesn't matter, it'll crash either way. 6) Boom! Crashes for me every time on 3.6.4.3 (Build ID: 2ef5aff) on Windows 7 x64. The attached documents were originally an ODP of a presentation and an exported copy of said presentation to PDF - I ran into a problem where on reopening the ODP, the template slide I had been using, which had been copied from a freely available template online, had lost its background color. I attempted to copy a slide from the ppt (which did not have this problem) back to the odp and ran into this. How these two files ended up in a state such that this could happen is...a fascinating question. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59731] EDITING: Reproducible crash in OpenOffice.org
https://bugs.freedesktop.org/show_bug.cgi?id=59731 --- Comment #5 from Rich Ercolani rerc...@pha.jhu.edu --- (In reply to comment #4) So, instructions for reproducing this. 1) Open one of the files 2) Open the other file 3) Drag-copy the slide from the PPT into the ODP 4) Attempt to quit without saving 5) Choose Save or Discard - it doesn't matter, it'll crash either way. 6) Boom! Crashes for me every time on 3.6.4.3 (Build ID: 2ef5aff) on Windows 7 x64. The attached documents were originally an ODP of a presentation and an exported copy of said presentation to PDF - I ran into a problem where on reopening the ODP, the template slide I had been using, which had been copied from a freely available template online, had lost its background color. I attempted to copy a slide from the ppt (which did not have this problem) back to the odp and ran into this. How these two files ended up in a state such that this could happen is...a fascinating question. ...export to PPT, not PDF. Similar to the above conflation of LibreOffice and OpenOffice.org - my apologies, I'm tired, and do know which I mean, even if I cannot type. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59731] EDITING: Reproducible crash in OpenOffice.org
https://bugs.freedesktop.org/show_bug.cgi?id=59731 --- Comment #6 from Rich Ercolani rerc...@pha.jhu.edu --- Additional notes: - Reproducible for me even after removing my LibreOffice user profile - if you select save on the save/discard prompt, it does appear to correctly save the result, but the resulting odp and (unmodified) ppt still suffer from this problem - I'm running on a ThinkPad T420s with an Intel HD3000 and an NVIDIA NVS 4200M onboard, with driver versions 9.17.10.2867 and 9.18.13.479 (in NVIDIA download land, that translates to 304.79), respectively. - This occurs with nothing else perceptibly running on the system for me - e.g. a clean boot with no other things open (other than, implicitly, explorer, since I am opening these by file association and double-clicking). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59731] EDITING: Reproducible crash in OpenOffice.org
https://bugs.freedesktop.org/show_bug.cgi?id=59731 --- Comment #7 from Rich Ercolani rerc...@pha.jhu.edu --- I'll go play the git bisect game and see if I can figure out where this starts and stops (I was going to just get a backtrace, but if I'm going to set up a debug environment just for that, I might as well also bisect...) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59679] Wrong window title encoding
https://bugs.freedesktop.org/show_bug.cgi?id=59679 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Stephan Bergmann sberg...@redhat.com --- I can reproduce this (Fedora 18, Gnome 3.6.2) when running soffice from an environment with LC_ALL=POSIX. For a workaround, try setting LC_ALL to something like en_US.utf8. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59748] New: FILESAVE: File named like folder saves in the folder
https://bugs.freedesktop.org/show_bug.cgi?id=59748 Priority: medium Bug ID: 59748 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE: File named like folder saves in the folder Severity: normal Classification: Unclassified OS: Windows (All) Reporter: ygavr...@gmail.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: unspecified Component: UI Product: LibreOffice When a file is being saved with the same name as a folder in the same directory, the LO puts the file in the folder instead of leaving it in the directory. E.g. file Tony is saved in folder Documents which contains among other things folder Tony. Rather than being saved in Documents, file Tony is put in folder Tony. The issue affects all applications in the current and previous builds. It has been observed for at least half a year on a PC with Windows 7 Home Premium x64 and a PC with Windows XP with Service Pack 3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59748] FILESAVE: File named like folder saves in the folder
https://bugs.freedesktop.org/show_bug.cgi?id=59748 YuriG ygavr...@gmail.com changed: What|Removed |Added Version|unspecified |3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59749] New: Personas with transparent background makes menus and toolbars transparent as well
https://bugs.freedesktop.org/show_bug.cgi?id=59749 Priority: medium Bug ID: 59749 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Personas with transparent background makes menus and toolbars transparent as well Severity: normal Classification: Unclassified OS: Windows (All) Reporter: pkarol...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.0.0.1 rc Component: UI Product: LibreOffice Created attachment 73500 -- https://bugs.freedesktop.org/attachment.cgi?id=73500action=edit upper part: FF header, lower part: LO header I've made a persona for LibreOffice (https://www.getpersonas.com/hu/persona/492384) with transparent backgrounf, to make sure that it integrates to any OS and any style seamlessly. However when I use it, it doesn't takes the default background's colour, like in Firefox (see header.png, upper: FF, lower: LO), but makes the whole header transparent, or simply black. However, you can reproduce it when you minimize your LO window, and then restore it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51896] Paste icon on Impress can be significantly improved
https://bugs.freedesktop.org/show_bug.cgi?id=51896 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53924] FORMATTING: PRINTING spaces mishandled in paragraphs that use letter-spacing OS X 10.7/10.8
https://bugs.freedesktop.org/show_bug.cgi?id=53924 --- Comment #47 from Tor Lillqvist tlillqv...@suse.com --- Note that the comma is in no way special; the same problem appears if the text is aa b, when printed it looks like a ab. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs