[Libreoffice-commits] core.git: 2 commits - basic/source
basic/source/runtime/methods.cxx |5 +++--
basic/source/sbx/sbxscan.cxx |2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
New commits:
commit bc56c5f8817526679c65e7f49682b6595583c588
Author: Caolán McNamara caol...@redhat.com
Date: Sun Feb 17 09:06:46 2013 +
coverity#707502 Uninitialized scalar variable
Change-Id: I38db032b2e9331170da9e8d84eaa85c894f9d8fb
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 856a40d..d6e55d3 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -719,7 +719,7 @@ void SbxValue::Format( OUString rRes, const OUString* pFmt
) const
LanguageType eLangType =
GetpApp()-GetSettings().GetLanguageTag().getLanguageType();
SvNumberFormatter aFormatter(
comphelper::getProcessComponentContext(), eLangType );
-sal_uInt32 nIndex;
+sal_uInt32 nIndex = 0;
double nNumber;
Color* pCol;
commit 9a55875ef4c466a4f176c3896c3cf7232b56c0bc
Author: Caolán McNamara caol...@redhat.com
Date: Sun Feb 17 09:03:50 2013 +
coverity#707496 Uninitialized scalar variable
also...
coverity#707497 Uninitialized scalar variable
Change-Id: Ie3ac361685a52b23e088b78404ea4e013407fe2a
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index b9a2861..aeba267 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1952,7 +1952,7 @@ RTLFUNC(DateValue)
SbiInstance::PrepareNumberFormatter( pFormatter, n, n, n );
}
-sal_uInt32 nIndex;
+sal_uInt32 nIndex = 0;
double fResult;
OUString aStr( rPar.Get(1)-GetOUString() );
sal_Bool bSuccess = pFormatter-IsNumberFormat( aStr, nIndex, fResult
);
@@ -1967,6 +1967,7 @@ RTLFUNC(DateValue)
{
// Create a new SvNumberFormatter by using LANGUAGE_ENGLISH to get
the date value;
SvNumberFormatter aFormatter(
comphelper::getProcessComponentContext(), LANGUAGE_ENGLISH_US );
+nIndex = 0;
bSuccess = aFormatter.IsNumberFormat( aStr, nIndex, fResult );
nType = aFormatter.GetType( nIndex );
}
@@ -2019,7 +2020,7 @@ RTLFUNC(TimeValue)
SbiInstance::PrepareNumberFormatter( pFormatter, n, n, n );
}
-sal_uInt32 nIndex;
+sal_uInt32 nIndex = 0;
double fResult;
sal_Bool bSuccess = pFormatter-IsNumberFormat(
rPar.Get(1)-GetOUString(),
nIndex, fResult );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/inftxt.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2a7db22c3825acdb0c36a9cefd5736d73e4fefbf
Author: Caolán McNamara caol...@redhat.com
Date: Sun Feb 17 09:33:07 2013 +
coverity#707555 Uninitialized scalar variable
Change-Id: Ibba9295d34a0089127c6e09f59f9c0de6be386c5
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index ad14afb..0819465 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -617,7 +617,7 @@ void SwTxtPaintInfo::_DrawText( const XubString rText,
const SwLinePortion rPo
rPor.InNumberGrp() ) ? 0 : GetSpaceAdd();
if ( nSpaceAdd )
{
-xub_StrLen nCharCnt;
+xub_StrLen nCharCnt = 0;
// #i41860# Thai justified alignment needs some
// additional information:
aDrawInf.SetNumberOfBlanks( rPor.InTxtGrp() ?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - comphelper/inc comphelper/source filter/source framework/inc framework/qa framework/source l10ntools/source odk/examples sfx2/source svx/source ucbhelper/in
comphelper/inc/comphelper/mediadescriptor.hxx
|8
comphelper/inc/comphelper/sequenceashashmap.hxx
|4 ++--
comphelper/source/misc/locale.cxx
|2 +-
comphelper/source/misc/numberedcollection.cxx
|2 +-
filter/source/config/cache/cacheitem.hxx
|6 +++---
filter/source/config/cache/filtercache.cxx
|2 +-
filter/source/config/cache/filtercache.hxx
|4 ++--
filter/source/config/cache/typedetection.cxx
|2 +-
framework/inc/classes/propertysethelper.hxx
|2 +-
framework/inc/dispatch/interceptionhelper.hxx
|2 +-
framework/inc/interaction/quietinteraction.hxx
|2 +-
framework/inc/properties.h
|4 ++--
framework/qa/complex/loadAllDocuments/InteractionHandler.java
|2 +-
framework/source/accelerators/storageholder.cxx
|4 ++--
framework/source/classes/framecontainer.cxx
|2 +-
framework/source/dispatch/dispatchprovider.cxx
|2 +-
framework/source/dispatch/mailtodispatcher.cxx
|2 +-
framework/source/inc/loadenv/actionlockguard.hxx
|4 ++--
framework/source/inc/loadenv/targethelper.hxx
|2 +-
framework/source/jobs/joburl.cxx
|2 +-
framework/source/loadenv/loadenv.cxx
|4 ++--
framework/source/services/autorecovery.cxx
|2 +-
framework/source/services/desktop.cxx
|4 ++--
framework/source/services/dispatchhelper.cxx
|2 +-
framework/source/services/frame.cxx
|8
l10ntools/source/filter/utils/Cache.java
|2 +-
l10ntools/source/filter/utils/FileHelper.java
|2 +-
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java
|4 ++--
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java
|2 +-
sfx2/source/appl/sfxhelp.cxx
|2 +-
sfx2/source/doc/docfile.cxx
|2 +-
sfx2/source/toolbox/tbxitem.cxx
|2 +-
svx/source/dialog/simptabl.cxx
|2 +-
svx/source/form/formcontroller.cxx
|2 +-
ucbhelper/inc/ucbhelper/interceptedinteraction.hxx
|2 +-
unotools/inc/unotools/securityoptions.hxx
|2 +-
36 files changed, 52 insertions(+), 52 deletions(-)
New commits:
commit a71946505b853ca3db7fd4c3a7df7bfc62626ed2
Author: Ivan Timofeev timofeev@gmail.com
Date: Sun Feb 17 13:56:11 2013 +0400
fix SvxSimpleTable size
Change-Id: I74b082e090cc382b699720f1cfc70f1920ff5db4
diff --git a/svx/source/dialog/simptabl.cxx b/svx/source/dialog/simptabl.cxx
index 5fa4077..c32ed74 100644
--- a/svx/source/dialog/simptabl.cxx
+++ b/svx/source/dialog/simptabl.cxx
@@ -125,7 +125,7 @@ SvxSimpleTable::~SvxSimpleTable()
void SvxSimpleTable::UpdateViewSize()
{
-Size theWinSize=m_rParentTableContainer.GetSizePixel();
+Size theWinSize=m_rParentTableContainer.GetOutputSizePixel();
Size HbSize=aHeaderBar.GetSizePixel();
HbSize.Width()=theWinSize.Width();
commit e2f97dcc1006aceb80c4805c0e1cb5b2f40ab7b0
Author: Ivan Timofeev timofeev@gmail.com
Date: Wed Feb 13 18:25:22 2013 +0400
spelling: otherwhise - otherwise
Change-Id: I2d89edbb2574b4e677c9a0682bc829d9476b54db
diff --git a/comphelper/inc/comphelper/mediadescriptor.hxx
b/comphelper/inc/comphelper/mediadescriptor.hxx
index 8c55f85..ac045dc 100644
---
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/servicemanager.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 80d81b40a1915eec599fc7004698ff113e5bb47f
Author: Stephan Bergmann sberg...@redhat.com
Date: Sun Feb 17 11:13:53 2013 +0100
cppcheck: Iterator i used after element has been erased
Change-Id: Id8eb6a475dafcaddc98ddc48627fa8090e91cf4f
diff --git a/cppuhelper/source/servicemanager.cxx
b/cppuhelper/source/servicemanager.cxx
index dcb7af9..ce4bf46 100644
--- a/cppuhelper/source/servicemanager.cxx
+++ b/cppuhelper/source/servicemanager.cxx
@@ -1567,6 +1567,9 @@ bool cppuhelper::ServiceManager::removeLegacyFactory(
}
assert(i-second.get() != 0);
clear = i-second;
+if (removeListener) {
+comp = i-second-component;
+}
//TODO: The below leaves data_ in an inconsistent state upon
exceptions:
removeFromImplementationMap(
data_.services, i-second-info-services, i-second);
@@ -1576,9 +1579,6 @@ bool cppuhelper::ServiceManager::removeLegacyFactory(
data_.namedImplementations.erase(i-second-info-name);
}
data_.dynamicImplementations.erase(i);
-if (removeListener) {
-comp = i-second-component;
-}
}
if (comp.is()) {
removeEventListenerFromComponent(comp);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - filter/source sw/source
filter/source/xsltfilter/XSLTFilter.cxx |2 +-
sw/source/core/txtnode/ndtxt.cxx|8
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 3f7ead7ffee808f99bf9cf76bbd247af04707242
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Sun Feb 17 11:19:29 2013 +0100
apparently there's no ssize_t on windows
Change-Id: Ic9aef7fe5295b7dae6f5b7ee7f28378d393cbfe4
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 4bc16af..c5ffa22 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -1710,8 +1710,8 @@ OUString SwTxtNode::InsertText( const XubString rStr,
const SwIndex rIdx,
xub_StrLen aPos = rIdx.GetIndex();
xub_StrLen nLen = m_Text.Len() - aPos;
-ssize_t const nOverflow(static_castssize_t(m_Text.Len())
-+ static_castssize_t(rStr.Len()) - TXTNODE_MAX);
+long const nOverflow(static_castlong(m_Text.Len())
++ static_castlong(rStr.Len()) - TXTNODE_MAX);
SAL_WARN_IF(nOverflow 0, sw.core,
SwTxtNode::InsertText: node text with insertion TXTNODE_MAX.);
OUString const sInserted(
@@ -3328,8 +3328,8 @@ void SwTxtNode::ReplaceText( const SwIndex rStart, const
xub_StrLen nDelLen,
rStart.GetIndex() + nDelLen = m_Text.Len(),
SwTxtNode::ReplaceText: index out of bounds );
-ssize_t const nOverflow(static_castssize_t(m_Text.Len())
-+ static_castssize_t(rStr.Len()) - nDelLen - TXTNODE_MAX);
+long const nOverflow(static_castlong(m_Text.Len())
++ static_castlong(rStr.Len()) - nDelLen - TXTNODE_MAX);
SAL_WARN_IF(nOverflow 0, sw.core,
SwTxtNode::ReplaceText: node text with insertion TXTNODE_MAX.);
OUString const sInserted(
commit d7f563ba35f9a6b565224b9076dbb238b423e225
Author: LuboÅ¡ LuÅák l.lu...@suse.cz
Date: Sun Feb 17 11:15:46 2013 +0100
fix build, caused by fast string concat
Change-Id: I07025171f0865b34de9a85b7820321e5eac46758
diff --git a/filter/source/xsltfilter/XSLTFilter.cxx
b/filter/source/xsltfilter/XSLTFilter.cxx
index a16627f..2b77274 100644
--- a/filter/source/xsltfilter/XSLTFilter.cxx
+++ b/filter/source/xsltfilter/XSLTFilter.cxx
@@ -241,7 +241,7 @@ m_rServiceFactory(r), m_bTerminated(sal_False),
m_bError(sal_False)
Exception e;
if (a = e)
{
-OSL_FAIL(XSLTFilter::error was called: +
OUStringToOString(e.Message, RTL_TEXTENCODING_ASCII_US));
+SAL_WARN(filter.xslt, XSLTFilter::error was called:
e.Message);
}
m_bError = sal_True;
osl_setCondition(m_cTransformed);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Cppcheck: Iterator 'i' used after element has been erased in servicemanager.cxx (cppuhelper module)
On 02/15/2013 11:52 PM, julien2412 wrote: Cppcheck reported this: cppuhelper/source/servicemanager.cxx 1578eraseDereferenceerror Iterator 'i' used after element has been erased. Oops. Fixed now as http://cgit.freedesktop.org/libreoffice/core/commit/?id=80d81b40a1915eec599fc7004698ff113e5bb47f cppcheck: Iterator i used after element has been erased. Thanks for reporting. (+ this but I don't know if we can do something: 1216unusedScopedObject error Instance of 'Parser' object is destroyed immediately. 1390unusedScopedObject error Instance of 'Parser' object is destroyed immediately) Those are false positives---looks like cppcheck doesn't fully appreciate the implications of a language with side effects. ;) (Though it is arguably somewhat odd-looking code for sure.) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: connectivity/Library_kab1.mk connectivity/Library_kabdrv1.mk
connectivity/Library_kab1.mk|5 - connectivity/Library_kabdrv1.mk |1 + 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit 4d33da4065bb7620d78f10d04b840f2dd77c6e6e Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 17 11:44:07 2013 +0100 connectivity/kab (indirectly) depends on boost_header ...at least via KDriver.cxx - tools/diagnose_ex.h - boost/noncopyable.hpp (kab1) and KStatement.cxx - KStatement.hxx - connectivity/sqliterator.hxx - boost/shared_ptr.hpp (kabdrv1). Becomes evident when building --with-system-boost --with-boost=... on a machine with no system-wide Boost installation. Not sure solving those problems this way is the best approach, though. Change-Id: Ida72362596aaac076efc4e1faab41fa47013975f diff --git a/connectivity/Library_kab1.mk b/connectivity/Library_kab1.mk index 7fd80cb..e51ab45 100644 --- a/connectivity/Library_kab1.mk +++ b/connectivity/Library_kab1.mk @@ -27,7 +27,10 @@ $(eval $(call gb_Library_Library,kab1)) -$(eval $(call gb_Library_use_externals,kab1,kde)) +$(eval $(call gb_Library_use_externals,kab1, \ +boost_headers \ +kde \ +)) $(eval $(call gb_Library_set_componentfile,kab1,connectivity/source/drivers/kab/kab1)) diff --git a/connectivity/Library_kabdrv1.mk b/connectivity/Library_kabdrv1.mk index ecdd905..9050c71 100644 --- a/connectivity/Library_kabdrv1.mk +++ b/connectivity/Library_kabdrv1.mk @@ -34,6 +34,7 @@ $(eval $(call gb_Library_use_packages,kabdrv1,\ $(eval $(call gb_Library_use_sdk_api,kabdrv1)) $(eval $(call gb_Library_use_externals,kabdrv1,\ + boost_headers \ kde \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: liborcus/liborcus_0.1.0-boost-include.patch.1 liborcus/UnpackedTarball_orcus.mk
liborcus/UnpackedTarball_orcus.mk |4
liborcus/liborcus_0.1.0-boost-include.patch.1 | 26 ++
2 files changed, 30 insertions(+)
New commits:
commit faf72664d11deaa570a0f8c7e702ff07bf5914c8
Author: Stephan Bergmann sberg...@redhat.com
Date: Sun Feb 17 11:49:34 2013 +0100
Missing include in liborcus when building against Boost 1.53.0
Change-Id: Ie6c944d53d6e2fcdd161f674e32c9fbfd761d844
diff --git a/liborcus/UnpackedTarball_orcus.mk
b/liborcus/UnpackedTarball_orcus.mk
index ca5232d..de0788a 100644
--- a/liborcus/UnpackedTarball_orcus.mk
+++ b/liborcus/UnpackedTarball_orcus.mk
@@ -18,6 +18,10 @@ orcus_patches :=
orcus_patches += liborcus_0.1.0-configure.patch
# disable boost auto lib in MSVC build
orcus_patches += liborcus_0.1.0-boost_disable_auto_lib.patch
+# https://gitorious.org/orcus/orcus/merge_requests/2#
+# f60d6eecee72349993a392a9a63ddf3383d3b8c8-
+# f60d6eecee72349993a392a9a63ddf3383d3b8c8@2:
+orcus_patches += liborcus_0.1.0-boost-include.patch.1
$(eval $(call gb_UnpackedTarball_fix_end_of_line,orcus,\
vsprojects/liborcus-static-nozip/liborcus-static-nozip.vcproj \
diff --git a/liborcus/liborcus_0.1.0-boost-include.patch.1
b/liborcus/liborcus_0.1.0-boost-include.patch.1
new file mode 100644
index 000..07558b0
--- /dev/null
+++ b/liborcus/liborcus_0.1.0-boost-include.patch.1
@@ -0,0 +1,26 @@
+From f60d6eecee72349993a392a9a63ddf3383d3b8c8 Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann sberg...@redhat.com
+Date: Sat, 16 Feb 2013 13:25:44 +0100
+Subject: [PATCH] Missing include boost/noncopyable.hpp
+
+(at least when compiling against Boost 1.53.0)
+---
+ src/liborcus/dom_tree.cpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/liborcus/dom_tree.cpp b/src/liborcus/dom_tree.cpp
+index ecf7beb..14725ad 100644
+--- a/src/liborcus/dom_tree.cpp
b/src/liborcus/dom_tree.cpp
+@@ -34,6 +34,8 @@
+ #include iostream
+ #include sstream
+
++#include boost/noncopyable.hpp
++
+ using namespace std;
+
+ namespace orcus {
+--
+1.8.1.2
+
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: libmspub/ExternalProject_libmspub.mk liborcus/ExternalProject_liborcus.mk libvisio/ExternalProject_libvisio.mk
libmspub/ExternalProject_libmspub.mk |2 +- liborcus/ExternalProject_liborcus.mk |2 +- libvisio/ExternalProject_libvisio.mk |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit be9bf4801bc157ec1bf52250077de914a212 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 17 11:55:31 2013 +0100 Improve support for --with-system-boost --with-boost=... in external modules ...though it would arguably be better to just pass along --with-boost=... where applicable. (liborcus' orcus-xml-dump links against -lboost_system, so needs BOOST_LDFLAGS passed in in addition to BOOST_CPPFLAGS.) Change-Id: I6467d0f453d68494b75559a7eb61f865f9513b50 diff --git a/libmspub/ExternalProject_libmspub.mk b/libmspub/ExternalProject_libmspub.mk index 14cc85e..9fdcce1 100644 --- a/libmspub/ExternalProject_libmspub.mk +++ b/libmspub/ExternalProject_libmspub.mk @@ -72,7 +72,7 @@ $(call gb_ExternalProject_get_state_target,libmspub,build) : --disable-debug \ --disable-werror \ --disable-weffc \ - $(if $(filter NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(call gb_UnpackedTarball_get_dir,boost)) \ + $(if $(filter NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(call gb_UnpackedTarball_get_dir,boost),CXXFLAGS=$(BOOST_CPPFLAGS)) \ $(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ (cd $(EXTERNAL_WORKDIR)/src/lib $(MAKE)) \ touch $@ diff --git a/liborcus/ExternalProject_liborcus.mk b/liborcus/ExternalProject_liborcus.mk index aea4c87..2bbf2e9 100644 --- a/liborcus/ExternalProject_liborcus.mk +++ b/liborcus/ExternalProject_liborcus.mk @@ -60,7 +60,7 @@ $(call gb_ExternalProject_get_state_target,liborcus,build) : --disable-spreadsheet-model \ --disable-werror \ $(if $(filter LINUX FREEBSD OPENBSD NETBSD DRAGONFLY ANDROID,$(OS)),$(if $(gb_ENABLE_DBGUTIL),CPPFLAGS=-D_GLIBCXX_DEBUG)) \ - $(if $(filter NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(call gb_UnpackedTarball_get_dir,boost)) \ + $(if $(filter NO,$(SYSTEM_BOOST)),CXXFLAGS=-I$(call gb_UnpackedTarball_get_dir,boost),CXXFLAGS=$(BOOST_CPPFLAGS) LDFLAGS=$(BOOST_LDFLAGS)) \ $(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(MAKE) \ touch $@ diff --git a/libvisio/ExternalProject_libvisio.mk b/libvisio/ExternalProject_libvisio.mk index c133158..deee499 100644 --- a/libvisio/ExternalProject_libvisio.mk +++ b/libvisio/ExternalProject_libvisio.mk @@ -68,7 +68,7 @@ $(call gb_ExternalProject_get_state_target,libvisio,build) : --without-docs \ --disable-debug \ --disable-werror \ - CXXFLAGS=$(if $(filter NO,$(SYSTEM_BOOST)),-I$(call gb_UnpackedTarball_get_dir,boost)) \ + CXXFLAGS=$(if $(filter NO,$(SYSTEM_BOOST)),-I$(call gb_UnpackedTarball_get_dir,boost),$(BOOST_CPPFLAGS)) \ $(if $(filter NO,$(SYSTEM_LIBXML)),-I$(call gb_UnpackedTarball_get_dir,xml2)/include) \ $(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ (cd $(EXTERNAL_WORKDIR)/src/lib $(MAKE)) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) New commits: commit 93c69637ffc878d02fa860079804465d2684d794 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 17 11:59:32 2013 +0100 Improve configure support for --with-system-boost --with-boost=... ...by doing the Boost header checks (are they necessary at all, or does AX_BOOST_BASE cover them anyway?) with BOOST_CPPFLAGS already set. Change-Id: I341043fc514cf286c1ca295e69ff6cd4d3e7974c diff --git a/configure.ac b/configure.ac index 5b0853415..d8e1abd 100644 --- a/configure.ac +++ b/configure.ac @@ -8240,20 +8240,28 @@ AC_MSG_CHECKING([which boost to use]) if test $with_system_boost = yes; then AC_MSG_RESULT([external]) SYSTEM_BOOST=YES +AX_BOOST_BASE +AX_BOOST_DATE_TIME +mingw_boost_date_time_dll=`echo $BOOST_DATE_TIME_LIB | sed -e 's/^-l//' -e 's/\.dll$//'` +libo_MINGW_TRY_DLL([BOOST_DATE_TIME], [$mingw_boost_date_time_dll]) +if test -z $MINGW_BOOST_DATE_TIME_DLL; then +# if not found, try again with 'lib' prefix +libo_MINGW_CHECK_DLL([BOOST_DATE_TIME], + [lib$mingw_boost_date_time_dll]) +fi AC_LANG_PUSH([C++]) +save_CXXFLAGS=$CXXFLAGS +CXXFLAGS=$CXXFLAGS $BOOST_CPPFLAGS AC_CHECK_HEADER(boost/shared_ptr.hpp, [], [AC_MSG_ERROR(boost/shared_ptr.hpp not found. install boost)], []) AC_CHECK_HEADER(boost/spirit/include/classic_core.hpp, [], [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost = 1.36)], []) AC_CHECK_HEADER(boost/function.hpp, [], [AC_MSG_ERROR(boost/function.hpp not found. install boost)], []) - -save_CXXFLAGS=$CXXFLAGS CXXFLAGS=$CXXFLAGS -fno-exceptions AC_MSG_CHECKING([whether boost/function.hpp compiles with -fno-exceptions]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include boost/function.hpp ]], [[]])],[ac_cv_cxx_boost_no_exceptions_broken=no],[ac_cv_cxx_boost_no_exceptions_broken=yes]) - if test $ac_cv_cxx_boost_no_exceptions_broken = yes; then AC_MSG_ERROR([no, see https://bugzilla.redhat.com/show_bug.cgi?id=477131]) else @@ -8261,16 +8269,6 @@ if test $with_system_boost = yes; then fi CXXFLAGS=$save_CXXFLAGS AC_LANG_POP([C++]) - -AX_BOOST_BASE -AX_BOOST_DATE_TIME -mingw_boost_date_time_dll=`echo $BOOST_DATE_TIME_LIB | sed -e 's/^-l//' -e 's/\.dll$//'` -libo_MINGW_TRY_DLL([BOOST_DATE_TIME], [$mingw_boost_date_time_dll]) -if test -z $MINGW_BOOST_DATE_TIME_DLL; then -# if not found, try again with 'lib' prefix -libo_MINGW_CHECK_DLL([BOOST_DATE_TIME], - [lib$mingw_boost_date_time_dll]) -fi else AC_MSG_RESULT([internal]) BUILD_TYPE=$BUILD_TYPE BOOST ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 850b4c7e2d5535dcf76cebea85b4f14c1c7aeaea
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Sun Feb 17 11:57:58 2013 +0100
configure.ac: automatically find versioned servlet-api.jar
Change-Id: I87533bb16d0ac2bbcb7c8592c4f6caa1aa05c705
diff --git a/configure.ac b/configure.ac
index d8e1abd..7281004 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10009,7 +10009,11 @@ if test $ENABLE_MEDIAWIKI = YES; then
AC_MSG_RESULT([external])
SYSTEM_SERVLETAPI=YES
if test -z $SERVLETAPI_JAR; then
-SERVLETAPI_JAR=/usr/share/java/servlet-api.jar
+for version in '' -3.3 -3.2 -3.1 -3.0 -2.5 -2.4; do
+if test -r /usr/share/java/servlet-api${version}.jar; then
+SERVLETAPI_JAR=/usr/share/java/servlet-api${version}.jar
+fi
+done
fi
AC_CHECK_FILE($SERVLETAPI_JAR, [],
[AC_MSG_ERROR(servlet-api.jar not found.)], [])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: setup_native/Library_instooofiltmsi.mk setup_native/Library_jfregca.mk setup_native/Library_qslnkmsi.mk setup_native/Library_reg4allmsdoc.mk setup_native/Library_regact
setup_native/Library_instooofiltmsi.mk | 17 -- setup_native/Library_jfregca.mk | 12 +++ setup_native/Library_qslnkmsi.mk | 15 setup_native/Library_reg4allmsdoc.mk | 8 setup_native/Library_regactivex.mk | 14 +++- setup_native/Library_regpatchactivex.mk | 13 +++ setup_native/Library_sdqsmsi.mk | 13 +++ setup_native/Library_sellangmsi.mk | 11 +- setup_native/Library_shlxtmsi.mk | 14 +++- setup_native/Library_sn_tools.mk | 16 - setup_native/StaticLibrary_quickstarter.mk | 8 setup_native/StaticLibrary_seterror.mk | 8 setup_native/source/win32/customactions/quickstarter/shutdown_quickstart.cxx | 4 +- setup_native/source/win32/customactions/shellextensions/iconcache.cxx| 4 +- 14 files changed, 143 insertions(+), 14 deletions(-) New commits: commit c13c500630746ba035e0b48c0cbd276aa436db2b Author: Andras Timar ati...@suse.com Date: Sun Feb 17 12:22:01 2013 +0100 CustomActions should be statically linked with MSVCRT Change-Id: I100b7ff7e3aa505098ce8bd1aa8faca50370 diff --git a/setup_native/Library_instooofiltmsi.mk b/setup_native/Library_instooofiltmsi.mk index 0c74484..677e590 100644 --- a/setup_native/Library_instooofiltmsi.mk +++ b/setup_native/Library_instooofiltmsi.mk @@ -9,14 +9,27 @@ $(eval $(call gb_Library_Library,instooofiltmsi)) -ifeq ($(COM),MSC) +$(eval $(call gb_Library_add_defs,instooofiltmsi,\ + -U_DLL \ +)) + +$(eval $(call gb_Library_add_cxxflags,instooofiltmsi,\ + /MT \ +)) + $(eval $(call gb_Library_add_ldflags,instooofiltmsi,\ /DEF:$(SRCDIR)/setup_native/source/win32/customactions/indexingfilter/instooofiltmsi.def \ + /NODEFAULTLIB \ )) -endif $(eval $(call gb_Library_add_exception_objects,instooofiltmsi,\ setup_native/source/win32/customactions/indexingfilter/restartindexingservice \ )) +$(eval $(call gb_Library_use_system_win32_libs,instooofiltmsi,\ + libcmt \ + libcpmt \ + kernel32 \ +)) + # vim: set noet sw=4 ts=4: diff --git a/setup_native/Library_jfregca.mk b/setup_native/Library_jfregca.mk index d3eea27..c213e81 100644 --- a/setup_native/Library_jfregca.mk +++ b/setup_native/Library_jfregca.mk @@ -9,8 +9,17 @@ $(eval $(call gb_Library_Library,jfregca)) +$(eval $(call gb_Library_add_defs,jfregca,\ + -U_DLL \ +)) + +$(eval $(call gb_Library_add_cxxflags,jfregca,\ + /MT \ +)) + $(eval $(call gb_Library_add_ldflags,jfregca,\ /DEF:$(SRCDIR)/setup_native/source/win32/customactions/javafilter/jfregca.def \ + /NODEFAULTLIB \ )) $(eval $(call gb_Library_add_exception_objects,jfregca,\ @@ -18,6 +27,9 @@ $(eval $(call gb_Library_add_exception_objects,jfregca,\ )) $(eval $(call gb_Library_use_system_win32_libs,jfregca,\ + libcmt \ + libcpmt \ + kernel32 \ msi \ advapi32 \ )) diff --git a/setup_native/Library_qslnkmsi.mk b/setup_native/Library_qslnkmsi.mk index 04dd1fb..7f7bbb3 100644 --- a/setup_native/Library_qslnkmsi.mk +++ b/setup_native/Library_qslnkmsi.mk @@ -9,8 +9,17 @@ $(eval $(call gb_Library_Library,qslnkmsi)) +$(eval $(call gb_Library_add_defs,qslnkmsi,\ + -U_DLL \ +)) + +$(eval $(call gb_Library_add_cxxflags,qslnkmsi,\ + /MT \ +)) + $(eval $(call gb_Library_add_ldflags,qslnkmsi,\ /DEF:$(SRCDIR)/setup_native/source/win32/customactions/quickstarter/qslnkmsi.def \ + /NODEFAULTLIB \ )) $(eval $(call gb_Library_add_exception_objects,qslnkmsi,\ @@ -22,7 +31,11 @@ $(eval $(call gb_Library_use_static_libraries,qslnkmsi,\ )) $(eval $(call gb_Library_use_system_win32_libs,qslnkmsi,\ -msi \ + libcmt \ + libcpmt \ + msi \ + kernel32 \ + user32 \ advapi32 \ shell32 \ )) diff --git a/setup_native/Library_reg4allmsdoc.mk b/setup_native/Library_reg4allmsdoc.mk index 6c0b241..69f3903 100644 --- a/setup_native/Library_reg4allmsdoc.mk +++ b/setup_native/Library_reg4allmsdoc.mk @@ -12,10 +12,16 @@ $(eval $(call gb_Library_Library,reg4allmsdoc)) $(eval $(call gb_Library_add_defs,reg4allmsdoc,\ -DUNICODE \ -D_UNICODE \ + -U_DLL \ +)) + +$(eval $(call gb_Library_add_cxxflags,reg4allmsdoc,\ + /MT \ )) $(eval $(call gb_Library_add_ldflags,reg4allmsdoc,\ /DEF:$(SRCDIR)/setup_native/source/win32/customactions/reg4allmsdoc/reg4allmsdoc.def \ + /NODEFAULTLIB \ )) $(eval $(call
Re: [PATCH] convert setup_native to gbuild and add to tail_build
Hi Peter, I fixed it with c13c500630746ba035e0b48c0cbd276aa436db2b. dmake-based build system had option for static link (DYNAMIC_CRT=), but I could solve it in gbuild, too, with a little hack, i.e. by adding defines, cxx flags and linker flags. The only problem that we get warnings: cl : Command line warning D9025 : overriding '/D_DLL' with '/U_DLL' cl : Command line warning D9025 : overriding '/MD' with '/MT' Best regards, Andras On Wed, Feb 13, 2013 at 11:39 PM, Peter Foley pefol...@verizon.net wrote: Andras, I'm not sure exactly why it changed or what the problem is. Do you know how I would force msvcrt to be linked staticly? Thanks, Peter -Original Message- From: Andras Timar Sent: Wednesday, February 13, 2013 6:13 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert setup_native to gbuild and add to tail_build Hi Peter, Thanks, it was a good fix, I did the same for all CustomActions. Just one more problem: now MSVCRT is linked dinamically. It is not good, because MSVCRT is not part of the default Windows installation. We need to link it statically like we did that before. Thanks, Andras On Mon, Feb 11, 2013 at 11:03 PM, Peter Foley pefol...@verizon.net wrote: Andras, I just pushed a patch that should fix it. Could you test it? Thanks, Peter -Original Message- From: Andras Timar Sent: Monday, February 11, 2013 7:37 AM To: Peter Foley Cc: libreoffice Subject: Re: [PATCH] convert setup_native to gbuild and add to tail_build Hi Peter, On Sat, Feb 9, 2013 at 3:54 PM, Peter Foley (via Code Review) ger...@gerrit.libreoffice.org wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2063 I tested you patch and it does not work for me. Windows Installer cannot execure any of the CustomActions. E.g.: MSI (c) (9C:B0) [13:23:41:427]: Invoking remote custom action. DLL: C:\Users\timar\AppData\Local\Temp\MSIAF36.tmp, Entrypoint: SelectLanguage CustomAction SelectLanguage returned actual error code 1154 but will be translated to success due to continue marking The problem is that in newly built DLLs the names are mangled, I see _SelectLanguage@4 instead of SelectLanguage in Dependency Walker. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: mingw build is currently broken
On Fri, Feb 15, 2013 at 1:13 PM, Andras Timar tima...@gmail.com wrote: On Fri, Feb 15, 2013 at 12:51 PM, Michael Stahl mst...@redhat.com wrote: On 15/02/13 12:23, Jan Holesovsky wrote: Hi Andras, Tor Lillqvist píše v Pá 15. 02. 2013 v 13:01 +0200: It am fairly sure that the breakage is a consequence of the recently introduced dependency on the svt and tl libraries to the helplinker library. Any chance we can move the code that is needed in helplinker somewhere higher the hierarchy than in svt / tl, and remove the dependency on svt and tl again, please? The SyntaxHighlighter class seems to be quite self-contained when I quickly looked, so hopefully it might be easy? Would be better not to have to build 1/2 of LO to have the build tools :-) agreed, having build time tools depend on VCL smells rather bad to me... I'm trying to work out a solution. I moved the SyntaxHighlighter class to comphelper (c16e9f4ed97f65357e9986f46ad88ee9f2237997). MinGW tinderbox is green again. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
License statement: All of my past and future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Krisztian Pinter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: mingw build is currently broken
Andras Timar schrieb: I moved the SyntaxHighlighter class to comphelper (c16e9f4ed97f65357e9986f46ad88ee9f2237997). MinGW tinderbox is green again. Hi András, thank you for the fix, indeed, we get new builds. But the bad thing is, the last MinGW build that was at least a little useful I saw 1 year ago (or so). For example, build in master~2013-02-17_08.19.43_LibO-Dev_4.1.0.0.alpha0_Win_x86_archive terminates launch with a C++ Rungime Lib error message. Is it useful to report such MinGW problems? It seems currently the Tinderbox produces builds nobody cares. Best regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Need Help for Bug 47302 - Adding a new field in Insert-Fields
I have the following(attached) *Reply* from one of the developers for my Earlier Query. But I am slightly confused with my approach in solving the problem: After testing some code instances ,I have found out that code for Insert-Fields-Slide Name (impress) can be added here * drviewsb.cxx file * And Using the method define at *drviewsb.cxx*, I am planning to follow this approach: (1)For getting a *Slide Name. *Create a class (similar to the class) which is define at *flditem.hxx* . (2)Use the class created above in deriving the SvxFieldItem( ) at * drviewsb.cxx* . (3)As I am not familiar with UNO references used in the *flditem.hxx* , I am not sure whether this is a right approach or some other approach is available. So if someone can guide me with the approach ,it would be really helpful. *drviewsb.cxx file* - http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviewsb.cxx#520 *flditem.hxx*- http://opengrok.libreoffice.org/xref/core/editeng/inc/editeng/flditem.hxx#182 Eagerly waiting for the needed answer. Regards, Vishv *Reply* In order to actually implement the feature, you should follow the SID_INSERT_FLD_PAGE use cases in .cxx files also: http://opengrok.libreoffice.org/search?q=project=coredefs=refs=SID_INSERT_FLD_PAGEpath=%2Fcore%2Fsd%2Fsource%2Fui%2Fview%2Fhist= Here you can see what insert field page does (when in draw view): http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviewsb.cxx#484 As far as I understand, you should derive an SvxFieldItem for hold a text data - but I'm not sure at all. Maybe you should check some Writer fields... You can get slide name by SdPage::GetName() http://opengrok.libreoffice.org/xref/core/sd/inc/sdpage.hxx#282 http://opengrok.libreoffice.org/xref/core/sd/source/core/sdpage.cxx#2508 while you can retrieve the SdPage by index here SdDrawDocument::GetSdPage() http://opengrok.libreoffice.org/xref/core/sd/source/core/drawdoc2.cxx#199 Maybe you can get some clues here http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviewsb.cxx#710 Regards. 2013/2/13 Vishv Brahmbhatt vishvbrahmbhat...@gmail.com: Hi, I need help for this bug https://bugs.freedesktop.org/show_bug.cgi?id=47302 .I am little inexperienced at scripting(xml). So I want help for my Query. As per comment#1 at the above link.I have done following steps: 1)Added a menuitem with label ~Slide Name at http://opengrok.libreoffice.org/xref/core/scripting/workben/bindings/impressmenubar.xml#190 . 2)Added a node oor:name=.uno:InsertSlideField with value=~Slide Name at http://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu#534 3)Added a menuitem with menu:id=.uno:InsertSlideField at http://opengrok.libreoffice.org/xref/core/sd/uiconfig/simpress/menubar/menubar.xml#147 4)Define SID_INSERT_FLD_SLIDE at http://opengrok.libreoffice.org/xref/core/sd/inc/app.hrc#379 5)Added a function SfxVoidItem InsertSlideField SID_INSERT_FLD_SLIDE at http://opengrok.libreoffice.org/xref/core/sd/sdi/sdraw.sdi#3472 Using above procedure I am able to get ~Slide Name option in Insert-Fields-Slide Name.But it is not active/working. So here is my Query: (1)Do I need to use some helper functions for viewing getting Slide Name ? If yes ,then which function do I have to use and where can I use it to make Slide Name option active? Or I have to make some changes in the above given steps? Eagerly waiting to get some answers in this query. Regards, Vishv ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac
configure.ac |5 + 1 file changed, 5 insertions(+) New commits: commit 0e6fdbd79f196aaa06bf3de31123f6a39fe0ec6e Author: Lionel Elie Mamane lio...@mamane.lu Date: Sun Feb 17 13:40:53 2013 +0100 confgure.ac: dbgutil and system-libcmis incompatible libcmis exposes STL containers in its API: workdir/*/CxxObject/ucb/source/ucp/cmis/cmis_content.o: In function `cmis::Content::setCmisProperty(std::string, std::string, com::sun::star::uno::Referencecom::sun::star::ucb::XCommandEnvironment const)': ucb/source/ucp/cmis/cmis_content.cxx:1756: undefined reference to `libcmis::Property::Property(boost::shared_ptrlibcmis::PropertyType, std::__debug::vectorstd::string, std::allocatorstd::string )' ucb/source/ucp/cmis/cmis_content.cxx:1762: undefined reference to `libcmis::Property::setValues(std::__debug::vectorstd::string, std::allocatorstd::string )' Change-Id: Ife845ca5c6cedcbe57e5ce7fbdd8cc641dffae52 diff --git a/configure.ac b/configure.ac index 7281004..cc801f1 100644 --- a/configure.ac +++ b/configure.ac @@ -3384,6 +3384,11 @@ if test -n $enable_dbgutil -a $enable_dbgutil != no; then else with_system_orcus=no fi +if test $with_system_libcmis = yes; then +AC_MSG_ERROR([--with-system-libcmis conflicts with --enable-dbgutil]) +else +with_system_libcmis=no +fi else ENABLE_DBGUTIL= # PRODUCT is old concept, still used by build.pl . ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Happy Birthday, Document Foundation!
Hello everyone, exactly one year ago, February 17th 2012, The Document Foundation was established as a charitable Foundation under German law (gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts). So far, it has proven to be the ideal entity for reflecting the LibreOffice's community needs. I am proud and honoured to be part of this project, part of this community, and part of TDF. I would like to thank all of you who have contributed to the success of our common goal - all developers, marketeers, localizers, administrators, designers, testers, donors, adopters, users and everyone else involved. You have made possible what the community has been dreaming of for a decade, and we all can be excited about the future! Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: oox/source
oox/source/export/chartexport.cxx | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
New commits:
commit 1aadb8789bc9a58e1798c0905214833a0cd6d40e
Author: Katarina Behrens bu...@bubli.org
Date: Sun Feb 17 14:29:51 2013 +0100
fdo#58789: export field separators, fix series name display
Change-Id: I1edae1c2ec845a46d7a9a4ab2517784d2d68d51d
diff --git a/oox/source/export/chartexport.cxx
b/oox/source/export/chartexport.cxx
index ebeafc2..2d24717 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2293,12 +2293,13 @@ void ChartExport::exportDataLabels(
{
// TODO: export field separators, missing flag vs. showing series name or
not
uno::Reference chart2::XDataSeries xSeries( xSeriesProperties,
uno::UNO_QUERY );
-Sequence sal_Int32 aDataPointSeq;
+
if( xSeriesProperties.is())
{
FSHelperPtr pFS = GetFS();
pFS-startElement( FSNS( XML_c, XML_dLbls ),
FSEND );
+
sal_Int32 nElem;
for( nElem = 0; nElem nSeriesLength; ++nElem)
{
@@ -2327,6 +2328,7 @@ void ChartExport::exportDataLabels(
namespace csscd =
::com::sun::star::chart::DataLabelPlacement;
sal_Int32 nPlacement(csscd::AVOID_OVERLAP);
const char *aPlacement = NULL;
+ OUString aSep;
if (GetProperty( xPropSet, LabelPlacement))
mAny = nPlacement;
@@ -2347,6 +2349,13 @@ void ChartExport::exportDataLabels(
pFS-startElement( FSNS( XML_c, XML_dLbl ), FSEND);
pFS-singleElement( FSNS( XML_c, XML_idx), XML_val,
I32S(nElem), FSEND);
pFS-singleElement( FSNS( XML_c, XML_dLblPos), XML_val,
aPlacement, FSEND);
+
+ if (GetProperty( xPropSet, LabelSeparator))
+ {
+ mAny = aSep;
+ pFS-singleElement( FSNS( XML_c, XML_separator),
XML_val, USS(aSep), FSEND);
+ }
+
pFS-singleElement( FSNS( XML_c, XML_showLegendKey),
XML_val,
aLabel.ShowLegendSymbol ? 1 : 0,
FSEND);
pFS-singleElement( FSNS( XML_c, XML_showVal), XML_val,
@@ -2355,6 +2364,10 @@ void ChartExport::exportDataLabels(
aLabel.ShowCategoryName ? 1 : 0,
FSEND);
pFS-singleElement( FSNS( XML_c, XML_showPercent), XML_val,
aLabel.ShowNumberInPercent ? 1 : 0,
FSEND);
+ // MSO somehow assumes series name to be on (=displayed) by
default.
+ // Let's put false here and switch it off then, since we
have no UI means
+ // in LibO to toggle it on anyway
+ pFS-singleElement( FSNS( XML_c, XML_showSerName), XML_val,
0, FSEND);
pFS-endElement( FSNS( XML_c, XML_dLbl ));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: scripting/examples
scripting/examples/python/HelloWorld.py |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit 270967f340670189e42939d9432e28e8259feefc Author: Xisco Fauli aniste...@gmail.com Date: Sun Feb 17 14:59:45 2013 +0100 fdo#60670: Create a new document in case there's none Change-Id: I7e03481beb1d4e60601fd93d787bc7354495e41f diff --git a/scripting/examples/python/HelloWorld.py b/scripting/examples/python/HelloWorld.py index 48e7786..4cad8a8 100644 --- a/scripting/examples/python/HelloWorld.py +++ b/scripting/examples/python/HelloWorld.py @@ -21,7 +21,12 @@ def HelloWorldPython( ): Prints the string 'Hello World(in Python)' into the current document #get the doc from the scripting context which is made available to all scripts -model = XSCRIPTCONTEXT.getDocument() +desktop = XSCRIPTCONTEXT.getDesktop() +model = desktop.getCurrentComponent() +#check whether there's already an opened document. Otherwise, create a new one +if not hasattr(model, Text): +model = desktop.loadComponentFromURL( +private:factory/swriter,_blank, 0, () ) #get the XText interface text = model.Text #create an XTextRange at the end of the document ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - 2 commits - scripting/examples wizards/com
scripting/examples/python/HelloWorld.py |7 ++- wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py |3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) New commits: commit 3e8af168ca227529b752abb9c7aecc42be4a2290 Author: Xisco Fauli aniste...@gmail.com Date: Fri Feb 15 20:19:16 2013 +0100 fdo#38451: Disable Sender and Recipient step Change-Id: I5ab0989ed4e5e30b97170cbba0d516eff4befc59 diff --git a/wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py b/wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py index 466cd61..23d2f77 100644 --- a/wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py +++ b/wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py @@ -287,10 +287,11 @@ class LetterWizardDialogImpl(LetterWizardDialog): self.xDialogModel.lstPrivateStyle.Enabled = False self.lstPrivOfficialStyleItemChanged() self.disableBusinessPaper() -self.enableSenderReceiver() +self.disableSenderReceiver() self.setPossibleFooter(True) if self.myPathSelection.xSaveTextBox.Text.lower(): self.myPathSelection.initializePath() +self.myLetterDoc.fillSenderWithUserData() def optPrivateLetterItemChanged(self): self.lstBusinessStylePos = None commit 70b6d7510d6910e046342114a79321ae8654764a Author: Xisco Fauli aniste...@gmail.com Date: Sun Feb 17 14:59:45 2013 +0100 fdo#60670: Create a new document in case there's none Change-Id: I7e03481beb1d4e60601fd93d787bc7354495e41f diff --git a/scripting/examples/python/HelloWorld.py b/scripting/examples/python/HelloWorld.py index 48e7786..4cad8a8 100644 --- a/scripting/examples/python/HelloWorld.py +++ b/scripting/examples/python/HelloWorld.py @@ -21,7 +21,12 @@ def HelloWorldPython( ): Prints the string 'Hello World(in Python)' into the current document #get the doc from the scripting context which is made available to all scripts -model = XSCRIPTCONTEXT.getDocument() +desktop = XSCRIPTCONTEXT.getDesktop() +model = desktop.getCurrentComponent() +#check whether there's already an opened document. Otherwise, create a new one +if not hasattr(model, Text): +model = desktop.loadComponentFromURL( +private:factory/swriter,_blank, 0, () ) #get the XText interface text = model.Text #create an XTextRange at the end of the document ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#3). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 693 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/3 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert xpdf to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2197 to look at the new patch set (#2). Change subject: convert xpdf to gbuild and add to tail_build .. convert xpdf to gbuild and add to tail_build Change-Id: Ie85f8092e0c37124508123a1d2f942f50f0740da --- M Module_tail_build.mk M RepositoryExternal.mk M RepositoryModule_ooo.mk M sdext/Library_pdfimport.mk M tail_build/prj/build.lst A xpdf/ExternalPackage_xpdf.mk A xpdf/ExternalProject_xpdf.mk A xpdf/Makefile A xpdf/Module_xpdf.mk A xpdf/UnpackedTarball_xpdf.mk D xpdf/makefile.mk M xpdf/prj/build.lst M xpdf/prj/d.lst D xpdf/prj/dmake M xpdf/xpdf-3.02.patch M xpdf/xpdf-no-writable-literals.patch 16 files changed, 138 insertions(+), 165 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/2197/2 -- To view, visit https://gerrit.libreoffice.org/2197 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie85f8092e0c37124508123a1d2f942f50f0740da Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#4). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 693 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/4 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
using backtrace() in exception throwing?
Hi Background: I'm looking at bug reports, and the messages are generally only marginally useful, because I generally have no idea where the original exception was actually thrown from. Sometimes the message in the exception will narrow it down a little, but that still often leaves a lot of likely places, and often the information I'm really interested in, is a few frames worth of callng stack information. What would be the costs of calling backtrace() http://www.gnu.org/software/libc/manual/html_node/Backtraces.html in the exception base class, storing a few frames worth of data, and then modifying the exception printing code to call backtrace_symbols() when writing out the exception? For me personally, this would really speed up tracking down the source of bugs. Regards, Noel Grandin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/Library_sd.mk sd/source
sd/Library_sd.mk |3 ++- sd/source/ui/remotecontrol/OSXBluetooth.mm |7 --- 2 files changed, 2 insertions(+), 8 deletions(-) New commits: commit c21916ad8a315a9dd7f23bf9aef0576975470a5a Author: Norbert Thiebaud nthieb...@gmail.com Date: Sun Feb 17 10:08:01 2013 -0600 pragma GCC diagnostic is not available for 4.0.1 Change-Id: I4aa9fb45c391c8b17d713e77a8a6e3338005441b diff --git a/sd/Library_sd.mk b/sd/Library_sd.mk index 4967845..6a967c5 100644 --- a/sd/Library_sd.mk +++ b/sd/Library_sd.mk @@ -543,7 +543,8 @@ else $(eval $(call gb_Library_add_objcxxobjects,sd,\ sd/source/ui/remotecontrol/BluetoothServer \ -sd/source/ui/remotecontrol/OSXBluetooth \ +sd/source/ui/remotecontrol/OSXBluetooth,\ +-Wno-error \ )) $(eval $(call gb_Library_add_libs,sd,\ diff --git a/sd/source/ui/remotecontrol/OSXBluetooth.mm b/sd/source/ui/remotecontrol/OSXBluetooth.mm index 1d4a3f0..ef1b700 100644 --- a/sd/source/ui/remotecontrol/OSXBluetooth.mm +++ b/sd/source/ui/remotecontrol/OSXBluetooth.mm @@ -6,7 +6,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ - #include osl/conditn.hxx // Include this early to avoid error as check() gets defined by some SDK header to empty #include premac.h @@ -43,12 +42,6 @@ pSocket = NULL; } -// The Xcode 3 compiler warns if we don't implement all methods of the -// IOBluetoothRFCOMMChannelDelegate protocol. In later SDKs they are -// marked as @optional. - -#pragma GCC diagnostic ignored -Wprotocol - @end /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Module_tail_build.mk RepositoryExternal.mk RepositoryModule_ooo.mk sdext/Library_pdfimport.mk tail_build/prj xpdf/ExternalPackage_xpdf.mk xpdf/ExternalProject_xpdf.mk x
Module_tail_build.mk |1 RepositoryExternal.mk|6 + RepositoryModule_ooo.mk |1 sdext/Library_pdfimport.mk |1 tail_build/prj/build.lst |2 xpdf/ExternalPackage_xpdf.mk | 24 + xpdf/ExternalProject_xpdf.mk | 46 ++ xpdf/Makefile|7 + xpdf/Module_xpdf.mk | 22 + xpdf/UnpackedTarball_xpdf.mk | 25 + xpdf/makefile.mk | 153 --- xpdf/prj/build.lst |2 xpdf/prj/d.lst |5 - xpdf/xpdf-3.02.patch |2 xpdf/xpdf-no-writable-literals.patch |6 - 15 files changed, 138 insertions(+), 165 deletions(-) New commits: commit fb1d11d9a54738562994ee6f7a5875f7a62d5863 Author: Peter Foley pefol...@verizon.net Date: Sun Feb 17 09:26:01 2013 -0500 convert xpdf to gbuild and add to tail_build Change-Id: Ie85f8092e0c37124508123a1d2f942f50f0740da Reviewed-on: https://gerrit.libreoffice.org/2197 Tested-by: LibreOffice gerrit bot ger...@libreoffice.org Reviewed-by: Peter Foley pefol...@verizon.net diff --git a/Module_tail_build.mk b/Module_tail_build.mk index 988edda..0495dac 100644 --- a/Module_tail_build.mk +++ b/Module_tail_build.mk @@ -210,6 +210,7 @@ $(eval $(call gb_Module_add_moduledirs,tail_build,\ xmerge \ $(call gb_Helper_optional,DESKTOP,xmlhelp) \ xmloff \ + $(call gb_Helper_optional,XPDF,xpdf) \ xmlreader \ xmlscript \ xmlsecurity \ diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index d0ad921..9031863 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -1741,8 +1741,12 @@ $(eval $(call gb_Helper_register_static_libraries,PLAINLIBS,\ )) define gb_LinkTarget__use_poppler +$(call gb_LinkTarget_use_package,$(1),xpdf) + $(call gb_LinkTarget_set_include,$(1),\ - -I$(OUTDIR)/inc/xpdf \ + -I$(call gb_UnpackedTarball_get_dir,xpdf) \ + -I$(call gb_UnpackedTarball_get_dir,xpdf)/xpdf \ + -I$(call gb_UnpackedTarball_get_dir,xpdf)/goo \ $$(INCLUDE) \ ) diff --git a/RepositoryModule_ooo.mk b/RepositoryModule_ooo.mk index 4256564..cf85f6e 100644 --- a/RepositoryModule_ooo.mk +++ b/RepositoryModule_ooo.mk @@ -223,6 +223,7 @@ $(eval $(call gb_Module_add_moduledirs,ooo,\ xmerge \ $(call gb_Helper_optional,DESKTOP,xmlhelp) \ xmloff \ + $(call gb_Helper_optional,XPDF,xpdf) \ xmlreader \ xmlscript \ xmlsecurity \ diff --git a/sdext/Library_pdfimport.mk b/sdext/Library_pdfimport.mk index ce171f2..260a39c 100644 --- a/sdext/Library_pdfimport.mk +++ b/sdext/Library_pdfimport.mk @@ -50,6 +50,7 @@ $(eval $(call gb_Library_use_static_libraries,pdfimport,\ $(eval $(call gb_Library_use_externals,pdfimport,\ boost_headers \ zlib \ +poppler \ )) $(eval $(call gb_Library_add_exception_objects,pdfimport,\ diff --git a/tail_build/prj/build.lst b/tail_build/prj/build.lst index b3643bb..e1851ff 100644 --- a/tail_build/prj/build.lst +++ b/tail_build/prj/build.lst @@ -1,2 +1,2 @@ -tb tail_build : EXPAT:expat MOZ:moz NSS:nss OPENSSL:openssl PYTHON:python3 XPDF:xpdf external solenv soltools NULL +tb tail_build : EXPAT:expat MOZ:moz NSS:nss OPENSSL:openssl PYTHON:python3 external solenv soltools NULL tb tail_build\prj nmake - all tb_prj NULL diff --git a/xpdf/ExternalPackage_xpdf.mk b/xpdf/ExternalPackage_xpdf.mk new file mode 100644 index 000..fd0a611 --- /dev/null +++ b/xpdf/ExternalPackage_xpdf.mk @@ -0,0 +1,24 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_ExternalPackage_ExternalPackage,xpdf,xpdf)) + +$(eval $(call gb_ExternalPackage_use_external_project,xpdf,xpdf)) + +ifeq ($(COM),MSC) +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/fofi.lib,fofi/fofi.lib)) +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/Goo.lib,goo/Goo.lib)) +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/xpdf.lib,xpdf/xpdf.lib)) +else +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/libfofi.a,fofi/libfofi.a)) +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/libGoo.a,goo/libGoo.a)) +$(eval $(call gb_ExternalPackage_add_file,xpdf,lib/libxpdf.a,xpdf/libxpdf.a)) +endif + +# vim: set noet sw=4 ts=4: diff --git a/xpdf/ExternalProject_xpdf.mk b/xpdf/ExternalProject_xpdf.mk new file mode 100644 index 000..3ad1d9c --- /dev/null +++ b/xpdf/ExternalProject_xpdf.mk @@ -0,0 +1,46 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is
[PUSHED] [PUSHED] convert xpdf to gbuild and add to tail_build
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2197 Approvals: LibreOffice gerrit bot: Verified Peter Foley: Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2197 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie85f8092e0c37124508123a1d2f942f50f0740da Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a rebased change. Please visit https://gerrit.libreoffice.org/2192 to look at the new rebased patch set (#5). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 693 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/5 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 5 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: mingw build is currently broken
Hi Rainer, On Sun, Feb 17, 2013 at 1:24 PM, Rainer Bielefeld libreoff...@bielefeldundbuss.de wrote: Andras Timar schrieb: I moved the SyntaxHighlighter class to comphelper (c16e9f4ed97f65357e9986f46ad88ee9f2237997). MinGW tinderbox is green again. Hi András, thank you for the fix, indeed, we get new builds. But the bad thing is, the last MinGW build that was at least a little useful I saw 1 year ago (or so). For example, build in master~2013-02-17_08.19.43_LibO-Dev_4.1.0.0.alpha0_Win_x86_archive terminates launch with a C++ Rungime Lib error message. Is it useful to report such MinGW problems? It seems currently the Tinderbox produces builds nobody cares. master~2013-02-17_08.19.43_LibO-Dev_4.1.0.0.alpha0_Win_x86_archive.tar.gz works for me (on Windows 7 64-bit) Regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
i18ned entry of numbers within LibreOffice
(Please keep me and Zolnai in CC in this discussion. Thanks.) In the context of https://gerrit.libreoffice.org/1994 Zolnai is contributing a nice feature to LibreOffice Base, but in the review of the patch I'm hitting what should be a simple issue: how to get a number (or special value All) from the user? My assumption is that in some locales we should allow the user to use other digits that the ASCII 0-9 (byte values 0x30 to 0x39). I *think* Zolnai's patch does this right, but could someone please check it out from this POV? Thanks in advance. Maybe there is even simpler (as in more code reuse instead of reinventing the wheel), and there is a vcl class that we can just derive from to get a number entry box? But we also need a special value All, so maybe Zolnai did it the simplest way possible already :) One question I'm less sure about: In the non-ASCII digit locales, is there any reason to reject ASCII digits? Should we do that? In all these questions, if we do the same as the other number entries in LibreOffice (e.g. font size, configuration of undo stack depth, ...), then I'm happy. I'm not trying to do better. Thanks in advance for the help, -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - test-bugzilla-files/test-bugzilla-files.py
test-bugzilla-files/test-bugzilla-files.py | 88 +++--
1 file changed, 46 insertions(+), 42 deletions(-)
New commits:
commit f77e09c7faed8cb244e4a5c5373041652a4fb8d3
Author: jorendc joren.libreoff...@telenet.be
Date: Sun Dec 30 02:50:18 2012 +0100
add Class State which creates 3 lists that we need to compare later
Conflicts:
test-bugzilla-files/test-bugzilla-files.py
diff --git a/test-bugzilla-files/test-bugzilla-files.py
b/test-bugzilla-files/test-bugzilla-files.py
index 62122a5..f66a5e7 100644
--- a/test-bugzilla-files/test-bugzilla-files.py
+++ b/test-bugzilla-files/test-bugzilla-files.py
@@ -149,12 +149,10 @@ class OfficeConnection:
print(...done)
#except com.sun.star.lang.DisposedException:
except
pyuno.getClass(com.sun.star.beans.UnknownPropertyException):
-print(caught UnknownPropertyException)
-print(crashed)
+print(caught UnknownPropertyException while TearDown)
pass # ignore, also means disposed
except pyuno.getClass(com.sun.star.lang.DisposedException):
-print(caught DisposedException)
-print(crashed)
+print(caught DisposedException while TearDown)
pass # ignore
else:
self.soffice.terminate()
@@ -292,12 +290,12 @@ def loadFromURL(xContext, url, connection):
if xListener:
xGEB.removeDocumentEventListener(xListener)
-def handleCrash(file, crashed_files):
+def handleCrash(file):
print(File: + file + crashed)
crashLog = open(crashlog.txt, a)
crashLog.write('Crash:' + file + '\n')
crashLog.close()
-crashed_files.append(file)
+#crashed_files.append(file)
# add here the remaining handling code for crashed files
class Alarm(Exception):
@@ -307,9 +305,9 @@ def alarm_handler():
os.system(killall -9 soffice.bin)
class LoadFileTest:
-def __init__(self, file, crashed_files):
+def __init__(self, file, stateNew):
self.file = file
-self.crashed_files = crashed_files
+self.stateNew = stateNew
def run(self, xContext, connection):
print(Loading document: + self.file)
t = None
@@ -325,7 +323,8 @@ class LoadFileTest:
t.cancel()
print(TIMEOUT!)
t.cancel()
-handleCrash(self.file, self.crashed_files)
+handleCrash(self.file)
+self.stateNew.badFiles.append(self.file)
connection.setUp()
except pyuno.getClass(com.sun.star.lang.DisposedException):
print(caught DisposedException + self.file)
@@ -333,7 +332,8 @@ class LoadFileTest:
print(TIMEOUT!)
else:
t.cancel()
-handleCrash(self.file, self.crashed_files)
+handleCrash(self.file)
+self.stateNew.badFiles.append(self.file)
connection.tearDown()
connection.setUp()
finally:
@@ -342,6 +342,13 @@ class LoadFileTest:
if xDoc:
xDoc.close(True)
print(...done with: + self.file)
+
+class State:
+def __init__(self):
+self.goodFiles = []
+self.badFiles = []
+self.unknown = []
+
validFileExtensions = [ .docx , .rtf, .odt, .doc ]
@@ -350,13 +357,14 @@ def runLoadFileTests(opts, dirs):
for suffix in validFileExtensions:
files.extend(getFiles(dirs, suffix))
files.sort()
-crashed_files = []
-tests = (LoadFileTest(file, crashed_files) for file in files)
+stateNew = State() #create stateNew instance
+tests = (LoadFileTest(file, stateNew) for file in files)
connection = PersistentConnection(opts)
-#connection = PerTestConnection(opts)
runConnectionTests(connection, simpleInvoke, tests)
connection.tearDown()
-print(crashed_files)
+print(stateNew.goodFiles)
+print(stateNew.badFiles)
+print(stateNew.unknown)
def parseArgs(argv):
(optlist,args) = getopt.getopt(argv[1:], hr,
commit 482bb1ae3cf7fdc7a3dfc30bfd371c95f09b8a65
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 18:01:57 2013 +0100
get the timeout working
diff --git a/test-bugzilla-files/test-bugzilla-files.py
b/test-bugzilla-files/test-bugzilla-files.py
index 7bf87d1..62122a5 100644
--- a/test-bugzilla-files/test-bugzilla-files.py
+++ b/test-bugzilla-files/test-bugzilla-files.py
@@ -33,6 +33,7 @@ import time
import uuid
import signal
+import threading
try:
from urllib.parse import quote
except ImportError:
@@ -164,8 +165,6 @@ class OfficeConnection:
if ret != 0:
raise Exception(Exit status indicates failure: + str(ret))
#return ret
-def kill(self):
-os.system(killall -9 soffice.bin)
class
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 51976, which changed state. Bug 51976 Summary: EDITING: Base embedded HSQLDB needs minutes for first Go to last record in the Table https://bugs.freedesktop.org/show_bug.cgi?id=51976 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: regarding patch 38838
Hi Prashant, 2013/2/17 Prashant Pandey prashant3.yi...@gmail.com Hi, I need some guidance as am stuck at a place. How should I replace 'erase' using guidelines given under https://wiki.documentfoundation.org/Development/String_Classes. If I try to fit 'replaceAt' in place of 'erase' in the line bolded below: *aRealStyle.Erase(aRealStyle.Search(aSep) + aSep.Len());* it will give me error (if I do : *aRealStyle.replaceAt(aRealStyle.indexOf(aSep) + aSep.getLength());*) Reason: replaceAt defined as: rtl::OUString rtl::OUString::replaceAt(sal_Int32, sal_Int32, const rtl::OUString) const (candidate expects 3 arguments, 1 provided) error: no matching function for call to ‘rtl::OUString::replaceAt(sal_Int32) My question is, what should I pass inside the replaceAt() parameters/arguments? I would suggest you write this: *sal_int32 idx = **aRealStyle.indexOf(aSep) + aSep.getLength();* ***aRealStyle = aRealStyle.replaceAt(idx, **aRealStyle.getLength() - **aRealStyle, );* Because: - If nIndex is set then can use replaceAt with an arg of an empty string (from the wiki page) - The second argument is the count, and here we replace until the end of the string - Since OUString is immutable, you must assign back the resulting OUString if you do not want to lose it Cheers, Jean-Noël ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#6). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 695 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/6 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 6 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 8 commits - sc/source
sc/source/core/data/colorscale.cxx|4 ++--
sc/source/core/data/postit.cxx|3 ++-
sc/source/filter/dif/difimp.cxx |2 +-
sc/source/filter/excel/xecontent.cxx |2 +-
sc/source/filter/xml/xmldpimp.cxx |3 +--
sc/source/filter/xml/xmldpimp.hxx |2 +-
sc/source/ui/Accessibility/AccessibleDocument.cxx |2 ++
sc/source/ui/docshell/docfunc.cxx |1 +
sc/source/ui/docshell/impex.cxx | 19 +++
9 files changed, 18 insertions(+), 20 deletions(-)
New commits:
commit b3652dae4b4d3f02fc0c02d9e139391ef43d7ba5
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 19:06:17 2013 +0100
coverity: fix memory leak
Change-Id: I2a620971d70c021c7a31dac14ce76f3428324f26
diff --git a/sc/source/core/data/colorscale.cxx
b/sc/source/core/data/colorscale.cxx
index 0d17fa6..e4183e7 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -889,8 +889,6 @@ ScIconSetInfo* ScIconSetFormat::GetIconSetInfo(const
ScAddress rAddr) const
return NULL;
}
-ScIconSetInfo* pInfo = new ScIconSetInfo;
-
// now we have for sure a value
double nVal = mpDoc-GetValue(rAddr);
@@ -919,6 +917,8 @@ ScIconSetInfo* ScIconSetFormat::GetIconSetInfo(const
ScAddress rAddr) const
if(nVal = nValMax)
++nIndex;
+ScIconSetInfo* pInfo = new ScIconSetInfo;
+
if(mpFormatData-mbReverse)
{
sal_Int32 nMaxIndex = mpFormatData-maEntries.size() - 1;
commit 68e10304389fee75bc069d25c5bfe4b50d0b58a4
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 19:04:35 2013 +0100
coverity: make clear that this is safe
Change-Id: Ibcc313700862e0dcb630e98a13e451d3b5035a7f
diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index 5ca89b1..00ec727 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -1038,7 +1038,8 @@ ScPostIt* ScNotes::GetOrCreateNote(const ScAddress rPos)
else
{
ScPostIt* pPostIt = new ScPostIt(*mpDoc, rPos, false);
-insert(rPos, pPostIt);
+if(!insert(rPos, pPostIt))
+assert(false);
return pPostIt;
}
}
commit 4254672d6a4adccedeaf899faf86f7763afb2bed
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 18:59:48 2013 +0100
coverity: fix memory leak
Change-Id: Ib471de0977614996cda1e58ccb17d7cd6cadda7f
diff --git a/sc/source/filter/dif/difimp.cxx b/sc/source/filter/dif/difimp.cxx
index e03a9a8..b4f4508 100644
--- a/sc/source/filter/dif/difimp.cxx
+++ b/sc/source/filter/dif/difimp.cxx
@@ -930,7 +930,7 @@ DifAttrCache::~DifAttrCache()
delete ppCols[ nCnt ];
}
-delete ppCols;
+delete[] ppCols;
}
void DifAttrCache::SetLogical( const SCCOL nCol, const SCROW nRow )
commit db62ad5984d19f5af57f38d21aa98b709030a2cf
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 18:57:15 2013 +0100
coverity: fix memory leak
Change-Id: Ice50e9b84ab4ce0d02072c5fb40ed313692b
diff --git a/sc/source/filter/excel/xecontent.cxx
b/sc/source/filter/excel/xecontent.cxx
index 3f35f5e..9a7b96e 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -911,7 +911,7 @@ void XclExpCFImpl::SaveXml( XclExpXmlStream rStrm )
// we need to write the text without quotes
// we have to actually get the string from
// the token array for that
-ScTokenArray* pTokenArray = mrFormatEntry.CreateTokenArry(0);
+boost::scoped_ptrScTokenArray
pTokenArray(mrFormatEntry.CreateTokenArry(0));
if(pTokenArray-GetLen())
aText = XclXmlUtils::ToOString(pTokenArray-First()-GetString());
}
commit a62303c13161b5fbe620d69aa82f02997fe41bee
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 18:50:43 2013 +0100
coverity: fix memory leak
Change-Id: I57937130d6ef40743c1b13d10783a6810a8d
diff --git a/sc/source/filter/xml/xmldpimp.cxx
b/sc/source/filter/xml/xmldpimp.cxx
index ac42282..8b269af 100644
--- a/sc/source/filter/xml/xmldpimp.cxx
+++ b/sc/source/filter/xml/xmldpimp.cxx
@@ -112,7 +112,6 @@ ScXMLDataPilotTableContext::ScXMLDataPilotTableContext(
ScXMLImport rImport,
SvXMLImportContext( rImport, nPrfx, rLName ),
pDoc(GetScImport().GetDocument()),
pDPObject(NULL),
-pDPSave(NULL),
pDPDimSaveData(NULL),
sDataPilotTableName(),
sApplicationData(),
@@ -216,7 +215,7 @@ ScXMLDataPilotTableContext::ScXMLDataPilotTableContext(
ScXMLImport rImport,
}
pDPObject = new ScDPObject(pDoc);
-pDPSave = new ScDPSaveData();
+pDPSave.reset(new ScDPSaveData());
}
ScXMLDataPilotTableContext::~ScXMLDataPilotTableContext()
diff --git a/sc/source/filter/xml/xmldpimp.hxx
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#7). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 695 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/7 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 7 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sdext/source vcl/source
sdext/source/pdfimport/tree/drawtreevisiting.cxx |2 +-
sdext/source/pdfimport/tree/pdfiprocessor.cxx|4 +++-
sdext/source/pdfimport/tree/pdfiprocessor.hxx|2 +-
vcl/source/window/dlgctrl.cxx|3 +--
4 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 07ee72672e6966dafccf21ca3349e428c2a9dd0a
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 19:53:00 2013 +0100
coverity: pass by const reference is more efficient
Change-Id: Iec40176a5dd567e667178f07fecd043fe0aa4344
diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
index 8f4c16c..9a38e3d 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
@@ -666,7 +666,7 @@ bool isSpaces(TextElement* pTextElem)
return true;
}
-bool notTransformed(GraphicsContext GC)
+bool notTransformed(const GraphicsContext GC)
{
return (
GC.Transformation.get(0,0) == 100.00
commit c66ec11c41c9519e2f9462ae7fe2b54927f6bc77
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Feb 17 19:50:41 2013 +0100
coverity: pass by const reference is more efficient
Change-Id: I08cebe4aca8eaa5a2be8c319c2de20de10dbd2d3
diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
index 0e9955f..a457d47 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
@@ -486,9 +486,10 @@ GraphicsContext PDFIProcessor::getTransformGlyphContext(
CharGlyph rGlyph )
return rGlyph.getGC();
}
+
void PDFIProcessor::drawCharGlyphs( rtl::OUString rGlyphs,
geometry::RealRectangle2D rRect,
-GraphicsContext aGC,
+const GraphicsContext aGC,
ParagraphElement* pPara,
FrameElement* pFrame,
bool bSpaceFlag )
@@ -523,6 +524,7 @@ void PDFIProcessor::drawCharGlyphs( rtl::OUString
rGlyphs,
pFrame-updateGeometryWith( pPara );
}
+
void PDFIProcessor::drawGlyphs( const rtl::OUString rGlyphs,
const geometry::RealRectangle2D rRect,
const geometry::Matrix2DrFontMatrix )
diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.hxx
b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
index 1e4af25..e86ccfe 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.hxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
@@ -116,7 +116,7 @@ namespace pdfi
void drawCharGlyphs( rtl::OUString rGlyphs,
::com::sun::star::geometry::RealRectangle2D
rRect,
- GraphicsContext aGC,
+ const GraphicsContext aGC,
ParagraphElement* pPara,
FrameElement* pFrame,
bool bSpaceFlag );
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index 15078a0..19d68a0 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -1167,10 +1167,9 @@ static Window* ImplGetLabelFor( Window* pFrameWindow,
WindowType nMyType, Window
// #i100833# MT 2010/02: Group box and fixed lines can also lable a
fixed text.
// See tools/options/print for example.
sal_Bool bThisIsAGroupControl = (nMyType == WINDOW_GROUPBOX) ||
(nMyType == WINDOW_FIXEDLINE);
-Window* pSWindow = NULL;
// get index, form start and form end
sal_uInt16 nIndex=0, nFormStart=0, nFormEnd=0;
-pSWindow = ::ImplFindDlgCtrlWindow( pFrameWindow,
+Window* pSWindow = ::ImplFindDlgCtrlWindow( pFrameWindow,
pLabel,
nIndex,
nFormStart,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#8). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 695 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/8 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 8 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build LibreOffice on Mac OS X
Raphaël, hello? Any progress? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] convert sysui to gbuild and add to tail_build
Hello LibreOffice gerrit bot, I'd like you to reexamine a change. Please visit https://gerrit.libreoffice.org/2192 to look at the new patch set (#9). Change subject: convert sysui to gbuild and add to tail_build .. convert sysui to gbuild and add to tail_build Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a --- M Module_cross_tail_build.mk M Module_tail_build.mk M RepositoryModule_ooo.mk M cross_toolset/prj/build.lst M postprocess/prj/build.lst M solenv/gbuild/TargetLocations.mk A sysui/CustomTarget_deb.mk A sysui/CustomTarget_infoplist.mk A sysui/CustomTarget_rpm.mk A sysui/CustomTarget_share.mk A sysui/CustomTarget_slackware.mk A sysui/CustomTarget_solaris.mk A sysui/Makefile A sysui/Module_sysui.mk A sysui/Package_desktop.mk A sysui/Package_icons.mk A sysui/Package_infoplist.mk A sysui/Package_share.mk A sysui/Zip_osxicons.mk D sysui/desktop/cleanversion/makefile.mk D sysui/desktop/debian/makefile.mk D sysui/desktop/freedesktop/makefile.mk D sysui/desktop/icons/makefile.mk D sysui/desktop/macosx/delzip D sysui/desktop/macosx/makefile.mk D sysui/desktop/mandriva/makefile.mk D sysui/desktop/productversion.mk M sysui/desktop/share/create_tree.sh D sysui/desktop/share/makefile.mk M sysui/desktop/share/translate.pl D sysui/desktop/slackware/makefile.mk D sysui/desktop/solaris/makefile.mk D sysui/desktop/suse/makefile.mk D sysui/desktop/tg_rpm.mk D sysui/desktop/util/makefile.mk M sysui/prj/build.lst M sysui/prj/d.lst D sysui/prj/dmake D sysui/util/checksize.pl D sysui/util/makefile.mk 40 files changed, 695 insertions(+), 1,228 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/2192/9 -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 9 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scp2/source
scp2/source/calc/file_calc.scp |9 - scp2/source/draw/file_draw.scp | 10 -- scp2/source/impress/file_impress.scp | 10 -- scp2/source/math/file_math.scp | 10 -- scp2/source/writer/file_writer.scp | 23 --- 5 files changed, 62 deletions(-) New commits: commit c3a8667d69b8e270fe6a3aed00d86a39dd4f0be7 Author: Tor Lillqvist t...@iki.fi Date: Sun Feb 17 22:45:27 2013 +0200 Remove some bits that have been commented out since 2004 Change-Id: Ibd95e9ea1c3ab6f24e0a469108191e59b049823e diff --git a/scp2/source/calc/file_calc.scp b/scp2/source/calc/file_calc.scp index c9fdf18..e768887 100644 --- a/scp2/source/calc/file_calc.scp +++ b/scp2/source/calc/file_calc.scp @@ -78,15 +78,6 @@ File gid_File_Help_Scalc_Zip End #endif -// new user interface configuration files -/* -File gid_File_Share_Config_Sofficecfg_Calc_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Scalc_Menubar; -Name = /uiconfig/scalc/menubar/menubar.xml; -End -*/ File gid_File_Exe_Scalc BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; diff --git a/scp2/source/draw/file_draw.scp b/scp2/source/draw/file_draw.scp index 9a388bc..26428ab 100644 --- a/scp2/source/draw/file_draw.scp +++ b/scp2/source/draw/file_draw.scp @@ -54,13 +54,3 @@ File gid_File_Exe_Sdraw Styles = (PACKED); #endif End - -// new user interface configuration files -/* -File gid_File_Share_Config_Sofficecfg_Draw_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Sdraw_Menubar; -Name = /uiconfig/sdraw/menubar/menubar.xml; -End -*/ diff --git a/scp2/source/impress/file_impress.scp b/scp2/source/impress/file_impress.scp index 21deb8e..1958046 100644 --- a/scp2/source/impress/file_impress.scp +++ b/scp2/source/impress/file_impress.scp @@ -76,16 +76,6 @@ File gid_File_Exe_Simpress #endif End -// new user interface configuration files -/* -File gid_File_Share_Config_Sofficecfg_Impress_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Simpress_Menubar; -Name = /uiconfig/simpress/menubar/menubar.xml; -End -*/ - // configuration files for custom animation effects File gid_File_Share_Config_Sofficecfg_Impress_Effects_Xml diff --git a/scp2/source/math/file_math.scp b/scp2/source/math/file_math.scp index f3bbd32..8da1031 100644 --- a/scp2/source/math/file_math.scp +++ b/scp2/source/math/file_math.scp @@ -70,13 +70,3 @@ File gid_File_Exe_Smath Styles = (PACKED); #endif End - -// new user interface configuration files -/* -File gid_File_Share_Config_Sofficecfg_Math_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Smath_Menubar; -Name = /uiconfig/smath/menubar/menubar.xml; -End -*/ diff --git a/scp2/source/writer/file_writer.scp b/scp2/source/writer/file_writer.scp index 3c831d8..4d8e65a 100644 --- a/scp2/source/writer/file_writer.scp +++ b/scp2/source/writer/file_writer.scp @@ -62,29 +62,6 @@ File gid_File_Help_Swriter_Zip End #endif -/* -File gid_File_Share_Config_Sofficecfg_Writer_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Swriter_Menubar; -Name = /uiconfig/swriter/menubar/menubar.xml; -End - -File gid_File_Share_Config_Sofficecfg_Writerweb_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Sweb_Menubar; -Name = /uiconfig/sweb/menubar/menubar.xml; -End - -File gid_File_Share_Config_Sofficecfg_Writerglobal_Menubar_Xml -TXT_FILE_BODY; -Styles = (PACKED); -Dir = gid_Dir_Share_Config_Sofficecfg_Sglobal_Menubar; -Name = /uiconfig/sglobal/menubar/menubar.xml; -End -*/ - File gid_File_Share_Registry_Writer_Xcd TXT_FILE_BODY; Styles = (PACKED); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: regarding patch 38838
Hi Jean, Thanks for help ! Finally, I did : *aRealStyle.copy(0,(aRealStyle.Search(aSep) + aSep.Len())); * It also worked :) Thanks once again! -Prashant On Sun, Feb 17, 2013 at 11:11 PM, Jean-Noël Rouvignac jn.rouvig...@gmail.com wrote: Hi Prashant, 2013/2/17 Prashant Pandey prashant3.yi...@gmail.com Hi, I need some guidance as am stuck at a place. How should I replace 'erase' using guidelines given under https://wiki.documentfoundation.org/Development/String_Classes. If I try to fit 'replaceAt' in place of 'erase' in the line bolded below: *aRealStyle.Erase(aRealStyle.Search(aSep) + aSep.Len());* it will give me error (if I do : *aRealStyle.replaceAt(aRealStyle.indexOf(aSep) + aSep.getLength());*) Reason: replaceAt defined as: rtl::OUString rtl::OUString::replaceAt(sal_Int32, sal_Int32, const rtl::OUString) const (candidate expects 3 arguments, 1 provided) error: no matching function for call to ‘rtl::OUString::replaceAt(sal_Int32) My question is, what should I pass inside the replaceAt() parameters/arguments? I would suggest you write this: *sal_int32 idx = **aRealStyle.indexOf(aSep) + aSep.getLength();* ***aRealStyle = aRealStyle.replaceAt(idx, **aRealStyle.getLength() - * *aRealStyle, );* Because: - If nIndex is set then can use replaceAt with an arg of an empty string (from the wiki page) - The second argument is the count, and here we replace until the end of the string - Since OUString is immutable, you must assign back the resulting OUString if you do not want to lose it Cheers, Jean-Noël ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: regarding patch 38838
Sorry, it was *aRealStyle.copy(aRealStyle.Search(aSep) + aSep.Len());*which made it through correctly. Thanks Prashant On Mon, Feb 18, 2013 at 3:06 AM, Prashant Pandey prashant3.yi...@gmail.comwrote: Hi Jean, Thanks for help ! Finally, I did : *aRealStyle.copy(0,(aRealStyle.Search(aSep) + aSep.Len()));* It also worked :) Thanks once again! -Prashant On Sun, Feb 17, 2013 at 11:11 PM, Jean-Noël Rouvignac jn.rouvig...@gmail.com wrote: Hi Prashant, 2013/2/17 Prashant Pandey prashant3.yi...@gmail.com Hi, I need some guidance as am stuck at a place. How should I replace 'erase' using guidelines given under https://wiki.documentfoundation.org/Development/String_Classes. If I try to fit 'replaceAt' in place of 'erase' in the line bolded below: *aRealStyle.Erase(aRealStyle.Search(aSep) + aSep.Len());* it will give me error (if I do : *aRealStyle.replaceAt(aRealStyle.indexOf(aSep) + aSep.getLength());*) Reason: replaceAt defined as: rtl::OUString rtl::OUString::replaceAt(sal_Int32, sal_Int32, const rtl::OUString) const (candidate expects 3 arguments, 1 provided) error: no matching function for call to ‘rtl::OUString::replaceAt(sal_Int32) My question is, what should I pass inside the replaceAt() parameters/arguments? I would suggest you write this: *sal_int32 idx = **aRealStyle.indexOf(aSep) + aSep.getLength();* ***aRealStyle = aRealStyle.replaceAt(idx, **aRealStyle.getLength() - **aRealStyle, );* Because: - If nIndex is set then can use replaceAt with an arg of an empty string (from the wiki page) - The second argument is the count, and here we replace until the end of the string - Since OUString is immutable, you must assign back the resulting OUString if you do not want to lose it Cheers, Jean-Noël ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: regarding patch 38838
I've changed several files. When I try to 'make' : a lot of stuff is printed regarding XShape, CustomShapeGeometry, PointSequence, etc Then error is printed as : diff.cxx:332:Assertion Test name: SdFiltersTest::test double equality assertion failed - Expected: 3433903 - Actual : 0 - Delta : 1e-08 - startColor Failures !!! Run: 3 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: export DEBUGCPPUNIT=TRUE# for exception catching export GDBCPPUNITTRACE=gdb --args # for interactive debugging export VALGRIND=memcheck# for memory checking and retry. make[1]: *** [/home/elixir/lo/workdir/ unxlngx6.pro/CppunitTest/sd_regression_test.test] Error 1 make[1]: *** Waiting for unfinished jobs Can't get rid of it and i don't have any clue too, please guide ! Thanking you in anticipation. Regards Prashant On Mon, Feb 18, 2013 at 3:09 AM, Prashant Pandey prashant3.yi...@gmail.comwrote: Sorry, it was *aRealStyle.copy(aRealStyle.Search(aSep) + aSep.Len());*which made it through correctly. Thanks Prashant On Mon, Feb 18, 2013 at 3:06 AM, Prashant Pandey prashant3.yi...@gmail.com wrote: Hi Jean, Thanks for help ! Finally, I did : *aRealStyle.copy(0,(aRealStyle.Search(aSep) + aSep.Len()));* It also worked :) Thanks once again! -Prashant On Sun, Feb 17, 2013 at 11:11 PM, Jean-Noël Rouvignac jn.rouvig...@gmail.com wrote: Hi Prashant, 2013/2/17 Prashant Pandey prashant3.yi...@gmail.com Hi, I need some guidance as am stuck at a place. How should I replace 'erase' using guidelines given under https://wiki.documentfoundation.org/Development/String_Classes. If I try to fit 'replaceAt' in place of 'erase' in the line bolded below: *aRealStyle.Erase(aRealStyle.Search(aSep) + aSep.Len());* it will give me error (if I do : *aRealStyle.replaceAt(aRealStyle.indexOf(aSep) + aSep.getLength());*) Reason: replaceAt defined as: rtl::OUString rtl::OUString::replaceAt(sal_Int32, sal_Int32, const rtl::OUString) const (candidate expects 3 arguments, 1 provided) error: no matching function for call to ‘rtl::OUString::replaceAt(sal_Int32) My question is, what should I pass inside the replaceAt() parameters/arguments? I would suggest you write this: *sal_int32 idx = **aRealStyle.indexOf(aSep) + aSep.getLength();* ***aRealStyle = aRealStyle.replaceAt(idx, **aRealStyle.getLength() - **aRealStyle, );* Because: - If nIndex is set then can use replaceAt with an arg of an empty string (from the wiki page) - The second argument is the count, and here we replace until the end of the string - Since OUString is immutable, you must assign back the resulting OUString if you do not want to lose it Cheers, Jean-Noël ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9b5975072ccd67279f653e982f9a044d5262c4e2 Author: Andras Timar ati...@suse.com Date: Sun Feb 17 22:56:15 2013 +0100 Updated core Project: translations cf576bff556326dcf418d6781c1b71637ce08217 diff --git a/translations b/translations index dd4d177..cf576bf 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit dd4d1778cdac6d5b5b8a611f7a64f1bbd7118be4 +Subproject commit cf576bff556326dcf418d6781c1b71637ce08217 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: RepositoryExternal.mk
RepositoryExternal.mk |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 3743cdbbf499800acd370d2082b0ab88817e4eb0 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 17 22:58:21 2013 +0100 Let BOOST_SYSTEM_LIB be found in --with-system-boost --with-boost=... case Change-Id: If767692e8a3eda4d970c9b3e6affd8d3e4f7f38d diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 9031863..c072b8f 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -2251,7 +2251,10 @@ $(call gb_LinkTarget_set_include,$(1),\ ) $(call gb_LinkTarget_use_static_libraries,$(1),orcus) -$(if $(filter YES,$(SYSTEM_BOOST)),$(call gb_LinkTarget_add_libs,$(1),$(BOOST_SYSTEM_LIB))) +$(if $(filter YES,$(SYSTEM_BOOST)), \ +$(call gb_LinkTarget_add_ldflags,$(1),$(BOOST_LDFLAGS)) \ +$(call gb_LinkTarget_add_libs,$(1),$(BOOST_SYSTEM_LIB)) \ +) endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] [PUSHED] convert sysui to gbuild and add to tail_build
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2192 Approvals: LibreOffice gerrit bot: Verified David Ostrovsky: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2192 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia32e51f0d95e001bcf07766f6340398e0ab1bf6a Gerrit-PatchSet: 10 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Peter Foley pefol...@verizon.net Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Peter Foley pefol...@verizon.net ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - basegfx/source sdext/source
basegfx/source/polygon/b2dpolygontools.cxx |2 +-
sdext/source/presenter/PresenterScreen.cxx | 20 ++--
sdext/source/presenter/PresenterScreen.hxx |8 ++--
3 files changed, 17 insertions(+), 13 deletions(-)
New commits:
commit d100aaaeacdf99363069319e5936eae9ff21cce9
Author: Caolán McNamara caol...@redhat.com
Date: Sun Feb 17 22:02:03 2013 +
coverity#984038 Uninitialized scalar variable
Change-Id: I6c460ea0ca039ccc8d62bb7a7005832fb809f369
diff --git a/basegfx/source/polygon/b2dpolygontools.cxx
b/basegfx/source/polygon/b2dpolygontools.cxx
index 926ff90..56176e5 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -2451,7 +2451,7 @@ namespace basegfx
const sal_uInt32 nNextIndex((a + 1) % nPointCount);
aBezier.setEndPoint(rCandidate.getB2DPoint(nNextIndex));
double fEdgeDist;
-double fNewCut;
+double fNewCut(0.0);
bool bEdgeIsCurve(false);
if(rCandidate.areControlPointsUsed())
commit ba9da7f098a32813d9e8c30982c6bcf64ed0c2ff
Author: Caolán McNamara caol...@redhat.com
Date: Sun Feb 17 21:58:45 2013 +
coverity#984041 Uninitialized scalar variable
Change-Id: Ia726b08717d26b439f46f95dedfdb30e27e8499e
diff --git a/sdext/source/presenter/PresenterScreen.cxx
b/sdext/source/presenter/PresenterScreen.cxx
index 1ac2933..2028887 100644
--- a/sdext/source/presenter/PresenterScreen.cxx
+++ b/sdext/source/presenter/PresenterScreen.cxx
@@ -396,14 +396,14 @@ void PresenterScreen::InitializePresenterScreen (void)
mpPresenterController-GetWindowManager()-RestoreViewMode();
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
xCC-restoreConfiguration(mxSavedConfiguration);
}
xCC-unlock();
}
}
-catch (Exception)
+catch (const Exception)
{
}
}
@@ -501,7 +501,7 @@ sal_Int32 PresenterScreen::GetPresenterScreenNumber (
return -1;
}
}
-catch (beans::UnknownPropertyException)
+catch (const beans::UnknownPropertyException)
{
OSL_ASSERT(false);
// For some reason we can not access the screen number. Use
@@ -608,7 +608,7 @@ void PresenterScreen::SetupPaneFactory (const
ReferenceXComponentContext rxCo
mxController,
mpPresenterController);
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
OSL_ASSERT(false);
}
@@ -624,7 +624,7 @@ void PresenterScreen::SetupViewFactory (const
ReferenceXComponentContext rxCo
mxController,
mpPresenterController);
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
OSL_ASSERT(false);
}
@@ -647,7 +647,7 @@ void PresenterScreen::SetupConfiguration (
OUString(Presenter/CurrentLayout)) = sLayoutName;
ProcessLayout(aConfiguration, sLayoutName, rxContext, rxAnchorId);
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
}
}
@@ -701,7 +701,7 @@ void PresenterScreen::ProcessLayout (
rxContext,
rxAnchorId));
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
}
}
@@ -726,7 +726,7 @@ void PresenterScreen::ProcessViewDescriptions (
aProperties,
::boost::bind(PresenterScreen::ProcessViewDescription, this, _1,
_2));
}
-catch (RuntimeException)
+catch (const RuntimeException)
{
OSL_ASSERT(false);
}
@@ -798,8 +798,8 @@ void PresenterScreen::ProcessViewDescription (
if (aViewDescriptor.msAccessibleTitle.isEmpty())
aViewDescriptor.msAccessibleTitle = aViewDescriptor.msTitle;
maViewDescriptors[sViewURL] = aViewDescriptor;
- }
-catch (Exception)
+}
+catch (const Exception)
{
OSL_ASSERT(false);
}
diff --git a/sdext/source/presenter/PresenterScreen.hxx
b/sdext/source/presenter/PresenterScreen.hxx
index 16a3e05..2538fea 100644
--- a/sdext/source/presenter/PresenterScreen.hxx
+++ b/sdext/source/presenter/PresenterScreen.hxx
@@ -145,9 +145,13 @@ private:
class ViewDescriptor
{
public:
-::rtl::OUString msTitle;
-::rtl::OUString msAccessibleTitle;
+OUString msTitle;
+OUString msAccessibleTitle;
bool mbIsOpaque;
+ViewDescriptor()
+: mbIsOpaque(false)
+{
+}
};
typedef ::std::maprtl::OUString,ViewDescriptor ViewDescriptorContainer;
ViewDescriptorContainer maViewDescriptors;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 134374473ea481410f389cab162a52fab62c5c43 Author: Andras Timar ati...@suse.com Date: Sun Feb 17 22:56:15 2013 +0100 Updated core Project: translations 6928867911fdb1e2c78092c99b5731350d926b45 diff --git a/translations b/translations index 6ee4658..6928867 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 6ee465836d1fee4b4fbe714bde3b804cdda1b4ff +Subproject commit 6928867911fdb1e2c78092c99b5731350d926b45 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - test-bugzilla-files/test-bugzilla-files.py
test-bugzilla-files/test-bugzilla-files.py | 82 +++-- 1 file changed, 55 insertions(+), 27 deletions(-) New commits: commit f6a935d7b779ecb0938de5056ddaea0d05be9b44 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Feb 17 23:20:20 2013 +0100 make the soffice window hidden again diff --git a/test-bugzilla-files/test-bugzilla-files.py b/test-bugzilla-files/test-bugzilla-files.py index bcd33fc..2d2b387 100644 --- a/test-bugzilla-files/test-bugzilla-files.py +++ b/test-bugzilla-files/test-bugzilla-files.py @@ -118,7 +118,7 @@ class OfficeConnection: argv = [ soffice, --accept= + socket + ;urp, -env:UserInstallation= + userdir, --quickstart=no, --nofirststartwizard, ---norestore, --nologo ] +--norestore, --nologo, --headless ] if --valgrind in self.args: argv.append(--valgrind) self.pro = subprocess.Popen(argv) commit 39ec29e0432b4a16f66aae71457807a6386096f2 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Feb 17 23:16:18 2013 +0100 fix some problems with test-bugzilla-files script diff --git a/test-bugzilla-files/test-bugzilla-files.py b/test-bugzilla-files/test-bugzilla-files.py index f66a5e7..bcd33fc 100644 --- a/test-bugzilla-files/test-bugzilla-files.py +++ b/test-bugzilla-files/test-bugzilla-files.py @@ -31,6 +31,7 @@ import subprocess import sys import time import uuid +import datetime import signal import threading @@ -267,11 +268,12 @@ def loadFromURL(xContext, url, connection): try: xDoc = None xDoc = xDesktop.loadComponentFromURL(url, _blank, 0, loadProps) -while True: +time_ = 0 +while time_ 30: if xListener.layoutFinished: -t.cancel() return xDoc print(delaying...) +time_ += 1 time.sleep(1) except pyuno.getClass(com.sun.star.beans.UnknownPropertyException): xListener = None @@ -298,42 +300,42 @@ def handleCrash(file): #crashed_files.append(file) # add here the remaining handling code for crashed files -class Alarm(Exception): -pass - def alarm_handler(): os.system(killall -9 soffice.bin) class LoadFileTest: -def __init__(self, file, stateNew): +def __init__(self, file, state): self.file = file -self.stateNew = stateNew +self.state = state def run(self, xContext, connection): print(Loading document: + self.file) t = None try: url = file:// + quote(self.file) xDoc = None -t = threading.Timer(5, alarm_handler) +t = threading.Timer(40, alarm_handler) t.start() xDoc = loadFromURL(xContext, url, connection) +self.state.goodFiles.append(self.file) except pyuno.getClass(com.sun.star.beans.UnknownPropertyException): print(caught UnknownPropertyException + self.file) if not t.is_alive(): -t.cancel() print(TIMEOUT!) -t.cancel() -handleCrash(self.file) -self.stateNew.badFiles.append(self.file) +self.state.timeoutFiles.append(self.file) +else: +t.cancel() +handleCrash(self.file) +self.state.badFiles.append(self.file) connection.setUp() except pyuno.getClass(com.sun.star.lang.DisposedException): print(caught DisposedException + self.file) if not t.is_alive(): print(TIMEOUT!) +self.state.timeoutFiles.append(self.file) else: t.cancel() handleCrash(self.file) -self.stateNew.badFiles.append(self.file) +self.state.badFiles.append(self.file) connection.tearDown() connection.setUp() finally: @@ -347,24 +349,50 @@ class State: def __init__(self): self.goodFiles = [] self.badFiles = [] -self.unknown = [] +self.timeoutFiles = [] validFileExtensions = [ .docx , .rtf, .odt, .doc ] +def writeReport(state, startTime): +goodFiles = open(goodFiles.log, w) +goodFiles.write(All files tested which opened perfectly:\n) +goodFiles.write(Starttime: + startTime.isoformat() +\n) +for file in state.goodFiles: +goodFiles.write(file) +goodFiles.write(\n) +goodFiles.close() +badFiles = open(badFiles.log, w) +badFiles.write(All files tested which crashed:\n) +badFiles.write(Starttime: + startTime.isoformat() + \n) +for file in state.badFiles: +badFiles.write(file) +badFiles.write(\n) +badFiles.close() +timeoutFiles = open(timeoutFiles.log, w) +timeoutFiles.write(All files tested which timed out:\n) +
Re: regarding patch 38838
On Sun, Feb 17, 2013 at 3:36 PM, Prashant Pandey prashant3.yi...@gmail.com wrote: Hi Jean, Thanks for help ! Finally, I did : aRealStyle.copy(0,(aRealStyle.Search(aSep) + aSep.Len())); It also worked :) No it did not work. it compiled, but it does not do the same as the orginal code. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: regarding patch 38838
Hi Nobert, I corrected myself in the following mail with this one. I did : aRealStyle.copy(aRealStyle.indexOf(aSep) + aSep.getLength()); which I suppose is doing the same thing as required. since foo.erase(0,n) = foo=foo.copy(n) Still, if I am wrong, then please inform. Thanks Prashant On Mon, Feb 18, 2013 at 4:17 AM, Norbert Thiebaud nthieb...@gmail.comwrote: On Sun, Feb 17, 2013 at 3:36 PM, Prashant Pandey prashant3.yi...@gmail.com wrote: Hi Jean, Thanks for help ! Finally, I did : aRealStyle.copy(0,(aRealStyle.Search(aSep) + aSep.Len())); It also worked :) No it did not work. it compiled, but it does not do the same as the orginal code. Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#57950: Remove more chained appends in filter
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2186
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/2186/1
fdo#57950: Remove more chained appends in filter
And also sanitize some OUStringBuffer uses.
Change-Id: I338b18981e1f925d76c0d640159de30bab219122
---
M filter/source/msfilter/msvbahelper.cxx
M filter/source/msfilter/svdfppt.cxx
M filter/source/pdf/pdfexport.cxx
M filter/source/svg/svgwriter.cxx
M filter/source/svg/test/odfserializer.cxx
M filter/source/xsltfilter/XSLTFilter.cxx
6 files changed, 17 insertions(+), 45 deletions(-)
diff --git a/filter/source/msfilter/msvbahelper.cxx
b/filter/source/msfilter/msvbahelper.cxx
index 9b8353d..e143ba4 100644
--- a/filter/source/msfilter/msvbahelper.cxx
+++ b/filter/source/msfilter/msvbahelper.cxx
@@ -48,11 +48,7 @@
OUString makeMacroURL( const OUString sMacroName )
{
-return OUStringBuffer().
-append( sUrlPart0 ).
-append( sMacroName ).
-append( sUrlPart1 ).
-makeStringAndClear();
+return sUrlPart0 + sMacroName + sUrlPart1;
}
OUString extractMacroName( const OUString rMacroUrl )
@@ -282,7 +278,7 @@
OUString aLibName = rLibName.isEmpty() ? getDefaultProjectName(
pShell ) : rLibName ;
OUString aModuleName = rModuleName;
if( hasMacro( pShell, aLibName, aModuleName, rMacroName ) )
-return OUStringBuffer( aLibName ).append( sal_Unicode( '.' )
).append( aModuleName ).append( sal_Unicode( '.' ) ).append( rMacroName
).makeStringAndClear();
+return aLibName + . + aModuleName + . + rMacroName;
}
#endif
return OUString();
diff --git a/filter/source/msfilter/svdfppt.cxx
b/filter/source/msfilter/svdfppt.cxx
index 057f7e5..b307db4 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -4110,24 +4110,20 @@
{
if ( rIn.GetError() == 0 )
{
-rtl::OStringBuffer aMsg;
+OStringBuffer aMsg;
if ( rIn.Tell() aTxMasterStyleHd.GetRecEndFilePos() )
{
-aMsg.append(RTL_CONSTASCII_STRINGPARAM(\n ));
-aMsg.append(RTL_CONSTASCII_STRINGPARAM(reading too
many bytes:));
-aMsg.append(static_castsal_Int32(rIn.Tell() -
aTxMasterStyleHd.GetRecEndFilePos()));
+aMsg.append(\n + reading too many bytes: +
+OString::number(rIn.Tell() -
aTxMasterStyleHd.GetRecEndFilePos()));
}
if ( rIn.Tell() aTxMasterStyleHd.GetRecEndFilePos() )
{
-aMsg.append(RTL_CONSTASCII_STRINGPARAM(\n ));
-aMsg.append(RTL_CONSTASCII_STRINGPARAM(reading too
few bytes:));
-
aMsg.append(static_castsal_Int32(aTxMasterStyleHd.GetRecEndFilePos() -
rIn.Tell()));
+aMsg.append(\n + reading too few bytes: +
+
OString::number(aTxMasterStyleHd.GetRecEndFilePos() - rIn.Tell()));
}
if (aMsg.getLength())
{
-aMsg.insert(0, RTL_CONSTASCII_STRINGPARAM(]:));
-aMsg.insert(0, RTL_CONSTASCII_STRINGPARAM(
-PptStyleSheet::operator[));
+aMsg.insert(0, PptStyleSheet::operator[]);
OSL_FAIL(aMsg.getStr());
}
}
diff --git a/filter/source/pdf/pdfexport.cxx b/filter/source/pdf/pdfexport.cxx
index c9f3133..57d538b 100644
--- a/filter/source/pdf/pdfexport.cxx
+++ b/filter/source/pdf/pdfexport.cxx
@@ -878,10 +878,7 @@
if( aPageRange.isEmpty() )
{
-aPageRange = OUStringBuffer()
-.append( static_cast sal_Int32 ( 1 ) )
-.append( static_cast sal_Unicode ( '-' ) )
-.append( nPageCount ).makeStringAndClear();
+aPageRange = OUString::number( 1 ) + - +
OUString::number(nPageCount );
}
StringRangeEnumerator aRangeEnum( aPageRange, 0, nPageCount-1
);
diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 8ba1446..14e115e 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -2935,8 +2935,7 @@
{
SvXMLElementExport aElem( mrExport,
XML_NAMESPACE_NONE, desc, sal_False, sal_False );
-OUStringBuffer sType;
-sType.append(static_castsal_Int32(nType));
+OUStringBuffer sType(OUString::number(nType));
if (pAction (nType == META_COMMENT_ACTION))
{
sType.append(: );
@@
[PUSHED] fdo#57950: Remove more chained appends in filter
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2186 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2186 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I338b18981e1f925d76c0d640159de30bab219122 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Olivier Hallot olivier.hal...@alta.org.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove not needed function in calc
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/2187
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2187/1
Remove not needed function in calc
Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
---
M sc/source/ui/collab/sendfunc.hxx
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/sc/source/ui/collab/sendfunc.hxx b/sc/source/ui/collab/sendfunc.hxx
index f7fcca9..6bd9a1e 100644
--- a/sc/source/ui/collab/sendfunc.hxx
+++ b/sc/source/ui/collab/sendfunc.hxx
@@ -34,17 +34,12 @@
// method name ';' then arguments ; separated
class ScChangeOpWriter
{
-rtl::OUStringBuffer aMessage;
-void appendSeparator()
-{
-aMessage.append( sal_Unicode( ';' ) );
-}
+OUStringBuffer aMessage;
public:
ScChangeOpWriter( const char *pName )
{
-aMessage.appendAscii( pName );
-appendSeparator();
+aMessage.append( OUString(pName ) + ;);
}
void appendString( const rtl::OUString rStr )
@@ -58,27 +53,24 @@
}
else
aMessage.append( rStr );
-appendSeparator();
+aMessage.append(;);
}
void appendAddress( const ScAddress rPos )
{
-rtl::OUString aStr;
+OUString aStr;
rPos.Format( aStr, SCA_VALID );
-aMessage.append( aStr );
-appendSeparator();
+aMessage.append( aStr + ; );
}
void appendInt( sal_Int32 i )
{
-aMessage.append( i );
-appendSeparator();
+aMessage.append( OUString::number(i) + ; );
}
void appendBool( sal_Bool b )
{
-aMessage.appendAscii( b ? true : false );
-appendSeparator();
+aMessage.append( OUString(b ? true : false ) + ;;
}
void appendCell( ScBaseCell *pCell )
--
To view, visit https://gerrit.libreoffice.org/2187
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] simplify extension logic in configure
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2188 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2188/1 simplify extension logic in configure Change-Id: I1b255f9da925501449d7a41ce5914595da582e40 --- M configure.ac A m4/libo_check_extension.m4 2 files changed, 35 insertions(+), 157 deletions(-) diff --git a/configure.ac b/configure.ac index 5b0853415..864fa15 100644 --- a/configure.ac +++ b/configure.ac @@ -10968,9 +10968,6 @@ ### # Extensions checking ### -dnl === -dnl Test whether to integrate extensions into the product's installer -dnl === AC_MSG_CHECKING([for extensions integration]) if test x$enable_extension_integration != xno; then WITH_EXTENSION_INTEGRATION=YES @@ -10987,160 +10984,19 @@ WITH_EXTRA_EXTENSIONS= AC_SUBST([WITH_EXTRA_EXTENSIONS]) -dnl === -dnl Test whether to include Watch Window extension -dnl === -AC_MSG_CHECKING([for Watch Window extension integration]) -WATCH_WINDOW_EXTENSION_PACK= -if test x$enable_ext_watch_window = xyes -a x$enable_extension_integration != xno; then -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_WATCH_WINDOW - WATCH_WINDOW_EXTENSION_PACK=23bd75552206dfcd8fd4e29137dcac84-WatchWindow_1.2.0.0.oxt -WITH_EXTRA_EXTENSIONS=YES -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -AC_SUBST(WATCH_WINDOW_EXTENSION_PACK) - -dnl === -dnl Test whether to include SmART Gallery (Diagram) extension -dnl === -AC_MSG_CHECKING([for SmART Gallery (Diagram) extension integration]) -DIAGRAM_EXTENSION_PACK= -if test x$enable_ext_diagram = xyes -a x$enable_extension_integration != xno; then -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_DIAGRAM -DIAGRAM_EXTENSION_PACK=8d74685d41f8bffe8c3e71fe8deac09d-SmART_0.9.5.oxt -WITH_EXTRA_EXTENSIONS=YES -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -AC_SUBST(DIAGRAM_EXTENSION_PACK) - -dnl === -dnl Test whether to include Validator extension -dnl === -AC_MSG_CHECKING([for Validator extension integration]) -VALIDATOR_EXTENSION_PACK= -if test x$enable_ext_validator = xyes -a x$enable_extension_integration != xno; then -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_VALIDATOR - VALIDATOR_EXTENSION_PACK=bbdd5639ada63e3130761daaecae1a10-Validator_1.1.0.0.oxt -WITH_EXTRA_EXTENSIONS=YES -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -AC_SUBST(VALIDATOR_EXTENSION_PACK) - -dnl === -dnl Test whether to include Barcode extension -dnl === -AC_MSG_CHECKING([for Barcode extension integration]) -BARCODE_EXTENSION_PACK= -if test x$enable_ext_barcode = xyes -a x$enable_extension_integration != xno; then -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_BARCODE - BARCODE_EXTENSION_PACK=3ed18025a766f1e955707b969c8113a5-Barcode_1.3.5.0.oxt -WITH_EXTRA_EXTENSIONS=YES -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -AC_SUBST([BARCODE_EXTENSION_PACK]) - -dnl === -dnl Test whether to include ConvertTextToNumber extension -dnl === -AC_MSG_CHECKING([for ConvertTextToNumber extension integration]) -if test x$enable_ext_ct2n = xyes -a x$enable_extension_integration != xno; then -BUILD_TYPE=$BUILD_TYPE CT2N -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_CT2N -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi - -dnl === -dnl Test whether to include Numbertext extension -dnl === -AC_MSG_CHECKING([for Numbertext extension integration]) -NUMBERTEXT_EXTENSION_PACK= -if test x$enable_ext_numbertext = xyes -a x$enable_extension_integration != xno; then -SCPDEFS=$SCPDEFS -DWITH_EXTENSION_NUMBERTEXT - NUMBERTEXT_EXTENSION_PACK=b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt -WITH_EXTRA_EXTENSIONS=YES -AC_MSG_RESULT([yes]) -else -AC_MSG_RESULT([no]) -fi -AC_SUBST(NUMBERTEXT_EXTENSION_PACK) - -dnl === -dnl Test whether to include Hungarian Cross-reference Toolbar extension -dnl
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zformat.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit aecb97a421b02a65443ec1722b3b35719a7734d1
Author: Caolán McNamara caol...@redhat.com
Date: Mon Feb 18 00:30:20 2013 +
coverity#984042 Uninitialized scalar variable
Change-Id: If75afb24632553bb9aa90990c347ad8851ee55a9
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 9709110..759136f 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -3629,7 +3629,7 @@ bool SvNumberformat::ImpGetDateOutput(double fNumber,
int nUseMonthCase = 0; // not decided yet
OUString aOrgCalendar;// empty = not changed yet
-double fOrgDateTime;
+double fOrgDateTime(0.);
bool bOtherCalendar = ImpIsOtherCalendar( NumFor[nIx] );
if ( bOtherCalendar )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 9 commits - lotuswordpro/source
lotuswordpro/source/filter/lwpbulletstylemgr.cxx |2 ++
lotuswordpro/source/filter/lwpcelllayout.cxx |6 ++
lotuswordpro/source/filter/lwplayout.cxx | 16
lotuswordpro/source/filter/lwprowlayout.cxx | 20 +---
lotuswordpro/source/filter/lwptablelayout.cxx|2 +-
5 files changed, 22 insertions(+), 24 deletions(-)
New commits:
commit fdf59cc3b5928aa1b4fca62909988c455695cd03
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Feb 18 01:40:13 2013 +0100
coverity: fix memory leak
Change-Id: Ibe595adf52c6880ce4ecdb469b89074fcdc0c16b
diff --git a/lotuswordpro/source/filter/lwptablelayout.cxx
b/lotuswordpro/source/filter/lwptablelayout.cxx
index ec05975..9c8941e 100644
--- a/lotuswordpro/source/filter/lwptablelayout.cxx
+++ b/lotuswordpro/source/filter/lwptablelayout.cxx
@@ -266,7 +266,7 @@ double LwpSuperTableLayout::GetTableWidth()
void LwpSuperTableLayout::ApplyShadow(XFTableStyle *pTableStyle)
{
// use shadow property of supertable
-XFShadow* pXFShadow = GetXFShadow();
+boost::scoped_ptrXFShadow pXFShadow(GetXFShadow());
if(pXFShadow)
{
pTableStyle-SetShadow(pXFShadow-GetPosition(),
pXFShadow-GetOffset(), pXFShadow-GetColor());
commit 7511f631775365ec4477e98852a7f6df2bca333a
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Feb 18 01:37:19 2013 +0100
coverity: fix memory leak
Change-Id: I991f0e90abfa6e772f43afd8b8aa69d3b5ce4fa0
diff --git a/lotuswordpro/source/filter/lwprowlayout.cxx
b/lotuswordpro/source/filter/lwprowlayout.cxx
index 1c162f8..3c544ee 100644
--- a/lotuswordpro/source/filter/lwprowlayout.cxx
+++ b/lotuswordpro/source/filter/lwprowlayout.cxx
@@ -177,14 +177,11 @@ void LwpRowLayout::Read()
*/
void LwpRowLayout::ConvertRow(XFTable* pXFTable,sal_uInt8 nStartCol,sal_uInt8
nEndCol)
{
-XFRow* pXFRow = new XFRow;
-
LwpTableLayout* pTableLayout = GetParentTableLayout();
LwpTable* pTable = pTableLayout-GetTable();
//calculate the connected cell position
-sal_Int32 nMarkConnCell;
-nMarkConnCell = FindMarkConnCell(nStartCol,nEndCol);
+sal_Int32 nMarkConnCell = FindMarkConnCell(nStartCol,nEndCol);
//if there is no connected cell
if (nMarkConnCell == -1)
@@ -195,6 +192,7 @@ void LwpRowLayout::ConvertRow(XFTable* pXFTable,sal_uInt8
nStartCol,sal_uInt8 nE
//register connect row style
sal_uInt16 nRowMark = crowid + GetCurMaxSpannedRows(nStartCol,nEndCol);
+XFRow* pXFRow = new XFRow;
RegisterCurRowStyle(pXFRow,nRowMark);
//if there is connected cell
commit 856a3a09a06fef903ce09d385a97205fdf9308fe
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Feb 18 01:35:05 2013 +0100
coverity: fix memory leak
Change-Id: I12ad99f3179ee8ef9e0322823685eb2bf337fc22
diff --git a/lotuswordpro/source/filter/lwprowlayout.cxx
b/lotuswordpro/source/filter/lwprowlayout.cxx
index f21114c..1c162f8 100644
--- a/lotuswordpro/source/filter/lwprowlayout.cxx
+++ b/lotuswordpro/source/filter/lwprowlayout.cxx
@@ -248,25 +248,25 @@ void LwpRowLayout::ConvertRow(XFTable* pXFTable,sal_uInt8
nStartCol,sal_uInt8 nE
*/
void LwpRowLayout::RegisterCurRowStyle(XFRow* pXFRow,sal_uInt16 nRowMark)
{
-XFRowStyle* pRowStyle;
-XFRowStyle* pNewStyle = new XFRowStyle;
-double fHeight;
XFStyleManager* pXFStyleManager =
LwpGlobalMgr::GetInstance()-GetXFStyleManager();
-pRowStyle =
static_castXFRowStyle*(pXFStyleManager-FindStyle(m_StyleName));
+XFRowStyle* pRowStyle =
static_castXFRowStyle*(pXFStyleManager-FindStyle(m_StyleName));
if (!pRowStyle)
return;
-fHeight = pRowStyle-GetRowHeight();
+double fHeight = pRowStyle-GetRowHeight();
+XFRowStyle* pNewStyle = new XFRowStyle;
*pNewStyle = *pRowStyle;
-std::mapsal_uInt16,LwpRowLayout*::iterator iter;
LwpTableLayout* pTableLayout = GetParentTableLayout();
if (!pTableLayout)
+{
+delete pNewStyle;
return;
+}
std::mapsal_uInt16,LwpRowLayout* RowsMap = pTableLayout-GetRowsMap();
for (sal_uInt16 i=crowid+1; inRowMark;i++)
{
-iter = RowsMap.find(i);
+std::mapsal_uInt16,LwpRowLayout*::iterator iter = RowsMap.find(i);
if (iter == RowsMap.end())
{
pRowStyle = static_castXFRowStyle*(
commit 655c7b5260e2618d0115f1437f0a96b2a9490f09
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Feb 18 01:30:44 2013 +0100
coverity: fix memory leak
Change-Id: I9fa99a3f2a5de644961cbf8b9951e1c1246d97cb
diff --git a/lotuswordpro/source/filter/lwplayout.cxx
b/lotuswordpro/source/filter/lwplayout.cxx
index 918b74e..ca36718 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -1589,7 +1589,7 @@ XFColumns* LwpLayout::GetXFColumns()
XFColumns* pColumns = new XFColumns();
//set XFColumnSep
-XFColumnSep*
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added Depends on||39484 --- Comment #203 from Winfried Donkers o...@dci-electronics.nl --- This bug causes data loss (notices of entire tabsheets get lost) and is extremely annoying as the damage is only noted when reopening the calc document. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scripting/examples
scripting/examples/java/HelloWorld/parcel-descriptor.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 54d91caf7b3519ee44e299a8174b7ec28fa6a6ed Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 17 17:56:56 2013 +0100 Fix typo Change-Id: Id5aff315b1d52ac5a869a17b3a654c2d1e670b08 diff --git a/scripting/examples/java/HelloWorld/parcel-descriptor.xml b/scripting/examples/java/HelloWorld/parcel-descriptor.xml index 926a797..57e2e04 100644 --- a/scripting/examples/java/HelloWorld/parcel-descriptor.xml +++ b/scripting/examples/java/HelloWorld/parcel-descriptor.xml @@ -21,7 +21,7 @@ locale lang=en displayname value=HelloWorld.Java/ description -Prints Helo World. +Prints Hello World. /description /locale functionname value=org.libreoffice.example.java_scripts.HelloWorld.printHW/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
RE: patch removing Labels.xcu out of configuration
Hi Matus, Michael, Well, overwriting existing labels does not work I think, but it did not before either, so.. I think that's fine. If you would like to fix this, poke IMPL_LINK_NOARG(SwSaveLabelDlg, OkHdl) in sw/source/ui/envelp/labfmt.cxx Maybe if(RET_YES != eRet) makes it return before saving ? Really no idea what's going on. I did not try to debug. Anyhow, always good to test changes, so if you want, please do. I get an exception (warn:legacy.osl:24509:1:unotools/source/config/configitem.cxx:58: Exception from GetNodeNames: *['Avery A4']) which can well be the cause of not being able to overwrite existing labels. I haven't got further than that the exception comes from ReferenceXHierarchicalNameAccess xHierarchyAccess = GetTree(); in Sequence OUString ConfigItem::GetNodeNames(const OUString rNode, ConfigNameFormat eFormat) in /core/unotools/source/config/configitem.cxx (line 730). It'll probably cost me some time to find my way in the maze of templates/constructs/etc., but I won''t give up easily. Also, I found some small spelling errors in labels.xml (possibly my errors, or there from long ago) and an incomplete comment. I will patch these together with the overwrite-patch I hope to make. BTW, should it be possible to overwrite exisiting label definitions at all? I mean, shouldn't it be necessary to at least change the type name? The existing label definitions are for real labels and overwriting them could lead to confusing. Or is this purely the user's responsibilty? Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 42428] Split panes in same window for side-by-side or above-and-below editing of two (or more) parts a single document/file
https://bugs.freedesktop.org/show_bug.cgi?id=42428 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #11 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #9) Wow! It's true that Window New Window allows one to scroll and edit independently at two locations in a document! When I made my comment (#3, 2011-12-02) it didn't work but now it does, both in OOo 3.3 and LO 3.4. I don't know why it's working now and wasn't then. This satisfies my needs, even if it takes some fiddling to get the windows arranged properly. Hey! Thanks for that. I didn't get it earlier. Your post made it clear. It's a pretty good workaround. I suspect that it's meant to serve the same purpose as the split pane, though not as elegant. It's probably an easier implementation for the coders. I can confirm dE's experience about having independent scrolls... when a duplicate document is opened via Windows New Window. Still the split pane is a more elegant solution. You have my vote on this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52519] Libreoffice crash when typing some word using ibus
https://bugs.freedesktop.org/show_bug.cgi?id=52519 --- Comment #6 from balakrishanan a.p.balakris...@gmail.com --- Created attachment 74965 -- https://bugs.freedesktop.org/attachment.cgi?id=74965action=edit backtrace Julien Nabet pls find this new one -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60530] Allow user to disable spellchecker and grammar in current document only (not global settings)
https://bugs.freedesktop.org/show_bug.cgi?id=60530 --- Comment #2 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #1) I don't have a need for this, but can appreciate how it is useful for users like you. Now I wonder if I understood you correctly. Your problem may be solved by just making some changes at Tools AutoCorrect Options. If this works for you, please mark the status as RESOLVED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60989] New: There is no longer a menuoption for the extension TemplateChanger in LibreOffice 4.0
https://bugs.freedesktop.org/show_bug.cgi?id=60989 Priority: high Bug ID: 60989 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: There is no longer a menuoption for the extension TemplateChanger in LibreOffice 4.0 Severity: major Classification: Unclassified OS: Windows (All) Reporter: kees...@gmail.com Hardware: Other Status: NEW Version: 4.0.0.3 release Component: Writer Product: LibreOffice I'm using the extension TemplateChanger. In LibreOffice 3.6 it results in extra menu items under File Templates. It can import a template in an existing document. Now in 4.0 the menu item template is canceled and is the Template dialog screen moved to File New Template. I can't find the TemplateChanger options there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60990] New: FILESAVE as .docx (MSO2007): background pictures lost when reopen
https://bugs.freedesktop.org/show_bug.cgi?id=60990
Priority: medium
Bug ID: 60990
Keywords: regression
Assignee: libreoffice-bugs@lists.freedesktop.org
Summary: FILESAVE as .docx (MSO2007): background pictures lost
when reopen
Severity: major
Classification: Unclassified
OS: Windows (All)
Reporter: libreoff...@bielefeldundbuss.de
Hardware: Other
Status: UNCONFIRMED
Version: 3.6.5.2 release
Component: Writer
Product: LibreOffice
Created attachment 74966
-- https://bugs.freedesktop.org/attachment.cgi?id=74966action=edit
Test Kit
Steps how to reproduce with LibreOffice 3.6.5.2 English UI/ German Locale
[Build-ID: 5b93205] {pull date 2013-01-18} on German WIN7 Home Premium (64bit)
1. Open sample document SampleBackgroundPictures.odt from attached test kit
2. Save as .docx
3. close
4. Reopen with LibO:
Bug: only placeholders shown for 2 background pictures (jpg, png)
5. close, reopen with MS WORD VIEWER
Bug: 2 background pictures not visible at all
The reason is the Wrap - Through - Background picture property. If you redo
the test with Sample.odt the pictures will be visible
Pictures remain visible after export from 3.4.5 and 3.5.7 so regression.
Reincarnation of Bug 30713 - [FILESAVE]: Images only shown as placeholders in
docx (at least some aspects of it)?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60990] FILESAVE as .docx (MSO2007): background pictures lost when reopen
https://bugs.freedesktop.org/show_bug.cgi?id=60990 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Whiteboard||bibisectrequest CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- LibreOffice 3.6.5.2 shows the background pictures in attached SampleBackgroundPictures_MSO2007_357.docx fine. So a bibisect should not be too difficult. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60990] FILESAVE as .docx (MSO2007): paragraph background pictures lost when reopen
https://bugs.freedesktop.org/show_bug.cgi?id=60990 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Summary|FILESAVE as .docx |FILESAVE as .docx |(MSO2007): background |(MSO2007): paragraph |pictures lost when reopen |background pictures lost ||when reopen -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59979] copy and paste header
https://bugs.freedesktop.org/show_bug.cgi?id=59979 --- Comment #5 from andrej8anu...@gmail.com --- This bug is similar to bug https://bugs.freedesktop.org/show_bug.cgi?id=56262 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56262] title is not copied correctly formatted
https://bugs.freedesktop.org/show_bug.cgi?id=56262 --- Comment #2 from andrej8anu...@gmail.com --- This bug is similar to bug: https://bugs.freedesktop.org/show_bug.cgi?id=59979 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60992] New: FILESAVE as .docx ignores 'Background' property in 'Wrap-Through' of DRAW shape
https://bugs.freedesktop.org/show_bug.cgi?id=60992
Priority: medium
Bug ID: 60992
Assignee: libreoffice-bugs@lists.freedesktop.org
Summary: FILESAVE as .docx ignores 'Background' property in
'Wrap-Through' of DRAW shape
Severity: normal
Classification: Unclassified
OS: All
Reporter: libreoff...@bielefeldundbuss.de
Hardware: Other
Status: UNCONFIRMED
Version: 3.3.0 release
Component: Writer
Product: LibreOffice
Created attachment 74967
-- https://bugs.freedesktop.org/attachment.cgi?id=74967action=edit
Test kit with source document and some export results
I found this problem during my tests for Bug 54660 - FILEOPEN .docx (MSO2007)
(OOXML) ignores wrap property 'Background'
The combination of these bugs might show that we currently have a more general
misunderstanding concerning the Draw
Steps how to reproduce [Reproducible] with LibreOffice 3.6.5.2 German UI/
German Locale [Build-ID: 5b93205] {pull date 2013-01-18} on German WIN7 Home
Premium (64bit):
1. open Wrapthroughbackground.odt from attached test kit
2. Save as .docx (MSO2007) or (OOXML), does not matter
3. close
4. Reopen with MS WORD Viewer
Expected: Rectangle in Background
Actual: Rectangle in foreground
That's already broken in LibO 3.3.0
Works fine for Save as .doc (MSO97)
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52519] Libreoffice crash when typing some word using ibus
https://bugs.freedesktop.org/show_bug.cgi?id=52519 --- Comment #7 from Julien Nabet serval2...@yahoo.fr --- balakrishanan: thank you for the bt! Would it be possible you attach the font (ttf file I think) to the bugtracker so we can try to reproduce the problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60545] Vectors and hats are not correctly displayed
https://bugs.freedesktop.org/show_bug.cgi?id=60545 Jacques VALLOIS p...@vallois.nom.fr changed: What|Removed |Added CC||p...@vallois.nom.fr --- Comment #4 from Jacques VALLOIS p...@vallois.nom.fr --- Sorry christophe.devall...@gmail.com, but this is not for the same version. As math teacher I would like this to be very quickly improve because il could be a good reason for some colleague of mine to promote Microsoft Office ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39484] Outline groups are lost while editing or after re-opening a spreadsheet
https://bugs.freedesktop.org/show_bug.cgi?id=39484 kouka...@gmail.com changed: What|Removed |Added Severity|major |blocker Priority|high|highest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54660] FILEOPEN .docx (MSO2007) (OOXML) ignores wrap property 'Background'
https://bugs.freedesktop.org/show_bug.cgi?id=54660 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|[DOCX] FILEOPEN: rectangle |FILEOPEN .docx (MSO2007) |over text instead of|(OOXML) ignores wrap |background |property 'Background' Version|3.6.0.1 rc |3.3.0 release --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Bug 60992 - FILESAVE as .docx ignores 'Background' property in 'Wrap-Through' of DRAW shape might show that there is some more general misunderstanding concerning Wrap through - Background for Draw objects in .docx? I do not understand why this bug depends on Bug 52208 - [DOCX] FILEOPEN: additional empty page after a continuous section break at the end of document, what has been fixed [target:3.6.4], but this one still does exist. The problem discussed here (Forgeground instead of background) with sample mentioned in original report is already visible in LibO 3.3.0, I think it never worked and I do not understand the discussion here concerning bug appearance. @Miklós: Are you planning to fix tis one or should we involve an additional developer? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54660] FILEOPEN .docx (MSO2007) (OOXML) ignores wrap property 'Background'
https://bugs.freedesktop.org/show_bug.cgi?id=54660 --- Comment #6 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 74969 -- https://bugs.freedesktop.org/attachment.cgi?id=74969action=edit Background jpg and png shown fine I am a little doubtful concerning DUP Bug 58782, that's a picture (not Draw Element) anchored as character (where no background option is available). This sample contains 2 pictures (jpg / png) with wrap throuth + background what are shown correctly in background when I open it with LibO 3.6.5 (and in MS WORD Viewer). I would prefer to leave Bug 58782 as separate bug if it's not proved without doubt that roots are the same like here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60990] FILESAVE as .docx (MSO2007): paragraph background pictures lost when reopen
https://bugs.freedesktop.org/show_bug.cgi?id=60990 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #2 from A stgohi-lob...@yahoo.de --- partially reproducible with LO 4.0.0.3 (Win7 Home, 64bit) Results after saving as a docx file (see also the attached file 345) and reopening it with LO and opening it with MS Office 2007: in LO: the draw element is no longer shown as a background image (including a missing text), the other elements are shown fine in MSO: the draw element is not shown as a background image and in addition paragraphs are added, the other elements are shown fine When the file is saved as a doc file, then all the elements are shown fine in LO and MSO. An additional interesting bug is that if the docx file is saved once more as a docx file, then in addition the png and jpg elements are displaced. @Rainer: Would is the difference between the attached files 345 and 357 and how is the file 365 generated? 365 shows in LO and MSO a Read Error message for the png and jpg elements and the draw element is not shown as a background image. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60994] New: UI: I want PDF export that work on single page
https://bugs.freedesktop.org/show_bug.cgi?id=60994 Priority: medium Bug ID: 60994 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: I want PDF export that work on single page Severity: normal Classification: Unclassified OS: All Reporter: lilil...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.0.0.alpha0+ Master Component: Printing and PDF export Product: LibreOffice Problem description: Current behavior: PDF export function do not allow selective page export. Expected behavior: PDF export allow user to select pages to export. Operating System: All Version: 4.1.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60774] Impress v4.0.0.3 loses some images from presentation made in v3.6.2.2
https://bugs.freedesktop.org/show_bug.cgi?id=60774 --- Comment #10 from Jonathan Barr jonathan0b...@gmail.com --- Hello Jacques, The V4.01 beta does not display animated text boxes correctly in a slide show. I have attached a file containing 9 slides which show correctly in V3.6 but not in V4. Hope this helps in resolving the issue. In the meantime I will revert to V3.6 for an upcoming training session that I have to do shortly as all appears to run correctly in V3.6. Best regards, Jonathan Sent from Laptop *From:* Jonathan Barr jonathan0b...@gmail.com *Sent:* 17 February 2013 08:09 *To:* bugzilla-dae...@freedesktop.org *Subject:* RE: [Bug 60774] Impress v4.0.0.3 loses some images from presentation made in v3.6.2.2 Hello Jacques, It is not possible to select the callout box. I can see the callout box when in the normal slide view, but it is not shown in the Slide-Show. I will have to do a bit more checking because I think I changed the original animated slide into just a composite picture when I initially had the problem. I will come back to you later with my findings. Best regards, Jonathan Sent from Laptop *From:* bugzilla-dae...@freedesktop.org *Sent:* 16 February 2013 16:28 *To:* jonathan0b...@gmail.com *Subject:* [Bug 60774] Impress v4.0.0.3 loses some images from presentation made in v3.6.2.2 *Comment # 8 https://bugs.freedesktop.org/show_bug.cgi?id=60774#c8 on bug 60774 https://bugs.freedesktop.org/show_bug.cgi?id=60774 from Jacques Guilleron guillero...@aol.com * Hello Jonathan, Sorry for this delay. I see there's another issue, but I have not your slide, just the three ones in Sample Problem1.odp. What I see is a drawing shape missing(Callout), but the text is there, so it would be interresting to know if you can select the shape, and if so, add for example visible shadow or something like that, and report separatly your issue, after a search in Bugzilla for an identical issue. Can you do that ? Thank you ! Jacques -- You are receiving this mail because: - You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60996] New: page break hesitation and crash
https://bugs.freedesktop.org/show_bug.cgi?id=60996 Priority: medium Bug ID: 60996 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: page break hesitation and crash Severity: critical Classification: Unclassified OS: Windows (All) Reporter: fabi...@fabiana.co.za Hardware: x86 (IA32) Status: UNCONFIRMED Version: unspecified Component: Writer Product: LibreOffice Switching to 4.0 find that my 172 page book with many image and spreadsheet inserts now halts on scrolling at page breaks and sometimes crashes ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60997] New: Cannot save file, error in writing sub document content.xml
https://bugs.freedesktop.org/show_bug.cgi?id=60997 Priority: medium Bug ID: 60997 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Cannot save file, error in writing sub document content.xml Severity: critical Classification: Unclassified OS: Windows (All) Reporter: anton.bal...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.0.0.3 release Component: Writer Product: LibreOffice Sometimes when I use feature attaching comments to document text ranges I recieve error message Cannot save file, error in writing sub document content.xml and after that I can't save document by any way except export it as .doc file. In the bugzilla there is same bag (60769) but for MacOS -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60996] page break hesitation and crash
https://bugs.freedesktop.org/show_bug.cgi?id=60996 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||joren.libreoffice@telenet.b ||e Ever confirmed|0 |1 --- Comment #1 from Jorendc joren.libreoff...@telenet.be --- Is it possible to attach this document? If this document includes secret/personal/business critical information, please feel free to sensor it or send it by email so we can test. Without more information on 'what document' we can't determine the cause and fix it properly. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60997] Cannot save file, error in writing sub document content.xml
https://bugs.freedesktop.org/show_bug.cgi?id=60997 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE QA Contact||joren.libreoffice@telenet.b ||e --- Comment #1 from Jorendc joren.libreoff...@telenet.be --- hi, Thanks for reporting! Also thanks for searching first for duplicates. I mark this indeed as duplicate of Bug 60769 and mark that bug as NEW and platforms = all. Kind regards, Joren *** This bug has been marked as a duplicate of bug 60769 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60769] FILEOPEN, FILESAVE, Could not save document, error in writing sub document context.xml then corrupt file.
https://bugs.freedesktop.org/show_bug.cgi?id=60769 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added CC||anton.bal...@gmail.com --- Comment #1 from Jorendc joren.libreoff...@telenet.be --- *** Bug 60997 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60769] FILEOPEN, FILESAVE, Could not save document, error in writing sub document context.xml then corrupt file.
https://bugs.freedesktop.org/show_bug.cgi?id=60769 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Hardware|x86 (IA32) |All OS|Mac OS X (All) |All Status|UNCONFIRMED |NEW QA Contact||joren.libreoffice@telenet.b ||e Ever confirmed|0 |1 --- Comment #2 from Jorendc joren.libreoff...@telenet.be --- Because Anton reported a duplicate bug, we have a independent confirmation. Therefore I mark this bug as NEW. Anton reported this bug using windows, thus I change platforms to all. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57061] Not all personal data imported during install from /3 User Profile
https://bugs.freedesktop.org/show_bug.cgi?id=57061 --- Comment #60 from harald-koes...@htp-tel.de --- Hence there was a complaint on the german user mailing list, I checked the migration of macros with version 4.0.0.3. According my test macros are not migrated. I used the same procedure like in comment 24. If necessary I can provide a step-by-step description. Petr: Is the migration of macros also solved with your patches? BTW: Thanks for your commitment. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52518] ACCESSIBILITY: Font Name and Font Size icons on VERTICAL formatting toolbar need to have drop-down menus
https://bugs.freedesktop.org/show_bug.cgi?id=52518 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement QA Contact||joren.libreoffice@telenet.b ||e See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=55846 Summary|ACCESSIBILITY: [Feature |ACCESSIBILITY: Font Name |Request] Font Name and|and Font Size icons on |Font Size icons on|VERTICAL formatting toolbar |VERTICAL formatting toolbar |need to have drop-down |need to have drop-down |menus |menus | Ever confirmed|0 |1 --- Comment #2 from Jorendc joren.libreoff...@telenet.be --- Thanks for reporting! I know they are working on the 'font size' button now, but I'm not sure also for the 'font name' list. Therefore I mark this bug as NEW and place the other enhancement request in the 'See Also' field. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60990] FILESAVE as .docx (MSO2007): paragraph background pictures lost when reopen
https://bugs.freedesktop.org/show_bug.cgi?id=60990 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- (In reply to comment #2) the draw element is no longer shown as a background image That#s Bug 54660 - FILEOPEN .docx (MSO2007) (OOXML) ignores wrap property 'Background', please excuse me, I forgot to mention! png and jpg elements are displaced That is something I also saw during tests with older LibO Verions (3.4.5 or so). The big problem here is that we have quite a lot problems here and it's difficult to produce sane sample documents because of several FILESAVE problems. @A Thank you for review Can you please following up tthat displaced pictures problem in a new Bug report? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60972] Font Name box too narrow, no apparent way to re-size it
https://bugs.freedesktop.org/show_bug.cgi?id=60972 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Hardware|x86-64 (AMD64) |All OS|Windows (All) |All Status|UNCONFIRMED |NEW Severity|normal |enhancement QA Contact||joren.libreoffice@telenet.b ||e Version|4.0.0.3 release |unspecified Component|Writer |Libreoffice Ever confirmed|0 |1 --- Comment #3 from Jorendc joren.libreoff...@telenet.be --- Thanks for reporting! I can't find any duplicate for now, and I can confirm this will be an improvement. Therefore I mark this as NEW and as an enhancement request. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60999] New: Do not change function of the up/down arrows under scrollbar in writer
https://bugs.freedesktop.org/show_bug.cgi?id=60999 Priority: medium Bug ID: 60999 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Do not change function of the up/down arrows under scrollbar in writer Severity: enhancement Classification: Unclassified OS: All Reporter: will...@techservsys.com Hardware: All Status: UNCONFIRMED Version: unspecified Component: UI Product: LibreOffice The up/down arrows below the scrollbar in writer currently do a (printed page) page up/down. If one starts a find the arrows become blue and function at search up/down. But, when the find is done they stay that way until one opens the navigation menu and selects page (which is hardly intuitive), which is a pain. Now, when one starts a find a find bar opens at the bottom of the window and it has the search up/down arrows (which is intuitive) so that changing the function of the scrollbar up/down arrows is no longer of any use. bill -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60923] Impress shows full-screen slideshow tiny
https://bugs.freedesktop.org/show_bug.cgi?id=60923 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO QA Contact||joren.libreoffice@telenet.b ||e Ever confirmed|0 |1 --- Comment #2 from Jorendc joren.libreoff...@telenet.be --- Is it possible for you to attach the presentation, so we can try to reproduce? I can't reproduce this behavior using Linux Mint 14 x64 with LibreOffice 4.0.0. It's off course also possible that this bug is OS-specific (Fedora-only). Is it also possible to retest with a clean user profile following this guide: https://wiki.documentfoundation.org/UserProfile#Resetting_the_user_profile ? Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50395] EDITING: writer focus on paste special with styles and formatting window open
https://bugs.freedesktop.org/show_bug.cgi?id=50395 Paddy Landau pa...@landau.ws changed: What|Removed |Added CC||pa...@landau.ws --- Comment #1 from Paddy Landau pa...@landau.ws --- This bug is still present in Libre Office 4.0.0.3 (tested on Ubuntu 12.04 64-bit fully updated; LO 4.0.0.3 deb files downloaded from the Libre Office website and installed using dpkg). I can elaborate on the original bug report: 1) It affects not only the Styles dialogue, but also the Navigator dialogue. 2) It happens not only with Paste Special, but also other actions such as F7 (spell check) or adding an image. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60819] FILESAVE: LO freeze when saving files
https://bugs.freedesktop.org/show_bug.cgi?id=60819 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||joren.libreoffice@telenet.b ||e Ever confirmed|0 |1 --- Comment #1 from Jorendc joren.libreoff...@telenet.be --- Hi, Thanks for reporting. I can't reproduce this behavior using Linux Mint 14 x64 with LibreOffice 4.0.0. Is it possible for you to reset your user profile using this guide: https://wiki.documentfoundation.org/UserProfile#Resetting_the_user_profile Does this problem still exists with a clean user profile? Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60789] docx document content not shown, several pages missing
https://bugs.freedesktop.org/show_bug.cgi?id=60789 Jorendc joren.libreoff...@telenet.be changed: What|Removed |Added Attachment #74750|text/plain |application/vnd.openxmlform mime type||ats-officedocument.wordproc ||essingml.document -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60822] Enable choice of location (Sheet, Cell) where new Chart should appear
https://bugs.freedesktop.org/show_bug.cgi?id=60822 --- Comment #2 from bugquestcon...@online.de --- I am not aware of the pivot table issue, thus, cannot sat Yes or NO. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60781] ASKLIBREOFFICE: Add a list to a profile with questions which commented or answered by a registered person
https://bugs.freedesktop.org/show_bug.cgi?id=60781 --- Comment #2 from bugquestcon...@online.de --- There is no real life example in AskLibO. It is just a request to enable filters for all AskLibO question a user answered. By doing so, a person answering questions can easily identify question which he/she wants to follow up until the orignal questions is surely answered. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60994] UI: I want PDF export that work on single page
https://bugs.freedesktop.org/show_bug.cgi?id=60994 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Severity|normal |enhancement CC||LibreOffice@bielefeldundbus ||s.de Ever confirmed|0 |1 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- I haven't a clue what reporter is talking about @Jiero Please be more precise! What's your problem? a) You can not select a particular page you want to export b) You can not export selection on page, always whole page will be exported. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59055] UI: Asian font names are in English, not in native language (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=59055
Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:
What|Removed |Added
QA Contact|jmadero@gmail.com |
CC||LibreOffice@bielefeldundbus
||s.de
Summary|Asian font names are in |UI: Asian font names are in
|English, not in native |English, not in native
|language (regression) |language (regression)
Component|UI |Localization
--- Comment #8 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
NOT reproducible as regression compared to 3.6 with LibreOffice 3.6.5.2
German UI/ German Locale [Build-ID: 5b93205] {pull date 2013-01-18} on German
WIN7 Home Premium (64bit)
And I am rather astonished to see somehow chinese fontnames in an English UI?
@webofht-libreofficebugs002
Can you please gain screenshots into 1 document and obsolete the other ones?
Currently your screenshots are very worrying for me
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
