[PATCH] fdo#35320 A fix for Arabic justification problem caused by k...

2013-04-28 Thread Ahmad Harthi (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3644

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1

fdo#35320 A fix for Arabic justification problem caused by kashidas

Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec
---
M vcl/source/gdi/sallayout.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 9d315e3..d4696c7 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -1274,7 +1274,7 @@
 // calculate gap, ignore if too small
 int nGapWidth = pG-mnNewWidth - pG-mnOrigWidth;
 // worst case is one kashida even for mini-gaps
-if( 3 * nGapWidth  nKashidaWidth )
+if( nGapWidth  nKashidaWidth )
 continue;
 
 nKashidaCount = 0;

-- 
To view, visit https://gerrit.libreoffice.org/3644
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ahmad Harthi aalhar...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Clang error

2013-04-28 Thread Chris Sherlock
I apologize for spamming up the list. I just realized - I've installed the
wrong version of Clang.

Chris


On Sun, Apr 28, 2013 at 1:16 AM, Chris Sherlock
chris.sherloc...@gmail.comwrote:

 A slightly cleaned up message:

 http://pastebin.com/mu4P9rEC

 Anyone have any ideas what's causing this?

 Seems to be issues with the cppuhelper library.

 Chris


 On Sun, Apr 28, 2013 at 12:06 AM, Chris Sherlock 
 chris.sherloc...@gmail.com wrote:

 Actually, just worked it out - I forced the -v to be passed in via
 autogen.sh:


 chris@LibreOfficeDev:~/repos/LibreOffice/core$ make toolkit
 cd /home/chris/repos/LibreOffice/core/toolkit  /usr/bin/make -j 1 -rsr
 [ DEP ] SRS:toolkit/awt
 [ LNK ] Library/libtklo.so
 Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM
 3.0)
 Target: i386-pc-linux-gnu
 Thread model: posix
  /usr/bin/ld -z relro --hash-style=gnu --as-needed --build-id
 --eh-frame-hdr -m elf_i386 -shared -o
 /home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/LinkTarget/Library/libtklo.so/usr/lib/gcc/i686-linux-gnu/4.6/../../../i386-linux-gnu/crti.o
 /usr/lib/gcc/i686-linux-gnu/4.6/crtbeginS.o
 -L/home/chris/repos/LibreOffice/core/solver/unxlngi6.pro/lib-L/usr/lib/gcc/i686-linux-gnu/4.6
 -L/usr/lib/gcc/i686-linux-gnu/4.6/../../../i386-linux-gnu
 -L/lib/i386-linux-gnu -L/usr/lib/i386-linux-gnu
 -L/usr/lib/gcc/i686-linux-gnu/4.6/../../../i386-linux-gnu
 -L/usr/lib/gcc/i686-linux-gnu/4.6/../../.. -L/lib/i386-linux-gnu -L/lib
 -L/usr/lib/i386-linux-gnu -L/usr/lib -z noexecstack -z origin -rpath
 \$ORIGIN:\$ORIGIN/../ure-link/lib -rpath-link
 /home/chris/repos/LibreOffice/core/solver/unxlngi6.pro/lib -z defs
 -rpath-link /lib:/usr/lib -z combreloc --hash-style=gnu
 --dynamic-list-cpp-new --dynamic-list-cpp-typeinfo -Bsymbolic-functions -O1
 /home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/asynccallback.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/stylesettings.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/scrollabledialog.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxaccessiblecomponent.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxbitmap.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxcontainer.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxdevice.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxfont.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxgraphics.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxmenu.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxpointer.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxprinter.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxregion.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxspinbutton.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxsystemdependentwindow.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxtabpagecontainer.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/animatedimagespeer.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxtoolkit.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxtopwindow.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxwindow.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxwindow1.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/vclxwindows.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/xsimpleanimation.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/awt/xthrobber.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/accessiblecontrolcontext.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/controlmodelcontainerbase.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/dialogcontrol.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/eventcontainer.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/formattedcontrol.o/home/chris/repos/LibreOffice/core/workdir/
 unxlngi6.pro/CxxObject/toolkit/source/controls/geometrycontrolmodel.o/home/chris/repos/LibreOffice/core/workdir/
 

[Libreoffice-commits] core.git: vcl/source

2013-04-28 Thread Ahmad H . Al Harthi
 vcl/source/gdi/sallayout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c4b9db8bbaed7acd064a4015fabe784c4fbca21
Author: Ahmad H. Al Harthi aalhar...@kacst.edu.sa
Date:   Sun Apr 28 09:03:03 2013 +0300

fdo#35320 A fix for Arabic justification problem caused by kashidas

Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec
Reviewed-on: https://gerrit.libreoffice.org/3644
Tested-by: Ahmad Harthi aalhar...@kacst.edu.sa
Reviewed-by: Ahmad Harthi aalhar...@kacst.edu.sa

diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
index 9d315e3..d4696c7 100644
--- a/vcl/source/gdi/sallayout.cxx
+++ b/vcl/source/gdi/sallayout.cxx
@@ -1274,7 +1274,7 @@ void GenericSalLayout::KashidaJustify( long 
nKashidaIndex, int nKashidaWidth )
 // calculate gap, ignore if too small
 int nGapWidth = pG-mnNewWidth - pG-mnOrigWidth;
 // worst case is one kashida even for mini-gaps
-if( 3 * nGapWidth  nKashidaWidth )
+if( nGapWidth  nKashidaWidth )
 continue;
 
 nKashidaCount = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] fdo#35320 A fix for Arabic justification problem caused by k...

2013-04-28 Thread Ahmad Harthi (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3644

Approvals:
  Ahmad Harthi: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3644
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ahmad Harthi aalhar...@kacst.edu.sa
Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] New Snap Object Widget .ui

2013-04-28 Thread Manal Alhassoun (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3645

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3645/1

New Snap Object Widget .ui

Change-Id: I801f4af269efcea91bc3bafbfc9e0b9033488f2d
---
A sd/uiconfig/sdraw/ui/dlgsnap.ui
1 file changed, 276 insertions(+), 0 deletions(-)



diff --git a/sd/uiconfig/sdraw/ui/dlgsnap.ui b/sd/uiconfig/sdraw/ui/dlgsnap.ui
new file mode 100644
index 000..73699e4
--- /dev/null
+++ b/sd/uiconfig/sdraw/ui/dlgsnap.ui
@@ -0,0 +1,276 @@
+?xml version=1.0 encoding=UTF-8?
+interface
+  !-- interface-requires gtk+ 3.0 --
+  object class=GtkDialog id=NewSnapObject
+property name=can_focusFalse/property
+property name=border_width6/property
+property name=title translatable=yesNew Snap Object/property
+property name=type_hintdialog/property
+child internal-child=vbox
+  object class=GtkBox id=dialog-vbox1
+property name=can_focusFalse/property
+property name=spacing2/property
+child internal-child=action_area
+  object class=GtkButtonBox id=dialog-action_area1
+property name=can_focusFalse/property
+property name=orientationvertical/property
+property name=layout_stylestart/property
+child
+  object class=GtkButton id=ok1
+property name=labelgtk-ok/property
+property name=visibleTrue/property
+property name=can_focusTrue/property
+property name=has_defaultTrue/property
+property name=receives_defaultTrue/property
+property name=use_action_appearanceFalse/property
+property name=use_stockTrue/property
+  /object
+  packing
+property name=expandFalse/property
+property name=fillTrue/property
+property name=position0/property
+  /packing
+/child
+child
+  object class=GtkButton id=cancel1
+property name=labelgtk-cancel/property
+property name=visibleTrue/property
+property name=can_focusTrue/property
+property name=receives_defaultTrue/property
+property name=use_action_appearanceFalse/property
+property name=use_stockTrue/property
+  /object
+  packing
+property name=expandFalse/property
+property name=fillTrue/property
+property name=position1/property
+  /packing
+/child
+child
+  object class=GtkButton id=help1
+property name=labelgtk-help/property
+property name=visibleTrue/property
+property name=can_focusTrue/property
+property name=receives_defaultTrue/property
+property name=use_action_appearanceFalse/property
+property name=use_stockTrue/property
+property name=image_positiontop/property
+  /object
+  packing
+property name=expandFalse/property
+property name=fillTrue/property
+property name=position2/property
+  /packing
+/child
+  /object
+  packing
+property name=expandFalse/property
+property name=fillTrue/property
+property name=pack_typeend/property
+property name=position0/property
+  /packing
+/child
+child
+  object class=GtkBox id=box1
+property name=visibleTrue/property
+property name=can_focusFalse/property
+property name=orientationvertical/property
+child
+  object class=GtkFrame id=frame1
+property name=visibleTrue/property
+property name=can_focusFalse/property
+property name=label_xalign0/property
+property name=shadow_typenone/property
+child
+  object class=GtkAlignment id=alignment1
+property name=visibleTrue/property
+property name=can_focusFalse/property
+property name=top_padding6/property
+property name=left_padding12/property
+child
+  object class=GtkGrid id=grid1
+property name=visibleTrue/property
+property name=can_focusFalse/property
+property name=n_rows2/property
+property name=n_columns2/property
+child
+  object class=GtkSpinButton id=spinbutton1
+property name=visibleTrue/property
+property name=can_focusTrue/property
+ 

[PATCH] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-28 Thread Matthias Freund (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3646

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/3646/1

fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 2)

Change-Id: I389569b027a900f42e43762c5685ec239bc4b565
---
M sw/source/ui/shells/beziersh.cxx
M sw/source/ui/shells/drawsh.cxx
M sw/source/ui/shells/drformsh.cxx
M sw/source/ui/shells/drwbassh.cxx
M sw/source/ui/shells/drwtxtex.cxx
M sw/source/ui/shells/drwtxtsh.cxx
M sw/source/ui/shells/frmsh.cxx
7 files changed, 82 insertions(+), 118 deletions(-)



diff --git a/sw/source/ui/shells/beziersh.cxx b/sw/source/ui/shells/beziersh.cxx
index a5948bd..cdabed2 100644
--- a/sw/source/ui/shells/beziersh.cxx
+++ b/sw/source/ui/shells/beziersh.cxx
@@ -89,7 +89,7 @@
 pSh-LeaveSelFrmMode();
 pSh-NoEdit();
 }
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 }
 break;
@@ -102,13 +102,13 @@
 if ( pSh-IsDrawCreate() )
 {
 GetView().GetDrawFuncPtr()-BreakCreate();
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 else if ( pSh-HasSelection() || GetView().IsDrawMode() )
 {
 GetView().LeaveDrawCreate();
 pSh-EnterStdMode();
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 }
 break;
@@ -261,7 +261,7 @@
 switch (eSegm)
 {
 case SDRPATHSEGMENT_DONTCARE: 
rSet.InvalidateItem(SID_BEZIER_CONVERT); break;
-case SDRPATHSEGMENT_LINE: 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_False)); break; // Button 
reingedrueckt = Kurve
+case SDRPATHSEGMENT_LINE: 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_False)); break; // Button pressed = 
curve
 case SDRPATHSEGMENT_CURVE   : 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_True));  break;
 default:; //prevent warning
 }
diff --git a/sw/source/ui/shells/drawsh.cxx b/sw/source/ui/shells/drawsh.cxx
index eb402f7..bcf1b08 100644
--- a/sw/source/ui/shells/drawsh.cxx
+++ b/sw/source/ui/shells/drawsh.cxx
@@ -112,7 +112,7 @@
 }
 GetView().FlipDrawSelMode();
 pSdrView-SetFrameDragSingles(GetView().IsDrawSelMode());
-GetView().AttrChangedNotify(rSh); // Shellwechsel...
+GetView().AttrChangedNotify(rSh); // Shell switch
 break;
 
 case SID_OBJECT_HELL:
@@ -283,7 +283,7 @@
 sal_uInt16 nWhich = aIter.FirstWhich();
 sal_Bool bProtected = rSh.IsSelObjProtected(FLYPROTECT_CONTENT);
 
-if (!bProtected)// Im Parent nachsehen
+if (!bProtected)// Check the parent
 bProtected |= rSh.IsSelObjProtected( 
FLYPROTECT_CONTENT|FLYPROTECT_PARENT ) != 0;
 
 while( nWhich )
@@ -355,11 +355,8 @@
 SetName(OUString(Draw));
 }
 
-/*
-|*
-|* SfxRequests fuer FontWork bearbeiten
-|*
-\/
+// Edit SfxRequests for FontWork
+
 void SwDrawShell::ExecFormText(SfxRequest rReq)
 {
 SwWrtShell rSh = GetShell();
@@ -406,11 +403,8 @@
 pDrView-GetModel()-SetChanged(sal_True);
 }
 
-/*
-|*
-|* Statuswerte fuer FontWork zurueckgeben
-|*
-\/
+//Return status values for FontWork
+
 void SwDrawShell::GetFormTextState(SfxItemSet rSet)
 {
 SwWrtShell rSh = GetShell();
diff --git a/sw/source/ui/shells/drformsh.cxx b/sw/source/ui/shells/drformsh.cxx
index 1e7b3a7..e0d4112 100644
--- a/sw/source/ui/shells/drformsh.cxx
+++ b/sw/source/ui/shells/drformsh.cxx
@@ -111,7 +111,7 @@
 
 uno::Reference beans::XPropertySet   
xPropSet(xControlModel, uno::UNO_QUERY);
 
-// Darf man eine URL an dem Objekt setzen?
+// Can we set an URL to the object?
 OUString sTargetURL( TargetURL );
 uno::Reference beans::XPropertySetInfo   
xPropInfoSet = xPropSet-getPropertySetInfo();
 if( xPropInfoSet-hasPropertyByName( sTargetURL ))
@@ -120,7 +120,7 @@
 if( !aProp.Name.isEmpty() )
 

Re: [PATCH] fdo#35320 A fix for Arabic justification problem caused by k...

2013-04-28 Thread Khaled Hosny
On Sun, Apr 28, 2013 at 06:04:04AM +, Ahmad Harthi (via Code Review) wrote:
 Hi,
 
 I have submitted a patch for review:
 
 https://gerrit.libreoffice.org/3644
 
 To pull it, you can do:
 
 git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1
 
 fdo#35320 A fix for Arabic justification problem caused by kashidas
 
 diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx
 index 9d315e3..d4696c7 100644
 --- a/vcl/source/gdi/sallayout.cxx
 +++ b/vcl/source/gdi/sallayout.cxx
 @@ -1274,7 +1274,7 @@
  // calculate gap, ignore if too small
  int nGapWidth = pG-mnNewWidth - pG-mnOrigWidth;
  // worst case is one kashida even for mini-gaps
 -if( 3 * nGapWidth  nKashidaWidth )
 +if( nGapWidth  nKashidaWidth )
  continue;
  
  nKashidaCount = 0;

Can we have some explanation what the patch is doing? Neither the commit
message nor the bugzilla issue explain the fix.

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] make use of pOutWin, which is member of ImpEditView class.

2013-04-28 Thread navin patidar (via Code Review)
navin patidar has abandoned this change.

Change subject: make use of pOutWin, which is member of ImpEditView class.
..


Patch Set 2: Abandoned

dynamic cast produces pOutWin only when pTargetDevice is NULL for 
ImpEditEngine::Paint( ImpEditView* pView, const Rectangle rRect, OutputDevice* 
pTargetDevice, sal_Bool bUseVirtDev )
.

-- 
To view, visit https://gerrit.libreoffice.org/3592
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I78218572abe06f189eb20ba341c4de3aced8df61
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: navin patidar pati...@kacst.edu.sa
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org
Gerrit-Reviewer: navin patidar pati...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sc/source

2013-04-28 Thread Caolán McNamara
 sc/source/filter/orcus/interface.cxx |   34 --
 1 file changed, 16 insertions(+), 18 deletions(-)

New commits:
commit ca97ee598a08365f7bef7e7b8172bff4433ee8b0
Author: Caolán McNamara caol...@redhat.com
Date:   Sat Apr 27 21:05:42 2013 +0100

collision between orcus::spreadsheet::col_t and aix col_t typedef

Change-Id: I091b12bed3cdfd3abacaa0dba7913d0351d17634

diff --git a/sc/source/filter/orcus/interface.cxx 
b/sc/source/filter/orcus/interface.cxx
index a32842c..a3c1e6d 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -24,9 +24,7 @@
 
 using namespace com::sun::star;
 
-using orcus::spreadsheet::row_t;
-using orcus::spreadsheet::col_t;
-using orcus::spreadsheet::formula_grammar_t;
+namespace os = orcus::spreadsheet;
 
 ScOrcusGlobalSettings::ScOrcusGlobalSettings(ScDocumentImport rDoc) : 
mrDoc(rDoc) {}
 
@@ -188,14 +186,14 @@ void ScOrcusSheet::cellInserted()
 }
 }
 
-void ScOrcusSheet::set_auto(row_t row, col_t col, const char* p, size_t n)
+void ScOrcusSheet::set_auto(os::row_t row, os::col_t col, const char* p, 
size_t n)
 {
 OUString aVal(p, n, RTL_TEXTENCODING_UTF8);
 mrDoc.setAutoInput(ScAddress(col, row, mnTab), aVal);
 cellInserted();
 }
 
-void ScOrcusSheet::set_string(row_t row, col_t col, size_t sindex)
+void ScOrcusSheet::set_string(os::row_t row, os::col_t col, size_t sindex)
 {
 // We need to defer string cells since the shared string pool is not yet
 // populated at the time this method is called.  Orcus imports string
@@ -206,20 +204,20 @@ void ScOrcusSheet::set_string(row_t row, col_t col, 
size_t sindex)
 cellInserted();
 }
 
-void ScOrcusSheet::set_value(row_t row, col_t col, double value)
+void ScOrcusSheet::set_value(os::row_t row, os::col_t col, double value)
 {
 mrDoc.setNumericCell(ScAddress(col, row, mnTab), value);
 cellInserted();
 }
 
-void ScOrcusSheet::set_bool(row_t row, col_t col, bool value)
+void ScOrcusSheet::set_bool(os::row_t row, os::col_t col, bool value)
 {
 mrDoc.setNumericCell(ScAddress(col, row, mnTab), value ? 1.0 : 0.0);
 cellInserted();
 }
 
 void ScOrcusSheet::set_date_time(
-row_t row, col_t col, int year, int month, int day, int hour, int minute, 
double second)
+os::row_t row, os::col_t col, int year, int month, int day, int hour, int 
minute, double second)
 {
 SvNumberFormatter* pFormatter = mrDoc.getDoc().GetFormatTable();
 
@@ -242,13 +240,13 @@ void ScOrcusSheet::set_date_time(
 cellInserted();
 }
 
-void ScOrcusSheet::set_format(row_t /*row*/, col_t /*col*/, size_t 
/*xf_index*/)
+void ScOrcusSheet::set_format(os::row_t /*row*/, os::col_t /*col*/, size_t 
/*xf_index*/)
 {
 }
 
 namespace {
 
-formula::FormulaGrammar::Grammar getCalcGrammarFromOrcus( formula_grammar_t 
grammar )
+formula::FormulaGrammar::Grammar getCalcGrammarFromOrcus( 
os::formula_grammar_t grammar )
 {
 formula::FormulaGrammar::Grammar eGrammar = 
formula::FormulaGrammar::GRAM_ODFF;
 switch(grammar)
@@ -271,7 +269,7 @@ formula::FormulaGrammar::Grammar getCalcGrammarFromOrcus( 
formula_grammar_t gram
 }
 
 void ScOrcusSheet::set_formula(
-row_t row, col_t col, formula_grammar_t grammar, const char* p, size_t n)
+os::row_t row, os::col_t col, os::formula_grammar_t grammar, const char* 
p, size_t n)
 {
 OUString aFormula(p, n, RTL_TEXTENCODING_UTF8);
 formula::FormulaGrammar::Grammar eGrammar = getCalcGrammarFromOrcus( 
grammar );
@@ -279,7 +277,7 @@ void ScOrcusSheet::set_formula(
 cellInserted();
 }
 
-void ScOrcusSheet::set_formula_result(row_t row, col_t col, const char* p, 
size_t n)
+void ScOrcusSheet::set_formula_result(os::row_t row, os::col_t col, const 
char* p, size_t n)
 {
 ScFormulaCell* pCell = mrDoc.getDoc().GetFormulaCell(ScAddress(col, row, 
mnTab));
 if (!pCell)
@@ -293,7 +291,7 @@ void ScOrcusSheet::set_formula_result(row_t row, col_t col, 
const char* p, size_
 }
 
 void ScOrcusSheet::set_shared_formula(
-row_t row, col_t col, formula_grammar_t grammar, size_t sindex,
+os::row_t row, os::col_t col, os::formula_grammar_t grammar, size_t sindex,
 const char* p_formula, size_t n_formula)
 {
 OUString aFormula( p_formula, n_formula, RTL_TEXTENCODING_UTF8 );
@@ -314,7 +312,7 @@ void ScOrcusSheet::set_shared_formula(
 }
 
 void ScOrcusSheet::set_shared_formula(
-row_t row, col_t col, formula_grammar_t grammar, size_t sindex,
+os::row_t row, os::col_t col, os::formula_grammar_t grammar, size_t sindex,
 const char* p_formula, size_t n_formula, const char* /*p_range*/, size_t 
/*n_range*/)
 {
 OUString aFormula( p_formula, n_formula, RTL_TEXTENCODING_UTF8 );
@@ -334,7 +332,7 @@ void ScOrcusSheet::set_shared_formula(
 }
 }
 
-void ScOrcusSheet::set_shared_formula(row_t row, col_t col, size_t sindex)
+void ScOrcusSheet::set_shared_formula(os::row_t row, os::col_t col, size_t 
sindex)
 {
 if(maSharedFormulas.find(sindex) == maSharedFormulas.end())
  

[Libreoffice-commits] core.git: desktop/inc desktop/source desktop/unx sw/source

2013-04-28 Thread Thomas Arnhold
 desktop/inc/app.hxx  |   14 +---
 desktop/source/app/appfirststart.cxx |2 
 desktop/source/app/appinit.cxx   |4 -
 desktop/source/app/check_ext_deps.cxx|3 +
 desktop/source/deployment/gui/license_dialog.hxx |   18 ++
 desktop/source/offacc/acceptor.cxx   |7 ++
 desktop/source/offacc/acceptor.hxx   |   63 -
 desktop/unx/splash/unxsplash.cxx |1 
 desktop/unx/splash/unxsplash.hxx |   23 +++
 sw/source/filter/ww1/w1class.hxx |   68 +++
 10 files changed, 93 insertions(+), 110 deletions(-)

New commits:
commit 2094610175140023cf8f904f8506c189e36dec06
Author: Thomas Arnhold tho...@arnhold.org
Date:   Sun Apr 28 10:36:40 2013 +0200

namespacing cleanup

Change-Id: I1384bf53a29e174bb97db4c0644f9dce39c0e36d

diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index f53f08c..d949304 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -37,10 +37,6 @@ namespace com { namespace sun { namespace star { namespace 
uno {
 class XComponentContext;
 } } } }
 
-using namespace com::sun::star::task;
-using namespace com::sun::star::uno;
-using namespace com::sun::star::lang;
-
 namespace desktop
 {
 
@@ -49,7 +45,7 @@ namespace desktop
  */
 class CommandLineArgs;
 class Lockfile;
-class AcceptorMap : public std::map OUString, ReferenceXInitialization  {};
+class AcceptorMap : public std::map OUString, 
css::uno::Referencecss::lang::XInitialization  {};
 struct ConvertData;
 class Desktop : public Application
 {
@@ -137,8 +133,8 @@ class Desktop : public Application
 
 private:
 void RegisterServices(
-com::sun::star::uno::Reference
-com::sun::star::uno::XComponentContext  const  context);
+css::uno::Reference
+css::uno::XComponentContext  const  context);
 voidDeregisterServices();
 
 voidCreateTemporaryDirectory();
@@ -148,7 +144,7 @@ class Desktop : public Application
 boolInitializeConfiguration();
 voidFlushConfiguration();
 static sal_Bool shouldLaunchQuickstart();
-sal_BoolInitializeQuickstartMode( const 
com::sun::star::uno::Reference com::sun::star::uno::XComponentContext  
rxContext );
+sal_BoolInitializeQuickstartMode( const 
css::uno::Reference css::uno::XComponentContext  rxContext );
 
 voidHandleBootstrapPathErrors( 
::utl::Bootstrap::Status, const OUString aMsg );
 voidStartSetup( const OUString aParameters );
@@ -160,7 +156,7 @@ class Desktop : public Application
 static void PreloadModuleData( const CommandLineArgs );
 static void PreloadConfigurationData();
 
-ReferenceXStatusIndicator m_rSplashScreen;
+css::uno::Referencecss::task::XStatusIndicator m_rSplashScreen;
 voidOpenSplashScreen();
 voidCloseSplashScreen();
 
diff --git a/desktop/source/app/appfirststart.cxx 
b/desktop/source/app/appfirststart.cxx
index af9eb05..97ca6e1 100644
--- a/desktop/source/app/appfirststart.cxx
+++ b/desktop/source/app/appfirststart.cxx
@@ -33,6 +33,8 @@
 using namespace ::desktop;
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::beans;
+using namespace ::com::sun::star::lang;
+using namespace ::com::sun::star::uno;
 
 static const char aAccessSrvc[] = 
com.sun.star.configuration.ConfigurationUpdateAccess;
 
diff --git a/desktop/source/app/appinit.cxx b/desktop/source/app/appinit.cxx
index 42f2b6b..05b3b30 100644
--- a/desktop/source/app/appinit.cxx
+++ b/desktop/source/app/appinit.cxx
@@ -30,8 +30,6 @@
 #include com/sun/star/uno/Exception.hpp
 #include com/sun/star/uno/XCurrentContext.hpp
 #include com/sun/star/packages/zip/ZipIOException.hpp
-
-
 #include com/sun/star/beans/XPropertySet.hpp
 #include com/sun/star/ucb/UniversalContentBroker.hpp
 #include com/sun/star/ucb/XUniversalContentBroker.hpp
@@ -55,7 +53,6 @@
 #include vcl/svapp.hxx
 #include unotools/pathoptions.hxx
 
-
 using namespace desktop;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
@@ -63,7 +60,6 @@ using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::registry;
 using namespace ::com::sun::star::ucb;
 
-
 namespace desktop
 {
 
diff --git a/desktop/source/app/check_ext_deps.cxx 
b/desktop/source/app/check_ext_deps.cxx
index 2ea7f84..bb9aadb 100644
--- a/desktop/source/app/check_ext_deps.cxx
+++ b/desktop/source/app/check_ext_deps.cxx
@@ -57,6 +57,9 @@
 
 using namespace desktop;
 using namespace com::sun::star;
+using namespace com::sun::star::lang;
+using namespace 

Re: Need Guidance on bug fdo#37222

2013-04-28 Thread Tomaž Vajngerl
Hi,

system(xdg-open abc.pdf); is not good enough - this won't work on OSX or
Windows.

You have to use XSystemShellExecute:
ReferenceXSystemShellExecute
xSystemShellExecute(SystemShellExecute::create(
::comphelper::getProcessComponentContext() ) );
xSystemShellExecute-execute( aFileName, OUString(),
SystemShellExecuteFlags::URIS_ONLY );

see svx/source/core/extedit.cxx method ExternalToolEdit::threadWorker as an
example where it is used.

As for path and filename in PDFExport::Export you get rFile as parameter
- this is the location where the file will be written to.

Regards, Tomaž




On Sat, Apr 27, 2013 at 1:34 AM, Anurag Kanungo anuragkanu...@gmail.comwrote:


 Hi,

 In bug

 https://bugs.freedesktop.org/show_bug.cgi?id=37222

 I was trying to resolve the bug , and got a little progress that whenever
 a user
 exports the pdf , i am able to open a particular fixed pdf file .

 In file filter/source/pdf/pdfexport.cxx,

 i used there system(xdg-open abc.pdf);   //xdg-open because it can
 work with any desktop environment (i guess)

 so it will always open abc.pdf file .



 I am not able to open the newly saved pdf file , as i require the location
 and the name of the new pdf to open it ,
 and i also require to convert string to const char* , as string.c_str();
 doesn't worked there .

 Thank You .



 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] libvisio.git: src/lib

2013-04-28 Thread Fridrich Štrba
 src/lib/gentoken.pl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cbe03a66e9bee3edae23c6462b8292b454892541
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Fri Apr 26 11:16:15 2013 +0200

Token ID 0 is special in the way the has handles it

diff --git a/src/lib/gentoken.pl b/src/lib/gentoken.pl
index 27da298..67689fb 100644
--- a/src/lib/gentoken.pl
+++ b/src/lib/gentoken.pl
@@ -71,9 +71,9 @@ print ( HXX \n );
 $i = 0;
 foreach( sort(keys(%tokens)) )
 {
+$i = $i + 1;
 print( HXX const int $tokens{$_} = $i;\n );
 print( GPERF $_,$tokens{$_}\n );
-$i = $i + 1;
 }
 print ( GPERF %%\n );
 print ( HXX \n );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: svx/source

2013-04-28 Thread Luke Deller
 svx/source/svdraw/svdoashp.cxx |1 -
 svx/source/svdraw/svdobj.cxx   |   12 
 2 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 57082b1243e86694b72c5e4fad013bf207bfe81a
Author: Luke Deller l...@deller.id.au
Date:   Sun Apr 28 07:06:11 2013 +1000

fdo#60910: discard UNO shape object in SdrObject::SetPage

The creation of the UNO shape in SdrObject::getUnoShape is influenced
by pPage, so when the page changes we need to discard the cached UNO
shape so that a new one will be created with the new page.

This replaces my first shot at a fix for fdo#60910 which reinstated a
line to discard the custom shape engine (and consequently the UNO shape) in
SdrObjCustomShape::InvalidateRenderGeometry.  That worked but did more
discarding than was necessary.

Change-Id: I665fb6f9e1563bbc4eced046f027a53991a7e45f
Reviewed-on: https://gerrit.libreoffice.org/3642
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index fd0c5c8..67bd0a5 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -3217,7 +3217,6 @@ bool SdrObjCustomShape::doConstructOrthogonal(const 
OUString rName)
 void SdrObjCustomShape::InvalidateRenderGeometry()
 {
 mXRenderedCustomShape = 0L;
-mxCustomShapeEngine = 0L;
 SdrObject::Free( mpLastShadowGeometry );
 mpLastShadowGeometry = 0L;
 }
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 8385b07..fca7f2a 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -568,12 +568,24 @@ SdrObjList* SdrObject::GetObjList() const
 
 void SdrObject::SetPage(SdrPage* pNewPage)
 {
+SdrModel* pOldModel = pModel;
+SdrPage* pOldPage = pPage;
+
 pPage=pNewPage;
 if (pPage!=NULL) {
 SdrModel* pMod=pPage-GetModel();
 if (pMod!=pModel  pMod!=NULL) {
 SetModel(pMod);
 }}
+
+// The creation of the UNO shape in SdrObject::getUnoShape is influenced
+// by pPage, so when the page changes we need to discard the cached UNO
+// shape so that a new one will be created.
+// If the page is changing to another page with the same model, we
+// assume they create compatible UNO shape objects so we shouldn't have
+// to invalidate.
+if (pOldPage != pPage  !(pOldPage  pPage  pOldModel == pModel))
+setUnoShape(NULL);
 }
 
 SdrPage* SdrObject::GetPage() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] fdo#60910: discard UNO shape object in SdrObject::SetPage

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3642

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3642
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I665fb6f9e1563bbc4eced046f027a53991a7e45f
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luke Deller l...@deller.id.au
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Matthias Freund
 sw/source/ui/shells/beziersh.cxx |8 ++---
 sw/source/ui/shells/drawsh.cxx   |   18 +++
 sw/source/ui/shells/drformsh.cxx |7 +---
 sw/source/ui/shells/drwbassh.cxx |   37 ++-
 sw/source/ui/shells/drwtxtex.cxx |   26 +++-
 sw/source/ui/shells/drwtxtsh.cxx |   61 ++-
 sw/source/ui/shells/frmsh.cxx|   43 ---
 7 files changed, 82 insertions(+), 118 deletions(-)

New commits:
commit df0376ea3f80f7bab7f4075dc8004e8f25d0d9a4
Author: Matthias Freund matti...@yahoo.de
Date:   Sun Apr 28 09:34:57 2013 +0200

fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 2)

Change-Id: I389569b027a900f42e43762c5685ec239bc4b565
Reviewed-on: https://gerrit.libreoffice.org/3646
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/sw/source/ui/shells/beziersh.cxx b/sw/source/ui/shells/beziersh.cxx
index a5948bd..cdabed2 100644
--- a/sw/source/ui/shells/beziersh.cxx
+++ b/sw/source/ui/shells/beziersh.cxx
@@ -89,7 +89,7 @@ void SwBezierShell::Execute(SfxRequest rReq)
 pSh-LeaveSelFrmMode();
 pSh-NoEdit();
 }
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 }
 break;
@@ -102,13 +102,13 @@ void SwBezierShell::Execute(SfxRequest rReq)
 if ( pSh-IsDrawCreate() )
 {
 GetView().GetDrawFuncPtr()-BreakCreate();
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 else if ( pSh-HasSelection() || GetView().IsDrawMode() )
 {
 GetView().LeaveDrawCreate();
 pSh-EnterStdMode();
-GetView().AttrChangedNotify(pSh); // ggf Shellwechsel...
+GetView().AttrChangedNotify(pSh); // Shell change if 
applicable...
 }
 }
 break;
@@ -261,7 +261,7 @@ void SwBezierShell::GetState(SfxItemSet rSet)
 switch (eSegm)
 {
 case SDRPATHSEGMENT_DONTCARE: 
rSet.InvalidateItem(SID_BEZIER_CONVERT); break;
-case SDRPATHSEGMENT_LINE: 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_False)); break; // Button 
reingedrueckt = Kurve
+case SDRPATHSEGMENT_LINE: 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_False)); break; // Button pressed = 
curve
 case SDRPATHSEGMENT_CURVE   : 
rSet.Put(SfxBoolItem(SID_BEZIER_CONVERT,sal_True));  break;
 default:; //prevent warning
 }
diff --git a/sw/source/ui/shells/drawsh.cxx b/sw/source/ui/shells/drawsh.cxx
index eb402f7..bcf1b08 100644
--- a/sw/source/ui/shells/drawsh.cxx
+++ b/sw/source/ui/shells/drawsh.cxx
@@ -112,7 +112,7 @@ void SwDrawShell::Execute(SfxRequest rReq)
 }
 GetView().FlipDrawSelMode();
 pSdrView-SetFrameDragSingles(GetView().IsDrawSelMode());
-GetView().AttrChangedNotify(rSh); // Shellwechsel...
+GetView().AttrChangedNotify(rSh); // Shell switch
 break;
 
 case SID_OBJECT_HELL:
@@ -283,7 +283,7 @@ void SwDrawShell::GetState(SfxItemSet rSet)
 sal_uInt16 nWhich = aIter.FirstWhich();
 sal_Bool bProtected = rSh.IsSelObjProtected(FLYPROTECT_CONTENT);
 
-if (!bProtected)// Im Parent nachsehen
+if (!bProtected)// Check the parent
 bProtected |= rSh.IsSelObjProtected( 
FLYPROTECT_CONTENT|FLYPROTECT_PARENT ) != 0;
 
 while( nWhich )
@@ -355,11 +355,8 @@ SwDrawShell::SwDrawShell(SwView _rView) :
 SetName(OUString(Draw));
 }
 
-/*
-|*
-|* SfxRequests fuer FontWork bearbeiten
-|*
-\/
+// Edit SfxRequests for FontWork
+
 void SwDrawShell::ExecFormText(SfxRequest rReq)
 {
 SwWrtShell rSh = GetShell();
@@ -406,11 +403,8 @@ void SwDrawShell::ExecFormText(SfxRequest rReq)
 pDrView-GetModel()-SetChanged(sal_True);
 }
 
-/*
-|*
-|* Statuswerte fuer FontWork zurueckgeben
-|*
-\/
+//Return status values for FontWork
+
 void SwDrawShell::GetFormTextState(SfxItemSet rSet)
 {
 SwWrtShell rSh = GetShell();
diff --git a/sw/source/ui/shells/drformsh.cxx b/sw/source/ui/shells/drformsh.cxx
index 1e7b3a7..e0d4112 100644
--- 

[PUSHED] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3646

Approvals:
  Chris Sherlock: Looks good to me, but someone else must approve
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3646
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I389569b027a900f42e43762c5685ec239bc4b565
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matthias Freund matti...@yahoo.de
Gerrit-Reviewer: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: filter/source

2013-04-28 Thread Julien Nabet
 filter/source/msfilter/svdfppt.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit b5ca660e41fd81156ed62aa2c8451ed66a61eed4
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Apr 28 14:13:05 2013 +0200

coverity#988424: Logically dead code

Change-Id: I916d72cb1104a4d6109a3c5a3a74fb74cea74769

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index fca74f7..8354791 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -5060,21 +5060,15 @@ void PPTStyleTextPropReader::ReadCharProps( SvStream 
rIn, PPTCharPropSet aChar
 if ( nExtParaPos )
 {
 sal_uInt32 nExtBuInd = nMask  0x3c00;
-sal_uInt32  nExtParaNibble = 0;
 if ( nExtBuInd )
 nExtBuInd = ( aSet.mnFlags  0x3c00 )  10;
 if ( nExtBuInd  aStyleTextProp9.size() )
 {
-if ( nExtParaNibble  ( ( nExtBuInd + nExtParaNibble )  
aStyleTextProp9.size() ) )
-nExtBuInd += nExtParaNibble;
-
 nExtParaFlags = aStyleTextProp9[ nExtBuInd ].mnExtParagraphMask;
 nBuBlip = aStyleTextProp9[ nExtBuInd ].mnBuBlip;
 nHasAnm = aStyleTextProp9[ nExtBuInd ].mnHasAnm;
 nAnmScheme = aStyleTextProp9[ nExtBuInd ].mnAnmScheme;
 }
-if ( ( nExtBuInd  0xf ) == 0xf )
-nExtParaNibble += 16;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[SOLVED] Re: About coverity 988424 (svdfppt.cxx from filter module)

2013-04-28 Thread Julien Nabet

On 24/04/2013 18:25, Caolán McNamara wrote:

On Sat, 2013-03-16 at 14:03 -0700, julien2412 wrote:

Hello,

Scan coverity detected this:
CID 988424 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this expression nExtBuInd + nExtParaNibble
aStyleTextProp9-size() inside statement if (nExtParaNibble  nExtB

Indeed, we have these lines:
5026 if ( nExtParaPos )
5027 {
5028 sal_uInt32 nExtBuInd = nMask  0x3c00;
5029 sal_uInt32  nExtParaNibble = 0;
5030 if ( nExtBuInd )
5031 nExtBuInd = ( aSet.mnFlags  0x3c00 )  10;
5032 if ( nExtBuInd  aStyleTextProp9.size() )
5033 {
5034 if ( nExtParaNibble  ( ( nExtBuInd + nExtParaNibble )
  aStyleTextProp9.size() ) )
5035 nExtBuInd += nExtParaNibble;

(see
http://opengrok.libreoffice.org/xref/core/filter/source/msfilter/svdfppt.cxx#5026)

Any idea what should be done?

Git doesn't seem able to track back to where this code was really
originally written across the old version control file moves and
removes. But throwing some key words into google I can find the original
code, and can determine it happened with
StyleTextProp with empty text PPT import (bnc#485630) [Thorsten] which
appeared to get merged to OpenOffice.org from ooo-build in Jun 2009.

The original code it was based on was originally a loop where multiple
properties were read and it made sense to increment nExtParaNibble
between properties. Now it doesn't.

So, yeah, all lines with nExtParaNibble in them or depend on those lines
or exist only to set that value can be removed as it enters the
condition as 0, and gets useless set to non 0 after exiting the
condition.
Thank you Caolán, I pushed the fix on master (see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b5ca660e41fd81156ed62aa2c8451ed66a61eed4)


Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3647

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/3647/1

Keep OUString instance by using local variable to avoid crash.

Crash with GCC 4.8 without the modification.

Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
---
M sw/source/core/text/itrcrsr.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index b68b5ce..d567e76 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -1593,7 +1593,8 @@
 else
 nOldProp = 0;
 {
-SwTxtSizeInfo aSizeInf( GetInfo(), rText, nCurrStart );
+OUString rTextStr = rText;
+SwTxtSizeInfo aSizeInf( GetInfo(), rTextStr, nCurrStart );
 ((SwTxtCursor*)this)-SeekAndChg( aSizeInf );
 SwTxtSlot aDiffTxt( aSizeInf, ((SwTxtPortion*)pPor), false, 
false );
 SwFontSave aSave( aSizeInf, pPor-IsDropPortion() ?

-- 
To view, visit https://gerrit.libreoffice.org/3647
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 4 commits - solenv/gbuild

2013-04-28 Thread David Tardon
 solenv/gbuild/InternalUnoApi.mk  |4 
 solenv/gbuild/TargetLocations.mk |2 --
 solenv/gbuild/UnoApi.mk  |   21 +
 solenv/gbuild/UnoApiTarget.mk|   11 +--
 4 files changed, 14 insertions(+), 24 deletions(-)

New commits:
commit 92b618f5829bc46104c4c0ba2129bd857b42b4c6
Author: David Tardon dtar...@redhat.com
Date:   Sun Apr 28 14:44:19 2013 +0200

do not copy anything to instdir in build stage

Change-Id: I923704d47d4fbc764e847a1bd6eed9fca2dce089

diff --git a/solenv/gbuild/UnoApi.mk b/solenv/gbuild/UnoApi.mk
index 9d2a80b..6897af9 100644
--- a/solenv/gbuild/UnoApi.mk
+++ b/solenv/gbuild/UnoApi.mk
@@ -10,8 +10,7 @@
 gb_UnoApi_DOCDIR := $(gb_Package_SDKDIRNAME)/docs/common/ref
 # NOTE: this is the output dir used in odk/CustomTarget_autodoc.mk
 gb_UnoApi_SRCDOCDIR := $(call gb_CustomTarget_get_workdir,odk/docs/common/ref)
-gb_UnoApi_ENABLE_DOC := $(filter ODK,$(BUILD_TYPE))
-gb_UnoApi_ENABLE_IDL := $(filter ODK,$(BUILD_TYPE))
+gb_UnoApi_ENABLE_INSTALL := $(and $(filter host,$(gb_Side)),$(filter 
ODK,$(BUILD_TYPE)))
 
 # NOTE: This is needed temporarily to force rebuild with API files from
 # $(WORKDIR), thus fixing generated deps. Otherwise, a change of an .idl
@@ -30,11 +29,9 @@ $(call gb_UnoApi_get_clean_target,%) :
 define gb_UnoApi_UnoApi
 $(call gb_UnoApiTarget_UnoApiTarget,$(1))
 $(call gb_UnoApiHeadersTarget_UnoApiHeadersTarget,$(1))
-ifneq ($(gb_UnoApi_ENABLE_IDL),)
+ifneq ($(gb_UnoApi_ENABLE_INSTALL),)
 $(call gb_Package_Package_internal,$(1)_idl,$(SRCDIR))
 $(call gb_Package_set_outdir,$(1)_idl,$(INSTDIR))
-endif
-ifneq ($(gb_UnoApi_ENABLE_DOC),)
 $(call gb_Package_Package_internal,$(1)_doc,$(gb_UnoApi_SRCDOCDIR))
 $(call gb_Package_set_outdir,$(1)_doc,$(INSTDIR))
 endif
@@ -56,7 +53,7 @@ $(call gb_Helper_make_userfriendly_targets,$(1),UnoApi)
 
 endef
 
-ifneq ($(gb_UnoApi_ENABLE_IDL),)
+ifneq ($(gb_UnoApi_ENABLE_INSTALL),)
 
 # Create a package of IDL files for putting into SDK.
 #
@@ -72,7 +69,7 @@ $(call gb_Package_add_file,$(1)_idl,$(patsubst 
$(1)/%,$(gb_Package_SDKDIRNAME)/i
 
 endef
 
-else # !gb_UnoApi_ENABLE_IDL
+else # !gb_UnoApi_ENABLE_INSTALL
 
 gb_UnoApi_package_idlfiles :=
 gb_UnoApi__add_idlfile :=
@@ -91,7 +88,7 @@ $(call gb_UnoApi__add_headerfile_impl,$(1),$(2),$(subst $() 
$(),/,$(wordlist 2,$
 
 endef
 
-ifneq ($(gb_UnoApi_ENABLE_DOC),)
+ifneq ($(gb_UnoApi_ENABLE_INSTALL),)
 
 # gb_UnoApi__add_docfile_impl api htmlfile
 define gb_UnoApi__add_docfile_impl
@@ -129,7 +126,7 @@ $(foreach idlfile,$(3),$(call 
gb_UnoApi__add_docfile_for_idl,$(1),$(2)/$(idlfile
 
 endef
 
-else
+else # !gb_UnoApi_ENABLE_INSTALL
 
 gb_UnoApi__add_docfile :=
 gb_UnoApi__add_docfiles :=
commit 423bec3b760092cd1aadebd710586b007dd80ee0
Author: David Tardon dtar...@redhat.com
Date:   Sun Apr 28 14:12:00 2013 +0200

drop UnoApiTarget_get_*headers

This was actually meant for idls, not headers :-) And it is obsolete, as
we do not deliver these to $(OUTDIR) anymore. We use explicit include
paths into $(SRCDIR) instead.

Change-Id: Iccb0dc529a99be59390f032fc331996146829abb

diff --git a/solenv/gbuild/InternalUnoApi.mk b/solenv/gbuild/InternalUnoApi.mk
index dabcdf5..869b6a7 100644
--- a/solenv/gbuild/InternalUnoApi.mk
+++ b/solenv/gbuild/InternalUnoApi.mk
@@ -33,9 +33,6 @@ $(call gb_InternalUnoApi_get_target,$(1)) : $(call 
gb_UnoApiTarget_get_target,$(
 $(call gb_InternalUnoApi_get_target,$(1)) :| $(dir $(call 
gb_InternalUnoApi_get_target,$(1))).dir
 $(call gb_InternalUnoApi_get_clean_target,$(1)) : $(call 
gb_UnoApiHeadersTarget_get_clean_target,$(1))
 
-$(call gb_UnoApiTarget_get_headers_target,$(1)) : $(gb_Helper_MISCDUMMY)
-$(call gb_UnoApiTarget_get_external_headers_target,$(1)) : 
$(gb_Helper_MISCDUMMY)
-
 $$(eval $$(call gb_Module_register_target,$(call 
gb_InternalUnoApi_get_target,$(1)),$(call 
gb_InternalUnoApi_get_clean_target,$(1
 $(call gb_Helper_make_userfriendly_targets,$(1),InternalUnoApi)
 
@@ -55,7 +52,6 @@ define gb_InternalUnoApi__use_api
 $(call gb_UnoApiTarget_use_api,$(1),$(2))
 $(call gb_UnoApiHeadersTarget_use_api,$(1),$(2))
 $(call gb_InternalUnoApi_get_target,$(1)) : $(call 
gb_UnoApiTarget_get_target,$(2))
-$(call gb_UnoApiTarget_get_external_headers_target,$(1)) : $(call 
gb_UnoApiTarget_get_headers_target,$(2))
 
 endef
 
diff --git a/solenv/gbuild/TargetLocations.mk b/solenv/gbuild/TargetLocations.mk
index 3c43b36..727e582 100644
--- a/solenv/gbuild/TargetLocations.mk
+++ b/solenv/gbuild/TargetLocations.mk
@@ -195,8 +195,6 @@ gb_UIImageListTarget_get_target = 
$(WORKDIR)/UIImageListTarget/$(1).ilst
 gb_UILocalizeTarget_get_target = $(WORKDIR)/UILocalizeTarget/$(1).done
 gb_UILocalizeTarget_get_workdir = $(WORKDIR)/UILocalizeTarget/$(1)
 gb_UIMenubarTarget_get_target = $(WORKDIR)/UIMenubarTarget/$(1).xml
-gb_UnoApiTarget_get_external_headers_target = 
$(WORKDIR)/UnoApiTarget/$(1).external
-gb_UnoApiTarget_get_headers_target = $(WORKDIR)/UnoApiTarget/$(1).headers
 

[PATCH] fdo#63197: convert fontunxafm

2013-04-28 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3648

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/3648/1

fdo#63197: convert fontunxafm

Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804
---
R afms/ExternalPackage_fontunxafm.mk
M afms/Module_afms.mk
M scp2/source/ooo/file_extra_ooo.scp
3 files changed, 7 insertions(+), 9 deletions(-)



diff --git a/afms/Zip_fontunxafm.mk b/afms/ExternalPackage_fontunxafm.mk
similarity index 82%
rename from afms/Zip_fontunxafm.mk
rename to afms/ExternalPackage_fontunxafm.mk
index 058ee7e..d2600a1 100644
--- a/afms/Zip_fontunxafm.mk
+++ b/afms/ExternalPackage_fontunxafm.mk
@@ -7,13 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,fontunxafm,$(call gb_UnpackedTarball_get_dir,afms)))
+$(eval $(call gb_ExternalPackage_ExternalPackage,afms_fontunxafm,afms))
 
-$(eval $(call gb_Zip_add_dependencies,fontunxafm,\
-   $(call gb_UnpackedTarball_get_target,afms) \
-))
+$(eval $(call gb_ExternalPackage_set_outdir,afms_fontunxafm,$(INSTDIR)))
 
-$(eval $(call gb_Zip_add_files,fontunxafm,\
+$(eval $(call 
gb_ExternalPackage_add_unpacked_files,afms_fontunxafm,share/psprint/fontmetric,\
Courier-Bold.afm \
Courier-BoldOblique.afm \
Courier-Oblique.afm \
diff --git a/afms/Module_afms.mk b/afms/Module_afms.mk
index ee04aa9..5e0c750 100644
--- a/afms/Module_afms.mk
+++ b/afms/Module_afms.mk
@@ -11,7 +11,7 @@
 
 $(eval $(call gb_Module_add_targets,afms,\
UnpackedTarball_afms \
-   Zip_fontunxafm \
+   ExternalPackage_fontunxafm \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/scp2/source/ooo/file_extra_ooo.scp 
b/scp2/source/ooo/file_extra_ooo.scp
index 93ebc12..0a804d3 100644
--- a/scp2/source/ooo/file_extra_ooo.scp
+++ b/scp2/source/ooo/file_extra_ooo.scp
@@ -208,10 +208,10 @@
 
 #ifndef WITHOUT_AFMS
 File gid_File_Extra_Fontunxafm
-Dir = gid_Dir_Psprint_Fontmetric;
+Dir = FILELIST_DIR;
 TXT_FILE_BODY;
-Styles = (ARCHIVE);
-Name = fontunxafm.zip;
+Styles = (FILELIST);
+Name = afms_fontunxafm.filelist;
 End
 #endif
 

-- 
To view, visit https://gerrit.libreoffice.org/3648
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[ABANDONED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has abandoned this change.

Change subject: Keep OUString instance by using local variable to avoid crash.
..


Patch Set 1: Abandoned

http://cgit.freedesktop.org/~vmiklos/lo-core/commit/?id=bfb8d155269e915b150f2690323df5d572e69683
 is better to solve this issue.

-- 
To view, visit https://gerrit.libreoffice.org/3647
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#63197: convert helpxsl

2013-04-28 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3649

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/3649/1

fdo#63197: convert helpxsl

Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089
---
M scp2/source/ooo/file_ooo.scp
M xmlhelp/Module_xmlhelp.mk
R xmlhelp/Package_helpxsl.mk
3 files changed, 9 insertions(+), 6 deletions(-)



diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 90b04d4..00f1a94 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -350,9 +350,10 @@
 STD_RES_FILE( gid_File_Res_Eps, eps )
 
 File gid_File_Help_Help_Zip
-Dir = gid_Dir_Help;
-ARCHIVE_TXT_FILE_BODY;
-Name = helpxsl.zip;
+Dir = FILELIST_DIR;
+TXT_FILE_BODY;
+Styles = (FILELIST);
+Name = xmlhelp_helpxsl.filelist;
 End
 
 #if defined WITH_HELP
diff --git a/xmlhelp/Module_xmlhelp.mk b/xmlhelp/Module_xmlhelp.mk
index 24390ea..5e5105d2 100644
--- a/xmlhelp/Module_xmlhelp.mk
+++ b/xmlhelp/Module_xmlhelp.mk
@@ -13,7 +13,7 @@
Library_tvhlp1 \
Library_ucpchelp1 \
Package_xsl \
-   Zip_helpxsl \
+   Package_helpxsl \
 ))
 
 # vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/xmlhelp/Zip_helpxsl.mk b/xmlhelp/Package_helpxsl.mk
similarity index 68%
rename from xmlhelp/Zip_helpxsl.mk
rename to xmlhelp/Package_helpxsl.mk
index 8e10a80..ca86276 100644
--- a/xmlhelp/Zip_helpxsl.mk
+++ b/xmlhelp/Package_helpxsl.mk
@@ -7,9 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,helpxsl,$(SRCDIR)/xmlhelp/util))
+$(eval $(call gb_Package_Package,xmlhelp_helpxsl,$(SRCDIR)/xmlhelp/util))
 
-$(eval $(call gb_Zip_add_files,helpxsl,\
+$(eval $(call gb_Package_set_outdir,xmlhelp_helpxsl,$(INSTDIR)))
+
+$(eval $(call gb_Package_add_files,xmlhelp_helpxsl,help,\
idxcaption.xsl \
idxcontent.xsl \
main_transform.xsl \

-- 
To view, visit https://gerrit.libreoffice.org/3649
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[RESTORED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Arnaud Versini (via Code Review)
Arnaud Versini has restored this change.

Change subject: Keep OUString instance by using local variable to avoid crash.
..


Patch Set 1: Restored

Tomorary fix untail Miklos finish its patch.

-- 
To view, visit https://gerrit.libreoffice.org/3647
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] libmspub.git: src/lib

2013-04-28 Thread Franz Schmid
 src/lib/MSPUBBlockID.h |1 +
 src/lib/MSPUBCollector.cpp |6 ++
 src/lib/MSPUBParser.cpp|3 +++
 src/lib/MSPUBTypes.h   |3 ++-
 4 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 8b3c9c61a8d1d83e4be8f2bfcd45d6f4c4487550
Author: Franz Schmid fr...@linux-hp-i7.site
Date:   Thu Apr 25 23:09:47 2013 +0200

Added Drop Caps to the Paragraph Styles.

diff --git a/src/lib/MSPUBBlockID.h b/src/lib/MSPUBBlockID.h
index 5a42d72..a44c5a8 100644
--- a/src/lib/MSPUBBlockID.h
+++ b/src/lib/MSPUBBlockID.h
@@ -68,6 +68,7 @@ enum MSPUBBlockID // Don't be alarmed by multiple elements 
with the same value;
   PARAGRAPH_FIRST_LINE_INDENT = 0xC,
   PARAGRAPH_LEFT_INDENT = 0xD,
   PARAGRAPH_RIGHT_INDENT = 0xE,
+  PARAGRAPH_DROP_CAP_LINES = 0x8,
   THIS_MASTER_NAME = 0xE,
   APPLIED_MASTER_NAME = 0xD,
   BA_ARRAY = 0x02,
diff --git a/src/lib/MSPUBCollector.cpp b/src/lib/MSPUBCollector.cpp
index a8d55ca..f16ae79 100644
--- a/src/lib/MSPUBCollector.cpp
+++ b/src/lib/MSPUBCollector.cpp
@@ -1193,6 +1193,12 @@ WPXPropertyList 
libmspub::MSPUBCollector::getParaStyleProps(const ParagraphStyle
   {
 ret.insert(fo:margin-right, (double)rightIndentEmu / EMUS_IN_INCH);
   }
+  unsigned dropCapLines = style.m_dropCapLines.get_value_or(
+defaultStyle.m_dropCapLines.get_value_or(0));
+  if (dropCapLines != 0)
+  {
+ret.insert(style:drop-cap, (int)dropCapLines);
+  }
   return ret;
 }
 
diff --git a/src/lib/MSPUBParser.cpp b/src/lib/MSPUBParser.cpp
index 9851ec6..418ea1b 100644
--- a/src/lib/MSPUBParser.cpp
+++ b/src/lib/MSPUBParser.cpp
@@ -1260,6 +1260,9 @@ libmspub::ParagraphStyle 
libmspub::MSPUBParser::getParagraphStyle(WPXInputStream
 case PARAGRAPH_LIST_NUMBER_RESTART:
   numberIfRestarted = info.data;
   break;
+case PARAGRAPH_DROP_CAP_LINES:
+  ret.m_dropCapLines = info.data;
+  break;
 default:
   break;
 }
diff --git a/src/lib/MSPUBTypes.h b/src/lib/MSPUBTypes.h
index 7884725..946f9c4 100644
--- a/src/lib/MSPUBTypes.h
+++ b/src/lib/MSPUBTypes.h
@@ -158,10 +158,11 @@ struct ParagraphStyle
   boost::optionalunsigned m_rightIndentEmu;
   boost::optionalListInfo m_listInfo;
   std::vectorunsigned m_tabStopsInEmu;
+  boost::optionalunsigned m_dropCapLines;
   ParagraphStyle() :
 m_align(), m_defaultCharStyleIndex(), m_lineSpacing(), m_spaceBeforeEmu(),
 m_spaceAfterEmu(), m_firstLineIndentEmu(), m_leftIndentEmu(),
-m_rightIndentEmu(), m_listInfo(), m_tabStopsInEmu()
+m_rightIndentEmu(), m_listInfo(), m_tabStopsInEmu(), m_dropCapLines()
   {
   }
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Arnaud Versini
 sw/source/core/text/itrcrsr.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d0d295af530e7dc1379a878ba5854e28eae250ad
Author: Arnaud Versini arnaud.vers...@gmail.com
Date:   Sun Apr 28 14:38:22 2013 +0200

Keep OUString instance by using local variable to avoid crash.

Crash with GCC 4.8 without the modification.
Temporary fix, should be replaced by OUString copy.

Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Reviewed-on: https://gerrit.libreoffice.org/3647
Reviewed-by: Miklos Vajna vmik...@suse.cz
Tested-by: Miklos Vajna vmik...@suse.cz

diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index b68b5ce..d567e76 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -1593,7 +1593,8 @@ xub_StrLen SwTxtCursor::GetCrsrOfst( SwPosition *pPos, 
const Point rPoint,
 else
 nOldProp = 0;
 {
-SwTxtSizeInfo aSizeInf( GetInfo(), rText, nCurrStart );
+OUString rTextStr = rText;
+SwTxtSizeInfo aSizeInf( GetInfo(), rTextStr, nCurrStart );
 ((SwTxtCursor*)this)-SeekAndChg( aSizeInf );
 SwTxtSlot aDiffTxt( aSizeInf, ((SwTxtPortion*)pPor), false, 
false );
 SwFontSave aSave( aSizeInf, pPor-IsDropPortion() ?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] Keep OUString instance by using local variable to avoid cras...

2013-04-28 Thread Miklos Vajna (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3647

Approvals:
  Miklos Vajna: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3647
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Arnaud Versini arnaud.vers...@gmail.com
Gerrit-Reviewer: Bosdonnat Cedric cedric.bosdon...@free.fr
Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz
Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sw/source

2013-04-28 Thread Miklos Vajna
 sw/source/core/text/itrcrsr.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1fd3167695aaebb050df53acd91f2e1625e8305a
Author: Miklos Vajna vmik...@suse.cz
Date:   Sun Apr 28 16:12:19 2013 +0200

fdo#63680 SwTxtCursor::GetCrsrOfst: don't pass reference to a temporary

This was a situation similar to
d0d295af530e7dc1379a878ba5854e28eae250ad. Unfortunately just changing
SwTxtSizeInfo's pTxt to an OUString copy doesn't work, as we still have
code that relies on that being a pointer only.

Change-Id: I202d7e6f5bd3005fc50551aa7195b419994ca3e8

diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index d567e76..bb1d08b 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -489,8 +489,8 @@ sal_Bool SwTxtCursor::GetEndCharRect( SwRect* pOrig, const 
xub_StrLen nOfst,
 void SwTxtCursor::_GetCharRect( SwRect* pOrig, const xub_StrLen nOfst,
 SwCrsrMoveState* pCMS )
 {
-const XubString rText = GetInfo().GetTxt();
-SwTxtSizeInfo aInf( GetInfo(), rText, nStart );
+const OUString aText = GetInfo().GetTxt();
+SwTxtSizeInfo aInf( GetInfo(), aText, nStart );
 if( GetPropFont() )
 aInf.GetFont()-SetProportion( GetPropFont() );
 KSHORT nTmpAscent, nTmpHeight;  // Zeilenhoehe
@@ -1593,8 +1593,8 @@ xub_StrLen SwTxtCursor::GetCrsrOfst( SwPosition *pPos, 
const Point rPoint,
 else
 nOldProp = 0;
 {
-OUString rTextStr = rText;
-SwTxtSizeInfo aSizeInf( GetInfo(), rTextStr, nCurrStart );
+OUString aText = rText;
+SwTxtSizeInfo aSizeInf( GetInfo(), aText, nCurrStart );
 ((SwTxtCursor*)this)-SeekAndChg( aSizeInf );
 SwTxtSlot aDiffTxt( aSizeInf, ((SwTxtPortion*)pPor), false, 
false );
 SwFontSave aSave( aSizeInf, pPor-IsDropPortion() ?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sfx2/source

2013-04-28 Thread David Tardon
 sfx2/source/doc/objmisc.cxx |   12 ++--
 1 file changed, 2 insertions(+), 10 deletions(-)

New commits:
commit f7cea8fb5b5d92ff6b8ac09b38d02badaaf7db04
Author: David Tardon dtar...@redhat.com
Date:   Sun Apr 28 11:18:35 2013 +0200

use SAL_CONFIGFILE macro

Change-Id: I958a961993aaf920c52b5d7b8eea656b4ddd

diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx
index 7ce3d1d..1bde2ae 100644
--- a/sfx2/source/doc/objmisc.cxx
+++ b/sfx2/source/doc/objmisc.cxx
@@ -2076,19 +2076,11 @@ void SfxObjectShell::StoreLog()
 
 if ( pImp-m_xLogRing.is() )
 {
-#ifdef WNT
-OUString aFileURL = OUString( 
${$BRAND_BASE_DIR/program/bootstrap.ini:UserInstallation}  );
-#else
-OUString aFileURL = OUString( 
${$BRAND_BASE_DIR/program/bootstraprc:UserInstallation}  );
-#endif
+OUString aFileURL = OUString( ${$BRAND_BASE_DIR/program/ 
SAL_CONFIGFILE(bootstrap) :UserInstallation}  );
 
 ::rtl::Bootstrap::expandMacros( aFileURL );
 
-#ifdef WNT
-OUString aBuildID = OUString( 
${$BRAND_BASE_DIR/program/setup.ini:buildid}  );
-#else
-OUString aBuildID = OUString( 
${$BRAND_BASE_DIR/program/setuprc:buildid}  );
-#endif
+OUString aBuildID = OUString( ${$BRAND_BASE_DIR/program/ 
SAL_CONFIGFILE(setup) :buildid}  );
 
 ::rtl::Bootstrap::expandMacros( aBuildID );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] Bin CLOOK comments and un-split one large switch statement

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3640

Approvals:
  LibreOffice gerrit bot: Verified
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3640
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id93d973a5fb3c81b6c754eef0ba3b0bd55a649d2
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Tor Lillqvist t...@iki.fi
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 60270] LibreOffice 4.1 most annoying bugs

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270

Bug 60270 depends on bug 63680, which changed state.

Bug 63680 Summary: EDITING: CRASH when click on contents or entering a line of 
text
https://bugs.freedesktop.org/show_bug.cgi?id=63680

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: scp2/source xmlhelp/Module_xmlhelp.mk xmlhelp/Package_helpxsl.mk xmlhelp/Zip_helpxsl.mk

2013-04-28 Thread Julien Nabet
 scp2/source/ooo/file_ooo.scp |7 ---
 xmlhelp/Module_xmlhelp.mk|2 +-
 xmlhelp/Package_helpxsl.mk   |   20 
 xmlhelp/Zip_helpxsl.mk   |   18 --
 4 files changed, 25 insertions(+), 22 deletions(-)

New commits:
commit 2c04d86f692d4b0841adba508a21e63e1bcdc45f
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Apr 28 15:47:42 2013 +0200

fdo#63197: convert helpxsl

Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089
Reviewed-on: https://gerrit.libreoffice.org/3649
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 90b04d4..00f1a94 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -350,9 +350,10 @@ End
 STD_RES_FILE( gid_File_Res_Eps, eps )
 
 File gid_File_Help_Help_Zip
-Dir = gid_Dir_Help;
-ARCHIVE_TXT_FILE_BODY;
-Name = helpxsl.zip;
+Dir = FILELIST_DIR;
+TXT_FILE_BODY;
+Styles = (FILELIST);
+Name = xmlhelp_helpxsl.filelist;
 End
 
 #if defined WITH_HELP
diff --git a/xmlhelp/Module_xmlhelp.mk b/xmlhelp/Module_xmlhelp.mk
index 24390ea..5e5105d2 100644
--- a/xmlhelp/Module_xmlhelp.mk
+++ b/xmlhelp/Module_xmlhelp.mk
@@ -13,7 +13,7 @@ $(eval $(call gb_Module_add_targets,xmlhelp,\
Library_tvhlp1 \
Library_ucpchelp1 \
Package_xsl \
-   Zip_helpxsl \
+   Package_helpxsl \
 ))
 
 # vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/xmlhelp/Zip_helpxsl.mk b/xmlhelp/Package_helpxsl.mk
similarity index 68%
rename from xmlhelp/Zip_helpxsl.mk
rename to xmlhelp/Package_helpxsl.mk
index 8e10a80..ca86276 100644
--- a/xmlhelp/Zip_helpxsl.mk
+++ b/xmlhelp/Package_helpxsl.mk
@@ -7,9 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,helpxsl,$(SRCDIR)/xmlhelp/util))
+$(eval $(call gb_Package_Package,xmlhelp_helpxsl,$(SRCDIR)/xmlhelp/util))
 
-$(eval $(call gb_Zip_add_files,helpxsl,\
+$(eval $(call gb_Package_set_outdir,xmlhelp_helpxsl,$(INSTDIR)))
+
+$(eval $(call gb_Package_add_files,xmlhelp_helpxsl,help,\
idxcaption.xsl \
idxcontent.xsl \
main_transform.xsl \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: afms/ExternalPackage_fontunxafm.mk afms/Module_afms.mk afms/Zip_fontunxafm.mk scp2/source

2013-04-28 Thread Julien Nabet
 afms/ExternalPackage_fontunxafm.mk |   48 +++
 afms/Module_afms.mk|2 -
 afms/Zip_fontunxafm.mk |   50 -
 scp2/source/ooo/file_extra_ooo.scp |6 ++--
 4 files changed, 52 insertions(+), 54 deletions(-)

New commits:
commit 9ed5affa51257e1bfece7fd8712acad77ad64cad
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Apr 28 15:20:46 2013 +0200

fdo#63197: convert fontunxafm

Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804
Reviewed-on: https://gerrit.libreoffice.org/3648
Tested-by: David Tardon dtar...@redhat.com
Reviewed-by: David Tardon dtar...@redhat.com

diff --git a/afms/Zip_fontunxafm.mk b/afms/ExternalPackage_fontunxafm.mk
similarity index 82%
rename from afms/Zip_fontunxafm.mk
rename to afms/ExternalPackage_fontunxafm.mk
index 058ee7e..d2600a1 100644
--- a/afms/Zip_fontunxafm.mk
+++ b/afms/ExternalPackage_fontunxafm.mk
@@ -7,13 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,fontunxafm,$(call gb_UnpackedTarball_get_dir,afms)))
+$(eval $(call gb_ExternalPackage_ExternalPackage,afms_fontunxafm,afms))
 
-$(eval $(call gb_Zip_add_dependencies,fontunxafm,\
-   $(call gb_UnpackedTarball_get_target,afms) \
-))
+$(eval $(call gb_ExternalPackage_set_outdir,afms_fontunxafm,$(INSTDIR)))
 
-$(eval $(call gb_Zip_add_files,fontunxafm,\
+$(eval $(call 
gb_ExternalPackage_add_unpacked_files,afms_fontunxafm,share/psprint/fontmetric,\
Courier-Bold.afm \
Courier-BoldOblique.afm \
Courier-Oblique.afm \
diff --git a/afms/Module_afms.mk b/afms/Module_afms.mk
index ee04aa9..5e0c750 100644
--- a/afms/Module_afms.mk
+++ b/afms/Module_afms.mk
@@ -11,7 +11,7 @@ $(eval $(call gb_Module_Module,afms))
 
 $(eval $(call gb_Module_add_targets,afms,\
UnpackedTarball_afms \
-   Zip_fontunxafm \
+   ExternalPackage_fontunxafm \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/scp2/source/ooo/file_extra_ooo.scp 
b/scp2/source/ooo/file_extra_ooo.scp
index 93ebc12..0a804d3 100644
--- a/scp2/source/ooo/file_extra_ooo.scp
+++ b/scp2/source/ooo/file_extra_ooo.scp
@@ -208,10 +208,10 @@ End
 
 #ifndef WITHOUT_AFMS
 File gid_File_Extra_Fontunxafm
-Dir = gid_Dir_Psprint_Fontmetric;
+Dir = FILELIST_DIR;
 TXT_FILE_BODY;
-Styles = (ARCHIVE);
-Name = fontunxafm.zip;
+Styles = (FILELIST);
+Name = afms_fontunxafm.filelist;
 End
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] fdo#63197: convert helpxsl

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3649

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3649
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd436733b47d7883209fe73dc1d0099dc87db089
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fdo#63197: convert fontunxafm

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3648

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3648
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib382319a4916b711c820c06ba57928ca11d0b804
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 12 commits - instsetoo_native/config instsetoo_native/CustomTarget_setup.mk instsetoo_native/Module_instsetoo_native.mk instsetoo_native/Package_config.mk instsetoo_nat

2013-04-28 Thread David Tardon
 instsetoo_native/CustomTarget_setup.mk  |   51 
 instsetoo_native/Module_instsetoo_native.mk |9 
 instsetoo_native/Package_config.mk  |   22 
 instsetoo_native/Package_rdb.mk |   19 ++
 instsetoo_native/Package_setup.mk   |   21 +++
 instsetoo_native/config/bootstraprc |   14 +++
 instsetoo_native/config/fundamentalrc   |   27 ++
 instsetoo_native/config/unorc   |   20 ++
 instsetoo_native/config/unorc.ure   |   13 +++
 postprocess/Module_postprocess.mk   |7 +++
 postprocess/Package_images_install.mk   |   20 ++
 postprocess/Package_registry_install.mk |   23 
 solenv/Module_solenv.mk |1 
 solenv/Package_gdb_install.mk   |   27 ++
 solenv/gbuild/AllLangResTarget.mk   |   14 +++
 solenv/gbuild/Executable.mk |   29 +++
 solenv/gbuild/Library.mk|   39 -
 solenv/gbuild/gbuild.mk |2 +
 18 files changed, 357 insertions(+), 1 deletion(-)

New commits:
commit 88a943b051bb78be4a3c105474ca20b57f758542
Author: David Tardon dtar...@redhat.com
Date:   Sun Apr 28 11:35:35 2013 +0200

generate versionrc for instdir

Change-Id: I5f2cdcd8a17ca250413bda066acaeab24118f9d6

diff --git a/instsetoo_native/CustomTarget_setup.mk 
b/instsetoo_native/CustomTarget_setup.mk
index 2374fb1..366f1a9 100644
--- a/instsetoo_native/CustomTarget_setup.mk
+++ b/instsetoo_native/CustomTarget_setup.mk
@@ -12,6 +12,7 @@ $(eval $(call 
gb_CustomTarget_CustomTarget,instsetoo_native/setup))
 $(eval $(call gb_CustomTarget_register_targets,instsetoo_native/setup,\
ooenv \
ure-link \
+   versionrc \
 ))
 
 $(call gb_CustomTarget_get_workdir,instsetoo_native/setup)/ooenv :
@@ -37,4 +38,14 @@ $(call 
gb_CustomTarget_get_workdir,instsetoo_native/setup)/ure-link :
cd $(dir $@)  \
ln -s ure ure-link
 
+$(call gb_CustomTarget_get_workdir,instsetoo_native/setup)/versionrc :
+   $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ECH,1)
+   ( \
+   echo '[Version]'  \
+   echo 'AllLanguages=en-US'  \
+   echo 'buildid=$(shell git log -1 --format=%H)'  \
+   echo 
'ProductMajor=$(LIBO_VERSION_MAJOR)$(LIBO_VERSION_MINOR)$(LIBO_VERSION_MICRO)' 
 \
+   echo 'ProductMinor=$(LIBO_VERSION_PATCH)' \
+   )  $@
+
 # vim: set noet sw=4 ts=4:
diff --git a/instsetoo_native/Package_setup.mk 
b/instsetoo_native/Package_setup.mk
index cd32a9e..9f8ca30 100644
--- a/instsetoo_native/Package_setup.mk
+++ b/instsetoo_native/Package_setup.mk
@@ -11,7 +11,11 @@ $(eval $(call 
gb_Package_Package,instsetoo_native_setup,$(call gb_CustomTarget_g
 
 $(eval $(call gb_Package_set_outdir,instsetoo_native_setup,$(INSTDIR)))
 
-$(eval $(call gb_Package_add_file,instsetoo_native_setup,program/ooenv,ooenv))
+$(eval $(call gb_Package_add_files,instsetoo_native_setup,program,\
+   ooenv \
+   versionrc \
+))
+
 $(eval $(call gb_Package_add_file,instsetoo_native_setup,ure-link,ure-link))
 
 # vim: set noet sw=4 ts=4:
commit e203f79faac1d26e0d6883be9f0ff88eaaf484ed
Author: David Tardon dtar...@redhat.com
Date:   Sun Apr 28 10:21:10 2013 +0200

copy xcd files to instdir

Change-Id: Idbde83eab55864c16e3472397cb5bd433cf2431c

diff --git a/postprocess/Module_postprocess.mk 
b/postprocess/Module_postprocess.mk
index 1a52832..6a38191 100644
--- a/postprocess/Module_postprocess.mk
+++ b/postprocess/Module_postprocess.mk
@@ -29,6 +29,7 @@ endif
 ifneq ($(gb_RUNNABLE_INSTDIR),)
 $(eval $(call gb_Module_add_targets,postprocess,\
Package_images_install \
+   Package_registry_install \
 ))
 endif
 
diff --git a/postprocess/Package_registry_install.mk 
b/postprocess/Package_registry_install.mk
new file mode 100644
index 000..ca9f7c2
--- /dev/null
+++ b/postprocess/Package_registry_install.mk
@@ -0,0 +1,23 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_Package_Package,postprocess_registry_install,$(call 
gb_CustomTarget_get_workdir,postprocess/registry)))
+
+$(eval $(call gb_Package_set_outdir,postprocess_registry_install,$(INSTDIR)))
+
+$(eval $(call 
gb_Package_add_files,postprocess_registry_install,share/registry,\
+   $(postprocess_XCDS) \
+   $(foreach lang,$(gb_Configuration_LANGS), \
+   Langpack-$(lang).xcd \
+   fcfg_langpack_$(lang).xcd \
+   registry_$(lang).xcd \
+   ) \
+))
+
+# vim: set noet sw=4 ts=4:
commit 

[PATCH] fdo#63197: convert liblangtag_data

2013-04-28 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3650

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3650/1

fdo#63197: convert liblangtag_data

Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9
---
A liblangtag/ExternalPackage_liblangtag_data.mk
M liblangtag/Module_liblangtag.mk
D liblangtag/Zip_liblangtag_data.mk
M scp2/source/ooo/file_extra_ooo.scp
4 files changed, 34 insertions(+), 34 deletions(-)



diff --git a/liblangtag/ExternalPackage_liblangtag_data.mk 
b/liblangtag/ExternalPackage_liblangtag_data.mk
new file mode 100644
index 000..a56211f
--- /dev/null
+++ b/liblangtag/ExternalPackage_liblangtag_data.mk
@@ -0,0 +1,30 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,liblangtag_data,langtag))
+
+$(eval $(call gb_ExternalPackage_set_outdir,liblangtag_data,$(INSTDIR)))
+
+$(eval $(call 
gb_ExternalPackage_add_unpacked_files,liblangtag_data,share/liblangtag,\
+   data/language-subtag-registry.xml \
+   data/common/bcp47/calendar.xml \
+   data/common/bcp47/collation.xml \
+   data/common/bcp47/currency.xml \
+   data/common/bcp47/number.xml \
+   data/common/bcp47/timezone.xml \
+   data/common/bcp47/transform.xml \
+   data/common/bcp47/transform_ime.xml \
+   data/common/bcp47/transform_keyboard.xml \
+   data/common/bcp47/transform_mt.xml \
+   data/common/bcp47/transform_private_use.xml \
+   data/common/bcp47/variant.xml \
+   data/common/supplemental/likelySubtags.xml \
+))
+
+# vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/liblangtag/Module_liblangtag.mk b/liblangtag/Module_liblangtag.mk
index b5e9cc3..36201f8 100644
--- a/liblangtag/Module_liblangtag.mk
+++ b/liblangtag/Module_liblangtag.mk
@@ -17,7 +17,7 @@
ExternalPackage_langtag_data \
ExternalPackage_langtag \
ExternalProject_langtag \
-   Zip_liblangtag_data \
+   ExternalPackage_liblangtag_data \
 ))
 endif
 endif
diff --git a/liblangtag/Zip_liblangtag_data.mk 
b/liblangtag/Zip_liblangtag_data.mk
deleted file mode 100644
index 54b3080..000
--- a/liblangtag/Zip_liblangtag_data.mk
+++ /dev/null
@@ -1,30 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call gb_Zip_Zip,liblangtag_data,$(call 
gb_UnpackedTarball_get_dir,langtag/data)))
-
-$(eval $(call gb_Zip_use_unpacked,liblangtag_data,langtag))
-
-$(eval $(call gb_Zip_add_files,liblangtag_data,\
-   language-subtag-registry.xml \
-   common/bcp47/calendar.xml \
-   common/bcp47/collation.xml \
-   common/bcp47/currency.xml \
-   common/bcp47/number.xml \
-   common/bcp47/timezone.xml \
-   common/bcp47/transform.xml \
-   common/bcp47/transform_ime.xml \
-   common/bcp47/transform_keyboard.xml \
-   common/bcp47/transform_mt.xml \
-   common/bcp47/transform_private_use.xml \
-   common/bcp47/variant.xml \
-   common/supplemental/likelySubtags.xml \
-))
-
-# vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/scp2/source/ooo/file_extra_ooo.scp 
b/scp2/source/ooo/file_extra_ooo.scp
index 93ebc12..92855f7 100644
--- a/scp2/source/ooo/file_extra_ooo.scp
+++ b/scp2/source/ooo/file_extra_ooo.scp
@@ -147,10 +147,10 @@
 
 #if defined( ENABLE_LIBLANGTAG )  !defined( SYSTEM_LIBLANGTAG )
 File gid_File_Extra_Liblangtag
-Dir = gid_Dir_Share_Liblangtag;
+Dir = FILELIST_DIR;
 USER_FILE_BODY;
-Styles = (ARCHIVE);
-Name = liblangtag_data.zip;
+Styles = (FILELIST);
+Name = liblangtag_data.filelist;
 End
 #endif
 

-- 
To view, visit https://gerrit.libreoffice.org/3650
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: liblangtag/ExternalPackage_liblangtag_data.mk liblangtag/Module_liblangtag.mk liblangtag/Zip_liblangtag_data.mk scp2/source

2013-04-28 Thread Julien Nabet
 liblangtag/ExternalPackage_liblangtag_data.mk |   30 ++
 liblangtag/Module_liblangtag.mk   |2 -
 liblangtag/Zip_liblangtag_data.mk |   30 --
 scp2/source/ooo/file_extra_ooo.scp|6 ++---
 4 files changed, 34 insertions(+), 34 deletions(-)

New commits:
commit 9c4f99287c1ffc7119f6bf171926db6233e9de9c
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Apr 28 16:43:49 2013 +0200

fdo#63197: convert liblangtag_data

Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9
Reviewed-on: https://gerrit.libreoffice.org/3650
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/liblangtag/ExternalPackage_liblangtag_data.mk 
b/liblangtag/ExternalPackage_liblangtag_data.mk
new file mode 100644
index 000..a56211f
--- /dev/null
+++ b/liblangtag/ExternalPackage_liblangtag_data.mk
@@ -0,0 +1,30 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,liblangtag_data,langtag))
+
+$(eval $(call gb_ExternalPackage_set_outdir,liblangtag_data,$(INSTDIR)))
+
+$(eval $(call 
gb_ExternalPackage_add_unpacked_files,liblangtag_data,share/liblangtag,\
+   data/language-subtag-registry.xml \
+   data/common/bcp47/calendar.xml \
+   data/common/bcp47/collation.xml \
+   data/common/bcp47/currency.xml \
+   data/common/bcp47/number.xml \
+   data/common/bcp47/timezone.xml \
+   data/common/bcp47/transform.xml \
+   data/common/bcp47/transform_ime.xml \
+   data/common/bcp47/transform_keyboard.xml \
+   data/common/bcp47/transform_mt.xml \
+   data/common/bcp47/transform_private_use.xml \
+   data/common/bcp47/variant.xml \
+   data/common/supplemental/likelySubtags.xml \
+))
+
+# vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/liblangtag/Module_liblangtag.mk b/liblangtag/Module_liblangtag.mk
index b5e9cc3..36201f8 100644
--- a/liblangtag/Module_liblangtag.mk
+++ b/liblangtag/Module_liblangtag.mk
@@ -17,7 +17,7 @@ $(eval $(call gb_Module_add_targets,liblangtag,\
ExternalPackage_langtag_data \
ExternalPackage_langtag \
ExternalProject_langtag \
-   Zip_liblangtag_data \
+   ExternalPackage_liblangtag_data \
 ))
 endif
 endif
diff --git a/liblangtag/Zip_liblangtag_data.mk 
b/liblangtag/Zip_liblangtag_data.mk
deleted file mode 100644
index 54b3080..000
--- a/liblangtag/Zip_liblangtag_data.mk
+++ /dev/null
@@ -1,30 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call gb_Zip_Zip,liblangtag_data,$(call 
gb_UnpackedTarball_get_dir,langtag/data)))
-
-$(eval $(call gb_Zip_use_unpacked,liblangtag_data,langtag))
-
-$(eval $(call gb_Zip_add_files,liblangtag_data,\
-   language-subtag-registry.xml \
-   common/bcp47/calendar.xml \
-   common/bcp47/collation.xml \
-   common/bcp47/currency.xml \
-   common/bcp47/number.xml \
-   common/bcp47/timezone.xml \
-   common/bcp47/transform.xml \
-   common/bcp47/transform_ime.xml \
-   common/bcp47/transform_keyboard.xml \
-   common/bcp47/transform_mt.xml \
-   common/bcp47/transform_private_use.xml \
-   common/bcp47/variant.xml \
-   common/supplemental/likelySubtags.xml \
-))
-
-# vim: set shiftwidth=4 tabstop=4 noexpandtab:
diff --git a/scp2/source/ooo/file_extra_ooo.scp 
b/scp2/source/ooo/file_extra_ooo.scp
index 0a804d3..96cffcc 100644
--- a/scp2/source/ooo/file_extra_ooo.scp
+++ b/scp2/source/ooo/file_extra_ooo.scp
@@ -147,10 +147,10 @@ End
 
 #if defined( ENABLE_LIBLANGTAG )  !defined( SYSTEM_LIBLANGTAG )
 File gid_File_Extra_Liblangtag
-Dir = gid_Dir_Share_Liblangtag;
+Dir = FILELIST_DIR;
 USER_FILE_BODY;
-Styles = (ARCHIVE);
-Name = liblangtag_data.zip;
+Styles = (FILELIST);
+Name = liblangtag_data.filelist;
 End
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] fdo#63197: convert liblangtag_data

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3650

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3650
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0727b800c715962a88e256b30046c9e13d6bd2a9
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


LO Impress: text field (and other main fields of different layout) needs reset function for size and position

2013-04-28 Thread Karl-Philipp Richter

Hi together,
it is not clear how to reset size and position of the text field (or any 
other layout (table, video, etc.) main field) in LO Impress. If it is 
possible (and I didn't find it quick enough (as you might expect from an 
intuitive program)) there ought to be a reset or default button in 
the size and position dialog.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Fixing Indentation RTL bug

2013-04-28 Thread Adam Co (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3651

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/3651/1

Fixing Indentation RTL bug

Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c
---
M writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
1 file changed, 13 insertions(+), 1 deletion(-)



diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx 
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index 81ac271..0a0b63e 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -1609,7 +1609,19 @@
 
 if (mpValue.get() == NULL)
 {
-OOXMLValue::Pointer_t pValue(new OOXMLIntegerValue(0));
+// Value should not always be 'true'
+//OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(true));
+bool bSet = true;
+
+// Paragraph properties are not always 'true' by default
+// For example - RTL layout of paragraph is by default 'false' (look 
in this link for 'sprmPFBiDi')
+// 
http://msdn.microsoft.com/en-us/library/dd923496%28v=office.12%29.aspx
+if (getId() == 0x2441)
+{
+bSet = false;
+}
+
+OOXMLValue::Pointer_t pValue(new OOXMLBooleanValue(bSet));
 setValue(pValue);
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3651
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8c3d30cb28afb97d4ded4ac67241ed18ab9e50c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Adam Co rattles2...@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#63197: convert osxres

2013-04-28 Thread Julien Nabet (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3652

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/3652/1

fdo#63197: convert osxres

Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885
---
M scp2/source/ooo/file_ooo.scp
M vcl/Module_vcl.mk
R vcl/Package_osxres.mk
3 files changed, 9 insertions(+), 7 deletions(-)



diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 00f1a94..aa47787 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -1232,10 +1232,10 @@
 
 #ifdef MACOSX
 File gid_File_Res_Bundle
-ARCHIVE_TXT_FILE_BODY;
-Dir = gid_Dir_Bundle_Contents_Resources;
-Name = osxres.zip;
-Styles = (ARCHIVE);
+Dir = FILELIST_DIR;
+TXT_FILE_BODY;
+Styles = (FILELIST);
+Name = vcl_osxres.filelist;
 End
 #endif
 
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 976b7698..fd2be4c5 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -71,7 +71,7 @@
 
 ifeq ($(OS),MACOSX)
 $(eval $(call gb_Module_add_targets,vcl,\
-Zip_osxres \
+Package_osxres \
 ))
 endif
 
diff --git a/vcl/Zip_osxres.mk b/vcl/Package_osxres.mk
similarity index 91%
rename from vcl/Zip_osxres.mk
rename to vcl/Package_osxres.mk
index 10c0d12..e6ee3e5 100644
--- a/vcl/Zip_osxres.mk
+++ b/vcl/Package_osxres.mk
@@ -7,9 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,osxres,$(SRCDIR)/vcl/aqua/source/res))
+$(eval $(call gb_Package_Package,vcl_osxres,$(SRCDIR)/vcl/aqua/source/res))
 
-$(eval $(call gb_Zip_add_files,osxres,\
+$(eval $(call gb_Package_set_outdir,vcl_osxres,$(INSTDIR)))
+
+$(eval $(call gb_Package_add_files,vcl_osxres,Contents,\
 MainMenu.nib/classes.nib \
 MainMenu.nib/info.nib \
 MainMenu.nib/keyedobjects.nib \

-- 
To view, visit https://gerrit.libreoffice.org/3652
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: scp2/source vcl/Module_vcl.mk vcl/Package_osxres.mk vcl/Zip_osxres.mk

2013-04-28 Thread Julien Nabet
 scp2/source/ooo/file_ooo.scp |8 +--
 vcl/Module_vcl.mk|2 
 vcl/Package_osxres.mk|   90 +++
 vcl/Zip_osxres.mk|   88 --
 4 files changed, 95 insertions(+), 93 deletions(-)

New commits:
commit 14a96e28c9dac64cfa0d1cf1c6fc3fece8ed6b0c
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Apr 28 18:11:56 2013 +0200

fdo#63197: convert osxres

Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885
Reviewed-on: https://gerrit.libreoffice.org/3652
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 00f1a94..aa47787 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -1232,10 +1232,10 @@ End
 
 #ifdef MACOSX
 File gid_File_Res_Bundle
-ARCHIVE_TXT_FILE_BODY;
-Dir = gid_Dir_Bundle_Contents_Resources;
-Name = osxres.zip;
-Styles = (ARCHIVE);
+Dir = FILELIST_DIR;
+TXT_FILE_BODY;
+Styles = (FILELIST);
+Name = vcl_osxres.filelist;
 End
 #endif
 
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 976b7698..fd2be4c5 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -71,7 +71,7 @@ endif
 
 ifeq ($(OS),MACOSX)
 $(eval $(call gb_Module_add_targets,vcl,\
-Zip_osxres \
+Package_osxres \
 ))
 endif
 
diff --git a/vcl/Zip_osxres.mk b/vcl/Package_osxres.mk
similarity index 91%
rename from vcl/Zip_osxres.mk
rename to vcl/Package_osxres.mk
index 10c0d12..8f4849f 100644
--- a/vcl/Zip_osxres.mk
+++ b/vcl/Package_osxres.mk
@@ -7,9 +7,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Zip_Zip,osxres,$(SRCDIR)/vcl/aqua/source/res))
+$(eval $(call gb_Package_Package,vcl_osxres,$(SRCDIR)/vcl/aqua/source/res))
 
-$(eval $(call gb_Zip_add_files,osxres,\
+$(eval $(call gb_Package_set_outdir,vcl_osxres,$(INSTDIR)))
+
+$(eval $(call gb_Package_add_files_with_dir,vcl_osxres,Resources,\
 MainMenu.nib/classes.nib \
 MainMenu.nib/info.nib \
 MainMenu.nib/keyedobjects.nib \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[PUSHED] fdo#63197: convert osxres

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3652

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3652
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I969217263fdda3e61b38dc16f0a9251b745de885
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet serval2...@yahoo.fr
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Julien Nabet serval2...@yahoo.fr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] script to create git tree with submodule setup from bundles

2013-04-28 Thread Christian Lohmaier (via Code Review)
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3653

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/dev-tools refs/changes/53/3653/1

script to create git tree with submodule setup from bundles

the existing script doesn't do anything useful for current development
line, it is meant for the old buildsetup where there was a clone
directory and tons of symlinks.

Unfortunately using git bundles with submodules is not just unpacking
the tarballs, the git config needs to be tweaked for that. Hence this
script that downloads the bundles and does all the work.

./lo-submodules-from-bundles.sh -t my-checkout-name help dict

to setup the checkout with the helpcontent2 and dictionaries submodules.
For more details, see ./lo-submodules-from-bundles.sh -h

nice benefit over using git is that the script setups the repositories
using relative paths, so you can move/copy your checkout without git
complaining

Change-Id: Ia483039fcbafe8fc042877d6b610ee88a6097c0a
---
A lo-submodules-from-bundles.sh
1 file changed, 179 insertions(+), 0 deletions(-)



diff --git a/lo-submodules-from-bundles.sh b/lo-submodules-from-bundles.sh
new file mode 100755
index 000..758bc14
--- /dev/null
+++ b/lo-submodules-from-bundles.sh
@@ -0,0 +1,179 @@
+#!/usr/bin/env bash
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+# creates a working submodule based checkout using using bundles
+function usage {
+cat  EOF
+Usage:
+$0 -h|--help|-?
+$0 [-d downloaddir] [-t targetdir] [SUBMODULES]
+$0 -a [-d downloaddir] [-t targetdir] SUBMODULES
+
+-h,--help,-? show this help
+-d pathdownload directory, defaults to working directory
+ (»$download_dir«) - tries to use existing bundle files
+ in this directory before downloading them
+ (directory must exist)
+-t pathtarget directory, defaults to »$target_dir« (directory must
+not yet exist unless used with -a, then an existing directory
+ must be specified)
+-a   add submodules to an existing checkout without
+ submodules (be careful with that one)
+SUBMODULES   the submodules to include.
+noneonly download the core repository (default)
+all include dictionaries, helpcontent2 and translations
+h[elpcontent2]  helpcontent2 (can be combined)
+d[ictionaries]  dictionaries (can be combined)
+t[ranslations]  translations (can be combined)
+
+As relative paths are used when using this script, the resulting directory can 
be
+moved around at will without breaking git's references.
+
+Examples:
+»$0 h d«
+Setup the repository in »$target_dir« with the helpcontent2 and dictionaries
+submodules, downloads go to the current working directory
+
+»$0 -d /path/to/directory all«
+Setup the repository in »$target_dir« with all submodules (dictionaries,
+helpcontent2, translations), downloads are looked for/stored in
+/path/to/directory
+
+»$0 -t /desired/path«
+Setup the repository in »/desired/path« with no submodules.
+
+»$0 -a -t /existing/checkout translations«
+Add the translations submodule to the existing git checkout in 
/existing/checkout
+Only use this one if you didn't initialize the specified submodules with git 
already.
+EOF
+exit 0
+}
+
+bundleurl=http://dev-www.libreoffice.org/bundles;
+
+#defaults
+target_dir=libo-core
+download_dir=.
+core=true
+dictionaries=false
+help=false
+translations=false
+add_to_existing=false
+superrepo=libo
+
+function download {
+if ${!1}; then
+cd $download_dir
+wget -nc $bundleurl/libreoffice-$1.tar.bz2
+cd $workdir
+fi
+}
+function checkout {
+if ${!1}; then
+reponame=$1
+repodir=${2:-$1}
+echo extracting $1
+tar -xjf $download_dir/libreoffice-$reponame.tar.bz2
+echo checking out files
+cd $repodir
+git checkout -- .
+cd $workdir
+fi
+}
+function submodulesetup {
+if ${!1}; then
+reponame=$1
+directory=${2:-$1}
+echo setting up submodule for $directory
+cd $workdir
+rmdir $superrepo/$directory
+mv $reponame/.git $superrepo/.git/modules/$directory
+mv $reponame $superrepo/$directory
+echo gitdir: ../.git/modules/$directory  $superrepo/$directory/.git
+sed -e /logallrefupdates/a\\\tworktree = ../../../$directory -e 
's#anongit\.freedesktop\.org/libreoffice/#gerrit.libreoffice.org/#' -i 
$superrepo/.git/modules/$directory/config
+cat EOF  $superrepo/.git/config
+[submodule $directory]
+   url = git://gerrit.libreoffice.org/$reponame
+EOF
+cd $workdir
+fi
+}
+##
+# commandline options
+while [ 

[Libreoffice-commits] dev-tools.git: lo-submodules-from-bundles.sh

2013-04-28 Thread Christian Lohmaier
 lo-submodules-from-bundles.sh |  179 ++
 1 file changed, 179 insertions(+)

New commits:
commit 3328f5e88ade4b6f132c261b977793f863deae2e
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date:   Sun Apr 28 22:42:45 2013 +0200

script to create git tree with submodule setup from bundles

the existing script doesn't do anything useful for current development
line, it is meant for the old buildsetup where there was a clone
directory and tons of symlinks.

Unfortunately using git bundles with submodules is not just unpacking
the tarballs, the git config needs to be tweaked for that. Hence this
script that downloads the bundles and does all the work.

./lo-submodules-from-bundles.sh -t my-checkout-name help dict

to setup the checkout with the helpcontent2 and dictionaries submodules.
For more details, see ./lo-submodules-from-bundles.sh -h

nice benefit over using git is that the script setups the repositories
using relative paths, so you can move/copy your checkout without git
complaining

Change-Id: Ia483039fcbafe8fc042877d6b610ee88a6097c0a
Reviewed-on: https://gerrit.libreoffice.org/3653
Reviewed-by: Thorsten Behrens tbehr...@suse.com
Tested-by: Thorsten Behrens tbehr...@suse.com

diff --git a/lo-submodules-from-bundles.sh b/lo-submodules-from-bundles.sh
new file mode 100755
index 000..758bc14
--- /dev/null
+++ b/lo-submodules-from-bundles.sh
@@ -0,0 +1,179 @@
+#!/usr/bin/env bash
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+# creates a working submodule based checkout using using bundles
+function usage {
+cat  EOF
+Usage:
+$0 -h|--help|-?
+$0 [-d downloaddir] [-t targetdir] [SUBMODULES]
+$0 -a [-d downloaddir] [-t targetdir] SUBMODULES
+
+-h,--help,-? show this help
+-d pathdownload directory, defaults to working directory
+ (»$download_dir«) - tries to use existing bundle files
+ in this directory before downloading them
+ (directory must exist)
+-t pathtarget directory, defaults to »$target_dir« (directory must
+not yet exist unless used with -a, then an existing directory
+ must be specified)
+-a   add submodules to an existing checkout without
+ submodules (be careful with that one)
+SUBMODULES   the submodules to include.
+noneonly download the core repository (default)
+all include dictionaries, helpcontent2 and translations
+h[elpcontent2]  helpcontent2 (can be combined)
+d[ictionaries]  dictionaries (can be combined)
+t[ranslations]  translations (can be combined)
+
+As relative paths are used when using this script, the resulting directory can 
be
+moved around at will without breaking git's references.
+
+Examples:
+»$0 h d«
+Setup the repository in »$target_dir« with the helpcontent2 and dictionaries
+submodules, downloads go to the current working directory
+
+»$0 -d /path/to/directory all«
+Setup the repository in »$target_dir« with all submodules (dictionaries,
+helpcontent2, translations), downloads are looked for/stored in
+/path/to/directory
+
+»$0 -t /desired/path«
+Setup the repository in »/desired/path« with no submodules.
+
+»$0 -a -t /existing/checkout translations«
+Add the translations submodule to the existing git checkout in 
/existing/checkout
+Only use this one if you didn't initialize the specified submodules with git 
already.
+EOF
+exit 0
+}
+
+bundleurl=http://dev-www.libreoffice.org/bundles;
+
+#defaults
+target_dir=libo-core
+download_dir=.
+core=true
+dictionaries=false
+help=false
+translations=false
+add_to_existing=false
+superrepo=libo
+
+function download {
+if ${!1}; then
+cd $download_dir
+wget -nc $bundleurl/libreoffice-$1.tar.bz2
+cd $workdir
+fi
+}
+function checkout {
+if ${!1}; then
+reponame=$1
+repodir=${2:-$1}
+echo extracting $1
+tar -xjf $download_dir/libreoffice-$reponame.tar.bz2
+echo checking out files
+cd $repodir
+git checkout -- .
+cd $workdir
+fi
+}
+function submodulesetup {
+if ${!1}; then
+reponame=$1
+directory=${2:-$1}
+echo setting up submodule for $directory
+cd $workdir
+rmdir $superrepo/$directory
+mv $reponame/.git $superrepo/.git/modules/$directory
+mv $reponame $superrepo/$directory
+echo gitdir: ../.git/modules/$directory  $superrepo/$directory/.git
+sed -e /logallrefupdates/a\\\tworktree = ../../../$directory -e 

[PUSHED] script to create git tree with submodule setup from bundles

2013-04-28 Thread Thorsten Behrens (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3653

Approvals:
  Thorsten Behrens: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3653
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia483039fcbafe8fc042877d6b610ee88a6097c0a
Gerrit-PatchSet: 2
Gerrit-Project: dev-tools
Gerrit-Branch: master
Gerrit-Owner: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Gerrit-Reviewer: Thorsten Behrens tbehr...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 6 commits - chart2/source include/oox oox/source sc/source

2013-04-28 Thread Markus Mohrhard
 chart2/source/tools/ErrorBar.cxx   |1 
 include/oox/export/chartexport.hxx |3 
 oox/source/export/chartexport.cxx  |  177 ++---
 sc/source/filter/xml/xmlsubti.cxx  |9 -
 4 files changed, 174 insertions(+), 16 deletions(-)

New commits:
commit e81d0c400c02a87d7fa492dbc5ac9f7921167920
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Mon Apr 29 00:12:07 2013 +0200

change order to allow validation of chart part

My simple test file is finally valid but is still now shown in Excel.
There must be another bug in our exporter.

Change-Id: Ib55e5b32edc3a556e9081b3008df539275dc289b

diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index 9198924..c3cf09f 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2188,6 +2188,9 @@ void ChartExport::_exportAxis(
 XML_val, sTickLblPos,
 FSEND );
 
+// shape properties
+exportShapeProps( xAxisProp );
+
 pFS-singleElement( FSNS( XML_c, XML_crossAx ),
 XML_val, I32S( aAxisIdPair.nCrossAx ),
 FSEND );
@@ -2282,8 +2285,6 @@ void ChartExport::_exportAxis(
 FSEND );
 }
 
-// shape properties
-exportShapeProps( xAxisProp );
 // TODO: text properties
 
 pFS-endElement( FSNS( XML_c, nAxisType ) );
commit 3812e99e939e6f3d8a6246c7adaa01de4e5abb99
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Apr 28 23:59:24 2013 +0200

another validation error with OOXML chart export

c:characters does not have an attribute val. The value has to be written
out as normal string.

Change-Id: Icd2c4034918bd223d0c8082a7d137e1ce79a9cfe

diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index 128eceb..9198924 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2368,7 +2368,9 @@ void ChartExport::exportDataLabels(
if (GetProperty( xPropSet, LabelSeparator))
{
mAny = aSep;
-   pFS-singleElement( FSNS( XML_c, XML_separator), 
XML_val, USS(aSep), FSEND);
+   pFS-startElement( FSNS( XML_c, XML_separator), FSEND);
+   pFS-writeEscaped(aSep);
+   pFS-endElement( FSNS( XML_c, XML_separator) );
}
pFS-endElement( FSNS( XML_c, XML_dLbl ));
}
commit 672398d84dcebba71ba996b07c7d47bb4257efef
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Apr 28 23:58:29 2013 +0200

order of element matters in OOXML export

this fixes one validation error with documents containing charts

Change-Id: I879963484b1cc00322e8c79bf77dfbbf91869587

diff --git a/oox/source/export/chartexport.cxx 
b/oox/source/export/chartexport.cxx
index ea872b4..128eceb 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2352,24 +2352,24 @@ void ChartExport::exportDataLabels(
pFS-singleElement( FSNS( XML_c, XML_idx), XML_val, 
I32S(nElem), FSEND);
pFS-singleElement( FSNS( XML_c, XML_dLblPos), XML_val, 
aPlacement, FSEND);
 
-   if (GetProperty( xPropSet, LabelSeparator))
-   {
-   mAny = aSep;
-   pFS-singleElement( FSNS( XML_c, XML_separator), 
XML_val, USS(aSep), FSEND);
-   }
-
pFS-singleElement( FSNS( XML_c, XML_showLegendKey), 
XML_val,
aLabel.ShowLegendSymbol ? 1 : 0, 
FSEND);
pFS-singleElement( FSNS( XML_c, XML_showVal), XML_val,
aLabel.ShowNumber ? 1 : 0, FSEND);
pFS-singleElement( FSNS( XML_c, XML_showCatName), XML_val,
aLabel.ShowCategoryName ? 1 : 0, 
FSEND);
-   pFS-singleElement( FSNS( XML_c, XML_showPercent), XML_val,
-   aLabel.ShowNumberInPercent ? 1 : 0, 
FSEND);
// MSO somehow assumes series name to be on (=displayed) by 
default.
// Let's put false here and switch it off then, since we 
have no UI means
// in LibO to toggle it on anyway
pFS-singleElement( FSNS( XML_c, XML_showSerName), XML_val, 
0, FSEND);
+   pFS-singleElement( FSNS( XML_c, XML_showPercent), XML_val,
+   aLabel.ShowNumberInPercent ? 1 : 0, 
FSEND);
+
+   if (GetProperty( xPropSet, LabelSeparator))
+   {
+   mAny = aSep;
+   pFS-singleElement( FSNS( XML_c, XML_separator), 
XML_val, USS(aSep), FSEND);
+   }
pFS-endElement( FSNS( XML_c, XML_dLbl ));
  

Using UNO API for java

2013-04-28 Thread adrivero




Using UNO API for java and charge a template that contains a table 

I try to copy that table on the next page (I need copy also property ) to
create a new  and I find as

// first query the XTextTablesSupplier interface from our document
XTextTablesSupplier xTablesSupplier = (XTextTablesSupplier)
UnoRuntime.queryInterface(
XTextTablesSupplier.class, xWriterComponent);
// get the tables collection
XNameAccess xNamedTables = xTablesSupplier.getTextTables();

// now query the XIndexAccess from the tables collection
XIndexAccess xIndexedTables = (XIndexAccess) UnoRuntime.queryInterface(
XIndexAccess.class, xNamedTables);
// we need properties
xTableProps = null;

// get the tables
for (int i = 0; i  xIndexedTables.getCount(); i++) {
table = xIndexedTables.getByIndex(i);
// the properties, please!


xTableProps = (XPropertySet) UnoRuntime.queryInterface(
XPropertySet.class, table);
this.xTable = (XTextTable) UnoRuntime.queryInterface(
XTextTable.class, table);
}




--
View this message in context: 
http://nabble.documentfoundation.org/Using-UNO-API-for-java-tp4052668.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fdo#39468 Translation and cleanup

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3643

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3643
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71d5fdab8226d61bda9ac906bb82176dc11cafd2
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PUSHED] fdo#60949: Remove UNOLIBS_OOO

2013-04-28 Thread David Tardon (via Code Review)
Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3626

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3626
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8fc1da123f8374fb83192f14db730638213f564
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Björn Michaelsen bjoern.michael...@canonical.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-qa] [Moztrap] Error message CSRF verification failed, when I try to login

2013-04-28 Thread Thomas Hackert
Hello @ll,
I wanted to continue my translation of the test cases in Moztrap, 
when I got the message

quote
Forbidden (403)

CSRF verification failed. Request aborted.
Help

Reason given for failure:

CSRF token missing or incorrect.


In general, this can occur when there is a genuine Cross Site 
Request Forgery, or when Django's CSRF mechanism has not been used 
correctly. For POST forms, you need to ensure:

Your browser is accepting cookies.
The view function uses RequestContext for the template, instead 
of Context.
In the template, there is a {% csrf_token %} template tag inside 
each POST form that targets an internal URL.
If you are not using CsrfViewMiddleware, then you must use 
csrf_protect on any views that use the csrf_token template tag, as 
well as those that accept the POST data.

You're seeing the help section of this page because you have DEBUG = 
True in your Django settings file. Change that to False, and only 
the initial error message will be displayed.

You can customize this page using the CSRF_FAILURE_VIEW setting.
/quote

, when I try to login ... :( Does anybody know, why I get this 
message? And/or is able to fix django?
TIA for any answer/fix
Thomas.

-- 
Surprise due today. Also the rent.

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/


[Libreoffice-bugs] [Bug 63878] [FORMATTING] On an RTL spreadsheet, changing zoom level moves charts

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63878

--- Comment #5 from Faisal Menawer fmalota...@kacst.edu.sa ---
not only the charts also the shapes and images

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] New: UI RTL: you can't draw shapes from left to right on RTL Sheet and the start position are worng

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

  Priority: medium
Bug ID: 64011
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: UI RTL: you can't draw shapes from left to right on
RTL Sheet and the start position are worng
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: fmalota...@kacst.edu.sa
  Hardware: Other
Status: UNCONFIRMED
   Version: unspecified
 Component: Spreadsheet
   Product: LibreOffice

steps to reproduce:
1-open calc
2-change the sheet to be RTL(Right To Left)
3-select any of the shapes
4-try to draw the shape from the left to right.

current behavior:
the start position are wrong and can't draw the shape from left to right.

expected behavior:
the start position are correct and you can draw from left to right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] UI RTL: you can't draw shapes from left to right on RTL Sheet and the start position are worng

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

--- Comment #1 from Faisal Menawer fmalota...@kacst.edu.sa ---
Created attachment 78571
  -- https://bugs.freedesktop.org/attachment.cgi?id=78571action=edit
Test

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] UI RTL: you can't draw shapes from left to right on RTL Sheet and the start position are worng

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

Faisal Menawer fmalota...@kacst.edu.sa changed:

   What|Removed |Added

   Hardware|Other   |All
 CC||kaplanl...@gmail.com
Version|unspecified |4.0.1.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] UI RTL: you can't draw shapes from left to right on RTL Sheet and the start position are wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

Faisal Menawer fmalota...@kacst.edu.sa changed:

   What|Removed |Added

Summary|UI RTL: you can't draw  |UI RTL: you can't draw
   |shapes from left to right   |shapes from left to right
   |on RTL Sheet and the start  |on RTL Sheet and the start
   |position are worng  |position are wrong

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] UI RTL: you can't draw shapes from left to right on RTL Sheet and the start position are wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

Lior Kaplan kaplanl...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|4.0.1.2 release |4.0.0.3 release
 Ever confirmed|0   |1

--- Comment #2 from Lior Kaplan kaplanl...@gmail.com ---
Confirmed with 4.0.0.3 as well, changing status to new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] RTL sheets: you can't draw shapes from left to right, also the start position are wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

Lior Kaplan kaplanl...@gmail.com changed:

   What|Removed |Added

Summary|UI RTL: you can't draw  |RTL sheets: you can't draw
   |shapes from left to right   |shapes from left to right,
   |on RTL Sheet and the start  |also the start position are
   |position are wrong  |wrong

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64011] RTL sheets: you can't draw shapes from left to right, also the start position are wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64011

Lior Kaplan kaplanl...@gmail.com changed:

   What|Removed |Added

 Blocks||43808

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 43808] Meta bug for Most Annoying RTL related issues

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43808

Lior Kaplan kaplanl...@gmail.com changed:

   What|Removed |Added

 Depends on||64011

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58504] Extension Zotero does not work with LOdev4.0

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58504

--- Comment #7 from strug k...@o2.pl ---
I didn't keep track on every system I have, but I checked yesterday again,
seemed not to work, but I needed to rebuild bibligraphy, so I reinstalled
Zotero, and Zotero-firefox-LibreOffice plugin and it started to work again. But
now I don't use LOdev, but  4.0.2.2 (Build ID: 4.0.2.2 Arch Linux build-3).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 62455] Underbrace and overbrace positions and sizes broken

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62455

--- Comment #3 from Owen Genat owen.ge...@gmail.com ---
This AskLO thread may contain more information that is relevant to this
positioning issue:

http://ask.libreoffice.org/en/question/15177/underbraces-and-overbraces/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64012] New: EDITING: falta de funcionalidade no menu iniciar do Windows

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64012

  Priority: medium
Bug ID: 64012
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: EDITING: falta de funcionalidade no menu iniciar do
Windows
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: carlosdate...@ig.com.br
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 3.6.6.2 release
 Component: Writer
   Product: LibreOffice

Created attachment 78572
  -- https://bugs.freedesktop.org/attachment.cgi?id=78572action=edit
observe que ao pousar o mouse sobre bloco de notas aparece do lado direito os
últimos documentos. O mesmo acontecia antigamente com o libre office, porém
nesta versão 3.6, isso não está acontecendo

Problem description: 
quando se coloca o mouse sobre o nome do programa não aparece o menu dos
últimos arquivos acessados
Steps to reproduce:
1. 
2. 
3. 

Current behavior:

Expected behavior:


Operating System: Windows 7
Version: 3.6.6.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64013] New: FORMATTING: Need icons or locations of script formats

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64013

  Priority: medium
Bug ID: 64013
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FORMATTING: Need icons or locations of script formats
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: nj...@juno.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.1.1 rc
 Component: Writer
   Product: LibreOffice

Problem description: Unable to access icons to change script formats.  For
newbies, need icons, or an intuitive way to locate tools to effect alphabet
letter configurations; i.e.
1.  Boldface enable/disable 
2.  Change font size 
3.  Change fonts

Steps to reproduce:  n.a.
1. 
2. 
3. 

Current behavior:  n.a.

Expected behavior:  n.a.


Operating System: Windows XP
Version: 4.0.1.1 rc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64012] EDITING: falta de funcionalidade no menu iniciar do Windows

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64012

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Urmas davian...@gmail.com ---


*** This bug has been marked as a duplicate of bug 35785 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 35785] LibreOffice's support of the recent documents feature of the Windows 7 Start menu broken

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35785

Urmas davian...@gmail.com changed:

   What|Removed |Added

 CC||carlosdate...@ig.com.br

--- Comment #38 from Urmas davian...@gmail.com ---
*** Bug 64012 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 58663] RFE: Mac OS X 64bit port (cannot use UNO with Java 7)

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=58663

--- Comment #12 from Tor Lillqvist tlillqv...@suse.com ---
There are no 32-bit master builds because nobody has volunteered to produce
such builds. There is no central authority that decides what nightly builds to
produce and then delegates that tasks to underlings. It is quite the opposite;
anybody can run a tinderbox, and if he or she seems at least a bit reliable,
can be allowed to upload daily builds for redistribution (I assume; I am not
even a member of TDF).

In other words, if you have a suitable Mac and and maybe a dozen of gigs of
disk space available, you could well run a tinderbox yourself and upload
dailies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64015] New: UI: No lines are printed

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64015

  Priority: medium
Bug ID: 64015
  Keywords: regression
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: UI: No lines are printed
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: abug.seeb...@gmx.net
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Printing and PDF export
   Product: LibreOffice

Problem description: No lines are printed with EPSON Stylus CX6600

Steps to reproduce:
1. create a table in writer or a drwaing in draw
2. use lines as borders in the table
3. print with EPSON Stylus CX6600

Current behavior:
Lines are not printed


Printing with HP LaserJet works fine.
Printing the same document with OO 3.4.0 works fine.

Operating System: Windows XP
Version: 4.0.2.2 release
Last worked in: (See in Summary)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63968] VIEWING: libreoffice freeze ubuntu when docx open

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63968

--- Comment #4 from duteil linedub...@free.fr ---
(In reply to comment #3)
 Hi. Thank you for submitting a bug report. I tried to reproduce this issue
 with LibreOffice Writer using version 4.0.3.1 on Ubuntu 13.04. I opened 2
 .doc files, and then opened a .docx file. I am able to save, close, and edit
 any of the documents normally. For this reason, I am marking this bug as
 Work for me.
 
 If this is still an issue for you, you can REOPEN the bug with any extra
 information (such as specific version of Ubuntu you are using, and sample
 documents which result in the freeze).
 
 Version: 4.0.3.1
 Platform: Ubuntu 13.04 (Build ID: a67943cd4d125208f4ea7fa29439551825cfb39)
 
 - Brenda
 
 ---
 LibreOffice is powered by a team of volunteers, every bug is confirmed
 (triaged) by human beings who mostly give their time for free. We invite you
 to join our triaging by checking out this link:
 https://wiki.documentfoundation.org/QA/BugTriage
 There are also other ways to get involved including with marketing, UX,
 documentation, and of course developing - 
 http://www.libreoffice.org/get-help/mailing-lists

could i send my docx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63968] VIEWING: libreoffice freeze ubuntu when docx open

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63968

--- Comment #5 from duteil linedub...@free.fr ---
thanks a lot Brenda

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63968] VIEWING: libreoffice freeze ubuntu when docx open

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63968

duteil linedub...@free.fr changed:

   What|Removed |Added

   Hardware|Other   |x86-64 (AMD64)

--- Comment #6 from duteil linedub...@free.fr ---
ubuntu 12.04.2lts 
libreoffice 3.5.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64016] New: UI: In print preview the page forward and backwards buttons do not match

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64016

  Priority: medium
Bug ID: 64016
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: UI: In print preview the page forward and backwards
buttons do not match
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: john.pr...@cantab.net
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 78576
  -- https://bugs.freedesktop.org/attachment.cgi?id=78576action=edit
Screenshot of a print preview

Problem description: open a document in print preview and the forwards and
backwards buttons do not match - they seem to come from different icon sets.

Steps to reproduce:
1. open a calc document
2. go to print preview

Current behavior: the back one page button does not match the other buttons

Expected behavior: they should match

NB: screenshot taken with Welsh locale, but English displays the same behaviour
too.


Operating System: Windows 7
Version: 4.0.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64018] New: FILEOPEN: Error bars are not importet from xls

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64018

  Priority: medium
Bug ID: 64018
  Keywords: regression
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: FILEOPEN: Error bars are not importet from xls
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: abug.seeb...@gmx.net
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

Problem description: 
Importing an xls-file with a graphic using error-bars does not show the error
bars.

Steps to reproduce:
1. Create xls-file:
Create table with 4 colums (and 5 rows) (x, y, Error1, Error 2) and fill it
with appropriate values
Mark colum 1 an 2
Menue: Insert/Diagram
Select dots (with lines)
Select accept (Fertigstellen in german - I don't know the exact Name in
English)
Right-click on one data-point
Select Error-indicator Y
Add row 2 and 3 as error-bars
Save document
2. Import it to LibreOffice

Current behavior:
Error bars are missing.

Expected behavior:
Error bars should be shown.

Works with OO 3.4.0


Operating System: Windows XP
Version: 4.0.2.2 release
Last worked in: (See in Summary)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 57782] : Documents fail to close and exit using File Menu.

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57782

--- Comment #2 from Tim Short timsho...@virginmedia.com ---
Joren

Just upgraded Ubuntu to 13.04, not problems closing down docs. under
LibreOffice 4.

Many thanks.

Tim

On 24/04/13 22:54, bugzilla-dae...@freedesktop.org wrote:
 Jorendc mailto:joren.libreoff...@telenet.be changed bug 57782 
 https://bugs.freedesktop.org/show_bug.cgi?id=57782
 What  Removed Added
 StatusUNCONFIRMED NEEDINFO
 CCjoren.libreoff...@telenet.be
 Ever confirmed1

 *Comment # 1 https://bugs.freedesktop.org/show_bug.cgi?id=57782#c1 
 on bug 57782 https://bugs.freedesktop.org/show_bug.cgi?id=57782 from 
 Jorendc mailto:joren.libreoff...@telenet.be *
 Hi Tim,

 Is this still reproducible using latest 4.0 version (which you can download
 here:http://www.libreoffice.org/download)?

 Kind regards,
 Joren
 
 You are receiving this mail because:

   * You reported the bug.


-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] New: Viewing error: formatting is wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

  Priority: medium
Bug ID: 64019
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Viewing error: formatting is wrong
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: cince...@seznam.cz
  Hardware: All
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 78580
  -- https://bugs.freedesktop.org/attachment.cgi?id=78580action=edit
xls

Verze 4.0.2.2 (ID sestavení: 4c82dcdd6efcd48b1d8bba66bfe1989deee49c3)

Hi, another bug.
See attached xls.

And see also pictures in latest libreoffice and Excel 2013. 

SOrry for confussing summary, it is very hard to create one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] Viewing error: formatting is wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

--- Comment #1 from cince...@seznam.cz ---
Created attachment 78581
  -- https://bugs.freedesktop.org/attachment.cgi?id=78581action=edit
libreoffice version

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] Viewing error: formatting is wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

--- Comment #2 from cince...@seznam.cz ---
Created attachment 78582
  -- https://bugs.freedesktop.org/attachment.cgi?id=78582action=edit
excel 2013

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] Viewing error: formatting is wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

--- Comment #3 from cince...@seznam.cz ---
(In reply to comment #0)
 Created attachment 78580 [details]
 xls
 
 Verze 4.0.2.2 (ID sestavení: 4c82dcdd6efcd48b1d8bba66bfe1989deee49c3)
 
 Hi, another bug.
 See attached xls.
 
 And see also pictures in latest libreoffice and Excel 2013. 
 
 SOrry for confussing summary, it is very hard to create one.

not  confussing  but confusing

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64020] New: EXTENSIONSWEBSITE: Wrong link request for Firefox Personas

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64020

  Priority: medium
Bug ID: 64020
  Keywords: regression
CC: webs...@global.libreoffice.org
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: EXTENSIONSWEBSITE: Wrong link request for Firefox
Personas
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: danysa...@gmail.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.1.0.0.alpha0+ Master
 Component: WWW
   Product: LibreOffice

Problem description: 

Steps to reproduce:
1. settings
2. personalization
3. Select Persona
4. Insert link from personas site

Current behavior:
requests the old website (form getpersonas.com/persona/..) instead of actual
(addons.mozilla.org/it/firefox/addon/..)

Expected behavior:
Accept the link

Operating System: Windows 8
Version: 4.1.0.0.alpha0+ Master
Last worked in: 4.0.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64020] EXTENSIONSWEBSITE: Wrong link request for Firefox Personas

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64020

danysa...@gmail.com changed:

   What|Removed |Added

  Component|WWW |graphics stack

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39468] translate German comments, removing redundant ones

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39468

--- Comment #61 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Matthias Freund committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=df0376ea3f80f7bab7f4075dc8004e8f25d0d9a4

fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 2)



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64021] New: a lot of problem with printing, pdf, selections cells to print, aperçu (show before print)...only works with one page

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64021

  Priority: medium
Bug ID: 64021
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: a lot of problem with printing, pdf, selections cells
to print, aperçu (show before print)...only works
with one page
  Severity: major
Classification: Unclassified
OS: Windows (All)
  Reporter: jomini0...@hotmail.fr
  Hardware: x86-64 (AMD64)
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Printing and PDF export
   Product: LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64021] a lot of problem with printing, pdf, selections cells to print, aperçu (show before print)...only works with one page

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64021

--- Comment #1 from Joel MESSAGER jomini0...@hotmail.fr ---
Sorry I don't understand all you need.

When I change from 3.6.? to version 4.0.2.2 I can't printing or pdf my 2 pages
of calcThe aperçu (show before print) don't works well...only one
page...I Try to change format zones impression...nothing better, I try to
use insertion noms nothing betterI try to create a special calc page
to print only cells what I would...better but only for one page.   Finally I
can print my 2 pages not exactly how because I check the same way many times
and only one method word...My method 1) create two special page with only the
cells I want to print,  and use format zones impression ajouter and I
create pdf and I print PDF.

thank to your good work for libre office.
by the past I was a user of excel 95 with good macro, free office

JM

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64021] a lot of problem with printing, pdf, selections cells to print, aperçu (show before print)...only works with one page

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64021

Joel MESSAGER jomini0...@hotmail.fr changed:

   What|Removed |Added

   Severity|major   |normal
   Keywords||NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64020] EXTENSIONSWEBSITE: Wrong link request for Firefox Personas

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64020

Florian Effenberger flo...@documentfoundation.org changed:

   What|Removed |Added

 CC||floeff@documentfoundation.o
   ||rg

--- Comment #1 from Florian Effenberger flo...@documentfoundation.org ---
Is that really a problem for the extension website? Isn't it more a bug in the
program itself?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] Viewing error: formatting is wrong

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

Urmas davian...@gmail.com changed:

   What|Removed |Added

  Attachment #78580|text/plain  |application/octet-stream
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] FILEOPEN: Excel 2003: Button form controls have invisible captions

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

Urmas davian...@gmail.com changed:

   What|Removed |Added

Summary|Viewing error: formatting   |FILEOPEN: Excel 2003:
   |is wrong|Button form controls have
   ||invisible captions

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] FILEOPEN: Excel 2003: Button form controls have invisible captions

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

Urmas davian...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Urmas davian...@gmail.com ---
Confirmed in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61908] FILESAVE: mmult array function not saved correctly in .xlsx format

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61908

--- Comment #4 from V. Wood wood.vi.t...@gmail.com ---
LO 4.0.1.2 does not fix this issue for me, running on Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64019] FILEOPEN: Excel 2003: Button form controls have invisible captions

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64019

--- Comment #5 from cince...@seznam.cz ---
(In reply to comment #4)
 Confirmed in master.

thank you. Just for information: what does confirmed in master mean. Does it
mean that somebody is working on that ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61908] FILESAVE: mmult array function not saved correctly in .xlsx format

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61908

--- Comment #5 from V. Wood wood.vi.t...@gmail.com ---
It's nothing to do with the actual MMULT function, it's to do with the array
formulas.  All array formulas fail when saved to xlsx.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 64023] New: VIEWING: Showing negative values red

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64023

  Priority: medium
Bug ID: 64023
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: VIEWING: Showing negative values red
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: heikobi...@gmail.com
  Hardware: Other
Whiteboard: BSA
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 78583
  -- https://bugs.freedesktop.org/attachment.cgi?id=78583action=edit
Attached screenshot of spredsheet -- column C: formula e.g.[C320]= B320-B319;
column D: e.g. [D320]=(B320/B319)-1

Problem description: 
In my spreadsheets I use the number formatting of showing negative values RED.
After installing the 4.0.0.3 release values in cells with formulas and
conditions (IF THEN) doesn't show negative values in RED color. The color
changes only for newly calculated values but after opening the document again
all values are in BLACK again.


Current behavior:

showing negative values in BLACK font color

Expected behavior:
showing negative values in RED font color

Operating System: Windows 8
Version: 4.0.2.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63680] EDITING: CRASH when click on contents or entering a line of text

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63680

Commit Notification libreoffice-comm...@lists.freedesktop.org changed:

   What|Removed |Added

 Whiteboard||target:4.1.0

--- Comment #17 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Miklos Vajna committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1fd3167695aaebb050df53acd91f2e1625e8305a

fdo#63680 SwTxtCursor::GetCrsrOfst: don't pass reference to a temporary



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63680] EDITING: CRASH when click on contents or entering a line of text

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63680

Miklos Vajna vmik...@suse.cz changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Miklos Vajna vmik...@suse.cz ---
FWIW, problem can be reproduced when building without --enable-debug or
--enable-dbgutil, using MSVC. Just rebuilding sw with debug=t makes the problem
go away, however ENABLE_SYMBOLS=y still reproduced the problem.

Can't reproduce on 4.0, so closing without a backport.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 60270] LibreOffice 4.1 most annoying bugs

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60270

Bug 60270 depends on bug 63680, which changed state.

Bug 63680 Summary: EDITING: CRASH when click on contents or entering a line of 
text
https://bugs.freedesktop.org/show_bug.cgi?id=63680

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63197] avoid packing stuff into zips during build

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63197

--- Comment #19 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Julien Nabet committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c04d86f692d4b0841adba508a21e63e1bcdc45f

fdo#63197: convert helpxsl



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63197] avoid packing stuff into zips during build

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63197

--- Comment #20 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Julien Nabet committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ed5affa51257e1bfece7fd8712acad77ad64cad

fdo#63197: convert fontunxafm



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63680] EDITING: CRASH when click on contents or entering a line of text

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63680

Miklos Vajna vmik...@suse.cz changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |vmik...@suse.cz
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63767] CRASH when opening a file

2013-04-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63767

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from V Stuart Foote vstuart.fo...@utsa.edu ---
Closing as resolved duplicate of bug 63680 which has been resolved fixed by

Miklos Vajna committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1fd3167695aaebb050df53acd91f2e1625e8305a

fdo#63680 SwTxtCursor::GetCrsrOfst: don't pass reference to a temporary


@Urmas, would be great if you also can confirm on your build of master.

*** This bug has been marked as a duplicate of bug 63680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   >