date:20140131

 canvas/source/cairo/cairo_textlayout.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 9d5024a46e12dc91f75a964d87a1d53385c1a521
Author: Jan Holesovsky ke...@collabora.com
Date:   Fri Jan 31 10:28:55 2014 +0100

cairo canvas: Zero font's width means the same as height.

Change-Id: I1d24b2039fb3c615e672189d12c77e960cc858ee

diff --git a/canvas/source/cairo/cairo_textlayout.cxx 
b/canvas/source/cairo/cairo_textlayout.cxx
index 3477c1b..40da537 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -519,7 +519,11 @@ namespace cairocanvas
 if (aSysLayoutData.orientation)
 cairo_matrix_rotate(m, (3600 - aSysLayoutData.orientation) * 
M_PI / 1800.0);
 
-cairo_matrix_scale(m, aFont.GetWidth(), aFont.GetHeight());
+long nWidth = aFont.GetWidth();
+long nHeight = aFont.GetHeight();
+if (nWidth == 0)
+nWidth = nHeight;
+cairo_matrix_scale(m, nWidth, nHeight);
 
 //faux italics
 if (rSysFontData.bFakeItalic)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.0' - canvas/source

 canvas/source/cairo/cairo_textlayout.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit f2293d1c1c30ea0f6d8b1d1af5f12262f796cd81
Author: Jan Holesovsky ke...@collabora.com
Date:   Fri Jan 31 10:28:55 2014 +0100

cairo canvas: Zero font's width means the same as height.

Change-Id: I1d24b2039fb3c615e672189d12c77e960cc858ee

diff --git a/canvas/source/cairo/cairo_textlayout.cxx 
b/canvas/source/cairo/cairo_textlayout.cxx
index 6075029..9f862c8 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -527,7 +527,11 @@ namespace cairocanvas
 if (aSysLayoutData.orientation)
 cairo_matrix_rotate(m, (3600 - aSysLayoutData.orientation) * 
M_PI / 1800.0);
 
-cairo_matrix_scale(m, aFont.GetWidth(), aFont.GetHeight());
+long nWidth = aFont.GetWidth();
+long nHeight = aFont.GetHeight();
+if (nWidth == 0)
+nWidth = nHeight;
+cairo_matrix_scale(m, nWidth, nHeight);
 
 //faux italics
 if (rSysFontData.bFakeItalic)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2014-01-31 Thread YogeshBharate

 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 sw/source/filter/ww8/docxexport.cxx  |5 ++---
 sw/source/filter/ww8/docxexport.hxx  |2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit ac177e3919362deb6e46257a2787384620ca9a5e
Author: YogeshBharate yogesh.bhar...@synerzip.com
Date:   Fri Jan 24 18:27:25 2014 +0530

fdo#73872: File Corruption - Issue with w:footerReference in document.xml

Problem Description :
- In case if the header/footer had a chart in it then the associated
  relation Id was getting added to document.xml.rels instead of adding
  it to the relevent item*.xml.rels file.
- Due to this the MS office was unable to read the round tripped file.

Implementation :
- Added the relation id's to relevant rels files.

Change-Id: I412178222400e98ab2ef46d930c1e1fdfebf9799
Reviewed-on: https://gerrit.libreoffice.org/7630
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index c5c2feb..6e0b428 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -3131,7 +3131,7 @@ void DocxAttributeOutput::WritePostponedChart()
 static sal_Int32 nChartCount = 0;
 nChartCount++;
 uno::Reference frame::XModel  xModel( xChartDoc, uno::UNO_QUERY );
-aRelId = m_rExport.OutputChart( xModel, nChartCount );
+aRelId = m_rExport.OutputChart( xModel, nChartCount, m_pSerializer );
 
 m_pSerializer-singleElementNS( XML_c, XML_chart,
 FSNS( XML_xmlns, XML_c ), 
http://schemas.openxmlformats.org/drawingml/2006/chart;,
diff --git a/sw/source/filter/ww8/docxexport.cxx 
b/sw/source/filter/ww8/docxexport.cxx
index e67b538..e8342c4 100644
--- a/sw/source/filter/ww8/docxexport.cxx
+++ b/sw/source/filter/ww8/docxexport.cxx
@@ -341,13 +341,12 @@ void DocxExport::DoFormText(const SwInputField* /*pFld*/)
 OSL_TRACE( TODO DocxExport::ForFormText() );
 }
 
-OString DocxExport::OutputChart( uno::Reference frame::XModel  xModel, 
sal_Int32 nCount )
+OString DocxExport::OutputChart( uno::Reference frame::XModel  xModel, 
sal_Int32 nCount, ::sax_fastparser::FSHelperPtr m_pSerializer )
 {
 OUString aFileName = charts/chart + OUString::number(nCount) + .xml;
-OUString sId = m_pFilter-addRelation( m_pDocumentFS-getOutputStream(),
+OUString sId = m_pFilter-addRelation( m_pSerializer-getOutputStream(),
 
http://schemas.openxmlformats.org/officeDocument/2006/relationships/chart;,
 aFileName );
-
 aFileName = word/charts/chart + OUString::number(nCount) + .xml;
 ::sax_fastparser::FSHelperPtr pChartFS =
 m_pFilter-openFragmentStreamWithSerializer( aFileName,
diff --git a/sw/source/filter/ww8/docxexport.hxx 
b/sw/source/filter/ww8/docxexport.hxx
index d371fa1..5d37095 100644
--- a/sw/source/filter/ww8/docxexport.hxx
+++ b/sw/source/filter/ww8/docxexport.hxx
@@ -154,7 +154,7 @@ public:
 virtual sal_uLong ReplaceCr( sal_uInt8 nChar );
 
 /// Returns the relationd id
-OString OutputChart( com::sun::star::uno::Reference 
com::sun::star::frame::XModel  xModel, sal_Int32 nCount );
+OString OutputChart( com::sun::star::uno::Reference 
com::sun::star::frame::XModel  xModel, sal_Int32 nCount, 
::sax_fastparser::FSHelperPtr m_pSerializer );
 /// Writes the shape using drawingML syntax.
 void OutputDML( com::sun::star::uno::Reference 
com::sun::star::drawing::XShape  xShape );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=51781

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.freedesktop.or |
   |g/show_bug.cgi?id=51781 |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=36546

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

 Blocks||36546

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/filter sw/source

2014-01-31 Thread Miklos Vajna

 include/filter/msfilter/sprmids.hxx |1 +
 sw/source/filter/ww8/wrtw8num.cxx   |2 +-
 sw/source/filter/ww8/ww8par3.cxx|2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 2df08acc4c0bdbe1df96770cab347d1f5df9d7a7
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Fri Jan 31 10:50:44 2014 +0100

sw: hardcoded NS_sprm::LN_CPbiIBullet

Change-Id: I51d4638b588da290853422750b90365b454c046f

diff --git a/include/filter/msfilter/sprmids.hxx 
b/include/filter/msfilter/sprmids.hxx
index 1aa84c2..85c97a0 100644
--- a/include/filter/msfilter/sprmids.hxx
+++ b/include/filter/msfilter/sprmids.hxx
@@ -171,6 +171,7 @@ namespace NS_sprm {
 const sal_uInt16 LN_CFUsePgsuSettings = 0x0868;
 const sal_uInt16 LN_CCpg = 0x486b;
 const sal_uInt16 LN_CPbiGrf = 0x4888;
+const sal_uInt16 LN_CPbiIBullet = 0x6887;
 const sal_uInt16 LN_CRgLid0_80 = 0x486d;
 const sal_uInt16 LN_CRgLid1_80 = 0x486e;
 const sal_uInt16 LN_CIdctHint = 0x286f;
diff --git a/sw/source/filter/ww8/wrtw8num.cxx 
b/sw/source/filter/ww8/wrtw8num.cxx
index 9fc8f44..c4b7d69 100644
--- a/sw/source/filter/ww8/wrtw8num.cxx
+++ b/sw/source/filter/ww8/wrtw8num.cxx
@@ -261,7 +261,7 @@ void WW8AttributeOutput::NumberingLevel( sal_uInt8 
/*nLevel*/,
 int nIndex = m_rWW8Export.GetGrfIndex(*pBrush);
 if ( nIndex != -1 )
 {
-m_rWW8Export.InsUInt16(0x6887);
+m_rWW8Export.InsUInt16(NS_sprm::LN_CPbiIBullet);
 m_rWW8Export.InsUInt32(nIndex);
 m_rWW8Export.InsUInt16(NS_sprm::LN_CPbiGrf);
 m_rWW8Export.InsUInt16(1);
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index 7f688a7..9a7440a 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -666,7 +666,7 @@ bool WW8ListManager::ReadLVL(SwNumFmt rNumFmt, 
SfxItemSet* rpItemSet,
 return false;
 
 //For i120928,parse the graphic info of bullets
-sal_uInt8 *pSprmWhichPis = 
GrpprlHasSprm(0x6887,aGrpprlChpx[0],aLVL.nLenGrpprlChpx);
+sal_uInt8 *pSprmWhichPis = GrpprlHasSprm(NS_sprm::LN_CPbiIBullet, 
aGrpprlChpx[0],aLVL.nLenGrpprlChpx);
 sal_uInt8 *pSprmIsPicBullet = GrpprlHasSprm(NS_sprm::LN_CPbiGrf, 
aGrpprlChpx[0],aLVL.nLenGrpprlChpx);
 if (pSprmWhichPis)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

RE: how to detect compiler warning

2014-01-31 Thread Winfried Donkers

Hi Miklos,

Just use:

./autogen.sh --enable-werror

and then any warning from your compiler will fail your build, making sure you 
don't introduce new warnings without noticing them.

Thank you, will do so.
I only hope that 'others' will get rid of 'their' warnings too ;-)

Winfried

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: javaunohelper/com ridljar/com

2014-01-31 Thread Stephan Bergmann

 javaunohelper/com/sun/star/comp/helper/Bootstrap.java |   13 ++-
 javaunohelper/com/sun/star/comp/helper/ComponentContextEntry.java |2 
 javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java   |   34 
+-
 javaunohelper/com/sun/star/lib/uno/helper/PropertySet.java|   15 ++--
 javaunohelper/com/sun/star/lib/uno/helper/PropertySetMixin.java   |2 
 ridljar/com/sun/star/uno/IEnvironment.java|2 
 ridljar/com/sun/star/uno/IMethodDescription.java  |4 -
 ridljar/com/sun/star/uno/ITypeDescription.java|   22 +++---
 ridljar/com/sun/star/uno/Type.java|4 -
 9 files changed, 55 insertions(+), 43 deletions(-)

New commits:
commit 3a05aabe4190fc948ebdc94a14a15872f977ba0c
Author: Stephan Bergmann sberg...@redhat.com
Date:   Fri Jan 31 11:00:17 2014 +0100

Silence javadoc 8 errors

Change-Id: Ib0b2286669d797708b30bf0fffdbe14c14d1e30d

diff --git a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java 
b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
index 85bc483..6c40f7c 100644
--- a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
+++ b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
@@ -136,9 +136,10 @@ public class Bootstrap {
 
 /**
  * Bootstraps a servicemanager with the jurt base components registered.
- * p
+ *
+ * See also UNOIDL codecom.sun.star.lang.ServiceManager/code.
+ *
  * @return a freshly boostrapped service manager
- * @seecom.sun.star.lang.ServiceManager
  */
 static public XMultiServiceFactory createSimpleServiceManager() throws 
Exception
 {
@@ -149,7 +150,8 @@ public class Bootstrap {
 
 /** Bootstraps the initial component context from a native UNO 
installation.
 
-@see cppuhelper/defaultBootstrap_InitialComponentContext()
+See also
+codecppuhelper/defaultBootstrap_InitialComponentContext()/code.
 */
 static public final XComponentContext 
defaultBootstrap_InitialComponentContext()
 throws Exception
@@ -168,12 +170,13 @@ public class Bootstrap {
 }
 /** Bootstraps the initial component context from a native UNO 
installation.
 
+See also
+codecppuhelper/defaultBootstrap_InitialComponentContext()/code.
+
 @param ini_file
ini_file (may be null: uno.rc besides cppuhelper lib)
 @param bootstrap_parameters
bootstrap parameters (maybe null)
-
-@see cppuhelper/defaultBootstrap_InitialComponentContext()
 */
 static public final XComponentContext 
defaultBootstrap_InitialComponentContext(
 String ini_file, java.util.MapString,String bootstrap_parameters )
diff --git a/javaunohelper/com/sun/star/comp/helper/ComponentContextEntry.java 
b/javaunohelper/com/sun/star/comp/helper/ComponentContextEntry.java
index ea1c57e..bb3bd7a 100644
--- a/javaunohelper/com/sun/star/comp/helper/ComponentContextEntry.java
+++ b/javaunohelper/com/sun/star/comp/helper/ComponentContextEntry.java
@@ -24,7 +24,7 @@ package com.sun.star.comp.helper;
 The first one is commonly used for singleton objects of the component
 context, that are raised on first-time retrieval of the key.
 You have to pass a com.sun.star.lang.XSingleComponentFactory
-or string (= service name) object for this.
+or string (=gt; service name) object for this.
 /p
 */
 public class ComponentContextEntry
diff --git a/javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java 
b/javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
index c7e3ded..32610a3 100644
--- a/javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
+++ b/javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
@@ -29,10 +29,10 @@ import com.sun.star.registry.XRegistryKey;
  *
  * The codeSharedLibraryLoader/code class provides the functionality of 
the codecom.sun.star.loader.SharedLibrary/code
  * service.
- * p
+ *
+ * See also UNOIDL codecom.sun.star.lang.ServiceManager/code.
+ *
  * @see com.sun.star.loader.SharedLibrary
- * @see com.sun.star.comp.servicemanager.ServiceManager
- * @see com.sun.star.lang.ServiceManager
  */
 public class SharedLibraryLoader {
 /**
@@ -77,13 +77,14 @@ public class SharedLibraryLoader {
  * The defaults are shlibloader.uno
  * for the library and com.sun.star.comp.stoc.DLLComponentLoader
  * for the component name.
- * p
+ *
+ * See also UNOIDL codecom.sun.star.lang.ServiceManager/code and
+ * codecom.sun.star.registry.RegistryKey/code.
+ *
  * @return  the factory for the 
com.sun.star.comp.stoc.DLLComponentLoader component.
  * @param   smgrthe ServiceManager
  * @param   regKey  the root registry key
  * @see com.sun.star.loader.SharedLibrary
- * @see com.sun.star.lang.ServiceManager
- * @see com.sun.star.registry.RegistryKey

[Bug 54938] Adapt supportsService implementations to cppu::supportsService

https://bugs.freedesktop.org/show_bug.cgi?id=54938

--- Comment #35 from Stephan Bergmann sberg...@redhat.com ---
(In reply to comment #34)
 sal_Bool SAL_CALL FilterBase::supportsService( const OUString rServiceName
 ) throw( RuntimeException )
 {
return
(rServiceName == com.sun.star.document.ImportFilter ) ||
(rServiceName == com.sun.star.document.ExportFilter );
 }

Please always give a pointer to the relevant file, apparently
oox/source/core/filterbase.cxx in this case.

As currrent FilterBase::supportsService behavior is in line with
FilterBase::getSupportedServiceNames behavior (defined just afterwards), the
usual approach of forwarding to cppu::supportsService just works here.  Or what
am I missing?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: odk/examples

2014-01-31 Thread Alexandre Vicenzi

 
odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
|   23 +---
 odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx 
  |4 
 odk/examples/DevelopersGuide/Components/CppComponent/service2_impl.cxx 
  |4 
 odk/examples/DevelopersGuide/Database/DriverSkeleton/OSubComponent.hxx 
  |   55 +++---
 
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/FlatXmlFilterDetection/filterdetect.cxx
 |   10 -
 odk/examples/cpp/complextoolbarcontrols/MyJob.cxx  
  |9 -
 odk/examples/cpp/complextoolbarcontrols/MyListener.cxx 
  |   10 -
 odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx  
  |   11 --
 8 files changed, 39 insertions(+), 87 deletions(-)

New commits:
commit 4f63a5fa269678cdc021f5c280f697e53771545a
Author: Alexandre Vicenzi vicenzi.alexan...@gmail.com
Date:   Fri Jan 31 02:42:47 2014 -0200

fdo#54938 Convert odk to cppu::supportsService

Change-Id: Ia5095367be90dd5383e7701ea2587f79a7505a67
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git 
a/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
 
b/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
index 7ad15d7..4f9ed11 100644
--- 
a/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
+++ 
b/odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx
@@ -34,8 +34,6 @@
  */
 
 #include addon.hxx
-#include osl/diagnose.h
-#include rtl/ustring.hxx
 #include com/sun/star/beans/PropertyValue.hpp
 #include com/sun/star/frame/XFrame.hpp
 #include com/sun/star/frame/XController.hpp
@@ -44,6 +42,9 @@
 #include com/sun/star/awt/WindowAttribute.hpp
 #include com/sun/star/awt/XMessageBox.hpp
 #include com/sun/star/uno/XComponentContext.hpp
+#include cppuhelper/supportsservice.hxx
+#include osl/diagnose.h
+#include rtl/ustring.hxx
 
 using rtl::OUString;
 using namespace com::sun::star::uno;
@@ -193,22 +194,13 @@ void SAL_CALL Addon::removeStatusListener( const 
Reference XStatusListener  x
 {
 }
 
-//##
-// Helper functions for the implementation of UNO component interfaces 
#
-//##
-
+// Helper functions for the implementation of UNO component interfaces.
 OUString Addon_getImplementationName()
 throw (RuntimeException)
 {
 return OUString ( IMPLEMENTATION_NAME );
 }
 
-sal_Bool SAL_CALL Addon_supportsService( const ::rtl::OUString ServiceName )
-throw (RuntimeException)
-{
-return ServiceName == SERVICE_NAME;
-}
-
 Sequence ::rtl::OUString  SAL_CALL Addon_getSupportedServiceNames()
 throw (RuntimeException)
 {
@@ -224,10 +216,7 @@ Reference XInterface  SAL_CALL Addon_createInstance( 
const Reference XCompone
 return (cppu::OWeakObject*) new Addon( rContext );
 }
 
-//##
-// Implementation of the recommended/mandatory interfaces of a UNO 
component ###
-//##
-
+// Implementation of the recommended/mandatory interfaces of a UNO component.
 // XServiceInfo
 ::rtl::OUString SAL_CALL Addon::getImplementationName(  )
 throw (RuntimeException)
@@ -238,7 +227,7 @@ Reference XInterface  SAL_CALL Addon_createInstance( 
const Reference XCompone
 sal_Bool SAL_CALL Addon::supportsService( const ::rtl::OUString rServiceName )
 throw (RuntimeException)
 {
-return Addon_supportsService( rServiceName );
+return cppu::supportsService(this, rServiceName);
 }
 
 Sequence ::rtl::OUString  SAL_CALL Addon::getSupportedServiceNames(  )
diff --git 
a/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx 
b/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx
index 37c4b61..ab82348 100644
--- a/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx
+++ b/odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx
@@ -38,6 +38,7 @@
 #include rtl/uuid.h
 #include rtl/instance.hxx
 #include cppuhelper/factory.hxx
+#include cppuhelper/supportsservice.hxx
 
 #include com/sun/star/lang/XServiceInfo.hpp
 #include com/sun/star/lang/XTypeProvider.hpp
@@ -226,8 +227,7 @@ OUString MyService1Impl::getImplementationName()
 sal_Bool MyService1Impl::supportsService( OUString const  serviceName )
 throw (RuntimeException)
 {
-// this object only supports one service, so the test is simple
-

[Bug 54938] Adapt supportsService implementations to cppu::supportsService

https://bugs.freedesktop.org/show_bug.cgi?id=54938

--- Comment #36 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Alexandre Vicenzi committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f63a5fa269678cdc021f5c280f697e53771545a

fdo#54938 Convert odk to cppu::supportsService



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - odk/CustomTarget_settings.mk odk/settings

2014-01-31 Thread Stephan Bergmann

 odk/CustomTarget_settings.mk |5 +++-
 odk/settings/dk.mk   |3 +-
 odk/settings/settings.mk |   48 ++-
 3 files changed, 22 insertions(+), 34 deletions(-)

New commits:
commit 54eb449459db74634695c1a986e973f97adc6ab6
Author: Stephan Bergmann sberg...@redhat.com
Date:   Mon Jan 20 17:21:14 2014 +0100

SDK settings.mk: Don't guess PLATFORM/PROCTYPE, and fix Mac OS X 64 bit

...rather, pass them from the build to the SDK installation via dk.mk.  
(The SDK
installation is already platform-specific anyway, see the binary 
executables in
its bin/ directory, so there is no point in not fixing this at build time.  
In
the future, the shipped settings.mk could of course be stripped to just the
parts relevant for a given platform, of course.)

Along the way, fixes some apparent ppc vs. powerpc typos in settings.mk.

Cherry picked from commit dea0398ee24eb278cdb14999efbf34d634454eaa SDK
settings.mk: Don't guess PLATFORM/PROCTYPE plus
e5ad31e2f784856506c28092166dc8704c84e868 Fix Mac OS X 64 bit SDK 
settings.mk
and b3db695a338f1acddbe46102138a0167fc346f58 SDK: Split PLATFORMID at build
time rather than runtime fix.

Conflicts:
odk/settings/settings.mk

Change-Id: Ib8e0c03ad6dfd610aae58a61e32bdc61c785584f
Reviewed-on: https://gerrit.libreoffice.org/7748
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com

diff --git a/odk/CustomTarget_settings.mk b/odk/CustomTarget_settings.mk
index 2a0d6e4..c48a734 100644
--- a/odk/CustomTarget_settings.mk
+++ b/odk/CustomTarget_settings.mk
@@ -13,7 +13,10 @@ $(eval $(call 
gb_CustomTarget_register_target,odk/settings,dk.mk))
 
 $(call gb_CustomTarget_get_workdir,odk/settings)/dk.mk : 
$(SRCDIR)/odk/settings/dk.mk
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),build,SED,1)
-   tr -d \015  $ | sed -e 's/@@RELEASE@@/$(PRODUCTVERSION)/' \
+   tr -d \015  $ | sed \
+   -e 's/@@PLATFORM@@/$(firstword $(subst _, ,$(PLATFORMID)))/' \
+   -e 's/@@PROCTYPE@@/$(subst $(WHITESPACE),_,$(wordlist 2,$(words 
$(subst _, ,$(PLATFORMID))),$(subst _, ,$(PLATFORMID/' \
+   -e 's/@@RELEASE@@/$(PRODUCTVERSION)/' \
-e 
's/@@BUILDID@@/$(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO).$(LIBO_VERSION_PATCH)/'
 \
-e 's/@@ENABLE_DBGUTIL@@/$(ENABLE_DBGUTIL)/'  $@
 
diff --git a/odk/settings/dk.mk b/odk/settings/dk.mk
index 387ef13..8f41b7e1 100644
--- a/odk/settings/dk.mk
+++ b/odk/settings/dk.mk
@@ -1,4 +1,5 @@
-# OpenOffice.org @@RELEASE@@ SDK dependent settings
+PLATFORM=@@PLATFORM@@
+PROCTYPE=@@PROCTYPE@@
 SDKVERSION=@@RELEASE@@
 BUILDID=@@BUILDID@@
 LIBO_SDK_ENABLE_DBGUTIL=@@ENABLE_DBGUTIL@@
diff --git a/odk/settings/settings.mk b/odk/settings/settings.mk
index b884e75..0d14ad4 100644
--- a/odk/settings/settings.mk
+++ b/odk/settings/settings.mk
@@ -21,14 +21,6 @@
 
 include $(OO_SDK_HOME)/settings/dk.mk
 
-# test for the platform
-PLATFORM := $(shell $(PRJ)/config.guess | cut -d- -f3,4)
-
-# config.guess is missing for windows. We rely on getting  in this case.
-ifeq $(PLATFORM) 
-PLATFORM = windows
-endif
-
 # debug option, default is no debug
 DEBUG=no
 ifeq $(MAKECMDGOALS) debug
@@ -153,11 +145,9 @@ endif
 # Solaris specific settings
 #
 ###
-ifneq (,$(findstring solaris,$(PLATFORM)))
+ifeq $(PLATFORM) solaris
 # Settings for Solaris using Sun Workshop compiler
 
-PROCTYPE := $(shell $(PRJ)/config.guess | cut -d- -f1)$(shell 
/usr/ccs/bin/elfdump -e $(OO_SDK_URE_HOME)/lib/libuno_sal.so.3 | 
/usr/xpg4/bin/grep -q -w ELFCLASS64  echo 64)
-
 ifeq $(PROCTYPE) sparc
 PLATFORM=solsparc
 UNOPKG_PLATFORM=Solaris_SPARC
@@ -269,17 +259,13 @@ endif
 # Linux specific settings
 #
 ###
-ifneq (,$(findstring linux,$(PLATFORM)))
+ifeq $(PLATFORM) linux
 # Settings for Linux using gcc compiler
 
-PROCTYPE := $(shell $(PRJ)/config.guess | cut -d - -f1 | sed -e 
's/^i.86$$/i386/')
-PLATFORM=linux
-
 UNOPKG_PLATFORM=Linux_$(PROCTYPE)
 JAVA_PROC_TYPE=$(PROCTYPE)
 
-ifeq $(PROCTYPE) i386
-UNOPKG_PLATFORM=Linux_x86
+ifeq $(PROCTYPE) x86
 JAVA_PROC_TYPE=i386
 endif
 
@@ -290,7 +276,6 @@ endif
 
 ifeq $(PROCTYPE) sparc
 UNOPKG_PLATFORM=Linux_SPARC
-JAVA_PROC_TYPE=sparc
 endif
 
 ifeq $(PROCTYPE) x86_64
@@ -351,7 +336,7 @@ endif
 CC_FLAGS_JNI=-c -fpic $(OPT_FLAGS)
 CC_FLAGS=-c -fpic -fvisibility=hidden $(OPT_FLAGS)
 
-ifeq $(PROCTYPE) ppc
+ifeq $(PROCTYPE) powerpc
 CC_FLAGS+=-fPIC
 endif
 
@@ -366,7 +351,7 @@ LIBO_SDK_LDFLAGS_STDLIBS =
 
 LIBRARY_LINK_FLAGS=-shared -Wl,-z,origin '-Wl,-rpath,$$ORIGIN'
 
-ifeq $(PROCTYPE) ppc
+ifeq $(PROCTYPE) powerpc
 LIBRARY_LINK_FLAGS+=-fPIC
 endif
 COMP_LINK_FLAGS=$(LIBRARY_LINK_FLAGS)
@@ -386,36 +371,37 @@ endif
 # MacOSX/Darwin specific settings
 #

Re: NOTE: Impress remote clients have been moved to their own repos

2014-01-31 Thread Norbert Thiebaud

On Fri, Jan 31, 2014 at 7:04 AM, Jan Holesovsky ke...@collabora.com wrote:
 Hi Norbert,

 Norbert Thiebaud píše v Čt 30. 01. 2014 v 19:00 -0600:
 Impress clients, ios/android/firefoxos

 have been moved out of core.git and into

 git://gerrit.libreoffice.org/impress_remote

 Thanks! - any chance to create a mirroring repo on freedesktop.org,
 please? :-)

I created mirror on gitHub and gitorious already
But I do not have the karma to create new repo on fdo

Once there is a libreoffice/impress_remote  I can easily configure
replication to it.
Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sfx2/source

 sfx2/source/control/thumbnailview.cxx |   20 +---
 1 file changed, 9 insertions(+), 11 deletions(-)

New commits:
commit 470b393fd593440f49f0c3c1e95ef7a41fac0bb5
Author: Jan Holesovsky ke...@collabora.com
Date:   Fri Jan 31 13:10:27 2014 +0100

Kill one indentation level.

Change-Id: I5a5d98bb2f2d0749fb9113423f5663780ecf3520

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index d55e4a1..dbe2f46 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -891,19 +891,17 @@ void ThumbnailView::Paint( const Rectangle aRect)
 
 void ThumbnailView::GetFocus()
 {
+// Select the first item if nothing selected
+int nSelected = -1;
+for (size_t i = 0, n = mItemList.size(); i  n  nSelected == -1; ++i)
 {
-// Select the first item if nothing selected
-int nSelected = -1;
-for (size_t i = 0, n = mItemList.size(); i  n  nSelected == -1; ++i)
-{
-if (mItemList[i]-isSelected())
-nSelected = i;
-}
+if (mItemList[i]-isSelected())
+nSelected = i;
+}
 
-if ( nSelected == -1  mItemList.size( )  0 )
-{
-SelectItem( 1 );
-}
+if (nSelected == -1  mItemList.size()  0)
+{
+SelectItem(1);
 }
 
 // Tell the accessible object that we got the focus.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl sfx2/source vcl/source

2014-01-31 Thread Zolnai Tamás

 include/vcl/window.hxx|3 +
 sfx2/source/control/thumbnailview.cxx |1 
 sfx2/source/dialog/backingwindow.cxx  |   55 +-
 sfx2/source/dialog/backingwindow.hxx  |2 +
 vcl/source/window/taskpanelist.cxx|   12 +++
 vcl/source/window/window.cxx  |   25 +--
 6 files changed, 80 insertions(+), 18 deletions(-)

New commits:
commit 5b1e68bd852cac4534c5ce2e548187dce1d4561a
Author: Zolnai TamÃ¡s tamas.zol...@collabora.com
Date:   Wed Jan 29 21:07:42 2014 +0100

fdo#71763: F6 key moves focus on this trip: Menu - Sidebar - Thumbnail 
view

Sidebar and thumbnail View are actually not separate windows
but F6 key traversal should simulate it as they would be.
Define a new getfocus flag called GETFOCUS_F6 which means focus
were grabed as a result of pressing F6 key. Use this and other two
(GETFOCUS_FORWARD, GETFOCUS_BACKWARD) flags to indicate the focus were
grabbed along subwindow relation (define a new ImplGrabFocusToDocument
method with a flag parameter on the analogy of GrabFocus() - 
ImplGrabFocus()).
Handle F6, Shift+F6 inside BackingWindow as it would have
two subwindow (sidebar and thumbnail view).
Plus Ctrl+F6 - grab focus to the thumbnail view.

Change-Id: Ie43d761e7cb0269afb79481a81947a4b96e1dde0
Reviewed-on: https://gerrit.libreoffice.org/7486
Reviewed-by: Jan Holesovsky ke...@collabora.com
Tested-by: Jan Holesovsky ke...@collabora.com

diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 32dccde..0a3cf45 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -253,6 +253,7 @@ typedef sal_uInt16 StateChangedType;
 #define GETFOCUS_TAB((sal_uInt16)0x0001)
 #define GETFOCUS_CURSOR ((sal_uInt16)0x0002)
 #define GETFOCUS_MNEMONIC   ((sal_uInt16)0x0004)
+#define GETFOCUS_F6 ((sal_uInt16)0x0008)
 #define GETFOCUS_FORWARD((sal_uInt16)0x0010)
 #define GETFOCUS_BACKWARD   ((sal_uInt16)0x0020)
 #define GETFOCUS_AROUND ((sal_uInt16)0x0040)
@@ -260,6 +261,7 @@ typedef sal_uInt16 StateChangedType;
 #define GETFOCUS_INIT   ((sal_uInt16)0x0200)
 #define GETFOCUS_FLOATWIN_POPUPMODEEND_CANCEL ((sal_uInt16)0x0400)
 
+
 // Draw-Flags fuer Draw()
 #define WINDOW_DRAW_MONO((sal_uLong)0x0001)
 #define WINDOW_DRAW_NOBORDER((sal_uLong)0x0002)
@@ -481,6 +483,7 @@ public:
 SAL_DLLPRIVATE voidImplCallMouseMove( sal_uInt16 nMouseCode, 
sal_Bool bModChanged = sal_False );
 SAL_DLLPRIVATE voidImplGenerateMouseMove();
 SAL_DLLPRIVATE voidImplGrabFocus( sal_uInt16 nFlags );
+SAL_DLLPRIVATE voidImplGrabFocusToDocument( sal_uInt16 nFlags );
 SAL_DLLPRIVATE voidImplInvertFocus( const Rectangle rRect );
 SAL_DLLPRIVATE voidImplControlFocus( sal_uInt16 nFlags = 0 );
 SAL_DLLPRIVATE Window* ImplGetDlgWindow( sal_uInt16 n, sal_uInt16 
nType, sal_uInt16 nStart = 0, sal_uInt16 nEnd = 0x, sal_uInt16* pIndex = 
NULL );
diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index eda19f0..d55e4a1 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -891,7 +891,6 @@ void ThumbnailView::Paint( const Rectangle aRect)
 
 void ThumbnailView::GetFocus()
 {
-if(GETFOCUS_TAB  GetGetFocusFlags())
 {
 // Select the first item if nothing selected
 int nSelected = -1;
diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index daa3d10..70605d8 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -308,6 +308,41 @@ void BackingWindow::Paint( const Rectangle )
 aDev );
 }
 
+bool BackingWindow::PreNotify( NotifyEvent rNEvt )
+{
+if( rNEvt.GetType() == EVENT_KEYINPUT )
+{
+const KeyEvent* pEvt = rNEvt.GetKeyEvent();
+const KeyCode rKeyCode(pEvt-GetKeyCode());
+// Subwindows of BackingWindow: Sidebar and Thumbnail view
+if( rKeyCode.GetCode() == KEY_F6 )
+{
+if( rKeyCode.IsShift() ) // Shift + F6
+{
+if( mpAllRecentThumbnails-HasFocus() )
+{
+mpOpenButton-GrabFocus();
+return true;
+}
+}
+else if ( rKeyCode.IsMod1() ) // Ctrl + F6
+{
+mpAllRecentThumbnails-GrabFocus();
+return true;
+}
+else // F6
+{
+if( mpAllButtonsBox-HasChildPathFocus() )
+{
+mpAllRecentThumbnails-GrabFocus();
+return true;
+}
+}
+}
+}
+return Window::PreNotify( rNEvt );
+}
+
 bool BackingWindow::Notify(

Cppcheck Same expression on both sides of '|' in PresenterPaneBorderManager.cxx (sdext)

2014-01-31 Thread julien2412

Hello,

Cppcheck reported this:
sdext/source/presenter/PresenterPaneBorderManager.cxx
171 duplicateExpression style   Same expression on both sides of '|'.
switch (nCode)
{
case mnOutside | mnOutside:--- Same expression on both sides of
'|'.
case mnOutside | mnLeft:

See
http://dev-builds.libreoffice.org/cppcheck_reports/master/733.html#line-171

I thought about putting this:
case mnOutside:
case mnOutside | mnLeft:

Is it ok or do I miss something?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-Same-expression-on-both-sides-of-in-PresenterPaneBorderManager-cxx-sdext-tp4094873.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: NOTE: Impress remote clients have been moved to their own repos

Hi Norbert,

Norbert Thiebaud píše v Čt 30. 01. 2014 v 19:00 -0600:
 Impress clients, ios/android/firefoxos
 
 have been moved out of core.git and into
 
 git://gerrit.libreoffice.org/impress_remote

Thanks! - any chance to create a mirroring repo on freedesktop.org,
please? :-)

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

 sc/source/core/data/table4.cxx |   50 ++---
 1 file changed, 32 insertions(+), 18 deletions(-)

New commits:
commit b74233d410b1d25c7fab3bf360dc61bf1f2c769c
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 11:49:44 2014 -0500

Slight optimization by avoiding to query for hidden state unnecessarily.

Also removing static_cast during the loop speeds it up just a bit.

Change-Id: I4644046c91da71f4b7305e9063a853d03c5921e0

diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 0755cd6..ca89428 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1261,19 +1261,24 @@ void ScTable::IncDate(double rVal, sal_uInt16 
nDayOfMonth, double nStep, FillD
 rVal = aDate - aNullDate;
 }
 
-namespace
-{
+namespace {
 
-bool HiddenRowColumn(sal_uLong nRowColumn, bool bVertical, ScTable* pTable)
+bool HiddenRowColumn(ScTable* pTable, SCCOLROW nRowColumn, bool bVertical, 
SCCOLROW rLastPos)
 {
+bool bHidden = false;
 if(bVertical)
 {
-return pTable-RowHidden(static_castSCROW(nRowColumn));
+SCROW nLast;
+bHidden = pTable-RowHidden(nRowColumn, NULL, nLast);
+rLastPos = nLast;
 }
 else
 {
-return pTable-ColHidden(static_castSCCOL(nRowColumn));
+SCCOL nLast;
+bHidden = pTable-ColHidden(static_castSCCOL(nRowColumn), NULL, 
nLast);
+rLastPos = nLast;
 }
+return bHidden;
 }
 
 }
@@ -1290,15 +1295,15 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2,
 bool bVertical = (eFillDir == FILL_TO_BOTTOM || eFillDir == FILL_TO_TOP);
 bool bPositive = (eFillDir == FILL_TO_BOTTOM || eFillDir == FILL_TO_RIGHT);
 
-sal_uLong nCol = 0;
-sal_uLong nRow = 0;
-sal_uLong rInner = bVertical ? nRow : nCol;// loop variables
-sal_uLong rOuter = bVertical ? nCol : nRow;
-sal_uLong nOStart;
-sal_uLong nOEnd;
-sal_uLong nIStart;
-sal_uLong nIEnd;
-sal_uLong nISource;
+SCCOLROW nCol = 0;
+SCCOLROW nRow = 0;
+SCCOLROW rInner = bVertical ? nRow : nCol;// loop variables
+SCCOLROW rOuter = bVertical ? nCol : nRow;
+SCCOLROW nOStart;
+SCCOLROW nOEnd;
+SCCOLROW nIStart;
+SCCOLROW nIEnd;
+SCCOLROW nISource;
 ScRange aFillRange;
 
 if (bVertical)
@@ -1346,8 +1351,8 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, SCCOL 
nCol2, SCROW nRow2,
 }
 }
 
-sal_uLong nIMin = nIStart;
-sal_uLong nIMax = nIEnd;
+SCCOLROW nIMin = nIStart;
+SCCOLROW nIMax = nIEnd;
 PutInOrder(nIMin,nIMax);
 sal_uInt16 nDel = bAttribs ? IDF_AUTOFILL : (IDF_AUTOFILL  IDF_CONTENTS);
 
@@ -1444,12 +1449,18 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2,
 
 if (eFillCmd == FILL_SIMPLE)// copy
 {
+bool bHidden = false;
+SCCOLROW nHiddenValid = -1;
+
 if (eCellType == CELLTYPE_FORMULA)
 {
 bool bFirst = true;
 for (rInner = nIMin; rInner = nIMax; rInner++)
 {
-if(HiddenRowColumn(rInner, bVertical, this))
+if (rInner  nHiddenValid)
+bHidden = HiddenRowColumn(this, rInner, bVertical, 
nHiddenValid);
+
+if (bHidden)
 continue;
 sal_uLong nInd = nActFormCnt;
 FillFormula(nInd, bFirst, aSrcCell.mpFormula,
@@ -1463,7 +1474,10 @@ void ScTable::FillSeries( SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2,
 {
 for (rInner = nIMin; rInner = nIMax; rInner++)
 {
-if(HiddenRowColumn(rInner, bVertical, this))
+if (rInner  nHiddenValid)
+bHidden = HiddenRowColumn(this, rInner, bVertical, 
nHiddenValid);
+
+if (bHidden)
 continue;
 ScAddress aDestPos( static_castSCCOL(nCol), 
static_castSCROW(nRow), nTab );
 aSrcCell.commit(aCol[nCol], aDestPos.Row());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

2014-01-31 Thread Andrzej Hunt

 compilerplugins/clang/compat.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b8ca3737fbdf51038f80db89048ee00db4ba26b4
Author: Andrzej Hunt andrzej.h...@collabora.com
Date:   Fri Jan 31 15:23:51 2014 +

DiagnosticsEngine::getCustomDiagID isn't const, so don't pass in const 
engine.

Change-Id: I7e4494b7f1cb62ab27851e34ab4dc6be8e04e1fa
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 75e46ef..4c8c333 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -46,7 +46,7 @@ inline clang::QualType getParamType(
 }
 
 inline unsigned getCustomDiagID(
-clang::DiagnosticsEngine const  engine, clang::DiagnosticsEngine::Level L,
+clang::DiagnosticsEngine  engine, clang::DiagnosticsEngine::Level L,
 llvm::StringRef FormatString)
 {
 #if (__clang_major__ == 3  __clang_minor__ = 5) || __clang_major__  3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - chart2/opengl chart2/source

2014-01-31 Thread Markus Mohrhard

 chart2/opengl/backgroundFragmentShader.glsl |   11 +++
 chart2/opengl/backgroundVertexShader.glsl   |   11 +++
 chart2/opengl/commonFragmentShader.glsl |   11 +++
 chart2/opengl/commonVertexShader.glsl   |   11 +++
 chart2/opengl/debugFragmentShader.glsl  |   10 ++
 chart2/opengl/debugVertexShader.glsl|   10 ++
 chart2/opengl/renderFragmentShader.glsl |   11 +++
 chart2/opengl/renderVertexShader.glsl   |   11 +++
 chart2/opengl/symbolFragmentShader.glsl |   11 +++
 chart2/opengl/symbolVertexShader.glsl   |   11 +++
 chart2/opengl/textFragmentShader.glsl   |   11 +++
 chart2/opengl/textVertexShader.glsl |   11 +++
 chart2/source/view/main/OpenGLRender.cxx|9 +
 13 files changed, 135 insertions(+), 4 deletions(-)

New commits:
commit fb982d1fcaefe76f4e71a17b88e887a1d38dabdc
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Jan 31 19:23:54 2014 +0100

add license headers to glsl files

Change-Id: Ib473d7bbb39f50f5fea549e69dcac0e938a1700a

diff --git a/chart2/opengl/backgroundFragmentShader.glsl 
b/chart2/opengl/backgroundFragmentShader.glsl
index e772587..805789e 100644
--- a/chart2/opengl/backgroundFragmentShader.glsl
+++ b/chart2/opengl/backgroundFragmentShader.glsl
@@ -1,6 +1,17 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 varying vec4 fragmentColor;
 
 void main()
 {
 gl_FragColor = fragmentColor;
 }
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/opengl/backgroundVertexShader.glsl 
b/chart2/opengl/backgroundVertexShader.glsl
index 2a3a341..6d9d6c2 100644
--- a/chart2/opengl/backgroundVertexShader.glsl
+++ b/chart2/opengl/backgroundVertexShader.glsl
@@ -1,3 +1,12 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 attribute vec3 vPosition;
 uniform mat4 MVP;
 attribute vec4 vColor;
@@ -8,3 +17,5 @@ void main()
 gl_Position =  MVP * vec4(vPosition, 1);
 fragmentColor = vColor;
 }
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/opengl/commonFragmentShader.glsl 
b/chart2/opengl/commonFragmentShader.glsl
index e772587..805789e 100644
--- a/chart2/opengl/commonFragmentShader.glsl
+++ b/chart2/opengl/commonFragmentShader.glsl
@@ -1,6 +1,17 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 varying vec4 fragmentColor;
 
 void main()
 {
 gl_FragColor = fragmentColor;
 }
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/opengl/commonVertexShader.glsl 
b/chart2/opengl/commonVertexShader.glsl
index 862a35b..f32e3fd 100644
--- a/chart2/opengl/commonVertexShader.glsl
+++ b/chart2/opengl/commonVertexShader.glsl
@@ -1,3 +1,12 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 attribute vec3 vPosition;
 uniform mat4 MVP;
 uniform vec4 vColor;
@@ -8,3 +17,5 @@ void main()
 gl_Position =  MVP * vec4(vPosition, 1);
 fragmentColor = vColor;
 }
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/opengl/debugFragmentShader.glsl 
b/chart2/opengl/debugFragmentShader.glsl
index ce7f863..d36c4f4 100644
--- a/chart2/opengl/debugFragmentShader.glsl
+++ b/chart2/opengl/debugFragmentShader.glsl
@@ -1,3 +1,12 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
 varying vec4 fragmentColor;
 
 void main()
@@ -5,3 +14,4 @@ void main()
 gl_FragColor = vec4(1.0, 1.0, 0.0, 0.5);
 }
 
+/* vim:set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-commits] core.git: 5 commits - chart2/opengl chart2/source oox/source

2014-01-31 Thread Markus Mohrhard

 chart2/opengl/symbolFragmentShader.glsl  |2 +-
 chart2/opengl/symbolVertexShader.glsl|2 +-
 chart2/source/view/main/DummyXShape.cxx  |5 ++---
 chart2/source/view/main/OpenGLRender.cxx |   30 --
 oox/source/shape/ShapeContextHandler.cxx |7 ---
 5 files changed, 28 insertions(+), 18 deletions(-)

New commits:
commit 9aa225f0cb980d81bf0fdcc91dede3c7a3bdf99f
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Jan 31 13:55:57 2014 +0100

better OpenGL debug output

Change-Id: I90a3883c0bbead0de02c8d4096eccecc59f1b0e3

diff --git a/chart2/source/view/main/OpenGLRender.cxx 
b/chart2/source/view/main/OpenGLRender.cxx
index 1e401dc..da99f81 100755
--- a/chart2/source/view/main/OpenGLRender.cxx
+++ b/chart2/source/view/main/OpenGLRender.cxx
@@ -364,11 +364,15 @@ int OpenGLRender::InitOpenGL(GLWindow aWindow)
 glGenBuffers(1, m_VertexBuffer);
 glGenBuffers(1, m_ColorBuffer);
 
+CHECK_GL_ERROR();
+
 m_RenderProID = LoadShaders(renderVertexShader, renderFragmentShader);
 m_RenderVertexID = glGetAttribLocation(m_RenderProID, vPosition);
 m_RenderTexCoordID = glGetAttribLocation(m_RenderProID, texCoord);
 m_RenderTexID = glGetUniformLocation(m_RenderProID, RenderTex);
 
+CHECK_GL_ERROR();
+
 m_CommonProID = LoadShaders(commonVertexShader, commonFragmentShader);
 m_MatrixID = glGetUniformLocation(m_CommonProID, MVP);
 m_2DVertexID = glGetAttribLocation(m_CommonProID, vPosition);
@@ -378,19 +382,23 @@ int OpenGLRender::InitOpenGL(GLWindow aWindow)
 #if DEBUG_POSITIONING
 m_DebugProID = LoadShaders(debugVertexShader, debugFragmentShader);
 m_DebugVertexID = glGetAttribLocation(m_DebugProID, vPosition);
-#endif
 CHECK_GL_ERROR();
+#endif
 
 m_BackgroundProID = LoadShaders(backgroundVertexShader, 
backgroundFragmentShader);
 m_BackgroundMatrixID = glGetUniformLocation(m_BackgroundProID, MVP);
 m_BackgroundVertexID = glGetAttribLocation(m_BackgroundProID, vPosition);
 m_BackgroundColorID = glGetAttribLocation(m_BackgroundProID, vColor);
 
+CHECK_GL_ERROR();
+
 m_SymbolProID = LoadShaders(symbolVertexShader, symbolFragmentShader);
 m_SymbolVertexID = glGetAttribLocation(m_SymbolProID, vPosition);
 m_SymbolMatrixID = glGetAttribLocation(m_SymbolProID, MVP);
 m_SymbolColorID = glGetAttribLocation(m_SymbolProID, vColor);
 
+CHECK_GL_ERROR();
+
 m_TextProID = LoadShaders(textVertexShader, textFragmentShader);
 m_TextMatrixID = glGetUniformLocation(m_TextProID, MVP);
 m_TextVertexID = glGetAttribLocation(m_TextProID, vPosition);
@@ -1734,6 +1742,7 @@ int OpenGLRender::RenderSymbol2DShape(float x, float y, 
float width, float heigh
 glDisable(GL_POINT_SMOOTH);
 glDisable(GL_MULTISAMPLE);
 glPointSize(10.f);
+CHECK_GL_ERROR();
 PosVecf3 trans = {x/OPENGL_SCALE_VALUE, y/OPENGL_SCALE_VALUE, m_fZStep};
 PosVecf3 angle = {0.0f, 0.0f, 0.0f};
 PosVecf3 scale = {width/OPENGL_SCALE_VALUE, height/OPENGL_SCALE_VALUE, 
1.0f};
@@ -1744,12 +1753,11 @@ int OpenGLRender::RenderSymbol2DShape(float x, float y, 
float width, float heigh
 //fill vertex buffer
 glBindBuffer(GL_ARRAY_BUFFER, m_VertexBuffer);
 glBufferData(GL_ARRAY_BUFFER, 3 * sizeof(float), aPos, GL_STATIC_DRAW);
+CHECK_GL_ERROR();
 
 // Use our shader
 glUseProgram(m_SymbolProID);
-
 glUniform4fv(m_SymbolColorID, 1, m_2DColor[0]);
-
 glUniformMatrix4fv(m_SymbolMatrixID, 1, GL_FALSE, m_MVP[0][0]);
 
 // 1rst attribute buffer : vertices
@@ -1769,9 +1777,9 @@ int OpenGLRender::RenderSymbol2DShape(float x, float y, 
float width, float heigh
 glUseProgram(0);
 glEnable(GL_MULTISAMPLE);
 glEnable(GL_POINT_SMOOTH);
-CHECK_GL_ERROR();
 m_fZStep += Z_STEP;
 
+CHECK_GL_ERROR();
 return 0;
 }
 
commit 9741870c3e149befcee34fe01d12e3e7ab6670f2
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Jan 31 13:54:59 2014 +0100

extract the Z_STEP value into a define

Change-Id: I38ccce4c35f6cdaa2df0dfc250fcea72a8b79049

diff --git a/chart2/source/view/main/OpenGLRender.cxx 
b/chart2/source/view/main/OpenGLRender.cxx
index 474a125..1e401dc 100755
--- a/chart2/source/view/main/OpenGLRender.cxx
+++ b/chart2/source/view/main/OpenGLRender.cxx
@@ -62,6 +62,8 @@ using namespace std;
 #define WGL_SAMPLES_ARB  0x2042
 #endif
 
+#define Z_STEP 0.001;
+
 // end shaders
 
 static GLfloat squareVertices[] = {
@@ -497,7 +499,7 @@ int OpenGLRender::SetLine2DShapePoint(float x, float y, int 
listLength)
 
 int OpenGLRender::RenderLine2FBO(int)
 {
-m_fZStep += 0.001f;
+m_fZStep += Z_STEP;
 CHECK_GL_ERROR();
 glLineWidth(m_fLineWidth);
 size_t listNum = m_Line2DShapePointList.size();
@@ -1276,7 +1278,7 @@ int OpenGLRender::RectangleShapePoint(float x, float y, 
float directionX, float
 
 int OpenGLRender::RenderRectangleShape(bool bBorder, bool bFill)
 {
-m_fZStep += 0.001f;
+m_fZStep

[Libreoffice-commits] core.git: compilerplugins/clang

2014-01-31 Thread Jesús Corrius

 compilerplugins/clang/compat.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 82300f367dda20e3e83477dae9dd37124ac9831b
Author: JesÃºs Corrius jcorr...@gmail.com
Date:   Fri Jan 31 10:31:30 2014 +0100

sbergman's typo

Change-Id: I36dc29659d0d6965c28e5fe0bb03759476de4781

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index d4d92a0..75e46ef 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -16,7 +16,7 @@
 #include clang/Basic/DiagnosticIDs.h
 #include llvm/ADT/StringRef.h
 
-// Compatibility wrapper to abstract over (trivial) chanes in the Clang API:
+// Compatibility wrapper to abstract over (trivial) changes in the Clang API:
 namespace compat {
 
 inline clang::QualType getReturnType(clang::FunctionDecl const  decl) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Sketches and diagrams in open source software development

On Thu, 2014-01-30 at 23:09 +0100, Sebastian Baltes wrote:

 I write to this mailing list to ask for hints on where to find sketches
 and diagrams related to the development of LibreOffice (maybe your
 version control system, bug tracking system, or wiki?).

I use and maintain this class diagram

http://kohei.us/libreoffice/

which I manually edit whenever I explore the code base.  But because
this is a very laborious process and I don't see anyone else wanting to
go this far, I'm probably an exception rather than the rule.

I do this partly because the process of drawing a diagram itself helps
me organize my thought on the code base. So, to me the process of
building the diagram is as important as the diagram itself.

Kohei


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - sw/source

2014-01-31 Thread Armin Le Grand

 sw/source/core/doc/docnew.cxx |   20 +++-
 1 file changed, 19 insertions(+), 1 deletion(-)

New commits:
commit 059b53d8ae713be9c3db2348176e74e39586
Author: Armin Le Grand a...@apache.org
Date:   Fri Jan 31 17:42:41 2014 +

i123914 Use an own hold on the newly created SwDoc when a call to 
SetTmpDocShell(NULL) is needed

diff --git a/sw/source/core/doc/docnew.cxx b/sw/source/core/doc/docnew.cxx
index 7682e58..ab3bd93 100644
--- a/sw/source/core/doc/docnew.cxx
+++ b/sw/source/core/doc/docnew.cxx
@@ -1202,7 +1202,25 @@ SfxObjectShell* SwDoc::CreateCopy(bool bCallInitNew ) 
const
 pRet-Paste( *this );
 
 // remove the temporary shell if it is there as it was done before
-pRet-SetTmpDocShell( (SfxObjectShell*)NULL );
+if(pRet-GetTmpDocShell())
+{
+// #123914# If we get here, SwOLENode::MakeCopy had to create a 
temporary
+// SwDocShell to have a SvPersist as a target for the OLE data to be 
copied.
+// It is reset by a call to SetTmpDocShell(NULL), but in this case here
+// there is no other ref holder to the just cloned SwDoc. Thus - to 
prevent
+// it's immediate deletion - it is required to hold a fercunt to it 
during
+// the SetTmpDocShell call. This can be done with an instance of a 
class
+// holding a SwDoc, but most simple using acquire/release on the SwDoc
+// (as long as these are public, I was surprised. Also probably not
+// guaranteed for the future is that the release call does not delete 
the
+// SwDoc it gets called at, but currently works like this).
+pRet-acquire();
+pRet-SetTmpDocShell((SfxObjectShell*)NULL);
+pRet-release();
+}
+
+// remove the temporary shell if it is there as it was done before
+// pRet-SetTmpDocShell( (SfxObjectShell*)NULL );
 
 return pRetShell;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Keyboard navigation in StartCenter and Template Manager

2014-01-31 Thread V Stuart Foote

@Kendy, @Zolnai

Thanks for the work on the backingwindow.cxx and thumbnailview.cxx keyboard
navigation to resolve fdo#71763 and fdo#71764. Will test the F6 navigation
as the next TB builds of master roll around.

Since you've already gotten so far into the key board navigation might I be
able to encourage you to tackle two of the remaining keyboard annoyances
with Thumbnail views in both SC and TM.

The major one is fdo#72287 (
https://bugs.freedesktop.org/show_bug.cgi?id=72287 ) -- 'unable to scroll
thumbnail view list with keyboard only for selecting available
templates/documents in the thumbnail views'.

The other, which may actually be more involved, is purely an accessibility
issue affecting the thumbnail list items in the template manager that are
only available with mouse movements. fdo#73766 (
https://bugs.freedesktop.org/show_bug.cgi?id=73766 ) --'thumbnail view can
not navigate with keyboard onto attribute menubar of each template thumbnail
object'.But as an aside, would think that if you can get this working
correctly--the code to expose 'attributes' of the templates might also be
useful to expose 'attributes' of document thumbnails on StartCenter? Just a
thought.

Stuart

--
View this message in context:
http://nabble.documentfoundation.org/Keyboard-navigation-in-StartCenter-and-Template-Manager-tp4094878.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source

 sc/inc/column.hxx   |5 +
 sc/inc/table.hxx|8 +
 sc/source/core/data/column4.cxx |  112 ++-
 sc/source/core/data/table4.cxx  |  161 +---
 4 files changed, 206 insertions(+), 80 deletions(-)

New commits:
commit 571070074671bd0102422dd8a0ac1c3be6358f80
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 15:44:00 2014 -0500

Speed up simple fill of formula cells. Vertical direction only.

Other cells could be optimized in a similar fashion, but they aren't
that slow even with the current code.

Change-Id: I0b71bf271fab68c9fba0b39463dfe3ef46dacfb0

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 69ba1af..7fefa04 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -57,6 +57,7 @@ class EditTextIterator;
 struct NoteEntry;
 class DocumentStreamAccess;
 class CellValues;
+struct RowSpan;
 
 }
 
@@ -218,6 +219,8 @@ public:
 voidDeleteRow( SCROW nStartRow, SCSIZE nSize );
 void DeleteArea(
 SCROW nStartRow, SCROW nEndRow, sal_uInt16 nDelFlag, bool bBroadcast = 
true );
+void DeleteRanges( const std::vectorsc::RowSpan rRanges, sal_uInt16 
nDelFlag, bool bBroadcast );
+
 void CopyToClip(
 sc::CopyToClipContext rCxt, SCROW nRow1, SCROW nRow2, ScColumn 
rColumn ) const;
 void CopyStaticToDocument(SCROW nRow1, SCROW nRow2, ScColumn rDestCol);
@@ -289,6 +292,8 @@ public:
 ScFormulaCell* SetFormulaCell( SCROW nRow, ScFormulaCell* pCell );
 ScFormulaCell* SetFormulaCell( sc::ColumnBlockPosition rBlockPos, SCROW 
nRow, ScFormulaCell* pCell );
 
+void CloneFormulaCell( const ScFormulaCell rSrc, const 
std::vectorsc::RowSpan rRanges );
+
 svl::SharedString GetSharedString( SCROW nRow ) const;
 
 void SetRawString( SCROW nRow, const OUString rStr, bool bBroadcast = 
true );
diff --git a/sc/source/core/data/column4.cxx b/sc/source/core/data/column4.cxx
index 661c38d..7a5998c 100644
--- a/sc/source/core/data/column4.cxx
+++ b/sc/source/core/data/column4.cxx
@@ -14,6 +14,8 @@
 #include attarray.hxx
 #include document.hxx
 #include cellvalues.hxx
+#include columnspanset.hxx
+#include listenercontext.hxx
 
 #include svl/sharedstring.hxx
 
@@ -49,6 +51,8 @@ void ScColumn::CopyOneCellFromClip( sc::CopyFromClipContext 
rCxt, SCROW nRow1,
 
 if ((nFlags  IDF_CONTENTS) != 0)
 {
+std::vectorsc::CellTextAttr aTextAttrs(nDestSize);
+
 switch (rSrcCell.meType)
 {
 case CELLTYPE_VALUE:
@@ -56,13 +60,18 @@ void ScColumn::CopyOneCellFromClip( 
sc::CopyFromClipContext rCxt, SCROW nRow1,
 std::vectordouble aVals(nDestSize, rSrcCell.mfValue);
 pBlockPos-miCellPos =
 maCells.set(pBlockPos-miCellPos, nRow1, aVals.begin(), 
aVals.end());
+pBlockPos-miCellTextAttrPos =
+maCellTextAttrs.set(pBlockPos-miCellTextAttrPos, nRow1, 
aTextAttrs.begin(), aTextAttrs.end());
 CellStorageModified();
 }
 break;
 case CELLTYPE_STRING:
 {
 std::vectorsvl::SharedString aStrs(nDestSize, 
*rSrcCell.mpString);
-maCells.set(pBlockPos-miCellPos, nRow1, aStrs.begin(), 
aStrs.end());
+pBlockPos-miCellPos =
+maCells.set(pBlockPos-miCellPos, nRow1, aStrs.begin(), 
aStrs.end());
+pBlockPos-miCellTextAttrPos =
+maCellTextAttrs.set(pBlockPos-miCellTextAttrPos, nRow1, 
aTextAttrs.begin(), aTextAttrs.end());
 CellStorageModified();
 }
 break;
@@ -75,46 +84,17 @@ void ScColumn::CopyOneCellFromClip( 
sc::CopyFromClipContext rCxt, SCROW nRow1,
 
 pBlockPos-miCellPos =
 maCells.set(pBlockPos-miCellPos, nRow1, aStrs.begin(), 
aStrs.end());
+pBlockPos-miCellTextAttrPos =
+maCellTextAttrs.set(pBlockPos-miCellTextAttrPos, nRow1, 
aTextAttrs.begin(), aTextAttrs.end());
 CellStorageModified();
 }
 break;
 case CELLTYPE_FORMULA:
 {
-std::vectorScFormulaCell* aFormulas;
-ScAddress aPos(nCol, nRow1, nTab);
-aFormulas.reserve(nDestSize);
-ScFormulaCellGroupRef xGroup(new ScFormulaCellGroup);
-xGroup-setCode(*rSrcCell.mpFormula-GetCode());
-xGroup-compileCode(*pDocument, aPos, pDocument-GetGrammar());
-for (size_t i = 0; i  nDestSize; ++i)
-{
-ScFormulaCell* pCell = new ScFormulaCell(pDocument, aPos, 
xGroup);
-if (i == 0)
-{
-xGroup-mpTopCell = pCell;
-xGroup-mnLength = nDestSize;
-}
-aFormulas.push_back(pCell);
-

[Libreoffice-commits] help.git: 2 commits - helpers/help_hid.lst source/text

 helpers/help_hid.lst   |2 --
 source/text/shared/02/2401.xhp |   13 ++---
 2 files changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 8d10ad8bf909f3624f57065f4950fe0e2e171b2b
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jan 31 17:34:54 2014 +

update help ids for solarize dialog .ui conversion

Change-Id: I84eab47f565dd04fd99a8a8062a88eac57173cb3

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 07fedf1..a48d859 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -6242,7 +6242,6 @@ 
svx_CheckBox_RID_SVXTABPAGE_GALLERYTHEME_FILES_CBX_PREVIEW,706675715,
 svx_CheckBox_RID_SVX_FONT_SUBSTITUTION_CB_NONPROP,701006873,
 svx_CheckBox_RID_SVX_FONT_SUBSTITUTION_CB_USETABLE,701006869,
 
svx_CheckBox_RID_SVX_GRFFILTER_DLG_MOSAIC_DLG_FILTERMOSAIC_CBX_EDGES,1243022341,
-svx_CheckBox_RID_SVX_GRFFILTER_DLG_SOLARIZE_DLG_FILTERSOLARIZE_CBX_INVERT,1243038723,
 svx_CheckBox_RID_SVX_MDLG_HANGULHANJA_CB_HANGUL_ONLY,1237599234,
 svx_CheckBox_RID_SVX_MDLG_HANGULHANJA_CB_HANJA_ONLY,1237599235,
 svx_CheckBox_RID_SVX_MDLG_HANGULHANJA_CB_REPLACE_BY_CHARACTER,1237599233,
@@ -6514,7 +6513,6 @@ 
svx_MetricField_RID_SVXPAGE_STD_PARAGRAPH_ED_TOPDIST,700815893,
 
svx_MetricField_RID_SVX_GRFFILTER_DLG_MOSAIC_DLG_FILTERMOSAIC_MTR_HEIGHT,1243027972,
 
svx_MetricField_RID_SVX_GRFFILTER_DLG_MOSAIC_DLG_FILTERMOSAIC_MTR_WIDTH,1243027970,
 
svx_MetricField_RID_SVX_GRFFILTER_DLG_SEPIA_DLG_FILTERSEPIA_MTR_SEPIA,1243060738,
-svx_MetricField_RID_SVX_GRFFILTER_DLG_SOLARIZE_DLG_FILTERSOLARIZE_MTR_THRESHOLD,1243044354,
 svx_ModalDialog_DLG_CHINESEDICTIONARY,1078673408,
 svx_ModalDialog_DLG_CHINESETRANSLATION,1078657024,
 svx_ModalDialog_DLG_DOCUMENTLINK,1346109440,
diff --git a/source/text/shared/02/2401.xhp 
b/source/text/shared/02/2401.xhp
index 3152893..3294cd3 100644
--- a/source/text/shared/02/2401.xhp
+++ b/source/text/shared/02/2401.xhp
@@ -124,7 +124,7 @@
 /table
 
 bookmark xml-lang=en-US branch=hid/.uno:GraphicFilterSolarize 
id=bm_id6035997 localize=false/
-bookmark xml-lang=en-US branch=hid/.uno:GraphicFilterSolarize 
id=bm_id3154910 localize=false/
+bookmark xml-lang=en-US branch=hid/cui/ui/solarizedialog/SolarizeDialog 
id=bm_id3154910 localize=false/
 paragraph role=heading id=hd_id3144760 xml-lang=en-US level=2 
l10n=CSolarization/paragraph
 paragraph role=paragraph id=par_id3159150 xml-lang=en-US l10n=U 
oldref=74ahelp hid=.uno:GraphicFilterSolarizeOpens a dialog for defining 
solarization. Solarization refers to an effect that looks like what can happen 
when there is too much light during photo development. The colors become partly 
inverted./ahelp/paragraph
 table id=tbl_id3143231
@@ -142,12 +142,12 @@
 
 paragraph role=heading id=hd_id3145785 xml-lang=en-US level=3 
l10n=U oldref=76Parameters/paragraph
 paragraph role=paragraph id=par_id3147352 xml-lang=en-US l10n=U 
oldref=77Specifies the degree and type of solarization./paragraph
-bookmark xml-lang=en-US 
branch=hid/cui:MetricField:RID_SVX_GRFFILTER_DLG_SOLARIZE:DLG_FILTERSOLARIZE_MTR_THRESHOLD
 id=bm_id3151353 localize=false/
+bookmark xml-lang=en-US branch=hid/cui/ui/solarizedialog/value 
id=bm_id3151353 localize=false/
 paragraph role=heading id=hd_id3153370 xml-lang=en-US level=3 
l10n=U oldref=78Threshold Value/paragraph
-paragraph role=paragraph id=par_id3083443 xml-lang=en-US l10n=U 
oldref=79ahelp 
hid=SVX_METRICFIELD_RID_SVX_GRFFILTER_DLG_SOLARIZE_DLG_FILTERSOLARIZE_MTR_THRESHOLDSpecifies
 the degree of brightness, in percent, above which the pixels are to be 
solarized./ahelp/paragraph
-bookmark xml-lang=en-US 
branch=hid/cui:CheckBox:RID_SVX_GRFFILTER_DLG_SOLARIZE:DLG_FILTERSOLARIZE_CBX_INVERT
 id=bm_id3147318 localize=false/
+paragraph role=paragraph id=par_id3083443 xml-lang=en-US l10n=U 
oldref=79ahelp hid=cui/ui/solarizedialog/valueSpecifies the degree of 
brightness, in percent, above which the pixels are to be 
solarized./ahelp/paragraph
+bookmark xml-lang=en-US branch=hid/cui/ui/solarizedialog/invert 
id=bm_id3147318 localize=false/
 paragraph role=heading id=hd_id3152596 xml-lang=en-US level=3 
l10n=U oldref=80Invert/paragraph
-paragraph role=paragraph id=par_id3146921 xml-lang=en-US l10n=CHG 
oldref=81ahelp 
hid=SVX_CHECKBOX_RID_SVX_GRFFILTER_DLG_SOLARIZE_DLG_FILTERSOLARIZE_CBX_INVERTSpecifies
 to also invert all pixels./ahelp/paragraph
+paragraph role=paragraph id=par_id3146921 xml-lang=en-US l10n=CHG 
oldref=81ahelp hid=cui/ui/solarizedialog/invertSpecifies to also invert 
all pixels./ahelp/paragraph
 bookmark xml-lang=en-US branch=hid/.uno:GraphicFilterSepia 
id=bm_id2629364 localize=false/
 bookmark xml-lang=en-US branch=hid/.uno:GraphicFilterSepia 
id=bm_id3150105 localize=false/
 paragraph role=heading id=hd_id3150875 xml-lang=en-US level=2 
l10n=CAging/paragraph
commit 30251cd7cf62d765ef6b8d75a712a5b3191c552e
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jan 31 16:25:26 2014 +

update help ids for smooth dialog .ui conversion

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 48e14ccf97609a62711fd102266e35468fba2230
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jan 31 17:34:54 2014 +

Updated core
Project: help  8d10ad8bf909f3624f57065f4950fe0e2e171b2b

diff --git a/helpcontent2 b/helpcontent2
index 0d1ddfe..8d10ad8 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0d1ddfecb49e14b4e047e4a53e1d20629c1d192a
+Subproject commit 8d10ad8bf909f3624f57065f4950fe0e2e171b2b
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/win

2014-01-31 Thread Armin Le Grand

 vcl/win/source/gdi/salgdi.cxx |   18 +++---
 1 file changed, 15 insertions(+), 3 deletions(-)

New commits:
commit 9b677819a703208a650c08186546b11f0a535fd2
Author: Armin Le Grand a...@apache.org
Date:   Thu Jan 30 21:34:57 2014 +

Resolves: #i12355# Corrected case that...

in WinSalGraphics::setClipRegion an empty Polygon is handed over

(cherry picked from commit 9957d5854dcc65db37f0631c19e3421df1311089)

Change-Id: Id19a708d228d205bb1e14664c04af6eef179a5d4

diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 591909f..8402316 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -1003,13 +1003,19 @@ bool WinSalGraphics::setClipRegion( const Region 
i_rClip )
 }
 
 // create clip region from ClipRgnData
-if ( mpClipRgnData-rdh.nCount == 1 )
+if(0 == mpClipRgnData-rdh.nCount)
+{
+// #i123585# region is empty; this may happen when e.g. a 
PolyPolygon is given
+// that contains no polygons or only empty ones (no width/height). 
This is
+// perfectly fine and we are done, except setting it (see end of 
method)
+}
+else if(1 == mpClipRgnData-rdh.nCount)
 {
 RECT* pRect = (mpClipRgnData-rdh.rcBound);
 mhRegion = CreateRectRgn( pRect-left, pRect-top,
  pRect-right, 
pRect-bottom );
 }
-else if( mpClipRgnData-rdh.nCount  1 )
+else if(mpClipRgnData-rdh.nCount  1)
 {
 sal_uLong nSize = 
mpClipRgnData-rdh.nRgnSize+sizeof(RGNDATAHEADER);
 mhRegion = ExtCreateRegion( NULL, nSize, mpClipRgnData );
@@ -1049,8 +1055,14 @@ bool WinSalGraphics::setClipRegion( const Region 
i_rClip )
 //
 //bool bBla = true;
 }
+else
+{
+// #i123585# See above, this is a valid case, execute it
+SelectClipRgn( getHDC(), 0 );
+}
 
-return mhRegion != 0;
+// #i123585# retval no longer dependent of mhRegion, see TaskId comments 
above
+return true;
 }
 
 // ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 99/57d5854dcc65db37f0631c19e3421df1311089

 99/57d5854dcc65db37f0631c19e3421df1311089 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 997c70773775bde3b2900aab75313f1f302cf4f0
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jan 31 21:28:39 2014 +

Notes added by 'git notes add'

diff --git a/99/57d5854dcc65db37f0631c19e3421df1311089 
b/99/57d5854dcc65db37f0631c19e3421df1311089
new file mode 100644
index 000..e26c675
--- /dev/null
+++ b/99/57d5854dcc65db37f0631c19e3421df1311089
@@ -0,0 +1 @@
+merged as: 9b677819a703208a650c08186546b11f0a535fd2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 05/9b53d8ae713be9c3db23481768888e74e39586

 05/9b53d8ae713be9c3db2348176e74e39586 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 1b08d26778f3c1f72cf00f0a4d622c3c3b089d1e
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Fri Jan 31 21:37:09 2014 +

Notes added by 'git notes add'

diff --git a/05/9b53d8ae713be9c3db2348176e74e39586 
b/05/9b53d8ae713be9c3db2348176e74e39586
new file mode 100644
index 000..0001538
--- /dev/null
+++ b/05/9b53d8ae713be9c3db2348176e74e39586
@@ -0,0 +1 @@
+prefer: 190ee22a5161626b61a953556c5888e330e143b6
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] fdo#43157: Clean up OSL_ASSERT, DBG_ASSERT, etc.

2014-01-31 Thread Tim Markle

Here is a small contribution I tried for one of the easy hacks.

This code is contributed under the LGPLv3+ / MPL.
From 67b3b38717f788931c7acf44dd7b75d85a3fb713 Mon Sep 17 00:00:00 2001
From: Timothy Markle tmark...@gmail.com
Date: Fri, 31 Jan 2014 21:17:10 +0100
Subject: [PATCH] fdo#43157 - Clean up OSL_ASSERT

Changed OSL_ASSERT to SAL_WARN_IF

Change-Id: I6f81a265aefe769e1449b1f10c796bf3aa1d0f1c
---
 cppu/source/UnsafeBridge/UnsafeBridge.cxx | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/cppu/source/UnsafeBridge/UnsafeBridge.cxx b/cppu/source/UnsafeBridge/UnsafeBridge.cxx
index d653a1a..3f3c240 100644
--- a/cppu/source/UnsafeBridge/UnsafeBridge.cxx
+++ b/cppu/source/UnsafeBridge/UnsafeBridge.cxx
@@ -71,7 +71,7 @@ UnsafeBridge::~UnsafeBridge(void)
 {
 LOG_LIFECYCLE_UnsafeBridge_emit(fprintf(stderr, LIFE: %s - %p\n, UnsafeBridge::~UnsafeBridge(void), this));
 
-OSL_ASSERT(m_count = 0);
+SAL_WARN_IF(m_count  0, cppu.unsafebridge, m_count is less than 0);
 }
 
 void UnsafeBridge::v_callInto_v(uno_EnvCallee * pCallee, va_list * pParam)
@@ -83,7 +83,7 @@ void UnsafeBridge::v_callInto_v(uno_EnvCallee * pCallee, va_list * pParam)
 
 void UnsafeBridge::v_callOut_v(uno_EnvCallee * pCallee, va_list * pParam)
 {
-OSL_ASSERT(m_count  0);
+SAL_WARN_IF(m_count = 0, cppu.unsafebridge, m_count is less than or equal to 0);
 
 -- m_count;
 pCallee(pParam);
@@ -97,7 +97,7 @@ void UnsafeBridge::v_enter(void)
 {
 m_mutex.acquire();
 
-OSL_ASSERT(m_count = 0);
+SAL_WARN_IF(m_count  0, cppu.unsafebridge, m_count is less than 0);
 
 if (m_count == 0)
 m_threadId = osl::Thread::getCurrentIdentifier();
@@ -107,7 +107,7 @@ void UnsafeBridge::v_enter(void)
 
 void UnsafeBridge::v_leave(void)
 {
-OSL_ASSERT(m_count  0);
+SAL_WARN_IF(m_count = 0, cppu.unsafebridge, m_count is less than or equal to 0);
 
 -- m_count;
 if (!m_count)
-- 
1.8.3.2

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: plans to preserve field type info during pdf import?

2014-01-31 Thread Larry Evans


On 12/27/13 12:24, Larry Evans wrote:

Opening the irs f1040 form for 2012:

   f1040.pdf

with LibreOffice4.1.2.3 on my ubuntu system:

~/prog_dev/LibreOffice/file_conversion/inp $ uname -a
Linux evansl-Inspiron-531 3.2.0-57-generic #87-Ubuntu SMP Tue Nov 12
21:35:10 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
~/prog_dev/LibreOffice/file_conversion/inp $

and saving as f1040.fodg did not preserve the field types.
IOW, the checkboxes in the .pdf were coded as:

 lt;draw:polygon draw:style-name=gr5 draw:layer=layout
svg:width=0.281cm svg:height=0.281cm svg:x=4.642cm svg:y=7.267cm
svg:viewBox=0 0 282 282 draw:points=0,282 282,282 282,0 0,0gt;
  lt;text:p/gt;
 lt;/draw:polygongt;
 lt;draw:frame draw:style-name=gr45 draw:layer=layout
svg:width=0.273cm svg:height=0.336cm svg:x=4.161cm
svg:y=7.264cmgt;
  lt;draw:text-boxgt;
   lt;text:p text:style-name=P1gt;lt;text:span
text:style-name=T13gt;2 lt;/text:spangt;lt;/text:pgt;
  lt;/draw:text-boxgt;
 lt;/draw:framegt;
 lt;draw:frame draw:style-name=gr47 draw:layer=layout
svg:width=7.249cm svg:height=0.336cm svg:x=5.08cm svg:y=7.27cmgt;
  lt;draw:text-boxgt;
   lt;text:p text:style-name=P1gt;lt;text:span
text:style-name=T7gt;Married filing jointly (even if only one had
income) lt;/text:spangt;lt;/text:pgt;
  lt;/draw:text-boxgt;
 lt;/draw:framegt;

which gives no indication its a checkbox of any sort.  The same is
true of text fields because the First Name and intial field is coded
as:

 lt;draw:frame draw:style-name=gr176 draw:layer=layout
svg:width=3.922cm svg:height=0.336cm svg:x=1.34cm svg:y=3.05cmgt;
  lt;draw:text-boxgt;
   lt;text:p text:style-name=P1gt;lt;text:span
text:style-name=T25gt;YourFirstNameAndInitiallt;/text:spangt;lt;/text:pgt;

  lt;/draw:text-boxgt;
 lt;/draw:framegt;

Are there any plans to actually convert the fields into some form of
xform fields which are currently available in LibreOffice writer:

   https://help.libreoffice.org/Common/XML_Form_Documents_XForms

?

TIA.

-regards,
Larry Evans


FWIW, idrsolutions is already doing this conversion, but to html5
instead of to odf:

http://www.idrsolutions.com/jpedalxfa/

I tried their online converter on the f1040.pdf file, and,
in the resulting html, I could edit the fields and save
them.

-regards,
Larry




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/inc sc/source

 sc/inc/table.hxx   |9 -
 sc/source/core/data/table4.cxx |  339 -
 2 files changed, 181 insertions(+), 167 deletions(-)

New commits:
commit 28d5f8c69b2105dbc13af3993fcc5a4cfd4cc432
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 17:46:09 2014 -0500

Extract this code block into its own method.

Change-Id: I43cc4ae350455c104d079e628eabbd6c04e7

diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 658b4c1..095b16e 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -915,10 +915,17 @@ public:
 static void UpdateSearchItemAddressForReplace( const SvxSearchItem 
rSearchItem, SCCOL rCol, SCROW rRow );
 
 private:
-void FillSimple(
+void FillSeriesSimple(
 ScCellValue rSrcCell, SCCOLROW rInner, SCCOLROW nIMin, SCCOLROW 
nIMax,
 SCCOLROW rCol, SCCOLROW rRow, bool bVertical, ScProgress* pProgress, 
sal_uLong rProgress );
 
+void FillAutoSimple(
+SCCOLROW nISrcStart, SCCOLROW nISrcEnd, SCCOLROW nIStart, SCCOLROW 
nIEnd,
+SCCOLROW rInner, SCCOLROW rCol, SCCOLROW rRow,
+sal_uLong nActFormCnt, sal_uLong nMaxFormCnt,
+bool bHasFiltered, bool bVertical, bool bPositive,
+ScProgress* pProgress, sal_uLong rProgress );
+
 voidFillSeries( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
 sal_uLong nFillCount, FillDir eFillDir, 
FillCmd eFillCmd,
 FillDateCmd eFillDateCmd,
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 3f586f5..c0a3005 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -484,16 +484,16 @@ void ScTable::FillAuto( SCCOL nCol1, SCROW nRow1, SCCOL 
nCol2, SCROW nRow2,
 bool bVertical = (eFillDir == FILL_TO_BOTTOM || eFillDir == FILL_TO_TOP);
 bool bPositive = (eFillDir == FILL_TO_BOTTOM || eFillDir == FILL_TO_RIGHT);
 
-sal_uLong nCol = 0;
-sal_uLong nRow = 0;
-sal_uLong rInner = bVertical ? nRow : nCol;// loop variables
-sal_uLong rOuter = bVertical ? nCol : nRow;
-sal_uLong nOStart;
-sal_uLong nOEnd;
-sal_uLong nIStart;
-sal_uLong nIEnd;
-sal_uLong nISrcStart;
-sal_uLong nISrcEnd;
+SCCOLROW nCol = 0;
+SCCOLROW nRow = 0;
+SCCOLROW rInner = bVertical ? nRow : nCol;// loop variables
+SCCOLROW rOuter = bVertical ? nCol : nRow;
+SCCOLROW nOStart;
+SCCOLROW nOEnd;
+SCCOLROW nIStart;
+SCCOLROW nIEnd;
+SCCOLROW nISrcStart;
+SCCOLROW nISrcEnd;
 ScRange aFillRange;
 
 if (bVertical)
@@ -568,7 +568,7 @@ void ScTable::FillAuto( SCCOL nCol1, SCROW nRow1, SCCOL 
nCol2, SCROW nRow2,
 
 const ScPatternAttr* pSrcPattern = NULL;
 const ScStyleSheet* pStyleSheet = NULL;
-sal_uLong nAtSrc = nISrcStart;
+SCCOLROW nAtSrc = nISrcStart;
 ScPatternAttr* pNewPattern = NULL;
 bool bGetPattern = true;
 rInner = nIStart;
@@ -744,159 +744,9 @@ void ScTable::FillAuto( SCCOL nCol1, SCROW nRow1, SCCOL 
nCol2, SCROW nRow2,
 }
 else if (eFillCmd == FILL_SIMPLE)   // fill with pattern/sample
 {
-sal_uLong nSource = nISrcStart;
-double nDelta;
-if ( (nScFillModeMouseModifier  KEY_MOD1) )
-nDelta = 0.0;
-else if ( bPositive )
-nDelta = 1.0;
-else
-nDelta = -1.0;
-double nVal = 0.0;
-sal_uLong nFormulaCounter = nActFormCnt;
-bool bGetCell = true;
-sal_uInt16 nCellDigits = 0;
-short nHeadNoneTail = 0;
-sal_Int32 nStringValue = 0;
-OUString aValue;
-ScCellValue aSrcCell;
-CellType eCellType = CELLTYPE_NONE;
-bool bIsOrdinalSuffix = false;
-
-rInner = nIStart;
-while (true)// #i53728# with for (;;) old solaris/x86 
compiler mis-optimizes
-{
-if(!ColHidden(nCol)  !RowHidden(nRow))
-{
-if ( bGetCell )
-{
-if (bVertical)  // rInner:=nRow, rOuter:=nCol
-aSrcCell = 
aCol[nCol].GetCellValue(static_castSCROW(nSource));
-else// rInner:=nCol, rOuter:=nRow
-aSrcCell = 
aCol[nSource].GetCellValue(static_castSCROW(nRow));
-
-bGetCell = false;
-if (!aSrcCell.isEmpty())
-{
-eCellType = aSrcCell.meType;
-switch (eCellType)
-{
-case CELLTYPE_VALUE:
-nVal = aSrcCell.mfValue;
-break;
-case CELLTYPE_STRING:
-

[Libreoffice-commits] core.git: sc/source

 sc/source/core/data/table4.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit a995462e6855061816c6529c366f20ace2b45868
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 18:05:05 2014 -0500

Take advantage of segment-based hidden flag storage.

To avoid querying this states for every single column and row.

Change-Id: I3e570ae5309c826e809c170ea4635dd37c9b0d43

diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index c0a3005..09f9c78 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1270,10 +1270,19 @@ void ScTable::FillAutoSimple(
 CellType eCellType = CELLTYPE_NONE;
 bool bIsOrdinalSuffix = false;
 
+bool bColHidden = false, bRowHidden = false;
+SCCOL nColHiddenLast = -1;
+SCROW nRowHiddenLast = -1;
+
 rInner = nIStart;
 while (true)// #i53728# with for (;;) old solaris/x86 compiler 
mis-optimizes
 {
-if(!ColHidden(rCol)  !RowHidden(rRow))
+if (rCol  nColHiddenLast)
+bColHidden = ColHidden(rCol, NULL, nColHiddenLast);
+if (rRow  nRowHiddenLast)
+bRowHidden = RowHidden(rRow, NULL, nRowHiddenLast);
+
+if (!bColHidden  !bRowHidden)
 {
 if ( bGetCell )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - svx/source

2014-01-31 Thread Armin Le Grand

 svx/source/sidebar/possize/PosSizePropertyPanel.cxx |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 7e12414bf5e88108116653eee1870612d34c49cb
Author: Armin Le Grand a...@apache.org
Date:   Fri Jan 31 22:23:07 2014 +

i123993 When executing rotation actions from the Sidebar 
PosSizePropertyPanel, take UIScale into account.

Patch By: hanya
Review By: alg

diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx 
b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
index 97b471a..e59b562 100644
--- a/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
+++ b/svx/source/sidebar/possize/PosSizePropertyPanel.cxx
@@ -699,9 +699,11 @@ IMPL_LINK( PosSizePropertyPanel, AngleModifiedHdl, void *, 
EMPTYARG )
 }
 sal_Int64 nTmp = dTmp*100;
 
+// #123993# Need to take UIScale into account when executing rotations
+const double fUIScale(mpView  mpView-GetModel() ? 
double(mpView-GetModel()-GetUIScale()) : 1.0);
 SfxInt32Item aAngleItem( SID_ATTR_TRANSFORM_ANGLE,(sal_uInt32) nTmp);
-SfxInt32Item aRotXItem( SID_ATTR_TRANSFORM_ROT_X,(sal_uInt32) mlRotX);
-SfxInt32Item aRotYItem( SID_ATTR_TRANSFORM_ROT_Y,(sal_uInt32) mlRotY);
+SfxInt32Item aRotXItem( SID_ATTR_TRANSFORM_ROT_X, basegfx::fround(mlRotX * 
fUIScale));
+SfxInt32Item aRotYItem( SID_ATTR_TRANSFORM_ROT_Y, basegfx::fround(mlRotY * 
fUIScale));
 
 GetBindings()-GetDispatcher()-Execute(
 SID_ATTR_TRANSFORM, SFX_CALLMODE_RECORD, aAngleItem, aRotXItem, 
aRotYItem, 0L );
@@ -715,9 +717,11 @@ IMPL_LINK( PosSizePropertyPanel, RotationHdl, void *, 
EMPTYARG )
 {
 sal_Int32 nTmp = mpDial-GetRotation();
 
+// #123993# Need to take UIScale into account when executing rotations
+const double fUIScale(mpView  mpView-GetModel() ? 
double(mpView-GetModel()-GetUIScale()) : 1.0);
 SfxInt32Item aAngleItem( SID_ATTR_TRANSFORM_ANGLE,(sal_uInt32) nTmp);
-SfxInt32Item aRotXItem( SID_ATTR_TRANSFORM_ROT_X,(sal_uInt32) mlRotX);
-SfxInt32Item aRotYItem( SID_ATTR_TRANSFORM_ROT_Y,(sal_uInt32) mlRotY);
+SfxInt32Item aRotXItem( SID_ATTR_TRANSFORM_ROT_X, basegfx::fround(mlRotX * 
fUIScale));
+SfxInt32Item aRotYItem( SID_ATTR_TRANSFORM_ROT_Y, basegfx::fround(mlRotY * 
fUIScale));
 
 GetBindings()-GetDispatcher()-Execute(
 SID_ATTR_TRANSFORM, SFX_CALLMODE_RECORD, aAngleItem, aRotXItem, 
aRotYItem, 0L );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - sc/inc sc/source

 sc/inc/table.hxx   |6 ++
 sc/source/core/data/table4.cxx |  119 ++---
 2 files changed, 72 insertions(+), 53 deletions(-)

New commits:
commit dcca10d4e26d4602d9ac4f0b340b52c31fe086e3
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 21:06:34 2014 -0500

Special case for formula cell fill down for quicker filling.

Change-Id: Ia03aa4c042b22551deacf4d7a58c9492a0a13a66

diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 16fd34f..88d1f68 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1298,7 +1298,14 @@ void ScTable::FillAutoSimple(
 if ( bGetCell )
 {
 if (bVertical)  // rInner:=nRow, rOuter:=nCol
+{
 aSrcCell = aCol[rCol].GetCellValue(nSource);
+if (aSrcCell.meType == CELLTYPE_FORMULA)
+{
+FillFormulaVertical(*aSrcCell.mpFormula, rInner, rCol, 
nIStart, nIEnd, pProgress, rProgress);
+return;
+}
+}
 else// rInner:=nCol, rOuter:=nRow
 aSrcCell = aCol[nSource].GetCellValue(rRow);
 
commit 34ebbc6418e0953cd857c35e6d63a7aaae74dfda
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date:   Fri Jan 31 20:18:42 2014 -0500

Move this to its own method.

Change-Id: Ief8356bc8e0d3d791c97849b8b00ece4ede0b803

diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 095b16e..2621d32 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -915,6 +915,12 @@ public:
 static void UpdateSearchItemAddressForReplace( const SvxSearchItem 
rSearchItem, SCCOL rCol, SCROW rRow );
 
 private:
+
+void FillFormulaVertical(
+const ScFormulaCell rSrcCell,
+SCCOLROW rInner, SCCOL nCol, SCROW nRow1, SCROW nRow2,
+ScProgress* pProgress, sal_uLong rProgress );
+
 void FillSeriesSimple(
 ScCellValue rSrcCell, SCCOLROW rInner, SCCOLROW nIMin, SCCOLROW 
nIMax,
 SCCOLROW rCol, SCCOLROW rRow, bool bVertical, ScProgress* pProgress, 
sal_uLong rProgress );
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index 71fb74c..16fd34f 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1133,6 +1133,51 @@ bool HiddenRowColumn(ScTable* pTable, SCCOLROW 
nRowColumn, bool bVertical, SCCOL
 
 }
 
+void ScTable::FillFormulaVertical(
+const ScFormulaCell rSrcCell,
+SCCOLROW rInner, SCCOL nCol, SCROW nRow1, SCROW nRow2,
+ScProgress* pProgress, sal_uLong rProgress )
+{
+bool bHidden = false;
+SCCOLROW nHiddenLast = -1;
+
+SCCOLROW nRowStart = -1, nRowEnd = -1;
+std::vectorsc::RowSpan aSpans;
+for (rInner = nRow1; rInner = nRow2; ++rInner)
+{
+if (rInner  nHiddenLast)
+bHidden = HiddenRowColumn(this, rInner, true, nHiddenLast);
+
+if (bHidden)
+{
+if (nRowStart = 0)
+{
+nRowEnd = rInner - 1;
+aSpans.push_back(sc::RowSpan(nRowStart, nRowEnd));
+nRowStart = -1;
+}
+rInner = nHiddenLast;
+continue;
+}
+
+if (nRowStart  0)
+nRowStart = rInner;
+}
+
+if (nRowStart = 0)
+{
+nRowEnd = rInner - 1;
+aSpans.push_back(sc::RowSpan(nRowStart, nRowEnd));
+}
+
+aCol[nCol].DeleteRanges(aSpans, IDF_CONTENTS, false);
+aCol[nCol].CloneFormulaCell(rSrcCell, aSpans);
+
+rProgress += nRow2 - nRow1 + 1;
+if (pProgress)
+pProgress-SetStateOnPercent(rProgress);
+}
+
 void ScTable::FillSeriesSimple(
 ScCellValue rSrcCell, SCCOLROW rInner, SCCOLROW nIMin, SCCOLROW nIMax,
 SCCOLROW rCol, SCCOLROW rRow, bool bVertical, ScProgress* pProgress, 
sal_uLong rProgress )
@@ -1146,41 +1191,8 @@ void ScTable::FillSeriesSimple(
 {
 case CELLTYPE_FORMULA:
 {
-SCCOLROW nRowStart = -1, nRowEnd = -1;
-std::vectorsc::RowSpan aSpans;
-for (rInner = nIMin; rInner = nIMax; ++rInner)
-{
-if (rInner  nHiddenLast)
-bHidden = HiddenRowColumn(this, rInner, bVertical, 
nHiddenLast);
-
-if (bHidden)
-{
-if (nRowStart = 0)
-{
-nRowEnd = rInner - 1;
-aSpans.push_back(sc::RowSpan(nRowStart, nRowEnd));
-nRowStart = -1;
-}
-rInner = nHiddenLast;
-continue;
-}
-
-if (nRowStart  0)
-nRowStart = rInner;
-}
-
-if (nRowStart = 0)
-{
-

[Libreoffice-commits] core.git: 9 commits - include/tools sw/source ucb/source vbahelper/source

2014-01-31 Thread Norbert Thiebaud

 include/tools/config.hxx   |1 
 sw/source/core/doc/docfld.cxx  |9 ++-
 sw/source/core/doc/htmltbl.cxx |   81 ++---
 sw/source/core/layout/laycache.cxx |   22 +--
 sw/source/filter/html/htmltabw.cxx |   11 ++-
 ucb/source/ucp/file/filrset.cxx|   42 +++
 ucb/source/ucp/webdav-neon/NeonSession.cxx |   22 +++
 vbahelper/source/msforms/vbacontrol.cxx|5 +
 8 files changed, 116 insertions(+), 77 deletions(-)

New commits:
commit aaddfccb690f4aaa263cc24cb2fd616eebc1a8c1
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Jan 31 21:19:06 2014 -0600

coverity#984154 : Uninitialized scalar field

Change-Id: I6f5b0fe54708a6cb40183dd3857042acdfd84e49

diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx
index 35e3928..10b40a2 100644
--- a/sw/source/core/doc/docfld.cxx
+++ b/sw/source/core/doc/docfld.cxx
@@ -2542,9 +2542,14 @@ void SwDocUpdtFld::RemoveFldType( const SwFieldType 
rType )
 }
 
 SwDocUpdtFld::SwDocUpdtFld(SwDoc* pDoc)
-: pFldSortLst(0), nFldLstGetMode(0), pDocument(pDoc)
+: pFldSortLst(0)
+, nNodes(0)
+, nFldLstGetMode(0)
+, pDocument(pDoc)
+, bInUpdateFlds(false)
+, bFldsDirty(false)
+
 {
-bInUpdateFlds = bFldsDirty = false;
 memset( aFldTypeTable, 0, sizeof( aFldTypeTable ) );
 }
 
commit ece88aed8d31c8377153a50eb29665533bdbc535
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Jan 31 20:58:17 2014 -0600

coverity#984155 : Uninitialized scalar field

Change-Id: I02d2ef35d6d66faf8bc0e7431116ece03e2605fd

diff --git a/sw/source/core/doc/htmltbl.cxx b/sw/source/core/doc/htmltbl.cxx
index 9924534..d234f76 100644
--- a/sw/source/core/doc/htmltbl.cxx
+++ b/sw/source/core/doc/htmltbl.cxx
@@ -164,35 +164,58 @@ SwHTMLTableLayoutConstraints 
*SwHTMLTableLayoutConstraints::InsertNext(
 typedef SwHTMLTableLayoutColumn *SwHTMLTableLayoutColumnPtr;
 typedef SwHTMLTableLayoutCell *SwHTMLTableLayoutCellPtr;
 
-SwHTMLTableLayout::SwHTMLTableLayout(
-const SwTable * pSwTbl,
-sal_uInt16 nRws, sal_uInt16 nCls, bool bColsOpt, bool 
bColTgs,
-sal_uInt16 nWdth, bool bPrcWdth, sal_uInt16 nBorderOpt,
-sal_uInt16 nCellPad, sal_uInt16 nCellSp, SvxAdjust 
eAdjust,
-sal_uInt16 nLMargin, sal_uInt16 nRMargin,
-sal_uInt16 nBWidth, sal_uInt16 nLeftBWidth,
-sal_uInt16 nRightBWidth,
-sal_uInt16 nInhLeftBWidth, sal_uInt16 nInhRightBWidth 
) :
-aColumns( new SwHTMLTableLayoutColumnPtr[nCls] ),
-aCells( new SwHTMLTableLayoutCellPtr[nRws*nCls] ),
-pSwTable( pSwTbl ), pLeftFillerBox( 0 ), pRightFillerBox( 0 ),
-nMin( 0 ), nMax( 0 ),
-nRows( nRws ), nCols( nCls ),
-nLeftMargin( nLMargin ), nRightMargin( nRMargin ),
-nInhAbsLeftSpace( 0 ), nInhAbsRightSpace( 0 ),
-nRelLeftFill( 0 ), nRelRightFill( 0 ),
-nRelTabWidth( 0 ), nWidthOption( nWdth ),
-nCellPadding( nCellPad ), nCellSpacing( nCellSp ), nBorder( nBorderOpt ),
-nLeftBorderWidth( nLeftBWidth ), nRightBorderWidth( nRightBWidth ),
-nInhLeftBorderWidth( nInhLeftBWidth ),
-nInhRightBorderWidth( nInhRightBWidth ),
-nBorderWidth( nBWidth ),
-nDelayedResizeAbsAvail( 0 ), nLastResizeAbsAvail( 0 ),
-nPass1Done( 0 ), nWidthSet( 0 ), eTableAdjust( eAdjust ),
-bColsOption( bColsOpt ), bColTags( bColTgs ),
-bPrcWidthOption( bPrcWdth ), bUseRelWidth( false ),
-bMustResize( sal_True ), bExportable( sal_True ), bBordersChanged( 
sal_False ),
-bMustNotResize( sal_False ), bMustNotRecalc( sal_False )
+SwHTMLTableLayout::SwHTMLTableLayout( const SwTable * pSwTbl,
+  sal_uInt16 nRws, sal_uInt16 nCls,
+  bool bColsOpt, bool bColTgs,
+  sal_uInt16 nWdth, bool bPrcWdth,
+  sal_uInt16 nBorderOpt, sal_uInt16 
nCellPad,
+  sal_uInt16 nCellSp, SvxAdjust eAdjust,
+  sal_uInt16 nLMargin, sal_uInt16 nRMargin,
+  sal_uInt16 nBWidth, sal_uInt16 
nLeftBWidth,
+  sal_uInt16 nRightBWidth,
+  sal_uInt16 nInhLeftBWidth,
+  sal_uInt16 nInhRightBWidth )
+: aColumns( new SwHTMLTableLayoutColumnPtr[nCls] )
+, aCells( new SwHTMLTableLayoutCellPtr[nRws*nCls] )
+, pSwTable( pSwTbl )
+, pLeftFillerBox( 0 )
+, pRightFillerBox( 0 )
+, nMin( 0 )
+, nMax( 0 )
+, nRows( nRws )
+, nCols( nCls )
+, nLeftMargin( nLMargin )
+, nRightMargin( nRMargin )
+, nInhAbsLeftSpace( 0 )
+, nInhAbsRightSpace( 0 )
+, nRelLeftFill( 0 )
+, nRelRightFill( 0 )

LibreOffice Gerrit News for core on 2014-02-01

2014-01-31 Thread gerrit

Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things ! 
+ fdo#64337 Do not show empty findbar in startcenter.
  in https://gerrit.libreoffice.org/7770 from Robert Roth
  about module sfx2
+ fdo#54938 Convert framework to cppu::supportsService
  in https://gerrit.libreoffice.org/7754 from Alexandre Vicenzi
  about module framework
+ fdo#52461 Multiple instances of same cell now get same color.
  in https://gerrit.libreoffice.org/7514 from Rachit Gupta
  about module sc
+ fdo#70159 Comments label: Use darker color when not highlighted
  in https://gerrit.libreoffice.org/7768 from Joren De Cuyper
  about module sw
+ fdo#54938 Convert dtrans, remoteb., reportd., ucbhelper to cppu::supports
  in https://gerrit.libreoffice.org/7762 from Alexandre Vicenzi
  about module dtrans, remotebridges, reportdesign, ucbhelper
+ fd0#74150:Numbered list getting display after RT -table-within-table-1.do
  in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji
  about module sw
+ fdo#74271: Code changes for footer contains hyperlink.
  in https://gerrit.libreoffice.org/7766 from Yogesh Bharate
  about module include
+ fdo#74112 Preserve Chart displayunits properties during ODF import/export
  in https://gerrit.libreoffice.org/7721 from Sushil Shinde
  about module chart2, include, offapi, xmloff
+ fdo#74111 3D Rotation is wrong after Round trip for pie chart
  in https://gerrit.libreoffice.org/7718 from Priyanka Gaikwad
  about module chart2, oox
+ fdo#54938 Convert comphelper and vcl to cppu::supportsService
  in https://gerrit.libreoffice.org/7757 from Alexandre Vicenzi
  about module comphelper, vcl
+ fdo#74110 : Issue with a:prstGeom prst=rect tag in document.xml
  in https://gerrit.libreoffice.org/7765 from Umesh Kadam
  about module oox, sw
+ fdo#54938 Convert bridges, editeng and others to cppu::supportsService
  in https://gerrit.libreoffice.org/7761 from Alexandre Vicenzi
  about module bridges, editeng, hwpfilter, linguistic, lotuswordpro, scripting
+ fdo#74115 Fix for DOCX GradientFill for Chart Wall
  in https://gerrit.libreoffice.org/7739 from Vinaya Mandke
  about module chart2, include, oox
+ fdo#74112 Added properties to store chart display unit information in imp
  in https://gerrit.libreoffice.org/7720 from Sushil Shinde
  about module include, oox
+ fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::support
  in https://gerrit.libreoffice.org/7756 from Alexandre Vicenzi
  about module basctl, mysqlc, sdext, svgio, writerperfect
 End of freshness 



* Merged changes on master for project core changed in the last 25 hours:

+ DiagnosticsEngine::getCustomDiagID isn't const, so don't pass in const en
  in https://gerrit.libreoffice.org/7769 from Andrzej Hunt
+ fdo#71763: F6 key moves focus on this trip: Menu - Sidebar - Thumbnail 
  in https://gerrit.libreoffice.org/7486 from Zolnai Tamás
+ fdo#54938 Convert odk to cppu::supportsService
  in https://gerrit.libreoffice.org/7755 from Alexandre Vicenzi
+ fdo#73872: File Corruption - Issue with w:footerReference in document.xml
  in https://gerrit.libreoffice.org/7630 from Yogesh Bharate


* Abandoned changes on master for project core changed in the last 25 hours:

+ fdo#54938 Convert comphelper and vcl to cppu::supportsService
  in https://gerrit.libreoffice.org/7758 from Alexandre Vicenzi


* Open changes needing tweaks, but being untouched for more than a week:

+ sa/l add release_assert() and assert that stay even in release code
  in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud
+ fdo#69407: On transparent frames, shadows are painted in foreground.
  in https://gerrit.libreoffice.org/7070 from Mohamed-Ali BEN MANSOUR
+ add a header to provide posix compatible wrapper for platform lacking
  in https://gerrit.libreoffice.org/6837 from Norbert Thiebaud
+ upgrade liborcus
  in https://gerrit.libreoffice.org/7310 from Markus Mohrhard
+ WIP fdo#72987 Use firebird backup format for .odb
  in https://gerrit.libreoffice.org/7299 from Andrzej Hunt
+ Export CoreText-related SPI stuff
  in https://gerrit.libreoffice.org/7143 from Douglas Mencken
+ fdo#60698: Merge animcore into sd and slideshow
  in https://gerrit.libreoffice.org/7108 from Marcos Souza
+ sw/export docx: add unit test for document with header and section(s)
  in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer
+ Code clean-up/consolidation task.
  in https://gerrit.libreoffice.org/5926 from Vishv Brahmbhatt
+ fix for exporting of text watermark to DOCX
  in https://gerrit.libreoffice.org/5568 from Adam CloudOn
+ WIP: fdo#33980 Preserve selection across all slide sorters.
  in https://gerrit.libreoffice.org/6633 from Andrzej Hunt
+ fdo#71043 -  Use STACK lint tool to clean code
  in https://gerrit.libreoffice.org/6529 from José Guilherme Vanz
+ Increase number of remembered recent documents from 10 to 25
  in https://gerrit.libreoffice.org/6101 from Krisztian Pinter
+

[Libreoffice-commits] core.git: 5 commits - chart2/source codemaker/source reportdesign/source

2014-01-31 Thread Norbert Thiebaud

 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx |   21 
+-
 chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx  |9 ++--
 codemaker/source/javamaker/classfile.cxx|7 ++-
 reportdesign/source/core/api/FixedLine.cxx  |2 
 reportdesign/source/ui/report/ReportController.cxx  |8 ++-
 5 files changed, 28 insertions(+), 19 deletions(-)

New commits:
commit 2c8193137abf7bb59e854f0aa675dfdad126974e
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sat Feb 1 00:10:27 2014 -0600

coverity#707676 : Uninitialized scalar field

Change-Id: I546c3f497dc98c88a0d678622c20cced387a4ab2

diff --git a/codemaker/source/javamaker/classfile.cxx 
b/codemaker/source/javamaker/classfile.cxx
index c427e96..6673b2f 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -431,8 +431,11 @@ ClassFile::Code::Position ClassFile::Code::getPosition() 
const {
 return m_code.size();
 }
 
-ClassFile::Code::Code(ClassFile  classFile):
-m_classFile(classFile), m_exceptionTableLength(0)
+ClassFile::Code::Code(ClassFile  classFile)
+: m_classFile(classFile)
+, m_maxStack(0)
+, m_maxLocals(0)
+, m_exceptionTableLength(0)
 {}
 
 void ClassFile::Code::ldc(sal_uInt16 index) {
commit 498c878ddc197c7b7da775f81f25aefa772c2df1
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Jan 31 23:54:18 2014 -0600

coverity#707670 : Uninitialized scalar field

Change-Id: I8815381cc1a9801ff5f5ecfac06ada234d5bc363

diff --git a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx 
b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
index f051b5f..7bc3a64 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
@@ -36,10 +36,11 @@ struct lcl_ModelProperties
 sal_Int32 m_nObjectLines;
 ::chart::ThreeDLookScheme m_eScheme;
 
-lcl_ModelProperties() :
-m_nRoundedEdges(-1),
-m_nObjectLines(-1),
-m_eScheme(::chart::ThreeDLookScheme_Unknown)
+lcl_ModelProperties()
+: m_aShadeMode(drawing::ShadeMode_FLAT)
+, m_nRoundedEdges(-1)
+, m_nObjectLines(-1)
+, m_eScheme(::chart::ThreeDLookScheme_Unknown)
 {}
 };
 
commit c74006b1c8420143679a6057c92942fa8a3a65ef
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Jan 31 23:41:52 2014 -0600

coverity#707668 : Uninitialized scalar field

Change-Id: I3527de5f4a00d2fa2aa3b01a82d7c91a24547b86

diff --git 
a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index 9b5b622..21b269a 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -484,16 +484,17 @@ void SAL_CALL DataSeriesPointWrapper::initialize( const 
uno::Sequence uno::Any
 m_eType = DATA_SERIES;
 }
 
-DataSeriesPointWrapper::DataSeriesPointWrapper( eType _eType
-, sal_Int32 nSeriesIndexInNewAPI
-, sal_Int32 nPointIndex //ignored for series
-, ::boost::shared_ptr Chart2ModelContact  spChart2ModelContact )
-: m_spChart2ModelContact( spChart2ModelContact )
-, m_aEventListenerContainer( m_aMutex )
-, m_eType( _eType )
-, m_nSeriesIndexInNewAPI( nSeriesIndexInNewAPI )
-, m_nPointIndex( (_eType == DATA_POINT) ? nPointIndex : -1 )
-, m_xDataSeries(0)
+DataSeriesPointWrapper::DataSeriesPointWrapper( eType _eType,
+sal_Int32 nSeriesIndexInNewAPI 
,
+sal_Int32 nPointIndex, 
//ignored for series
+::boost::shared_ptr 
Chart2ModelContact  spChart2ModelContact )
+: m_spChart2ModelContact( spChart2ModelContact )
+, m_aEventListenerContainer( m_aMutex )
+, m_eType( _eType )
+, m_nSeriesIndexInNewAPI( nSeriesIndexInNewAPI )
+, m_nPointIndex( (_eType == DATA_POINT) ? nPointIndex : -1 )
+, m_bLinesAllowed( sal_False )
+, m_xDataSeries(0)
 {
 }
 
commit f68d5d5c8c7d865db0fbb7562ddd03076fbe605f
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Fri Jan 31 21:49:06 2014 -0600

coverity#738780-79 : Uninitialized scalar field

Change-Id: Ie8a986bb633a7d81f95b81eac5bf2879ccba2cb9

diff --git a/reportdesign/source/core/api/FixedLine.cxx 
b/reportdesign/source/core/api/FixedLine.cxx
index b3d0332..2b40055 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -131,6 +131,7 @@ OFixedLine::OFixedLine(uno::Reference 
uno::XComponentContext  const  _xContex
 :FixedLineBase(m_aMutex)
 ,FixedLinePropertySet(_xContext,static_cast Implements

QA Meeting Minutes - 2014-01-27

2014-01-31 Thread Robinson Tryon

Hi all,

Meeting minutes are available here:
https://wiki.documentfoundation.org/QA/Meetings/2014/January_27

Our upcoming meeting will be in two weeks:
https://wiki.documentfoundation.org/QA/Meetings/2014/February_10

As always, our meetings are open to everyone -- please feel free to
join us in a meeting or in the IRC channel.

Best,
--R
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Trendline equation

2014-01-31 Thread Stefan Weigel

Hi,

Am 30.01.2014 22:12, schrieb Laurent BP:

 https://bugs.freedesktop.org/show_bug.cgi?id=74163


 Lets take an example which corresponds to a common error of beginner:
 1. Enter Data such as X=1, 10, 100 and Y=11, 12, 13
 2. Create a *XY* (scatter) chart
 3. Insert trendline and show equation
 = f(x) = 0.0165165165x + 11.39
 With same data:
 4. Create a *Line* chart with  First column as label selected on 2nd step
 5. Insert linear trendline and show equation
 = f(x) = 1x + 10

 Do you know some case, where the user would require the equation of the
 trendline for other type of diagram different from XY scatter chart?

Yes, I do.

Example:

1. Enter Data A1=11, A2=13, A3=12, A4=14, A5=16, A6=15
2. Select A1:A6
3. 4. Create a Line chart
4. Insert linear trendline and show equation

-- Equation does make sense.

;-)

As long as you do *not* specify X-values or categories, the equation
is usefull even for Column, Bar, Area, Line and Column and
Line charts.

Cheers,
Stefan


-- 
LibreOffice - Die Freiheit nehm' ich mir!
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] Trendline equation

2014-01-31 Thread Laurent BP

Stefan Weigel wrote
 1. Enter Data A1=11, A2=13, A3=12, A4=14, A5=16, A6=15
 2. Select A1:A6
 3. 4. Create a Line chart
 4. Insert linear trendline and show equation
 
 -- Equation does make sense.

If you do not specify X-values/categories, what sense can you give in the
equation for 'x'?
From my point of view, equation is useful if you need to extrapolate or
interpolate values. What else?
The trendline give you the trend of your data, but the numerical values of
the equation must be linked to something. Did I mess something?
And what about forced intercept (new option for 4.2), which sense can user
give for categories value of zero?



-
LibreOffice 4.1.1.2
--
View this message in context: 
http://nabble.documentfoundation.org/Trendline-equation-tp4094690p4094863.html
Sent from the QA mailing list archive at Nabble.com.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] QA Meeting Minutes - 2014-01-27

2014-01-31 Thread Robinson Tryon

Hi all,

Meeting minutes are available here:
https://wiki.documentfoundation.org/QA/Meetings/2014/January_27

Our upcoming meeting will be in two weeks:
https://wiki.documentfoundation.org/QA/Meetings/2014/February_10

As always, our meetings are open to everyone -- please feel free to
join us in a meeting or in the IRC channel.

Best,
--R
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 72324] Other: Figures copied from Matlab and pasted as metafiles lose some lines.

https://bugs.freedesktop.org/show_bug.cgi?id=72324

--- Comment #5 from Karel Hruska push...@email.cz ---
Created attachment 93102
  -- https://bugs.freedesktop.org/attachment.cgi?id=93102action=edit
EMF file generated by Matlab (imported broken)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74261] New: Figure labels hide after document opening

https://bugs.freedesktop.org/show_bug.cgi?id=74261

  Priority: medium
Bug ID: 74261
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Figure labels hide after document opening
  Severity: major
Classification: Unclassified
OS: Linux (All)
  Reporter: push...@email.cz
  Hardware: x86-64 (AMD64)
Status: UNCONFIRMED
   Version: 4.2.0.4 release
 Component: Writer
   Product: LibreOffice

The figure labels in a Writer document disappear randomly after reopening the
document under certain conditions. It does not happen every opening of the
document but it is relatively common especially when working with larger
documents with many figures ( 10 MiB).

The text just hides behind the figures and it can be put back by choosing
another type of figure wrap. It happens to figures randomly over the document,
not every figure is affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74254] exporting to PDF appends PDF to the file name

https://bugs.freedesktop.org/show_bug.cgi?id=74254

--- Comment #4 from Tim Lloyd tim.ll...@gmx.com ---
LO4.2.0.4 Fedora 20. I tried this with calc and writer and the problem was not
visible. abc.odt becomes abc.pdf. xyz.ods becomes xyz.pdf

I have been using 4.1.4.2 and the problem was not apparent

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74261] Figure labels hide after document opening

https://bugs.freedesktop.org/show_bug.cgi?id=74261

--- Comment #1 from Karel Hruska push...@email.cz ---
I forgot to add, that I noticed this behaviour in earlier versions of LO, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74262] New: Writer crash

https://bugs.freedesktop.org/show_bug.cgi?id=74262

  Priority: medium
Bug ID: 74262
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Writer crash
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: se...@riseup.net
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.1.3.2 release
 Component: Writer
   Product: LibreOffice

I had opened two documets: docx and odt. Both was previously edited with MS
office.
When I started browsing odt document, LO crashed.
I can attach documents, if it is needed. 
Here I provide apport crash dump.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74262] Writer crash

https://bugs.freedesktop.org/show_bug.cgi?id=74262

--- Comment #1 from se...@riseup.net ---
I uploaded crash dump here: http://zalil.ru/34943545

Bug tracker doesn't allow me to attach large files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74264] New: Editing Calc - Cut then Undo looses hyperlinks

https://bugs.freedesktop.org/show_bug.cgi?id=74264

  Priority: medium
Bug ID: 74264
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Editing Calc - Cut then Undo looses hyperlinks
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: d...@tasit.net
  Hardware: x86-64 (AMD64)
Status: UNCONFIRMED
   Version: unspecified
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 93103
  -- https://bugs.freedesktop.org/attachment.cgi?id=93103action=edit
Cut  Undo Example

Version: 4.2.0.4
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
To reproduce:
  1. Select a cell or a range of cells with hyperlink(s) and cut.
  2. Click undo and hyperlink(s) disappear.
In the attached example file select cells A1 to A3 click cut then undo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69017] PRINTING: Printing doc: Row heights partially changed in printout

https://bugs.freedesktop.org/show_bug.cgi?id=69017

--- Comment #3 from bugzi...@team.cortado.com ---
Wa re-tested the issue with Arial. Rows are still moved but less than in the
first test. But still a new page can be created by moved rows.
Please see attachments - the lines indicate the offset.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69017] PRINTING: Printing doc: Row heights partially changed in printout

https://bugs.freedesktop.org/show_bug.cgi?id=69017

--- Comment #4 from bugzi...@team.cortado.com ---
Created attachment 93104
  -- https://bugs.freedesktop.org/attachment.cgi?id=93104action=edit
offset in LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69017] PRINTING: Printing doc: Row heights partially changed in printout

https://bugs.freedesktop.org/show_bug.cgi?id=69017

--- Comment #5 from bugzi...@team.cortado.com ---
Created attachment 93105
  -- https://bugs.freedesktop.org/attachment.cgi?id=93105action=edit
original

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69017] PRINTING: Printing doc: Row heights partially changed in printout

https://bugs.freedesktop.org/show_bug.cgi?id=69017

bugzi...@team.cortado.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74259] Draw crahs by opening a new file

https://bugs.freedesktop.org/show_bug.cgi?id=74259

Foss f...@openmailbox.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Whiteboard||NoRepro:4.2.0.2:OSX
 Ever confirmed|0   |1

--- Comment #1 from Foss f...@openmailbox.org ---
NoRepro:4.2.0.2:OSX

Your test file opens fine here on OSX. Which OS are you on?

* you might also want to reset your user profile and see if that improves the
situation: https://wiki.documentfoundation.org/UserProfile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74262] Writer crash

https://bugs.freedesktop.org/show_bug.cgi?id=74262

Foss f...@openmailbox.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Foss f...@openmailbox.org ---
Hi Senya, yes please indeed attach the test files, otherwise it will be
impossible to reproduce. Clear any sensitive information contained first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74262] Writer crash

https://bugs.freedesktop.org/show_bug.cgi?id=74262

--- Comment #3 from se...@riseup.net ---
Created attachment 93106
  -- https://bugs.freedesktop.org/attachment.cgi?id=93106action=edit
test file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74262] Writer crash

https://bugs.freedesktop.org/show_bug.cgi?id=74262

--- Comment #4 from se...@riseup.net ---
I have uploaded odt file.
I was just scrolling window with it and then libreoffice went segfault.
Doesn't crash dump contains enough information to understand what the problem
was?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38639] DOCX: section change with different header/footer settings not regarded

https://bugs.freedesktop.org/show_bug.cgi?id=38639

--- Comment #7 from vulc...@gmx.com ---
Still here in LibreOffice 4.2.0.4 Build ID:
05dceb5d363845f2cf968344d7adab8dcfb2ba71 on Ubuntu 12.04.4 x86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61543] Add Soft-edge Shadow to Impress

https://bugs.freedesktop.org/show_bug.cgi?id=61543

Kumāra kumara.bhik...@gmail.com changed:

   What|Removed |Added

 CC||diaz.bast...@ymail.com

--- Comment #3 from Kumāra kumara.bhik...@gmail.com ---
*** Bug 69577 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69577] Improve appearance of shadows added to objects (text and images) in LO Impress

https://bugs.freedesktop.org/show_bug.cgi?id=69577

Kumāra kumara.bhik...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||kumara.bhik...@gmail.com

--- Comment #1 from Kumāra kumara.bhik...@gmail.com ---


*** This bug has been marked as a duplicate of bug 61543 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61543] Add Soft-edge Shadow to Impress

https://bugs.freedesktop.org/show_bug.cgi?id=61543

Kumāra kumara.bhik...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Kumāra kumara.bhik...@gmail.com ---
(In reply to comment #2)
 I also believe others have reported a wish for such a feature (bug 69577).

I've marked that as a duplicate. Thanks for noticing that.

 Kumāra: Sorry if I hijacked your bug report, that was not my intention.

What hijack? I'm glad someone else voiced an interest. Thank you!

With 3 asking for this, I think we can safely mark this as NEW now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51781] Select a good replacement for embedded HSQLDB 1.8

https://bugs.freedesktop.org/show_bug.cgi?id=51781

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=51780

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.freedesktop.or |
   |g/show_bug.cgi?id=51781 |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=51781

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=36546

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51781] Select a good replacement for embedded HSQLDB 1.8

https://bugs.freedesktop.org/show_bug.cgi?id=51781

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugs.freedesktop.or |
   |g/show_bug.cgi?id=51780 |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36546] Internal HSQLDB 1.8 fails to cascade updates through multiple paths and deletions through some cyclic structures

https://bugs.freedesktop.org/show_bug.cgi?id=36546

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=51780

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70105] FORMATTING: Rendering of the header/footer is incorrect

https://bugs.freedesktop.org/show_bug.cgi?id=70105

--- Comment #4 from vulc...@gmx.com ---
Reproduce with LibreOffice 4.2.0.4 Build ID:
05dceb5d363845f2cf968344d7adab8dcfb2ba71 on Ubuntu 12.04.4 x86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68167] Create an outline view similar to that in MS Word and Apple Pages

https://bugs.freedesktop.org/show_bug.cgi?id=68167

--- Comment #20 from Jean-Marc Liotier j...@liotier.org ---
Saying that developers ignore the gaping functional hole is exaggerated: some
are fully aware, but then it is all a matter of prioritizing issues vs.
resources... And we don't bring much to the table besides our rightful
lamentation. Maybe we should organize some way to translate our requirements
into project resources.

Mathias Bauer explained in 2007
(https://issues.apache.org/ooo/show_bug.cgi?id=3959#c76) that, on top of being
a substantial and entirely new layout, outline view depended on being able to
display simultaneously multiple layouts for a single document - which implied
significant refactoring of the existing functionnality. In 2008
(https://issues.apache.org/ooo/show_bug.cgi?id=3959#c96) he underlined that
lack of progress was not caused by undervaluing this feature but because its
cost made it a lower priority. Support for multiple layouts was added to
Openoffice in Q3-Q4 2010 (https://issues.apache.org/ooo/show_bug.cgi?id=81480)
but that was around the time of the Openffice/Libreoffice fork so I do not know
how much of that exists in the Libreoffice code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36546] Internal HSQLDB 1.8 fails to cascade updates through multiple paths and deletions through some cyclic structures

https://bugs.freedesktop.org/show_bug.cgi?id=36546

--- Comment #16 from Popa Adrian Marius map...@gmail.com ---

This can be marked as fixed once #51780 is marked as done

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74259] Draw crahs by opening a new file

https://bugs.freedesktop.org/show_bug.cgi?id=74259

--- Comment #2 from Dennis d.cra...@gmail.com ---
Created attachment 93120
  -- https://bugs.freedesktop.org/attachment.cgi?id=93120action=edit
corrput draw-file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74259] Draw crahs by opening a new file

https://bugs.freedesktop.org/show_bug.cgi?id=74259

Dennis d.cra...@gmail.com changed:

   What|Removed |Added

   Hardware|Other   |All
 OS|All |Windows (All)

--- Comment #3 from Dennis d.cra...@gmail.com ---
First: This is my first bug report :D

My test file works by me great, too.
Every time I will open a new draw, my LO Draw crash.

Now I've attached a corrupt file.

I create this at Desktop:
Right mouse - New - OpenDocument Drawing

My System is: Windows 7 Professional SP1 64bit

The other LO Suites like writer and calc work fine.

Moreover my windows report (german)
Problemsignatur:
  Problemereignisname:APPCRASH
  Anwendungsname:soffice.bin
  Anwendungsversion:4.2.0.4
  Anwendungszeitstempel:52e7c78b
  Fehlermodulname:StackHash_7efd
  Fehlermodulversion:6.1.7601.17725
  Fehlermodulzeitstempel:4ec49b8f
  Ausnahmecode:c374
  Ausnahmeoffset:000ce6c3
  Betriebsystemversion:6.1.7601.2.1.0.256.48
  Gebietsschema-ID:1031
  Zusatzinformation 1:7efd
  Zusatzinformation 2:7efdc4569fe7f11fc08ea73b50c7e01b
  Zusatzinformation 3:558c
  Zusatzinformation 4:558c6114612ea9cbb004b31492ca2303

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36546] Internal HSQLDB 1.8 fails to cascade updates through multiple paths and deletions through some cyclic structures

https://bugs.freedesktop.org/show_bug.cgi?id=36546

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

 Depends on||51780

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

https://bugs.freedesktop.org/show_bug.cgi?id=51780

Popa Adrian Marius map...@gmail.com changed:

   What|Removed |Added

 Blocks||36546

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54346] Libreoffice 3.5.5 Calc WEEKDAY() function shows wrong number of day

https://bugs.freedesktop.org/show_bug.cgi?id=54346

--- Comment #7 from andis.lazd...@gmail.com ---
Hello!

The problem with weekday() function is still there for me. I just stopped to
use this function after conclusion on this bug report that this is not a bug,
but feature :) Probably this problem appears only in case, if it is set, that
week starts with Monday or additional operators should be used in formula.

Considering that developers are not planning to deal with this and there is
very small interest on this issue, I recommend to find a workaround (there are
several options, like transforming weekdays into text and setting number of day
according to text strings) and not to use weekday() function in calculations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74267] New: Revert to system fonts on windows instead of Liberation fonts

https://bugs.freedesktop.org/show_bug.cgi?id=74267

  Priority: medium
Bug ID: 74267
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Revert to system fonts on windows instead of
Liberation fonts
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: felix.stad...@inventivio.com
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.2.0.4 release
 Component: Libreoffice
   Product: LibreOffice

I am a business user and was looking forward to release 4.2. Now I have just
spent an hour in changing back to the old templates and fonts in
writer/calc/impress and draw  because I have to share my documents with people
who don't use LibreOffice and who may not have Liberation fonts on their
systems. I create all documents for internal use in OpenDocument format, but I
need to save many documents for external use in Microsoft formats. Not great,
but unavoidable. 

I want to be sure that I know what these documents look like on my client's
systems and I don't want to have to answer questions by my clients about what
cause I am supporting with those strangely-named 'Liberation' fonts. 

By making these fonts the default on Windows, you are just introducing
difficulties for many users when they share their documents with others. Using
the default system fonts and then opening them on other operating systems is
not a problem because the Arial etc fonts will be substituted on most other
systems correctly. The reverse is not necessarily true (even if it were on most
systems, users would still be unsure about it). 

I know that all of us who are great fans of LibreOffice and Open Source
Software want to ditch the use of Windows system fonts. But fundamentally we
need to make LibreOffice as easy to use and as interoperable with the context
of our users as possible. Forcing liberation fonts on the users is not the
right approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74268] New: Chart forgets

https://bugs.freedesktop.org/show_bug.cgi?id=74268

  Priority: medium
Bug ID: 74268
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Chart forgets
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: to...@tmoravec.cz
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.2.0.4 release
 Component: Chart
   Product: LibreOffice

Problem description: 
When I insert text field from panel Drawing to chart, save document and restart
LO the text field is gone. In Calc 4.1.4.2 everything works properly.

Steps to reproduce:
1. Open Calc 4.2.
2. Create chart.
3. Double click on it.
4. Insert text field.
5. Save document.
6. Restart LO.

Current behavior:
The text field is forgotten.

Expected behavior:
I expect text field.

LibreOffice 4.2.0.4
Kubuntu 13.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74270] New: [FILEOPEN]: PPS ou PPSX add a countdown option for impress

https://bugs.freedesktop.org/show_bug.cgi?id=74270

  Priority: medium
Bug ID: 74270
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: [FILEOPEN]: PPS ou PPSX add a countdown option for
impress
  Severity: enhancement
Classification: Unclassified
OS: All
  Reporter: vulc...@gmx.com
  Hardware: All
Status: UNCONFIRMED
   Version: unspecified
 Component: Presentation
   Product: LibreOffice

PPS and PPSX are to specif files format to launch automatically in Full screen
for slideshow

But, some user prefer to have the choice to not open in Full-screen.

I think it could be a good feature to add an option for it.

Expected: 
* By default LibreOffice open pps or ppsx in Full screen
* option could be actived: the user will a countdown before the launch of the
fullscreen. The number of the countdown could choice by the user (5 seconds, 10
seconds, ...). During the countdown, the could stop the launch in full screen
with Echap. In the other hand, he could accelerate the launch with enter

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60268] FORMATTING: Square root and cdot are not correct displayed under Windows 8

https://bugs.freedesktop.org/show_bug.cgi?id=60268

--- Comment #11 from Andrea si...@libero.it ---
Still reproducible with 4.2.0.4 under Windows 8

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74271] New: File Corruption - Issue related with hyperlink in footer

https://bugs.freedesktop.org/show_bug.cgi?id=74271

  Priority: medium
Bug ID: 74271
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: File Corruption - Issue related with hyperlink in
footer
  Severity: normal
Classification: Unclassified
OS: Linux (All)
  Reporter: yogesh.bhar...@synerzip.com
  Hardware: IA64 (Itanium)
Status: UNCONFIRMED
   Version: 4.3.0.0.alpha0+ Master
 Component: Writer
   Product: LibreOffice

Created attachment 93122
  -- https://bugs.freedesktop.org/attachment.cgi?id=93122action=edit
footer contains hyperlink

Problem Description:
1. If the footer contains the hyperlink start with www ex. www.google.com.
2. After roundtrip footer*.xml.rels, contains the Target is empty related
 to the Hyperlink.
i.e Relationship Id=rId1
Type=http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink;
Target= TargetMode=External /

Steps to reproduce:
1. Open the file in LibreOffice
2. Click File - Save As (Microsoft Word 2007/2010 (.docx))
3. Open saved file in MS Office 2007.

Expected:
File should open without any error.

Actual:
File corrupt dialog is shown.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74264] Editing Calc - Cut then Undo looses hyperlinks

https://bugs.freedesktop.org/show_bug.cgi?id=74264

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
Hi Dave,

I would expect this is one of the examples of the problem fixed in bug 74014 ..
Could you pls have a look, and maybe test a daily build?

thanks for reporting  your help!

Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74271] File Corruption - Issue related with hyperlink in footer

https://bugs.freedesktop.org/show_bug.cgi?id=74271

Yogesh Bharate yogesh.bhar...@synerzip.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |yogesh.bhar...@synerzip.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74233] FILESAVE: RTF resaved without modifications changes the tables formatting

https://bugs.freedesktop.org/show_bug.cgi?id=74233

--- Comment #3 from Benjamin Bellec b.bel...@gmail.com ---
The problem doesn't occurs with Apache OpenOffice 4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74273] New: EDITING: Insert cell shift cell and comments down, deleting cell shift cell up and comment too much

https://bugs.freedesktop.org/show_bug.cgi?id=74273

  Priority: medium
Bug ID: 74273
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: EDITING: Insert cell shift cell and comments down,
deleting cell shift cell up and comment too much
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: andreabogazz...@gmail.com
  Hardware: x86 (IA32)
Status: UNCONFIRMED
   Version: unspecified
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 93123
  -- https://bugs.freedesktop.org/attachment.cgi?id=93123action=edit
ShiftingCellsDemo

Version 4.2.0.1 and 4.2.0.3 at least. Not in 4.1.4

How to recreate bug:

Open new spreadsheet.
I insert some data in some cell one under the other,
then i add comment for every cell ( red dot in top right corner ).
I select some cell over those and i choose delete
Calc ask me to shift content up , i say yes.
Content is shifted up, comments are shifted up too much ( i didn't check
relation between number of deleted cells and wrong shifting, but it looks like
it shifts it double )

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74229] FORMATTING: RTF cells are too close

https://bugs.freedesktop.org/show_bug.cgi?id=74229

--- Comment #4 from Benjamin Bellec b.bel...@gmail.com ---
The problem doesn't occurs with Apache OpenOffice 4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 40907] FILEOPEN - concurrent access to AFP shared files impossible - total lock on file

https://bugs.freedesktop.org/show_bug.cgi?id=40907

Alex Thurgood ipla...@yahoo.co.uk changed:

   What|Removed |Added

   Assignee|be...@benny.de  |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35176] Can't paste image from MS Word

https://bugs.freedesktop.org/show_bug.cgi?id=35176

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74217] FORMATTING: Copy and past of a chart to any other LibO or MSOffice application

https://bugs.freedesktop.org/show_bug.cgi?id=74217

--- Comment #2 from Diego Roncoroni diego.roncor...@garzantispecialties.it ---
Created attachment 93124
  -- https://bugs.freedesktop.org/attachment.cgi?id=93124action=edit
screenshots of the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 74217] FORMATTING: Copy and past of a chart to any other LibO or MSOffice application

https://bugs.freedesktop.org/show_bug.cgi?id=74217

--- Comment #3 from Diego Roncoroni diego.roncor...@garzantispecialties.it ---
See the attachement.
Hope it is clear now

Thanks and Ciao

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54346] Libreoffice 3.5.5 Calc WEEKDAY() function shows wrong number of day