LibreOffice Gerrit News for core on 2014-04-02
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + configure.ac: require g++ 4.2 or above to build LibreOffice in https://gerrit.libreoffice.org/8812 from Douglas Mencken about module build + external: revert java 1.6 stuff (at least until we'd get a real check in in https://gerrit.libreoffice.org/8801 from Douglas Mencken about module build, external, reportbuilder, swext + fdo#64945 Remove inconvenient localized symbol code. in https://gerrit.libreoffice.org/8696 from Darshana Padmadas about module officecfg, starmath End of freshness + fdo#73552 - Set name of CSV import sheet to something friendly in https://gerrit.libreoffice.org/8811 from Caolán McNamara about module sc * Merged changes on master for project core changed in the last 25 hours: + Convert RID_SYMDEFINEDIALOG to .ui in https://gerrit.libreoffice.org/8807 from Mihály Palenik + fdo#74702 Refactor code to use ClipToPaintRegion() in https://gerrit.libreoffice.org/8810 from Chris Sherlock + Remove unnecessary(?) warnings_not_errors for vcl KDE code in https://gerrit.libreoffice.org/8775 from Stephan Bergmann + sal: add aligned memory allocation with malloc for OS X 10.6 in https://gerrit.libreoffice.org/8405 from Douglas Mencken * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#67544 Slide transistion sound(other sound) is not included in present in https://gerrit.libreoffice.org/8700 from Vishv Brahmbhatt + fdo#57950: Replace chained O(U)StringBuffer::append() with operator+ in https://gerrit.libreoffice.org/8699 from Tharindu Lakmal + Refactored in https://gerrit.libreoffice.org/8683 from Tharindu Lakmal + fdo#75757 Remove inheritance to std::map from PropertyMap in https://gerrit.libreoffice.org/8656 from Krisztian Pinter + Remove visual noise from ios in https://gerrit.libreoffice.org/8274 from Alexander Wilms + FDO#75205 : Charts - Up Down bars are getting added to Line Chart. in https://gerrit.libreoffice.org/8360 from Umesh Kadam + WIP: Converting ExtensionUpdate dialog for new format in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes + Refactored swooxmlexport tests cases. Added function to check contents. in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar + FDO#74886: Data labels are not preserved for Column Chart in RT file in https://gerrit.libreoffice.org/8098 from Umesh Kadam + fdo#71984 fix first line indentation in footnotes for MS Word documents in https://gerrit.libreoffice.org/8160 from Andras Timar + fd0#74150:Numbered list getting display after RT -table-within-table-1.do in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji + Lots of changes to Tango icons in https://gerrit.libreoffice.org/7987 from Miroslav Mazel + sw/docx export: fix handling of document with header and section(s) in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer + fdo#51525 Fix duplicate Paste Special entries in Calc. in https://gerrit.libreoffice.org/7784 from Andrzej Hunt + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + sa/l add release_assert() and assert that stay even in release code in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: embeddedobj/source extensions/source
embeddedobj/source/msole/olecomponent.cxx| 37 +--
extensions/source/plugin/base/xplugin.cxx|9 ++--
extensions/source/plugin/unx/mediator.cxx| 13 +++---
extensions/source/propctrlr/formcomponenthandler.cxx |4 +-
extensions/source/scanner/grid.cxx | 10 ++---
extensions/source/scanner/sane.cxx | 33 ++--
extensions/source/scanner/sanedlg.cxx| 12 ++
7 files changed, 53 insertions(+), 65 deletions(-)
New commits:
commit 8f7c677dbba29123c48778a1024a535f36bca183
Author: Takeshi Abe t...@fixedpoint.jp
Date: Wed Apr 2 16:08:04 2014 +0900
Avoid possible resource leaks by boost::scoped_array
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
diff --git a/embeddedobj/source/msole/olecomponent.cxx
b/embeddedobj/source/msole/olecomponent.cxx
index 1ebeca4..eb248ec1 100644
--- a/embeddedobj/source/msole/olecomponent.cxx
+++ b/embeddedobj/source/msole/olecomponent.cxx
@@ -40,6 +40,7 @@
#include advisesink.hxx
#include oleembobj.hxx
#include mtnotification.hxx
+#include boost/scoped_array.hpp
using namespace ::com::sun::star;
using namespace ::comphelper;
@@ -286,7 +287,7 @@ sal_Bool OleComponentNative_Impl::ConvertDataForFlavor(
const STGMEDIUM aMedium
{
// first the GDI-metafile must be generated
-unsigned char* pBuf = NULL;
+boost::scoped_arrayunsigned char pBuf;
sal_uInt32 nBufSize = 0;
OUString aFormat;
@@ -297,23 +298,23 @@ sal_Bool OleComponentNative_Impl::ConvertDataForFlavor(
const STGMEDIUM aMedium
if ( pMF )
{
nBufSize = GetMetaFileBitsEx( pMF-hMF, 0, NULL ) + 22;
-pBuf = new unsigned char[nBufSize];
+pBuf.reset(new unsigned char[nBufSize]);
// TODO/LATER: the unit size must be calculated correctly
-*( (long* )pBuf ) = 0x9ac6cdd7L;
-*( (short* )( pBuf+6 )) = ( SHORT ) 0;
-*( (short* )( pBuf+8 )) = ( SHORT ) 0;
-*( (short* )( pBuf+10 )) = ( SHORT ) pMF-xExt;
-*( (short* )( pBuf+12 )) = ( SHORT ) pMF-yExt;
-*( (short* )( pBuf+14 )) = ( USHORT ) 2540;
+*( (long* )pBuf.get() ) = 0x9ac6cdd7L;
+*( (short* )( pBuf.get()+6 )) = ( SHORT ) 0;
+*( (short* )( pBuf.get()+8 )) = ( SHORT ) 0;
+*( (short* )( pBuf.get()+10 )) = ( SHORT ) pMF-xExt;
+*( (short* )( pBuf.get()+12 )) = ( SHORT ) pMF-yExt;
+*( (short* )( pBuf.get()+14 )) = ( USHORT ) 2540;
-if ( nBufSize nBufSize == GetMetaFileBitsEx( pMF-hMF,
nBufSize - 22, pBuf + 22 ) )
+if ( nBufSize nBufSize == GetMetaFileBitsEx( pMF-hMF,
nBufSize - 22, pBuf.get() + 22 ) )
{
if ( aFlavor.MimeType.matchAsciiL(
application/x-openoffice-wmf;windows_formatname=\Image WMF\, 57 ) )
{
-aResult = uno::Sequence sal_Int8 ( ( sal_Int8*
)pBuf, nBufSize );
+aResult = uno::Sequence sal_Int8 ( ( sal_Int8*
)pBuf.get(), nBufSize );
bAnyIsReady = sal_True;
}
}
@@ -325,12 +326,12 @@ sal_Bool OleComponentNative_Impl::ConvertDataForFlavor(
const STGMEDIUM aMedium
{
aFormat = image/x-emf;
nBufSize = GetEnhMetaFileBits( aMedium.hEnhMetaFile, 0, NULL );
-pBuf = new unsigned char[nBufSize];
-if ( nBufSize nBufSize == GetEnhMetaFileBits(
aMedium.hEnhMetaFile, nBufSize, pBuf ) )
+pBuf.reset(new unsigned char[nBufSize]);
+if ( nBufSize nBufSize == GetEnhMetaFileBits(
aMedium.hEnhMetaFile, nBufSize, pBuf.get() ) )
{
if ( aFlavor.MimeType.matchAsciiL(
application/x-openoffice-emf;windows_formatname=\Image EMF\, 57 ) )
{
-aResult = uno::Sequence sal_Int8 ( ( sal_Int8* )pBuf,
nBufSize );
+aResult = uno::Sequence sal_Int8 ( ( sal_Int8*
)pBuf.get(), nBufSize );
bAnyIsReady = sal_True;
}
}
@@ -339,12 +340,12 @@ sal_Bool OleComponentNative_Impl::ConvertDataForFlavor(
const STGMEDIUM aMedium
{
aFormat = image/x-MS-bmp;
nBufSize = GetBitmapBits( aMedium.hBitmap, 0, NULL );
-pBuf = new unsigned char[nBufSize];
-if ( nBufSize nBufSize == sal::static_int_cast ULONG (
GetBitmapBits( aMedium.hBitmap, nBufSize, pBuf ) ) )
+pBuf.reset(new unsigned char[nBufSize]);
+if ( nBufSize nBufSize == sal::static_int_cast ULONG (
GetBitmapBits( aMedium.hBitmap, nBufSize, pBuf.get() ) ) )
{
if ( aFlavor.MimeType.matchAsciiL(
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/fdo76586.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 16 +++
writerfilter/source/dmapper/DomainMapperTableManager.cxx | 10 +++--
3 files changed, 24 insertions(+), 2 deletions(-)
New commits:
commit 54d913aa74962781e31290d9bb7e2d95212d994c
Author: Vinaya Mandke vinaya.man...@synerzip.com
Date: Thu Mar 27 12:07:25 2014 +0530
fdo#76586 Table column separators from individual cell widths
In the test file Table Grid had only one value for entire table width
while there are two cells in a table row. So the table was not
imported with the correct Column Separators.
Added fix to calculate column seperators from cell widths if
unable to calculate from Table Grid, and all the cells have individual cell
widths and
there are no after and before cells.
Change-Id: I466737437a18d3373e75fea5ad56c9e31eb149ec
Reviewed-on: https://gerrit.libreoffice.org/8767
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/sw/qa/extras/ooxmlexport/data/fdo76586.docx
b/sw/qa/extras/ooxmlexport/data/fdo76586.docx
new file mode 100644
index 000..28ae05e
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo76586.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index de70fa3..fd080d0 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -2983,6 +2983,22 @@ DECLARE_OOXMLEXPORT_TEST(testAuthorPropertySdt,
author-property.docx)
//xmlns:ns0='http://purl.org/dc/elements/1.1/'
xmlns:ns1='http://schemas.openxmlformats.org/package/2006/metadata/core-properties');
}
+DECLARE_OOXMLEXPORT_TEST(testFDO76586, fdo76586.docx)
+{
+/*
+ * In the test file gridCol had only one value for entire table width
+ * while there are two cells in a table row.
+ * So the table was not imported with the correct cell widths
+ */
+xmlDocPtr pXmlDoc = parseExport(word/document.xml);
+
+if (!pXmlDoc)
+ return;
+
+// there is only one table in the test file
+assertXPath(pXmlDoc, //w:tblGrid/w:gridCol[1], w, 1601);
+assertXPath(pXmlDoc, //w:tblGrid/w:gridCol[2], w, 7843);
+}
#endif
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index e463ff1..fa84053 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -710,13 +710,19 @@ void DomainMapperTableManager::endOfRowAction()
#endif
insertRowProps(pPropMap);
}
-else if (pCellWidths-size() 0 m_nLayoutType ==
NS_ooxml::LN_Value_wordprocessingml_ST_TblLayout_fixed)
+else if ( pCellWidths-size() 0
+ ( m_nLayoutType ==
NS_ooxml::LN_Value_wordprocessingml_ST_TblLayout_fixed
+ || pCellWidths-size() == ( m_nGridBefore + nGrids +
m_nGridAfter ) )
+ )
{
// If we're here, then the number of cells does not equal to the amount
// defined by the grid, even after taking care of
// gridSpan/gridBefore/gridAfter. Handle this by ignoring the grid and
// providing the separators based on the provided cell widths, as long
-// as we have a fixed layout.
+// as we have a fixed layout;
+// On the other hand even if the layout is not fixed, but the cell
widths
+// provided equal the total number of cells, and there are no
after/before cells
+// then use the cell widths to calculate the column separators.
uno::Sequence text::TableColumnSeparator
aSeparators(pCellWidths-size() - 1);
text::TableColumnSeparator* pSeparators = aSeparators.getArray();
sal_Int16 nSum = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source vcl/source
sfx2/source/control/dispatch.cxx|5 +++--
vcl/source/filter/graphicfilter.cxx |2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
New commits:
commit e3495f475e5ed2ca5f17a33301f3bf6fdbbf8cf8
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 09:35:58 2014 +0200
GraphicFilter::LoadGraphic: SAL_WARN - SAL_INFO
Only the caller can decide if trying to load a graphic is really a
problem, e.g. in case no persona is configured, then loading its header
is OK.
Change-Id: I7286b7d907940fa3a80f6256cd5264cbd5718fb8
diff --git a/sfx2/source/control/dispatch.cxx b/sfx2/source/control/dispatch.cxx
index 9ab086f..7964446 100644
--- a/sfx2/source/control/dispatch.cxx
+++ b/sfx2/source/control/dispatch.cxx
@@ -2101,8 +2101,9 @@ bool SfxDispatcher::_FillState
if ( !IsInvalidItem(pItem) !pItem-ISA(SfxVoidItem) )
{
sal_uInt16 nSlotId =
rState.GetPool()-GetSlotId(pItem-Which());
-if (!pItem-IsA(pIF-GetSlot(nSlotId)-GetType()-Type()))
-SAL_INFO(sfx.control,
+SAL_INFO_IF(
+!pItem-IsA(pIF-GetSlot(nSlotId)-GetType()-Type()),
+sfx.control,
item-type unequal to IDL (= no BASIC) with SID:
nSlotId in pIF-GetClassName());
}
diff --git a/vcl/source/filter/graphicfilter.cxx
b/vcl/source/filter/graphicfilter.cxx
index 77c25e4..48b88ba 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -2311,7 +2311,7 @@ int GraphicFilter::LoadGraphic( const OUString rPath,
const OUString rFilterNa
break;
}
-SAL_WARN_IF( nRes, vcl.filter, Problem importing graphic rPath
. Reason: aReturnString );
+SAL_INFO_IF( nRes, vcl.filter, Problem importing graphic rPath
. Reason: aReturnString );
#endif
return nRes;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/findsofficepath.c |2 ++ 1 file changed, 2 insertions(+) New commits: commit 6cbf8dacffc3946b0bd4efb1e6d0f2d4fa3874b1 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Apr 2 10:01:17 2014 +0200 Make function prototype visible Change-Id: I7bc497b5acdcc270ad47bbeedff424e9332ae645 diff --git a/cppuhelper/source/findsofficepath.c b/cppuhelper/source/findsofficepath.c index 1c24d80..1bd7368 100644 --- a/cppuhelper/source/findsofficepath.c +++ b/cppuhelper/source/findsofficepath.c @@ -22,6 +22,8 @@ #include stdlib.h #include string.h +#include cppuhelper/findsofficepath.h + #if defined WNT #define WIN32_LEAN_AND_MEAN ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/itiff/lzwdecom.cxx | 42 +++--
1 file changed, 33 insertions(+), 9 deletions(-)
New commits:
commit e326b5e06d74685b1853d61c465e5be0b5bf1595
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:02:19 2014 +0100
detect add to table beyond MAX_TABLE_SIZE
Change-Id: I9b1357e583620c59898cd7a649a5b39a6d7e3739
diff --git a/filter/source/graphicfilter/itiff/lzwdecom.cxx
b/filter/source/graphicfilter/itiff/lzwdecom.cxx
index 1766e5b..0d7970d 100644
--- a/filter/source/graphicfilter/itiff/lzwdecom.cxx
+++ b/filter/source/graphicfilter/itiff/lzwdecom.cxx
@@ -20,14 +20,16 @@
#include lzwdecom.hxx
+#define MAX_TABLE_SIZE 4096
+
LZWDecompressor::LZWDecompressor()
: pOutBufData(NULL)
{
sal_uInt16 i;
-pTable=new LZWTableEntry[4096];
-pOutBuf=new sal_uInt8[4096];
-for (i=0; i4096; i++)
+pTable=new LZWTableEntry[MAX_TABLE_SIZE];
+pOutBuf=new sal_uInt8[MAX_TABLE_SIZE];
+for (i=0; iMAX_TABLE_SIZE; i++)
{
pTable[i].nPrevCode=0;
pTable[i].nDataCount=1;
@@ -144,6 +146,15 @@ sal_uInt16 LZWDecompressor::GetNextCode()
void LZWDecompressor::AddToTable(sal_uInt16 nPrevCode, sal_uInt16
nCodeFirstData)
{
+if (nTableSize = MAX_TABLE_SIZE)
+{
+//It might be possible to force emit a 256 to flush the buffer and try
+//to continue later?
+SAL_WARN(filter.tiff, Too much data at scanline);
+bEOIFound = sal_True;
+return;
+}
+
while (pTable[nCodeFirstData].nDataCount1)
nCodeFirstData=pTable[nCodeFirstData].nPrevCode;
@@ -160,20 +171,33 @@ void LZWDecompressor::DecompressSome()
sal_uInt16 i,nCode;
nCode=GetNextCode();
-if (nCode==256) {
+if (nCode==256)
+{
nTableSize=258;
nCode=GetNextCode();
-if (nCode==257) { bEOIFound=sal_True; return; }
+if (nCode==257)
+{
+bEOIFound=sal_True;
+}
+}
+else if (nCodenTableSize)
+AddToTable(nOldCode,nCode);
+else if (nCode==nTableSize)
+AddToTable(nOldCode,nOldCode);
+else
+{
+bEOIFound=sal_True;
}
-else if (nCodenTableSize) AddToTable(nOldCode,nCode);
-else if (nCode==nTableSize) AddToTable(nOldCode,nOldCode);
-else { bEOIFound=sal_True; return; }
+
+if (bEOIFound)
+return;
nOldCode=nCode;
nOutBufDataLen=pTable[nCode].nDataCount;
pOutBufData=pOutBuf+nOutBufDataLen;
-for (i=0; inOutBufDataLen; i++) {
+for (i=0; inOutBufDataLen; i++)
+{
*(--pOutBufData)=pTable[nCode].nData;
nCode=pTable[nCode].nPrevCode;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/source vcl/win
vcl/source/app/svapp.cxx |5 +++--
vcl/source/app/svdata.cxx | 22 +++---
vcl/win/source/window/salframe.cxx |2 +-
3 files changed, 15 insertions(+), 14 deletions(-)
New commits:
commit d9f425e86d95d6fc9fbf17f85c445875b5855b57
Author: Steve Yin stev...@apache.org
Date: Wed Apr 2 06:08:41 2014 +
Issue 124573 - Office does not start when accessibility is activated.
Fixed access bridge initialization issue in vcl.
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index e8eb02f..978fec7 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -2058,12 +2058,13 @@ sal_Bool Application::IsAccessibilityEnabled()
sal_Bool InitAccessBridge( sal_Bool bShowCancel, sal_Bool rCancelled )
{
-sal_Bool bRet = true;
+sal_Bool bRet = sal_True;
+
+rCancelled = sal_False;
// Disable Java bridge on UNIX and OS/2
#ifndef WNT
(void) bShowCancel; // unsued
-(void) rCancelled; // unused
#else
// Checking HasAtHook() was introduced with IBM's IA2 CWS.
if( HasAtHook() )
diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx
index 7325c09..9d77057 100644
--- a/vcl/source/app/svdata.cxx
+++ b/vcl/source/app/svdata.cxx
@@ -442,7 +442,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
{
rCancelled = sal_False;
-bool bErrorMessage = true;
+sal_Bool bErrorMessage = sal_True;
// Note:
// if bAllowCancel is sal_True we were called from application startup
@@ -452,13 +452,13 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
try
{
-bool bSuccess = true;
+sal_Bool bSuccess = sal_True;
// No error messages when env var is set ..
static const char* pEnv = getenv(SAL_ACCESSIBILITY_ENABLED );
if( pEnv *pEnv )
{
-bErrorMessage = false;
+bErrorMessage = sal_False;
}
ImplSVData* pSVData = ImplGetSVData();
@@ -479,7 +479,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
}
if( !pSVData-mxAccessBridge.is() )
-bSuccess = false;
+bSuccess = sal_False;
return bSuccess;
#endif
css::uno::Reference XExtendedToolkit xToolkit =
@@ -512,7 +512,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
}
if( !pSVData-mxAccessBridge.is() )
-bSuccess = false;
+bSuccess = sal_False;
}
}
@@ -541,7 +541,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
rCancelled = sal_True;
}
-return false;
+return sal_False;
}
catch(::com::sun::star::java::JavaVMCreationFailureException)
@@ -566,7 +566,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
rCancelled = sal_True;
}
-return false;
+return sal_False;
}
catch(::com::sun::star::java::MissingJavaRuntimeException)
@@ -591,7 +591,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
rCancelled = sal_True;
}
-return false;
+return sal_False;
}
catch(::com::sun::star::java::JavaDisabledException)
@@ -616,7 +616,7 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
rCancelled = sal_True;
}
-return false;
+return sal_False;
}
@@ -670,12 +670,12 @@ bool ImplInitAccessBridge(sal_Bool bAllowCancel, sal_Bool
rCancelled)
}
}
-return false;
+return sal_False;
}
catch (...)
{
-return false;
+return sal_False;
}
}
diff --git a/vcl/win/source/window/salframe.cxx
b/vcl/win/source/window/salframe.cxx
index 86ef843..835ea98 100644
--- a/vcl/win/source/window/salframe.cxx
+++ b/vcl/win/source/window/salframe.cxx
@@ -6211,7 +6211,7 @@ LRESULT CALLBACK SalFrameWndProc( HWND hWnd, UINT nMsg,
WPARAM wParam, LPARAM lP
// Make sure to launch Accessibiliity only the
following criterias are satisfied to avoid RFT interrupts regular acc processing
if (g_acc_manager1 == NULL)
{
-sal_Bool bCancelled;
+sal_Bool bCancelled(sal_False);
InitAccessBridge(sal_False,bCancelled);
if( bCancelled )
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - filter/source
filter/source/graphicfilter/itiff/lzwdecom.cxx | 42 +++--
1 file changed, 33 insertions(+), 9 deletions(-)
New commits:
commit 4e2c5ffa89b77e4d6b0a1dc964d330d2ae3636d6
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:02:19 2014 +0100
detect add to table beyond MAX_TABLE_SIZE
Change-Id: I9b1357e583620c59898cd7a649a5b39a6d7e3739
(cherry picked from commit e326b5e06d74685b1853d61c465e5be0b5bf1595)
diff --git a/filter/source/graphicfilter/itiff/lzwdecom.cxx
b/filter/source/graphicfilter/itiff/lzwdecom.cxx
index 2fdb054..4ac9d4c 100644
--- a/filter/source/graphicfilter/itiff/lzwdecom.cxx
+++ b/filter/source/graphicfilter/itiff/lzwdecom.cxx
@@ -20,14 +20,16 @@
#include lzwdecom.hxx
+#define MAX_TABLE_SIZE 4096
+
LZWDecompressor::LZWDecompressor()
: pOutBufData(NULL)
{
sal_uInt16 i;
-pTable=new LZWTableEntry[4096];
-pOutBuf=new sal_uInt8[4096];
-for (i=0; i4096; i++)
+pTable=new LZWTableEntry[MAX_TABLE_SIZE];
+pOutBuf=new sal_uInt8[MAX_TABLE_SIZE];
+for (i=0; iMAX_TABLE_SIZE; i++)
{
pTable[i].nPrevCode=0;
pTable[i].nDataCount=1;
@@ -144,6 +146,15 @@ sal_uInt16 LZWDecompressor::GetNextCode()
void LZWDecompressor::AddToTable(sal_uInt16 nPrevCode, sal_uInt16
nCodeFirstData)
{
+if (nTableSize = MAX_TABLE_SIZE)
+{
+//It might be possible to force emit a 256 to flush the buffer and try
+//to continue later?
+SAL_WARN(filter.tiff, Too much data at scanline);
+bEOIFound = sal_True;
+return;
+}
+
while (pTable[nCodeFirstData].nDataCount1)
nCodeFirstData=pTable[nCodeFirstData].nPrevCode;
@@ -160,20 +171,33 @@ void LZWDecompressor::DecompressSome()
sal_uInt16 i,nCode;
nCode=GetNextCode();
-if (nCode==256) {
+if (nCode==256)
+{
nTableSize=258;
nCode=GetNextCode();
-if (nCode==257) { bEOIFound=sal_True; return; }
+if (nCode==257)
+{
+bEOIFound=sal_True;
+}
+}
+else if (nCodenTableSize)
+AddToTable(nOldCode,nCode);
+else if (nCode==nTableSize)
+AddToTable(nOldCode,nOldCode);
+else
+{
+bEOIFound=sal_True;
}
-else if (nCodenTableSize) AddToTable(nOldCode,nCode);
-else if (nCode==nTableSize) AddToTable(nOldCode,nOldCode);
-else { bEOIFound=sal_True; return; }
+
+if (bEOIFound)
+return;
nOldCode=nCode;
nOutBufDataLen=pTable[nCode].nDataCount;
pOutBufData=pOutBuf+nOutBufDataLen;
-for (i=0; inOutBufDataLen; i++) {
+for (i=0; inOutBufDataLen; i++)
+{
*(--pOutBufData)=pTable[nCode].nData;
nCode=pTable[nCode].nPrevCode;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - filter/source
filter/source/graphicfilter/itiff/lzwdecom.cxx | 42 +++--
1 file changed, 33 insertions(+), 9 deletions(-)
New commits:
commit f1bf1ff3a15af438bdf8c4589c1da0902568ff46
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:02:19 2014 +0100
detect add to table beyond MAX_TABLE_SIZE
Change-Id: I9b1357e583620c59898cd7a649a5b39a6d7e3739
(cherry picked from commit e326b5e06d74685b1853d61c465e5be0b5bf1595)
(cherry picked from commit 4e2c5ffa89b77e4d6b0a1dc964d330d2ae3636d6)
diff --git a/filter/source/graphicfilter/itiff/lzwdecom.cxx
b/filter/source/graphicfilter/itiff/lzwdecom.cxx
index 2fdb054..4ac9d4c 100644
--- a/filter/source/graphicfilter/itiff/lzwdecom.cxx
+++ b/filter/source/graphicfilter/itiff/lzwdecom.cxx
@@ -20,14 +20,16 @@
#include lzwdecom.hxx
+#define MAX_TABLE_SIZE 4096
+
LZWDecompressor::LZWDecompressor()
: pOutBufData(NULL)
{
sal_uInt16 i;
-pTable=new LZWTableEntry[4096];
-pOutBuf=new sal_uInt8[4096];
-for (i=0; i4096; i++)
+pTable=new LZWTableEntry[MAX_TABLE_SIZE];
+pOutBuf=new sal_uInt8[MAX_TABLE_SIZE];
+for (i=0; iMAX_TABLE_SIZE; i++)
{
pTable[i].nPrevCode=0;
pTable[i].nDataCount=1;
@@ -144,6 +146,15 @@ sal_uInt16 LZWDecompressor::GetNextCode()
void LZWDecompressor::AddToTable(sal_uInt16 nPrevCode, sal_uInt16
nCodeFirstData)
{
+if (nTableSize = MAX_TABLE_SIZE)
+{
+//It might be possible to force emit a 256 to flush the buffer and try
+//to continue later?
+SAL_WARN(filter.tiff, Too much data at scanline);
+bEOIFound = sal_True;
+return;
+}
+
while (pTable[nCodeFirstData].nDataCount1)
nCodeFirstData=pTable[nCodeFirstData].nPrevCode;
@@ -160,20 +171,33 @@ void LZWDecompressor::DecompressSome()
sal_uInt16 i,nCode;
nCode=GetNextCode();
-if (nCode==256) {
+if (nCode==256)
+{
nTableSize=258;
nCode=GetNextCode();
-if (nCode==257) { bEOIFound=sal_True; return; }
+if (nCode==257)
+{
+bEOIFound=sal_True;
+}
+}
+else if (nCodenTableSize)
+AddToTable(nOldCode,nCode);
+else if (nCode==nTableSize)
+AddToTable(nOldCode,nOldCode);
+else
+{
+bEOIFound=sal_True;
}
-else if (nCodenTableSize) AddToTable(nOldCode,nCode);
-else if (nCode==nTableSize) AddToTable(nOldCode,nOldCode);
-else { bEOIFound=sal_True; return; }
+
+if (bEOIFound)
+return;
nOldCode=nCode;
nOutBufDataLen=pTable[nCode].nDataCount;
pOutBufData=pOutBuf+nOutBufDataLen;
-for (i=0; inOutBufDataLen; i++) {
+for (i=0; inOutBufDataLen; i++)
+{
*(--pOutBufData)=pTable[nCode].nData;
nCode=pTable[nCode].nPrevCode;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: tools/source
tools/source/generic/poly.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 6efbc4598aea1e87c1569c7beef13d44b1a4202c
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:13:37 2014 +0100
valgrind: Conditional jump or move depends on uninitialised value
Change-Id: I1939d376afe5dd5c67f378ffb2520a066dc99077
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 0c04fc5..c0546d2 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1598,7 +1598,7 @@ SvStream WritePolygon( SvStream rOStream, const
Polygon rPoly )
void Polygon::ImplRead( SvStream rIStream )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
ReadPolygon( rIStream, *this );
rIStream.ReadUChar( bHasPolyFlags );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - tools/source
tools/source/generic/poly.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1742008dd0d83f3e69b6e09d9e3223d0c5d28096
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:13:37 2014 +0100
valgrind: Conditional jump or move depends on uninitialised value
Change-Id: I1939d376afe5dd5c67f378ffb2520a066dc99077
(cherry picked from commit 6efbc4598aea1e87c1569c7beef13d44b1a4202c)
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 31a9bf8..b077e62 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1650,7 +1650,7 @@ SvStream operator( SvStream rOStream, const Polygon
rPoly )
void Polygon::ImplRead( SvStream rIStream )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStream *this
bHasPolyFlags;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - d9/f425e86d95d6fc9fbf17f85c445875b5855b57
d9/f425e86d95d6fc9fbf17f85c445875b5855b57 |1 + 1 file changed, 1 insertion(+) New commits: commit ccfb9056a1671101857ddac875209c4566f95312 Author: Caolán McNamara caol...@redhat.com Date: Wed Apr 2 09:16:01 2014 +0100 Notes added by 'git notes add' diff --git a/d9/f425e86d95d6fc9fbf17f85c445875b5855b57 b/d9/f425e86d95d6fc9fbf17f85c445875b5855b57 new file mode 100644 index 000..9e3bb75 --- /dev/null +++ b/d9/f425e86d95d6fc9fbf17f85c445875b5855b57 @@ -0,0 +1 @@ +prefer: 130833f80e89774269108cf30b2d1155a00354ce ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - tools/source
tools/source/generic/poly.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 8ee76a3e8a3f4e954a280b38236766419956e2c6
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:13:37 2014 +0100
valgrind: Conditional jump or move depends on uninitialised value
Change-Id: I1939d376afe5dd5c67f378ffb2520a066dc99077
(cherry picked from commit 6efbc4598aea1e87c1569c7beef13d44b1a4202c)
(cherry picked from commit 1742008dd0d83f3e69b6e09d9e3223d0c5d28096)
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index c83282c..828420a 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1650,7 +1650,7 @@ SvStream operator( SvStream rOStream, const Polygon
rPoly )
void Polygon::ImplRead( SvStream rIStream )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStream *this
bHasPolyFlags;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sccomp/CppunitTest_sccomp_lpsolver.mk sccomp/Module_sccomp.mk sccomp/qa
sccomp/CppunitTest_sccomp_lpsolver.mk | 50 +
sccomp/Module_sccomp.mk |4 +
sccomp/qa/unit/lpsolver.cxx | 128 ++
3 files changed, 182 insertions(+)
New commits:
commit d059866a38ca555050abea1554ceaf7da98edfac
Author: Matúš Kukan matus.ku...@collabora.com
Date: Tue Apr 1 21:00:47 2014 +0200
sccomp: Add very simple unit test for lp solvers.
Change-Id: I359737ad57decf2b1988afbceab85645fbbf1f33
diff --git a/sccomp/CppunitTest_sccomp_lpsolver.mk
b/sccomp/CppunitTest_sccomp_lpsolver.mk
new file mode 100644
index 000..4cb71fd
--- /dev/null
+++ b/sccomp/CppunitTest_sccomp_lpsolver.mk
@@ -0,0 +1,50 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,sccomp_lpsolver))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sccomp_lpsolver,\
+ sccomp/qa/unit/lpsolver \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,sccomp_lpsolver,\
+ boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_add_defs,sccomp_lpsolver,\
+ $(if $(ENABLE_COINMP), -DENABLE_COINMP) \
+ $(if $(ENABLE_LPSOLVE), -DENABLE_LPSOLVE) \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sccomp_lpsolver,\
+ cppu \
+ sal \
+ sc \
+ test \
+ $(gb_UWINAPI) \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sccomp_lpsolver,\
+ -I$(SRCDIR)/sc/inc \
+ $$(INCLUDE) \
+))
+
+
+$(eval $(call gb_CppunitTest_use_api,sccomp_lpsolver,\
+ offapi \
+ udkapi \
+))
+
+$(eval $(call gb_CppunitTest_use_ure,sccomp_lpsolver))
+
+$(eval $(call gb_CppunitTest_use_rdb,sccomp_lpsolver,services))
+
+$(eval $(call gb_CppunitTest_use_configuration,sccomp_lpsolver))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sccomp/Module_sccomp.mk b/sccomp/Module_sccomp.mk
index 08df52b..40ecd29 100644
--- a/sccomp/Module_sccomp.mk
+++ b/sccomp/Module_sccomp.mk
@@ -28,4 +28,8 @@ $(eval $(call gb_Module_add_l10n_targets,sccomp,\
$(if $(ENABLE_COINMP)$(ENABLE_LPSOLVE), AllLangResTarget_solver) \
))
+$(eval $(call gb_Module_add_check_targets,sccomp,\
+ CppunitTest_sccomp_lpsolver \
+))
+
# vim: set noet sw=4 ts=4:
diff --git a/sccomp/qa/unit/lpsolver.cxx b/sccomp/qa/unit/lpsolver.cxx
new file mode 100644
index 000..75c091b
--- /dev/null
+++ b/sccomp/qa/unit/lpsolver.cxx
@@ -0,0 +1,128 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include sal/config.h
+
+#include com/sun/star/container/XContentEnumerationAccess.hpp
+#include com/sun/star/frame/Desktop.hpp
+#include com/sun/star/lang/XServiceInfo.hpp
+#include com/sun/star/sheet/XSolver.hpp
+#include com/sun/star/sheet/XSolverDescription.hpp
+#include test/bootstrapfixture.hxx
+
+#include address.hxx
+
+using namespace css;
+
+namespace {
+
+class LpSolverTest: public test::BootstrapFixture
+{
+uno::Referencesheet::XSpreadsheetDocument m_xDocument;
+
+void test();
+void testSolver(const uno::Referencesheet::XSolver xSolver);
+
+public:
+virtual void setUp() SAL_OVERRIDE;
+virtual void tearDown() SAL_OVERRIDE;
+
+CPPUNIT_TEST_SUITE(LpSolverTest);
+CPPUNIT_TEST(test);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void LpSolverTest::setUp()
+{
+test::BootstrapFixture::setUp();
+uno::Referenceframe::XDesktop2 xComponentLoader =
frame::Desktop::create(m_xContext);
+uno::Referencelang::XComponent
xComponent(xComponentLoader-loadComponentFromURL(
+private:factory/scalc, _blank, 0,
+uno::Sequence ::com::sun::star::beans::PropertyValue ()));
+m_xDocument.set(xComponent, uno::UNO_QUERY_THROW);
+}
+
+void LpSolverTest::tearDown()
+{
+uno::Referencelang::XComponent(m_xDocument,
uno::UNO_QUERY_THROW)-dispose();
+test::BootstrapFixture::tearDown();
+}
+
+void LpSolverTest::test()
+{
+uno::Referencecontainer::XContentEnumerationAccess xEnAc(
+m_xContext-getServiceManager(), uno::UNO_QUERY_THROW);
+uno::Referencecontainer::XEnumeration xEnum = xEnAc-
+createContentEnumeration( com.sun.star.sheet.Solver );
+CPPUNIT_ASSERT(xEnum.is());
+
+sal_Int32 nCount = 0;
+while (xEnum-hasMoreElements())
+{
+uno::Referenceuno::XInterface xIntFac;
+xEnum-nextElement() = xIntFac;
+CPPUNIT_ASSERT(xIntFac.is());
+uno::Referencelang::XServiceInfo xInfo(xIntFac,
uno::UNO_QUERY_THROW);
+const OUString
[Libreoffice-commits] core.git: 2 commits - sal/Library_sal.mk sal/osl
sal/Library_sal.mk |2
sal/osl/unx/security.c | 501 --
sal/osl/unx/security.cxx | 511 +++
3 files changed, 512 insertions(+), 502 deletions(-)
New commits:
commit 6cd87e5ee27af05cf54ba56d06f519a8f7138e8a
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Apr 2 10:42:34 2014 +0200
coverity#1194930 Avoid TOCTOU between access and mkdir
Change-Id: I6567313abdacd06b59f7004c970b954a4b42419e
diff --git a/sal/osl/unx/security.cxx b/sal/osl/unx/security.cxx
index 77764b5..d2b1c1d 100644
--- a/sal/osl/unx/security.cxx
+++ b/sal/osl/unx/security.cxx
@@ -25,6 +25,7 @@
#include osl/security.h
#include osl/diagnose.h
#include rtl/bootstrap.h
+#include sal/log.hxx
#include osl/thread.h
#include osl/file.h
@@ -395,7 +396,6 @@ static sal_Bool SAL_CALL osl_psz_getConfigDir(oslSecurity
Security, sal_Char* ps
if (pStr == NULL || strlen(pStr) == 0 || access(pStr, 0) != 0)
{
size_t n = 0;
-sal_Bool dirOK = sal_True;
// a default equal to $HOME/.config should be used.
if (!osl_psz_getHomeDir(Security, pszDirectory, nMax))
@@ -406,34 +406,44 @@ static sal_Bool SAL_CALL osl_psz_getConfigDir(oslSecurity
Security, sal_Char* ps
strncpy(pszDirectory+n, DOT_CONFIG, sizeof(DOT_CONFIG));
// try to create dir if not present
-if (access(pszDirectory, F_OK) != 0 mkdir(pszDirectory,
S_IRWXU) != 0)
-dirOK = sal_False;
-else
+bool dirOK = true;
+if (mkdir(pszDirectory, S_IRWXU) != 0)
+{
+int e = errno;
+if (e != EEXIST)
+{
+SAL_WARN(
+sal.osl,
+mkdir( pszDirectory ): errno= e);
+dirOK = false;
+}
+}
+if (dirOK)
{
// check file type and permissions
struct stat st;
if (stat(pszDirectory, st) != 0)
{
OSL_TRACE(Could not stat $HOME/.config);
-dirOK = sal_False;
+dirOK = false;
}
else
{
if (!S_ISDIR(st.st_mode))
{
OSL_TRACE($HOME/.config is not a directory);
-dirOK = sal_False;
+dirOK = false;
}
if (!(st.st_mode S_IRUSR st.st_mode S_IWUSR
st.st_mode S_IXUSR))
{
OSL_TRACE($HOME/.config has bad permissions);
-dirOK = sal_False;
+dirOK = false;
}
}
}
// resort to HOME
-if (dirOK == sal_False)
+if (!dirOK)
pszDirectory[n] = '\0';
}
}
commit d37e9645edbdabaaf16ce0f1f904405f3477dc41
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Apr 2 10:36:04 2014 +0200
sal/osl/unx/security.c - .cxx
Change-Id: If8dbfa3e26a02ac3d5ee0077f730eeca4b59c4d7
diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk
index ec8d89b..2103fe8 100644
--- a/sal/Library_sal.mk
+++ b/sal/Library_sal.mk
@@ -164,6 +164,7 @@ $(eval $(call gb_Library_add_exception_objects,sal,\
sal/osl/unx/process \
sal/osl/unx/process_impl \
sal/osl/unx/profile \
+ sal/osl/unx/security \
$(if $(filter DESKTOP,$(BUILD_TYPE)), sal/osl/unx/salinit) \
))
$(eval $(call gb_Library_add_cobjects,sal,\
@@ -172,7 +173,6 @@ $(eval $(call gb_Library_add_cobjects,sal,\
sal/osl/unx/nlsupport \
sal/osl/unx/pipe \
sal/osl/unx/readwrite_helper \
- sal/osl/unx/security \
sal/osl/unx/socket \
sal/osl/unx/system \
sal/osl/unx/tempfile \
diff --git a/sal/osl/unx/security.c b/sal/osl/unx/security.cxx
similarity index 97%
rename from sal/osl/unx/security.c
rename to sal/osl/unx/security.cxx
index 3806a0f..77764b5 100644
--- a/sal/osl/unx/security.c
+++ b/sal/osl/unx/security.cxx
@@ -43,7 +43,7 @@
static oslSecurityError SAL_CALL
osl_psz_loginUser(const sal_Char* pszUserName, const sal_Char* pszPasswd,
oslSecurity* pSecurity);
-sal_Bool SAL_CALL osl_psz_getUserIdent(oslSecurity Security, sal_Char
*pszIdent, sal_uInt32 nMax);
+extern C sal_Bool SAL_CALL osl_psz_getUserIdent(oslSecurity Security,
sal_Char *pszIdent, sal_uInt32 nMax);
static sal_Bool SAL_CALL osl_psz_getUserName(oslSecurity Security, sal_Char*
pszName, sal_uInt32 nMax);
static sal_Bool SAL_CALL osl_psz_getHomeDir(oslSecurity Security, sal_Char*
pszDirectory, sal_uInt32 nMax);
static sal_Bool SAL_CALL osl_psz_getConfigDir(oslSecurity Security, sal_Char*
pszDirectory, sal_uInt32 nMax);
@@ -91,7 +91,7 @@
[Libreoffice-commits] core.git: vbahelper/source
vbahelper/source/vbahelper/vbahelper.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 6d20b453b6e667dee18bc456249279805aa08755
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Apr 2 10:52:04 2014 +0200
coverity#1194895 Logically dead code
Change-Id: I24e8ee88a1efdfaa7cedf996bd2d3bb05fbd4dc6
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx
b/vbahelper/source/vbahelper/vbahelper.cxx
index 5c11fbd..90efa1e 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -515,12 +515,11 @@ ContainerUtilities::getUniqueName( const uno::Sequence
OUString _slist, cons
{
sal_Int32 a = _nStartSuffix;
OUString scompname = _sElementName;
-bool bElementexists = true;
sal_Int32 nLen = _slist.getLength();
if ( nLen == 0 )
return _sElementName;
-while (bElementexists == true)
+for (;;)
{
for (sal_Int32 i = 0; i nLen; i++)
{
@@ -531,7 +530,6 @@ ContainerUtilities::getUniqueName( const uno::Sequence
OUString _slist, cons
}
scompname = _sElementName + _sSuffixSeparator + OUString::number( a++
);
}
-return OUString();
}
sal_Int32
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: tools/source vcl/source
tools/source/generic/poly.cxx |2 -
vcl/source/gdi/metaact.cxx| 77 ++
2 files changed, 43 insertions(+), 36 deletions(-)
New commits:
commit 67c6ea0c426c2796fc1b80cbe2cb0347686db90d
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:33:03 2014 +0100
init a few more stream-read svm elements
Change-Id: I3dfa2485afbe66131b86764374d53181b55c2346
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index c0546d2..9cbd48f 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1520,7 +1520,7 @@ SvStream ReadPolygon( SvStream rIStream, Polygon rPoly
)
DBG_ASSERTWARNING( rIStream.GetVersion(), Polygon:: - Solar-Version not
set on rIStream );
sal_uInt16 i;
-sal_uInt16 nPoints;
+sal_uInt16 nPoints(0);
// read all points and create array
rIStream.ReadUInt16( nPoints );
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index 75f1465..abd250d 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -1001,7 +1001,7 @@ void MetaPolyLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
ReadLineInfo( rIStm, maLineInfo );
if ( aCompat.GetVersion() = 3 )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStm.ReadUChar( bHasPolyFlags );
if ( bHasPolyFlags )
maPoly.Read( rIStm );
@@ -1183,10 +1183,11 @@ void MetaPolyPolygonAction::Read( SvStream rIStm,
ImplMetaReadData* )
if ( aCompat.GetVersion() = 2 )// Version 2
{
-sal_uInt16 i, nIndex, nNumberOfComplexPolygons;
+sal_uInt16 nNumberOfComplexPolygons(0);
rIStm.ReadUInt16( nNumberOfComplexPolygons );
-for ( i = 0; i nNumberOfComplexPolygons; i++ )
+for (sal_uInt16 i = 0; i nNumberOfComplexPolygons; ++i)
{
+sal_uInt16 nIndex(0);
rIStm.ReadUInt16( nIndex );
Polygon aPoly;
aPoly.Read( rIStm );
@@ -1271,11 +1272,12 @@ void MetaTextAction::Read( SvStream rIStm,
ImplMetaReadData* pData )
COMPAT( rIStm );
ReadPair( rIStm, maPt );
maStr = rIStm.ReadUniOrByteString(pData-meActualCharSet);
-sal_uInt16 nTmp(0);
-rIStm.ReadUInt16(nTmp);
-mnIndex = nTmp;
-rIStm.ReadUInt16(nTmp);
-mnLen = nTmp;
+sal_uInt16 nTmpIndex(0);
+rIStm.ReadUInt16(nTmpIndex);
+mnIndex = nTmpIndex;
+sal_uInt16 nTmpLen(0);
+rIStm.ReadUInt16(nTmpLen);
+mnLen = nTmpLen;
if ( aCompat.GetVersion() = 2 )// Version 2
maStr = read_uInt16_lenPrefixed_uInt16s_ToOUString(rIStm);
@@ -1419,13 +1421,15 @@ void MetaTextArrayAction::Read( SvStream rIStm,
ImplMetaReadData* pData )
COMPAT( rIStm );
ReadPair( rIStm, maStartPt );
maStr = rIStm.ReadUniOrByteString(pData-meActualCharSet);
-sal_uInt16 nTmp(0);
-rIStm.ReadUInt16(nTmp);
-mnIndex = nTmp;
-rIStm.ReadUInt16(nTmp);
-mnLen = nTmp;
-rIStm.ReadUInt16(nTmp);
-nAryLen = nTmp;
+sal_uInt16 nTmpIndex(0);
+rIStm.ReadUInt16(nTmpIndex);
+mnIndex = nTmpIndex;
+sal_uInt16 nTmpLen(0);
+rIStm.ReadUInt16(nTmpLen);
+mnLen = nTmpLen;
+sal_uInt16 nTmpAryLen(0);
+rIStm.ReadUInt16(nTmpAryLen);
+nAryLen = nTmpAryLen;
if ( mnIndex + mnLen maStr.getLength() )
{
@@ -1554,11 +1558,12 @@ void MetaStretchTextAction::Read( SvStream rIStm,
ImplMetaReadData* pData )
ReadPair( rIStm, maPt );
maStr = rIStm.ReadUniOrByteString(pData-meActualCharSet);
rIStm.ReadUInt32( mnWidth );
-sal_uInt16 nTmp(0);
-rIStm.ReadUInt16(nTmp);
-mnIndex = nTmp;
-rIStm.ReadUInt16(nTmp);
-mnLen = nTmp;
+sal_uInt16 nTmpIndex(0);
+rIStm.ReadUInt16(nTmpIndex);
+mnIndex = nTmpIndex;
+sal_uInt16 nTmpLen(0);
+rIStm.ReadUInt16(nTmpLen);
+mnLen = nTmpLen;
if ( aCompat.GetVersion() = 2 )// Version 2
maStr = read_uInt16_lenPrefixed_uInt16s_ToOUString(rIStm);
@@ -1726,18 +1731,20 @@ void MetaTextLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
COMPAT( rIStm );
//#fdo39428 SvStream no longer supports operator(long)
-sal_uInt32 nTemp;
-sal_Int32 nTemp2;
+sal_Int32 nTempWidth(0);
ReadPair( rIStm, maPos );
-rIStm.ReadInt32( nTemp2 );
-mnWidth = nTemp2;
-rIStm.ReadUInt32( nTemp );
-meStrikeout = (FontStrikeout)nTemp;
-rIStm.ReadUInt32( nTemp );
-meUnderline = (FontUnderline)nTemp;
+rIStm.ReadInt32( nTempWidth );
+mnWidth = nTempWidth;
+sal_uInt32 nTempStrikeout(0);
+rIStm.ReadUInt32( nTempStrikeout );
+meStrikeout = (FontStrikeout)nTempStrikeout;
+sal_uInt32 nTempUnderline(0);
+rIStm.ReadUInt32( nTempUnderline );
+meUnderline = (FontUnderline)nTempUnderline;
if ( aCompat.GetVersion() = 2 ) {
-rIStm.ReadUInt32( nTemp );
-
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - tools/source vcl/source
tools/source/generic/poly.cxx |2 +-
vcl/source/gdi/metaact.cxx| 39 +--
2 files changed, 22 insertions(+), 19 deletions(-)
New commits:
commit 21212a65c5653bdc38cea426710e68ed40c66eb8
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:33:03 2014 +0100
init a few more stream-read svm elements
(cherry picked from commit 67c6ea0c426c2796fc1b80cbe2cb0347686db90d)
Conflicts:
vcl/source/gdi/metaact.cxx
Change-Id: I3dfa2485afbe66131b86764374d53181b55c2346
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index b077e62..1caec37 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1567,7 +1567,7 @@ SvStream operator( SvStream rIStream, Polygon rPoly )
DBG_ASSERTWARNING( rIStream.GetVersion(), Polygon:: - Solar-Version not
set on rIStream );
sal_uInt16 i;
-sal_uInt16 nPoints;
+sal_uInt16 nPoints(0);
// read all points and create array
rIStream nPoints;
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index e7aed0d..2bc51b4 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -984,7 +984,7 @@ void MetaPolyLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
rIStm maLineInfo;
if ( aCompat.GetVersion() = 3 )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStm bHasPolyFlags;
if ( bHasPolyFlags )
maPoly.Read( rIStm );
@@ -1166,10 +1166,11 @@ void MetaPolyPolygonAction::Read( SvStream rIStm,
ImplMetaReadData* )
if ( aCompat.GetVersion() = 2 )// Version 2
{
-sal_uInt16 i, nIndex, nNumberOfComplexPolygons;
+sal_uInt16 nNumberOfComplexPolygons(0);
rIStm nNumberOfComplexPolygons;
-for ( i = 0; i nNumberOfComplexPolygons; i++ )
+for (sal_uInt16 i = 0; i nNumberOfComplexPolygons; ++i)
{
+sal_uInt16 nIndex(0);
rIStm nIndex;
Polygon aPoly;
aPoly.Read( rIStm );
@@ -1699,18 +1700,20 @@ void MetaTextLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
COMPAT( rIStm );
//#fdo39428 SvStream no longer supports operator(long)
-sal_uInt32 nTemp;
-sal_Int32 nTemp2;
rIStm maPos;
-rIStm nTemp2;
-mnWidth = nTemp2;
-rIStm nTemp;
-meStrikeout = (FontStrikeout)nTemp;
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_Int32 nTempWidth(0);
+rIStm nTempWidth;
+mnWidth = nTempWidth;
+sal_uInt32 nTempStrikeout(0);
+rIStm nTempStrikeout;
+meStrikeout = (FontStrikeout)nTempStrikeout;
+sal_uInt32 nTempUnderline(0);
+rIStm nTempUnderline;
+meUnderline = (FontUnderline)nTempUnderline;
if ( aCompat.GetVersion() = 2 ) {
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_uInt32 nTempUnderline2(0);
+rIStm nTempUnderline2;
+meUnderline = (FontUnderline)nTempUnderline2;
}
}
@@ -3375,7 +3378,7 @@ void MetaTextAlignAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaTextAlignAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; maAlign = (TextAlign) nTmp16;
@@ -3650,7 +3653,7 @@ void MetaRasterOpAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaRasterOpAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; meRasterOp = (RasterOp) nTmp16;
@@ -4117,9 +4120,9 @@ void MetaCommentAction::Scale( double fXScale, double
fYScale )
SvMemoryStream aMemStm( (void*)mpData, mnDataSize,
STREAM_READ );
SvMemoryStream aDest;
-sal_Int32 nLeft, nRight, nTop, nBottom;
-sal_Int32 nPixX, nPixY, nMillX, nMillY;
-float m11, m12, m21, m22, mdx, mdy;
+sal_Int32 nLeft(0), nRight(0), nTop(0), nBottom(0);
+sal_Int32 nPixX(0), nPixY(0), nMillX(0), nMillY(0);
+float m11(0), m12(0), m21(0), m22(0), mdx(0), mdy(0);
// read data
aMemStm nLeft nTop nRight nBottom;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - tools/source vcl/source
tools/source/generic/poly.cxx |2 +-
vcl/source/gdi/metaact.cxx| 39 +--
2 files changed, 22 insertions(+), 19 deletions(-)
New commits:
commit 8b5514ac364c65a5dec16e20dc6983094535e62c
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:33:03 2014 +0100
init a few more stream-read svm elements
(cherry picked from commit 67c6ea0c426c2796fc1b80cbe2cb0347686db90d)
Conflicts:
vcl/source/gdi/metaact.cxx
Change-Id: I3dfa2485afbe66131b86764374d53181b55c2346
(cherry picked from commit 21212a65c5653bdc38cea426710e68ed40c66eb8)
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 828420a..689f35a 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1567,7 +1567,7 @@ SvStream operator( SvStream rIStream, Polygon rPoly )
DBG_ASSERTWARNING( rIStream.GetVersion(), Polygon:: - Solar-Version not
set on rIStream );
sal_uInt16 i;
-sal_uInt16 nPoints;
+sal_uInt16 nPoints(0);
// read all points and create array
rIStream nPoints;
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index 2ab9faa..57accdd 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -981,7 +981,7 @@ void MetaPolyLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
rIStm maLineInfo;
if ( aCompat.GetVersion() = 3 )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStm bHasPolyFlags;
if ( bHasPolyFlags )
maPoly.Read( rIStm );
@@ -1163,10 +1163,11 @@ void MetaPolyPolygonAction::Read( SvStream rIStm,
ImplMetaReadData* )
if ( aCompat.GetVersion() = 2 )// Version 2
{
-sal_uInt16 i, nIndex, nNumberOfComplexPolygons;
+sal_uInt16 nNumberOfComplexPolygons(0);
rIStm nNumberOfComplexPolygons;
-for ( i = 0; i nNumberOfComplexPolygons; i++ )
+for (sal_uInt16 i = 0; i nNumberOfComplexPolygons; ++i)
{
+sal_uInt16 nIndex(0);
rIStm nIndex;
Polygon aPoly;
aPoly.Read( rIStm );
@@ -1696,18 +1697,20 @@ void MetaTextLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
COMPAT( rIStm );
//#fdo39428 SvStream no longer supports operator(long)
-sal_uInt32 nTemp;
-sal_Int32 nTemp2;
rIStm maPos;
-rIStm nTemp2;
-mnWidth = nTemp2;
-rIStm nTemp;
-meStrikeout = (FontStrikeout)nTemp;
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_Int32 nTempWidth(0);
+rIStm nTempWidth;
+mnWidth = nTempWidth;
+sal_uInt32 nTempStrikeout(0);
+rIStm nTempStrikeout;
+meStrikeout = (FontStrikeout)nTempStrikeout;
+sal_uInt32 nTempUnderline(0);
+rIStm nTempUnderline;
+meUnderline = (FontUnderline)nTempUnderline;
if ( aCompat.GetVersion() = 2 ) {
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_uInt32 nTempUnderline2(0);
+rIStm nTempUnderline2;
+meUnderline = (FontUnderline)nTempUnderline2;
}
}
@@ -3356,7 +3359,7 @@ void MetaTextAlignAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaTextAlignAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; maAlign = (TextAlign) nTmp16;
@@ -3632,7 +3635,7 @@ void MetaRasterOpAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaRasterOpAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; meRasterOp = (RasterOp) nTmp16;
@@ -4085,9 +4088,9 @@ void MetaCommentAction::Scale( double fXScale, double
fYScale )
SvMemoryStream aMemStm( (void*)mpData, mnDataSize,
STREAM_READ );
SvMemoryStream aDest;
-sal_Int32 nLeft, nRight, nTop, nBottom;
-sal_Int32 nPixX, nPixY, nMillX, nMillY;
-float m11, m12, m21, m22, mdx, mdy;
+sal_Int32 nLeft(0), nRight(0), nTop(0), nBottom(0);
+sal_Int32 nPixX(0), nPixY(0), nMillX(0), nMillY(0);
+float m11(0), m12(0), m21(0), m22(0), mdx(0), mdy(0);
// read data
aMemStm nLeft nTop nRight nBottom;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/uiconfig
vcl/uiconfig/ui/printdialog.ui | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit f85db6b7999d8d4f9f54a0699b73641934d7e441 Author: Caolán McNamara caol...@redhat.com Date: Mon Mar 31 16:04:14 2014 +0100 Resolves: fdo#63228 Printers list does not increase height with Print Dialog (cherry picked from commit e764b46eea2aab37b7f62d6bf495d2b80080e3b2) Change-Id: I731fe5159bead1dc0036ede8d4cd26c233e3b296 Reviewed-on: https://gerrit.libreoffice.org/8803 Reviewed-by: Matúš Kukan matus.ku...@collabora.com Tested-by: Matúš Kukan matus.ku...@collabora.com diff --git a/vcl/uiconfig/ui/printdialog.ui b/vcl/uiconfig/ui/printdialog.ui index 2aa464b..37c7d44 100644 --- a/vcl/uiconfig/ui/printdialog.ui +++ b/vcl/uiconfig/ui/printdialog.ui @@ -90,11 +90,15 @@ object class=GtkBox id=box1 property name=visibleTrue/property property name=can_focusFalse/property +property name=hexpandTrue/property +property name=vexpandTrue/property property name=spacing6/property child object class=GtkBox id=box2 property name=visibleTrue/property property name=can_focusFalse/property +property name=hexpandTrue/property +property name=vexpandTrue/property property name=orientationvertical/property property name=spacing6/property child @@ -188,10 +192,12 @@ object class=GtkNotebook id=tabcontrol property name=visibleTrue/property property name=can_focusTrue/property +property name=vexpandTrue/property child object class=GtkBox id=box3 property name=visibleTrue/property property name=can_focusFalse/property +property name=vexpandTrue/property property name=border_width6/property property name=orientationvertical/property property name=spacing6/property @@ -199,19 +205,20 @@ object class=GtkFrame id=frame1 property name=visibleTrue/property property name=can_focusFalse/property +property name=vexpandTrue/property property name=label_xalign0/property property name=shadow_typenone/property child object class=GtkAlignment id=alignment3 property name=visibleTrue/property property name=can_focusFalse/property +property name=vexpandTrue/property property name=top_padding6/property property name=left_padding12/property child object class=GtkGrid id=grid4 property name=visibleTrue/property property name=can_focusFalse/property -property name=hexpandTrue/property property name=vexpandTrue/property property name=row_spacing6/property child @@ -348,6 +355,7 @@ property name=height_request100/property property name=visibleTrue/property property name=can_focusTrue/property +property name=vexpandTrue/property child internal-child=selection object class=GtkTreeSelection id=treeview-selection/ /child ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Contribution to Impress media controls
(I'm a colleague of Remi, participating in the project where students contribute to open source projects) Tomaž Vajngerl wrote: Maybe it would be the best if the students address the whole development community (on IRC for simple questions or mailing list for more complex questions). My experience is that having a mentor greatly helps students. Of course, interaction with the rest of the community is still encouraged, but it's hard for inexperienced students to find their way in a large community without individual help. You may see our school project like a mini-Google summer of code. GSoC mentors do not replace the community, but they are definitely very helpful. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- View this message in context: http://nabble.documentfoundation.org/Contribution-to-Impress-media-controls-tp4103046p4103784.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/nodedump.cxx | 35 +++
1 file changed, 35 insertions(+)
New commits:
commit b0606fa6f8ab8bc3ee8b90eaedb34019c4d6657d
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 11:22:51 2014 +0200
sw doc model dump: include contents of draw page
Change-Id: I8f1687ba7aacfff47695fd43062c92d2eb034a29
diff --git a/sw/source/core/docnode/nodedump.cxx
b/sw/source/core/docnode/nodedump.cxx
index d6e1207..aee1ca2 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -26,6 +26,8 @@
#include editeng/rsiditem.hxx
#include editeng/fontitem.hxx
#include editeng/fhgtitem.hxx
+#include svx/svdpage.hxx
+#include svx/svdmodel.hxx
#include tools/datetimeutils.hxx
#include libxml/encoding.h
@@ -109,6 +111,38 @@ static const char* TMP_FORMAT_I32 = % SAL_PRIdINT32;
}
+void lcl_dumpSdrModel(WriterHelper writer, const SdrModel* pModel)
+{
+writer.startElement(sdrModel);
+writer.writeFormatAttribute(ptr, %p, pModel);
+if (pModel)
+{
+const SdrPage* pPage = pModel-GetPage(0);
+writer.startElement(sdrPage);
+writer.writeFormatAttribute(ptr, %p, pPage);
+if (pPage)
+{
+sal_Int32 nObjCount = pPage-GetObjCount();
+for (sal_Int32 i = 0; i nObjCount; ++i)
+{
+SdrObject* pObject = pPage-GetObj(i);
+writer.startElement(sdrObject);
+writer.writeFormatAttribute(ptr, %p, pObject);
+if (pObject)
+{
+writer.writeFormatAttribute(symbol, %s,
BAD_CAST(typeid(*pObject).name()));
+writer.writeFormatAttribute(name, %s,
BAD_CAST(OUStringToOString(pObject-GetName(),
RTL_TEXTENCODING_UTF8).getStr()));
+writer.writeFormatAttribute(title, %s,
BAD_CAST(OUStringToOString(pObject-GetTitle(),
RTL_TEXTENCODING_UTF8).getStr()));
+writer.writeFormatAttribute(description, %s,
BAD_CAST(OUStringToOString(pObject-GetDescription(),
RTL_TEXTENCODING_UTF8).getStr()));
+}
+writer.endElement();
+}
+}
+writer.endElement();
+}
+writer.endElement();
+}
+
void SwDoc::dumpAsXml( xmlTextWriterPtr w )
{
WriterHelper writer( w );
@@ -122,6 +156,7 @@ void SwDoc::dumpAsXml( xmlTextWriterPtr w )
mpNumRuleTbl-dumpAsXml( writer );
mpRedlineTbl-dumpAsXml( writer );
mpExtraRedlineTbl-dumpAsXml( writer );
+lcl_dumpSdrModel( writer, mpDrawModel );
writer.endElement();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/nodedump.cxx | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
New commits:
commit 82332ee1fc23b6fdccaf92149c0f2fa46fcdc4d6
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 11:59:47 2014 +0200
sw doc model dump: handle SdrObject text
Change-Id: I0b11aaa3efd5176a3a7c124bd15d50962ee7e90e
diff --git a/sw/source/core/docnode/nodedump.cxx
b/sw/source/core/docnode/nodedump.cxx
index aee1ca2..dbdf480 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -26,6 +26,8 @@
#include editeng/rsiditem.hxx
#include editeng/fontitem.hxx
#include editeng/fhgtitem.hxx
+#include editeng/editobj.hxx
+#include editeng/outlobj.hxx
#include svx/svdpage.hxx
#include svx/svdmodel.hxx
#include tools/datetimeutils.hxx
@@ -125,7 +127,7 @@ void lcl_dumpSdrModel(WriterHelper writer, const SdrModel*
pModel)
sal_Int32 nObjCount = pPage-GetObjCount();
for (sal_Int32 i = 0; i nObjCount; ++i)
{
-SdrObject* pObject = pPage-GetObj(i);
+const SdrObject* pObject = pPage-GetObj(i);
writer.startElement(sdrObject);
writer.writeFormatAttribute(ptr, %p, pObject);
if (pObject)
@@ -134,6 +136,22 @@ void lcl_dumpSdrModel(WriterHelper writer, const
SdrModel* pModel)
writer.writeFormatAttribute(name, %s,
BAD_CAST(OUStringToOString(pObject-GetName(),
RTL_TEXTENCODING_UTF8).getStr()));
writer.writeFormatAttribute(title, %s,
BAD_CAST(OUStringToOString(pObject-GetTitle(),
RTL_TEXTENCODING_UTF8).getStr()));
writer.writeFormatAttribute(description, %s,
BAD_CAST(OUStringToOString(pObject-GetDescription(),
RTL_TEXTENCODING_UTF8).getStr()));
+
+const OutlinerParaObject* pOutliner =
pObject-GetOutlinerParaObject();
+writer.startElement(outliner);
+writer.writeFormatAttribute(ptr, %p, pOutliner);
+if (pOutliner)
+{
+const EditTextObject rEditObj =
pOutliner-GetTextObject();
+sal_Int32 nPara = rEditObj.GetParagraphCount();
+for (sal_Int32 j = 0; j nPara; ++j)
+{
+writer.startElement(paragraph);
+xmlTextWriterWriteString(writer,
BAD_CAST(OUStringToOString(rEditObj.GetText(j),
RTL_TEXTENCODING_UTF8).getStr()));
+writer.endElement();
+}
+}
+writer.endElement();
}
writer.endElement();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 7 commits - avmedia/Library_avmedia.mk avmedia/source external/boost include/avmedia include/sal sd/source svx/source xmloff/source
avmedia/Library_avmedia.mk |1
avmedia/source/framework/mediaitem.cxx | 11 -
avmedia/source/framework/modeltools.cxx | 198 +++
external/boost/UnpackedTarball_boost.mk |1
external/boost/boost.jsonparser.warnings.patch.0 | 58 ++
external/boost/boost.libcdr.warnings.patch.1 | 97 ---
include/avmedia/mediaitem.hxx|5
include/avmedia/modeltools.hxx | 22 ++
include/sal/log-areas.dox|6
sd/source/ui/func/fuinsert.cxx |4
sd/source/ui/inc/View.hxx|7
sd/source/ui/view/sdview4.cxx| 34 +++
svx/source/svdraw/svdomedia.cxx | 70 +++-
xmloff/source/draw/shapeexport.cxx | 64 +++
xmloff/source/draw/ximpshap.cxx |3
15 files changed, 466 insertions(+), 115 deletions(-)
New commits:
commit e341ea3863bd19a2884083d2957273cc3572f989
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Tue Apr 1 19:22:52 2014 +0200
ODF import of glTF 3D models
Change-Id: I42f7bc63c1f75592ab628407b40d40536e58f18c
diff --git a/xmloff/source/draw/ximpshap.cxx b/xmloff/source/draw/ximpshap.cxx
index df6b191..aefffce 100644
--- a/xmloff/source/draw/ximpshap.cxx
+++ b/xmloff/source/draw/ximpshap.cxx
@@ -3062,7 +3062,8 @@ void SdXMLPluginShapeContext::StartElement( const
::com::sun::star::uno::Referen
if( nPrefix == XML_NAMESPACE_DRAW IsXMLToken( aLocalName,
XML_MIME_TYPE ) )
{
-if( xAttrList-getValueByIndex( n ).equalsAscii(
application/vnd.sun.star.media ) )
+if( xAttrList-getValueByIndex( n ).equalsAscii(
application/vnd.sun.star.media ) ||
+xAttrList-getValueByIndex( n ).equalsAscii(
application/vnd.gltf+json ))
mbMedia = true;
// leave this loop
commit f7a5ed9b4b34264252be48488cf23c052a2276c2
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Wed Apr 2 11:58:11 2014 +0200
Store glTF related files in a temp folder which URL can be given to the
player
media::XPlayer is constructed by media::XManager with
only one URL parameter.
Change-Id: I3693bce5386ea7f75fa7d9f1a7d744f90440d62b
diff --git a/svx/source/svdraw/svdomedia.cxx b/svx/source/svdraw/svdomedia.cxx
index 24199a9..e60b446 100644
--- a/svx/source/svdraw/svdomedia.cxx
+++ b/svx/source/svdraw/svdomedia.cxx
@@ -38,7 +38,9 @@
#include svx/sdr/contact/viewcontactofsdrmediaobj.hxx
#include avmedia/mediawindow.hxx
-
+// For handling of glTF models
+#include unotools/tempfile.hxx
+#include tools/urlobj.hxx
using namespace ::com::sun::star;
@@ -294,6 +296,65 @@ uno::Referenceio::XInputStream
SdrMediaObj::GetInputStream()
return tempFile.openStream();
}
+static bool lcl_HandleJsonPackageURL(
+const OUString rURL,
+SdrModel* const pModel,
+OUString o_rTempFileURL)
+{
+// Create a temporary folder which will contain all files of glTF model
+const OUString sTempFolder = ::utl::TempFile( NULL, true ).GetURL();
+
+const sal_uInt16 nPackageLength =
OString(vnd.sun.star.Package:).getLength();
+const OUString sUrlPath =
rURL.copy(nPackageLength,rURL.lastIndexOf(/)-nPackageLength);
+try
+{
+// Base storage:
+uno::Referencedocument::XStorageBasedDocument const xSBD(
+pModel-getUnoModel(), uno::UNO_QUERY_THROW);
+const uno::Referenceembed::XStorage xStorage(
+xSBD-getDocumentStorage(), uno::UNO_QUERY_THROW);
+
+// Model source
+::comphelper::LifecycleProxy proxy;
+const uno::Referenceembed::XStorage xModelStorage(
+::comphelper::OStorageHelper::GetStorageAtPath(xStorage, sUrlPath,
+embed::ElementModes::READ, proxy));
+
+// Copy all files of glTF model from storage to the temp folder
+uno::Reference container::XNameAccess xNameAccess( xModelStorage,
uno::UNO_QUERY );
+const uno::Sequence OUString aFilenames =
xNameAccess-getElementNames();
+for( sal_Int32 nFileIndex = 0; nFileIndex aFilenames.getLength();
++nFileIndex )
+{
+// Generate temp file path
+const OUString rFilename = aFilenames[nFileIndex];
+INetURLObject aUrlObj(sTempFolder);
+aUrlObj.insertName(rFilename);
+const OUString sFilepath = aUrlObj.GetMainURL(
INetURLObject::NO_DECODE );
+
+// Media URL will point at json file
+if( rFilename.endsWith(.json) )
+o_rTempFileURL = sFilepath;
+
+// Create temp file and fill it from storage
+::ucbhelper::Content aTargetContent(sFilepath,
+uno::Referenceucb::XCommandEnvironment(),
comphelper::getProcessComponentContext());
+
+uno::Referenceio::XStream const xStream(
+
[Libreoffice-commits] core.git: 4 commits - bin/convwatch.py vcl/README vcl/source
bin/convwatch.py |6 +-
vcl/README| 36
vcl/source/gdi/pdfwriter_impl.cxx | 19 ++-
vcl/source/gdi/pdfwriter_impl.hxx |4 +++-
4 files changed, 54 insertions(+), 11 deletions(-)
New commits:
commit e8062623355fcf3e65beae7f8f5e4d46384141f2
Author: Michael Stahl mst...@redhat.com
Date: Wed Apr 2 11:09:46 2014 +0200
fdo#63786 rhbz#1081968: fix PDF export of cropped SVG
When a META_FLOATTRANSPARENT_ACTION is exported, the
beginTransparencyGroup()/endTransparencyGroup() will write something
like Q 0 0 0 rg where the Q clears the previously set clipping region,
which is then not restored.
bdf75c7d9bce985ed10a9c41d03420f33ce82142 appears to be a fix for a
previous related problem; this essentially reverts it since it
introduced the current cropping problem. (Particularly funny is the
comment force reemitting clip region since the commit does the
opposite.)
It does not really make sense to me to write something to the page
content stream from beginRedirect()/endRedirect(), because that does not
actually have any effect on the _content_ of the substream, because the
referencing of the substream is only written _after_ endRedirect()
returns, so basically what is written can in the best case cancel itself
out and in the worst case introduce bugs; the state manipulations there
are just to modify the m_aCurrentPDFState following the push()/pop() (it
is necessary to clear the clip region before starting the substream to
avoid spurious Q at the beginning of the stream).
Change-Id: I4a5f57b784068bd7d3ba187115444574f7418195
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index b37c880..6646c7b 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8656,9 +8656,12 @@ void PDFWriterImpl::beginRedirect( SvStream* pStream,
const Rectangle rTargetRe
{
push( PUSH_ALL );
-// force reemitting clip region
+// force reemitting clip region inside the new stream, and
+// prevent emitting an unbalanced Q at the start
clearClipRegion();
-updateGraphicsState();
+// this is needed to point m_aCurrentPDFState at the pushed state
+// ... but it's pointless to actually write into the outer stream here!
+updateGraphicsState(NOWRITE);
m_aOutputStreams.push_front( StreamRedirect() );
m_aOutputStreams.front().m_pStream = pStream;
@@ -8695,14 +8698,12 @@ SvStream* PDFWriterImpl::endRedirect()
}
pop();
-// force reemitting colors and clip region
-clearClipRegion();
-m_aCurrentPDFState.m_bClipRegion = m_aGraphicsStack.front().m_bClipRegion;
-m_aCurrentPDFState.m_aClipRegion = m_aGraphicsStack.front().m_aClipRegion;
+
m_aCurrentPDFState.m_aLineColor = Color( COL_TRANSPARENT );
m_aCurrentPDFState.m_aFillColor = Color( COL_TRANSPARENT );
-updateGraphicsState();
+// needed after pop() to set m_aCurrentPDFState
+updateGraphicsState(NOWRITE);
return pStream;
}
@@ -10491,7 +10492,7 @@ void PDFWriterImpl::drawWallpaper( const Rectangle
rRect, const Wallpaper rWal
}
}
-void PDFWriterImpl::updateGraphicsState()
+void PDFWriterImpl::updateGraphicsState(Mode const mode)
{
OStringBuffer aLine( 256 );
GraphicsState rNewState = m_aGraphicsStack.front();
@@ -10587,7 +10588,7 @@ void PDFWriterImpl::updateGraphicsState()
// everything is up to date now
m_aCurrentPDFState = m_aGraphicsStack.front();
-if( !aLine.isEmpty() )
+if ((mode != NOWRITE) !aLine.isEmpty())
writeBuffer( aLine.getStr(), aLine.getLength() );
}
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 4fe749a..b94e4f4 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -840,10 +840,12 @@ i12626
void drawRelief( SalLayout rLayout, const OUString rText, bool
bTextLines );
void drawShadow( SalLayout rLayout, const OUString rText, bool
bTextLines );
+enum Mode { DEFAULT, NOWRITE };
+
/* writes differences between graphics stack and current real PDF
* state to the file
*/
-void updateGraphicsState();
+void updateGraphicsState(Mode mode = DEFAULT);
/* writes a transparency group object */
bool writeTransparentObject( TransparencyEmit rObject );
commit d256f08c6a7279489440d081e31355f99bee88ae
Author: Michael Stahl mst...@redhat.com
Date: Wed Apr 2 11:01:06 2014 +0200
convwatch.py: decode bytes before printing
Change-Id: Ic1b115583415ab9bd2bdb18fa55f61803efc8442
diff --git a/bin/convwatch.py b/bin/convwatch.py
index 283e67e..c60c0fa 100644
--- a/bin/convwatch.py
+++ b/bin/convwatch.py
@@ -327,7 +327,7 @@ def identify(imagefile):
if process.wait() != 0:
raise Exception(identify failed)
if
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/security.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 38696bae67580aa17fae40c8ccf0f2a34f549ba1 Author: Tor Lillqvist t...@collabora.com Date: Wed Apr 2 13:32:50 2014 +0300 Handle missing SIZE_MAX Change-Id: Id931f5339e19ce5ff635af93fe9f60f3abebe069 diff --git a/sal/osl/unx/security.cxx b/sal/osl/unx/security.cxx index d2b1c1d..28b32b6 100644 --- a/sal/osl/unx/security.cxx +++ b/sal/osl/unx/security.cxx @@ -40,6 +40,9 @@ #define getpwuid_r(uid, pwd, buf, buflen, result) (*(result) = getpwuid(uid), (*(result) ? (memcpy (buf, *(result), sizeof (struct passwd)), 0) : errno)) #endif +#ifndef SIZE_MAX +#define SIZE_MAX ((size_t)-1) +#endif static oslSecurityError SAL_CALL osl_psz_loginUser(const sal_Char* pszUserName, const sal_Char* pszPasswd, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/avmedia
include/avmedia/mediaitem.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 586612e4f51500a3ff7611f5446d5ee4757c7d8a Author: Zolnai Tamás tamas.zol...@collabora.com Date: Wed Apr 2 12:53:49 2014 +0200 Fix mac build: :: cannot begin a template-argument list Change-Id: Iddc71ca948ae478aa865378e0f3d3c7bbdcc577b diff --git a/include/avmedia/mediaitem.hxx b/include/avmedia/mediaitem.hxx index c512e26..7fec0bd 100644 --- a/include/avmedia/mediaitem.hxx +++ b/include/avmedia/mediaitem.hxx @@ -131,8 +131,8 @@ bool AVMEDIA_DLLPUBLIC EmbedMedia( OUString GetFilename(OUString const rSourceURL); -::com::sun::star::uno::Reference::com::sun::star::io::XStream CreateStream( -::com::sun::star::uno::Reference::com::sun::star::embed::XStorage const xStorage, OUString const rFilename); +::com::sun::star::uno::Reference ::com::sun::star::io::XStream CreateStream( +::com::sun::star::uno::Reference ::com::sun::star::embed::XStorage const xStorage, OUString const rFilename); } #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source
vcl/source/gdi/outdev3.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit d5b3e74e50a2616c85d1955f59e55bb4edba32dd Author: Matúš Kukan matus.ku...@collabora.com Date: Tue Apr 1 13:01:14 2014 +0200 fdo#74302: Adapt to OUString changes and set length exactly. This was fixed in master by 4c539fac018dfd44cd8db52161a8cb930c627da7 Change-Id: I69219e643f5eff3126191220ce2b1d0e1089a93e Reviewed-on: https://gerrit.libreoffice.org/8808 Tested-by: Michael Stahl mst...@redhat.com Reviewed-by: Michael Stahl mst...@redhat.com diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx index d97b71b..537f8aa 100644 --- a/vcl/source/gdi/outdev3.cxx +++ b/vcl/source/gdi/outdev3.cxx @@ -5399,6 +5399,9 @@ void OutputDevice::DrawText( const Point rStartPt, const OUString rStr, OUStringToOString( rStr, RTL_TEXTENCODING_UTF8 ).getStr() ); #endif +if( nLen == STRING_LEN ) +nLen = rStr.getLength() - nIndex; + if ( mpMetaFile ) mpMetaFile-AddAction( new MetaTextAction( rStartPt, rStr, nIndex, nLen ) ); if( pVector ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/source
vcl/source/gdi/outdev2.cxx | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
New commits:
commit d3c4a0c2a87504007a30e6944f52da4654cfa784
Author: Armin Le Grand a...@apache.org
Date: Wed Apr 2 11:21:46 2014 +
i124580 corrected some conversions of scale values to integer positions
diff --git a/vcl/source/gdi/outdev2.cxx b/vcl/source/gdi/outdev2.cxx
index bc892a6..975ff2a6 100644
--- a/vcl/source/gdi/outdev2.cxx
+++ b/vcl/source/gdi/outdev2.cxx
@@ -825,8 +825,11 @@ void OutputDevice::DrawTransformedBitmapEx(
{
// with no rotation, shear or mirroring it can be mapped to
DrawBitmapEx
// do *not* execute the mirroring here, it's done in the fallback
+// #124580# the correct DestSize needs to be calculated based on MaxXY
values
const Point aDestPt(basegfx::fround(aTranslate.getX()),
basegfx::fround(aTranslate.getY()));
-const Size aDestSize(basegfx::fround(aScale.getX()),
basegfx::fround(aScale.getY()));
+const Size aDestSize(
+basegfx::fround(aScale.getX() + aTranslate.getX()) - aDestPt.X(),
+basegfx::fround(aScale.getY() + aTranslate.getY()) - aDestPt.Y());
DrawBitmapEx(aDestPt, aDestSize, rBitmapEx);
return;
@@ -879,8 +882,11 @@ void OutputDevice::DrawTransformedBitmapEx(
{
// with no rotation or shear it can be mapped to DrawBitmapEx
// do *not* execute the mirroring here, it's done in the fallback
+// #124580# the correct DestSize needs to be calculated based on
MaxXY values
const Point aDestPt(basegfx::fround(aTranslate.getX()),
basegfx::fround(aTranslate.getY()));
-const Size aDestSize(basegfx::fround(aScale.getX()),
basegfx::fround(aScale.getY()));
+const Size aDestSize(
+basegfx::fround(aScale.getX() + aTranslate.getX()) -
aDestPt.X(),
+basegfx::fround(aScale.getY() + aTranslate.getY()) -
aDestPt.Y());
DrawBitmapEx(aDestPt, aDestSize, rBitmapEx);
return;
@@ -1016,8 +1022,11 @@ void OutputDevice::DrawTransformedBitmapEx(
aTargetRange.getMinimum()));
// extract point and size; do not remove size, the bitmap may have
been prepared reduced by purpose
+// #124580# the correct DestSize needs to be calculated based on
MaxXY values
const Point aDestPt(basegfx::fround(aVisibleRange.getMinX()),
basegfx::fround(aVisibleRange.getMinY()));
-const Size aDestSize(basegfx::fround(aVisibleRange.getWidth()),
basegfx::fround(aVisibleRange.getHeight()));
+const Size aDestSize(
+basegfx::fround(aVisibleRange.getMaxX()) - aDestPt.X(),
+basegfx::fround(aVisibleRange.getMaxY()) - aDestPt.Y());
DrawBitmapEx(aDestPt, aDestSize, aTransformed);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 4 commits - filter/source tools/source vcl/source
filter/source/graphicfilter/itiff/lzwdecom.cxx | 42 +++--
tools/source/generic/poly.cxx |4 +-
vcl/source/gdi/metaact.cxx | 41 +---
3 files changed, 57 insertions(+), 30 deletions(-)
New commits:
commit 799f9805b761ff1930a9864a0d7f44966328906b
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:33:03 2014 +0100
init a few more stream-read svm elements
(cherry picked from commit 67c6ea0c426c2796fc1b80cbe2cb0347686db90d)
Conflicts:
vcl/source/gdi/metaact.cxx
Change-Id: I3dfa2485afbe66131b86764374d53181b55c2346
(cherry picked from commit 21212a65c5653bdc38cea426710e68ed40c66eb8)
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 73a93e3..585e915 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -1553,7 +1553,7 @@ SvStream operator( SvStream rIStream, Polygon rPoly )
DBG_ASSERTWARNING( rIStream.GetVersion(), Polygon:: - Solar-Version not
set on rIStream );
sal_uInt16 i;
-sal_uInt16 nPoints;
+sal_uInt16 nPoints(0);
// read all points and create array
rIStream nPoints;
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index c349061..5be33a9 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -982,7 +982,7 @@ void MetaPolyLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
rIStm maLineInfo;
if ( aCompat.GetVersion() = 3 )
{
-sal_uInt8 bHasPolyFlags;
+sal_uInt8 bHasPolyFlags(0);
rIStm bHasPolyFlags;
if ( bHasPolyFlags )
maPoly.Read( rIStm );
@@ -1164,10 +1164,11 @@ void MetaPolyPolygonAction::Read( SvStream rIStm,
ImplMetaReadData* )
if ( aCompat.GetVersion() = 2 )// Version 2
{
-sal_uInt16 i, nIndex, nNumberOfComplexPolygons;
+sal_uInt16 nNumberOfComplexPolygons(0);
rIStm nNumberOfComplexPolygons;
-for ( i = 0; i nNumberOfComplexPolygons; i++ )
+for (sal_uInt16 i = 0; i nNumberOfComplexPolygons; ++i)
{
+sal_uInt16 nIndex(0);
rIStm nIndex;
Polygon aPoly;
aPoly.Read( rIStm );
@@ -1697,18 +1698,20 @@ void MetaTextLineAction::Read( SvStream rIStm,
ImplMetaReadData* )
COMPAT( rIStm );
//#fdo39428 SvStream no longer supports operator(long)
-sal_uInt32 nTemp;
-sal_Int32 nTemp2;
rIStm maPos;
-rIStm nTemp2;
-mnWidth = nTemp2;
-rIStm nTemp;
-meStrikeout = (FontStrikeout)nTemp;
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_Int32 nTempWidth(0);
+rIStm nTempWidth;
+mnWidth = nTempWidth;
+sal_uInt32 nTempStrikeout(0);
+rIStm nTempStrikeout;
+meStrikeout = (FontStrikeout)nTempStrikeout;
+sal_uInt32 nTempUnderline(0);
+rIStm nTempUnderline;
+meUnderline = (FontUnderline)nTempUnderline;
if ( aCompat.GetVersion() = 2 ) {
-rIStm nTemp;
-meUnderline = (FontUnderline)nTemp;
+sal_uInt32 nTempUnderline2(0);
+rIStm nTempUnderline2;
+meUnderline = (FontUnderline)nTempUnderline2;
}
}
@@ -3357,7 +3360,7 @@ void MetaTextAlignAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaTextAlignAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; maAlign = (TextAlign) nTmp16;
@@ -3632,7 +3635,7 @@ void MetaRasterOpAction::Write( SvStream rOStm,
ImplMetaWriteData* pData )
void MetaRasterOpAction::Read( SvStream rIStm, ImplMetaReadData* )
{
-sal_uInt16 nTmp16;
+sal_uInt16 nTmp16(0);
COMPAT( rIStm );
rIStm nTmp16; meRasterOp = (RasterOp) nTmp16;
@@ -4088,9 +4091,9 @@ void MetaCommentAction::Scale( double fXScale, double
fYScale )
SvMemoryStream aMemStm( (void*)mpData, mnDataSize,
STREAM_READ );
SvMemoryStream aDest;
-sal_Int32 nLeft, nRight, nTop, nBottom;
-sal_Int32 nPixX, nPixY, nMillX, nMillY;
-float m11, m12, m21, m22, mdx, mdy;
+sal_Int32 nLeft(0), nRight(0), nTop(0), nBottom(0);
+sal_Int32 nPixX(0), nPixY(0), nMillX(0), nMillY(0);
+float m11(0), m12(0), m21(0), m22(0), mdx(0), mdy(0);
// read data
aMemStm nLeft nTop nRight nBottom;
commit 1720d588fb5e5cba55560066cfe9602e7df2a1e5
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 09:13:37 2014 +0100
valgrind: Conditional jump or move depends on uninitialised value
Change-Id: I1939d376afe5dd5c67f378ffb2520a066dc99077
(cherry picked from commit 6efbc4598aea1e87c1569c7beef13d44b1a4202c)
(cherry picked from commit 1742008dd0d83f3e69b6e09d9e3223d0c5d28096)
diff --git a/tools/source/generic/poly.cxx
[Libreoffice-commits] core.git: svtools/source
svtools/source/control/ctrlbox.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit aa16ca73260681b19f0be8a58be95ed454580f7f
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 13:47:54 2014 +0100
Resolves: fdo#76905 long delay when changing font size from % to pt
Change-Id: I33d72b51536ab96653ccda64c6e058c497289327
diff --git a/svtools/source/control/ctrlbox.cxx
b/svtools/source/control/ctrlbox.cxx
index 8082056..2afe11f 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -1899,13 +1899,13 @@ void FontSizeBox::SetRelative( bool bNewRelative )
if ( bPtRelative )
{
+Clear(); //clear early because SetDecimalDigits is a slow
recalc
+
SetDecimalDigits( 1 );
SetMin( nPtRelMin );
SetMax( nPtRelMax );
SetUnit( FUNIT_POINT );
-Clear();
-
short i = nPtRelMin, n = 0;
// JP 30.06.98: more than 100 values are not useful
while ( i = nPtRelMax n++ 100 )
@@ -1916,12 +1916,13 @@ void FontSizeBox::SetRelative( bool bNewRelative )
}
else
{
+Clear(); //clear early because SetDecimalDigits is a slow
recalc
+
SetDecimalDigits( 0 );
SetMin( nRelMin );
SetMax( nRelMax );
SetUnit( FUNIT_PERCENT );
-Clear();
sal_uInt16 i = nRelMin;
while ( i = nRelMax )
{
@@ -1932,6 +1933,8 @@ void FontSizeBox::SetRelative( bool bNewRelative )
}
else
{
+if (pFontList)
+Clear(); //clear early because SetDecimalDigits is a slow
recalc
bRelative = bPtRelative = false;
SetDecimalDigits( 1 );
SetMin( 20 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/suse/suse-4.0' - 2 commits - tools/source vcl/win
tools/source/generic/poly.cxx| 13 +
vcl/win/source/gdi/winlayout.cxx | 17 -
2 files changed, 25 insertions(+), 5 deletions(-)
New commits:
commit 9c340d46b457cb54700cd2e8ccaab7001ee42b27
Author: Herbert Dürr h...@apache.org
Date: Thu Mar 27 16:07:37 2014 +
Related: #i124516# handle bad surrogate pairs gracefully on Windows
When running into invalid Unicode surrogate pairs the text layout code on
Windows ran into massive problems like crashes. This change detects the
situation of an invalid surrogate pair and falls back to treat it as
a simple character instead of requesting a complex glyph fallback.
(cherry picked from commit 913f1fc4b1362f6e91595af5ae10c4cba79fd355)
Change-Id: I2988f4b64061d0a5df211f6f0f04b1f235fcd6a5
(cherry picked from commit 67688d3118b1a361d5dbdaa78e918815c163d75c)
diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx
index 5a55387..e7bdc11 100644
--- a/vcl/win/source/gdi/winlayout.cxx
+++ b/vcl/win/source/gdi/winlayout.cxx
@@ -385,12 +385,19 @@ bool SimpleWinLayout::LayoutText( ImplLayoutArgs rArgs )
bool bSurrogate = ((nCharCode = 0xD800) (nCharCode = 0xDFFF));
if( bSurrogate )
{
-if( nCharCode = 0xDC00 ) // this part of a surrogate pair was
already processed
+// ignore high surrogates, they were already processed with their
low surrogates
+if( nCharCode = 0xDC00 )
continue;
-nCharCode = 0x1 + ((pCodes[0] - 0xD800) 10) + (pCodes[1] -
0xDC00);
-}
+// check the second half of the surrogate pair
+bSurrogate = (0xDC00 = pCodes[1]) (pCodes[1] = 0xDFFF);
+// calculate the UTF-32 code of valid surrogate pairs
+if( bSurrogate )
+nCharCode = 0x1 + ((pCodes[0] - 0xD800) 10) +
(pCodes[1] - 0xDC00);
+else // or fall back to a replacement character
+nCharCode = '?';
+}
-// get the advance width for the current UCS-4 code point
+// get the advance width for the current UTF-32 code point
int nGlyphWidth = mrWinFontEntry.GetCachedGlyphWidth( nCharCode );
if( nGlyphWidth == -1 )
{
@@ -408,7 +415,7 @@ bool SimpleWinLayout::LayoutText( ImplLayoutArgs rArgs )
mpGlyphAdvances[ i ] = nGlyphWidth;
mnWidth += nGlyphWidth;
-// remaining codes of surrogate pair get a zero width
+// the second half of surrogate pair gets a zero width
if( bSurrogate ((i+1) mnGlyphCount) )
mpGlyphAdvances[ i+1 ] = 0;
commit 6ea4789e99c92994d083b13fd8efee8c35987561
Author: Jürgen Schmidt j...@apache.org
Date: Fri Mar 28 10:52:29 2014 +
Resolves: #i124453# check if the resulting polygon...
has already exceeded the number of points (2^16) that can be handled by a
tools
polygon
(cherry picked from commit 804e547d70552fd64e1344d538427f8898824b43)
Change-Id: I437a84493e264f7b650561599170e831da20c9aa
(cherry picked from commit a9582c05f854cad02710178ab7fa79498573269e)
(cherry picked from commit ab71a4512557b7290cd7b1b4923463052acf164e)
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 585e915..6f2805b 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -910,6 +910,19 @@ void Polygon::AdaptiveSubdivide( Polygon rResult, const
double d ) const
}
*aPointIter++ = mpImplPolygon-mpPointAry[ i++ ];
+
+if (aPoints.size() = SAL_MAX_UINT16)
+{
+OSL_ENSURE(aPoints.size() SAL_MAX_UINT16,
+Polygon::AdapativeSubdivision created polygon too many
points;
+ using original polygon instead);
+
+// The resulting polygon can not hold all the points
+// that we have created so far. Stop the subdivision
+// and return a copy of the unmodified polygon.
+rResult = *this;
+return;
+}
}
// fill result polygon
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/apr
external/apr/ExternalProject_apr.mk |1 + external/apr/ExternalProject_apr_util.mk |1 + 2 files changed, 2 insertions(+) New commits: commit 463952bff239c53862430e865b1b01f580205af0 Author: Matúš Kukan matus.ku...@collabora.com Date: Wed Apr 2 15:31:38 2014 +0200 apr external: add --with-pic Change-Id: Ica3b1207a2847917d82b3c82d14479fb58a7aaa2 diff --git a/external/apr/ExternalProject_apr.mk b/external/apr/ExternalProject_apr.mk index 4848ae8..093cdde 100644 --- a/external/apr/ExternalProject_apr.mk +++ b/external/apr/ExternalProject_apr.mk @@ -28,6 +28,7 @@ $(call gb_ExternalProject_get_state_target,apr,build): +$(call gb_ExternalProject_run,build,\ ./configure \ --enable-static --disable-shared \ + --with-pic \ $(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM))\ $(MAKE) libapr-1.la \ ) diff --git a/external/apr/ExternalProject_apr_util.mk b/external/apr/ExternalProject_apr_util.mk index ba0f7cb..4de76ba 100644 --- a/external/apr/ExternalProject_apr_util.mk +++ b/external/apr/ExternalProject_apr_util.mk @@ -30,6 +30,7 @@ $(call gb_ExternalProject_get_state_target,apr_util,build): +$(call gb_ExternalProject_run,build,\ ./configure \ --enable-static --disable-shared \ + --with-pic \ $(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM))\ --with-apr=$(call gb_UnpackedTarball_get_dir,apr)/apr-1-config \ $(MAKE) libaprutil-1.la \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Eike Rathke er...@redhat.com changed: What|Removed |Added Depends on||76949 --- Comment #122 from Eike Rathke er...@redhat.com --- Adding bug 76949, FILESAVE: .xlsx new functions are saved without _xlfn. prefix and lead to #NAME? error when reloaded -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac
configure.ac | 33 +++--
1 file changed, 7 insertions(+), 26 deletions(-)
New commits:
commit db1c9e4dadc90c5afe3190776a60cc5dcbbce3ac
Author: Douglas Mencken dougmenc...@gmail.com
Date: Wed Apr 2 09:45:09 2014 -0400
configure.ac: require g++ 4.1 or above
it's known that GCC 4.0 is unable to build LibreOffice;
also remove check for a buggy version of g++ (3.4.x)
Change-Id: I97a030c4a214033cab13a69b4c4a599970f9e1cd
Reviewed-on: https://gerrit.libreoffice.org/8812
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/configure.ac b/configure.ac
index 3bd4575..cebff52 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5387,40 +5387,21 @@ else
fi
fi
-dnl check if we are using a buggy version of g++ (currently 3.4.0, 3.4.1 and
trunk)
+dnl check for GNU C++ compiler version
if test $GXX = yes; then
AC_MSG_CHECKING([the GNU C++ compiler version])
_gpp_version=`$CXX -dumpversion`
_gpp_majmin=`echo $_gpp_version | $AWK -F. '{ print \$1*100+\$2 }'`
-AC_MSG_RESULT([checked (g++ $_gpp_version)])
-
-if test $_gpp_majmin = 304; then
-AC_MSG_CHECKING([whether $CXX has the enum bug])
-AC_RUN_IFELSE([AC_LANG_SOURCE([[
-extern C void abort (void);
-extern C void exit (int status);
-
-enum E { E0, E1, E2, E3, E4, E5 };
-
-void test (enum E e)
-{
-if (e == E2 || e == E3 || e == E1)
-exit (1);
-}
-
-int main (void)
-{
-test (E4);
-test (E5);
-test (E0);
-return 0;
-}
-]])],[AC_MSG_ERROR([your version of the GNU C++ compile has a bug
which prevents LibreOffice from being compiled correctly - please check
http://gcc.gnu.org/ml/gcc-patches/2004-07/msg00968.html for
details.])],[AC_MSG_RESULT([no])],[])
+if test $_gpp_majmin -lt 410; then
+AC_MSG_ERROR([You need to use GNU C++ compiler version = 4.1 to build
LibreOffice.])
+else
+AC_MSG_RESULT([checked (g++ $_gpp_version)])
fi
+
dnl see https://code.google.com/p/android/issues/detail?id=41770
-if test $_gpp_majmin -ge 407; then
+if test $_gpp_majmin -ge 410; then
glibcxx_threads=no
AC_LANG_PUSH([C++])
AC_REQUIRE_CPP
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: formula/source include/formula sc/inc sc/qa sc/source
formula/source/core/resource/core_resource.src | 14 +
include/formula/compiler.hrc |4
include/formula/opcode.hxx |2
sc/inc/helpids.h |2
sc/qa/unit/subsequent_filters-test.cxx | 24 ++-
sc/qa/unit/ucalc.cxx |2
sc/source/core/inc/interpre.hxx|5
sc/source/core/tool/interpr2.cxx | 196 +
sc/source/core/tool/interpr4.cxx |2
sc/source/core/tool/parclass.cxx |2
sc/source/filter/excel/xlformula.cxx |9 -
sc/source/filter/oox/formulabase.cxx |6
sc/source/ui/src/scfuncs.src | 96
13 files changed, 352 insertions(+), 12 deletions(-)
New commits:
commit 22dac22fe256b28b78c8e0783f2625aee0f75ace
Author: Winfried Donkers winfrieddonk...@libreoffice.org
Date: Thu Mar 27 13:33:15 2014 +0100
fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL
Change-Id: I3ab9dde5c421a3a3e6022a27be37f23547197317
Reviewed-on: https://gerrit.libreoffice.org/8772
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/formula/source/core/resource/core_resource.src
b/formula/source/core/resource/core_resource.src
index 28ecee3..e008f6c 100644
--- a/formula/source/core/resource/core_resource.src
+++ b/formula/source/core/resource/core_resource.src
@@ -385,6 +385,8 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH_ODFF
String SC_OPCODE_WEEK { Text = ISOWEEKNUM ; };
String SC_OPCODE_EASTERSUNDAY { Text = ORG.OPENOFFICE.EASTERSUNDAY ; };
String SC_OPCODE_GET_DAY_OF_WEEK { Text = WEEKDAY ; };
+String SC_OPCODE_NETWORKDAYS_MS { Text = COM.MICROSOFT.NETWORKDAYS.INTL
; };
+String SC_OPCODE_WORKDAY_MS { Text = COM.MICROSOFT.WORKDAY.INTL ; };
String SC_OPCODE_NO_NAME { Text = #NAME! ; };
String SC_OPCODE_STYLE { Text = ORG.OPENOFFICE.STYLE ; };
String SC_OPCODE_DDE { Text = DDE ; };
@@ -786,6 +788,8 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML
String SC_OPCODE_WEEK { Text = WEEKNUM ; };
String SC_OPCODE_EASTERSUNDAY { Text = EASTERSUNDAY ; };
String SC_OPCODE_GET_DAY_OF_WEEK { Text = WEEKDAY ; };
+String SC_OPCODE_NETWORKDAYS_MS { Text = NETWORKDAYS.INTL ; };
+String SC_OPCODE_WORKDAY_MS { Text = WORKDAY.INTL ; };
String SC_OPCODE_NO_NAME { Text = #NAME! ; };
String SC_OPCODE_STYLE { Text = STYLE ; };
String SC_OPCODE_DDE { Text = DDE ; };
@@ -1189,6 +1193,8 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH
String SC_OPCODE_WEEK { Text = WEEKNUM ; };
String SC_OPCODE_EASTERSUNDAY { Text = EASTERSUNDAY ; };
String SC_OPCODE_GET_DAY_OF_WEEK { Text = WEEKDAY ; };
+String SC_OPCODE_NETWORKDAYS_MS { Text = NETWORKDAYS.INTL ; };
+String SC_OPCODE_WORKDAY_MS { Text = WORKDAY.INTL ; };
String SC_OPCODE_NO_NAME { Text = #NAME! ; };
String SC_OPCODE_STYLE { Text = STYLE ; };
String SC_OPCODE_DDE { Text = DDE ; };
@@ -2606,6 +2612,14 @@ Resource RID_STRLIST_FUNCTION_NAMES
{
Text [ en-US ] = WEEKDAY ;
};
+String SC_OPCODE_NETWORKDAYS_MS
+{
+Text [ en-US ] = NETWORKDAYS.INTL ;
+};
+String SC_OPCODE_WORKDAY_MS
+{
+Text [ en-US ] = WORKDAY.INTL ;
+};
String SC_OPCODE_NO_NAME
{
Text [ en-US ] = #NAME! ;
diff --git a/include/formula/compiler.hrc b/include/formula/compiler.hrc
index 23eedf3..47d22aa 100644
--- a/include/formula/compiler.hrc
+++ b/include/formula/compiler.hrc
@@ -463,8 +463,10 @@
#define SC_OPCODE_CEIL_MS 465
#define SC_OPCODE_CEIL_ISO 466
#define SC_OPCODE_FLOOR_MS 467
+#define SC_OPCODE_NETWORKDAYS_MS468
+#define SC_OPCODE_WORKDAY_MS469
-#define SC_OPCODE_STOP_2_PAR468 /* last function with two or more
parameters' OpCode + 1 */
+#define SC_OPCODE_STOP_2_PAR470 /* last function with two or more
parameters' OpCode + 1 */
#define SC_OPCODE_STOP_FUNCTION SC_OPCODE_STOP_2_PAR/* last
function's OpCode + 1 */
#define SC_OPCODE_LAST_OPCODE_ID(SC_OPCODE_STOP_FUNCTION - 1) /* last
OpCode */
diff --git a/include/formula/opcode.hxx b/include/formula/opcode.hxx
index 13daeff..4239c53 100644
--- a/include/formula/opcode.hxx
+++ b/include/formula/opcode.hxx
@@ -436,6 +436,8 @@ enum OpCodeEnum
// miscellaneous
ocWeek = SC_OPCODE_WEEK,
ocGetDayOfWeek = SC_OPCODE_GET_DAY_OF_WEEK,
+ocNetWorkdays_MS= SC_OPCODE_NETWORKDAYS_MS,
+ocWorkday_MS= SC_OPCODE_WORKDAY_MS,
ocNoName= SC_OPCODE_NO_NAME,
ocStyle = SC_OPCODE_STYLE,
ocDde = SC_OPCODE_DDE,
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index bc28f46..2aa8e60 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -702,5 +702,7
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/aqua
vcl/aqua/source/app/salinst.cxx | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
New commits:
commit 7a16301474acc0433c431248aaca7f0589dbe6ec
Author: Herbert Dürr h...@apache.org
Date: Wed Apr 2 12:09:54 2014 +
#i124509# use setenv() instead of putenv() on OSX
putenv() has changed its semantic to no longer copy input buffers which
results in problems if the input buffers were only temporary. Using
setenv(), which still copies the input buffers solves the problem.
diff --git a/vcl/aqua/source/app/salinst.cxx b/vcl/aqua/source/app/salinst.cxx
index 5bf7944c..819b162 100644
--- a/vcl/aqua/source/app/salinst.cxx
+++ b/vcl/aqua/source/app/salinst.cxx
@@ -303,32 +303,29 @@ void InitSalMain()
// Assign to PATH environment variable
if ( aCmdPath.Len() )
{
-aTmpPath = ByteString( PATH= );
-aTmpPath += aCmdPath;
+aTmpPath = aCmdPath;
if ( aPath.Len() )
aTmpPath += ByteString( DirEntry::GetSearchDelimiter(),
RTL_TEXTENCODING_ASCII_US );
aTmpPath += aPath;
-putenv( (char*)aTmpPath.GetBuffer() );
+setenv( PATH, aTmpPath.GetBuffer(), TRUE );
}
// Assign to STAR_RESOURCEPATH environment variable
if ( aCmdPath.Len() )
{
-aTmpPath = ByteString( STAR_RESOURCEPATH= );
-aTmpPath += aCmdPath;
+aTmpPath = aCmdPath;
if ( aResPath.Len() )
aTmpPath += ByteString( DirEntry::GetSearchDelimiter(),
RTL_TEXTENCODING_ASCII_US );
aTmpPath += aResPath;
-putenv( (char*)aTmpPath.GetBuffer() );
+setenv( STAR_RESOURCEPATH, aTmpPath.GetBuffer(), TRUE );
}
// Assign to DYLD_LIBRARY_PATH environment variable
if ( aCmdPath.Len() )
{
-aTmpPath = ByteString( DYLD_LIBRARY_PATH= );
-aTmpPath += aCmdPath;
+aTmpPath = aCmdPath;
if ( aLibPath.Len() )
aTmpPath += ByteString( DirEntry::GetSearchDelimiter(),
RTL_TEXTENCODING_ASCII_US );
aTmpPath += aLibPath;
-putenv( (char*)aTmpPath.GetBuffer() );
+setenv( DYLD_LIBRARY_PATH, aTmpPath.GetBuffer(), TRUE );
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - configure.ac
configure.ac | 40
1 file changed, 20 insertions(+), 20 deletions(-)
New commits:
commit 44405c95b63fcd4b8b594c47106a7491424cbc40
Author: Tor Lillqvist t...@collabora.com
Date: Wed Apr 2 17:12:09 2014 +0300
We use four column indentation steps in this file
Change-Id: I52898b460669ce7afaaeef4d28f36883eb20effa
diff --git a/configure.ac b/configure.ac
index c4b86ff..3726dfa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5402,23 +5402,23 @@ if test $GXX = yes; then
dnl see https://code.google.com/p/android/issues/detail?id=41770
if test $_gpp_majmin -ge 401; then
-glibcxx_threads=no
-AC_LANG_PUSH([C++])
-AC_REQUIRE_CPP
-AC_MSG_CHECKING([whether $CXX is broken with boost.thread])
-AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
-#include bits/c++config.h]],[[
-#if !defined(_GLIBCXX_HAVE_GTHR_DEFAULT) \
- !defined(_GLIBCXX__PTHREADS) \
- !defined(_GLIBCXX_HAS_GTHREADS)
-choke me
-#endif
-]])],[AC_MSG_RESULT([yes])
-glibcxx_threads=yes],[AC_MSG_RESULT([no])])
-AC_LANG_POP([C++])
-if test $glibcxx_threads = yes; then
- BOOST_CXXFLAGS=-D_GLIBCXX_HAS_GTHREADS
-fi
+glibcxx_threads=no
+AC_LANG_PUSH([C++])
+AC_REQUIRE_CPP
+AC_MSG_CHECKING([whether $CXX is broken with boost.thread])
+AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
+#include bits/c++config.h]],[[
+#if !defined(_GLIBCXX_HAVE_GTHR_DEFAULT) \
+ !defined(_GLIBCXX__PTHREADS) \
+ !defined(_GLIBCXX_HAS_GTHREADS)
+choke me
+#endif
+]])],[AC_MSG_RESULT([yes])
+glibcxx_threads=yes],[AC_MSG_RESULT([no])])
+AC_LANG_POP([C++])
+if test $glibcxx_threads = yes; then
+ BOOST_CXXFLAGS=-D_GLIBCXX_HAS_GTHREADS
+fi
fi
fi
AC_SUBST(BOOST_CXXFLAGS)
commit 3ec4b907991d62155801b42acff9d09417fe66ed
Author: Tor Lillqvist t...@collabora.com
Date: Wed Apr 2 17:08:16 2014 +0300
Fix g++ version test
Change-Id: I03bb06ddda9f8d54fae926004f5cf55cf5846833
diff --git a/configure.ac b/configure.ac
index cebff52..c4b86ff 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5394,14 +5394,14 @@ if test $GXX = yes; then
_gpp_version=`$CXX -dumpversion`
_gpp_majmin=`echo $_gpp_version | $AWK -F. '{ print \$1*100+\$2 }'`
-if test $_gpp_majmin -lt 410; then
-AC_MSG_ERROR([You need to use GNU C++ compiler version = 4.1 to build
LibreOffice.])
+if test $_gpp_majmin -lt 401; then
+AC_MSG_ERROR([You need to use GNU C++ compiler version = 4.1 to build
LibreOffice, you have $_gpp_version.])
else
AC_MSG_RESULT([checked (g++ $_gpp_version)])
fi
dnl see https://code.google.com/p/android/issues/detail?id=41770
-if test $_gpp_majmin -ge 410; then
+if test $_gpp_majmin -ge 401; then
glibcxx_threads=no
AC_LANG_PUSH([C++])
AC_REQUIRE_CPP
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/docary.hxx |1
sw/source/core/docnode/nodedump.cxx | 126 +++-
2 files changed, 125 insertions(+), 2 deletions(-)
New commits:
commit 0635918c5153116a22eebec12d1b5de9d6e83e01
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 15:42:30 2014 +0200
SwFrmFmts: add a dumpAsXml() method
With this, it's possible to see properties of e.g. fly frames in a
document.
Change-Id: Iba68156ba7f0149dfea3e0a6367b71b8642a2a80
diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx
index 93f1815..3269eb0 100644
--- a/sw/inc/docary.hxx
+++ b/sw/inc/docary.hxx
@@ -81,6 +81,7 @@ public:
virtual SwFmt* GetFmt(size_t idx) const SAL_OVERRIDE { return
(SwFmt*)operator[](idx); }
sal_uInt16 GetPos(const SwFrmFmt* pFmt) const;
bool Contains(const SwFrmFmt* pFmt) const;
+void dumpAsXml(xmlTextWriterPtr w);
/// free's any remaining child objects
virtual ~SwFrmFmts();
};
diff --git a/sw/source/core/docnode/nodedump.cxx
b/sw/source/core/docnode/nodedump.cxx
index dbdf480..11ebfa1 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -16,7 +16,11 @@
#include docufld.hxx
#include txatbase.hxx
#include fmtautofmt.hxx
+#include fmtcntnt.hxx
#include charfmt.hxx
+#include frmfmt.hxx
+#include fmtanchr.hxx
+#include fmtsrnd.hxx
#include paratr.hxx
#include redline.hxx
#include swmodule.hxx
@@ -28,8 +32,10 @@
#include editeng/fhgtitem.hxx
#include editeng/editobj.hxx
#include editeng/outlobj.hxx
+#include svx/xdef.hxx
#include svx/svdpage.hxx
#include svx/svdmodel.hxx
+#include svx/xfillit0.hxx
#include tools/datetimeutils.hxx
#include libxml/encoding.h
@@ -171,6 +177,7 @@ void SwDoc::dumpAsXml( xmlTextWriterPtr w )
mpFldTypes-dumpAsXml( writer );
mpTxtFmtCollTbl-dumpAsXml( writer );
mpCharFmtTbl-dumpAsXml( writer );
+mpSpzFrmFmtTbl-dumpAsXml( writer );
mpNumRuleTbl-dumpAsXml( writer );
mpRedlineTbl-dumpAsXml( writer );
mpExtraRedlineTbl-dumpAsXml( writer );
@@ -365,8 +372,8 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const
SfxItemSet* pSet)
css::uno::Any aAny;
static_castconst SvxRsidItem*(pItem)-QueryValue(aAny);
oValue = OString::number(aAny.getsal_uInt32());
+break;
}
-break;
case RES_CHRATR_ROTATE: pWhich = character rotation; oValue =
OString::number(static_castconst SvxCharRotateItem*(pItem)-GetValue());
break;
case RES_PARATR_OUTLINELEVEL: pWhich = paragraph outline level;
oValue = OString::number(static_castconst SfxUInt16Item*(pItem)-GetValue());
break;
case RES_PARATR_NUMRULE: pWhich = paragraph numbering rule;
oValue = OUStringToOString(static_castconst
SwNumRuleItem*(pItem)-GetValue(), RTL_TEXTENCODING_UTF8); break;
@@ -378,8 +385,103 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const
SfxItemSet* pSet)
pWhich = character font size;
const SvxFontHeightItem* pFontHeightItem = static_castconst
SvxFontHeightItem*(pItem);
oValue = nHeight: +
OString::number(pFontHeightItem-GetHeight()) + , nProp: +
OString::number(pFontHeightItem-GetProp());
+break;
+}
+case RES_CNTNT:
+{
+pWhich = frame content;
+const SwFmtCntnt* pCntnt = static_castconst
SwFmtCntnt*(pItem);
+oValue = node index: +
OString::number(pCntnt-GetCntntIdx()-GetNode().GetIndex());
+break;
+}
+case RES_FRM_SIZE:
+{
+pWhich = frame size;
+break;
+}
+case RES_VERT_ORIENT:
+{
+pWhich = frame vertical orientation;
+break;
+}
+case RES_HORI_ORIENT:
+{
+pWhich = frame horizontal orientation;
+break;
+}
+case RES_ANCHOR:
+{
+pWhich = frame anchor;
+const SwFmtAnchor* pAnchor = static_castconst
SwFmtAnchor*(pItem);
+const SwPosition* pPosition = pAnchor-GetCntntAnchor();
+if (pPosition)
+oValue = node index: +
OString::number(pPosition-nNode.GetNode().GetIndex()) + , index: +
OString::number(pPosition-nContent.GetIndex());
+break;
+}
+case RES_SURROUND:
+{
+pWhich = frame surround;
+const SwFmtSurround* pSurround = static_castconst
SwFmtSurround*(pItem);
+switch (pSurround-GetSurround())
+{
+case SURROUND_NONE:
+oValue = none;
+break;
+case SURROUND_THROUGHT:
+oValue = throught;
+break;
+
[Libreoffice-commits] core.git: 3 commits - cui/source cui/uiconfig vcl/source
cui/source/tabpages/chardlg.cxx | 20
cui/uiconfig/ui/positionpage.ui | 13 -
vcl/source/gdi/outdev2.cxx | 15 ---
3 files changed, 40 insertions(+), 8 deletions(-)
New commits:
commit f5b9db43080658201caf07cd646bae4f4f2acc95
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 15:18:05 2014 +0100
Resolves: fdo#75307 discard invalid user data
Change-Id: Id39b51c344004e02d3d5a281ba98721b944468c3
diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 5f8e255..28c118f 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -2897,6 +2897,26 @@ void SvxCharPositionPage::Reset( const SfxItemSet rSet )
m_nSubEsc = (short)sUser.getToken( 1, ';' ).toInt32();
m_nSuperProp = (sal_uInt8)sUser.getToken( 2, ';' ).toInt32();
m_nSubProp = (sal_uInt8)sUser.getToken( 3, ';' ).toInt32();
+
+//fdo#75307 validate all the entries and discard all of them if any are
+//out of range
+bool bValid = true;
+if (m_nSuperEsc m_pHighLowMF-GetMin() || m_nSuperEsc
m_pHighLowMF-GetMax())
+bValid = false;
+if (m_nSubEsc*-1 m_pHighLowMF-GetMin() || m_nSubEsc*-1
m_pHighLowMF-GetMax())
+bValid = false;
+if (m_nSuperProp m_pFontSizeMF-GetMin() || m_nSuperProp
m_pFontSizeMF-GetMax())
+bValid = false;
+if (m_nSubProp m_pFontSizeMF-GetMin() || m_nSubProp
m_pFontSizeMF-GetMax())
+bValid = false;
+
+if (!bValid)
+{
+m_nSuperEsc = DFLT_ESC_SUPER;
+m_nSubEsc = DFLT_ESC_SUB;
+m_nSuperProp = DFLT_ESC_PROP;
+m_nSubProp = DFLT_ESC_PROP;
+}
}
short nEsc = 0;
commit 604f67db541060146a8a33944d4bcf31f2e346b4
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 14:14:36 2014 +0100
set mnemonic widgets
Change-Id: Id4f4d2dfab6cf7f370488e87c6e86eb8da50b6fd
diff --git a/cui/uiconfig/ui/positionpage.ui b/cui/uiconfig/ui/positionpage.ui
index c44bee6..ebd1b24 100644
--- a/cui/uiconfig/ui/positionpage.ui
+++ b/cui/uiconfig/ui/positionpage.ui
@@ -1,7 +1,8 @@
?xml version=1.0 encoding=UTF-8?
+!-- Generated with glade 3.16.1 --
interface
!-- interface-requires LibreOffice 1.0 --
- !-- interface-requires gtk+ 3.0 --
+ requires lib=gtk+ version=3.0/
object class=GtkAdjustment id=adjustment1
property name=lower1/property
property name=upper100/property
@@ -135,6 +136,8 @@
property name=can_focusFalse/property
property name=xalign0/property
property name=label translatable=yesRaise/lower
by/property
+property name=use_underlineTrue/property
+property
name=mnemonic_widgetraiselowersb:0%/property
/object
packing
property name=left_attach0/property
@@ -148,7 +151,6 @@
property name=visibleTrue/property
property name=can_focusTrue/property
property name=invisible_charâ/property
-property name=invisible_char_setTrue/property
property name=adjustmentadjustment1/property
/object
packing
@@ -163,7 +165,6 @@
property name=visibleTrue/property
property name=can_focusTrue/property
property name=invisible_charâ/property
-property name=invisible_char_setTrue/property
property name=adjustmentadjustment1/property
/object
packing
@@ -195,6 +196,8 @@
property name=can_focusFalse/property
property name=xalign0/property
property name=label translatable=yesRelative
font size/property
+property name=use_underlineTrue/property
+property
name=mnemonic_widgetfontsizesb:0%/property
/object
packing
property name=left_attach0/property
@@ -337,6 +340,8 @@
property name=visibleTrue/property
property name=can_focusFalse/property
property name=label translatable=yesScale
width/property
+property name=use_underlineTrue/property
+property
name=mnemonic_widgetscalewidthsb:0%/property
/object
packing
property name=expandFalse/property
@@ -349,7 +354,6 @@
property name=visibleTrue/property
property name=can_focusTrue/property
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - d3/c4a0c2a87504007a30e6944f52da4654cfa784
d3/c4a0c2a87504007a30e6944f52da4654cfa784 |1 + 1 file changed, 1 insertion(+) New commits: commit b69f79da56ad30d52789f8158d10b93e76102071 Author: Caolán McNamara caol...@redhat.com Date: Wed Apr 2 15:20:10 2014 +0100 Notes added by 'git notes add' diff --git a/d3/c4a0c2a87504007a30e6944f52da4654cfa784 b/d3/c4a0c2a87504007a30e6944f52da4654cfa784 new file mode 100644 index 000..57293ef --- /dev/null +++ b/d3/c4a0c2a87504007a30e6944f52da4654cfa784 @@ -0,0 +1 @@ +merged as: 4520973ccf0ab042b09b4233d54a1779625b0093 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 7a/16301474acc0433c431248aaca7f0589dbe6ec
7a/16301474acc0433c431248aaca7f0589dbe6ec |1 + 1 file changed, 1 insertion(+) New commits: commit ebdaa130eb318615b8551cf44a8edb4f9e81b20b Author: Caolán McNamara caol...@redhat.com Date: Wed Apr 2 15:22:37 2014 +0100 Notes added by 'git notes add' diff --git a/7a/16301474acc0433c431248aaca7f0589dbe6ec b/7a/16301474acc0433c431248aaca7f0589dbe6ec new file mode 100644 index 000..3b8855e --- /dev/null +++ b/7a/16301474acc0433c431248aaca7f0589dbe6ec @@ -0,0 +1 @@ +prefer: d841273ba54b173020aa8da18ba7841cf950c13c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 19 ++-
vcl/source/gdi/pdfwriter_impl.hxx |4 +++-
2 files changed, 13 insertions(+), 10 deletions(-)
New commits:
commit 7bea9683e14fcba98e2691fe7fb75f6f68ab0b29
Author: Michael Stahl mst...@redhat.com
Date: Wed Apr 2 11:09:46 2014 +0200
fdo#63786 rhbz#1081968: fix PDF export of cropped SVG
When a META_FLOATTRANSPARENT_ACTION is exported, the
beginTransparencyGroup()/endTransparencyGroup() will write something
like Q 0 0 0 rg where the Q clears the previously set clipping region,
which is then not restored.
bdf75c7d9bce985ed10a9c41d03420f33ce82142 appears to be a fix for a
previous related problem; this essentially reverts it since it
introduced the current cropping problem. (Particularly funny is the
comment force reemitting clip region since the commit does the
opposite.)
It does not really make sense to me to write something to the page
content stream from beginRedirect()/endRedirect(), because that does not
actually have any effect on the _content_ of the substream, because the
referencing of the substream is only written _after_ endRedirect()
returns, so basically what is written can in the best case cancel itself
out and in the worst case introduce bugs; the state manipulations there
are just to modify the m_aCurrentPDFState following the push()/pop() (it
is necessary to clear the clip region before starting the substream to
avoid spurious Q at the beginning of the stream).
Change-Id: I4a5f57b784068bd7d3ba187115444574f7418195
(cherry picked from commit e8062623355fcf3e65beae7f8f5e4d46384141f2)
Reviewed-on: https://gerrit.libreoffice.org/8813
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 8f86255..89355ad 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8662,9 +8662,12 @@ void PDFWriterImpl::beginRedirect( SvStream* pStream,
const Rectangle rTargetRe
{
push( PUSH_ALL );
-// force reemitting clip region
+// force reemitting clip region inside the new stream, and
+// prevent emitting an unbalanced Q at the start
clearClipRegion();
-updateGraphicsState();
+// this is needed to point m_aCurrentPDFState at the pushed state
+// ... but it's pointless to actually write into the outer stream here!
+updateGraphicsState(NOWRITE);
m_aOutputStreams.push_front( StreamRedirect() );
m_aOutputStreams.front().m_pStream = pStream;
@@ -8701,14 +8704,12 @@ SvStream* PDFWriterImpl::endRedirect()
}
pop();
-// force reemitting colors and clip region
-clearClipRegion();
-m_aCurrentPDFState.m_bClipRegion = m_aGraphicsStack.front().m_bClipRegion;
-m_aCurrentPDFState.m_aClipRegion = m_aGraphicsStack.front().m_aClipRegion;
+
m_aCurrentPDFState.m_aLineColor = Color( COL_TRANSPARENT );
m_aCurrentPDFState.m_aFillColor = Color( COL_TRANSPARENT );
-updateGraphicsState();
+// needed after pop() to set m_aCurrentPDFState
+updateGraphicsState(NOWRITE);
return pStream;
}
@@ -10497,7 +10498,7 @@ void PDFWriterImpl::drawWallpaper( const Rectangle
rRect, const Wallpaper rWal
}
}
-void PDFWriterImpl::updateGraphicsState()
+void PDFWriterImpl::updateGraphicsState(Mode const mode)
{
OStringBuffer aLine( 256 );
GraphicsState rNewState = m_aGraphicsStack.front();
@@ -10593,7 +10594,7 @@ void PDFWriterImpl::updateGraphicsState()
// everything is up to date now
m_aCurrentPDFState = m_aGraphicsStack.front();
-if( !aLine.isEmpty() )
+if ((mode != NOWRITE) !aLine.isEmpty())
writeBuffer( aLine.getStr(), aLine.getLength() );
}
diff --git a/vcl/source/gdi/pdfwriter_impl.hxx
b/vcl/source/gdi/pdfwriter_impl.hxx
index 4602044..8e622fa 100644
--- a/vcl/source/gdi/pdfwriter_impl.hxx
+++ b/vcl/source/gdi/pdfwriter_impl.hxx
@@ -840,10 +840,12 @@ i12626
void drawRelief( SalLayout rLayout, const OUString rText, bool
bTextLines );
void drawShadow( SalLayout rLayout, const OUString rText, bool
bTextLines );
+enum Mode { DEFAULT, NOWRITE };
+
/* writes differences between graphics stack and current real PDF
* state to the file
*/
-void updateGraphicsState();
+void updateGraphicsState(Mode mode = DEFAULT);
/* writes a transparency group object */
bool writeTransparentObject( TransparencyEmit rObject );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/boost
external/boost/boost.jsonparser.warnings.patch.0 | 11 +++
1 file changed, 11 insertions(+)
New commits:
commit 0978c495da920c12934324c3c662fa94daf95475
Author: Tor Lillqvist t...@collabora.com
Date: Wed Apr 2 17:30:11 2014 +0300
WaE: comparison of constant 255 with expression of type 'const char'
Change-Id: Ibe07fc9a61ae8432e92c43ac6ff07c4dc9e6c771
diff --git a/external/boost/boost.jsonparser.warnings.patch.0
b/external/boost/boost.jsonparser.warnings.patch.0
index 4a71b3b..b3d9bbf 100644
--- a/external/boost/boost.jsonparser.warnings.patch.0
+++ b/external/boost/boost.jsonparser.warnings.patch.0
@@ -56,3 +56,14 @@
m_tr(tr), m_start(m_value.begin())
{}
+--- boost/property_tree/detail/json_parser_write.hpp
boost/property_tree/detail/json_parser_write.hpp
+@@ -33,7 +33,7 @@
+ // We escape everything outside ASCII, because this code can't
+ // handle high unicode characters.
+ if (*b == 0x20 || *b == 0x21 || (*b = 0x23 *b = 0x2E) ||
+-(*b = 0x30 *b = 0x5B) || (*b = 0x5D *b = 0xFF))
++(*b = 0x30 *b = 0x5B) || (*b = 0x5D))
+ result += *b;
+ else if (*b == Ch('\b')) result += Ch('\\'), result += Ch('b');
+ else if (*b == Ch('\f')) result += Ch('\\'), result += Ch('f');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 17 commits - filter/source include/tools pyuno/source reportdesign/source sc/source sd/source svx/source vcl/source
filter/source/graphicfilter/ipict/ipict.cxx | 12
filter/source/graphicfilter/itiff/itiff.cxx | 49 +-
include/tools/inetmime.hxx|1
pyuno/source/module/pyuno_impl.hxx|3 +
pyuno/source/module/pyuno_module.cxx | 10 ++-
reportdesign/source/core/api/ReportDefinition.cxx |3 +
reportdesign/source/filter/xml/xmlStyleImport.hxx |1
reportdesign/source/ui/inspection/GeometryHandler.cxx | 16 +++--
reportdesign/source/ui/report/ViewsWindow.cxx | 13
sc/source/core/data/colorscale.cxx|5 +
sc/source/core/data/dociter.cxx | 30 +--
sd/source/filter/eppt/epptso.cxx |2
sd/source/ui/presenter/PresenterHelper.cxx| 28 --
svx/source/core/extedit.cxx |9 ++-
vcl/source/control/lstbox.cxx |4 +
vcl/source/filter/ixpm/xpmread.cxx| 42 ---
vcl/source/gdi/impimage.cxx |2
vcl/source/window/brdwin.cxx |5 +
18 files changed, 164 insertions(+), 71 deletions(-)
New commits:
commit ba17f5a34480f76942414eab79e297ae5fad59b7
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 13:00:26 2014 +0100
coverity#708209 Uninitialized scalar field
Change-Id: Ic24e147dd631bbed4e5759b1bd4bebbd0b8add4a
diff --git a/include/tools/inetmime.hxx b/include/tools/inetmime.hxx
index 72fd678..04b3141 100644
--- a/include/tools/inetmime.hxx
+++ b/include/tools/inetmime.hxx
@@ -978,6 +978,7 @@ inline
INetMIMEEncodedWordOutputSink::INetMIMEEncodedWordOutputSink(
m_nExtraSpaces(0),
m_pEncodingList(INetMIME::createPreferredCharsetList(ePreferredEncoding)),
m_ePrevCoding(CODING_NONE),
+m_ePrevMIMEEncoding(RTL_TEXTENCODING_DONTKNOW),
m_eCoding(CODING_NONE),
m_nQuotedEscaped(0),
m_eEncodedWordState(STATE_INITIAL)
commit 67e2de7d6c4340be605f6770b2e0b732d41dbeac
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 12:57:40 2014 +0100
coverity#707967 Uninitialized scalar field
Change-Id: I65aa00d79efe15f63c272fbcd5d3e0dea2c28dfc
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx
b/reportdesign/source/core/api/ReportDefinition.cxx
index c8922a7..2186b7e 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -616,6 +616,8 @@ struct OReportDefinitionImpl
,m_aDocEventListeners(_aMutex)
,m_sMimeType(_aCopy.m_sMimeType)
,m_sIdentifier(_aCopy.m_sIdentifier)
+,m_aVisualAreaSize(_aCopy.m_aVisualAreaSize)
+,m_nAspect(_aCopy.m_nAspect)
,m_nGroupKeepTogether(_aCopy.m_nGroupKeepTogether)
,m_nPageHeaderOption(_aCopy.m_nPageHeaderOption)
,m_nPageFooterOption(_aCopy.m_nPageFooterOption)
@@ -623,6 +625,7 @@ struct OReportDefinitionImpl
,m_bControllersLocked(_aCopy.m_bControllersLocked)
,m_bModified(_aCopy.m_bModified)
,m_bEscapeProcessing(_aCopy.m_bEscapeProcessing)
+,m_bSetModifiedEnabled(_aCopy.m_bSetModifiedEnabled)
{}
~OReportDefinitionImpl();
};
commit f6dd2b47f42917a185296969bca03c63b0b9e95b
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 12:53:26 2014 +0100
coverity#707969 unused nMasterPageNameIndex
Change-Id: I1a91871eb9f1952625b94b15d9ab8a4712487048
diff --git a/reportdesign/source/filter/xml/xmlStyleImport.hxx
b/reportdesign/source/filter/xml/xmlStyleImport.hxx
index c3222da..e71d5f2 100644
--- a/reportdesign/source/filter/xml/xmlStyleImport.hxx
+++ b/reportdesign/source/filter/xml/xmlStyleImport.hxx
@@ -89,7 +89,6 @@ namespace rptxml
const OUString m_sCellStyleFamilyName;
ORptFilter m_rImport;
sal_Int32 m_nNumberFormatIndex;
-sal_Int32 nMasterPageNameIndex;
sal_Bool bAutoStyles : 1;
//mutable UniReference SvXMLImportPropertyMapper
m_xControlImpPropMapper;
commit eac97e7925a7e7dc47c9860fecf47fa4ff498b41
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 12:52:27 2014 +0100
coverity#707970 Uninitialized scalar field
Change-Id: I70cc8c7667d9cfb2fc043e3889c7fb5adc9abd52
diff --git a/reportdesign/source/ui/inspection/GeometryHandler.cxx
b/reportdesign/source/ui/inspection/GeometryHandler.cxx
index 325b3a7..6d5838b 100644
--- a/reportdesign/source/ui/inspection/GeometryHandler.cxx
+++ b/reportdesign/source/ui/inspection/GeometryHandler.cxx
@@ -225,13 +225,15 @@ OUString GeometryHandler::impl_convertToFormula( const
uno::Any _rControlValue
aParser = ReportFormula( impl_isDataField(sName) ? ReportFormula::Field :
ReportFormula::Expression, sName );
return aParser.getCompleteFormula();
}
-GeometryHandler::GeometryHandler(uno::Reference uno::XComponentContext
const context) :
-
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - xmloff/source
xmloff/source/style/bordrhdl.cxx | 51 +--
1 file changed, 17 insertions(+), 34 deletions(-)
New commits:
commit 7f3105323f1db11bc0a3ff5c5c71e1dc62338cc4
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sun Feb 2 18:23:48 2014 -0500
fdo#76697: Remove this duplicate and use the UNO constant values instead.
(cherry picked from commit 72b2fafebfc44fa90f08cc198e2fa5fc26154c5b)
Conflicts:
xmloff/source/style/bordrhdl.cxx
This fixes the bug because in XMLBorderHdl::importXML() the value none
was rejected as invalid because API_LINE_NONE pointlessly had a
different value than BorderLineStyle::NONE.
Change-Id: Id81aacc6c594ad25d97f6f6dc578ed9ca16549ab
Signed-off-by: Michael Stahl mst...@redhat.com
diff --git a/xmloff/source/style/bordrhdl.cxx b/xmloff/source/style/bordrhdl.cxx
index e0c7be5..cecc3b1 100644
--- a/xmloff/source/style/bordrhdl.cxx
+++ b/xmloff/source/style/bordrhdl.cxx
@@ -29,23 +29,6 @@
using namespace ::com::sun::star;
using namespace ::xmloff::token;
-const sal_uInt16 API_LINE_SOLID = 0;
-const sal_uInt16 API_LINE_DOTTED = 1;
-const sal_uInt16 API_LINE_DASHED = 2;
-const sal_uInt16 API_LINE_DOUBLE = 3;
-const sal_uInt16 API_LINE_THINTHICK_SMALLGAP = 4;
-const sal_uInt16 API_LINE_THINTHICK_MEDIUMGAP = 5;
-const sal_uInt16 API_LINE_THINTHICK_LARGEGAP = 6;
-const sal_uInt16 API_LINE_THICKTHIN_SMALLGAP = 7;
-const sal_uInt16 API_LINE_THICKTHIN_MEDIUMGAP = 8;
-const sal_uInt16 API_LINE_THICKTHIN_LARGEGAP = 9;
-const sal_uInt16 API_LINE_EMBOSSED = 10;
-const sal_uInt16 API_LINE_ENGRAVED = 11;
-const sal_uInt16 API_LINE_OUTSET = 12;
-const sal_uInt16 API_LINE_INSET = 13;
-const sal_uInt16 API_LINE_FINE_DASHED = 14;
-const sal_uInt16 API_LINE_NONE = USHRT_MAX;
-
#define DEF_LINE_WIDTH_01
#define DEF_LINE_WIDTH_135
#define DEF_LINE_WIDTH_288
@@ -90,7 +73,7 @@ static sal_uInt16 const aBorderWidths[] =
static void lcl_frmitems_setXMLBorderStyle( table::BorderLine2 rBorderLine,
sal_uInt16 nStyle )
{
sal_Int16 eStyle = -1; // None
-if ( nStyle != API_LINE_NONE )
+if (nStyle != table::BorderLineStyle::NONE)
eStyle = sal_Int16( nStyle );
rBorderLine.LineStyle = eStyle;
@@ -238,7 +221,7 @@ bool XMLBorderHdl::importXML( const OUString rStrImpValue,
uno::Any rValue, co
// if there is no style or a different style than none but no width,
// then the declaration is not valid.
-if( !bHasStyle || (API_LINE_NONE != nStyle !bHasWidth) )
+if (!bHasStyle || (table::BorderLineStyle::NONE != nStyle !bHasWidth))
return false;
table::BorderLine2 aBorderLine;
@@ -252,7 +235,7 @@ bool XMLBorderHdl::importXML( const OUString rStrImpValue,
uno::Any rValue, co
}
// first of all, delete an empty line
-if( (bHasStyle API_LINE_NONE == nStyle) ||
+if ((bHasStyle table::BorderLineStyle::NONE == nStyle) ||
(bHasWidth USHRT_MAX == nNamedWidth 0 == nWidth) )
{
aBorderLine.InnerLineWidth = 0;
@@ -312,34 +295,34 @@ bool XMLBorderHdl::exportXML( OUString rStrExpValue,
const uno::Any rValue, co
XMLTokenEnum eStyleToken = XML_SOLID;
switch ( aBorderLine.LineStyle )
{
-case API_LINE_DASHED:
+case table::BorderLineStyle::DASHED:
eStyleToken = XML_DASHED;
break;
-case API_LINE_DOTTED:
+case table::BorderLineStyle::DOTTED:
eStyleToken = XML_DOTTED;
break;
-case API_LINE_DOUBLE:
-case API_LINE_THINTHICK_SMALLGAP:
-case API_LINE_THINTHICK_MEDIUMGAP:
-case API_LINE_THINTHICK_LARGEGAP:
-case API_LINE_THICKTHIN_SMALLGAP:
-case API_LINE_THICKTHIN_MEDIUMGAP:
-case API_LINE_THICKTHIN_LARGEGAP:
+case table::BorderLineStyle::DOUBLE:
+case table::BorderLineStyle::THINTHICK_SMALLGAP:
+case table::BorderLineStyle::THINTHICK_MEDIUMGAP:
+case table::BorderLineStyle::THINTHICK_LARGEGAP:
+case table::BorderLineStyle::THICKTHIN_SMALLGAP:
+case table::BorderLineStyle::THICKTHIN_MEDIUMGAP:
+case table::BorderLineStyle::THICKTHIN_LARGEGAP:
eStyleToken = XML_DOUBLE;
break;
-case API_LINE_EMBOSSED:
+case table::BorderLineStyle::EMBOSSED:
eStyleToken = XML_RIDGE;
break;
-case API_LINE_ENGRAVED:
+case table::BorderLineStyle::ENGRAVED:
eStyleToken = XML_GROOVE;
break;
-case API_LINE_OUTSET:
+case table::BorderLineStyle::OUTSET:
eStyleToken = XML_OUTSET;
break;
-case API_LINE_INSET:
+case table::BorderLineStyle::INSET:
eStyleToken = XML_INSET;
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 76697, which changed state. Bug 76697 Summary: Frames without border are not correctly displayed/loaded https://bugs.freedesktop.org/show_bug.cgi?id=76697 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/core/data/column3.cxx |3 +--
sc/source/filter/excel/xestream.cxx |2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 31e4419ac7581aa7864905bcd4ce42e14df6c9bb
Author: Eike Rathke er...@redhat.com
Date: Wed Apr 2 16:54:17 2014 +0200
resolved fdo#76949 correct grammar is GRAM_OOXML
Regression introduced with ca8ca8c28742879220f3ff88ae0d71c8d69b11cd that
used GRAM_ENGLISH_XL_OOX instead, which is English UI function names
with OOXML reference syntax.
Change-Id: If6b73e85a45e57f6ef281d1edf8e34dec7cb9bb8
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index d5bf89d..04a8298 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -821,7 +821,7 @@ OUString XclXmlUtils::ToOUString(
ScDocument rDocument, const ScAddress rAddress, const ScTokenArray*
pTokenArray )
{
ScCompiler aCompiler( rDocument, rAddress,
const_castScTokenArray(*pTokenArray));
-aCompiler.SetGrammar(FormulaGrammar::GRAM_ENGLISH_XL_OOX);
+aCompiler.SetGrammar(FormulaGrammar::GRAM_OOXML);
OUStringBuffer aBuffer( pTokenArray-GetLen() * 5 );
aCompiler.CreateStringFromTokenArray( aBuffer );
commit cc911e8bc428b16cff9fdc77c10d470110c4531b
Author: Eike Rathke er...@redhat.com
Date: Tue Apr 1 15:59:45 2014 +0200
just nitpicking on scope
Change-Id: I01969fb4596e7866ddb348d026a22f45deeef0c8
diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 86ee9a2..38a92c0 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2710,7 +2710,6 @@ class MaxNumStringLenHandler
OUString aString;
OUString aSep;
-sal_Int32 nLen;
sal_uInt16 nPrec;
sal_uInt32 nFormat = static_castconst SfxUInt32Item*(
mrColumn.GetAttr(nRow, ATTR_VALUE_FORMAT))-GetValue();
@@ -2748,7 +2747,7 @@ class MaxNumStringLenHandler
nPrec = SvNumberFormatter::UNLIMITED_PRECISION;
}
-nLen = aString.getLength();
+sal_Int32 nLen = aString.getLength();
if (nLen = 0)
// Ignore empty string.
return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 76949, which changed state. Bug 76949 Summary: FILESAVE: .xlsx new functions are saved without _xlfn. prefix and lead to #NAME? error when reloaded https://bugs.freedesktop.org/show_bug.cgi?id=76949 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/sfx2 include/vcl sfx2/source vcl/source
include/sfx2/tabdlg.hxx |1 -
include/vcl/tabpage.hxx |2 ++
sfx2/source/dialog/tabdlg.cxx | 35 ---
vcl/source/window/tabpage.cxx |8
4 files changed, 38 insertions(+), 8 deletions(-)
New commits:
commit 6fa98a08f2f4b57b660fc39542a9ceb20779d769
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 16:15:59 2014 +0100
Related: fdo#75307 use the unique auto help id to identify tabpages
and dialogs that are loaded from the .ui format
Change-Id: Id8abff6d89818ca7384d9691a05eacd378a5905c
diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 4bc1138..54baa7a 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -91,7 +91,6 @@ friend class SfxTabDialogController;
SfxItemSet* pOutSet;
TabDlg_Impl*pImpl;
sal_uInt16* pRanges;
-sal_uInt32 nResId;
sal_uInt16 nAppPageId;
boolbItemsReset;
sal_BoolbFmt; // sal_True, sal_False or 2(some kind of hack)
diff --git a/include/vcl/tabpage.hxx b/include/vcl/tabpage.hxx
index a8ac279..88a1ead 100644
--- a/include/vcl/tabpage.hxx
+++ b/include/vcl/tabpage.hxx
@@ -53,6 +53,8 @@ public:
virtual voidActivatePage();
virtual voidDeactivatePage();
+OString GetConfigId() const;
+
//To-Do, consider inheriting from VclContainer
virtual voidSetPosSizePixel(const Point rNewPos, const Size
rNewSize) SAL_OVERRIDE;
virtual voidSetPosPixel(const Point rNewPos) SAL_OVERRIDE;
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index d12b5c4..853c806 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -405,7 +405,6 @@ SfxTabDialog::SfxTabDialog
, pSet(pItemSet)
, pOutSet(0)
, pRanges(0)
-, nResId(0)
, nAppPageId(USHRT_MAX)
, bItemsReset(false)
, bFmt(bEditFmt)
@@ -436,7 +435,6 @@ SfxTabDialog::SfxTabDialog
, pSet(pItemSet)
, pOutSet(0)
, pRanges(0)
-, nResId(0)
, nAppPageId(USHRT_MAX)
, bItemsReset(false)
, bFmt(bEditFmt)
@@ -464,7 +462,15 @@ SfxTabDialog::~SfxTabDialog()
if ( !aPageData.isEmpty() )
{
// save settings of all pages (user data)
-SvtViewOptions aPageOpt( E_TABPAGE, OUString::number(
pDataObject-nId ) );
+OUString sConfigId =
OStringToOUString(pDataObject-pTabPage-GetConfigId(),
+RTL_TEXTENCODING_UTF8);
+if (sConfigId.isEmpty())
+{
+SAL_WARN(sfx.config, Tabpage needs to be converted to
.ui format);
+sConfigId = OUString::number(pDataObject-nId);
+}
+
+SvtViewOptions aPageOpt(E_TABPAGE, sConfigId);
aPageOpt.SetUserItem( USERITEM_NAME, makeAny( OUString(
aPageData ) ) );
}
@@ -685,7 +691,7 @@ void SfxTabDialog::Start_Impl()
sal_uInt16 nActPage = m_pTabCtrl-GetPageId( 0 );
// load old settings, when exists
-SvtViewOptions aDlgOpt( E_TABDIALOG, OUString::number( nResId ) );
+SvtViewOptions aDlgOpt(E_TABDIALOG,
OStringToOUString(GetHelpId(),RTL_TEXTENCODING_UTF8));
if ( aDlgOpt.Exists() )
{
SetWindowState(OUStringToOString(aDlgOpt.GetWindowState().getStr(),
RTL_TEXTENCODING_ASCII_US));
@@ -806,7 +812,15 @@ void SfxTabDialog::RemoveTabPage( sal_uInt16 nId )
if ( !aPageData.isEmpty() )
{
// save settings of this page (user data)
-SvtViewOptions aPageOpt( E_TABPAGE, OUString::number(
pDataObject-nId ) );
+OUString sConfigId =
OStringToOUString(pDataObject-pTabPage-GetConfigId(),
+RTL_TEXTENCODING_UTF8);
+if (sConfigId.isEmpty())
+{
+SAL_WARN(sfx.config, Tabpage needs to be converted to
.ui format);
+sConfigId = OUString::number(pDataObject-nId);
+}
+
+SvtViewOptions aPageOpt(E_TABPAGE, sConfigId);
aPageOpt.SetUserItem( USERITEM_NAME, makeAny( OUString(
aPageData ) ) );
}
@@ -882,8 +896,9 @@ SfxTabPage* SfxTabDialog::GetTabPage( sal_uInt16 nPageId )
const
void SfxTabDialog::SavePosAndId()
{
// save settings (screen position and current page)
-SvtViewOptions aDlgOpt( E_TABDIALOG, OUString::number( nResId ) );
+SvtViewOptions aDlgOpt(E_TABDIALOG,
OStringToOUString(GetHelpId(),RTL_TEXTENCODING_UTF8));
aDlgOpt.SetWindowState(OStringToOUString(GetWindowState(WINDOWSTATE_MASK_POS),RTL_TEXTENCODING_ASCII_US));
+// to-do replace with name of page when all pages are converted to .ui
aDlgOpt.SetPageID( m_pTabCtrl-GetCurPageId() );
}
@@ -1252,7 +1267,13 @@ IMPL_LINK( SfxTabDialog, ActivatePageHdl, TabControl *,
pTabCtrl )
DBG_ASSERT( NULL ==
[Libreoffice-commits] core.git: external/boost
external/boost/boost.jsonparser.warnings.patch.0 |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit cf704d65e005b08697c7a6f454acff01bd4ef6c3
Author: Tor Lillqvist t...@collabora.com
Date: Wed Apr 2 18:16:57 2014 +0300
WaE: comparison of constant 255 with expression of type 'const char'
Better fix for warning: comparison of constant 255 with expression of
type 'const char' is always true. I hadn't considered that the code
is in a template, so it must handle strings of arbitrary integer types
(well, Unicode).
Change-Id: I38d6d480bfc3ff89db1276cac38d310ecdcc2cfa
diff --git a/external/boost/boost.jsonparser.warnings.patch.0
b/external/boost/boost.jsonparser.warnings.patch.0
index b3d9bbf..0cda6ea 100644
--- a/external/boost/boost.jsonparser.warnings.patch.0
+++ b/external/boost/boost.jsonparser.warnings.patch.0
@@ -63,7 +63,7 @@
// handle high unicode characters.
if (*b == 0x20 || *b == 0x21 || (*b = 0x23 *b = 0x2E) ||
-(*b = 0x30 *b = 0x5B) || (*b = 0x5D *b = 0xFF))
-+(*b = 0x30 *b = 0x5B) || (*b = 0x5D))
++(*b = 0x30 *b = 0x5B) || (*b = 0x5D
static_casttypename std::basic_stringCh::traits_type::int_type(*b) = 0xFF))
result += *b;
else if (*b == Ch('\b')) result += Ch('\\'), result += Ch('b');
else if (*b == Ch('\f')) result += Ch('\\'), result += Ch('f');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Re: ship Maven meta information to ease creation of LO plugins with Maven
Hi all, thanks for all your answers. I hadn't noticed the change in Debian. But I am really glad that it also made its way upstream where all distributions can benefit from this change. Thanks for all your work Sebastian -- Web: http://www.crustulus.de | Blog: http://www.crustulus.de/cgi-bin/blog.cgi?de-0 Freies Latein-Deutsch-Wörterbuch: http://www.crustulus.de/freedict.de.html FreeDict: Free multilingual dictionary databases - http://www.freedict.org signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/concat-deps.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9db717d063ae60a56e2304e5bf53ae62652e3f97
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Apr 2 17:41:52 2014 +0200
Internal linkage
Change-Id: Id329745fa1988003b4771c6b7d75f2db0930184c
diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c
index a64723f..439deb9 100644
--- a/solenv/bin/concat-deps.c
+++ b/solenv/bin/concat-deps.c
@@ -187,7 +187,7 @@ void* data = NULL;
* this is a simplified implementation that
* is _not_ thread safe.
*/
-struct pool* pool_create(int size_elem, int primary, int secondary)
+static struct pool* pool_create(int size_elem, int primary, int secondary)
{
struct pool* pool;
@@ -210,7 +210,7 @@ struct pool* pool;
}
-void pool_destroy(struct pool* pool)
+static void pool_destroy(struct pool* pool)
{
void* extent;
void* next;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - cui/source
cui/source/tabpages/chardlg.cxx | 20
1 file changed, 20 insertions(+)
New commits:
commit 63dd47aed73a502bfbf3b490bd8b9f26528fdfc0
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 2 15:18:05 2014 +0100
Resolves: fdo#75307 discard invalid user data
Change-Id: Id39b51c344004e02d3d5a281ba98721b944468c3
(cherry picked from commit f5b9db43080658201caf07cd646bae4f4f2acc95)
Reviewed-on: https://gerrit.libreoffice.org/8815
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 3e6807c..28222fa 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -2897,6 +2897,26 @@ void SvxCharPositionPage::Reset( const SfxItemSet rSet )
m_nSubEsc = (short)sUser.getToken( 1, ';' ).toInt32();
m_nSuperProp = (sal_uInt8)sUser.getToken( 2, ';' ).toInt32();
m_nSubProp = (sal_uInt8)sUser.getToken( 3, ';' ).toInt32();
+
+//fdo#75307 validate all the entries and discard all of them if any are
+//out of range
+bool bValid = true;
+if (m_nSuperEsc m_pHighLowMF-GetMin() || m_nSuperEsc
m_pHighLowMF-GetMax())
+bValid = false;
+if (m_nSubEsc*-1 m_pHighLowMF-GetMin() || m_nSubEsc*-1
m_pHighLowMF-GetMax())
+bValid = false;
+if (m_nSuperProp m_pFontSizeMF-GetMin() || m_nSuperProp
m_pFontSizeMF-GetMax())
+bValid = false;
+if (m_nSubProp m_pFontSizeMF-GetMin() || m_nSubProp
m_pFontSizeMF-GetMax())
+bValid = false;
+
+if (!bValid)
+{
+m_nSuperEsc = DFLT_ESC_SUPER;
+m_nSubEsc = DFLT_ESC_SUB;
+m_nSuperProp = DFLT_ESC_PROP;
+m_nSubProp = DFLT_ESC_PROP;
+}
}
short nEsc = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/compat.hxx | 11 +++
compilerplugins/clang/literaltoboolconversion.cxx | 16 +---
2 files changed, 16 insertions(+), 11 deletions(-)
New commits:
commit b4e5b8bc1d6be0d53843ac68ba86da4d8cd0c2b0
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed Apr 2 17:53:43 2014 +0200
Add compat::isInMainFile
Change-Id: I0e155c6c68a43020110a8e1c0cb29cabdcade454
diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 1f025e7..3d26572 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -20,6 +20,7 @@
#include clang/AST/Type.h
#include clang/Basic/Diagnostic.h
#include clang/Basic/DiagnosticIDs.h
+#include clang/Basic/SourceManager.h
#include llvm/ADT/StringRef.h
#include llvm/Support/FileSystem.h
#include llvm/Support/raw_ostream.h
@@ -101,6 +102,16 @@ inline unsigned getBuiltinCallee(clang::CallExpr const
expr) {
#endif
}
+inline bool isInMainFile(
+clang::SourceManager const manager, clang::SourceLocation Loc)
+{
+#if (__clang_major__ == 3 __clang_minor__ = 4) || __clang_major__ 3
+return manager.isInMainFile(Loc);
+#else
+return manager.isFromMainFile(Loc);
+#endif
+}
+
inline unsigned getCustomDiagID(
clang::DiagnosticsEngine engine, clang::DiagnosticsEngine::Level L,
llvm::StringRef FormatString)
diff --git a/compilerplugins/clang/literaltoboolconversion.cxx
b/compilerplugins/clang/literaltoboolconversion.cxx
index c94e0d1..4c3c3a4 100644
--- a/compilerplugins/clang/literaltoboolconversion.cxx
+++ b/compilerplugins/clang/literaltoboolconversion.cxx
@@ -151,17 +151,11 @@ bool LiteralToBoolConversion::VisitImplicitCastExpr(
bool LiteralToBoolConversion::isFromCIncludeFile(
SourceLocation spellingLocation) const
{
-#if (__clang_major__ == 3 __clang_minor__ = 4) || __clang_major__ 3
-if (compiler.getSourceManager().isInMainFile(spellingLocation)) {
-return false;
-}
-#else
-if (compiler.getSourceManager().isFromMainFile(spellingLocation)) {
-return false;
-}
-#endif
-return
StringRef(compiler.getSourceManager().getPresumedLoc(spellingLocation)
-.getFilename()).endswith(.h);
+return !compat::isInMainFile(compiler.getSourceManager(), spellingLocation)
+ (StringRef(
+compiler.getSourceManager().getPresumedLoc(spellingLocation)
+.getFilename())
+.endswith(.h));
}
bool LiteralToBoolConversion::isMacroBodyExpansion(SourceLocation location)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source
sc/source/filter/excel/xestream.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2dd84cf254f28523c3ff7f014fdbc515e9b89daa
Author: Eike Rathke er...@redhat.com
Date: Wed Apr 2 16:54:17 2014 +0200
resolved fdo#76949 correct grammar is GRAM_OOXML
Regression introduced with ca8ca8c28742879220f3ff88ae0d71c8d69b11cd that
used GRAM_ENGLISH_XL_OOX instead, which is English UI function names
with OOXML reference syntax.
Change-Id: If6b73e85a45e57f6ef281d1edf8e34dec7cb9bb8
(cherry picked from commit 31e4419ac7581aa7864905bcd4ce42e14df6c9bb)
Reviewed-on: https://gerrit.libreoffice.org/8817
Reviewed-by: Kohei Yoshida libreoff...@kohei.us
Tested-by: Kohei Yoshida libreoff...@kohei.us
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index 3e9935d..035a827 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -824,7 +824,7 @@ OUString XclXmlUtils::ToOUString(
ScDocument rDocument, const ScAddress rAddress, const ScTokenArray*
pTokenArray )
{
ScCompiler aCompiler( rDocument, rAddress,
const_castScTokenArray(*pTokenArray));
-aCompiler.SetGrammar(FormulaGrammar::GRAM_ENGLISH_XL_OOX);
+aCompiler.SetGrammar(FormulaGrammar::GRAM_OOXML);
OUStringBuffer aBuffer( pTokenArray-GetLen() * 5 );
aCompiler.CreateStringFromTokenArray( aBuffer );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #123 from mgme...@gmail.com --- hello all, i need to ask something. i have submitted a code to libreoffice as an initial step to participate in gsoc. since then, i am receiving various emails about other bugs. since i am new to GSOC, i dont know what should be my next step. can you please tell me about that On Wed, Apr 2, 2014 at 8:38 PM, bugzilla-dae...@freedesktop.org wrote: Bug 65675 https://bugs.freedesktop.org/show_bug.cgi?id=65675 depends on bug 76949 https://bugs.freedesktop.org/show_bug.cgi?id=76949, which changed state. What Removed Added Status ASSIGNED RESOLVED Resolution --- FIXED -- You are receiving this mail because: - You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: formula/source
formula/source/core/resource/core_resource.src |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit f07bdba6c586044ab4249f34d808e394ba6edb3c
Author: Winfried Donkers winfrieddonk...@libreoffice.org
Date: Wed Apr 2 19:59:13 2014 +0200
fdo#71720 fix transalate strings
Change-Id: I8758e2407f1d3d1e09324b4fe5cc0442f8dda34d
Reviewed-on: https://gerrit.libreoffice.org/8819
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/formula/source/core/resource/core_resource.src
b/formula/source/core/resource/core_resource.src
index e008f6c..4f5b91d 100644
--- a/formula/source/core/resource/core_resource.src
+++ b/formula/source/core/resource/core_resource.src
@@ -1665,15 +1665,15 @@ Resource RID_STRLIST_FUNCTION_NAMES
};
String SC_OPCODE_CEIL_MS
{
-Text = CEILING.PRECISE ;
+Text [ en-US ] = CEILING.PRECISE ;
};
String SC_OPCODE_CEIL_ISO
{
-Text = ISO.CEILING ;
+Text [ en-US ] = ISO.CEILING ;
};
String SC_OPCODE_FLOOR_MS
{
-Text = FLOOR.PRECISE ;
+Text [ en-US ] = FLOOR.PRECISE ;
};
String SC_OPCODE_FLOOR
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - writerfilter/inc writerfilter/source
writerfilter/inc/WriterFilterDllApi.hxx|6
writerfilter/inc/resourcemodel/Fraction.hxx|2
writerfilter/inc/resourcemodel/LoggedResources.hxx |8
writerfilter/inc/resourcemodel/QNameToString.hxx |4
writerfilter/inc/resourcemodel/ResourceModelHelper.hxx |2
writerfilter/inc/resourcemodel/SubSequence.hxx | 247 -
writerfilter/inc/resourcemodel/TagLogger.hxx |2
writerfilter/inc/resourcemodel/WW8ResourceModel.hxx| 12
writerfilter/inc/resourcemodel/XPathLogger.hxx |2
writerfilter/inc/resourcemodel/exceptions.hxx | 54 ---
writerfilter/inc/resourcemodel/util.hxx|4
writerfilter/source/resourcemodel/qnametostrcore.cxx |4
12 files changed, 20 insertions(+), 327 deletions(-)
New commits:
commit 8b867eae9b5ef2f5ec3b296a69751e00d1d07751
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 21:10:16 2014 +0200
writerfilter: unused Exception class
Change-Id: I127ef1183a2c146471668680965fa3d72f6a8f81
diff --git a/writerfilter/inc/resourcemodel/exceptions.hxx
b/writerfilter/inc/resourcemodel/exceptions.hxx
deleted file mode 100644
index 6abb34c..000
--- a/writerfilter/inc/resourcemodel/exceptions.hxx
+++ /dev/null
@@ -1,54 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef _DOCTOK_EXCEPTIONS_HXX
-#define _DOCTOK_EXCEPTIONS_HXX
-
-#include string
-#include WriterFilterDllApi.hxx
-
-namespace writerfilter {
-using namespace ::std;
-
-class Exception
-{
-string mText;
-
-public:
-Exception(string text) : mText(text) {}
-
-const string getText() const { return mText; }
-};
-
-class ExceptionNotFound : public Exception
-{
-public:
-ExceptionNotFound(string text) : Exception(text) {}
-};
-
-class ExceptionOutOfBounds : public Exception
-{
-public:
-ExceptionOutOfBounds(string text) : Exception(text) {}
-};
-}
-
-#endif // _DOCTOK_EXCEPTIONS_HXX
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 6320f7a5ee12cfc58f6b0f5d04108fba959cc92e
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Apr 2 21:00:00 2014 +0200
writerfilter: unused SubSequence class
Change-Id: Ib52309202714e67af78ef5a47f519779d849931c
diff --git a/writerfilter/inc/resourcemodel/SubSequence.hxx
b/writerfilter/inc/resourcemodel/SubSequence.hxx
deleted file mode 100644
index 6b6b1ed..000
--- a/writerfilter/inc/resourcemodel/SubSequence.hxx
+++ /dev/null
@@ -1,247 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_SUB_SEQUENCE_HXX
-#define INCLUDED_SUB_SEQUENCE_HXX
-
-#include com/sun/star/uno/Sequence.hxx
-
-#include boost/shared_ptr.hpp
-#include iostream
-#include stdio.h
-#include ctype.h
-#include exceptions.hxx
-#include WriterFilterDllApi.hxx
-
-namespace writerfilter {
-using namespace ::std;
-
-template class T
-class SubSequence;
-
-template class T
-class SubSequence
-{
-typedef boost::shared_ptrcom::sun::star::uno::SequenceT
-SequencePointer;
-
-SequencePointer mpSequence;
-sal_uInt32 mnOffset;
-sal_uInt32 mnCount;
-
-public:
-typedef boost::shared_ptrSubSequence Pointer_t;
-
-SubSequence() : mpSequence(new
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui | 806 - 1 file changed, 416 insertions(+), 390 deletions(-) New commits: commit e46372fc5ca6c28386fa763385f38f79c8bf4b67 Author: Jan Holesovsky ke...@collabora.com Date: Wed Apr 2 19:37:46 2014 +0200 Pivot dialog: Make it resemble the old dialog a bit. No idea what is best here :-) - MSO is more like what it was before this change, OTOH this layout looks more as the final pivot table, which (in my eyes) makes it easier to use. Change-Id: I5acb8c151139688c71b06d07006499513a17bdb9 diff --git a/sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui b/sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui index 549bdd0..e7820a7 100644 --- a/sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui +++ b/sc/uiconfig/scalc/ui/pivottablelayoutdialog.ui @@ -1,7 +1,6 @@ ?xml version=1.0 encoding=UTF-8? -!-- Generated with glade 3.16.1 -- interface - requires lib=gtk+ version=3.0/ + !-- interface-requires gtk+ 3.0 -- !-- interface-requires LibreOffice 1.0 -- object class=GtkDialog id=PivotTableLayout property name=can_focusFalse/property @@ -70,281 +69,452 @@ /packing /child child - object class=GtkGrid id=grid1 + object class=GtkBox id=box1 property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property property name=vexpandTrue/property -property name=row_spacing6/property -property name=column_spacing12/property +property name=orientationvertical/property +property name=spacing6/property child - object class=GtkLabel id=label1 + object class=GtkBox id=box2 property name=visibleTrue/property property name=can_focusFalse/property -property name=xalign0/property -property name=xpad4/property -property name=label translatable=yesAvailable Fields:/property -property name=use_underlineTrue/property -property name=mnemonic_widgetlistbox-fields/property -attributes - attribute name=weight value=bold/ -/attributes - /object - packing -property name=left_attach2/property -property name=top_attach0/property -property name=width1/property -property name=height1/property - /packing -/child -child - object class=GtkScrolledWindow id=scrolledwindow2 -property name=visibleTrue/property -property name=can_focusTrue/property -property name=hexpandTrue/property property name=vexpandTrue/property -property name=shadow_typein/property +property name=border_width6/property +property name=spacing6/property child - object class=scuilo-ScPivotLayoutTreeList id=listbox-column -property name=width_request200/property -property name=height_request100/property + object class=GtkGrid id=grid7 property name=visibleTrue/property -property name=can_focusTrue/property +property name=can_focusFalse/property property name=hexpandTrue/property property name=vexpandTrue/property -child internal-child=selection - object class=GtkTreeSelection id=Pivot Table List-selection6/ +property name=row_spacing6/property +property name=column_spacing6/property +child + object class=GtkBox id=box4 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=orientationvertical/property +property name=spacing6/property +child + object class=GtkLabel id=label3 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=xalign0/property +property name=yalign0/property +property name=xpad4/property +property name=label translatable=yesColumn Fields:/property +property name=use_underlineTrue/property +property name=mnemonic_widgetlistbox-column/property +attributes + attribute name=weight value=bold/ +/attributes +
chart xshape tests are now enabled on @50 tinderbox
Hey, so the chart XShape tests are enabled again on the @50 tinderbox. They test the layout and rendering of charts and are therefore the missing piece besides the import and export tests in chart2. Sadly we can't push them to more machines as the chart layout is not the same on each machine. They have been enabled for a short period in the past on all machines but there have been so many problems with small rendering differences between different machines that I decided this time to limit the test for now to a single tinderbox. There is now no excuse anymore to not add a test when you fix a bug in chart2 unless it is for the dialogs. Please help me avoid such embarrassing bugs like fdo#75075 in the future in chart2. I will use that tinderbox in the future for more exotic tests that I can't or don't want to enable by default so don't be surprised if you see the tinderbox complain in tests that are not executed locally. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 76678] Picture from Calc cannot insert to Gimp
https://bugs.freedesktop.org/show_bug.cgi?id=76678 Tomaz Vajngerl qui...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #7 from Tomaz Vajngerl qui...@gmail.com --- Resolved by backporting of [1] and [2]. The fix will be in LO 4.2.4 [1]: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2id=1711bf49b0a426908c74b98e215c0ef8f3d2e601 [2]: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2id=001af24128f04df6583bd9613090568817f2b5b2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76930] New: Creating an Index produces error message
https://bugs.freedesktop.org/show_bug.cgi?id=76930 Priority: medium Bug ID: 76930 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Creating an Index produces error message Severity: normal Classification: Unclassified OS: Windows (All) Reporter: winfrieddonk...@libreoffice.org Hardware: Other Status: NEW Version: 4.2.3.2 rc Component: Writer Product: LibreOffice Open new writer document, enter text with at least one index item. menu Insert - Indexes and Tables - Indexes and Tables... A message appears: File internal/idxexample.sdw not found in path [paths]. After Acknowledging this message the Index dialog appears. AFAICS this bug doesn't harm anything, but is annoying and confusing for users. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76930] Creating an Index produces error message
https://bugs.freedesktop.org/show_bug.cgi?id=76930 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75522] corruption while copying cells to irfanview
https://bugs.freedesktop.org/show_bug.cgi?id=75522 --- Comment #32 from Burak Ural buraku...@gmail.com --- Hi, I have tested libo-42~2014-04-01_09.38.08_LibreOfficeDev_4.2.4.0.0_Win_x86.msi on Windows XP SP3. It works fine , I tested for both clipboard copy paste and lookup function bugs, they are both solved. Thanks for all the help. On Tue, Apr 1, 2014 at 5:17 PM, bugzilla-dae...@freedesktop.org wrote: *Comment # 31 https://bugs.freedesktop.org/show_bug.cgi?id=75522#c31 on bug 75522 https://bugs.freedesktop.org/show_bug.cgi?id=75522 from Tomaz Vajngerl qui...@gmail.com * (In reply to comment #30 https://bugs.freedesktop.org/show_bug.cgi?id=75522#c30) Which one, is the current one ok? http://dev-builds.libreoffice.org/daily/libreoffice-4-2/Win-x86@42/current/ Yes, it's OK.. but just to be safe I used [1]. [1]http://dev-builds.libreoffice.org/daily/libreoffice-4-2/Win-x86@42/2014-04-01_09.38.08/ -- You are receiving this mail because: - You are on the CC list for the bug. - You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76931] New: Slideshow at 100% zoom factor
https://bugs.freedesktop.org/show_bug.cgi?id=76931 Priority: medium Bug ID: 76931 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Slideshow at 100% zoom factor Severity: normal Classification: Unclassified OS: All Reporter: narayana...@outlook.com Hardware: Other Status: UNCONFIRMED Version: 4.2.0.2 rc Component: Presentation Product: LibreOffice I make a lot of presentations by taking screenshots of GUIs (or their parts), and annotating them. The images look crisp only when- (a) the screenshot is pasted at 100%, and (b) the slide is viewed at 100%. But since the slideshow mode of Impress does not have a 100% zoom mode. It has either full screen mode or window mode. It is virtually impossible to adjust the window size so that the image is rendered precisely at 100%. While adjusting the window size manually, we never know whether we are below 100% or above 100% magnification. I think this would be a fairly regular use case. Desired: Please provide a slideshow setting where the presentation is made at 100% zoom factor. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76930] Creating an Index produces error message
https://bugs.freedesktop.org/show_bug.cgi?id=76930 sophie gautier.sop...@gmail.com changed: What|Removed |Added CC||gautier.sop...@gmail.com --- Comment #1 from sophie gautier.sop...@gmail.com --- For information, I do not reproduce with Version: 4.2.3.2 Build ID: 7c5c769e412afd32da4d946d2cb0c8b0674e95e0 on Ubuntu 13.10. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76586] FILEOPEN DOCX Column width not imported properly
https://bugs.freedesktop.org/show_bug.cgi?id=76586 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard||target:4.3.0 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Vinaya Mandke committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=54d913aa74962781e31290d9bb7e2d95212d994c fdo#76586 Table column separators from individual cell widths The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75522] corruption while copying cells to irfanview
https://bugs.freedesktop.org/show_bug.cgi?id=75522 Tomaz Vajngerl qui...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #33 from Tomaz Vajngerl qui...@gmail.com --- Resolved by backporting of [1] and [2]. The fix will be in LO 4.2.4 [1]: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2id=1711bf49b0a426908c74b98e215c0ef8f3d2e601 [2]: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2id=001af24128f04df6583bd9613090568817f2b5b2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76932] New: Other: No scrolling in --help GUI / Help Message window
https://bugs.freedesktop.org/show_bug.cgi?id=76932 Priority: medium Bug ID: 76932 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: No scrolling in --help GUI / Help Message window Severity: normal Classification: Unclassified OS: Windows (All) Reporter: genial.dane...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.1.1 release Component: Libreoffice Product: LibreOffice Starting LibreOffice.../program/soffice.exe --help from command-line, a window/dialog opens with command/switch descriptions, the text goes past its height, but no scrolling option is available. Steps to reproduce: 1. Start soffice --help from CLI 2. Help Message window opens 3. Maximize, try to Ctrl+A the text, etc the Help Message window, no way to read the whole text. 4. Close button doesn't work too (probably the textbox overlays it). Also: Why not echo description to stdout (so it can be dumped to file)? Why no /? alias for windows? Operating System: Windows 7 Version: 4.2.1.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76916] Section User paths is missing in tab Motion Paths of Animation
https://bugs.freedesktop.org/show_bug.cgi?id=76916 sophie gautier.sop...@gmail.com changed: What|Removed |Added OS|Windows (All) |All Status|UNCONFIRMED |NEW CC||gautier.sop...@gmail.com Ever confirmed|0 |1 --- Comment #1 from sophie gautier.sop...@gmail.com --- Confirmed, the options exist in 4.1.5.3 but no more on 4.2.3.2 - Set as New, changed plateform - Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76930] Creating an Index produces error message
https://bugs.freedesktop.org/show_bug.cgi?id=76930 --- Comment #2 from Winfried Donkers winfrieddonk...@libreoffice.org --- Created attachment 96763 -- https://bugs.freedesktop.org/attachment.cgi?id=96763action=edit sample writer document Attached document showed the error message when the index was created and also shows it when I remove the index and insert a new one. Extra O/S information: Windows 7-64 professional, Dutch I can't reproduce the problem on fairly recent master (5 days old) and openSUSE 13.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76930] Creating an Index produces error message
https://bugs.freedesktop.org/show_bug.cgi?id=76930 --- Comment #3 from Winfried Donkers winfrieddonk...@libreoffice.org --- (In reply to comment #1) For information, I do not reproduce with Version: 4.2.3.2 Build ID: 7c5c769e412afd32da4d946d2cb0c8b0674e95e0 on Ubuntu 13.10. My build ID is identical, but O/S is not (see comment #2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71423] Impress frequently crashes when editing tables in slides
https://bugs.freedesktop.org/show_bug.cgi?id=71423 --- Comment #35 from Thorsten Behrens t...@libreoffice.org --- Played a bit with the sample documents, couldn't make it crash. Could someone who sees this attach a screenshot just before the crashing? I'm particularly interested in the state of the Styles Formatting floater. Backtrace hints at const SfxStyleFamilyItem *pItem = GetFamilyItem_Impl(); pStyleSheetPool-SetSearchMask(pItem-GetFamily(), SFXSTYLEBIT_ALL_VISIBLE); pItem being NULL or something. Band-aid fix is trivial, but would be good to know this is really the sticking point. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74582] Calc Named interval looses reference when reference is external
https://bugs.freedesktop.org/show_bug.cgi?id=74582 sophie gautier.sop...@gmail.com changed: What|Removed |Added CC||gautier.sop...@gmail.com --- Comment #7 from sophie gautier.sop...@gmail.com --- I could not reproduce with 4.2.3.2 and Ubuntu 13.10 - Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76932] Other: No scrolling in --help GUI / Help Message window
https://bugs.freedesktop.org/show_bug.cgi?id=76932 --- Comment #1 from genial.dane...@gmail.com --- 4.2.2.1 - same thing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71423] Impress frequently crashes when editing tables in slides
https://bugs.freedesktop.org/show_bug.cgi?id=71423 --- Comment #36 from choffardet pierre.choffar...@free.fr --- This bug is quite curious. I've yet a sample doc : https://www.dropbox.com/s/dutvaaopn2rjrng/impress%20crash.odp To make LO crash, I just have to select the word 'Domaine' and right-clic on 'default'. LO crash almost every times It crashes on my laptop and on my notebook (both with Seven x64) But it does not crash with LO 4.1.6+ (on both computers) and does not crash on Vmwares with LO 4.1.3.2 and XP or Seven x64 But with any LO on these computers I can always make LO crash, just playing with tables (inserting columns, lines, copy, pasting, changing font, size, color) it just take less than 5 min. sometimes 5 seconds, and yes rarely, I can't make it crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76934] New: FILESAVE : DOCX : Title style is not preserved
https://bugs.freedesktop.org/show_bug.cgi?id=76934 Priority: medium Bug ID: 76934 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE : DOCX : Title style is not preserved Severity: normal Classification: Unclassified OS: All Reporter: pallavi.jad...@synerzip.com Hardware: Other Status: UNCONFIRMED Version: 4.2.0.0.alpha0+ Master Component: Writer Product: LibreOffice Created attachment 96766 -- https://bugs.freedesktop.org/attachment.cgi?id=96766action=edit Contains Title Style. Text is divided into two columns. Steps to reproduce : 1] Open attached DOCX in LO 2] Perform save_as 3] Open saved file in MS Office 2010 Current behavior : 1) Justification is changed from Center to Left. 2) Text is no more Bold. 3) Font Name is converted from Arial to Times New Roman. 4) Text Size is changed. Expected behavior : 1) Justification should be Center. 2) Text should be Bold. 3) Font Name should be Arial. 4) Text Size should be 18. Problem at both Import and Export side. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76934] FILESAVE : DOCX : Title style is not preserved
https://bugs.freedesktop.org/show_bug.cgi?id=76934 pallavi.jad...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |pallavi.jad...@synerzip.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76878] Polygons, curves, and contours fail to load correct text rotation
https://bugs.freedesktop.org/show_bug.cgi?id=76878 sophie gautier.sop...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||gautier.sop...@gmail.com Ever confirmed|0 |1 --- Comment #2 from sophie gautier.sop...@gmail.com --- Confirmed using Ubuntu 13.10 Version: 4.2.3.2 Build ID: 7c5c769e412afd32da4d946d2cb0c8b0674e95e0 with the provided document and a new one - Set as new - Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76735] UI: Options below Pivot Table - More not visable in 768pixel high GNOME (thus Pivot is useless)
https://bugs.freedesktop.org/show_bug.cgi?id=76735 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Summary|UI: Options below Pivot|UI: Options below Pivot |Table - More not visable |Table - More not visable |in GNOME (thus Pivot is |in 768pixel high GNOME |useless)|(thus Pivot is useless) --- Comment #6 from Caolán McNamara caol...@redhat.com --- I did shrink it with http://cgit.freedesktop.org/libreoffice/core/commit/sc/source/ui/src/condformatdlg.src?h=libreoffice-4-2-3id=a79ce257ae9974f14c7ac1d9adc990a54ae554b7 a little for -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76936] New: FILESAVE: SVG files not compressed anymore in ODT
https://bugs.freedesktop.org/show_bug.cgi?id=76936 Priority: medium Bug ID: 76936 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE: SVG files not compressed anymore in ODT Severity: normal Classification: Unclassified OS: Windows (All) Reporter: come.despl...@free.fr Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.2.2.1 release Component: Writer Product: LibreOffice Created attachment 96767 -- https://bugs.freedesktop.org/attachment.cgi?id=96767action=edit Document saved with LibreOffice 4.1 The SVG files are not compressed in ODT since LibreOffice 4.2. Documents containing SVG files are significantly bigger than with previous versions. It seems that the method Store is used in the Picture directory instead of the method Deflate. It makes sense for PNG files, but not for SVG Steps to reproduce: 1. Insert SVG file in your document 2. Save Document Current behavior: The document size is significantly bigger than it should. Expected behavior: SVG files should be compressed with Deflate method. Operating System: Windows 8 Version: 4.2.2.1 release Last worked in: 4.1.5.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76937] New: In Style Formatting dialog, the layout of Position controls is haphazard and confusing
https://bugs.freedesktop.org/show_bug.cgi?id=76937 Priority: medium Bug ID: 76937 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: In Style Formatting dialog, the layout of Position controls is haphazard and confusing Severity: normal Classification: Unclassified OS: All Reporter: narayana...@outlook.com Hardware: Other Status: UNCONFIRMED Version: 4.2.0.2 rc Component: Writer Product: LibreOffice 1. Press F11 to view the Style Formatting dialog. 2. Click on the List styles button 3. Select any existing style and right-click. 4. From the context menu, select the Modify... (or New...) option. 5. The numbering style editor dialog opens. Switch to the Position tab. 6. There are several problems here: (a) The level list and the controls look like two columns of the same table. In other words, level#1 corresponds to Numbering followed by entry. Similarly, level#5/6 corresponds to the Numbering alignment entry. (b) The labels and actual controls are placed far too apart (there's a huge gap) (c) The controls are not placed in the correct sequence of their use. (d) They are not functionally grouped. As a result, the layout is extremely confusing and difficult to use. I have made a video that shows these problems and suggested layout. https://drive.google.com/file/d/0BwlATzWr1zTObFFJcUxycG9mY0U/edit?usp=sharing To keep its size small, I have inserted a Pause symbol at certain points. Please pause the video at these points and pay attention to finer details. Please download and confirm, so that I can removed the video from my drive. (I do not intend to keep the video forever on my Google drive) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76938] New: FILESAVE: SVG files not compressed anymore in ODT
https://bugs.freedesktop.org/show_bug.cgi?id=76938 Priority: medium Bug ID: 76938 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE: SVG files not compressed anymore in ODT Severity: normal Classification: Unclassified OS: Windows (All) Reporter: come.despl...@free.fr Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.2.2.1 release Component: Writer Product: LibreOffice Created attachment 96768 -- https://bugs.freedesktop.org/attachment.cgi?id=96768action=edit Document with SVG saved with LibreOffice 4.2 The SVG files are not compressed in ODT since LibreOffice 4.2. Documents containing SVG files are significantly bigger than with previous versions. It seems that the method Store is used in the Picture directory instead of the method Deflate. It makes sense for PNG files, but not for SVG Steps to reproduce: 1. Insert SVG file in your document 2. Save Document Current behavior: The document size is significantly bigger than it should. Expected behavior: SVG files should be compressed with Deflate method. Operating System: Windows 8 Version: 4.2.2.1 release Last worked in: 4.1.5.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73984] Lost format in axis units and lost names of legends in Chart pasted from Calc to Writer
https://bugs.freedesktop.org/show_bug.cgi?id=73984 --- Comment #2 from Nono j.arraez.monl...@gmail.com --- Created attachment 96769 -- https://bugs.freedesktop.org/attachment.cgi?id=96769action=edit file asked (bugzilla-dae...@freedesktop.org) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76938] FILESAVE: SVG files not compressed anymore in ODT
https://bugs.freedesktop.org/show_bug.cgi?id=76938 --- Comment #1 from Côme Desplats come.despl...@free.fr --- Created attachment 96770 -- https://bugs.freedesktop.org/attachment.cgi?id=96770action=edit Document with SVG saved with LibreOffice 4.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76941] New: EDITING: .docx file not equal to original
https://bugs.freedesktop.org/show_bug.cgi?id=76941 Priority: medium Bug ID: 76941 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: .docx file not equal to original Severity: normal Classification: Unclassified OS: Windows (All) Reporter: be...@sapo.pt Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.2.1 release Component: Writer Product: LibreOffice Problem description: Steps to reproduce: 1. open a .docx file with black and white images Current behavior: the images appear in color. Expected behavior: the images should be black and white. Operating System: Windows 7 Version: 4.2.2.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76942] New: EPS preview image (epsi) neither exported to pdf nor displayed in full screen mode
https://bugs.freedesktop.org/show_bug.cgi?id=76942 Priority: medium Bug ID: 76942 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EPS preview image (epsi) neither exported to pdf nor displayed in full screen mode Severity: normal Classification: Unclassified OS: Windows (All) Reporter: schno...@mailzone.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.1.1 release Component: Presentation Product: LibreOffice This is not a repeat of a bug report 'eps image cannot be exported to pdf' ! An eps-file with integrated preview image (an epsi-file) is neither exported to pdf nor displayed in full-screen mode. At least the preview image should be displayed if the eps cannot be rendered directly. In LO and OO version 3.x this worked correctly! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62947] UI Add 'paste special' or even better 'paste text without formatting' to context menu in Writer
https://bugs.freedesktop.org/show_bug.cgi?id=62947 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Whiteboard|NeedsDevEval|EasyHack DifficultyBeginner -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69750] Feature request: Preserve last used Paste special options selection for next use
https://bugs.freedesktop.org/show_bug.cgi?id=69750 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl Summary|Feature request: Paste |Feature request: Preserve |special options selection |last used Paste special ||options selection for next ||use -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43442] Calc UI: Preselected options in Paste Special dialog are not sensible
https://bugs.freedesktop.org/show_bug.cgi?id=43442 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=69750 Version|3.5.4 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69750] Feature request: Preserve last used Paste special options selection for next use
https://bugs.freedesktop.org/show_bug.cgi?id=69750 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=43442 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75252] Allow to select a new default for Edit-Paste in Edit-Paste Special
https://bugs.freedesktop.org/show_bug.cgi?id=75252 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Component|UI |Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75252] UI: Allow to select a new default for Edit-Paste in Edit-Paste Special
https://bugs.freedesktop.org/show_bug.cgi?id=75252 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Summary|Allow to select a new |UI: Allow to select a new |default for Edit-Paste in |default for Edit-Paste in |Edit-Paste Special |Edit-Paste Special -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76943] New: UI: Add option to set default for Paste to as text without formatting
https://bugs.freedesktop.org/show_bug.cgi?id=76943 Priority: medium Bug ID: 76943 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: Add option to set default for Paste to as text without formatting Severity: enhancement Classification: Unclassified OS: All Reporter: c...@nouenoff.nl Hardware: Other Status: UNCONFIRMED Version: Inherited From OOo Component: UI Product: LibreOffice At least for Writer, Impress (Draw) this would make sense. People that paste without thinking, just have text without formatting. For other choices Paste special should be used. Technically, when there is no text to paste, Past special should be presented, IMO. For the position of the option, the following seem sensible: In Writer Tools Options Writer Formatting aid In Impress Tools Options Impress General -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76943] UI: Add option to set default for Paste to as text without formatting
https://bugs.freedesktop.org/show_bug.cgi?id=76943 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||c...@nouenoff.nl, ||libreoffice-ux-advise@lists ||.freedesktop.org Ever confirmed|0 |1 --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Opinions ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63786] PDF: cropped svg image in writer, not cropped when viewed in exported Pdf document.
https://bugs.freedesktop.org/show_bug.cgi?id=63786 Michael Stahl mst...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |mst...@redhat.com |desktop.org | Component|Writer |Printing and PDF export --- Comment #5 from Michael Stahl mst...@redhat.com --- fixed on master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71475] PDF: Cropping imported SVG images not reliable in Export/print
https://bugs.freedesktop.org/show_bug.cgi?id=71475 Michael Stahl mst...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||mst...@redhat.com Version|4.1.0.4 release |4.0.0.3 release --- Comment #3 from Michael Stahl mst...@redhat.com --- similar to bug 63786, but this one appears to be working already in 4.2.0 (when viewed with Okular) *** This bug has been marked as a duplicate of bug 63786 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76944] New: Forms Time default Value
https://bugs.freedesktop.org/show_bug.cgi?id=76944 Priority: medium Bug ID: 76944 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Forms Time default Value Severity: normal Classification: Unclassified OS: Windows (All) Reporter: funm...@talktalk.net Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.0.4 release Component: Database Product: LibreOffice In the Time field control, when a default value is entered it does not display the correct time. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76943] UI: Add option to set default for Paste to as text without formatting
https://bugs.freedesktop.org/show_bug.cgi?id=76943 --- Comment #2 from Sveinn í Felli svei...@nett.is --- Yes please, paste into the current style at cursor location. Guess it could eliminate a lot of Askbot questions like how to eliminate links in text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
