LibreOffice Gerrit News for core on 2014-11-01
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Fix fdo#84795 Menu, DropDown-List not disappears with right mouse click in https://gerrit.libreoffice.org/12061 from juegen funk about module vcl + SIFR: Adding new icons for page break number and footnote and fixing ot in https://gerrit.libreoffice.org/12169 from Yousuf Philips about module icon-themes + fdo#85620 - Changing the label 'Gallery' and having it in the insert menu in https://gerrit.libreoffice.org/12167 from Yousuf Philips about module officecfg, sc, sd, sw + toolkit: don't force gb_OBJCXXFLAGS for all .cxx files in https://gerrit.libreoffice.org/12166 from Douglas Mencken about module toolkit + gbuild: introduce add_objcxxflags_exception_object/objects in https://gerrit.libreoffice.org/11815 from Douglas Mencken about module sal, solenv + fdo#60349 - FORMATTING: Icon in Calc toolbar for wrap text in https://gerrit.libreoffice.org/12163 from Yousuf Philips about module icon-themes, officecfg, sc + TANGO: Updated formatting icons and moved old tango sources to human in https://gerrit.libreoffice.org/12147 from Yousuf Philips about module icon-themes, officecfg + Apache Commons Codec 1.9 at least requires Java 1.6 and non debug version in https://gerrit.libreoffice.org/12115 from Robert Antoni Buj i Gelonch about module external + Apache Commons Logging 1.2 - re-enable the non debug version. in https://gerrit.libreoffice.org/12123 from Robert Antoni Buj i Gelonch about module external + fdo#83753: consider JAVA_HOME and PATH when selecting JRE in https://gerrit.libreoffice.org/11392 from Michael Weghorn about module include, jvmfwk End of freshness + crashrep: get rid of tmpnam() in https://gerrit.libreoffice.org/12066 from Julien Nabet about module crashrep + SVG: handle visibility property in https://gerrit.libreoffice.org/12168 from Christina Roßmanith about module svgio + Parse perfcheck results in https://gerrit.libreoffice.org/12155 from Laurent Godard about module bin + add some asserts to validate KeyCode values in https://gerrit.libreoffice.org/12161 from Noel Grandin about module include * Merged changes on master for project core changed in the last 25 hours: + Removed duplicated includes in https://gerrit.libreoffice.org/12160 from Andrea Gelmini + fix missing page break icon from showing in https://gerrit.libreoffice.org/12162 from Yousuf Philips + fdo#80403: AutoCorrect uses XFastParser in https://gerrit.libreoffice.org/12083 from Daniel Sikeler + fdo#80403: Import baseclasses implement FastParser interfaces in https://gerrit.libreoffice.org/12082 from Daniel Sikeler + KEY_ALLMOD is the same as KEY_MOD in https://gerrit.libreoffice.org/12152 from Noel Grandin * Abandoned changes on master for project core changed in the last 25 hours: + solenv: windows: A better way to place separator of dir path to. in https://gerrit.libreoffice.org/12045 from YiiChang Yen * Open changes needing tweaks, but being untouched for more than a week: + Use rtl/character.hxx and dobjectize basiccharclass in https://gerrit.libreoffice.org/11979 from Arnaud Versini + jvmfwk: Apple Oracle's JRE detection for OS X 10.8+ in https://gerrit.libreoffice.org/12057 from Robert Antoni Buj i Gelonch + HIG-ification of GSoC Color Picker dialog in https://gerrit.libreoffice.org/11494 from Olivier Hallot + WIP: fdo#43090: Add an option to disable autoclose brackets in https://gerrit.libreoffice.org/12024 from Marcos Paulo de Souza + convert ScHint ID's to an enum in https://gerrit.libreoffice.org/11986 from Noel Grandin + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl + fdo#58194 - export DOCX Automatic indent as firstLine indent in https://gerrit.libreoffice.org/10425 from Joren De Cuyper + WIP (do not merge): remove custom impl of bidirectional list in https://gerrit.libreoffice.org/11001 from Chris Laplante + fdo#83003 Startcenter: No method for returnin Recent Docs in https://gerrit.libreoffice.org/11525 from Efe Gürkan Yalaman + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your
LibreOffice Gerrit News for submodules on 2014-11-01
Moin! ~~ Project dictionaries ~~ Nothing moved in the project for the last 25 hours ~~ Project translations ~~ Nothing moved in the project for the last 25 hours ~~ Project help ~~ * Open changes on master for project help changed in the last 25 hours: + fdo#85686 update help page for Calc Option Formula in https://gerrit.libreoffice.org/12165 from Olivier Hallot * Merged changes on master for project help changed in the last 25 hours: None * Abandoned changes on master for project help changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: None Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwptools.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 513956cfaddda21b82af76f2c79ed2f2ddec2c82
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Sat Nov 1 01:32:46 2014 -0500
coverity#1250437 : Ressource Leak
Change-Id: Id1c4885c05c70fedcf85360e3ec7c3e166fa01c6
diff --git a/lotuswordpro/source/filter/lwptools.cxx
b/lotuswordpro/source/filter/lwptools.cxx
index c6fad99..cd61c4d 100644
--- a/lotuswordpro/source/filter/lwptools.cxx
+++ b/lotuswordpro/source/filter/lwptools.cxx
@@ -603,7 +603,10 @@ XFDateStyle* LwpTools::GetSystemDateStyle(bool bLongFormat)
default:
{
if ((cSymbol='A' cSymbol='Z') || (cSymbol='a'
cSymbol='z') )
+{
+delete pDateStyle;
return NULL;
+}
else//TEXT
{
//UChar buffer[1024];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/keycod.hxx | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
New commits:
commit 9044260c35b22aeb6fdecee35a6ac34bb660ee35
Author: Noel Grandin n...@peralex.com
Date: Fri Oct 31 09:07:35 2014 +0200
add some asserts to validate KeyCode values
Change-Id: I1b4b8d44f11086ed994a093fef0029982fac2c63
Reviewed-on: https://gerrit.libreoffice.org/12161
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/keycod.hxx b/include/vcl/keycod.hxx
index 3c96d45..a82a2de 100644
--- a/include/vcl/keycod.hxx
+++ b/include/vcl/keycod.hxx
@@ -38,12 +38,11 @@ private:
KeyFuncType eFunc;
public:
-KeyCode() { nKeyCodeAndModifiers = 0; eFunc =
KeyFuncType::DONTKNOW; }
-KeyCode( const ResId rResId );
-KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier = 0 )
-{ nKeyCodeAndModifiers = nKey | nModifier; eFunc =
KeyFuncType::DONTKNOW; }
-KeyCode( sal_uInt16 nKey, bool bShift, bool bMod1, bool bMod2,
bool bMod3 );
-KeyCode( KeyFuncType eFunction );
+KeyCode() { nKeyCodeAndModifiers = 0; eFunc =
KeyFuncType::DONTKNOW; }
+KeyCode( const ResId rResId );
+KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier = 0 );
+KeyCode( sal_uInt16 nKey, bool bShift, bool bMod1, bool
bMod2, bool bMod3 );
+KeyCode( KeyFuncType eFunction );
sal_uInt16 GetFullCode() const { return nKeyCodeAndModifiers; }
KeyFuncType GetFullFunction() const { return eFunc; }
@@ -78,8 +77,17 @@ public:
} // namespace vcl
+inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier )
+{
+assert(nKey = KEY_CODE);
+assert(nModifier = KEY_MODTYPE);
+nKeyCodeAndModifiers = nKey | nModifier;
+eFunc = KeyFuncType::DONTKNOW;
+}
+
inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, bool bShift, bool bMod1, bool
bMod2, bool bMod3 )
{
+assert(nKey = KEY_CODE);
nKeyCodeAndModifiers = nKey;
if( bShift )
nKeyCodeAndModifiers |= KEY_SHIFT;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - configure.ac solenv/bin
configure.ac |5 +
solenv/bin/modules/par2script/work.pm |5 +
2 files changed, 10 insertions(+)
New commits:
commit 76d2d78ac48c0ec7fcdc27c841d0777cab732464
Author: David Tardon dtar...@redhat.com
Date: Sat Nov 1 10:14:16 2014 +0100
fdo#85633 filter out empty file records
Change-Id: I9f96cf3e059d444c52ce81b37cf5f69157c2888d
diff --git a/solenv/bin/modules/par2script/work.pm
b/solenv/bin/modules/par2script/work.pm
index 9c03078..8003785 100644
--- a/solenv/bin/modules/par2script/work.pm
+++ b/solenv/bin/modules/par2script/work.pm
@@ -187,6 +187,11 @@ sub collect_definitions
if ( $oneitem eq Directory ) { if ( $itemkey =~ DosName ) {
$itemkey =~ s/DosName/HostName/; } }
if (( $oneitem eq Directory ) || ( $oneitem eq File ) || (
$oneitem eq Unixlink )) { if ( $itemvalue eq PD_PROGDIR ) { $itemvalue =
PREDEFINED_PROGDIR; }}
if (( $itemkey eq Styles ) ( $itemvalue =~ /^\s*(\w+)(\s*\;\s*)$/
)) { $itemvalue = ($1)$2; }
+elsif ( $itemkey eq Files ) # filter out empty file records, as they
mess up assignment to modules
+{
+$itemvalue =~ /^\(([^)]*)\)$/;
+$itemvalue = '(' . join( ',', grep( !/^$/, split( ',', $1 ) ) ) .
')';
+}
$oneitemhash{$itemkey} = $itemvalue;
}
commit 7f5672bb14956d589fd257067b9eebef3c28e421
Author: David Tardon dtar...@redhat.com
Date: Thu Oct 30 09:58:46 2014 +0100
system libgltf conflicts with dbgutil too
Change-Id: I326d62077b556501d0a98794bca4b00f4bcfc369
diff --git a/configure.ac b/configure.ac
index e39ce6b..84505ba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3753,6 +3753,11 @@ if test -n $enable_dbgutil -a $enable_dbgutil !=
no; then
else
with_system_libcmis=no
fi
+if test $with_system_libgltf = yes; then
+AC_MSG_ERROR([--with-system-libgltf conflicts with --enable-dbgutil])
+else
+with_system_libgltf=no
+fi
if test $enable_win_mozab_driver = yes; then
AC_MSG_ERROR([--enable-win-mozab-driver conflicts with
--enable-dbgutil])
fi
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
make fails when using '--with-system-libs'
Hi, Im running into the following build failure (it looks like it only occurs when when I run configure with the option '--with-system-libs'). Does anyone have an idea what might be going on here ? Thanks, Maarten Hoes. -- [build CXX] vcl/headless/svpprn.cxx [build CXX] vcl/headless/svptext.cxx [build CXX] vcl/headless/svpvd.cxx [build CXX] extensions/source/plugin/unx/mediator.cxx [build CXX] extensions/source/plugin/unx/plugcon.cxx In file included from /usr/local/src/libreoffice/extensions/source/plugin/inc/plugin/unx/plugcon.hxx:71:0, from /usr/local/src/libreoffice/extensions/source/plugin/unx/plugcon.cxx:36: /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:91:27: error: expected ‘)’ before ‘NPP_InitializeUPP’ typedef void (* NP_LOADDS NPP_InitializeUPP)(void); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:118:27: error: expected ‘)’ before ‘NPP_ShutdownUPP’ typedef void (* NP_LOADDS NPP_ShutdownUPP)(void); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:151:30: error: expected ‘)’ before ‘NPP_NewUPP’ typedef NPError (* NP_LOADDS NPP_NewUPP)(NPMIMEType pluginType, NPP instance, uint16_t mode, int16_t argc, char* argn[], char* argv[], NPSavedData* saved); ^ In file included from /usr/local/src/libreoffice/extensions/source/plugin/inc/plugin/unx/plugcon.hxx:71:0, from /usr/local/src/libreoffice/extensions/source/plugin/unx/plugcon.cxx:36: /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:177:30: error: expected ‘)’ before ‘NPP_DestroyUPP’ typedef NPError (* NP_LOADDS NPP_DestroyUPP)(NPP instance, NPSavedData** save); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:204:30: error: expected ‘)’ before ‘NPP_SetWindowUPP’ typedef NPError (* NP_LOADDS NPP_SetWindowUPP)(NPP instance, NPWindow* window); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:233:30: error: expected ‘)’ before ‘NPP_NewStreamUPP’ typedef NPError (* NP_LOADDS NPP_NewStreamUPP)(NPP instance, NPMIMEType type, NPStream* stream, NPBool seekable, uint16_t* stype); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:260:30: error: expected ‘)’ before ‘NPP_DestroyStreamUPP’ typedef NPError (* NP_LOADDS NPP_DestroyStreamUPP)(NPP instance, NPStream* stream, NPReason reason); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:287:30: error: expected ‘)’ before ‘NPP_WriteReadyUPP’ typedef int32_t (* NP_LOADDS NPP_WriteReadyUPP)(NPP instance, NPStream* stream); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:317:30: error: expected ‘)’ before ‘NPP_WriteUPP’ typedef int32_t (* NP_LOADDS NPP_WriteUPP)(NPP instance, NPStream* stream, int32_t offset, int32_t len, void* buffer); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:345:27: error: expected ‘)’ before ‘NPP_StreamAsFileUPP’ typedef void (* NP_LOADDS NPP_StreamAsFileUPP)(NPP instance, NPStream* stream, const char* fname); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:371:27: error: expected ‘)’ before ‘NPP_PrintUPP’ typedef void (* NP_LOADDS NPP_PrintUPP)(NPP instance, NPPrint* platformPrint); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:398:30: error: expected ‘)’ before ‘NPP_HandleEventUPP’ typedef int16_t (* NP_LOADDS NPP_HandleEventUPP)(NPP instance, void* event); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:427:27: error: expected ‘)’ before ‘NPP_URLNotifyUPP’ typedef void (* NP_LOADDS NPP_URLNotifyUPP)(NPP instance, const char* url, NPReason reason, void* notifyData); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:454:30: error: expected ‘)’ before ‘NPP_GetValueUPP’ typedef NPError (* NP_LOADDS NPP_GetValueUPP)(NPP instance, NPPVariable variable, void *ret_alue); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:480:30: error: expected ‘)’ before ‘NPP_SetValueUPP’ typedef NPError (* NP_LOADDS NPP_SetValueUPP)(NPP instance, NPNVariable variable, void *ret_alue); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:513:30: error: expected ‘)’ before ‘NPN_GetValueUPP’ typedef NPError (* NP_LOADDS NPN_GetValueUPP)(NPP instance, NPNVariable variable, void *ret_alue); ^ /usr/local/src/libreoffice/external/np_sdk/npsdk/npupp.h:539:30: error: expected ‘)’ before ‘NPN_SetValueUPP’ typedef NPError (* NP_LOADDS NPN_SetValueUPP)(NPP instance, NPPVariable variable, void
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - package/source
package/source/zippackage/ZipPackageStream.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 124c81037be1a971232c622614a629ca64478dc1
Author: Matúš Kukan matus.ku...@collabora.com
Date: Sat Nov 1 12:06:41 2014 +0100
Test parallelism again.
Change-Id: I495e147b679b770c479eb0bb2c2714d815e5b9e9
diff --git a/package/source/zippackage/ZipPackageStream.cxx
b/package/source/zippackage/ZipPackageStream.cxx
index 396b052..1efa9ab 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -797,7 +797,7 @@ bool ZipPackageStream::saveChild(
}
else
{
-bParallelDeflate = false;
+bParallelDeflate = true;
if (bParallelDeflate)
{
// Start a new thread deflating this zip entry
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Depends on||77592 --- Comment #230 from Cor Nouws c...@nouenoff.nl --- adding Bug 77592 - FILEOPEN: LibO 4.2.x incorrectly changes row height - various issues related/ look the same, - at least one duplicate, - bibisected, - clear example to reproduce -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 4 commits - oox/source sw/source writerfilter/source
oox/source/drawingml/textbodycontext.cxx| 32 oox/source/drawingml/textcharacterpropertiescontext.cxx | 58 oox/source/drawingml/textparagraphpropertiescontext.cxx | 22 +++--- oox/source/token/namespaces.hxx.tail|1 oox/source/vml/vmltextboxcontext.cxx| 52 +++--- sw/source/core/layout/objectformattertxtfrm.cxx |2 sw/source/core/layout/pagechg.cxx | 18 sw/source/core/layout/paintfrm.cxx |7 - writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |8 +- 9 files changed, 87 insertions(+), 113 deletions(-) New commits: commit 1f4cadcc100d303c5f949774bb6541b8bd26f2e2 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Nov 1 13:39:55 2014 +0100 sw: unused includes in paintfrm Change-Id: Ie8aa47d98849d8a8fc0962f0fdf9758fad59088f diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx index dee2a9b..ec7adfa 100644 --- a/sw/source/core/layout/paintfrm.cxx +++ b/sw/source/core/layout/paintfrm.cxx @@ -18,16 +18,13 @@ */ #include vcl/lazydelete.hxx -#include vcl/gradient.hxx #include sfx2/docfile.hxx #include sfx2/progress.hxx #include editeng/brushitem.hxx -#include editeng/opaqitem.hxx #include editeng/prntitem.hxx #include editeng/boxitem.hxx #include editeng/shaditem.hxx #include svx/framelink.hxx -#include svx/xflgrit.hxx #include drawdoc.hxx #include tgrditem.hxx #include switerator.hxx @@ -42,7 +39,6 @@ #include viewimp.hxx #include dflyobj.hxx #include flyfrm.hxx -#include frmtool.hxx #include viewopt.hxx #include dview.hxx #include dcontact.hxx @@ -71,16 +67,13 @@ #include svx/sdr/contact/viewcontact.hxx #include DocumentSettingManager.hxx #include IDocumentDeviceAccess.hxx -#include IDocumentDrawModelAccess.hxx #include ndole.hxx #include PostItMgr.hxx -#include vcl/svapp.hxx #include vcl/settings.hxx #include svx/sdr/attribute/sdrallfillattributeshelper.hxx #include drawinglayer/processor2d/processor2dtools.hxx -#include ndtxt.hxx #include svtools/borderhelper.hxx commit e0c38189d4505a669d89b22a0a6e6b78c6016eb6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Nov 1 13:39:31 2014 +0100 sw: unused includes in pagechg Change-Id: I0c50675ba5fe7ff3763c4e598cccaea823a324f9 diff --git a/sw/source/core/layout/pagechg.cxx b/sw/source/core/layout/pagechg.cxx index 45a3252..2ebfe73 100644 --- a/sw/source/core/layout/pagechg.cxx +++ b/sw/source/core/layout/pagechg.cxx @@ -17,17 +17,12 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include com/sun/star/embed/EmbedStates.hpp #include ndole.hxx -#include docary.hxx #include svl/itemiter.hxx #include fmtfsize.hxx #include fmthdft.hxx #include fmtclds.hxx -#include fmtanchr.hxx #include fmtpdsc.hxx -#include fmtfordr.hxx -#include fmtfld.hxx #include fmtornt.hxx #include fmtsrnd.hxx #include ftninfo.hxx @@ -41,20 +36,10 @@ #include viewimp.hxx #include pagefrm.hxx #include rootfrm.hxx -#include cntfrm.hxx -#include flyfrm.hxx -#include doc.hxx #include IDocumentSettingAccess.hxx -#include IDocumentDrawModelAccess.hxx #include IDocumentFieldsAccess.hxx -#include fesh.hxx -#include dview.hxx -#include dflyobj.hxx #include dcontact.hxx -#include frmtool.hxx -#include fldbas.hxx #include hints.hxx -#include swtable.hxx #include ftnidx.hxx #include bodyfrm.hxx @@ -65,12 +50,9 @@ #include flyfrms.hxx #include htmltbl.hxx #include pagedesc.hxx -#include poolfmt.hxx #include editeng/frmdiritem.hxx -#include swfntcch.hxx #include sortedobjs.hxx #include switerator.hxx -#include vcl/svapp.hxx #include txtfly.hxx using namespace ::com::sun::star; commit b16a3b86103a631be0943ad1654c99e764597452 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Nov 1 13:39:18 2014 +0100 sw: unused includes in objectformattertxtfrm Change-Id: Ib564b09ddf68d045dcb89f1127c65aa95b3c1f68 diff --git a/sw/source/core/layout/objectformattertxtfrm.cxx b/sw/source/core/layout/objectformattertxtfrm.cxx index dba8f41..4b4a994 100644 --- a/sw/source/core/layout/objectformattertxtfrm.cxx +++ b/sw/source/core/layout/objectformattertxtfrm.cxx @@ -18,14 +18,12 @@ */ #include objectformattertxtfrm.hxx -#include anchoredobject.hxx #include sortedobjs.hxx #include flyfrms.hxx #include txtfrm.hxx #include pagefrm.hxx #include rowfrm.hxx #include layouter.hxx -#include frmfmt.hxx #include fmtanchr.hxx #include fmtwrapinfluenceonobjpos.hxx #include fmtfollowtextflow.hxx commit c88c53c4b17a67fe700874a87c87d7f69603e156 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Nov 1 13:38:47 2014 +0100 oox: introduce W_TOKEN() macro It was inconsistent that when parsing a:foo elements, A_TOKEN(foo) was available, but for w:foo elements there was no W_TOKEN() macro. Also, there were two manual variants
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 2 commits - chart2/qa oox/source svx/source
chart2/qa/extras/chart2import.cxx |2 +-
oox/source/drawingml/chart/axismodel.cxx |2 +-
svx/source/sdr/contact/objectcontactofpageview.cxx | 11 +--
3 files changed, 11 insertions(+), 4 deletions(-)
New commits:
commit 5a6379ab11d9daf8e516c34daea738b5cb96fcd1
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Fri Oct 31 23:59:27 2014 -0400
Actually we shouldn't always set Overlap flag on for all xlsx charts...
The correct fix unfortunately would require making the axis label layout
smarter, to avoid overlapping of angled text label objects.
Change-Id: I92198dbb90fd4a206ee226307992343d064f733a
diff --git a/chart2/qa/extras/chart2import.cxx
b/chart2/qa/extras/chart2import.cxx
index 3b1f1e7..b28559b 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -91,7 +91,7 @@ public:
CPPUNIT_TEST(testFdo78080);
CPPUNIT_TEST(testFdo54361);
CPPUNIT_TEST(testAutoBackgroundXLSX);
-CPPUNIT_TEST(testTextCanOverlapXLSX);
+// CPPUNIT_TEST(testTextCanOverlapXLSX); // TODO : temporarily disabled.
CPPUNIT_TEST(testNumberFormatsXLSX);
CPPUNIT_TEST_SUITE_END();
diff --git a/oox/source/drawingml/chart/axismodel.cxx
b/oox/source/drawingml/chart/axismodel.cxx
index cbd66b7..d4163bc 100644
--- a/oox/source/drawingml/chart/axismodel.cxx
+++ b/oox/source/drawingml/chart/axismodel.cxx
@@ -46,7 +46,7 @@ AxisModel::AxisModel( sal_Int32 nTypeId ) :
mnMinorTimeUnit( XML_days ),
mnOrientation( XML_minMax ),
mnTickLabelPos( XML_nextTo ),
-mnTickLabelSkip( 1 ),
+mnTickLabelSkip( 0 ),
mnTickMarkSkip( 0 ),
mnTypeId( nTypeId ),
mbAuto( false ),
commit d7f2cc4d9e4b81a788f178a180e026de365cb43c
Author: Michael Stahl mst...@redhat.com
Date: Fri Oct 24 17:58:27 2014 +0200
fdo#83664: svx: don't try to paint on empty OutputDevice
ObjectContactOfPageView::DoProcessDisplay() initalizes an empty
aViewRange, which later code assumes to mean paint everything, but
actually the OutputDevice has 0 size so nothing can be painted.
Change-Id: I1e47e8d38c1fad5e08027bb76fce4b54c5b3358b
diff --git a/svx/source/sdr/contact/objectcontactofpageview.cxx
b/svx/source/sdr/contact/objectcontactofpageview.cxx
index f778df1..27ae1bb 100644
--- a/svx/source/sdr/contact/objectcontactofpageview.cxx
+++ b/svx/source/sdr/contact/objectcontactofpageview.cxx
@@ -141,6 +141,15 @@ namespace sdr
// OutputDevices then the given ones.
void ObjectContactOfPageView::DoProcessDisplay(DisplayInfo
rDisplayInfo)
{
+OutputDevice rTargetOutDev =
GetPageWindow().GetPaintWindow().GetTargetOutputDevice();
+const Size aOutputSizePixel(rTargetOutDev.GetOutputSizePixel());
+if (!isOutputToRecordingMetaFile() // do those have outdev too?
+ (0 == aOutputSizePixel.getWidth() ||
+0 == aOutputSizePixel.getHeight()))
+{
+return;
+}
+
// visualize entered group when that feature is switched on and
it's not
// a print output. #i29129# No ghosted display for printing.
bool bVisualizeEnteredGroup(DoVisualizeEnteredGroup()
!isOutputToPrinter());
@@ -170,7 +179,6 @@ namespace sdr
// update current ViewInformation2D at the ObjectContact
const double fCurrentTime(getPrimitiveAnimator().GetTime());
-OutputDevice rTargetOutDev =
GetPageWindow().GetPaintWindow().GetTargetOutputDevice();
basegfx::B2DRange aViewRange;
// create ViewRange
@@ -194,7 +202,6 @@ namespace sdr
else
{
// use visible pixels, but transform to world coordinates
-const Size
aOutputSizePixel(rTargetOutDev.GetOutputSizePixel());
aViewRange = basegfx::B2DRange(0.0, 0.0,
aOutputSizePixel.getWidth(), aOutputSizePixel.getHeight());
// if a clip region is set, use it
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/settings.cxx |5 - vcl/source/window/accessibility.cxx |1 - vcl/source/window/syschild.cxx |3 --- 3 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 8d48f6329518c6dfd25348aadc5d05e807d57d49 Author: Douglas Mencken dougmenc...@gmail.com Date: Mon Oct 6 08:18:55 2014 -0400 vcl/source: get rid of redundant svsys.h includes + adapted for WNT (it does really need it for app/settings.cxx) Change-Id: I33a65d24f7c6c46a36718e4421ae88de180a9739 Reviewed-on: https://gerrit.libreoffice.org/11814 Reviewed-by: Douglas Mencken dougmenc...@gmail.com Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx index a30fd34..8048875 100644 --- a/vcl/source/app/settings.cxx +++ b/vcl/source/app/settings.cxx @@ -21,7 +21,10 @@ #include officecfg/Office/Common.hxx -#include svsys.h +#ifdef WNT +#include win/svsys.h +#endif + #include comphelper/processfactory.hxx #include rtl/bootstrap.hxx #include tools/debug.hxx diff --git a/vcl/source/window/accessibility.cxx b/vcl/source/window/accessibility.cxx index 0f3b416..49c95ac 100644 --- a/vcl/source/window/accessibility.cxx +++ b/vcl/source/window/accessibility.cxx @@ -55,7 +55,6 @@ #include vcl/settings.hxx // declare system types in sysdata.hxx -#include svsys.h #include vcl/sysdata.hxx #include salframe.hxx diff --git a/vcl/source/window/syschild.cxx b/vcl/source/window/syschild.cxx index 78c31f1..d930c3d 100644 --- a/vcl/source/window/syschild.cxx +++ b/vcl/source/window/syschild.cxx @@ -24,9 +24,6 @@ #include tools/rc.h -// declare system types in sysdata.hxx -#include svsys.h - #include vcl/window.hxx #include vcl/sysdata.hxx #include vcl/svapp.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/sifr
icon-themes/sifr/cmd/lc_insertfieldctrl.png |binary icon-themes/sifr/cmd/lc_insertfootnote.png|binary icon-themes/sifr/cmd/lc_insertgraphic.png |binary icon-themes/sifr/cmd/lc_insertpagebreak.png |binary icon-themes/sifr/cmd/lc_insertpagenumberfield.png |binary icon-themes/sifr/cmd/sc_insertfieldctrl.png |binary icon-themes/sifr/cmd/sc_insertfootnote.png|binary icon-themes/sifr/cmd/sc_insertgraphic.png |binary icon-themes/sifr/cmd/sc_insertpagebreak.png |binary icon-themes/sifr/cmd/sc_insertpagenumberfield.png |binary icon-themes/sifr/sfx2/res/symphony/sidebar-property-large.png |binary icon-themes/sifr/sfx2/res/symphony/sidebar-property-small.png |binary 12 files changed New commits: commit 7d9e3674a486f1fc251c8f159e093cf1c09daa45 Author: Yousuf Philips philip...@hotmail.com Date: Sat Nov 1 01:44:39 2014 +0400 SIFR: Adding new icons for page break number and footnote and fixing others Change-Id: Ib1ff131dc54fb15fdd72fc17db239b2e5c9c7ee6 Reviewed-on: https://gerrit.libreoffice.org/12169 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/icon-themes/sifr/cmd/lc_insertfieldctrl.png b/icon-themes/sifr/cmd/lc_insertfieldctrl.png index f099a37..f0c033e 100644 Binary files a/icon-themes/sifr/cmd/lc_insertfieldctrl.png and b/icon-themes/sifr/cmd/lc_insertfieldctrl.png differ diff --git a/icon-themes/sifr/cmd/lc_insertfootnote.png b/icon-themes/sifr/cmd/lc_insertfootnote.png new file mode 100644 index 000..4da5910 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertfootnote.png differ diff --git a/icon-themes/sifr/cmd/lc_insertgraphic.png b/icon-themes/sifr/cmd/lc_insertgraphic.png index 1a9cc07..f1942ee 100644 Binary files a/icon-themes/sifr/cmd/lc_insertgraphic.png and b/icon-themes/sifr/cmd/lc_insertgraphic.png differ diff --git a/icon-themes/sifr/cmd/lc_insertpagebreak.png b/icon-themes/sifr/cmd/lc_insertpagebreak.png new file mode 100644 index 000..1a5246f Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertpagebreak.png differ diff --git a/icon-themes/sifr/cmd/lc_insertpagenumberfield.png b/icon-themes/sifr/cmd/lc_insertpagenumberfield.png new file mode 100644 index 000..f0c033e Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertpagenumberfield.png differ diff --git a/icon-themes/sifr/cmd/sc_insertfieldctrl.png b/icon-themes/sifr/cmd/sc_insertfieldctrl.png index c67104a..eaf1dff 100644 Binary files a/icon-themes/sifr/cmd/sc_insertfieldctrl.png and b/icon-themes/sifr/cmd/sc_insertfieldctrl.png differ diff --git a/icon-themes/sifr/cmd/sc_insertfootnote.png b/icon-themes/sifr/cmd/sc_insertfootnote.png new file mode 100644 index 000..d8672a6 Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertfootnote.png differ diff --git a/icon-themes/sifr/cmd/sc_insertgraphic.png b/icon-themes/sifr/cmd/sc_insertgraphic.png index 124208c..9f92fd7 100644 Binary files a/icon-themes/sifr/cmd/sc_insertgraphic.png and b/icon-themes/sifr/cmd/sc_insertgraphic.png differ diff --git a/icon-themes/sifr/cmd/sc_insertpagebreak.png b/icon-themes/sifr/cmd/sc_insertpagebreak.png new file mode 100644 index 000..d9f2b5f Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertpagebreak.png differ diff --git a/icon-themes/sifr/cmd/sc_insertpagenumberfield.png b/icon-themes/sifr/cmd/sc_insertpagenumberfield.png new file mode 100644 index 000..eaf1dff Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertpagenumberfield.png differ diff --git a/icon-themes/sifr/sfx2/res/symphony/sidebar-property-large.png b/icon-themes/sifr/sfx2/res/symphony/sidebar-property-large.png index 2d139a4d..1a3b10b 100644 Binary files a/icon-themes/sifr/sfx2/res/symphony/sidebar-property-large.png and b/icon-themes/sifr/sfx2/res/symphony/sidebar-property-large.png differ diff --git a/icon-themes/sifr/sfx2/res/symphony/sidebar-property-small.png b/icon-themes/sifr/sfx2/res/symphony/sidebar-property-small.png index afc7b4f..bb9fa4b 100644 Binary files a/icon-themes/sifr/sfx2/res/symphony/sidebar-property-small.png and b/icon-themes/sifr/sfx2/res/symphony/sidebar-property-small.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/galaxy icon-themes/tango officecfg/registry sc/uiconfig
icon-themes/galaxy/cmd/lc_wraptext.png|binary icon-themes/galaxy/cmd/sc_wraptext.png|binary icon-themes/tango/cmd/lc_wraptext.png |binary icon-themes/tango/cmd/sc_wraptext.png |binary officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |5 - sc/uiconfig/scalc/toolbar/formatobjectbar.xml |2 ++ 6 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 80f49553518e6d344dae81358b8d7fb5f24c3cf1 Author: Yousuf Philips philip...@hotmail.com Date: Fri Oct 31 16:08:15 2014 +0400 fdo#60349 - FORMATTING: Icon in Calc toolbar for wrap text Change-Id: I04390075006bd0492e0c39c5e1bf4a4eb107ed2c Reviewed-on: https://gerrit.libreoffice.org/12163 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/icon-themes/galaxy/cmd/lc_wraptext.png b/icon-themes/galaxy/cmd/lc_wraptext.png new file mode 100644 index 000..9df8481 Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_wraptext.png differ diff --git a/icon-themes/galaxy/cmd/sc_wraptext.png b/icon-themes/galaxy/cmd/sc_wraptext.png new file mode 100644 index 000..555db61 Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_wraptext.png differ diff --git a/icon-themes/tango/cmd/lc_wraptext.png b/icon-themes/tango/cmd/lc_wraptext.png new file mode 100644 index 000..9df8481 Binary files /dev/null and b/icon-themes/tango/cmd/lc_wraptext.png differ diff --git a/icon-themes/tango/cmd/sc_wraptext.png b/icon-themes/tango/cmd/sc_wraptext.png new file mode 100644 index 000..555db61 Binary files /dev/null and b/icon-themes/tango/cmd/sc_wraptext.png differ diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index 64eb9ad..9c5e84f 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -537,7 +537,10 @@ /node node oor:name=.uno:WrapText oor:op=replace prop oor:name=Label oor:type=xs:string - value xml:lang=en-USAutomatic Row Break/value + value xml:lang=en-USWrap Text/value +/prop +prop oor:name=Properties oor:type=xs:int + value1/value /prop /node node oor:name=.uno:DefinePrintArea oor:op=replace diff --git a/sc/uiconfig/scalc/toolbar/formatobjectbar.xml b/sc/uiconfig/scalc/toolbar/formatobjectbar.xml index 4386660..4fcc8c1 100644 --- a/sc/uiconfig/scalc/toolbar/formatobjectbar.xml +++ b/sc/uiconfig/scalc/toolbar/formatobjectbar.xml @@ -34,7 +34,9 @@ toolbar:toolbaritem xlink:href=.uno:AlignHorizontalCenter toolbar:style=radio auto/ toolbar:toolbaritem xlink:href=.uno:AlignRight toolbar:style=radio auto/ toolbar:toolbaritem xlink:href=.uno:AlignBlock toolbar:style=radio auto/ + toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:ToggleMergeCells/ + toolbar:toolbaritem xlink:href=.uno:WrapText/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:ParaLeftToRight toolbar:style=radio/ toolbar:toolbaritem xlink:href=.uno:ParaRightToLeft toolbar:style=radio/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/human icon-themes/tango
dev/null |binary icon-themes/human/cmd/lc_alignblock.xcf.bz2|binary icon-themes/human/cmd/lc_alignhorizontalcenter.xcf.bz2 |binary icon-themes/human/cmd/lc_alignleft.xcf.bz2 |binary icon-themes/human/cmd/lc_alignright.xcf.bz2|binary icon-themes/human/cmd/lc_bold.xcf.bz2 |binary icon-themes/human/cmd/lc_decrementindent.xcf.bz2 |binary icon-themes/human/cmd/lc_defaultbullet.xcf.bz2 |binary icon-themes/human/cmd/lc_defaultnumbering.xcf.bz2 |binary icon-themes/human/cmd/lc_incrementindent.xcf.bz2 |binary icon-themes/human/cmd/lc_italic.xcf.bz2|binary icon-themes/human/cmd/lc_underline.xcf.bz2 |binary icon-themes/human/cmd/lc_underlinedouble.xcf.bz2 |binary icon-themes/human/cmd/sc_decrementindent.xcf.bz2 |binary icon-themes/human/cmd/sc_defaultbullet.xcf.bz2 |binary icon-themes/human/cmd/sc_defaultnumbering.xcf.bz2 |binary icon-themes/human/cmd/sc_incrementindent.xcf.bz2 |binary icon-themes/tango/cmd/lc_alignblock.png|binary icon-themes/tango/cmd/lc_alignhorizontalcenter.png |binary icon-themes/tango/cmd/lc_alignleft.png |binary icon-themes/tango/cmd/lc_alignright.png|binary icon-themes/tango/cmd/lc_backcolor.png |binary icon-themes/tango/cmd/lc_bold.png |binary icon-themes/tango/cmd/lc_color.png |binary icon-themes/tango/cmd/lc_controlcodes.png |binary icon-themes/tango/cmd/lc_decrementindent.png |binary icon-themes/tango/cmd/lc_defaultbullet.png |binary icon-themes/tango/cmd/lc_defaultnumbering.png |binary icon-themes/tango/cmd/lc_incrementindent.png |binary icon-themes/tango/cmd/lc_italic.png|binary icon-themes/tango/cmd/lc_spacepara1.png|binary icon-themes/tango/cmd/lc_spacepara15.png |binary icon-themes/tango/cmd/lc_spacepara2.png|binary icon-themes/tango/cmd/lc_text.png |binary icon-themes/tango/cmd/lc_underline.png |binary 35 files changed New commits: commit 2f97d5b897f6c770d8ceffefc9df6df8c93f3066 Author: Yousuf Philips philip...@hotmail.com Date: Fri Oct 31 14:43:46 2014 +0400 TANGO: Updated formatting icons and moved old tango sources to human Change-Id: If4c730e77ae06af4239934ac05498c21c5c08602 Reviewed-on: https://gerrit.libreoffice.org/12147 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/icon-themes/tango/cmd/lc_alignblock.xcf.bz2 b/icon-themes/human/cmd/lc_alignblock.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_alignblock.xcf.bz2 rename to icon-themes/human/cmd/lc_alignblock.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_alignhorizontalcenter.xcf.bz2 b/icon-themes/human/cmd/lc_alignhorizontalcenter.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_alignhorizontalcenter.xcf.bz2 rename to icon-themes/human/cmd/lc_alignhorizontalcenter.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_alignleft.xcf.bz2 b/icon-themes/human/cmd/lc_alignleft.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_alignleft.xcf.bz2 rename to icon-themes/human/cmd/lc_alignleft.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_alignright.xcf.bz2 b/icon-themes/human/cmd/lc_alignright.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_alignright.xcf.bz2 rename to icon-themes/human/cmd/lc_alignright.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_bold.xcf.bz2 b/icon-themes/human/cmd/lc_bold.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_bold.xcf.bz2 rename to icon-themes/human/cmd/lc_bold.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_decrementindent.xcf.bz2 b/icon-themes/human/cmd/lc_decrementindent.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_decrementindent.xcf.bz2 rename to icon-themes/human/cmd/lc_decrementindent.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_defaultbullet.xcf.bz2 b/icon-themes/human/cmd/lc_defaultbullet.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_defaultbullet.xcf.bz2 rename to icon-themes/human/cmd/lc_defaultbullet.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_defaultnumbering.xcf.bz2 b/icon-themes/human/cmd/lc_defaultnumbering.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_defaultnumbering.xcf.bz2 rename to icon-themes/human/cmd/lc_defaultnumbering.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_incrementindent.xcf.bz2 b/icon-themes/human/cmd/lc_incrementindent.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/lc_incrementindent.xcf.bz2 rename to icon-themes/human/cmd/lc_incrementindent.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_italic.xcf.bz2
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - ac/91424975502e1a67434dcaa649e26a2bcf8be4
ac/91424975502e1a67434dcaa649e26a2bcf8be4 |1 + 1 file changed, 1 insertion(+) New commits: commit ecc92876cf68a0c98d7c3b69df4c16a801dbc899 Author: Caolán McNamara caol...@redhat.com Date: Sat Nov 1 14:27:09 2014 + Notes added by 'git notes add' diff --git a/ac/91424975502e1a67434dcaa649e26a2bcf8be4 b/ac/91424975502e1a67434dcaa649e26a2bcf8be4 new file mode 100644 index 000..8ebbe55 --- /dev/null +++ b/ac/91424975502e1a67434dcaa649e26a2bcf8be4 @@ -0,0 +1 @@ +ignore: obsolete ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/shared/guide/startcenter.xhp | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) New commits: commit 677001e7747ae7b61ed93028024e71fb14beb728 Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Thu Oct 30 21:45:48 2014 -0200 fdo#80481: Update Start Center help page. Update Start Center help page with new features. Change-Id: I052e0245a6e3598b561b6aaf43913be2a6387fca Reviewed-on: https://gerrit.libreoffice.org/12159 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/source/text/shared/guide/startcenter.xhp b/source/text/shared/guide/startcenter.xhp index 49d1d11..2544df5 100644 --- a/source/text/shared/guide/startcenter.xhp +++ b/source/text/shared/guide/startcenter.xhp @@ -37,15 +37,20 @@ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/all_recent id=bm_id0820200802550238 localize=false/ paragraph xml-lang=en-US id=hd_id0820200802524447 role=heading level=1 l10n=NEWvariable id=startcenterlink href=text/shared/guide/startcenter.xhpStart Center/link /variable/paragraph - paragraph xml-lang=en-US id=par_id0820200803204063 role=paragraph l10n=NEWWelcome to %PRODUCTNAME. Thank you for using the %PRODUCTNAME link href=text/shared/05/0110.xhpapplication help/link. Press F1 whenever you need help using the %PRODUCTNAME software./paragraph - paragraph xml-lang=en-US id=par_id0820200802524413 role=paragraph l10n=NEWYou see the Start Center when no document is open in %PRODUCTNAME. ahelp hid=.Click an icon to open a new document or a file dialog./ahelp/paragraph +paragraph xml-lang=en-US id=par_id0820200803204063 role=paragraph l10n=NEWWelcome to %PRODUCTNAME. + Thank you for using the %PRODUCTNAME link href=text/shared/05/0110.xhpapplication help/link. + Press F1 whenever you need help using the %PRODUCTNAME software./paragraph +paragraph xml-lang=en-US id=par_id0820200802524413 role=paragraph l10n=NEWYou see the Start Center when no document is open in %PRODUCTNAME. + It is divided into two panes. ahelp hid=.Click an icon on the left pane to open a new document or a file dialog./ahelp +/paragraph bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/writer_all id=bm_id1022200910564632 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/calc_all id=bm_id1022200910570124 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/draw_all id=bm_id1022200910571273 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/impress_all id=bm_id102220091057270 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/database_all id=bm_id102220091057437 localize=false/ bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/math_all id=bm_id1022200910575575 localize=false/ -paragraph xml-lang=en-US id=par_id0820200803104810 role=paragraph l10n=NEWahelp hid=.The document icons each open a new document of the specified type./ahelp/paragraph +paragraph xml-lang=en-US id=par_id0820200803104810 role=paragraph l10n=NEWahelp hid=.The document icons each open a new document +of the specified type./ahelp/paragraph list type=ordered listitem paragraph xml-lang=en-US id=par_id0820200803104978 role=paragraph l10n=NEW @@ -74,10 +79,17 @@ /list bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/templates_all id=bm_id1022200910584084 localize=false/ paragraph xml-lang=en-US id=par_id1022200911011855 role=paragraph l10n=NEWahelp hid=. visibility=hiddenThe Templates icon opens the Templates and Documents dialog./ahelp/paragraph - paragraph xml-lang=en-US id=par_id0820200803105045 role=paragraph l10n=NEWThe emphTemplates/emph icon opens the link href=text/shared/guide/aaa_start.xhpTemplates and Documents/link dialog./paragraph +paragraph xml-lang=en-US id=par_id0820200803105045 role=paragraph l10n=NEWThe emphTemplates/emph icon opens the link href=text/shared/guide/aaa_start.xhpTemplates and Documents/link dialog./paragraph bookmark xml-lang=en-US branch=hid/sfx2/ui/startcenter/open_all id=bm_id1022200910595546 localize=false/ paragraph xml-lang=en-US id=par_id1022200911011975 role=paragraph l10n=NEWahelp hid=. visibility=hiddenThe Open a Document icon presents a file open dialog./ahelp/paragraph - paragraph xml-lang=en-US id=par_id082020080310500 role=paragraph l10n=NEWThe emphOpen a document/emph icon presents a link href=text/shared/guide/doc_open.xhpfile open/link dialog./paragraphcommentthe four icons show a short explanation already/comment - +paragraph xml-lang=en-US id=par_id082020080310500 role=paragraph l10n=NEWThe emphOpen a document/emph icon presents a link href=text/shared/guide/doc_open.xhpfile open/link dialog./paragraphcommentthe four icons show a short explanation already/comment +paragraph xml-lang=en-US id=par_id0820200802525413 role=paragraph l10n=NEW + The right pane
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 653a8d8c1e3348d1e8c094b98b8a53a12ea4f353 Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Thu Oct 30 21:45:48 2014 -0200 Updated core Project: help 677001e7747ae7b61ed93028024e71fb14beb728 fdo#80481: Update Start Center help page. Update Start Center help page with new features. Change-Id: I052e0245a6e3598b561b6aaf43913be2a6387fca Reviewed-on: https://gerrit.libreoffice.org/12159 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/helpcontent2 b/helpcontent2 index 42c2490..677001e 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 42c2490f90d1a0dbc2b00bfc446caded8ca682b1 +Subproject commit 677001e7747ae7b61ed93028024e71fb14beb728 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: apple_remote/source
apple_remote/source/AppleRemote.h|2 +- apple_remote/source/HIDRemoteControlDevice.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 87578eb519c6280c1d67083d4028f5cee5371113 Author: Andrea Gelmini andrea.gelm...@gelma.net Date: Thu Oct 30 10:23:54 2014 +0100 Fixed license encoding to have all the same apple_remote/source/* Change-Id: Ibeee5a8c49f2d4710de6a1e0ee2013f3755a177b Reviewed-on: https://gerrit.libreoffice.org/12149 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/apple_remote/source/AppleRemote.h b/apple_remote/source/AppleRemote.h index 0e4187f..f80431b 100644 --- a/apple_remote/source/AppleRemote.h +++ b/apple_remote/source/AppleRemote.h @@ -19,7 +19,7 @@ * The above copyright notice and this permission notice shall be included * in all copies or substantial portions of the Software. * - * THE SOFTWARE IS PROVIDED âÃúAS ISâÃù, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * THE SOFTWARE IS PROVIDED âAS ISâ, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER diff --git a/apple_remote/source/HIDRemoteControlDevice.h b/apple_remote/source/HIDRemoteControlDevice.h index be975fb..f4bc068 100644 --- a/apple_remote/source/HIDRemoteControlDevice.h +++ b/apple_remote/source/HIDRemoteControlDevice.h @@ -19,7 +19,7 @@ * The above copyright notice and this permission notice shall be included * in all copies or substantial portions of the Software. * - * THE SOFTWARE IS PROVIDED âÃúAS ISâÃù, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * THE SOFTWARE IS PROVIDED âAS ISâ, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: wizards/source
wizards/source/access2base/Application.xba |7 - wizards/source/access2base/Database.xba|2 wizards/source/access2base/DoCmd.xba | 157 + wizards/source/access2base/L10N.xba|4 wizards/source/access2base/Root_.xba |8 - wizards/source/access2base/acConstants.xba |2 6 files changed, 167 insertions(+), 13 deletions(-) New commits: commit a65308f307554cfd277f24af66df246814ad1b8b Author: Jean-Pierre Ledure j...@ledure.be Date: Sat Nov 1 15:33:30 2014 +0100 Access2Base - new ApplyFilter and SetOrderBy actions Those actions are meaningful when applied on Table and Query datasheets. Forms and subforms (1 level) supported as well. Change-Id: Ic104559d84ff94f1e7e9bed3db1a13a286953314 diff --git a/wizards/source/access2base/Application.xba b/wizards/source/access2base/Application.xba index 441e2ee..162575c 100644 --- a/wizards/source/access2base/Application.xba +++ b/wizards/source/access2base/Application.xba @@ -70,6 +70,7 @@ Global Const ERRQUERYDEFDELETED = 1549 Global Const ERRTABLEDEFDELETED= 1550 Global Const ERRTABLECREATION = 1551 Global Const ERRFIELDCREATION = 1552 +Global Const ERRSUBFORMNOTFOUND= 1553 REM --- Global Const DBCONNECTBASE = 1 apos; Connection from Base document (OpenConnection) @@ -1185,9 +1186,11 @@ Public Function _CurrentDb(ByVal Optional piDocEntry As Integer, ByVal Optional REM Without arguments same as CurrentDb() except that it generates an error if database not connected (internal use) REM With 2 arguments return the corresponding entry in Root +Dim oCurrentDb As Object If IsEmpty(_A2B_) Then GoTo Trace_Error - If IsMissing(piDocEntry)Then Set _CurrentDb = Application.CurrentDb() _ - Else Set _CurrentDb = _A2B_._CurrentDb(piDocEntry, piDbEntry) + If IsMissing(piDocEntry)Then Set oCurrentDb = Application.CurrentDb() _ + Else Set oCurrentDb = _A2B_._CurrentDb(piDocEntry, piDbEntry) + If IsNull(oCurrentDb) Then Goto Trace_Error Else Set _CurrentDb = oCurrentDb Exit_Function: Exit Function diff --git a/wizards/source/access2base/Database.xba b/wizards/source/access2base/Database.xba index d6b84c1..a8fd3e2 100644 --- a/wizards/source/access2base/Database.xba +++ b/wizards/source/access2base/Database.xba @@ -545,7 +545,7 @@ Const cstNull = -1 If IsMissing(pvOption) Then pvOption = cstNull Else - If Not Utils._CheckArgument(pvOption, 2, Utils._AddNumeric(), dbSQLPassThrough) Then Goto Exit_Function + If Not Utils._CheckArgument(pvOption, 2, Utils._AddNumeric(), Array(dbSQLPassThrough, cstNull)) Then Goto Exit_Function End If If _DbConnect lt;gt; DBCONNECTBASE And _DbConnect lt;gt; DBCONNECTFORM Then Goto Error_NotApplicable diff --git a/wizards/source/access2base/DoCmd.xba b/wizards/source/access2base/DoCmd.xba index b88dcef..b1c06e1 100644 --- a/wizards/source/access2base/DoCmd.xba +++ b/wizards/source/access2base/DoCmd.xba @@ -37,6 +37,66 @@ REM VBA allows call to actions with missing arguments e.g. OpenForm(quot;aaaqu REM in StarBasic IsMissing requires Variant parameters REM --- +Public Function ApplyFilter( _ + ByVal Optional pvFilter As Variant _ + , ByVal Optional pvSQL As Variant _ + , ByVal Optional pvControlName As Variant _ + ) As Boolean +apos; Set filter on open table, query, form or subform (if pvControlName present) + + If _ErrorHandler() Then On Local Error Goto Error_Function +Const cstThisSub = quot;ApplyFilterquot; + Utils._SetCalledSub(cstThisSub) + ApplyFilter = False + + If IsMissing(pvFilter) And IsMissing(pvSQL) Then Call _TraceArguments() + If IsMissing(pvFilter) Then pvFilter = quot;quot; + If Not Utils._CheckArgument(pvFilter, 1, vbString) Then Goto Exit_Function + If IsMissing(pvSQL) Then pvSQL = quot;quot; + If Not Utils._CheckArgument(pvSQL, 1, vbString) Then Goto Exit_Function + If IsMissing(pvControlName) Then pvControlName = quot;quot; + If Not Utils._CheckArgument(pvControlName, 1, vbString) Then Goto Exit_Function + +Dim sFilter As String, oWindow As Object, oDatabase As Object, oTarget As Object + Set oDatabase = Application._CurrentDb() + If oDatabase._DbConnect
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unomap.cxx |2 +-
sw/source/uibase/uno/unotxdoc.cxx | 10 ++
2 files changed, 7 insertions(+), 5 deletions(-)
New commits:
commit b812374174144e077bc3b08fe347626cb1a33eee
Author: Justin Luth justin_l...@sil.org
Date: Tue Oct 7 09:52:28 2014 -0400
related to #fdo71248 - ActiveDocument not tracking ThisWordDoc
Making the same change that fixed ThisExcelDoc in 2012
(commit cea414bfe8fe356793778bdf09f5ca3b3a42daa0),
but matching the current code structure
(commit 191bf98991e1934bfef115a1cec463ac250b0191)
Change-Id: I0a5c1a006d5a73b8e3be1b6b407e62927d49c36a
Reviewed-on: https://gerrit.libreoffice.org/11842
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
diff --git a/sw/source/core/unocore/unomap.cxx
b/sw/source/core/unocore/unomap.cxx
index f17f5b1..96e039b 100644
--- a/sw/source/core/unocore/unomap.cxx
+++ b/sw/source/core/unocore/unomap.cxx
@@ -1795,7 +1795,7 @@ const SfxItemPropertyMapEntry*
SwUnoPropertyMapProvider::GetPropertyMapEntries(s
{ OUString(UNO_NAME_CHAR_LOCALE), RES_CHRATR_LANGUAGE ,
cppu::UnoTypecss::lang::Locale::get(), PropertyAttribute::MAYBEVOID,
MID_LANG_LOCALE },
{ OUString(UNO_NAME_CHARACTER_COUNT), WID_DOC_CHAR_COUNT,
cppu::UnoTypesal_Int32::get(), PropertyAttribute::READONLY, 0},
{ OUString(UNO_NAME_DIALOG_LIBRARIES),
WID_DOC_DIALOG_LIBRARIES,
cppu::UnoTypecss::script::XLibraryContainer::get(),
PropertyAttribute::READONLY, 0},
-{ OUString(UNO_NAME_VBA_DOCOBJ), WID_DOC_VBA_DOCOBJ,
cppu::UnoType cppu::UnoSequenceTypecss::beans::PropertyValue ::get(),
PropertyAttribute::READONLY, 0},
+{ OUString(UNO_NAME_VBA_DOCOBJ), WID_DOC_VBA_DOCOBJ,
cppu::UnoTypeOUString::get(), PropertyAttribute::READONLY, 0},
{ OUString(UNO_NAME_INDEX_AUTO_MARK_FILE_U_R_L),
WID_DOC_AUTO_MARK_URL, cppu::UnoTypeOUString::get(),PROPERTY_NONE, 0},
{ OUString(UNO_NAME_PARAGRAPH_COUNT), WID_DOC_PARA_COUNT,
cppu::UnoTypesal_Int32::get(), PropertyAttribute::READONLY, 0},
{ OUString(UNO_NAME_RECORD_CHANGES),
WID_DOC_CHANGES_RECORD,cppu::UnoTypebool::get(), PROPERTY_NONE, 0},
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index bf543d1..d48ab72 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -2124,10 +2124,12 @@ Any SwXTextDocument::getPropertyValue(const OUString
rPropertyName)
break;
case WID_DOC_VBA_DOCOBJ:
{
-beans::PropertyValue aProp;
-aProp.Name = ThisWordDoc;
-aProp.Value = pDocShell-GetModel();
-aAny = aProp;
+/* #i111553# This property provides the name of the constant that
+ will be used to store this model in the global Basic manager.
+ That constant will be equivalent to 'ThisComponent' but for
+ each application, so e.g. a 'ThisExcelDoc' and a 'ThisWordDoc'
+ constant can co-exist, as required by VBA. */
+aAny = OUString( ThisWordDoc );
}
break;
case WID_DOC_RUNTIME_UID:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sfx2/source sw/inc
sfx2/source/doc/objxtor.cxx |2 +-
sw/inc/unoprnms.hxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 33c132baca3a2089551226167d27bdc3f9a67907
Author: Justin Luth justin_l...@sil.org
Date: Tue Sep 30 14:37:59 2014 -0400
fdo#71248 Excel VBA: ActiveDocument is not tracking currently selected Doc
Change-Id: I86606646206ec26e2822a6e27888537d44351b7b
Reviewed-on: https://gerrit.libreoffice.org/11725
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
(cherry picked from commit 4108bd9b7a41eaa0f3bf8b8173f27f57e009ee34)
Reviewed-on: https://gerrit.libreoffice.org/11827
Reviewed-by: Muthu Subramanian K muthus...@gmail.com
diff --git a/sfx2/source/doc/objxtor.cxx b/sfx2/source/doc/objxtor.cxx
index 60ae2ef..1fbe840 100644
--- a/sfx2/source/doc/objxtor.cxx
+++ b/sfx2/source/doc/objxtor.cxx
@@ -131,7 +131,7 @@ OString lclGetVBAGlobalConstName( const Reference
XInterface rxComponent )
if( xProps.is() ) try
{
OUString aConstName;
-xProps-getPropertyValue(ThisVBADocObj) = aConstName;
+xProps-getPropertyValue(VBAGlobalConstantName) = aConstName;
return OUStringToOString( aConstName, RTL_TEXTENCODING_ASCII_US );
}
catch (const uno::Exception) // not supported
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index 9c8c7a7..7521061 100644
--- a/sw/inc/unoprnms.hxx
+++ b/sw/inc/unoprnms.hxx
@@ -772,7 +772,7 @@
#define UNO_NAME_DESCRIPTION Description
#define UNO_NAME_META InContentMetadata
#define UNO_NAME_IS_TEMPLATE IsTemplate
-#define UNO_NAME_VBA_DOCOBJ ThisVBADocObj
+#define UNO_NAME_VBA_DOCOBJ VBAGlobalConstantName
#define UNO_NAME_NESTED_TEXT_CONTENT NestedTextContent
#define UNO_NAME_SEPARATOR_LINE_STYLE SeparatorLineStyle
#define UNO_NAME_FOOTNOTE_LINE_STYLE FootnoteLineStyle
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 84938] replace #defined constants with ‘enum class’
https://bugs.freedesktop.org/show_bug.cgi?id=84938 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack|EasyHack |DifficultyInteresting |DifficultyInteresting |SkillCpp|SkillCpp target:4.4.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 84938] replace #defined constants with ‘enum class’
https://bugs.freedesktop.org/show_bug.cgi?id=84938 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Noel Grandin committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7542d38ddeebd37ddea233fa1e4cf15b2e03c49 fdo#84938: replace MIB_ constants with enum It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: accessibility/source dbaccess/source editeng/source framework/source include/rsc include/svtools include/vcl rsc/inc rsc/source sc/source sd/source sfx2/source svtools/
accessibility/source/standard/vclxaccessiblemenuitem.cxx |4 -
dbaccess/source/ui/browser/sbagrid.cxx | 10 ++--
editeng/source/editeng/editview.cxx |4 -
framework/source/classes/menumanager.cxx |6 +-
framework/source/fwe/classes/addonmenu.cxx |4 -
framework/source/uielement/fontsizemenucontroller.cxx|6 +-
framework/source/uielement/headermenucontroller.cxx |4 -
framework/source/uielement/menubarmanager.cxx| 14 +++---
framework/source/uielement/menubarmerger.cxx |2
framework/source/uielement/recentfilesmenucontroller.cxx |2
framework/source/uielement/toolbarmanager.cxx|2
include/rsc/rsc-vcl-shared-types.hxx | 31 +++--
include/svtools/toolbarmenu.hxx |6 +-
include/vcl/menu.hxx |6 +-
rsc/inc/rscdb.hxx|3 +
rsc/source/parser/rscicpx.cxx| 10 ++--
sc/source/ui/view/tabcont.cxx|2
sd/source/ui/app/sdpopup.cxx |2
sfx2/source/dialog/taskpane.cxx |6 +-
sfx2/source/menu/mnuitem.cxx |4 -
sfx2/source/menu/mnumgr.cxx |2
sfx2/source/menu/virtmenu.cxx|2
sfx2/source/sidebar/SidebarController.cxx|8 +--
svtools/source/control/stdmenu.cxx |8 +--
svtools/source/control/toolbarmenu.cxx | 16 +++
svtools/source/control/toolbarmenuimp.hxx|2
svx/source/fmcomp/fmgridcl.cxx |2
svx/source/form/datanavi.cxx |2
svx/source/mnuctrls/SmartTagCtl.cxx |6 +-
svx/source/tbxctrls/fontworkgallery.cxx | 14 +++---
sw/source/uibase/lingu/olmenu.cxx| 20
sw/source/uibase/smartmenu/stmenu.cxx|6 +-
vcl/source/control/tabctrl.cxx |2
vcl/source/window/builder.cxx|2
vcl/source/window/menu.cxx | 34 +++
vcl/source/window/menufloatingwindow.cxx | 10 ++--
vcl/source/window/menuitemlist.cxx |4 -
vcl/source/window/menuitemlist.hxx |6 +-
vcl/source/window/toolbox2.cxx |4 -
vcl/unx/gtk/window/gtksalmenu.cxx|6 +-
40 files changed, 146 insertions(+), 138 deletions(-)
New commits:
commit a7542d38ddeebd37ddea233fa1e4cf15b2e03c49
Author: Noel Grandin n...@peralex.com
Date: Sat Nov 1 14:50:30 2014 +0200
fdo#84938: replace MIB_ constants with enum
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a
Reviewed-on: https://gerrit.libreoffice.org/12179
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/accessibility/source/standard/vclxaccessiblemenuitem.cxx
b/accessibility/source/standard/vclxaccessiblemenuitem.cxx
index 95c59eb..cf4d2f3 100644
--- a/accessibility/source/standard/vclxaccessiblemenuitem.cxx
+++ b/accessibility/source/standard/vclxaccessiblemenuitem.cxx
@@ -190,9 +190,9 @@ sal_Int16 VCLXAccessibleMenuItem::getAccessibleRole( )
throw (RuntimeException,
{
sal_uInt16 nItemId = m_pParent-GetItemId( m_nItemPos );
MenuItemBits nItemBits = m_pParent-GetItemBits(nItemId);
-if( nItemBits MIB_RADIOCHECK)
+if( nItemBits MenuItemBits::RADIOCHECK)
nRole = AccessibleRole::RADIO_MENU_ITEM;
-else if( nItemBits MIB_CHECKABLE)
+else if( nItemBits MenuItemBits::CHECKABLE)
nRole = AccessibleRole::CHECK_MENU_ITEM;
}
return nRole;
diff --git a/dbaccess/source/ui/browser/sbagrid.cxx
b/dbaccess/source/ui/browser/sbagrid.cxx
index abfe3bd..cf86c83 100644
--- a/dbaccess/source/ui/browser/sbagrid.cxx
+++ b/dbaccess/source/ui/browser/sbagrid.cxx
@@ -661,13 +661,13 @@ void
SbaGridHeader::PreExecuteColumnContextMenu(sal_uInt16 nColId, PopupMenu rM
case DataType::REF:
break;
default:
-rMenu.InsertItem(ID_BROWSER_COLATTRSET,
aNewItems.GetItemText(ID_BROWSER_COLATTRSET), 0, OString(), nPos++);
+rMenu.InsertItem(ID_BROWSER_COLATTRSET,
aNewItems.GetItemText(ID_BROWSER_COLATTRSET), MenuItemBits::NONE, OString(),
nPos++);
rMenu.SetHelpId(ID_BROWSER_COLATTRSET,
aNewItems.GetHelpId(ID_BROWSER_COLATTRSET));
rMenu.InsertSeparator(OString(), nPos++);
}
}
-rMenu.InsertItem(ID_BROWSER_COLWIDTH,
aNewItems.GetItemText(ID_BROWSER_COLWIDTH),
[Libreoffice-commits] core.git: include/vcl
include/vcl/keycod.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 654da83ac27fbf84b3813172724ff4ad52782d60
Author: Noel Grandin n...@peralex.com
Date: Sat Nov 1 14:56:32 2014 +0200
fix assert I added to KeyCode
in commit 9044260c35b22aeb6
add some asserts to validate KeyCode values
Change-Id: I73dc4c9ee5e4ced699d44ecdfb306a49b853f67e
Reviewed-on: https://gerrit.libreoffice.org/12180
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/keycod.hxx b/include/vcl/keycod.hxx
index a82a2de..8c344b0 100644
--- a/include/vcl/keycod.hxx
+++ b/include/vcl/keycod.hxx
@@ -80,7 +80,7 @@ public:
inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier )
{
assert(nKey = KEY_CODE);
-assert(nModifier = KEY_MODTYPE);
+assert(nModifier = 0x1000 nModifier = 0xf000);
nKeyCodeAndModifiers = nKey | nModifier;
eFunc = KeyFuncType::DONTKNOW;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/sifr
icon-themes/sifr/cmd/lc_insertauthorfield.png |binary icon-themes/sifr/cmd/lc_shadowed.png |binary icon-themes/sifr/cmd/lc_underlinedouble.png |binary icon-themes/sifr/cmd/lc_upperline.png |binary icon-themes/sifr/cmd/sc_insertauthorfield.png |binary icon-themes/sifr/cmd/sc_shadowed.png |binary icon-themes/sifr/cmd/sc_underlinedouble.png |binary icon-themes/sifr/cmd/sc_upperline.png |binary 8 files changed New commits: commit 946daff61b97a196003d32ada7729fb842db191d Author: Matthias Freund matti...@secure.mailbox.org Date: Sat Nov 1 16:31:22 2014 +0100 fdo#75256 Improve Sifr Icon Theme New insertauthorfield, underlinedouble, upperline and updated shadowed icons. The a of the shadowed icon looked thinner and is looking like the other format icons now. Change-Id: I3bd7e68df5e4a2686be022605a96dd92eb86a200 Reviewed-on: https://gerrit.libreoffice.org/12183 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/icon-themes/sifr/cmd/lc_insertauthorfield.png b/icon-themes/sifr/cmd/lc_insertauthorfield.png new file mode 100644 index 000..8e455c1 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertauthorfield.png differ diff --git a/icon-themes/sifr/cmd/lc_shadowed.png b/icon-themes/sifr/cmd/lc_shadowed.png index ad451e0..9ac7137 100644 Binary files a/icon-themes/sifr/cmd/lc_shadowed.png and b/icon-themes/sifr/cmd/lc_shadowed.png differ diff --git a/icon-themes/sifr/cmd/lc_underlinedouble.png b/icon-themes/sifr/cmd/lc_underlinedouble.png new file mode 100644 index 000..b41743e Binary files /dev/null and b/icon-themes/sifr/cmd/lc_underlinedouble.png differ diff --git a/icon-themes/sifr/cmd/lc_upperline.png b/icon-themes/sifr/cmd/lc_upperline.png new file mode 100644 index 000..c0d5157 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_upperline.png differ diff --git a/icon-themes/sifr/cmd/sc_insertauthorfield.png b/icon-themes/sifr/cmd/sc_insertauthorfield.png new file mode 100644 index 000..16249b9 Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertauthorfield.png differ diff --git a/icon-themes/sifr/cmd/sc_shadowed.png b/icon-themes/sifr/cmd/sc_shadowed.png index 0e0506e..c9c2ed8 100644 Binary files a/icon-themes/sifr/cmd/sc_shadowed.png and b/icon-themes/sifr/cmd/sc_shadowed.png differ diff --git a/icon-themes/sifr/cmd/sc_underlinedouble.png b/icon-themes/sifr/cmd/sc_underlinedouble.png new file mode 100644 index 000..f803bfc Binary files /dev/null and b/icon-themes/sifr/cmd/sc_underlinedouble.png differ diff --git a/icon-themes/sifr/cmd/sc_upperline.png b/icon-themes/sifr/cmd/sc_upperline.png new file mode 100644 index 000..9cd2401 Binary files /dev/null and b/icon-themes/sifr/cmd/sc_upperline.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx | 197 +++
1 file changed, 96 insertions(+), 101 deletions(-)
New commits:
commit 6d960bd72c81d43ba7ba6bde359aa2fbc07c421a
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 12:43:07 2014 -0400
Unindent.
Change-Id: I1b65915b7d864f1a69f48fcacf38e7aec23c38a4
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
index ca819b5..d80b309 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
@@ -32,129 +32,124 @@
#include basegfx/matrix/b2dhommatrix.hxx
#include svtools/embedhlp.hxx
-
using namespace com::sun::star;
+namespace sdr { namespace contact {
+const SdrOle2Obj ViewObjectContactOfSdrOle2Obj::getSdrOle2Object() const
+{
+return static_cast ViewContactOfSdrOle2Obj
(GetViewContact()).GetOle2Obj();
+}
-namespace sdr
+drawinglayer::primitive2d::Primitive2DSequence
ViewObjectContactOfSdrOle2Obj::createPrimitive2DSequence(
+const DisplayInfo /*rDisplayInfo*/) const
{
-namespace contact
+// this method is overloaded to do some things the old
SdrOle2Obj::DoPaintObject did.
+// In the future, some of these may be solved different, but ATM try to
stay compatible
+// with the old behaviour
+drawinglayer::primitive2d::Primitive2DSequence xRetval;
+const SdrOle2Obj rSdrOle2 = getSdrOle2Object();
+sal_Int32 nState(-1);
+
{
-const SdrOle2Obj ViewObjectContactOfSdrOle2Obj::getSdrOle2Object()
const
+const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
+if ( xObjRef.is() )
+nState = xObjRef-getCurrentState();
+}
+
+const bool bIsOutplaceActive(nState == embed::EmbedStates::ACTIVE);
+const bool bIsInplaceActive((nState == embed::EmbedStates::INPLACE_ACTIVE)
|| (nState == embed::EmbedStates::UI_ACTIVE));
+bool bDone(false);
+
+if(!bDone bIsInplaceActive)
+{
+if( !GetObjectContact().isOutputToPrinter()
!GetObjectContact().isOutputToRecordingMetaFile() )
{
-return static_cast ViewContactOfSdrOle2Obj
(GetViewContact()).GetOle2Obj();
+//no need to create a primitive sequence here as the OLE object
does render itself
+//in case of charts the superfluous creation of a metafile is
strongly performance relevant!
+bDone = true;
}
+}
-drawinglayer::primitive2d::Primitive2DSequence
ViewObjectContactOfSdrOle2Obj::createPrimitive2DSequence(
-const DisplayInfo /*rDisplayInfo*/) const
+if( !bDone )
+{
+//old stuff that should be reworked
{
-// this method is overloaded to do some things the old
SdrOle2Obj::DoPaintObject did.
-// In the future, some of these may be solved different, but ATM
try to stay compatible
-// with the old behaviour
-drawinglayer::primitive2d::Primitive2DSequence xRetval;
-const SdrOle2Obj rSdrOle2 = getSdrOle2Object();
-sal_Int32 nState(-1);
-
+//if no replacement image is available load the OLE object
+// if(!rSdrOle2.GetGraphic()) //try to fetch the metafile - this can
lead to the actual creation of the metafile what can be extremely expensive
(e.g. for big charts)!!! #i101925#
+// {
+//// try to create embedded object
+// rSdrOle2.GetObjRef(); //this loads the OLE object if it is not
loaded already
+// }
+const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
+if(xObjRef.is())
{
-const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
-if ( xObjRef.is() )
-nState = xObjRef-getCurrentState();
-}
-
-const bool bIsOutplaceActive(nState == embed::EmbedStates::ACTIVE);
-const bool bIsInplaceActive((nState ==
embed::EmbedStates::INPLACE_ACTIVE) || (nState ==
embed::EmbedStates::UI_ACTIVE));
-bool bDone(false);
+const sal_Int64
nMiscStatus(xObjRef-getStatus(rSdrOle2.GetAspect()));
-if(!bDone bIsInplaceActive)
-{
-if( !GetObjectContact().isOutputToPrinter()
!GetObjectContact().isOutputToRecordingMetaFile() )
+// this hack (to change model data during PAINT argh(!))
should be reworked
+if(!rSdrOle2.IsResizeProtect() (nMiscStatus
embed::EmbedMisc::EMBED_NEVERRESIZE))
{
-//no need to create a primitive sequence here as the OLE
object does render itself
-//in case of charts the superfluous creation of a metafile
is strongly performance relevant!
-bDone = true;
+const_cast SdrOle2Obj*
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - svx/source
svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx | 197 +++
1 file changed, 96 insertions(+), 101 deletions(-)
New commits:
commit 80c86ba81b38fe4085f7b588a2dbf24894a7f215
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 12:43:07 2014 -0400
Unindent.
Change-Id: I1b65915b7d864f1a69f48fcacf38e7aec23c38a4
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
index ca819b5..d80b309 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrole2obj.cxx
@@ -32,129 +32,124 @@
#include basegfx/matrix/b2dhommatrix.hxx
#include svtools/embedhlp.hxx
-
using namespace com::sun::star;
+namespace sdr { namespace contact {
+const SdrOle2Obj ViewObjectContactOfSdrOle2Obj::getSdrOle2Object() const
+{
+return static_cast ViewContactOfSdrOle2Obj
(GetViewContact()).GetOle2Obj();
+}
-namespace sdr
+drawinglayer::primitive2d::Primitive2DSequence
ViewObjectContactOfSdrOle2Obj::createPrimitive2DSequence(
+const DisplayInfo /*rDisplayInfo*/) const
{
-namespace contact
+// this method is overloaded to do some things the old
SdrOle2Obj::DoPaintObject did.
+// In the future, some of these may be solved different, but ATM try to
stay compatible
+// with the old behaviour
+drawinglayer::primitive2d::Primitive2DSequence xRetval;
+const SdrOle2Obj rSdrOle2 = getSdrOle2Object();
+sal_Int32 nState(-1);
+
{
-const SdrOle2Obj ViewObjectContactOfSdrOle2Obj::getSdrOle2Object()
const
+const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
+if ( xObjRef.is() )
+nState = xObjRef-getCurrentState();
+}
+
+const bool bIsOutplaceActive(nState == embed::EmbedStates::ACTIVE);
+const bool bIsInplaceActive((nState == embed::EmbedStates::INPLACE_ACTIVE)
|| (nState == embed::EmbedStates::UI_ACTIVE));
+bool bDone(false);
+
+if(!bDone bIsInplaceActive)
+{
+if( !GetObjectContact().isOutputToPrinter()
!GetObjectContact().isOutputToRecordingMetaFile() )
{
-return static_cast ViewContactOfSdrOle2Obj
(GetViewContact()).GetOle2Obj();
+//no need to create a primitive sequence here as the OLE object
does render itself
+//in case of charts the superfluous creation of a metafile is
strongly performance relevant!
+bDone = true;
}
+}
-drawinglayer::primitive2d::Primitive2DSequence
ViewObjectContactOfSdrOle2Obj::createPrimitive2DSequence(
-const DisplayInfo /*rDisplayInfo*/) const
+if( !bDone )
+{
+//old stuff that should be reworked
{
-// this method is overloaded to do some things the old
SdrOle2Obj::DoPaintObject did.
-// In the future, some of these may be solved different, but ATM
try to stay compatible
-// with the old behaviour
-drawinglayer::primitive2d::Primitive2DSequence xRetval;
-const SdrOle2Obj rSdrOle2 = getSdrOle2Object();
-sal_Int32 nState(-1);
-
+//if no replacement image is available load the OLE object
+// if(!rSdrOle2.GetGraphic()) //try to fetch the metafile - this can
lead to the actual creation of the metafile what can be extremely expensive
(e.g. for big charts)!!! #i101925#
+// {
+//// try to create embedded object
+// rSdrOle2.GetObjRef(); //this loads the OLE object if it is not
loaded already
+// }
+const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
+if(xObjRef.is())
{
-const svt::EmbeddedObjectRef xObjRef =
rSdrOle2.getEmbeddedObjectRef();
-if ( xObjRef.is() )
-nState = xObjRef-getCurrentState();
-}
-
-const bool bIsOutplaceActive(nState == embed::EmbedStates::ACTIVE);
-const bool bIsInplaceActive((nState ==
embed::EmbedStates::INPLACE_ACTIVE) || (nState ==
embed::EmbedStates::UI_ACTIVE));
-bool bDone(false);
+const sal_Int64
nMiscStatus(xObjRef-getStatus(rSdrOle2.GetAspect()));
-if(!bDone bIsInplaceActive)
-{
-if( !GetObjectContact().isOutputToPrinter()
!GetObjectContact().isOutputToRecordingMetaFile() )
+// this hack (to change model data during PAINT argh(!))
should be reworked
+if(!rSdrOle2.IsResizeProtect() (nMiscStatus
embed::EmbedMisc::EMBED_NEVERRESIZE))
{
-//no need to create a primitive sequence here as the OLE
object does render itself
-//in case of charts the superfluous creation of a metafile
is strongly performance relevant!
-bDone = true;
+const_cast SdrOle2Obj*
[Libreoffice-commits] core.git: include/vcl
include/vcl/keycod.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c75466ac88a47859227efc635fa1fcd5edd0a277
Author: Noel Grandin n...@peralex.com
Date: Sat Nov 1 19:10:19 2014 +0200
second attempt at fixing my asserts
it appears I can't trust the buildbots, they don't seem to be
compiling with asserts
Change-Id: Ia49f5d3f134cf1a578469ddcbc7c492383aa971d
Reviewed-on: https://gerrit.libreoffice.org/12184
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/keycod.hxx b/include/vcl/keycod.hxx
index 8c344b0..7e7ece3 100644
--- a/include/vcl/keycod.hxx
+++ b/include/vcl/keycod.hxx
@@ -80,7 +80,7 @@ public:
inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier )
{
assert(nKey = KEY_CODE);
-assert(nModifier = 0x1000 nModifier = 0xf000);
+assert(nModifier == 0 || (nModifier = 0x1000 nModifier = 0xf000));
nKeyCodeAndModifiers = nKey | nModifier;
eFunc = KeyFuncType::DONTKNOW;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 2 commits - include/svx svx/inc svx/source
include/svx/sdr/contact/viewcontactofpageobj.hxx |6
include/svx/sdr/contact/viewcontactofsdrmediaobj.hxx |6
include/svx/sdr/contact/viewcontactofsdrrectobj.hxx | 11
include/svx/sdr/contact/viewcontactoftextobj.hxx | 11
include/svx/svdomedia.hxx |4
svx/inc/sdr/contact/viewcontactofgraphic.hxx | 10
svx/inc/sdr/contact/viewcontactofgroup.hxx| 11
svx/inc/sdr/contact/viewcontactofsdrcaptionobj.hxx| 11
svx/inc/sdr/contact/viewcontactofsdrcircobj.hxx | 11
svx/inc/sdr/contact/viewcontactofsdredgeobj.hxx | 11
svx/inc/sdr/contact/viewcontactofsdrmeasureobj.hxx| 11
svx/inc/sdr/contact/viewcontactofsdrobjcustomshape.hxx| 11
svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx |6
svx/inc/sdr/contact/viewcontactofsdrpathobj.hxx | 11
svx/inc/sdr/contact/viewcontactofunocontrol.hxx |6
svx/inc/sdr/contact/viewobjectcontactofgraphic.hxx|1
svx/source/items/customshapeitem.cxx |2
svx/source/items/drawitem.cxx | 12
svx/source/items/e3ditem.cxx |2
svx/source/items/grfitem.cxx | 11
svx/source/sdr/attribute/sdrformtextattribute.cxx | 42 -
svx/source/sdr/contact/objectcontactofpageview.cxx|2
svx/source/sdr/contact/viewcontactofgraphic.cxx | 20
svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx | 12
svx/source/sdr/contact/viewcontactofsdrcircobj.cxx|4
svx/source/sdr/contact/viewcontactofsdrmeasureobj.cxx | 20
svx/source/sdr/contact/viewcontactofsdrobj.cxx|6
svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx |2
svx/source/sdr/contact/viewcontactofsdrrectobj.cxx|2
svx/source/sdr/contact/viewcontactofvirtobj.cxx | 10
svx/source/sdr/contact/viewobjectcontactofgraphic.cxx |7
svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx | 214
--
svx/source/sdr/overlay/overlaymanager.cxx |4
svx/source/sdr/overlay/overlaymanagerbuffered.cxx |2
svx/source/sdr/primitive2d/sdrattributecreator.cxx| 151
+++
svx/source/sdr/primitive2d/sdrcaptionprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrconnectorprimitive2d.cxx|2
svx/source/sdr/primitive2d/sdrcustomshapeprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrellipseprimitive2d.cxx |4
svx/source/sdr/primitive2d/sdrgrafprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrmeasureprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrole2primitive2d.cxx |2
svx/source/sdr/primitive2d/sdrolecontentprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrpathprimitive2d.cxx |2
svx/source/sdr/primitive2d/sdrrectangleprimitive2d.cxx|2
svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx | 12
svx/source/svdraw/svdomedia.cxx |2
svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx |4
48 files changed, 333 insertions(+), 370 deletions(-)
New commits:
commit 760e63c14cab67320b40aa71accaa91d58fe2ad7
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:21:08 2014 -0400
Unindent.
Change-Id: I0e86d04c0fa6185b41d5751d28a7e3f3b86af371
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index d61bc3e..2273f4b 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -32,137 +32,133 @@
#include fmobj.hxx
+namespace sdr { namespace contact {
+const SdrObject ViewObjectContactOfSdrObj::getSdrObject() const
+{
+return static_cast ViewContactOfSdrObj
(GetViewContact()).GetSdrObject();
+}
-namespace sdr
+ViewObjectContactOfSdrObj::ViewObjectContactOfSdrObj(ObjectContact
rObjectContact, ViewContact rViewContact)
+: ViewObjectContact(rObjectContact, rViewContact)
{
-namespace contact
-{
-const SdrObject ViewObjectContactOfSdrObj::getSdrObject() const
-{
-return static_cast ViewContactOfSdrObj
(GetViewContact()).GetSdrObject();
-}
[Libreoffice-commits] core.git: svx/source
svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx | 214 +--
1 file changed, 105 insertions(+), 109 deletions(-)
New commits:
commit 0cada896f09d9e6b9a2c7ac04317a3a9cc6c0a7c
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:21:08 2014 -0400
Unindent.
Change-Id: I0e86d04c0fa6185b41d5751d28a7e3f3b86af371
diff --git a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
index d61bc3e..2273f4b 100644
--- a/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
+++ b/svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx
@@ -32,137 +32,133 @@
#include fmobj.hxx
+namespace sdr { namespace contact {
+const SdrObject ViewObjectContactOfSdrObj::getSdrObject() const
+{
+return static_cast ViewContactOfSdrObj
(GetViewContact()).GetSdrObject();
+}
-namespace sdr
+ViewObjectContactOfSdrObj::ViewObjectContactOfSdrObj(ObjectContact
rObjectContact, ViewContact rViewContact)
+: ViewObjectContact(rObjectContact, rViewContact)
{
-namespace contact
-{
-const SdrObject ViewObjectContactOfSdrObj::getSdrObject() const
-{
-return static_cast ViewContactOfSdrObj
(GetViewContact()).GetSdrObject();
-}
+}
-ViewObjectContactOfSdrObj::ViewObjectContactOfSdrObj(ObjectContact
rObjectContact, ViewContact rViewContact)
-: ViewObjectContact(rObjectContact, rViewContact)
-{
-}
+ViewObjectContactOfSdrObj::~ViewObjectContactOfSdrObj()
+{
+}
-ViewObjectContactOfSdrObj::~ViewObjectContactOfSdrObj()
-{
-}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const
+{
+return aLayers.IsSet(getSdrObject().GetLayer());
+}
-bool ViewObjectContactOfSdrObj::isPrimitiveVisibleOnAnyLayer(const
SetOfByte aLayers) const
-{
-return aLayers.IsSet(getSdrObject().GetLayer());
-}
+bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
+{
+const SdrObject rObject = getSdrObject();
-bool ViewObjectContactOfSdrObj::isPrimitiveVisible(const DisplayInfo
rDisplayInfo) const
-{
-const SdrObject rObject = getSdrObject();
+// Test layer visibility
+if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
+{
+return false;
+}
-// Test layer visibility
-if(!isPrimitiveVisibleOnAnyLayer(rDisplayInfo.GetProcessLayers()))
-{
-return false;
-}
+if(GetObjectContact().isOutputToPrinter() )
+{
+// Test if print output but not printable
+if( !rObject.IsPrintable())
+return false;
+}
+else
+{
+// test is object is not visible on screen
+if( !rObject.IsVisible() )
+return false;
+}
-if(GetObjectContact().isOutputToPrinter() )
-{
-// Test if print output but not printable
-if( !rObject.IsPrintable())
-return false;
-}
-else
-{
-// test is object is not visible on screen
-if( !rObject.IsVisible() )
-return false;
-}
+// Test for hidden object on MasterPage
+if(rDisplayInfo.GetSubContentActive() rObject.IsNotVisibleAsMaster())
+{
+return false;
+}
-// Test for hidden object on MasterPage
-if(rDisplayInfo.GetSubContentActive()
rObject.IsNotVisibleAsMaster())
-{
-return false;
-}
+// Test for Calc object hiding (for OLE and Graphic it's extra, see there)
+const SdrPageView* pSdrPageView = GetObjectContact().TryToGetSdrPageView();
-// Test for Calc object hiding (for OLE and Graphic it's extra,
see there)
-const SdrPageView* pSdrPageView =
GetObjectContact().TryToGetSdrPageView();
+if(pSdrPageView)
+{
+const SdrView rSdrView = pSdrPageView-GetView();
+const bool bHideOle(rSdrView.getHideOle());
+const bool bHideChart(rSdrView.getHideChart());
+const bool bHideDraw(rSdrView.getHideDraw());
+const bool bHideFormControl(rSdrView.getHideFormControl());
-if(pSdrPageView)
+if(bHideOle || bHideChart || bHideDraw || bHideFormControl)
+{
+if(OBJ_OLE2 == rObject.GetObjIdentifier())
{
-const SdrView rSdrView = pSdrPageView-GetView();
-const bool bHideOle(rSdrView.getHideOle());
-const bool bHideChart(rSdrView.getHideChart());
-const bool bHideDraw(rSdrView.getHideDraw());
-const bool bHideFormControl(rSdrView.getHideFormControl());
-
-if(bHideOle || bHideChart || bHideDraw || bHideFormControl)
+if(static_castconst
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - include/svx
include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx | 65 --
1 file changed, 31 insertions(+), 34 deletions(-)
New commits:
commit f158bf604e60b55051c9bab3945c59cf8c459263
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:45:12 2014 -0400
Unindent.
Change-Id: I911de1c7b47768233bdd9580361b8cf430b3684e
diff --git a/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index 45cd0d9..e4def23 100644
--- a/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -28,42 +28,39 @@ class SdrObject;
class SetOfByte;
class OutputDevice;
+namespace sdr { namespace contact {
-namespace sdr
+class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public ViewObjectContact
{
-namespace contact
-{
-class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
-{
-/** Test whether the primitive is visible on any layer from @c
aLayers
-
-This should be overridden by ViewObjectContacts of SDR classes
-that have subparts which can be on different layers (that is,
-SdrObjGroup .-)
- */
-virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
-
-protected:
-const SdrObject getSdrObject() const;
-
-public:
-ViewObjectContactOfSdrObj(ObjectContact rObjectContact,
ViewContact rViewContact);
-virtual ~ViewObjectContactOfSdrObj();
-
-virtual bool isPrimitiveVisible(const DisplayInfo rDisplayInfo)
const SAL_OVERRIDE;
-
-/** retrieves the device which a PageView belongs to, starting
from its ObjectContactOfPageView
-
-Since #i72752#, the PaintWindow (and thus the OutputDevice)
associated with a PageView is not
-constant over its lifetime. Instead, during some paint
operations, the PaintWindow/OutputDevice
-might be temporarily patched.
-
-This method cares for this, by retrieving the very original
OutputDevice.
-*/
-boost::optionalconst OutputDevice getPageViewOutputDevice()
const;
-};
-} // end of namespace contact
-} // end of namespace sdr
+/** Test whether the primitive is visible on any layer from @c aLayers
+
+This should be overridden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte aLayers) const;
+
+protected:
+const SdrObject getSdrObject() const;
+
+public:
+ViewObjectContactOfSdrObj(ObjectContact rObjectContact, ViewContact
rViewContact);
+virtual ~ViewObjectContactOfSdrObj();
+
+virtual bool isPrimitiveVisible(const DisplayInfo rDisplayInfo) const
SAL_OVERRIDE;
+
+/** retrieves the device which a PageView belongs to, starting from its
ObjectContactOfPageView
+
+Since #i72752#, the PaintWindow (and thus the OutputDevice) associated
with a PageView is not
+constant over its lifetime. Instead, during some paint operations, the
PaintWindow/OutputDevice
+might be temporarily patched.
+
+This method cares for this, by retrieving the very original
OutputDevice.
+*/
+boost::optionalconst OutputDevice getPageViewOutputDevice() const;
+};
+
+}}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svx
include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx | 65 --
1 file changed, 31 insertions(+), 34 deletions(-)
New commits:
commit 9de534e629e4338ae7f317ebc7ca63a2dfebb7ba
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:45:12 2014 -0400
Unindent.
Change-Id: I911de1c7b47768233bdd9580361b8cf430b3684e
diff --git a/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
b/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
index 45cd0d9..e4def23 100644
--- a/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
+++ b/include/svx/sdr/contact/viewobjectcontactofsdrobj.hxx
@@ -28,42 +28,39 @@ class SdrObject;
class SetOfByte;
class OutputDevice;
+namespace sdr { namespace contact {
-namespace sdr
+class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public ViewObjectContact
{
-namespace contact
-{
-class SVX_DLLPUBLIC ViewObjectContactOfSdrObj : public
ViewObjectContact
-{
-/** Test whether the primitive is visible on any layer from @c
aLayers
-
-This should be overridden by ViewObjectContacts of SDR classes
-that have subparts which can be on different layers (that is,
-SdrObjGroup .-)
- */
-virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte
aLayers) const;
-
-protected:
-const SdrObject getSdrObject() const;
-
-public:
-ViewObjectContactOfSdrObj(ObjectContact rObjectContact,
ViewContact rViewContact);
-virtual ~ViewObjectContactOfSdrObj();
-
-virtual bool isPrimitiveVisible(const DisplayInfo rDisplayInfo)
const SAL_OVERRIDE;
-
-/** retrieves the device which a PageView belongs to, starting
from its ObjectContactOfPageView
-
-Since #i72752#, the PaintWindow (and thus the OutputDevice)
associated with a PageView is not
-constant over its lifetime. Instead, during some paint
operations, the PaintWindow/OutputDevice
-might be temporarily patched.
-
-This method cares for this, by retrieving the very original
OutputDevice.
-*/
-boost::optionalconst OutputDevice getPageViewOutputDevice()
const;
-};
-} // end of namespace contact
-} // end of namespace sdr
+/** Test whether the primitive is visible on any layer from @c aLayers
+
+This should be overridden by ViewObjectContacts of SDR classes
+that have subparts which can be on different layers (that is,
+SdrObjGroup .-)
+ */
+virtual bool isPrimitiveVisibleOnAnyLayer(const SetOfByte aLayers) const;
+
+protected:
+const SdrObject getSdrObject() const;
+
+public:
+ViewObjectContactOfSdrObj(ObjectContact rObjectContact, ViewContact
rViewContact);
+virtual ~ViewObjectContactOfSdrObj();
+
+virtual bool isPrimitiveVisible(const DisplayInfo rDisplayInfo) const
SAL_OVERRIDE;
+
+/** retrieves the device which a PageView belongs to, starting from its
ObjectContactOfPageView
+
+Since #i72752#, the PaintWindow (and thus the OutputDevice) associated
with a PageView is not
+constant over its lifetime. Instead, during some paint operations, the
PaintWindow/OutputDevice
+might be temporarily patched.
+
+This method cares for this, by retrieving the very original
OutputDevice.
+*/
+boost::optionalconst OutputDevice getPageViewOutputDevice() const;
+};
+
+}}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - svx/inc
svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx | 30 ++
1 file changed, 11 insertions(+), 19 deletions(-)
New commits:
commit 6c37011e6abc10348cd1acc7ab85426938256f0f
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:51:35 2014 -0400
Unindent.
Change-Id: I32afaeb71f57b4f8741758a1db98e04365bd2a77
diff --git a/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
b/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
index bb97105..25b66a5 100644
--- a/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
+++ b/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
@@ -22,32 +22,24 @@
#include svx/sdr/contact/viewobjectcontactofsdrobj.hxx
-
-// predeclarations
class SdrOle2Obj;
+namespace sdr { namespace contact {
-
-namespace sdr
+class ViewObjectContactOfSdrOle2Obj : public ViewObjectContactOfSdrObj
{
-namespace contact
-{
-class ViewObjectContactOfSdrOle2Obj : public ViewObjectContactOfSdrObj
-{
-protected:
-const SdrOle2Obj getSdrOle2Object() const;
-
-// This method is responsible for creating the graphical
visualisation data
-virtual drawinglayer::primitive2d::Primitive2DSequence
createPrimitive2DSequence(const DisplayInfo rDisplayInfo) const SAL_OVERRIDE;
+protected:
+const SdrOle2Obj getSdrOle2Object() const;
-public:
-ViewObjectContactOfSdrOle2Obj(ObjectContact rObjectContact,
ViewContact rViewContact);
-virtual ~ViewObjectContactOfSdrOle2Obj();
-};
-} // end of namespace contact
-} // end of namespace sdr
+// This method is responsible for creating the graphical visualisation data
+virtual drawinglayer::primitive2d::Primitive2DSequence
createPrimitive2DSequence(const DisplayInfo rDisplayInfo) const SAL_OVERRIDE;
+public:
+ViewObjectContactOfSdrOle2Obj(ObjectContact rObjectContact, ViewContact
rViewContact);
+virtual ~ViewObjectContactOfSdrOle2Obj();
+};
+}}
#endif // INCLUDED_SVX_INC_SDR_CONTACT_VIEWOBJECTCONTACTOFSDROLE2OBJ_HXX
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/inc
svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx | 30 ++
1 file changed, 11 insertions(+), 19 deletions(-)
New commits:
commit 5d87009cc2d385e61edd06bb5c81ef2106405066
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Nov 1 13:51:35 2014 -0400
Unindent.
Change-Id: I32afaeb71f57b4f8741758a1db98e04365bd2a77
diff --git a/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
b/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
index bb97105..25b66a5 100644
--- a/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
+++ b/svx/inc/sdr/contact/viewobjectcontactofsdrole2obj.hxx
@@ -22,32 +22,24 @@
#include svx/sdr/contact/viewobjectcontactofsdrobj.hxx
-
-// predeclarations
class SdrOle2Obj;
+namespace sdr { namespace contact {
-
-namespace sdr
+class ViewObjectContactOfSdrOle2Obj : public ViewObjectContactOfSdrObj
{
-namespace contact
-{
-class ViewObjectContactOfSdrOle2Obj : public ViewObjectContactOfSdrObj
-{
-protected:
-const SdrOle2Obj getSdrOle2Object() const;
-
-// This method is responsible for creating the graphical
visualisation data
-virtual drawinglayer::primitive2d::Primitive2DSequence
createPrimitive2DSequence(const DisplayInfo rDisplayInfo) const SAL_OVERRIDE;
+protected:
+const SdrOle2Obj getSdrOle2Object() const;
-public:
-ViewObjectContactOfSdrOle2Obj(ObjectContact rObjectContact,
ViewContact rViewContact);
-virtual ~ViewObjectContactOfSdrOle2Obj();
-};
-} // end of namespace contact
-} // end of namespace sdr
+// This method is responsible for creating the graphical visualisation data
+virtual drawinglayer::primitive2d::Primitive2DSequence
createPrimitive2DSequence(const DisplayInfo rDisplayInfo) const SAL_OVERRIDE;
+public:
+ViewObjectContactOfSdrOle2Obj(ObjectContact rObjectContact, ViewContact
rViewContact);
+virtual ~ViewObjectContactOfSdrOle2Obj();
+};
+}}
#endif // INCLUDED_SVX_INC_SDR_CONTACT_VIEWOBJECTCONTACTOFSDROLE2OBJ_HXX
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8
HSQLDB requires some J2EE libs that aren't bundled within a standard JDK (javax.servlet). source files: ./workdir/UnpackedTarball/hsqldb/src/hsqlServlet.java ./workdir/UnpackedTarball/hsqldb/src/org/hsqldb/Servlet.java build: ./workdir/UnpackedTarball/hsqldb/classes/hsqlServlet.class ./workdir/UnpackedTarball/hsqldb/classes/org/hsqldb/Servlet.class Regards, Robert On Tue, Oct 28, 2014 at 11:22 AM, Stephan Bergmann sberg...@redhat.com wrote: On 10/20/2014 01:48 PM, Alexander Thurgood wrote: I encountrered this very same problem, and solved it by installing the appropriate JavaforOSX2014-001.dmg, which allowed my build to complete the debug tests, but this apparently also has consequences for use of third party jdbc drivers that rely on JDK 1.8 In how far? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- http://about.me/rbuj ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Spelling dialog regression in calc
Just discovered we have a pesky regression we picked up on the 4.1 - 4.2 transition with the Spelling dialog F7 not resetting underline of the misspelled words when corrected. All seems correct if the spelling is corrected with context menu. So, suspect it to be mishandling of the bPaintWrong value in Calc when set from the spelling dialog rather than context menu. Reported some time ago as fdo#82091 https://bugs.freedesktop.org/show_bug.cgi?id=82091 . -- View this message in context: http://nabble.documentfoundation.org/Spelling-dialog-regression-in-calc-tp4127603.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8
I think that the following command can solve the issue with Oracle's JDKs. sudo curl -o /Library/Java/Extensions/javaee-api-7.0.jar -O#L http://central.maven.org/maven2/javax/javaee-api/7.0/javaee-api-7.0.jar Regards, Robert On Sat, Nov 1, 2014 at 8:19 PM, Robert Antoni Buj i Gelonch robert@gmail.com wrote: HSQLDB requires some J2EE libs that aren't bundled within a standard JDK (javax.servlet). source files: ./workdir/UnpackedTarball/hsqldb/src/hsqlServlet.java ./workdir/UnpackedTarball/hsqldb/src/org/hsqldb/Servlet.java build: ./workdir/UnpackedTarball/hsqldb/classes/hsqlServlet.class ./workdir/UnpackedTarball/hsqldb/classes/org/hsqldb/Servlet.class Regards, Robert On Tue, Oct 28, 2014 at 11:22 AM, Stephan Bergmann sberg...@redhat.com wrote: On 10/20/2014 01:48 PM, Alexander Thurgood wrote: I encountrered this very same problem, and solved it by installing the appropriate JavaforOSX2014-001.dmg, which allowed my build to complete the debug tests, but this apparently also has consequences for use of third party jdbc drivers that rely on JDK 1.8 In how far? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- http://about.me/rbuj -- http://about.me/rbuj ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 17 commits - chart2/source cui/source extensions/source i18npool/source lotuswordpro/source registry/source sot/source svtools/source svx/source sw/source tools/source
chart2/source/controller/main/DrawCommandDispatch.cxx|2 -
cui/source/customize/cfg.cxx |6 ++-
extensions/source/scanner/sane.cxx |2 -
i18npool/source/calendar/calendar_gregorian.cxx |2 +
lotuswordpro/source/filter/lwptools.cxx |3 +
registry/source/reflread.cxx | 23 ---
sot/source/sdstor/ucbstorage.cxx |7 +++
svtools/source/brwbox/brwbox1.cxx|6 +--
svtools/source/brwbox/datwin.cxx | 13 ++
svx/source/table/tablecontroller.cxx |2 -
sw/source/core/doc/htmltbl.cxx | 11 -
sw/source/uibase/dbui/mailmergehelper.cxx|2 -
tools/source/generic/fract.cxx |1
vcl/generic/fontmanager/fontconfig.cxx |2 -
vcl/generic/glyphs/gcach_ftyp.cxx|9 +---
vcl/source/control/combobox.cxx |2 -
vcl/source/outdev/map.cxx|5 ++
writerfilter/source/dmapper/DomainMapperTableManager.cxx | 29 +--
18 files changed, 79 insertions(+), 48 deletions(-)
New commits:
commit 6fed9d0b1fc95fcea0de1a5faec2b4d5647be58a
Author: Caolán McNamara caol...@redhat.com
Date: Sat Nov 1 20:47:57 2014 +
coverity#1241199 Unchecked dynamic_cast
Change-Id: Id6bbd9d6922ee6fda7e9eb0945c27ed5a902d05b
diff --git a/svx/source/table/tablecontroller.cxx
b/svx/source/table/tablecontroller.cxx
index 3ef0370..f02ae22 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -699,7 +699,7 @@ void SvxTableController::onInsert( sal_uInt16 nSId, const
SfxItemSet* pArgs )
for( nSpanInfoRow = nPropSrcRow - 1; nSpanInfoRow =
0; --nSpanInfoRow )
{
CellRef xMergeInfoCell( dynamic_cast Cell* (
mxTable-getCellByPosition( nCol, nSpanInfoRow ).get() ) );
-if( !xMergeInfoCell-isMerged() )
+if (xMergeInfoCell.is()
!xMergeInfoCell-isMerged())
{
nColSpan = xMergeInfoCell-getColumnSpan();
nRowSpan = xMergeInfoCell-getRowSpan();
commit 8f69c7a11bf31f7134caf4e03fbcd4c6ef86382d
Author: Caolán McNamara caol...@redhat.com
Date: Sat Nov 1 20:46:35 2014 +
coverity#1213373 Use of untrusted scalar value
Change-Id: Ia5cafdde1171f81ea7387e073026a2e860d36544
diff --git a/registry/source/reflread.cxx b/registry/source/reflread.cxx
index 3f0a994..f8a5e8f 100644
--- a/registry/source/reflread.cxx
+++ b/registry/source/reflread.cxx
@@ -72,7 +72,13 @@ public:
inline sal_uInt16 readUINT16(sal_uInt32 index) const
{
-return ((m_pBuffer[index] 8) | (m_pBuffer[index+1] 0));
+//This is untainted data which comes from a controlled source
+//so, using a byte-swapping pattern which coverity doesn't
+//detect as such
+
//http://security.coverity.com/blog/2014/Apr/on-detecting-heartbleed-with-static-analysis.html
+sal_uInt32 v = m_pBuffer[index]; v = 8;
+v |= m_pBuffer[index+1];
+return v;
}
inline sal_Int32 readINT32(sal_uInt32 index) const
@@ -87,12 +93,15 @@ public:
inline sal_uInt32 readUINT32(sal_uInt32 index) const
{
-return (
-(m_pBuffer[index]24) |
-(m_pBuffer[index+1] 16) |
-(m_pBuffer[index+2] 8) |
-(m_pBuffer[index+3] 0)
-);
+//This is untainted data which comes from a controlled source
+//so, using a byte-swapping pattern which coverity doesn't
+//detect as such
+
//http://security.coverity.com/blog/2014/Apr/on-detecting-heartbleed-with-static-analysis.html
+sal_uInt32 v = m_pBuffer[index]; v = 8;
+v |= m_pBuffer[index+1]; v = 8;
+v |= m_pBuffer[index+2]; v = 8;
+v |= m_pBuffer[index+3];
+return v;
}
inline sal_Int64 readINT64(sal_uInt32 index) const
commit 78e670b3055f92740402803174d61d058effb5d7
Author: Caolán McNamara caol...@redhat.com
Date: Sat Nov 1 20:38:57 2014 +
coverity#1078538 Division or modulo by zero
Change-Id: I0ae8d51a569c2a63f5fb390e66fdbde4a8e8b5d5
diff --git a/sw/source/core/doc/htmltbl.cxx b/sw/source/core/doc/htmltbl.cxx
index b788405..63a877f 100644
--- a/sw/source/core/doc/htmltbl.cxx
+++ b/sw/source/core/doc/htmltbl.cxx
@@ -1455,9 +1455,14 @@ void SwHTMLTableLayout::AutoLayoutPass2( sal_uInt16
nAbsAvail, sal_uInt16 nRelAv
}
sal_uLong nAbsTabWidthL = nAbsTabWidth;
-nRelTabWidth =
-( nRelAvail ? (sal_uInt16)((nAbsTabWidthL * nRelAvail) / nAbsAvail)
-: nAbsTabWidth );
+
[Libreoffice-commits] core.git: cui/uiconfig filter/uiconfig
cui/uiconfig/ui/aboutconfigdialog.ui | 15 cui/uiconfig/ui/aboutconfigvaluedialog.ui|7 cui/uiconfig/ui/agingdialog.ui | 16 cui/uiconfig/ui/areadialog.ui|5 cui/uiconfig/ui/areatabpage.ui | 97 ++--- cui/uiconfig/ui/asiantypography.ui |5 cui/uiconfig/ui/assigncomponentdialog.ui |7 cui/uiconfig/ui/autocorrectdialog.ui |6 cui/uiconfig/ui/borderareatransparencydialog.ui |4 cui/uiconfig/ui/borderbackgrounddialog.ui|5 cui/uiconfig/ui/borderpage.ui| 106 +- cui/uiconfig/ui/breaknumberoption.ui | 28 - cui/uiconfig/ui/calloutdialog.ui |6 cui/uiconfig/ui/calloutpage.ui | 58 --- cui/uiconfig/ui/cellalignment.ui | 225 +--- cui/uiconfig/ui/charnamepage.ui | 105 + cui/uiconfig/ui/colorconfigwin.ui| 290 cui/uiconfig/ui/colorpage.ui | 99 - cui/uiconfig/ui/colorpickerdialog.ui |1 cui/uiconfig/ui/connectortabpage.ui | 51 -- cui/uiconfig/ui/croppage.ui | 83 cui/uiconfig/ui/cuiimapdlg.ui| 16 cui/uiconfig/ui/customizedialog.ui |6 cui/uiconfig/ui/databaselinkdialog.ui| 25 - cui/uiconfig/ui/dimensionlinestabpage.ui | 42 -- cui/uiconfig/ui/distributiondialog.ui|6 cui/uiconfig/ui/editmodulesdialog.ui | 17 cui/uiconfig/ui/embossdialog.ui | 15 cui/uiconfig/ui/eventassigndialog.ui |6 cui/uiconfig/ui/eventsconfigpage.ui | 32 - cui/uiconfig/ui/fmsearchdialog.ui| 74 cui/uiconfig/ui/formatcellsdialog.ui |5 cui/uiconfig/ui/formatnumberdialog.ui|5 cui/uiconfig/ui/galleryfilespage.ui | 26 - cui/uiconfig/ui/gallerysearchprogress.ui |8 cui/uiconfig/ui/gallerythemedialog.ui|5 cui/uiconfig/ui/gallerythemeiddialog.ui |6 cui/uiconfig/ui/gallerytitledialog.ui| 19 - cui/uiconfig/ui/galleryupdateprogress.ui |5 cui/uiconfig/ui/gradientpage.ui | 89 + cui/uiconfig/ui/hangulhanjaadddialog.ui |6 cui/uiconfig/ui/hangulhanjaconversiondialog.ui | 15 cui/uiconfig/ui/hangulhanjaeditdictdialog.ui | 10 cui/uiconfig/ui/hangulhanjaoptdialog.ui | 18 - cui/uiconfig/ui/hatchpage.ui | 43 -- cui/uiconfig/ui/hyperlinkdialog.ui |6 cui/uiconfig/ui/hyperlinkdocpage.ui | 58 --- cui/uiconfig/ui/hyperlinkinternetpage.ui | 64 --- cui/uiconfig/ui/hyperlinkmailpage.ui | 58 --- cui/uiconfig/ui/hyperlinkmarkdialog.ui |2 cui/uiconfig/ui/hyperlinknewdocpage.ui | 56 --- cui/uiconfig/ui/hyphenate.ui | 37 -- cui/uiconfig/ui/iconchangedialog.ui | 11 cui/uiconfig/ui/iconselectordialog.ui|4 cui/uiconfig/ui/insertfloatingframe.ui | 44 -- cui/uiconfig/ui/insertoleobject.ui | 12 cui/uiconfig/ui/insertplugin.ui | 10 cui/uiconfig/ui/insertrowcolumn.ui | 15 cui/uiconfig/ui/javaclasspathdialog.ui |5 cui/uiconfig/ui/javastartparametersdialog.ui | 20 - cui/uiconfig/ui/linedialog.ui|5 cui/uiconfig/ui/macroassigndialog.ui |6 cui/uiconfig/ui/mosaicdialog.ui | 28 - cui/uiconfig/ui/movemenu.ui | 34 + cui/uiconfig/ui/multipathdialog.ui | 16 cui/uiconfig/ui/newtoolbardialog.ui | 19 - cui/uiconfig/ui/numberingformatpage.ui | 193 -- cui/uiconfig/ui/numberingoptionspage.ui | 334 +++ cui/uiconfig/ui/numberingpositionpage.ui | 69 --- cui/uiconfig/ui/objectnamedialog.ui |7 cui/uiconfig/ui/objecttitledescdialog.ui | 22 - cui/uiconfig/ui/optadvancedpage.ui | 31 - cui/uiconfig/ui/optappearancepage.ui | 27 - cui/uiconfig/ui/optasianpage.ui | 25 - cui/uiconfig/ui/optbasicidepage.ui | 23 - cui/uiconfig/ui/optctlpage.ui| 27 - cui/uiconfig/ui/optemailpage.ui | 14 cui/uiconfig/ui/optfontspage.ui | 45 --
[Bug 78826] UI: inconsistent fields labeling. Text: or Text?
https://bugs.freedesktop.org/show_bug.cgi?id=78826 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a51aa75d92eadaa613192a1773e0b78b0df74527 fdo#78826 HIG: missing colons and capitalization in cui, filter It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dev-tools.git: test-bugzilla-files/execute.sh test-bugzilla-files/new-control.py test-bugzilla-files/test-bugzilla-files.py
test-bugzilla-files/execute.sh |2
test-bugzilla-files/new-control.py | 77 +
test-bugzilla-files/test-bugzilla-files.py | 22 +---
3 files changed, 63 insertions(+), 38 deletions(-)
New commits:
commit 77eb5fd822f0827e288e26940eb867858d6a6f7b
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 1 22:22:57 2014 +0100
move from dir based testing to task list based
Instead of going through a whole directory in one task split the whole
into 100 file tasks. This should make sure that all cores are always
doing some work.
diff --git a/test-bugzilla-files/execute.sh b/test-bugzilla-files/execute.sh
index 9203a7e..e2c6076 100755
--- a/test-bugzilla-files/execute.sh
+++ b/test-bugzilla-files/execute.sh
@@ -1,4 +1,4 @@
mkdir /srv/crashtestdata/control/$1
cd /srv/crashtestdata/control/$1
-TMPDIR=/srv/crashtestdata/tmpdir /home/buildslave/build/instdir/program/python
/home/buildslave/source/dev-tools/test-bugzilla-files/test-bugzilla-files.py
--soffice=path:/home/buildslave/build/instdir/program/soffice
--userdir=file:///home/buildslave/.config/libreoffice_$1/4
/home/buildslave/source/bugdocs3/$1 21 | tee /srv/crashtestdata/console_$i.log
+TMPDIR=/srv/crashtestdata/tmpdir /home/buildslave/build/instdir/program/python
/home/buildslave/source/dev-tools/test-bugzilla-files/test-bugzilla-files.py
--soffice=path:/home/buildslave/build/instdir/program/soffice
--userdir=file:///home/buildslave/.config/libreoffice_$1/4 $1 21 | tee
/srv/crashtestdata/console_$i.log
rm core*
diff --git a/test-bugzilla-files/new-control.py
b/test-bugzilla-files/new-control.py
index 25617a7..c27cb5f 100644
--- a/test-bugzilla-files/new-control.py
+++ b/test-bugzilla-files/new-control.py
@@ -21,26 +21,63 @@ import os.path
import concurrent.futures
import time
import subprocess
+import getopt
+import sys
-def get_directories():
-d='.'
-directories = [o for o in os.listdir(d) if
os.path.isdir(os.path.join(d,o))]
-return directories
+def partition(l, n):
+for i in range(0, len(l), n):
+yield l[i:i+n]
+
+def get_tasks(directory, files_per_task):
+flist = [os.path.join(dirpath, f) for dirpath, dirnames, fnames in
os.walk(directory) for f in fnames]
+
+partitioned_list = list(partition(flist, files_per_task))
+task_files = []
+i = 0
+for list_item in partitioned_list:
+filename = task + str(i)
+task_file = open(filename, w)
+for item in list_item:
+task_file.write(%s\n % item)
+task_files.append(filename)
+i += 1
+return task_files
+
+def execute_task(task_file):
+# subprocess.call(./execute.sh + task_file, shell=True)
+time.sleep(1)
+
+def usage():
+message = usage: {program} [option] dir
+ - h | --help: print usage information
+
+ 'dir' is the path to the directory with the test files
+print(message.format(program = os.path.basename(sys.argv[0])))
+
+if __name__ == __main__:
+opts, args = getopt.getopt(sys.argv[1:], hd:, [help, directory=])
+print(args)
+print(opts)
+if -h in opts or --help in opts:
+usage()
+sys.exit()
+
+for opt, arg in opts:
+if opt in (-d, --directory):
+directory = arg
-def execute_task(directory):
-print(Yeah)
print(directory)
-subprocess.call(./execute.sh + directory, shell=True)
-time.sleep(10)
-return
-
-with concurrent.futures.ThreadPoolExecutor(max_workers=5) as executor:
-future_to_task = {executor.submit(execute_task, dirs): dirs for dirs in
get_directories()}
-for future in concurrent.futures.as_completed(future_to_task):
-task = future_to_task[future]
-try:
-future.result()
-except Exception as exc:
-print('%r generated an exception: %s' % (task, exc))
-else:
-print('%r successfully passed' % (task))
+if not os.path.isdir(directory):
+sys.exit(1)
+
+task_size = 100
+with concurrent.futures.ThreadPoolExecutor(max_workers=5) as executor:
+future_to_task = {executor.submit(execute_task, task_file): task_file
for task_file in get_tasks(directory, task_size)}
+for future in concurrent.futures.as_completed(future_to_task):
+task = future_to_task[future]
+try:
+future.result()
+except Exception as exc:
+print('%r generated an exception: %s' % (task, exc))
+else:
+print('%r successfully passed' % (task))
diff --git a/test-bugzilla-files/test-bugzilla-files.py
b/test-bugzilla-files/test-bugzilla-files.py
index 2bd907e..11cf41c 100644
--- a/test-bugzilla-files/test-bugzilla-files.py
+++ b/test-bugzilla-files/test-bugzilla-files.py
@@ -69,21 +69,9 @@ def partition(list, pred):
right.append(e)
return (left, right)
-def filelist(dir, suffix):
-if len(dir) == 0:
-raise
[Libreoffice-commits] core.git: svgio/inc svgio/source
svgio/inc/svgio/svgreader/svgstyleattributes.hxx | 13
svgio/inc/svgio/svgreader/svgtoken.hxx |1
svgio/source/svgreader/svgnode.cxx | 24 +++
svgio/source/svgreader/svgstyleattributes.cxx| 24 +++
svgio/source/svgreader/svgtoken.cxx |2 +
5 files changed, 56 insertions(+), 8 deletions(-)
New commits:
commit 501f25e3291dd0ab38e3612de2fc160d953c1846
Author: Chr. Rossmanith chrrossman...@gmx.de
Date: Sat Nov 1 22:22:38 2014 +0100
SVG: handle visibility property
improve import of masking-path-08-b.svg of the W3C svg test suite when
using insert-media-image
Change-Id: Ib4d48165f982e394e2171ac82e6cc06911553904
Reviewed-on: https://gerrit.libreoffice.org/12168
Reviewed-by: Christina RoÃmanith chrrossman...@web.de
Tested-by: Christina RoÃmanith chrrossman...@web.de
diff --git a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
index ab40e9d..693772b 100644
--- a/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
+++ b/svgio/inc/svgio/svgreader/svgstyleattributes.hxx
@@ -153,6 +153,14 @@ namespace svgio
BaselineShift_Length
};
+enum Visibility
+{
+Visibility_visible,
+Visibility_hidden,
+Visibility_collapse,
+Visibility_inherit
+};
+
class SvgStyleAttributes
{
private:
@@ -185,6 +193,7 @@ namespace svgio
TextAnchor maTextAnchor;
SvgPaintmaColor;
SvgNumber maOpacity;
+Visibility maVisibility;
OUString maTitle;
OUString maDesc;
@@ -401,6 +410,10 @@ namespace svgio
SvgNumber getOpacity() const { return maOpacity; }
void setOpacity(const SvgNumber rOpacity = SvgNumber()) {
maOpacity = rOpacity; }
+/// Visibility
+Visibility getVisibility() const { return maVisibility; }
+void setVisibility(Visibility eVisibility) { maVisibility =
eVisibility; }
+
// Title content
const OUString getTitle() const { return maTitle; }
void setTitle(const OUString rNew) { maTitle = rNew; }
diff --git a/svgio/inc/svgio/svgreader/svgtoken.hxx
b/svgio/inc/svgio/svgreader/svgtoken.hxx
index 87d23b6..8d60847 100644
--- a/svgio/inc/svgio/svgreader/svgtoken.hxx
+++ b/svgio/inc/svgio/svgreader/svgtoken.hxx
@@ -102,6 +102,7 @@ namespace svgio
SVGTokenPatternContentUnits,
SVGTokenPatternTransform,
SVGTokenOpacity,
+SVGTokenVisibility,
SVGTokenTitle,
SVGTokenDesc,
diff --git a/svgio/source/svgreader/svgnode.cxx
b/svgio/source/svgreader/svgnode.cxx
index 723ddbf..d084868 100644
--- a/svgio/source/svgreader/svgnode.cxx
+++ b/svgio/source/svgreader/svgnode.cxx
@@ -496,6 +496,12 @@ namespace svgio
return;
}
+const SvgStyleAttributes* pStyles = getSvgStyleAttributes();
+if(pStyles (Visibility_hidden == pStyles-getVisibility() ||
Visibility_collapse == pStyles-getVisibility()))
+{
+return;
+}
+
if(!bReferenced)
{
if(SVGTokenDefs == getType() ||
@@ -534,16 +540,20 @@ namespace svgio
if(pCandidate Display_none != pCandidate-getDisplay())
{
-drawinglayer::primitive2d::Primitive2DSequence
aNewTarget;
+const SvgStyleAttributes* pChildStyles =
pCandidate-getSvgStyleAttributes();
+if(pChildStyles Visibility_hidden !=
pChildStyles-getVisibility())
+{
+drawinglayer::primitive2d::Primitive2DSequence
aNewTarget;
-pCandidate-decomposeSvgNode(aNewTarget, bReferenced);
+pCandidate-decomposeSvgNode(aNewTarget,
bReferenced);
-if(aNewTarget.hasElements())
-{
-
drawinglayer::primitive2d::appendPrimitive2DSequenceToPrimitive2DSequence(rTarget,
aNewTarget);
+if(aNewTarget.hasElements())
+{
+
drawinglayer::primitive2d::appendPrimitive2DSequenceToPrimitive2DSequence(rTarget,
aNewTarget);
+}
}
}
-else
+else if(!pCandidate)
{
OSL_ENSURE(false, Null-Pointer in child node list
(!));
}
@@ -551,8 +561,6 @@ namespace svgio
if(rTarget.hasElements())
{
-
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/rtfimport/data/fdo82512.rtf | 10 ++
sw/qa/extras/rtfimport/rtfimport.cxx |6 ++
writerfilter/source/dmapper/DomainMapper.cxx |8
3 files changed, 24 insertions(+)
New commits:
commit dcb37dcebcde6188eb58ef7d8d34d08fea4badb8
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Nov 1 22:00:46 2014 +0100
fdo#82512 RTF import: fix position of column break
Change-Id: Ib0f39c4af7cc32d0f4491f13ea207d90a449a47d
diff --git a/sw/qa/extras/rtfimport/data/fdo82512.rtf
b/sw/qa/extras/rtfimport/data/fdo82512.rtf
new file mode 100644
index 000..925cc4b
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo82512.rtf
@@ -0,0 +1,10 @@
+{\rtf1\ansi\deff0
+\cols2\colsx709
+\pard\plain
+{First col\par}{
+\column
+\par
+\par
+Second col\par
+}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 90ae2ef..6639948 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -2007,6 +2007,12 @@ DECLARE_RTFIMPORT_TEST(testFdo82076, fdo82076.rtf)
CPPUNIT_ASSERT_EQUAL(OUString(Footnote),
getPropertyOUString(getRun(getParagraphOfText(1, xCell-getText()), 2),
TextPortionType));
}
+DECLARE_RTFIMPORT_TEST(testFdo82512, fdo82512.rtf)
+{
+// This was style::BreakType_NONE, column break was before the 3rd
paragraph, not before the 2nd one.
+CPPUNIT_ASSERT_EQUAL(style::BreakType_COLUMN_BEFORE,
getPropertystyle::BreakType(getParagraph(2), BreakType));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index a06935d..1491440 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2798,8 +2798,16 @@ void DomainMapper::lcl_text(const sal_uInt8 * data_,
size_t len)
m_pImpl-getTableManager().text(data_, len);
return;
case 0x0d:
+{
+PropertyMapPtr pContext =
m_pImpl-GetTopContextOfType(CONTEXT_PARAGRAPH);
+if (pContext m_pImpl-isBreakDeferred(COLUMN_BREAK))
+{
+pContext-Insert(PROP_BREAK_TYPE,
uno::makeAny(style::BreakType_COLUMN_BEFORE));
+m_pImpl-clearDeferredBreak(COLUMN_BREAK);
+}
m_pImpl-finishParagraph(m_pImpl-GetTopContextOfType(CONTEXT_PARAGRAPH));
return;
+}
case 0x13:
m_pImpl-PushFieldContext();
return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/sectfrm.cxx | 14 -- 1 file changed, 14 deletions(-) New commits: commit 86725e3808c778e2d7bc11cbc6c02051ffbd5c5e Author: Miklos Vajna vmik...@collabora.co.uk Date: Sat Nov 1 20:45:16 2014 +0100 sw: unused includes in sectfrm Change-Id: I59c33d25361c79e77994647b978915785cc650ee diff --git a/sw/source/core/layout/sectfrm.cxx b/sw/source/core/layout/sectfrm.cxx index e17ce8a..0350cc6 100644 --- a/sw/source/core/layout/sectfrm.cxx +++ b/sw/source/core/layout/sectfrm.cxx @@ -17,40 +17,26 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include svl/smplhint.hxx #include svl/itemiter.hxx -#include hints.hxx #include txtftn.hxx #include fmtftn.hxx #include fmtclbl.hxx #include sectfrm.hxx #include section.hxx -#include frmtool.hxx -#include doc.hxx #include IDocumentSettingAccess.hxx -#include cntfrm.hxx #include rootfrm.hxx #include pagefrm.hxx -#include fmtpdsc.hxx -#include fmtcntnt.hxx -#include ndindex.hxx -#include ftnidx.hxx #include txtfrm.hxx #include fmtclds.hxx #include colfrm.hxx #include tabfrm.hxx -#include flyfrm.hxx #include ftnfrm.hxx #include layouter.hxx #include dbg_lay.hxx -#include viewsh.hxx #include viewopt.hxx #include viewimp.hxx -#include editeng/ulspitem.hxx -#include editeng/lrspitem.hxx #include editeng/brushitem.hxx #include fmtftntx.hxx -#include dflyobj.hxx #include flyfrms.hxx #include sortedobjs.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/tools include/vcl tools/Library_tl.mk tools/source vcl/source
include/tools/gen.hxx |5 ++
include/vcl/outdev.hxx |4 --
tools/Library_tl.mk|1
tools/source/generic/point.cxx | 79 +
vcl/source/outdev/font.cxx | 15 ++-
vcl/source/outdev/outdev.cxx | 53 ---
vcl/source/outdev/text.cxx |6 ++-
vcl/source/outdev/textline.cxx | 17 ++--
8 files changed, 112 insertions(+), 68 deletions(-)
New commits:
commit 06bde51ced10e9d2997157b91c85d80100b0dafb
Author: Chris Sherlock chris.sherloc...@gmail.com
Date: Sat Nov 1 21:33:09 2014 +1100
tools vcl: move OutputDevice::ImplRotatePos() to Point::RotateAbout()
OutputDevice has a private function that rotates a point around another
point. However, there is no real reason why OutputDevice should be
responsible for this - it's really the responsibility of the Point
class in the tools module. Therefore, I've moved this functionality out
of OutputDevice and into Point, but I've renamed it from the rather
confusing name ImplRotatePos to RotateAround, which is what it
actually does.
Change-Id: If12fb40a7b476653224d4edfc01887bc91a80c7d
Reviewed-on: https://gerrit.libreoffice.org/12171
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Tested-by: Chris Sherlock chris.sherloc...@gmail.com
diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx
index af046df..e8ad8fe 100644
--- a/include/tools/gen.hxx
+++ b/include/tools/gen.hxx
@@ -78,7 +78,7 @@ inline bool Pair::operator != ( const Pair rPair ) const
// Point
-class SAL_WARN_UNUSED Point : public Pair
+class SAL_DLLPUBLIC_EXPORT SAL_WARN_UNUSED Point : public Pair
{
public:
Point();
@@ -96,6 +96,9 @@ public:
boolIsLeft( const Point rPoint ) const;
boolIsRight( const Point rPoint ) const;
+voidRotateAround( long rX, long rY, short nOrientation )
const;
+
+
Point operator += ( const Point rPoint );
Point operator -= ( const Point rPoint );
Point operator *= ( const long nVal );
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index c17fd9e..0a775db 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -478,10 +478,6 @@ public:
voidSetExtOutDevData( vcl::ExtOutDevData*
pExtOutDevData ) { mpExtOutDevData = pExtOutDevData; }
vcl::ExtOutDevData* GetExtOutDevData() const { return
mpExtOutDevData; }
-private:
-
-SAL_DLLPRIVATE void ImplRotatePos( long nOriginX, long nOriginY,
long rX, long rY,
- short nOrientation ) const;
///@}
diff --git a/tools/Library_tl.mk b/tools/Library_tl.mk
index 856471b..d399548 100644
--- a/tools/Library_tl.mk
+++ b/tools/Library_tl.mk
@@ -59,6 +59,7 @@ $(eval $(call gb_Library_add_exception_objects,tl,\
tools/source/generic/gen \
tools/source/generic/line \
tools/source/generic/link \
+tools/source/generic/point \
tools/source/generic/poly \
tools/source/generic/poly2 \
tools/source/generic/svborder \
diff --git a/tools/source/generic/point.cxx b/tools/source/generic/point.cxx
new file mode 100644
index 000..7feaef6
--- /dev/null
+++ b/tools/source/generic/point.cxx
@@ -0,0 +1,79 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the License); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include numeric
+
+#include tools/gen.hxx
+#include basegfx/numeric/ftools.hxx
+
+void Point::RotateAround( long rX, long rY,
+ short nOrientation ) const
+{
+const long nOriginX = X();
+const long nOriginY = Y();
+
+if ( (nOrientation = 0) !(nOrientation % 900) )
+{
+if ( (nOrientation = 3600) )
+nOrientation %= 3600;
+
+if ( nOrientation )
+{
+rX -= nOriginX;
+rY -= nOriginY;
+
+if ( nOrientation == 900 )
+{
+long nTemp = rX;
+rX = rY;
+rY = -nTemp;
+}
+else if (
Re: Java problem when running CppunitTest_dbaccess_dialog_save on OS X 10.10 with Oracle JDK 1.8
Not yet solved. No Java runtime present, requesting install. On Sat, Nov 1, 2014 at 8:41 PM, Robert Antoni Buj i Gelonch robert@gmail.com wrote: I think that the following command can solve the issue with Oracle's JDKs. sudo curl -o /Library/Java/Extensions/javaee-api-7.0.jar -O#L http://central.maven.org/maven2/javax/javaee-api/7.0/javaee-api-7.0.jar Regards, Robert On Sat, Nov 1, 2014 at 8:19 PM, Robert Antoni Buj i Gelonch robert@gmail.com wrote: HSQLDB requires some J2EE libs that aren't bundled within a standard JDK (javax.servlet). source files: ./workdir/UnpackedTarball/hsqldb/src/hsqlServlet.java ./workdir/UnpackedTarball/hsqldb/src/org/hsqldb/Servlet.java build: ./workdir/UnpackedTarball/hsqldb/classes/hsqlServlet.class ./workdir/UnpackedTarball/hsqldb/classes/org/hsqldb/Servlet.class Regards, Robert On Tue, Oct 28, 2014 at 11:22 AM, Stephan Bergmann sberg...@redhat.com wrote: On 10/20/2014 01:48 PM, Alexander Thurgood wrote: I encountrered this very same problem, and solved it by installing the appropriate JavaforOSX2014-001.dmg, which allowed my build to complete the debug tests, but this apparently also has consequences for use of third party jdbc drivers that rely on JDK 1.8 In how far? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- http://about.me/rbuj -- http://about.me/rbuj -- http://about.me/rbuj ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 2 commits - chart2/source include/vcl vcl/source vcl/unx
chart2/source/view/main/GL3DRenderer.cxx |3 +++
include/vcl/opengl/OpenGLHelper.hxx |5 +
vcl/source/opengl/OpenGLHelper.cxx |5 +
vcl/unx/generic/gdi/salgdi.cxx |5 -
4 files changed, 17 insertions(+), 1 deletion(-)
New commits:
commit b0350404832a992a1d1db5075821a9a50b31d3fb
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date: Sun Nov 2 00:12:21 2014 +0100
add possibility to check if system can run OpenGL VCL backend
Change-Id: If3475c6b2c76e4634f16053928b43a94c83be6ee
diff --git a/include/vcl/opengl/OpenGLHelper.hxx
b/include/vcl/opengl/OpenGLHelper.hxx
index 8c04e32..be2dfda 100644
--- a/include/vcl/opengl/OpenGLHelper.hxx
+++ b/include/vcl/opengl/OpenGLHelper.hxx
@@ -46,6 +46,11 @@ public:
static float getGLVersion();
static void checkGLError(const char* aFile, size_t nLine);
+
+/**
+ * checks if the system supports all features that are necessary for the
OpenGL VCL support
+ */
+static bool supportsVCLOpenGL();
};
#define CHECK_GL_ERROR() OpenGLHelper::checkGLError(__FILE__, __LINE__)
diff --git a/vcl/source/opengl/OpenGLHelper.cxx
b/vcl/source/opengl/OpenGLHelper.cxx
index c94e290..9811b99 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -358,4 +358,9 @@ void OpenGLHelper::checkGLError(const char* pFile, size_t
nLine)
}
}
+bool OpenGLHelper::supportsVCLOpenGL()
+{
+return true;
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx
index a87eb33..c5dd0be 100644
--- a/vcl/unx/generic/gdi/salgdi.cxx
+++ b/vcl/unx/generic/gdi/salgdi.cxx
@@ -60,6 +60,8 @@
#include officecfg/Office/Common.hxx
+#include vcl/opengl/OpenGLHelper.hxx
+
X11SalGraphics::X11SalGraphics():
m_pFrame(NULL),
m_pVDev(NULL),
@@ -79,7 +81,8 @@ X11SalGraphics::X11SalGraphics():
bPrinter_(false),
bVirDev_(false)
{
-bool bUseOpenGL = officecfg::Office::Common::VCL::UseOpenGL::get();
+static bool bOpenGLPossible = OpenGLHelper::supportsVCLOpenGL();
+bool bUseOpenGL = bOpenGLPossible ?
officecfg::Office::Common::VCL::UseOpenGL::get() : false;
if (bUseOpenGL)
mpImpl.reset(new OpenGLSalGraphicsImpl());
else
commit 4f65d229da71e055e10cd7063b96e1bf5a58d89a
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date: Sat Nov 1 16:05:14 2014 +0100
prevent crash with empty chart scene
Change-Id: I9eb8adf887532c62af6efeac5b0eeec1419b7252
diff --git a/chart2/source/view/main/GL3DRenderer.cxx
b/chart2/source/view/main/GL3DRenderer.cxx
index 6b0004f..b2dfc6f 100755
--- a/chart2/source/view/main/GL3DRenderer.cxx
+++ b/chart2/source/view/main/GL3DRenderer.cxx
@@ -2487,6 +2487,9 @@ glm::mat4 OpenGL3DRenderer::GetGlobalScaleMatrix()
void OpenGL3DRenderer::RenderBatchBars(bool bNewScene)
{
+if (m_BarSurface[0].modelMatrixList.empty())
+return;
+
if(bNewScene)
{
GetBatchBarsInfo();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - sc/workben
sc/workben/opencl/platform_detect.cxx | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
New commits:
commit 1973029229012d5761a070a741f5dd2d7d79b23f
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Oct 31 01:33:02 2014 +0100
make that file platform independent
Change-Id: I65c056faaa95af3493b73a7403f199c8c826d724
diff --git a/sc/workben/opencl/platform_detect.cxx
b/sc/workben/opencl/platform_detect.cxx
index b0a9c61..ef45588 100644
--- a/sc/workben/opencl/platform_detect.cxx
+++ b/sc/workben/opencl/platform_detect.cxx
@@ -7,13 +7,17 @@
using namespace std;
+#ifdef WIN32
+#define OPENCL_DLL_NAME OpenCL.dll
+#elif defined(MACOSX)
+#define OPENCL_DLL_NAME NULL
+#else
+#define OPENCL_DLL_NAME libOpenCL.so
+#endif
+
int main()
{
-const char* dllname = libOpenCL.so; // on Linux
-// const char* dllname = OpenCL.dll; // from GPU driver.
-// const char* dllname = amdocl.dll; // from AMD SDK
-// const char* dllname = intelocl.dll; // from Intel SDK
-int status = clewInit(dllname);
+int status = clewInit(OPENCL_DLL_NAME);
if (status 0)
{
cout failed to load endl;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 4 commits - vcl/inc vcl/source vcl/win
vcl/inc/win/salgdi.h| 29 +
vcl/source/opengl/OpenGLContext.cxx |6 +++---
vcl/win/source/gdi/gdiimpl.cxx | 34 +-
vcl/win/source/gdi/salgdi.cxx | 34 --
vcl/win/source/gdi/salprn.cxx |7 +--
vcl/win/source/gdi/salvd.cxx|9 ++---
vcl/win/source/window/salframe.cxx | 18 --
7 files changed, 80 insertions(+), 57 deletions(-)
New commits:
commit fbc8db04ad4515e609ca497a47bddae1387885f7
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 02:39:36 2014 +0100
a little bit more sanity
Change-Id: I080984c5faaa8cf349ba37ffdb116b6d8d016552
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 57b1381..363ab0f 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -152,6 +152,7 @@ private:
boolmbVirDev : 1; // is VirDev
boolmbWindow : 1; // is Window
boolmbScreen : 1; // is Screen compatible
+HWNDmhWnd; // Window-Handle, when
Window-Graphics
public:
HDC getHDC() const { return mhLocalDC; }
@@ -166,7 +167,6 @@ public:
};
public:
-HWNDmhWnd; // Window-Handle, when
Window-Graphics
HWND gethWnd();
HFONT mhFonts[ MAX_FALLBACK ];// Font + Fallbacks
@@ -194,7 +194,7 @@ public:
HFONT ImplDoSetFont( FontSelectPattern* i_pFont, float
o_rFontScale, HFONT o_rOldFont );
public:
-explicit WinSalGraphics(WinSalGraphics::Type eType, bool bScreen);
+explicit WinSalGraphics(WinSalGraphics::Type eType, bool bScreen, HWND
hWnd);
virtual ~WinSalGraphics();
bool isPrinter() const;
@@ -202,6 +202,8 @@ public:
bool isWindow() const;
bool isScreen() const;
+void setHWND(HWND hWnd);
+
protected:
virtual boolsetClipRegion( const vcl::Region );
// draw -- LineColor and FillColor and RasterOp and ClipRegion
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index c9f9cf4..af16d90 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -554,12 +554,13 @@ void ImplClearHDCCache( SalData* pData )
}
}
-WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType, bool bScreen):
+WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType, bool bScreen, HWND
hWnd):
mpImpl(new WinSalGraphicsImpl(*this)),
mhLocalDC(0),
mbPrinter(eType == WinSalGraphics::PRINTER),
mbVirDev(eType == WinSalGraphics::VIRTUAL_DEVICE),
mbWindow(eType == WinSalGraphics::WINDOW),
+mhWnd(hWnd),
mbScreen(bScreen),
mfCurrentFontScale(1.0),
mhRegion(0),
@@ -638,6 +639,11 @@ HWND WinSalGraphics::gethWnd()
return mhWnd;
}
+void WinSalGraphics::setHWND(HWND hWnd)
+{
+mhWnd = hWnd;
+}
+
void WinSalGraphics::GetResolution( sal_Int32 rDPIX, sal_Int32 rDPIY )
{
rDPIX = GetDeviceCaps( getHDC(), LOGPIXELSX );
diff --git a/vcl/win/source/gdi/salprn.cxx b/vcl/win/source/gdi/salprn.cxx
index ffcc7d0..b992554 100644
--- a/vcl/win/source/gdi/salprn.cxx
+++ b/vcl/win/source/gdi/salprn.cxx
@@ -1045,10 +1045,9 @@ static HDC ImplCreateSalPrnIC( WinSalInfoPrinter*
pPrinter, ImplJobSetup* pSetup
static WinSalGraphics* ImplCreateSalPrnGraphics( HDC hDC )
{
-WinSalGraphics* pGraphics = new WinSalGraphics(WinSalGraphics::PRINTER,
false);
+WinSalGraphics* pGraphics = new WinSalGraphics(WinSalGraphics::PRINTER,
false, 0);
pGraphics-SetLayout( 0 );
pGraphics-setHDC(hDC);
-pGraphics-mhWnd= 0;
ImplSalInitGraphics( pGraphics );
return pGraphics;
}
diff --git a/vcl/win/source/gdi/salvd.cxx b/vcl/win/source/gdi/salvd.cxx
index a05de8d..820f12f 100644
--- a/vcl/win/source/gdi/salvd.cxx
+++ b/vcl/win/source/gdi/salvd.cxx
@@ -104,10 +104,9 @@ SalVirtualDevice* WinSalInstance::CreateVirtualDevice(
SalGraphics* pSGraphics,
{
WinSalVirtualDevice*pVDev = new WinSalVirtualDevice;
SalData*pSalData = GetSalData();
-WinSalGraphics* pVirGraphics = new
WinSalGraphics(WinSalGraphics::VIRTUAL_DEVICE, pGraphics-isScreen());
+WinSalGraphics* pVirGraphics = new
WinSalGraphics(WinSalGraphics::VIRTUAL_DEVICE, pGraphics-isScreen(), 0);
pVirGraphics-SetLayout( 0 ); // by default no! mirroring for
VirtualDevices, can be enabled with EnableRTL()
pVirGraphics-setHDC(hDC);
-pVirGraphics-mhWnd= 0;
if ( pSalData-mhDitherPal pVirGraphics-isScreen() )
{
pVirGraphics-mhDefPal = SelectPalette( hDC,
pSalData-mhDitherPal, TRUE );
diff --git a/vcl/win/source/window/salframe.cxx
b/vcl/win/source/window/salframe.cxx
index 309dd5a..dde2845 100644
--- a/vcl/win/source/window/salframe.cxx
+++
Re: 10.10 tinderbox builds crashes on opening any file
It's an issue related with LibreOfficePython.framework and install_name_tool: 1 - create the folder where LibreOfficePython.framework was installed in the tinderbox: $: sudo mkdir -p /Volumes/Master/lo/core/workdir/UnpackedTarball/python3/python-inst/@__OOO 2 - create a symbolic link to LibreOfficePython.framework: $: sudo ln -s /Applications/LibreOfficeDev.app/Contents/Frameworks/LibreOfficePython.framework /Volumes/Master/lo/core/workdir/UnpackedTarball/python3/python-inst/@__OOO/LibreOfficePython.framework 3 - Launch LibreOffice: $: /Applications/LibreOfficeDev.app/Contents/MacOS/soffice Regards, Robert On Sat, Nov 1, 2014 at 10:40 AM, Robert Antoni Buj i Gelonch wrote: Doing a clean build seems that doesn't solve the issue, so I'm going to install the development environment from scratch. On Fri, Oct 31, 2014 at 11:16 AM, Christian Lohmaier wrote: Hi Robert, there have been reports on IRC that the daily builds of your tinderbox (@64) crashes when opening any file. Those crashes don't occur with the daily builds from my bot (@49), that also compiles on Mac OSX 10.10 (although with the default min-version. As your bot does incremental builds: could you try a make clean to see whether the problem is caused by some incompatible changes that weren't picked up properly by the incremental build? The user who reported it often hangs out in the #libreoffice-qa channel (nich steve-_-2) Thanks a lot, ciao Christian -- http://about.me/rbuj -- http://about.me/rbuj ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 2 commits - vcl/inc vcl/source vcl/win
vcl/inc/win/salgdi.h| 43 +++--
vcl/source/opengl/OpenGLContext.cxx |2 -
vcl/win/source/gdi/salgdi.cxx | 47 ++--
vcl/win/source/gdi/salprn.cxx | 14
vcl/win/source/gdi/salvd.cxx| 10 +++---
vcl/win/source/window/salframe.cxx | 60 ++--
6 files changed, 100 insertions(+), 76 deletions(-)
New commits:
commit 33e9890625c630148a8eb9fa08563812b5302bde
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 03:31:00 2014 +0100
at least some sanity for WinSalGraphics
we no longer invite everyone to change our member variables.
This was obviously written by a C programmer and needs further refactoring.
Change-Id: I896576a5abc24e8d03787d30e6ba6c11b0bf84c6
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 363ab0f..9392cc5 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -144,6 +144,8 @@ public:
class WinSalGraphics : public SalGraphics
{
+friend class WinSalGraphicsImpl;
+friend class ScopedFont;
private:
boost::scoped_ptrSalGraphicsImpl mpImpl;
@@ -154,21 +156,6 @@ private:
boolmbScreen : 1; // is Screen compatible
HWNDmhWnd; // Window-Handle, when
Window-Graphics
-public:
-HDC getHDC() const { return mhLocalDC; }
-void setHDC(HDC aNew) { mhLocalDC = aNew; }
-
-enum Type
-{
-PRINTER,
-VIRTUAL_DEVICE,
-WINDOW,
-SCREEN
-};
-
-public:
-
-HWND gethWnd();
HFONT mhFonts[ MAX_FALLBACK ];// Font + Fallbacks
const ImplWinFontData* mpWinFontData[ MAX_FALLBACK ]; // pointer to the
most recent font face
ImplWinFontEntry* mpWinFontEntry[ MAX_FALLBACK ]; // pointer to the
most recent font instance
@@ -191,6 +178,30 @@ public:
sal_uIntPtr mnFontKernPairCount;// Number of Kerning Pairs
of the current Font
int mnPenWidth; // Linienbreite
+public:
+HDC getHDC() const { return mhLocalDC; }
+void setHDC(HDC aNew) { mhLocalDC = aNew; }
+
+HPALETTE getDefPal() const;
+void setDefPal(HPALETTE hDefPal);
+
+HRGN getRegion() const;
+
+void InitGraphics();
+void DeInitGraphics();
+
+enum Type
+{
+PRINTER,
+VIRTUAL_DEVICE,
+WINDOW,
+SCREEN
+};
+
+public:
+
+HWND gethWnd();
+
HFONT ImplDoSetFont( FontSelectPattern* i_pFont, float
o_rFontScale, HFONT o_rOldFont );
public:
@@ -391,8 +402,6 @@ public:
};
// Init/Deinit Graphics
-voidImplSalInitGraphics( WinSalGraphics* );
-voidImplSalDeInitGraphics( WinSalGraphics* );
voidImplUpdateSysColorEntries();
int ImplIsSysColorEntry( SalColor nSalColor );
voidImplGetLogFontFromFontSelect( HDC, const FontSelectPattern*,
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index af16d90..4022d2d 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -464,34 +464,34 @@ void ImplUpdateSysColorEntries()
ImplInsertSysColorEntry( COLOR_INACTIVECAPTIONTEXT );
}
-void ImplSalInitGraphics( WinSalGraphics* pData )
+void WinSalGraphics::InitGraphics()
{
// calculate the minimal line width for the printer
-if ( pData-isPrinter() )
+if ( isPrinter() )
{
-int nDPIX = GetDeviceCaps( pData-getHDC(), LOGPIXELSX );
+int nDPIX = GetDeviceCaps( getHDC(), LOGPIXELSX );
if ( nDPIX = 300 )
-pData-mnPenWidth = 0;
+mnPenWidth = 0;
else
-pData-mnPenWidth = nDPIX/300;
+mnPenWidth = nDPIX/300;
}
-::SetTextAlign( pData-getHDC(), TA_BASELINE | TA_LEFT | TA_NOUPDATECP );
-::SetBkMode( pData-getHDC(), WIN32_TRANSPARENT );
-::SetROP2( pData-getHDC(), R2_COPYPEN );
+::SetTextAlign( getHDC(), TA_BASELINE | TA_LEFT | TA_NOUPDATECP );
+::SetBkMode( getHDC(), WIN32_TRANSPARENT );
+::SetROP2( getHDC(), R2_COPYPEN );
}
-void ImplSalDeInitGraphics( WinSalGraphics* pData )
+void WinSalGraphics::DeInitGraphics()
{
// clear clip region
-SelectClipRgn( pData-getHDC(), 0 );
+SelectClipRgn( getHDC(), 0 );
// select default objects
-if ( pData-mhDefPen )
-SelectPen( pData-getHDC(), pData-mhDefPen );
-if ( pData-mhDefBrush )
-SelectBrush( pData-getHDC(), pData-mhDefBrush );
-if ( pData-mhDefFont )
-SelectFont( pData-getHDC(), pData-mhDefFont );
+if ( mhDefPen )
+SelectPen( getHDC(), mhDefPen );
+if ( mhDefBrush )
+SelectBrush( getHDC(), mhDefBrush );
+if ( mhDefFont )
+SelectFont( getHDC(), mhDefFont );
}
HDC ImplGetCachedDC( sal_uLong nID, HBITMAP hBmp )
@@ -644,6 +644,21 @@ void WinSalGraphics::setHWND(HWND hWnd)
mhWnd = hWnd;
}
+HPALETTE WinSalGraphics::getDefPal()
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/outdev.hxx |2 +-
vcl/source/outdev/polyline.cxx |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit b167d1127e1579468a74c4414e7f4f33d9d24122
Author: Chris Sherlock chris.sherloc...@gmail.com
Date: Sun Nov 2 12:38:16 2014 +1100
vcl: rename OutputDevice::DrawPolyLineWithLineInfo() to drawPolyLine()
Change-Id: I145ebcfb92fc75f4558d3bf090093aef9e848136
Reviewed-on: https://gerrit.libreoffice.org/12188
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Tested-by: Chris Sherlock chris.sherloc...@gmail.com
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 0a775db..e96f47f 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -737,7 +737,7 @@ private:
// #i101491#
// Helper which holds the old line geometry creation and is extended to
use AA when
// switched on. Advantage is that line geometry is only temporarily used
for paint
-SAL_DLLPRIVATE void DrawPolyLineWithLineInfo(const Polygon rPoly,
const LineInfo rLineInfo);
+SAL_DLLPRIVATE void drawPolyLine(const Polygon rPoly, const
LineInfo rLineInfo);
// #i101491#
diff --git a/vcl/source/outdev/polyline.cxx b/vcl/source/outdev/polyline.cxx
index d0f2f61..89e27c7 100644
--- a/vcl/source/outdev/polyline.cxx
+++ b/vcl/source/outdev/polyline.cxx
@@ -126,7 +126,7 @@ void OutputDevice::DrawPolyLine( const Polygon rPoly,
const LineInfo rLineInfo
if ( mpMetaFile )
mpMetaFile-AddAction( new MetaPolyLineAction( rPoly, rLineInfo ) );
-DrawPolyLineWithLineInfo(rPoly, rLineInfo);
+drawPolyLine(rPoly, rLineInfo);
}
void OutputDevice::DrawPolyLine( const basegfx::B2DPolygon rB2DPolygon,
@@ -226,11 +226,11 @@ void OutputDevice::DrawPolyLine( const
basegfx::B2DPolygon rB2DPolygon,
if( fLineWidth != 0.0 )
aLineInfo.SetWidth( static_castlong(fLineWidth+0.5) );
-DrawPolyLineWithLineInfo( aToolsPolygon, aLineInfo );
+drawPolyLine( aToolsPolygon, aLineInfo );
}
}
-void OutputDevice::DrawPolyLineWithLineInfo(const Polygon rPoly, const
LineInfo rLineInfo)
+void OutputDevice::drawPolyLine(const Polygon rPoly, const LineInfo
rLineInfo)
{
sal_uInt16 nPoints(rPoly.GetSize());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/outdev.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1a178bd5a2249b49d61ccd8c5643aa6cb501f25b Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sun Nov 2 12:42:13 2014 +1100 vcl: include variable names in definition of OutputDevice::DrawPolyLine() Change-Id: Ifde547b0e883871a7d30e93adbe868faa74bef71 Reviewed-on: https://gerrit.libreoffice.org/12189 Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com Tested-by: Chris Sherlock chris.sherloc...@gmail.com diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index e96f47f..161342f 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -710,8 +710,8 @@ public: voidDrawPolyLine( const basegfx::B2DPolygon, double fLineWidth = 0.0, -basegfx::B2DLineJoin = basegfx::B2DLINEJOIN_ROUND, -css::drawing::LineCap = css::drawing::LineCap_BUTT); +basegfx::B2DLineJoin eLineJoin = basegfx::B2DLINEJOIN_ROUND, +css::drawing::LineCap eLineCap = css::drawing::LineCap_BUTT); /** Render the given polygon as a line stroke ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 4 commits - include/vcl vcl/source vcl/win
include/vcl/opengl/OpenGLContext.hxx |2 ++
vcl/source/opengl/OpenGLContext.cxx | 12 +++-
vcl/win/source/gdi/salgdi.cxx| 23 +--
3 files changed, 30 insertions(+), 7 deletions(-)
New commits:
commit 58fc3a6992332b8a6dba2fe7a077f421f27725c5
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 04:13:34 2014 +0100
forgot to remove the env variable based OpenGL setting
Change-Id: Ib4d0c4730eceac483bb179ce4e75fe555bba91fa
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 97f102e..9dfcf74 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -602,12 +602,6 @@ WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType,
bool bScreen, HWND hW
mpWinFontEntry[ i ] = NULL;
mfFontScale[ i ] = 1.0;
}
-
-static const char* pEnv = getenv(USE_OPENGL);
-if (pEnv)
-{
-mpImpl.reset(new OpenGLSalGraphicsImpl());
-}
}
WinSalGraphics::~WinSalGraphics()
commit 446d01bc8725d1a63d5234887d0468cdae49a496
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 04:12:59 2014 +0100
init the OpenGL context in the windows backend
Change-Id: Ic4fb491c95170639015a4452f355354ad01612bc
diff --git a/include/vcl/opengl/OpenGLContext.hxx
b/include/vcl/opengl/OpenGLContext.hxx
index 1692ba0..3a8ec9a 100644
--- a/include/vcl/opengl/OpenGLContext.hxx
+++ b/include/vcl/opengl/OpenGLContext.hxx
@@ -164,6 +164,8 @@ public:
// only in vcl's platform code
#if defined( UNX ) !defined MACOSX !defined IOS !defined ANDROID
bool init(Display* dpy, Window win, int screen);
+#elif defined( _WIN32 )
+bool init( HDC hDC, HWND hWnd );
#endif
void makeCurrent();
diff --git a/vcl/source/opengl/OpenGLContext.cxx
b/vcl/source/opengl/OpenGLContext.cxx
index b4c2cee..fe97372 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -513,6 +513,16 @@ bool OpenGLContext::init(Display* dpy, Window win, int
screen)
return ImplInit();
}
+#elif defined( _WIN32 )
+bool OpenGLContext::init(HDC hDC, HWND hWnd)
+{
+if (mbInitialized)
+return false;
+
+m_aGLWin.hDC = hDC;
+m_aGLWin.hWnd = hWnd;
+return ImplInit();
+}
#endif
bool OpenGLContext::ImplInit()
@@ -524,7 +534,6 @@ bool OpenGLContext::ImplInit()
m_aGLWin.Height = 0;
#if defined( WNT )
-m_aGLWin.hDC = GetDC(m_aGLWin.hWnd);
#elif defined( MACOSX )
#elif defined( IOS )
@@ -778,6 +787,7 @@ bool OpenGLContext::initWindow()
m_aGLWin.hWnd = sysData-hWnd;
}
+m_aGLWin.hDC = GetDC(m_aGLWin.hWnd);
return true;
}
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index e3a6fad..97f102e 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -483,6 +483,12 @@ void WinSalGraphics::InitGraphics()
::SetTextAlign( getHDC(), TA_BASELINE | TA_LEFT | TA_NOUPDATECP );
::SetBkMode( getHDC(), WIN32_TRANSPARENT );
::SetROP2( getHDC(), R2_COPYPEN );
+
+OpenGLSalGraphicsImpl* pImpl =
dynamic_castOpenGLSalGraphicsImpl*(mpImpl.get());
+if (pImpl)
+{
+pImpl-GetOpenGLContext().init(mhLocalDC, mhWnd);
+}
}
void WinSalGraphics::DeInitGraphics()
commit 789208bcd165f4d53447a602833a0bdfd7733e41
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 03:54:44 2014 +0100
don't try to use OpenGL for printing
Change-Id: I88403bcb5b1974deba237c497885d3793a29315c
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index b1a164e1..e3a6fad 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -583,7 +583,7 @@ WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType,
bool bScreen, HWND hW
mnPenWidth(GSL_PEN_WIDTH)
{
static bool bOpenGLPossible = OpenGLHelper::supportsVCLOpenGL();
-bool bUseOpenGL = bOpenGLPossible ?
officecfg::Office::Common::VCL::UseOpenGL::get() : false;
+bool bUseOpenGL = bOpenGLPossible !mbPrinter ?
officecfg::Office::Common::VCL::UseOpenGL::get() : false;
if (bUseOpenGL)
mpImpl.reset(new OpenGLSalGraphicsImpl());
else
commit d6a1c284cf14b4163204a243f2c52e40d8522a6a
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 2 03:50:57 2014 +0100
improve OpenGL rendering engine selection for Windows backend
Change-Id: Ibcf520aac1441e5ce86b83372061550f8957ab17
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 4022d2d..b1a164e1 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -36,6 +36,10 @@
#include gdiimpl.hxx
#include openglgdiimpl.hxx
+#include vcl/opengl/OpenGLHelper.hxx
+
+#include officecfg/Office/Common.hxx
+
#define DITHER_PAL_DELTA51
#define DITHER_PAL_STEPS6
#define DITHER_PAL_COUNT
[Libreoffice-commits] core.git: include/vcl
include/vcl/keycod.hxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit cd44a7288e09ffadd34d9fe1a71b7462429c5c65
Author: Noel Grandin n...@peralex.com
Date: Sun Nov 2 07:04:58 2014 +0200
revert the KeyCode asserts
there are two many places it appears to trigger in real use.
will have to fix those first.
Change-Id: I536b7925033d5337ba360db3c2cf40ec205157ca
Reviewed-on: https://gerrit.libreoffice.org/12193
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/include/vcl/keycod.hxx b/include/vcl/keycod.hxx
index 7e7ece3..a1da5d9 100644
--- a/include/vcl/keycod.hxx
+++ b/include/vcl/keycod.hxx
@@ -79,15 +79,12 @@ public:
inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, sal_uInt16 nModifier )
{
-assert(nKey = KEY_CODE);
-assert(nModifier == 0 || (nModifier = 0x1000 nModifier = 0xf000));
nKeyCodeAndModifiers = nKey | nModifier;
eFunc = KeyFuncType::DONTKNOW;
}
inline vcl::KeyCode::KeyCode( sal_uInt16 nKey, bool bShift, bool bMod1, bool
bMod2, bool bMod3 )
{
-assert(nKey = KEY_CODE);
nKeyCodeAndModifiers = nKey;
if( bShift )
nKeyCodeAndModifiers |= KEY_SHIFT;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: drawinglayer/source include/vcl vcl/source
drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |7 -
include/vcl/outdev.hxx |4 -
vcl/source/outdev/polyline.cxx | 61 ++--
3 files changed, 29 insertions(+), 43 deletions(-)
New commits:
commit 498a40f33908791c3b2409a1ccb4b3c81ea1e032
Author: Chris Sherlock chris.sherloc...@gmail.com
Date: Sun Nov 2 13:10:13 2014 +1100
vcl: Refactor OutputDevice::TryDrawPolyLineDirect()
I've renamed TryDrawPolyLineDirect() to DrawPolyLineDirect() and also
renamed TryDrawPolyLineDirectNoAACheck() to drawPolyLineDirectNoAACheck().
However, at the same time I feel that there is no need to call on
drawPolyLineDirectNoAACheck in most instances, because DrawPolyLineDirect
does an AA check before it can continue anyway. There is one instance where
constantly checking the AA check is inefficient because it's in a loop, in
that case then we call directly on drawPolyLineDirectNoAACheck, but this is
the only case it is necessary.
Change-Id: Ie0320bfc45b5c0e1ac6ce35912da3e2897af9429
Reviewed-on: https://gerrit.libreoffice.org/12190
Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com
Tested-by: Chris Sherlock chris.sherloc...@gmail.com
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index ddd6d33..d287739 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -173,10 +173,7 @@ namespace drawinglayer
aLocalPolygon.transform(maCurrentTransformation);
// try drawing; if it did not work, use standard fallback
-if(mpOutputDevice-TryDrawPolyLineDirect(
-aLocalPolygon,
-0.0,
-fTransparency))
+if(mpOutputDevice-DrawPolyLineDirect( aLocalPolygon, 0.0,
fTransparency))
{
return true;
}
@@ -258,7 +255,7 @@ namespace drawinglayer
{
bHasPoints = true;
-if(mpOutputDevice-TryDrawPolyLineDirect(
+if(mpOutputDevice-DrawPolyLineDirect(
aSingle,
fLineWidth,
fTransparency,
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 161342f..f505f04 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -726,7 +726,7 @@ public:
voidDrawPolyLine( const Polygon rPoly,
const LineInfo rLineInfo );
-boolTryDrawPolyLineDirect(
+boolDrawPolyLineDirect(
const basegfx::B2DPolygon rB2DPolygon,
double fLineWidth = 0.0,
double fTransparency = 0.0,
@@ -742,7 +742,7 @@ private:
// #i101491#
// Helper who tries to use SalGDI's DrawPolyLine direct and returns it's
bool. Contains no AA check.
-SAL_DLLPRIVATE bool TryDrawPolyLineDirectNoAACheck(
+SAL_DLLPRIVATE bool drawPolyLineDirectNoAACheck(
const basegfx::B2DPolygon rB2DPolygon,
double fLineWidth = 0.0,
double fTransparency = 0.0,
diff --git a/vcl/source/outdev/polyline.cxx b/vcl/source/outdev/polyline.cxx
index 89e27c7..d896bd1 100644
--- a/vcl/source/outdev/polyline.cxx
+++ b/vcl/source/outdev/polyline.cxx
@@ -52,33 +52,25 @@ void OutputDevice::DrawPolyLine( const Polygon rPoly )
if ( mbInitLineColor )
InitLineColor();
-const bool bTryAA( (mnAntialiasing ANTIALIASING_ENABLE_B2DDRAW)
- mpGraphics-supportsOperation(OutDevSupport_B2DDraw)
- ROP_OVERPAINT == GetRasterOp()
- IsLineColor());
-
// use b2dpolygon drawing if possible
-if(bTryAA)
+if ( DrawPolyLineDirect( rPoly.getB2DPolygon() ) )
{
-if ( TryDrawPolyLineDirectNoAACheck( rPoly.getB2DPolygon() ) )
-{
-basegfx::B2DPolygon aB2DPolyLine(rPoly.getB2DPolygon());
-const ::basegfx::B2DHomMatrix aTransform =
ImplGetDeviceTransformation();
-const ::basegfx::B2DVector aB2DLineWidth( 1.0, 1.0 );
+basegfx::B2DPolygon aB2DPolyLine(rPoly.getB2DPolygon());
+const ::basegfx::B2DHomMatrix aTransform =
ImplGetDeviceTransformation();
+const ::basegfx::B2DVector aB2DLineWidth( 1.0, 1.0 );
-// transform the polygon
-aB2DPolyLine.transform( aTransform );
+// transform the polygon
+aB2DPolyLine.transform( aTransform );
-if(mnAntialiasing ANTIALIASING_PIXELSNAPHAIRLINE)
-{
-aB2DPolyLine =
[Libreoffice-qa] www.viewdocsonline.com for MS files bug triaging
hi QA team, I've found this nice website http://www.viewdocsonline.com/ it allows to view .docx files and more MS file extensions without installing any software. PDF export is also possible. I think it can help LibO bug triaging of MS files for people (like me) without MS Office. bye, Tommy -- Using Opera's revolutionary email client: http://www.opera.com/mail/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] retest ping to UNCONFIRMED bugs older than 6 months
once 4.2.7 and 4.3.3 are now available, I think we could run the please retest automated message to UNCONFIRMED bugs older than 6 months. actually there's 94 out of them. see list: http://snipurl.com/29eckcc let's see what's the feedback ratio and then decide if doing the same on older NEW bugs (excluding easy hacks as already discussed in the mailing list( -- Using Opera's revolutionary email client: http://www.opera.com/mail/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 83005] Export problem from Writer using footnotes
https://bugs.freedesktop.org/show_bug.cgi?id=83005 --- Comment #8 from Dr. Matthias Weisser matthias.weis...@gmx.de --- In LO 4.4.0. master, I get: odt 26 pages, doc 57 pages. DOC saved in LO 4.4.0.: 26 pages. this sounds well. So, this may have been solved somewhere, and it remains to be seen whether this will be backported to 4.3.x. ok. Sorry, don't you send PDF, exported from original ODT, which should be fine? unfortunately some of those publishers were not happy getting pdf. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85722] Sidebar hides itself after unhiding it
https://bugs.freedesktop.org/show_bug.cgi?id=85722 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- Could you please give me a little bit more information about the different steps to reproduce it, because I am not sure how to reproduce it. I know with VIEW - SIDEBAR you can select whether the sidebar is shown or not and if the full sidebar is open you can close it with clicking on X so that you can only see the icons. But how can you hide the sidebar and where can I find the show button? Thank you very much in advance. (tested with LO 4.3.3.2, Win 8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78732] EDITING: Format Paintbrush instrument is inconvenient
https://bugs.freedesktop.org/show_bug.cgi?id=78732 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- Is my understanding correct that you would like to have also a shortcut for the FORMAT PAINTBRUSH function? But what I have not noticed before is this tooltip. What does (double click for multi-selection) mean. This tooltip is not clear/intuitive for me. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85707] NOT BETWEEN query not working (in query design view) when LibreOffice user interface is in Spanish
https://bugs.freedesktop.org/show_bug.cgi?id=85707 rob...@familiegrosskopf.de changed: What|Removed |Added CC|rob...@familiegrosskopf.de | --- Comment #7 from rob...@familiegrosskopf.de --- Seems you couldn't understand what I am writing. I have confirmed the bug, but you won't give the information I have asked for. So I remove myself from the CCList. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78732] EDITING: Format Paintbrush instrument is inconvenient
https://bugs.freedesktop.org/show_bug.cgi?id=78732 Alexander strog...@gmail.com changed: What|Removed |Added CC||strog...@gmail.com --- Comment #2 from Alexander strog...@gmail.com --- To Andy, I often need to set the same format to several separate text fragments. In MS Word I can copy a selected fragment's format (it's always copied when Format Paintbrush button is pressed) and then iterate in selecting some text fragment and applying the copied format options (MS Word uses Ctrl+Shift+V by default). It's so much logical I think. In LO I can do it only with mouse that is very inconvenient. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78732] EDITING: Format Paintbrush instrument is inconvenient
https://bugs.freedesktop.org/show_bug.cgi?id=78732 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from A (Andy) stgohi-lob...@yahoo.de --- Thanks for your fast reply, for me a shortcut seems to be a good idea. (tested with LO 4.3.3.2, Win8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85588] COLOR PICKER: More space between 'Custom Color' icon and label
https://bugs.freedesktop.org/show_bug.cgi?id=85588 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Priority|medium |low Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85693] TANGO: Save and save as icons
https://bugs.freedesktop.org/show_bug.cgi?id=85693 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Priority|medium |low Severity|normal |minor --- Comment #4 from Adolfo Jayme f...@libreoffice.org --- (In reply to Jay Philips from comment #3) Well i had proposed that the old ones be brought back Adolfo didnt agree with this change in a commit i had made For the record: I don’t believe on reversions as constructive contributions. It just frustrates people who tried to make improvements in the first place. Also: I’m not colorblind, and I guess most of you aren’t as well, how can we evaluate this new color isn’t “as clear”? Or is that statement based just on the subtler contrast in the icon’s edges? To get real user feedback we need to actually ship the new icon. And I’m not saying the new icon is perfect and can’t be improved further, of course! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85727] New: LibreOffice Spreadsheet formatting
https://bugs.freedesktop.org/show_bug.cgi?id=85727 Bug ID: 85727 Summary: LibreOffice Spreadsheet formatting Product: LibreOffice Version: 4.2.6.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: NEW Severity: normal Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: poub...@yahoo.fr Created attachment 108751 -- https://bugs.freedesktop.org/attachment.cgi?id=108751action=edit Screencopy of the bug. I have a spreadsheet containing MAC adresses. One of the MAC adress contains e9:9e at the end. When I validate the cell, the last e is changed in exponent. The default format is used. When I change the format in text or with a personal format (ie xx:xx:xx:xx:xx:xx), there is no change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79079] Arch Linux: UI text corrupts and disappears
https://bugs.freedesktop.org/show_bug.cgi?id=79079 --- Comment #9 from j...@janknizek.cz --- Unfortunately I don't have this computer anymore. So I would have to take it from the cellar and install there Arch again. So maybe we can leave it, because there is no other user that confirm that. Anyway, I am using the same configuration on other computer (ASUS K50IJ) and there it works perfectly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85701] FILESAVE: copied conditional formatting lost
https://bugs.freedesktop.org/show_bug.cgi?id=85701 psmits batav...@gmail.com changed: What|Removed |Added Hardware|All |x86 (IA32) Version|unspecified |4.3.2.2 release OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85722] Sidebar hides itself after unhiding it
https://bugs.freedesktop.org/show_bug.cgi?id=85722 --- Comment #2 from Jay Philips philip...@hotmail.com --- To the right of the scrollbar, there is a small button, which can be seen in attachment 105798. It is used to hide and unhide the sidebar without having the enable/disable it from the view menu. As this happens in a random way, in order to reproduce it, you would have to be regularly hiding and unhiding the sidebar during your regular usage of LibO. Steps: 1) Open Writer with sidebar in its enabled but hidden/closed state 2) Click the small show button to expand sidebar 3) Move mouse to toolbar or to document 4) Sidebar hides itself -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79585] RTL: RTL Layout Problem in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=79585 --- Comment #9 from Beluga todven...@suomi24.fi --- Argh, my eyes must have been crossed yesterday night.. I noticed I did have one single error using 4.3.3.2 in the last highlighted line: .abc instead of .abc. Yet, I didn't have the LTR - error as in Jay's screenshot. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79950] EDITING: Auto-Deleting words while typing
https://bugs.freedesktop.org/show_bug.cgi?id=79950 --- Comment #3 from Beluga todven...@suomi24.fi --- Can you attach an example file, so we can try to reproduce the error? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85721] FILEOPEN: assertion failed when opening .odp with RTL text
https://bugs.freedesktop.org/show_bug.cgi?id=85721 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||mst...@redhat.com, ||serval2...@yahoo.fr --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- The add of this assert has been made with http://cgit.freedesktop.org/libreoffice/core/log/?qt=rangeq=cec68bceba9aa1e984d74897fcd7bf4db702d14b Michael: thought you might be interested in this tracker. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79079] Arch Linux: UI text corrupts and disappears
https://bugs.freedesktop.org/show_bug.cgi?id=79079 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59611] Use of personas
https://bugs.freedesktop.org/show_bug.cgi?id=59611 Peter Maunder peter_maun...@cantab.net changed: What|Removed |Added CC||peter_maun...@cantab.net --- Comment #7 from Peter Maunder peter_maun...@cantab.net --- With the new changes to Persona support in 4.4.0.0 I think it is a good time to re-focus on the benefits of adding support for managing Persona directly on LibreOffice just as you can with Firefox and Thunderbird in addition to the on-line Firefox support currently provided. This would allow both private and business users to personalise their LibO, adding that little bit of glitter to LibO. In the same way that a desktop with your own image is yours rather than some background provided by the system. I personally do not download any Persona from the system as I use my own. So I have to go through the hassle of downloading an unwanted persona from Firefox when I install LibreOffice on a friends system and then modify the .xcu file. This takes away the easy to install look for LibO... I realise we may just be a minority, but who knows..Peter -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85701] FILESAVE: copied conditional formatting lost
https://bugs.freedesktop.org/show_bug.cgi?id=85701 psmits batav...@gmail.com changed: What|Removed |Added Version|4.3.2.2 release |4.3 Daily -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85701] FILESAVE: copied conditional formatting lost
https://bugs.freedesktop.org/show_bug.cgi?id=85701 psmits batav...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #3 from psmits batav...@gmail.com --- I just downloaded the latest version from the homepage LO 4.3.3.2 for Windows. Bug is still present on both Windows Vista and 7. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85687] Do not attempt to restore empty documents
https://bugs.freedesktop.org/show_bug.cgi?id=85687 --- Comment #2 from Geoffrey computergeoff...@zoho.com --- I am using Manjaro Linux, and it always occurs whenever I kill LibreOffice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85693] TANGO: Save and save as icons
https://bugs.freedesktop.org/show_bug.cgi?id=85693 --- Comment #5 from Jay Philips philip...@hotmail.com --- (In reply to Adolfo Jayme from comment #4) For the record: I don’t believe on reversions as constructive contributions. It just frustrates people who tried to make improvements in the first place. Yes i was hasty with the change and i apologize to Mirek for not speaking to him first about the it and should have inquired who made the change. Also: I’m not colorblind, and I guess most of you aren’t as well, how can we evaluate this new color isn’t “as clear”? Or is that statement based just on the subtler contrast in the icon’s edges? I believe the purple is to dark and doubt any floppy in our days was that color. There is also less clarity in the melt slider part because a gradient was used on its stroke rather than a solid color. Also the bottom part is blurry and you cant see a solid stroke color around the entire floppy, as can be found in the blue one. To get real user feedback we need to actually ship the new icon. We do not need to ship the icon to get feedback. We have a design team and libreoffice users we can get feedback from before shipping. And I’m not saying the new icon is perfect and can’t be improved further, of course! Well i would be best to replace something which is good with something that is better whenever its ready. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85693] TANGO: Save and save as icons
https://bugs.freedesktop.org/show_bug.cgi?id=85693 --- Comment #6 from A (Andy) stgohi-lob...@yahoo.de --- My View: If I read your posts I suppose you had already some (for me unknown) discussions about this. I as a normal user am very happy that there are more and more UI improvements, though maybe some of them are more incremental and I would like to see/assess them also in a broader strategy/context, but I like them and thank you both and the others for this/their work. I saw that you both made several improvements for LO 4.4 and therefore, I am very much looking forward to see LO 4.4. Mirek (as far as I know the new purple proposal is from him?) also made further nice improvements in the past and suggestions for further improvements, if I follow the Design/Whiteboard, where I hope to see some of them as final versions in LO in the future, if not already there. The here mentioned old blue Save buttons could also have an improvement/refresh because for me they look a little bit old-fashioned. The new purple colour version is interesting, but of course is also a matter of taste … some will like them, maybe some not … Of course you could also make a poll. From my point of view one could give them a real try, but I personally would prefer if they could maybe improved a little bit to be a bit less blurry, if possible (@Adolfo: for me at the icon's edges, @Mirek: What do you think?, I have unfortunately no graphical design skills), because it would be sad if users would maybe only not like them, because maybe some of them view them as a little bit blurry, because I think they are an interesting new improvement proposal. Therefore as Jay mentions, maybe we wait a little bit with the new Save buttons for further feedbacks? @Jay and Mirek: Maybe you can discuss this a little bit more together and make a further joint proposal? But as mentioned due to missing graphical skills I could not make any own proposals/contributions and can only comment it as a user. Maybe, we will also get some further responses from other users what they think about this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85722] Sidebar hides itself after unhiding it
https://bugs.freedesktop.org/show_bug.cgi?id=85722 --- Comment #3 from A (Andy) stgohi-lob...@yahoo.de --- Thank you very much for your fast reply and support. I tried it a few times, but I could unfortunately not reproduce it. But you wrote it happens randomly and not always? I will take care if I can maybe see it in the next days. (tested with LO 4.3.3.2, Win 8.1) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85728] New: FILEOPEN Wrong section break in DOCX
https://bugs.freedesktop.org/show_bug.cgi?id=85728 Bug ID: 85728 Summary: FILEOPEN Wrong section break in DOCX Product: LibreOffice Version: 4.4.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: davian...@gmail.com Created attachment 108752 -- https://bugs.freedesktop.org/attachment.cgi?id=108752action=edit The file The section break in the attached document is interpreted as a page break. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85728] FILEOPEN Wrong section break in DOCX
https://bugs.freedesktop.org/show_bug.cgi?id=85728 Urmas davian...@gmail.com changed: What|Removed |Added Attachment #108752|text/plain |application/octet-stream mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85703] Pages created by pressing Tab in a Table are not deletable
https://bugs.freedesktop.org/show_bug.cgi?id=85703 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- If you click Non printing character icon, you'll see there's one after your table. So you must delete an extra row so the page is removed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85714] Single Page Printing in LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=85714 --- Comment #2 from Frank fobe...@enteract.com --- Sorry if the explanation wasn't clear - the guesses you proposed were all correct, so is it that you simply can't reproduce this behavior? This behavior has existed in both 64-bit Ubuntu 12.04 (which I was using when I originally posted the bug) and 64-bit Ubuntu 14.04, but I don't have any other operating systems installed at the moment so can't check their behavior. At any rate, here's how I get the behavior: Step 1: Open a Writer Document - go to some arbitrary page and click the mouse; this sets what I am referring to as the current page. Step 2: (as you surmised) Use the menu sequence Tools | Options | General | Print Dialogs: Insure that Use LibreOffice Dialogs is Unchecked. (This causes LibreOffice to use the printing dialog boxes supplied by the Operating System - in my case the operating system is 64-bit Ubuntu 14.04) Step 3: (again, as you surmised) Use the menu sequence File | Print and insure that the General tab is the one displayed. In the lower Range section there is a grouping of three radio buttons labeled All Pages, Current Page, and Pages. The problem I am describing is that the Current Page radio button is always disabled (greyed out) and there is no page number in the input box adjacent to that radio button when using LibreOffice Writer. In the operating system printing dialog, the other tabs differ based on the printer that is selected as well as the application that is calling the dialog. For instance, the LibreOffice Writer tab is only present when called from Writer. So Writer seems to be sharing at least some information with the OS - just not the current page. Although the issue I describe could (so far) be related to either the operating system or the application, the reason I suspect the application (Writer) is that the identical OS printing dialog is used with other applications and all those I have looked at show the current page number filled in next to the Current Page radio button. It would therefore seem that Writer is not passing this information to the operating system's dialog box, at least in 64 bit versions of Ubuntu. If there are further questions, or things you would like me to try, let me know. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79429] Other: icons in alt+tab dialogue are not correct
https://bugs.freedesktop.org/show_bug.cgi?id=79429 --- Comment #3 from Beluga todven...@suomi24.fi --- Created attachment 108753 -- https://bugs.freedesktop.org/attachment.cgi?id=108753action=edit Screenshots from Debian and Arch In this .zip file I have included three screenshots generously provided to me by Xfce community members on the #xfce IRC channel. The only one that shows a grey icon is Arch Linux with LO 4.2.7.2. The others don't have the problem and they are from Aptosid and Debian Jessie, LO 4.3.3 rc2. All three use Xfce 4.10.1. Arch and Aptosid use Greybird theme with Faenza. It might be that the problem has gone away in 4.3.x. I will try and get more information. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79429] Other: icons in alt+tab dialogue are not correct
https://bugs.freedesktop.org/show_bug.cgi?id=79429 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85646] LibreOffice Writer crashes 10 times per minute and from debug logs looks like Python initialization problem
https://bugs.freedesktop.org/show_bug.cgi?id=85646 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- On which Windows are you? (XP, Seven, 8) 32 or 64 bits? For the test, could you rename your LO directory profile (see https://wiki.documentfoundation.org/UserProfile#Windows) and give a try to last stable 4.3.3? Did you install any specific fonts? I mean do you have other fonts than those installed out of box with Windows? If yes, could you disable them and give it a new try? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85603] Filesave (Export)
https://bugs.freedesktop.org/show_bug.cgi?id=85603 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- Do you reproduce this with a brand new file with just test? If not, would it be possible you attach your file so we can give it a try? (please have in mind that any attachment is automatically made public so remove any confidential/private part). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79429] Other: icons in alt+tab dialogue are not correct
https://bugs.freedesktop.org/show_bug.cgi?id=79429 --- Comment #4 from gray.timothyja...@gmail.com --- I was encountering the same thing as shown in the Arch screenshot. starting to remember from my research about the problem when I was encountering it. I think alt-tab switcher was fetching the icon from the libreoffice theme (i.e., icons used inside libreoffice) rather than the external system theme. you'll notice that the Aptosid and Debian Jessie screenshots have a standard (colour) theme in libreoffice, the and that the writer icon shown in the alt-tab switcher is consistent with (for example) the new document icon in top left. however, the Arch screenshot shows the black-and-white Faenza icon for both the new document and the switcher. in light of this, not sure if the problem is with libreoffice or xfce. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85722] Sidebar hides itself after unhiding it
https://bugs.freedesktop.org/show_bug.cgi?id=85722 --- Comment #4 from Jacques Guilleron guillero...@aol.com --- Hi Jay, Andy, There's two behaviours for this button. Once the sidebar enabled but closed (you see a narrrow band with a central button on the right of the scrollbar), if you click exactly on the button, you open the sidebar and it keeps opened constantly. If you now click out of this button but into the narrow band to open the sidebar, this time when you click into your document to work, the sidebar disappears. Is it the behaviour you observed? Regards, Jacques -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80540] VIEWING: Stock chart does not display correctly
https://bugs.freedesktop.org/show_bug.cgi?id=80540 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #10 from Cor Nouws c...@nouenoff.nl --- Is OK in 4.3.3.2 too (and maybe earlier - didn't check that) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80059] EDITING Row height of certain rows (non default, without content) changes after opening
https://bugs.freedesktop.org/show_bug.cgi?id=80059 --- Comment #5 from Cor Nouws c...@nouenoff.nl --- (In reply to raal from comment #3) I can not reproduce with Version: 4.3.2.0.0+ Build ID: 25459cb0c9afdf46c3d90ae8ba0b6ffb375f67da TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:libreoffice-4-3, Time: 2014-08-17_22:48:01 Still a problem in 4.3.3.2 for me On 32 bits, maybe that's different? Versie: 4.3.3.2 Build ID: 9bb7eadab57b6755b1265afa86e04bf45fbfc644 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77592] FILEOPEN: LibO 4.2.x incorrectly changes row height
https://bugs.freedesktop.org/show_bug.cgi?id=77592 --- Comment #9 from Cor Nouws c...@nouenoff.nl --- *** Bug 80059 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80059] EDITING Row height of certain rows (non default, without content) changes after opening
https://bugs.freedesktop.org/show_bug.cgi?id=80059 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Cor Nouws c...@nouenoff.nl --- (In reply to rlk from comment #4) This looks a lot like bug 77592. Looks so. Thanks Rik *** This bug has been marked as a duplicate of bug 77592 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80059] EDITING Row height of certain rows (non default, without content) changes during editing
https://bugs.freedesktop.org/show_bug.cgi?id=80059 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Summary|EDITING Row height of |EDITING Row height of |certain rows (non default, |certain rows (non default, |without content) changes|without content) changes |after opening |during editing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85707] NOT BETWEEN query not working (in query design view) when LibreOffice user interface is in Spanish
https://bugs.freedesktop.org/show_bug.cgi?id=85707 --- Comment #8 from mrmister001 mrmister...@gmail.com --- Is there a difference to older versions of LO, special the input in the Spanish GUI for «NOT BETWEEN ... AND ...». REPLY: I don't know if the older versions of LibreOffice were having this error or not, I've discovered it in the current version. Wouldn't it be better to change component to Localization? * REPLY: * I am sorry, I don't understand what you mean about component to Localization?, absolutely, you are right, I don't understand what you are saying. If you could explain so in detail (as I did to confirm the error) it would be greatly appreciated. * In the meantime, we still having a CRITICAL issue that affect 400 million of potential users from the hispanic community. * Summarizing: In Spanish, LibreOffice cannot tackle queries based in NOT BETWEEN ... AND when the queries are accomplished in the *** Design View Mode *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77592] FILEOPEN: LibO 4.2.x incorrectly changes row height
https://bugs.freedesktop.org/show_bug.cgi?id=77592 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Version|4.2.2.1 release |4.2.1.1 release --- Comment #10 from Cor Nouws c...@nouenoff.nl --- Hi, Set to 4.2.1.1 - the first version that I could reproduce the duplicate bug 80059 in. Also to Hardware All - I'm on 32 bits. In the description of 80059 there is a simple sheet + 'editing' instructions to reproduce. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77592] FILEOPEN: LibO 4.2.x incorrectly changes row height
https://bugs.freedesktop.org/show_bug.cgi?id=77592 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Blocks||65675 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
