[Libreoffice-bugs] [Bug 88611] LENB co. wrong value for Cyrillic text
https://bugs.freedesktop.org/show_bug.cgi?id=88611 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- LENB(Проба) returns 5 in excel 2010 https://support.office.com/en-in/article/LEN-LENB-functions-6a149d3a-ba2e-4394-ad47-2eb083265a56 Important LENB counts 2 bytes per character only when a DBCS language is set as the default language. Otherwise LENB behaves the same as LEN, counting 1 byte per character. The languages that support DBCS include Japanese, Chinese (Simplified), Chinese (Traditional), and Korean. Your language is Russian or similar, I think.. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88051] Linux Libertine G ligature followed by tab: strange behavior
https://bugs.freedesktop.org/show_bug.cgi?id=88051 --- Comment #4 from R.Yu. ogldel...@mail.ru --- Created attachment 112521 -- https://bugs.freedesktop.org/attachment.cgi?id=112521action=edit Fixes bug Don't really know how, but it fix the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62268] FILEOPEN: Optimum row height should be recalculated with style:use-optimal-row-height='true'
https://bugs.freedesktop.org/show_bug.cgi?id=62268 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||daniel.dev.libreoffice@gmai ||l.com, ||fdb...@neosheffield.co.uk Whiteboard|bibisectRequest |bibisected --- Comment #16 from Matthew Francis fdb...@neosheffield.co.uk --- Bibisect points to source-hash-2b5b04e1e62914bf0902dfd7943cdc44499c47a6 in 43all (massive quantities of skipping required so I will omit the log) Follow-up source bisection points to the below commit. Looks like a GSOC 2012 job. commit cd2f8a1cabbfb924c62d7af2aac3ac09288c2d4c Author: Daniel Bankston daniel.e.banks...@gmail.com Date: Mon Jun 25 01:21:26 2012 -0500 Stop calculating row heights and instead use imported row heights only Change-Id: I1a5e33c292fb915e61511efbdb9ce4a0cfd7265f -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86416] middle click paste truncates [Hard to reproduce]
https://bugs.freedesktop.org/show_bug.cgi?id=86416 --- Comment #25 from Beluga todven...@suomi24.fi --- (In reply to Todd from comment #24) Parcellite (or the version that runs under SL 6.x) won't allow for the coping and pasting of images. Sigh. You have a favorite replacement? Sorry, I don't use clipboard managers myself. CopyQ looks hot, but it requires Qt, which might be a deal-breaker for you. I could reproduce the truncation with these old versions, too: LibreOffice 3.5.0rc3 Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735 Version 4.0.4.2 (Build ID: 4.0.4.2-14.el6) So this isn't a regression we could bibisect :( Wow! What a tremendous amount of work! And in Step 1, he made no mention of where he is getting all those i686 packages from. I book marked it, just in case I ever have a free week with nothing else to do and decide to try compiling it again. Here are my notes: step 2: had to tweak this: yum localinstall rpmbuild/RPMS/i686/chrpath-0.13-14.el7.centos.i686.rpm to this: yum localinstall rpmbuild/RPMS/i686/chrpath-0.13-14.el7.i686.rpm Installed cmake from package manager. had to tweak this: yum localinstall rpmbuild/RPMS/i686/openal-soft{,-devel}-1.16.0-2.el7.centos.i686.rpm to this: yum localinstall rpmbuild/RPMS/i686/openal-soft{,-devel}-1.16.0-2.el7.i686.rpm For editing: http://www.lagmonster.org/docs/vi.html http://www.cs.colostate.edu/helpdocs/vi.html dd delete line a Append after cursor (press ESC to complete) /stringSearch forward for string ?stringSearch back for string nSearch for next instance of string NSearch for previous instance of string ZZ save and exit -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88581] Set 'Enable regular expression' off by default
https://bugs.freedesktop.org/show_bug.cgi?id=88581 raal r...@post.cz changed: What|Removed |Added Summary|VLOOKUP returns #N/A|Set 'Enable regular |(because of Allow regular |expression' off by default |expressions in formulas| |option) | --- Comment #6 from raal r...@post.cz --- (In reply to Kevin Suo from comment #5) (In reply to raal from comment #4) Yes correct. I set this as an enhancement request. Changing summary. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52194] Failure to launch if already open
https://bugs.freedesktop.org/show_bug.cgi?id=52194 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #3 from Beluga todven...@suomi24.fi --- Not happening anymore - WFM. Kubuntu 14.10 64-bit, LibO 4.3.3.2 Scientific Linux 7 64-bit, Xfce 4.10, LibO 4.1.4.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85174] PDF import of special characters (Algebra ) broken
https://bugs.freedesktop.org/show_bug.cgi?id=85174 --- Comment #6 from vv...@yandex.ru --- Displacement of characters fixed here: https://gerrit.libreoffice.org/14029 Empty rectangles instead of brackets - is another issue - problems with Symbol font. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82613] UI: Variable / User field Selection list displays entries in order of creation (rather than order of variable name)
https://bugs.freedesktop.org/show_bug.cgi?id=82613 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||weizenkille...@gmx.de --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 84945 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: cppcheck: arrayIndexOutOfBounds report in stortree.cxx (store module)
On 01/19/2015 10:52 PM, julien2412 wrote: However, I'm not sure to understand. I mean, I thought there were mere array (like in C) with fixed size and vector or other dynamic containers. The idea is to allocate only a single block of memory for the fixed-size head of the struct plus the dynamically-sized tail, by doing something like OStoreBTreeNodeData * p = reinterpret_castOStoreBTreeNodeData *( new char[ offsetof(OStoreBTreeNodeData, m_pData) + k * sizeof(T)]); That trick is used in quite a number of places across the LO codebase, the most prominent example being rtl_uString underlying OUString. I don't know what you mean by flexible array member but above all what about if n (so capacityCount()) is 1? m_pData[1] would be out of bounds, wouldn't it? if n is 1, the body of the loop for (sal_uInt16 i = 1; i n; i++) will be executed zero times, so there would not be any access to out-of-bounds m_pData[1]. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88610] Incorrect rendering of some characters in Symbol font
https://bugs.freedesktop.org/show_bug.cgi?id=88610 --- Comment #2 from vv...@yandex.ru --- Also tested with Ubuntu 14.10 + LibreOffice 4.5.0.0 master @ 07e84cae - works well, same result as with Ubuntu 14.10 + LibreOffice 4.3.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46203] Vertical Text by the side of pages all wrong.
https://bugs.freedesktop.org/show_bug.cgi?id=46203 Beluga todven...@suomi24.fi changed: What|Removed |Added Priority|high|medium CC||todven...@suomi24.fi OS|Linux (All) |All --- Comment #10 from Beluga todven...@suomi24.fi --- (In reply to sasha.libreoffice from comment #7) When open attached doc in Writer, appears extra vertical text on left. Reproduced in 3.3.4, 3.5.5, 3.6.2 on Fedora 64 bit IMHO it is because doc has frame placed outside of page Problem still exists. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 5f6bdce0c0ac687f418821ce328f2987bf340cda TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-17_01:06:46 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 2 commits - desktop/source include/LibreOfficeKit libreofficekit/qa libreofficekit/source
desktop/source/lib/init.cxx | 24 include/LibreOfficeKit/LibreOfficeKit.h | 12 ++ include/LibreOfficeKit/LibreOfficeKit.hxx | 12 ++ libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |9 --- libreofficekit/source/gtk/lokdocview.c | 24 ++-- 5 files changed, 70 insertions(+), 11 deletions(-) New commits: commit a28584efe460813f43d552498825622b6907f976 Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Jan 20 10:20:24 2015 +0100 gtktiledviewer: call postMouseEvent() Again, no unit conversion yet. Change-Id: I261febd875bac5a729f449e42558b5af9d7a359b diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx index 085e3e3..ea5a273 100644 --- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx +++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx @@ -160,14 +160,6 @@ static void signalKey(GtkWidget* /*pWidget*/, GdkEventKey* pEvent, gpointer /*pD pLOKDocView-pOffice-pClass-postKeyEvent(pLOKDocView-pOffice, LOK_KEYEVENT_KEYINPUT, nCode); } -/// Receives a button press event. -static void signalButton(GtkWidget* /*pWidget*/, GdkEvent* /*pEvent*/, gpointer /*pData*/) -{ -LOKDocView* pLOKDocView = LOK_DOCVIEW(pDocView); - -lok_docview_set_edit(pLOKDocView, TRUE); -} - // GtkComboBox requires gtk 2.24 or later #if ( GTK_MAJOR_VERSION == 2 GTK_MINOR_VERSION = 24 ) || GTK_MAJOR_VERSION 2 void populatePartSelector() @@ -325,7 +317,6 @@ int main( int argc, char* argv[] ) // Input handling. g_signal_connect(pWindow, key-press-event, G_CALLBACK(signalKey), NULL); g_signal_connect(pWindow, key-release-event, G_CALLBACK(signalKey), NULL); -g_signal_connect(pDocView, button-press-event, G_CALLBACK(signalButton), NULL); gtk_container_add( GTK_CONTAINER(pVBox), pDocView ); diff --git a/libreofficekit/source/gtk/lokdocview.c b/libreofficekit/source/gtk/lokdocview.c index b335d8b..bf8dd71 100644 --- a/libreofficekit/source/gtk/lokdocview.c +++ b/libreofficekit/source/gtk/lokdocview.c @@ -33,6 +33,26 @@ void lcl_onDestroy( LOKDocView* pDocView, gpointer pData ) pDocView-pDocument = NULL; } +/// Receives a button press event. +void lcl_signalButton(GtkWidget* pEventBox, GdkEventButton* pEvent, LOKDocView* pDocView) +{ +(void) pEventBox; + +lok_docview_set_edit(pDocView, TRUE); + +switch (pEvent-type) +{ +case GDK_BUTTON_PRESS: +pDocView-pOffice-pClass-postMouseEvent(pDocView-pOffice, LOK_MOUSEEVENT_MOUSEBUTTONDOWN, pEvent-x, pEvent-y); +break; +case GDK_BUTTON_RELEASE: +pDocView-pOffice-pClass-postMouseEvent(pDocView-pOffice, LOK_MOUSEEVENT_MOUSEBUTTONUP, pEvent-x, pEvent-y); +break; +default: +break; +} +} + SAL_DLLPUBLIC_EXPORT guint lok_docview_get_type() { static guint lok_docview_type = 0; @@ -73,8 +93,8 @@ static void lok_docview_init( LOKDocView* pDocView ) gtk_scrolled_window_add_with_viewport( GTK_SCROLLED_WINDOW(pDocView), pDocView-pEventBox ); -// Allow reacting to button press events. -gtk_widget_set_events(pDocView-pEventBox, GDK_BUTTON_PRESS_MASK); +gtk_signal_connect(GTK_OBJECT(pDocView-pEventBox), button-press-event, GTK_SIGNAL_FUNC(lcl_signalButton), pDocView); +gtk_signal_connect(GTK_OBJECT(pDocView-pEventBox), button-release-event, GTK_SIGNAL_FUNC(lcl_signalButton), pDocView); gtk_widget_show( pDocView-pEventBox ); commit cdabb94b3e4de2978a999ffda1e7cb0aa62454da Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Jan 20 10:17:03 2015 +0100 Add initial lok::Office::postMouseEvent() There is no unit conversion yet, most probably we want to work with doc model coordinates at an API level, while VCL works with pixel coordinates. Change-Id: I98848851fbec5253e76c997844f6339402dfac46 diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 14c1860..e8f98aa 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -253,6 +253,7 @@ static int lo_initialize (LibreOfficeKit* pThis, const ch static LibreOfficeKitDocument* lo_documentLoad (LibreOfficeKit* pThis, const char* pURL); static char * lo_getError (LibreOfficeKit* pThis); static voidlo_postKeyEvent (LibreOfficeKit* pThis, int nType, int nCode); +static voidlo_postMouseEvent (LibreOfficeKit* pThis, int nType, int nX, int nY); struct LibLibreOffice_Impl : public _LibreOfficeKit @@ -272,6 +273,7 @@ struct LibLibreOffice_Impl : public _LibreOfficeKit m_pOfficeClass-documentLoad = lo_documentLoad; m_pOfficeClass-getError = lo_getError; m_pOfficeClass-postKeyEvent = lo_postKeyEvent; +
[Libreoffice-commits] core.git: testtools/source
testtools/source/bridgetest/bridgetest.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit b0ce8ea909cc61710e73ddfa0d03c6fe34aab4cb Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 10:22:49 2015 +0100 Some more loplugin:cstylecast: testtools Change-Id: I28bce2f4bdbadef2d68130adc6fdc09c9840a005 diff --git a/testtools/source/bridgetest/bridgetest.cxx b/testtools/source/bridgetest/bridgetest.cxx index 6bd4a92..80e601b 100644 --- a/testtools/source/bridgetest/bridgetest.cxx +++ b/testtools/source/bridgetest/bridgetest.cxx @@ -1037,7 +1037,7 @@ uno_Sequence* cloneSequence(const uno_Sequence* val, const Type type) td.makeComplete(); typelib_TypeDescription* pTdRaw = td.get(); typelib_IndirectTypeDescription* pIndirectTd = -(typelib_IndirectTypeDescription*) pTdRaw; +reinterpret_casttypelib_IndirectTypeDescription*(pTdRaw); typelib_TypeDescription* pTdElem = pIndirectTd-pType-pType; sal_Int8* buf = new sal_Int8[pTdElem-nSize * val-nElements]; @@ -1051,12 +1051,12 @@ uno_Sequence* cloneSequence(const uno_Sequence* val, const Type type) Type _tElem(pTdElem-pWeakRef); for (int i = 0; i val-nElements; i++) { -sal_Int8 *pValBuf = (sal_Int8 *)(val-elements + i * pTdElem-nSize); +sal_Int8 const *pValBuf = reinterpret_castsal_Int8 const *(val-elements + i * pTdElem-nSize); uno_Sequence* seq = cloneSequence( -*(uno_Sequence**) (pValBuf), +reinterpret_castuno_Sequence const *(pValBuf), _tElem); -*((uno_Sequence**) pBufCur) = seq; +*reinterpret_castuno_Sequence**(pBufCur) = seq; pBufCur += pTdElem-nSize; } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 57052] FILEOPEN particular .docx shows rotated text in text frame without rotation
https://bugs.freedesktop.org/show_bug.cgi?id=57052 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |WORKSFORME --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- The rotation is already fixed in 4.3.5.1, 4.4.0.2 and 4.5 master. Not sure if the vertical alignment is quite right, but if not that should be raised as a different bug. - RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58624] SwAccessibleParagraph - SwAccessibleMap lifetime mismatch
https://bugs.freedesktop.org/show_bug.cgi?id=58624 Michael Stahl mst...@redhat.com changed: What|Removed |Added CC||mst...@redhat.com --- Comment #2 from Michael Stahl mst...@redhat.com --- it's possible this is fixed by: commit 296e8b597c141b6b54cbf943871d6a6820c1779d Author: Michael Stahl mst...@redhat.com AuthorDate: Thu Dec 18 21:52:51 2014 +0100 fdo#87199: sw: fix root cause of a11y crash when merging cells ... which should dispose (and thereby remove from the SwAccessibleMap) more SwAccessible instances but it's hard to know for sure... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/socket.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit e7057033beafedb857c45d5b32d9622b0ce545e8 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 10:33:54 2015 +0100 Fix for Android gethostbyaddr Change-Id: Icc8f5f71f07d0afb016b6188daea26068db93769 diff --git a/sal/osl/unx/socket.cxx b/sal/osl/unx/socket.cxx index ce8a4f3..c818686 100644 --- a/sal/osl/unx/socket.cxx +++ b/sal/osl/unx/socket.cxx @@ -961,7 +961,10 @@ oslHostAddr SAL_CALL osl_createHostAddrByAddr (const oslSocketAddr pAddr) if (sin-sin_addr.s_addr == htonl(INADDR_ANY)) return ((oslHostAddr)NULL); -he= gethostbyaddr(sin-sin_addr, +char const * addr = reinterpret_castchar const *(sin-sin_addr); +// at least some Androids apparently have a gethostbyaddr with char* +// instead of void* argument +he= gethostbyaddr(addr, sizeof (sin-sin_addr), sin-sin_family); return _osl_hostentToHostAddr (he); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 42910] [Calc] xls export corrupts some formulas with named ranges
https://bugs.freedesktop.org/show_bug.cgi?id=42910 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #7 from Beluga todven...@suomi24.fi --- No problem anymore. Win 7 Pro 64-bit, LibO Version: 4.3.6.1 Build ID: 9629686a67dd1f357477c13325e45a66f3452bb9 Version: 4.5.0.0.alpha0+ Build ID: 5f6bdce0c0ac687f418821ce328f2987bf340cda TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-01-17_01:06:46 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84945] UserField Should be in Alphabetical Order
https://bugs.freedesktop.org/show_bug.cgi?id=84945 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 82613 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - 6 commits - android/experimental desktop/source
android/experimental/LOAndroid3/AndroidManifest.xml.in |6 +-- android/experimental/LOAndroid3/res/values/ids.xml |4 ++ android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java | 18 +++--- android/experimental/LOAndroid3/src/java/org/mozilla/gecko/gfx/LayerView.java |4 +- desktop/source/lib/lokandroid.cxx |6 ++- dev/null |binary 6 files changed, 21 insertions(+), 17 deletions(-) New commits: commit 66ea35dcebd458d0e2aa730fa02b92ef83fbcf36 Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk Date: Tue Jan 20 18:26:51 2015 +0900 android: revert the app package name relative activity name Package name must stay org.libreoffice as code gen uses this for the package name of resources (generated org.libreoffice.R) which we reference in the source code. Usual practice is to change the package name at packaging step. The code was changed to allow this. Change-Id: I4e36f46c4b8d620f3c9b20fe4fd39737c76624bc diff --git a/android/experimental/LOAndroid3/AndroidManifest.xml.in b/android/experimental/LOAndroid3/AndroidManifest.xml.in index 0bb8333..ac2c8af 100644 --- a/android/experimental/LOAndroid3/AndroidManifest.xml.in +++ b/android/experimental/LOAndroid3/AndroidManifest.xml.in @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=utf-8? manifest xmlns:android=http://schemas.android.com/apk/res/android; -package=@ANDROID_PACKAGE_NAME@ +package=org.libreoffice @ANDROID_INSTALL_LOCATION@ android:versionCode=1 android:versionName=@ANDROID_VERSION@ @@ -19,7 +19,7 @@ android:theme=@style/AppTheme !-- Viewer Activity -- activity -android:name=org.libreoffice.LibreOfficeMainActivity +android:name=.LibreOfficeMainActivity android:label=@string/app_name android:configChanges=orientation|keyboard|keyboardHidden|screenLayout|uiMode|screenSize|smallestScreenSize intent-filter @@ -38,7 +38,7 @@ data android:mimeType=application/vnd.oasis.opendocument.text-flat-xml / data android:mimeType=application/vnd.oasis.opendocument.graphics-flat-xml / data android:mimeType=application/vnd.oasis.opendocument.presentation-flat-xml / -!-- TODO: opening FODS documents crashes currently +!-- TODO: opening FODS documents crashes currently data android:mimeType=application/vnd.oasis.opendocument.spreadsheet-flat-xml / -- commit 17457c7dbccd851a1ffbc52185a1a1b86e254f71 Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk Date: Tue Jan 20 18:24:27 2015 +0900 android: add dummy resurce to get the correct package name Change-Id: I27a40108d9523058b6340d870105667bb4c0bdae diff --git a/android/experimental/LOAndroid3/res/values/ids.xml b/android/experimental/LOAndroid3/res/values/ids.xml new file mode 100644 index 000..e57595b --- /dev/null +++ b/android/experimental/LOAndroid3/res/values/ids.xml @@ -0,0 +1,4 @@ +?xml version=1.0 encoding=utf-8? +resources xmlns:android=http://schemas.android.com/apk/res/android; +item name=dummy_id_for_package_name_resolution type=id/ +/resources diff --git a/android/experimental/LOAndroid3/src/java/org/mozilla/gecko/gfx/LayerView.java b/android/experimental/LOAndroid3/src/java/org/mozilla/gecko/gfx/LayerView.java index 6c71eeb..c6b4e2e 100644 --- a/android/experimental/LOAndroid3/src/java/org/mozilla/gecko/gfx/LayerView.java +++ b/android/experimental/LOAndroid3/src/java/org/mozilla/gecko/gfx/LayerView.java @@ -28,6 +28,7 @@ import android.view.inputmethod.InputMethodManager; import android.widget.FrameLayout; import org.libreoffice.LibreOfficeMainActivity; +import org.libreoffice.R; import java.lang.reflect.Method; import java.nio.IntBuffer; @@ -261,7 +262,8 @@ public class LayerView extends FrameLayout { public Bitmap getDrawable(String name) { Context context = getContext(); Resources resources = context.getResources(); -int resourceID = resources.getIdentifier(name, drawable, context.getPackageName()); +String packageName = resources.getResourcePackageName(R.id.dummy_id_for_package_name_resolution); +int resourceID = resources.getIdentifier(name, drawable, packageName); BitmapFactory.Options options = new BitmapFactory.Options(); options.inScaled = false; return BitmapFactory.decodeResource(context.getResources(), resourceID, options); commit 1b310bd91503f7b96b1a1fe03a744d648fba73e5 Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk Date: Tue Jan 20 18:21:58 2015 +0900 android: release local ref to string after callback exec. in JNI
[Libreoffice-commits] core.git: editeng/source include/editeng sw/source
editeng/source/items/frmitems.cxx | 11 +++ include/editeng/shaditem.hxx|1 + sw/source/core/docnode/nodedump.cxx |6 +++--- 3 files changed, 15 insertions(+), 3 deletions(-) New commits: commit 71edf281f38a3ee839a99393cb06316c7231f3d2 Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Jan 20 09:10:35 2015 +0100 Factor out SvxShadowItem::dumpAsXml() from sw Change-Id: Id25a050a9840d83cff4b390faec7478f17336524 diff --git a/editeng/source/items/frmitems.cxx b/editeng/source/items/frmitems.cxx index 8b68df0..2c0adcc 100644 --- a/editeng/source/items/frmitems.cxx +++ b/editeng/source/items/frmitems.cxx @@ -1589,6 +1589,17 @@ void SvxShadowItem::SetEnumValue( sal_uInt16 nVal ) SetLocation( (const SvxShadowLocation)nVal ); } +void SvxShadowItem::dumpAsXml(xmlTextWriterPtr pWriter) const +{ +xmlTextWriterStartElement(pWriter, BAD_CAST(svxShadowItem)); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(whichId), BAD_CAST(OString::number(Which()).getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(aShadowColor), BAD_CAST(aShadowColor.AsRGBHexString().toUtf8().getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nWidth), BAD_CAST(OString::number(nWidth).getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(eLocation), BAD_CAST(OString::number(eLocation).getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(presentation), BAD_CAST(EE_RESSTR(RID_SVXITEMS_SHADOW_BEGIN + eLocation).toUtf8().getStr())); +xmlTextWriterEndElement(pWriter); +} + // class SvxBoxItem -- SvxBoxItem::SvxBoxItem( const SvxBoxItem rCpy ) : diff --git a/include/editeng/shaditem.hxx b/include/editeng/shaditem.hxx index 43ec3bc..c7761fca 100644 --- a/include/editeng/shaditem.hxx +++ b/include/editeng/shaditem.hxx @@ -83,6 +83,7 @@ public: virtual OUString GetValueTextByPos( sal_uInt16 nPos ) const SAL_OVERRIDE; virtual sal_uInt16 GetEnumValue() const SAL_OVERRIDE; virtual voidSetEnumValue( sal_uInt16 nNewVal ) SAL_OVERRIDE; +void dumpAsXml(struct _xmlTextWriter* pWriter) const; }; inline SvxShadowItem SvxShadowItem::operator=( const SvxShadowItem rFmtShadow ) diff --git a/sw/source/core/docnode/nodedump.cxx b/sw/source/core/docnode/nodedump.cxx index 5822f89..b05809a 100644 --- a/sw/source/core/docnode/nodedump.cxx +++ b/sw/source/core/docnode/nodedump.cxx @@ -496,6 +496,9 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const SfxItemSet* pSet) case RES_UL_SPACE: static_castconst SvxULSpaceItem*(pItem)-dumpAsXml(writer); break; +case RES_SHADOW: +static_castconst SvxShadowItem*(pItem)-dumpAsXml(writer); +break; default: bDone = false; break; } if (bDone) @@ -510,9 +513,6 @@ void lcl_dumpSfxItemSet(WriterHelper writer, const SfxItemSet* pSet) boost::optionalOString oValue; switch (pItem-Which()) { -case RES_SHADOW: -pWhich = shadow; -break; case RES_PAGEDESC: { pWhich = page description; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/strtmpl.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit a3f3d4d1904fd68ec3f79cc367a995a6b5a31e35 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 09:24:37 2015 +0100 Missing const Change-Id: I13058a46526a1186deaa8fffde303c272c0cc8aa diff --git a/sal/rtl/strtmpl.cxx b/sal/rtl/strtmpl.cxx index 8bea7db..6b92658 100644 --- a/sal/rtl/strtmpl.cxx +++ b/sal/rtl/strtmpl.cxx @@ -340,7 +340,7 @@ sal_Int32 SAL_CALL IMPL_RTL_STRNAME( indexOfChar )( const IMPL_RTL_STRCODE* pStr if (sizeof(IMPL_RTL_STRCODE) == sizeof(wchar_t)) { // take advantage of builtin optimisations -wchar_t* p = wcschr(reinterpret_castwchar_t const *(pStr), (wchar_t)c); +wchar_t const * p = wcschr(reinterpret_castwchar_t const *(pStr), (wchar_t)c); return p ? p - reinterpret_castwchar_t const *(pStr) : -1; } else @@ -399,7 +399,7 @@ sal_Int32 SAL_CALL IMPL_RTL_STRNAME( lastIndexOfChar )( const IMPL_RTL_STRCODE* if (sizeof(IMPL_RTL_STRCODE) == sizeof(wchar_t)) { // take advantage of builtin optimisations -wchar_t* p = wcsrchr(reinterpret_castwchar_t const *(pStr), (wchar_t)c); +wchar_t const * p = wcsrchr(reinterpret_castwchar_t const *(pStr), (wchar_t)c); return p ? p - reinterpret_castwchar_t const *(pStr) : -1; } else @@ -443,7 +443,7 @@ sal_Int32 SAL_CALL IMPL_RTL_STRNAME( indexOfStr )( const IMPL_RTL_STRCODE* pStr, if (sizeof(IMPL_RTL_STRCODE) == sizeof(wchar_t)) { // take advantage of builtin optimisations -wchar_t* p = wcsstr(reinterpret_castwchar_t const *(pStr), reinterpret_castwchar_t const *(pSubStr)); +wchar_t const * p = wcsstr(reinterpret_castwchar_t const *(pStr), reinterpret_castwchar_t const *(pSubStr)); return p ? p - reinterpret_castwchar_t const *(pStr) : -1; } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88615] New: When a document is more than 1 page in Web View, increasing zoom makes Libreoffice crash
https://bugs.freedesktop.org/show_bug.cgi?id=88615 Bug ID: 88615 Summary: When a document is more than 1 page in Web View, increasing zoom makes Libreoffice crash Product: LibreOffice Version: 4.3.5.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zeriani...@gmail.com Exactly as it says in the summary, when a document in Libreoffice Writer is more than one page in Web View, increasing zoom past 100% (necessary on some screens to make the text big enough to be read) makes Libreoffice crash out. This same error is present with documents that were saved in another .odt creation tool (I believe I used Windows 8's inbuilt .odt reader to do this) which have the zoom saved at more than 100% and you open them in Writer. This error was fixed at one point (I believe it was in the 4.2.X.X series, one of them) and a regression appeared when I updated to 4.3.5.2 today. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88621] Undo and Redo dropdown menu in toolbox hides last line
https://bugs.freedesktop.org/show_bug.cgi?id=88621 --- Comment #1 from Maxim Britov ungift...@ya.ru --- Both on Windows/Linux for me -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: slideshow/source
slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e4fd2972e4e540d5ecc9eeba21c4464aae771c10 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 11:24:13 2015 +0100 Some more loplugin:cstylecast: slideshow Change-Id: I5cba157aa69b979a1e821f267f0560dd16533677 diff --git a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx index 754e794..a878b08 100644 --- a/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx +++ b/slideshow/source/engine/OGLTrans/generic/OGLTrans_TransitionerImpl.cxx @@ -337,7 +337,7 @@ void OGLTransitionerImpl::impl_initializeFlags( bool const bValidContext ) const GLubyte* vendor = glGetString( GL_VENDOR ); /* TODO: check for version once the bug in fglrx driver is fixed */ -mbBrokenTexturesATI = (vendor strcmp( (const char *) vendor, ATI Technologies Inc. ) == 0 ); +mbBrokenTexturesATI = (vendor strcmp( reinterpret_castconst char *(vendor), ATI Technologies Inc. ) == 0 ); } CHECK_GL_ERROR(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88611] LENB co. wrong value for Cyrillic text
https://bugs.freedesktop.org/show_bug.cgi?id=88611 --- Comment #2 from Urmas davian...@gmail.com --- The system locale was Simplified Chinese. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88624] Reportbuilder always stores absolute paths for graphics
https://bugs.freedesktop.org/show_bug.cgi?id=88624 --- Comment #1 from schaber gerhard.scha...@gmx.at --- Correction, deselecting the report builder during installation is no workaround. If the internal report builder is not installed, the reports cannot be opened, no matter if the Oracle Report Builder 1.2.1 extension has been added manually or not. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88267] Page orientation doesn't export to .doc/.docx correctly
https://bugs.freedesktop.org/show_bug.cgi?id=88267 Timur gti...@gmail.com changed: What|Removed |Added CC||gti...@gmail.com --- Comment #3 from Timur gti...@gmail.com --- (In reply to Matthew Francis from comment #1) Created attachment 112057 [details] Sample file with mixed portrait / landscape pages Reproducible with the attached .odt, but NOT reproducible from scratch creating simple document with Insert- Page break - Landscape. Please specify how this example was created and in which version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - scaddins/source
scaddins/source/analysis/analysishelper.hxx |4 1 file changed, 4 insertions(+) New commits: commit 113bf75007f915b684bb9b122e0cf27aecd95aed Author: Michael Meeks michael.me...@collabora.com Date: Tue Jan 20 11:25:52 2015 + scaddins: quick fix for conflict on ConvertData. Also used by VCL image plugins - defer the rest to an easy-hack. Mostly impacts mobile which uses scaddins linked without a map file. Change-Id: I49fd40146905f4de42c9b0e7355ab89689c776bf diff --git a/scaddins/source/analysis/analysishelper.hxx b/scaddins/source/analysis/analysishelper.hxx index caf5115..d81017c 100644 --- a/scaddins/source/analysis/analysishelper.hxx +++ b/scaddins/source/analysis/analysishelper.hxx @@ -448,6 +448,7 @@ enum ConvertDataClass class ConvertDataList; +namespace analysis { class ConvertData { @@ -484,6 +485,9 @@ public: inline bool IsPrefixSupport( void ) const; }; +} // namespace analysis + +using namespace ::analysis; class ConvertDataLinear : public ConvertData { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88593] Significant numbers omitted with some column widths
https://bugs.freedesktop.org/show_bug.cgi?id=88593 --- Comment #2 from matti.hav...@gmail.com --- LibreOffice 4.2.3 displays the correct spreadsheet numbers in the same setup (OS X 10.10.1). But LibreOffice 4.3.4 and 4.3.5 omit significant numbers: Depending on the column width 3551,6282571 is displayed as: ,628 1,6283 51,62826 3552 (correct) 3551,6 (correct) 3551,63 (correct) 3551,62826 (correct) Setting Preferences LibreOffice Calc Calculate Limit decimals for general number format ON also displays the correct value for THAT SAVED spreadsheet. Another workaround is to use some other format that GENERAL in the Format Cells... Numbers dialog. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54913] FORMATTING: Table formatting problems
https://bugs.freedesktop.org/show_bug.cgi?id=54913 --- Comment #4 from Wolfgang j...@psilosoph.de --- Just tested M. Schlegel's example under 4.5.3.1. Compared to the original report the behaviour may be changed a bit (not quite sure): The font (or character respectively) properties 'Italic' and 'Strikethrough' were editable and applied correctly. 'Overlining' and 'Underlining' as well, this including an explicitly chosen colour and modifications of the style (like 'double', 'bold', 'dotted'). Still editable and remembered but not correctly applied were the font properties 'Bold' (including the bold modification of 'Italic') and 'Size'. The wrong 'Size' applied, 7 in the example, also showed up using the context menue and then the selecting aid 'Size' while it was set to 18 in the formatting dialogue. Changing the properties under discussion ('Bold', 'Size') on the way over the context menu were correctly applied. They were not taken over by the formatting dialogue. No problem with the other style modifications. A newly created table in the same document did not show any of these flaws. A strange bug whose fixing, however, my have become obsolete as historic. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88578] Paste Special 'Values Only' button should not be highlighted by default
https://bugs.freedesktop.org/show_bug.cgi?id=88578 Thomas Viehmann tv.bugs.freedesktop@beamnet.de changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |tv.bugs.freedesktop.org@bea |desktop.org |mnet.de --- Comment #11 from Thomas Viehmann tv.bugs.freedesktop@beamnet.de --- Created attachment 112526 -- https://bugs.freedesktop.org/attachment.cgi?id=112526action=edit Add can_default to OK button of calc's paste special Hi. Thank you, alex, for putting me in the CC list! I would suspect that something is up with the dialog definition in sc/uiconfig/scalc/ui/pastespecial.ui I will try to test the attached patch. Best regards Thomas -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmlhelp/source
xmlhelp/source/cxxhelp/provider/db.cxx |6 +++--- xmlhelp/source/cxxhelp/provider/urlparameter.cxx |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit 473c20d86ea0cdd1307bfd5c89f89c3ba2c316a1 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 11:31:42 2015 +0100 Some more loplugin:cstylecast: xmlhelp Change-Id: I1aa45f669711a90cce52bafd839bd84eb711436a diff --git a/xmlhelp/source/cxxhelp/provider/db.cxx b/xmlhelp/source/cxxhelp/provider/db.cxx index c8cbbe7..8a834d0 100644 --- a/xmlhelp/source/cxxhelp/provider/db.cxx +++ b/xmlhelp/source/cxxhelp/provider/db.cxx @@ -85,7 +85,7 @@ void Hdf::createHashMap( bool bOptimizeForPerformance ) sal_Int32 nSize = m_xSFA-getSize( m_aFileURL ); sal_Int32 nRead = xIn-readBytes( aData, nSize ); -const char* pData = (const char*)aData.getConstArray(); +const char* pData = reinterpret_castconst char*(aData.getConstArray()); int iPos = 0; while( iPos nRead ) { @@ -173,7 +173,7 @@ bool Hdf::getValueForKey( const OString rKey, HDFData rValue ) sal_Int32 nRead = xIn-readBytes( aData, nValueLen ); if( nRead == nValueLen ) { -const char* pData = (const sal_Char*)aData.getConstArray(); +const char* pData = reinterpret_castconst sal_Char*(aData.getConstArray()); rValue.copyToBuffer( pData, nValueLen ); bSuccess = true; } @@ -218,7 +218,7 @@ bool Hdf::startIteration( void ) if( m_nItRead == nSize ) { bSuccess = true; -m_pItData = (const char*)m_aItData.getConstArray(); +m_pItData = reinterpret_castconst char*(m_aItData.getConstArray()); m_iItPos = 0; } else diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx index 08cdee8..6deea99 100644 --- a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx +++ b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx @@ -370,7 +370,7 @@ public: void addToBuffer( const char* buffer,int len ); -sal_Int8* getData() const { return (sal_Int8*) buffer; } +sal_Int8 const * getData() const { return reinterpret_castsal_Int8 const *(buffer); } sal_Int32 getLen() const { return sal_Int32( len ); } @@ -986,7 +986,7 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam, xmlRegisterInputCallbacks(fileMatch, fileOpen, fileRead, fileClose); xsltStylesheetPtr cur = -xsltParseStylesheetFile((const xmlChar *)xslURLascii.getStr()); +xsltParseStylesheetFile(reinterpret_castconst xmlChar *(xslURLascii.getStr())); xmlDocPtr doc = xmlParseFile(vnd.sun.star.zip:/); @@ -996,7 +996,7 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam, xmlChar *doc_txt_ptr=0; int doc_txt_len; xsltSaveResultToString(doc_txt_ptr, doc_txt_len, res, cur); -addToBuffer((const char*)doc_txt_ptr, doc_txt_len); +addToBuffer(reinterpret_castchar*(doc_txt_ptr), doc_txt_len); xmlFree(doc_txt_ptr); } xmlPopInputCallbacks(); //filePatch ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/opengl
vcl/opengl/gdiimpl.cxx |4 1 file changed, 4 deletions(-) New commits: commit 6cc84edfaf212fd202bc30002869d50f8ca7e53d Author: Chris Sherlock chris.sherloc...@gmail.com Date: Tue Jan 20 10:51:55 2015 + Revert vcl: increment ref in OpenGLSalGraphicsImpl::AcquireContext This reverts commit 3d580990643119cccb73f4f15d549863a6660aa6. Change-Id: Ib16fea0df909d41b2d51d5f3efe44dd4b3419352 Reviewed-on: https://gerrit.libreoffice.org/14033 Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com Tested-by: Chris Sherlock chris.sherloc...@gmail.com diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index 51374b9..bae5302 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -96,11 +96,7 @@ bool OpenGLSalGraphicsImpl::AcquireContext( ) if( pContext ) pContext-AddRef(); else -{ pContext = mbOffscreen ? GetDefaultContext() : CreateWinContext(); -if (pContext) -pContext-AddRef(); -} mpContext = pContext; return (mpContext != NULL); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 71447] File menu takes long time to open when network files on recent documents list are offline
https://bugs.freedesktop.org/show_bug.cgi?id=71447 --- Comment #34 from jmgigan...@libertysurf.fr --- Hi, Same problem here. Win 7 pro x64, LO 4.3.5.2. We use a NAS, so almost all our files are on network. Opening File menu for 1s time is very slow. Sometimes it does not open at all, we need to reselect File Menu (popup instantly). Closing a spreasheet also takes a very long time. After clearing the recent document list, opening of File menu and closing of docuents, are fast. Regards, Jean-Marc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73071] Other: Sidebar: Styles are missing from Properties
https://bugs.freedesktop.org/show_bug.cgi?id=73071 Timur gti...@gmail.com changed: What|Removed |Added Blocks||65351 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86443] Sidebar: Add character and paragraph styles formatting drop-down box to Properties
https://bugs.freedesktop.org/show_bug.cgi?id=86443 Timur gti...@gmail.com changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=65351 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65351] Sidebar: open pane that was active when last used
https://bugs.freedesktop.org/show_bug.cgi?id=65351 Timur gti...@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=86443 | Depends on||73071 Summary|Sidebar: default view is|Sidebar: open pane that was |not Styles and formatting |active when last used --- Comment #15 from Timur gti...@gmail.com --- (In reply to Cor Nouws from comment #14) Then this issue should be blocked /headed by 86443 Bug 86443 - Sidebar: Add character and paragraph styles formatting drop-down box to Properties is a DUPE of Bug 73071 - Other: Sidebar: Styles are missing from Properties. Depends set. And the summary should be radically changed. So much that IMO a new issue is just as good.. Title changed from Sidebar: default view is not Styles and formatting to Sidebar: open pane that was active when last used -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88624] New: Reportbuilder always stores absolute paths for graphics
https://bugs.freedesktop.org/show_bug.cgi?id=88624 Bug ID: 88624 Summary: Reportbuilder always stores absolute paths for graphics Product: LibreOffice Version: 4.3.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Database Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gerhard.scha...@gmx.at Problem description: When adding an image to a report, always the absolute path of the image is stored, independent of the setting Tools Options Load/Save General Save URLs relative to file system. This happens with 4.3.5.2. With 4.4, the report builder, and in turn LibreOffice as well, just freezes and never returns. Steps to reproduce: 1. Insert graphics via file in a report 2. Store the report and the database file 3. Check the odb file with a text editor and search of the file name Current behavior: LibreOffice always stores the absolute path of the graphics and so the database file including the image files are not portable anymore. Expected behavior: Depending on the Save URLs relative to file system, the relative path should be stored, quite like OpenOffice 4.1.1 does it with Oracle Report Builder 1.2.1. Well, one can deselect the report builder during the LibreOffice installation, and install the Oracle Report Builder as extension as workaround, but this is not maintained anymore. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87217] the floating Sidebar moves back onto the side of the window at closing
https://bugs.freedesktop.org/show_bug.cgi?id=87217 --- Comment #22 from Jay Philips philip...@hotmail.com --- Sorry about that. :D Here is the patch for going into 4.4.0. https://gerrit.libreoffice.org/#/c/14037/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88624] Reportbuilder always stores absolute paths for graphics
https://bugs.freedesktop.org/show_bug.cgi?id=88624 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #3 from raal r...@post.cz --- I can confirm with LO 4.3.5, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88593] Significant numbers omitted with some column widths
https://bugs.freedesktop.org/show_bug.cgi?id=88593 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal r...@post.cz --- unable to reproduce with LO .3.5.2, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/grammar.cxx | 50 ++- 1 file changed, 3 insertions(+), 47 deletions(-) New commits: commit 83853b9c86ee867f743b6b1827c6eb6b3a5c21d5 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 10:52:04 2015 +0100 Just use plain memcpy Change-Id: I6f2014f3dfc650a61e8c0dc0bb7d7d4fdb88dbe9 diff --git a/hwpfilter/source/grammar.cxx b/hwpfilter/source/grammar.cxx index 93e7329..bfde898 100644 --- a/hwpfilter/source/grammar.cxx +++ b/hwpfilter/source/grammar.cxx @@ -459,50 +459,6 @@ int yydebug;/* nonzero means print parse trace */ #define YYMAXDEPTH 1 #endif -/* Define __yy_memcpy. Note that the size argument - should be passed with type unsigned int, because that is what the non-GCC - definitions require. With GCC, __builtin_memcpy takes an arg - of type size_t, but it can handle unsigned int. */ - -#if defined(__GNUC__) -#define __yy_memcpy(TO,FROM,COUNT) __builtin_memcpy(TO,FROM,COUNT) -#else -#ifndef __cplusplus - -/* This is the most reliable way to avoid incompatibilities - in available built-in functions on various systems. */ -static void -__yy_memcpy (to, from, count) - char *to; - char *from; - unsigned int count; -{ - char *f = from; - char *t = to; - int i = count; - - while (i-- 0) -*t++ = *f++; -} - -#else /* __cplusplus */ - -/* This is the most reliable way to avoid incompatibilities - in available built-in functions on various systems. */ -static void -__yy_memcpy (char *to, char *from, unsigned int count) -{ - char *t = to; - char *f = from; - int i = count; - - while (i-- 0) -*t++ = *f++; -} - -#endif -#endif - /* The user can define YYPARSE_PARAM as the name of an argument to be passed into yyparse. The argument should have type void *. It should actually point to an object. @@ -660,14 +616,14 @@ yynewstate: yyfree_stacks = 1; #endif yyss = (short *) YYSTACK_ALLOC (yystacksize * sizeof (*yyssp)); - __yy_memcpy (yyss, yyss1, + memcpy (yyss, yyss1, size * (unsigned int) sizeof (*yyssp)); yyvs = (YYSTYPE *) YYSTACK_ALLOC (yystacksize * sizeof (*yyvsp)); - __yy_memcpy (yyvs, yyvs1, + memcpy (yyvs, yyvs1, size * (unsigned int) sizeof (*yyvsp)); #ifdef YYLSP_NEEDED yyls = (YYLTYPE *) YYSTACK_ALLOC (yystacksize * sizeof (*yylsp)); - __yy_memcpy ((char *)yyls, (char *)yyls1, + memcpy ((char *)yyls, (char *)yyls1, size * (unsigned int) sizeof (*yylsp)); #endif #endif /* no yyoverflow */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 46088] Hidden lines become visible after collapsing and expanding of the group
https://bugs.freedesktop.org/show_bug.cgi?id=46088 --- Comment #6 from Valery k...@yandex.ru --- It seems that the subject is really not a bug but an strange feature also present in Excel 2007-2010. In latest builds of LO Calc it present as well (I tested ver. 4.3.3 and 4.3.4). So, if developers decided to leave this illogical behavior for needs of compatibility with Excel ...well let it be. Personally I think that the line status hidden/unhidden must be saved independently of collapsed/expanded status of the group. Quite likely i am wrong. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/opengl/OpenGLContext.cxx |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) New commits: commit 33af00a9ae3136e8aa0fe3183a49681383cd48c7 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Tue Jan 20 12:34:48 2015 +0100 bail out early if there is no Display Change-Id: I1d724ae9346a4df7207e737cf98bf0cd7293bc2b diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 5df70f4..5bd863d 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -730,6 +730,11 @@ bool OpenGLContext::init(Display* dpy, Pixmap pix, unsigned int width, unsigned bool OpenGLContext::ImplInit() { +if (!m_aGLWin.dpy) +{ +return false; +} + GLXContext pSharedCtx( NULL ); #ifdef DBG_UTIL TempErrorHandler aErrorHandler(m_aGLWin.dpy, unxErrorHandler); @@ -767,10 +772,10 @@ bool OpenGLContext::ImplInit() if (!m_aGLWin.ctx) { -if (!m_aGLWin.dpy || !m_aGLWin.vi) +if (!m_aGLWin.vi) return false; -m_aGLWin.ctx = m_aGLWin.dpy == 0 ? 0 : glXCreateContext(m_aGLWin.dpy, +m_aGLWin.ctx = glXCreateContext(m_aGLWin.dpy, m_aGLWin.vi, pSharedCtx, GL_TRUE); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xetable.cxx |2 +- sc/source/filter/inc/xetable.hxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 352cdc8bf8ee7bbb821d1244df6dc35bcc32f52e Author: László Németh laszlo.nem...@collabora.com Date: Tue Jan 20 12:33:37 2015 +0100 fdo#88623 replace std::deque with std::vector in xlsx saving Change-Id: I0b9c44b405e2c617c60e11a1a15eaeb867cba57e diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx index 059d4d9..807ea80 100644 --- a/sc/source/filter/excel/xetable.cxx +++ b/sc/source/filter/excel/xetable.cxx @@ -1226,7 +1226,7 @@ void XclExpMultiCellBase::RemoveUnusedXFIndexes( const ScfUInt16Vec rXFIndexes if( !maXFIds.empty() (maXFIds.front().mnXFIndex == EXC_XF_NOTFOUND) ) { SetXclCol( GetXclCol() + maXFIds.front().mnCount ); -maXFIds.pop_front(); +maXFIds.erase(maXFIds.begin(), maXFIds.begin() + 1); } if( !maXFIds.empty() (maXFIds.back().mnXFIndex == EXC_XF_NOTFOUND) ) maXFIds.pop_back(); diff --git a/sc/source/filter/inc/xetable.hxx b/sc/source/filter/inc/xetable.hxx index 12b6ed2..9e16e77 100644 --- a/sc/source/filter/inc/xetable.hxx +++ b/sc/source/filter/inc/xetable.hxx @@ -22,7 +22,7 @@ #include xltable.hxx -#include deque +#include vector #include tools/mempool.hxx #include xladdress.hxx #include xerecord.hxx @@ -529,7 +529,7 @@ private: virtual voidWriteXmlContents( XclExpXmlStream rStrm, const XclAddress rAddress, sal_uInt32 nXFId, sal_uInt16 nRelCol ) = 0; private: -typedef ::std::deque XclExpMultiXFId XclExpMultiXFIdDeq; +typedef ::std::vector XclExpMultiXFId XclExpMultiXFIdDeq; sal_uInt16 mnMulRecId; /// Record ID for multiple record variant. sal_SizemnContSize; /// Data size of contents for one cell ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 --- Comment #17 from just-me h...@chemie.uni-leipzig.de --- Created attachment 112541 -- https://bugs.freedesktop.org/attachment.cgi?id=112541action=edit strace log of the problem Okay, here is the strace, and it's kind of huge (in my non-developer eyes) and contains unsanitized output. So just opening a file in question (quite the same as given, just containing more pictures on the following pages), scrolling, setting zoom to 200% (screen wide), now even slower, clicking a context menu, slow response, then closing the file and exiting LibO. All that created uncompressed 9 MB of data. Impressive. :) gzipped for your convenience. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 87217] the floating Sidebar moves back onto the side of the window at closing
https://bugs.freedesktop.org/show_bug.cgi?id=87217 --- Comment #22 from Jay Philips philip...@hotmail.com --- Sorry about that. :D Here is the patch for going into 4.4.0. https://gerrit.libreoffice.org/#/c/14037/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 54266] TABLE: Table border tool not precise enough
https://bugs.freedesktop.org/show_bug.cgi?id=54266 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added CC||samuel.rakitni...@gmail.com --- Comment #9 from Chris Wilson ch...@chris-wilson.co.uk --- *** Bug 88626 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: io/source jurt/com
io/source/acceptor/acc_socket.cxx |6 +- io/source/connector/connector.cxx |4 +++- jurt/com/sun/star/lib/connections/socket/socketAcceptor.java |8 jurt/com/sun/star/lib/connections/socket/socketConnector.java |6 +- 4 files changed, 17 insertions(+), 7 deletions(-) New commits: commit c9e6b5854197dd33d4e20ed78aee8382472a0f01 Author: Noel Grandin n...@peralex.com Date: Sun Jan 11 13:54:04 2015 +0200 enable tcpNoDelay for loopback connections automatically it can make a significant speed difference for applications talking to the office binary via UNO Change-Id: If6e901908fe6a6119ac1fd0bf8feebabe5602ff7 Reviewed-on: https://gerrit.libreoffice.org/13856 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/io/source/acceptor/acc_socket.cxx b/io/source/acceptor/acc_socket.cxx index 830a9b3..89fb44d 100644 --- a/io/source/acceptor/acc_socket.cxx +++ b/io/source/acceptor/acc_socket.cxx @@ -380,7 +380,11 @@ namespace io_acceptor { } pConn-completeConnectionString(); -if( m_bTcpNoDelay ) +OUString remoteHostname = pConn-m_addr.getHostname(); +// we enable tcpNoDelay for loopback connections because +// it can make a significant speed difference on linux boxes. +if( m_bTcpNoDelay || remoteHostname == localhost || +remoteHostname.startsWith(127.0.0.) ) { sal_Int32 nTcpNoDelay = sal_True; pConn-m_socket.setOption( osl_Socket_OptionTcpNoDelay , nTcpNoDelay, diff --git a/io/source/connector/connector.cxx b/io/source/connector/connector.cxx index 0aca22c..81bfdb6 100644 --- a/io/source/connector/connector.cxx +++ b/io/source/connector/connector.cxx @@ -132,7 +132,9 @@ namespace stoc_connector delete pConn; throw NoConnectException( sMessage ); } -if( bTcpNoDelay ) +// we enable tcpNoDelay for loopback connections because +// it can make a significant speed difference on linux boxes. +if( bTcpNoDelay || aHost == localhost || aHost.startsWith(127.0.0.) ) { sal_Int32 nTcpNoDelay = sal_True; pConn-m_socket.setOption( osl_Socket_OptionTcpNoDelay , nTcpNoDelay, diff --git a/jurt/com/sun/star/lib/connections/socket/socketAcceptor.java b/jurt/com/sun/star/lib/connections/socket/socketAcceptor.java index e3dbea7..85790df 100644 --- a/jurt/com/sun/star/lib/connections/socket/socketAcceptor.java +++ b/jurt/com/sun/star/lib/connections/socket/socketAcceptor.java @@ -28,9 +28,7 @@ import com.sun.star.lang.XSingleServiceFactory; import com.sun.star.registry.XRegistryKey; import java.io.IOException; -import java.net.InetAddress; -import java.net.ServerSocket; -import java.net.Socket; +import java.net.*; /** * A component that implements the codeXAcceptor/code interface. @@ -152,7 +150,9 @@ public final class socketAcceptor implements XAcceptor { System.err.println(# + getClass().getName() + .accept: accepted + socket); } -if (tcpNoDelay != null) { +// we enable tcpNoDelay for loopback connections because +// it can make a significant speed difference on linux boxes. +if (tcpNoDelay != null || ((InetSocketAddress)socket.getRemoteSocketAddress()).getAddress().isLoopbackAddress()) { socket.setTcpNoDelay(tcpNoDelay.booleanValue()); } return new SocketConnection(acceptingDescription, socket); diff --git a/jurt/com/sun/star/lib/connections/socket/socketConnector.java b/jurt/com/sun/star/lib/connections/socket/socketConnector.java index a0c4937..1d3c2b1 100644 --- a/jurt/com/sun/star/lib/connections/socket/socketConnector.java +++ b/jurt/com/sun/star/lib/connections/socket/socketConnector.java @@ -131,8 +131,10 @@ public final class socketConnector implements XConnector { throw new ConnectionSetupException(e); } Socket socket = null; +boolean isLoopbackAddress = false; for (int i = 0; i adr.length; ++i) { try { +isLoopbackAddress = adr[i].isLoopbackAddress(); socket = new Socket(adr[i], desc.getPort()); break; } catch (IOException e) { @@ -142,7 +144,9 @@ public final class socketConnector implements XConnector { } XConnection con; try { -if (desc.getTcpNoDelay() != null) +// we enable tcpNoDelay for loopback connections because +// it can make a significant speed difference on linux boxes. +if (desc.getTcpNoDelay() != null || isLoopbackAddress)
[Libreoffice-bugs] [Bug 88623] FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 --- Comment #1 from László Németh nem...@numbertext.org --- Created attachment 112537 -- https://bugs.freedesktop.org/attachment.cgi?id=112537action=edit cycle estimation with std::vector -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88576] functions IFNA and IFERROR second argument
https://bugs.freedesktop.org/show_bug.cgi?id=88576 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice |desktop.org |.org --- Comment #5 from Winfried Donkers winfrieddonk...@libreoffice.org --- (In reply to raal from comment #4) Tested iferror with excel2010 and excel doesn't allow to create formula with only one argument, so we should do the same OK, that's clear. I will start working on a fix. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88304] Installer on Win7 in Slovenian not showing sl-SI dictionaries/UI translations checked
https://bugs.freedesktop.org/show_bug.cgi?id=88304 --- Comment #1 from Andras Timar tima...@gmail.com --- I cannot confirm this bug. On Windows 7 64-bit I set Slovenian (Slovenia) at Control Panel - Region and Language - Formats tab - Format. Then I started LibreOffice 4.4.0.1 installer, which was in Slovenian, and Slovenian UI and dictionary was selected. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88621] Undo and Redo dropdown menu in toolbox hides last line
https://bugs.freedesktop.org/show_bug.cgi?id=88621 Maxim Britov ungift...@ya.ru changed: What|Removed |Added Attachment #112532|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88621] New: Undo and Redo dropdown menu in toolbox hides last line
https://bugs.freedesktop.org/show_bug.cgi?id=88621 Bug ID: 88621 Summary: Undo and Redo dropdown menu in toolbox hides last line Product: LibreOffice Version: 4.4.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ungift...@ya.ru Created attachment 112532 -- https://bugs.freedesktop.org/attachment.cgi?id=112532action=edit screenshot When I scroll Undo and Redo dropdown menu I see only part of last line. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82700] EDITING: Unable to select part of a hyperlink
https://bugs.freedesktop.org/show_bug.cgi?id=82700 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #10 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 72266 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72266] EDITING: problems with selecting single charakters in a hyperlink with the mouse
https://bugs.freedesktop.org/show_bug.cgi?id=72266 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||j...@encremento.com --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 82700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88593] Significant numbers omitted with some column widths
https://bugs.freedesktop.org/show_bug.cgi?id=88593 raal r...@post.cz changed: What|Removed |Added Attachment #112490|text/plain |application/x-compressed mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112541|application/octet-stream|application/gzip mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/opengl
vcl/opengl/gdiimpl.cxx |4 1 file changed, 4 insertions(+) New commits: commit 3d580990643119cccb73f4f15d549863a6660aa6 Author: Chris Sherlock chris.sherloc...@gmail.com Date: Tue Jan 20 21:49:30 2015 +1100 vcl: increment ref in OpenGLSalGraphicsImpl::AcquireContext Change-Id: Id8167dfe55eb6f7a83454f5eb7a3b5a96e252980 diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index bae5302..51374b9 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -96,7 +96,11 @@ bool OpenGLSalGraphicsImpl::AcquireContext( ) if( pContext ) pContext-AddRef(); else +{ pContext = mbOffscreen ? GetDefaultContext() : CreateWinContext(); +if (pContext) +pContext-AddRef(); +} mpContext = pContext; return (mpContext != NULL); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 73071] Other: Sidebar: Styles are missing from Properties
https://bugs.freedesktop.org/show_bug.cgi?id=73071 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=65351 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88623] New: FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 Bug ID: 88623 Summary: FILESAVE: slow data structure in XLSX saving Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nem...@numbertext.org Created attachment 112536 -- https://bugs.freedesktop.org/attachment.cgi?id=112536action=edit cycle estimation with std::deque Replacing std::deque with std::vector in XclExpMultiCellBase results 4.5 times difference in the cost of AppendXfld() during the saving of a bigger XLSX document, resulting more than 15% speed up in file saving (kcachegrind screen shots are attached). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source extensions/source filter/source include/comphelper sc/source sw/source vbahelper/source
desktop/source/deployment/dp_services.cxx|6 +- desktop/source/deployment/gui/dp_gui_service.cxx |6 ++ extensions/source/resource/resourceservices.cxx |6 ++ filter/source/graphic/Services.cxx |8 +++- filter/source/svg/svgfilter.cxx |8 +++- include/comphelper/servicedecl.hxx | 12 ++-- sc/source/ui/vba/service.cxx |7 ++- sw/source/ui/vba/service.cxx |7 +-- vbahelper/source/msforms/service.cxx |7 ++- 9 files changed, 18 insertions(+), 49 deletions(-) New commits: commit ea0bb58d98b651599dabf9a93f9568f46c3baeb1 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jan 20 11:05:38 2015 +0100 Drop unused comphelper::service_decl::component_getFactoryHelper params Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337 diff --git a/desktop/source/deployment/dp_services.cxx b/desktop/source/deployment/dp_services.cxx index c38c0a4..53ae196 100644 --- a/desktop/source/deployment/dp_services.cxx +++ b/desktop/source/deployment/dp_services.cxx @@ -72,14 +72,10 @@ extern sdecl::ServiceDecl const serviceDecl; extern C { SAL_DLLPUBLIC_EXPORT void * SAL_CALL deployment_component_getFactory( -sal_Char const * pImplName, -void * pServiceManager, -void * pRegistryKey ) +sal_Char const * pImplName, void *, void *) { return component_getFactoryHelper( pImplName, -static_castcss::lang::XMultiServiceFactory *(pServiceManager), -static_castcss::registry::XRegistryKey *(pRegistryKey), dp_registry::backend::configuration::serviceDecl, dp_registry::backend::component::serviceDecl, dp_registry::backend::help::serviceDecl, diff --git a/desktop/source/deployment/gui/dp_gui_service.cxx b/desktop/source/deployment/gui/dp_gui_service.cxx index 1063f7c..9efb027 100644 --- a/desktop/source/deployment/gui/dp_gui_service.cxx +++ b/desktop/source/deployment/gui/dp_gui_service.cxx @@ -330,12 +330,10 @@ sdecl::ServiceDecl const updateDecl( extern C { SAL_DLLPUBLIC_EXPORT void * SAL_CALL deploymentgui_component_getFactory( -sal_Char const * pImplName, -void * pServiceManager, -void * pRegistryKey ) +sal_Char const * pImplName, void *, void *) { return component_getFactoryHelper( -pImplName, static_castcss::lang::XMultiServiceFactory *(pServiceManager), static_castcss::registry::XRegistryKey *(pRegistryKey), dp_gui::serviceDecl, dp_gui::licenseDecl, dp_gui::updateDecl ); +pImplName, dp_gui::serviceDecl, dp_gui::licenseDecl, dp_gui::updateDecl ); } } // extern C diff --git a/extensions/source/resource/resourceservices.cxx b/extensions/source/resource/resourceservices.cxx index f8e1f5e..d25ecd5 100644 --- a/extensions/source/resource/resourceservices.cxx +++ b/extensions/source/resource/resourceservices.cxx @@ -30,11 +30,9 @@ const sdecl::ServiceDecl OpenOfficeResourceLoaderDecl( com.sun.star.resource.OfficeResourceLoader); extern C SAL_DLLPUBLIC_EXPORT void* SAL_CALL res_component_getFactory( -sal_Char const* pImplName, -::com::sun::star::lang::XMultiServiceFactory* pServiceManager, -::com::sun::star::registry::XRegistryKey* pRegistryKey ) +sal_Char const* pImplName, void*, void*) { -return component_getFactoryHelper( pImplName, pServiceManager, pRegistryKey, +return component_getFactoryHelper( pImplName, ResourceIndexAccessDecl, OpenOfficeResourceLoaderDecl ); } diff --git a/filter/source/graphic/Services.cxx b/filter/source/graphic/Services.cxx index 35cf5d7..87d0268 100644 --- a/filter/source/graphic/Services.cxx +++ b/filter/source/graphic/Services.cxx @@ -38,17 +38,15 @@ const comphelper::service_decl::ServiceDecl graphicExportDialog( extern C SAL_DLLPUBLIC_EXPORT void* SAL_CALL graphicfilter_component_getFactory( -sal_Char const* pImplementationName, -::com::sun::star::lang::XMultiServiceFactory* pServiceManager, -::com::sun::star::registry::XRegistryKey* pRegistryKey ) +sal_Char const* pImplementationName, void*, void*) { if ( rtl_str_compare (pImplementationName, GRAPHIC_EXPORT_FILTER_SERVICE) == 0 ) { -return component_getFactoryHelper( pImplementationName, pServiceManager, pRegistryKey, graphicExportFilter ); +return component_getFactoryHelper( pImplementationName, graphicExportFilter ); } else if ( rtl_str_compare (pImplementationName, GRAPHIC_EXPORT_DIALOG_SERVICE) == 0 ) { -return component_getFactoryHelper( pImplementationName, pServiceManager, pRegistryKey, graphicExportDialog ); +return component_getFactoryHelper( pImplementationName, graphicExportDialog ); } return NULL; } diff --git a/filter/source/svg/svgfilter.cxx b/filter/source/svg/svgfilter.cxx index 4da9382..e44c37d 100644 --- a/filter/source/svg/svgfilter.cxx +++ b/filter/source/svg/svgfilter.cxx
[Libreoffice-bugs] [Bug 82674] PDF: Export-as-PDF during Page Preview corrupts display (2 overlapping images)
https://bugs.freedesktop.org/show_bug.cgi?id=82674 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||regression CC||fdb...@neosheffield.co.uk Hardware|Other |All Version|4.2.5.2 release |3.5.6.2 release Whiteboard|BSA |BSA preBibisect OS|Linux (All) |All --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- Not reproduced on 3.3.0, but seems to have started before the start of the 43all bibisect repository (next oldest release I have handy is 3.5.6.2, where the bug is present). Also reproducible on OSX. Setting: - Platform: All - Version: 3.5.6.2 - Keywords: regression - Whiteboard: preBibisect -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 6 commits - include/vcl vcl/opengl vcl/source
include/vcl/opengl/OpenGLContext.hxx | 11 include/vcl/virdev.hxx |3 -- vcl/opengl/gdiimpl.cxx | 16 vcl/source/app/svdata.cxx|6 vcl/source/app/svmain.cxx|6 vcl/source/opengl/OpenGLContext.cxx | 44 --- 6 files changed, 76 insertions(+), 10 deletions(-) New commits: commit 229891d6cbc24f9e6291d8057d0d51326b059d9b Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Tue Jan 20 12:00:59 2015 +0100 lets do that before we delete our object Change-Id: I8c7166ba66f74f5c548bb6fb30dfc3d28880e9a2 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index d237249..5df70f4 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -114,13 +114,14 @@ void OpenGLContext::AddRef(SalGraphicsImpl* pImpl) void OpenGLContext::DeRef(SalGraphicsImpl* pImpl) { -assert(mnRefCount 0); -if( --mnRefCount == 0 ) -delete this; auto it = maParents.find(pImpl); if(it != maParents.end()) maParents.erase(it); + +assert(mnRefCount 0); +if( --mnRefCount == 0 ) +delete this; } #else void OpenGLContext::AddRef() commit 145ad1964389d363e389490be4b9acad1b6b7b99 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Tue Jan 20 04:12:18 2015 +0100 some debug code for finding leaked OpenGLContexts Change-Id: I10e8c344ae6aa2e0a4ef562154f57e2070c70e2f diff --git a/include/vcl/opengl/OpenGLContext.hxx b/include/vcl/opengl/OpenGLContext.hxx index 18fc710..0178e21 100644 --- a/include/vcl/opengl/OpenGLContext.hxx +++ b/include/vcl/opengl/OpenGLContext.hxx @@ -56,9 +56,12 @@ class NSOpenGLView; #include tools/gen.hxx #include vcl/syschild.hxx +#include set + class OpenGLFramebuffer; class OpenGLProgram; class OpenGLTexture; +class SalGraphicsImpl; /// Holds the information of our new child window struct GLWindow @@ -189,8 +192,13 @@ public: bool AcquireDefaultFramebuffer(); OpenGLFramebuffer* AcquireFramebuffer( const OpenGLTexture rTexture ); void ReleaseFramebuffer( OpenGLFramebuffer* pFramebuffer ); +#ifdef DBG_UTIL +void AddRef(SalGraphicsImpl*); +void DeRef(SalGraphicsImpl*); +#else void AddRef(); void DeRef(); +#endif void ReleaseFramebuffer( const OpenGLTexture rTexture ); void ReleaseFramebuffers(); @@ -260,6 +268,9 @@ private: boost::ptr_mapProgramKey, OpenGLProgram maPrograms; OpenGLProgram* mpCurrentProgram; +#ifdef DBG_UTIL +std::setSalGraphicsImpl* maParents; +#endif public: vcl::Region maClipRegion; diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index bae5302..da2ace3 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -80,7 +80,11 @@ bool OpenGLSalGraphicsImpl::AcquireContext( ) { if( mpContext-isInitialized() ) return true; +#ifdef DBG_UTIL +mpContext-DeRef(this); +#else mpContext-DeRef(); +#endif } @@ -94,7 +98,13 @@ bool OpenGLSalGraphicsImpl::AcquireContext( ) } if( pContext ) +{ +#ifdef DBG_UTIL +pContext-AddRef(this); +#else pContext-AddRef(); +#endif +} else pContext = mbOffscreen ? GetDefaultContext() : CreateWinContext(); @@ -105,7 +115,13 @@ bool OpenGLSalGraphicsImpl::AcquireContext( ) bool OpenGLSalGraphicsImpl::ReleaseContext() { if( mpContext ) +{ +#ifdef DBG_UTIL +mpContext-DeRef(this); +#else mpContext-DeRef(); +#endif +} mpContext = NULL; return true; } diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx index c539a76..155b5cc 100644 --- a/vcl/source/app/svdata.cxx +++ b/vcl/source/app/svdata.cxx @@ -130,7 +130,13 @@ vcl::Window* ImplGetDefaultWindow() // Add a reference to the default context so it never gets deleted OpenGLContext* pContext = pSVData-mpDefaultWin-GetGraphics()-GetOpenGLContext(); if( pContext ) +{ +#ifdef DBG_UTIL +pContext-AddRef(NULL); +#else pContext-AddRef(); +#endif +} } Application::GetSolarMutex().release(); } diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx index 8ae3592..c0979a6 100644 --- a/vcl/source/app/svmain.cxx +++ b/vcl/source/app/svmain.cxx @@ -444,7 +444,13 @@ void DeInitVCL() { OpenGLContext* pContext = pSVData-mpDefaultWin-GetGraphics()-GetOpenGLContext(); if( pContext ) +{ +#ifdef DBG_UTIL +pContext-DeRef(NULL); +#else pContext-DeRef(); +#endif +} delete pSVData-mpDefaultWin; pSVData-mpDefaultWin = NULL; } diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 32d2c28..d237249
[Libreoffice-bugs] [Bug 55384] Reduce Bitmap option is ignored
https://bugs.freedesktop.org/show_bug.cgi?id=55384 --- Comment #5 from markus.m...@kdwelt.de --- Tried with LO 4.3.5.2 on a Debian 8 amd64 system. Problem still exists. Print to file gives the same filesize, regardless Reduce bitmaps settings. The URL in comment 1 has changed to: http://fserver.alburg.selfhost.me/LO-55384/MyCat.zip -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - include/sal svtools/source
include/sal/log-areas.dox |1 + svtools/source/brwbox/brwbox2.cxx |7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) New commits: commit c147a110d6d9bc1de0ebf79638751dd360317fc4 Author: Lionel Elie Mamane lio...@mamane.lu Date: Mon Jan 19 11:44:55 2015 +0100 fixup previous commit for fdo#88475 OSL_ENSURE does not execute in non-debug builds (and is deprecated). Do not try to seek back if paint did not seek. This happens in particular when there is no data source attached (and thus trying to seek fails). Change-Id: I3f4908c4dcae2bb120bf58c1218e3386c40d5721 (cherry picked from commit e8a68c1f50f32a0f9d8bcdf16c1270c319910baa) Reviewed-on: https://gerrit.libreoffice.org/14028 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox index 62525e4..d42c8c2 100644 --- a/include/sal/log-areas.dox +++ b/include/sal/log-areas.dox @@ -289,6 +289,7 @@ certain functionality. @section svtools @li @c svtools +@li @c svtools.brwbox @li @c svtools.config @li @c svtools.contnr @li @c svtools.control diff --git a/svtools/source/brwbox/brwbox2.cxx b/svtools/source/brwbox/brwbox2.cxx index eacb2a8..9ea9031 100644 --- a/svtools/source/brwbox/brwbox2.cxx +++ b/svtools/source/brwbox/brwbox2.cxx @@ -887,6 +887,7 @@ void BrowseBox::ImplPaintData(OutputDevice _rOut, const Rectangle _rRect, bool Color aDelimiterLineColor( ::svtools::ColorConfig().GetColorValue( ::svtools::CALCGRID ).nColor ); // redraw the invalid fields +bool paint_seeked(false); for ( sal_uLong nRelRow = nRelTopRow; nRelRow = nRelBottomRow (sal_uLong)nTopRow+nRelRow (sal_uLong)nRowCount; ++nRelRow, aPos.Y() += nDataRowHeigt ) @@ -899,6 +900,7 @@ void BrowseBox::ImplPaintData(OutputDevice _rOut, const Rectangle _rRect, bool // prepare row sal_uLong nRow = nTopRow+nRelRow; +paint_seeked = true; if ( !SeekRow( nRow) ) { OSL_FAIL(BrowseBox::ImplPaintData: SeekRow failed); } @@ -1031,7 +1033,10 @@ void BrowseBox::ImplPaintData(OutputDevice _rOut, const Rectangle _rRect, bool } } -OSL_ENSURE(SeekRow(nCurRow), BrowseBox::ImplPaintData could not seek back to current row after paint); +if (paint_seeked !SeekRow(nCurRow)) +{ +SAL_WARN(svtools.brwbox, BrowseBox::ImplPaintData could not seek back to current row after paint); +} if (aPos.Y() aOverallAreaBRPos.Y() + 1) aPos.Y() = aOverallAreaBRPos.Y() + 1; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88624] Reportbuilder always stores absolute paths for graphics
https://bugs.freedesktop.org/show_bug.cgi?id=88624 --- Comment #2 from schaber gerhard.scha...@gmx.at --- See also https://issues.apache.org/ooo/show_bug.cgi?id=96013. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/priorities' - include/vcl vcl/source
include/vcl/idle.hxx| 23 +-- vcl/source/app/idle.cxx | 29 + 2 files changed, 30 insertions(+), 22 deletions(-) New commits: commit bc637c2096621061d1a5dc37aaebc657f195ac7f Author: Jennifer Liebel jliebe...@gmail.com Date: Tue Jan 20 12:42:43 2015 + insert comments and corrected priority values Change-Id: I2c73bb2b2edd3b830dad5d1f7d8f7bc72622b11c diff --git a/include/vcl/idle.hxx b/include/vcl/idle.hxx index 5a46462..0415575 100644 --- a/include/vcl/idle.hxx +++ b/include/vcl/idle.hxx @@ -27,18 +27,20 @@ struct ImplIdleData; struct ImplSVData; -// The timemarks behind the priorities is the catgorizing of timer to idle +// The timemarks behind the priorities are need to change timer to idle. It is to convert +// timeout values to priorities. enum class IdlePriority { -VCL_IDLE_PRIORITY_STARVATIONPROTECTION = -1, // Do not use this for normal prioritizing -VCL_IDLE_PRIORITY_HIGHEST = 0, // - 0ms -VCL_IDLE_PRIORITY_HIGH = 1,// - 1ms -VCL_IDLE_PRIORITY_DEFAULT = 1,// - 1ms -VCL_IDLE_PRIORITY_REPAINT = 2, // - 30ms +VCL_IDLE_PRIORITY_STARVATIONPROTECTION = -1, // Do not use this for normal prioritizing! + +VCL_IDLE_PRIORITY_HIGHEST = 0, // - 0ms +VCL_IDLE_PRIORITY_HIGH = 1, // - 1ms +VCL_IDLE_PRIORITY_DEFAULT = 1, // - 1ms +VCL_IDLE_PRIORITY_REPAINT = 2, // - 30ms VCL_IDLE_PRIORITY_RESIZE= 3, // - 50ms VCL_IDLE_PRIORITY_MEDIUM= 3, // - 50ms -VCL_IDLE_PRIORITY_LOW = 5, // - 100ms -VCL_IDLE_PRIORITY_LOWER = 6, // - 200ms -VCL_IDLE_PRIORITY_LOWEST= 7 // - 400ms +VCL_IDLE_PRIORITY_LOW = 4, // - 100ms +VCL_IDLE_PRIORITY_LOWER = 5, // - 200ms +VCL_IDLE_PRIORITY_LOWEST= 6 // - 400ms }; @@ -65,8 +67,9 @@ public: /// Make it possible to associate a callback with this idle handler /// of course, you can also sub-class and override 'DoIdle' voidSetIdleHdl( const Link rLink ) { maIdleHdl = rLink; } -const Link GetIdleHdl() const { return maIdleHdl; } +const Link GetIdleHdl() const { return maIdleHdl; } +// Call idle handler virtual voidDoIdle(); voidStart(); diff --git a/vcl/source/app/idle.cxx b/vcl/source/app/idle.cxx index 6ad03d2..37299de 100644 --- a/vcl/source/app/idle.cxx +++ b/vcl/source/app/idle.cxx @@ -26,9 +26,9 @@ struct ImplIdleData { -ImplIdleData* mpNext; // Pointer to the next Instance -Idle* mpIdle;// Pointer to VCL Idle instance -boolmbDelete; // Was Idle deleted during Update()? +ImplIdleData* mpNext; // Pointer to the next Instance +Idle* mpIdle; // Pointer to VCL Idle instance +boolmbDelete;// Was Idle deleted during Update()? boolmbInIdle;// Are we in a idle handler? void Invoke() @@ -60,6 +60,9 @@ struct ImplIdleData else { // Find the highest priority. +// If the priority of the current idle is higher (numerical value is lower) than +// the priority of the most urgent, the priority of most urgent is increased and +// the current is the new most urgent. So starving is impossible. if ( p-mpIdle-GetPriority() pMostUrgent-mpIdle-GetPriority() ) { IncreasePriority(pMostUrgent-mpIdle); @@ -77,7 +80,8 @@ struct ImplIdleData { switch(pIdle-GetPriority()) { -// Increase priority based on their current priority +// Increase priority based on their current priority; +// (so don't use VCL_IDLE_PRIORITY_STARVATIONPROTECTION for default-priority!) case IdlePriority::VCL_IDLE_PRIORITY_STARVATIONPROTECTION: break; // If already highest priority - extra state for starving tasks @@ -132,10 +136,11 @@ void Idle::ImplDeInitIdle() void Idle::ProcessAllIdleHandlers() { -// process all pending Idle +// process all pending idle ImplIdleData* pIdleData = NULL; ImplIdleData* pPrevIdleData = NULL; ImplSVData* pSVData = ImplGetSVData(); +// timer can interrupt idle while (!Timer::TimerReady() (pIdleData = ImplIdleData::GetFirstIdle())) { pIdleData-Invoke(); @@ -144,7 +149,7 @@ void Idle::ProcessAllIdleHandlers() pIdleData = pSVData-mpFirstIdleData; while ( pIdleData ) { -// Was Idle destroyed in the meantime? +// Was idle destroyed in the meantime? if ( pIdleData-mbDelete ) { if ( pPrevIdleData ) @@
[Libreoffice-bugs] [Bug 80680] SOLVER crashing CALC
https://bugs.freedesktop.org/show_bug.cgi?id=80680 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Keywords||have-backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80680] SOLVER crashing CALC
https://bugs.freedesktop.org/show_bug.cgi?id=80680 --- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 112546 -- https://bugs.freedesktop.org/attachment.cgi?id=112546action=edit full bt Full backtrace with master 4500alpha -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58624] SwAccessibleParagraph - SwAccessibleMap lifetime mismatch
https://bugs.freedesktop.org/show_bug.cgi?id=58624 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Stephan Bergmann sberg...@redhat.com --- ...so tentatively close as WORKSFORME for now; doesn't help much to have this issue remain open for years anyway -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[SOLVED] Re: cppcheck: arrayIndexOutOfBounds report in stortree.cxx (store module)
Thank you Stephan, I didn't know this. (about the loop, sorry for mystupid confusion! :-)) -- View this message in context: http://nabble.documentfoundation.org/cppcheck-arrayIndexOutOfBounds-report-in-stortree-cxx-store-module-tp4136432p4136757.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 65351] Sidebar: default view is not Styles and formatting
https://bugs.freedesktop.org/show_bug.cgi?id=65351 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=73071 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: scaddins/source
scaddins/source/analysis/analysishelper.hxx |4 1 file changed, 4 insertions(+) New commits: commit b398945d08bdab0de5f22b06c91686569942e668 Author: Michael Meeks michael.me...@collabora.com Date: Tue Jan 20 11:25:52 2015 + scaddins: quick fix for conflict on ConvertData. Also used by VCL image plugins - defer the rest to an easy-hack. Mostly impacts mobile which uses scaddins linked without a map file. Change-Id: I49fd40146905f4de42c9b0e7355ab89689c776bf diff --git a/scaddins/source/analysis/analysishelper.hxx b/scaddins/source/analysis/analysishelper.hxx index caf5115..d81017c 100644 --- a/scaddins/source/analysis/analysishelper.hxx +++ b/scaddins/source/analysis/analysishelper.hxx @@ -448,6 +448,7 @@ enum ConvertDataClass class ConvertDataList; +namespace analysis { class ConvertData { @@ -484,6 +485,9 @@ public: inline bool IsPrefixSupport( void ) const; }; +} // namespace analysis + +using namespace ::analysis; class ConvertDataLinear : public ConvertData { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 --- Comment #14 from just-me h...@chemie.uni-leipzig.de --- Here is soffice --backtrace output # cat ./gdbtrace.log warning: Currently logging to gdbtrace.log. Turn the logging off and on to make the new setting effective. warning: Could not load shared library symbols for linux-vdso.so.1. Do you need set solib-search-path or set sysroot? [Thread debugging using libthread_db enabled] Using host libthread_db library /lib64/libthread_db.so.1. [New Thread 0x7fffec0e7700 (LWP 6223)] [New Thread 0x7fffddc00700 (LWP 6224)] [New Thread 0x7fffdd3ff700 (LWP 6225)] [New Thread 0x7fffd716c700 (LWP 6226)] [New Thread 0x7fffd5bd1700 (LWP 6227)] [Thread 0x7fffddc00700 (LWP 6224) exited] [New Thread 0x7fffddc00700 (LWP 6230)] [New Thread 0x7fffc92a1700 (LWP 6231)] [Thread 0x7fffc92a1700 (LWP 6231) exited] [Thread 0x7fffddc00700 (LWP 6230) exited] [New Thread 0x7fffddc00700 (LWP 6232)] [Thread 0x7fffddc00700 (LWP 6232) exited] [New Thread 0x7fffddc00700 (LWP 6279)] [Thread 0x7fffddc00700 (LWP 6279) exited] [New Thread 0x7fffddc00700 (LWP 6281)] [New Thread 0x7fffc92a1700 (LWP 6282)] [Thread 0x7fffc92a1700 (LWP 6282) exited] [Thread 0x7fffddc00700 (LWP 6281) exited] [New Thread 0x7fffddc00700 (LWP 6324)] [Thread 0x7fffd5bd1700 (LWP 6227) exited] [Thread 0x7fffddc00700 (LWP 6324) exited] [Thread 0x7fffdd3ff700 (LWP 6225) exited] [Thread 0x7fffd716c700 (LWP 6226) exited] [Thread 0x7fffec0e7700 (LWP 6223) exited] [Inferior 1 (process 6218) exited normally] /usr/lib64/libreoffice/program/gdbtrace:9: Error in sourced command file: No stack. Quit [EOF] Had to emerge gdb first. Should I enable vDSO options in kernel config? Not really much output but if that helps... Also attached 2 odt files (JPEG_one.odt and PNG_one.odt), one with one of the images as JPEG, perfect scrolling, and one with PNG which slows down, especially at zoom so far that also menus (context, file menu etc.) become slow in responsiveness. Is there any other way of tracing the behaviour of LibO? I remember that cairo-trace could follow some renderings happening in LibO. Will emerge and check w. strace next. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88623] FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:4.5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82922] Word 2003 document (.doc) can't be opened after saving it as .odt (possibly because of comments)
https://bugs.freedesktop.org/show_bug.cgi?id=82922 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |WORKSFORME Whiteboard|BSA |BSA backportRequest:4.3 OS|Linux (All) |All --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- Already fixed in 4.4.0.2 and 4.5 master, but not 4.3 Without actually building to check, the bibisect range contains the below commits which look potentially relevant. Setting Platform - All Status - RESOLVED WORKSFORME Whiteboard: backportRequest:4.3 commit 0ec0ec267986644084baaa5bda5ba917dc5744df Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Dec 30 18:49:04 2014 +0100 i#93570 DOC import: handle commented text ranges via RES_FLTR_ANNOTATIONMARK ... commit 677fdd4fa235466649911042577bc4980d42deb6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Dec 30 10:46:26 2014 +0100 i#93570 DOC import: tokenize PlcfAtnBkf and PlcfAtnBkl ... commit 271722d923610d128a358528e64d7233641ea0dc Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Dec 30 10:32:16 2014 +0100 i#93570 sw: add RES_FLTR_ANNOTATIONMARK ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88623] FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- László Németh committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=352cdc8bf8ee7bbb821d1244df6dc35bcc32f52e fdo#88623 replace std::deque with std::vector in xlsx saving It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 --- Comment #16 from just-me h...@chemie.uni-leipzig.de --- Created attachment 112539 -- https://bugs.freedesktop.org/attachment.cgi?id=112539action=edit file with the embedded picture in PNG, heavy slowdown -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 --- Comment #15 from just-me h...@chemie.uni-leipzig.de --- Created attachment 112538 -- https://bugs.freedesktop.org/attachment.cgi?id=112538action=edit file with the embedded picture in JPEG, no slowdown -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Solved: 4.4.0.1 build error on libstdc++ on solaris/illumos
Because our default gcc is 4.4.7 on XStreamOS, but I'm building with gcc 4.7, installed as an added option under /usr/gcc/4.7, I had to patch solaris.mk to link there, so here is the patch I'm using. What do you suggest in this case? --- libreoffice-4.4.0.1/solenv/gbuild/platform/solaris.mk Sat Jan 17 10:36:18 2015 +++ libreoffice-4.4.0.1/solenv/gbuild/platform/solaris.mk.new Tue Jan 20 12:33:59 2015 @@ -65,6 +65,7 @@ endif gb_LinkTarget_LDFLAGS += \ + -L$(SYSBASE)/usr/gcc/4.7/lib \ -L$(SYSBASE)/lib \ -L$(SYSBASE)/usr/lib \ -Wl,-z,combreloc \ @@ -83,11 +84,11 @@ endif -ifneq ($(gb_DEBUGLEVEL),0) -gb_LINKEROPTFLAGS := -else -gb_LINKEROPTFLAGS := -Wl,-O1 -endif +#ifneq ($(gb_DEBUGLEVEL),0) +#gb_LINKEROPTFLAGS := +#else +#gb_LINKEROPTFLAGS := -Wl,-O1 +#endif ifeq ($(gb_SYMBOL),$(true)) gb_LINKERSTRIPDEBUGFLAGS := @@ -198,6 +199,7 @@ -lm \ -lnsl \ -lsocket \ + -lstdc++ \ gb_Library_FILENAMES := \ $(foreach lib,$(gb_Library_OOOLIBS),$(lib):$(gb_Library_SYSPRE)$(lib)$(gb_Library_OOOEXT)) \ Da: Gabriele Bulfon A: Richard PALO Norbert Thiebaud Cc: Michael Stahl libreoffice Data: 19 gennaio 2015 13.30.25 CET Oggetto: 4.4.0.1 build error on libstdc++ on solaris/illumos Ok, now build goes on. Tried to figure out this, looks like libstdc++ is not correctly linked: Undefined first referenced symbol in file std::basic_string , std::allocator ::basic_string(std::basic_string , std::allocator ) /sources/sonicle/xstream-desktop-gate/components/libreoffice/libreoffice/libreoffice-4.4.0.2/workdir/CxxObject/l10ntools/source/idxdict/idxdict.o ld: fatal: symbolreferencing errors. No output written to /sources/sonicle/xstream-desktop-gate/components/libreoffice/libreoffice/libreoffice-4.4.0.2/workdir/LinkTarget/Executable/idxdict collect2: error: ld returned 1 exit status -- Da: Richard PALO A: gbul...@sonicle.com Norbert Thiebaud Cc: Michael Stahl libreoffice Data: 18 gennaio 2015 22.56.51 CET Oggetto: Re: 4.4.0.1 build error on sal/types.h on solaris/illumos -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 18/01/15 21:33, Gabriele Bulfon a écrit : Ok, I commented out these on Solaris.mk: #ifneq ($(gb_DEBUGLEVEL),0) #gb_LINKEROPTFLAGS := #else #gb_LINKEROPTFLAGS := -Wl,-O1 #endif will let you know :) -- Da: Norbert Thiebaud A: gbul...@sonicle.com Cc: Michael Stahl libreoffice Richard PALO Data: 18 gennaio 2015 20.15.22 CET Oggetto: Re: 4.4.0.1 build error on sal/types.h on solaris/illumos On Sun, Jan 18, 2015 at 12:18 PM, Gabriele Bulfon wrote: Ok, I checked and it looks fine, so solaris.mk should be taken. Also config.log shows correct variables for OS, CPU and COM. What actually happens is during make, after it has downloaded and extracted various stuff. The last one is translations file. Then it goes on building concat-deps, and linking fails: [build C ] solenv/bin/concat-deps.c [build LNK] Executable/concat-deps ld: fatal: unrecognized option '-O' ld: fatal: unrecognized option '-1' ld: fatal: use the -z help option for usage information collect2: error: ld returned 1 exit status Maybe just concat-deps have problems linking with wrong options on Solaris? Yes it is quite possible... concat-deps is a small utility I wrote to speed up the original perl-based one... and I'm quite sure I never tried to link it on Solaris. Otoh concat-deps is built using the standard gbuild mechanism for that: see solenv/Executable_concat-deps.mk so it is more likely that the problem is generic and that concat-deps just happen to be the first one to be linked. BTW, is there any way to issue gmake and let it show what command LNK is doing? It tried forcing a -n but I did not get the command debugged verbose=t make Norbert Yeah, this should go as not valid for solaris ld. Apparently comes from here: commit 3c4cd1deaf71d0d800957b3580d426c721bf7844 Author: Jonathan Adams Date: Fri Mar 16 21:50:37 2012 +0100 gbuild: switch solaris.mk to GCC -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJUvCwiAAoJECAB22fHtp27MBMH/2IYZRT44q8six0NjeXYkG6B vDe0AJund3FTcN/t9zT0bpFx9mPCCdVxWbqqdv0CFKYQrfSLhPRaksuWrAnK1mOI Nl5vcDxI8D0ls6N1c40ZIAcpI3mOeY1Xye6rpKwYJSjWxqOZHxgWEMMvIrzd9Jxb wnChiTHrDj4ljX1QCPWLxJQB0+e3gXrFmcLvQSEhIPslGPou4i14ur3tf2vVwk0a FZzCoiYfCnUil7vQJHA8vUtbVASMxX4sJ6iYOfD0K/Z+11c4PwF4xZZtZCtG6Rek qLd/Yz/OhqIg2POqJeaDL8S9fYOfrWUgfKuwcFhqBgqDQMknQH8DSeJt6IPAea0= =ZdNh -END PGP SIGNATURE- ___LibreOffice mailing listLibreOffice@lists.freedesktop.orghttp://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112539|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #111972|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #111973|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.freedesktop.org/show_bug.cgi?id=87485 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112538|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55018] FILESAVE: Joined cells in table cause table distortion after save to DOC, DOCX (example in Comment 3)
https://bugs.freedesktop.org/show_bug.cgi?id=55018 Timur gti...@gmail.com changed: What|Removed |Added CC||gti...@gmail.com See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=42668 | Summary|FILESAVE and FILEOPEN: |FILESAVE: Joined cells in |Joined cells in table cause |table cause table |table distortion after save |distortion after save to |to doc and docx and reopen |DOC, DOCX (example in |in LO |Comment 3) --- Comment #14 from Timur gti...@gmail.com --- Problem with example from Comment 0 cannot be reproduced anymore. Title changed from FILESAVE and FILEOPEN: Joined cells in table cause table distortion after save to doc and docx and reopen in LO to FILESAVE: Joined cells in table cause table distortion after save to DOC, DOCX (example in Comment 3) (In reply to Kevin Suo from comment #7) When save sasha.libreoffice's test file as docx, it totally in a mess Still so with LO 4.4.0. the page became portrait rather than landscape. This may be some other bug, like Bug 88267 - Page orientation doesn't export to .doc/.docx. Just for a reference and a test. (In reply to sasha.libreoffice from comment #4) changing version to 3.6.0 as most early reproduced This has never worked fine. So, doesn't seem to be a regression as marked. Looks inherited from OO for doc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42668] FORMATTING: TABLE: crash when adding column to a table containing merged cells in .docx [no backtrace yet]
https://bugs.freedesktop.org/show_bug.cgi?id=42668 Timur gti...@gmail.com changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=55018 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82553] FILEOPEN: Wrong import of DOCX with table (Summary in Comment 3)
https://bugs.freedesktop.org/show_bug.cgi?id=82553 Timur gti...@gmail.com changed: What|Removed |Added Keywords||regression Version|4.3.0.4 release |4.0.0.0 beta1 --- Comment #6 from Timur gti...@gmail.com --- I change Version to 4.0 beta which is the first after proper preview with LO 3.6.7.2. I also add Regression. That version looks close to MS Office except bottom margin that differs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f1/c5f03d2e6e93739538b0f8afb7a0babaf62dd0
f1/c5f03d2e6e93739538b0f8afb7a0babaf62dd0 |1 + 1 file changed, 1 insertion(+) New commits: commit eef12440832870076f5c7705004a483b97e9 Author: Caolán McNamara caol...@redhat.com Date: Tue Jan 20 13:36:42 2015 + Notes added by 'git notes add' diff --git a/f1/c5f03d2e6e93739538b0f8afb7a0babaf62dd0 b/f1/c5f03d2e6e93739538b0f8afb7a0babaf62dd0 new file mode 100644 index 000..8a2345e --- /dev/null +++ b/f1/c5f03d2e6e93739538b0f8afb7a0babaf62dd0 @@ -0,0 +1 @@ +ignore: fixed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 38889] Make macro editing easier
https://bugs.freedesktop.org/show_bug.cgi?id=38889 --- Comment #12 from Amit Chaudhary amitchaudhary1994...@gmail.com --- hi I want to work on this , its my first bug ! can someone please guide me for this? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 2c/11fc40e0500da7fc217e1bc1290adfdccab82f
2c/11fc40e0500da7fc217e1bc1290adfdccab82f |1 + 1 file changed, 1 insertion(+) New commits: commit f545014ce1cd454506caef9b5b0fb57e987c3a5c Author: Caolán McNamara caol...@redhat.com Date: Tue Jan 20 13:42:19 2015 + Notes added by 'git notes add' diff --git a/2c/11fc40e0500da7fc217e1bc1290adfdccab82f b/2c/11fc40e0500da7fc217e1bc1290adfdccab82f new file mode 100644 index 000..a0c185d --- /dev/null +++ b/2c/11fc40e0500da7fc217e1bc1290adfdccab82f @@ -0,0 +1 @@ +merged as: d8915be647a85e6c20763febc28f015e6e11c688 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 38889] Make macro editing easier
https://bugs.freedesktop.org/show_bug.cgi?id=38889 --- Comment #12 from Amit Chaudhary amitchaudhary1994...@gmail.com --- hi I want to work on this , its my first bug ! can someone please guide me for this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88593] Significant numbers omitted with some column widths
https://bugs.freedesktop.org/show_bug.cgi?id=88593 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- @Matti : are you using a 32bit version of LO on OSX ? What locale are you using ? Setting to NEEDINFO, until requested information is provided. Set back to unconfirmed once information has been provided. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88623] FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:4.5.0 | target:4.5.0 target:4.4.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88623] FILESAVE: slow data structure in XLSX saving
https://bugs.freedesktop.org/show_bug.cgi?id=88623 --- Comment #3 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- László Németh committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b81107be0d9c23c9ddf9ff6dbc8a521f92d6c3f3h=libreoffice-4-4 fdo#88623 replace std::deque with std::vector in xlsx saving It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88593] Significant numbers omitted with some column widths
https://bugs.freedesktop.org/show_bug.cgi?id=88593 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- As for rounding on the right hand side, this functions as designed methinks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88241] Sidebar: Undocked sidebar opened by call to Styles and Formatting is not dismissed with another call
https://bugs.freedesktop.org/show_bug.cgi?id=88241 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Trent MacAlpine committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7bb81cd93ad3a8d24cc69bc32ad22a5cbe1ec955h=libreoffice-4-4 fdo#88241 Floating sidebar second call to same item should dismiss it It will be available in 4.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63800] EDITING: Input lists in write protected sections not updated in window when edited
https://bugs.freedesktop.org/show_bug.cgi?id=63800 --- Comment #7 from Kulo h.kulov...@lohr.at --- *** Bug 79265 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sfx2/source
sfx2/source/sidebar/SidebarController.cxx | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) New commits: commit 7bb81cd93ad3a8d24cc69bc32ad22a5cbe1ec955 Author: Trent MacAlpine tmac...@gmail.com Date: Sun Jan 18 13:37:20 2015 -0500 fdo#88241 Floating sidebar second call to same item should dismiss it fixed in master by commit# 592984cea1a9cc545358b8d6077113a658834aa5 Note that this was written to be used in combination with commit 304e2002a053e9eb54e36462165eca831da8aeb2 to give back the behavior of calling and dismissing the styles and formatting dialog. Change-Id: I087f60c4bc0fa46b59bc17abf447553d7fda4074 Reviewed-on: https://gerrit.libreoffice.org/14027 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sfx2/source/sidebar/SidebarController.cxx b/sfx2/source/sidebar/SidebarController.cxx index a0e05fc..620bfeb 100644 --- a/sfx2/source/sidebar/SidebarController.cxx +++ b/sfx2/source/sidebar/SidebarController.cxx @@ -520,8 +520,17 @@ void SidebarController::OpenThenSwitchToDeck ( // fdo#67627 Clicking a second time on a Deck icon will close the Deck if (IsDeckVisible(rsDeckId)) { -RequestCloseDeck(); -return; +// fdo#88241 Summoning an undocked sidebar a second time should close sidebar +if (!GetSplitWindow()) +{ +mpParentWindow-Close(); +return; +} +else +{ +RequestCloseDeck(); +return; +} } RequestOpenDeck(); SwitchToDeck(rsDeckId); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88241] Sidebar: Undocked sidebar opened by call to Styles and Formatting is not dismissed with another call
https://bugs.freedesktop.org/show_bug.cgi?id=88241 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:4.5.0 | target:4.5.0 target:4.4.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs