[Libreoffice-commits] core.git: 2 commits - connectivity/Module_connectivity.mk external/jpeg-turbo
connectivity/Module_connectivity.mk |6 +- external/jpeg-turbo/ExternalProject_jpeg-turbo.mk |2 +- 2 files changed, 2 insertions(+), 6 deletions(-) New commits: commit 0c3505f01a792449b0c6bf81f518e7a062eea146 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 4 17:26:44 2015 +0100 Typo $(CPU) - $(CPUNAME) Change-Id: I2e121c36021508bbdbc9111087f5cc6e1aae6524 diff --git a/connectivity/Module_connectivity.mk b/connectivity/Module_connectivity.mk index 97310d1..1ba9e7b 100644 --- a/connectivity/Module_connectivity.mk +++ b/connectivity/Module_connectivity.mk @@ -102,7 +102,7 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif -ifeq ($(OS)-$(CPU),WNT-INTEL) +ifeq ($(OS)-$(CPUNAME),WNT-INTEL) ifneq ($(WITH_MOZAB4WIN),) $(eval $(call gb_Module_add_targets,connectivity,\ diff --git a/external/jpeg-turbo/ExternalProject_jpeg-turbo.mk b/external/jpeg-turbo/ExternalProject_jpeg-turbo.mk index ad35a6f..c913d70 100755 --- a/external/jpeg-turbo/ExternalProject_jpeg-turbo.mk +++ b/external/jpeg-turbo/ExternalProject_jpeg-turbo.mk @@ -25,7 +25,7 @@ $(call gb_ExternalProject_get_state_target,jpeg-turbo,build) : $(call gb_Externa $(call gb_ExternalProject_get_state_target,jpeg-turbo,configure) : $(call gb_ExternalProject_run,configure,\ MAKE=$(MAKE) ./configure \ - --build=$(if $(filter WNT,$(OS)),$(if $(filter INTEL,$(CPU)),i686-pc-cygwin,x86_64-pc-cygwin),$(BUILD_PLATFORM)) \ + --build=$(if $(filter WNT,$(OS)),$(if $(filter INTEL,$(CPUNAME)),i686-pc-cygwin,x86_64-pc-cygwin),$(BUILD_PLATFORM)) \ --with-pic \ --enable-static \ --disable-shared \ commit 484d5914575feb30146e0b75cef4860652805fa6 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 4 17:24:41 2015 +0100 Revert Do not let WNT non-INTEL run into the else branch This reverts commit c0f080403b869e162dc81db6c8c50b7360a3, logic error, true fix will follow. diff --git a/connectivity/Module_connectivity.mk b/connectivity/Module_connectivity.mk index ade21dd..97310d1 100644 --- a/connectivity/Module_connectivity.mk +++ b/connectivity/Module_connectivity.mk @@ -102,9 +102,7 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif -ifeq ($(OS),WNT) - -ifeq ($(CPU),INTEL) +ifeq ($(OS)-$(CPU),WNT-INTEL) ifneq ($(WITH_MOZAB4WIN),) $(eval $(call gb_Module_add_targets,connectivity,\ @@ -118,8 +116,6 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif -endif - else ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) $(eval $(call gb_Module_add_targets,connectivity,\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/inc framework/source include/framework include/vcl vcl/source
framework/inc/uielement/newmenucontroller.hxx|4 -- framework/source/fwe/classes/addonmenu.cxx |6 +-- framework/source/fwe/classes/bmkmenu.cxx |4 +- framework/source/fwe/xml/menuconfiguration.cxx | 22 ++ framework/source/uielement/menubarmanager.cxx|5 +-- framework/source/uielement/newmenucontroller.cxx | 31 ++- include/framework/menuconfiguration.hxx | 36 +++ include/vcl/menu.hxx |6 ++- vcl/source/window/menu.cxx | 11 +-- vcl/source/window/menuitemlist.cxx |2 + vcl/source/window/menuitemlist.hxx |5 ++- 11 files changed, 92 insertions(+), 40 deletions(-) New commits: commit 4904180247c0d5745a393e3cd57eaae29f3837e5 Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 4 14:02:41 2015 + fix leak from framework::AddonMenuManager::BuildMenu provide a callback when a menu item gets deleted Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530 diff --git a/framework/inc/uielement/newmenucontroller.hxx b/framework/inc/uielement/newmenucontroller.hxx index ad802fa..a86d5ad 100644 --- a/framework/inc/uielement/newmenucontroller.hxx +++ b/framework/inc/uielement/newmenucontroller.hxx @@ -81,9 +81,6 @@ namespace framework private: virtual void impl_setPopupMenu() SAL_OVERRIDE; -typedef MenuConfiguration::Attributes AddInfo; - -typedef std::unordered_map int, std::unique_ptrAddInfo AddInfoForId; void fillPopupMenu( com::sun::star::uno::Reference com::sun::star::awt::XPopupMenu rPopupMenu ); void retrieveShortcutsFromConfiguration( const ::com::sun::star::uno::Reference ::com::sun::star::ui::XAcceleratorConfiguration rAccelCfg, @@ -99,7 +96,6 @@ namespace framework m_bNewMenu: 1, m_bModuleIdentified : 1, m_bAcceleratorCfg : 1; -AddInfoForIdm_aAddInfoForItem; OUString m_aTargetFrame; OUString m_aModuleIdentifier; OUString m_aEmptyDocURL; diff --git a/framework/source/fwe/classes/addonmenu.cxx b/framework/source/fwe/classes/addonmenu.cxx index 460104a..54c1fa9 100644 --- a/framework/source/fwe/classes/addonmenu.cxx +++ b/framework/source/fwe/classes/addonmenu.cxx @@ -58,10 +58,7 @@ AddonMenu::~AddonMenu() { if ( GetItemType( i ) != MenuItemType::SEPARATOR ) { -// delete user attributes created with new! sal_uInt16 nId = GetItemId( i ); -MenuConfiguration::Attributes* pUserAttributes = reinterpret_castMenuConfiguration::Attributes*(GetUserValue( nId )); -delete pUserAttributes; delete GetPopupMenu( nId ); } } @@ -333,7 +330,8 @@ void AddonMenuManager::BuildMenu( PopupMenu* pCurrent // Store values from configuration to the New and Wizard menu entries to enable // sfx2 based code to support high contrast mode correctly! -pCurrentMenu-SetUserValue( nId, sal_uIntPtr( new MenuConfiguration::Attributes( aTarget, aImageId )) ); +sal_uIntPtr nAttributePtr = MenuConfiguration::Attributes::CreateAttribute(aTarget, aImageId); +pCurrentMenu-SetUserValue(nId, nAttributePtr, MenuConfiguration::Attributes::ReleaseAttribute); pCurrentMenu-SetItemCommand( nId, aURL ); if ( pSubMenu ) diff --git a/framework/source/fwe/classes/bmkmenu.cxx b/framework/source/fwe/classes/bmkmenu.cxx index bf1396b..a3f4290 100644 --- a/framework/source/fwe/classes/bmkmenu.cxx +++ b/framework/source/fwe/classes/bmkmenu.cxx @@ -164,8 +164,8 @@ void BmkMenu::Initialize() else InsertItem( nId, aTitle ); -MenuConfiguration::Attributes* pUserAttributes = new MenuConfiguration::Attributes( aTargetFrame, aImageId ); -SetUserValue( nId, reinterpret_castsal_uIntPtr(pUserAttributes) ); +sal_uIntPtr nAttributePtr = MenuConfiguration::Attributes::CreateAttribute(aTargetFrame, aImageId); +SetUserValue(nId, nAttributePtr, MenuConfiguration::Attributes::ReleaseAttribute); SetItemCommand( nId, aURL ); } diff --git a/framework/source/fwe/xml/menuconfiguration.cxx b/framework/source/fwe/xml/menuconfiguration.cxx index 8eb6a6d..aabbc47 100644 --- a/framework/source/fwe/xml/menuconfiguration.cxx +++ b/framework/source/fwe/xml/menuconfiguration.cxx @@ -139,6 +139,28 @@ void MenuConfiguration::StoreMenuBarConfigurationToXML( } } +sal_uIntPtr MenuConfiguration::Attributes::CreateAttribute(const OUString rFrame, const OUString rImageIdStr) +{ +Attributes* pAttributes = new Attributes(rFrame, rImageIdStr); +pAttributes-acquire(); +
[Libreoffice-bugs] [Bug 88033] EDITING: Only one relation between two tables is displayed even when there are more than one
https://bugs.documentfoundation.org/show_bug.cgi?id=88033 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- @James : if I go to the menu Tools Relationships and try and create a new relationship by dragging and dropping from the first table id to the non-displayed FK id fields, I get an error message that the FK ref already exists, and asked whether I want to create a new one or edit the existing ref. Is this also what you see ? I can confirm that in the ODB file you provided the relations are not drawn in the relations window, yet they appear to be defined in the ODB file itself. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84442] Image map address bar does not preserve upper-case
https://bugs.documentfoundation.org/show_bug.cgi?id=84442 --- Comment #3 from celtic alias@laposte.net --- the machine runs Kubuntu 14.10, kde 4.14, LO 4.3.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89125] clicking on an object slightly displaces it
https://bugs.documentfoundation.org/show_bug.cgi?id=89125 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming Version: 4.5.0.0.alpha0+ Build ID: 6143a7eeabea394133c54e97e3690bdf40b98247 Locale: fr_ but only the first time the text object is selected. Subsequent selects do not move the object down and left. It seems to affect the file only once, even closing LO and reopening the file to repeat the selection doesn't seem to cause the object to move again. Of course, the movement registers as a change / edit, and so when you close the file, even if you htink you haven't changed anything, you get asked whether you want to save it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89125] EDITING - clicking on an object in Impress slightly displaces it
https://bugs.documentfoundation.org/show_bug.cgi?id=89125 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|clicking on an object |EDITING - clicking on an |slightly displaces it |object in Impress slightly ||displaces it -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/Module_connectivity.mk Repository.mk
Repository.mk | 17 - connectivity/Module_connectivity.mk |8 +--- 2 files changed, 9 insertions(+), 16 deletions(-) New commits: commit 0cbe2e92a24be1354f9b058b6584aaed40ddb6ce Author: Michael Stahl mst...@redhat.com Date: Wed Feb 4 17:29:23 2015 +0100 connectivity: just check the WITH_MOZAB4WIN variable Either build mozab or mork driver, and install it in Repository.mk too. Change-Id: I456d6cb4ebe99625a64a960d1133cb06d836e8c7 diff --git a/Repository.mk b/Repository.mk index 8f948a5..095dfba 100644 --- a/Repository.mk +++ b/Repository.mk @@ -460,20 +460,19 @@ $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \ xof \ xsltdlg \ xsltfilter \ + $(if $(WITH_MOZAB4WIN), \ + mozab2 \ + mozabdrv \ + ) \ + $(if $(WITH_MOZAB4WIN),,\ + mork \ + mozbootstrap \ + ) \ $(if $(filter $(OS),WNT), \ ado \ $(if $(DISABLE_ATL),,oleautobridge) \ smplmail \ wininetbe1 \ - $(if $(WITH_MOZAB4WIN), \ - mozab2 \ - mozabdrv \ - ) \ - $(if $(WITH_MOZAB4WIN),,mozbootstrap) \ - ) \ - $(if $(filter $(OS),WNT),, \ - mork \ - mozbootstrap \ ) \ $(if $(filter $(OS),MACOSX), \ $(if $(ENABLE_MACOSX_SANDBOX),, \ diff --git a/connectivity/Module_connectivity.mk b/connectivity/Module_connectivity.mk index 1ba9e7b..4616eb3 100644 --- a/connectivity/Module_connectivity.mk +++ b/connectivity/Module_connectivity.mk @@ -102,19 +102,13 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif -ifeq ($(OS)-$(CPUNAME),WNT-INTEL) - ifneq ($(WITH_MOZAB4WIN),) + $(eval $(call gb_Module_add_targets,connectivity,\ Configuration_mozab \ Library_mozab \ Library_mozabdrv \ )) -else -$(eval $(call gb_Module_add_targets,connectivity,\ - Library_mozbootstrap \ -)) -endif else ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45257] EDITING Relation designer does not pick up all existing relationships
https://bugs.documentfoundation.org/show_bug.cgi?id=45257 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||byrn...@harte-lyne.ca --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 88033 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84442] Image map address bar does not preserve upper-case
https://bugs.documentfoundation.org/show_bug.cgi?id=84442 --- Comment #4 from celtic alias@laposte.net --- oups, i'm terribly sorry, i'm not on right bug. How to delete my comments ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88800] 4.4 doesn't start [OpenGL]
https://bugs.documentfoundation.org/show_bug.cgi?id=88800 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Beluga todven...@suomi24.fi --- Sorry to all, I should have searched for a duplicate. Note from Markus Mohrhard in the comments of bug 87673: Don't use that setting right now. We have horrible issues with memory corruption and race conditions. *** This bug has been marked as a duplicate of bug 87673 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88033] EDITING: Only one relation between two tables is displayed even when there are more than one
https://bugs.documentfoundation.org/show_bug.cgi?id=88033 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming on master Version: 4.5.0.0.alpha0+ Build ID: 6143a7eeabea394133c54e97e3690bdf40b98247 Locale: fr_ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87673] If OpenGL rendering is not available, LO fails to start
https://bugs.documentfoundation.org/show_bug.cgi?id=87673 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||o...@sophia-louise.de --- Comment #10 from Beluga todven...@suomi24.fi --- *** Bug 88800 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - desktop/source include/LibreOfficeKit ios/CustomTarget_TiledLibreOffice_app.mk ios/experimental
desktop/source/app/officeipcthread.cxx | 24 +++- desktop/source/app/sofficemain.cxx | 12 -- desktop/source/lib/init.cxx | 21 +++ include/LibreOfficeKit/LibreOfficeKitInit.h | 12 +- ios/CustomTarget_TiledLibreOffice_app.mk | 13 +- ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj | 20 +-- ios/experimental/TiledLibreOffice/TiledLibreOffice/AppDelegate.m | 53 +- ios/experimental/TiledLibreOffice/TiledLibreOffice/TiledView.h | 5 ios/experimental/TiledLibreOffice/TiledLibreOffice/TiledView.m | 21 ++- ios/experimental/TiledLibreOffice/TiledLibreOffice/View.h| 3 ios/experimental/TiledLibreOffice/TiledLibreOffice/View.m| 21 ++- ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm | 5 12 files changed, 114 insertions(+), 96 deletions(-) New commits: commit 4b269ecb7a699318b067eb64c464460b1783d3d2 Author: Tor Lillqvist t...@collabora.com Date: Wed Feb 4 17:48:41 2015 +0100 Use LibreOfficeKit in the TiledLibreOffice iOS demo app, too For iOS, the pBuffer argument to LibreOfficeKitDocument::paintTile() is not a pixel buffer, but a CGContextRef. Thus we can keep the existing CGContext-oriented vcl code for iOS as is. I commented out the touch/touch.h -using code in sw, and it probably would be OK to just kill touch/touch.h and remove use and implementations of its API. I don't think they are used by our current Android or iOS code. This concludes the commits of the work I did at the post-FOSDEM hackfest and on the flight home. TiledLibreOffice now works as before, but uses LibreOfficeKit. Change-Id: Ibbde6e11d660561840eab6335f7fc0db6758173e diff --git a/desktop/source/app/officeipcthread.cxx b/desktop/source/app/officeipcthread.cxx index 58fa25a..c5f2367 100644 --- a/desktop/source/app/officeipcthread.cxx +++ b/desktop/source/app/officeipcthread.cxx @@ -449,12 +449,12 @@ void OfficeIPCThread::RequestsCompleted( int nCount ) OfficeIPCThread::Status OfficeIPCThread::EnableOfficeIPCThread() { -#if HAVE_FEATURE_DESKTOP || defined(ANDROID) ::osl::MutexGuard aGuard( GetMutex() ); if( pGlobalOfficeIPCThread.is() ) return IPC_STATUS_OK; +#if HAVE_FEATURE_DESKTOP || defined(ANDROID) OUString aUserInstallPath; OUString aDummy; @@ -605,14 +605,15 @@ OfficeIPCThread::Status OfficeIPCThread::EnableOfficeIPCThread() return IPC_STATUS_2ND_OFFICE; } #else -pGlobalOfficeIPCThread = rtl::Reference OfficeIPCThread (new OfficeIPCThread); +rtl::Reference OfficeIPCThread pThread(new OfficeIPCThread); +pGlobalOfficeIPCThread = pThread; +pThread-launch(); #endif return IPC_STATUS_OK; } void OfficeIPCThread::DisableOfficeIPCThread(bool join) { -#if HAVE_FEATURE_DESKTOP || defined(ANDROID) osl::ClearableMutexGuard aMutex( GetMutex() ); if( pGlobalOfficeIPCThread.is() ) @@ -635,9 +636,6 @@ void OfficeIPCThread::DisableOfficeIPCThread(bool join) pOfficeIPCThread-join(); } } -#else - (void) join; -#endif } OfficeIPCThread::OfficeIPCThread() : @@ -967,6 +965,20 @@ void OfficeIPCThread::execute() salhelper::Thread::wait( tval ); } } while( schedule() ); +#else + +#if 0 // Seems to work fine to let this thread just die? + +// Not sure what to do, so wait forever. Note that on iOS (or +// Android, but in this case ANDROID is handled like DESKTOP, see +// above) an app never exits voluntarily, but is always killed by +// the system when its resources are needed.) +TimeValue tval; +tval.Seconds = 10; +tval.Nanosec = 0; +salhelper::Thread::wait( tval ); +#endif + #endif } diff --git a/desktop/source/app/sofficemain.cxx b/desktop/source/app/sofficemain.cxx index 9cee2c4..0597a4f 100644 --- a/desktop/source/app/sofficemain.cxx +++ b/desktop/source/app/sofficemain.cxx @@ -49,10 +49,6 @@ # define LOGI(...) ((void)__android_log_print(ANDROID_LOG_INFO, LOGTAG, __VA_ARGS__)) #endif -#ifdef IOS -#include touch/touch.h -#endif - extern C int DESKTOP_DLLPUBLIC soffice_main() { #if defined( UNX ) !defined MACOSX !defined IOS !defined ANDROID @@ -114,22 +110,16 @@ extern C int DESKTOP_DLLPUBLIC soffice_main() extern C SAL_JNI_EXPORT void JNICALL Java_org_libreoffice_android_AppSupport_runMain(JNIEnv* /* env */, jobject /* clazz */) -#else -extern C -void -touch_lo_runMain() -#endif { int nRet; do { nRet = soffice_main(); -#ifdef ANDROID LOGI(soffice_main returned %d, nRet); -#endif } while (nRet ==
[Libreoffice-bugs] [Bug 89125] New: clicking on an object slightly displaces it
https://bugs.documentfoundation.org/show_bug.cgi?id=89125 Bug ID: 89125 Summary: clicking on an object slightly displaces it Product: LibreOffice Version: 3.3.0 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: conve...@gmail.com When I click to select say a text area in a slide, the text area is displaced slightly to the bottom-left. To reproduce it: - load a presentation file - in the initial view of Presenter, click on a slide in the left part of the screen - then click on the (non visible) border of the main text area in the main view of the slide to select the text area (i.e. do not click on the text directly or it will insert an insert edit text cursor instead of selecting the text area object) - after releasing the button, the text object is selected *and* slightly displaced this bug have been occurring for many years and it is s annoying that each time I test a new release of Libre or Open Office, this is the first thing I see, and I immediately give up... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/number.cxx | 10 ++ sw/source/core/docnode/nodedump.cxx | 12 2 files changed, 10 insertions(+), 12 deletions(-) New commits: commit a66950bb99069d5133ce28b48816148cc10b15d6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed Feb 4 17:34:41 2015 +0100 Extract SwNumRule::dumpAsXml() from docnode Change-Id: I4104f39227cb42d5cc2013c9ae0f4bb15e0f0f00 diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx index ab57814..163eda1 100644 --- a/sw/source/core/doc/number.cxx +++ b/sw/source/core/doc/number.cxx @@ -46,6 +46,7 @@ #include algorithm #include unordered_map +#include libxml/xmlwriter.h #include unotools/saveopt.hxx @@ -1037,6 +1038,15 @@ void SwNumRule::RemoveParagraphStyle( SwTxtFmtColl rTxtFmtColl ) } } +void SwNumRule::dumpAsXml(xmlTextWriterPtr pWriter) const +{ +xmlTextWriterStartElement(pWriter, BAD_CAST(swNumRule)); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(msName), BAD_CAST(msName.toUtf8().getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(mnPoolFmtId), BAD_CAST(OString::number(mnPoolFmtId).getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(mbAutoRuleFlag), BAD_CAST(OString::boolean(mbAutoRuleFlag).getStr())); +xmlTextWriterEndElement(pWriter); +} + void SwNumRule::GetGrabBagItem(uno::Any rVal) const { if (mpGrabBagItem.get()) diff --git a/sw/source/core/docnode/nodedump.cxx b/sw/source/core/docnode/nodedump.cxx index c9aa867..64ea367 100644 --- a/sw/source/core/docnode/nodedump.cxx +++ b/sw/source/core/docnode/nodedump.cxx @@ -373,18 +373,6 @@ void SwTxtFmtColls::dumpAsXml(xmlTextWriterPtr w) const } } -void SwNumRule::dumpAsXml(xmlTextWriterPtr w) const -{ - WriterHelper writer(w); - writer.startElement(swnumrule); - OString aName = OUStringToOString(GetName(), RTL_TEXTENCODING_UTF8); - writer.writeFormatAttribute(name, %s, BAD_CAST(aName.getStr())); - writer.writeFormatAttribute(isautorule, TMP_FORMAT, IsAutoRule() ? 1 : 0); - if (GetPoolFmtId() != USHRT_MAX) - writer.writeFormatAttribute(poolfmtid, TMP_FORMAT, GetPoolFmtId()); - writer.endElement(); -} - void SwNumRuleTbl::dumpAsXml(xmlTextWriterPtr w) const { if (!empty()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - android/Bootstrap
android/Bootstrap/Makefile.shared |2 ++ 1 file changed, 2 insertions(+) New commits: commit c8f52f87ef7370a1847e362350dcdf6067e6b053 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed Feb 4 17:45:00 2015 +0100 android: fix missing drawingML preset shapes Change-Id: I7a22b9bcacd26b837c00bb09743ab2e176d60746 diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 77d2bcf..12b4774 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -138,6 +138,8 @@ copy-stuff: rm -Rf assets/share # pre-clean it mkdir -p assets/share/config cp -R $(INSTDIR)/share/registry assets/share +# Filter data is needed by e.g. the drawingML preset shape import. + cp -R $(INSTDIR)/share/filter assets/share # Make sure the soffice.cfg directory is always created, it's not possible to hit any keys without it. if ! test z$(DISABLE_UI) = zTRUE; then \ echo Copying UI files into the apk; \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 45257] EDITING Relation designer does not pick up all existing relationships
https://bugs.documentfoundation.org/show_bug.cgi?id=45257 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|EDITING postgreSQL-SDBC |EDITING Relation designer |Relation designer does not |does not pick up all |pick up all existing|existing relationships |relationships | --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- Changing title because the problem is independent of db engine -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88033] EDITING: Only one relation between two tables is displayed even when there are more than one
https://bugs.documentfoundation.org/show_bug.cgi?id=88033 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- *** This bug has been marked as a duplicate of bug 45257 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88800] 4.4 doesn't start [OpenGL]
https://bugs.documentfoundation.org/show_bug.cgi?id=88800 k-j o...@sophia-louise.de changed: What|Removed |Added Summary|4.4 doesn't start [Hard to |4.4 doesn't start [OpenGL] |reproduce] | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88800] 4.4 doesn't start [Hard to reproduce]
https://bugs.documentfoundation.org/show_bug.cgi?id=88800 --- Comment #7 from k-j o...@sophia-louise.de --- Ok, I can reproduce now here: WIN 8.1, 64bit GEFORCE GT 650M, NVIDIA graphics driver 327.02: the problem exists when the Force OpenGL even if blacklisted is enabled. @Beluga: Why are you changing the title again? 1 It is reproduceable. 2 It is my bug. So when I change the title back, I can expect, that you ask me or even you give a comment here why you think that changing the title in your way is right. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84442] Image map address bar does not preserve upper-case
https://bugs.documentfoundation.org/show_bug.cgi?id=84442 --- Comment #2 from celtic alias@laposte.net --- Created attachment 113129 -- https://bugs.documentfoundation.org/attachment.cgi?id=113129action=edit screenshots and comments i'm going to attach a file with sreenshots but it is not easy to show the problem the the cursor (or mouse). Please tell if you more information -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89126] New: Spreadsheet named zone with macro
https://bugs.documentfoundation.org/show_bug.cgi?id=89126 Bug ID: 89126 Summary: Spreadsheet named zone with macro Product: LibreOffice Version: 4.2.8.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stefa...@free.fr It is impossible to reach the least row of the named zone for erasing or creating a new row. For create i insert a row at index position n-1 and i move the least row up. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89125] clicking on an object slightly displaces it
https://bugs.documentfoundation.org/show_bug.cgi?id=89125 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Beluga todven...@suomi24.fi --- Could not reproduce. OS X only? Win 7 Pro 64-bit, LibO Version: 4.4.0.3 Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7 Ubuntu 14.10 64-bit Version: 4.4.0.3 Build ID: 40m0(Build:3) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89117] Crash when using pivot table and two delete keys pressed on EVERY field
https://bugs.documentfoundation.org/show_bug.cgi?id=89117 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Caolán McNamara caol...@redhat.com --- *** This bug has been marked as a duplicate of bug 89108 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84442] Image map address bar does not preserve upper-case
https://bugs.documentfoundation.org/show_bug.cgi?id=84442 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to celtic from comment #4) oups, i'm terribly sorry, i'm not on right bug. How to delete my comments ? You can't delete them, sorry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84432] FILESAVE: cursor jump in dialog box (kubuntu)
https://bugs.documentfoundation.org/show_bug.cgi?id=84432 --- Comment #7 from celtic alias@laposte.net --- Created attachment 113130 -- https://bugs.documentfoundation.org/attachment.cgi?id=113130action=edit screenshots and comments i'm going to attach a file with sreenshots but it is not easy to show the problem the the cursor (or mouse) kubuntu 14.10, kde 4.14, LO 4.3.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Loosing formula (hence data) in MSO, raise priority and backport to 4.3, 4.4.
Hi Folks, This week I hit this problem: https://bugs.documentfoundation.org/show_bug.cgi?id=89042 and I saw this was fixed here: https://bugs.documentfoundation.org/show_bug.cgi?id=81596 Since this bug causes data lost (converting formula to its value) while load files to MSO2010-13 I would like to ask you to raise its priority and backport this bug to all maintained version of LibreOffice Thank you in advance! Best Regards: Kálmán (KAMI) Szalai ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 89081] Calc Legends keep shifting to the far left
https://bugs.documentfoundation.org/show_bug.cgi?id=89081 Peter Hartmann pe1hartm...@yahoo.de changed: What|Removed |Added Attachment #113105|Faulty Legend in upper |Faulty Legend in upper left description|right corner|corner -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89101] FORMATTING, UI; Ubuntu Unity shell becomes black after apply borders
https://bugs.documentfoundation.org/show_bug.cgi?id=89101 raal r...@post.cz changed: What|Removed |Added Summary|FORMATTING, UI |FORMATTING, UI; Ubuntu ||Unity shell becomes black ||after apply borders -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89103] START CENTER: Right-click context menu needed in Templates section
https://bugs.documentfoundation.org/show_bug.cgi?id=89103 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||qu...@runcibility.com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86355] executable bit is set on non-executable files CREDITS, LICENSE and NOTICE
https://bugs.documentfoundation.org/show_bug.cgi?id=86355 --- Comment #11 from Richard PALO rich...@netbsd.org --- (In reply to Robinson Tryon (qubit) from comment #10) (In reply to Richard PALO from comment #9) I must say I don't use git archive, perhaps there's some simple thing. from 'git help archive' I'm still not seeing executable bits set. Do you have a suggestion re: the perms changing? Perhaps the summary needs an update? Status - NEEDINFO What platform are you running on? Perhaps try a couple? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89112] New: moving paragraphs / rows up and down does not work in writer tables
https://bugs.documentfoundation.org/show_bug.cgi?id=89112 Bug ID: 89112 Summary: moving paragraphs / rows up and down does not work in writer tables Product: LibreOffice Version: 4.4.0.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: moritz-documentfoundat...@moeller-herrmann.de In Writer (and in Microsoft Office) it is possible to move a paragraph up and down with a key press of CRTL+ALT+Move up/down. This works fine on normal text paragraphs. However, in tables, where this is extremely useful, the key does not move the current table row up or down. This works in Microsoft Office and it really makes it difficult to quickly rearrange table rows in a text table in Writer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89111] New: Over 1 million rows in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=89111 Bug ID: 89111 Summary: Over 1 million rows in spreadsheet Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mercergeoi...@gmail.com Copy/Pasting 77 rows by 16 columns from an xls into a new spreadsheet resulted in 1048576 rows being created, all but the first 77 empty. This slows down performance somewhat. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86355] executable bit is set on non-executable files CREDITS, LICENSE and NOTICE
https://bugs.documentfoundation.org/show_bug.cgi?id=86355 --- Comment #12 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Richard PALO from comment #11) (In reply to Robinson Tryon (qubit) from comment #10) I'm still not seeing executable bits set. Do you have a suggestion re: the perms changing? Perhaps the summary needs an update? Status - NEEDINFO What platform are you running on? Perhaps try a couple? I can try multiple platforms, but the point remains that I still haven't seen any direct evidence that the executable bit is set on anything but a directory. You have this: = Checking file permissions in libreoffice4-4.3.4.1 warning: /tmp/pkgsrc/misc/libreoffice4/work/.destdir/opt/local/libreoffice4-4.3.4.1/ CREDITS.fodt: executable bit is set on non-executable file. ...but I don't know what program generated that output (and on which OS, version, etc..). Are you installing from source? Please provide more information so that I can see the problem and seek to reproduce it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88212] Load At Startup Option During Install Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=88212 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #3 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Timur from comment #2) Is this a dupe of Bug 35568 - QuickStarter setting not remembered after upgrade (win only)? Status - NEEDINFO Joel: *nudge* -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72880] CONFIGURATION: Automatically associate the protocol vnd.libreoffice.cmis with LibreOffice on the installation
https://bugs.documentfoundation.org/show_bug.cgi?id=72880 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Christopher Potter from comment #0) When LO is installed, it should be great that it modify the registry to associate the protocol vnd.libreoffice.cmis with the program. Sounds like a plausible enhancement request Status - NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89113] New: Dialog (Especially the Options Dialog) exceeds screen boundaries
https://bugs.documentfoundation.org/show_bug.cgi?id=89113 Bug ID: 89113 Summary: Dialog (Especially the Options Dialog) exceeds screen boundaries Product: LibreOffice Version: 4.3.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nb...@broadpark.no I use Fedora 21 with gnome and have set the text size to LARGE (larger than the default setting) The resolution of my screen is 1366x768. The Options Dialog (and perhaps others) exceed the screen, and hence the OK button on the bottom disappear. The Customize Dialog on the other hand fits EXACTLY. I know the issue of dialog sizing from my days of programming, so, perhaps the EASY solution is to make the dialog smaller. It is excessively large. For users who don't know how to TAB their way to the OK button have no means of saving their choices. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
RE: Loosing formula (hence data) in MSO, raise priority and backport to 4.3, 4.4.
Hi Kálmán, This week I hit this problem: https://bugs.documentfoundation.org/show_bug.cgi?id=89042 and I saw this was fixed here: https://bugs.documentfoundation.org/show_bug.cgi?id=81596 Since this bug causes data lost (converting formula to its value) while load files to MSO2010-13 I would like to ask you to raise its priority and backport this bug to all maintained version of LibreOffice Yesterday you put your request into bug report 81596. I have not had time to respond as I don't know yet if the patch can easily be applied to version 4.4 and 4.3. Using the bug reports is the best way to put your request. This mailing list is intended for developers and posts about code and code changes. HTH, Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 89004] Choosing Document Colors from font/background palette takes 2-3 minutes with 100% CPU use
https://bugs.documentfoundation.org/show_bug.cgi?id=89004 --- Comment #13 from Ron Johnson ron.l.john...@cox.net --- (In reply to Joel Madero from comment #12) I'm setting this to new as I can confirm the issue with the test document: Ubuntu 14.04 x64 LibreOffice 4.4.0.3 Thanks, because with the greatly expanded palette size, Document Colors is a great idea. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89081] Calc Legends keep shifting to the far left
https://bugs.documentfoundation.org/show_bug.cgi?id=89081 --- Comment #4 from Peter Hartmann pe1hartm...@yahoo.de --- Of course the faulty legend is at the *left* side. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85484] Make Python macro examples editable
https://bugs.documentfoundation.org/show_bug.cgi?id=85484 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||qu...@runcibility.com Ever confirmed|0 |1 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING with LO 4.4.0.3 + Ubuntu 14.04 (In reply to Philipp Weissenbacher from comment #0) The Python macro examples in Tools - Macros - Organize Macros ... - Python are not editable from within LibreOffice. CONFIRMED The reason is twofold: 1) the 'Edit' button is grayed out an 2) the file location is usually not user-editable. This could be fixed by: 1) launching the systems editor for Python files and There is a built-in editor inside LibreOffice, so that could be used... 2) moving the example files from /opt/libreoffice4.3/share/Scripts/python to ~/.config/libreoffice/4/user/Scripts/python Sounds like a plausible idea for an enhancement. Status - NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89110] New: LibreOffice Calc crashes when soffice.bin reaches 1.600.000 K RAM in Taskmanager (out of memory)
https://bugs.documentfoundation.org/show_bug.cgi?id=89110 Bug ID: 89110 Summary: LibreOffice Calc crashes when soffice.bin reaches 1.600.000 K RAM in Taskmanager (out of memory) Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fors...@mailbox.org I'm working on quite simple spreadsheet that does have about 300 highres .png images in a column. When opening the file soffice.bin allocates about 1.060.000 K according to Taskmanager. The more I scroll through this file and the more images LibreOffice loads the more memory it allocates. When it reaches ~1.600.000 K LibreOffice just crashes. It will either show the recovery dialogue or a message pointing towards an out of memory error appears. In the settings there is an option for removing objects from the cache after a few minutes. If I set this to 1 Minute, the memory allocation will shrink down to 1.060.000 K after 1 minute but it will still reach 1.600.000 K when scrolling through the whole file. This means I have to constantly monitor memory usage in the Taskmanager while working on the file. Please make LibreOffice remove objects from the cache when it reaches ~1.600.000K to avoid crashes. (This limit around 1.6 GB seems to be quite normal for applications that are not large address aware) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89110] LibreOffice Calc crashes when soffice.bin reaches 1.600.000 K RAM in Taskmanager (out of memory)
https://bugs.documentfoundation.org/show_bug.cgi?id=89110 fors...@mailbox.org changed: What|Removed |Added Version|unspecified |4.3.5.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75471] New windows stay in background, don't get focus
https://bugs.documentfoundation.org/show_bug.cgi?id=75471 --- Comment #17 from Carsten pohlm...@transdata.net --- This issue still exists. Tested versions are 4.3 and 4.4. Is it complicated to fix this problem? We just migrated our sales department from MS Office to LO. They are not very excited about the conversion. But this issue is really annoying if you work with several documents at the same time. LO Version: 4.4.0.3 OS: Windows 8.1 including all available updates same with Windows 7, Windows Server 2008 R2, Windows Server 2012 R2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86904] Crashes/exits when clicking diagram button
https://bugs.documentfoundation.org/show_bug.cgi?id=86904 --- Comment #20 from merike gasell+libreoff...@smail.ee --- I never specifically enabled OpenGL. It must've been enabled automatically then. Anyway 4.4.0.3 does not crash in a similar way. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86355] executable bit is set on non-executable files CREDITS, LICENSE and NOTICE
https://bugs.documentfoundation.org/show_bug.cgi?id=86355 --- Comment #13 from Richard PALO rich...@netbsd.org --- (In reply to Robinson Tryon (qubit) from comment #12) I can try multiple platforms, but the point remains that I still haven't seen any direct evidence that the executable bit is set on anything but a directory. You have this: = Checking file permissions in libreoffice4-4.3.4.1 warning: /tmp/pkgsrc/misc/libreoffice4/work/.destdir/opt/local/libreoffice4-4.3.4.1/ CREDITS.fodt: executable bit is set on non-executable file. ...but I don't know what program generated that output (and on which OS, version, etc..). Are you installing from source? Please provide more information so that I can see the problem and seek to reproduce it. As mentioned above, pkgsrc builds from the tarball. The tarball, as shown in the extract snippet provided clearly indicates the protection bits *in the tarball*. What more could I possibly provide? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65830] Other: Trying to connect to MySQL database trough ODBC crashes LibreOffice - signal 11 (SIGSEGV) (summary in comment 34)
https://bugs.documentfoundation.org/show_bug.cgi?id=65830 --- Comment #41 from Beluga todven...@suomi24.fi --- (In reply to Lionel Elie Mamane from comment #40) The Driver = ... line must match the section name in odbcinst.ini (where you put unixODBC which is a bit weird). In other words, the Driver line in my instructions assumes that the corresponding driver section is called MySQL, but you called it unixODBC. Also, it seems unusual to me that the Setup = line maps to unixodbc's libodbcinst.so instead of a myodbc .so file; my entry has Setup=libodbcmyS.so; that's on Debian GNU/Linux FWIW. Ok I made the change to MySQL, no help. I don't have any libodbcmyS.so in /usr/lib64 or anywhere in this system. Note that I haver never done this before, have no personal use for this and I'm only doing this for QA testing. I'm using an openSUSE VM specifically set up for testing this report. This sounds like LibreOffice is compiled for a different libodbc than what you have... Usually, when the .so has a different name, it means it is an incompatible version, and simply linking one to the other WILL NOT WORK (or can seem to work, but lead to crashes, data corruption, etc). I'm using TDF's build: Version: 4.4.0.3 Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7 I found this: http://www.unixodbc.org/ 28.Nov.2011 2.3.1 Released Mainly bug fixes. Major change is to change the library version number from 1 to 2 to signal the SQLLEN change for 64 land. Should have been done for 2.3.0, but better late than never. So if after installing you have apps that can't find libodbc.so, its likely they are linked to libodbc.so.1, so just create a symlink from libodbc.so.2 -- Based on that official suggestion to symlink, there seems to be no danger. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libreoffice-projects] minutes of ESC call ...
On 2015-02-01 02:05 PM, Michel Renon wrote: here are some ideas : if you think some might be interesting, tell me and I'll make some specs/ux design Those are some very good ideas! Even if they don't make the GSOC, they should probably be logged in bugzilla. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
Hi there On Thu, 2015-01-22 at 17:00 +, Michael Meeks wrote: * GSoC (Kendy) + February, 9th: Mentoring organizations can begin submitting applications to Google. It will be hard for me to join the call during the next month... but that doesn't alter my capability to handle the admin side of GSoc this year. -- Cedric ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Network outage on multiple sites/VMs
Hi, Since today starting from around 16:00 GMT+1 we faced network outage affecting most of the services available to the public. Work is ongoing for getting this issue addressed as soon as possible. Sorry for the inconveniences generated. Regards, Alin Crețu ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-marketing] Re: [libreoffice-website] [LibreOffice Bugzilla Migration] We're done! Please visit the new site to reset your password!
Hi :) A big +1 from me! I guess there might be teething problems but hopefully we can all be patient with those and just enjoy the advantages of the new system more and more :) Many thanks and regards from Tom :) On 25 January 2015 at 09:22, Florian Effenberger flo...@documentfoundation.org wrote: Hi, Robinson Tryon wrote on 2015-01-24 at 21:50: The migration was a great success. All of our bugs are now happily living at https://bugs.documentfoundation.org/ thanks a lot to everyone involved, especially Robinson, Cloph and Alex - great work, and happy to finally have BugZilla in our own infrastructure! Thanks for the extra work during the weekend, you rock! ;-) Florian -- To unsubscribe e-mail to: marketing+unsubscr...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/marketing/ All messages sent to this list will be publicly archived and cannot be deleted ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] And then there were two...
Hi, 2015-01-27 10:54 GMT+02:00 Robinson Tryon bishop.robin...@gmail.com: 2) What Components should this product have? Here's a start: - Documentation - General - Localization - UI - Installation - Connection - Pebble - Android - iOS - FirefoxOS 5) How about the Pebble remote? Should this have its own component? (Gülşah: you're the expert here :-) Pebble component makes easier to follow bugs about pebble-remote :) Regards -- *Gülşah Köse* *about.me http://about.me/gulsahkose* ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 65830] Other: Trying to connect to MySQL database trough ODBC crashes LibreOffice - signal 11 (SIGSEGV) (summary in comment 34)
https://bugs.documentfoundation.org/show_bug.cgi?id=65830 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #39 from Beluga todven...@suomi24.fi --- (In reply to Lionel Elie Mamane from comment #34) 1) Install MySQL or MariaDB, or secure access to a server. 2) Install MyODBC (from OpenSUSE 12.3) 3) In MySQL connection: CREATE DATABASE fdo65830; use fdo65830; 4) replay the SQL script in attachment 81091 [details] (e.g.: SCRIPT /path/to/libretest.sql; ) Did this on openSUSE 13.2 64-bit with MariaDB 10.0.13, MyODBC 5.1.8, unixODBC 2.3.2. Running the script was with: \. /home/test/libretest.sql 5) In ~/.odbc.ini, add something like: My ~/.odbc.ini is: [ODBC Data Sources] myodbc5 = MySQL ODBC 5.1.8 Driver DSN [fdo65830] Description = fdo#65830 test DB Driver = MySQL Server = 127.0.0.1 Database= fdo65830 Port= 3306 Socket = Option = 3 ReadOnly= No I got help from Mechtilde on IRC and used this guide with modifications: http://mechtilde.de/mysql2ooo20/howtomysql2ooo20.html I also have an /etc/unixODBC/odbcinst.ini: [unixODBC] Description = ODBC Driver for Unix Driver = /usr/lib64/libmyodbc5.so Setup = /usr/lib64/libodbcinst.so FileUsage = 1 CPTimeout = CPReuse = 6) libreoffice --base (use a 4.x TDF build, not OpenSUSE build) 7) Connect to an existing database Next 8) Connection using ODBC (Open Database Connectivityà Next LibO kept complaining about missing libodbc.so.1, so I had to link /usr/lib64/libodbc.so.2 /usr/lib64/libodbc.so.1 9) Browse / Select fdo65830 in list, OK, Next The list is empty. I'm stuck, what should I do? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49813] Enhanced autofilter popup window should be resizeable (too narrow)
https://bugs.documentfoundation.org/show_bug.cgi?id=49813 --- Comment #8 from Ellert Hardarson ellert.hardar...@gmail.com --- Still the same in LibreOffice Version: 4.3.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65830] Other: Trying to connect to MySQL database trough ODBC crashes LibreOffice - signal 11 (SIGSEGV) (summary in comment 34)
https://bugs.documentfoundation.org/show_bug.cgi?id=65830 --- Comment #40 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to Beluga from comment #39) (In reply to Lionel Elie Mamane from comment #34) 5) In ~/.odbc.ini, add something like: My ~/.odbc.ini is: [ODBC Data Sources] myodbc5 = MySQL ODBC 5.1.8 Driver DSN [fdo65830] Description = fdo#65830 test DB Driver = MySQL Server = 127.0.0.1 Database= fdo65830 Port= 3306 Socket = Option = 3 ReadOnly= No I also have an /etc/unixODBC/odbcinst.ini: [unixODBC] Description = ODBC Driver for Unix Driver = /usr/lib64/libmyodbc5.so Setup = /usr/lib64/libodbcinst.so FileUsage = 1 CPTimeout = CPReuse = The Driver = ... line must match the section name in odbcinst.ini (where you put unixODBC which is a bit weird). In other words, the Driver line in my instructions assumes that the corresponding driver section is called MySQL, but you called it unixODBC. Also, it seems unusual to me that the Setup = line maps to unixodbc's libodbcinst.so instead of a myodbc .so file; my entry has Setup=libodbcmyS.so; that's on Debian GNU/Linux FWIW. LibO kept complaining about missing libodbc.so.1, so I had to link /usr/lib64/libodbc.so.2 /usr/lib64/libodbc.so.1 This sounds like LibreOffice is compiled for a different libodbc than what you have... Usually, when the .so has a different name, it means it is an incompatible version, and simply linking one to the other WILL NOT WORK (or can seem to work, but lead to crashes, data corruption, etc). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86355] executable bit is set on non-executable files CREDITS, LICENSE and NOTICE
https://bugs.documentfoundation.org/show_bug.cgi?id=86355 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #10 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Richard PALO from comment #9) I must say I don't use git archive, perhaps there's some simple thing. from 'git help archive' I'm still not seeing executable bits set. Do you have a suggestion re: the perms changing? Perhaps the summary needs an update? Status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89127] Tools Macros OrganizeMacros Libreoffice Basic crashed LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=89127 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal r...@post.cz --- I can not confirm with win7 4.4.0.3 ID build: de093506bcdc5fafd9023ee680b8c60e3e0645d7 Version: 4.5.0.0.alpha0+ Build ID: 20deac4903fc0697477e855feeff482b3da234f9 TinderBox: Win-x86@42, Branch:master, Time: 2015-01-29_23:02:41 no freeze when Click Tools Macros OrganizeMacros Libreoffice Basic -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86636] Menu totally black when opening LO - also when opening database-file - summary circumstances -as far as possible- in comment 23
https://bugs.documentfoundation.org/show_bug.cgi?id=86636 Joel Madero jmadero@gmail.com changed: What|Removed |Added Severity|blocker |critical --- Comment #32 from Joel Madero jmadero@gmail.com --- Please don't manipulate the severity/importance. This is not a blocker. Moving back to critical. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/formulacell.hxx |4 sc/inc/tokenarray.hxx |3 +++ sc/source/core/data/formulacell.cxx | 13 - sc/source/core/tool/token.cxx | 27 +++ 4 files changed, 46 insertions(+), 1 deletion(-) New commits: commit fab297c7945b51964627aa16a0b0019442d27a66 Author: Tor Lillqvist t...@collabora.com Date: Wed Feb 4 16:19:38 2015 +0200 Check number of cells referenced by group instead of group size Put using it in #if 0 for now, though. This reverts commit 2021275f8fc33d9917d5fef58959a95da1dc7e6f. Change-Id: Ia6541df12ee97747badbbedd758873688190b00c diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx index 3803a46..c3a8f0e 100644 --- a/sc/inc/formulacell.hxx +++ b/sc/inc/formulacell.hxx @@ -411,6 +411,10 @@ public: bool IsSharedTop() const; SCROW GetSharedTopRow() const; SCROW GetSharedLength() const; + +// An estimate of the number of cells referenced by the formula +sal_Int32 GetWeight() const; + ScTokenArray* GetSharedCode(); const ScTokenArray* GetSharedCode() const; diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx index 5d6593d..ab1e941 100644 --- a/sc/inc/tokenarray.hxx +++ b/sc/inc/tokenarray.hxx @@ -60,6 +60,9 @@ public: virtual ~ScTokenArray(); ScTokenArray* Clone() const;/// True copy! +// An estimate of the number of cells referenced by the token array +sal_Int32 GetWeight() const; + void GenHash(); size_t GetHash() const { return mnHashValue;} diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 3939c04..d591870 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -3766,7 +3766,7 @@ bool ScFormulaCell::InterpretFormulaGroup() if (mxGroup-meCalcState == sc::GroupCalcDisabled) return false; -if (GetSharedLength() ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize) +if (GetWeight() ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize) { mxGroup-meCalcState = sc::GroupCalcDisabled; return false; @@ -4144,6 +4144,17 @@ SCROW ScFormulaCell::GetSharedLength() const return mxGroup ? mxGroup-mnLength : 0; } +sal_Int32 ScFormulaCell::GetWeight() const +{ +#if 0 +if (!mxGroup) +return pCode-GetWeight(); +return GetSharedLength() * GetSharedCode()-GetWeight(); +#else +return GetSharedLength(); +#endif +} + ScTokenArray* ScFormulaCell::GetSharedCode() { return mxGroup ? mxGroup-mpCode : NULL; diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 4312f55..e7e6ece 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -1417,6 +1417,33 @@ bool ScTokenArray::ImplGetReference( ScRange rRange, const ScAddress rPos, boo return bIs; } +sal_Int32 ScTokenArray::GetWeight() const +{ +sal_Int32 result(1); + +FormulaToken** p = pCode; +FormulaToken** pEnd = p + static_castsize_t(nLen); +for (; p != pEnd; ++p) +{ +switch ((*p)-GetType()) +{ +case svDoubleRef : +case svExternalDoubleRef: +{ +const ScComplexRefData rRef = *(*p)-GetDoubleRef(); +result += ( (rRef.Ref2.Row() - rRef.Ref1.Row() + 1) * (rRef.Ref2.Col() - rRef.Ref1.Col() + 1) ); +} +break; +default: +break; +} +} +// Just print out the this pointer. It turns out to be quite complicated to get +// a symbolic printout of the ScTokenArray here. +SAL_INFO(sc.token, GetWeight( this ): result); +return result; +} + namespace { // we want to compare for similar not identical formulae ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [libreoffice-design] Re: [libreoffice-projects] minutes of ESC call ...
Writer: - Implement Image crop tool similar to the one present in Impress, Sidebar: - Implement an Insert subcategory in the Properties tab of the Sidebar in Writer/Calc/Excel, - Implement a Data subcategory in the Properties tab of the Sidebar in Calc, General - Allow to use different shapes in cropped images in Writer/Impress/Draw (besides the rectangle) - similar to Google Docs. On Wed, Feb 4, 2015 at 9:47 AM, Noel Grandin noelgran...@gmail.com wrote: On 2015-02-01 02:05 PM, Michel Renon wrote: here are some ideas : if you think some might be interesting, tell me and I'll make some specs/ux design Those are some very good ideas! Even if they don't make the GSOC, they should probably be logged in bugzilla. -- To unsubscribe e-mail to: design+unsubscr...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to- unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/design/ All messages sent to this list will be publicly archived and cannot be deleted ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/inc sc/source
sc/inc/formulacell.hxx |4 sc/inc/tokenarray.hxx |3 +++ sc/source/core/data/formulacell.cxx | 13 - sc/source/core/tool/token.cxx | 27 +++ 4 files changed, 46 insertions(+), 1 deletion(-) New commits: commit 3c50f98dc266b42ffe9cdc8843d21e4a47a16bcb Author: Tor Lillqvist t...@collabora.com Date: Wed Feb 4 16:19:38 2015 +0200 Check number of cells referenced by group instead of group size Put using it in #if 0 for now, though. This reverts commit 1fd902d4b851c534cf7473dd13983fc2c46500ed Change-Id: I7bb3efdc594bf7f1a61b037bf3488dae4ca119c9 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx index 86b8045..746ca550 100644 --- a/sc/inc/formulacell.hxx +++ b/sc/inc/formulacell.hxx @@ -410,6 +410,10 @@ public: bool IsSharedTop() const; SCROW GetSharedTopRow() const; SCROW GetSharedLength() const; + +// An estimate of the number of cells referenced by the formula +sal_Int32 GetWeight() const; + ScTokenArray* GetSharedCode(); const ScTokenArray* GetSharedCode() const; diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx index 07f344b..ad61ef3 100644 --- a/sc/inc/tokenarray.hxx +++ b/sc/inc/tokenarray.hxx @@ -59,6 +59,9 @@ public: virtual ~ScTokenArray(); ScTokenArray* Clone() const;/// True copy! +// An estimate of the number of cells referenced by the token array +sal_Int32 GetWeight() const; + void GenHash(); size_t GetHash() const { return mnHashValue;} diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index bc9ffbe..98bb568 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -3750,7 +3750,7 @@ bool ScFormulaCell::InterpretFormulaGroup() if (mxGroup-meCalcState == sc::GroupCalcDisabled) return false; -if (GetSharedLength() ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize) +if (GetWeight() ScInterpreter::GetGlobalConfig().mnOpenCLMinimumFormulaGroupSize) { mxGroup-meCalcState = sc::GroupCalcDisabled; return false; @@ -4128,6 +4128,17 @@ SCROW ScFormulaCell::GetSharedLength() const return mxGroup ? mxGroup-mnLength : 0; } +sal_Int32 ScFormulaCell::GetWeight() const +{ +#if 0 +if (!mxGroup) +return pCode-GetWeight(); +return GetSharedLength() * GetSharedCode()-GetWeight(); +#else +return GetSharedLength(); +#endif +} + ScTokenArray* ScFormulaCell::GetSharedCode() { return mxGroup ? mxGroup-mpCode : NULL; diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 8816b87..ee55b07 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -1412,6 +1412,33 @@ bool ScTokenArray::ImplGetReference( ScRange rRange, const ScAddress rPos, boo return bIs; } +sal_Int32 ScTokenArray::GetWeight() const +{ +sal_Int32 result(1); + +FormulaToken** p = pCode; +FormulaToken** pEnd = p + static_castsize_t(nLen); +for (; p != pEnd; ++p) +{ +switch ((*p)-GetType()) +{ +case svDoubleRef : +case svExternalDoubleRef: +{ +const ScComplexRefData rRef = *(*p)-GetDoubleRef(); +result += ( (rRef.Ref2.Row() - rRef.Ref1.Row() + 1) * (rRef.Ref2.Col() - rRef.Ref1.Col() + 1) ); +} +break; +default: +break; +} +} +// Just print out the this pointer. It turns out to be quite complicated to get +// a symbolic printout of the ScTokenArray here. +SAL_INFO(sc.token, GetWeight( this ): result); +return result; +} + namespace { // we want to compare for similar not identical formulae ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties
https://bugs.documentfoundation.org/show_bug.cgi?id=83726 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|RESOLVED|NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise Resolution|NOTABUG |--- Ever confirmed|0 |1 --- Comment #7 from Joel Madero jmadero@gmail.com --- I am setting this to NEW and asking for ux-advise. I find this behavior to be consistently annoying and if a user wants a style applied, they almost definitely want every property of that style applied. UX - any thoughts here? Feel free to close again but please think of users who don't know about this direct formatting stuff (and the shortcut of ctrl + m to remove it). On one side we tell users to start using styles consistently, but on the other, when you apply a style, you don't see consistent results. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89127] Tools Macros OrganizeMacros Libreoffice Basic crashed LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=89127 Joel Madero jmadero@gmail.com changed: What|Removed |Added CC||jmadero@gmail.com --- Comment #1 from Joel Madero jmadero@gmail.com --- Please report one bug per report (here you seem to have two...one with recording, one with organizing macros). Also please try with a fresh profile: https://wiki.documentfoundation.org/UserProfile For this one we'll only address the first issue (organize macros crash). That being said, I'm not on a windows machine right now so can't test -- leaving as UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'private/llunak/munich_12587'
New branch 'private/llunak/munich_12587' available with the following commits: commit 4fe21d490b073a970364eaaff830d5734975124a Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Feb 4 19:39:52 2015 +0100 discard excessive (X11) autorepeat keyboard events if they overload LO If e.g. a document is slow to redraw, scrolling it by holding down a key such as PageDown can make LO lag behind and continue processing the queued up input events even (long) after the key has been released. Since with autorepeat keyboard events the normal user expectations are to hold it until something happens and the exact number of the events doesn't matter, simply discard excessive autorepeat keyboard events if LO can't keep up with them. (cherry picked from commit fc29d34dc60dda5ddbc8f0444684bd2f4eb3668e) Change-Id: I45acdc9aa5033647fb80760991437dddfcb6591c commit cedee021e45ddd0655e9cb791cf706ab4ef042af Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Feb 4 19:37:27 2015 +0100 compress (X11) mouse wheel events There is one event per wheel step, so wheeling more can create a number of wheel events, and LO processed those one by one. If processing one took long (e.g. the repaint was complicated), the scrolling visibly lagged. This commit works only for X11 VCL backend (and by extension, KDE3/4 backends). (cherry picked from commit 847513d409b146400515d7796d196b8b2a142036) Change-Id: I5eff7446da16167ec75925e75243314c68bc81a4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89127] New: Tools Macros OrganizeMacros Libreoffice Basic crashed LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=89127 Bug ID: 89127 Summary: Tools Macros OrganizeMacros Libreoffice Basic crashed LibreOffice Product: LibreOffice Version: 4.4.0.0.alpha1 Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rleht...@gmail.com Installed first Fresh version, then removed and installed Still version. Same problem. Windows 7 with plenty of RAM. When I Click Tools Macros OrganizeMacros Libreoffice Basic I lose all mouse and menu control. Need to use Task Manager to close it. Problem does not occur when I go to Tools Macros OrganizeMacros Python. I have Java 7 latest version installed (750). This problem happened even with LO 4.4.0. I have tried many combinations over several days. Problem occurred as well when I was runni9ng Java 7 (210). Problem occurs when using Macro Recorder as well. Macro recorder Stop Recording button accepts mouse click, but does not finish recording session. Then I loose control and have to go to Task Manager to start over again. I really want to record a few macros. I have checked Bugzilla, checked the LO website, etc. This problem seems to come and go over the years. Please advise how I can start making macros without locking up the works. Cheers, RickWriter -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44282] [FORMATING] [TOC] space missing between text and ouline numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=44282 --- Comment #11 from Lovekesh Garg iamvoi...@gmail.com --- Hello ,I am a rookie and want to solve this as my first easy bug hack. Can any body give me idea how should I procede. Thanks in Advance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry sc/source
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |2 +- sc/source/core/tool/calcconfig.cxx |4 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit cf726ae8514ce9ad8f8a88e2de06a67850543fef Author: Tor Lillqvist t...@collabora.com Date: Wed Feb 4 21:30:59 2015 +0200 Add Add, Sub, Mul and Div back to the default OpenCL opcode subset The code falls back to the traditional interpreter when necessary. This reverts commit ad582ce757f671a6271648e22a136f2d238cc15e. Change-Id: I4cbafba2c469c0814dcc5c5210db5ce495e6b641 diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs index 7ef9afb..5966b0b 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs @@ -1373,7 +1373,7 @@ true, and a formula contains only these operators and functions, it might be calculated using OpenCL./desc /info - valueRAND;SIN;COS;TAN;ATAN;EXP;LN;SQRT;NORMSINV;ROUND;POWER;SUMPRODUCT;MIN;MAX;SUM;PRODUCT;AVERAGE;COUNT;NORMDIST;SUMIFS/value + value+;-;*;/;RAND;SIN;COS;TAN;ATAN;EXP;LN;SQRT;NORMSINV;ROUND;POWER;SUMPRODUCT;MIN;MAX;SUM;PRODUCT;AVERAGE;COUNT;NORMDIST;SUMIFS/value /prop prop oor:name=OpenCLAutoSelect oor:type=xs:boolean oor:nillable=false !-- UIHints: Tools - Options Spreadsheet Formula -- diff --git a/sc/source/core/tool/calcconfig.cxx b/sc/source/core/tool/calcconfig.cxx index 4e9292a..0023910 100644 --- a/sc/source/core/tool/calcconfig.cxx +++ b/sc/source/core/tool/calcconfig.cxx @@ -41,6 +41,10 @@ void ScCalcConfig::setOpenCLConfigToDefault() // Keep in order of opcode value, is that clearest? (Random order, // at least, would make no sense at all.) +maOpenCLSubsetOpCodes.insert(ocAdd); +maOpenCLSubsetOpCodes.insert(ocSub); +maOpenCLSubsetOpCodes.insert(ocMul); +maOpenCLSubsetOpCodes.insert(ocDiv); maOpenCLSubsetOpCodes.insert(ocRandom); maOpenCLSubsetOpCodes.insert(ocSin); maOpenCLSubsetOpCodes.insert(ocCos); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89129] EDITING: crash when defining a specific relationship
https://bugs.documentfoundation.org/show_bug.cgi?id=89129 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- bt=new -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89129] EDITING: crash when defining a specific relationship
https://bugs.documentfoundation.org/show_bug.cgi?id=89129 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/workctrl.hxx| 13 ++--- sw/source/uibase/ribbar/workctrl.cxx |6 +++--- 2 files changed, 13 insertions(+), 6 deletions(-) New commits: commit 535f34bba60e06d390a6f3802072b16a9841bc4e Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 4 21:04:44 2015 + Resolves: tdf#Crash when clicking the Reminder icon on the Navigation toolbar the Parent window isn't a SwScrollNaviPopup anymore Change-Id: I5c539d125aac28bfee0beb842ff2df001e19c945 diff --git a/sw/source/uibase/inc/workctrl.hxx b/sw/source/uibase/inc/workctrl.hxx index 493b164..6bb9c1f 100644 --- a/sw/source/uibase/inc/workctrl.hxx +++ b/sw/source/uibase/inc/workctrl.hxx @@ -110,14 +110,21 @@ public: DECL_LINK(PopupHdl, PopupMenu*); }; +class SwScrollNaviPopup; + class SwScrollNaviToolBox : public ToolBox { +SwScrollNaviPopup *m_pNaviPopup; + virtual voidMouseButtonUp( const MouseEvent rMEvt ) SAL_OVERRIDE; virtual voidRequestHelp( const HelpEvent rHEvt ) SAL_OVERRIDE; -public: -SwScrollNaviToolBox(vcl::Window* pParent, WinBits nWinStyle ) : -ToolBox(pParent, nWinStyle ) {} +public: +SwScrollNaviToolBox(vcl::Window* pParent, SwScrollNaviPopup* pNaviPopup, WinBits nWinStyle) +: ToolBox(pParent, nWinStyle) +, m_pNaviPopup(pNaviPopup) +{ +} }; class SwScrollNaviPopup : public SfxPopupWindow diff --git a/sw/source/uibase/ribbar/workctrl.cxx b/sw/source/uibase/ribbar/workctrl.cxx index 5317632..09ee4a3 100644 --- a/sw/source/uibase/ribbar/workctrl.cxx +++ b/sw/source/uibase/ribbar/workctrl.cxx @@ -394,7 +394,7 @@ SwScrollNaviPopup::SwScrollNaviPopup(sal_uInt16 nId, const Reference XFrame modules/swriter/ui/floatingnavigation.ui, rFrame), aIList(SW_RES(IL_VALUES)) { -m_pToolBox = new SwScrollNaviToolBox(getvcl::Window(box), 0); +m_pToolBox = new SwScrollNaviToolBox(getvcl::Window(box), this, 0); get(m_pInfoField, label); sal_uInt16 i; @@ -502,8 +502,8 @@ IMPL_LINK(SwScrollNaviPopup, SelectHdl, ToolBox*, pSet) void SwScrollNaviToolBox::MouseButtonUp( const MouseEvent rMEvt ) { ToolBox::MouseButtonUp(rMEvt); -if ( static_castSwScrollNaviPopup*(GetParent())-IsInPopupMode() ) -static_castSwScrollNaviPopup*(GetParent())-EndPopupMode( FLOATWIN_POPUPMODEEND_CLOSEALL ); +if (m_pNaviPopup-IsInPopupMode()) +m_pNaviPopup-EndPopupMode(FLOATWIN_POPUPMODEEND_CLOSEALL); } void SwScrollNaviToolBox::RequestHelp( const HelpEvent rHEvt ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68137] ODT Document crash when editing script fields / script editor
https://bugs.documentfoundation.org/show_bug.cgi?id=68137 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60345] SUMIF does not sum properly accounting for use of wildcard * in the search criteria.
https://bugs.documentfoundation.org/show_bug.cgi?id=60345 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|REOPENED|RESOLVED CC||mari...@miguelangel.mobi Resolution|--- |DUPLICATE --- Comment #13 from m.a.riosv mari...@miguelangel.mobi --- Enhancement request. https://bugs.documentfoundation.org/show_bug.cgi?id=72196 *** This bug has been marked as a duplicate of bug 72196 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85004] Writer: Crash when clicking the Reminder icon on the Navigation toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=85004 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source include/framework sfx2/source
framework/source/classes/menumanager.cxx |8 - framework/source/fwe/classes/addonmenu.cxx|4 framework/source/fwe/classes/bmkmenu.cxx |4 framework/source/fwe/xml/menuconfiguration.cxx| 12 +- framework/source/uielement/menubarmanager.cxx | 12 +- framework/source/uielement/newmenucontroller.cxx |8 - framework/source/uielement/popuptoolbarcontroller.cxx |4 include/framework/menuconfiguration.hxx | 88 +- sfx2/source/menu/mnuitem.cxx |8 - sfx2/source/menu/virtmenu.cxx | 12 +- 10 files changed, 80 insertions(+), 80 deletions(-) New commits: commit af6cd2356afd1212acc529f796f8043ad7e278e6 Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 4 20:46:57 2015 + rename MenuConfiguration::Attributes-MenuAttributes Change-Id: I2ada1394c4cbee7c27b02f241ee4a254597a5dd8 diff --git a/framework/source/classes/menumanager.cxx b/framework/source/classes/menumanager.cxx index c09cc87..b9350ef 100644 --- a/framework/source/classes/menumanager.cxx +++ b/framework/source/classes/menumanager.cxx @@ -219,8 +219,8 @@ MenuManager::MenuManager( Image aImage; OUString aImageId; -MenuConfiguration::Attributes* pMenuAttributes = - reinterpret_castMenuConfiguration::Attributes*(pMenu-GetUserValue( nItemId )); +MenuAttributes* pMenuAttributes = + reinterpret_castMenuAttributes*(pMenu-GetUserValue( nItemId )); if ( pMenuAttributes !pMenuAttributes-aImageId.isEmpty() ) { @@ -944,8 +944,8 @@ void MenuManager::FillMenuImages(Reference XFrame _xFrame, Menu* _pMenu,bool boolbImageSet = false; OUString aImageId; -::framework::MenuConfiguration::Attributes* pMenuAttributes = -reinterpret_cast ::framework::MenuConfiguration::Attributes*(_pMenu-GetUserValue( nId )); +::framework::MenuAttributes* pMenuAttributes = +reinterpret_cast ::framework::MenuAttributes*(_pMenu-GetUserValue( nId )); if ( pMenuAttributes ) aImageId = pMenuAttributes-aImageId; // Retrieve image id from menu attributes diff --git a/framework/source/fwe/classes/addonmenu.cxx b/framework/source/fwe/classes/addonmenu.cxx index 54c1fa9..5161e62 100644 --- a/framework/source/fwe/classes/addonmenu.cxx +++ b/framework/source/fwe/classes/addonmenu.cxx @@ -330,8 +330,8 @@ void AddonMenuManager::BuildMenu( PopupMenu* pCurrent // Store values from configuration to the New and Wizard menu entries to enable // sfx2 based code to support high contrast mode correctly! -sal_uIntPtr nAttributePtr = MenuConfiguration::Attributes::CreateAttribute(aTarget, aImageId); -pCurrentMenu-SetUserValue(nId, nAttributePtr, MenuConfiguration::Attributes::ReleaseAttribute); +sal_uIntPtr nAttributePtr = MenuAttributes::CreateAttribute(aTarget, aImageId); +pCurrentMenu-SetUserValue(nId, nAttributePtr, MenuAttributes::ReleaseAttribute); pCurrentMenu-SetItemCommand( nId, aURL ); if ( pSubMenu ) diff --git a/framework/source/fwe/classes/bmkmenu.cxx b/framework/source/fwe/classes/bmkmenu.cxx index a3f4290..cc9c31f 100644 --- a/framework/source/fwe/classes/bmkmenu.cxx +++ b/framework/source/fwe/classes/bmkmenu.cxx @@ -164,8 +164,8 @@ void BmkMenu::Initialize() else InsertItem( nId, aTitle ); -sal_uIntPtr nAttributePtr = MenuConfiguration::Attributes::CreateAttribute(aTargetFrame, aImageId); -SetUserValue(nId, nAttributePtr, MenuConfiguration::Attributes::ReleaseAttribute); +sal_uIntPtr nAttributePtr = MenuAttributes::CreateAttribute(aTargetFrame, aImageId); +SetUserValue(nId, nAttributePtr, MenuAttributes::ReleaseAttribute); SetItemCommand( nId, aURL ); } diff --git a/framework/source/fwe/xml/menuconfiguration.cxx b/framework/source/fwe/xml/menuconfiguration.cxx index aabbc47..1d2a8dd 100644 --- a/framework/source/fwe/xml/menuconfiguration.cxx +++ b/framework/source/fwe/xml/menuconfiguration.cxx @@ -139,25 +139,25 @@ void MenuConfiguration::StoreMenuBarConfigurationToXML( } } -sal_uIntPtr MenuConfiguration::Attributes::CreateAttribute(const OUString rFrame, const OUString rImageIdStr) +sal_uIntPtr MenuAttributes::CreateAttribute(const OUString rFrame, const OUString rImageIdStr) { -Attributes* pAttributes = new Attributes(rFrame, rImageIdStr); +MenuAttributes* pAttributes = new MenuAttributes(rFrame, rImageIdStr); pAttributes-acquire(); return
[Libreoffice-bugs] [Bug 89099] Circular Cell Reference causes Bad Allocation Crash in 4.4.0.3
https://bugs.documentfoundation.org/show_bug.cgi?id=89099 --- Comment #2 from ma...@sce-engineers.com --- (In reply to m.a.riosv from comment #1) Hi @marco, thanks for reporting. If was possible better attach a sample file. Kind of hard to attach a sample file since the data is sensitive I'm not sure I could replicate a sample file. I'll try. Side note, after resaving into Excel format, I discovered I could no longer save into an ODS format. After some poking, I removed all conditional formatting and now things really seem to have stabilized. Conditional formatting, although visually helpful, seems to generate havok. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89111] Over 1 million rows in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=89111 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||mari...@miguelangel.mobi Resolution|--- |NOTABUG --- Comment #1 from m.a.riosv mari...@miguelangel.mobi --- Hi @mercergeoingo, thanks for reporting. Sorry but no a bug, 1048576 is the row limit and doesn't influence the performance except you use it. Open a new spreadsheet and 1048576 rows are there with 1024 columns. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85004] Writer: Crash when clicking the Reminder icon on the Navigation toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=85004 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Whiteboard||BSA target:4.5.0 --- Comment #10 from Caolán McNamara caol...@redhat.com --- http://cgit.freedesktop.org/libreoffice/core/commit/?id=535f34bba60e06d390a6f3802072b16a9841bc4e https://gerrit.libreoffice.org/14326 for 4.4.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - dbaccess/source sw/source unusedcode.easy
dbaccess/source/ui/inc/TableController.hxx |4 dbaccess/source/ui/tabledesign/TEditControl.cxx| 20 dbaccess/source/ui/tabledesign/TEditControl.hxx|3 --- dbaccess/source/ui/tabledesign/TableController.cxx | 11 --- sw/source/ui/fldui/javaedit.cxx|7 ++- unusedcode.easy|5 - 6 files changed, 6 insertions(+), 44 deletions(-) New commits: commit 38a65f76bc944ea730ebac7640dc135248ec3da0 Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 4 17:11:14 2015 + Resolves: fdo#68137 crash in traversing script fields use the same guards as the SwFldEditDlg does Change-Id: I7d135cf969d9925cec57a90ef0fba8fe40f664eb diff --git a/sw/source/ui/fldui/javaedit.cxx b/sw/source/ui/fldui/javaedit.cxx index e67d532..0e27086 100644 --- a/sw/source/ui/fldui/javaedit.cxx +++ b/sw/source/ui/fldui/javaedit.cxx @@ -73,7 +73,7 @@ SwJavaEditDialog::SwJavaEditDialog(vcl::Window* pParent, SwWrtShell* pWrtSh) : aFont.SetWeight( WEIGHT_LIGHT ); m_pEditED-SetFont( aFont ); -pMgr = new SwFldMgr; +pMgr = new SwFldMgr(pSh); pFld = static_castSwScriptField*(pMgr-GetCurFld()); bNew = !(pFld pFld-GetTyp()-Which() == RES_SCRIPTFLD); @@ -88,6 +88,7 @@ SwJavaEditDialog::SwJavaEditDialog(vcl::Window* pParent, SwWrtShell* pWrtSh) : SwJavaEditDialog::~SwJavaEditDialog() { +pSh-EnterStdMode(); delete pMgr; delete pFileDlg; Application::SetDefDialogParent( pOldDefDlgParent ); @@ -95,6 +96,8 @@ SwJavaEditDialog::~SwJavaEditDialog() IMPL_LINK_NOARG_INLINE_START(SwJavaEditDialog, PrevHdl) { +pSh-EnterStdMode(); + SetFld(); pMgr-GoPrev(); pFld = static_castSwScriptField*(pMgr-GetCurFld()); @@ -107,6 +110,8 @@ IMPL_LINK_NOARG_INLINE_END(SwJavaEditDialog, PrevHdl) IMPL_LINK_NOARG_INLINE_START(SwJavaEditDialog, NextHdl) { +pSh-EnterStdMode(); + SetFld(); pMgr-GoNext(); pFld = static_castSwScriptField*(pMgr-GetCurFld()); commit 7e1eb03a39b776adf0f479e2801214b1e2d0f6cc Author: Caolán McNamara caol...@redhat.com Date: Wed Feb 4 17:15:02 2015 + callcatcher: remove some more recently discovered unused methods Change-Id: Ib01e444b24ad9288970066a47f3fcf3dbee1fc49 diff --git a/dbaccess/source/ui/inc/TableController.hxx b/dbaccess/source/ui/inc/TableController.hxx index d44aa34..578eb99 100644 --- a/dbaccess/source/ui/inc/TableController.hxx +++ b/dbaccess/source/ui/inc/TableController.hxx @@ -133,10 +133,6 @@ namespace dbaui static ::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface SAL_CALL Create(const ::com::sun::star::uno::Reference ::com::sun::star::lang::XMultiServiceFactory ); - -void Load(const ::com::sun::star::uno::Reference ::com::sun::star::io::XObjectInputStream _rxIn); -void Save(const ::com::sun::star::uno::Reference ::com::sun::star::io::XObjectOutputStream _rxOut); - protected: void startTableListening(); void stopTableListening(); diff --git a/dbaccess/source/ui/tabledesign/TEditControl.cxx b/dbaccess/source/ui/tabledesign/TEditControl.cxx index ce169f3..ad3e528 100644 --- a/dbaccess/source/ui/tabledesign/TEditControl.cxx +++ b/dbaccess/source/ui/tabledesign/TEditControl.cxx @@ -129,15 +129,6 @@ void OTableEditorCtrl::Init() RowInserted(0, m_pRowList-size(), true); } -void OTableEditorCtrl::UpdateAll() -{ -RowRemoved(0, GetRowCount(), false); -m_nDataPos = 0; - -InvalidateFeatures(); -Invalidate(); -} - OTableEditorCtrl::OTableEditorCtrl(vcl::Window* pWindow) :OTableRowView(pWindow) ,pNameCell(NULL) @@ -716,17 +707,6 @@ void OTableEditorCtrl::InvalidateFeatures() GetView()-getController().InvalidateFeature(SID_SAVEDOC); } -void OTableEditorCtrl::Undo() -{ - -InvalidateFeatures(); -} - -void OTableEditorCtrl::Redo() -{ -InvalidateFeatures(); -} - void OTableEditorCtrl::CopyRows() { // set to the right row and save it diff --git a/dbaccess/source/ui/tabledesign/TEditControl.hxx b/dbaccess/source/ui/tabledesign/TEditControl.hxx index cd9f73b..bfae245 100644 --- a/dbaccess/source/ui/tabledesign/TEditControl.hxx +++ b/dbaccess/source/ui/tabledesign/TEditControl.hxx @@ -100,8 +100,6 @@ namespace dbaui virtual void CellModified() SAL_OVERRIDE; virtual bool SaveModified() SAL_OVERRIDE; // is called before changing a cell (false prevents change) -void Undo(); -void Redo(); virtual OUString GetCellText(long nRow, sal_uInt16 nColId) const SAL_OVERRIDE; virtual sal_uInt32 GetTotalCellWidth(long nRow, sal_uInt16 nColId) SAL_OVERRIDE; @@ -125,7 +123,6 @@ namespace dbaui OTableEditorCtrl(vcl::Window* pParentWin); virtual ~OTableEditorCtrl(); virtual bool CursorMoving(long nNewRow, sal_uInt16 nNewCol) SAL_OVERRIDE; -void UpdateAll();
[Libreoffice-bugs] [Bug 72196] FILTER: Implement ODF 1.2 HOST-USE-WILDCARDS
https://bugs.documentfoundation.org/show_bug.cgi?id=72196 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added CC||t...@tim-richardson.net --- Comment #9 from m.a.riosv mari...@miguelangel.mobi --- *** Bug 60345 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89128] LO Writer fails to properly track numbered lists
https://bugs.documentfoundation.org/show_bug.cgi?id=89128 --- Comment #1 from YSO yan...@olanguena.com --- I first noticed the problem while working on titles. I believed that if I was to apply the same style on two lines, and that the first line to which the style has been applied was part of a numbered list, the second line would immediately become an item of the said list upon being applied the same style as the first one. Wasn't this feature, kind of automated track of numbering depending on the applied style already present in LO? If not, I'm wondering if it could be considered? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xeextlst.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit e98b6027458dd9410e27c5f273f4db5cc1443b01 Author: Katarina Behrens bu...@bubli.org Date: Wed Feb 4 22:43:31 2015 +0100 Seems that BS() does something else than I thought XclXmlUtils::ToPsz is the one I needed Change-Id: If4aee9a2a9c943535d7e07b08f61b419ac2c8a22 diff --git a/sc/source/filter/excel/xeextlst.cxx b/sc/source/filter/excel/xeextlst.cxx index 9015672..c621c24 100644 --- a/sc/source/filter/excel/xeextlst.cxx +++ b/sc/source/filter/excel/xeextlst.cxx @@ -14,7 +14,6 @@ #include xename.hxx #include xecontent.hxx #include tokenarray.hxx -#include oox/export/utils.hxx using namespace ::oox; @@ -151,7 +150,7 @@ void XclExpExtDataBar::SaveXml( XclExpXmlStream rStrm ) XML_minLength, OString::number(0).getStr(), XML_maxLength, OString::number(100).getStr(), XML_axisPosition, getAxisPosition(meAxisPosition), -XML_gradient, BS(mbGradient), +XML_gradient, XclXmlUtils::ToPsz(mbGradient), FSEND ); mpLowerLimit-SaveXml( rStrm ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68137] ODT Document crash when editing script fields / script editor
https://bugs.documentfoundation.org/show_bug.cgi?id=68137 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:4.5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68137] ODT Document crash when editing script fields / script editor
https://bugs.documentfoundation.org/show_bug.cgi?id=68137 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=38a65f76bc944ea730ebac7640dc135248ec3da0 Resolves: fdo#68137 crash in traversing script fields It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89129] New: EDITING: crash when defining a specific relationship
https://bugs.documentfoundation.org/show_bug.cgi?id=89129 Bug ID: 89129 Summary: EDITING: crash when defining a specific relationship Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Database Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: serval2...@yahoo.fr Created attachment 113131 -- https://bugs.documentfoundation.org/attachment.cgi?id=113131action=edit odb test file On pc Debian x86-64 with master sources updated today, I got a crash when defining a specific relationship. Steps to reproduce: - open database attached (hsqldb embedded) - Tools/Relationships - Increase size of tables Assets and Orders - Select StatusID in Assets and try to make a relation with CustomerID in Orders (of course it's nonsense but it's just to have the crash) expected: no crash of course -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89122] FILEOPEN an xlsx file with autofilter shows the autofilter icon not only in the top row
https://bugs.documentfoundation.org/show_bug.cgi?id=89122 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- I can not reproduce with my xlsx file on LO 4.4 and LO 4.5, win7, linux. File created in excel2010. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89128] New: LO Writer fails to properly track numbered lists
https://bugs.documentfoundation.org/show_bug.cgi?id=89128 Bug ID: 89128 Summary: LO Writer fails to properly track numbered lists Product: LibreOffice Version: 4.4.0.3 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yan...@olanguena.com Using the 4.4.0.3 release version of Libre Office Writer, it appears that the program can't properly track the numbered lists whether the numbering consist in actual numbers or letters. This results in un-proper numbering. Steps to reproduce : - Create a new document - Make 5 lines - Select the first and last line to create a numbered list. The two lines are now numbered, but it appears that the numbering restarts at each line (eg. '1.' and '1.'). - Select the lines 2,3,4. - Create a bullet list - Select line 5. Right-click and try to Continue previous numbering. - Instead of the expected outcome (line 5 being next in the numbered list, eg. '2.'), the last line will become and item of the bullet list, as if the program forgot that it was referring from the last seen numbered list and just applying the rule whatever last list is present within the text. One can also notice that if there's no list between the two items we want as a numbered list, then the Continue previous numbering is actually working as it should. Screencasting of the problem : http://dl.free.fr/pLA8brj6O System specs are : Ubuntu 14.04.1 LTS 64bits Linux PHARXTI 3.17.0 #2 SMP Fri Jan 16 01:35:04 CET 2015 x86_64 x86_64 x86_64 GNU/Linux LO was downloaded from : http://download.documentfoundation.org/libreoffice/stable/4.4.0/deb/x86_64/LibreOffice_4.4.0_Linux_x86-64_deb.tar.gz After having encountered the problem, I removed 4.4.0.3, reinstalled 4.3.0.4, and deleted ~/.config/libreoffice, reproduced the same steps and the problem was still there. Thanks for your support. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89128] LO Writer fails to properly track numbered lists
https://bugs.documentfoundation.org/show_bug.cgi?id=89128 YSO yan...@olanguena.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89107] Calc cannot display MS-Office Excel file(xlsx format) in correctly effects (loss template effects)
https://bugs.documentfoundation.org/show_bug.cgi?id=89107 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- Hello allen, Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89129] EDITING: crash when defining a specific relationship
https://bugs.documentfoundation.org/show_bug.cgi?id=89129 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- Created attachment 113132 -- https://bugs.documentfoundation.org/attachment.cgi?id=113132action=edit console bt with master sources -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88852] SIDEBAR: Mouse Pointer Displayed During Resizing a Sidebar Panel is at the Wrong Position
https://bugs.documentfoundation.org/show_bug.cgi?id=88852 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Harald Koester from comment #4) Created attachment 113125 [details] Screen Video of bug. Thank you very much for the vid. I guess the problem for my reproduction ability is that I don't have an interactive update of the sidebar width! I just see the ghost of the edge moving. I tried to find some option to enable interactive resizing of UI elements, but no luck. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89121] Implement smart placement of figures
https://bugs.documentfoundation.org/show_bug.cgi?id=89121 --- Comment #2 from Frederic Parrenin parrenin@gmail.com --- Anchoring the image to the page does not work if you insert a large section of text (e.g., several pages). Then the figure would be out of place. The current options for figure placement, as far as I have tested, cannot solve this problem of white spaces. You need a more flexible paragraph anchoring mechanism: the figure does not have to be directly besides the paragraph, it just has to be as close as possible while eliminating the white spaces. It is what is called floating figures in latex. It is a known limitation of LO with respect to latex (I work in the academic field) and I sincerely hope it will be solved one day. Some explanation on how it works in latex are given here: http://tex.stackexchange.com/questions/39017/how-to-influence-the-position-of-float-environments-like-figure-and-table-in-lat If you need, I can provide a concrete example of such a large text document with figure to better understand the problem. If this bug has not been already reported, it is in my opinion not a good idea to close it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88917] Distorted text in chart titles in EPS exports
https://bugs.documentfoundation.org/show_bug.cgi?id=88917 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming on Version: 4.5.0.0.alpha0+ Build ID: 6143a7eeabea394133c54e97e3690bdf40b98247 Locale: fr_ Enclosing exported EPS where ti can clearly be seen that the labels overwrite themselves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88917] Distorted text in chart titles in EPS exports
https://bugs.documentfoundation.org/show_bug.cgi?id=88917 --- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 113127 -- https://bugs.documentfoundation.org/attachment.cgi?id=113127action=edit exported ODS chart to eps file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - include/vcl vcl/headless vcl/inc vcl/osx vcl/source vcl/unx vcl/win
include/vcl/timer.hxx |5 - vcl/headless/svpinst.cxx|5 - vcl/inc/saltimer.hxx|4 vcl/inc/salwtype.hxx|2 vcl/inc/unx/gtk/gtkdata.hxx |2 vcl/inc/unx/saldata.hxx |2 vcl/inc/unx/saldisp.hxx |1 vcl/inc/unx/salframe.h |1 vcl/osx/salinst.cxx |3 vcl/osx/salnstimer.mm |3 vcl/osx/saltimer.cxx|3 vcl/source/app/svapp.cxx|4 vcl/source/app/timer.cxx|4 vcl/unx/generic/app/saldata.cxx | 23 + vcl/unx/generic/app/saltimer.cxx|4 vcl/unx/generic/window/salframe.cxx | 147 vcl/unx/gtk/app/gtkdata.cxx | 14 ++- vcl/unx/kde4/KDEXLib.cxx|9 +- vcl/unx/kde4/KDEXLib.hxx|1 vcl/win/source/app/saltimer.cxx |3 20 files changed, 189 insertions(+), 51 deletions(-) New commits: commit fc29d34dc60dda5ddbc8f0444684bd2f4eb3668e Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Feb 4 15:25:03 2015 +0100 discard excessive (X11) autorepeat keyboard events if they overload LO If e.g. a document is slow to redraw, scrolling it by holding down a key such as PageDown can make LO lag behind and continue processing the queued up input events even (long) after the key has been released. Since with autorepeat keyboard events the normal user expectations are to hold it until something happens and the exact number of the events doesn't matter, simply discard excessive autorepeat keyboard events if LO can't keep up with them. Change-Id: I45acdc9aa5033647fb80760991437dddfcb6591c diff --git a/vcl/inc/unx/salframe.h b/vcl/inc/unx/salframe.h index d7ce0c2..af89ba8 100644 --- a/vcl/inc/unx/salframe.h +++ b/vcl/inc/unx/salframe.h @@ -77,7 +77,6 @@ class VCLPLUG_GEN_PUBLIC X11SalFrame : public SalFrame, public X11WindowProvider X11SalGraphics *pGraphics_;// current frame graphics X11SalGraphics *pFreeGraphics_;// first free frame graphics -TimenReleaseTime_; // timestamp of last key release sal_uInt16 nKeyCode_; // last key code sal_uInt16 nKeyState_; // last key state int nCompose_; // compose state diff --git a/vcl/unx/generic/window/salframe.cxx b/vcl/unx/generic/window/salframe.cxx index 9dee672..77e70e7 100644 --- a/vcl/unx/generic/window/salframe.cxx +++ b/vcl/unx/generic/window/salframe.cxx @@ -778,7 +778,6 @@ X11SalFrame::X11SalFrame( SalFrame *pParent, sal_uLong nSalFrameStyle, hCursor_= None; nCaptured_ = 0; - nReleaseTime_ = 0; nKeyCode_ = 0; nKeyState_ = 0; nCompose_ = -1; @@ -3157,6 +3156,66 @@ bool X11SalFrame::endUnicodeSequence() long X11SalFrame::HandleKeyEvent( XKeyEvent *pEvent ) { +if( pEvent-type == KeyRelease ) +{ +// Ignore autorepeat keyrelease events. If there is a series of keypress+keyrelease+keypress events +// generated by holding down a key, and if these are from autorepeat (keyrelease and the following keypress +// have the same timestamp), drop the autorepeat keyrelease event. Not exactly sure why this is done +// (possibly hiding differences between platforms, or just making it more sensible, because technically +// the key has not been released at all). +bool ignore = false; +// Discard queued excessive autorepeat events. +// If the user presses and holds down a key, the autorepeating keypress events +// may overload LO (e.g. if the key is PageDown and the LO cannot keep up scrolling). +// Reduce the load by simply discarding such excessive events (so for a KeyRelease event, +// check if it's followed by matching KeyPress+KeyRelease pair(s) and discard those). +// This shouldn't have any negative effects - unlike with normal (non-autorepeat +// events), the user is unlikely to rely on the exact number of resulting actions +// (since autorepeat generates keypress events rather quickly and it's hard to estimate +// how many exactly) and the idea should be just keeping the key pressed until something +// happens (in which case more events that just lag LO shouldn't make a difference). +Display* dpy = pEvent-display; +XKeyEvent previousRelease = *pEvent; +while( XPending( dpy )) +{ +XEvent nextEvent1; +bool discard1 = false; +XNextEvent( dpy, nextEvent1 ); +if( nextEvent1.type == KeyPress nextEvent1.xkey.time == previousRelease.time + !nextEvent1.xkey.send_event nextEvent1.xkey.window == previousRelease.window +
[Libreoffice-bugs] [Bug 88917] Distorted text in chart titles in EPS exports
https://bugs.documentfoundation.org/show_bug.cgi?id=88917 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Keywords||regression --- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk --- Regression over LO 4242 where the labels are exported correctly, enclosed EPS file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: New Defects reported by Coverity Scan for LibreOffice
On 02/02/2015 04:28 PM, Lubos Lunak wrote: On Monday 02 of February 2015, Stephan Bergmann wrote: My take on it is simple: There /is/ a flaw in the above code, and Coverity /does/ correctly identify it. If the asserted condition cannot legitimately be false at that place, the ?: check is wrong and must go away. If it can, the assert is wrong and must go away (or, depending on context, be replaced with a SAL_WARN_IF, say). That is indeed the theory, but what is the reality? Can somebody with such a monstrous codebase say for sure which case it is for every instance of the problem? Nobody can for all of the codebase. But the author adding an assert in a specific place hopefully can for that instance. If memory serves me well, we shipped a couple of releases that under some circumstances had VCL KFileDialog integration hitting asserts on improper locking, but release builds still managed to cope with it somehow (more often than not, anyway). There must for sure be war stories providing evidence that defensive programming happened to exhibit desirable behavior on occasion. Developer builds should of course fall flat on their face in such cases, but in practice it's probably better to value end product stability more than practically insignificant warnings from a tool. That's probably where we are of different opinion, that IMO non-accidental stability can only arise from rigorousness. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88917] Distorted text in chart titles in EPS exports
https://bugs.documentfoundation.org/show_bug.cgi?id=88917 --- Comment #10 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 113128 -- https://bugs.documentfoundation.org/attachment.cgi?id=113128action=edit correctly exported labels from ODS chart to eps with LO 4242 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/Module_connectivity.mk
connectivity/Module_connectivity.mk |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit c0f080403b869e162dc81db6c8c50b7360a3 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Feb 4 17:03:00 2015 +0100 Do not let WNT non-INTEL run into the else branch Change-Id: I85a5f35fb8b44734e84c686ecdffc6096226b91d diff --git a/connectivity/Module_connectivity.mk b/connectivity/Module_connectivity.mk index 97310d1..ade21dd 100644 --- a/connectivity/Module_connectivity.mk +++ b/connectivity/Module_connectivity.mk @@ -102,7 +102,9 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif -ifeq ($(OS)-$(CPU),WNT-INTEL) +ifeq ($(OS),WNT) + +ifeq ($(CPU),INTEL) ifneq ($(WITH_MOZAB4WIN),) $(eval $(call gb_Module_add_targets,connectivity,\ @@ -116,6 +118,8 @@ $(eval $(call gb_Module_add_targets,connectivity,\ )) endif +endif + else ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) $(eval $(call gb_Module_add_targets,connectivity,\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89124] New: Add more system details to Help - About
https://bugs.documentfoundation.org/show_bug.cgi?id=89124 Bug ID: 89124 Summary: Add more system details to Help - About Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: markus.mohrh...@googlemail.com, michael.me...@collabora.com As a continuation of bug 85432 regarding the 'Locale' label in the dialog, Meeks stated, I'd change the string to : Details: and present a ',' separated list, system then selected locale - also whether OpenGL is enabled is another chestnut we need to make visible; ... might also be good to have the OS vendor/version too So i'd like to suggest the following format as an example :- System Details: Windows 7 64-bit, en_US, OpenGL enabled It would be nice to also include the OpenGL version number of the graphics card and possibly some additional info about the graphic card now that so much is being done in that department, even if its just the name (e.g. Intel, ATI, Nvidia). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88212] Load At Startup Option During Install Does Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=88212 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEEDINFO|NEW CC||jmadero@gmail.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=35 ||568 --- Comment #4 from Joel Madero jmadero@gmail.com --- Probably related but it's not exactly the same. These are clean installs (not upgrades). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs