[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 --- Comment #6 from ychu...@yandex.ru --- I deleted user profile and create backtrace.txt (attached). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
LibreOffice Gerrit News for core on 2015-04-17
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Applies CharAttribute to selected text and tests undo in https://gerrit.libreoffice.org/15158 from Austin Chen about module .git-hooks, build, sc, svx, sw + tdf#90223:PPTX table cell left and right margin is not exported. in https://gerrit.libreoffice.org/15015 from Yogesh Bharate about module oox, sd + mediawiki: cell alignment in https://gerrit.libreoffice.org/15351 from Robert Antoni Buj i Gelonch about module swext + tdf#90190 PPTX table cell border width is not exported. in https://gerrit.libreoffice.org/15350 from Yogesh Bharate about module include, oox, sd + mediawiki: font/backgroud color of the text in https://gerrit.libreoffice.org/15341 from Robert Antoni Buj i Gelonch about module swext + tdf#87437 exclude CR/cell break from redline deletions in https://gerrit.libreoffice.org/15340 from Justin Luth about module sw + enhancement : tdf#90225 Cannot open compressed csv files from calc in https://gerrit.libreoffice.org/15108 from Dennis Francis about module build, config_host, filter, include, sc, tools + tdf#80340: Table changes format in PPTX format in https://gerrit.libreoffice.org/14925 from Yogesh Bharate about module sd, svx + tdf#90494-Add new Attribute for exporting gradient angle diagonally in https://gerrit.libreoffice.org/15323 from Heena Gupta about module cui, drawinglayer, include, offapi, sfx2, svx, xmloff + tdf#90246 PPTX paragraph and bullet leftMargin and Indentation is not exp in https://gerrit.libreoffice.org/15016 from Priyanka Gaikwad about module include, oox, sd + tdf#90245: Support for table merge cell export. in https://gerrit.libreoffice.org/15282 from Sujith Sudhakaran about module oox End of freshness + Make use of std::unique_ptr to simplify ctor and dtor in https://gerrit.libreoffice.org/15359 from Takeshi Abe about module starmath + Power trendline: enable negative Y values in https://gerrit.libreoffice.org/15357 from Laurent BP about module chart2 + Exponential trendline: enable negative Y values in https://gerrit.libreoffice.org/15353 from Laurent BP about module chart2 + Make cpp/poppler-version.h header optional in https://gerrit.libreoffice.org/15339 from Tomáš Chvátal about module build, config_host, sdext + convert BROWSER_ constants to scoped enum in https://gerrit.libreoffice.org/15348 from Noel Grandin about module chart2, cui, dbaccess, include, reportdesign, svtools, svx, sw + convert SVX_SEARCHIN_ flags to scoped enum in https://gerrit.libreoffice.org/15347 from Noel Grandin about module include, sc, svl, svx + convert SFX_STYLESHEET_ constants to scoped enum in https://gerrit.libreoffice.org/15346 from Noel Grandin about module editeng, include, sc, sd, svl, svx, sw + convert SCRIPTTYPE_ constants to scoped enum in https://gerrit.libreoffice.org/15344 from Noel Grandin about module cui, desktop, editeng, forms, framework, include, oox, sc, sd, starmath, svl, svx, sw + convert SEARCH_OPTIONS constants to scoped enum in https://gerrit.libreoffice.org/15345 from Noel Grandin about module basctl, include, sc, sd, svx, sw + WIP: make all SwUnoCrsrs ref-counted in https://gerrit.libreoffice.org/15336 from Björn Michaelsen about module sw * Merged changes on master for project core changed in the last 25 hours: + Breeze: some updates recs from jay in https://gerrit.libreoffice.org/15358 from Andreas Kainz + Breeze: modifications and missing icons in https://gerrit.libreoffice.org/15338 from Andreas Kainz + Breeze: point fixes in https://gerrit.libreoffice.org/15337 from Andreas Kainz + Do not clobber configure output with gnutls in https://gerrit.libreoffice.org/15333 from Tomáš Chvátal * Abandoned changes on master for project core changed in the last 25 hours: + tdf#89394. fix hangs because of unavailable Windows UNC path. in https://gerrit.libreoffice.org/15311 from Jan K. * Open changes needing tweaks, but being untouched for more than a week: + Fix typo code Persistant in https://gerrit.libreoffice.org/14030 from Andrea Gelmini + tdf#90222: replace ScaList in scaddins with a std container in https://gerrit.libreoffice.org/15012 from Pieter Adriaensen + replace ScaList in scaddins with a std container tdf#90222 in https://gerrit.libreoffice.org/15177 from Pieter Adriaensen + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + tdf#64575 Photo Album: Better Image Layout in https://gerrit.libreoffice.org/14912 from Enes Ateş + WIP fdo#72987 Use firebird backup format for .odb no need for rebuild ind in https://gerrit.libreoffice.org/14968 from Popa Adrian Marius + Upgrade firebird to 2.5.3 , a few patches are already applied upstream in https://gerrit.libreoffice.org/15026 from Popa Adrian Marius + Removed unnecessary variables which occupy space in
[Libreoffice-bugs] [Bug 90669] New: Feature Request:Monochrome printing from Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=90669 Bug ID: 90669 Summary: Feature Request:Monochrome printing from Calc Product: LibreOffice Version: unspecified Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kg_oooh...@ashisuto.co.jp Created attachment 114849 -- https://bugs.documentfoundation.org/attachment.cgi?id=114849action=edit Attached sample pic Feature Request: I request the additional of the same features as the black-and-white print of Excel. For example,if you set the black and white from the print properties, the background color will be printed in gray. I want to print with no background color. Best regards. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 --- Comment #5 from ychu...@yandex.ru --- Created attachment 114850 -- https://bugs.documentfoundation.org/attachment.cgi?id=114850action=edit backtrace.txt -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source desktop/source editeng/source forms/source framework/inc framework/source include/editeng include/svl include/svx oox/source sc/inc sc/qa sc/source sd/source
cui/source/options/optgdlg.cxx | 10 - desktop/source/app/langselect.cxx |4 editeng/source/editeng/editdoc.cxx | 18 +- editeng/source/editeng/editdoc.hxx |5 editeng/source/editeng/editeng.cxx |6 editeng/source/editeng/editobj.cxx | 12 - editeng/source/editeng/editobj2.hxx | 13 - editeng/source/editeng/editview.cxx | 10 - editeng/source/editeng/impedit.hxx |7 editeng/source/editeng/impedit2.cxx | 12 - editeng/source/editeng/impedit3.cxx |9 - editeng/source/editeng/impedit4.cxx | 22 +- editeng/source/items/textitem.cxx | 80 ++ editeng/source/outliner/outlin2.cxx |2 editeng/source/outliner/outlvw.cxx | 10 - forms/source/richtext/richtextimplcontrol.cxx |8 - forms/source/richtext/richtextimplcontrol.hxx |4 forms/source/richtext/rtattributehandler.cxx| 19 +- forms/source/richtext/rtattributehandler.hxx| 21 +- forms/source/richtext/rtattributes.hxx |2 framework/inc/helper/mischelper.hxx | 11 - framework/inc/uielement/langselectionmenucontroller.hxx |8 - framework/source/fwi/helper/mischelper.cxx |4 framework/source/uielement/langselectionmenucontroller.cxx |6 framework/source/uielement/langselectionstatusbarcontroller.cxx | 14 - include/editeng/editeng.hxx |7 include/editeng/editobj.hxx |3 include/editeng/editview.hxx|3 include/editeng/outliner.hxx|7 include/editeng/scripttypeitem.hxx | 12 - include/svl/languageoptions.hxx | 48 -- include/svx/svdedxv.hxx |5 oox/source/export/drawingml.cxx |4 sc/inc/celltextattr.hxx |5 sc/inc/column.hxx |8 - sc/inc/document.hxx | 15 + sc/inc/documentimport.hxx |3 sc/inc/global.hxx |7 sc/inc/globalnames.hxx |4 sc/inc/patattr.hxx |7 sc/inc/table.hxx|6 sc/qa/unit/ucalc_column.cxx |8 - sc/source/core/data/celltextattr.cxx|2 sc/source/core/data/column.cxx | 14 - sc/source/core/data/column2.cxx | 42 ++--- sc/source/core/data/column3.cxx |2 sc/source/core/data/column4.cxx |2 sc/source/core/data/documen6.cxx| 39 ++-- sc/source/core/data/documen8.cxx|6 sc/source/core/data/document.cxx|6 sc/source/core/data/documentimport.cxx | 14 - sc/source/core/data/global.cxx | 24 +-- sc/source/core/data/patattr.cxx | 12 - sc/source/core/data/table1.cxx | 10 - sc/source/core/data/table5.cxx |4 sc/source/core/tool/numformat.cxx |4 sc/source/filter/excel/xestyle.cxx | 28 --- sc/source/filter/excel/xlroot.cxx |6 sc/source/filter/html/htmlexp.cxx |4 sc/source/filter/inc/htmlexp.hxx|4 sc/source/filter/rtf/eeimpars.cxx |6 sc/source/filter/xml/xmlimprt.cxx |2 sc/source/ui/app/inputwin.cxx | 14 - sc/source/ui/drawfunc/drtxtob.cxx |6 sc/source/ui/inc/gridwin.hxx|2 sc/source/ui/inc/viewfunc.hxx |2 sc/source/ui/inc/viewutil.hxx |4 sc/source/ui/view/editsh.cxx
[Libreoffice-bugs] [Bug 75554] VIEWING: Caused Xorg 100% CPU and the whole GUI hanged
https://bugs.documentfoundation.org/show_bug.cgi?id=75554 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #10 from Jean-Baptiste Faure jbfa...@libreoffice.org --- No problem for me with Version: 5.0.0.0.alpha0+ Build ID: 6ffecab0cfa0168ae2a98dc961de663855d41648 built at home under Ubuntu 14.10 x86-64. Opening and formatting the document is rather long but it is probably because the used font (Chinese) is not installed on my PC. No freeze at all. Idem (no problem) with LibreOffice 4.4.4.0.0+ also built at home under Ubuntu 14.10 x86-64. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/source
vcl/source/outdev/text.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 84b28b7d0b5061377b368c809acdb286902b4069 Author: Michael Stahl mst...@redhat.com Date: Thu Apr 16 22:25:23 2015 +0200 tdf#86793: vcl: speed up OutputDevice::GetEllipsisString() The ridiculous algrorithm used for TEXT_DRAW_CENTERELLIPSIS will go faster if we cut out most of the text at the beginning instead of one at a time. (regression from 912ecaf565e68d2ca3fb9584712313e712749f75) (cherry picked from commit c6ec3e4cee8c7c22380780f2661ac23946cdb050) Change-Id: I9310dda184715bafe372e3efef9d365e1ad9 Reviewed-on: https://gerrit.libreoffice.org/15355 Tested-by: Miklos Vajna vmik...@collabora.co.uk Reviewed-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx index 113a42e..8c066d1 100644 --- a/vcl/source/outdev/text.cxx +++ b/vcl/source/outdev/text.cxx @@ -1993,7 +1993,8 @@ OUString OutputDevice::ImplGetEllipsisString( const OutputDevice rTargetDevice, if( (nStyle TEXT_DRAW_CENTERELLIPSIS) == TEXT_DRAW_CENTERELLIPSIS ) { OUStringBuffer aTmpStr( aStr ); -sal_Int32 nEraseChars = 4; +// speed it up by removing all but 1.33x as many as the break pos. +sal_Int32 nEraseChars = std::maxsal_Int32(4, aStr.getLength() - (nIndex*4)/3); while( nEraseChars aStr.getLength() _rLayout.GetTextWidth( aTmpStr.toString(), 0, aTmpStr.getLength() ) nMaxWidth ) { aTmpStr = OUStringBuffer(aStr); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=48381 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from steve -_- st...@openmailbox.org --- Clement, does this persist with LO 4.4? What are the exact steps to reproduce this problem? NEEDINFO and please back to NEW once the requested information has been provided. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90670] New: android: Remove .res files from the .apk
https://bugs.documentfoundation.org/show_bug.cgi?id=90670 Bug ID: 90670 Summary: android: Remove .res files from the .apk Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Android Viewer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ke...@collabora.com Turns out that we ship all the .res files with strings in the .apk. We can decrease the .apk size by just avoiding them - or at least by hacking rsc so that that they actually contain only empty strings. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - compilerplugins/clang
compilerplugins/clang/vclwidgets.cxx | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) New commits: commit e0686cb7564eb2eeab62ac35a2a36da8f83ed90a Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 09:59:18 2015 +0200 workaround ErrorContextImpl in vclwidget clang plugin Change-Id: I6c0265f33a88169708d0812639169b665a95fc1f diff --git a/compilerplugins/clang/vclwidgets.cxx b/compilerplugins/clang/vclwidgets.cxx index 2c171d0..e12e957 100644 --- a/compilerplugins/clang/vclwidgets.cxx +++ b/compilerplugins/clang/vclwidgets.cxx @@ -265,13 +265,17 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * fieldDecl) { if (fieldDecl-isBitField()) { return true; } +const CXXRecordDecl *pParentRecordDecl = dyn_castCXXRecordDecl(fieldDecl-getParent()); if (containsWindowSubclass(fieldDecl-getType())) { -report( -DiagnosticsEngine::Warning, -OutputDevice subclass declared as a pointer field, should be wrapped in VclPtr. + fieldDecl-getType().getAsString(), -fieldDecl-getLocation()) - fieldDecl-getSourceRange(); -return true; +// have to ignore this for now, nasty reverse dependency from tools-vcl +if (!(pParentRecordDecl != nullptr pParentRecordDecl-getQualifiedNameAsString() == ErrorContextImpl)) { +report( +DiagnosticsEngine::Warning, +OutputDevice subclass declared as a pointer field, should be wrapped in VclPtr. + fieldDecl-getType().getAsString(), +fieldDecl-getLocation()) + fieldDecl-getSourceRange(); +return true; + } } const RecordType *recordType = fieldDecl-getType()-getAsRecordType(); if (recordType == nullptr) { @@ -292,7 +296,6 @@ bool VCLWidgets::VisitFieldDecl(const FieldDecl * fieldDecl) { } // If this field is a VclPtr field, then the class MUST have a dispose method -const CXXRecordDecl *pParentRecordDecl = dyn_castCXXRecordDecl(fieldDecl-getParent()); if (pParentRecordDecl isDerivedFromWindow(pParentRecordDecl) startsWith(recordDecl-getQualifiedNameAsString(), VclPtr)) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=48381 clem clement.marsh...@free.fr changed: What|Removed |Added CC||clement.marsh...@free.fr --- Comment #3 from clem clement.marsh...@free.fr --- Created attachment 114852 -- https://bugs.documentfoundation.org/attachment.cgi?id=114852action=edit testcase for bug 48381 An ODS document with 2 sheets : one is invoice with columns (invoice_id, client_id, invoice_amount) two is client with columns (client_id, total_invoiced) There are 100 invoice rows and 300 client rows both filled with random generated test data. Where the formula in client.B2 is : =somme.si(invoice.B$2:B$1000; A2 ; invoice.C$2:C$1000) (which function would likely be SUM.IF in english) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=48381 clem clement.marsh...@free.fr changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #5 from clem clement.marsh...@free.fr --- To reproduce : - open testcase - select client.B2 - Copy - select client.B (whole column) - remove client.B1 (column title) from selection - paste Saving the resulting file is equally long. This teaches me that pasting complicated formulae into 1 million cells could have you wait a little time. However, LibreOffice aiming to be a trouble free experience for it's users might want to deal with long calculations in an appropriate manner that lets the user know what happens and eventually cancel the process if it takes too long. In that instance, there are no need to calculate 1M cells, just 300, and that is done in a snap. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: ciabot/run-libreoffice-ciabot.pl
ciabot/run-libreoffice-ciabot.pl |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 2bd27f18f2435681259c0535c7b223195b3bdf7b Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Apr 17 07:42:46 2015 + we need to always include a branch name diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl index 80551a0..517960c 100755 --- a/ciabot/run-libreoffice-ciabot.pl +++ b/ciabot/run-libreoffice-ciabot.pl @@ -120,7 +120,10 @@ sub report($$$) { qx(perl -I $cwd $cwd/sigui-bugzilla.pl $repo $_ $branch_name); } else { if ( is_valid_bugzilla_commit( $repo, $branch_name ) ) { -qx(python $cwd/libreoffice-bugzilla2.py -r $repo -c $_ -b $branch_name); + my $branch = $branch_name; + $branch = 'master' if ($branch eq ''); + print reporting to bugzilla: $_ and branch $branch; +qx(python $cwd/libreoffice-bugzilla2.py -r $repo -c $_ -b $branch /home/ciabot/bugzilla.log); } qx($ciabot $repo $_ $branch_name $ciaproxy); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=48381 --- Comment #4 from clem clement.marsh...@free.fr --- Created attachment 114853 -- https://bugs.documentfoundation.org/attachment.cgi?id=114853action=edit Mac OS stack trace sample for bug 48381 Output of the Apple /usr/bin/sample analysis tool showing 3 seconds of sampling every 1ms entirely within the duration of the hung interface. The interesting parts are where the statistics of where the program spends most of it's time are supplied : search for these : - Total number in stack - Sort by top of stack -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/468aaa1bcf96c86c4a33b5dcd0aabb41e14b042d/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/svddrgv.hxx |2 svx/source/svdraw/svdoashp.cxx |8 +-- svx/source/svdraw/svdocirc.cxx |6 +- svx/source/svdraw/svdoedge.cxx | 88 svx/source/svdraw/svdopath.cxx | 34 +++ svx/source/svdraw/svdotxtr.cxx |4 - svx/source/unodraw/unoshap2.cxx |8 +-- 7 files changed, 75 insertions(+), 75 deletions(-) New commits: commit 7e5980ccf39b54240524f059a65497b766af91cc Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 09:13:11 2015 +0200 svx: nPntAnz - nPointCount Change-Id: I2a4c7ef9d33db1c34a4ab338f70f800b30083f4f diff --git a/include/svx/svddrgv.hxx b/include/svx/svddrgv.hxx index c7269ae..1aae1fb 100644 --- a/include/svx/svddrgv.hxx +++ b/include/svx/svddrgv.hxx @@ -180,7 +180,7 @@ public: // all polygons. Default=500. // NoDragPolys is (temporarily) activated, if one of the limits // is exceeded. -void SetDragXorPointLimit(sal_uIntPtr nPntAnz) { nDragXorPointLimit=nPntAnz; } +void SetDragXorPointLimit(sal_uIntPtr nPointCount) { nDragXorPointLimit=nPointCount; } sal_uIntPtr GetDragXorPointLimit() const { return nDragXorPointLimit; } void SetSolidDragging(bool bOn); diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx index 238166b..9b06946 100644 --- a/svx/source/svdraw/svdoashp.cxx +++ b/svx/source/svdraw/svdoashp.cxx @@ -3108,8 +3108,8 @@ bool SdrObjCustomShape::TRGetBaseGeometry(basegfx::B2DHomMatrix rMatrix, basegf Point aRef1( ( aBoundRect.Left() + aBoundRect.Right() ) 1, aBoundRect.Top() ); Point aRef2( aRef1.X(), aRef1.Y() + 1000 ); sal_uInt16 i; -sal_uInt16 nPntAnz=aPol.GetSize(); -for (i=0; inPntAnz; i++) +sal_uInt16 nPointCount=aPol.GetSize(); +for (i=0; inPointCount; i++) { MirrorPoint(aPol[i],aRef1,aRef2); } @@ -3130,8 +3130,8 @@ bool SdrObjCustomShape::TRGetBaseGeometry(basegfx::B2DHomMatrix rMatrix, basegf Point aRef1( aBoundRect.Left(), ( aBoundRect.Top() + aBoundRect.Bottom() ) 1 ); Point aRef2( aRef1.X() + 1000, aRef1.Y() ); sal_uInt16 i; -sal_uInt16 nPntAnz=aPol.GetSize(); -for (i=0; inPntAnz; i++) +sal_uInt16 nPointCount=aPol.GetSize(); +for (i=0; inPointCount; i++) { MirrorPoint(aPol[i],aRef1,aRef2); } diff --git a/svx/source/svdraw/svdocirc.cxx b/svx/source/svdraw/svdocirc.cxx index e62175d..08c41d7 100644 --- a/svx/source/svdraw/svdocirc.cxx +++ b/svx/source/svdraw/svdocirc.cxx @@ -569,16 +569,16 @@ OUString SdrCircObj::getSpecialDragComment(const SdrDragStat rDrag) const OUString aStr; ImpTakeDescriptionStr(STR_ViewCreateObj, aStr); OUStringBuffer aBuf(aStr); -const sal_uInt32 nPntAnz(rDrag.GetPointAnz()); +const sal_uInt32 nPointCount(rDrag.GetPointAnz()); -if(OBJ_CIRC != meCircleKind nPntAnz 2) +if(OBJ_CIRC != meCircleKind nPointCount 2) { const ImpCircUser* pU = static_castconst ImpCircUser*(rDrag.GetUser()); sal_Int32 nAngle; aBuf.appendAscii( (); -if(3 == nPntAnz) +if(3 == nPointCount) { nAngle = pU-nStart; } diff --git a/svx/source/svdraw/svdoedge.cxx b/svx/source/svdraw/svdoedge.cxx index 27f4763..48cc722 100644 --- a/svx/source/svdraw/svdoedge.cxx +++ b/svx/source/svdraw/svdoedge.cxx @@ -413,18 +413,18 @@ bool SdrEdgeObj::IsNode() const SdrGluePoint SdrEdgeObj::GetVertexGluePoint(sal_uInt16 nNum) const { Point aPt; -sal_uInt16 nPntAnz=pEdgeTrack-GetPointCount(); -if (nPntAnz0) +sal_uInt16 nPointCount=pEdgeTrack-GetPointCount(); +if (nPointCount0) { Point aOfs = GetSnapRect().Center(); if (nNum==2 GetConnectedNode(true)==NULL) aPt=(*pEdgeTrack)[0]; -else if (nNum==3 GetConnectedNode(false)==NULL) aPt=(*pEdgeTrack)[nPntAnz-1]; +else if (nNum==3 GetConnectedNode(false)==NULL) aPt=(*pEdgeTrack)[nPointCount-1]; else { -if ((nPntAnz 1) ==1) { -aPt=(*pEdgeTrack)[nPntAnz/2]; +if ((nPointCount 1) ==1) { +aPt=(*pEdgeTrack)[nPointCount/2]; } else { -Point aPt1((*pEdgeTrack)[nPntAnz/2-1]); -Point aPt2((*pEdgeTrack)[nPntAnz/2]); +Point aPt1((*pEdgeTrack)[nPointCount/2-1]); +Point aPt2((*pEdgeTrack)[nPointCount/2]); aPt1+=aPt2; aPt1.X()/=2; aPt1.Y()/=2; @@ -1266,16 +1266,16 @@ XPolygon SdrEdgeObj::ImpCalcEdgeTrack(const Point rPt1, long nAngle1, const Rec nNum--; aXP1.Insert(XPOLY_APPEND,aXP2[nNum],XPOLY_NORMAL); } -sal_uInt16 nPntAnz=aXP1.GetPointCount(); +sal_uInt16
[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 raal r...@post.cz changed: What|Removed |Added Keywords||have-backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90670] android: Remove .res files from the .apk
https://bugs.documentfoundation.org/show_bug.cgi?id=90670 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Blocks||84726 Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84726] LibreOffice for Android most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=84726 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added Depends on||90670 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - basctl/source basic/source vcl/README.lifecycle
basctl/source/basicide/baside2.cxx |6 +++--- basctl/source/basicide/baside2b.cxx | 22 +++--- basctl/source/basicide/baside3.cxx |2 +- basctl/source/basicide/basides2.cxx |4 ++-- basctl/source/basicide/basides3.cxx |4 ++-- basctl/source/basicide/basidesh.cxx | 10 +- basctl/source/basicide/layout.cxx |4 ++-- basctl/source/basicide/moduldl2.cxx |2 +- basctl/source/basicide/moduldlg.cxx | 14 +++--- basctl/source/basicide/objdlg.cxx |4 ++-- basic/source/runtime/inputbox.cxx |4 ++-- basic/source/runtime/iosys.cxx |4 ++-- basic/source/runtime/methods.cxx| 10 +- vcl/README.lifecycle|7 +++ 14 files changed, 52 insertions(+), 45 deletions(-) New commits: commit 5cc560f6c27dc60764f644d6b5fb5ccb1b8072be Author: Michael Meeks michael.me...@collabora.com Date: Fri Apr 17 09:11:51 2015 +0100 basctl, basic: convert new to ::Create. Change-Id: I1fc2c69640ed625425a679380d6f25178bc5aeb1 diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index df27e30..48f9eab 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -192,7 +192,7 @@ ModulWindow::ModulWindow ( BaseWindow(pParent, rDocument, aLibName, aName), rLayout(*pParent), nValid(ValidWindow), -aXEditorWindow(new ComplexEditorWindow(this)), +aXEditorWindow(VclPtrComplexEditorWindow::Create(this)), m_aModule(aModule) { aXEditorWindow-Show(); @@ -1470,8 +1470,8 @@ void ModulWindow::UpdateModule () ModulWindowLayout::ModulWindowLayout (vcl::Window* pParent, ObjectCatalog rObjectCatalog_) : Layout(pParent), pChild(0), -aWatchWindow(new WatchWindow(this)), -aStackWindow(new StackWindow(this)), +aWatchWindow(VclPtrWatchWindow::Create(this)), +aStackWindow(VclPtrStackWindow::Create(this)), rObjectCatalog(rObjectCatalog_) { } diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx index 076aa3e..f44fb4e 100644 --- a/basctl/source/basicide/baside2b.cxx +++ b/basctl/source/basicide/baside2b.cxx @@ -227,7 +227,7 @@ EditorWindow::EditorWindow (vcl::Window* pParent, ModulWindow* pModulWindow) : bHighlightning(false), bDoSyntaxHighlight(true), bDelayHighlight(true), -pCodeCompleteWnd(new CodeCompleteWindow(this)) +pCodeCompleteWnd(VclPtrCodeCompleteWindow::Create(this)) { SetBackground(Wallpaper(GetSettings().GetStyleSettings().GetFieldColor())); SetPointer( Pointer( POINTER_TEXT ) ); @@ -1599,11 +1599,11 @@ namespace WatchWindow::WatchWindow (Layout* pParent) : DockingWindow(pParent), aWatchStr( IDEResId( RID_STR_REMOVEWATCH ) ), -aXEdit( new ExtendedEdit(this, IDEResId( RID_EDT_WATCHEDIT )) ), -aRemoveWatchButton( new ImageButton(this, IDEResId( RID_IMGBTN_REMOVEWATCH )) ), -aTreeListBox( new WatchTreeListBox(this, WB_BORDER | WB_3DLOOK | WB_HASBUTTONS | WB_HASLINES | WB_HSCROLL | WB_TABSTOP +aXEdit( VclPtrExtendedEdit::Create(this, IDEResId( RID_EDT_WATCHEDIT )) ), +aRemoveWatchButton( VclPtrImageButton::Create(this, IDEResId( RID_IMGBTN_REMOVEWATCH )) ), +aTreeListBox( VclPtrWatchTreeListBox::Create(this, WB_BORDER | WB_3DLOOK | WB_HASBUTTONS | WB_HASLINES | WB_HSCROLL | WB_TABSTOP | WB_HASLINESATROOT | WB_HASBUTTONSATROOT) ), -aHeaderBar( new HeaderBar( this, WB_BUTTONSTYLE | WB_BORDER ) ) +aHeaderBar( VclPtrHeaderBar::Create( this, WB_BUTTONSTYLE | WB_BORDER ) ) { aXEdit-SetAccessibleName(IDEResId(RID_STR_WATCHNAME).toString()); aTreeListBox-SetAccessibleName(IDEResId(RID_STR_WATCHNAME).toString()); @@ -1902,7 +1902,7 @@ void WatchWindow::UpdateWatches( bool bBasicStopped ) StackWindow::StackWindow (Layout* pParent) : DockingWindow(pParent), -aTreeListBox( new SvTreeListBox(this, WB_BORDER | WB_3DLOOK | WB_HSCROLL | WB_TABSTOP) ), +aTreeListBox( VclPtrSvTreeListBox::Create(this, WB_BORDER | WB_3DLOOK | WB_HSCROLL | WB_TABSTOP) ), aStackStr( IDEResId( RID_STR_STACK ) ) { aTreeListBox-SetHelpId(HID_BASICIDE_STACKWINDOW_LIST); @@ -2044,10 +2044,10 @@ void StackWindow::UpdateCalls() ComplexEditorWindow::ComplexEditorWindow( ModulWindow* pParent ) : Window( pParent, WB_3DLOOK | WB_CLIPCHILDREN ), -aBrkWindow(new BreakPointWindow(this, pParent)), -aLineNumberWindow(new LineNumberWindow(this, pParent)), -aEdtWindow(new EditorWindow(this, pParent)), -aEWVScrollBar( new ScrollBar(this, WB_VSCROLL | WB_DRAG) ) +aBrkWindow(VclPtrBreakPointWindow::Create(this, pParent)), +aLineNumberWindow(VclPtrLineNumberWindow::Create(this, pParent)), +aEdtWindow(VclPtrEditorWindow::Create(this, pParent)), +aEWVScrollBar( VclPtrScrollBar::Create(this, WB_VSCROLL | WB_DRAG) ) { aEdtWindow-Show(); aBrkWindow-Show(); @@ -2862,7 +2862,7 @@ void
[Libreoffice-bugs] [Bug 90307] Convert insert chart wizard into tabbed dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=90307 --- Comment #3 from Heiko Tietze heiko.tie...@user-prompt.com --- First ideas were presented at http://user-prompt.com/de/libreoffice-design-session-inserting-a-chart/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90668] EDITING: No color border when reference more than 31 cells
https://bugs.documentfoundation.org/show_bug.cgi?id=90668 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #2 from raal r...@post.cz --- I can confirm with LO 4.4.2.2, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86182] FILEOPEN RTF Text direction not imported properly
https://bugs.documentfoundation.org/show_bug.cgi?id=86182 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Status|NEW |ASSIGNED Depends on|84318 | Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | --- Comment #8 from Miklos Vajna vmik...@collabora.co.uk --- Removing depends on, this has little to do with pasting, I think. The problem is that \rtlpar should be mapped to the ooxml:CT_PPrBase_bidi dmapper token, but it's mapped to ooxml:CT_PPrBase_textDirection currently, which was probably just a guess. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84318] Forgetting indentation, direction and selected font when pasting
https://bugs.documentfoundation.org/show_bug.cgi?id=84318 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Blocks|86182 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - instsetoo_native/util sw/qa writerfilter/source
instsetoo_native/util/openoffice.lst.in|4 ++-- sw/qa/extras/rtfimport/data/tdf86182.rtf |4 sw/qa/extras/rtfimport/rtfimport.cxx |7 +++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |2 +- 4 files changed, 14 insertions(+), 3 deletions(-) New commits: commit 06a2e00c1a3c00cb40700f61f7cd61ac6681a7c3 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 11:32:10 2015 +0200 instsetoo_native: also keep profile at 4 here Change-Id: I29f7efd065805b12199b8a6a3aadcf62cdcecee7 diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index fc2e98b..46176a9 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -51,7 +51,7 @@ LibreOffice POSTVERSIONEXTENSION BUNDLEIDENTIFIER @MACOSX_BUNDLE_IDENTIFIER@ BRANDPACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ -USERDIRPRODUCTVERSION @LIBO_VERSION_MAJOR@ +USERDIRPRODUCTVERSION 4 ABOUTBOXPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ ABOUTBOXPRODUCTVERSIONSUFFIX @LIBO_VERSION_SUFFIX_SUFFIX@ BASEPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ @@ -98,7 +98,7 @@ LibreOffice_Dev POSTVERSIONEXTENSION BUNDLEIDENTIFIER @MACOSX_BUNDLE_IDENTIFIER@ BRANDPACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ -USERDIRPRODUCTVERSION @LIBO_VERSION_MAJOR@ +USERDIRPRODUCTVERSION 4 ABOUTBOXPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ ABOUTBOXPRODUCTVERSIONSUFFIX @LIBO_VERSION_SUFFIX_SUFFIX@ BASEPRODUCTVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@ commit 4ee2a882dddb395a816cd54004b634d57cfb2446 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 10:44:47 2015 +0200 tdf#86182 RTF import: fix handling of \rtlpar Commit 558d5c25a0b1d6a937d33291a4b6cd7fca6cb15b (implement RTF_LTRPAR and RTF_RTLPAR, 2011-06-09) was just a guess, this one is the proper mapping. Change-Id: I1156ef5ddc34264d761d3e64dd0537bc6ec0ced7 diff --git a/sw/qa/extras/rtfimport/data/tdf86182.rtf b/sw/qa/extras/rtfimport/data/tdf86182.rtf new file mode 100644 index 000..d63c489 --- /dev/null +++ b/sw/qa/extras/rtfimport/data/tdf86182.rtf @@ -0,0 +1,4 @@ +{\rtf1 +\rtlpar +\u1662\'3f\u1587\'3f +\par} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index c579403..f4c14c7 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -46,6 +46,7 @@ #include com/sun/star/text/WrapTextMode.hpp #include com/sun/star/text/HoriOrientation.hpp #include com/sun/star/text/VertOrientation.hpp +#include com/sun/star/text/WritingMode2.hpp #include com/sun/star/util/XNumberFormatsSupplier.hpp #include rtl/ustring.hxx @@ -2238,6 +2239,12 @@ DECLARE_RTFIMPORT_TEST(mathtype, mathtype.rtf) CPPUNIT_ASSERT(!aFormula.isEmpty()); } +DECLARE_RTFIMPORT_TEST(testTdf86182, tdf86182.rtf) +{ +// Writing mode was the default, i.e. text::WritingMode2::CONTEXT. +CPPUNIT_ASSERT_EQUAL(text::WritingMode2::RL_TB, getPropertysal_Int16(getParagraph(1), WritingMode)); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 8550613..4965e13 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -3021,7 +3021,7 @@ RTFError RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword) case RTF_RTLPAR: { auto pValue = std::make_sharedRTFValue(nKeyword == RTF_LTRPAR ? 0 : 1); - m_aStates.top().aParagraphSprms.set(NS_ooxml::LN_CT_PPrBase_textDirection, pValue); +m_aStates.top().aParagraphSprms.set(NS_ooxml::LN_CT_PPrBase_bidi, pValue); } break; case RTF_LTRROW: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90672] FILEOPEN : table cell border color is not exported.
https://bugs.documentfoundation.org/show_bug.cgi?id=90672 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Hardware|Other |All Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33714] UI Warning Box is an annoyance on export to CSV
https://bugs.documentfoundation.org/show_bug.cgi?id=33714 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from steve -_- st...@openmailbox.org --- I'm not sure I can still reproduce this with LO Version: 4.5.0.0.alpha0+ Build ID: 09a1e4f36128f64029d45a38d9b059bf11ea0821 TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-04-15_23:40:09 Locale: de_ Please add exact reproduce steps for this bug and add a screenshot of the dialog which you do not want to see (or be able to never show again). Once the additional info has been provided set this bug back to NEW please. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - oox/source
oox/source/export/chartexport.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6beaa148f59e22610fb38db1f1e628963789d5d7 Author: Caolán McNamara caol...@redhat.com Date: Wed Apr 15 10:30:34 2015 +0100 fix crash on export of fdo60365-2.ods to xlsx Change-Id: I1a281b096e4d1831bcf67ca03180afff043fbcfd (cherry picked from commit 135907f2061550624ee1859745d94eee01849070) Reviewed-on: https://gerrit.libreoffice.org/15322 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index 3dc8602..5ad9f35 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -1943,7 +1943,7 @@ void ChartExport::exportSeriesCategory( const Reference chart2::data::XDataSequ pFS-startElement( FSNS( XML_c, XML_cat ), FSEND ); -OUString aCellRange = xValueSeq-getSourceRangeRepresentation(); +OUString aCellRange = xValueSeq.is() ? xValueSeq-getSourceRangeRepresentation() : OUString(); aCellRange = parseFormula( aCellRange ); // TODO: need to handle XML_multiLvlStrRef according to aCellRange pFS-startElement( FSNS( XML_c, XML_strRef ), @@ -1986,7 +1986,7 @@ void ChartExport::exportSeriesValues( const Reference chart2::data::XDataSequen pFS-startElement( FSNS( XML_c, nValueType ), FSEND ); -OUString aCellRange = xValueSeq-getSourceRangeRepresentation(); +OUString aCellRange = xValueSeq.is() ? xValueSeq-getSourceRangeRepresentation() : OUString(); aCellRange = parseFormula( aCellRange ); // TODO: need to handle XML_multiLvlStrRef according to aCellRange pFS-startElement( FSNS( XML_c, XML_numRef ), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90671] New: When editing macros, toolbar and menu bar not drawn correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=90671 Bug ID: 90671 Summary: When editing macros, toolbar and menu bar not drawn correctly Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Steps: 1) Open Writer 2) Tools Macros Organize Macros LibreOfficeDev Basic 3) LibreOfficeDev Macros Tools Debug 4) Click edit button 5) Menu bar and toolbar not fully drawn resulting in thinks behind the window to appear in the window Screenshot: attachment 102883 Version: 4.5.0.0.alpha0+ Build ID: 25c25f855169c98c30f3f7868fd1ad430e159ddc TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-04-14_08:59:23 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90672] FILEOPEN : table cell border color is not exported.
https://bugs.documentfoundation.org/show_bug.cgi?id=90672 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||190 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90190] FILEOPEN : When open the Roundtrip PPTX in LO loss the table cell border line width i.e lnL, lnT, lnR, lnB tag is not exported.
https://bugs.documentfoundation.org/show_bug.cgi?id=90190 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||672 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90672] New: FILEOPEN : table cell border color is not exported.
https://bugs.documentfoundation.org/show_bug.cgi?id=90672 Bug ID: 90672 Summary: FILEOPEN : table cell border color is not exported. Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yogesh.bhar...@synerzip.com Created attachment 114851 -- https://bugs.documentfoundation.org/attachment.cgi?id=114851action=edit Table cell Border Color Problem Description : Table cell border color is not exported i.e cell border line color is not preserved after roundtrip. XML Difference: In Original File : -a:lnL a:solidFill a:srgbClr val=00B0F0/ /a:solidFill /a:lnL In Roundtrip File: -a:lnL /a:lnL -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90666] FILEOPEN takes 60-70 seconds for LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=90666 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Version|unspecified |4.4.2.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40227] Create new files from the command line
https://bugs.documentfoundation.org/show_bug.cgi?id=40227 Nuno J. Silva (aka njsg) nunojsi...@ist.utl.pt changed: What|Removed |Added CC||nunojsi...@ist.utl.pt --- Comment #12 from Nuno J. Silva (aka njsg) nunojsi...@ist.utl.pt --- I would also like to see this happening. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90590] Unable to set specific character spacing to 'space' character
https://bugs.documentfoundation.org/show_bug.cgi?id=90590 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to Martin Delille from comment #4) I download the 4.4.2.2 fresh release and the problem is still here. Are you sur you understood what was my problem? I'm speaking about single character spacing (and in this case, the character is a space). I did what you described in the original bug submission : 1) Opened Writer 2) Typed the phrase. 3) Selected the entire phrase and set Format Character Position Spacing Expanded to 2pt 4) Then slected the space between I and write and selected Format Character Position Spacing Expanded to 1pt. If this isn't what you are doing then you might want to put explicit instructions on how to reproduce here so that I can try again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90070] Adding a border and spacing to content shrinks the size on an image
https://bugs.documentfoundation.org/show_bug.cgi?id=90070 --- Comment #5 from Jay Philips philip...@hotmail.com --- Created attachment 114855 -- https://bugs.documentfoundation.org/attachment.cgi?id=114855action=edit sample docx Attached is an example docx file, which when opened in LO results in the image being cropped to give place to the borders. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - include/vcl sw/source
include/vcl/vclptr.hxx | 12 +++- sw/source/uibase/sidebar/PageColumnControl.cxx |2 +- sw/source/uibase/sidebar/PageMarginControl.cxx | 24 sw/source/uibase/sidebar/PagePropertyPanel.cxx | 22 +- sw/source/uibase/sidebar/PagePropertyPanel.hxx | 10 +- sw/source/uibase/sidebar/PageSizeControl.cxx |4 ++-- sw/source/uibase/sidebar/WrapPropertyPanel.cxx |3 ++- sw/source/uibase/sidebar/WrapPropertyPanel.hxx |5 ++--- sw/source/uibase/uiview/pview.cxx |6 +++--- sw/source/uibase/uiview/srcview.cxx|2 +- sw/source/uibase/uiview/view.cxx |8 sw/source/uibase/uiview/viewling.cxx |4 ++-- sw/source/uibase/uiview/viewmdi.cxx|2 +- sw/source/uibase/utlui/condedit.cxx|6 -- sw/source/uibase/utlui/navipi.cxx | 14 +++--- sw/source/uibase/utlui/numfmtlb.cxx| 19 --- sw/source/uibase/utlui/unotools.cxx|2 +- 17 files changed, 67 insertions(+), 78 deletions(-) New commits: commit a3525585f10ff39b9aae14d7506e94cf77542c14 Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 13:14:20 2015 +0200 sw: convert new to ::Create. Change-Id: I937aa67ee4a3b07bd180d3c665245ea08b92 diff --git a/include/vcl/vclptr.hxx b/include/vcl/vclptr.hxx index d97124d..5ad0bda 100644 --- a/include/vcl/vclptr.hxx +++ b/include/vcl/vclptr.hxx @@ -23,6 +23,7 @@ #include rtl/ref.hxx #include cstddef #include utility +#include type_traits /// @cond INTERNAL namespace vcl { namespace detail { @@ -165,7 +166,16 @@ public: m_rInnerRef.set(pBody); } -inline VclPtrreference_type SAL_CALL operator= (reference_type * pBody) +/** Up-casting conversion constructor: Copies interface reference. + +Does not work for up-casts to ambiguous bases. For the special case of +up-casting to Reference XInterface , see the corresponding conversion +operator. + +@param rRef another reference +*/ +template class derived_type, class = typename std::enable_if ::vcl::detail::UpCast reference_type, derived_type ::t ::type +inline VclPtrreference_type SAL_CALL operator= (derived_type * pBody) { m_rInnerRef.set(pBody); return *this; diff --git a/sw/source/uibase/sidebar/PageColumnControl.cxx b/sw/source/uibase/sidebar/PageColumnControl.cxx index 23676cb..39b6757 100644 --- a/sw/source/uibase/sidebar/PageColumnControl.cxx +++ b/sw/source/uibase/sidebar/PageColumnControl.cxx @@ -38,7 +38,7 @@ PageColumnControl::PageColumnControl( const bool bLandscape ) : ::svx::sidebar::PopupControl( pParent, SW_RES(RID_POPUP_SWPAGE_COLUMN) ) , mpColumnValueSet( new ::svx::sidebar::ValueSetWithTextControl( ::svx::sidebar::ValueSetWithTextControl::IMAGE_TEXT, this, SW_RES(VS_COLUMN) ) ) -, maMoreButton( new PushButton( this, SW_RES(CB_COLUMN_MORE) ) ) +, maMoreButton( VclPtrPushButton::Create( this, SW_RES(CB_COLUMN_MORE) ) ) , mnColumnType( nColumnType ) , mrPagePropPanel(rPanel) { diff --git a/sw/source/uibase/sidebar/PageMarginControl.cxx b/sw/source/uibase/sidebar/PageMarginControl.cxx index e01c373..6479a7f 100644 --- a/sw/source/uibase/sidebar/PageMarginControl.cxx +++ b/sw/source/uibase/sidebar/PageMarginControl.cxx @@ -50,18 +50,18 @@ PageMarginControl::PageMarginControl( const SfxMapUnit eUnit ) : ::svx::sidebar::PopupControl( pParent, SW_RES(RID_POPUP_SWPAGE_MARGIN) ) , mpMarginValueSet( new ::svx::sidebar::ValueSetWithTextControl( ::svx::sidebar::ValueSetWithTextControl::IMAGE_TEXT, this, SW_RES(VS_MARGIN) ) ) -, maCustom(new FixedText(this, SW_RES(FT_CUSTOM))) -, maLeft(new FixedText(this, SW_RES(FT_LEFT))) -, maInner(new FixedText(this, SW_RES(FT_INNER))) -, maLeftMarginEdit(new MetricField(this, SW_RES(MF_SWLEFT_MARGIN))) -, maRight(new FixedText(this, SW_RES(FT_RIGHT))) -, maOuter(new FixedText(this, SW_RES(FT_OUTER))) -, maRightMarginEdit(new MetricField(this, SW_RES(MF_SWRIGHT_MARGIN))) -, maTop(new FixedText(this, SW_RES(FT_TOP))) -, maTopMarginEdit(new MetricField(this, SW_RES(MF_SWTOP_MARGIN))) -, maBottom(new FixedText(this, SW_RES(FT_BOTTOM))) -, maBottomMarginEdit(new MetricField(this, SW_RES(MF_SWBOTTOM_MARGIN))) -, maWidthHeightField(new MetricField( this, SW_RES(FLD_WIDTH_HEIGHT) ) ) +, maCustom(VclPtrFixedText::Create(this, SW_RES(FT_CUSTOM))) +, maLeft(VclPtrFixedText::Create(this, SW_RES(FT_LEFT))) +, maInner(VclPtrFixedText::Create(this, SW_RES(FT_INNER))) +, maLeftMarginEdit(VclPtrMetricField::Create(this, SW_RES(MF_SWLEFT_MARGIN))) +, maRight(VclPtrFixedText::Create(this, SW_RES(FT_RIGHT))) +, maOuter(VclPtrFixedText::Create(this, SW_RES(FT_OUTER))) +, maRightMarginEdit(VclPtrMetricField::Create(this, SW_RES(MF_SWRIGHT_MARGIN)))
VclPtr bits ...
Hi guys, As I mentioned in the ESC call, this is approaching merge-ability hopefully before Alpha 1, possibly afterwards work on feature/vclptr vs. a reasonably recent master as of last week or so. I append the new README.lifecycle from vcl/ - not everything is as obvious as it could be in a perfect world, but hopefully it de-tangles our VCL lifecycle in a helpful way, and one that we can build on in future =) ATB, Michael. ** Understanding transitional VCL lifecycle ** -- How it used to look -- All VCL classes were explicitly lifecycle managed; so you would do: Dialog aDialog(...); // old - on stack allocation aDialog.Execute(...); or: Dialog *pDialog = new Dialog(...); // old - manual heap allocation pDialog-Execute(...); delete pDialog; or: boost::shared_ptrDialog xDialog(new pDialog()); // old xDialog-Execute(...); // depending who shared the ptr this would be freed sometime In several cases this lead to rather unpleasant code, when various shared_ptr wrappers were used, the lifecycle was far less than obvious. Where controls were wrapped by other ref-counted classes - such as UNO interfaces, which were also used by native Window pointers, the lifecycle became extremely opaque. In addition VCL had significant issues with re-enterancy and event emission - adding various means such as DogTags to try to detect destruction of a window between calls: ImplDelData aDogTag( this );// 'orrible old code Show( true, SHOW_NOACTIVATE ); if( !aDogTag.IsDead() ) // did 'this' go invalid yet ? Update(); Unfortunately use of such protection is/was ad-hoc, and far from uniform, despite the prevelance of such potential problems. When a lifecycle problem was hit, typically it would take the form of accessing memory that had been freed, and contained garbage due to lingering pointers to freed objects. -- Where we are now: -- To fix this situation we now have a VclPtr - which is a smart reference-counting pointer (include/vcl/vclptr.hxx) which is designed to look and behave -very- much like a normal pointer to reduce code-thrash. VclPtr is used to wrap all OutputDevice derived classes thus: VclPtrDialog pDialog( new Dialog( ... ), SAL_NO_ACQUIRE ); ... pDialog.disposeAndClear(); However - while the VclPtr reference count controls the lifecycle of the Dialog object, it is necessary to be able to break reference count cycles. These are extremely common in widget hierarchies as each widget holds (smart) pointers to its parents and also its children. Thus - all previous 'delete' calls are replaced with 'dispose' method calls: ** What is dispose ? Dispose is defined to be a method that releases all references that an object holds - thus allowing their underlying resources to be released. However - in this specific case it also releases all backing graphical resources. In practical terms, all destructor functionality has been moved into 'dispose' methods, in order to provide a minimal initial behavioral change. As such a VclPtr can have three states: VclPtrPushButton pButton; ... assert (pButton == nullptr || !pButton);// null assert (pButton !pButton-IsDisposed()); // alive assert (pButton pButton-IsDisposed()); // disposed ** ScopedVclPtr - making disposes easier While replacing existing code with new, it can be a bit tiresome to have to manually add 'disposeAndClear()' calls to VclPtr instances. Luckily it is easy to avoid that with a ScopedVclPtr which does this for you when it goes out of scope. ** One extra gotcha - an initial reference-count of 1 In the normal world of love and sanity, eg. creating UNO objects, the objects start with a ref-count of zero. Thus the first reference is always taken after construction by the surrounding smart pointer. Unfortunately, the existing VCL code is somewhat tortured, and does a lot of reference and de-reference action on the class -during- construction. This forces us to construct with a reference of 1 - and to hand that into the initial smart pointer with a SAL_NO_ACQUIRE. To make this easier, we have 'Instance' template wrappers that make this apparently easier, by constructing the pointer for you. ** How does my familiar code change ? Lets tweak the exemplary code above to fit the new model: - Dialog aDialog(... dialog params ... ); - aDialog.Execute(...); + ScopedVclPtrInstanceDialog pDialog(... dialog params ... ); + pDialog-Execute(...);
[Libreoffice-commits] core.git: editeng/source
editeng/source/uno/unofield.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 3e56e3214073bb915c3a2ff4cb5429c63f18c459 Author: Katarina Behrens katarina.behr...@cib.de Date: Fri Apr 17 11:06:44 2015 +0200 Related tdf#88056: prep UNO stuff for ODF export/import Change-Id: I13c95b3e96db96634a3247154d28eddb3ae6c80d diff --git a/editeng/source/uno/unofield.cxx b/editeng/source/uno/unofield.cxx index 479e411..21b0ef5 100644 --- a/editeng/source/uno/unofield.cxx +++ b/editeng/source/uno/unofield.cxx @@ -508,6 +508,9 @@ SvxFieldData* SvxUnoTextField::CreateFieldData() const throw() case text::textfield::Type::PRESENTATION_DATE_TIME: pData = new SvxDateTimeField(); break; +case text::textfield::Type::PAGE_TITLE: +pData = new SvxPageTitleField(); +break; }; return pData; @@ -610,6 +613,8 @@ OUString SAL_CALL SvxUnoTextField::getPresentation( sal_Bool bShowCommand ) return OUString(Footer); case text::textfield::Type::PRESENTATION_DATE_TIME: return OUString(DateTime); +case text::textfield::Type::PAGE_TITLE: +return OUString(PageTitle); default: return OUString(Unknown); } @@ -857,6 +862,10 @@ uno::Sequence OUString SAL_CALL SvxUnoTextField::getSupportedServiceNames() pServices[2] = com.sun.star.presentation.TextField.DateTime; pServices[3] = com.sun.star.presentation.textfield.DateTime; break; +case text::textfield::Type::PAGE_TITLE: +pServices[2] = com.sun.star.text.TextField.PageTitle; +pServices[3] = com.sun.star.text.textfield.PageTitle; +break; default: aSeq.realloc(0); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/diagram/VDiagram.cxx | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) New commits: commit 063aec33f029f1fbdd1b1ee274e94a00f256465e Author: Tor Lillqvist t...@collabora.com Date: Fri Apr 17 15:08:02 2015 +0300 WaE: unused variables and fallout Change-Id: If6d68b54aa4fc5744a30521e5fa7caf9d876d975 diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx index 9f5db99..ae8a165 100644 --- a/chart2/source/view/diagram/VDiagram.cxx +++ b/chart2/source/view/diagram/VDiagram.cxx @@ -209,24 +209,6 @@ void VDiagram::createShapes_2d() adjustPosAndSize_2d( m_aAvailablePosIncludingAxes, m_aAvailableSizeIncludingAxes ); } -E3dScene* lcl_getE3dScene( const uno::Reference drawing::XShape xShape ) -{ -E3dScene* pRet=NULL; -uno::Reference lang::XUnoTunnel xUnoTunnel( xShape, uno::UNO_QUERY ); -uno::Reference lang::XTypeProvider xTypeProvider( xShape, uno::UNO_QUERY ); -if(xUnoTunnel.is()xTypeProvider.is()) -{ -SvxShape* pSvxShape = reinterpret_castSvxShape*(xUnoTunnel-getSomething( SvxShape::getUnoTunnelId() )); -if(pSvxShape) -{ -SdrObject* pObj = pSvxShape-GetSdrObject(); -if( pObj pObj-ISA(E3dScene) ) -pRet = static_castE3dScene*(pObj); -} -} -return pRet; -} - void lcl_setLightSources( const uno::Reference beans::XPropertySet xSource, const uno::Reference beans::XPropertySet xDest ) @@ -437,7 +419,8 @@ void VDiagram::adjustAspectRatio3d( const awt::Size rAvailableSize ) // To get the 3D aspect ratio's effect on the 2D scene size, the scene's 2D size needs to be adapted to // 3D content changes here. The tooling class remembers the current 3D transformation stack // and in its destructor, calculates a new 2D SnapRect for the scene and it's modified 3D geometry. -E3DModifySceneSnapRectUpdater aUpdater(lcl_getE3dScene( m_xOuterGroupShape )); + +// Unclear whether the above comment refers to an unused variable that was removed, or to the below code m_xAspectRatio3D-setPropertyValue( UNO_NAME_3D_TRANSFORM_MATRIX , uno::makeAny(BaseGFXHelper::B3DHomMatrixToHomogenMatrix( aResult )) ); @@ -602,7 +585,7 @@ void VDiagram::createShapes_3d() aEffectiveTranformation.shearXY(m_fYAnglePi,-m_fXAnglePi); //#i98497# 3D charts are rendered with wrong size -E3DModifySceneSnapRectUpdater aUpdater(lcl_getE3dScene( m_xOuterGroupShape )); + xDestProp-setPropertyValue( UNO_NAME_3D_TRANSFORM_MATRIX, uno::makeAny( BaseGFXHelper::B3DHomMatrixToHomogenMatrix( aEffectiveTranformation ) ) ); } @@ -659,7 +642,6 @@ void VDiagram::createShapes_3d() ::basegfx::B3DHomMatrix aM; aM.translate(GRID_TO_WALL_DISTANCE/fXScale, GRID_TO_WALL_DISTANCE/fYScale, GRID_TO_WALL_DISTANCE/fZScale); aM.scale( fXScale, fYScale, fZScale ); -E3DModifySceneSnapRectUpdater aUpdater(lcl_getE3dScene( m_xOuterGroupShape )); xShapeProp-setPropertyValue( UNO_NAME_3D_TRANSFORM_MATRIX , uno::makeAny(BaseGFXHelper::B3DHomMatrixToHomogenMatrix(aM)) ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90555] UI: Formula Editor allows As character formula object to be repositioned in the veritcal
https://bugs.documentfoundation.org/show_bug.cgi?id=90555 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- (In reply to Gordo from comment #0) 13. Double click on formula. Result: Formula box has scroll arrows. While the zoom in the menu is greyed out, Could not reproduce. The formula box looks just as before. Everything before step 13. went like you described. Could you attach a screenshot of the issue? Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the screenshot. Win 7 Pro 64-bit, Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90555] UI: Formula Editor allows As character formula object to be repositioned in the veritcal
https://bugs.documentfoundation.org/show_bug.cgi?id=90555 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|4.4.2.2 release |Inherited From OOo Ever confirmed|0 |1 OS|Windows (All) |All Severity|normal |minor --- Comment #3 from Beluga todven...@suomi24.fi --- Thanks. I'll set to NEW as the important steps were reproduced. Ubuntu 14.10 64-bit LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx
include/svx/e3dsceneupdater.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3ac1584549364c573d4d4e3baed9ad39ad6ce8e4 Author: Caolán McNamara caol...@redhat.com Date: Fri Apr 17 13:40:27 2015 +0100 E3DModifySceneSnapRectUpdater does its work in its dtor Change-Id: I215bc3fe9e8e5a95d98cc8f5f1ec970c6d80dee3 diff --git a/include/svx/e3dsceneupdater.hxx b/include/svx/e3dsceneupdater.hxx index 3208eb8..54e5dcc 100644 --- a/include/svx/e3dsceneupdater.hxx +++ b/include/svx/e3dsceneupdater.hxx @@ -42,7 +42,7 @@ namespace drawinglayer { namespace geometry { // 3D content and tu use it. This is only wanted if changes to the scene's // content are intended to change the scene's 2D geometry attributes -class SVX_DLLPUBLIC SAL_WARN_UNUSED E3DModifySceneSnapRectUpdater +class SVX_DLLPUBLIC E3DModifySceneSnapRectUpdater { // the scene which may be changed. This gets set to the outmost scene // of the to-be-changed 3D object when the scene has a 3d transformation ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 87360] Spacing to content should be disabled for images
https://bugs.documentfoundation.org/show_bug.cgi?id=87360 Jay Philips philip...@hotmail.com changed: What|Removed |Added CC|libreoffice-ux-advise@lists |vmik...@collabora.co.uk |.freedesktop.org| Component|ux-advise |Writer --- Comment #5 from Jay Philips philip...@hotmail.com --- Kendy asked me to CC you on this. :D -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - extensions/source include/sfx2 include/svx sfx2/source svx/source sw/source
extensions/source/propctrlr/browserline.cxx |2 +- include/sfx2/tbxctrl.hxx |2 +- include/svx/linectrl.hxx |2 +- sfx2/source/toolbox/tbxitem.cxx |2 +- svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx |2 +- svx/source/tbxctrls/colorwindow.hxx |2 +- svx/source/tbxctrls/layctrl.cxx |8 svx/source/tbxctrls/lboxctrl.cxx |4 ++-- svx/source/tbxctrls/linectrl.cxx |2 +- svx/source/tbxctrls/tbcontrl.cxx | 10 +- sw/source/uibase/app/docsh2.cxx |6 +++--- sw/source/uibase/dbui/dbmgr.cxx |4 ++-- sw/source/uibase/dbui/dbtree.cxx |2 +- sw/source/uibase/dbui/mailmergechildwindow.cxx |2 +- sw/source/uibase/dbui/mailmergehelper.cxx|4 ++-- sw/source/uibase/docvw/HeaderFooterWin.cxx |2 +- sw/source/uibase/docvw/PageBreakWin.cxx |2 +- sw/source/uibase/docvw/SidebarWin.cxx|8 sw/source/uibase/docvw/srcedtw.cxx |6 +++--- sw/source/uibase/envelp/syncbtn.cxx |2 +- sw/source/uibase/inc/workctrl.hxx|2 +- sw/source/uibase/misc/glshell.cxx|2 +- sw/source/uibase/misc/redlndlg.cxx |2 +- sw/source/uibase/misc/swruler.cxx|2 +- sw/source/uibase/ribbar/inputwin.cxx |6 +++--- sw/source/uibase/ribbar/workctrl.cxx |6 +++--- 26 files changed, 47 insertions(+), 47 deletions(-) New commits: commit 0269ef901119635fa809245698c985b30e648ef4 Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 15:11:54 2015 +0200 sw: convert new to ::Create. Change-Id: Iab0fc73540b3c7a60c64296dce86b70c1e02cf09 diff --git a/extensions/source/propctrlr/browserline.cxx b/extensions/source/propctrlr/browserline.cxx index 9a84905..c322075 100644 --- a/extensions/source/propctrlr/browserline.cxx +++ b/extensions/source/propctrlr/browserline.cxx @@ -141,7 +141,7 @@ namespace pcr { m_aFtTitle-SetZOrder(pRefWindow,nFlags); if ( m_pControlWindow ) -m_pControlWindow-SetZOrder( (vcl::Window*)m_aFtTitle, WINDOW_ZORDER_BEHIND ); +m_pControlWindow-SetZOrder( m_aFtTitle.get(), WINDOW_ZORDER_BEHIND ); if ( m_pBrowseButton m_pControlWindow ) m_pBrowseButton-SetZOrder( m_pControlWindow, WINDOW_ZORDER_BEHIND ); diff --git a/include/sfx2/tbxctrl.hxx b/include/sfx2/tbxctrl.hxx index 5284bcc..c7dab43 100644 --- a/include/sfx2/tbxctrl.hxx +++ b/include/sfx2/tbxctrl.hxx @@ -153,7 +153,7 @@ public: virtual ~SfxPopupWindow(); virtual voiddispose() SAL_OVERRIDE; -virtual SfxPopupWindow* Clone() const; +virtual VclPtrSfxPopupWindow Clone() const; virtual voidMouseMove( const MouseEvent rMEvt ) SAL_OVERRIDE; voidStartCascading(); diff --git a/include/svx/linectrl.hxx b/include/svx/linectrl.hxx index 4b5ccec..b9daf62 100644 --- a/include/svx/linectrl.hxx +++ b/include/svx/linectrl.hxx @@ -124,7 +124,7 @@ public: virtual voidStateChanged( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState ) SAL_OVERRIDE; -virtual SfxPopupWindow* Clone() const SAL_OVERRIDE; +virtual VclPtrSfxPopupWindow Clone() const SAL_OVERRIDE; }; diff --git a/sfx2/source/toolbox/tbxitem.cxx b/sfx2/source/toolbox/tbxitem.cxx index f229d8d..4fc75e1 100644 --- a/sfx2/source/toolbox/tbxitem.cxx +++ b/sfx2/source/toolbox/tbxitem.cxx @@ -1335,7 +1335,7 @@ void SfxPopupWindow::StartCascading() -SfxPopupWindow* SfxPopupWindow::Clone() const +VclPtrSfxPopupWindow SfxPopupWindow::Clone() const /* [Description] diff --git a/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx b/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx index 1ad7f6e..d40f8a4 100644 --- a/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx +++ b/svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx @@ -1038,7 +1038,7 @@ namespace sdr { namespace contact { if ( m_aControl.is() ) { -if ( m_pOutputDeviceForWindow.get() == const_castOutputDevice *( _rDevice ) ) +if ( m_pOutputDeviceForWindow.get() == _rDevice ) return true; // Somebody requested a control for a new device, which means either of diff --git a/svx/source/tbxctrls/colorwindow.hxx b/svx/source/tbxctrls/colorwindow.hxx index eae25a8..5cdf8b7 100644 --- a/svx/source/tbxctrls/colorwindow.hxx +++ b/svx/source/tbxctrls/colorwindow.hxx @@ -74,7
[Libreoffice-bugs] [Bug 84704] SIDEBAR: Slow 1-pixel scrollbar scrolling when clicking in empty space or arrow buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=84704 --- Comment #5 from Matthew Millar mattmil...@googlemail.com --- Fault still exists in 4.4.1.2, however I'm only experiencing the speed issue in the 'Properties' tab of the sidebar. Whilst there are scrollbars in all except the 'Styles and Formatting' tab, 'Properties' is the only tab with a scrollbar for the actual bar (due to the content exceeding the bar); all others are scrollbars within objects, e.g. lists with items which exceed the list object's capacity, but with the list object filling and not exceeding the bar. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 87360] Spacing to content should be disabled for images
https://bugs.documentfoundation.org/show_bug.cgi?id=87360 Jay Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||070 Summary|Spacing to content should |Spacing to content should |be 0.00 cm when adding |be disabled for images |border to image | --- Comment #4 from Jay Philips philip...@hotmail.com --- In actuality, spacing to content should be disabled for images, as it is a feature of frames and not images. Seems bug 90071 was added as a duplicate of bug 90070 when i submitted it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 87360] Spacing to content should be disabled for images
https://bugs.documentfoundation.org/show_bug.cgi?id=87360 Jay Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||070 Summary|Spacing to content should |Spacing to content should |be 0.00 cm when adding |be disabled for images |border to image | --- Comment #4 from Jay Philips philip...@hotmail.com --- In actuality, spacing to content should be disabled for images, as it is a feature of frames and not images. Seems bug 90071 was added as a duplicate of bug 90070 when i submitted it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90070] Adding a border and spacing to content shrinks the size on an image
https://bugs.documentfoundation.org/show_bug.cgi?id=90070 Jay Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||360 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - framework/source sw/source
framework/source/layoutmanager/layoutmanager.cxx |8 ++-- sw/source/uibase/app/docsh.cxx |3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) New commits: commit 5ed0006b385849896d399241639cc8883e9bca47 Author: László Németh laszlo.nem...@collabora.com Date: Fri Apr 17 11:38:19 2015 +0200 Don't enable toolbar layout manager using LibreOfficeKit LibreOfficeKit doesn't need ToolbarLayoutManager. Change-Id: I10ec8733448407b0a93ca63e444f914f05410eff diff --git a/framework/source/layoutmanager/layoutmanager.cxx b/framework/source/layoutmanager/layoutmanager.cxx index e8b5d51..1b173e3 100644 --- a/framework/source/layoutmanager/layoutmanager.cxx +++ b/framework/source/layoutmanager/layoutmanager.cxx @@ -60,6 +60,7 @@ #include com/sun/star/util/URLTransformer.hpp #include comphelper/processfactory.hxx +#include comphelper/lok.hxx #include svtools/imgdef.hxx #include tools/diagnose_ex.h #include vcl/window.hxx @@ -139,8 +140,11 @@ LayoutManager::LayoutManager( const Reference XComponentContext xContext ) : m_aStatusBarElement.m_aType = statusbar; m_aStatusBarElement.m_aName = STATUS_BAR_ALIAS; -m_pToolbarManager = new ToolbarLayoutManager( xContext, ReferenceXUIElementFactory(m_xUIElementFactoryManager, UNO_QUERY_THROW), this ); -m_xToolbarManager = uno::Reference ui::XUIConfigurationListener ( static_cast OWeakObject* ( m_pToolbarManager ), uno::UNO_QUERY ); +if (!comphelper::LibreOfficeKit::isActive()) +{ +m_pToolbarManager = new ToolbarLayoutManager( xContext, ReferenceXUIElementFactory(m_xUIElementFactoryManager, UNO_QUERY_THROW), this ); +m_xToolbarManager = uno::Reference ui::XUIConfigurationListener ( static_cast OWeakObject* ( m_pToolbarManager ), uno::UNO_QUERY ); +} Application::AddEventListener( LINK( this, LayoutManager, SettingsChanged ) ); commit 21a9ddbc1c69f57dec7944dc7751b5377e9c50ff Author: László Németh laszlo.nem...@collabora.com Date: Fri Apr 17 11:26:26 2015 +0200 Writer export: don't update doc stat using SkipImages to speed up text extraction Change-Id: Ifa81483f537c8a79326c40fb610201f0bbbcc97a diff --git a/sw/source/uibase/app/docsh.cxx b/sw/source/uibase/app/docsh.cxx index aadb707..c364136 100644 --- a/sw/source/uibase/app/docsh.cxx +++ b/sw/source/uibase/app/docsh.cxx @@ -589,7 +589,8 @@ bool SwDocShell::ConvertTo( SfxMedium rMedium ) } // #i76360# Update document statistics -m_pDoc-getIDocumentStatistics().UpdateDocStat( false, true ); +if ( !rMedium.IsSkipImages() ) +m_pDoc-getIDocumentStatistics().UpdateDocStat( false, true ); CalcLayoutForOLEObjects(); // format for OLE objets // #i62875# ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 70886] UI: Detective Trace inadequate display
https://bugs.documentfoundation.org/show_bug.cgi?id=70886 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA bibisected |BSA bibisected ||target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/drawview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 004381ddff4e926972a7a9d14915bb2f4638b1e5 Author: Noel Power noel.po...@suse.com Date: Thu Apr 16 19:07:29 2015 +0100 fix for fdo#70886 detective shape thingies set an anchor (with an invalid start address) no idea why, it seems intentional (for the case where the dependant stuff is on another tab) This screws up the alignment for zoom logic Change-Id: I0f2356da69caf705003e81c4f8020c466e031d69 Signed-off-by: Noel Power noel.po...@suse.com diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx index 498b5cc..afa14e1 100644 --- a/sc/source/ui/view/drawview.cxx +++ b/sc/source/ui/view/drawview.cxx @@ -910,7 +910,7 @@ void ScDrawView::SyncForGrid( SdrObject* pObj ) if ( pGridWin ) { ScAddress aOldStt; -if( pData ) +if( pData pData-maStart.IsValid()) { aOldStt = pData-maStart; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 70886] UI: Detective Trace inadequate display
https://bugs.documentfoundation.org/show_bug.cgi?id=70886 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Noel Power committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=004381ddff4e926972a7a9d14915bb2f4638b1e5 fix for fdo#70886 It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - chart2/source dbaccess/source extensions/source filter/source include/svtools svtools/source svx/source
chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx |4 ++-- chart2/source/controller/inc/dlg_ChartType_UNO.hxx |2 +- dbaccess/source/ext/macromigration/macromigrationwizard.cxx |6 +++--- dbaccess/source/ui/inc/unosqlmessage.hxx|2 +- dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx |7 +++ dbaccess/source/ui/uno/DBTypeWizDlg.cxx |5 ++--- dbaccess/source/ui/uno/DBTypeWizDlg.hxx |2 +- dbaccess/source/ui/uno/DBTypeWizDlgSetup.cxx|4 ++-- dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx|2 +- dbaccess/source/ui/uno/TableFilterDlg.cxx |5 ++--- dbaccess/source/ui/uno/TableFilterDlg.hxx |2 +- dbaccess/source/ui/uno/UserSettingsDlg.cxx |5 ++--- dbaccess/source/ui/uno/UserSettingsDlg.hxx |2 +- dbaccess/source/ui/uno/admindlg.cxx |5 ++--- dbaccess/source/ui/uno/admindlg.hxx |2 +- dbaccess/source/ui/uno/composerdialogs.cxx | 10 +- dbaccess/source/ui/uno/composerdialogs.hxx |8 dbaccess/source/ui/uno/copytablewizard.cxx |6 +++--- dbaccess/source/ui/uno/textconnectionsettings_uno.cxx |6 +++--- dbaccess/source/ui/uno/unoDirectSql.cxx |4 ++-- dbaccess/source/ui/uno/unoDirectSql.hxx |2 +- dbaccess/source/ui/uno/unosqlmessage.cxx|6 +++--- extensions/source/abpilot/unodialogabp.cxx |4 ++-- extensions/source/abpilot/unodialogabp.hxx |2 +- extensions/source/dbpilots/unoautopilot.hxx |2 +- extensions/source/dbpilots/unoautopilot.inl |4 ++-- extensions/source/propctrlr/MasterDetailLinkDialog.cxx |4 ++-- extensions/source/propctrlr/MasterDetailLinkDialog.hxx |2 +- extensions/source/propctrlr/controlfontdialog.cxx |5 ++--- extensions/source/propctrlr/controlfontdialog.hxx |2 +- extensions/source/propctrlr/pcrunodialogs.cxx |4 ++-- extensions/source/propctrlr/pcrunodialogs.hxx |2 +- filter/source/flash/swfdialog.cxx |7 +++ filter/source/flash/swfdialog.hxx |2 +- filter/source/pdf/pdfdialog.cxx | 12 +++- filter/source/pdf/pdfdialog.hxx |2 +- filter/source/svg/svgdialog.cxx |9 + filter/source/svg/svgdialog.hxx |2 +- include/svtools/genericunodialog.hxx|2 +- svtools/source/uno/addrtempuno.cxx |8 svtools/source/uno/genericunodialog.cxx |2 +- svtools/source/uno/wizard/unowizard.cxx |8 svx/source/form/xfm_addcondition.cxx|4 ++-- svx/source/inc/xfm_addcondition.hxx |2 +- 44 files changed, 88 insertions(+), 100 deletions(-) New commits: commit 0a497cb52a2ffecd94178eed296ba8ae7f526358 Author: Michael Meeks michael.me...@collabora.com Date: Fri Apr 17 12:10:27 2015 +0100 Use VclPtr for OGenericUnoDialog::createDialog. Change-Id: I0c2040889931a4700735339c5252f8d5fee234ff diff --git a/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx b/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx index ee3d904..b6145c9 100644 --- a/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx +++ b/chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx @@ -79,9 +79,9 @@ void ChartTypeUnoDlg::implInitialize(const uno::Any _rValue) else ChartTypeUnoDlg_BASE::implInitialize(_rValue); } -Dialog* ChartTypeUnoDlg::createDialog(vcl::Window* _pParent) +VclPtrDialog ChartTypeUnoDlg::createDialog(vcl::Window* _pParent) { -return new ChartTypeDialog( _pParent, m_xChartModel, m_aContext ); +return VclPtrChartTypeDialog::Create( _pParent, m_xChartModel, m_aContext ); } uno::Referencebeans::XPropertySetInfo SAL_CALL ChartTypeUnoDlg::getPropertySetInfo() throw(uno::RuntimeException, std::exception) { diff --git a/chart2/source/controller/inc/dlg_ChartType_UNO.hxx b/chart2/source/controller/inc/dlg_ChartType_UNO.hxx index 95dc944..f91d222 100644 --- a/chart2/source/controller/inc/dlg_ChartType_UNO.hxx +++ b/chart2/source/controller/inc/dlg_ChartType_UNO.hxx @@ -44,7 +44,7 @@ private: // OGenericUnoDialog overridables virtual void implInitialize(const com::sun::star::uno::Any _rValue) SAL_OVERRIDE; -virtual Dialog* createDialog(vcl::Window* _pParent) SAL_OVERRIDE; +virtual VclPtrDialog createDialog(vcl::Window* _pParent) SAL_OVERRIDE; // XTypeProvider
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - filter/source
filter/source/graphicfilter/ios2met/ios2met.cxx |2 +- filter/source/graphicfilter/ipict/ipict.cxx |2 +- filter/source/svg/impsvgdialog.cxx| 14 +++--- filter/source/xsltdialog/xmlfilterdialogcomponent.cxx |2 +- filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |6 +++--- filter/source/xsltdialog/xmlfiltertabdialog.cxx |4 ++-- 6 files changed, 15 insertions(+), 15 deletions(-) New commits: commit 9e43761446db5b085dbabea5df00f6fc253167ac Author: Michael Meeks michael.me...@collabora.com Date: Fri Apr 17 12:19:15 2015 +0100 filter: convert new to ::Create. Change-Id: I6cea3011ff3c89c95fa19cc4264b43779aa0e0a9 diff --git a/filter/source/graphicfilter/ios2met/ios2met.cxx b/filter/source/graphicfilter/ios2met/ios2met.cxx index 9e8b894..cecaf1f 100644 --- a/filter/source/graphicfilter/ios2met/ios2met.cxx +++ b/filter/source/graphicfilter/ios2met/ios2met.cxx @@ -2609,7 +2609,7 @@ void OS2METReader::ReadOS2MET( SvStream rStreamOS2MET, GDIMetaFile rGDIMetaF pOrdFile=NULL; -pVirDev = new VirtualDevice(); +pVirDev = VclPtrVirtualDevice::Create(); pVirDev-EnableOutput(false); rGDIMetaFile.Record(pVirDev); diff --git a/filter/source/graphicfilter/ipict/ipict.cxx b/filter/source/graphicfilter/ipict/ipict.cxx index a578272..f88fff3 100644 --- a/filter/source/graphicfilter/ipict/ipict.cxx +++ b/filter/source/graphicfilter/ipict/ipict.cxx @@ -1881,7 +1881,7 @@ void PictReader::ReadPict( SvStream rStreamPict, GDIMetaFile rGDIMetaFile ) aHRes = aVRes = Fraction( 1, 1 ); -pVirDev = new VirtualDevice(); +pVirDev = VclPtrVirtualDevice::Create(); pVirDev-EnableOutput(false); rGDIMetaFile.Record(pVirDev); diff --git a/filter/source/svg/impsvgdialog.cxx b/filter/source/svg/impsvgdialog.cxx index c142178..2e70390 100644 --- a/filter/source/svg/impsvgdialog.cxx +++ b/filter/source/svg/impsvgdialog.cxx @@ -36,13 +36,13 @@ inline sal_Int32 implMap( vcl::Window /*rWnd*/, sal_Int32 nVal ) ImpSVGDialog::ImpSVGDialog( vcl::Window* pParent, Sequence PropertyValue rFilterData ) : ModalDialog( pParent ), -maFI( new FixedLine(this) ), -maCBTinyProfile( new CheckBox(this) ), -maCBEmbedFonts( new CheckBox(this) ), -maCBUseNativeDecoration( new CheckBox(this) ), -maBTOK( new OKButton(this, WB_DEF_OK) ), -maBTCancel( new CancelButton(this) ), -maBTHelp( new HelpButton(this) ), +maFI( VclPtrFixedLine::Create(this) ), +maCBTinyProfile( VclPtrCheckBox::Create(this) ), +maCBEmbedFonts( VclPtrCheckBox::Create(this) ), +maCBUseNativeDecoration( VclPtrCheckBox::Create(this) ), +maBTOK( VclPtrOKButton::Create(this, WB_DEF_OK) ), +maBTCancel( VclPtrCancelButton::Create(this) ), +maBTHelp( VclPtrHelpButton::Create(this) ), maConfigItem( SVG_EXPORTFILTER_CONFIGPATH, rFilterData ), mbOldNativeDecoration( false ) { diff --git a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx index 9ff555c..2ee2058 100644 --- a/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx +++ b/filter/source/xsltdialog/xmlfilterdialogcomponent.cxx @@ -331,7 +331,7 @@ sal_Int16 SAL_CALL XMLFilterDialogComponent::execute( ) throw(RuntimeException, pParent = VCLUnoHelper::GetWindow(mxParent); Reference XComponent xComp( this ); -mpDialog = new XMLFilterSettingsDialog(pParent, mxContext); +mpDialog = VclPtrXMLFilterSettingsDialog::Create(pParent, mxContext); mpDialog-Execute(); } else if( !mpDialog-IsVisible() ) diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx index a5597e5..514d337f 100644 --- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx @@ -1356,12 +1356,12 @@ SvxPathControl::SvxPathControl(vcl::Window* pParent) : Window(pParent, WB_HIDE | WB_CLIPCHILDREN | WB_TABSTOP | WB_DIALOGCONTROL | WB_BORDER) , bHasBeenShown(false) { -m_pVBox = new VclVBox(this); +m_pVBox = VclPtrVclVBox::Create(this); -m_pHeaderBar = new HeaderBar(m_pVBox, WB_BOTTOMBORDER); +m_pHeaderBar = VclPtrHeaderBar::Create(m_pVBox, WB_BOTTOMBORDER); m_pHeaderBar-set_height_request(GetTextHeight() + 6); -m_pFocusCtrl = new XMLFilterListBox(m_pVBox, this); +m_pFocusCtrl = VclPtrXMLFilterListBox::Create(m_pVBox, this); m_pFocusCtrl-set_fill(true); m_pFocusCtrl-set_expand(true); diff --git a/filter/source/xsltdialog/xmlfiltertabdialog.cxx b/filter/source/xsltdialog/xmlfiltertabdialog.cxx index eb1eae8..ff725cc 100644 --- a/filter/source/xsltdialog/xmlfiltertabdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltertabdialog.cxx @@ -56,13 +56,13 @@ XMLFilterTabDialog::XMLFilterTabDialog(vcl::Window *pParent, ResMgr rResMgr, m_pTabCtrl-SetActivatePageHdl( LINK( this,
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - basctl/source include/sfx2 include/svtools include/svx sc/source sd/source sfx2/source svx/source svx/workben sw/source
basctl/source/basicide/tbxctl.cxx | 2 basctl/source/basicide/tbxctl.hxx | 2 include/sfx2/tbxctrl.hxx | 4 - include/svtools/popupwindowcontroller.hxx | 3 - include/svx/ParaLineSpacingPopup.hxx | 2 include/svx/clipboardctl.hxx | 2 include/svx/fontworkgallery.hxx| 2 include/svx/grafctrl.hxx | 2 include/svx/layctrl.hxx| 4 - include/svx/lboxctrl.hxx | 4 - include/svx/linectrl.hxx | 2 include/svx/subtoolboxcontrol.hxx | 2 include/svx/tbcontrl.hxx | 6 +- include/svx/tbxalign.hxx | 2 include/svx/tbxcustomshapes.hxx| 2 sc/source/ui/cctrl/tbinsert.cxx| 2 sc/source/ui/inc/tbinsert.hxx | 2 sd/source/ui/app/tbxww.cxx | 2 sd/source/ui/controller/slidelayoutcontroller.cxx | 2 sd/source/ui/controller/slidelayoutcontroller.hxx | 2 sd/source/ui/inc/tbx_ww.hxx| 2 sfx2/source/toolbox/tbxitem.cxx| 4 - svx/source/customshapes/tbxcustomshapes.cxx| 2 svx/source/form/tbxform.cxx| 2 svx/source/inc/tbxform.hxx | 2 svx/source/mnuctrls/clipboardctl.cxx | 2 svx/source/sidebar/paragraph/ParaLineSpacingPopup.cxx | 2 svx/source/svdraw/sdrpaintwindow.cxx | 2 svx/source/svdraw/svdfmtf.cxx | 2 svx/source/svdraw/svdibrow.cxx | 4 - svx/source/svdraw/svdpntv.cxx | 2 svx/source/tbxctrls/SvxColorChildWindow.cxx| 3 - svx/source/tbxctrls/bulletsnumbering.cxx | 8 +-- svx/source/tbxctrls/colrctrl.cxx | 2 svx/source/tbxctrls/extrusioncontrols.cxx | 16 +++--- svx/source/tbxctrls/extrusioncontrols.hxx | 8 +-- svx/source/tbxctrls/fillctrl.cxx | 4 - svx/source/tbxctrls/fontworkgallery.cxx| 14 ++--- svx/source/tbxctrls/grafctrl.cxx | 6 +- svx/source/tbxctrls/layctrl.cxx| 18 +++ svx/source/tbxctrls/lboxctrl.cxx | 8 +-- svx/source/tbxctrls/linectrl.cxx | 10 ++-- svx/source/tbxctrls/subtoolboxcontrol.cxx | 2 svx/source/tbxctrls/tbcontrl.cxx | 25 +- svx/source/tbxctrls/tbunocontroller.cxx| 3 - svx/source/tbxctrls/tbunosearchcontrollers.cxx | 6 +- svx/source/tbxctrls/tbxalign.cxx | 2 svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.cxx | 4 - svx/source/unodialogs/textconversiondlgs/chinese_translation_unodialog.cxx | 2 svx/source/unodialogs/textconversiondlgs/chinese_translationdialog.cxx | 2 svx/source/unodraw/UnoGraphicExporter.cxx | 6 +- svx/workben/msview/msview.cxx | 2 svx/workben/pixelctl.cxx | 2 sw/source/uibase/inc/tblctrl.hxx | 2 sw/source/uibase/inc/tbxanchr.hxx | 2 sw/source/uibase/inc/workctrl.hxx | 6 +- sw/source/uibase/ribbar/tblctrl.cxx| 2 sw/source/uibase/ribbar/tbxanchr.cxx | 2
[Libreoffice-bugs] [Bug 83365] Other: Access across spreadsheet returns Err:504
https://bugs.documentfoundation.org/show_bug.cgi?id=83365 --- Comment #9 from Eike Rathke er...@redhat.com --- Raal did a bibisect (binary build bisect, which gives a range of commits), Matthew did an exact bisect. With commit 194e9f9bae28bdf22a9ed4779c1656ee693f3302 indeed the detailed relative reference and 3D sheet flag handling and inheritance were lost. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90676] New: Envelope Printing Epson
https://bugs.documentfoundation.org/show_bug.cgi?id=90676 Bug ID: 90676 Summary: Envelope Printing Epson Product: LibreOffice Version: unspecified Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bobhi...@gmail.com When using the wizard to print envelopes, Epson printer (WF 3640) with center feed rear slot will not print. This is similar to HP and other printers reported. Generally, the envelope is ejected and a letter feed from the letter paper supply is printed upon (when new doc is selected, envelope invoked and text inserted for envelope only). With some adjustment of characteristics as described for other brands, a paper mismatch message is generated and no printing takes place. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90249] LibreOffice cannot open file on webdav server with windows 7 Operating system
https://bugs.documentfoundation.org/show_bug.cgi?id=90249 lnunes licinia.nu...@scantech.fr changed: What|Removed |Added Summary|Regression: Cannot open |LibreOffice cannot open |file on webdav server due |file on webdav server with |to lock problem |windows 7 Operating system --- Comment #3 from lnunes licinia.nu...@scantech.fr --- Hi Matus. I have downloaded version 4.2.7.2 for windows (I have windows 7 installed on my PC). It turns out that file cannot be opened on webdav server and lock has been put. My colleague also has 4.2.7.2 but running on linux. It works fine for him: lock is put and file is coorectly opened. So this is not a regression but an issue linked to OS version. I updated the bug summary accordingly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90249] LibreOffice cannot open file on webdav server with windows 7 Operating system
https://bugs.documentfoundation.org/show_bug.cgi?id=90249 --- Comment #4 from lnunes licinia.nu...@scantech.fr --- Hi Matus. I have downloaded version 4.2.7.2 for windows (I have windows 7 installed on my PC). It turns out that file cannot be opened on webdav server and lock has been put. My colleague also has 4.2.7.2 but running on linux. It works fine for him: lock is put and file is coorectly opened. So this is not a regression but an issue linked to OS version. I updated the bug summary accordingly. Regards Licinia -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83199] VIEWING: Clicking footnote number in web view causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=83199 --- Comment #13 from Jay Philips philip...@hotmail.com --- Didnt crash for me. Version: 4.5.0.0.alpha0+ Build ID: 25c25f855169c98c30f3f7868fd1ad430e159ddc TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-04-14_08:59:23 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90503] LibreOffice DOES NOT FULLY in Windows 10 Technical Preview (officially leaves in summer)
https://bugs.documentfoundation.org/show_bug.cgi?id=90503 vv...@yandex.ru changed: What|Removed |Added CC||vv...@yandex.ru --- Comment #3 from vv...@yandex.ru --- Created attachment 114860 -- https://bugs.documentfoundation.org/attachment.cgi?id=114860action=edit LibreOffice 4.4.2.2 + Windows 10 9926 Works fine for me. Screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx | 24 +++- sw/source/filter/ww8/docxattributeoutput.hxx |3 ++- 2 files changed, 17 insertions(+), 10 deletions(-) New commits: commit 4b431291bba8429ea80c43721bc6dd5f0ad4d2e8 Author: Caolán McNamara caol...@redhat.com Date: Fri Apr 17 13:59:52 2015 +0100 refactor a tiny bit for future plans, no change in logic Change-Id: If104cdbc7e9d38c9664492f433c53ee5ffb59578 diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 9ebf5eb..f65ba79 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -2812,7 +2812,7 @@ static void impl_cellMargins( FSHelperPtr pSerializer, const SvxBoxItem rBox, s } } -void DocxAttributeOutput::TableCellProperties( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ) +void DocxAttributeOutput::TableCellProperties( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner, sal_uInt32 nCell, sal_uInt32 nRow ) { m_pSerializer-startElementNS( XML_w, XML_tcPr, FSEND ); @@ -2824,9 +2824,9 @@ void DocxAttributeOutput::TableCellProperties( ww8::WW8TableNodeInfoInner::Point TableCellRedline( pTableTextNodeInfoInner ); // Cell preferred width -SwTwips nWidth = GetGridCols( pTableTextNodeInfoInner )-at( pTableTextNodeInfoInner-getCell() ); -if ( pTableTextNodeInfoInner-getCell() ) -nWidth = nWidth - GetGridCols( pTableTextNodeInfoInner )-at( pTableTextNodeInfoInner-getCell() - 1 ); +SwTwips nWidth = GetGridCols( pTableTextNodeInfoInner )-at( nCell ); +if ( nCell ) +nWidth = nWidth - GetGridCols( pTableTextNodeInfoInner )-at( nCell - 1 ); m_pSerializer-singleElementNS( XML_w, XML_tcW, FSNS( XML_w, XML_w ), OString::number( nWidth ).getStr( ), FSNS( XML_w, XML_type ), dxa, @@ -2834,8 +2834,7 @@ void DocxAttributeOutput::TableCellProperties( ww8::WW8TableNodeInfoInner::Point // Horizontal spans const SwWriteTableRows aRows = m_pTableWrt-GetRows( ); -SwWriteTableRow *pRow = aRows[ pTableTextNodeInfoInner-getRow( ) ]; -sal_uInt32 nCell = pTableTextNodeInfoInner-getCell(); +SwWriteTableRow *pRow = aRows[ nRow ]; const SwWriteTableCells *tableCells = pRow-GetCells(); if (nCell tableCells-size() ) { @@ -2987,7 +2986,7 @@ void DocxAttributeOutput::EndTableRow( ) m_pSerializer-endElementNS( XML_w, XML_tr ); } -void DocxAttributeOutput::StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ) +void DocxAttributeOutput::StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner, sal_uInt32 nCell, sal_uInt32 nRow ) { if ( !m_pTableWrt ) InitTableHelper( pTableTextNodeInfoInner ); @@ -2995,11 +2994,18 @@ void DocxAttributeOutput::StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t m_pSerializer-startElementNS( XML_w, XML_tc, FSEND ); // Write the cell properties here -TableCellProperties( pTableTextNodeInfoInner ); +TableCellProperties( pTableTextNodeInfoInner, nCell, nRow ); m_tableReference-m_bTableCellOpen = true; } +void DocxAttributeOutput::StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ) +{ +const sal_uInt32 nCell = pTableTextNodeInfoInner-getCell(); +const sal_uInt32 nRow = pTableTextNodeInfoInner-getRow(); +StartTableCell(pTableTextNodeInfoInner, nCell, nRow); +} + void DocxAttributeOutput::EndTableCell( ) { if (m_tableReference-m_bTableCellParaSdtOpen) @@ -3574,7 +3580,7 @@ void DocxAttributeOutput::TableVerticalCell( ww8::WW8TableNodeInfoInner::Pointer const SwWriteTableCells *tableCells = pRow-GetCells(); if (nCell tableCells-size() ) { -const SwWriteTableCell *pCell = pRow-GetCells( )[ pTableTextNodeInfoInner-getCell( ) ]; +const SwWriteTableCell *pCell = pRow-GetCells( )[ nCell ]; switch( pCell-GetVertOri()) { case text::VertOrientation::TOP: diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index 093a56b..e3d2fbb 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -424,7 +424,8 @@ private: void StartTable( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ); void StartTableRow( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ); void StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ); -void TableCellProperties( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner ); +void StartTableCell( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner, sal_uInt32 nCell, sal_uInt32 nRow ); +void TableCellProperties( ww8::WW8TableNodeInfoInner::Pointer_t pTableTextNodeInfoInner, sal_uInt32 nCell, sal_uInt32 nRow ); void
[Libreoffice-commits] core.git: 14 commits - basic/source compilerplugins/clang connectivity/source dbaccess/source editeng/source filter/source idl/source include/vcl sc/source sd/source sot/source s
basic/source/classes/sbxmod.cxx |2 basic/source/sbx/sbxcoll.cxx |2 compilerplugins/clang/implicitboolconversion.cxx | 362 --- connectivity/source/commontools/FValue.cxx |2 dbaccess/source/ui/inc/tabletree.hxx |2 editeng/source/editeng/editattr.cxx |2 editeng/source/editeng/editdoc.cxx |2 editeng/source/editeng/editobj.cxx |6 editeng/source/items/bulitem.cxx |6 editeng/source/items/frmitems.cxx|4 editeng/source/items/textitem.cxx| 18 - editeng/source/outliner/outliner.cxx |2 filter/source/flash/swfwriter2.cxx |8 filter/source/msfilter/escherex.cxx |2 idl/source/objects/bastype.cxx |2 include/vcl/salbtype.hxx | 12 sc/source/core/data/patattr.cxx |2 sc/source/core/tool/autoform.cxx | 12 sc/source/core/tool/ddelink.cxx |2 sc/source/filter/inc/xcl97rec.hxx|2 sc/source/filter/xcl97/xcl97rec.cxx |4 sc/source/ui/drawfunc/fupoor.cxx |4 sc/source/ui/unoobj/cellsuno.cxx |6 sc/source/ui/unoobj/docuno.cxx |4 sd/source/filter/eppt/pptexanimations.cxx|2 sd/source/filter/html/pubdlg.cxx | 22 - sd/source/ui/dlg/morphdlg.cxx|4 sd/source/ui/dlg/vectdlg.cxx |2 sot/source/sdstor/stgelem.cxx| 20 - sot/source/sdstor/stgelem.hxx|4 svl/source/items/cenumitm.cxx|2 svl/source/items/ctypeitm.cxx|2 svtools/source/graphic/grfattr.cxx |2 svtools/source/graphic/grfmgr.cxx|2 svtools/source/misc/imap.cxx |4 svx/source/gallery2/galobj.cxx |2 svx/source/gallery2/galtheme.cxx |4 svx/source/items/pageitem.cxx|2 svx/source/svdraw/svdattr.cxx|2 sw/source/core/doc/tblafmt.cxx | 14 sw/source/core/doc/tblrwcl.cxx |2 sw/source/core/edit/ednumber.cxx |2 sw/source/filter/inc/rtf.hxx |4 sw/source/filter/ww8/wrtww8.hxx | 16 - sw/source/filter/ww8/ww8atr.cxx | 12 sw/source/filter/ww8/ww8par.cxx |6 sw/source/filter/ww8/ww8par2.cxx | 18 - sw/source/filter/ww8/ww8par3.cxx | 34 +- sw/source/filter/ww8/ww8par6.cxx |2 sw/source/filter/ww8/ww8scan.cxx |3 sw/source/filter/ww8/ww8scan.hxx |4 sw/source/filter/ww8/ww8struc.hxx|3 tools/source/generic/poly.cxx|2 vcl/source/gdi/animate.cxx |2 vcl/source/gdi/cvtsvm.cxx| 18 - vcl/source/gdi/dibtools.cxx | 61 ++- vcl/source/gdi/font.cxx | 10 vcl/source/gdi/mapmod.cxx|2 vcl/source/gdi/metaact.cxx | 22 - vcl/source/gdi/region.cxx|2 vcl/source/gdi/wall.cxx |2 61 files changed, 543 insertions(+), 244 deletions(-) New commits: commit 8e4d82cd1125502c26ddaaa85c49c4aa44f65811 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 17 15:07:50 2015 +0200 loplugin:implicitboolconversion: warn about conversions to unsigned char ...while avoiding warnings about conversions to bool-like typedefs (sal_Bool etc.), also in cases where those typedefs are used as type arguments of template specializations (which is no little feat, and the current code is only an approximation of it, one that appears to cover the relevant cases in our code base though). Change-Id: I0ed3801aec7787bf38b429b66e25244ec00cac9b diff --git a/compilerplugins/clang/implicitboolconversion.cxx b/compilerplugins/clang/implicitboolconversion.cxx index d8ef00e..57d0016 100644 --- a/compilerplugins/clang/implicitboolconversion.cxx +++ b/compilerplugins/clang/implicitboolconversion.cxx @@ -36,30 +36,68 @@ template struct std::iterator_traitsConstExprIterator { namespace { -bool isBool(Expr const * expr, bool allowTypedefs = true) { -QualType t1 { expr-getType() }; -if (t1-isBooleanType()) { +Expr const * ignoreParenAndTemporaryMaterialization(Expr const * expr) { +for (;;) { +expr = expr-IgnoreParens(); +auto e = dyn_castMaterializeTemporaryExpr(expr); +if (e == nullptr) { +return expr; +} +
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - sw/source
sw/source/ui/fldui/flddb.cxx |2 +- sw/source/ui/fldui/flddinf.cxx |2 +- sw/source/ui/fldui/flddok.cxx |2 +- sw/source/ui/fldui/fldfunc.cxx |2 +- sw/source/ui/fldui/fldref.cxx |2 +- sw/source/ui/fldui/fldvar.cxx |2 +- sw/source/ui/frmdlg/column.cxx |2 +- sw/source/ui/frmdlg/frmpage.cxx|8 sw/source/ui/frmdlg/wrap.cxx |2 +- sw/source/ui/index/cnttab.cxx | 20 ++-- sw/source/ui/index/swuiidxmrk.cxx |8 sw/source/ui/misc/docfnote.cxx |4 ++-- sw/source/ui/misc/impfnote.hxx |2 +- sw/source/ui/misc/num.cxx |2 +- sw/source/ui/misc/outline.cxx |2 +- sw/source/ui/misc/pgfnote.cxx |2 +- sw/source/ui/misc/pggrid.cxx |2 +- sw/source/ui/table/tabledlg.cxx|6 +++--- sw/source/ui/table/tautofmt.cxx|2 +- sw/source/uibase/inc/column.hxx|3 +-- sw/source/uibase/inc/frmpage.hxx | 11 --- sw/source/uibase/inc/pgfnote.hxx |2 +- sw/source/uibase/inc/pggrid.hxx|3 +-- sw/source/uibase/inc/wrap.hxx |2 +- sw/source/uibase/table/tablepg.hxx |2 +- 25 files changed, 46 insertions(+), 51 deletions(-) New commits: commit f0f786e8fc7165a22b67ec73331ee8d66c01409c Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 15:30:46 2015 +0200 sw: convert new to ::Create. Change-Id: I1669be3e1dfdb6733952b2a801371da243fb94c2 diff --git a/sw/source/ui/fldui/flddb.cxx b/sw/source/ui/fldui/flddb.cxx index a05a7f2..4e16079 100644 --- a/sw/source/ui/fldui/flddb.cxx +++ b/sw/source/ui/fldui/flddb.cxx @@ -267,7 +267,7 @@ bool SwFldDBPage::FillItemSet(SfxItemSet* ) SfxTabPage* SwFldDBPage::Create(vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldDBPage( pParent, *rAttrSet ) ); +return VclPtrSwFldDBPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldDBPage::GetGroup() diff --git a/sw/source/ui/fldui/flddinf.cxx b/sw/source/ui/fldui/flddinf.cxx index d5d41f3..d77fdf6 100644 --- a/sw/source/ui/fldui/flddinf.cxx +++ b/sw/source/ui/fldui/flddinf.cxx @@ -465,7 +465,7 @@ bool SwFldDokInfPage::FillItemSet(SfxItemSet* ) SfxTabPage* SwFldDokInfPage::Create(vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldDokInfPage( pParent, *rAttrSet ) ); +return VclPtrSwFldDokInfPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldDokInfPage::GetGroup() diff --git a/sw/source/ui/fldui/flddok.cxx b/sw/source/ui/fldui/flddok.cxx index 2744141..cd0be8b 100644 --- a/sw/source/ui/fldui/flddok.cxx +++ b/sw/source/ui/fldui/flddok.cxx @@ -656,7 +656,7 @@ bool SwFldDokPage::FillItemSet(SfxItemSet* ) SfxTabPage* SwFldDokPage::Create( vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldDokPage( pParent, *rAttrSet ) ); +return VclPtrSwFldDokPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldDokPage::GetGroup() diff --git a/sw/source/ui/fldui/fldfunc.cxx b/sw/source/ui/fldui/fldfunc.cxx index 07d0fdd..b2cfeb3 100644 --- a/sw/source/ui/fldui/fldfunc.cxx +++ b/sw/source/ui/fldui/fldfunc.cxx @@ -631,7 +631,7 @@ OUString SwFldFuncPage::TurnMacroString(const OUString rMacro) SfxTabPage* SwFldFuncPage::Create( vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldFuncPage( pParent, *rAttrSet ) ); +return VclPtrSwFldFuncPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldFuncPage::GetGroup() diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx index 527e44c..e421f1f 100644 --- a/sw/source/ui/fldui/fldref.cxx +++ b/sw/source/ui/fldui/fldref.cxx @@ -953,7 +953,7 @@ bool SwFldRefPage::FillItemSet(SfxItemSet* ) SfxTabPage* SwFldRefPage::Create( vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldRefPage( pParent, *rAttrSet ) ); +return VclPtrSwFldRefPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldRefPage::GetGroup() diff --git a/sw/source/ui/fldui/fldvar.cxx b/sw/source/ui/fldui/fldvar.cxx index 1163e0a..257181a 100644 --- a/sw/source/ui/fldui/fldvar.cxx +++ b/sw/source/ui/fldui/fldvar.cxx @@ -1250,7 +1250,7 @@ bool SwFldVarPage::FillItemSet(SfxItemSet* ) SfxTabPage* SwFldVarPage::Create( vcl::Window* pParent, const SfxItemSet* rAttrSet ) { -return ( new SwFldVarPage( pParent, *rAttrSet ) ); +return VclPtrSwFldVarPage::Create( pParent, *rAttrSet ); } sal_uInt16 SwFldVarPage::GetGroup() diff --git a/sw/source/ui/frmdlg/column.cxx b/sw/source/ui/frmdlg/column.cxx index 4f14a5e..f0ae9c4 100644 --- a/sw/source/ui/frmdlg/column.cxx +++ b/sw/source/ui/frmdlg/column.cxx @@ -659,7 +659,7 @@ void SwColumnPage::Reset(const SfxItemSet *rSet) // create TabPage SfxTabPage* SwColumnPage::Create(vcl::Window *pParent, const SfxItemSet *rSet) { -return
[Libreoffice-bugs] [Bug 90659] FILESAVE: Libreoffice Calc .ods format very slow when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=90659 Jeffrey jeffreyzheng...@gmail.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - sw/inc sw/source
sw/inc/postithelper.hxx |4 sw/source/core/doc/DocumentDeviceManager.cxx |8 - sw/source/core/fields/postithelper.cxx |4 sw/source/core/layout/virtoutp.cxx |2 sw/source/core/view/viewsh.cxx |2 sw/source/core/view/vprint.cxx |2 sw/source/ui/chrdlg/chardlg.cxx |2 sw/source/ui/chrdlg/drpcps.cxx |2 sw/source/ui/chrdlg/numpara.cxx |2 sw/source/ui/chrdlg/swuiccoll.cxx|2 sw/source/ui/config/mailconfigpage.cxx |2 sw/source/ui/config/optcomp.cxx |2 sw/source/ui/config/optload.cxx |4 sw/source/ui/config/optpage.cxx | 18 +- sw/source/ui/dbui/addresslistdialog.cxx |8 - sw/source/ui/dbui/createaddresslistdialog.cxx| 10 - sw/source/ui/dbui/customizeaddresslistdialog.cxx |4 sw/source/ui/dbui/mailmergewizard.cxx| 16 +- sw/source/ui/dbui/mmaddressblockpage.cxx | 18 +- sw/source/ui/dbui/mmgreetingspage.cxx|4 sw/source/ui/dbui/mmoutputpage.cxx | 12 - sw/source/ui/dbui/mmoutputtypepage.cxx |2 sw/source/ui/dbui/selectdbtabledialog.cxx|2 sw/source/ui/dialog/ascfldlg.cxx |2 sw/source/ui/dialog/docstdlg.cxx |2 sw/source/ui/dialog/swdlgfact.cxx| 143 +++ sw/source/ui/dialog/uiregionsw.cxx |6 sw/source/ui/envelp/envfmt.cxx |2 sw/source/ui/envelp/envfmt.hxx |3 sw/source/ui/envelp/envlop1.cxx |2 sw/source/ui/envelp/envprt.cxx |2 sw/source/ui/envelp/envprt.hxx |3 sw/source/ui/envelp/label1.cxx |8 - sw/source/ui/envelp/labfmt.cxx |2 sw/source/ui/envelp/labfmt.hxx |3 sw/source/ui/envelp/labprt.cxx |2 sw/source/ui/envelp/labprt.hxx |3 sw/source/ui/envelp/swuilabimp.hxx | 12 - sw/source/uibase/inc/drpcps.hxx |3 sw/source/uibase/inc/envlop.hxx |3 sw/source/uibase/inc/numpara.hxx |4 sw/source/uibase/inc/optpage.hxx | 25 +--- sw/source/uibase/inc/swuiccoll.hxx |2 43 files changed, 177 insertions(+), 187 deletions(-) New commits: commit 5cf00154ca1e5013ceba59103ad706a3492ea70b Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 15:54:21 2015 +0200 sw: convert new to ::Create. Change-Id: I3783ee5c3eca2ecb4490a16032edad7e6ebe3460 diff --git a/sw/inc/postithelper.hxx b/sw/inc/postithelper.hxx index cf1f7c0..e8fa575 100644 --- a/sw/inc/postithelper.hxx +++ b/sw/inc/postithelper.hxx @@ -114,7 +114,7 @@ public: virtual bool UseElement() = 0; virtual const SwFmtFld GetFmtFld() const = 0; virtual const SfxBroadcaster* GetBroadCaster() const = 0; -virtual sw::sidebarwindows::SwSidebarWin* GetSidebarWindow( SwEditWin rEditWin, +virtual VclPtrsw::sidebarwindows::SwSidebarWin GetSidebarWindow( SwEditWin rEditWin, WinBits nBits, SwPostItMgr aMgr, SwPostItBits aBits) = 0; @@ -146,7 +146,7 @@ public: { return dynamic_castconst SfxBroadcaster * (mrFmtFld); } -virtual sw::sidebarwindows::SwSidebarWin* GetSidebarWindow( +virtual VclPtrsw::sidebarwindows::SwSidebarWin GetSidebarWindow( SwEditWin rEditWin, WinBits nBits, SwPostItMgr aMgr, diff --git a/sw/source/core/doc/DocumentDeviceManager.cxx b/sw/source/core/doc/DocumentDeviceManager.cxx index b8b0438..59ebd29 100644 --- a/sw/source/core/doc/DocumentDeviceManager.cxx +++ b/sw/source/core/doc/DocumentDeviceManager.cxx @@ -212,7 +212,7 @@ void DocumentDeviceManager::setJobsetup(/*[in]*/ const JobSetup rJobSetup ) SID_PRINTER_NOTFOUND_WARN, SID_PRINTER_NOTFOUND_WARN, SID_PRINTER_CHANGESTODOC, SID_PRINTER_CHANGESTODOC, 0 ); -SfxPrinter *p = new SfxPrinter( pSet, rJobSetup ); +VclPtrSfxPrinter p = VclPtrSfxPrinter::Create( pSet, rJobSetup ); if ( bCheckPageDescs ) setPrinter( p, true, true ); else @@ -261,9 +261,9 @@ DocumentDeviceManager::~DocumentDeviceManager() VirtualDevice DocumentDeviceManager::CreateVirtualDevice_() const { #ifdef IOS -VirtualDevice* pNewVir = new VirtualDevice( 8 ); +VclPtrVirtualDevice pNewVir = VclPtrVirtualDevice::Create( 8 ); #else -VirtualDevice* pNewVir = new VirtualDevice( 1 ); +
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxattributeoutput.cxx |9 - sw/source/filter/ww8/docxattributeoutput.hxx |2 -- 2 files changed, 11 deletions(-) New commits: commit ff349e96ae552d852ee39ce08009079b76033fd3 Author: Caolán McNamara caol...@redhat.com Date: Fri Apr 17 14:23:45 2015 +0100 incredibly dubious hunk of code from commit 0415e2696156b25226f21085a0716187f83c2f4b Author: PriyankaGaikwad priyanka.gaik...@synerzip.com Date: Thu Feb 27 17:42:52 2014 +0530 fdo#73219 File corruption: Table in header Description: File corrupt due to the end tag /w:tc /w:tr /w:tbl are missing after roundtrip in header4.xml Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Reviewed on: https://gerrit.libreoffice.org/8378 Change-Id: Ib05a50b3b3beca6c744b93360f9341ddcaa1a22a Change-Id: I93ecadf7bfd2d19da33611e82ba95c4106bda2a5 diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index f65ba79..f5e9581 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -264,18 +264,9 @@ void DocxAttributeOutput::StartParagraph( ww8::WW8TableNodeInfo::Pointer_t pText { ww8::WW8TableNodeInfoInner::Pointer_t pInner( pTextNodeInfo-getInnerForDepth( nDepth ) ); -if (m_tableReference-m_pOldTablepInner m_tableReference-m_pOldTablepInner-getTable() == pInner-getTable() nCurrentDepth 1 nDepth != 1) -{ - m_tableReference-m_pOldTablepInner = pInner; - break; -} -else -{ StartTable( pInner ); StartTableRow( pInner ); StartTableCell( pInner ); -m_tableReference-m_pOldTablepInner = pInner; -} } m_tableReference-m_nTableDepth = nCurrentDepth; diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx index e3d2fbb..4da101b 100644 --- a/sw/source/filter/ww8/docxattributeoutput.hxx +++ b/sw/source/filter/ww8/docxattributeoutput.hxx @@ -130,8 +130,6 @@ struct TableReference /// Remember the current table depth. sal_uInt32 m_nTableDepth; -ww8::WW8TableNodeInfoInner::Pointer_t m_pOldTablepInner; - TableReference() : m_bTableCellOpen(false), m_bTableCellParaSdtOpen(false), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/compiler.cxx | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) New commits: commit c9519a210523c732188a494c14ac212db43463e5 Author: Eike Rathke er...@redhat.com Date: Fri Apr 17 12:00:18 2015 +0200 TableRef: handle unresolved column specifiers Change-Id: I8b4fa10da0a39df941f92b8bb074b9031f81fb8e diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx index 055bcd2..63f2dd5 100644 --- a/sc/source/core/tool/compiler.cxx +++ b/sc/source/core/tool/compiler.cxx @@ -3710,6 +3710,9 @@ bool ScCompiler::NextNewToken( bool bInArray ) { if (IsTableRefColumn( aOrg )) return true; +// Do not attempt to resolve as any other name. +aUpper = aOrg; // for ocBad +break; // do; create ocBad token or set error. } mbRewind = false; @@ -4859,8 +4862,7 @@ bool ScCompiler::HandleTableRef() pDBData-GetArea(aDBRange); aDBRange.aEnd.SetTab(aDBRange.aStart.Tab()); ScRange aRange( aDBRange); -ScTokenArray* pNew = new ScTokenArray(); -bool bAddRange = true; +sal_uInt16 nError = 0; bool bForwardToClose = false; ScTableRefToken::Item eItem = pTR-GetItem(); switch (eItem) @@ -4874,7 +4876,7 @@ bool ScCompiler::HandleTableRef() if (pDBData-HasTotals()) aRange.aEnd.IncRow(-1); if (aRange.aEnd.Row() aRange.aStart.Row()) -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4888,7 +4890,7 @@ bool ScCompiler::HandleTableRef() if (pDBData-HasHeader()) aRange.aEnd.SetRow( aRange.aStart.Row()); else -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4903,7 +4905,7 @@ bool ScCompiler::HandleTableRef() if (pDBData-HasTotals()) aRange.aEnd.IncRow(-1); if (aRange.aEnd.Row() aRange.aStart.Row()) -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4912,7 +4914,7 @@ bool ScCompiler::HandleTableRef() if (pDBData-HasTotals()) aRange.aStart.SetRow( aRange.aEnd.Row()); else -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4921,7 +4923,7 @@ bool ScCompiler::HandleTableRef() if (pDBData-HasHeader()) aRange.aStart.IncRow(); if (aRange.aEnd.Row() aRange.aStart.Row()) -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4933,7 +4935,7 @@ bool ScCompiler::HandleTableRef() aRange.aEnd.SetRow( aPos.Row()); } else -bAddRange = false; +nError = errNoRef; bForwardToClose = true; } break; @@ -4995,6 +4997,11 @@ bool ScCompiler::HandleTableRef() eState = sStop; } break; +case ocBad: +eState = sLast; +if (!nError) +nError = errNoName; +break; default: eState = sStop; } @@ -5005,7 +5012,8 @@ bool ScCompiler::HandleTableRef() } } while (eState != sStop); } -if (bAddRange) +ScTokenArray* pNew = new ScTokenArray(); +if (!nError) { if (bColumnRange) { @@ -5083,7 +5091,7 @@ bool ScCompiler::HandleTableRef() } else { -pTR-SetAreaRefRPN( pNew-Add( new FormulaErrorToken( errNoRef))); +pTR-SetAreaRefRPN( pNew-Add( new FormulaErrorToken( nError))); } while (nLevel-- 0) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90503] LibreOffice DOES NOT FULLY in Windows 10 Technical Preview (officially leaves in summer)
https://bugs.documentfoundation.org/show_bug.cgi?id=90503 vv...@yandex.ru changed: What|Removed |Added Attachment #114860|application/pdf |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90620] Something different than LibreOffice...
https://bugs.documentfoundation.org/show_bug.cgi?id=90620 --- Comment #5 from jlbr...@portugalmail.com --- My point is: having a free office suite is good, but the first thing that is needed, before an office suite, is an OS...why not do a free LibreOS, with a portable version to carry in a USB drive, then?... If LibreOffice was made similar to Microsoft Office and free so we didn't have to buy MSOffice, why not do something similar in the OS area as well, dedicated to those who understand Windows and/or Mac and don't to buy it, but don't understand Linux to decide themselves to use it? (In reply to Adolfo Jayme from comment #4) I don’t see the point of your suggestion. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90503] LibreOffice DOES NOT FULLY in Windows 10 Technical Preview (officially leaves in summer)
https://bugs.documentfoundation.org/show_bug.cgi?id=90503 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- maceleiro: except if there was no previous LibreOffice/OpenOffice install on your machine, could you rename your LO directory profile (see https://wiki.documentfoundation.org/User_Profile#Windows) and give it a new try? If you still reproduce this, at least, we'll be sure it's not due to some specific customization. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] mso-dumper.git: 10 commits - doc-dump.py emf-dump.py Makefile msodumper/docdirstream.py msodumper/docrecord.py msodumper/docstream.py msodumper/msometa.py msodumper/vsdstream.py
Makefile |1 doc-dump.py |3 emf-dump.py |3 msodumper/docdirstream.py |3 msodumper/docrecord.py|7 - msodumper/docstream.py|8 + msodumper/msometa.py | 314 ++ msodumper/vsdstream.py| 293 -- test/doc/test.py |6 9 files changed, 337 insertions(+), 301 deletions(-) New commits: commit 34d3f8c16849f5a4c91d2a350f81a8c78f1539e7 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 15:31:25 2015 +0200 DefTableShd80Operand.dump: Unused variable 'i' diff --git a/msodumper/docrecord.py b/msodumper/docrecord.py index 1586c48..d904d34 100644 --- a/msodumper/docrecord.py +++ b/msodumper/docrecord.py @@ -624,13 +624,14 @@ class Shd80(DOCDirStream): The Shd80 structure specifies the colors and pattern that are used for background shading. size = 2 # in bytes, see 2.9.245 -def __init__(self, parent): +def __init__(self, parent, index): DOCDirStream.__init__(self, parent.bytes) self.pos = parent.pos self.parent = parent +self.index = index def dump(self): -print 'shd80 type=Shd80 offset=%d' % self.pos +print 'shd80 type=Shd80 offset=%d index=%d' % (self.pos, self.index) buf = self.readuInt16() self.printAndSet(icoFore, buf 0x001f, dict=Ico) # 1..5th bits self.printAndSet(icoBack, (buf 0x03e0) 5, dict=Ico) # 6..10th bits @@ -650,7 +651,7 @@ class DefTableShd80Operand(DOCDirStream): print 'defTableShd80Operand type=DefTableShd80Operand offset=%d' % self.pos self.printAndSet(cb, self.readuInt8()) for i in xrange(self.cb / Shd80.size): -Shd80(self).dump() +Shd80(self, i).dump() print '/defTableShd80Operand' commit 06ab6a09468b8400bc1622f055505bb640c620b6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 15:29:15 2015 +0200 DOCDirStream.getString: Unused variable 'pos' diff --git a/msodumper/docdirstream.py b/msodumper/docdirstream.py index 88a91d6..7b9e8de 100644 --- a/msodumper/docdirstream.py +++ b/msodumper/docdirstream.py @@ -153,8 +153,7 @@ class DOCDirStream: return (self.quoteAttr(globals.encodeName(globals.getUTF8FromUTF16(.join(map(lambda x: chr(x), bytes), pos) def getString(self, limit=None): -ret, pos = self.__getString(limit) -return ret +return self.__getString(limit)[0] def readString(self, limit=None): ret, pos = self.__getString(limit) commit f7031b02e6d97fd926d847397050c5736d9013e1 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 15:28:45 2015 +0200 emf-dump: Unused variable 'exname' diff --git a/emf-dump.py b/emf-dump.py index 1023a9f..1e8f3d3 100755 --- a/emf-dump.py +++ b/emf-dump.py @@ -25,8 +25,7 @@ class EMFDumper: def main(args): -exname, args = args[0], args[1:] -dumper = EMFDumper(args[0]) +dumper = EMFDumper(args[1]) dumper.dump() if __name__ == '__main__': commit f6a9a2b35c10b967efda2d792686dc10899268e7 Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 15:28:06 2015 +0200 doc-dump: Unused variable 'exname' diff --git a/doc-dump.py b/doc-dump.py index ab57719..a030fdd 100755 --- a/doc-dump.py +++ b/doc-dump.py @@ -33,9 +33,8 @@ class DOCDumper: def main(args): -exname, args = args[0], args[1:] params = globals.Params() -dumper = DOCDumper(args[0], params) +dumper = DOCDumper(args[1], params) dumper.dump() if __name__ == '__main__': commit f1f9e164a48fc29244d45269ef913c01b12f Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Apr 17 15:11:23 2015 +0200 docstream: hook into msometa diff --git a/msodumper/docstream.py b/msodumper/docstream.py index a30859f..b455cea 100644 --- a/msodumper/docstream.py +++ b/msodumper/docstream.py @@ -14,6 +14,8 @@ import globals import sys import os import bisect +from msometa import SummaryInformationStream +from msometa import DocumentSummaryInformationStream class DOCFile: @@ -54,8 +56,12 @@ class DOCFile: def getStreamFromBytes(self, name, bytes): if name == WordDocument: return WordDocumentStream(bytes, self.params, doc=self) -if name in (0Table, 1Table): +elif name in (0Table, 1Table): return TableStream(bytes, self.params, name, doc=self) +elif name == \x05SummaryInformation: +return SummaryInformationStream(bytes, self.params, doc=self) +elif name == \x05DocumentSummaryInformation: +return DocumentSummaryInformationStream(bytes, self.params, doc=self) else: return DOCDirStream(bytes, self.params, name, doc=self) diff --git a/test/doc/test.py b/test/doc/test.py index c63bc11..55d9819 100755 --- a/test/doc/test.py +++ b/test/doc/test.py @@ -157,6 +157,12 @@
[Libreoffice-bugs] [Bug 90659] FILESAVE: Libreoffice Calc .ods format very slow when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=90659 --- Comment #3 from Jeffrey jeffreyzheng...@gmail.com --- I think I jumped the gun by saying the issue was fixed by the upgrade. The issue still exists. After I added another sheet, the file save issue came back. Sorry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48381] Pasting a formula in a full column appears to hang Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=48381 --- Comment #6 from clem clement.marsh...@free.fr --- And yes, it persists in 4.4. I have reproduced them today 2015-04-17 in Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale : fr_ I hope it helps. I have software development training but no practice in 20 years, if there is anything I can do more, i'd be willing to help but i'm a bit scared to dive in LO code and mess things around ! On Mac intel 64b / Yosemite / Xcode installed -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90070] Adding a border and spacing to content shrinks the size on an image
https://bugs.documentfoundation.org/show_bug.cgi?id=90070 --- Comment #4 from Jay Philips philip...@hotmail.com --- So it seem this not only affects images, it also affects OLE objects like charts, and it also effects compatibility. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document
https://bugs.documentfoundation.org/show_bug.cgi?id=90640 Paddy Landau pa...@landau.ws changed: What|Removed |Added Keywords||regression --- Comment #5 from Paddy Landau pa...@landau.ws --- By the way, as this is a regression, shouldn't the importance be rated as high? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90656] Metadata in Word 6 imported with wrong encoding
https://bugs.documentfoundation.org/show_bug.cgi?id=90656 MM plokk...@fastmail.fm changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|4.4.2.2 release |4.1.6.2 release Ever confirmed|0 |1 --- Comment #3 from MM plokk...@fastmail.fm --- Unconfirmed for v4.3.7.1 under windows 7 x64. Confirmed for v4.1.6.2 under mint 16 x64. Confirmed for v4.4.2.2 under mint 17.1 x64. Looks like linux only ?! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 Jay Philips philip...@hotmail.com changed: What|Removed |Added Depends on||87360, 90070 --- Comment #106 from Jay Philips philip...@hotmail.com --- Bugs affecting Writer's embedding of images, OLEs, etc. when a border is added around them, which also causes compatibility problems. Bug 87360: Image/OLE should have 'spacing to content' disabled Bug 90070: Borders shrink image/OLE size rather than appearing on the outsides -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-ux-advise] [Bug 87360] Spacing to content should be disabled for images
https://bugs.documentfoundation.org/show_bug.cgi?id=87360 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||75025 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 Jay Philips philip...@hotmail.com changed: What|Removed |Added Depends on||87360, 90070 --- Comment #106 from Jay Philips philip...@hotmail.com --- Bugs affecting Writer's embedding of images, OLEs, etc. when a border is added around them, which also causes compatibility problems. Bug 87360: Image/OLE should have 'spacing to content' disabled Bug 90070: Borders shrink image/OLE size rather than appearing on the outsides -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87360] Spacing to content should be disabled for images
https://bugs.documentfoundation.org/show_bug.cgi?id=87360 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||75025 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/engine3d/dragmt3d.cxx |5 - svx/source/engine3d/e3dundo.cxx |4 svx/source/engine3d/obj3d.cxx|3 --- svx/source/engine3d/scene3d.cxx |2 -- svx/source/svdraw/svdundo.cxx|4 5 files changed, 18 deletions(-) New commits: commit 7bcf9131032cbcdb162f33d03230e43d4f1db2aa Author: Tor Lillqvist t...@collabora.com Date: Fri Apr 17 15:00:27 2015 +0300 WaE: unused variables Change-Id: I3b0ed8a6c8e5d13b9236ee1a1337820c3cbce9ac diff --git a/svx/source/engine3d/dragmt3d.cxx b/svx/source/engine3d/dragmt3d.cxx index 39dd69f..e02a6a7 100644 --- a/svx/source/engine3d/dragmt3d.cxx +++ b/svx/source/engine3d/dragmt3d.cxx @@ -159,7 +159,6 @@ bool E3dDragMethod::EndSdrDrag(bool /*bCopy*/) for(nOb=0;nObnCnt;nOb++) { E3dDragMethodUnit rCandidate = maGrp[nOb]; -E3DModifySceneSnapRectUpdater aUpdater(rCandidate.mp3DObj); rCandidate.mp3DObj-SetTransform(rCandidate.maTransform); if( bUndo ) { @@ -187,7 +186,6 @@ void E3dDragMethod::CancelSdrDrag() { // Restore transformation E3dDragMethodUnit rCandidate = maGrp[nOb]; -E3DModifySceneSnapRectUpdater aUpdater(rCandidate.mp3DObj); rCandidate.mp3DObj-SetTransform(rCandidate.maInitTransform); } } @@ -408,7 +406,6 @@ void E3dDragRotate::MoveSdrDrag(const Point rPnt) if(mbMoveFull) { -E3DModifySceneSnapRectUpdater aUpdater(rCandidate.mp3DObj); rCandidate.mp3DObj-SetTransform(rCandidate.maTransform); } else @@ -558,7 +555,6 @@ void E3dDragMove::MoveSdrDrag(const Point rPnt) if(mbMoveFull) { -E3DModifySceneSnapRectUpdater aUpdater(rCandidate.mp3DObj); rCandidate.mp3DObj-SetTransform(rCandidate.maTransform); } else @@ -677,7 +673,6 @@ void E3dDragMove::MoveSdrDrag(const Point rPnt) if(mbMoveFull) { -E3DModifySceneSnapRectUpdater aUpdater(rCandidate.mp3DObj); rCandidate.mp3DObj-SetTransform(rCandidate.maTransform); } else diff --git a/svx/source/engine3d/e3dundo.cxx b/svx/source/engine3d/e3dundo.cxx index 9d6dcfc..4f7a6dd 100644 --- a/svx/source/engine3d/e3dundo.cxx +++ b/svx/source/engine3d/e3dundo.cxx @@ -49,7 +49,6 @@ E3dRotateUndoAction::~E3dRotateUndoAction () void E3dRotateUndoAction::Undo () { -E3DModifySceneSnapRectUpdater aUpdater(pMy3DObj); pMy3DObj-SetTransform(aMyOldRotation); } @@ -57,7 +56,6 @@ void E3dRotateUndoAction::Undo () void E3dRotateUndoAction::Redo () { -E3DModifySceneSnapRectUpdater aUpdater(pMy3DObj); pMy3DObj-SetTransform(aMyNewRotation); } @@ -83,13 +81,11 @@ E3dAttributesUndoAction::~E3dAttributesUndoAction() void E3dAttributesUndoAction::Undo() { -E3DModifySceneSnapRectUpdater aUpdater(pObject); pObject-SetMergedItemSetAndBroadcast(aOldSet); } void E3dAttributesUndoAction::Redo() { -E3DModifySceneSnapRectUpdater aUpdater(pObject); pObject-SetMergedItemSetAndBroadcast(aNewSet); } diff --git a/svx/source/engine3d/obj3d.cxx b/svx/source/engine3d/obj3d.cxx index ef50b3d..a701ad9 100644 --- a/svx/source/engine3d/obj3d.cxx +++ b/svx/source/engine3d/obj3d.cxx @@ -374,7 +374,6 @@ void E3dObject::NbcResize(const Point rRef, const Fraction xFact, const Fracti basegfx::B3DHomMatrix mObjTrans(GetTransform()); mObjTrans *= mTrans; -E3DModifySceneSnapRectUpdater aUpdater(this); SetTransform(mObjTrans); } } @@ -427,7 +426,6 @@ void E3dObject::NbcMove(const Size rSize) basegfx::B3DHomMatrix aTranslate; aTranslate.translate(aMove.getX() - aPos.getX(), aMove.getY() - aPos.getY(), aMove.getZ() - aPos.getZ()); -E3DModifySceneSnapRectUpdater aUpdater(pScene); SetTransform(aTranslate * GetTransform()); } } @@ -739,7 +737,6 @@ void E3dObject::SaveGeoData(SdrObjGeoData rGeo) const void E3dObject::RestGeoData(const SdrObjGeoData rGeo) { maLocalBoundVol = static_castconst E3DObjGeoData (rGeo).maLocalBoundVol; -E3DModifySceneSnapRectUpdater aUpdater(this); NbcSetTransform(static_castconst E3DObjGeoData (rGeo).maTransformation); SdrAttrObj::RestGeoData (rGeo); } diff --git a/svx/source/engine3d/scene3d.cxx b/svx/source/engine3d/scene3d.cxx index 2876b4d..6140815 100644 --- a/svx/source/engine3d/scene3d.cxx +++ b/svx/source/engine3d/scene3d.cxx @@ -397,8 +397,6 @@ E3dScene* E3dScene::GetScene() const void E3dScene::removeAllNonSelectedObjects() { -E3DModifySceneSnapRectUpdater aUpdater(this); - for(size_t a = 0; a maSubList.GetObjCount(); ++a) { SdrObject* pObj = maSubList.GetObj(a); diff --git a/svx/source/svdraw/svdundo.cxx
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - desktop/source
desktop/source/deployment/gui/dp_gui_dialog2.cxx |6 +++--- desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx |8 +++- desktop/source/deployment/gui/dp_gui_extlistbox.cxx|4 ++-- desktop/source/deployment/gui/dp_gui_service.cxx |5 ++--- desktop/source/deployment/gui/dp_gui_theextmgr.cxx |4 ++-- desktop/source/deployment/gui/dp_gui_updatedialog.cxx |2 +- desktop/source/deployment/gui/license_dialog.cxx |3 ++- desktop/source/splash/splash.cxx |2 +- 8 files changed, 16 insertions(+), 18 deletions(-) New commits: commit 0703fc22519b391cece54f9d67012cffd9867765 Author: Michael Meeks michael.me...@collabora.com Date: Fri Apr 17 11:22:09 2015 +0100 desktop: convert new to ::Create. Change-Id: I114ab23302970ce0abe551ffd693e92b0f4ae8c5 diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx index 1313475..63d0986 100644 --- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx +++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx @@ -166,9 +166,9 @@ void ExtBoxWithBtns_Impl::InitFromDialog(ExtMgrDialog *pParentDialog) m_pParent = pParentDialog; -m_pOptionsBtn = new PushButton( this, WB_TABSTOP ); -m_pEnableBtn = new PushButton( this, WB_TABSTOP ); -m_pRemoveBtn = new PushButton( this, WB_TABSTOP ); +m_pOptionsBtn = VclPtrPushButton::Create( this, WB_TABSTOP ); +m_pEnableBtn = VclPtrPushButton::Create( this, WB_TABSTOP ); +m_pRemoveBtn = VclPtrPushButton::Create( this, WB_TABSTOP ); SetHelpId( HID_EXTENSION_MANAGER_LISTBOX ); m_pOptionsBtn-SetHelpId( HID_EXTENSION_MANAGER_LISTBOX_OPTIONS ); diff --git a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx index 1b2136d..29d3c90 100644 --- a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx +++ b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx @@ -814,7 +814,7 @@ void ExtensionCmdQueue::Thread::execute() const SolarMutexGuard guard; ScopedVclPtrMessageDialog box( -new MessageDialog(currentCmdEnv-activeDialog(), msg)); + VclPtrMessageDialog::Create(currentCmdEnv-activeDialog(), msg)); if ( m_pDialogHelper ) box-SetText( m_pDialogHelper-getWindow()-GetText() ); box-Execute(); @@ -923,12 +923,10 @@ void ExtensionCmdQueue::Thread::_removeExtension( ::rtl::Reference ProgressCmdE void ExtensionCmdQueue::Thread::_checkForUpdates( const std::vectoruno::Referencedeployment::XPackage vExtensionList ) { -ScopedVclPtrUpdateDialog pUpdateDialog; -std::vector UpdateData vData; - const SolarMutexGuard guard; -pUpdateDialog = new UpdateDialog( m_xContext, m_pDialogHelper? m_pDialogHelper-getWindow() : NULL, vExtensionList, vData ); +std::vector UpdateData vData; +ScopedVclPtrInstanceUpdateDialog pUpdateDialog( m_xContext, m_pDialogHelper? m_pDialogHelper-getWindow() : nullptr, vExtensionList, vData ); pUpdateDialog-notifyMenubar( true, false ); // prepare the checking, if there updates to be notified via menu bar icon diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx index 6eef818..50d5156 100644 --- a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx +++ b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx @@ -201,7 +201,7 @@ void ExtensionBox_Impl::Init() { SetHelpId( HID_EXTENSION_MANAGER_LISTBOX ); -m_pScrollBar = new ScrollBar( this, WB_VERT ); +m_pScrollBar = VclPtrScrollBar::Create( this, WB_VERT ); m_pScrollBar-SetScrollHdl( LINK( this, ExtensionBox_Impl, ScrollHdl ) ); m_pScrollBar-EnableDrag(); @@ -544,7 +544,7 @@ void ExtensionBox_Impl::DrawRow( const Rectangle rRect, const TEntry_Impl rEnt // Init publisher link here if ( !rEntry-m_pPublisher !rEntry-m_sPublisher.isEmpty() ) { -rEntry-m_pPublisher = new FixedHyperlink( this ); +rEntry-m_pPublisher = VclPtrFixedHyperlink::Create( this ); rEntry-m_pPublisher-SetBackground(); rEntry-m_pPublisher-SetPaintTransparent( true ); rEntry-m_pPublisher-SetURL( rEntry-m_sPublisherURL ); diff --git a/desktop/source/deployment/gui/dp_gui_service.cxx b/desktop/source/deployment/gui/dp_gui_service.cxx index badb58f..f07042d 100644 --- a/desktop/source/deployment/gui/dp_gui_service.cxx +++ b/desktop/source/deployment/gui/dp_gui_service.cxx @@ -223,9 +223,8 @@ void ServiceImpl::startExecuteModal( catch (const Exception exc) { if (bAppUp) { const SolarMutexGuard guard; -VclPtrMessageDialog box( -new MessageDialog(Application::GetActiveTopWindow(), -
[Libreoffice-bugs] [Bug 90666] FILEOPEN takes 60-70 seconds for LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=90666 --- Comment #1 from MM plokk...@fastmail.fm --- (In reply to markus.kramer from comment #0) I killed LibreOffice Draw about 4 times and removed the .~lock.___.odg# files. I have reinstalled LibreOffice 4.4.2.2 On MacOS 10.6, the same file is opening fine. What else can I do? You can try to rename your userprofile: https://wiki.documentfoundation.org/UserProfile#Resolving_corruption_in_the_user_profile -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90673] FILESAVE : PPTX Paragraph text direction right-to-left is not exported
https://bugs.documentfoundation.org/show_bug.cgi?id=90673 Priyanka Gaikwad priyanka.gaik...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |priyanka.gaikwad@synerzip.c |desktop.org |om -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90673] New: FILESAVE : PPTX Paragraph text direction right-to-left is not exported
https://bugs.documentfoundation.org/show_bug.cgi?id=90673 Bug ID: 90673 Summary: FILESAVE : PPTX Paragraph text direction right-to-left is not exported Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: priyanka.gaik...@synerzip.com Created attachment 114856 -- https://bugs.documentfoundation.org/attachment.cgi?id=114856action=edit right-to-left text Problem description: xml tag 'rtl' is not exported for paragraph Steps to reproduce: 1. Open .pptx (attached) 2. Save as .pptx 3. Open saved pptx Current behavior: After RT 'rtl' tag of a:pPr are not exported Expected behaviour: After RT 'rtl' tag of a:pPr should export -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - include/svx sw/source
include/svx/e3ditem.hxx |2 +- include/svx/e3dsceneupdater.hxx |2 +- include/svx/e3dundo.hxx |6 +++--- include/svx/extedit.hxx |4 ++-- include/svx/extrud3d.hxx |2 +- include/svx/extrusionbar.hxx |2 +- sw/source/filter/ww8/WW8TableInfo.hxx |2 +- 7 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 06a9243ff34f0666141c9eabb322a2eedb4c331a Author: Caolán McNamara caol...@redhat.com Date: Fri Apr 17 12:16:17 2015 +0100 it has always been the case that RowSpans are signed we just get away with this because we cast it to signed before use in ww8 Change-Id: I646ea3a0eb84923dd9835f18356d67f4f72ba18d diff --git a/sw/source/filter/ww8/WW8TableInfo.hxx b/sw/source/filter/ww8/WW8TableInfo.hxx index 34d56b3..ab5ff6c 100644 --- a/sw/source/filter/ww8/WW8TableInfo.hxx +++ b/sw/source/filter/ww8/WW8TableInfo.hxx @@ -44,7 +44,7 @@ typedef ::std::vectorconst SwTableBox * TableBoxVector; typedef boost::shared_ptrTableBoxVector TableBoxVectorPtr; typedef ::std::vectorsal_uInt32 GridCols; typedef boost::shared_ptrGridCols GridColsPtr; -typedef ::std::vectorsal_uInt32 RowSpans; +typedef ::std::vectorsal_Int32 RowSpans; typedef boost::shared_ptrRowSpans RowSpansPtr; typedef ::std::vectorsal_uInt32 Widths; typedef boost::shared_ptrWidths WidthsPtr; commit 350f11a8bd089698e004e0f288417108131ce74e Author: Caolán McNamara caol...@redhat.com Date: Thu Apr 16 09:44:09 2015 +0100 add some SAL_WARN_UNUSED Change-Id: I41ba1bed4f49a122a15213edf41e094254bfb282 diff --git a/include/svx/e3ditem.hxx b/include/svx/e3ditem.hxx index 6b4c8ff..15dd162 100644 --- a/include/svx/e3ditem.hxx +++ b/include/svx/e3ditem.hxx @@ -26,7 +26,7 @@ class SvStream; -class SVX_DLLPUBLIC SvxB3DVectorItem : public SfxPoolItem +class SVX_DLLPUBLIC SAL_WARN_UNUSED SvxB3DVectorItem : public SfxPoolItem { basegfx::B3DVector aVal; diff --git a/include/svx/e3dsceneupdater.hxx b/include/svx/e3dsceneupdater.hxx index 54e5dcc..3208eb8 100644 --- a/include/svx/e3dsceneupdater.hxx +++ b/include/svx/e3dsceneupdater.hxx @@ -42,7 +42,7 @@ namespace drawinglayer { namespace geometry { // 3D content and tu use it. This is only wanted if changes to the scene's // content are intended to change the scene's 2D geometry attributes -class SVX_DLLPUBLIC E3DModifySceneSnapRectUpdater +class SVX_DLLPUBLIC SAL_WARN_UNUSED E3DModifySceneSnapRectUpdater { // the scene which may be changed. This gets set to the outmost scene // of the to-be-changed 3D object when the scene has a 3d transformation diff --git a/include/svx/e3dundo.hxx b/include/svx/e3dundo.hxx index 40a22fa..29e2eb5 100644 --- a/include/svx/e3dundo.hxx +++ b/include/svx/e3dundo.hxx @@ -29,7 +29,7 @@ |* Base class for all 3D undo actions. |* \/ -class E3dUndoAction : public SdrUndoAction +class SAL_WARN_UNUSED E3dUndoAction : public SdrUndoAction { protected : @@ -54,7 +54,7 @@ class E3dUndoAction : public SdrUndoAction |* Undo for 3D rotation through the rotation matrices |* \/ -class E3dRotateUndoAction : public E3dUndoAction +class SAL_WARN_UNUSED E3dRotateUndoAction : public E3dUndoAction { basegfx::B3DHomMatrix aMyOldRotation; basegfx::B3DHomMatrix aMyNewRotation; @@ -83,7 +83,7 @@ class E3dRotateUndoAction : public E3dUndoAction |* Undo for 3D attributes (implemented using Set3DAttributes()) |* \/ -class SVX_DLLPUBLIC E3dAttributesUndoAction : public SdrUndoAction +class SVX_DLLPUBLIC SAL_WARN_UNUSED E3dAttributesUndoAction : public SdrUndoAction { using SdrUndoAction::Repeat; diff --git a/include/svx/extedit.hxx b/include/svx/extedit.hxx index 65e178d..ab3e4cf 100644 --- a/include/svx/extedit.hxx +++ b/include/svx/extedit.hxx @@ -19,7 +19,7 @@ class Graphic; class GraphicObject; class FileChangedChecker; -class SVX_DLLPUBLIC ExternalToolEdit +class SVX_DLLPUBLIC SAL_WARN_UNUSED ExternalToolEdit { protected: OUString m_aFileName; @@ -42,7 +42,7 @@ public: class FmFormView; class SdrObject; -class SVX_DLLPUBLIC SdrExternalToolEdit +class SVX_DLLPUBLIC SAL_WARN_UNUSED SdrExternalToolEdit : public ExternalToolEdit , public SfxListener { diff --git a/include/svx/extrud3d.hxx b/include/svx/extrud3d.hxx index cdade62..3982014 100644 --- a/include/svx/extrud3d.hxx +++ b/include/svx/extrud3d.hxx @@ -29,7 +29,7 @@ |* \/ -class SVX_DLLPUBLIC E3dExtrudeObj : public E3dCompoundObject +class SVX_DLLPUBLIC SAL_WARN_UNUSED E3dExtrudeObj : public E3dCompoundObject { private: // to allow sdr::properties::E3dExtrudeProperties access to SetGeometryValid() diff --git
[Libreoffice-bugs] [Bug 90070] Adding a border and spacing to content shrinks the size on an image
https://bugs.documentfoundation.org/show_bug.cgi?id=90070 Jay Philips philip...@hotmail.com changed: What|Removed |Added Blocks||75025 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - sw/source
sw/source/uibase/utlui/condedit.cxx |6 ++ sw/source/uibase/utlui/numfmtlb.cxx | 19 +++ 2 files changed, 25 insertions(+) New commits: commit 5459c4a7312ce7bc0326978f4164441e76e5d5a4 Author: Noel Grandin n...@peralex.com Date: Fri Apr 17 13:52:23 2015 +0200 restore these extern methods, they are used by VclBuilder Change-Id: I4c20e941975b6eb872729b351eb1af901adba649 diff --git a/sw/source/uibase/utlui/condedit.cxx b/sw/source/uibase/utlui/condedit.cxx index ca0c252..b15694b 100644 --- a/sw/source/uibase/utlui/condedit.cxx +++ b/sw/source/uibase/utlui/condedit.cxx @@ -34,6 +34,12 @@ ConditionEdit::ConditionEdit(vcl::Window* pParent, WinBits nStyle) { } +extern C SAL_DLLPUBLIC_EXPORT vcl::Window* SAL_CALL makeConditionEdit(vcl::Window *pParent, VclBuilder::stringmap rMap) +{ +VclBuilder::ensureDefaultWidthChars(rMap); +return new ConditionEdit(pParent, WB_LEFT|WB_VCENTER|WB_BORDER|WB_3DLOOK); +} + // Drop possible, respectively format known? sal_Int8 ConditionEdit::AcceptDrop( const AcceptDropEvent /*rEvt*/ ) diff --git a/sw/source/uibase/utlui/numfmtlb.cxx b/sw/source/uibase/utlui/numfmtlb.cxx index 7710c70..64590d8 100644 --- a/sw/source/uibase/utlui/numfmtlb.cxx +++ b/sw/source/uibase/utlui/numfmtlb.cxx @@ -68,6 +68,25 @@ NumFormatListBox::NumFormatListBox(vcl::Window* pWin, WinBits nStyle) : Init(css::util::NumberFormat::NUMBER, true); } +extern C SAL_DLLPUBLIC_EXPORT vcl::Window* SAL_CALL makeNumFormatListBox(vcl::Window *pParent, VclBuilder::stringmap rMap) +{ +WinBits nBits = WB_LEFT|WB_VCENTER|WB_3DLOOK; + +bool bDropdown = VclBuilder::extractDropdown(rMap); + +if (bDropdown) +nBits |= WB_DROPDOWN; +else +nBits |= WB_BORDER; + +NumFormatListBox* pListBox = new NumFormatListBox(pParent, nBits|WB_SIMPLEMODE); + +if (bDropdown) +pListBox-EnableAutoSize(true); + +return pListBox; +} + void NumFormatListBox::Init(short nFormatType, bool bUsrFmts) { SwView *pView = GetView(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/sidebar/SidebarChildWindow.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 0bdfe0f946042cdd59468d96a756f28db7cac7fe Author: Jan Holesovsky ke...@collabora.com Date: Fri Apr 17 14:02:22 2015 +0200 draw sidebar: With the recent Jay's fixes, default to expanded sidebar too. Change-Id: I5a05b116fbaac553adf7a87f88cf4bab19df39f0 diff --git a/sfx2/source/sidebar/SidebarChildWindow.cxx b/sfx2/source/sidebar/SidebarChildWindow.cxx index 22d71d3..4d4730d 100644 --- a/sfx2/source/sidebar/SidebarChildWindow.cxx +++ b/sfx2/source/sidebar/SidebarChildWindow.cxx @@ -50,10 +50,10 @@ SidebarChildWindow::SidebarChildWindow ( SfxDockingWindow* pDockingParent = dynamic_castSfxDockingWindow*(pWindow); if (pDockingParent != NULL) { -if (pInfo pInfo-aExtraString.isEmpty() pInfo-aModule != simpress) +if (pInfo pInfo-aExtraString.isEmpty() pInfo-aModule != sdraw pInfo-aModule != simpress) { // When this is the first start (never had the sidebar open yet), -// default to non-expanded sidebars in Writer, Calc, and Draw +// default to non-expanded sidebars in Writer and Calc. // // HACK: unfortunately I haven't found a clean solution to do // this, so do it this way: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/tabpages/tpshadow.cxx |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit 466d0f2cb2b2bb7fba306ab089be7f648578474e Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 17 14:09:46 2015 +0200 Clean up conversion from TriState to bool to witness, in Draw select multiple rectangles, with and without shadows, then Format - Area... - Shadow Change-Id: Ia1d042f0e3e99bb55228c558568c96b113edfe00 diff --git a/cui/source/tabpages/tpshadow.cxx b/cui/source/tabpages/tpshadow.cxx index b163ceb..fe94d0e 100644 --- a/cui/source/tabpages/tpshadow.cxx +++ b/cui/source/tabpages/tpshadow.cxx @@ -257,10 +257,14 @@ bool SvxShadowTabPage::FillItemSet( SfxItemSet* rAttrs ) { const SfxPoolItem* pOld = NULL; -TriState eState = m_pTsbShowShadow-GetState(); if( m_pTsbShowShadow-IsValueChangedFromSaved() ) { -SdrOnOffItem aItem( makeSdrShadowItem(sal::static_int_cast sal_Bool ( eState )) ); +TriState eState = m_pTsbShowShadow-GetState(); +assert(eState != TRISTATE_INDET); +// given how m_pTsbShowShadow is set up and saved in Reset(), +// eState == TRISTATE_INDET would imply +// !IsValueChangedFromSaved() +SdrOnOffItem aItem( makeSdrShadowItem(eState == TRISTATE_TRUE) ); pOld = GetOldItem( *rAttrs, SDRATTR_SHADOW ); if ( !pOld || !( *static_castconst SdrOnOffItem*(pOld) == aItem ) ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89882] LibreOffice crashes when I try to save a huge file on Mac OSX
https://bugs.documentfoundation.org/show_bug.cgi?id=89882 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|LibreOffice crashes when I |LibreOffice crashes when I |try to save a huge file on |try to save a huge file on |Mac OS X 10.9.5 |Mac OSX -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90640] Text frame background graphic set to 100% transparency on saving a document
https://bugs.documentfoundation.org/show_bug.cgi?id=90640 Paddy Landau pa...@landau.ws changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=82 ||784 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90674] New: Chart does not show amended state unless moved
https://bugs.documentfoundation.org/show_bug.cgi?id=90674 Bug ID: 90674 Summary: Chart does not show amended state unless moved Product: LibreOffice Version: 4.3.6.2 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jcarricksm...@gmail.com I double-click on a chart on a Calc sheet and update the data range to add a new line to the chart (line graph). When the chart object loses focus the content is as before editing. Double clicking the chart again will show the correct/new version. Also, when the chart data is changed the same situation can occur. Moving the chart object on the Calc sheet will cause the chart to be redrawn in the new version and appear correctly when it has lost focus. Version: 4.3.6.2 Build ID: 430m0(Build:2) O/S: openSUSE 13.2 uname -a output: Linux jl64.site 3.16.7-13-desktop #1 SMP PREEMPT Wed Mar 18 17:31:15 UTC 2015 (ba2afab) x86_64 x86_64 x86_64 GNU/Linux Now I know about it the workaround is easy! Best wishes John -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90590] Unable to set specific character spacing to 'space' character
https://bugs.documentfoundation.org/show_bug.cgi?id=90590 --- Comment #6 from Martin Delille mar...@phonations.com --- You're describing exactly the step I'm doing so I don't understand why you're not reproducting the bug. How can we investigate further? I can show you via teamviewer or any remote access software you might consider? If you want we can chat on my irc: phnt.io / #hackstack -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90555] UI: Formula Editor allows As character formula object to be repositioned in the veritcal
https://bugs.documentfoundation.org/show_bug.cgi?id=90555 --- Comment #2 from Gordo gordon1dr...@yahoo.com --- Created attachment 114857 -- https://bugs.documentfoundation.org/attachment.cgi?id=114857action=edit screenshot1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90555] UI: Formula Editor allows As character formula object to be repositioned in the veritcal
https://bugs.documentfoundation.org/show_bug.cgi?id=90555 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90656] Metadata in Word 6 imported with wrong encoding
https://bugs.documentfoundation.org/show_bug.cgi?id=90656 --- Comment #4 from Karl Ove Hufthammer k...@huftis.org --- MM, that’s a clue. It looks like it is not OS-specific, but *locale*-specific. If I change my locale from the default UTF-8 locale to an ISO 8859-1 locale, for example with: export LC_ALL=nn_NO.latin1 (and even ‘export LC_ALL=C’ seems to work) the characters are correctly rendered. I guess the Word 6.0 document is encoded as Windows-1252. But LibreOffice incorrectly treats the document properties as being in the user’s locale (while normal body text is correctly interpreted as being in Windows-1252, since non-ASCII characters work fine there). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/quartz
vcl/quartz/salbmp.cxx | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) New commits: commit d457c25c491267999b1f82f2b4f76f7ccbe9cf37 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Apr 17 16:16:41 2015 +0200 Blind fix for ImplPixelFormat16 As pointed out by tml on IRC, its implementation looks completely bogus, and together with the previous 40a26be24bd64a6c7c8cc98228fd440c8b9323b5 loplugin:implicitboolconversion gold that gives rise to the suspicion that the class is effectively unused anyway. Change-Id: If5fa5cdd1dac51f10dba7c77ad9975ee61ccc8be diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx index a0e5ca4..2bb7b29 100644 --- a/vcl/quartz/salbmp.cxx +++ b/vcl/quartz/salbmp.cxx @@ -334,12 +334,10 @@ namespace { class ImplPixelFormat { -protected: -sal_uInt8* pData; public: static ImplPixelFormat* GetFormat( sal_uInt16 nBits, const BitmapPalette rPalette ); -virtual void StartLine( sal_uInt8* pLine ) { pData = pLine; } +virtual void StartLine( sal_uInt8* pLine ) = 0; virtual void SkipPixel( sal_uInt32 nPixel ) = 0; virtual ColorData ReadPixel() = 0; virtual void WritePixel( ColorData nColor ) = 0; @@ -349,7 +347,9 @@ public: class ImplPixelFormat32 : public ImplPixelFormat // currently ARGB-format for 32bit depth { +sal_uInt8* pData; public: +virtual void StartLine( sal_uInt8* pLine ) SAL_OVERRIDE { pData = pLine; } virtual void SkipPixel( sal_uInt32 nPixel ) SAL_OVERRIDE { pData += nPixel 2; @@ -372,7 +372,9 @@ public: class ImplPixelFormat24 : public ImplPixelFormat // currently BGR-format for 24bit depth { +sal_uInt8* pData; public: +virtual void StartLine( sal_uInt8* pLine ) SAL_OVERRIDE { pData = pLine; } virtual void SkipPixel( sal_uInt32 nPixel ) SAL_OVERRIDE { pData += (nPixel 1) + nPixel; @@ -394,13 +396,12 @@ public: class ImplPixelFormat16 : public ImplPixelFormat // currently R5G6B5-format for 16bit depth { -protected: -sal_uInt16* pData16; +sal_uInt16* pData; public: virtual void StartLine( sal_uInt8* pLine ) SAL_OVERRIDE { -pData16 = reinterpret_castsal_uInt16*(pLine); +pData = reinterpret_castsal_uInt16*(pLine); } virtual void SkipPixel( sal_uInt32 nPixel ) SAL_OVERRIDE { @@ -408,14 +409,14 @@ public: } virtual ColorData ReadPixel() SAL_OVERRIDE { -const ColorData c = RGB_COLORDATA( (*pData 0x7c00) 7, (*pData 0x03e0) 2 , (*pData 0x001f) 3 ); +const ColorData c = RGB_COLORDATA( (*pData 0xf800) 8, (*pData 0x07e0) 3 , (*pData 0x001f) 3 ); pData++; return c; } virtual void WritePixel( ColorData nColor ) SAL_OVERRIDE { -*pData++ = ((COLORDATA_RED( nColor ) 0xf8 ) 7 ) | -((COLORDATA_GREEN( nColor ) 0xf8 ) 2 ) | +*pData++ = ((COLORDATA_RED( nColor ) 0xf8 ) 8 ) | +((COLORDATA_GREEN( nColor ) 0xfc ) 3 ) | ((COLORDATA_BLUE( nColor ) 0xf8 ) 3 ); } }; @@ -423,6 +424,7 @@ public: class ImplPixelFormat8 : public ImplPixelFormat { private: +sal_uInt8* pData; const BitmapPalette mrPalette; public: @@ -430,6 +432,7 @@ public: : mrPalette( rPalette ) { } +virtual void StartLine( sal_uInt8* pLine ) SAL_OVERRIDE { pData = pLine; } virtual void SkipPixel( sal_uInt32 nPixel ) SAL_OVERRIDE { pData += nPixel; @@ -448,6 +451,7 @@ public: class ImplPixelFormat4 : public ImplPixelFormat { private: +sal_uInt8* pData; const BitmapPalette mrPalette; sal_uInt32 mnX; sal_uInt32 mnShift; @@ -489,6 +493,7 @@ public: class ImplPixelFormat1 : public ImplPixelFormat { private: +sal_uInt8* pData; const BitmapPalette mrPalette; sal_uInt32 mnX; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits