[Libreoffice-bugs] [Bug 86329] EDITING: Image crop shouldnt be set to proportionate in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=86329 --- Comment #17 from tmacalp tmac...@gmail.com --- I've submitted a small patch to code review that should solve this particular issue: https://gerrit.libreoffice.org/#/c/15505/ Unfortunately, I noticed many other issues with interactive cropping while testing this bug. These may be reported elsewhere. 1. Hitting escape does not abort our crop, but applies it instead. 2. It's somehow possible to drag our crop area outside the bounds of the picture. This will expand a clickable invisible area around our image. 3. There is no easy way to undo our cropping other than undo. You would have to carefully drag your crop back to the edges of your picture. 4. There is no way to to constrain the resulting crop rectangle. Even with this bug fixed, it now ACTS like holding shift will constrain proportions while you have your mouse button down, but the actual crop region is determined somewhere else. Constrained crop really does need to be properly implemented. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89215] Unable to open Impress document
https://bugs.documentfoundation.org/show_bug.cgi?id=89215 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Mike Kaganski mikekagan...@hotmail.com --- Reproducible with Version: 4.5.0.0.alpha0+ Build ID: 6ef2c67 (Google Play) under Android 4.3 on GT-I9300 (In reply to Robinson Tryon (qubit) from comment #3) Maybe memory issue? I have a total of ~831 MB, ~180 free before opening -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/docxsdrexport.cxx | 21 +
sw/source/filter/ww8/docxsdrexport.hxx |2 --
2 files changed, 13 insertions(+), 10 deletions(-)
New commits:
commit 0ffbbe0694fe7d817f4c120a79ce28d77fcbe958
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Apr 24 09:01:10 2015 +0200
checkFrameBtlr() can be moved to DocxSdrExport::Impl
Change-Id: Ia5d04e3a7a56880f91c442b1b0dd73e5c7bcc0e5
diff --git a/sw/source/filter/ww8/docxsdrexport.cxx
b/sw/source/filter/ww8/docxsdrexport.cxx
index 7c191c0..00b250c 100644
--- a/sw/source/filter/ww8/docxsdrexport.cxx
+++ b/sw/source/filter/ww8/docxsdrexport.cxx
@@ -185,6 +185,8 @@ struct DocxSdrExport::Impl
void textFrameShadow(const SwFrmFmt rFrmFmt);
bool isSupportedDMLShape(uno::Referencedrawing::XShape xShape);
+/// Undo the text direction mangling done by the frame btLr handler in
writerfilter::dmapper::DomainMapper::lcl_startCharacterGroup()
+bool checkFrameBtlr(SwNode* pStartNode, bool bDML);
};
DocxSdrExport::DocxSdrExport(DocxExport rExport, sax_fastparser::FSHelperPtr
pSerializer, oox::drawingml::DrawingML* pDrawingML)
@@ -1296,7 +1298,7 @@ void DocxSdrExport::writeOnlyTextOfFrame(sw::Frame*
pParentFrame)
ExportDataSaveRestore aDataGuard(m_pImpl-m_rExport, nStt, nEnd,
pParentFrame);
m_pImpl-m_pBodyPrAttrList =
sax_fastparser::FastSerializerHelper::createAttrList();
-m_pImpl-m_bFrameBtLr =
checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt], 0);
+m_pImpl-m_bFrameBtLr =
m_pImpl-checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt],
/*bDML=*/true);
m_pImpl-m_bFlyFrameGraphic = true;
m_pImpl-m_rExport.WriteText();
m_pImpl-m_bFlyFrameGraphic = false;
@@ -1530,7 +1532,7 @@ void DocxSdrExport::writeDMLTextFrame(sw::Frame*
pParentFrame, int nAnchorId, bo
pFS-startElementNS(XML_w, XML_txbxContent, FSEND);
-m_pImpl-m_bFrameBtLr =
checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt], 0);
+m_pImpl-m_bFrameBtLr =
m_pImpl-checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt],
/*bDML=*/true);
m_pImpl-m_bFlyFrameGraphic = true;
m_pImpl-m_rExport.WriteText();
if (m_pImpl-m_bParagraphSdtOpen)
@@ -1625,7 +1627,7 @@ void DocxSdrExport::writeVMLTextFrame(sw::Frame*
pParentFrame, bool bTextBoxOnly
m_pImpl-m_pFlyAttrList-addNS(XML_w14, XML_anchorId,
OUStringToOString(sAnchorId, RTL_TEXTENCODING_UTF8));
}
sax_fastparser::XFastAttributeListRef
xFlyAttrList(m_pImpl-m_pFlyAttrList.release());
-m_pImpl-m_bFrameBtLr =
checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt],
m_pImpl-m_pTextboxAttrList);
+m_pImpl-m_bFrameBtLr =
m_pImpl-checkFrameBtlr(m_pImpl-m_rExport.pDoc-GetNodes()[nStt],
/*bDML=*/false);
sax_fastparser::XFastAttributeListRef
xTextboxAttrList(m_pImpl-m_pTextboxAttrList);
m_pImpl-m_pTextboxAttrList = NULL;
m_pImpl-m_bTextFrameSyntax = false;
@@ -1678,10 +1680,13 @@ void DocxSdrExport::writeVMLTextFrame(sw::Frame*
pParentFrame, bool bTextBoxOnly
m_pImpl-m_bDMLAndVMLDrawingOpen = bDMLAndVMLDrawingOpen;
}
-bool DocxSdrExport::checkFrameBtlr(SwNode* pStartNode,
sax_fastparser::FastAttributeList* pTextboxAttrList)
+bool DocxSdrExport::Impl::checkFrameBtlr(SwNode* pStartNode, bool bDML)
{
// The intended usage is to pass either a valid VML or DML attribute list.
-assert(pTextboxAttrList || m_pImpl-m_pBodyPrAttrList);
+if (bDML)
+assert(m_pBodyPrAttrList);
+else
+assert(m_pTextboxAttrList);
if (!pStartNode-IsTxtNode())
return false;
@@ -1715,10 +1720,10 @@ bool DocxSdrExport::checkFrameBtlr(SwNode* pStartNode,
sax_fastparser::FastAttri
const SvxCharRotateItem rCharRotate = static_castconst
SvxCharRotateItem(*pItem);
if (rCharRotate.GetValue() == 900)
{
-if (pTextboxAttrList)
-pTextboxAttrList-add(XML_style,
mso-layout-flow-alt:bottom-to-top);
+if (bDML)
+m_pBodyPrAttrList-add(XML_vert, vert270);
else
-m_pImpl-m_pBodyPrAttrList-add(XML_vert, vert270);
+m_pTextboxAttrList-add(XML_style,
mso-layout-flow-alt:bottom-to-top);
return true;
}
}
diff --git a/sw/source/filter/ww8/docxsdrexport.hxx
b/sw/source/filter/ww8/docxsdrexport.hxx
index 1ff9404..cbdd100 100644
--- a/sw/source/filter/ww8/docxsdrexport.hxx
+++ b/sw/source/filter/ww8/docxsdrexport.hxx
@@ -103,8 +103,6 @@ public:
void writeDMLTextFrame(sw::Frame* pParentFrame, int nAnchorId, bool
bTextBoxOnly = false);
/// Writes text frame in VML format.
void writeVMLTextFrame(sw::Frame* pParentFrame, bool bTextBoxOnly = false);
-/// Undo the text direction mangling done by the frame btLr handler in
writerfilter::dmapper::DomainMapper::lcl_startCharacterGroup()
-bool checkFrameBtlr(SwNode* pStartNode, sax_fastparser::FastAttributeList*
pTextboxAttrList = 0);
[Libreoffice-bugs] [Bug 90773] FILEOPEN: Long delay while opening impress presentations
https://bugs.documentfoundation.org/show_bug.cgi?id=90773 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Severity|blocker |critical --- Comment #9 from Markus Mohrhard markus.mohrh...@googlemail.com --- There are no blockers! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #6 from Beluga todven...@suomi24.fi --- Exporting from LibO GUI and validating with http://validator.w3.org/ I get 46 Errors. attachment 82545 gives 46 Errors, 1 warning(s) so I guess the problem persists. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34596] Search and replace empty paragraphs in a Writer document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=34596 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Version|3.6.4.3 release |3.3.1 release OS|Linux (All) |All --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Cyril Brosch from comment #3) I can confirm the problem persists in LO 3.6.4. I have a lot of tables with empty paragraphs around it like in the following example: http://www.cyrilbrosch.net/ex_1.odt The search never finds the empty line right before the table, which effectively makes it impossible for me to correct the 1000+ tables in my document automatically. Reproduced. It only replaces 1 time now, NOT 6 times. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90789] FILEOPEN:DOCX content messed up, all data from sections moved to last sections.
https://bugs.documentfoundation.org/show_bug.cgi?id=90789 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming with : Version: 5.0.0.0.alpha1+ Build ID: da36fc8c9564199b8c2f8f28c2e4d04d9862a2d4 TinderBox: MacOSX-10.10@61, Branch:master, Time: 2015-04-21_21:09:35 Locale: fr_ Also opened in Word 15.9.0 Preview on Mac where file displays as per poster's screenshot. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'feature/xtiledrenderable'
New branch 'feature/xtiledrenderable' available with the following commits: commit e2ad83e25aa86bc377b664d6d07a0b86abf487c0 Author: László Németh laszlo.nem...@collabora.com Date: Fri Apr 24 13:58:04 2015 +0200 Initial XTiledRenderable API Change-Id: I6dc337ec958c1e116fc9763877f331b751b64e6e ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68745] TABLE: Wrong cells are merged
https://bugs.documentfoundation.org/show_bug.cgi?id=68745 Beluga todven...@suomi24.fi changed: What|Removed |Added Keywords||regression CC||todven...@suomi24.fi Version|4.0.4.2 release |3.6.3.2 release Whiteboard|BSA |BSA bibisectRequest --- Comment #4 from Beluga todven...@suomi24.fi --- I could not reproduce it in 3.4.3. 3.5.0 crashed when merging, but I managed to see, that it didn't mess up the numbers. 3.6.3.2 showed the problem. Adding bibisect request anyway, because maybe there is something wrong in my end. I'm using the new releases repo: https://wiki.documentfoundation.org/QA/HowToBibisect#releases -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] Meta: HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Depends on|61932 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61932] VIEWING: Font rendering is bad
https://bugs.documentfoundation.org/show_bug.cgi?id=61932 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|NEW |RESOLVED Blocks|90796 | Resolution|--- |WORKSFORME --- Comment #13 from Adolfo Jayme f...@libreoffice.org --- Everyone please upgrade to 4.4. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73211] Unchecked checkboxes remain checked while mouse is over them
https://bugs.documentfoundation.org/show_bug.cgi?id=73211 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90827] Ubuntu 15.04 / Gnome 3.16 UI
https://bugs.documentfoundation.org/show_bug.cgi?id=90827 --- Comment #3 from James King bassbase...@gmail.com --- (In reply to Tomaz Vajngerl from comment #2) disable OpenGL for all rendering Ah, Many thanks. Apologies if this has been a long standing bug, it wasn't one I was aware of. Disabling OpenGL worked for me (with a restart). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70615] Setting the font size to 100% in a style saves a fixed value instead
https://bugs.documentfoundation.org/show_bug.cgi?id=70615 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Version|4.2.0.0.alpha0+ Master |Inherited From OOo Severity|normal |minor --- Comment #3 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67341] EDITING: Toolbar Edit Points not available in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=67341 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Version|4.1.0.4 release |Inherited From OOo OS|Linux (All) |All Severity|normal |minor --- Comment #4 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90829] New: Bookmarks are gone when setting their value via makro or navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=90829 Bug ID: 90829 Summary: Bookmarks are gone when setting their value via makro or navigator Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pascal.bec...@qd-e.de When a value of a bookmark is set in a BASIC Makro using for example the command bookmarks.getByName(Testbookmark).getAnchor().setString(test) then the bookmark itself gets deleted. There is no bookmark Testbookmark in the navigator anymore. The same happens when you click on the bookmark in the navigator and enter a text. The text is there in the document, but the bookmark is gone. Tested the same with version 4.3.5.2. There the behaviour is as expected. If you set the bookmark text via makro or by the navigator, the text is there and the bookmark still exists. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66302] FILESAVE: Formulae exported to XHTML incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=66302 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #6 from Beluga todven...@suomi24.fi --- Yep, incorrect in Chrome 42 and IE 11. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] Meta: HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Alias||HiDPI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73211] Unchecked checkboxes remain checked while mouse is over them
https://bugs.documentfoundation.org/show_bug.cgi?id=73211 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA |BSA target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |2 ++
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |6 +-
2 files changed, 7 insertions(+), 1 deletion(-)
New commits:
commit d194074aa34e3724dd9b93fbc81bf2ba793cd37a
Author: Caolán McNamara caol...@redhat.com
Date: Fri Apr 24 11:01:50 2015 +0100
Resolves: tdf#73211 gtk checkboxes need erase afer toggling
because an unchecked checkbox can have a smaller paint area
than a checked checkbox. This has always bugged me
Change-Id: Iac0f075089611b47c381863a9655445d732bfddc
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index 6f67c29..878540f 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -538,6 +538,8 @@ void GtkData::initNWF()
pSVData-maNWFData.mnMenuFormatBorderX = xthickness + horizontal_padding;
pSVData-maNWFData.mnMenuFormatBorderY = ythickness + vertical_padding;
+pSVData-maNWFData.mbCheckBoxNeedsErase = true;
+
if( SalGetDesktopEnvironment() == KDE )
{
// #i97196# ensure a widget exists and the style engine was loaded
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index d98cb3c..aba6dd9 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -1472,7 +1472,11 @@ void GtkSalGraphics::WidgetQueueDraw() const
static GtkWidget* gCacheWindow;
static GtkWidget* gDumbContainer;
-void GtkData::initNWF() {}
+void GtkData::initNWF()
+{
+ImplSVData* pSVData = ImplGetSVData();
+pSVData-maNWFData.mbCheckBoxNeedsErase = true;
+}
void GtkData::deInitNWF()
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 73211] Unchecked checkboxes remain checked while mouse is over them
https://bugs.documentfoundation.org/show_bug.cgi?id=73211 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d194074aa34e3724dd9b93fbc81bf2ba793cd37a Resolves: tdf#73211 gtk checkboxes need erase afer toggling It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: android/experimental
android/experimental/LOAndroid3/src/java/org/libreoffice/InvalidationHandler.java
|4 ++-
android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
| 13 +-
2 files changed, 10 insertions(+), 7 deletions(-)
New commits:
commit 02432d6ef24c4af957ab0d52307fef8ba6428306
Author: Jan Holesovsky ke...@collabora.com
Date: Mon Apr 20 09:58:06 2015 +0200
viewer: Enable taps to be able to handle hyperlinks.
Change-Id: I0b735d8db3204dc826c2b5fa9a568a5b425353e4
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/InvalidationHandler.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/InvalidationHandler.java
index a58e2dd..a22c5fd 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/InvalidationHandler.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/InvalidationHandler.java
@@ -41,7 +41,9 @@ public class InvalidationHandler implements
Document.MessageCallback {
@Override
public void messageRetrieved(int messageID, String payload) {
if (!LOKitShell.isEditingEnabled()) {
-return;
+// enable handling of hyperlinks even in the Viewer
+if (messageID != Document.CALLBACK_INVALIDATE_TILES messageID
!= Document.CALLBACK_HYPERLINK_CLICKED)
+return;
}
switch (messageID) {
case Document.CALLBACK_INVALIDATE_TILES:
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
index cc21840..0da9681 100644
--- a/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
+++ b/android/experimental/LOAndroid3/src/java/org/libreoffice/LOKitThread.java
@@ -293,13 +293,14 @@ public class LOKitThread extends Thread {
* Processes touch events.
*/
private void touch(String touchType, PointF documentCoordinate) {
-if (!LOKitShell.isEditingEnabled()) {
-return;
-}
if (mTileProvider == null) {
return;
}
-if (touchType.equals(LongPress)) {
+
+// to handle hyperlinks, enable single tap even in the Viewer
+boolean editing = LOKitShell.isEditingEnabled();
+
+if (touchType.equals(LongPress) editing) {
mInvalidationHandler.changeStateTo(InvalidationHandler.OverlayState.TRANSITION);
mTileProvider.mouseButtonDown(documentCoordinate, 1);
mTileProvider.mouseButtonUp(documentCoordinate, 1);
@@ -309,9 +310,9 @@ public class LOKitThread extends Thread {
mInvalidationHandler.changeStateTo(InvalidationHandler.OverlayState.TRANSITION);
mTileProvider.mouseButtonDown(documentCoordinate, 1);
mTileProvider.mouseButtonUp(documentCoordinate, 1);
-} else if (touchType.equals(GraphicSelectionStart)) {
+} else if (touchType.equals(GraphicSelectionStart) editing) {
mTileProvider.setGraphicSelectionStart(documentCoordinate);
-} else if (touchType.equals(GraphicSelectionEnd)) {
+} else if (touchType.equals(GraphicSelectionEnd) editing) {
mTileProvider.setGraphicSelectionEnd(documentCoordinate);
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 60255] UI elements do not adhere to OSX styling
https://bugs.documentfoundation.org/show_bug.cgi?id=60255 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Blocks|42082 | --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- Nowadays, only these remain: * Highlights in lists and dropdowns have a dotted outline * Scrollbars do not obey OSX hide-until-scrolling behaviour This: * Icons do not follow OSX style or use any of the system standard icons (e.g. folder icons) is not fixable since we can’t bundle the proprietary Apple-created artwork, our assets have to be freely licensed. As already mentioned, each bug report is meant to track a single issue only. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Depends on|60255 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/tango icon-themes/tango_testing
dev/null |binary icon-themes/tango/cmd/lc_aligncenter.png |binary icon-themes/tango/cmd/lc_aligncenter.svg | 782 icon-themes/tango/cmd/lc_aligndown.png |binary icon-themes/tango/cmd/lc_aligndown.svg | 746 icon-themes/tango/cmd/lc_alignmiddle.png |binary icon-themes/tango/cmd/lc_alignmiddle.svg | 748 icon-themes/tango/cmd/lc_alignup.png |binary icon-themes/tango/cmd/lc_alignup.svg | 746 icon-themes/tango/cmd/lc_bezierappend.png |binary icon-themes/tango/cmd/lc_bezierappend.svg | 4944 + icon-themes/tango/cmd/lc_bezierdelete.png |binary icon-themes/tango/cmd/lc_bezierdelete.svg |11933 + icon-themes/tango/cmd/lc_bezieredge.png|binary icon-themes/tango/cmd/lc_bezieredge.svg| 2823 +++ icon-themes/tango/cmd/lc_beziersmooth.png |binary icon-themes/tango/cmd/lc_beziersmooth.svg | 2817 +++ icon-themes/tango/cmd/lc_beziersymmetric.png |binary icon-themes/tango/cmd/lc_beziersymmetric.svg | 2862 +++ icon-themes/tango/cmd/lc_ellipse.png |binary icon-themes/tango/cmd/lc_ellipsetoolbox.png|binary icon-themes/tango/cmd/lc_exportdirecttopdf.png |binary icon-themes/tango/cmd/lc_exportdirecttopdf.svg | 756 icon-themes/tango/cmd/lc_viewdatasourcebrowser.png |binary icon-themes/tango/cmd/lc_viewdatasourcebrowser.svg | 3500 +++ icon-themes/tango/cmd/sc_deletecolumns.png |binary icon-themes/tango/cmd/sc_deletecolumns.svg | 433 icon-themes/tango/cmd/sc_deleterows.png|binary icon-themes/tango/cmd/sc_deleterows.svg| 427 icon-themes/tango/cmd/sc_exportdirecttopdf.png |binary icon-themes/tango/cmd/sc_exportdirecttopdf.svg | 556 icon-themes/tango/cmd/sc_insertcolumns.png |binary icon-themes/tango/cmd/sc_insertcolumns.svg | 531 icon-themes/tango/cmd/sc_insertrows.png|binary icon-themes/tango/cmd/sc_insertrows.svg| 535 icon-themes/tango_testing/cmd/lc_aligncenter.svg | 782 icon-themes/tango_testing/cmd/lc_aligndown.svg | 746 icon-themes/tango_testing/cmd/lc_alignmiddle.svg | 748 icon-themes/tango_testing/cmd/lc_alignup.svg | 746 icon-themes/tango_testing/cmd/lc_bezierappend.svg | 4944 - icon-themes/tango_testing/cmd/lc_bezierdelete.svg |11933 - icon-themes/tango_testing/cmd/lc_bezieredge.svg| 2823 --- icon-themes/tango_testing/cmd/lc_beziersmooth.svg | 2817 --- icon-themes/tango_testing/cmd/lc_beziersymmetric.svg | 2862 --- icon-themes/tango_testing/cmd/lc_exportdirecttopdf.svg | 756 icon-themes/tango_testing/cmd/lc_viewdatasourcebrowser.svg | 3500 --- icon-themes/tango_testing/cmd/sc_deletecolumns.svg | 433 icon-themes/tango_testing/cmd/sc_deleterows.svg| 427 icon-themes/tango_testing/cmd/sc_insertcolumns.svg | 531 icon-themes/tango_testing/cmd/sc_insertrows.svg| 535 icon-themes/tango_testing/starmath/res/al21802.svg | 84 icon-themes/tango_testing/starmath/res/al21804.svg | 93 52 files changed, 35139 insertions(+), 34760 deletions(-) New commits: commit 936e0ed0c9e1e7143b016b216165308415b73c16 Author: Adolfo Jayme Barrientos fit...@ubuntu.com Date: Fri Apr 24 04:38:35 2015 -0500 Tango: more integration Change-Id: I941e48120e13c225f09cbd8ea890f93150f473e2 diff --git a/icon-themes/tango/cmd/lc_aligncenter.png b/icon-themes/tango/cmd/lc_aligncenter.png index 24347ec..d10504b 100644 Binary files a/icon-themes/tango/cmd/lc_aligncenter.png and b/icon-themes/tango/cmd/lc_aligncenter.png differ diff --git a/icon-themes/tango_testing/cmd/lc_aligncenter.svg b/icon-themes/tango/cmd/lc_aligncenter.svg similarity index 100% rename from icon-themes/tango_testing/cmd/lc_aligncenter.svg rename to icon-themes/tango/cmd/lc_aligncenter.svg diff --git a/icon-themes/tango/cmd/lc_aligndown.png b/icon-themes/tango/cmd/lc_aligndown.png index 1416609..539a3a0 100644 Binary files a/icon-themes/tango/cmd/lc_aligndown.png and b/icon-themes/tango/cmd/lc_aligndown.png differ diff --git a/icon-themes/tango_testing/cmd/lc_aligndown.svg b/icon-themes/tango/cmd/lc_aligndown.svg similarity index 100% rename from icon-themes/tango_testing/cmd/lc_aligndown.svg rename to icon-themes/tango/cmd/lc_aligndown.svg diff --git a/icon-themes/tango/cmd/lc_alignmiddle.png b/icon-themes/tango/cmd/lc_alignmiddle.png index b96f9b0..387f4e6 100644 Binary files
[Libreoffice-bugs] [Bug 90787] terminated unexpectedly by exiting (EXC_BAD_ACCESS, EXC_I386_GPFLT)
https://bugs.documentfoundation.org/show_bug.cgi?id=90787 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- So it is not reproducible with a precise set of circumstances, we can't confirm - setting back to UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44225] text outside contour when rotating
https://bugs.documentfoundation.org/show_bug.cgi?id=44225 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- Confirmed on latest 5.0 master This is specific to adjust to contour - otherwise the text rotates as expected (the minor issue about the rotation symbol display should probably be split onto a separate bug) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41466] Missing notes and moved components after importing .docx file
https://bugs.documentfoundation.org/show_bug.cgi?id=41466 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi OS|Linux (All) |All --- Comment #15 from Beluga todven...@suomi24.fi --- (In reply to Rainer Bielefeld Retired from comment #10) Created attachment 53877 [details] Compare View The only remaining problem is that the comment boxes do not have the triangles protruding from them. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68710] FILESAVE: Tables corrupted when saving in Word97 format
https://bugs.documentfoundation.org/show_bug.cgi?id=68710 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Version|4.0.4.2 release |Inherited From OOo --- Comment #3 from Beluga todven...@suomi24.fi --- Reproduced the page breaks when saving .odt to .doc. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI OpenOffice.org 3.3.0 OOO330m20 (Build:9567) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60441] FILESAVE: Calc lost comments when more time save file ods
https://bugs.documentfoundation.org/show_bug.cgi?id=60441 --- Comment #13 from Jürgen gro.noitadnuoftnemu...@x.wellen.org --- Hi, I could reproduce this bug with version 4.2.0.4 (*32 bit) on Win7 64: 1) create new calc document 2) fill cell(s), e. g. A1=1 3) enter a note for A2 4) kill soffice.bin 5) restart LibreOffice = recover your document 6) fill another cell, e. g. A3 (if not filled another cell bug does not occour) 7) save 8) close LO 9) start LO and open your document = comments are gone :-( Hope to help to solve this serious bug! Thanks for your work! Best regards Jürgen -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68745] TABLE: Wrong cells are merged
https://bugs.documentfoundation.org/show_bug.cgi?id=68745 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Beluga from comment #4) I could not reproduce it in 3.4.3. 3.5.0 crashed when merging, but I managed to see, that it didn't mess up the numbers. 3.6.3.2 showed the problem. Adding bibisect request anyway, because maybe there is something wrong in my end. I'm using the new releases repo: https://wiki.documentfoundation.org/QA/HowToBibisect#releases These were on Linux.. I remembered I had 3.5.0rc3 on Windows as well and it didn't crash and did not show the problem! The problem persists in the latest version: Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/viewer2' - 13 commits - android/CustomTarget_lo_android.mk android/experimental
android/CustomTarget_lo_android.mk
|2
android/experimental/LOAndroid3/res/layout/file_list_item.xml
| 24 -
android/experimental/LOAndroid3/res/menu/view_menu.xml
|4
android/experimental/LOAndroid3/res/values/strings.xml
|6
android/experimental/LOAndroid3/res/values/themes.xml
|6
android/experimental/LOAndroid3/src/java/org/libreoffice/LibreOfficeMainActivity.java
|2
android/experimental/LOAndroid3/src/java/org/libreoffice/storage/local/LocalDocumentsDirectoryProvider.java
|3
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/FileUtilities.java
| 205 --
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/FolderIconView.java
| 124 +++---
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/GridItemAdapter.java
| 34 -
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
| 166
android/experimental/LOAndroid3/src/java/org/libreoffice/ui/ListItemAdapter.java
| 178
12 files changed, 292 insertions(+), 462 deletions(-)
New commits:
commit 14bf4870120857eca5ae4f6da15899418f6bc9a3
Author: Siqi Liu m...@siqi.fr
Date: Thu Apr 23 15:22:31 2015 +0200
intent preference overrides default prefs.
Change-Id: I315d283f6c000d971421a098264e9c594930283e
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index fd08574..938a259 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -501,6 +501,27 @@ public class LibreOfficeUIActivity extends
ActionBarActivity implements ActionBa
sortMode = prefs.getInt(SORT_MODE_KEY, FileUtilities.SORT_AZ);
SharedPreferences defaultPrefs =
PreferenceManager.getDefaultSharedPreferences(getBaseContext());
filterMode = Integer.valueOf(defaultPrefs.getString(FILTER_MODE_KEY ,
-1));
+
+Intent i = this.getIntent();
+if (i.hasExtra(CURRENT_DIRECTORY_KEY)) {
+try {
+currentDirectory = documentProvider.createFromUri(new URI(
+i.getStringExtra(CURRENT_DIRECTORY_KEY)));
+} catch (URISyntaxException e) {
+currentDirectory = documentProvider.getRootDirectory();
+}
+Log.d(LOGTAG, CURRENT_DIRECTORY_KEY);
+}
+
+if (i.hasExtra(FILTER_MODE_KEY)) {
+filterMode = i.getIntExtra( FILTER_MODE_KEY, FileUtilities.ALL);
+Log.d(LOGTAG, FILTER_MODE_KEY);
+}
+
+if (i.hasExtra(EXPLORER_VIEW_TYPE_KEY)) {
+viewMode = i.getIntExtra( EXPLORER_VIEW_TYPE_KEY, GRID_VIEW);
+Log.d(LOGTAG, EXPLORER_VIEW_TYPE_KEY);
+}
}
@Override
commit 1ef31fdf5eabd3c4b14d828021652d53da054c66
Author: Siqi Liu m...@siqi.fr
Date: Thu Apr 23 15:19:28 2015 +0200
load default prefs once and use new sortmode/filter mode on refresh.
Change-Id: I54c3e25e960ade172eeb0f4bf24104b3b06e2ee2
diff --git
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
index 3c269bf..fd08574 100644
---
a/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
+++
b/android/experimental/LOAndroid3/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
@@ -107,6 +107,7 @@ public class LibreOfficeUIActivity extends
ActionBarActivity implements ActionBa
DocumentProviderFactory.initialize(this);
documentProviderFactory = DocumentProviderFactory.getInstance();
+readPreferences();
// init UI and populate with contents from the provider
createUI();
switchToDocumentProvider(documentProviderFactory.getDefaultProvider());
@@ -496,11 +497,10 @@ public class LibreOfficeUIActivity extends
ActionBarActivity implements ActionBa
public void readPreferences(){
prefs = getSharedPreferences(EXPLORER_PREFS_KEY, MODE_PRIVATE);
-viewMode = prefs.getInt( EXPLORER_VIEW_TYPE_KEY, GRID_VIEW);
-sortMode = prefs.getInt( SORT_MODE_KEY, FileUtilities.SORT_AZ );
-SharedPreferences defaultPrefs =
PreferenceManager.getDefaultSharedPreferences( getBaseContext() );
-filterMode = Integer.valueOf( defaultPrefs.getString(
[Libreoffice-bugs] [Bug 66860] Importing templates: problem with filenames longer then 255 chars, without period, and without ott
https://bugs.documentfoundation.org/show_bug.cgi?id=66860 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43763] EDITING: Text remains small if typed after footnote if text file was created in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=43763 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added CC||f...@libreoffice.org Version|3.4.4 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - dbaccess/source vcl/osx vcl/qa
dbaccess/source/ui/dlg/advancedsettings.cxx | 58 ++--
vcl/osx/a11ylistener.cxx|2
vcl/qa/cppunit/complextext.cxx |2
vcl/qa/cppunit/outdev.cxx |2
4 files changed, 32 insertions(+), 32 deletions(-)
New commits:
commit e4fb1081eeea040bc970144699f792e4790bebfa
Author: Michael Meeks michael.me...@collabora.com
Date: Thu Apr 23 21:24:37 2015 +0100
Build and warning fixes, Mac, Win, Linux.
Change-Id: I8a8420f96c512e031ba3cde499523b71341dfa94
diff --git a/dbaccess/source/ui/dlg/advancedsettings.cxx
b/dbaccess/source/ui/dlg/advancedsettings.cxx
index 0310289..b020b5d 100644
--- a/dbaccess/source/ui/dlg/advancedsettings.cxx
+++ b/dbaccess/source/ui/dlg/advancedsettings.cxx
@@ -48,7 +48,7 @@ namespace dbaui
// SpecialSettingsPage
struct BooleanSettingDesc
{
-VclPtrCheckBox ppControl; // the dialog's control which
displays this setting
+VclPtrCheckBox* ppControl;// the dialog's control which displays
this setting
OString sControlId; // the widget name of the control in
the .ui
sal_uInt16 nItemId;// the ID of the item (in an
SfxItemSet) which corresponds to this setting
boolbInvertedDisplay; // true if and only if the checkbox is
checked when the item is sal_False, and vice versa
@@ -95,14 +95,14 @@ namespace dbaui
sal_uInt16 nItemId = setting-nItemId;
if ( rFeatures.has( nItemId ) )
{
-get(setting-ppControl, setting-sControlId);
-setting-ppControl-SetClickHdl( getControlModifiedLink() );
-setting-ppControl-Show();
+get(*setting-ppControl, setting-sControlId);
+(*setting-ppControl)-SetClickHdl( getControlModifiedLink() );
+(*setting-ppControl)-Show();
// check whether this must be a tristate check box
const SfxPoolItem rItem = _rCoreAttrs.Get( nItemId );
if ( rItem.ISA( OptionalBoolItem ) )
-setting-ppControl-EnableTriState( true );
+(*setting-ppControl)-EnableTriState( true );
}
}
@@ -124,7 +124,7 @@ namespace dbaui
if ( m_bHasMaxRowScan )
{
get(m_pMaxRowScanLabel, rowsft);
-get(m_pMaxRowScan, rows);
+-get(m_pMaxRowScan, rows);
m_pMaxRowScan-SetModifyHdl(getControlModifiedLink());
m_pMaxRowScan-SetUseThousandSep(false);
m_pMaxRowScanLabel-Show();
@@ -169,22 +169,22 @@ namespace dbaui
// for easier maintenance, write the table in this form, then copy it
to m_aBooleanSettings
BooleanSettingDesc aSettings[] = {
-{ m_pIsSQL92Check, usesql92,
DSID_SQL92CHECK,false },
-{ m_pAppendTableAlias, append,
DSID_APPEND_TABLE_ALIAS,false },
-{ m_pAsBeforeCorrelationName, useas,
DSID_AS_BEFORE_CORRNAME,false },
-{ m_pEnableOuterJoin, useoj,
DSID_ENABLEOUTERJOIN, false },
-{ m_pIgnoreDriverPrivileges, ignoreprivs,
DSID_IGNOREDRIVER_PRIV, false },
-{ m_pParameterSubstitution,replaceparams,
DSID_PARAMETERNAMESUBST,false },
-{ m_pSuppressVersionColumn,displayver,
DSID_SUPPRESSVERSIONCL, true },
-{ m_pCatalog, usecatalogname,
DSID_CATALOG, false },
-{ m_pSchema, useschemaname, DSID_SCHEMA,
false },
-{ m_pIndexAppendix,createindex,
DSID_INDEXAPPENDIX, false },
-{ m_pDosLineEnds, eol,
DSID_DOSLINEENDS, false },
-{ m_pCheckRequiredFields, ignorecurrency,
DSID_CHECK_REQUIRED_FIELDS, false },
-{ m_pIgnoreCurrency, inputchecks,
DSID_IGNORECURRENCY,false },
-{ m_pEscapeDateTime, useodbcliterals,
DSID_ESCAPE_DATETIME, false },
-{ m_pPrimaryKeySupport,primarykeys,
DSID_PRIMARY_KEY_SUPPORT, false },
-{ m_pRespectDriverResultSetType, resulttype,
DSID_RESPECTRESULTSETTYPE, false },
+{ m_pIsSQL92Check, usesql92,
DSID_SQL92CHECK,false },
+{ m_pAppendTableAlias, append,
DSID_APPEND_TABLE_ALIAS,false },
+{ m_pAsBeforeCorrelationName, useas,
DSID_AS_BEFORE_CORRNAME,false },
+{ m_pEnableOuterJoin, useoj,
DSID_ENABLEOUTERJOIN, false },
+{ m_pIgnoreDriverPrivileges, ignoreprivs,
DSID_IGNOREDRIVER_PRIV, false },
+
[Libreoffice-bugs] [Bug 58117] Excel's ComboBox object is not converted correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=58117 --- Comment #9 from NOKUBI Takatsugu nok...@gmail.com --- I tried on 4.4.2.2. It seems to work good. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90824] function Match / Vergleich doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=90824 raal r...@post.cz changed: What|Removed |Added Summary|: |function Match / ||Vergleich doesn't work --- Comment #1 from raal r...@post.cz --- I can not confirm with LO 4.4.2, win7 After change value in G7 values in G12, H12 are changed. Do you have Tools - Cell Contents - AutoCalculate checked? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/table/swtable.cxx |8
sw/source/core/undo/untbl.cxx |2 +-
sw/source/core/unocore/unotbl.cxx |2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 006b70044ae4884563b2b00534c0b1332ef339e6
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Apr 24 11:18:38 2015 +0200
sw: -Werror=sign-compare
Change-Id: Icbcee0740250c95db1f4931b6d49fb51dda1546f
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index 9c2a5ae..7b49f5d 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -2086,7 +2086,7 @@ void ChgNumToText( SwTableBox rBox, sal_uLong nFmt )
const SfxPoolItem* pItem;
Color* pCol = 0;
-if( css::util::NumberFormat::TEXT != nFmt )
+if( css::util::NumberFormat::TEXT != static_castsal_Int16(nFmt) )
{
// special text format:
OUString sTmp;
@@ -2236,14 +2236,14 @@ void SwTableBoxFmt::Modify( const SfxPoolItem* pOld,
const SfxPoolItem* pNew )
// is it newer or has the current been removed?
if( pNewVal )
{
-if( css::util::NumberFormat::TEXT != nNewFmt )
+if( css::util::NumberFormat::TEXT !=
static_castsal_Int16(nNewFmt) )
{
if( SfxItemState::SET == GetItemState(
RES_BOXATR_VALUE, false ))
nOldFmt = css::util::NumberFormat::TEXT;
else
nNewFmt = css::util::NumberFormat::TEXT;
}
-else if( css::util::NumberFormat::TEXT == nNewFmt )
+else if( css::util::NumberFormat::TEXT ==
static_castsal_Int16(nNewFmt) )
nOldFmt = 0;
}
@@ -2259,7 +2259,7 @@ void SwTableBoxFmt::Modify( const SfxPoolItem* pOld,
const SfxPoolItem* pNew )
// - align top for vertical alignment, if BOTTOM
is set
SvNumberFormatter* pNumFmtr =
GetDoc()-GetNumberFormatter();
bool bNewIsTxtFmt = pNumFmtr-IsTextFormat( nNewFmt ) ||
-css::util::NumberFormat::TEXT ==
nNewFmt;
+css::util::NumberFormat::TEXT ==
static_castsal_Int16(nNewFmt);
if( (!bNewIsTxtFmt nOldFmt != nNewFmt) || pNewFml )
{
diff --git a/sw/source/core/undo/untbl.cxx b/sw/source/core/undo/untbl.cxx
index d48e8d2..48d39db 100644
--- a/sw/source/core/undo/untbl.cxx
+++ b/sw/source/core/undo/untbl.cxx
@@ -2350,7 +2350,7 @@ void SwUndoTblNumFmt::RedoImpl(::sw::UndoRedoContext
rContext)
RedlineModeInternGuard aGuard( rDoc, nsRedlineMode_t::REDLINE_NONE,
nsRedlineMode_t::REDLINE_IGNORE );
pBoxFmt-SetFmtAttr( aBoxSet );
}
-else if( css::util::NumberFormat::TEXT != nFmtIdx )
+else if( css::util::NumberFormat::TEXT != static_castsal_Int16(nFmtIdx) )
{
SfxItemSet aBoxSet( rDoc.GetAttrPool(),
RES_BOXATR_FORMAT, RES_BOXATR_VALUE );
diff --git a/sw/source/core/unocore/unotbl.cxx
b/sw/source/core/unocore/unotbl.cxx
index af466b1..859fab9 100644
--- a/sw/source/core/unocore/unotbl.cxx
+++ b/sw/source/core/unocore/unotbl.cxx
@@ -735,7 +735,7 @@ void sw_setValue( SwXCell rCell, double nVal )
// - the current number format is not even a valid number formatter number
format, but rather Writer's own 'special' text number format
if(SfxItemState::SET !=
pBoxFmt-GetAttrSet().GetItemState(RES_BOXATR_FORMAT, true, pItem)
|| pDoc-GetNumberFormatter()-IsTextFormat(static_castconst
SwTblBoxNumFormat*(pItem)-GetValue())
-|| static_castconst SwTblBoxNumFormat*(pItem)-GetValue() ==
css::util::NumberFormat::TEXT)
+|| static_castsal_Int16(static_castconst
SwTblBoxNumFormat*(pItem)-GetValue()) == css::util::NumberFormat::TEXT)
{
aSet.Put(SwTblBoxNumFormat(0));
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/tiledrendering/tiledrendering.cxx | 74 ---
1 file changed, 68 insertions(+), 6 deletions(-)
New commits:
commit 041de031e456d6122dc28aeac2edb7f913ddfdbe
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Apr 24 11:19:50 2015 +0200
CppunitTest_sd_tiledrendering: add search testcase
This fails without ef9722558a33a6e88ed5ab76198f2698ddd1e003
(ImpEditView::SetEditSelection: fix missing tiled rendering selection
callbacks, 2015-04-23).
Change-Id: I5bf6bf6373e43e8551dd61d72d1f0012f92d2619
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 7e3cf19..a55b026 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -10,7 +10,9 @@
#define LOK_USE_UNSTABLE_API
#include LibreOfficeKit/LibreOfficeKitEnums.h
#include com/sun/star/frame/Desktop.hpp
+#include comphelper/dispatchcommand.hxx
#include comphelper/processfactory.hxx
+#include comphelper/propertysequence.hxx
#include comphelper/string.hxx
#include editeng/editids.hrc
#include editeng/editview.hxx
@@ -45,6 +47,7 @@ public:
void testSetTextSelection();
void testSetGraphicSelection();
void testResetSelection();
+void testSearch();
#endif
CPPUNIT_TEST_SUITE(SdTiledRenderingTest);
@@ -55,6 +58,7 @@ public:
CPPUNIT_TEST(testSetTextSelection);
CPPUNIT_TEST(testSetGraphicSelection);
CPPUNIT_TEST(testResetSelection);
+CPPUNIT_TEST(testSearch);
#endif
CPPUNIT_TEST_SUITE_END();
@@ -68,6 +72,7 @@ private:
uno::Referencelang::XComponent mxComponent;
#if !defined(WNT) !defined(MACOSX)
Rectangle m_aInvalidation;
+std::vectorRectangle m_aSelection;
#endif
};
@@ -103,6 +108,33 @@ void SdTiledRenderingTest::callback(int nType, const char*
pPayload, void* pData
static_castSdTiledRenderingTest*(pData)-callbackImpl(nType, pPayload);
}
+static std::vectorOUString lcl_convertSeparated(const OUString rString,
sal_Unicode nSeparator)
+{
+std::vectorOUString aRet;
+
+sal_Int32 nIndex = 0;
+do
+{
+OUString aToken = rString.getToken(0, nSeparator, nIndex);
+aToken = aToken.trim();
+if (!aToken.isEmpty())
+aRet.push_back(aToken);
+}
+while (nIndex = 0);
+
+return aRet;
+}
+
+static void lcl_convertRectangle(const OUString rString, Rectangle
rRectangle)
+{
+uno::SequenceOUString aSeq =
comphelper::string::convertCommaSeparated(rString);
+CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(4), aSeq.getLength());
+rRectangle.setX(aSeq[0].toInt32());
+rRectangle.setY(aSeq[1].toInt32());
+rRectangle.setWidth(aSeq[2].toInt32());
+rRectangle.setHeight(aSeq[3].toInt32());
+}
+
void SdTiledRenderingTest::callbackImpl(int nType, const char* pPayload)
{
switch (nType)
@@ -111,13 +143,18 @@ void SdTiledRenderingTest::callbackImpl(int nType, const
char* pPayload)
{
OUString aPayload = OUString::createFromAscii(pPayload);
if (aPayload != EMPTY m_aInvalidation.IsEmpty())
+lcl_convertRectangle(aPayload, m_aInvalidation);
+}
+break;
+case LOK_CALLBACK_TEXT_SELECTION:
+{
+OUString aPayload = OUString::createFromAscii(pPayload);
+m_aSelection.clear();
+for (const OUString rString : lcl_convertSeparated(aPayload,
static_castsal_Unicode(';')))
{
-uno::SequenceOUString aSeq =
comphelper::string::convertCommaSeparated(aPayload);
-CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(4), aSeq.getLength());
-m_aInvalidation.setX(aSeq[0].toInt32());
-m_aInvalidation.setY(aSeq[1].toInt32());
-m_aInvalidation.setWidth(aSeq[2].toInt32());
-m_aInvalidation.setHeight(aSeq[3].toInt32());
+Rectangle aRectangle;
+lcl_convertRectangle(rString, aRectangle);
+m_aSelection.push_back(aRectangle);
}
}
break;
@@ -269,6 +306,31 @@ void SdTiledRenderingTest::testResetSelection()
CPPUNIT_ASSERT(!pView-GetTextEditObject());
}
+void SdTiledRenderingTest::testSearch()
+{
+SdXImpressDocument* pXImpressDocument = createDoc(dummy.odp);
+pXImpressDocument-registerCallback(SdTiledRenderingTest::callback, this);
+uno::Referencecontainer::XIndexAccess
xDrawPage(pXImpressDocument-getDrawPages()-getByIndex(0), uno::UNO_QUERY);
+uno::Referencetext::XTextRange xShape(xDrawPage-getByIndex(0),
uno::UNO_QUERY);
+xShape-setString(Aaa bbb.);
+
+uno::Sequencebeans::PropertyValue
aPropertyValues(comphelper::InitPropertySequence(
+{
+{SearchItem.SearchString, uno::makeAny(OUString(bbb))},
+{SearchItem.Backward, uno::makeAny(false)}
+}));
+comphelper::dispatchCommand(.uno:ExecuteSearch, aPropertyValues);
+
+sd::ViewShell* pViewShell =
pXImpressDocument-GetDocShell()-GetViewShell();
+SdrView* pView =
[Libreoffice-bugs] [Bug 90824] function Match / Vergleich doesn't work (hard recalc needed)
https://bugs.documentfoundation.org/show_bug.cgi?id=90824 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|4.4.2.2 release |4.3.6.2 release Summary|function Match / |function Match / |Vergleich doesn't work|Vergleich doesn't work ||(hard recalc needed) Ever confirmed|0 |1 --- Comment #3 from raal r...@post.cz --- Really, I can confirm with LO 4.4.2.2, win7 Steps 1. Change G7 once (for example 6) 2. Change G7 a second time, but with the same value (6) 3. Observe the fields G12 and H12 4. Change G7 - for example value 7 G12 and H12 doesn't change. You can trigger change of cells G12 and H12 by hard recalc CTRL+SHIFT+F9 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90827] Ubuntu 15.04 / Gnome 3.16 UI
https://bugs.documentfoundation.org/show_bug.cgi?id=90827 James King bassbase...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90828] FILESAVE : Unable to save .xlsx with underline color for text inside textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=90828 Priyanka Gaikwad priyanka.gaik...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |priyanka.gaikwad@synerzip.c |desktop.org |om -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37924] FILEOPEN FORMATTING Impress truncates display of slide notes
https://bugs.documentfoundation.org/show_bug.cgi?id=37924 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44225] text outside contour when rotating
https://bugs.documentfoundation.org/show_bug.cgi?id=44225 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Version|3.5.0 Beta2 |Inherited From OOo --- Comment #8 from Matthew Francis fdb...@neosheffield.co.uk --- Also occurs in OOo 3.3.0 - Version: Inherited from OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73211] Unchecked checkboxes remain checked while mouse is over them
https://bugs.documentfoundation.org/show_bug.cgi?id=73211 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added URL|https://bugs.launchpad.net/ | |ubuntu/+source/libreoffice/ | |+bug/1265219| See Also||https://launchpad.net/bugs/ ||1265219 Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | QA Contact|caol...@redhat.com | --- Comment #10 from Adolfo Jayme f...@libreoffice.org --- Thanks for squashing this long-standing annoyance! :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37510] EDITING: screen position jumps when attempt to select row in a large table in a certain way with the mouse ...
https://bugs.documentfoundation.org/show_bug.cgi?id=37510 Beluga todven...@suomi24.fi changed: What|Removed |Added Priority|medium |low CC||todven...@suomi24.fi Version|3.4.0 RC1 |Inherited From OOo Severity|normal |trivial --- Comment #8 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63965] CONFIGURATION: two identical functions
https://bugs.documentfoundation.org/show_bug.cgi?id=63965 Beluga todven...@suomi24.fi changed: What|Removed |Added Priority|medium |low CC||todven...@suomi24.fi Version|3.5.7.2 release |Inherited From OOo OS|Linux (All) |All Severity|normal |trivial --- Comment #5 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI OpenOffice.org 3.3.0 OOO330m20 (Build:9567) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71339] EDITING sigma icon (sum function) operating on selected range
https://bugs.documentfoundation.org/show_bug.cgi?id=71339 Goran Rakic gra...@devbase.net changed: What|Removed |Added Version|4.0.2.2 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90827] Ubuntu 15.04 / Gnome 3.16 UI
https://bugs.documentfoundation.org/show_bug.cgi?id=90827 James King bassbase...@gmail.com changed: What|Removed |Added CC||bassbase...@gmail.com --- Comment #1 from James King bassbase...@gmail.com --- Created attachment 115049 -- https://bugs.documentfoundation.org/attachment.cgi?id=115049action=edit General UI This bug is apparent across the whole LibreOffice library as far as I can see. Unsure of what the cause is. Using the Crystal icon set -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83853] Other: Printing from FileLabels fails without error message
https://bugs.documentfoundation.org/show_bug.cgi?id=83853 --- Comment #9 from Winfried Donkers winfrieddonk...@libreoffice.org --- With steps: 1. Select FileLabels, use available database (e.g. bibliography), put one or more fields on the label (with already-existing format for labels); 2. Click on New Document; 3. Document shows, but with field names, not with data; Synchronizing does not help, openening data source (F4) and selecting records neither. On printing or export to PDF, the field names are on the labels, no data. Reproduced with LO 4.1.6 on openSUSE13.1-64 and LO4.4.2.2 on Windows 7. It used to work fine (unfortunately last tested more than a year ago). Although not exactly the same steps to reproduce, IMHO this is the same bug as in above comments and related to database connection. Mailmerge does work fine. HTH. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk Whiteboard|bibisectRequest |bibisected --- Comment #14 from Matthew Francis fdb...@neosheffield.co.uk --- This is hard to reproduce reliably, but I'm fairly sure it started (on master) at the below commit. The error I usually see on a regular build is: terminate called after throwing an instance of 'com::sun::star::io::NotConnectedException' Current 5.0 dbgutil gives: soffice.bin: /home/vmiklos/git/libreoffice/master/tools/source/stream/stream.cxx:1826: virtual sal_Size SvMemoryStream::PutData(const void*, sal_Size): Assertion `pBuf Possibly Reallocate failed' failed. commit 3fcd2ccb443653740d114b3e4dc371c6b0b6525b Author: Kohei Yoshida kohei.yosh...@collabora.com AuthorDate: Mon Dec 15 15:03:51 2014 -0500 Commit: Kohei Yoshida kohei.yosh...@collabora.com CommitDate: Mon Dec 15 15:13:44 2014 -0500 fdo#87210: Re-enable parallel deflate, which was not the root cause. With f92183833fa569006602ac7e93c906d2094e0d4d, export no longer crashes, and there is no reason to leave this piece disabled any more. Let's re-enable this. Change-Id: Ibeca8869f152cbcd80f1dcb55f8199110125741d -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90827] Ubuntu 15.04 / Gnome 3.16 UI
https://bugs.documentfoundation.org/show_bug.cgi?id=90827 Tomaz Vajngerl qui...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Tomaz Vajngerl qui...@gmail.com --- disable OpenGL for all rendering -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73211] Unchecked checkboxes remain checked while mouse is over them
https://bugs.documentfoundation.org/show_bug.cgi?id=73211 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED QA Contact||caol...@redhat.com --- Comment #8 from Caolán McNamara caol...@redhat.com --- I think you're referring to the tail of the checkbox outside the indicator size rectangle but within the indicator spacing margin. i.e the paint region of an unchecked checkbox is simply smaller than a checked checkbox so we need to explicitly erase the area on toggling -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 5 commits - sw/source
sw/source/core/doc/notxtfrm.cxx|8 +-
sw/source/core/docnode/ndsect.cxx |2 -
sw/source/core/docnode/ndtbl.cxx |2 -
sw/source/core/docnode/node.cxx|2 -
sw/source/core/frmedt/tblsel.cxx |6 ++--
sw/source/core/inc/cellfrm.hxx |4 ++-
sw/source/core/inc/cntfrm.hxx |4 ++-
sw/source/core/inc/colfrm.hxx |5 +++
sw/source/core/inc/flyfrm.hxx |4 ++-
sw/source/core/inc/flyfrms.hxx |9 ---
sw/source/core/inc/frame.hxx |7 +++--
sw/source/core/inc/layfrm.hxx |6 +++-
sw/source/core/inc/notxtfrm.hxx|5 +++
sw/source/core/inc/pagefrm.hxx |4 ++-
sw/source/core/inc/rootfrm.hxx |4 ++-
sw/source/core/inc/rowfrm.hxx |4 ++-
sw/source/core/inc/sectfrm.hxx |5 +++
sw/source/core/inc/tabfrm.hxx |4 ++-
sw/source/core/inc/txtfrm.hxx |5 +++
sw/source/core/layout/atrfrm.cxx |9 +++
sw/source/core/layout/colfrm.cxx | 10 ++-
sw/source/core/layout/flowfrm.cxx |6 ++--
sw/source/core/layout/fly.cxx | 18 --
sw/source/core/layout/flycnt.cxx |4 +--
sw/source/core/layout/flyincnt.cxx | 10 ---
sw/source/core/layout/flylay.cxx |8 +-
sw/source/core/layout/frmtool.cxx |8 +++---
sw/source/core/layout/ftnfrm.cxx | 32 -
sw/source/core/layout/hffrm.cxx| 13 +-
sw/source/core/layout/layact.cxx |2 -
sw/source/core/layout/layouter.cxx |4 +--
sw/source/core/layout/newfrm.cxx | 11
sw/source/core/layout/pagechg.cxx | 20 ---
sw/source/core/layout/sectfrm.cxx | 18 +-
sw/source/core/layout/ssfrm.cxx| 47 +++--
sw/source/core/layout/tabfrm.cxx | 38 ++---
sw/source/core/layout/wsfrm.cxx|7 +++--
sw/source/core/text/frmform.cxx|2 -
sw/source/core/text/txtfrm.cxx |8 +-
sw/source/core/txtnode/atrftn.cxx |2 -
sw/source/core/view/vnew.cxx |3 +-
41 files changed, 239 insertions(+), 131 deletions(-)
New commits:
commit 479031567dbc489292eff483fafaae2ad192ff84
Author: Michael Stahl mst...@redhat.com
Date: Fri Apr 24 11:37:44 2015 +0200
sw: revert type changes in SwFrm subclass destructors
These should be unnecessary now with DestroyImpl() and might break stuff.
Reverts commits 5a934b2c6085d4e397e1466f8cd6a813f3c2d9d6 and
db2c0dc78f11c2764f16e7ca4edaf2cdffc56c64.
Change-Id: Ida880dfed9fa6445b3530e2c4788fd4974c8f9c7
diff --git a/sw/source/core/layout/fly.cxx b/sw/source/core/layout/fly.cxx
index 3cac9d7..3d00dcf 100644
--- a/sw/source/core/layout/fly.cxx
+++ b/sw/source/core/layout/fly.cxx
@@ -269,10 +269,6 @@ void SwFlyFrm::DestroyImpl()
FinitDrawObj();
-// Hack to make sure code called from base ~SwLayoutFrm does not interpret
-// this as a SwFlyFrm (which it no longer is by then):
-mnFrmType = FRM_UNUSED;
-
SwLayoutFrm::DestroyImpl();
}
diff --git a/sw/source/core/layout/pagechg.cxx
b/sw/source/core/layout/pagechg.cxx
index d49c1e4..9e0475c 100644
--- a/sw/source/core/layout/pagechg.cxx
+++ b/sw/source/core/layout/pagechg.cxx
@@ -264,10 +264,6 @@ void SwPageFrm::DestroyImpl()
}
}
-// Hack to make sure code called from base ~SwFtnBossFrm does not interpret
-// this as a SwPageFrm (which it no longer is by then):
-mnFrmType = FRM_UNUSED;
-
SwFtnBossFrm::DestroyImpl();
}
commit f00be42dbf3f9238313a914818cbee9edf708ffa
Author: Michael Stahl mst...@redhat.com
Date: Fri Apr 24 10:46:40 2015 +0200
sw: pointless cast
Change-Id: I7cd1d31765d8183a064f5917cac317fcd12c1428
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index 200a3fa..faf7243 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -655,7 +655,7 @@ void SwFrm::InsertGroupBefore( SwFrm* pParent, SwFrm*
pBehind, SwFrm* pSct )
else
{
OSL_ENSURE( pSct-IsSctFrm(), InsertGroup: For SectionFrms only
);
-SwFrm::DestroyFrm(static_castSwSectionFrm*(pSct));
+SwFrm::DestroyFrm(pSct);
}
}
else
commit 8472de571c720934cb9b885565fe5100b475c984
Author: Michael Stahl mst...@redhat.com
Date: Fri Apr 24 10:46:04 2015 +0200
sw: merge the SwFrm::Destroy() into SwFrm::DestroyImpl()
Change-Id: Icbf7246cf87d5f3f5e418df6657c5bb07aa99f4b
diff --git a/sw/source/core/inc/frame.hxx b/sw/source/core/inc/frame.hxx
index 56325c3..6df4a5a 100644
--- a/sw/source/core/inc/frame.hxx
+++ b/sw/source/core/inc/frame.hxx
@@ -362,8 +362,6 @@ protected:
void ColLock() { mbColLocked = true; }
void ColUnlock(){ mbColLocked = false; }
-void Destroy(); // for ~SwRootFrm
-
virtual void DestroyImpl();
virtual ~SwFrm();
diff --git a/sw/source/core/inc/layfrm.hxx b/sw/source/core/inc/layfrm.hxx
[Libreoffice-bugs] [Bug 90820] crash when deleting as-character fly inside fly with a11y enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=90820 Michael Stahl mst...@redhat.com changed: What|Removed |Added Keywords||bisected Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |mst...@redhat.com |desktop.org | --- Comment #2 from Michael Stahl mst...@redhat.com --- problem is that a superclass dtor does not dispose the accessible object for the SwFlyInCntFrm because in ~SwFlyFrm the IsAccessibleFrm() and IsFlyInCntFrm() return false. reverted that commit and did a different fix to move all the logic out of destructors. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69686] Footer is not rendered correctly in LibreOffice for Microsoft_ITAD_CDI_Case_Study_April.docx
https://bugs.documentfoundation.org/show_bug.cgi?id=69686 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #4 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90826] New: number format with text gives sign at wrong position
https://bugs.documentfoundation.org/show_bug.cgi?id=90826 Bug ID: 90826 Summary: number format with text gives sign at wrong position Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robert.pol...@mykolab.com When using the format code d = 0.00 on a cell containing -1.23, the cell wrongly displays -d = 1.23 instead of d = -1.23. (Seen with LO 4.3.6.2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66339] Allow ad hoc editing of chart legend
https://bugs.documentfoundation.org/show_bug.cgi?id=66339 raal r...@post.cz changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||825 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90827] New: Ubuntu 15.04 / Gnome 3.16 UI
https://bugs.documentfoundation.org/show_bug.cgi?id=90827 Bug ID: 90827 Summary: Ubuntu 15.04 / Gnome 3.16 UI Product: LibreOffice Version: 4.4.2.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bassbase...@gmail.com Created attachment 115048 -- https://bugs.documentfoundation.org/attachment.cgi?id=115048action=edit Preferences Window I have a few screenshots but within the UI menu's all checkboxes are upside-down! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83853] Other: Printing from FileLabels fails without error message
https://bugs.documentfoundation.org/show_bug.cgi?id=83853 --- Comment #10 from Winfried Donkers winfrieddonk...@libreoffice.org --- (In reply to Winfried Donkers from comment #9) On printing or export to PDF, the field names are on the labels, no data. Due to mangled information I received, I must correct the above: when printing, a dialog appears about the database connection and selection to be printed, resulting in a proper print. In other words, printing behaviour is as expected. This does not work for export to PDF, nor for print preview, though. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90828] New: FILESAVE : Unable to save .xlsx with underline color for text inside textbox
https://bugs.documentfoundation.org/show_bug.cgi?id=90828 Bug ID: 90828 Summary: FILESAVE : Unable to save .xlsx with underline color for text inside textbox Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: priyanka.gaik...@synerzip.com Created attachment 115050 -- https://bugs.documentfoundation.org/attachment.cgi?id=115050action=edit Original file Steps to reproduce 1) Create calc file in LibreOffice add textbox apply underline with color 2) Save it as .xlsx 3) Open saved file in Excel 2013 Current behavior: After RT text underline color was not exported Expected behaviour: After RT text underline color should export In calc there is no export support for a:uFill -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60441] FILESAVE: Calc lost comments when more time save file ods
https://bugs.documentfoundation.org/show_bug.cgi?id=60441 Jürgen gro.noitadnuoftnemu...@x.wellen.org changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90825] New: Cannot remove trendline entry from the legend
https://bugs.documentfoundation.org/show_bug.cgi?id=90825 Bug ID: 90825 Summary: Cannot remove trendline entry from the legend Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robert.pol...@mykolab.com When generating a trend line, a corresponding entry shows up in the chart legend. I do not want this entry, but I cannot get rid of it. This might overlap with bug 66339. (I am using LO 4.3.6.2 on Windows.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90825] Cannot remove trendline entry from the legend
https://bugs.documentfoundation.org/show_bug.cgi?id=90825 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||339 Ever confirmed|0 |1 Severity|normal |enhancement --- Comment #1 from raal r...@post.cz --- I can confirm with Lo 4.4.2.2, win7 Setting as enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90824] function Match / Vergleich doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=90824 --- Comment #2 from Sebastian sebastiankuh...@googlemail.com --- (In reply to raal from comment #1) I can not confirm with LO 4.4.2, win7 After change value in G7 values in G12, H12 are changed. Do you have Tools - Cell Contents - AutoCalculate checked? Thanks. My feedback: - I am right now sitting in front of a fresh openSUSE 13.2 installation inside a virtual box - Libreoffice Version: 4.3.6.2 Build-ID: 430m0(Build:2) installed - Tools - Cell Contents - AutoCalculate is checked The issue remains the same. In G7, please enter the same value (e. g. 6% several times, by typing, and not just by re-entering). The change to e. g. 7%, and re-type. Hope you can confirm the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66458] FILEOPEN: DOCX imports 'ptab' as 'tab' instead of its own type
https://bugs.documentfoundation.org/show_bug.cgi?id=66458 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Beluga todven...@suomi24.fi --- Reproduced, checked in document.xml. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65498] FILESAVE: Cannot save file opened with --view even after enabling editing
https://bugs.documentfoundation.org/show_bug.cgi?id=65498 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=74 ||196 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74196] Saving edited read-only document gives error instead of behaving as Save As...
https://bugs.documentfoundation.org/show_bug.cgi?id=74196 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected, regression CC||fdb...@neosheffield.co.uk Component|filters and storage |LibreOffice Version|4.1.4.2 release |3.6.0.4 release See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=65 ||498 Summary|RFE: saving edited |Saving edited read-only |read-only document gives|document gives error |error instead of behaving |instead of behaving as |as Save As... |Save As... Whiteboard||bibisected --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- This seems to be another secondary issue of the commit which caused bug 65498. I'm leaving this as a separate bug so it gets tested separately when that issue is fixed. [This wasn't an OOo bug to begin with, the linked bug has been closed with ~This is an LO bug, not an OOo bug] Not adding Cc: to sberg...@redhat.com because I see you're already there ;) ; Could you possibly take a look at this one too? Thanks (see bug 65498 comment 4) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86879] FILEOPEN: Hangs trying to open this .doc file
https://bugs.documentfoundation.org/show_bug.cgi?id=86879 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #110274|text/plain |application/msword mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #13 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115054 -- https://bugs.documentfoundation.org/attachment.cgi?id=115054action=edit Writer AT verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #12 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115053 -- https://bugs.documentfoundation.org/attachment.cgi?id=115053action=edit StarCenter AT verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/vclptr' - 2 commits - cui/source dbaccess/source
cui/source/dialogs/insrc.cxx| 21 ++---
cui/source/dialogs/newtabledlg.cxx | 15
cui/source/dialogs/splitcelldlg.cxx | 34 ++--
cui/source/factory/dlgfact.cxx |6 ++--
cui/source/inc/insrc.hxx|6 ++--
cui/source/inc/newtabledlg.hxx |8 +++---
cui/source/inc/splitcelldlg.hxx |6 +---
dbaccess/source/ui/dlg/advancedsettings.cxx |2 -
8 files changed, 44 insertions(+), 54 deletions(-)
New commits:
commit 3592db637db2998692545bffc0b9c74b69acae40
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Apr 24 15:27:49 2015 +0100
Fix unhelpful MI from a VclPtr type and Abstract factory type.
Change-Id: Ibd8a8e22ffe2cd01225e97588d65eae1cc0bffb8
diff --git a/cui/source/dialogs/insrc.cxx b/cui/source/dialogs/insrc.cxx
index 2451ad9..f628d99 100644
--- a/cui/source/dialogs/insrc.cxx
+++ b/cui/source/dialogs/insrc.cxx
@@ -33,34 +33,29 @@ sal_uInt16 SvxInsRowColDlg::getInsertCount() const
}
SvxInsRowColDlg::SvxInsRowColDlg(vcl::Window* pParent, bool bCol, const
OString sHelpId )
-: ModalDialog(pParent, InsertRowColumnDialog,
cui/ui/insertrowcolumn.ui)
+: m_pDialog(VclPtrModalDialog::Create(pParent, InsertRowColumnDialog,
cui/ui/insertrowcolumn.ui))
, aRow(CUI_RESSTR(RID_SVXSTR_ROW))
, aCol(CUI_RESSTR(RID_SVXSTR_COL))
, bColumn(bCol)
{
-get(m_pCountEdit, insert_number);
-get(m_pBeforeBtn, insert_before);
-get(m_pAfterBtn, insert_after);
-SetText( bColumn ? aCol : aRow );
-SetHelpId( sHelpId );
+m_pDialog-get(m_pCountEdit, insert_number);
+m_pDialog-get(m_pBeforeBtn, insert_before);
+m_pDialog-get(m_pAfterBtn, insert_after);
+m_pDialog-SetText( bColumn ? aCol : aRow );
+m_pDialog-SetHelpId( sHelpId );
}
SvxInsRowColDlg::~SvxInsRowColDlg()
{
-disposeOnce();
-}
-
-void SvxInsRowColDlg::dispose()
-{
m_pCountEdit.clear();
m_pBeforeBtn.clear();
m_pAfterBtn.clear();
-ModalDialog::dispose();
+m_pDialog.disposeAndClear();
}
short SvxInsRowColDlg::Execute(void)
{
-return ModalDialog::Execute();
+return m_pDialog-Execute();
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/dialogs/newtabledlg.cxx
b/cui/source/dialogs/newtabledlg.cxx
index d659368..04b2fd3 100644
--- a/cui/source/dialogs/newtabledlg.cxx
+++ b/cui/source/dialogs/newtabledlg.cxx
@@ -22,27 +22,22 @@
#include newtabledlg.hxx
SvxNewTableDialog::SvxNewTableDialog( vcl::Window* pParent )
-: ModalDialog( pParent, NewTableDialog, cui/ui/newtabledialog.ui )
+: m_pDialog( VclPtrModalDialog::Create( pParent, NewTableDialog,
cui/ui/newtabledialog.ui ) )
{
-get(mpNumRows, rows);
-get(mpNumColumns, columns);
+m_pDialog-get(mpNumRows, rows);
+m_pDialog-get(mpNumColumns, columns);
}
SvxNewTableDialog::~SvxNewTableDialog()
{
-disposeOnce();
-}
-
-void SvxNewTableDialog::dispose()
-{
mpNumColumns.clear();
mpNumRows.clear();
-ModalDialog::dispose();
+m_pDialog.disposeAndClear();
}
short SvxNewTableDialog::Execute(void)
{
-return ModalDialog::Execute();
+return m_pDialog-Execute();
}
sal_Int32 SvxNewTableDialog::getRows() const
diff --git a/cui/source/dialogs/splitcelldlg.cxx
b/cui/source/dialogs/splitcelldlg.cxx
index c412265..69bfd0e 100644
--- a/cui/source/dialogs/splitcelldlg.cxx
+++ b/cui/source/dialogs/splitcelldlg.cxx
@@ -24,16 +24,27 @@
#include splitcelldlg.hxx
#include cuires.hrc
+namespace {
+class NoApplyDialog : public SvxStandardDialog
+{
+public:
+NoApplyDialog(vcl::Window *pParent, const OUString rId, const
OUString rXML) :
+SvxStandardDialog(pParent, rId, rXML) { }
+protected:
+virtual void Apply() SAL_OVERRIDE {}
+};
+}
+
SvxSplitTableDlg::SvxSplitTableDlg( vcl::Window *pParent, bool
bIsTableVertical,
long nMaxVertical, long nMaxHorizontal )
-: SvxStandardDialog(pParent, SplitCellsDialog,
cui/ui/splitcellsdialog.ui)
+: m_pDialog(VclPtrNoApplyDialog::Create(pParent, SplitCellsDialog,
cui/ui/splitcellsdialog.ui))
, mnMaxVertical(nMaxVertical)
, mnMaxHorizontal(nMaxHorizontal)
{
-get(m_pCountEdit, countnf);
-get(m_pHorzBox, hori);
-get(m_pVertBox, vert);
-get(m_pPropCB, prop);
+m_pDialog-get(m_pCountEdit, countnf);
+m_pDialog-get(m_pHorzBox, hori);
+m_pDialog-get(m_pVertBox, vert);
+m_pDialog-get(m_pPropCB, prop);
m_pHorzBox-SetClickHdl( LINK( this, SvxSplitTableDlg, ClickHdl ));
m_pPropCB-SetClickHdl( LINK( this, SvxSplitTableDlg, ClickHdl ));
m_pVertBox-SetClickHdl( LINK( this, SvxSplitTableDlg, ClickHdl ));
@@ -55,16 +66,11 @@ SvxSplitTableDlg::SvxSplitTableDlg( vcl::Window *pParent,
bool bIsTableVertical,
SvxSplitTableDlg::~SvxSplitTableDlg()
{
-disposeOnce();
-}
-
-void SvxSplitTableDlg::dispose()
-{
m_pCountEdit.clear();
[Libreoffice-bugs] [Bug 71339] EDITING sigma icon (sum function) operating on selected range
https://bugs.documentfoundation.org/show_bug.cgi?id=71339 --- Comment #8 from Goran Rakic gra...@devbase.net --- This is a duplicate of #62279, but I think this one is better documented. There is a discussion on LibreOfficeForum.org about the issue: http://en.libreofficeforum.org/node/6918 I know at least one annoyed user that would very much like if the AutoSum can be modified to respect selected range. That would break consolidation usage (making sum of the sums) but it could still work for those users, just without selecting the range. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52501] Spell Regression: Add Does Not Clear Duplicates
https://bugs.documentfoundation.org/show_bug.cgi?id=52501 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #8 from Beluga todven...@suomi24.fi --- Problem does not occur anymore. WFM. Ubuntu 14.10 64-bit Version: 4.4.2.2 Build ID: 40m0(Build:2) Locale: en_US Win 7 Pro 64-bit, Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44328] Writer FILEOPEN: doc file opens incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=44328 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #5 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65498] FILESAVE: Cannot save file opened with --view even after enabling editing
https://bugs.documentfoundation.org/show_bug.cgi?id=65498 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected, regression CC||fdb...@neosheffield.co.uk, ||sberg...@redhat.com Component|Calc|LibreOffice Version|4.0.3.3 release |3.6.0.4 release Summary|Cannot leave from readonly |FILESAVE: Cannot save file |mode FILESAVE |opened with --view even ||after enabling editing Whiteboard||bibisected --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- Bibisect result from 43all: # first bad commit: [1273b9e25faacf414c611503c2a11283af274044] source-hash-cf04745f7a027594fd64a493c276a8280dbccfe1 There's only one real candidate in that range, which is the below commit. Adding Cc: to sberg...@redhat.com; Could you possibly take a look at this one? Thanks commit b9ecec7c74687ed5a9470cffb7d02e0e6e83107e Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jun 1 17:32:07 2012 +0200 Allow for editing of read-only documents -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88844] Open a doc read-only, click Edit File, change then save gives error
https://bugs.documentfoundation.org/show_bug.cgi?id=88844 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 65498 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65498] FILESAVE: Cannot save file opened with --view even after enabling editing
https://bugs.documentfoundation.org/show_bug.cgi?id=65498 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||r...@mirrabooka.com --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 88844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87545] Window title retains '(read-only)' after exiting read-only mode
https://bugs.documentfoundation.org/show_bug.cgi?id=87545 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected, regression CC||fdb...@neosheffield.co.uk, ||sberg...@redhat.com Version|Inherited From OOo |3.6.0.4 release See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=65 ||498 Whiteboard||bibisected --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- This isn't actually inherited from OOo - in fact before 3.6 the (read-only) went away after typing any text into the document. This seems to be a secondary issue of the commit which caused bug 65498. I'm leaving this as a separate bug so it gets tested separately when that issue is fixed. Adding Cc: to sberg...@redhat.com; Could you possibly take a look at this one too? Thanks (see bug 65498 comment 4) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86873] Edit hyperlink by selecting it from right to left causes text to be blank in dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=86873 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #110262|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65498] FILESAVE: Cannot save file opened with --view even after enabling editing
https://bugs.documentfoundation.org/show_bug.cgi?id=65498 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||545 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72024] Changing Paragaph to Do not split paragraph hangs the program
https://bugs.documentfoundation.org/show_bug.cgi?id=72024 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Gordo gordon1dr...@yahoo.com --- Could not reproduce. Windows Vista 64 Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Changed to RESOLVED WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90833] New: FILESAVE: HTML Export shape with textbox inside is not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=90833 Bug ID: 90833 Summary: FILESAVE: HTML Export shape with textbox inside is not correct Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: coch...@email.cz Created attachment 115052 -- https://bugs.documentfoundation.org/attachment.cgi?id=115052action=edit Textbox with table inside shape When I save textbox with textbox (table inside) as HTML file, it is divided into two separated parts (see attachment) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #14 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115055 -- https://bugs.documentfoundation.org/attachment.cgi?id=115055action=edit Calc AT verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=55571 | Summary|ACCESSIBILITY: |MAC AT accessibility |Accessibility - MAC AT |problems |accessibility problems | --- Comment #24 from V Stuart Foote vstuart.fo...@utsa.edu --- a little QA housekeeping Alex, thanks for posting the AT verifier results. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90831] not responding
https://bugs.documentfoundation.org/show_bug.cgi?id=90831 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- What were you doing, or attempting to do, when LibreOffice stopped responding ? You mention Base as the module, were you trying to open or create a database document ? Do you have Java installed ? If so, which version(s) ? You need both AppleJavaforOSX and Oracle Java 64bit versions. If you were trying to open an existing document and the application froze, please post a non-confidential copy of the document on this report (use the attachment link above). Setting to NEEDINFO, please reset to UNCONFIRMED once you have provided the requested information. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34596] Search and replace empty paragraphs in a Writer document with tables
https://bugs.documentfoundation.org/show_bug.cgi?id=34596 --- Comment #6 from Antanas antan...@gmail.com --- The critical part of the original bug seems now resolved – no more 6 times replace (testing with LibreOffice 4.4.2.2 40m0(Build:2), Ubuntu 14.04.2 LTS 32 bit) All empty paragraphs are removed using regular expression, *exept* those: - one empty paragraph directly before the table, - the last empty paragraph in the tables' cell(s). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57729] Too much space around some frames in some cases
https://bugs.documentfoundation.org/show_bug.cgi?id=57729 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from Gordo gordon1dr...@yahoo.com --- Could not reproduce. Edited formula by adding New Line from Elements and also by typing newline at end of formula. Removing it did not leave a gap. Windows Vista 64 Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Changed to RESOLVED WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90821] UI: different behaviour for 'insert row/column' for Writer and Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=90821
--- Comment #2 from vlotorev loto...@gmail.com ---
thanks raal, but the bug is not about 'how to insert row above'.
The question is behaviour for insert row GUI button should be the same: it
has the same icon for button and and almost the same icon text ('insert rows'
for Calc and 'insert row' for Writer).
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86878] Crash on Mac OS X after installing Grammalecte extension
https://bugs.documentfoundation.org/show_bug.cgi?id=86878 Michael Stahl mst...@redhat.com changed: What|Removed |Added CC||mst...@redhat.com Component|Extensions |Linguistic --- Comment #1 from Michael Stahl mst...@redhat.com --- something is throwing an exception of a type that is not allowed to be thrown because it is not listed in the exception specification of a method: 3 libstdc++.6.dylib 0x0096217a __cxxabiv1::__terminate(void (*)()) + 10 4 libstdc++.6.dylib 0x009621ba __cxxabiv1::__unexpected(void (*)()) + 0 5 libstdc++.6.dylib 0x009622b8 __gxx_exception_cleanup(_Unwind_Reason_Code, _Unwind_Exception*) + 0 6 libgcc3_uno.dylib 0x0a7bf611 gcc3::raiseException(_uno_Any*, _uno_Mapping*) + 1537 7 libgcc3_uno.dylib 0x0a7bc851 (anonymous namespace)::cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, _typelib_TypeDescription const*, _typelib_TypeDescriptionReference*, long, _typelib_MethodParameter*, void**, void*) + 1025 8 libgcc3_uno.dylib 0x0a7bce8b cpp_vtable_call + 1051 9 libgcc3_uno.dylib 0x0a7c478d privateSnippetExecutorClass + 17 10 liblnglo.dylib 0x273c894d GrammarCheckingIterator::DequeueAndCheck() + 1837 given that there is UNO bridge code on the stack, it's probably the extension - likely implemented in a non-C++ language. it is possible this bug causes a crash only on Mac OS X because that is built with clang and clang is the only compiler where the C++ exception specifications are actually enforced. GrammarCheckingIterator::DequeueAndCheck() calls the linguistic2::XProofreader::doProofreading UNO method so presumably the implementation of that in the extension throws the exception. this is likely not-our-bug, please contact the authors of the extension. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45243] Allow writing in a read-only file
https://bugs.documentfoundation.org/show_bug.cgi?id=45243 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |WORKSFORME --- Comment #13 from Matthew Francis fdb...@neosheffield.co.uk --- The originally reported issue has been resolved by the addition of the infobar prompt which allows an easy change to read-write mode The remaining issues mentioned later should be covered by bug 65498 and the other bugs linked from there -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #18 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115059 -- https://bugs.documentfoundation.org/attachment.cgi?id=115059action=edit DBWizard Step 2 Verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #17 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115058 -- https://bugs.documentfoundation.org/attachment.cgi?id=115058action=edit DBWizard Step1 AT verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - svl/source sw/source
svl/source/items/grabbagitem.cxx |2 +-
sw/source/filter/ww8/docxsdrexport.cxx | 16
2 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit acfebe601313a913640c75a2e0dcd10abaf526ea
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Apr 24 14:26:48 2015 +0200
DocxSdrExport::writeBoxItemLine: fix indentation
Change-Id: Ifa1faf5417e71c0528aa11c418729c895ae2d99a
diff --git a/sw/source/filter/ww8/docxsdrexport.cxx
b/sw/source/filter/ww8/docxsdrexport.cxx
index 00b250c..0beefaa 100644
--- a/sw/source/filter/ww8/docxsdrexport.cxx
+++ b/sw/source/filter/ww8/docxsdrexport.cxx
@@ -1309,21 +1309,21 @@ void DocxSdrExport::writeBoxItemLine(const SvxBoxItem
rBox)
{
const editeng::SvxBorderLine* pBorderLine = 0;
-if( rBox.GetTop() )
+if (rBox.GetTop())
{
- pBorderLine = rBox.GetTop();
+pBorderLine = rBox.GetTop();
}
-else if( rBox.GetLeft() )
+else if (rBox.GetLeft())
{
- pBorderLine = rBox.GetLeft();
+pBorderLine = rBox.GetLeft();
}
-else if( rBox.GetBottom() )
+else if (rBox.GetBottom())
{
- pBorderLine = rBox.GetBottom();
+pBorderLine = rBox.GetBottom();
}
-else if( rBox.GetRight() )
+else if (rBox.GetRight())
{
- pBorderLine = rBox.GetRight();
+pBorderLine = rBox.GetRight();
}
if (!pBorderLine)
commit 19aadbd561bc57c1ef0048033ec8a2db97fc66f1
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Apr 24 14:26:40 2015 +0200
Ensure that svl/grabbagitem.hxx is self-contained
Change-Id: I1b3bd4add8c32e271e51db321fafe98604b2b830
diff --git a/svl/source/items/grabbagitem.cxx b/svl/source/items/grabbagitem.cxx
index 8ca9e2c..19213b6 100644
--- a/svl/source/items/grabbagitem.cxx
+++ b/svl/source/items/grabbagitem.cxx
@@ -7,10 +7,10 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include svl/grabbagitem.hxx
#include sal/config.h
#include sal/log.hxx
-#include svl/grabbagitem.hxx
#include comphelper/sequence.hxx
#include com/sun/star/beans/PropertyValue.hpp
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 49576] ACCESSIBILITY: Accessibility - MAC AT accessibility problems
https://bugs.documentfoundation.org/show_bug.cgi?id=49576 --- Comment #19 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 115060 -- https://bugs.documentfoundation.org/attachment.cgi?id=115060action=edit DBWizardSaveAsDialog AT verifier -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60803] PRINTING: some 0, 05pt borders shown in pale grey instead of solid black
https://bugs.documentfoundation.org/show_bug.cgi?id=60803 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #6 from Beluga todven...@suomi24.fi --- Confirmed with PDF export. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/simplifybool.cxx |9 +
1 file changed, 9 insertions(+)
New commits:
commit 5beac3c0b76c5c74798c197d926564bae60ea7f2
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Apr 24 15:01:20 2015 +0200
Add clarifying comment
Change-Id: Ie891404a4d21e1917e5e653737e35257df3dfcae
diff --git a/compilerplugins/clang/simplifybool.cxx
b/compilerplugins/clang/simplifybool.cxx
index 5bdb4cf..e30d408 100644
--- a/compilerplugins/clang/simplifybool.cxx
+++ b/compilerplugins/clang/simplifybool.cxx
@@ -32,6 +32,15 @@ enum class Value { Unknown, False, True };
Value getValue(Expr const * expr) {
if (expr-getType()-isBooleanType()) {
+// Instead going via Expr::isCXX11ConstantExpr would turn up excatly
one
+// additional place in svx/source/dialog/framelinkarray.cxx
+//
+// const bool DIAG_DBL_CLIP_DEFAULT = false;
+// ...
+// ... = mxImpl.get() ? mxImpl-mbDiagDblClip :
DIAG_DBL_CLIP_DEFAULT;
+//
+// where it is unclear whether it is not actually better to consider
+// DIAG_DBL_CLIP_DEFAULT a tunable parameter (and thus not to
simplify):
auto lit
= dyn_castCXXBoolLiteralExpr(ignoreParenImpCastAndComma(expr));
if (lit != nullptr) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86749] Line Spacing wrong with MetaNormal font
https://bugs.documentfoundation.org/show_bug.cgi?id=86749 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #110081|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72942] importing .docx file overwrites all global properties
https://bugs.documentfoundation.org/show_bug.cgi?id=72942 --- Comment #5 from Gordo gordon1dr...@yahoo.com --- Still reproducible. Windows Vista 64 Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86724] Bullets do not work
https://bugs.documentfoundation.org/show_bug.cgi?id=86724 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #110034|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
