[Libreoffice-bugs] [Bug 91040] The memory could not be read error msg after closing Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91040 --- Comment #4 from Beluga todven...@suomi24.fi --- (In reply to Marcin Segit from comment #3) Created attachment 115438 [details] Backtrace Attaching a backtrace log. My first ever, hope I did everything right. Thanks, it seems ok. I'll alert devs. I can't reproduce the crash myself. Win 7 Pro 64-bit, Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91154] New: Navigation Buttons are not working
https://bugs.documentfoundation.org/show_bug.cgi?id=91154 Bug ID: 91154 Summary: Navigation Buttons are not working Product: LibreOffice Version: 4.3.7.2 rc Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sumanbhttc...@gmail.com Steps: 1. Click on any link and go to the specific section of document 2. Press back button to navigate to previous section from where clicked on link Expected result: Document navigates back to the previous section Actual Result: Document does not navigate at all. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - i18npool/source
i18npool/source/characterclassification/cclass_unicode.cxx | 56 -
1 file changed, 36 insertions(+), 20 deletions(-)
New commits:
commit 94e990de1fcf3b6bbb5e6524858fe7cc09e95594
Author: Caolán McNamara caol...@redhat.com
Date: Thu May 7 10:23:13 2015 +0100
Resolves: tdf#91057 transliterateChar2Char throws
MultipleCharsOutputException
for Ã, but toTitle only allows RuntimeException, which is our usual
awesomeness
Change-Id: Ib5618a55a369fa5cd1d323f657f0798776828386
(cherry picked from commit d0a0da717682a0e57f733d75d9d0700cfb198823)
Reviewed-on: https://gerrit.libreoffice.org/15659
Reviewed-by: Stephan Bergmann sberg...@redhat.com
Tested-by: Stephan Bergmann sberg...@redhat.com
diff --git a/i18npool/source/characterclassification/cclass_unicode.cxx
b/i18npool/source/characterclassification/cclass_unicode.cxx
index e58598e..637d75c 100644
--- a/i18npool/source/characterclassification/cclass_unicode.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode.cxx
@@ -21,8 +21,10 @@
#include com/sun/star/i18n/UnicodeScript.hpp
#include com/sun/star/i18n/UnicodeType.hpp
#include com/sun/star/i18n/KCharacterType.hpp
+#include com/sun/star/lang/WrappedTargetRuntimeException.hpp
#include unicode/uchar.h
#include comphelper/string.hxx
+#include cppuhelper/exc_hlp.hxx
#include cppuhelper/supportsservice.hxx
#include breakiteratorImpl.hxx
@@ -79,27 +81,41 @@ cclass_Unicode::toLower( const OUString Text, sal_Int32
nPos, sal_Int32 nCount,
OUString SAL_CALL
cclass_Unicode::toTitle( const OUString Text, sal_Int32 nPos, sal_Int32
nCount, const Locale rLocale ) throw(RuntimeException, std::exception) {
-sal_Int32 len = Text.getLength();
-if (nPos = len)
-return OUString();
-if (nCount + nPos len)
-nCount = len - nPos;
-
-trans-setMappingType(MappingTypeToTitle, rLocale);
-rtl_uString* pStr = rtl_uString_alloc(nCount);
-sal_Unicode* out = pStr-buffer;
-BreakIteratorImpl brk(m_xContext);
-Boundary bdy = brk.getWordBoundary(Text, nPos, rLocale,
-WordType::ANYWORD_IGNOREWHITESPACES, sal_True);
-for (sal_Int32 i = nPos; i nCount + nPos; i++, out++) {
-if (i = bdy.endPos)
-bdy = brk.nextWord(Text, bdy.endPos, rLocale,
-WordType::ANYWORD_IGNOREWHITESPACES);
-*out = (i == bdy.startPos) ?
-trans-transliterateChar2Char(Text[i]) : Text[i];
+try
+{
+sal_Int32 len = Text.getLength();
+if (nPos = len)
+return OUString();
+if (nCount + nPos len)
+nCount = len - nPos;
+
+trans-setMappingType(MappingTypeToTitle, rLocale);
+rtl_uString* pStr = rtl_uString_alloc(nCount);
+sal_Unicode* out = pStr-buffer;
+BreakIteratorImpl brk(m_xContext);
+Boundary bdy = brk.getWordBoundary(Text, nPos, rLocale,
+WordType::ANYWORD_IGNOREWHITESPACES, sal_True);
+for (sal_Int32 i = nPos; i nCount + nPos; i++, out++) {
+if (i = bdy.endPos)
+bdy = brk.nextWord(Text, bdy.endPos, rLocale,
+WordType::ANYWORD_IGNOREWHITESPACES);
+*out = (i == bdy.startPos) ?
+trans-transliterateChar2Char(Text[i]) : Text[i];
+}
+*out = 0;
+return OUString( pStr, SAL_NO_ACQUIRE );
+}
+catch (const RuntimeException)
+{
+throw;
+}
+catch (const Exception e)
+{
+uno::Any a(cppu::getCaughtException());
+throw lang::WrappedTargetRuntimeException(
+wrapped Exception + e.Message,
+uno::Referenceuno::XInterface(), a);
}
-*out = 0;
-return OUString( pStr, SAL_NO_ACQUIRE );
}
sal_Int16 SAL_CALL
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/characterclassification/cclass_unicode.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 665657d3da01f98cedac15af3d3c82b372c5a050
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 08:57:56 2015 +0200
Also mention exception type
Change-Id: I3ba60fd0ff8f4ed0a2683986cec7bdb25a837c18
diff --git a/i18npool/source/characterclassification/cclass_unicode.cxx
b/i18npool/source/characterclassification/cclass_unicode.cxx
index 95a6c57..da317a8 100644
--- a/i18npool/source/characterclassification/cclass_unicode.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode.cxx
@@ -113,7 +113,7 @@ cclass_Unicode::toTitle( const OUString Text, sal_Int32
nPos, sal_Int32 nCount,
{
uno::Any a(cppu::getCaughtException());
throw lang::WrappedTargetRuntimeException(
-wrapped Exception + e.Message,
+wrapped + a.getValueTypeName() + : + e.Message,
uno::Referenceuno::XInterface(), a);
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/unotools
include/unotools/fontcfg.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d4f90e1a2ad16ab5bc26e60b0ade02438b358154
Author: Thorsten Behrens thorsten.behr...@cib.de
Date: Fri May 8 08:23:33 2015 +0200
Revert fix for older gcc
Superseded by 7ad4e562b462af22a1c29c955293238cdb30267b
This reverts commit fbd85c25ba90b8db461555d735ab8b13f52d01ee.
diff --git a/include/unotools/fontcfg.hxx b/include/unotools/fontcfg.hxx
index 1fdd40f..c13e4a5 100644
--- a/include/unotools/fontcfg.hxx
+++ b/include/unotools/fontcfg.hxx
@@ -85,7 +85,7 @@ enum class ImplFontAttrs : sal_uLong
};
namespace o3tl
{
-template struct typed_flagsImplFontAttrs :
is_typed_flagsImplFontAttrs, 0xUL {};
+template struct typed_flagsImplFontAttrs :
is_typed_flagsImplFontAttrs, 0x {};
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91056] Writer crashes with start
https://bugs.documentfoundation.org/show_bug.cgi?id=91056 --- Comment #5 from kompilainenn 79045_79...@mail.ru --- (In reply to Beluga from comment #4) (In reply to kompilainenn from comment #3) (In reply to raal from comment #2) No crash with Version: 5.0.0.0.alpha1+ Build ID: 5984cc83fe756f7483d1ac582b8adbef5042be8b TinderBox: Win-x86@42, Branch:master, Time: 2015-05-07_05:11:59 It has the opportunity to test a 64-bit build? Well it doesn't crash for me. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-07_00:45:19 Locale: fi-FI (fi_FI) then repaired. You can close a bug -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
LibreOffice Gerrit News for core on 2015-05-08
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Unit test for tdf#83366 in https://gerrit.libreoffice.org/15670 from Henry Castro about module sc + tdf#90494: Change gradient angle diagonally by choosing option. in https://gerrit.libreoffice.org/15180 from Heena Gupta about module cui + ICONS: Breeze fallsback on galaxy and sifr fallsback on breeze in https://gerrit.libreoffice.org/15661 from Yousuf Philips about module vcl + tdf#74932 FILESAVE: Shapes appear when saving a .XLSX file with filter in https://gerrit.libreoffice.org/15662 from Priyanka Gaikwad about module oox, sc End of freshness + Do not write v:fill properties on export of imagedata in https://gerrit.libreoffice.org/15668 from Joren De Cuyper about module oox + Add very initial support for Visual Studio 2015 in https://gerrit.libreoffice.org/15644 from Jesús Corrius about module build + convert SHOWDIALOG_ID constants to scoped enum in https://gerrit.libreoffice.org/15651 from Noel Grandin about module framework, include, vcl + unit test for tdf#91095 in https://gerrit.libreoffice.org/15653 from Laurent Godard about module sw + convert MEDIA_COMMAND constants to scoped enum in https://gerrit.libreoffice.org/15652 from Noel Grandin about module include, sd, vcl * Merged changes on master for project core changed in the last 25 hours: + Clipart - PNG files optimized. in https://gerrit.libreoffice.org/15669 from Andrew Dent + tdf#55665: Fix a corner case OLE processing in https://gerrit.libreoffice.org/15667 from Mike Kaganski + improve fallback behaviour of underlying_type for old gcc in https://gerrit.libreoffice.org/15663 from Christoph Lutz + tdf#91066: Condensed Character Spacing i.e spc(negative value) is not exp in https://gerrit.libreoffice.org/15635 from Yogesh Bharate + remove unused code; bMapDupToInternal in struct AddInMap in https://gerrit.libreoffice.org/15658 from Winfried Donkers + tdf#91051: fix typo Trancparency-Transparency in https://gerrit.libreoffice.org/15665 from Andrea Gelmini + tdf#91050: fix typo TabePage-TabPage in https://gerrit.libreoffice.org/15664 from Andrea Gelmini + tdf#74299: improve DXF import in https://gerrit.libreoffice.org/15627 from Mike Kaganski + vcl: simplify code by using std::any_of/std::none_of in https://gerrit.libreoffice.org/15585 from Takeshi Abe + simplify code by replacing std::find_if with std::any_of/std::none_of in https://gerrit.libreoffice.org/15615 from Takeshi Abe + tdf#90994 The accessible name should not contain the accessible role in https://gerrit.libreoffice.org/15636 from Niklas Johansson + tdf#90994 Sidebar tab bar buttons should should have accessible names in https://gerrit.libreoffice.org/15639 from Niklas Johansson + Fix typo informations - information in https://gerrit.libreoffice.org/15655 from Andrea Gelmini + convert PUSHBUTTON_DROPDOWN constants to scoped enum in https://gerrit.libreoffice.org/15650 from Noel Grandin + convert BUTTONDIALOG constants to scoped enum in https://gerrit.libreoffice.org/15648 from Noel Grandin + Fix a crash in SfxInfoBarWindow in https://gerrit.libreoffice.org/15660 from Philippe Jung + convert BMP_VECTORIZE constants to scoped enum in https://gerrit.libreoffice.org/15647 from Noel Grandin + convert BMP_DITHER flags to scoped enum in https://gerrit.libreoffice.org/15646 from Noel Grandin * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + tdf#69701 use Calc's GCD() function instead of add-in GCD and in https://gerrit.libreoffice.org/15185 from Winfried Donkers + Fixed two strings in the context menu for consistency with other entries in https://gerrit.libreoffice.org/15537 from Yousuf Philips + tdf#90494-Add new Attribute for exporting gradient angle diagonally in https://gerrit.libreoffice.org/15323 from Heena Gupta + preserve whitespaces here, tdf#88137, tdf#89254 in https://gerrit.libreoffice.org/15375 from Markus Mohrhard + add kde5 build of vcl in https://gerrit.libreoffice.org/15327 from Jonathan Riddell + added currency dropdown menu may have some erors in https://gerrit.libreoffice.org/15274 from rajat vijay + Remove compiler Warnings in https://gerrit.libreoffice.org/15260 from Delveri Chick + Init in https://gerrit.libreoffice.org/15259 from Delveri Chick + tdf#90222: replace ScaList in scaddins with a std container in https://gerrit.libreoffice.org/15012 from Pieter Adriaensen + replace ScaList in scaddins with a std container tdf#90222 in https://gerrit.libreoffice.org/15177 from Pieter Adriaensen + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + tdf#64575 Photo Album: Better Image Layout in https://gerrit.libreoffice.org/14912 from Enes Ateş + WIP fdo#72987 Use firebird backup format for .odb no
LibreOffice Gerrit News for submodules on 2015-05-08
Moin! ~~ Project dictionaries ~~ Nothing moved in the project for the last 25 hours ~~ Project translations ~~ Nothing moved in the project for the last 25 hours ~~ Project help ~~ * Open changes on master for project help changed in the last 25 hours: + Update for number format: engineering notation, and some more in https://gerrit.libreoffice.org/15656 from Laurent BP * Merged changes on master for project help changed in the last 25 hours: None * Abandoned changes on master for project help changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: None Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 67248] FILEOPEN Layer with reserved name vanishes when changing UI language
https://bugs.documentfoundation.org/show_bug.cgi?id=67248 --- Comment #6 from Rolf Eder e...@herrmannsdorfer.de --- Bug is still present in LibO 4.4.2.2, OS X 10.10.3 :-( -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91043] Crash in gtk+ file dialog from LibreLex ...
https://bugs.documentfoundation.org/show_bug.cgi?id=91043 --- Comment #6 from Cor Nouws c...@nouenoff.nl --- (In reply to Michael Meeks from comment #5) You will need a stack-trace taken vs. a build with debug symbols to make this useful I think; fixing such things blind is a bit of a pain =) Some combined ugliness going on there. Also an unhandeld basic exception, but solving that does not end the crash. So will get the needed stuff. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91056] Writer crashes with start
https://bugs.documentfoundation.org/show_bug.cgi?id=91056 --- Comment #4 from Beluga todven...@suomi24.fi --- (In reply to kompilainenn from comment #3) (In reply to raal from comment #2) No crash with Version: 5.0.0.0.alpha1+ Build ID: 5984cc83fe756f7483d1ac582b8adbef5042be8b TinderBox: Win-x86@42, Branch:master, Time: 2015-05-07_05:11:59 It has the opportunity to test a 64-bit build? Well it doesn't crash for me. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: 6e78bf76f3a10b43475e1bd801bdcbb9ce62f668 TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-07_00:45:19 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: framework/source include/vcl vcl/osx vcl/source
framework/source/dispatch/windowcommanddispatch.cxx |6 +++---
include/vcl/cmdevt.hxx | 17 ++---
vcl/osx/salmenu.cxx | 12 ++--
vcl/source/window/winproc.cxx |4 ++--
4 files changed, 21 insertions(+), 18 deletions(-)
New commits:
commit cce752b1ba0c7dc3bbfcb77d78b63398246da80a
Author: Noel Grandin n...@peralex.com
Date: Wed May 6 15:10:25 2015 +0200
convert SHOWDIALOG_ID constants to scoped enum
Change-Id: I58fffa7345f6b5050b8a1b3ac1022c630e64dbb4
Reviewed-on: https://gerrit.libreoffice.org/15651
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/framework/source/dispatch/windowcommanddispatch.cxx
b/framework/source/dispatch/windowcommanddispatch.cxx
index 7f961e7..6920549 100644
--- a/framework/source/dispatch/windowcommanddispatch.cxx
+++ b/framework/source/dispatch/windowcommanddispatch.cxx
@@ -114,16 +114,16 @@ IMPL_LINK(WindowCommandDispatch, impl_notifyCommand,
void*, pParam)
if ( ! pData)
return 0L;
-const int nCommand = pData-GetDialogId();
+const ShowDialogId nCommand = pData-GetDialogId();
OUString sCommand;
switch (nCommand)
{
-case SHOWDIALOG_ID_PREFERENCES :
+case ShowDialogId::Preferences :
sCommand = .uno:OptionsTreeDialog;
break;
-case SHOWDIALOG_ID_ABOUT :
+case ShowDialogId::About :
sCommand = .uno:About;
break;
diff --git a/include/vcl/cmdevt.hxx b/include/vcl/cmdevt.hxx
index 942d45b..fd308eb 100644
--- a/include/vcl/cmdevt.hxx
+++ b/include/vcl/cmdevt.hxx
@@ -253,21 +253,24 @@ inline CommandModKeyData::CommandModKeyData( sal_uInt16
nCode )
}
-// - CommanDialogData -
+// - CommandDialogData -
-#define SHOWDIALOG_ID_PREFERENCES 1
-#define SHOWDIALOG_ID_ABOUT 2
+enum class ShowDialogId
+{
+Preferences = 1,
+About = 2,
+};
class VCL_DLLPUBLIC CommandDialogData
{
-int m_nDialogId;
-public:
-CommandDialogData( int nDialogId = SHOWDIALOG_ID_PREFERENCES )
+ShowDialogId m_nDialogId;
+public:
+CommandDialogData( ShowDialogId nDialogId = ShowDialogId::Preferences )
: m_nDialogId( nDialogId )
{}
-int GetDialogId() const { return m_nDialogId; }
+ShowDialogId GetDialogId() const { return m_nDialogId; }
};
// Media Commands
diff --git a/vcl/osx/salmenu.cxx b/vcl/osx/salmenu.cxx
index b1e652e..61e7b76 100644
--- a/vcl/osx/salmenu.cxx
+++ b/vcl/osx/salmenu.cxx
@@ -44,13 +44,13 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL;
@interface MainMenuSelector : NSObject
{
}
--(void)showDialog: (int)nDialog;
+-(void)showDialog: (ShowDialogId)nDialog;
-(void)showPreferences: (id)sender;
-(void)showAbout: (id)sender;
@end
@implementation MainMenuSelector
--(void)showDialog: (int)nDialog
+-(void)showDialog: (ShowDialogId)nDialog
{
if( AquaSalMenu::pCurrentMenuBar )
{
@@ -63,9 +63,9 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL;
else
{
OUString aDialog;
-if( nDialog == SHOWDIALOG_ID_ABOUT )
+if( nDialog == ShowDialogId::About )
aDialog = ABOUT;
-else if( nDialog == SHOWDIALOG_ID_PREFERENCES )
+else if( nDialog == ShowDialogId::Preferences )
aDialog = PREFERENCES;
const ApplicationEvent* pAppEvent = new ApplicationEvent(
ApplicationEvent::TYPE_SHOWDIALOG, aDialog);
@@ -78,14 +78,14 @@ const AquaSalMenu* AquaSalMenu::pCurrentMenuBar = NULL;
(void)sender;
YIELD_GUARD;
-[self showDialog: SHOWDIALOG_ID_PREFERENCES];
+[self showDialog: ShowDialogId::Preferences];
}
-(void)showAbout: (id) sender
{
(void)sender;
YIELD_GUARD;
-[self showDialog: SHOWDIALOG_ID_ABOUT];
+[self showDialog: ShowDialogId::About];
}
@end
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index 30db414..d50093e 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -2256,7 +2256,7 @@ static void ImplHandleSalExtTextInputPos( vcl::Window*
pWindow, SalExtTextInputP
}
}
-static bool ImplHandleShowDialog( vcl::Window* pWindow, int nDialogId )
+static bool ImplHandleShowDialog( vcl::Window* pWindow, ShowDialogId nDialogId
)
{
if( ! pWindow )
return false;
@@ -2605,7 +2605,7 @@ bool ImplWindowFrameProc( vcl::Window* _pWindow,
SalFrame* /*pFrame*/,
break;
case SALEVENT_SHOWDIALOG:
{
-int nDialogID =
static_castint(reinterpret_castsal_IntPtr(pEvent));
+ShowDialogId nDialogID =
static_castShowDialogId(reinterpret_castsal_IntPtr(pEvent));
nRet = ImplHandleShowDialog( pWindow, nDialogID );
}
break;
[Libreoffice-commits] core.git: libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit c5a96b5d3d2a40ab202acc1559c361712d8ffe32
Author: Tor Lillqvist t...@collabora.com
Date: Fri May 8 10:50:14 2015 +0300
Clarify the usage message a bit
Change-Id: I6ae2f5c12ae5c20fd2f33bff639129dd303c3c20
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 72988d7..14cf767 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -28,7 +28,7 @@
static int help()
{
-fprintf( stderr, Usage: gtktiledviewer
absolute-path-to-libreoffice-install path-to-document\n );
+fprintf( stderr, Usage: gtktiledviewer
absolute-path-to-libreoffice-install's-program-directory
path-to-document\n );
return 1;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 88001] Default document view, force single page rather than automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=88001 Bug 88001 depends on bug 75644, which changed state. Bug 75644 Summary: Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=75644 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #21 from steve -_- st...@openmailbox.org --- OS X 10.10.3 Version: 5.0.0.0.alpha1+ Build ID: e658cb4d5ce49d3a3c6acc63155974b5ff8490c7 TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-05-07_23:37:20 Locale: de-DE (de.UTF-8) Since there is no specific commit fixing this issue, setting to WORKSFORME. FIXED is used only when a commit exists. Feel free to reopen this issue if you still can reproduce this particular problem or if I did miss something peculiar. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89061] [TEST] with show advanced fields, anyone can set
https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89061 Philippe Jung phil.j...@free.fr changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #3 from Philippe Jung phil.j...@free.fr --- Still on bugzilla-test testing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: help with the LO bibliography as seen by the source code?
Yury yury.tarasievich at gmail.com writes: I'm trying to create some kind of a stopgap solution for the https://bugs.documentfoundation.org/show_bug.cgi?id=88697 ... Never mind, guys, I've managed to do this (see issue page for details). Thank to all who helped (empty set :)) -Yury ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91155] New: Any Unicode character of U+10000 or beyond cannot be rendered in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=91155 Bug ID: 91155 Summary: Any Unicode character of U+1 or beyond cannot be rendered in LibreOffice Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yunt...@yeah.net I'm using Windows 7 x64 and LibreOffice 4.4.3.2. In LibreOffice 4.4.3.2, any Unicode character of U+1 or beyond is not showing correctly: instead of showing the character, a rectangle or a space is shown. In dialog “Special Character”, character of U+1 or beyond is not shown. (A font supporting that range is selected.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
four changes of suspicious code (connectivity, sc, sw, editeng)
The updated loplugin:implicitboolconversion now also warns about
implicit conversions from bool-like types like sal_Bool. That flagged
four places that I tried to fix as best I could, but wouldn't mind if
others more familiar with the respective code would take a look, too:
One is in connectivity (Lionel, do you happen to know how to trigger
that code?):
commit c5e08b42ace5f4481c3db87b4fb6ae2dbf9d9a51
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 09:26:35 2015 +0200
I very much assume this wants to call java.io.Reader.ready
...seeing that there is no java.io.Reader.available. (And then, there's no
good
way to map from java.io.Reader.ready's boolean value to
css.io.XInputStream.available's long value, so conservatively map true to
1.)
But I have no idea how to trigger this code.
Change-Id: I18d12e0d968141410a1b56e700ed544edceda97c
diff --git a/connectivity/source/drivers/jdbc/Reader.cxx
b/connectivity/source/drivers/jdbc/Reader.cxx
index a7cd369..20db510 100644
--- a/connectivity/source/drivers/jdbc/Reader.cxx
+++ b/connectivity/source/drivers/jdbc/Reader.cxx
@@ -57,19 +57,19 @@ void SAL_CALL java_io_Reader::skipBytes( sal_Int32
nBytesToSkip ) throw(::com::s
sal_Int32 SAL_CALL java_io_Reader::available( )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
{
-jboolean out(sal_False);
+jboolean out;
SDBThreadAttach t; OSL_ENSURE(t.pEnv,Java Enviroment geloescht worden!);
{
static const char * cSignature = ()Z;
-static const char * cMethodName = available;
+static const char * cMethodName = ready;
// Java-Call
static jmethodID mID(NULL);
obtainMethodId_throwRuntime(t.pEnv, cMethodName,cSignature, mID);
out = t.pEnv-CallBooleanMethod( object, mID);
ThrowRuntimeException(t.pEnv,*this);
} //t.pEnv
-return out;
+return out ? 1 : 0; // no way to tell *how much* is ready
}
void SAL_CALL java_io_Reader::closeInput( )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
One is in sc:
commit f593be5bcde09965bb3478e00bcdedbc6bd5bc57
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed May 6 08:17:32 2015 +0200
SfxBoolItem takes a sal_uInt16 nWhich as first argument
This code was like that ever since 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24
initial import. From the surrounding code, the best bet appears to be
ATTR_LINEBREAK?
Change-Id: Id0e3346f2f9bb9c00c202003d06c2518dea38112
diff --git a/sc/source/filter/starcalc/scflt.cxx
b/sc/source/filter/starcalc/scflt.cxx
index 682eb20..b21f9a4 100644
--- a/sc/source/filter/starcalc/scflt.cxx
+++ b/sc/source/filter/starcalc/scflt.cxx
@@ -1189,7 +1189,7 @@ void Sc10Import::LoadPatternCollection()
}
if( ( OJustify ojWordBreak ) == ojWordBreak )
-rItemSet.Put( SfxBoolItem( sal_True ) );
+rItemSet.Put( SfxBoolItem( ATTR_LINEBREAK, true ) );
if( ( OJustify ojBottomTop ) == ojBottomTop )
rItemSet.Put( SfxInt32Item( ATTR_ROTATE_VALUE, 9000 ) );
else if( ( OJustify ojTopBottom ) == ojTopBottom )
@@ -1830,7 +1830,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab)
}
if (OJustify ojWordBreak)
-aScPattern.GetItemSet().Put(SfxBoolItem(sal_True));
+aScPattern.GetItemSet().Put(SfxBoolItem(ATTR_LINEBREAK, true));
if (OJustify ojBottomTop)
aScPattern.GetItemSet().Put(SfxInt32Item(ATTR_ROTATE_VALUE,9000));
else if (OJustify ojTopBottom)
One is in sw:
commit 2c9b7e3304db9d571d15a4ba3732acf8cf40cffe
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed May 6 15:16:37 2015 +0200
SvxOpaqueItem takes a sal_uInt16 nId as first argument
This code was like that ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62
initial import. From other uses of SvxOpaqueItem, the best bet appears
to be
RES_OPAQUE.
Change-Id: I19de8fac4f41716d9c2a73bda4a8cea200ae99f8
diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx
b/sw/source/core/doc/DocumentStylePoolManager.cxx
index 3276b9f4..8d4fe0e 100644
--- a/sw/source/core/doc/DocumentStylePoolManager.cxx
+++ b/sw/source/core/doc/DocumentStylePoolManager.cxx
@@ -1318,7 +1318,7 @@ SwFmt* DocumentStylePoolManager::GetFmtFromPool(
sal_uInt16 nId )
aSet.Put( SwFmtAnchor( FLY_AT_PAGE ));
aSet.Put( SwFmtHoriOrient( 0, text::HoriOrientation::CENTER,
text::RelOrientation::FRAME ));
aSet.Put( SwFmtVertOrient( 0, text::VertOrientation::CENTER,
text::RelOrientation::FRAME ));
-aSet.Put( SvxOpaqueItem( sal_False ));
+aSet.Put( SvxOpaqueItem(
Build dependency on external cppunit
Dear list, I am trying to build Version 4.4.0.3 with a -j30 parallel build, but I am running into this error. In file included from /git/libreoffice/sal/cppunittester/cppunittester.cxx:28:0: /git/libreoffice/include/cppunittester/protectorfactory.hxx:24:31: fatal error: cppunit/Protector.h: No such file or directory #include cppunit/Protector.h I am not using '--with-system-cppunit'. Questions: 1. Where is the dependency from sal-cppunit specified? 2. How can I force a build of cppunit (and other externals)? Thanks, Richard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 80224] FILESAVE: Custom text color changed to black on export to pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=80224 --- Comment #4 from Yogesh Bharate yogesh.bhar...@synerzip.com --- In original file, the font name is Liberation Serif after save as font name changed to Times New Roman this is another bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89061] New: with show advanced fields, anyone can set
https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89061 Bug ID: 89061 Summary: with show advanced fields, anyone can set Product: LibreOffice Version: 4.5.0.0.alpha0+ Master Hardware: All OS: Android Status: UNCONFIRMED Severity: blocker Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: phil.j...@free.fr Bla -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 15 commits - animations/source avmedia/source bean/native bridges/source chart2/source compilerplugins/clang connectivity/source cui/source desktop/unx extensions/sourc
animations/source/animcore/animcore.cxx |8
avmedia/source/gstreamer/gstplayer.cxx |2
bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c |2
bridges/source/jni_uno/jni_base.h|4
bridges/source/jni_uno/jni_bridge.cxx|8
bridges/source/jni_uno/jni_data.cxx |3
chart2/source/view/main/GL3DRenderer.cxx |2
compilerplugins/clang/implicitboolconversion.cxx | 131
++
connectivity/source/drivers/firebird/Connection.cxx |2
connectivity/source/drivers/hsqldb/HStorageAccess.cxx|2
connectivity/source/drivers/hsqldb/HStorageMap.cxx |6
connectivity/source/drivers/hsqldb/StorageFileAccess.cxx |4
connectivity/source/drivers/jdbc/Reader.cxx |6
cui/source/customize/eventdlg.cxx|2
desktop/unx/source/start.c |2
extensions/source/update/check/updatecheckconfig.cxx |4
io/source/acceptor/acc_socket.cxx|2
io/source/connector/connector.cxx|2
javaunohelper/source/bootstrap.cxx |6
mysqlc/source/mysqlc_resultsetmetadata.cxx |4
odk/examples/DevelopersGuide/Database/DriverSkeleton/SConnection.cxx |2
package/source/xstor/xstorage.cxx|2
sal/textenc/tcvtutf7.cxx | 76
++---
sd/source/ui/annotations/annotationtag.cxx |2
sd/source/ui/sidebar/LayoutMenu.cxx |6
sd/source/ui/slidesorter/controller/SlideSorterController.cxx|2
sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx |4
sd/source/ui/view/ViewShellManager.cxx |2
sfx2/source/dialog/templdlg.cxx |6
sfx2/source/menu/mnuitem.cxx |2
sfx2/source/menu/mnumgr.cxx |6
sfx2/source/menu/virtmenu.cxx|6
sfx2/source/sidebar/AsynchronousCall.cxx |2
sfx2/source/sidebar/Deck.cxx |2
sfx2/source/sidebar/SidebarController.cxx|4
stoc/source/javavm/javavm.cxx|8
svtools/source/svrtf/rtfkeywd.cxx|4
svx/source/form/formfeaturedispatcher.cxx|2
sw/source/ui/table/tautofmt.cxx |2
sw/source/uibase/docvw/SidebarWin.cxx|2
sw/source/uibase/utlui/glbltree.cxx |2
test/source/sheet/xdatabaserange.cxx |4
testtools/source/bridgetest/constructors.cxx |4
writerfilter/source/dmapper/PropertyMapHelper.cxx|2
xmloff/source/forms/elementexport.cxx|2
xmloff/source/transform/OOo2Oasis.cxx| 16 -
46 files changed, 206 insertions(+), 168 deletions(-)
New commits:
commit 9be45dd750ede909ba3a181662c1bfa18e662a75
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 09:48:38 2015 +0200
lopluign:implicitboolconversion: warn about conversion from sal_Bool etc.,
too
Change-Id: I5bc23a2b599742c579ad82c1b1f68df130ac426b
diff --git a/compilerplugins/clang/implicitboolconversion.cxx
b/compilerplugins/clang/implicitboolconversion.cxx
index dec8e23..0d933bf 100644
--- a/compilerplugins/clang/implicitboolconversion.cxx
+++ b/compilerplugins/clang/implicitboolconversion.cxx
@@ -71,6 +71,14 @@ SubstTemplateTypeParmType const *
getAsSubstTemplateTypeParmType(QualType type)
}
}
+bool areSameTypedef(QualType type1, QualType type2) {
+// type1.getTypePtr() == typ2.getTypePtr() fails for e.g. ::sal_Bool vs.
+// sal_Bool:
+auto t1 = type1-getAsTypedefType();
+auto t2 = type2-getAsTypedefType();
+return t1 != nullptr t2 != nullptr t1-getDecl() == t2-getDecl();
+}
+
bool isBool(QualType type, bool allowTypedefs = true) {
if (type-isBooleanType()) {
return true;
@@ -93,6 +101,11 @@ bool isBool(Expr const * expr, bool allowTypedefs = true) {
return isBool(expr-getType(), allowTypedefs);
}
+bool isMatchingBool(Expr const * expr, Expr const * comparisonExpr) {
+return isBool(expr, false)
+||
[Libreoffice-bugs] [Bug 61914] [META] Start Center -- implementation UI and UX
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 75644, which changed state. Bug 75644 Summary: Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=75644 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88001] Default document view, force single page rather than automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=88001 Bug 88001 depends on bug 75644, which changed state. Bug 75644 Summary: Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=75644 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80319] Truncated text in Start Center and fix minimum size by localization
https://bugs.documentfoundation.org/show_bug.cgi?id=80319 Bug 80319 depends on bug 75644, which changed state. Bug 75644 Summary: Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10) https://bugs.documentfoundation.org/show_bug.cgi?id=75644 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #21 from steve -_- st...@openmailbox.org --- OS X 10.10.3 Version: 5.0.0.0.alpha1+ Build ID: e658cb4d5ce49d3a3c6acc63155974b5ff8490c7 TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-05-07_23:37:20 Locale: de-DE (de.UTF-8) Since there is no specific commit fixing this issue, setting to WORKSFORME. FIXED is used only when a commit exists. Feel free to reopen this issue if you still can reproduce this particular problem or if I did miss something peculiar. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91143] A type of arrow doesn't scale properly
https://bugs.documentfoundation.org/show_bug.cgi?id=91143 --- Comment #3 from Emanuele Giusti emanuelegiu...@me.com --- Comment on attachment 115445 -- https://bugs.documentfoundation.org/attachment.cgi?id=115445 LibreOffice Draw-Arrow issue instructions Yes of course. From LibreOffice Start Center I open LibreOffice Draw. Next: 1) From the draw tools I choose the tool Line Ends with Arrow and I design the arrow number 2 (see attachment 2); 2) I copy it and them I move it next to the arrow number 2; I use the command number 3 Line to change the End style of the arrow. I choose Short Line Arrow. This is now the arrow number 5; 3) I copy and move it, then I increase the Line Width with the command number 7 Line Width. I set it to 0,10 cm (or 0.10 cm, I don't know if you use , or .). This is arrow number 8; 4) I have done the same things (copy, move and increase line width) to arrow number 20. I hope my instructions could be more clearly as possible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91143] A type of arrow doesn't scale properly
https://bugs.documentfoundation.org/show_bug.cgi?id=91143 Emanuele Giusti emanuelegiu...@me.com changed: What|Removed |Added CC||emanuelegiu...@me.com --- Comment #2 from Emanuele Giusti emanuelegiu...@me.com --- Created attachment 115445 -- https://bugs.documentfoundation.org/attachment.cgi?id=115445action=edit LibreOffice Draw-Arrow issue instructions Yes of course. From LibreOffice Start Center I open LibreOffice Draw. Next: 1) From the draw tools I choose the tool Line Ends with Arrow and I design the arrow number 2 (see attachment 2); 2) I copy it and them I move it next to the arrow number 2; I use the command number 3 Line to change the End style of the arrow. I choose Short Line Arrow. This is now the arrow number 5; 3) I copy and move it, then I increase the Line Width with the command number 7 Line Width. I set it to 0,10 cm (or 0.10 cm, I don't know if you use , or .). This is arrow number 8; 4) I have done the same things (copy, move and increase line width) to arrow number 20. I hope my instructions could be more clearly as possible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91142] Ugly LibreOffice Start Center
https://bugs.documentfoundation.org/show_bug.cgi?id=91142 Emanuele Giusti emanuelegiu...@me.com changed: What|Removed |Added CC||emanuelegiu...@me.com --- Comment #3 from Emanuele Giusti emanuelegiu...@me.com --- Created attachment 115446 -- https://bugs.documentfoundation.org/attachment.cgi?id=115446action=edit Start Center concept design Hello Adolfo. I think your design is really what I've in my mind. I'll follow the link you posted. My concept was simply to remove that part of the design, but I like a lot your Splashscreen graphics and the color scheme. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91156] FORMATTING: Calc cell grid rendering error
https://bugs.documentfoundation.org/show_bug.cgi?id=91156 --- Comment #1 from Vitaly 9459...@gmail.com --- Created attachment 115448 -- https://bugs.documentfoundation.org/attachment.cgi?id=115448action=edit Screenshot of a XLSX file with cell grid lines messed up after several clicks on different cells -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91056] Writer crashes with start
https://bugs.documentfoundation.org/show_bug.cgi?id=91056 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67248] FILEOPEN Layer with reserved name vanishes when changing UI language
https://bugs.documentfoundation.org/show_bug.cgi?id=67248 Rolf Eder e...@herrmannsdorfer.de changed: What|Removed |Added Version|4.0.4.2 release |Inherited From OOo --- Comment #7 from Rolf Eder e...@herrmannsdorfer.de --- Tested with LibO 3.3: Bug is present there too. Set version to Inherited From OOo. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 61b44da9fbf35100ac96896f04dee5b779305d68
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 09:06:49 2015 +0200
gtktiledviewer: unused pFileName
Change-Id: I30cd9d8adffbdf9d7451bca0c09aa56639379486
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index ac74266..72988d7 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -50,7 +50,6 @@ GtkWidget* pFindbar;
GtkWidget* pFindbarEntry;
static LibreOfficeKit* pOffice;
-static char* pFileName;
static void lcl_registerToolItem(GtkToolItem* pItem, const std::string rName)
{
@@ -438,7 +437,6 @@ int main( int argc, char* argv[] )
// Hide the findbar by default.
gtk_widget_hide(pFindbar);
-pFileName = argv[2];
int bOpened = lok_docview_open_document( LOK_DOCVIEW(pDocView), argv[2] );
if (!bOpened)
g_error(main: lok_docview_open_document() failed with '%s',
pOffice-pClass-getError(pOffice));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source include/connectivity include/sfx2 include/sot include/svx sfx2/source sot/source svx/source sw/inc sw/source unusedcode.easy
connectivity/source/commontools/dbtools.cxx |5 -
include/connectivity/dbtools.hxx|2
include/sfx2/mnuitem.hxx| 24 +-
include/sot/stg.hxx |2
include/svx/dlgctrl.hxx |1
sfx2/source/menu/mnuitem.cxx| 93 --
sfx2/source/sidebar/Deck.cxx|5 -
sfx2/source/sidebar/Deck.hxx|1
sfx2/source/sidebar/SidebarController.cxx |1
sot/source/sdstor/ucbstorage.cxx| 97
svx/source/dialog/dlgctrl.cxx | 17
sw/inc/unotxdoc.hxx |1
sw/source/uibase/uno/unotxdoc.cxx |9 --
unusedcode.easy |3
14 files changed, 10 insertions(+), 251 deletions(-)
New commits:
commit efdd215124df0ab98a33525ac01a9d8ff4a542d4
Author: Caolán McNamara caol...@redhat.com
Date: Fri May 8 09:21:42 2015 +0100
callcatcher: update unused code
Change-Id: I8563922204d3ec93bf138cbd1aaba620c0215bf7
diff --git a/connectivity/source/commontools/dbtools.cxx
b/connectivity/source/commontools/dbtools.cxx
index adbb61f..f49bdc6 100644
--- a/connectivity/source/commontools/dbtools.cxx
+++ b/connectivity/source/commontools/dbtools.cxx
@@ -737,11 +737,6 @@ Sequence OUString getFieldNamesByCommandDescriptor(
const Reference XConnect
return aNames;
}
-SQLContext prependContextInfo(const SQLException _rException, const
Reference XInterface _rxContext, const OUString _rContextDescription,
const OUString _rContextDetails)
-{
-return SQLContext( _rContextDescription, _rxContext, OUString(), 0,
makeAny( _rException ), _rContextDetails );
-}
-
SQLException prependErrorInfo( const SQLException _rChainedException, const
Reference XInterface _rxContext,
const OUString _rAdditionalError, const StandardSQLState _eSQLState,
const sal_Int32 _nErrorCode )
{
diff --git a/include/connectivity/dbtools.hxx b/include/connectivity/dbtools.hxx
index 77ed4fd..02b3f06 100644
--- a/include/connectivity/dbtools.hxx
+++ b/include/connectivity/dbtools.hxx
@@ -302,8 +302,6 @@ namespace dbtools
/** create a new ::com::sun::star::sdbc::SQLContext, fill it with the
given descriptions and the given source,
and iappend/i _rException (i.e. put it into the NextException
member of the SQLContext).
*/
-OOO_DLLPUBLIC_DBTOOLS ::com::sun::star::sdb::SQLContext
prependContextInfo(const ::com::sun::star::sdbc::SQLException _rException,
const ::com::sun::star::uno::Reference ::com::sun::star::uno::XInterface
_rxContext, const OUString _rContextDescription, const OUString
_rContextDetails );
-
OOO_DLLPUBLIC_DBTOOLS
::com::sun::star::sdbc::SQLException prependErrorInfo(
const ::com::sun::star::sdbc::SQLException _rChainedException,
diff --git a/include/sfx2/mnuitem.hxx b/include/sfx2/mnuitem.hxx
index 0d40854..8e5e0cd 100644
--- a/include/sfx2/mnuitem.hxx
+++ b/include/sfx2/mnuitem.hxx
@@ -120,27 +120,13 @@ inline SfxVirtualMenu* SfxMenuControl::GetPopupMenu()
const
{ SfxMenuControl::RegisterMenuControl( pMod, new
SfxMenuCtrlFactory( \
Class::CreateImpl, TYPE(nItemClass), nSlotId ) ); }
-class SfxAppMenuControl_Impl : public SfxMenuControl
+struct ExecuteInfo
{
-PopupMenu* pMenu;
-OUStringm_sIconTheme;
-boolm_bShowMenuImages;
+::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatch
xDispatch;
+::com::sun::star::util::URL
aTargetURL;
+::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue
aArgs;
-protected:
-DECL_LINK_TYPED( Activate, Menu *, bool ); // Needed to support high
contrast images
-
-public:
-SfxAppMenuControl_Impl( sal_uInt16 nPos, Menu rMenu, SfxBindings
rBindings );
-virtual ~SfxAppMenuControl_Impl();
-
-struct ExecuteInfo
-{
-::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatch
xDispatch;
-::com::sun::star::util::URL
aTargetURL;
-::com::sun::star::uno::Sequence
::com::sun::star::beans::PropertyValue aArgs;
-};
-
-DECL_STATIC_LINK( SfxAppMenuControl_Impl, ExecuteHdl_Impl, ExecuteInfo* );
+DECL_STATIC_LINK( ExecuteInfo, ExecuteHdl_Impl, ExecuteInfo* );
};
#endif
diff --git a/include/sot/stg.hxx b/include/sot/stg.hxx
index a6be7ce..5f4ba36 100644
--- a/include/sot/stg.hxx
+++ b/include/sot/stg.hxx
@@ -284,9 +284,7 @@ protected:
virtual ~UCBStorage();
public:
static bool IsStorageFile( SvStream* );
-static bool IsDiskSpannedFile( SvStream* );
static OUString GetLinkedFile( SvStream );
-static OUString CreateLinkFile( const OUString rName );
[Libreoffice-bugs] [Bug 79740] FILESAVE: Field page count is not saved in PPT and PPTX format
https://bugs.documentfoundation.org/show_bug.cgi?id=79740 Yogesh Bharate yogesh.bhar...@synerzip.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Yogesh Bharate yogesh.bhar...@synerzip.com --- As there is functionality in powerpoint to show the slide number. But there is no such function or feature in related to field page count. So, mapping of this feature with powerpoint i.e pptx is not good idea. Therefore, this issue required more info to understand. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88697] FILESAVE: export to word 2003 .doc format formats bibliography entries not appropriately
https://bugs.documentfoundation.org/show_bug.cgi?id=88697 --- Comment #20 from Yury yury.tarasiev...@gmail.com --- Created attachment 115444 -- https://bugs.documentfoundation.org/attachment.cgi?id=115444action=edit patch for 4.3.7.1 enabling the bibliography entries AND index export This patch is against the 4.3.7.1 source and enables the export to word2003 (!) .DOC of both the bibliography entries AND the resulting bibliography list. Implemented with the (more correct) QUOTE field type. Round-trip build test fails (predictably), may ignore, the resulting binary works fine. This works for me adequately, both real word2003 and softmaker freeoffice open my exported biblios okay. Are proofdocs needed? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89061] [TEST] with show advanced fields, anyone can set
https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89061 Philippe Jung phil.j...@free.fr changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Summary|with show advanced fields, |[TEST] with show advanced |anyone can set |fields, anyone can set Ever confirmed|0 |1 --- Comment #1 from Philippe Jung phil.j...@free.fr --- This is a test ticket to check how BZ behaves with locked fields. I can change the status to ASSIGNED. As an external user, I should not be able to change status to ASSIGNED, even if I reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91156] New: FORMATTING: Calc cell grid rendering error
https://bugs.documentfoundation.org/show_bug.cgi?id=91156 Bug ID: 91156 Summary: FORMATTING: Calc cell grid rendering error Product: LibreOffice Version: 4.3.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 9459...@gmail.com Created attachment 115447 -- https://bugs.documentfoundation.org/attachment.cgi?id=115447action=edit XLSX file that rendered with line grid messed up after 20-30 clicks on different cells Picking two different fonts inside the spreadsheet resulted in a peculiar rendering error where the cell grid didn't line up until we scrolled the area off-screen and back on. Example xls file and screenshot attached. To achieve this grid lines mess just click 20-30 times in different cells. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89061] [TEST] with show advanced fields, anyone can set
https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89061 Philippe Jung phil.j...@free.fr changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |INVALID --- Comment #2 from Philippe Jung phil.j...@free.fr --- I reported this and now I mark it invalid because I changed my mind. I will reopen it after that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72205] LibreOffice Database - LONGVARCHAR anomaly when trying to dismiss a window without first saving
https://bugs.documentfoundation.org/show_bug.cgi?id=72205 --- Comment #7 from Alan Wheeler ostersund18...@gmail.com --- Still present in LibreOffice 4.4.3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'private/bubli/sw_16bit'
New branch 'private/bubli/sw_16bit' available with the following commits: commit a98ef8adcc10bec409e8132ace3de1e6606e6c8f Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun Apr 26 13:12:37 2015 +0200 Use auto and range-based for loops Change-Id: I400bce4479eb0ab8105384f88a379c3ea90b9f66 commit 76c34865f595e0f79775d0f3e22e8ff62844867a Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun May 3 19:04:23 2015 +0200 Use range-based for loops Change-Id: I02dbe522c61804e5868b350e99ab02f691f36b0b commit 5b737ca478f70d652ea36338b005425eec8c8f18 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun May 3 19:22:22 2015 +0200 Use auto and range-based for loops Change-Id: I5fecd9cfb64fee9d18e4491e6219c1b90e64ea7c commit b271abe87672881ed0ae94c5f287ac2f93e81815 Author: Matteo Casalin matteo.casa...@yahoo.com Date: Sun May 3 22:28:13 2015 +0200 Use range-based for loops, better integer types and avoid some casts Change-Id: Ife8bb0bb1d20655c0526aad1d4921713c961eb7a commit bde8062181295d832ace1c0f2bc8a54d17da8c0c Author: Katarina Behrens katarina.behr...@cib.de Date: Sun May 3 23:25:52 2015 +0200 tdf#89783: Adjust to new GetPos retval (size_t vs. sal_uInt16) Some of the usages of GetPos were just misusing it to find out whether a vector contains given element -- use Contains() in those cases This patch is partially based on work of Christoph Lutz Conflicts: sw/source/filter/ww8/wrtw8esh.cxx sw/source/filter/ww8/wrtw8num.cxx Change-Id: I40bedba905e7577ba23f69acee178e0ea7cc1521 commit 4925372f705239aebe8424e55df6a2a9718d1174 Author: Vasily Melenchuk vasily.melenc...@cib.de Date: Mon Apr 6 12:23:09 2015 +0300 tdf#89783: sal_uInt16 replacement by size_t: sections These replacements allow LO to load, save and mail merge documents having more than 65536 sections in total. Change-Id: I0e70889b1edc6e472a39f1f2638ac3c70a0d7058 Signed-off-by: Katarina Behrens katarina.behr...@cib.de commit 447de7e569739aa05f9a0dbd1128306c65c457ce Author: Katarina Behrens katarina.behr...@cib.de Date: Wed Apr 29 10:16:19 2015 +0200 tdf#89783: avoid endless loop with 65k style names Change-Id: I09be0ade1cd66253f420c2158ef6c093758ca493 commit ca0579f2bbf0b8bce8b3d3a79931758ebf4bd90e Author: Katarina Behrens katarina.behr...@cib.de Date: Wed Apr 29 10:13:18 2015 +0200 tdf#89783: fix another potential endless loop the same pattern as in 4de83e2c322509c0fb1b989f7e4898728fc4a Change-Id: I38d48b9c1302f23a0d2537f8e5eced2ee64ddf4e commit f3ddeb1d66de742648556fe569ab6638851c8bc2 Author: Christoph Lutz christoph.lutz...@cib.de Date: Tue Apr 28 17:55:11 2015 +0200 tdf#89783: MM fixes potential endless loops with dbgutil build Change-Id: I0eeb0decab588d89881a24983eb89727c3d9151b Reviewed-on: https://gerrit.libreoffice.org/15561 Reviewed-by: Katarina Behrens katarina.behr...@cib.de Tested-by: Katarina Behrens katarina.behr...@cib.de ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91155] Any Unicode character of U+10000 or beyond cannot be rendered in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=91155 --- Comment #1 from yunt...@yeah.net --- I tried LibreOffice Still (4.3.7.2) in Windows 7 x64, the same problem occurs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91125] Crash creating pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=91125 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Michael Meeks michael.me...@collabora.com --- Nice - there are a whole clutch of calc dialogs with the same problem here - all going through one unfortunate function - with a simple fix =) will push shortly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91152] Crash closing floating sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=91152 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Michael Meeks michael.me...@collabora.com --- Thanks =) most likely a duplicate. *** This bug has been marked as a duplicate of bug 91128 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87509] Polygon filling not updated when changing None =Color Black
https://bugs.documentfoundation.org/show_bug.cgi?id=87509 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Summary|Rectangle tool with |Polygon filling not updated |dropdown issues with|when changing None =Color |line/fill color of |Black |none/black | --- Comment #7 from Laurent BP jumbo4...@yahoo.fr --- Update summary in a more general way -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sc/source vcl/README.lifecycle
sc/source/ui/inc/tabvwsh.hxx |6 +++---
sc/source/ui/view/reffact.cxx |2 +-
sc/source/ui/view/tabvwshc.cxx | 11 ++-
vcl/README.lifecycle | 24
4 files changed, 34 insertions(+), 9 deletions(-)
New commits:
commit b6bd432a584c1361ca6277794f8a5466fc01bc52
Author: Michael Meeks michael.me...@collabora.com
Date: Fri May 8 11:34:22 2015 +0100
vcl: more VclPtr debugging docs in the README.lifecycle.
Change-Id: I49d06d54157e1e7c5b7ce2aa3f8917763de6826d
diff --git a/vcl/README.lifecycle b/vcl/README.lifecycle
index 7c2ceb2..55ec160 100644
--- a/vcl/README.lifecycle
+++ b/vcl/README.lifecycle
@@ -299,4 +299,28 @@ ways and often both.
cleanup methods, especially LoseFocus continue to work even
on disposed Window sub-class instances.
+** It crashes with some invalid memory ...
+
+Assuming that the invalid memory is a Window sub-class itself,
+ then almost certainly there is some cockup in the
+ reference-counting; eg. if you hit an OutputDevice::release
+ assert on mnRefCount - then almost certainly you have a
+ Window that has already been destroyed. This can easily
+ happen via this sort of pattern:
+
+ ModelessDialog *pDlg = VclPtrModelessDialog(nullptr /* parent */);
+ // by here the pDlg quite probably points to free'd memory
+ ...
+
+ It is necessary in these cases to ensure that the *pDlg is
+ a VclPtrModelessDialog instead.
+
+** It crashes with some invalid memory #2 ...
+
+ Often a ::dispose method will free some pImpl member, but
+ not NULL it; and (cf. above) we can now get various virtual
+ methods called post-dispose; so:
+
+ a) delete pImpl; pImpl = NULL; // in the destructor
+ b) if (pImpl ...) // in the subsequently called method
commit 087f7fe50b03307e2d9202365886e8c37bd7e6e3
Author: Michael Meeks michael.me...@collabora.com
Date: Fri May 8 11:33:33 2015 +0100
tdf#91125 - nail a clutch of calc modeless dialog lifecycle issues.
Good idea to hold a reference after creation.
Change-Id: I450c415259c4011c8b3fb8be715e55643765d9db
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index 4bc50e5..04e21a9 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -356,9 +356,9 @@ public:
voidDeactivateOle();
SC_DLLPUBLIC static ScTabViewShell* GetActiveViewShell();
-SfxModelessDialog* CreateRefDialog( SfxBindings* pB, SfxChildWindow* pCW,
-SfxChildWinInfo* pInfo,
-vcl::Window* pParent, sal_uInt16
nSlotId );
+VclPtrSfxModelessDialog CreateRefDialog( SfxBindings* pB,
SfxChildWindow* pCW,
+ SfxChildWinInfo* pInfo,
+ vcl::Window* pParent,
sal_uInt16 nSlotId );
voidUpdateOleZoom();
inline SbxObject* GetScSbxObject() const
diff --git a/sc/source/ui/view/reffact.cxx b/sc/source/ui/view/reffact.cxx
index 4ba4eb9..b05db95f 100644
--- a/sc/source/ui/view/reffact.cxx
+++ b/sc/source/ui/view/reffact.cxx
@@ -90,7 +90,7 @@ namespace
pViewShell = PTR_CAST( ScTabViewShell, SfxViewShell::Current() ); \
OSL_ENSURE( pViewShell, missing view shell :-( ); \
pWindow = pViewShell ? \
-pViewShell-CreateRefDialog( p, this, pInfo, pParentP, sid ) :
NULL;\
+pViewShell-CreateRefDialog( p, this, pInfo, pParentP, sid ) :
nullptr;\
if (pViewShell !pWindow)
\
pViewShell-GetViewFrame()-SetChildWindow( nId, false );
\
}
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index fbbfa24..4d5d2d4 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -113,9 +113,10 @@ void
ScTabViewShell::SwitchBetweenRefDialogs(SfxModelessDialog* pDialog)
}
}
-SfxModelessDialog* ScTabViewShell::CreateRefDialog(
-SfxBindings* pB, SfxChildWindow* pCW, SfxChildWinInfo*
pInfo,
-vcl::Window* pParent, sal_uInt16 nSlotId )
+VclPtrSfxModelessDialog ScTabViewShell::CreateRefDialog(
+SfxBindings* pB, SfxChildWindow* pCW,
+SfxChildWinInfo* pInfo,
+vcl::Window* pParent, sal_uInt16 nSlotId )
{
// Dialog nur aufmachen, wenn ueber ScModule::SetRefDialog gerufen, damit
// z.B. nach einem Absturz offene Ref-Dialoge nicht wiederkommen
(#42341#).
@@ -132,7 +133,7 @@ SfxModelessDialog* ScTabViewShell::CreateRefDialog(
return NULL;
}
-SfxModelessDialog* pResult = 0;
+VclPtrSfxModelessDialog pResult;
if(pCW)
pCW-SetHideNotDelete(true);
[Libreoffice-bugs] [Bug 91125] Crash creating pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=91125 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=087f7fe50b03307e2d9202365886e8c37bd7e6e3 tdf#91125 - nail a clutch of calc modeless dialog lifecycle issues. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91125] Crash creating pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=91125 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91091] Copy-paste from read-only file + save hangs entire LibreOffice suite
https://bugs.documentfoundation.org/show_bug.cgi?id=91091 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||vmik...@collabora.co.uk Whiteboard|bibisectRequest |bibisected --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- This appears to have begun at the below commit. Adding Cc: to vmik...@collabora.co.uk; Could you possibly take a look at this one? Thanks (I can't reproduce a hang, although if you paste the *whole* .doc into a presentation slide it's certainly quite slow after) commit 07d01742c69f1c0335bc7e1b57abd8341ce255e7 Author: Miklos Vajna vmik...@suse.cz Date: Thu May 10 16:45:50 2012 +0200 i#119219 fix non-unicode RTF export There were two problems here: - non-unicode charset being set to Shift JIS for all UTF-8 text - non-unicode text using UTF-8 Change-Id: I533d3e950a4ebd611b5d5db8a95e724e729a641f -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - dbaccess/source
dbaccess/source/core/dataaccess/databasecontext.cxx | 10 +-
dbaccess/source/filter/xml/xmlfilter.cxx|4
2 files changed, 13 insertions(+), 1 deletion(-)
New commits:
commit a20d53afb97a278a16ad604cb65f107d33ab4fb9
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 11:14:12 2015 +0200
dbaccess: handle URL mark as StreamRelPath in ODatabaseContext
With this, dbaccess can not only load .odb files, but also other ODF
packages as well, as long as the URL's mark (the part after the #)
contains under what namespace the real .odb is.
This will be used for embedding data source definitions into .odt
documents by Writer in a bit.
Change-Id: Ic1e922418c185fd6ec49d442a3419b80c9a6c76a
diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index e4fb8e6..4e6c185 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -310,9 +310,15 @@ Reference XInterface
ODatabaseContext::getRegisteredObject(const OUString _
return loadObjectFromURL( _rName, sURL );
}
-Reference XInterface ODatabaseContext::loadObjectFromURL(const OUString
_rName,const OUString _sURL)
+Reference XInterface ODatabaseContext::loadObjectFromURL(const OUString
_rName,const OUString rURL)
{
+OUString _sURL(rURL);
INetURLObject aURL( _sURL );
+
+OUString aMark = aURL.GetMark(INetURLObject::DECODE_WITH_CHARSET);
+if (!aMark.isEmpty())
+_sURL = aURL.GetURLNoMark();
+
if ( aURL.GetProtocol() == INetProtocol::NotValid )
throw NoSuchElementException( _rName, *this );
@@ -361,6 +367,8 @@ Reference XInterface
ODatabaseContext::loadObjectFromURL(const OUString _rNa
aArgs.put( URL, _sURL );
aArgs.put( MacroExecutionMode, MacroExecMode::USE_CONFIG );
aArgs.put( InteractionHandler,
task::InteractionHandler::createWithParent(m_aContext, 0) );
+if (!aMark.isEmpty())
+aArgs.put(StreamRelPath, aMark);
Sequence PropertyValue aResource( aArgs.getPropertyValues() );
xLoad-load( aResource );
commit dbab26d1fdcc0891a0f3e098f10a5c98e328a48b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 11:13:27 2015 +0200
dbaccess: handle StreamRelPath in ODBFilter::implImport()
Change-Id: I8a4d21f8bef272a6cdb5a72da274e65516c36617
diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx
b/dbaccess/source/filter/xml/xmlfilter.cxx
index 4d2e8cc..60fd9f3 100644
--- a/dbaccess/source/filter/xml/xmlfilter.cxx
+++ b/dbaccess/source/filter/xml/xmlfilter.cxx
@@ -457,6 +457,10 @@ bool ODBFilter::implImport( const Sequence PropertyValue
rDescriptor )
try
{
xStorage.set(pMedium-GetStorage(false), UNO_QUERY_THROW);
+
+OUString sStreamRelPath =
aMediaDescriptor.getOrDefault(StreamRelPath, OUString());
+if (!sStreamRelPath.isEmpty())
+xStorage = xStorage-openStorageElement(sStreamRelPath,
embed::ElementModes::READ);
}
catch (const Exception)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/oox oox/source
include/oox/helper/attributelist.hxx |3 ---
oox/source/helper/attributelist.cxx |7 ---
2 files changed, 10 deletions(-)
New commits:
commit 80743f11fcdb49f997b0a8ff08bee28a0f2cfce7
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 11:37:45 2015 +0200
Unused oox::AttributeList::getUnsignedHex() variant
Change-Id: I4ec0cd4781aaa905f734b15ba4eff7819ca01082
diff --git a/include/oox/helper/attributelist.hxx
b/include/oox/helper/attributelist.hxx
index 38bdf34..0e5eb5e 100644
--- a/include/oox/helper/attributelist.hxx
+++ b/include/oox/helper/attributelist.hxx
@@ -112,9 +112,6 @@ public:
/** Returns the 32-bit signed integer value of the specified attribute
(hexadecimal). */
OptValue sal_Int32 getIntegerHex( sal_Int32 nAttrToken ) const;
-/** Returns the 32-bit unsigned integer value of the specified attribute
(hexadecimal). */
-OptValue sal_uInt32 getUnsignedHex( sal_Int32 nAttrToken ) const;
-
/** Returns the boolean value of the specified attribute. */
OptValue bool getBool( sal_Int32 nAttrToken ) const;
diff --git a/oox/source/helper/attributelist.cxx
b/oox/source/helper/attributelist.cxx
index 34cd8402..e2e5f9a 100644
--- a/oox/source/helper/attributelist.cxx
+++ b/oox/source/helper/attributelist.cxx
@@ -191,13 +191,6 @@ OptValue sal_Int32 AttributeList::getIntegerHex(
sal_Int32 nAttrToken ) const
return OptValue sal_Int32 ( bValid, bValid ?
AttributeConversion::decodeIntegerHex( aValue ) : 0 );
}
-OptValue sal_uInt32 AttributeList::getUnsignedHex( sal_Int32 nAttrToken )
const
-{
-OUString aValue = mxAttribs-getOptionalValue( nAttrToken );
-bool bValid = !aValue.isEmpty();
-return OptValue sal_uInt32 ( bValid, bValid ?
AttributeConversion::decodeUnsignedHex( aValue ) : 0 );
-}
-
OptValue bool AttributeList::getBool( sal_Int32 nAttrToken ) const
{
const char *pAttr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkgdi.hxx| 17 -- vcl/unx/gtk/app/gtkdata.cxx |1 vcl/unx/gtk/gdi/gtkprintwrapper.cxx | 21 ++ vcl/unx/gtk/window/gtksalframe.cxx|5 vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 18 +- vcl/unx/kde/UnxCommandThread.cxx | 72 vcl/unx/kde/UnxCommandThread.hxx |1 vcl/unx/kde/UnxFilePicker.cxx | 215 +- vcl/unx/kde/UnxFilePicker.hxx |3 vcl/unx/kde/fpicker/kdecommandthread.cxx | 90 +- vcl/unx/kde/fpicker/kdecommandthread.hxx |1 vcl/unx/kde/fpicker/kdefilepicker.cxx | 130 --- vcl/unx/kde/fpicker/kdefilepicker.hxx |4 vcl/unx/kde/salnativewidgets-kde.cxx | 76 - 14 files changed, 344 insertions(+), 310 deletions(-) New commits: commit 79776356d9597f3c0e06f8e81019909bdbb1a560 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 8 11:56:28 2015 +0200 loplugin:staticmethods Change-Id: Ie3629a14c7a15a0f5f93a4bfc663a2bb52a8735d diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx index 2805ef6..68c6cf7 100644 --- a/vcl/inc/unx/gtk/gtkgdi.hxx +++ b/vcl/inc/unx/gtk/gtkgdi.hxx @@ -80,36 +80,35 @@ private: static GtkStyleContext *mpListboxStyle; static GtkStyleContext *mpNoteBookStyle; -void getStyleContext(GtkStyleContext** style, GtkWidget* widget); -Rectangle NWGetScrollButtonRect( ControlPart nPart, Rectangle aAreaRect ); -Rectangle NWGetSpinButtonRect( ControlPart nPart, Rectangle aAreaRect); -Rectangle NWGetComboBoxButtonRect( ControlType nType, ControlPart nPart, Rectangle aAreaRect ); +static Rectangle NWGetScrollButtonRect( ControlPart nPart, Rectangle aAreaRect ); +static Rectangle NWGetSpinButtonRect( ControlPart nPart, Rectangle aAreaRect); +static Rectangle NWGetComboBoxButtonRect( ControlType nType, ControlPart nPart, Rectangle aAreaRect ); -void PaintScrollbar(GtkStyleContext *context, +static void PaintScrollbar(GtkStyleContext *context, cairo_t *cr, const Rectangle rControlRectangle, ControlType nType, ControlPart nPart, const ImplControlValue aValue ); -void PaintOneSpinButton( GtkStyleContext *context, +static void PaintOneSpinButton( GtkStyleContext *context, cairo_t *cr, ControlType nType, ControlPart nPart, Rectangle aAreaRect, ControlState nState ); -void PaintSpinButton(GtkStyleContext *context, +static void PaintSpinButton(GtkStyleContext *context, cairo_t *cr, const Rectangle rControlRectangle, ControlType nType, ControlPart nPart, const ImplControlValue aValue ); -void PaintCombobox( GtkStyleContext *context, +static void PaintCombobox( GtkStyleContext *context, cairo_t *cr, const Rectangle rControlRectangle, ControlType nType, ControlPart nPart, const ImplControlValue aValue ); -void PaintCheckOrRadio(GtkStyleContext *context, +static void PaintCheckOrRadio(GtkStyleContext *context, cairo_t *cr, const Rectangle rControlRectangle, ControlType nType); diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx index d1f594f..0d5aea0 100644 --- a/vcl/unx/gtk/app/gtkdata.cxx +++ b/vcl/unx/gtk/app/gtkdata.cxx @@ -169,6 +169,7 @@ GdkFilterReturn GtkSalDisplay::filterGdkEvent( GdkXEvent* sys_event, return aFilterReturn; #else +(void) this; // loplugin:staticmethods (void) sys_event; //FIXME: implement filterGdkEvent ... return GDK_FILTER_CONTINUE; diff --git a/vcl/unx/gtk/gdi/gtkprintwrapper.cxx b/vcl/unx/gtk/gdi/gtkprintwrapper.cxx index 809ddae..1db42c8 100644 --- a/vcl/unx/gtk/gdi/gtkprintwrapper.cxx +++ b/vcl/unx/gtk/gdi/gtkprintwrapper.cxx @@ -112,6 +112,7 @@ bool GtkPrintWrapper::supportsPrinting() const m_print_unix_dialog_set_settings ; #else +(void) this; // loplugin:staticmethods return true; #endif } @@ -125,6 +126,7 @@ bool GtkPrintWrapper::supportsPrintSelection() const m_print_unix_dialog_set_has_selection ; #else +(void) this; // loplugin:staticmethods return true; #endif } @@ -135,6 +137,7 @@ GtkPageSetup* GtkPrintWrapper::page_setup_new() const assert(m_page_setup_new); return (*m_page_setup_new)(); #else +(void) this; // loplugin:staticmethods return
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/dockwin.cxx | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 1394e45450e58d23223ac3bea264a15e0b2b9078
Author: Michael Meeks michael.me...@collabora.com
Date: Fri May 8 11:07:22 2015 +0100
tdf#91128 - Dockwin post-dispose crash fix.
Change-Id: I46252c272d45209f8cb3fd072df4109440d3fcae
diff --git a/sfx2/source/dialog/dockwin.cxx b/sfx2/source/dialog/dockwin.cxx
index 0c6af19..8b4b8f3 100644
--- a/sfx2/source/dialog/dockwin.cxx
+++ b/sfx2/source/dialog/dockwin.cxx
@@ -450,7 +450,7 @@ void SfxDockingWindow::Resize()
{
DockingWindow::Resize();
Invalidate();
-if ( pImp-bConstructed pMgr )
+if ( pImp pImp-bConstructed pMgr )
{
if ( IsFloatingMode() )
{
@@ -501,7 +501,7 @@ bool SfxDockingWindow::PrepareToggleFloatingMode()
*/
{
-if (!pImp-bConstructed)
+if (!pImp || !pImp-bConstructed)
return true;
if ( (Application::IsInModalMode() IsFloatingMode()) || !pMgr )
@@ -554,7 +554,7 @@ void SfxDockingWindow::ToggleFloatingMode()
SfxDockingWindow::ToggleFloatingMode() must be called.
*/
{
-if ( !pImp-bConstructed || !pMgr )
+if ( !pImp || !pImp-bConstructed || !pMgr )
return; // No Handler call
// Remember old alignment and then switch.
@@ -638,7 +638,7 @@ void SfxDockingWindow::StartDocking()
the end.
*/
{
-if ( !pImp-bConstructed || !pMgr )
+if ( !pImp || !pImp-bConstructed || !pMgr )
return;
SfxChildIdentifier eIdent = SfxChildIdentifier::DOCKINGWINDOW;
if ( pImp-bSplitable )
@@ -672,7 +672,7 @@ bool SfxDockingWindow::Docking( const Point rPos,
Rectangle rRect )
if ( Application::IsInModalMode() )
return true;
-if ( !pImp-bConstructed || !pMgr )
+if ( !pImp || !pImp-bConstructed || !pMgr )
{
rRect.SetSize( Size() );
return IsFloatingMode();
@@ -771,7 +771,7 @@ void SfxDockingWindow::EndDocking( const Rectangle rRect,
bool bFloatMode )
SfxDockingWindow::EndDocking() must be called first.
*/
{
-if ( !pImp-bConstructed || IsDockingCanceled() || !pMgr )
+if ( !pImp || !pImp-bConstructed || IsDockingCanceled() || !pMgr )
return;
SfxWorkWindow *pWorkWin = pBindings-GetWorkWindow_Impl();
@@ -1242,7 +1242,7 @@ void SfxDockingWindow::FillInfo(SfxChildWinInfo rInfo)
const
if ( !pMgr )
return;
-if ( GetFloatingWindow() pImp-bConstructed )
+if ( GetFloatingWindow() pImp pImp-bConstructed )
pImp-aWinState = GetFloatingWindow()-GetWindowState();
rInfo.aWinState = pImp-aWinState;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/evoab2/NResultSet.cxx | 70 +-
connectivity/source/drivers/evoab2/NStatement.cxx | 41 ++---
connectivity/source/drivers/evoab2/NStatement.hxx |4
connectivity/source/drivers/kab/KDriver.cxx | 151 +++---
connectivity/source/drivers/kab/KDriver.hxx | 16 --
5 files changed, 138 insertions(+), 144 deletions(-)
New commits:
commit ece4466e4ff5f89aad0ec88b39269cfac0dc76c3
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 12:27:52 2015 +0200
loplugin:staticmethods
Change-Id: Ic93e560641f1ec1c5fc316ed126617c6d99ab5b5
diff --git a/connectivity/source/drivers/evoab2/NResultSet.cxx
b/connectivity/source/drivers/evoab2/NResultSet.cxx
index 7fc072f..077bf16 100644
--- a/connectivity/source/drivers/evoab2/NResultSet.cxx
+++ b/connectivity/source/drivers/evoab2/NResultSet.cxx
@@ -368,6 +368,18 @@ OString OEvoabVersionHelper::getUserName( EBook *pBook )
return aName;
}
+namespace {
+
+bool isBookBackend( EBookClient *pBook, const char *backendname)
+{
+if (!pBook)
+return false;
+ESource *pSource = e_client_get_source ((EClient *) pBook);
+return isSourceBackend(pSource, backendname);
+}
+
+}
+
class OEvoabVersion36Helper : public OEvoabVersionHelper
{
private:
@@ -416,14 +428,6 @@ public:
return pBook;
}
-bool isBookBackend( EBookClient *pBook, const char *backendname)
-{
-if (!pBook)
-return false;
-ESource *pSource = e_client_get_source ((EClient *) pBook);
-return isSourceBackend(pSource, backendname);
-}
-
virtual bool isLDAP( EBook *pBook ) SAL_OVERRIDE
{
return isBookBackend(pBook, ldap);
@@ -490,37 +494,41 @@ protected:
}
};
-class OEvoabVersion35Helper : public OEvoabVersionHelper
-{
-private:
-GList *m_pContacts;
+namespace {
-ESource * findSource( const char *id )
-{
-ESourceList *pSourceList = NULL;
+ESource * findSource( const char *id )
+{
+ESourceList *pSourceList = NULL;
-g_return_val_if_fail (id != NULL, NULL);
+g_return_val_if_fail (id != NULL, NULL);
-if (!e_book_get_addressbooks (pSourceList, NULL))
-pSourceList = NULL;
+if (!e_book_get_addressbooks (pSourceList, NULL))
+pSourceList = NULL;
-for ( GSList *g = e_source_list_peek_groups (pSourceList); g; g =
g-next)
+for ( GSList *g = e_source_list_peek_groups (pSourceList); g; g = g-next)
+{
+for (GSList *s = e_source_group_peek_sources (E_SOURCE_GROUP
(g-data)); s; s = s-next)
{
-for (GSList *s = e_source_group_peek_sources (E_SOURCE_GROUP
(g-data)); s; s = s-next)
-{
-ESource *pSource = E_SOURCE (s-data);
-if (!strcmp (e_source_peek_name (pSource), id))
-return pSource;
-}
+ESource *pSource = E_SOURCE (s-data);
+if (!strcmp (e_source_peek_name (pSource), id))
+return pSource;
}
-return NULL;
}
+return NULL;
+}
-bool isAuthRequired( EBook *pBook )
-{
-return e_source_get_property( e_book_get_source( pBook ),
- auth ) != NULL;
-}
+bool isAuthRequired( EBook *pBook )
+{
+return e_source_get_property( e_book_get_source( pBook ),
+ auth ) != NULL;
+}
+
+}
+
+class OEvoabVersion35Helper : public OEvoabVersionHelper
+{
+private:
+GList *m_pContacts;
public:
OEvoabVersion35Helper()
diff --git a/connectivity/source/drivers/evoab2/NStatement.cxx
b/connectivity/source/drivers/evoab2/NStatement.cxx
index c824188..f8cb606 100644
--- a/connectivity/source/drivers/evoab2/NStatement.cxx
+++ b/connectivity/source/drivers/evoab2/NStatement.cxx
@@ -49,6 +49,26 @@ using namespace com::sun::star::container;
using namespace com::sun::star::io;
using namespace com::sun::star::util;
+namespace {
+
+EBookQuery * createTrue()
+{ // Not the world's most efficient unconditional true but ...
+return e_book_query_from_string((exists \full_name\));
+}
+
+EBookQuery * createTest( const OUString aColumnName,
+ EBookQueryTest eTest,
+ const OUString aMatch )
+{
+OString sMatch = OUStringToOString( aMatch, RTL_TEXTENCODING_UTF8 );
+OString sColumnName = OUStringToOString( aColumnName,
RTL_TEXTENCODING_UTF8 );
+
+return e_book_query_field_test( e_contact_field_id( sColumnName.getStr() ),
+eTest, sMatch.getStr() );
+}
+
+}
+
OCommonStatement::OCommonStatement(OEvoabConnection* _pConnection)
: OCommonStatement_IBase(m_aMutex)
, ::comphelper::OPropertyContainer(OCommonStatement_IBase::rBHelper)
@@ -152,27 +172,6 @@ void SAL_CALL OCommonStatement::close( )
throw(SQLException, RuntimeException,
dispose();
}
-
-EBookQuery *
-OCommonStatement::createTrue()
-{ // Not
[Libreoffice-bugs] [Bug 77248] 500 page document hogging CPU and crashes randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=77248 David genericinet+libreoffice@gmail.com changed: What|Removed |Added Priority|medium |high Status|NEEDINFO|NEW CC||michael.me...@collabora.com Severity|normal |major --- Comment #15 from David genericinet+libreoffice@gmail.com --- I have confirmed this bug as described in comment 13 on Linux with a newly compiled version 5.0.0.0.alpha1 ID efdd215124df0ab98a33525ac01a9d8ff4a542d4. It did not crash immediately, but after scrolling back forth a bit and selecting various headings and continuing to scroll, it crashed after about maybe a minute. I am having what looks to be like the same issue as this with another file. The crashes seem to have become quite a bit more frequent after the following commit: commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Build dependency on external cppunit
On 05/08/2015 10:45 AM, Richard Cochran wrote: 1. Where is the dependency from sal-cppunit specified? in sal/Executable_cppunittester.mk: $(eval $(call gb_Executable_use_externals,cppunittester,\ boost_headers \ cppunit \ )) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/mnuitem.hxx |9 -
sfx2/source/menu/mnuitem.cxx | 15 ---
2 files changed, 12 insertions(+), 12 deletions(-)
New commits:
commit eef0e91d5ec90d7e972195b8d3b059ffab39c92d
Author: Caolán McNamara caol...@redhat.com
Date: Fri May 8 11:07:10 2015 +0100
there's another ExecuteInfo in sw
Change-Id: Id72d3cdfa8b0d5e62fc04ddc464069ac58df0f58
diff --git a/include/sfx2/mnuitem.hxx b/include/sfx2/mnuitem.hxx
index 8e5e0cd..3f6586f 100644
--- a/include/sfx2/mnuitem.hxx
+++ b/include/sfx2/mnuitem.hxx
@@ -120,15 +120,6 @@ inline SfxVirtualMenu* SfxMenuControl::GetPopupMenu() const
{ SfxMenuControl::RegisterMenuControl( pMod, new
SfxMenuCtrlFactory( \
Class::CreateImpl, TYPE(nItemClass), nSlotId ) ); }
-struct ExecuteInfo
-{
-::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatch
xDispatch;
-::com::sun::star::util::URL
aTargetURL;
-::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue
aArgs;
-
-DECL_STATIC_LINK( ExecuteInfo, ExecuteHdl_Impl, ExecuteInfo* );
-};
-
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/source/menu/mnuitem.cxx b/sfx2/source/menu/mnuitem.cxx
index c3daef0..9d10b93 100644
--- a/sfx2/source/menu/mnuitem.cxx
+++ b/sfx2/source/menu/mnuitem.cxx
@@ -327,6 +327,15 @@ SfxUnoMenuControl::~SfxUnoMenuControl()
pUnoCtrl-release();
}
+struct MenuExecuteInfo
+{
+::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatch
xDispatch;
+::com::sun::star::util::URL
aTargetURL;
+::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue
aArgs;
+
+DECL_STATIC_LINK( MenuExecuteInfo, ExecuteHdl_Impl, MenuExecuteInfo* );
+};
+
sal_IntPtr Select_Impl( void* /*pHdl*/, void* pVoid )
{
Menu* pMenu = static_castMenu*(pVoid);
@@ -360,17 +369,17 @@ sal_IntPtr Select_Impl( void* /*pHdl*/, void* pVoid )
if ( xDisp.is() )
{
-ExecuteInfo* pExecuteInfo = new ExecuteInfo;
+MenuExecuteInfo* pExecuteInfo = new MenuExecuteInfo;
pExecuteInfo-xDispatch = xDisp;
pExecuteInfo-aTargetURL= aTargetURL;
pExecuteInfo-aArgs = Sequence PropertyValue ();
-Application::PostUserEvent( LINK( 0, ExecuteInfo, ExecuteHdl_Impl),
pExecuteInfo );
+Application::PostUserEvent( LINK( 0, MenuExecuteInfo,
ExecuteHdl_Impl), pExecuteInfo );
}
return sal_IntPtr(true);
}
-IMPL_STATIC_LINK_NOINSTANCE( ExecuteInfo, ExecuteHdl_Impl, ExecuteInfo*,
pExecuteInfo )
+IMPL_STATIC_LINK_NOINSTANCE( MenuExecuteInfo, ExecuteHdl_Impl,
MenuExecuteInfo*, pExecuteInfo )
{
pExecuteInfo-xDispatch-dispatch( pExecuteInfo-aTargetURL,
pExecuteInfo-aArgs );
delete pExecuteInfo;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1394e45450e58d23223ac3bea264a15e0b2b9078 tdf#91128 - Dockwin post-dispose crash fix. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87509] Rectangle tool with dropdown issues with line/fill color of none/black
https://bugs.documentfoundation.org/show_bug.cgi?id=87509 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added CC||jumbo4...@yahoo.fr Severity|minor |normal --- Comment #6 from Laurent BP jumbo4...@yahoo.fr --- The bug occurs with all filled polygons or filled curve, whatever the method used to create it: - either with method of comment 1 - or Toolbar Drawing Curve (or Lines) Curve filled, or Polygon filled or Polygon 45° filled or freeform line filled - or draw a regular shape (rectangle, ellipse, basic shapes...) right click Convert To polygon or To curve 1. Once your shape is created, it has now green handle. 2. Change fill color to black (NO bug with other colors). = OK the shape is correctly filled with black 3. Change filling to None = Bug: shape keeps its black filling 4. Click on black and drag the shape = When clicking on black, nothing should happen as there is no filling. But shape is moved. On release, filling is updated to none. You can no more click inside the shape 5. Change filling to Color, Black = Bug: shape stays without filling. You cannot click inside the shape 6. Move the shape = Black filling appears again NO bug if some transparency is defined. Bug appears only between these two states (None = Color Black). If you change .SOC file, so Black is no more the first color (such as html.soc), the bug is still only with Black color. It seems that LibO get confused between no filling and (0,0,0) as code color. Change can be made with toolbar, sidebar, or Format Area dialog UI. My hand made bibisection revealed: - NO bug with LibO 4.0.6 RC2 - bug with Version: 4.1.0.0.alpha1 Build ID: 67ce08e2c64a6615abc90d3a3c442f90d86fa69 I enhance severity to Normal, as there is much more ways to be impacted by the bug. A simple case: open PDF with Draw with some checkbox. If you want to fill checkboxes with black, they appear empty. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62656] FILEOPEN of particular .docx takes 5 to 20 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=62656 --- Comment #23 from Owen Genat owen.ge...@gmail.com --- I think this report can be RESOLVED as INVALID. Without the initial doc it seems unworkable. My interest in getting it resolved is minimal. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83103] Indent spacing after numbering wrong when numbering value has 4 or more characters
https://bugs.documentfoundation.org/show_bug.cgi?id=83103 --- Comment #7 from almos aaalmo...@gmail.com --- I tried this with LO 3.3, and that one positions the lines with a tab for 1-9, and a space for 10-99, which results in good alignment. Starting with 100, however, the alignment is wrong. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Michael Meeks michael.me...@collabora.com --- Fixed locally; will push shortly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91071] function creation (right-clicking always displays the same help-text)
https://bugs.documentfoundation.org/show_bug.cgi?id=91071 --- Comment #11 from gmarco gmmell...@inwind.it --- Now, after updating to LO 4.4.3.2, the problem is same, but in order to see the tooltip I have to check both Suggerimenti and Guida attiva (Tips and Extended tips)on Tools Options General -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91128] LibO crashes when clicking on Navigator in Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=91128 --- Comment #5 from Michael Meeks michael.me...@collabora.com --- *** Bug 91152 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89062] New: Just a severity test..
https://bugzilla-test.documentfoundation.org/show_bug.cgi?id=89062 Bug ID: 89062 Summary: Just a severity test.. Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: blocker Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: todven...@suomi24.fi Severity: blocker -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/sfx2
include/sfx2/sidebar/SidebarToolBox.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 9d74271f742b06306ed10c6a9a7385c75d48fe14 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 8 15:42:37 2015 +0200 Missing from previous commit Change-Id: Ic4ba1f85575047cd03ccca8987b411f6ad2a809a diff --git a/include/sfx2/sidebar/SidebarToolBox.hxx b/include/sfx2/sidebar/SidebarToolBox.hxx index 32db84e..bf1663f 100644 --- a/include/sfx2/sidebar/SidebarToolBox.hxx +++ b/include/sfx2/sidebar/SidebarToolBox.hxx @@ -82,8 +82,8 @@ private: DECL_LINK_TYPED(ClickHandler, ToolBox*, void); DECL_LINK_TYPED(DoubleClickHandler, ToolBox*, void); DECL_LINK_TYPED(SelectHandler, ToolBox*, void); -DECL_LINK_TYPED(ActivateToolBox, ToolBox*, void); -DECL_LINK_TYPED(DeactivateToolBox, ToolBox*, void); +DECL_STATIC_LINK_TYPED(SidebarToolBox, ActivateToolBox, ToolBox*, void); +DECL_STATIC_LINK_TYPED(SidebarToolBox, DeactivateToolBox, ToolBox*, void); void CreateController ( const sal_uInt16 nItemId, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 --- Comment #23 from steve -_- st...@openmailbox.org --- Stuart so should DevEval be used as a keyword? Also what are the next steps for this? Is this on some ESC agenda? Who from UX can we get involved? Is Adolfo cc: already? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 --- Comment #23 from steve -_- st...@openmailbox.org --- Stuart so should DevEval be used as a keyword? Also what are the next steps for this? Is this on some ESC agenda? Who from UX can we get involved? Is Adolfo cc: already? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/jdbc/Reader.cxx | 98 +++-
connectivity/source/inc/java/io/Reader.hxx |2
2 files changed, 85 insertions(+), 15 deletions(-)
New commits:
commit 3af5437e2adf00793404957f30237ba4b9a31772
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri May 8 15:31:06 2015 +0200
jdbc character stream: don't mix up bytes and characters
Change-Id: I59352edd887982faa792b02adbb55c3f67f1d78d
diff --git a/connectivity/source/drivers/jdbc/Reader.cxx
b/connectivity/source/drivers/jdbc/Reader.cxx
index 20db510..f5f7034 100644
--- a/connectivity/source/drivers/jdbc/Reader.cxx
+++ b/connectivity/source/drivers/jdbc/Reader.cxx
@@ -20,6 +20,7 @@
#include java/io/Reader.hxx
#include string.h
using namespace connectivity;
+using ::com::sun::star::uno::Sequence;
// Class: java.io.Reader
@@ -52,11 +53,31 @@ sal_Int32 SAL_CALL java_io_Reader::readSomeBytes(
::com::sun::star::uno::Sequenc
void SAL_CALL java_io_Reader::skipBytes( sal_Int32 nBytesToSkip )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::BufferSizeExceededException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
{
static jmethodID mID(NULL);
-callIntMethodWithIntArg_ThrowRuntime(skip,mID,nBytesToSkip);
+if(nBytesToSkip = 0)
+return;
+
+if(m_buf != boost::none)
+{
+m_buf = boost::none;
+--nBytesToSkip;
+}
+
+static_assert(sizeof(jchar) == 2, I thought Java characters were UTF16
code units?);
+sal_Int32 nCharsToSkip = nBytesToSkip / sizeof(jchar);
+callIntMethodWithIntArg_ThrowRuntime(skip,mID,nCharsToSkip);
+if(nBytesToSkip % sizeof(jchar) != 0)
+{
+assert(nBytesToSkip % sizeof(jchar) == 1);
+Sequence sal_Int8 aData(1);
+assert(m_buf == boost::none);
+readBytes(aData, 1);
+}
}
sal_Int32 SAL_CALL java_io_Reader::available( )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
{
+if(m_buf != boost::none)
+return 1;
jboolean out;
SDBThreadAttach t; OSL_ENSURE(t.pEnv,Java Enviroment geloescht worden!);
@@ -69,7 +90,7 @@ sal_Int32 SAL_CALL java_io_Reader::available( )
throw(::com::sun::star::io::Not
out = t.pEnv-CallBooleanMethod( object, mID);
ThrowRuntimeException(t.pEnv,*this);
} //t.pEnv
-return out ? 1 : 0; // no way to tell *how much* is ready
+return (m_buf != boost::none) + (out ? 1 : 0); // no way to tell *how
much* is ready
}
void SAL_CALL java_io_Reader::closeInput( )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
@@ -80,31 +101,78 @@ void SAL_CALL java_io_Reader::closeInput( )
throw(::com::sun::star::io::NotConn
sal_Int32 SAL_CALL java_io_Reader::readBytes( ::com::sun::star::uno::Sequence
sal_Int8 aData, sal_Int32 nBytesToRead )
throw(::com::sun::star::io::NotConnectedException,
::com::sun::star::io::BufferSizeExceededException,
::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException,
std::exception)
{
-OSL_ENSURE(aData.getLength() nBytesToRead, Sequence is smaller than
BytesToRead);
-jint out(0);
+OSL_ENSURE(aData.getLength() = nBytesToRead, Sequence is smaller than
BytesToRead);
+
+if(nBytesToRead == 0)
+return 0;
+
+sal_Int8 *dst(aData.getArray());
+sal_Int32 nBytesWritten(0);
+
+if(m_buf != boost::none)
+{
+if(aData.getLength() == 0)
+{
+aData.realloc(1);
+dst = aData.getArray();
+}
+*dst = *m_buf;
+m_buf = boost::none;
+++nBytesWritten;
+++dst;
+--nBytesToRead;
+}
+
+if(nBytesToRead == 0)
+return 0;
+
+sal_Int32 nCharsToRead = (nBytesToRead + 1)/2;
+
+jint outChars(0);
SDBThreadAttach t; OSL_ENSURE(t.pEnv,Java Enviroment geloescht worden!);
{
-jcharArray pCharArray = t.pEnv-NewCharArray(nBytesToRead);
+jcharArray pCharArray = t.pEnv-NewCharArray(nCharsToRead);
static const char * cSignature = ([CII)I;
static const char * cMethodName = read;
// Java-Call
static jmethodID mID(NULL);
obtainMethodId_throwRuntime(t.pEnv, cMethodName,cSignature, mID);
-out = t.pEnv-CallIntMethod( object, mID, pCharArray, 0, nBytesToRead
);
-if ( !out )
-ThrowRuntimeException(t.pEnv,*this);
-if(out 0)
+outChars = t.pEnv-CallIntMethod( object, mID, pCharArray, 0,
nCharsToRead );
+if ( !outChars )
+{
+if(nBytesWritten==0)
+ThrowRuntimeException(t.pEnv,*this);
+else
+return 1;
+}
+if(outChars 0)
{
-jboolean p = sal_False;
-
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/jdbc/Reader.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8f90336948770350c75c445d478c04107e5cef6e Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 8 15:54:02 2015 +0200 loplugin:implicitboolconversion Change-Id: Iec38fdf8c165d1121e74f7221b49ca49f808ac03 diff --git a/connectivity/source/drivers/jdbc/Reader.cxx b/connectivity/source/drivers/jdbc/Reader.cxx index f5f7034..cd4 100644 --- a/connectivity/source/drivers/jdbc/Reader.cxx +++ b/connectivity/source/drivers/jdbc/Reader.cxx @@ -90,7 +90,7 @@ sal_Int32 SAL_CALL java_io_Reader::available( ) throw(::com::sun::star::io::Not out = t.pEnv-CallBooleanMethod( object, mID); ThrowRuntimeException(t.pEnv,*this); } //t.pEnv -return (m_buf != boost::none) + (out ? 1 : 0); // no way to tell *how much* is ready +return (m_buf != boost::none out) ? 1 : 0; // no way to tell *how much* is ready } void SAL_CALL java_io_Reader::closeInput( ) throw(::com::sun::star::io::NotConnectedException, ::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException, std::exception) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66353] DATALOSS: **Expression is faulty** in cells with formulas containing both references to this table and another table cells after paste to this table
https://bugs.documentfoundation.org/show_bug.cgi?id=66353 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #6 from Mike Kaganski mikekagan...@hotmail.com --- Submitted patch to gerrit: https://gerrit.libreoffice.org/15678 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/modules/installer/simplepackage.pm |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 81802cfa7cb04f770e57413dbeb2c852c2431e65
Author: Andras Timar andras.ti...@collabora.com
Date: Fri May 8 16:46:12 2015 +0200
OS X SDK.app build fix
Change-Id: Ib6f34f833a6fbaa8038796d86accd385b2a21a44
diff --git a/solenv/bin/modules/installer/simplepackage.pm
b/solenv/bin/modules/installer/simplepackage.pm
index d470b4e..d70394e 100644
--- a/solenv/bin/modules/installer/simplepackage.pm
+++ b/solenv/bin/modules/installer/simplepackage.pm
@@ -393,7 +393,7 @@ sub create_package
chdir $localfrom;
}
-else
+elsif ($volume_name_classic_app eq 'LibreOffice' ||
$volume_name_classic_app eq 'LibreOfficeDev')
{
my $subdir =
$tempdir/$packagename/$volume_name_classic_app.app/Contents/Resources;
if ( ! -d $subdir ) {
installer::systemactions::create_directory($subdir); }
@@ -402,8 +402,7 @@ sub create_package
{
installer::systemactions::create_directory($subdir . / .
$lang . .lproj);
}
-if (($volume_name_classic_app eq 'LibreOffice' ||
$volume_name_classic_app eq 'LibreOfficeDev')
-defined($ENV{'MACOSX_CODESIGNING_IDENTITY'})
$ENV{'MACOSX_CODESIGNING_IDENTITY'} ne )
+if ( defined($ENV{'MACOSX_CODESIGNING_IDENTITY'})
$ENV{'MACOSX_CODESIGNING_IDENTITY'} ne )
{
$systemcall =
$ENV{'SRCDIR'}/solenv/bin/macosx-codesign-app-bundle
$localtempdir/$folder/$volume_name_classic_app.app;
print ... $systemcall ...\n;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: four changes of suspicious code (connectivity, sc, sw, editeng)
Hi Stephan, On Fri, May 08, 2015 at 10:23:37AM +0200, Stephan Bergmann sberg...@redhat.com wrote: diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx b/sw/source/core/doc/DocumentStylePoolManager.cxx index 3276b9f4..8d4fe0e 100644 --- a/sw/source/core/doc/DocumentStylePoolManager.cxx +++ b/sw/source/core/doc/DocumentStylePoolManager.cxx @@ -1318,7 +1318,7 @@ SwFmt* DocumentStylePoolManager::GetFmtFromPool( sal_uInt16 nId ) aSet.Put( SwFmtAnchor( FLY_AT_PAGE )); aSet.Put( SwFmtHoriOrient( 0, text::HoriOrientation::CENTER, text::RelOrientation::FRAME )); aSet.Put( SwFmtVertOrient( 0, text::VertOrientation::CENTER, text::RelOrientation::FRAME )); -aSet.Put( SvxOpaqueItem( sal_False )); +aSet.Put( SvxOpaqueItem( RES_OPAQUE, false )); That's correct. The authorative source about which pool item should have what which id in case of sw is sw/source/core/bastyp/init.cxx AFAIK, and that has: aAttrTab[ RES_OPAQUE- POOLATTR_BEGIN ] =new SvxOpaqueItem( RES_OPAQUE ); Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - compilerplugins/clang sd/source sw/inc sw/source
compilerplugins/clang/staticmethods.cxx |2 +-
sd/source/ui/dlg/navigatr.cxx |3 ++-
sd/source/ui/inc/navigatr.hxx |2 +-
sw/inc/dbmgr.hxx|2 +-
sw/source/core/doc/doc.cxx |2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit aa50b1c03f18a10c281786c69e24d8255613ac5a
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 16:57:23 2015 +0200
Enable loplugin:staticmethods
Change-Id: Ic0062eddebf9225d298569bb4900047a0ee0b112
diff --git a/compilerplugins/clang/staticmethods.cxx
b/compilerplugins/clang/staticmethods.cxx
index a0d6099..decb3ff 100644
--- a/compilerplugins/clang/staticmethods.cxx
+++ b/compilerplugins/clang/staticmethods.cxx
@@ -206,7 +206,7 @@ bool StaticMethods::TraverseCXXMethodDecl(const
CXXMethodDecl * pCXXMethodDecl)
return true;
}
-loplugin::Plugin::RegistrationStaticMethods X(staticmethods, false);
+loplugin::Plugin::RegistrationStaticMethods X(staticmethods);
}
commit 516d3007444fe2dd07b2cde24066637281c2a217
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 16:57:03 2015 +0200
loplugin:staticmethods
Change-Id: I0041724d340bf75a184910805f7f927efb3b2131
diff --git a/sw/inc/dbmgr.hxx b/sw/inc/dbmgr.hxx
index e5f719c..dfcd231 100644
--- a/sw/inc/dbmgr.hxx
+++ b/sw/inc/dbmgr.hxx
@@ -371,7 +371,7 @@ public:
const
::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet
*pSettings = 0);
/// Load the embedded data source of the document and also register it.
-void LoadAndRegisterEmbeddedDataSource(const SwDBData rData, const
SwDocShell rDocShell);
+static void LoadAndRegisterEmbeddedDataSource(const SwDBData rData, const
SwDocShell rDocShell);
/** try to get the data source from the given connection through the
XChild interface.
If this is not possible, the data source will be created through its
name.
diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index 4886e29..9c3e75f 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -495,7 +495,7 @@ void SwDoc::ChgDBData(const SwDBData rNewData)
if( rNewData != maDBData )
{
if (maDBData.sEmbeddedName != rNewData.sEmbeddedName GetDocShell())
-mpDBManager-LoadAndRegisterEmbeddedDataSource(rNewData,
*GetDocShell());
+SwDBManager::LoadAndRegisterEmbeddedDataSource(rNewData,
*GetDocShell());
maDBData = rNewData;
getIDocumentState().SetModified();
commit 7fabc2300bc7255c839eb42c2185cad92029009d
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 16:57:00 2015 +0200
loplugin:staticmethods
Change-Id: I33d722c27d85732d23510ebaaaba0b8792d0d61d
diff --git a/sd/source/ui/dlg/navigatr.cxx b/sd/source/ui/dlg/navigatr.cxx
index ec19ebf..1f891e5 100644
--- a/sd/source/ui/dlg/navigatr.cxx
+++ b/sd/source/ui/dlg/navigatr.cxx
@@ -313,7 +313,8 @@ IMPL_LINK_NOARG_TYPED(SdNavigatorWin, SelectToolboxHdl,
ToolBox *, void)
}
}
-IMPL_LINK_NOARG_TYPED(SdNavigatorWin, ClickToolboxHdl, ToolBox *, void)
+IMPL_STATIC_LINK_NOINSTANCE_NOARG_TYPED(
+SdNavigatorWin, ClickToolboxHdl, ToolBox *, void)
{}
IMPL_LINK_TYPED( SdNavigatorWin, DropdownClickToolBoxHdl, ToolBox*, pBox, void
)
diff --git a/sd/source/ui/inc/navigatr.hxx b/sd/source/ui/inc/navigatr.hxx
index 77b7a7e..e16e21e 100644
--- a/sd/source/ui/inc/navigatr.hxx
+++ b/sd/source/ui/inc/navigatr.hxx
@@ -146,7 +146,7 @@ private:
DECL_LINK( GetFocusObjectsHdl, void * );
DECL_LINK_TYPED( SelectToolboxHdl, ToolBox *,
void );
-DECL_LINK_TYPED(ClickToolboxHdl, ToolBox *,
void);
+DECL_STATIC_LINK_TYPED(SdNavigatorWin,
ClickToolboxHdl, ToolBox *, void);
DECL_LINK_TYPED( DropdownClickToolBoxHdl,
ToolBox *, void );
DECL_LINK( ClickPageHdl, void * );
DECL_LINK( ClickObjectHdl, void * );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91164] PDF: When exporting to PDF before some non-breaking hyphens are inserted spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=91164 --- Comment #1 from deepjungle.m...@gmail.com --- Created attachment 115451 -- https://bugs.documentfoundation.org/attachment.cgi?id=115451action=edit PDF export -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62656] FILEOPEN of particular .docx takes 5 to 20 minutes
https://bugs.documentfoundation.org/show_bug.cgi?id=62656 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Build dependency on external cppunit
On Fri, May 08, 2015 at 02:48:53PM +0200, Miklos Vajna wrote: Hi Richard, On Fri, May 08, 2015 at 02:12:45PM +0200, Richard Cochran richardcoch...@gmail.com wrote: Can't I just force cppunit to build manually beforehand? make cppunit.all Tried that already, too. Here is what I got: PARALLELISM=1 make cppunit.all GMAKE_OPTIONS='VERBOSE=1' make[1]: Entering directory '/mnt/storage/git/libreoffice' ... mkdir -p /mnt/storage/git/libreoffice/workdir/Dep/CxxObject/UnoControls/source/base/ mkdir -p /mnt/storage/git/libreoffice/workdir/Dep/CxxObject/UnoControls/source/controls/ [build MOD] cppunit S=/mnt/storage/git/libreoffice I=$S/instdir W=$S/workdir mkdir -p $W/Module/ touch $W/Module/cppunit make[1]: Leaving directory '/mnt/storage/git/libreoffice' The 'touch' is the only result! I should probably add that I am trying to cross compile LO (I know, I know, don't ask why), and it is clear that building cross is not fully implemented, but in this case I think it should still work. Should do that, though you just hide the root cause with that. :-) Yep. Unfortunately I am having a hard time understanding how this build system is supposed to work, otherwise I would fix it and send a patch! Thanks, Richard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/inc/virtmenu.hxx |2 +-
sfx2/source/menu/virtmenu.cxx |3 ++-
sfx2/source/sidebar/SidebarToolBox.cxx |6 --
3 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 7314fc7b9436ac44dbf0e5fece8c156a19ef3861
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 15:41:52 2015 +0200
loplugin:staticmethods
Change-Id: I9b661dc67ccbdcb757d661168b4c3fa4b6f5b1fa
diff --git a/sfx2/source/inc/virtmenu.hxx b/sfx2/source/inc/virtmenu.hxx
index 48b5064..c71c9c0 100644
--- a/sfx2/source/inc/virtmenu.hxx
+++ b/sfx2/source/inc/virtmenu.hxx
@@ -69,7 +69,7 @@ protected:
SfxBindings rBind, bool bOLEServer=false, bool
bRes=false, bool bIsAddonMenu=false );
voidCreateFromSVMenu();
-DECL_LINK_TYPED( Highlight, Menu *, bool );
+DECL_STATIC_LINK_TYPED( SfxVirtualMenu, Highlight, Menu *, bool );
DECL_LINK_TYPED( Activate, Menu *, bool );
DECL_LINK_TYPED( Deactivate, Menu *, bool );
DECL_LINK( SettingsChanged, void* );
diff --git a/sfx2/source/menu/virtmenu.cxx b/sfx2/source/menu/virtmenu.cxx
index 93e729e..1161585 100644
--- a/sfx2/source/menu/virtmenu.cxx
+++ b/sfx2/source/menu/virtmenu.cxx
@@ -483,7 +483,8 @@ void SfxVirtualMenu::CreateFromSVMenu()
// called on activation of the SV-Menu
-IMPL_LINK_NOARG_TYPED( SfxVirtualMenu, Highlight, Menu *, bool )
+IMPL_STATIC_LINK_NOINSTANCE_NOARG_TYPED(
+SfxVirtualMenu, Highlight, Menu *, bool )
{
return true;
diff --git a/sfx2/source/sidebar/SidebarToolBox.cxx
b/sfx2/source/sidebar/SidebarToolBox.cxx
index ce0c7bd..18c3b29 100644
--- a/sfx2/source/sidebar/SidebarToolBox.cxx
+++ b/sfx2/source/sidebar/SidebarToolBox.cxx
@@ -273,10 +273,12 @@ IMPL_LINK_TYPED(SidebarToolBox, SelectHandler, ToolBox*,
pToolBox, void)
xController-execute((sal_Int16)pToolBox-GetModifier());
}
-IMPL_LINK_NOARG_TYPED(SidebarToolBox, ActivateToolBox, ToolBox*, void)
+IMPL_STATIC_LINK_NOINSTANCE_NOARG_TYPED(
+SidebarToolBox, ActivateToolBox, ToolBox*, void)
{}
-IMPL_LINK_NOARG_TYPED(SidebarToolBox, DeactivateToolBox, ToolBox*, void)
+IMPL_STATIC_LINK_NOINSTANCE_NOARG_TYPED(
+SidebarToolBox, DeactivateToolBox, ToolBox*, void)
{}
} } // end of namespace sfx2::sidebar
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/jdbc/Reader.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2c70139d6a8d8fabd671455d3edd32117783d4d7 Author: Stephan Bergmann sberg...@redhat.com Date: Fri May 8 16:16:35 2015 +0200 ...or rather, like this Change-Id: I87b547b76f6e214730757bec375b1d7b3d5d8f41 diff --git a/connectivity/source/drivers/jdbc/Reader.cxx b/connectivity/source/drivers/jdbc/Reader.cxx index cd4..be913dd 100644 --- a/connectivity/source/drivers/jdbc/Reader.cxx +++ b/connectivity/source/drivers/jdbc/Reader.cxx @@ -90,7 +90,7 @@ sal_Int32 SAL_CALL java_io_Reader::available( ) throw(::com::sun::star::io::Not out = t.pEnv-CallBooleanMethod( object, mID); ThrowRuntimeException(t.pEnv,*this); } //t.pEnv -return (m_buf != boost::none out) ? 1 : 0; // no way to tell *how much* is ready +return (m_buf != boost::none ? 1 : 0) + (out ? 1 : 0); // no way to tell *how much* is ready } void SAL_CALL java_io_Reader::closeInput( ) throw(::com::sun::star::io::NotConnectedException, ::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException, std::exception) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build dependency on external cppunit
On Fri, May 08, 2015 at 04:53:49PM +0200, Miklos Vajna wrote: On Fri, May 08, 2015 at 03:55:35PM +0200, Richard Cochran richardcoch...@gmail.com wrote: Ok, it is somehow related to the cross compile configuration. The 'make cppunit.all' works as expected with a native build. Isn't the very point of cross-compilation that the resulting binary is not something you can run? If so, I find it a feature that unit tests are not built / executed when cross-compiling. :-) Yes, *I* would say so, but the LO build thinks otherwise! I specifically did 'make build' in order to avoid the tests, but the build system compiles the tests anyhow. There are LOTS of other ways in which cross compile is broken. It seems clear that it really isn't supported or tested, and so I don't expect too much. My goal is just to get it working, somehow, for a particular setup. In any case: if test $cross_compiling != yes; then libo_CHECK_SYSTEM_MODULE([cppunit],[CPPUNIT],[cppunit = 1.12.0]) fi in configure.ac where cppunit is disabled in case of cross-compiling. Ok, I'll take a look. Thanks, Richard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-ux-advise] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks|88001 | Whiteboard||needsDevEval topicUI --- Comment #24 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to steve -_- from comment #23) Stuart so should DevEval be used as a keyword? Also what are the next steps for this? Is this on some ESC agenda? Who from UX can we get involved? Is Adolfo cc: already? Not a keyword, rather have set the correct Whiteboard of needsDevEval topicUI The BZ blocks field distributes this via META to those with interest in the UI and UX of the StartCenter. So the correct folks are already involved. Somewhat related, with some 400 valid BZ issues tagged ux-advise in various states of UI design and UX review this is just one issue. We have a current Design UI/UX Team AI to fully triage/prioritize and assign as needed needsDevEval topicUI. The challenge is presenting this and its related fiends forward as cohesive enhancements for developer attention. This is part of a larger issue of how the modules and UI behaves within a session, for each of the OS builds. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 88001] Default document view, force single page rather than automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=88001 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on|75644 | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 80976] UI: save dialog partially in English - make it use the UI language
https://bugs.documentfoundation.org/show_bug.cgi?id=80976 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Adolfo Jayme f...@libreoffice.org --- *** This bug has been marked as a duplicate of bug 78834 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91164] New: PDF: When exporting to PDF before some non-breaking hyphens are inserted spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=91164 Bug ID: 91164 Summary: PDF: When exporting to PDF before some non-breaking hyphens are inserted spaces Product: LibreOffice Version: 4.4.2.2 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: deepjungle.m...@gmail.com Created attachment 115450 -- https://bugs.documentfoundation.org/attachment.cgi?id=115450action=edit Testing file When exporting to PDF before some non-breaking hyphens are inserted spaces. See attachmented Writer document with a basic text. The problem occurrs in LibreOffice 4.4 as in LibreOffice 5.0 alpha1 versions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/menu/mnuitem.cxx | 16
1 file changed, 16 deletions(-)
New commits:
commit e1c6c850b7c478a672dc914e60e87bc0ce4506fc
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri May 8 15:41:23 2015 +0200
Remove dead code
Change-Id: I3684210a180a3044ac52c3cd92a3184fc349e40d
diff --git a/sfx2/source/menu/mnuitem.cxx b/sfx2/source/menu/mnuitem.cxx
index 6cbd552..8ff9a78 100644
--- a/sfx2/source/menu/mnuitem.cxx
+++ b/sfx2/source/menu/mnuitem.cxx
@@ -325,20 +325,4 @@ SfxUnoMenuControl::~SfxUnoMenuControl()
pUnoCtrl-release();
}
-struct MenuExecuteInfo
-{
-::com::sun::star::uno::Reference ::com::sun::star::frame::XDispatch
xDispatch;
-::com::sun::star::util::URL
aTargetURL;
-::com::sun::star::uno::Sequence ::com::sun::star::beans::PropertyValue
aArgs;
-
-DECL_STATIC_LINK( MenuExecuteInfo, ExecuteHdl_Impl, MenuExecuteInfo* );
-};
-
-IMPL_STATIC_LINK_NOINSTANCE( MenuExecuteInfo, ExecuteHdl_Impl,
MenuExecuteInfo*, pExecuteInfo )
-{
-pExecuteInfo-xDispatch-dispatch( pExecuteInfo-aTargetURL,
pExecuteInfo-aArgs );
-delete pExecuteInfo;
-return 0;
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/app/sdxfer.cxx | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
New commits:
commit 7b2367f868778739fba382a68a35248904cc9565
Author: Caolán McNamara caol...@redhat.com
Date: Fri May 8 15:49:08 2015 +0100
misspell some words, copy and paste slide to gimp
and we don't want to see the mis-spelt underlines
Change-Id: Ib3ae29297a1697e0f7b0caa816504da7edf721d1
diff --git a/sd/source/ui/app/sdxfer.cxx b/sd/source/ui/app/sdxfer.cxx
index 044f680..587ead7 100644
--- a/sd/source/ui/app/sdxfer.cxx
+++ b/sd/source/ui/app/sdxfer.cxx
@@ -518,13 +518,27 @@ bool SdTransferable::GetData( const DataFlavor rFlavor,
const OUString rDestDo
}
else if( nFormat == SotClipboardFormatId::GDIMETAFILE )
{
-if( mpSdViewIntern )
+if (mpSdViewIntern)
+{
+const bool bToggleOnlineSpell = mpSdDrawDocumentIntern
mpSdDrawDocumentIntern-GetOnlineSpell();
+if (bToggleOnlineSpell)
+mpSdDrawDocumentIntern-SetOnlineSpell(false);
bOK = SetGDIMetaFile( mpSdViewIntern-GetMarkedObjMetaFile(
true ), rFlavor );
+if (bToggleOnlineSpell)
+mpSdDrawDocumentIntern-SetOnlineSpell(true);
+}
}
else if( SotClipboardFormatId::BITMAP == nFormat ||
SotClipboardFormatId::PNG == nFormat )
{
-if( mpSdViewIntern )
+if (mpSdViewIntern)
+{
+const bool bToggleOnlineSpell = mpSdDrawDocumentIntern
mpSdDrawDocumentIntern-GetOnlineSpell();
+if (bToggleOnlineSpell)
+mpSdDrawDocumentIntern-SetOnlineSpell(false);
bOK = SetBitmapEx( mpSdViewIntern-GetMarkedObjBitmapEx(true),
rFlavor );
+if (bToggleOnlineSpell)
+mpSdDrawDocumentIntern-SetOnlineSpell(true);
+}
}
else if( ( nFormat == SotClipboardFormatId::STRING ) mpBookmark )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build dependency on external cppunit
On Fri, May 08, 2015 at 03:55:35PM +0200, Richard Cochran richardcoch...@gmail.com wrote: Ok, it is somehow related to the cross compile configuration. The 'make cppunit.all' works as expected with a native build. Isn't the very point of cross-compilation that the resulting binary is not something you can run? If so, I find it a feature that unit tests are not built / executed when cross-compiling. :-) In any case: if test $cross_compiling != yes; then libo_CHECK_SYSTEM_MODULE([cppunit],[CPPUNIT],[cppunit = 1.12.0]) fi in configure.ac where cppunit is disabled in case of cross-compiling. signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: libreofficekit/qa
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
New commits:
commit 40ad68bbe7cd1c86a8ebefb1539fb7b403506792
Author: Pranav Kant pranav...@gmail.com
Date: Fri May 8 19:19:57 2015 +0530
gtktiledviewer: Stop event propagation to GtkToolbar when in edit mode
If not stopped, key-press events are interpreted by both LOKDocView and
GtkToolbar leading to poor editing experience.
Change-Id: Ie878d168e202a0f3e1d52191aa3fd7cc00a7cbfd
Reviewed-on: https://gerrit.libreoffice.org/15677
Tested-by: Miklos Vajna vmik...@collabora.co.uk
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 14cf767..cb84ee7 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -132,12 +132,17 @@ void toggleFindbar(GtkWidget* /*pButton*/, gpointer
/*pItem*/)
}
/// Handles the key-press-event of the window.
-static void signalKey(GtkWidget* pWidget, GdkEventKey* pEvent, gpointer pData)
+static gboolean signalKey(GtkWidget* pWidget, GdkEventKey* pEvent, gpointer
pData)
{
+LOKDocView* pLOKDocView = LOK_DOCVIEW(pDocView);
#if GTK_CHECK_VERSION(2,18,0) // we need gtk_widget_get_visible()
-if (!gtk_widget_get_visible(pFindbar))
-lok_docview_post_key(pWidget, pEvent, pData);
+if (!gtk_widget_get_visible(pFindbar)
bool(lok_docview_get_edit(pLOKDocView)))
+{
+lok_docview_post_key(pWidget, pEvent, pData);
+return TRUE;
+}
#endif
+return FALSE;
}
/// Searches for the next or previous text of pFindbarEntry.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source sw/source
dbaccess/source/core/dataaccess/databasecontext.cxx | 16 +++-
sw/source/uibase/dbui/dbmgr.cxx |9 ++---
2 files changed, 17 insertions(+), 8 deletions(-)
New commits:
commit 12bb6a054d697efddee76269605ed2450a2fae9c
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 16:49:06 2015 +0200
dbaccess, sw: use vnd.sun.star.pkg:// for embedded data source handling
Change-Id: I69eaf2e4dd051d62f56caef962d40889cc3a3876
diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index 4e6c185..2332ced 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -315,9 +315,15 @@ Reference XInterface
ODatabaseContext::loadObjectFromURL(const OUString _rNa
OUString _sURL(rURL);
INetURLObject aURL( _sURL );
-OUString aMark = aURL.GetMark(INetURLObject::DECODE_WITH_CHARSET);
-if (!aMark.isEmpty())
-_sURL = aURL.GetURLNoMark();
+OUString sStreamRelPath;
+if (_sURL.startsWithIgnoreAsciiCase(vnd.sun.star.pkg:))
+{
+// In this case the host contains the real path, and the the path is
the embedded stream name.
+_sURL = aURL.GetHost(INetURLObject::DECODE_WITH_CHARSET);
+sStreamRelPath = aURL.GetURLPath(INetURLObject::DECODE_WITH_CHARSET);
+if (sStreamRelPath.startsWith(/))
+sStreamRelPath = sStreamRelPath.copy(1);
+}
if ( aURL.GetProtocol() == INetProtocol::NotValid )
throw NoSuchElementException( _rName, *this );
@@ -367,8 +373,8 @@ Reference XInterface
ODatabaseContext::loadObjectFromURL(const OUString _rNa
aArgs.put( URL, _sURL );
aArgs.put( MacroExecutionMode, MacroExecMode::USE_CONFIG );
aArgs.put( InteractionHandler,
task::InteractionHandler::createWithParent(m_aContext, 0) );
-if (!aMark.isEmpty())
-aArgs.put(StreamRelPath, aMark);
+if (!sStreamRelPath.isEmpty())
+aArgs.put(StreamRelPath, sStreamRelPath);
Sequence PropertyValue aResource( aArgs.getPropertyValues() );
xLoad-load( aResource );
diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 042a0bd..3f81f2e 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -2631,9 +2631,12 @@ void
SwDBManager::LoadAndRegisterEmbeddedDataSource(const SwDBData rData, const
if (xDatabaseContext-hasByName(rData.sDataSource))
xDatabaseContext-revokeObject(rData.sDataSource);
-INetURLObject aURLObject(rDocShell.GetMedium()-GetURLObject());
-aURLObject.SetMark(rData.sEmbeddedName);
-OUString aURL = aURLObject.GetMainURL(INetURLObject::DECODE_WITH_CHARSET);
+// Encode the stream name and the real path into a single URL.
+const INetURLObject rURLObject = rDocShell.GetMedium()-GetURLObject();
+OUString aURL = vnd.sun.star.pkg://;
+aURL +=
INetURLObject::encode(rURLObject.GetMainURL(INetURLObject::DECODE_WITH_CHARSET),
INetURLObject::PART_AUTHORITY, INetURLObject::ENCODE_ALL);
+aURL += / + INetURLObject::encode(rData.sEmbeddedName,
INetURLObject::PART_FPATH, INetURLObject::ENCODE_ALL);
+
uno::Referenceuno::XInterface
xDataSource(xDatabaseContext-getByName(aURL), uno::UNO_QUERY);
xDatabaseContext-registerObject(rData.sDataSource, xDataSource);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88001] Default document view, force single page rather than automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=88001 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on|75644 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75644] Start Center better options to control LibO window resize of the start screen (StartModule) and last used window size of each document module (Summary comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Blocks|88001 | Whiteboard||needsDevEval topicUI --- Comment #24 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to steve -_- from comment #23) Stuart so should DevEval be used as a keyword? Also what are the next steps for this? Is this on some ESC agenda? Who from UX can we get involved? Is Adolfo cc: already? Not a keyword, rather have set the correct Whiteboard of needsDevEval topicUI The BZ blocks field distributes this via META to those with interest in the UI and UX of the StartCenter. So the correct folks are already involved. Somewhat related, with some 400 valid BZ issues tagged ux-advise in various states of UI design and UX review this is just one issue. We have a current Design UI/UX Team AI to fully triage/prioritize and assign as needed needsDevEval topicUI. The challenge is presenting this and its related fiends forward as cohesive enhancements for developer attention. This is part of a larger issue of how the modules and UI behaves within a session, for each of the OS builds. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 Bug 42082 depends on bug 80976, which changed state. Bug 80976 Summary: UI: save dialog partially in English - make it use the UI language https://bugs.documentfoundation.org/show_bug.cgi?id=80976 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/dbmgr.hxx|4
sw/source/core/doc/doc.cxx |4
sw/source/uibase/dbui/dbmgr.cxx | 14 ++
3 files changed, 22 insertions(+)
New commits:
commit 358a7ca728dced8ca41ad79a7c54a6c2408807b1
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri May 8 14:58:55 2015 +0200
Add SwDBManager::LoadAndRegisterEmbeddedDataSource
With this, if a .odt document has an embedded data source definition,
referred as EmbeddedDatabaseName in settings.xml, then that data source
gets registered when opening the document.
Change-Id: Ibd836fe11c0e74e8ea10e357886e6266e9ba0db0
diff --git a/sw/inc/dbmgr.hxx b/sw/inc/dbmgr.hxx
index d420a8a..e5f719c 100644
--- a/sw/inc/dbmgr.hxx
+++ b/sw/inc/dbmgr.hxx
@@ -77,6 +77,7 @@ class SwXMailMerge;
class SwMailMergeConfigItem;
class SwCalc;
class INetURLObject;
+class SwDocShell;
enum DBManagerOptions
{
@@ -369,6 +370,9 @@ public:
static OUStringLoadAndRegisterDataSource(const OUString rURI,
const OUString *pPrefix = 0, const OUString *pDestDir = 0,
const
::com::sun::star::uno::Reference ::com::sun::star::beans::XPropertySet
*pSettings = 0);
+/// Load the embedded data source of the document and also register it.
+void LoadAndRegisterEmbeddedDataSource(const SwDBData rData, const
SwDocShell rDocShell);
+
/** try to get the data source from the given connection through the
XChild interface.
If this is not possible, the data source will be created through its
name.
@param _xConnection
diff --git a/sw/source/core/doc/doc.cxx b/sw/source/core/doc/doc.cxx
index 80de11e..4886e29 100644
--- a/sw/source/core/doc/doc.cxx
+++ b/sw/source/core/doc/doc.cxx
@@ -38,6 +38,7 @@
#include DocumentLayoutManager.hxx
#include DocumentExternalDataManager.hxx
#include UndoManager.hxx
+#include dbmgr.hxx
#include hintids.hxx
#include tools/globname.hxx
#include svx/svxids.hrc
@@ -493,6 +494,9 @@ void SwDoc::ChgDBData(const SwDBData rNewData)
{
if( rNewData != maDBData )
{
+if (maDBData.sEmbeddedName != rNewData.sEmbeddedName GetDocShell())
+mpDBManager-LoadAndRegisterEmbeddedDataSource(rNewData,
*GetDocShell());
+
maDBData = rNewData;
getIDocumentState().SetModified();
}
diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 0574eb4..042a0bd 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -2624,6 +2624,20 @@ OUString SwDBManager::LoadAndRegisterDataSource(const
OUString rURI, const OUSt
return LoadAndRegisterDataSource( type, aURLAny, pSettings, rURI, pPrefix,
pDestDir );
}
+void SwDBManager::LoadAndRegisterEmbeddedDataSource(const SwDBData rData,
const SwDocShell rDocShell)
+{
+uno::Referencesdb::XDatabaseContext xDatabaseContext =
sdb::DatabaseContext::create(comphelper::getProcessComponentContext());
+
+if (xDatabaseContext-hasByName(rData.sDataSource))
+xDatabaseContext-revokeObject(rData.sDataSource);
+
+INetURLObject aURLObject(rDocShell.GetMedium()-GetURLObject());
+aURLObject.SetMark(rData.sEmbeddedName);
+OUString aURL = aURLObject.GetMainURL(INetURLObject::DECODE_WITH_CHARSET);
+uno::Referenceuno::XInterface
xDataSource(xDatabaseContext-getByName(aURL), uno::UNO_QUERY);
+xDatabaseContext-registerObject(rData.sDataSource, xDataSource);
+}
+
void SwDBManager::ExecuteFormLetter( SwWrtShell rSh,
const SequencePropertyValue rProperties,
bool bWithDataSourceBrowser)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: four changes of suspicious code (connectivity, sc, sw, editeng)
On Fri, May 08, 2015 at 01:01:40PM +0200, Lionel Elie Mamane wrote: On Fri, May 08, 2015 at 10:23:37AM +0200, Stephan Bergmann wrote: One is in connectivity (Lionel, do you happen to know how to trigger that code?): I uploaded a trigger case to http://people.freedesktop.org/~lmamane/trigger-java_io_Reader::available.odb Enable macros and run the macro Main in Module1 in that file. I tried it, and it doesn't work. In my tests, HSQLDB's Clob.getCharacterStream().ready() returns true even at end-of-file. So we might return 1 although we should return 0. Since the documentation says: Note: This method offers no information on whether the EOF has been reached., I suggest to just let it slide and be like that: we return 1 even at EOF. This whole class is a mess. It confuses the notion of byte and the notion of character. In Java, and also in LibreOffice, a character is *two* bytes. I'm hesitating between: 1) Unimplementing getCharacterStream in the SDBC-JDBC driver 2) Having it just call getBinaryStream (which uses java_io_InputStream) 3) Fixing java_io_Reader to properly handle the bytes - character conversion, (which is annoying because it will have to do its own buffering for when an odd number of bytes is read...). I took option 3. Pushing soon. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/pagedlg/scuitphfedit.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit c1405651f6c0c8e519e0aed3f12473499d8ed942 Author: Katarina Behrens katarina.behr...@cib.de Date: Fri May 8 15:18:34 2015 +0200 tdf#90257: Prevent dialog from growing out of the screen when large font sizes are used. Set size request on 1 edit widget (+- match what used to be in the old .src file), the remaining two are in the same grid, so this will hopefull do the trick Change-Id: I3ca27ea4d037cf8877f022c1ee5ed7f348b0cfdd diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx b/sc/source/ui/pagedlg/scuitphfedit.cxx index f5c4fe8..5bfa114 100644 --- a/sc/source/ui/pagedlg/scuitphfedit.cxx +++ b/sc/source/ui/pagedlg/scuitphfedit.cxx @@ -132,6 +132,12 @@ ScHFEditPage::ScHFEditPage( vcl::Window* pParent, m_pWndCenter-SetFont( aPatAttr ); m_pWndRight-SetFont( aPatAttr ); +// Set size request of 1 widget, the other two will follow as they are +// in the same grid +Size aSize = LogicToPixel(Size(80, 120), MAP_APPFONT); +m_pWndLeft-set_width_request(aSize.Width()); +m_pWndLeft-set_height_request(aSize.Height()); + m_pWndLeft-SetObjectSelectHdl( LINK(this,ScHFEditPage,ObjectSelectHdl) ); m_pWndCenter-SetObjectSelectHdl( LINK(this,ScHFEditPage,ObjectSelectHdl) ); m_pWndRight-SetObjectSelectHdl( LINK(this,ScHFEditPage,ObjectSelectHdl) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build dependency on external cppunit
On Fri, May 08, 2015 at 03:31:39PM +0200, Richard Cochran wrote: I should probably add that I am trying to cross compile LO (I know, I know, don't ask why), and it is clear that building cross is not fully implemented, but in this case I think it should still work. Ok, it is somehow related to the cross compile configuration. The 'make cppunit.all' works as expected with a native build. Sigh, Richard ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 75458] writer 4.2.1.1 changes formatting of imported Word doc
https://bugs.documentfoundation.org/show_bug.cgi?id=75458 --- Comment #3 from Ed Attfield attfi...@rogers.com --- Retested in 4.4.3.2 by downloading the amd64 version for Ubuntu. + /usr/local/bin/libreoffice4.4 --version LibreOffice 4.4.3.2 88805f81e9fe61362df02b9941de8e38a9b5fd16 + /usr/local/bin/libreoffice4.4 RegistrationForm2014.doc -- still puts the document onto 3 pages instead of 2. uname -a says 3.13.0-51-generic #84-Ubuntu SMP Wed Apr 15 12:08:34 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux ubuntu version seems to be 14.04.2 (64 bit) + java -version java version 1.7.0_79 OpenJDK Runtime Environment (IcedTea 2.5.5) (7u79-2.5.5-0ubuntu0.14.04.2) OpenJDK 64-Bit Server VM (build 24.79-b02, mixed mode) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91027] Crash when creating a brand hsqldb embedded base
https://bugs.documentfoundation.org/show_bug.cgi?id=91027 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Judging from the trace, prolly a dup - thanks for reporting ! =) *** This bug has been marked as a duplicate of bug 91157 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
