[Libreoffice-bugs] [Bug 91222] VclBuilder constructor cleanup ...
https://bugs.documentfoundation.org/show_bug.cgi?id=91222 --- Comment #2 from Michael Meeks michael.me...@collabora.com --- Heh - so, I've no idea how well all the C / linking declarations go with templates; we need: extern C SAL_DLLPUBLIC_EXPORT void SAL_CALL as a prefix; at least for me that's easy to do via macros. Either way - whatever we do - having constructors that take the property map, and simple one-line factory definitions would be nice; then we can do what we want there =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88295] FILEOPEN: White Background Appears in Impress Text Boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=88295 --- Comment #11 from godlike godlik...@gmail.com --- For anybody wondering, yes this is still an issue and yes there's a workaround. I had created a presentation with a black background and experienced the exact same symptoms when saving and opening it later. If I focus the text box, the problem is gone (until I unfocus). The workaround I found is to (ugh) export to ppt. Opening the ppt does not render this problem -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85356] Hindi script improperly rendered in LibreOffice (in some cases)
https://bugs.documentfoundation.org/show_bug.cgi?id=85356 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |INVALID --- Comment #4 from Beluga todven...@suomi24.fi --- Jeff: thanks for checking back, I'll close as INVALID then. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #11 from Robert Antoni Buj i Gelonch robert@gmail.com --- Yes, the incorrect Outline Numbering is the reason for generating invalid output. Because headers can't be within a numbering list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91252] Radial gradient exported as path instead of gradient in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=91252 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Component|Impress |Printing and PDF export -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91254] Very strange EMF+ corruption on Linux and OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=91254 --- Comment #4 from Andras Timar tima...@gmail.com --- Created attachment 115551 -- https://bugs.documentfoundation.org/attachment.cgi?id=115551action=edit LibreOffice in OS X -- all but text are missing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91254] Very strange EMF+ corruption on Linux and OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=91254 --- Comment #3 from Andras Timar tima...@gmail.com --- Created attachment 115550 -- https://bugs.documentfoundation.org/attachment.cgi?id=115550action=edit LibreOffice in Linux -- lines missing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - compilerplugins/clang include/vcl sc/source sw/inc sw/source vcl/source
compilerplugins/clang/vclwidgets.cxx | 33 +++--
include/vcl/lazydelete.hxx| 18 +-
sc/source/ui/pagedlg/scuitphfedit.cxx |2 +-
sc/source/ui/pagedlg/tphfedit.cxx |2 +-
sw/inc/viewsh.hxx | 10 +-
sw/source/core/view/viewsh.cxx|2 +-
sw/source/uibase/inc/view.hxx | 16
sw/source/uibase/uiview/view.cxx |7 ---
vcl/source/helper/lazydelete.cxx |4 ++--
vcl/source/window/window.cxx |4 ++--
10 files changed, 52 insertions(+), 46 deletions(-)
New commits:
commit 4eb16dab21e3e6f47e899060e28ccc515e47316f
Author: Noel Grandin n...@peralex.com
Date: Wed May 13 12:16:55 2015 +0200
wrap some static fields in VclPtr
Change-Id: I2df0929d1b34b9ebf2d5d4c27321abdea072007a
diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx
b/sc/source/ui/pagedlg/scuitphfedit.cxx
index f7063f8..6de4ed6 100644
--- a/sc/source/ui/pagedlg/scuitphfedit.cxx
+++ b/sc/source/ui/pagedlg/scuitphfedit.cxx
@@ -51,7 +51,7 @@
// STATIC DATA ---
-static ScEditWindow* pActiveEdWnd = NULL;
+static VclPtrScEditWindow pActiveEdWnd = NULL;
// class ScHFEditPage
diff --git a/sc/source/ui/pagedlg/tphfedit.cxx
b/sc/source/ui/pagedlg/tphfedit.cxx
index a01a89f..cb6d90b 100644
--- a/sc/source/ui/pagedlg/tphfedit.cxx
+++ b/sc/source/ui/pagedlg/tphfedit.cxx
@@ -48,7 +48,7 @@
#include boost/scoped_ptr.hpp
// STATIC DATA ---
-static ScEditWindow* pActiveEdWnd = NULL;
+static VclPtrScEditWindow pActiveEdWnd = NULL;
ScEditWindow* GetScEditWindow ()
{
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index fb1f9c7..fee06ba 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -187,8 +187,8 @@ class SW_DLLPUBLIC SwViewShell : public
sw::RingSwViewShell
SAL_DLLPRIVATE void ImplApplyViewOptions( const SwViewOption rOpt );
protected:
-static ShellResource* mpShellRes; /// Resources for the Shell.
-static vcl::Window* mpCareWindow;/// Avoid this window.
+static ShellResource* mpShellRes; /// Resources for the Shell.
+static VclPtrvcl::Window mpCareWindow;/// Avoid this window.
SwRect maVisArea; /// The modern version of
VisArea.
SwDoc *mpDoc; /// The document; never 0.
@@ -440,9 +440,9 @@ public:
static ShellResource* GetShellRes();
static void SetCareWin( vcl::Window* pNew );
-static vcl::Window*GetCareWin(SwViewShell rVSh)
- { return mpCareWindow ? mpCareWindow :
CareChildWin(rVSh); }
-static vcl::Window*CareChildWin(SwViewShell rVSh);
+static vcl::Window* GetCareWin(SwViewShell rVSh)
+ { return mpCareWindow ? mpCareWindow.get() :
CareChildWin(rVSh); }
+static vcl::Window* CareChildWin(SwViewShell rVSh);
inline SfxViewShell *GetSfxViewShell() { return mpSfxViewShell; }
inline void SetSfxViewShell(SfxViewShell *pNew) { mpSfxViewShell
= pNew; }
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index c9b92fb..7d5495c 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -85,7 +85,7 @@
bool SwViewShell::mbLstAct = false;
ShellResource *SwViewShell::mpShellRes = 0;
-vcl::Window *SwViewShell::mpCareWindow = 0;
+VclPtrvcl::Window SwViewShell::mpCareWindow = nullptr;
BitmapEx* SwViewShell::mpErrorBmp = NULL;
BitmapEx* SwViewShell::mpReplaceBmp = NULL;
diff --git a/sw/source/uibase/inc/view.hxx b/sw/source/uibase/inc/view.hxx
index 6f0cec2..c89d330 100644
--- a/sw/source/uibase/inc/view.hxx
+++ b/sw/source/uibase/inc/view.hxx
@@ -153,14 +153,14 @@ class SW_DLLPUBLIC SwView: public SfxViewShell
friend class SwClipboardChangeListener;
// search replace
-static SvxSearchDialog *m_pSrchDlg;
-static SvxSearchItem *m_pSrchItem;
-
-static sal_uInt16 m_nInsertCtrlState;
-static sal_uInt16 m_nWebInsertCtrlState;
-static sal_uInt16 m_nInsertObjectCtrlState;
-static sal_uInt16 m_nInsertFieldCtrlState;
-static sal_uInt16 m_nMoveType; // for buttons below the
scrollbar (viewmdi)
+static VclPtrSvxSearchDialog m_pSrchDlg;
+static SvxSearchItem *m_pSrchItem;
+
+static sal_uInt16 m_nInsertCtrlState;
+static sal_uInt16 m_nWebInsertCtrlState;
+static sal_uInt16 m_nInsertObjectCtrlState;
+static sal_uInt16 m_nInsertFieldCtrlState;
+static sal_uInt16 m_nMoveType; // for buttons below the scrollbar
(viewmdi)
static sal_Int32m_nActMark; // current jump mark for unknown mark
static bool m_bExtra;
diff --git a/sw/source/uibase/uiview/view.cxx
[Libreoffice-bugs] [Bug 91257] Cells show wrong numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=91257 --- Comment #1 from q...@bk.ru --- Created attachment 115556 -- https://bugs.documentfoundation.org/attachment.cgi?id=115556action=edit Example where to find this problem -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91257] New: Cells show wrong numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=91257 Bug ID: 91257 Summary: Cells show wrong numbers Product: LibreOffice Version: 4.4.3.2 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: q...@bk.ru Created attachment 11 -- https://bugs.documentfoundation.org/attachment.cgi?id=11action=edit File with a bug In file (see attachment test.ods) created and edited with LibreOffice we found a bug with cells content when you double click it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: slideshow/source slideshow/test
slideshow/source/engine/animationnodes/basecontainernode.cxx |7 ++---
slideshow/source/engine/shapes/backgroundshape.cxx | 10 +++
slideshow/source/engine/shapes/drawshape.cxx | 10 +++
slideshow/source/engine/slide/layermanager.cxx | 14 +++
slideshow/source/engine/tools.cxx| 14 ++-
slideshow/source/engine/unoviewcontainer.cxx |9 +++
slideshow/source/inc/listenercontainer.hxx |8 ++
slideshow/test/testshape.cxx |4 +--
8 files changed, 28 insertions(+), 48 deletions(-)
New commits:
commit 19ba9e08cab4ff75595f53b9689989495ff5f625
Author: Takeshi Abe t...@fixedpoint.jp
Date: Tue May 12 19:54:36 2015 +0900
slideshow: simplify code by replacing std::find_if by
std::any_of/std::none_of
Change-Id: Ib8eec5074e82127e11f4fba2c0b143ab8cef3bcc
Reviewed-on: https://gerrit.libreoffice.org/15714
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/slideshow/source/engine/animationnodes/basecontainernode.cxx
b/slideshow/source/engine/animationnodes/basecontainernode.cxx
index cc1eb68..a3c73e8 100644
--- a/slideshow/source/engine/animationnodes/basecontainernode.cxx
+++ b/slideshow/source/engine/animationnodes/basecontainernode.cxx
@@ -94,10 +94,9 @@ bool BaseContainerNode::hasPendingAnimation() const
// does any of our children returns true on
// AnimationNode::hasPendingAnimation()?
// If yes, we, too, return true
-VectorOfNodes::const_iterator const iEnd( maChildren.end() );
-return (std::find_if(
-maChildren.begin(), iEnd,
-boost::mem_fn(AnimationNode::hasPendingAnimation) ) != iEnd);
+return std::any_of(
+maChildren.begin(), maChildren.end(),
+boost::mem_fn(AnimationNode::hasPendingAnimation) );
}
void BaseContainerNode::appendChildNode( AnimationNodeSharedPtr const pNode )
diff --git a/slideshow/source/engine/shapes/backgroundshape.cxx
b/slideshow/source/engine/shapes/backgroundshape.cxx
index f820a26..762c05c 100644
--- a/slideshow/source/engine/shapes/backgroundshape.cxx
+++ b/slideshow/source/engine/shapes/backgroundshape.cxx
@@ -169,16 +169,14 @@ namespace slideshow
void BackgroundShape::addViewLayer( const ViewLayerSharedPtr
rNewLayer,
bool
bRedrawLayer )
{
-ViewBackgroundShapeVector::iterator aEnd( maViewShapes.end() );
-
// already added?
-if( ::std::find_if( maViewShapes.begin(),
-aEnd,
-::boost::bindbool(
+if( ::std::any_of( maViewShapes.begin(),
+ maViewShapes.end(),
+ ::boost::bindbool(
::std::equal_to ViewLayerSharedPtr (),
::boost::bind(
ViewBackgroundShape::getViewLayer,
_1 ),
-::boost::cref( rNewLayer ) ) ) != aEnd )
+::boost::cref( rNewLayer ) ) ) )
{
// yes, nothing to do
return;
diff --git a/slideshow/source/engine/shapes/drawshape.cxx
b/slideshow/source/engine/shapes/drawshape.cxx
index 7c77a3c..875dffe 100644
--- a/slideshow/source/engine/shapes/drawshape.cxx
+++ b/slideshow/source/engine/shapes/drawshape.cxx
@@ -632,16 +632,14 @@ namespace slideshow
void DrawShape::addViewLayer( const ViewLayerSharedPtr rNewLayer,
bool bRedrawLayer )
{
-ViewShapeVector::iterator aEnd( maViewShapes.end() );
-
// already added?
-if( ::std::find_if( maViewShapes.begin(),
-aEnd,
-::boost::bindbool(
+if( ::std::any_of( maViewShapes.begin(),
+ maViewShapes.end(),
+ ::boost::bindbool(
::std::equal_to ViewLayerSharedPtr (),
::boost::bind( ViewShape::getViewLayer,
_1 ),
-::boost::cref( rNewLayer ) ) ) != aEnd )
+::boost::cref( rNewLayer ) ) ))
{
// yes, nothing to do
return;
diff --git a/slideshow/source/engine/slide/layermanager.cxx
b/slideshow/source/engine/slide/layermanager.cxx
index c46b902..7e02799 100644
--- a/slideshow/source/engine/slide/layermanager.cxx
+++ b/slideshow/source/engine/slide/layermanager.cxx
@@ -488,13 +488,9 @@ namespace slideshow
[Libreoffice-bugs] [Bug 91257] Cells show wrong numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=91257 --- Comment #3 from q...@bk.ru --- No. This file was earlier created with Ctrl+C and Ctrl+V from another program. And now copying from that program is correct. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48047] Impress FILEOPEN: pptx with table, formatting of table is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=48047 Timur gti...@gmail.com changed: What|Removed |Added Keywords|regression | Status|NEW |RESOLVED Resolution|--- |FIXED Whiteboard|PreBibisect |PreBibisect |Confirmed:4.2.0.2:OSX |Confirmed:4.2.0.2:OSX BSA ||target:5.0.0 --- Comment #12 from Timur gti...@gmail.com --- As noted in Bug 80340 - thanks to Yogesh: yogesh.bharate001 committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f2c8194f485b1527fb4f4dfe23ce804937f1f9c tdf#80340: Table changes format in PPTX format It will be available in 5.0.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91116] UI: List Styles of Formatting and Styles highlights the first style in Hierarchical view of paragraph with no numbering style
https://bugs.documentfoundation.org/show_bug.cgi?id=91116 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 Severity|normal |minor --- Comment #1 from Beluga todven...@suomi24.fi --- Reproduced. Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64) Build ID: ddb3c4531c657cda6ae20dd950020cea1d12ba2e TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-11_00:25:02 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry starmath/uiconfig
officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu |7 +-- starmath/uiconfig/smath/menubar/menubar.xml |1 - starmath/uiconfig/smath/ui/dockingelements.ui |2 +- 3 files changed, 2 insertions(+), 8 deletions(-) New commits: commit edf3c40421c193a0603d220d50320c9953cfb9ed Author: Adolfo Jayme Barrientos fit...@ubuntu.com Date: Wed May 13 04:41:18 2015 -0500 tdf#68871 Nuke old Elements box from menu, rename new pane Change-Id: I22301e72a8cb8d11ad35ea63e6361b56e7c7e867 diff --git a/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu index fc99e06..eda6c08 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu @@ -151,14 +151,9 @@ value1/value /prop /node - node oor:name=.uno:ToolBox oor:op=replace -prop oor:name=Label oor:type=xs:string - value xml:lang=en-USElements/value -/prop - /node node oor:name=.uno:ElementsDockingWindow oor:op=replace prop oor:name=Label oor:type=xs:string - value xml:lang=en-USElements Dock/value + value xml:lang=en-USElements/value /prop /node node oor:name=.uno:FormelCursor oor:op=replace diff --git a/starmath/uiconfig/smath/menubar/menubar.xml b/starmath/uiconfig/smath/menubar/menubar.xml index 3468d43..5a8edbb 100644 --- a/starmath/uiconfig/smath/menubar/menubar.xml +++ b/starmath/uiconfig/smath/menubar/menubar.xml @@ -80,7 +80,6 @@ menu:menuitem menu:id=.uno:AvailableToolbars/ menu:menuitem menu:id=.uno:StatusBarVisible/ menu:menuitem menu:id=.uno:ShowImeStatusWindow/ - menu:menuitem menu:id=.uno:ToolBox/ menu:menuitem menu:id=.uno:ElementsDockingWindow/ menu:menuseparator/ menu:menuitem menu:id=.uno:TaskPane/ diff --git a/starmath/uiconfig/smath/ui/dockingelements.ui b/starmath/uiconfig/smath/ui/dockingelements.ui index b963054..79dd567 100644 --- a/starmath/uiconfig/smath/ui/dockingelements.ui +++ b/starmath/uiconfig/smath/ui/dockingelements.ui @@ -8,7 +8,7 @@ property name=hexpandTrue/property property name=vexpandTrue/property property name=border_width6/property -property name=title translatable=yesElements Dock/property +property name=title translatable=yesElements/property property name=type_hintdock/property child object class=GtkGrid id=grid1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #14 from Robert Antoni Buj i Gelonch robert@gmail.com --- Created attachment 115558 -- https://bugs.documentfoundation.org/attachment.cgi?id=115558action=edit Outline numbering has been fixed in test case document: exporting output -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - bin/rename-sw-abbreviations.sh sw/source
bin/rename-sw-abbreviations.sh |6 +++---
sw/source/uibase/config/StoredChapterNumbering.cxx |6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 0d7a34d11f05dfdb010fce43710a3f03a931616c
Author: Jan Holesovsky ke...@collabora.com
Date: Wed May 13 11:27:23 2015 +0200
rename-sw-abbreviations.sh: More stuff that must stay verbatim.
diff --git a/bin/rename-sw-abbreviations.sh b/bin/rename-sw-abbreviations.sh
index ccaab39..dc1bf93 100755
--- a/bin/rename-sw-abbreviations.sh
+++ b/bin/rename-sw-abbreviations.sh
@@ -16,8 +16,8 @@ for I in FrmFmt/FrameFormat Fmt/Format Cntnt/Content
Txt/Text Tbl/Table
do
S=${I%/*}
# change all except the filenames (in the .mk and in #include)
-# also avoid XML_numFmt, that's a token name
-git grep -l $S sw/ | grep -v -e '\.mk' -e '/data/' | xargs sed -i
'/\(#include\|XML_numFmt\)/ !{ s/'$I'/g }'
+# also avoid numFmt (OOXML token) and other stuff that must stay verbatim
+git grep -l $S sw/ | grep -v -e '\.mk' -e '/data/' | xargs sed -i
'/\(#include\|numFmt\|ForeignTxt\)/ !{ s/'$I'/g }'
done
# global:
@@ -40,4 +40,4 @@ do
git grep -l $S | grep -v -e '\.mk' -e 'rename-sw-abbreviations.sh' |
xargs sed -i s/$I/g
done
-# vim: set noet sw=4 ts=4:
+# vim: set et sw=4 ts=4 textwidth=0:
commit c6b00f6b277e5751f6fe5e3366e33ac19fcbf729
Author: Jan Holesovsky ke...@collabora.com
Date: Wed May 13 11:26:31 2015 +0200
sw: Rename variable.
diff --git a/sw/source/uibase/config/StoredChapterNumbering.cxx
b/sw/source/uibase/config/StoredChapterNumbering.cxx
index 1621841..df5388c 100644
--- a/sw/source/uibase/config/StoredChapterNumbering.cxx
+++ b/sw/source/uibase/config/StoredChapterNumbering.cxx
@@ -154,15 +154,15 @@ public:
static_cast ::cppu::OWeakObject*(this), 1);
SolarMutexGuard g;
-SwNumFmt numFmt;
+SwNumFmt aNumberFormat;
OUString charStyleName;
SwXNumberingRules::SetPropertiesToNumFmt(
-numFmt,
+aNumberFormat,
charStyleName,
0, 0, 0, 0, 0,
props);
SwNumRulesWithName *const pRules(GetOrCreateRules());
-pRules-SetNumFmt(nIndex, numFmt, charStyleName);
+pRules-SetNumFmt(nIndex, aNumberFormat, charStyleName);
}
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91255] New: FILESAVE: after particular XLSX saving text properties are lost
https://bugs.documentfoundation.org/show_bug.cgi?id=91255 Bug ID: 91255 Summary: FILESAVE: after particular XLSX saving text properties are lost Product: LibreOffice Version: 4.4.3.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kaktebyaviru...@gmail.com Created attachment 115552 -- https://bugs.documentfoundation.org/attachment.cgi?id=115552action=edit Example_32_1.xlsx - original file LibreOffice Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: ru_RU on Russian Windows XP Professional SP3 (32bit) If we try to open Example_32_1.xlsx file in LibreOffice 4.4.3.2 and make any changes (for example, in cell D22 we change 0 - 1), save file in existent format (Microsoft Excel 2007/2010 XML (.xlsx)) and close LibreOffice after that, then the next time we try to open that file (see Example_32_4_4_3_2.xlsx) we see that some text properties are lost (font and backround colors lost, ...). For example, rows 30, 47, 62, 82, 84, 86, 88, ... lost text and background colors, cells D41:D46, D60, D75:D77, D80:D81 lost background colors. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91256] New: Installation asks to close Google Chrome
https://bugs.documentfoundation.org/show_bug.cgi?id=91256 Bug ID: 91256 Summary: Installation asks to close Google Chrome Product: LibreOffice Version: 4.4.3.2 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sarentasci...@hotmail.com Created attachment 115554 -- https://bugs.documentfoundation.org/attachment.cgi?id=115554action=edit Installation asks me to close Google Chrome During the installation of LibreOffice (in my case this was to update current 4.2 version), the installation asks me to close Google Chrome to proceed with the installation. I don't which files the installation tries to update, which are used by Google Chrome. But I think this is a weird behavior. I suppose, LibreOffice only may ask to close itself and not another program. Please excuse me if there is a very valid explanation/scenario for this behavior, which I did not consider. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svtools/source vcl/source
svtools/source/config/colorcfg.cxx |2 +-
vcl/source/app/settings.cxx|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 595a109f8f5cd19cc72e1e44f2ae111427bb4330
Author: Adolfo Jayme Barrientos fit...@ubuntu.com
Date: Wed May 13 05:43:03 2015 -0500
Slightly darken default workspace again to be easier on the eyes
Restoring the fix for tdf#79278 and tdf#72142, which was inadvertently
dropped,
but with a better color.
Change-Id: Ifa5a85e5113713d6eff706a542d475a19caa0c13
diff --git a/svtools/source/config/colorcfg.cxx
b/svtools/source/config/colorcfg.cxx
index c1323cf..9689be6 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -420,7 +420,7 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry eEntry)
{
COL_WHITE, // DOCCOLOR
0xc0c0c0, // DOCBOUNDARIES
-0xCFCFCF, // APPBACKGROUND
+0xDFDFDE, // APPBACKGROUND
COL_LIGHTGRAY, // OBJECTBOUNDARIES
COL_LIGHTGRAY, // TABLEBOUNDARIES
COL_BLACK, // FONTCOLOR
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
index 52b5055..5d59336 100644
--- a/vcl/source/app/settings.cxx
+++ b/vcl/source/app/settings.cxx
@@ -716,7 +716,7 @@ void ImplStyleData::SetStandardStyles()
maWindowTextColor = Color( COL_BLACK );
maDialogColor = Color( COL_LIGHTGRAY );
maDialogTextColor = Color( COL_BLACK );
-maWorkspaceColor= Color( 0xF0, 0xF0, 0xF0 );
+maWorkspaceColor= Color( 0xDF, 0xDF, 0xDE );
maMonoColor = Color( COL_BLACK );
maFieldColor= Color( COL_WHITE );
maFieldTextColor= Color( COL_BLACK );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/source vcl/unx
vcl/inc/unx/gtk/gtkgdi.hxx|9 -
vcl/source/control/ilstbox.cxx|2
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 182 +++---
3 files changed, 114 insertions(+), 79 deletions(-)
New commits:
commit 7343e171256f16e86b3c43aca6412c738c89c3d4
Author: Caolán McNamara caol...@redhat.com
Date: Tue May 12 21:06:48 2015 +0100
gtk3: stop painting the active listboxes blue
gtk3 equivalents are comboboxes without entries and
those don't do this
Change-Id: I71efe2c11a1d604e6c15927844f5a25b78771e62
diff --git a/vcl/source/control/ilstbox.cxx b/vcl/source/control/ilstbox.cxx
index bd1935c..0961df1 100644
--- a/vcl/source/control/ilstbox.cxx
+++ b/vcl/source/control/ilstbox.cxx
@@ -2716,7 +2716,7 @@ void ImplWin::ImplDraw( bool bLayout )
if( IsEnabled() )
{
-if( HasFocus() )
+if (HasFocus()
!ImplGetSVData()-maNWFData.mbDDListBoxNoTextArea)
{
SetTextColor( rStyleSettings.GetHighlightTextColor() );
SetFillColor( rStyleSettings.GetHighlightColor() );
commit 5db6da7c5d27c5b8be59fb9a4599d5c95d7f1bd7
Author: Caolán McNamara caol...@redhat.com
Date: Tue May 12 17:37:58 2015 +0100
gtk3: get comboboxes and listboxes rendering right again
and also get roll-over working for listboxes, here
its actually to *not* support PART_BUTTON_DOWN that does
that, which is weird.
Change-Id: I0fc1152a3ee49164f6b5ecca6933730271c6da5c
diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx
index 68c6cf7..bde44ab 100644
--- a/vcl/inc/unx/gtk/gtkgdi.hxx
+++ b/vcl/inc/unx/gtk/gtkgdi.hxx
@@ -77,7 +77,10 @@ private:
static GtkStyleContext *mpMenuItemStyle;
static GtkStyleContext *mpSpinStyle;
static GtkStyleContext *mpComboboxStyle;
+static GtkStyleContext *mpComboboxEntryStyle;
+static GtkStyleContext *mpComboboxButtonStyle;
static GtkStyleContext *mpListboxStyle;
+static GtkStyleContext *mpListboxButtonStyle;
static GtkStyleContext *mpNoteBookStyle;
static Rectangle NWGetScrollButtonRect( ControlPart nPart, Rectangle
aAreaRect );
@@ -101,13 +104,13 @@ private:
const Rectangle rControlRectangle,
ControlType nType,
ControlPart nPart,
- const ImplControlValue aValue );
-static void PaintCombobox( GtkStyleContext *context,
+ const ImplControlValue aValue);
+static void PaintCombobox(GtkStateFlags flags,
cairo_t *cr,
const Rectangle rControlRectangle,
ControlType nType,
ControlPart nPart,
-const ImplControlValue aValue );
+const ImplControlValue aValue);
static void PaintCheckOrRadio(GtkStyleContext *context,
cairo_t *cr,
const Rectangle rControlRectangle,
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index 906d3b2..2aad70e 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -32,7 +32,10 @@ GtkStyleContext* GtkSalGraphics::mpMenuStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpMenuItemStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpSpinStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpComboboxStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpComboboxEntryStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpComboboxButtonStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpListboxStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpListboxButtonStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpNoteBookStyle = NULL;
bool GtkSalGraphics::style_loaded = false;
@@ -78,37 +81,6 @@ enum {
RENDER_EXTENSION = 11,
};
-static void PrepareComboboxStyle( GtkStyleContext *context,
- gboolean forEntry)
-{
-GtkWidgetPath *path, *siblingsPath;
-
-path = gtk_widget_path_new();
-siblingsPath = gtk_widget_path_new();
-gtk_widget_path_append_type(path, GTK_TYPE_COMBO_BOX);
-gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_COMBOBOX_ENTRY);
-
-gtk_widget_path_append_type(siblingsPath, GTK_TYPE_ENTRY);
-gtk_widget_path_append_type(siblingsPath, GTK_TYPE_BUTTON);
-gtk_widget_path_iter_add_class(siblingsPath, 0, GTK_STYLE_CLASS_ENTRY);
-gtk_widget_path_iter_add_class(siblingsPath, 1, GTK_STYLE_CLASS_BUTTON);
-
-if (forEntry)
-{
-gtk_widget_path_append_with_siblings(path, siblingsPath, 1);
-gtk_widget_path_append_with_siblings(path, siblingsPath, 0);
-}
-else
-{
-gtk_widget_path_append_with_siblings(path, siblingsPath, 0);
-gtk_widget_path_append_with_siblings(path, siblingsPath, 1);
-}
-
-
Re: starmath, export, preview generation
Yury yury.tarasievich at gmail.com writes: Could somebody have a look at the code generating formulas preview in starmath export? I have a feeling that bug 88697 in its part relating to the 'too high' placement of exported formula preview in .DOC (and that's the last part of 88697 yet unresolved) is somehow connected with the initial report on bug 88139 -- formulas had their frames' lower edges shifted up then (lower edge put on paragraph baseline). I would really like some advise on this. They tell you to not ask questions on source coed on bugtracker, there is a maililng list for that, you know. Okay, that is not the hot topic of icon themes, but I assure you, for the relevant audience the correctly formed formula previews in .DOC are no less important :) -Yury ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 Robert Antoni Buj i Gelonch robert@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #9 from Robert Antoni Buj i Gelonch robert@gmail.com --- There is no issue with the export filter. The document has a bad format due to the fact headers are inside a numbering, probably the user did an incomplete Outline Numbering. This can be fixed by cleaning the format, removing the numbering, selecting the desired style (Header 1, Header 2, ...) in each header (Outline Numbering is preserved). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41067] : Graphic object broken, hyperlink does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=41067 Harald Koester harald.koes...@mail.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Harald Koester harald.koes...@mail.de --- *** This bug has been marked as a duplicate of bug 79604 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/main/DrawCommandDispatch.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 47ac1b7445520c04f4c98bac925fe14257fd8098
Author: Takeshi Abe t...@fixedpoint.jp
Date: Wed May 13 00:16:54 2015 +0900
perform a proper boundary check, just in case
Change-Id: I4713b88a2130658513fd64793129c855169f0187
Reviewed-on: https://gerrit.libreoffice.org/15720
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx
b/chart2/source/controller/main/DrawCommandDispatch.cxx
index 8804bb9..27479169 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -381,7 +381,7 @@ void DrawCommandDispatch::execute( const OUString
rCommand, const Sequence bea
const beans::PropertyValue* pKeyModifier = ::std::find_if(
pIter, pEnd, ::std::bind2nd( PropertyValueCompare(),
boost::cref( sKeyModifier ) ) );
sal_Int16 nKeyModifier = 0;
-if ( pKeyModifier ( pKeyModifier-Value = nKeyModifier )
nKeyModifier == KEY_MOD1 )
+if ( pKeyModifier != pEnd pKeyModifier (
pKeyModifier-Value = nKeyModifier ) nKeyModifier == KEY_MOD1 )
{
if ( eDrawMode == CHARTDRAW_INSERT )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91248] Calc function cumprinc wizard fails due to 2 missing parameters: start_period end_period
https://bugs.documentfoundation.org/show_bug.cgi?id=91248 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |WORKSFORME --- Comment #1 from raal r...@post.cz --- Hello, with LO 4.4.3, win7 I see all parameters of function (6 parameters) in wizard. Please test with latest version 4.4.3. Set to unconfirmed again if you still see the error in actual version. Closing as worksforme. Thanks http://www.libreoffice.org/download/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91255] FILESAVE: after particular XLSX saving text properties are lost
https://bugs.documentfoundation.org/show_bug.cgi?id=91255 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #2 from raal r...@post.cz --- I can confirm with LO 4.4.3, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91258] New: Broken download page if version argument is wrong?
https://bugs.documentfoundation.org/show_bug.cgi?id=91258 Bug ID: 91258 Summary: Broken download page if version argument is wrong? Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: olafvds...@gmail.com Check for updates in 4.4.0.3 sends me to http://www.libreoffice.org/download/libreoffice-fresh/?type=win-x86lang=en-USversion=4.4.2 The download button is missing the version number and forwards me to the home page (http://www.libreoffice.org/) Is a check of the version argument missing? BTW, not sure what the right component for this bug is. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91254] Very strange EMF+ corruption on Linux and OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=91254 --- Comment #2 from Andras Timar tima...@gmail.com --- Created attachment 115549 -- https://bugs.documentfoundation.org/attachment.cgi?id=115549action=edit LibreOffice in Windows -- OK -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91255] FILESAVE: after particular XLSX saving text properties are lost
https://bugs.documentfoundation.org/show_bug.cgi?id=91255 --- Comment #1 from Timon kaktebyaviru...@gmail.com --- Created attachment 115553 -- https://bugs.documentfoundation.org/attachment.cgi?id=115553action=edit Example_32_4_4_3_2.xlsx - resaved in LibO 4.4.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #13 from Robert Antoni Buj i Gelonch robert@gmail.com --- Created attachment 115557 -- https://bugs.documentfoundation.org/attachment.cgi?id=115557action=edit Outline numbering has been fixed in test case document There are still two errors in xml validation. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
tool for chasing elusive VclPtr crashers ...
Hi guys,
I've been chasing this bug:
https://bugs.documentfoundation.org/show_bug.cgi?id=91125
on and off for around a week. And it's quite an amazing one =)
Before I go further, I'd like to hope this is quite a rare specimen -
the vast majority of VclPtr bugs are really not this bug; so this is
really a thing of last-resort:
The stack trace shows something like this:
0x4C28FAC: operator delete(void*) (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
0x3134D719: ScPivotLayoutTreeListLabel::~ScPivotLayoutTreeListLabel()
(PivotLayoutTreeListLabel.cxx:33)
Here we delete this guy - which sounds sensible; except that ...
0xB7F3FC4: OutputDevice::release() const (outdev.hxx:284)
0xB7F71FB: rtl::Referencevcl::Window::set(vcl::Window*) (ref.hxx:95)
0xB7F5249: rtl::Referencevcl::Window::operator=(rtl::Referencevcl::Window
const) (ref.hxx:106)
0xB7F4214: VclPtrvcl::Window::operator=(VclPtrvcl::Window const)
(vclptr.hxx:83)
0xB82AFF4: vcl::Window::ImplRemoveWindow(bool) (stacking.cxx:148)
0xB9A8E20: vcl::Window::dispose() (window.cxx:511)
0xBA12D1D: Control::dispose() (ctrl.cxx:76)
0x9B434A5: SvTreeListBox::dispose() (treelistbox.cxx:1584)
0x313499FD: ScPivotLayoutTreeListBase::dispose()
(PivotLayoutTreeListBase.cxx:38)
0xBAEF813: OutputDevice::disposeOnce() (outdev.cxx:203)
0xB85E3BF: VclPtrvcl::Window::disposeAndClear() (vclptr.hxx:209)
In this frame we are holding a reference (to ensure that the object
lives until the end of the disposeAndClear)
0xB83F000: VclBuilder::disposeBuilder() (builder.cxx:536)
So - despite all the smart-ref-counting logic - somehow we're getting
the reference counting wrong:
So ... after about a week of chasing this on off, I found the bug
which is here:
sal_Int8 SvTreeListBox::ExecuteDrop( const ExecuteDropEvent rEvt,
SvTreeListBox* pSourceView )
...
SvLBoxDDInfo aDDInfo;
memset( aDDInfo, 0, sizeof(SvLBoxDDInfo) );
TransferableDataHelper aData( rEvt.maDropEvent.Transferable );
if( aData.HasFormat( SotClipboardFormatId::TREELISTBOX ))
{
css::uno::Sequencesal_Int8 aSeq =
aData.GetSequence(SotClipboardFormatId::TREELISTBOX, OUString());
if (sizeof(SvLBoxDDInfo) == aSeq.getLength())
{
memcpy( aDDInfo, aSeq.getConstArray(), sizeof(SvLBoxDDInfo) );
This final memcpy writes over a VclPtr inside the aDDInfo struct:
struct SvLBoxDDInfo
{
Application*pApp;
VclPtrSvTreeListBox pSource;
...
Lets hold our breath and gloss over the -horrible- details of passing
raw pointers through an UNO sequence as a byte array and then ... [ it
seems the DD code - which is also threaded ] is some living nightmare
in this regard ;-)
Anyhow - the question is: how to find this stuff ? the problem being
that when you track every one of the (2000+) acquire/releases on the
underlying ref-count they all appear to be correct: there are just more
releases than there should be. [ the ref-count is stored in the object
not the VclPtr which is clobbered ].
Anyhow - here is how:
a) run soffice.bin under gdb:
gdb --args ./soffice.bin 21 | tee /tmp/gdb-log.txt
place a breakpoint in the 'makeFoo' function you're
interested in - it is rather useful to get this function
before the construction really gets going.
(gdb) print mnRefCnt
$1 = (int *) 0x12345678
(gdb) watch *$1
This creates a hardware watch-point so whenever the ref-count
changes you get a trace.
(gdb) set pagination off
(gdb) continue
it will break shortly afterwards
(gdb) commands
backtrace 10
continue
end
(gdb) continue
This will then produce a log of all stack frames that maniplate the
'mnRefCnt' - in my case this produced 2000+ of them or so ;-)
It is probable that you want a dbgutil build - or at least one with
no-optimization too.
When you hit your crash quit gdb.
You should have a nice gdb-log.txt now.
now
$ cat gdb-log.txt | chase.pl
Problematic ref-count mis-matches on VclPtr instances with values:
this=0x7fffd7391148 -1
this=0x7fff6e70 -1
this=0x7fffc5b0 1
Search for the above pointer values in your log.
Then look for the above ptr values in your log eg.
Old value = 22
New value = 21
0x72af3647 in OutputDevice::release (this=0x2252e10) at
/data/opt/libreoffice/master/include/vcl/outdev.hxx:284
284 if (!--mnRefCnt)
#0 0x72af3647 in OutputDevice::release (this=0x2252e10) at
/data/opt/libreoffice/master/include/vcl/outdev.hxx:284
#1 0x72baa6bb in rtl::ReferenceSvTreeListBox::~Reference
(this=0x7fffd7391148, __in_chrg=optimized out) at
/data/opt/libreoffice/master/include/rtl/ref.hxx:81
#2 0x72ba9eca in VclPtrSvTreeListBox::~VclPtr
[Libreoffice-bugs] [Bug 91257] Cells show wrong numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=91257 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 OS|Linux (All) |All --- Comment #2 from raal r...@post.cz --- I can confirm with LO 4.4.3, win7 Are you able to reproduce the bug with new file? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91254] New: Very strange EMF+ corruption on Linux and OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=91254
Bug ID: 91254
Summary: Very strange EMF+ corruption on Linux and OS X
Product: LibreOffice
Version: 4.3 Daily
Hardware: Other
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: graphics stack
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: tima...@gmail.com
Created attachment 115547
-- https://bugs.documentfoundation.org/attachment.cgi?id=115547action=edit
Anonymized bugdoc (EMF+)
The attached EMF+ image is not opened correctly on Linux, lines are not shown
(e.g. arrow lines).
* The bug was originally found on Linux (64-bit).
* The bug is not reproduced on Windows (both 32-bit and 64-bit).
* The chart looks terribly broken with OS X builds. Only text elements are
displayed.
* On all platforms rendering is OK with EMF_PLUS_DISABLE=1, not perfect of
course, because the EMF+ image has more details.
* I bisected the problem on Linux, and the first bad commit was mine, but in my
opinion it only triggered the bug, because it seems to be unrelated.
5b8ad54cc596a58da1f79937cc6709ce0799ac7f is the first bad commit
commit 5b8ad54cc596a58da1f79937cc6709ce0799ac7f
Author: Andras Timar andras.ti...@collabora.com
Date: Mon Jan 6 19:23:01 2014 +0100
EMF/WMF: parse line cap and line join
I was surprised, that the following patch fixed the bug on Linux (but not on OS
X):
diff --git a/vcl/source/filter/wmf/enhwmf.cxx
b/vcl/source/filter/wmf/enhwmf.cxx
index c314ef6..152bee6 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -936,7 +936,7 @@ bool EnhWMFReader::ReadEnhWMF()
switch( nStyle 0xF00 )
{
case PS_ENDCAP_ROUND :
-aLineInfo.SetLineCap(
com::sun::star::drawing::LineCap_ROUND );
+aLineInfo.SetLineCap(
com::sun::star::drawing::LineCap_BUTT );
break;
case PS_ENDCAP_SQUARE :
aLineInfo.SetLineCap(
com::sun::star::drawing::LineCap_SQUARE );
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91254] Very strange EMF+ corruption on Linux and OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=91254 --- Comment #1 from Andras Timar tima...@gmail.com --- Created attachment 115548 -- https://bugs.documentfoundation.org/attachment.cgi?id=115548action=edit Reference rendering in Word 2010 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91101] Cannot register on ask.libreoffice.org
https://bugs.documentfoundation.org/show_bug.cgi?id=91101 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |INVALID --- Comment #2 from Beluga todven...@suomi24.fi --- I, too, can see the captcha. It was apparently a temporary error. I will close as invalid. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91119] Difficult to change incoming documents to default language
https://bugs.documentfoundation.org/show_bug.cgi?id=91119 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 Severity|normal |minor --- Comment #2 from Beluga todven...@suomi24.fi --- It seems there is something strange with Tools - Options - Languages - Default lang for documents. I set it to Estonian and opened attachment 115392. Then I went to check the option and it had turned into English (USA)! The document itself said English (UK) in the status bar and if I left-clicked it and selected Reset to default lang, nothing happened. It is true that we can left-click the status bar - More - Font tab - Language - select desired lang. Thus I'm lowering severity: https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg Win 7 Pro 64-bit, Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: fi_FI Version: 5.0.0.0.alpha1+ (x64) Build ID: ddb3c4531c657cda6ae20dd950020cea1d12ba2e TinderBox: Win-x86_64@42, Branch:master, Time: 2015-05-11_00:25:02 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65328] FILESAVE: after particular XLSX saving document structure is lost and it could not be opened in MSO
https://bugs.documentfoundation.org/show_bug.cgi?id=65328 --- Comment #8 from Timon kaktebyaviru...@gmail.com --- LibreOffice Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: ru_RU on Russian Windows XP Professional SP3 (32bit) I don't see much changes vs LibreOffice Version: 4.3.0.4 Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0 After saving, if we try to open document in LibreOffice, than the structure is not lost (except text properties). But if we try to open document in MSOffice 2007, then structure of document is completely lost. The only good thing, that we can see file content. I don't agree that [ Yogesh Bharate ] changed bug status to RESOLVED WORKSFORME. It doesn't works for me in current more or less stable version! Made separate bug about lost text properties https://bugs.documentfoundation.org/show_bug.cgi?id=91255 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - odk/CustomTarget_doxygen.mk offapi/org
odk/CustomTarget_doxygen.mk |1 +
offapi/org/freedesktop/PackageKit/XModify.idl |4
offapi/org/freedesktop/PackageKit/XQuery.idl |4
3 files changed, 9 insertions(+)
New commits:
commit be316c62086bd59b097f1db13034752833c3febe
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed May 13 11:59:34 2015 +0200
Improve documentation
Change-Id: I37a610acbce78033f90b7d18274eb233a734fd7e
diff --git a/offapi/org/freedesktop/PackageKit/XModify.idl
b/offapi/org/freedesktop/PackageKit/XModify.idl
index 5313d8f..a712bb5 100644
--- a/offapi/org/freedesktop/PackageKit/XModify.idl
+++ b/offapi/org/freedesktop/PackageKit/XModify.idl
@@ -20,6 +20,10 @@ module PackageKit
{
/**
* The interface used for modifying the package database.
+ *
+ * @sa
+ *
https://git.gnome.org/browse/gnome-software/tree/src/org.freedesktop.PackageKit.xml
+ * for documentation of the corresponding D-Bus interface
*/
interface XModify : com::sun::star::uno::XInterface
{
diff --git a/offapi/org/freedesktop/PackageKit/XQuery.idl
b/offapi/org/freedesktop/PackageKit/XQuery.idl
index 0c8ea1c..ecfe1aa 100644
--- a/offapi/org/freedesktop/PackageKit/XQuery.idl
+++ b/offapi/org/freedesktop/PackageKit/XQuery.idl
@@ -19,6 +19,10 @@ module PackageKit
{
/**
* The interface used for quering the package database.
+ *
+ * @sa
+ *
https://git.gnome.org/browse/gnome-software/tree/src/org.freedesktop.PackageKit.xml
+ * for documentation of the corresponding D-Bus interface
*/
interface XQuery : com::sun::star::uno::XInterface
{
commit 4eb73e4e00be7680674a706331fd245a207e8b5f
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed May 13 11:59:12 2015 +0200
Also generated doxygen docu for the org UNOIDL tree
Change-Id: Ia903c473a482ff228e013aa28f3a041b12cf2a79
diff --git a/odk/CustomTarget_doxygen.mk b/odk/CustomTarget_doxygen.mk
index 6fe5096..be8c865 100644
--- a/odk/CustomTarget_doxygen.mk
+++ b/odk/CustomTarget_doxygen.mk
@@ -65,6 +65,7 @@ odk_idl_PREFIX := $(SRCDIR)/udkapi/ $(SRCDIR)/offapi/
# otherwise spurious references to it will appear in the output
odk_idl_DOXY_INPUT := $(SRCDIR)/odk/docs/idl/main.dox \
$(addsuffix com,$(odk_idl_PREFIX)) \
+ $(addsuffix org,$(odk_idl_PREFIX)) \
$(SRCDIR)/odk/docs/idl/generated_idl_chapter_refs.idl
odk_idl_DOXY_WORKDIR := $(call gb_CustomTarget_get_workdir,odk/docs/idl)/ref
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #10 from y...@gmx.de --- So you are saying that improper input is an excuse for generating invalid output? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 y...@gmx.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #12 from y...@gmx.de --- With respect but your argumentation is completely nonsense. An export filter must never ever generate improper output - independent of whatever error situation - either in the processing or within the input. Once again: you are generating improper HTML - this *is* a bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #15 from y...@gmx.de --- This is an argument? Am I talking here against a wall? Do you have a basic understanding of quality assurance for a certain functionality as an output filter? An output filter is supposed something that is compatible with the specs of the format that is support to generate. Is H a valid HTML tags? Instead of swallowing error or performing stupid error handling either raise an error message or deal with such an error situation properly. Generating trash output is not a correct functionality of an output filter. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91132] FILESAVE: save a copy or export as pdf - ending isn't handled well
https://bugs.documentfoundation.org/show_bug.cgi?id=91132 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #6 from raal r...@post.cz --- Cannot reproduce with steps in comment 5. Win7, LO 4.4.3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75612] FORMATTING: Filling of textframe not saved when document is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=75612 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Gordo gordon1dr...@yahoo.com --- Could not reproduce. Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Bug still present in 4.3.6.2. Changed to RESOLVED WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91259] New: Crash when close a LibreOffice with Help
https://bugs.documentfoundation.org/show_bug.cgi?id=91259 Bug ID: 91259 Summary: Crash when close a LibreOffice with Help Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: baffc...@yahoo.co.jp Steps to Reproduce: 1. start LibO-Dev 2. Open a help, Menu - Help - LibreOfficeDev Help F1 3. Closed LibO-Dev window 4. Crash a LibO-Dev Appear error dialog LibreofficeDev 5.0 - Fatal Error Unknown SEH Exception daily/master/Win-x86@62-merge-TDF/2015-05-13_01.52.36 Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-13_01:52:36 Locale: ja-JP (ja_JP) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 --- Comment #16 from Robert Antoni Buj i Gelonch robert@gmail.com --- Created attachment 115559 -- https://bugs.documentfoundation.org/attachment.cgi?id=115559action=edit Example of CSS counters in Outline Numbering The w3c validator reported that header was not a permitted content in element list (OL/UL) in the initial document, plus two more errors. From my point of view, the incorrect usage of the headers is an user mistake, and it's not an issue in the export filter. Now, I'm focused in these two errors. Next, I think that we can reduce the complexity in Outline Numbering by using CSS counters, but it's an enhancement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkgdi.hxx|2
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 114 ++
2 files changed, 85 insertions(+), 31 deletions(-)
New commits:
commit 009b10efab695ed8f95f0dc5621ad13ddfcb3645
Author: Caolán McNamara caol...@redhat.com
Date: Wed May 13 14:00:59 2015 +0100
gtk3: implement CTRL_FRAME
Change-Id: Icf9d7703c8a82f1e7b178ea75a66861c01f58800
diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx
index bde44ab..0403b59 100644
--- a/vcl/inc/unx/gtk/gtkgdi.hxx
+++ b/vcl/inc/unx/gtk/gtkgdi.hxx
@@ -82,6 +82,8 @@ private:
static GtkStyleContext *mpListboxStyle;
static GtkStyleContext *mpListboxButtonStyle;
static GtkStyleContext *mpNoteBookStyle;
+static GtkStyleContext *mpFrameInStyle;
+static GtkStyleContext *mpFrameOutStyle;
static Rectangle NWGetScrollButtonRect( ControlPart nPart, Rectangle
aAreaRect );
static Rectangle NWGetSpinButtonRect( ControlPart nPart, Rectangle
aAreaRect);
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index ce3e88f..711003f 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -14,6 +14,7 @@
#include unx/gtk/gtkdata.hxx
#include unx/gtk/gtkinst.hxx
#include unx/gtk/gtkgdi.hxx
+#include vcl/decoview.hxx
#include vcl/settings.hxx
#include fontmanager.hxx
#include gtk3cairotextrender.hxx
@@ -37,6 +38,8 @@ GtkStyleContext* GtkSalGraphics::mpComboboxButtonStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpListboxStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpListboxButtonStyle = NULL;
GtkStyleContext* GtkSalGraphics::mpNoteBookStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpFrameInStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpFrameOutStyle = NULL;
bool GtkSalGraphics::style_loaded = false;
/
@@ -227,20 +230,20 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext
*context,
const Rectangle rControlRectangle,
ControlType nType,
ControlPart nPart,
-const ImplControlValue aValue )
+const ImplControlValue rValue )
{
(void)nType;
-OSL_ASSERT( aValue.getType() == CTRL_SCROLLBAR );
-const ScrollbarValue* pScrollbarVal = static_castconst ScrollbarValue
*(aValue);
+OSL_ASSERT( rValue.getType() == CTRL_SCROLLBAR );
+const ScrollbarValue rScrollbarVal = static_castconst
ScrollbarValue(rValue);
RectanglescrollbarRect;
GtkStateFlagsstateFlags;
GtkShadowTypeshadowType;
GtkOrientationscrollbarOrientation;
-RectanglethumbRect = pScrollbarVal-maThumbRect;
-Rectanglebutton11BoundRect = pScrollbarVal-maButton1Rect; //
backward
-Rectanglebutton22BoundRect = pScrollbarVal-maButton2Rect; //
forward
-Rectanglebutton12BoundRect = pScrollbarVal-maButton1Rect; //
secondary forward
-Rectanglebutton21BoundRect = pScrollbarVal-maButton2Rect; //
secondary backward
+RectanglethumbRect = rScrollbarVal.maThumbRect;
+Rectanglebutton11BoundRect = rScrollbarVal.maButton1Rect; //
backward
+Rectanglebutton22BoundRect = rScrollbarVal.maButton2Rect; //
forward
+Rectanglebutton12BoundRect = rScrollbarVal.maButton1Rect; //
secondary forward
+Rectanglebutton21BoundRect = rScrollbarVal.maButton2Rect; //
secondary backward
gdouble arrow1Angle;//
backward
gdouble arrow2Angle;//
forward
RectanglearrowRect;
@@ -388,8 +391,8 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext
*context,
// - THUMB
if ( has_slider )
{
-NWConvertVCLStateToGTKState( pScrollbarVal-mnThumbState, stateFlags,
shadowType );
-if ( pScrollbarVal-mnThumbState ControlState::PRESSED )
+NWConvertVCLStateToGTKState( rScrollbarVal.mnThumbState, stateFlags,
shadowType );
+if ( rScrollbarVal.mnThumbState ControlState::PRESSED )
stateFlags = (GtkStateFlags) (stateFlags | GTK_STATE_PRELIGHT);
gtk_style_context_save(context);
@@ -404,14 +407,14 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext
*context,
}
bool backwardButtonInsensitive =
-pScrollbarVal-mnCur == pScrollbarVal-mnMin;
-bool forwardButtonInsensitive = pScrollbarVal-mnMax == 0 ||
-pScrollbarVal-mnCur + pScrollbarVal-mnVisibleSize =
pScrollbarVal-mnMax;
+rScrollbarVal.mnCur == rScrollbarVal.mnMin;
+bool forwardButtonInsensitive = rScrollbarVal.mnMax == 0 ||
+rScrollbarVal.mnCur + rScrollbarVal.mnVisibleSize =
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
New commits:
commit 182c202d6d3fd9422bf3628a2fa4ccd7ab955c5e
Author: Caolán McNamara caol...@redhat.com
Date: Wed May 13 14:22:39 2015 +0100
gtk3:don't even out the left/right top/bottom, take the figures as-is
Change-Id: I2836446a8032b71c83feba5e3e669b5131a29ac1
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index 711003f..40a662a 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -659,14 +659,16 @@ Rectangle GtkSalGraphics::NWGetComboBoxButtonRect(
ControlType nType,
}
else if( nPart == PART_SUB_EDIT )
{
-gint adjust_x = (gint) ((padding.left + padding.right) / 2) +
nFocusWidth + nFocusPad;
-gint adjust_y = (gint) ((padding.top + padding.bottom) / 2) +
nFocusWidth + nFocusPad;
+gint adjust_left = padding.left + nFocusWidth + nFocusPad;
+gint adjust_top = padding.top + nFocusWidth + nFocusPad;
+gint adjust_right = padding.right + nFocusWidth + nFocusPad;
+gint adjust_bottom = padding.bottom + nFocusWidth + nFocusPad;
-aButtonRect.SetSize( Size( aAreaRect.GetWidth() - nButtonWidth - 2 *
adjust_x,
- aAreaRect.GetHeight() - 2 * adjust_y ) );
+aButtonRect.SetSize( Size( aAreaRect.GetWidth() - nButtonWidth -
(adjust_left + adjust_right),
+ aAreaRect.GetHeight() - (adjust_top +
adjust_bottom)) );
Point aEditPos = aAreaRect.TopLeft();
-aEditPos.X() += adjust_x;
-aEditPos.Y() += adjust_y;
+aEditPos.X() += adjust_left;
+aEditPos.Y() += adjust_top;
aButtonRect.SetPos( aEditPos );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 68326] FILEOPEN: Bad table formating when open docx
https://bugs.documentfoundation.org/show_bug.cgi?id=68326 --- Comment #5 from ig...@yandex.ru --- ver 4.4.3.2 still have the same -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 David Tardon dtar...@redhat.com changed: What|Removed |Added CC||dtar...@redhat.com --- Comment #18 from David Tardon dtar...@redhat.com --- I am in favor of removing the XHTML export filter entirely. Seriously, nobody is going to touch that steaming pile of... XSLT. Actually, thinking about it, I am in favor of removing all the XSLT export filters, except maybe the MediaWiki one, for which we have received some improvements recently. Let's just admit that XSLT has never been the right tool for a complex document format conversion... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/PropertyIds.cxx |3 +--
writerfilter/source/dmapper/PropertyIds.hxx |3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 926392de616c4ce32b82f7cc002655bc765b4aae
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed May 13 09:53:42 2015 +0200
PropertyNameSupplier: use std::unique_ptr
Change-Id: I1e4cf3241bee20677f61ea334efc3aa4e490a016
diff --git a/writerfilter/source/dmapper/PropertyIds.cxx
b/writerfilter/source/dmapper/PropertyIds.cxx
index 53d101c..5506322 100644
--- a/writerfilter/source/dmapper/PropertyIds.cxx
+++ b/writerfilter/source/dmapper/PropertyIds.cxx
@@ -34,14 +34,13 @@ struct PropertyNameSupplier_Impl
PropertyNameSupplier::PropertyNameSupplier() :
-m_pImpl(new PropertyNameSupplier_Impl)
+m_pImpl(new PropertyNameSupplier_Impl())
{
}
PropertyNameSupplier::~PropertyNameSupplier()
{
-delete m_pImpl;
}
diff --git a/writerfilter/source/dmapper/PropertyIds.hxx
b/writerfilter/source/dmapper/PropertyIds.hxx
index 618d02d..51b2732 100644
--- a/writerfilter/source/dmapper/PropertyIds.hxx
+++ b/writerfilter/source/dmapper/PropertyIds.hxx
@@ -19,6 +19,7 @@
#ifndef INCLUDED_WRITERFILTER_SOURCE_DMAPPER_PROPERTYIDS_HXX
#define INCLUDED_WRITERFILTER_SOURCE_DMAPPER_PROPERTYIDS_HXX
+#include memory
namespace writerfilter {
namespace dmapper{
@@ -380,7 +381,7 @@ enum PropertyIds
struct PropertyNameSupplier_Impl;
class PropertyNameSupplier
{
-PropertyNameSupplier_Impl* m_pImpl;
+std::unique_ptrPropertyNameSupplier_Impl m_pImpl;
public:
PropertyNameSupplier();
~PropertyNameSupplier();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
New commits:
commit 85eb28ccb72b97f253418a925fe54fa6bc124d01
Author: Caolán McNamara caol...@redhat.com
Date: Wed May 13 14:34:14 2015 +0100
gtk3: don't include the focus pad and width in comboboxes
otherwise the text inside them is getting clipped out.
May have to revisit this when we get to drawing focus rects
Change-Id: I3be4ce9d5e5540056974159d4ddb866c099958de
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index 40a662a..14f75c7 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -638,19 +638,12 @@ Rectangle GtkSalGraphics::NWGetComboBoxButtonRect(
ControlType nType,
RectangleaButtonRect;
gintnArrowWidth;
gintnButtonWidth;
-gintnFocusWidth;
-gintnFocusPad;
GtkBorder padding;
-// Grab some button style attributes
-gtk_style_context_get_style( mpButtonStyle,
- focus-line-width, nFocusWidth,
- focus-padding, nFocusPad,
- NULL );
gtk_style_context_get_padding( mpButtonStyle, GTK_STATE_FLAG_NORMAL,
padding);
nArrowWidth = ARROW_SIZE;
-nButtonWidth = nArrowWidth + padding.left + padding.right + (2 *
(nFocusWidth+nFocusPad));
+nButtonWidth = nArrowWidth + padding.left + padding.right;
if( nPart == PART_BUTTON_DOWN )
{
aButtonRect.SetSize( Size( nButtonWidth, aAreaRect.GetHeight() ) );
@@ -659,10 +652,10 @@ Rectangle GtkSalGraphics::NWGetComboBoxButtonRect(
ControlType nType,
}
else if( nPart == PART_SUB_EDIT )
{
-gint adjust_left = padding.left + nFocusWidth + nFocusPad;
-gint adjust_top = padding.top + nFocusWidth + nFocusPad;
-gint adjust_right = padding.right + nFocusWidth + nFocusPad;
-gint adjust_bottom = padding.bottom + nFocusWidth + nFocusPad;
+gint adjust_left = padding.left;
+gint adjust_top = padding.top;
+gint adjust_right = padding.right;
+gint adjust_bottom = padding.bottom;
aButtonRect.SetSize( Size( aAreaRect.GetWidth() - nButtonWidth -
(adjust_left + adjust_right),
aAreaRect.GetHeight() - (adjust_top +
adjust_bottom)) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit ccfab82ebd35771163d782da6b3737127a8ad589 Author: Caolán McNamara caol...@redhat.com Date: Wed May 13 14:46:22 2015 +0100 gtk3: if we have GTK_STATE_FLAG_CHECKED use only that bit in order to get insensitive checkmarks painted gray Change-Id: I29016b8c5f08c74934068bb06ae2c76ca2cb01c7 diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx index 14f75c7..37b00b1 100644 --- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx @@ -790,9 +790,9 @@ void GtkSalGraphics::PaintCheckOrRadio(GtkStyleContext *context, } #if GTK_CHECK_VERSION(3,14,0) -# define CHECKED_AND_ACTIVE (GTK_STATE_FLAG_CHECKED | GTK_STATE_FLAG_ACTIVE) +# define CHECKED GTK_STATE_FLAG_CHECKED #else -# define CHECKED_AND_ACTIVE GTK_STATE_FLAG_ACTIVE +# define CHECKED GTK_STATE_FLAG_ACTIVE #endif bool GtkSalGraphics::drawNativeControl( ControlType nType, ControlPart nPart, const Rectangle rControlRegion, @@ -889,7 +889,7 @@ bool GtkSalGraphics::drawNativeControl( ControlType nType, ControlPart nPart, co break; case CTRL_CHECKBOX: flags = (GtkStateFlags)(flags | -( (rValue.getTristateVal() == BUTTONVALUE_ON) ? CHECKED_AND_ACTIVE : +( (rValue.getTristateVal() == BUTTONVALUE_ON) ? CHECKED : (rValue.getTristateVal() == BUTTONVALUE_MIXED) ? GTK_STATE_FLAG_INCONSISTENT : GTK_STATE_FLAG_NORMAL)); context = mpCheckButtonStyle; @@ -898,7 +898,7 @@ bool GtkSalGraphics::drawNativeControl( ControlType nType, ControlPart nPart, co break; case CTRL_RADIOBUTTON: flags = (GtkStateFlags)(flags | -( (rValue.getTristateVal() == BUTTONVALUE_ON) ? CHECKED_AND_ACTIVE : GTK_STATE_FLAG_NORMAL)); +( (rValue.getTristateVal() == BUTTONVALUE_ON) ? CHECKED : GTK_STATE_FLAG_NORMAL)); context = mpCheckButtonStyle; styleClass = GTK_STYLE_CLASS_RADIO; renderType = RENDER_RADIO; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx
include/vcl/salnativewidgets.hxx | 13 ---
vcl/source/control/combobox.cxx |6 +--
vcl/source/control/edit.cxx |5 +-
vcl/source/control/ilstbox.cxx|2 -
vcl/source/control/lstbox.cxx |8 ++--
vcl/source/control/spinfld.cxx|6 +--
vcl/source/outdev/nativecontrols.cxx | 19 +-
vcl/source/window/brdwin.cxx | 13 ++-
vcl/source/window/toolbox.cxx |2 -
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 48 +-
10 files changed, 39 insertions(+), 83 deletions(-)
New commits:
commit b1a9498a1415ca42e4d13f3e56daff0ebffc0ccf
Author: Caolán McNamara caol...@redhat.com
Date: Wed May 13 10:06:02 2015 +0100
Remove EditBoxValue again and just use the native widgets size request
Change-Id: Ib9d0f06bffc9e9d31149a622350145024a9b8a99
diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx
index c8370aa..b61f6e9 100644
--- a/include/vcl/salnativewidgets.hxx
+++ b/include/vcl/salnativewidgets.hxx
@@ -482,19 +482,6 @@ public:
boolmbSingleLine:1;
};
-/* EditBoxValue:
- *
- * Value container for editbox specifying additional drawing hints
- */
-class VCL_DLLPUBLIC EditBoxValue : public ImplControlValue
-{
-public:
-EditBoxValue(long nTextHeight)
-: ImplControlValue(CTRL_EDITBOX, BUTTONVALUE_DONTKNOW, nTextHeight)
-{
-}
-virtual EditBoxValue* clone() const SAL_OVERRIDE;
-};
#endif
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 502ab15..688fff6 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -109,7 +109,7 @@ void ComboBox::ImplCalcEditHeight()
Rectangle aCtrlRegion( Point( 0, 0 ), Size( 10, 10 ) );
Rectangle aBoundRegion, aContentRegion;
-EditBoxValue aControlValue(GetTextHeight());
+ImplControlValue aControlValue;
ControlType aType = IsDropDownBox() ? CTRL_COMBOBOX : CTRL_EDITBOX;
if( GetNativeControlRegion( aType, PART_ENTIRE_CONTROL,
aCtrlRegion,
@@ -992,7 +992,7 @@ long ComboBox::getMaxWidthScrollBarAndDownButton() const
long nButtonDownWidth = 0;
vcl::Window *pBorder = GetWindow( WINDOW_BORDER );
-EditBoxValue aControlValue(GetTextHeight());
+ImplControlValue aControlValue;
Point aPoint;
Rectangle aContent, aBound;
@@ -1425,7 +1425,7 @@ ComboBox::ComboBoxBounds
ComboBox::calcComboBoxDropDownComponentBounds(const Siz
longnBottom = rOutSz.Height();
vcl::Window *pBorder = GetWindow( WINDOW_BORDER );
-EditBoxValue aControlValue(GetTextHeight());
+ImplControlValue aControlValue;
Point aPoint;
Rectangle aContent, aBound;
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 0d5859e..c642282 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -2739,7 +2739,6 @@ void Edit::SetSubEdit( Edit* pEdit )
Size Edit::CalcMinimumSizeForText(const OUString rString) const
{
int eCtrlType = ImplGetNativeControlType();
-auto nTextHeight = GetTextHeight();
Size aSize;
if (mnWidthInChars != -1)
@@ -2756,7 +2755,7 @@ Size Edit::CalcMinimumSizeForText(const OUString
rString) const
else
aString = rString;
-aSize.Height() = nTextHeight;
+aSize.Height() = GetTextHeight();
aSize.Width() = GetTextWidth(aString);
aSize.Width() += ImplGetExtraXOffset() * 2;
@@ -2775,7 +2774,7 @@ Size Edit::CalcMinimumSizeForText(const OUString
rString) const
aSize = CalcWindowSize( aSize );
// ask NWF what if it has an opinion, too
-EditBoxValue aControlValue(nTextHeight);
+ImplControlValue aControlValue;
Rectangle aRect( Point( 0, 0 ), aSize );
Rectangle aContent, aBound;
if( GetNativeControlRegion(
diff --git a/vcl/source/control/ilstbox.cxx b/vcl/source/control/ilstbox.cxx
index 0961df1..8e94b42 100644
--- a/vcl/source/control/ilstbox.cxx
+++ b/vcl/source/control/ilstbox.cxx
@@ -2675,7 +2675,7 @@ void ImplWin::ImplDraw( bool bLayout )
// vcl/source/window/brdwin.cxx
vcl::Window *pWin = GetParent();
-EditBoxValue aControlValue(GetTextHeight());
+ImplControlValue aControlValue;
if ( !pWin-IsEnabled() )
nState = ~ControlState::ENABLED;
if ( pWin-HasFocus() )
diff --git a/vcl/source/control/lstbox.cxx b/vcl/source/control/lstbox.cxx
index f45962b..8db825e 100644
--- a/vcl/source/control/lstbox.cxx
+++ b/vcl/source/control/lstbox.cxx
@@ -118,7 +118,7 @@ void ListBox::ImplInit( vcl::Window* pParent, WinBits
nStyle )
if( IsNativeWidgetEnabled()
IsNativeControlSupported( CTRL_LISTBOX, PART_ENTIRE_CONTROL ) )
{
-EditBoxValue aControlValue(GetTextHeight());
+
[Libreoffice-bugs] [Bug 67013] FILESAVE: border of header dissapears when saving in anything but .odt /.ott
https://bugs.documentfoundation.org/show_bug.cgi?id=67013 --- Comment #6 from Gordo gordon1dr...@yahoo.com --- Still reproducible for doc and docx. Windows Vista 64 Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 4.3.6.2 4.2.8.2 4.1.6.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66999] XHTML export generates improper markup
https://bugs.documentfoundation.org/show_bug.cgi?id=66999 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||mst...@redhat.com, ||vmik...@collabora.co.uk --- Comment #17 from Julien Nabet serval2...@yahoo.fr --- Michael/Miklos: there's a debate here about if the result of an export filter should be ok even if input is wrong, thought you might have an opinion as experts in filters (perhaps not in xhtml export filter made in xsl). Also, will we keep xsl filters or will they be converted in Python? I think having read about this but I don't remember where or when. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90563] LibreOffice Calc crashes when attempting to format page
https://bugs.documentfoundation.org/show_bug.cgi?id=90563 peer.fr...@web.de changed: What|Removed |Added Priority|medium |high Status|NEEDINFO|REOPENED Version|4.4.2.2 release |4.4.3.2 rc OS|Mac OS X (All) |Linux (All) Severity|major |critical --- Comment #2 from peer.fr...@web.de --- have the same problem under Linux (Opensuse 13.2). It seems to be related to the document (others work fine). No hint what is going wrong. Also completely erasing the sheet does not help. My last changes to the crashing document was clearing print ranges on several tabs. All of a sudden LO becomes unusable ! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83796] Images jump lots of pages in master document
https://bugs.documentfoundation.org/show_bug.cgi?id=83796 --- Comment #12 from bugzi...@tiggez.de --- Try to remove all fo:break-befor=page in context.xml This worked for me, very well. On a 400+ pages odm document. See: http://ask.libreoffice.org/en/question/21740/how-do-i-prevent-master-document-adding-additional-blank-pages/ Best regards Tigges -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90023] UI: Navigator item tooltip displays to the left of mouse pointer
https://bugs.documentfoundation.org/show_bug.cgi?id=90023 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- I can confirm with LO 4.4.3, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91076] Arial font is replaced within LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=91076 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal r...@post.cz --- Cannot reproduce in Win7, LO 4.4.3 see here: https://en.wikipedia.org/wiki/Fontconfig There might be a problem with your font cache. Try running sudo fc-cache -f -v. This will rebuild the cache. Do you see Arial in another application correctly? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91260] New: DOCX frames can overreach the page vertically, but not in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91260 Bug ID: 91260 Summary: DOCX frames can overreach the page vertically, but not in Writer Product: LibreOffice Version: 4.4.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nem...@numbertext.org Created attachment 115560 -- https://bugs.documentfoundation.org/attachment.cgi?id=115560action=edit test document with an overreaching textbox This results bad vertical frame position in Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91138] LibreOffice Draw crashes when trying to edit extrusions
https://bugs.documentfoundation.org/show_bug.cgi?id=91138 --- Comment #5 from Gabriel Diosan gabs...@gmail.com --- Confirm that this bug and bug 91139 are fixed with: LibreOffice Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-05-13_02:00:37 Locale: en-AU (en_AU.UTF-8) Thanks for fixing these Michael. :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49769] EDITING: arrowup moves caret down instead up in 2 columns section in TABLE
https://bugs.documentfoundation.org/show_bug.cgi?id=49769 --- Comment #5 from Gordo gordon1dr...@yahoo.com --- Created attachment 115561 -- https://bugs.documentfoundation.org/attachment.cgi?id=115561action=edit yet another test document Inserting a section into a table cell will always have an empty paragraph after the section unless, of course, you decide that you need text there. When arrowing up through the first column the cursor jumps to this empty paragraph (or text). Arrowing up again, correctly, moves the cursor up through the second column. Since it is not possible to delete the empty paragraph after the section, the behaviour of hiding it after saving and reloading probably exists so as to make everything look tidy. Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49769] EDITING: Arrow up moves caret down instead of up in 2 columns section in TABLE
https://bugs.documentfoundation.org/show_bug.cgi?id=49769 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Summary|EDITING: arrowup moves |EDITING: Arrow up moves |caret down instead up in 2 |caret down instead of up in |columns section in TABLE|2 columns section in TABLE Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65509] FILESAVE Automatically save is not running
https://bugs.documentfoundation.org/show_bug.cgi?id=65509 --- Comment #9 from m.a.riosv mari...@miguelangel.mobi --- I think not only make it invisible, but also set up to false, to avoid it working from an updated profile. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68734] triple click to select a phrase needs an uppercase character after the punctuation signal
https://bugs.documentfoundation.org/show_bug.cgi?id=68734 --- Comment #7 from Jayme jofi...@yahoo.com --- Yes, you have some points. I agree with your main idea, specially when we're talking about texts written in English. Thks for your attention. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.
https://bugs.documentfoundation.org/show_bug.cgi?id=77388 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91260] DOCX frames can overreach the page vertically, but not in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91260 László Németh nem...@numbertext.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77388] Images, inserted in a table cell, go out of cell borders when the document (and thus the table) is zoomed.
https://bugs.documentfoundation.org/show_bug.cgi?id=77388 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/lo-generate-source-tarball
bin/lo-generate-source-tarball |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 02cc648dc068080d65b44ebd10d0940f6a097b8a
Author: Tor Lillqvist t...@collabora.com
Date: Wed May 13 17:49:04 2015 +0300
The --prefix option to the 'git archive' command should end with a slash
diff --git a/bin/lo-generate-source-tarball b/bin/lo-generate-source-tarball
index b67be85..2cb5398 100755
--- a/bin/lo-generate-source-tarball
+++ b/bin/lo-generate-source-tarball
@@ -140,7 +140,7 @@ pushd ${CORE_DIR} /dev/null
echo archiving core...
-git archive --format=tar --prefix=${base_name?} -o
${OUT_DIR}/${base_name}.tar ${LABEL?}
+git archive --format=tar --prefix=${base_name?}/ -o
${OUT_DIR}/${base_name}.tar ${LABEL?}
concatenate_list=
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Request for Removal
This email confirms that we received your request to be removed from our mailing list on 05/13/15 10:15:14 AM. Your request has been completed. Thank you for your interest in Davison. For additional information about our services, please visit our Web site, http://www.davison.com or call us 24 hours a day at 1-800-54IDEAS ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - avmedia/source configure.ac include/sal shell/source
avmedia/source/gstreamer/gstplayer.cxx| 62 +
configure.ac |6
include/sal/log-areas.dox |1
shell/source/sessioninstall/SyncDbusSessionHelper.cxx | 121 ++
shell/source/sessioninstall/SyncDbusSessionHelper.hxx | 36 ++---
5 files changed, 181 insertions(+), 45 deletions(-)
New commits:
commit de8afb9a2b461da4c81e45a7e185b553a5f4c3e7
Author: Stephan Bergmann sberg...@redhat.com
Date: Wed May 13 16:44:42 2015 +0200
First cut at reporting missing GStreamer plugins
Change-Id: Ia3cd8a2f0979f2312a70b8ee169fe9d6eef85c81
diff --git a/avmedia/source/gstreamer/gstplayer.cxx
b/avmedia/source/gstreamer/gstplayer.cxx
index 1b06c17..eea5bb6 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -17,12 +17,17 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include sal/config.h
+
+#include cstddef
+#include cstring
+#include set
#include math.h
#include cppuhelper/supportsservice.hxx
#include rtl/string.hxx
-
+#include vcl/svapp.hxx
#include vcl/syschild.hxx
#include vcl/sysdata.hxx
@@ -39,6 +44,9 @@
# define AVMEDIA_GST_PLAYER_SERVICENAME
com.sun.star.media.Player_GStreamer
#endif
+#include gst/pbutils/missing-plugins.h
+#include gst/pbutils/pbutils.h
+
#if !defined DBG
# if OSL_DEBUG_LEVEL 2
#ifdef AVMEDIA_GST_0_10
@@ -56,6 +64,56 @@ using namespace ::com::sun::star;
namespace avmedia { namespace gstreamer {
+namespace {
+
+class MissingPluginInstaller {
+public:
+void report(GstMessage * message);
+
+private:
+DECL_STATIC_LINK(MissingPluginInstaller, install, rtl_String *);
+
+std::setOString reported_;
+};
+
+void MissingPluginInstaller::report(GstMessage * message) {
+// assert(gst_is_missing_plugin_message(message));
+gchar * det = gst_missing_plugin_message_get_installer_detail(message);
+if (det != nullptr) {
+std::size_t len = std::strlen(det);
+if (len = sal_uInt32(SAL_MAX_INT32)) {
+OString detStr(det, len);
+if (reported_.insert(detStr).second) {
+rtl_string_acquire(detStr.pData);
+Application::PostUserEvent(
+LINK(nullptr, MissingPluginInstaller, install),
+detStr.pData);
+}
+} else {
+SAL_WARN(
+avmedia.gstreamer, detail string too long);
+}
+g_free(det);
+} else {
+SAL_WARN(
+avmedia.gstreamer,
+gst_missing_plugin_message_get_installer_detail failed);
+}
+}
+
+IMPL_STATIC_LINK(MissingPluginInstaller, install, rtl_String *, data) {
+OString res(data, SAL_NO_ACQUIRE);
+gst_pb_utils_init(); // not thread safe
+char * args[]{const_castchar *(res.getStr()), nullptr};
+gst_install_plugins_sync(args, nullptr);
+return 0;
+}
+
+struct TheMissingPluginInstaller:
+public rtl::StaticMissingPluginInstaller, TheMissingPluginInstaller
+{};
+
+}
// - Player -
@@ -328,6 +386,8 @@ GstBusSyncReply Player::processSyncMessage( GstMessage
*message )
}
}
#endif
+} else if (gst_is_missing_plugin_message(message)) {
+TheMissingPluginInstaller::get().report(message);
} else if( GST_MESSAGE_TYPE( message ) == GST_MESSAGE_ERROR ) {
DBG( Error !\n );
if( mnWidth == 0 ) {
diff --git a/configure.ac b/configure.ac
index 5414754..ca530c1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10220,7 +10220,7 @@ if test $build_gstreamer_1_0 = yes; then
if test $enable_avmedia = yes -a $enable_gstreamer_1_0 != no; then
ENABLE_GSTREAMER_1_0=TRUE
AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( [GSTREAMER_1_0], [gstreamer-1.0
gstreamer-plugins-base-1.0 gstreamer-video-1.0] )
+PKG_CHECK_MODULES( [GSTREAMER_1_0], [gstreamer-1.0
gstreamer-plugins-base-1.0 gstreamer-pbutils-1.0 gstreamer-video-1.0] )
GSTREAMER_1_0_CFLAGS=$(printf '%s' $GSTREAMER_1_0_CFLAGS | sed -e
s/-I/${ISYSTEM?}/g)
else
AC_MSG_RESULT([no])
@@ -10238,8 +10238,8 @@ if test $build_gstreamer_0_10 = yes; then
if test $enable_avmedia = yes -a $enable_gstreamer_0_10 != no; then
ENABLE_GSTREAMER_0_10=TRUE
AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10
gstreamer-plugins-base-0.10 gstreamer-interfaces-0.10],, [
-PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10
gstreamer-plugins-base-0.10] )
+PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10
gstreamer-plugins-base-0.10 gstreamer-pbutils-0.10 gstreamer-interfaces-0.10],,
[
+PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10
gstreamer-plugins-base-0.10 gstreamer-pbutils-0.10] )
])
GSTREAMER_0_10_CFLAGS=$(printf '%s' $GSTREAMER_0_10_CFLAGS | sed -e
s/-I/${ISYSTEM?}/g)
else
diff --git
[Libreoffice-ux-advise] [Bug 86138] TOOLBAR: Context menu should state the name of the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=86138 Philippe Jung phil.j...@free.fr changed: What|Removed |Added Attachment #115521|0 |1 is obsolete|| --- Comment #7 from Philippe Jung phil.j...@free.fr --- Created attachment 115562 -- https://bugs.documentfoundation.org/attachment.cgi?id=115562action=edit Updated screenshot Patchset 3 pushed to gerrit. This is the new appearance of the popup. I reused an existing aTitleText defined with Menu::SetText The title is painted on top of the menu. It is no longer a hacked MenuItem. It is bold, centered on a slightly darker background. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91257] Cells show wrong numbers
https://bugs.documentfoundation.org/show_bug.cgi?id=91257 GerardF gerard.farg...@orange.fr changed: What|Removed |Added CC||gerard.farg...@orange.fr --- Comment #4 from GerardF gerard.farg...@orange.fr --- Have a look at Format Cell for each individual cells. Ctrl + M fixes the problem. Copy/paste from another program (what program) paste weird formatting. Paste special would have worked I presume. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70128] FORMATTING: Font formatting in calc (partial text in a cell)
https://bugs.documentfoundation.org/show_bug.cgi?id=70128 --- Comment #4 from bruno.bi...@cegepsherbrooke.qc.ca --- Bug still present in LO 4.4.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91263] New: [META] Microsoft Office 2013 Template Tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=91263 Bug ID: 91263 Summary: [META] Microsoft Office 2013 Template Tracker Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com This is a tracker to track all issues relating to the Microsoft Office 2013 Template project. If you're interested in helping in this project please contact me (get email from bugzilla), or find me at http://webchat.freenode.net/?channels=libreoffice-qa What you need: 1) Access to Microsoft Office 2013; 2) Latest master build of LibreOffice 3) Tremendous patience and diligence :) This will be an ongoing project that QA has been asked to tackle by developers working on interoperability. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91263] [META] Microsoft Office 2013 Template Tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=91263 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com, ||markus.mohrhard@googlemail. ||com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91029] Writer: character identification by copying into dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=91029 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||philip...@hotmail.com --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- I would assume the searching for a character to find its unicode number is a feature found in a character map application, or alternatively a user can search google for it, and isnt really suited to be a feature of the current special character dialog. @Adolfo, Heiko, Stuart: What is your opinion of this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91264] New: MSO2013 Template - DB Business Verification - Text Placement Incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=91264 Bug ID: 91264 Summary: MSO2013 Template - DB Business Verification - Text Placement Incorrect Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Created attachment 115566 -- https://bugs.documentfoundation.org/attachment.cgi?id=115566action=edit Original XLSX from MSO Windows 7 LibreOffice Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-13_01:52:36 Locale: en-US (en_US) Reproduce: 1) Download original file (Original XLSX from MSO) in LibreOffice 2) Compare header text BUSINESS VERIFICATION to that in PDF Observed: Placement is incorrect - distance between icon and first letter substantially more Note: In our case the text is left justified but it does not actually justify to the left side of Cell B1, if you change justification to center, then left again, the font position changes (still wrong) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90563] LibreOffice Calc crashes when attempting to format page
https://bugs.documentfoundation.org/show_bug.cgi?id=90563 raal r...@post.cz changed: What|Removed |Added Status|REOPENED|NEEDINFO CC||r...@post.cz OS|Linux (All) |All --- Comment #3 from raal r...@post.cz --- Peer, Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91264] MSO2013 Template - DB Business Verification - Text Placement Incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=91264 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||jmadero@gmail.com Resolution|--- |NOTOURBUG --- Comment #1 from Joel Madero jmadero@gmail.com --- I am closing this as NOTABUG - if you do a PDF export within Microsoft Office 2013 - the output matches what we show and not what Microsoft Office 2013 shows within Excel, so apparently this is their bug, not ours. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91265] New: MSO2013 Template - DB Business Verification - Chart Size Too Large
https://bugs.documentfoundation.org/show_bug.cgi?id=91265 Bug ID: 91265 Summary: MSO2013 Template - DB Business Verification - Chart Size Too Large Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Created attachment 115567 -- https://bugs.documentfoundation.org/attachment.cgi?id=115567action=edit Original.pdf Windows 7 Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-13_01:52:36 Locale: en-US (en_US) 1) Open Original.xlsx in LibreOffice 2) Compare chart position/size to Original.pdf (export from Microsoft Office 2013) Observed: Chart size is substantially larger/overlaps text in LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91265] MSO2013 Template - DB Business Verification - Chart Size Too Large
https://bugs.documentfoundation.org/show_bug.cgi?id=91265 Joel Madero jmadero@gmail.com changed: What|Removed |Added Blocks||91263 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91263] [META] Microsoft Office 2013 Template Tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=91263 Joel Madero jmadero@gmail.com changed: What|Removed |Added Depends on||91265 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91265] MSO2013 Template - DB Business Verification - Chart Size Too Large
https://bugs.documentfoundation.org/show_bug.cgi?id=91265 Joel Madero jmadero@gmail.com changed: What|Removed |Added CC||jmadero@gmail.com --- Comment #1 from Joel Madero jmadero@gmail.com --- Created attachment 115568 -- https://bugs.documentfoundation.org/attachment.cgi?id=115568action=edit Original.xlxs -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91266] MSO2013 Template - DB Business Verification - RoundTrip Shifts Chart Position
https://bugs.documentfoundation.org/show_bug.cgi?id=91266 Joel Madero jmadero@gmail.com changed: What|Removed |Added CC||jmadero@gmail.com --- Comment #1 from Joel Madero jmadero@gmail.com --- Created attachment 115570 -- https://bugs.documentfoundation.org/attachment.cgi?id=115570action=edit Original.pdf -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91266] New: MSO2013 Template - DB Business Verification - RoundTrip Shifts Chart Position
https://bugs.documentfoundation.org/show_bug.cgi?id=91266 Bug ID: 91266 Summary: MSO2013 Template - DB Business Verification - RoundTrip Shifts Chart Position Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Created attachment 115569 -- https://bugs.documentfoundation.org/attachment.cgi?id=115569action=edit Original.xlxs Windows 7 Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-13_01:52:36 Locale: en-US (en_US) 1) Open Original.xlxs 2) Save file as new file name 3) Open saved file in Microsoft Office 2013 4) Compare to Original.pdf Observed: Chart has shifted to the right some (shift.pdf) Expected: Roundtrip should not shift chart -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91125] Crash creating pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=91125 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Michael Meeks michael.me...@collabora.com --- Nailed it - this was really a surprisingly vicious bug =) Thanks for reporting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8struc.hxx | 14 ++ 1 file changed, 14 insertions(+) New commits: commit cfade6de8ea417a8b6b94bf6c320ac2d4c15e256 Author: Caolán McNamara caol...@redhat.com Date: Wed May 13 21:13:16 2015 +0100 rtf spec better describes the mysterious bx and by values Change-Id: Ic89bfcb13515ba3e9ce4410e84813d4e953ee603 diff --git a/sw/source/filter/ww8/ww8struc.hxx b/sw/source/filter/ww8/ww8struc.hxx index fbfbf65..38a4d1b 100644 --- a/sw/source/filter/ww8/ww8struc.hxx +++ b/sw/source/filter/ww8/ww8struc.hxx @@ -697,6 +697,20 @@ struct WW8_DO SVBT16 cb; // 2size (count of bytes) of the entire DO sal_uInt8 bx; // 4x position relative to anchor CP sal_uInt8 by; // 5y position relative to anchor CP + +/* + bx and by above are apparently better described by this info from the rtf standard... + +\dobxpage The drawing object is page relative in the x-direction. +\dobxcolumn The drawing object is column relative in the x-direction. +\dobxmargin The drawing object is margin relative in the x-direction. + +\dobypage The drawing object is page relative in the y-direction. +\dobypara The drawing object is paragraph relative in the y-direction. +\dobymargin The drawing object is margin relative in the y-direction. + +*/ + SVBT16 dhgt;// 6height of DO SVBT16 aBits1; // sal_uInt16 fAnchorLock : 1; // 81 if the DO anchor is locked ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90563] LibreOffice Calc crashes when attempting to format page
https://bugs.documentfoundation.org/show_bug.cgi?id=90563 --- Comment #4 from peer.fr...@web.de --- Created attachment 115576 -- https://bugs.documentfoundation.org/attachment.cgi?id=115576action=edit this (sanitized) spreadsheet crashes LO when trying to format page the print preview -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/view.hxx| 134 +++
starmath/source/document.cxx | 72 ++-
starmath/source/view.cxx | 47 ---
3 files changed, 120 insertions(+), 133 deletions(-)
New commits:
commit e42cc88032d3f59b289e5ff454101971eecc4bea
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 14 13:51:36 2015 +0900
cleanup starmath view/document
Change-Id: Ieda85c0f157a6b299ba10528dd3cee3fe9942783
diff --git a/starmath/inc/view.hxx b/starmath/inc/view.hxx
index 1256044..952dfac 100644
--- a/starmath/inc/view.hxx
+++ b/starmath/inc/view.hxx
@@ -44,47 +44,55 @@ class SmViewShell;
class SmPrintUIOptions;
class SmGraphicAccessible;
-/**/
-
class SmGraphicWindow : public ScrollableWindow
{
-Point aFormulaDrawPos;
-
+Point aFormulaDrawPos;
// old style editing pieces
Rectangle aCursorRect;
-bool bIsCursorVisible;
-bool bIsLineVisible;
+bool bIsCursorVisible;
+bool bIsLineVisible;
AutoTimer aCaretBlinkTimer;
public:
-bool IsCursorVisible() const { return bIsCursorVisible; }
+bool IsCursorVisible() const
+{
+return bIsCursorVisible;
+}
void ShowCursor(bool bShow);
-bool IsLineVisible() const { return bIsLineVisible; }
+bool IsLineVisible() const
+{
+return bIsLineVisible;
+}
void ShowLine(bool bShow);
const SmNode * SetCursorPos(sal_uInt16 nRow, sal_uInt16 nCol);
protected:
-voidSetIsCursorVisible(bool bVis) { bIsCursorVisible = bVis; }
-using Window::SetCursor;
-voidSetCursor(const SmNode *pNode);
-voidSetCursor(const Rectangle rRect);
-boolIsInlineEditEnabled() const;
+void SetIsCursorVisible(bool bVis)
+{
+bIsCursorVisible = bVis;
+}
+using Window::SetCursor;
+void SetCursor(const SmNode *pNode);
+void SetCursor(const Rectangle rRect);
+bool IsInlineEditEnabled() const;
private:
-::com::sun::star::uno::Reference
-::com::sun::star::accessibility::XAccessible xAccessible;
-SmGraphicAccessible * pAccessible;
+css::uno::Referencecss::accessibility::XAccessible xAccessible;
+SmGraphicAccessible* pAccessible;
-SmViewShell*pViewShell;
-sal_uInt16 nZoom;
+SmViewShell* pViewShell;
+sal_uInt16 nZoom;
protected:
-voidSetFormulaDrawPos(const Point rPos) { aFormulaDrawPos = rPos;
}
+void SetFormulaDrawPos(const Point rPos)
+{
+aFormulaDrawPos = rPos;
+}
virtual void DataChanged( const DataChangedEvent ) SAL_OVERRIDE;
virtual void Paint(vcl::RenderContext rRenderContext, const Rectangle)
SAL_OVERRIDE;
virtual void KeyInput(const KeyEvent rKEvt) SAL_OVERRIDE;
virtual void Command(const CommandEvent rCEvt) SAL_OVERRIDE;
virtual void StateChanged( StateChangedType eChanged ) SAL_OVERRIDE;
-DECL_LINK(MenuSelectHdl, Menu *);
+DECL_LINK(MenuSelectHdl, Menu*);
private:
void RepaintViewShellDoc();
@@ -98,35 +106,45 @@ public:
virtual void dispose() SAL_OVERRIDE;
// Window
-virtual voidMouseButtonDown(const MouseEvent rMEvt) SAL_OVERRIDE;
-virtual voidMouseMove(const MouseEvent rMEvt) SAL_OVERRIDE;
-virtual voidGetFocus() SAL_OVERRIDE;
-virtual voidLoseFocus() SAL_OVERRIDE;
+virtual void MouseButtonDown(const MouseEvent rMEvt) SAL_OVERRIDE;
+virtual void MouseMove(const MouseEvent rMEvt) SAL_OVERRIDE;
+virtual void GetFocus() SAL_OVERRIDE;
+virtual void LoseFocus() SAL_OVERRIDE;
-SmViewShell * GetView() { return pViewShell; }
+SmViewShell* GetView()
+{
+return pViewShell;
+}
-using Window::SetZoom;
-void SetZoom(sal_uInt16 Factor);
-using Window::GetZoom;
-sal_uInt16 GetZoom() const { return nZoom; }
+using Window::SetZoom;
+void SetZoom(sal_uInt16 Factor);
+using Window::GetZoom;
+sal_uInt16 GetZoom() const
+{
+return nZoom;
+}
-const PointGetFormulaDrawPos() const { return aFormulaDrawPos; }
+const Point GetFormulaDrawPos() const
+{
+return aFormulaDrawPos;
+}
void ZoomToFitInWindow();
-using ScrollableWindow::SetTotalSize;
+using ScrollableWindow::SetTotalSize;
void SetTotalSize();
-void ApplyColorConfigValues( const svtools::ColorConfig rColorCfg );
+void ApplyColorConfigValues(const svtools::ColorConfig rColorCfg);
// for Accessibility
-virtual ::com::sun::star::uno::Reference
::com::sun::star::accessibility::XAccessible CreateAccessible() SAL_OVERRIDE;
+virtual css::uno::Referencecss::accessibility::XAccessible
CreateAccessible() SAL_OVERRIDE;
-using Window::GetAccessible;
-SmGraphicAccessible * GetAccessible_Impl() { return
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/dialog.hxx|2 ++
starmath/source/dialog.cxx | 44 +---
2 files changed, 23 insertions(+), 23 deletions(-)
New commits:
commit 5b4408dab502ffef99e57244832a332497989e99
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Thu May 14 14:04:58 2015 +0900
SmShowFont: change to save the font and use it in Paint + HiDPI
No painting should be performed outside of Paint hierarchy.
Change-Id: I97a8d6429abcd6022e9bf89295dc2944485984eb
diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx
index c67190b..ec70f02 100644
--- a/starmath/inc/dialog.hxx
+++ b/starmath/inc/dialog.hxx
@@ -81,6 +81,8 @@ class SmShowFont : public vcl::Window
{
virtual void Paint(vcl::RenderContext rRenderContext, const Rectangle)
SAL_OVERRIDE;
+vcl::Font maFont;
+
public:
SmShowFont(vcl::Window *pParent, WinBits nStyle)
: Window(pParent, nStyle)
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 686c60c..f28a9a2 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -64,15 +64,15 @@ public:
SmFontStyles();
static sal_uInt16 GetCount() { return 4; }
-const OUString GetStyleName( const vcl::Font rFont ) const;
-const OUString GetStyleName( sal_uInt16 nIdx ) const;
+const OUString GetStyleName(const vcl::Font rFont) const;
+const OUString GetStyleName(sal_uInt16 nIdx) const;
};
SmFontStyles::SmFontStyles() :
-aNormal ( ResId( RID_FONTREGULAR, *SM_MOD()-GetResMgr() ) ),
-aBold ( ResId( RID_FONTBOLD,*SM_MOD()-GetResMgr() ) ),
-aItalic ( ResId( RID_FONTITALIC, *SM_MOD()-GetResMgr() ) )
+aNormal (ResId(RID_FONTREGULAR, *SM_MOD()-GetResMgr())),
+aBold (ResId(RID_FONTBOLD,*SM_MOD()-GetResMgr())),
+aItalic (ResId(RID_FONTITALIC, *SM_MOD()-GetResMgr()))
{
aBoldItalic = aBold;
@@ -81,7 +81,7 @@ SmFontStyles::SmFontStyles() :
}
-const OUString SmFontStyles::GetStyleName( const vcl::Font rFont ) const
+const OUString SmFontStyles::GetStyleName(const vcl::Font rFont) const
{
//! compare also SmSpecialNode::Prepare
bool bBold = IsBold( rFont ),
@@ -146,16 +146,13 @@ void SetFontStyle(const OUString rStyleName, vcl::Font
rFont)
rFont.SetWeight((nIndex 0x2) ? WEIGHT_BOLD : WEIGHT_NORMAL);
}
-
-/**/
-
IMPL_LINK( SmPrintOptionsTabPage, SizeButtonClickHdl, Button *,/*pButton*/ )
{
m_pZoom-Enable(m_pSizeZoomed-IsChecked());
return 0;
}
-SmPrintOptionsTabPage::SmPrintOptionsTabPage(vcl::Window *pParent, const
SfxItemSet rOptions)
+SmPrintOptionsTabPage::SmPrintOptionsTabPage(vcl::Window* pParent, const
SfxItemSet rOptions)
: SfxTabPage(pParent, SmathSettings,
modules/smath/ui/smathsettings.ui, rOptions)
{
get( m_pTitle, title);
@@ -241,15 +238,24 @@ VclPtrSfxTabPage
SmPrintOptionsTabPage::Create(vcl::Window* pWindow, const Sfx
return VclPtrSmPrintOptionsTabPage::Create(pWindow, rSet).get();
}
-void SmShowFont::Paint(vcl::RenderContext rRenderContext, const Rectangle
rRect )
+void SmShowFont::Paint(vcl::RenderContext rRenderContext, const Rectangle
rRect)
{
Window::Paint(rRenderContext, rRect);
+Color aTxtColor(rRenderContext.GetTextColor());
+vcl::Font aFont(maFont);
+aFont.SetSize(Size(0, 24 * rRenderContext.GetDPIScaleFactor()));
+aFont.SetAlign(ALIGN_TOP);
+rRenderContext.SetFont(aFont);
+
+// keep old text color (new font may have different color)
+rRenderContext.SetTextColor(aTxtColor);
+
OUString sText(rRenderContext.GetFont().GetName());
-Size TextSize(rRenderContext.GetTextWidth(sText),
rRenderContext.GetTextHeight());
+Size aTextSize(rRenderContext.GetTextWidth(sText),
rRenderContext.GetTextHeight());
-rRenderContext.DrawText(Point((GetOutputSize().Width() -
TextSize.Width()) / 2,
- (GetOutputSize().Height() -
TextSize.Height()) / 2), sText);
+rRenderContext.DrawText(Point((rRenderContext.GetOutputSize().Width() -
aTextSize.Width()) / 2,
+ (rRenderContext.GetOutputSize().Height() -
aTextSize.Height()) / 2), sText);
}
VCL_BUILDER_DECL_FACTORY(SmShowFont)
@@ -270,16 +276,8 @@ Size SmShowFont::GetOptimalSize() const
void SmShowFont::SetFont(const vcl::Font rFont)
{
-Color aTxtColor( GetTextColor() );
-vcl::Font aFont (rFont);
-
+maFont = rFont;
Invalidate();
-aFont.SetSize(Size(0, 24));
-aFont.SetAlign(ALIGN_TOP);
-Window::SetFont(aFont);
-
-// keep old text color (new font may have different color)
-SetTextColor( aTxtColor );
}
IMPL_LINK( SmFontDialog, FontSelectHdl, ComboBox *, pComboBox )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 91269] New: MSO2013 Template - DB Business Verification - Comment Bubble Covers Text and Won't Go Away
https://bugs.documentfoundation.org/show_bug.cgi?id=91269 Bug ID: 91269 Summary: MSO2013 Template - DB Business Verification - Comment Bubble Covers Text and Won't Go Away Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Created attachment 115574 -- https://bugs.documentfoundation.org/attachment.cgi?id=115574action=edit Original.xlsx Windows 7 Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-13_01:52:36 Locale: en-US (en_US) 1) Open Original.xlsx in LibreOffice; 2) Left click on C11 Observed: Comment bubble pops up in an awkward position (in the row), covers heading text and you cannot get it to go away. Expected: The comment is treated like any other comment and pops up in a comment bubble that you can easily close -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91029] Writer: character identification by copying into dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=91029 --- Comment #5 from Heiko Tietze heiko.tie...@user-prompt.com --- +1 for Regina -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91029] Writer: character identification by copying into dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=91029 --- Comment #5 from Heiko Tietze heiko.tie...@user-prompt.com --- +1 for Regina -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91125] Crash creating pivot table
https://bugs.documentfoundation.org/show_bug.cgi?id=91125 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1 tdf#91125 - unwind horrendous SvTreeListBox dragdrop code. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34438] feature request FORMATTING group not works with raster images
https://bugs.documentfoundation.org/show_bug.cgi?id=34438 --- Comment #9 from Ben benswans...@gmail.com --- I just want to say we are a SMB (60+ employees) this this issue is a deal breaker for migrating. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81749] Java UNO deadlock on document close
https://bugs.documentfoundation.org/show_bug.cgi?id=81749 Michael Stahl mst...@redhat.com changed: What|Removed |Added CC||mst...@redhat.com, ||sberg...@redhat.com --- Comment #1 from Michael Stahl mst...@redhat.com --- note: i've just removed the 25% of framework::Gate that was unused on master to make it easier to understand * the only way the Gate can be closed so that the thread will block in Gate::wait() is if another thread calls TransactionManager::registerTransaction() N times and blocks before calling N times TransactionManager::unregisterTransaction() unregisterTransaction() does not throw anything the only calls to both functions are from TransactionGuard which is RAII and only used on the stack = the main thread blocking on SolarMutex cannot be immediate cause of the deadlock * a self-deadlock is possible with Gate, but the only framework function on the blocking thread's stack is Frame::close() which already releases its TransactionGuard either some other thread is in framework code, or perhaps the lost wakeups cited in osl/conditn.hxx are to blame? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91270] New: UI: Crash on exit after Manage Changes
https://bugs.documentfoundation.org/show_bug.cgi?id=91270 Bug ID: 91270 Summary: UI: Crash on exit after Manage Changes Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gordon1dr...@yahoo.com Created attachment 115575 -- https://bugs.documentfoundation.org/attachment.cgi?id=115575action=edit backtrace 1. New Text Document. 2. Type test. 3. Edit - Track Changes - Record Changes on. 4. Delete test. 5. Edit - Track Changes - Manage Changes and Close. 6. Exit application. Result: Crash. Version: 5.0.0.0.alpha1+ Build ID: 5b3a30f40a7ce476922649b734f6ede1c2fdef4b TinderBox: Win-x86@42, Branch:master, Time: 2015-05-13_01:51:22 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/calcmove.cxx |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit 0811de12ee6727bbb9d4265217833ba02301eed8
Author: Michael Stahl mst...@redhat.com
Date: Wed May 13 17:55:46 2015 +0200
i#95974: sw: avoid layout crash on ooo95974-1.odt
There's a SwTxtFrame inside a table, and OptCalc() is called on it which
calls pUpper-Calc(), which reformats rows the table and ends up calling
SwTxtFrm::_AdjustFollow() on some SwTxtFrame that has the first one as
follow. Use the new ForbidDelete() hack to prevent immediate disaster.
Change-Id: I091704ce6cde15e322986b8f2ecefb5a518f0d8c
diff --git a/sw/source/core/layout/calcmove.cxx
b/sw/source/core/layout/calcmove.cxx
index 2a82263..8e101e7 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -346,7 +346,9 @@ void SwFrm::OptPrepareMake()
if ( GetUpper() !GetUpper()-IsFooterFrm()
!GetUpper()-IsFlyFrm() )
{
+ForbidDelete();
GetUpper()-Calc();
+AllowDelete();
OSL_ENSURE( GetUpper(), :-( Layout unstable (Upper gone). );
if ( !GetUpper() )
return;
@@ -1045,6 +1047,7 @@ void SwCntntFrm::MakeAll()
return;
}
+bool const bDeleteForbidden(IsDeleteForbidden());
ForbidDelete();
LockJoin();
long nFormatCount = 0;
@@ -1675,7 +1678,8 @@ void SwCntntFrm::MakeAll()
delete pSaveFtn;
UnlockJoin();
-AllowDelete();
+if (!bDeleteForbidden)
+AllowDelete();
if ( bMovedFwd || bMovedBwd )
pNotify-SetInvaKeep();
// OD 2004-02-26 #i25029#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
