[Libreoffice-bugs] [Bug 91864] Crash when closing Writer after having cancelled control setup of a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=91864 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Keywords||have-backtrace CC||michael.me...@collabora.com --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- Michael: vclptr related? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
review of OpenGL blacklist work
Hey, so as part of my work to integrate glyphy for OpenGL text rendering I finally managed to implement the last missing piece from my earlier blacklist work. Currently we have a blacklist based on the old Mozilla blacklist which has two downsides: 1.) The entries are mostly irrelevant to us (except for the two entries related to my systems). 2.) The blacklist is in the source code which means that if you discover combinations that cause issues (crashes, rendering issues, ...) you have no chance to help users until the next release. Mozilla, despite a much faster release cycle, has therefore already switched to mostly a xml based blacklist that is updated from a central server and only a small part (e.g. for past security issues) stays in the code). I have implemented something similar now in the feature/opengl-preparation branch for windows as preparation for the glyphy work (which is expected to uncover many driver bugs). I'd appreciated if someone would have a look at it and comment on the general idea (do we want to use that concept, is there something that I missed, ...). I'd also like to add one more feature to my xml files to be able to specify selected features that should be disabled. So it would be possibly to disable OpenGL text rendering while keeping the other OpenGL features available. Please note that the automatic update is not yet implemented as I have no URL on a TDF server yet. Is there a need for a similar service on Linux. Mesa is at least as bad as the Windows OpenGL drivers but I fear that all linux distros would disable that feature anyway so making it useless. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/unoobj/docuno.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eb8c323d94bf13d4a373f88c6b932a97701c283b Author: Henry Castro hcas...@collabora.com Date: Thu Jun 4 20:44:45 2015 -0400 sc tiled editing: EndTracking trigger MouseUp It does not need to trigger fake MouseUp event Change-Id: Id90c7787ef3312abe81bce359648aee0dfccd905 diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx index a47b7e0..87d9671 100644 --- a/sc/source/ui/unoobj/docuno.cxx +++ b/sc/source/ui/unoobj/docuno.cxx @@ -591,7 +591,7 @@ void ScModelObj::postMouseEvent(int nType, int nX, int nY, int nCount) // sometimes MouseButtonDown captures mouse and starts tracking, and VCL // will not take care of releasing that with tiled rendering if (pGridWindow-IsTracking()) -pGridWindow-EndTracking(); +pGridWindow-EndTracking(TrackingEventFlags::DontCallHdl); break; default: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ed81eaf2f9ac33912f54a9bfa6a1e3d1aad07dc8
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:10:28 2015 -0400
sc tiled editing: double-click empty cell
Change-Id: I35c43e2a22ac6591a2bcf9857808503c0e111344
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 0c7a5d3..eb1c5af 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2415,7 +2415,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent rMEvt
)
{
// don't forward the event to an empty cell, causes deselection in
// case we used the double-click to select the empty cell
-if (bIsTiledRendering)
+if (bIsTiledRendering bDouble)
{
ScRefCellValue aCell;
aCell.assign(*pViewData-GetDocument(), ScAddress(nPosX,
nPosY, nTab));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91859] Libre Office Base
https://bugs.documentfoundation.org/show_bug.cgi?id=91859 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Component|LibreOffice |Base -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91781] Reorganization of the menu bar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91781 --- Comment #40 from Adolfo Jayme f...@libreoffice.org --- The ESC has okayed pushing this into 5.0 as its a major release and of course it can be polished during the 5.x cycle. “And of course it can be polished during the 5.x cycle”. WHAT? So the ESC no longer cares about the UI freeze, about translators, about documenters? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sd/source
sd/source/ui/app/menuids_tmpl.src |8 +-
sd/source/ui/app/popup2_tmpl.src | 113 --
2 files changed, 30 insertions(+), 91 deletions(-)
New commits:
commit ca6997fbb8b1f4b8c039db1c487df0ce8961472c
Author: Yousuf Philips philip...@hotmail.com
Date: Wed Jun 3 19:52:10 2015 +0400
tdf#86614 Adjusting some text entries and rearranging and removing others
Change-Id: Ic3103e6ed1052fbc292f235e1e3104a61579519d
Reviewed-on: https://gerrit.libreoffice.org/16062
Reviewed-by: Yousuf Philips philip...@hotmail.com
Tested-by: Yousuf Philips philip...@hotmail.com
diff --git a/sd/source/ui/app/menuids_tmpl.src
b/sd/source/ui/app/menuids_tmpl.src
index 9ed590a..bf30830 100644
--- a/sd/source/ui/app/menuids_tmpl.src
+++ b/sd/source/ui/app/menuids_tmpl.src
@@ -430,7 +430,7 @@
Identifier = SID_OBJECT_ALIGN ; \
Command = .uno:AlignObjetMenu ; \
HelpId = CMD_SID_OBJECT_ALIGN ; \
-Text [ en-US ] = Al~ignment ; \
+Text [ en-US ] = Al~ign ; \
SubMenu = Menu\
{\
ItemList = \
@@ -653,7 +653,7 @@
{\
Identifier = SID_SET_DEFAULT ; \
HelpId = CMD_SID_SET_DEFAULT ; \
-Text [ en-US ] = ~Default ; \
+Text [ en-US ] = ~Default Formatting ; \
};
#define MN_FONTWORK\
@@ -669,14 +669,14 @@
{\
Identifier = SID_ORIGINAL_SIZE ; \
HelpId = CMD_SID_ORIGINAL_SIZE ; \
-Text [ en-US ] = ~Original Size ; \
+Text [ en-US ] = Restore ~Original Size ; \
};
#define MN_CROP\
MenuItem\
{\
Identifier = SID_OBJECT_CROP ; \
-Text [ en-US ] = Crop Image ; \
+Text [ en-US ] = Crop I~mage ; \
};
#define MN_GLUE_INSERT_POINT\
diff --git a/sd/source/ui/app/popup2_tmpl.src b/sd/source/ui/app/popup2_tmpl.src
index f9a2122..28c858f 100644
--- a/sd/source/ui/app/popup2_tmpl.src
+++ b/sd/source/ui/app/popup2_tmpl.src
@@ -35,25 +35,19 @@
{
MN_SET_DEFAULT
SEPARATOR
+MN_TRANSFORM
MN_LINE
MN_AREA
MN_TEXTATTR
-MN_TRANSFORM
MN_FONTWORK
SEPARATOR
MN_CHAR_PARAGRAPH
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_CONVERT
-// #i68101#
-SEPARATOR
-MN_OBJECT_TITLE_DESCRIPTION
-MN_NAME_GROUP
-// #i68101#
-
#if SD_POPUP == RID_DRAW_TEXTOBJ_POPUP
SEPARATOR
MN_ACTION
@@ -74,26 +68,20 @@
{
MN_SET_DEFAULT
SEPARATOR
+MN_TRANSFORM
MN_LINE
MN_AREA
MN_TEXTATTR
MN_OUTLINE_TEXT_AUTOFIT
-MN_TRANSFORM
MN_FONTWORK
SEPARATOR
MN_CHAR_PARAGRAPH
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_CONVERT
-// #i68101#
-SEPARATOR
-MN_OBJECT_TITLE_DESCRIPTION
-MN_NAME_GROUP
-// #i68101#
-
#if SD_POPUP == RID_DRAW_TEXTOBJ_POPUP
SEPARATOR
MN_ACTION
@@ -112,16 +100,17 @@
{
ItemList =
{
+MN_TRANSFORM
MN_LINE
MN_AREA
MN_TEXTATTR
-MN_TRANSFORM
+SEPARATOR
MN_EDIT_POINTS
SEPARATOR
MN_CHAR_PARAGRAPH
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_MIRROR
MNSUB_CONVERT
@@ -129,12 +118,6 @@
MN_LEAVE_GROUP
MN_DISMANTLE
-// #i68101#
-SEPARATOR
-MN_OBJECT_TITLE_DESCRIPTION
-MN_NAME_GROUP
-// #i68101#
-
#if SD_POPUP == RID_DRAW_TEXTOBJ_POPUP
SEPARATOR
MN_ACTION
@@ -157,8 +140,8 @@
MN_LINE
MN_AREA
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_MIRROR
// #i37263#
@@ -186,23 +169,18 @@
{
ItemList =
{
+MN_3D_WIN
+SEPARATOR
+MN_TRANSFORM
MN_LINE
MN_AREA
-MN_TRANSFORM
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_CONVERT
SEPARATOR
MN_ENTER_GROUP
-MN_3D_WIN
-
-// #i68101#
-SEPARATOR
-MN_OBJECT_TITLE_DESCRIPTION
-MN_NAME_GROUP
-// #i68101#
#if SD_POPUP == RID_DRAW_TEXTOBJ_POPUP
SEPARATOR
@@ -222,12 +200,12 @@
{
ItemList =
{
+MN_TRANSFORM
MN_LINE
MN_AREA
-MN_TRANSFORM
SEPARATOR
-MN_POSITION
MN_OBJECT_ALIGN
+MN_POSITION
MN_DISTRIBUTE
MNSUB_CONVERT
SEPARATOR
@@ -235,12 +213,6 @@
MN_LEAVE_GROUP
MN_3D_WIN
-// #i68101#
-SEPARATOR
-MN_OBJECT_TITLE_DESCRIPTION
-MN_NAME_GROUP
-
[Libreoffice-commits] core.git: Branch 'private/moggi/opengl-preparation' - 2 commits - vcl/opengl
vcl/opengl/win/WinDeviceInfo.cxx| 26 ++
vcl/opengl/win/blocklist_parser.cxx | 10 --
vcl/opengl/win/blocklist_parser.hxx |1 +
3 files changed, 35 insertions(+), 2 deletions(-)
New commits:
commit 756d7898166ebf40720d2f483ee17669e5841d63
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jun 5 04:40:21 2015 +0200
finally enable the blacklist parser
Change-Id: I8346872a3e5bc7443524e5039f66eea0d3d381cd
diff --git a/vcl/opengl/win/WinDeviceInfo.cxx b/vcl/opengl/win/WinDeviceInfo.cxx
index 0479358..670d3c2 100644
--- a/vcl/opengl/win/WinDeviceInfo.cxx
+++ b/vcl/opengl/win/WinDeviceInfo.cxx
@@ -9,6 +9,8 @@
#include opengl/win/WinDeviceInfo.hxx
+#include blocklist_parser.hxx
+
#include windows.h
#include setupapi.h
#include algorithm
@@ -884,8 +886,32 @@ OUString
WinOpenGLDeviceInfo::GetDeviceVendor(wgl::DeviceVendor id)
return *mpDeviceVendors[id];
}
+namespace {
+
+
+OUString getBlacklistFile()
+{
+OUString url(${$BRAND_BASE_DIR/ LIBO_ETC_FOLDER /
SAL_CONFIGFILE(bootstrap)
:UserInstallation}/user/config/opengl_blacklist_windows.xml);
+rtl::Bootstrap::expandMacros(url);
+
+return url;
+}
+
+
+}
+
void WinOpenGLDeviceInfo::FillBlacklist()
{
+OUString aURL = getBlacklistFile();
+WinBlocklistParser aParser(aURL, maDriverInfo);
+try {
+aParser.parse();
+}
+catch (...)
+{
+SAL_WARN(vcl.opengl.win, error parsing blacklist);
+maDriverInfo.clear();
+}
}
diff --git a/vcl/opengl/win/blocklist_parser.hxx
b/vcl/opengl/win/blocklist_parser.hxx
index c34af0a..6f0142b 100644
--- a/vcl/opengl/win/blocklist_parser.hxx
+++ b/vcl/opengl/win/blocklist_parser.hxx
@@ -19,6 +19,7 @@ class InvalidFileException
class WinBlocklistParser
{
+public:
WinBlocklistParser(const OUString rURL, std::vectorwgl::DriverInfo
rDriverList);
void parse();
commit d82eaaec2e1cd4c2def22301b134ece27e93b283
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jun 5 04:39:29 2015 +0200
fix a few bugs in blacklist parser
Change-Id: Iaeaa568c24d6814bb696d040bef02470bd46e8e1
diff --git a/vcl/opengl/win/blocklist_parser.cxx
b/vcl/opengl/win/blocklist_parser.cxx
index 83bf490..ef4771a 100644
--- a/vcl/opengl/win/blocklist_parser.cxx
+++ b/vcl/opengl/win/blocklist_parser.cxx
@@ -122,6 +122,10 @@ void WinBlocklistParser::handleDevice(wgl::DriverInfo
rDriver, xmlreader::XmlRe
{
rDriver.mbWhitelisted = true;
}
+else if (meBlockType == BlockType::BLACKLIST)
+{
+rDriver.mbWhitelisted = false;
+}
else if (meBlockType == BlockType::UNKNOWN)
{
throw InvalidFileException();
@@ -173,7 +177,8 @@ void WinBlocklistParser::handleDevice(wgl::DriverInfo
rDriver, xmlreader::XmlRe
}
else
{
-SAL_WARN(vcl.opengl.win, unsupported attribute);
+OString aAttrName(name.begin, name.length);
+SAL_WARN(vcl.opengl.win, unsupported attribute: aAttrName);
}
}
@@ -185,7 +190,7 @@ void WinBlocklistParser::handleDevice(wgl::DriverInfo
rDriver, xmlreader::XmlRe
int nsId;
xmlreader::XmlReader::Result res = rReader.nextItem(
-xmlreader::XmlReader::TEXT_NONE, name, nsId);
+xmlreader::XmlReader::TEXT_NORMALIZED, name, nsId);
if (res == xmlreader::XmlReader::RESULT_BEGIN)
{
@@ -203,6 +208,7 @@ void WinBlocklistParser::handleDevice(wgl::DriverInfo
rDriver, xmlreader::XmlRe
if (!bSuccess || !name.equals(id))
throw InvalidFileException();
+name = rReader.getAttributeValue(false);
OString aDeviceId(name.begin, name.length);
rDriver.maDevices.push_back(OStringToOUString(aDeviceId,
RTL_TEXTENCODING_UTF8));
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91847] “Filter Criteria” section does not fill extra space when resizing Standard Filter window
https://bugs.documentfoundation.org/show_bug.cgi?id=91847 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Summary|Standard Filter GUI in |“Filter Criteria” section |Calc: make resizable Filter |does not fill extra space |Criteria|when resizing Standard ||Filter window -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/moggi/opengl-preparation' - 11 commits - sc/source sw/inc sw/source vcl/inc vcl/Library_vcl.mk vcl/Module_vcl.mk vcl/opengl vcl/Package_opengl_blacklist
Rebased ref, commits from common ancestor:
commit 551fd0ec64c774fa46b177f2a77c59f668645954
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jun 5 03:47:30 2015 +0200
add license header to blacklist file
Change-Id: I19edaf928ab4d99b5d3c399b59e26d515c2265b0
diff --git a/vcl/opengl/opengl_blacklist_windows.xml
b/vcl/opengl/opengl_blacklist_windows.xml
index 6ff92d0..310bae0 100644
--- a/vcl/opengl/opengl_blacklist_windows.xml
+++ b/vcl/opengl/opengl_blacklist_windows.xml
@@ -1,3 +1,11 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+* This file is part of the LibreOffice project.
+*
+* This Source Code Form is subject to the terms of the Mozilla Public
+* License, v. 2.0. If a copy of the MPL was not distributed with this
+* file, You can obtain one at http://mozilla.org/MPL/2.0/.
+--
root
whitelist
entry os=7 vendor=intel compare=equal version=10.18.10.3412
commit a42ff0b771ccdf21ace297f91b372523a97b01da
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Jun 5 02:32:01 2015 +0200
install blacklist into user profile
Change-Id: I2571fcdde1689f1a168a5c5d6bd20785ce018927
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 8cb05ba..c278517 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Module_add_targets,vcl,\
CustomTarget_afm_hash \
Library_vcl \
Package_opengl \
+ Package_opengl_blacklist \
$(if $(filter DESKTOP,$(BUILD_TYPE)), \
StaticLibrary_vclmain \
$(if $(ENABLE_HEADLESS),, \
diff --git a/vcl/Package_opengl_blacklist.mk b/vcl/Package_opengl_blacklist.mk
new file mode 100644
index 000..b858a56
--- /dev/null
+++ b/vcl/Package_opengl_blacklist.mk
@@ -0,0 +1,16 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_Package_Package,vcl_opengl_blacklist,$(SRCDIR)/vcl/opengl))
+
+$(eval $(call
gb_Package_add_files,vcl_opengl_blacklist,$(LIBO_SHARE_PRESETS_FOLDER)/config,\
+ opengl_blacklist_windows.xml \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/vcl/opengl/win/blacklist.xml
b/vcl/opengl/opengl_blacklist_windows.xml
similarity index 100%
rename from vcl/opengl/win/blacklist.xml
rename to vcl/opengl/opengl_blacklist_windows.xml
commit 101e7b12c9a0c725175a5ce79e1e2b30d547a272
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Thu Jun 4 17:39:48 2015 +0200
remove all traces of old device code
Change-Id: I792749951f11e99504c708bf27bec56c2d98019e
diff --git a/vcl/inc/opengl/win/WinDeviceInfo.hxx
b/vcl/inc/opengl/win/WinDeviceInfo.hxx
index 37779a5..0c60b35 100644
--- a/vcl/inc/opengl/win/WinDeviceInfo.hxx
+++ b/vcl/inc/opengl/win/WinDeviceInfo.hxx
@@ -47,22 +47,6 @@ enum VersionComparisonOp {
DRIVER_COMPARISON_IGNORED
};
-enum DeviceFamily {
-IntelGMA500,
-IntelGMA900,
-IntelGMA950,
-IntelGMA3150,
-IntelGMAX3000,
-IntelGMAX4500HD,
-IntelHD3000,
-IntelMobileHDGraphics,
-NvidiaBlockD3D9Layers,
-RadeonX1000,
-Geforce7300GT,
-Nvidia310M,
-DeviceFamilyMax
-};
-
enum DeviceVendor {
VendorAll,
VendorIntel,
@@ -77,15 +61,8 @@ bool ParseDriverVersion(const OUString rString, uint64_t
rVersion);
struct DriverInfo
{
-typedef std::vectorOUString DeviceFamilyVector;
-
-// If |ownDevices| is true, you are transferring ownership of the devices
-// array, and it will be deleted when this GfxDriverInfo is destroyed.
-
-DriverInfo(OperatingSystem os, const OUString vendor, DeviceFamilyVector*
devices,
-VersionComparisonOp op,
-uint64_t driverVersion, bool bWhiteListed = false, const char
*suggestedVersion = nullptr,
-bool ownDevices = false);
+DriverInfo(OperatingSystem os, const OUString vendor, VersionComparisonOp
op,
+uint64_t driverVersion, bool bWhiteListed = false, const char
*suggestedVersion = nullptr);
DriverInfo();
DriverInfo(const DriverInfo);
@@ -96,8 +73,6 @@ struct DriverInfo
OUString maAdapterVendor;
-static DeviceFamilyVector* const allDevices;
-DeviceFamilyVector* mpDevices;
std::vectorOUString maDevices;
// Whether the mDevices array should be deleted when this structure is
@@ -113,9 +88,6 @@ struct DriverInfo
uint64_t mnDriverVersionMax;
static uint64_t allDriverVersions;
-static const DeviceFamilyVector* GetDeviceFamily(DeviceFamily id);
-static DeviceFamilyVector* mpDeviceFamilies[DeviceFamilyMax];
-
OUString maSuggestedVersion;
OUString maMsg;
};
diff --git a/vcl/opengl/win/WinDeviceInfo.cxx b/vcl/opengl/win/WinDeviceInfo.cxx
index d69ee1a..0479358 100644
--- a/vcl/opengl/win/WinDeviceInfo.cxx
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 3 commits - sc/source
sc/source/ui/unoobj/docuno.cxx |2 +-
sc/source/ui/view/gridwin.cxx |2 +-
sc/source/ui/view/viewdata.cxx |7 +++
3 files changed, 9 insertions(+), 2 deletions(-)
New commits:
commit 1b3d17ba7cd45dc0431b9b1809d908a7a066d9a1
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:37:55 2015 -0400
sc tiled editing: Editview register LOKit callback
Change-Id: I5ad07f0f3defacaac0f5dac724e9867bbc011dd6
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 22d46dc..8795afe 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -928,6 +928,13 @@ void ScViewData::SetEditEngine( ScSplitPos eWhich,
else
{
pEditView[eWhich] = new EditView( pNewEngine, pWin );
+
+if (pDoc-GetDrawLayer() pDoc-GetDrawLayer()-isTiledRendering())
+{
+
pEditView[eWhich]-registerLibreOfficeKitCallback(pDoc-GetDrawLayer()-getLibreOfficeKitCallback(),
+
pDoc-GetDrawLayer()-getLibreOfficeKitData());
+pEditView[eWhich]-setTiledRendering(true);
+}
}
// bei IdleFormat wird manchmal ein Cursor gemalt, wenn die View schon
weg ist (23576)
commit d1ed5b06b2cc7f52b896d6cd4ce0b59e8ceea6b9
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:10:28 2015 -0400
sc tiled editing: double-click empty cell
Change-Id: I35c43e2a22ac6591a2bcf9857808503c0e111344
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index c31d246..cfc0b5e 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2415,7 +2415,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent rMEvt
)
{
// don't forward the event to an empty cell, causes deselection in
// case we used the double-click to select the empty cell
-if (bIsTiledRendering)
+if (bIsTiledRendering bDouble)
{
ScRefCellValue aCell;
aCell.assign(*pViewData-GetDocument(), ScAddress(nPosX,
nPosY, nTab));
commit 671787e144345b03a801ede499cc4784e71d6941
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 20:44:45 2015 -0400
sc tiled editing: EndTracking trigger MouseUp
It does not need to trigger fake MouseUp event
Change-Id: Id90c7787ef3312abe81bce359648aee0dfccd905
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 73f674ef..36de586 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -591,7 +591,7 @@ void ScModelObj::postMouseEvent(int nType, int nX, int nY,
int nCount)
// sometimes MouseButtonDown captures mouse and starts tracking, and
VCL
// will not take care of releasing that with tiled rendering
if (pGridWindow-IsTracking())
-pGridWindow-EndTracking();
+pGridWindow-EndTracking(TrackingEventFlags::DontCallHdl);
break;
default:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 --- Comment #8 from Yousuf (Jay) Philips philip...@hotmail.com --- Created attachment 116293 -- https://bugs.documentfoundation.org/attachment.cgi?id=116293action=edit revised mockup Modified the mockup so a user could easily switch to a new master slide from the section and have renamed it 'Slide'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 --- Comment #8 from Yousuf (Jay) Philips philip...@hotmail.com --- Created attachment 116293 -- https://bugs.documentfoundation.org/attachment.cgi?id=116293action=edit revised mockup Modified the mockup so a user could easily switch to a new master slide from the section and have renamed it 'Slide'. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - 3 commits - sc/source
sc/source/ui/unoobj/docuno.cxx |2 +-
sc/source/ui/view/gridwin.cxx |2 +-
sc/source/ui/view/viewdata.cxx |7 +++
3 files changed, 9 insertions(+), 2 deletions(-)
New commits:
commit 3004be4465b1fcaa3cd6b44cb517fcbf1b067deb
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:37:55 2015 -0400
sc tiled editing: Editview register LOKit callback
Change-Id: I5ad07f0f3defacaac0f5dac724e9867bbc011dd6
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 22d46dc..8795afe 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -928,6 +928,13 @@ void ScViewData::SetEditEngine( ScSplitPos eWhich,
else
{
pEditView[eWhich] = new EditView( pNewEngine, pWin );
+
+if (pDoc-GetDrawLayer() pDoc-GetDrawLayer()-isTiledRendering())
+{
+
pEditView[eWhich]-registerLibreOfficeKitCallback(pDoc-GetDrawLayer()-getLibreOfficeKitCallback(),
+
pDoc-GetDrawLayer()-getLibreOfficeKitData());
+pEditView[eWhich]-setTiledRendering(true);
+}
}
// bei IdleFormat wird manchmal ein Cursor gemalt, wenn die View schon
weg ist (23576)
commit 08debbc33ca99a25947f3c845b41a58e1706e031
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:10:28 2015 -0400
sc tiled editing: double-click empty cell
Change-Id: I35c43e2a22ac6591a2bcf9857808503c0e111344
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index c31d246..cfc0b5e 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2415,7 +2415,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent rMEvt
)
{
// don't forward the event to an empty cell, causes deselection in
// case we used the double-click to select the empty cell
-if (bIsTiledRendering)
+if (bIsTiledRendering bDouble)
{
ScRefCellValue aCell;
aCell.assign(*pViewData-GetDocument(), ScAddress(nPosX,
nPosY, nTab));
commit 126abd9c58a98497bd40a2904a4c7e34264ecfe4
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 20:44:45 2015 -0400
sc tiled editing: EndTracking trigger MouseUp
It does not need to trigger fake MouseUp event
Change-Id: Id90c7787ef3312abe81bce359648aee0dfccd905
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 73f674ef..36de586 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -591,7 +591,7 @@ void ScModelObj::postMouseEvent(int nType, int nX, int nY,
int nCount)
// sometimes MouseButtonDown captures mouse and starts tracking, and
VCL
// will not take care of releasing that with tiled rendering
if (pGridWindow-IsTracking())
-pGridWindow-EndTracking();
+pGridWindow-EndTracking(TrackingEventFlags::DontCallHdl);
break;
default:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 86614] CONTEXT MENU: Way too many entries
https://bugs.documentfoundation.org/show_bug.cgi?id=86614 --- Comment #22 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Yousuf Philips committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=ca6997fbb8b1f4b8c039db1c487df0ce8961472c tdf#86614 Adjusting some text entries and rearranging and removing others It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/viewdata.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 856233d2ef20ba0f4118edd475308bd59442068c
Author: Henry Castro hcas...@collabora.com
Date: Thu Jun 4 21:37:55 2015 -0400
sc tiled editing: Editview register LOKit callback
Change-Id: I5ad07f0f3defacaac0f5dac724e9867bbc011dd6
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 22d46dc..8795afe 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -928,6 +928,13 @@ void ScViewData::SetEditEngine( ScSplitPos eWhich,
else
{
pEditView[eWhich] = new EditView( pNewEngine, pWin );
+
+if (pDoc-GetDrawLayer() pDoc-GetDrawLayer()-isTiledRendering())
+{
+
pEditView[eWhich]-registerLibreOfficeKitCallback(pDoc-GetDrawLayer()-getLibreOfficeKitCallback(),
+
pDoc-GetDrawLayer()-getLibreOfficeKitData());
+pEditView[eWhich]-setTiledRendering(true);
+}
}
// bei IdleFormat wird manchmal ein Cursor gemalt, wenn die View schon
weg ist (23576)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91866] Standard Filter: Add more than 8 filtering criterias
https://bugs.documentfoundation.org/show_bug.cgi?id=91866 Eldar eagala...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91866] New: Standard Filter: Add more than 8 filtering criterias
https://bugs.documentfoundation.org/show_bug.cgi?id=91866 Bug ID: 91866 Summary: Standard Filter: Add more than 8 filtering criterias Product: LibreOffice Version: 5.0.0.0.beta1 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eagala...@gmail.com Standard Filter have only 8 conditions in Filter Criteria. I suggest to implement unlimited number of conditions (or at least add more conditions, 100 for example) in Filter Criteria. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91867] New: Open Navigation/Style menu from the status bar in the sidebar.
https://bugs.documentfoundation.org/show_bug.cgi?id=91867 Bug ID: 91867 Summary: Open Navigation/Style menu from the status bar in the sidebar. Product: LibreOffice Version: 4.4.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: diaz.bast...@openmailbox.org Description of problem: Currently selecting items Number of pages/Page style from the status bar, the options navigation/Styles are displayed in window mode, repeating the options available from the sidebar. Version-Release number of selected component: LibreOffice 4.4.3.2 Fedora 22 (GNOME) How reproducible: Always Steps to Reproduce: 1. Select Page Number/style page from the status bar. 2. Click in the optión to display Navigation/styles menu. Current results: Navigation/style menus are displayed in windowed mode. Expected results: Navigation/style menus are displated in the sidebar Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'moggi/opengl-preparation'
New branch 'moggi/opengl-preparation' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Depends on||91856 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91856] The Sidebar should be able to be turned off permanently
https://bugs.documentfoundation.org/show_bug.cgi?id=91856 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Blocks||65138 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - include/svx svx/source
include/svx/svdotext.hxx|1 +
svx/source/svdraw/svdotextdecomposition.cxx | 12 ++--
svx/source/svdraw/svdotxed.cxx |5 -
3 files changed, 15 insertions(+), 3 deletions(-)
New commits:
commit c3c510a4cb0bae1e9acf1e2b172540456094202b
Author: matteocam matteo.campane...@gmail.com
Date: Fri Jun 5 01:54:10 2015 -0400
Non-overflowing text is moved when we exit editing
Change-Id: I4cab6c3363a2e58667599583d28a27cadb5266aa
diff --git a/include/svx/svdotext.hxx b/include/svx/svdotext.hxx
index a93f087..75df5ed 100644
--- a/include/svx/svdotext.hxx
+++ b/include/svx/svdotext.hxx
@@ -606,6 +606,7 @@ public:
const drawinglayer::geometry::ViewInformation2D aViewInformation)
const;
void impMoveChainedTextToNextLink(SdrTextObj *pNextTextObj) const;
+OutlinerParaObject *impGetNonOverflowingParaObject() const;
void impLeaveOnlyNonOverflowingText() const;
// Handler for Chained Text
diff --git a/svx/source/svdraw/svdotextdecomposition.cxx
b/svx/source/svdraw/svdotextdecomposition.cxx
index 802863f..6b7b630 100644
--- a/svx/source/svdraw/svdotextdecomposition.cxx
+++ b/svx/source/svdraw/svdotextdecomposition.cxx
@@ -728,7 +728,7 @@ void SdrTextObj::impDecomposeContourTextPrimitive(
rTarget = aConverter.getPrimitive2DSequence();
}
-void SdrTextObj::impLeaveOnlyNonOverflowingText() const
+OutlinerParaObject *SdrTextObj::impGetNonOverflowingParaObject() const
{
// Cut non overflowing text
NonOverflowingText *pNonOverflowingTxt =
@@ -754,7 +754,12 @@ void SdrTextObj::impLeaveOnlyNonOverflowingText() const
rOutliner.AddText(*pPObj);
}
-OutlinerParaObject *pNewText = rOutliner.CreateParaObject();
+ return rOutliner.CreateParaObject();
+}
+
+void SdrTextObj::impLeaveOnlyNonOverflowingText() const
+{
+OutlinerParaObject *pNewText = impGetNonOverflowingParaObject();
const_castSdrTextObj*(this)-SetOutlinerParaObject(pNewText);
//const_castSdrTextObj*(this)-ReformatText();
}
@@ -1540,6 +1545,9 @@ void SdrTextObj::impDecomposeChainedTextPrimitive(
assert (pNextTextObj);
// NOTE: Commented because we do not need to do this anymore (maybe
and for now)
//impMoveChainedTextToNextLink(pNextTextObj); // XXX: it actually
moves the overflowing text currently
+
+// XXX:
+//const_castSdrTextObj*(this)-impLeaveOnlyNonOverflowingText();
// Chaining occurred. Let's reset the status
const_castSdrTextObj*(this)-SetToBeChained( false );
diff --git a/svx/source/svdraw/svdotxed.cxx b/svx/source/svdraw/svdotxed.cxx
index c0a5164..62e2c01 100644
--- a/svx/source/svdraw/svdotxed.cxx
+++ b/svx/source/svdraw/svdotxed.cxx
@@ -280,7 +280,10 @@ void SdrTextObj::EndTextEdit(SdrOutliner rOutl)
// for now doing the same as below - probably we don't need
// any more chain checks here but one single default behavior
sal_Int32 nParaAnz = rOutl.GetParagraphCount();
-pNewText = rOutl.CreateParaObject( 0, nParaAnz );
+// XXX: FRESHLY COMMENTED (5/6/15) // FIXME:matteocam
+//pNewText = rOutl.CreateParaObject( 0, nParaAnz );
+
+pNewText = impGetNonOverflowingParaObject();
// set non overflow part of text to current box
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91852] [si-gui] while downloading cannot close the architecture selector window
https://bugs.documentfoundation.org/show_bug.cgi?id=91852 Florian Reisinger reisi...@gmail.com changed: What|Removed |Added CC||reisi...@gmail.com --- Comment #1 from Florian Reisinger reisi...@gmail.com --- For each component (Main, Helppack, SDK) WHEN selected, this prompt will show -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - configure.ac external/liborcus
configure.ac |2 -- external/liborcus/ExternalProject_liborcus.mk |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit ea2ed8a1d442d7f0e00b63abdab15fddb0d58233 Author: Tor Lillqvist t...@collabora.com Date: Fri Jun 5 00:46:26 2015 +0300 Bin superfluous assignments The variable is assigned an empty value already a few lines above. Change-Id: I52d2b650d908209421368384e44d95bfe18d93ae diff --git a/configure.ac b/configure.ac index ac00539..68242b0 100644 --- a/configure.ac +++ b/configure.ac @@ -5977,10 +5977,8 @@ if test $COM = MSC; then AC_MSG_CHECKING([whether $CXX supports C++11]) AC_MSG_RESULT(yes) # MSVC supports (a subset of) CXX11 without any switch -CXXFLAGS_CXX11= elif test $GCC = yes; then HAVE_CXX11= -CXXFLAGS_CXX11= AC_MSG_CHECKING([whether $CXX supports C++11]) for flag in -std=gnu++11 -std=gnu++0x -std=c++11 -std=c++0x ; do save_CXXFLAGS=$CXXFLAGS commit e48bb73b818d1e60b6a7a4389151ae6644805d4a Author: Tor Lillqvist t...@collabora.com Date: Fri Jun 5 00:44:12 2015 +0300 Fix weird compilation problem with __float128 Change-Id: I4a7ac5ee7f2f2c9d9d87517c826c1e80bd23477d diff --git a/external/liborcus/ExternalProject_liborcus.mk b/external/liborcus/ExternalProject_liborcus.mk index ff488bf..8a53fa8 100644 --- a/external/liborcus/ExternalProject_liborcus.mk +++ b/external/liborcus/ExternalProject_liborcus.mk @@ -63,7 +63,7 @@ liborcus_CPPFLAGS+=-D_GLIBCXX_DEBUG endif endif -liborcus_CXXFLAGS=$(CXXFLAGS) $(gb_VISIBILITY_FLAGS) $(gb_VISIBILITY_FLAGS_CXX) +liborcus_CXXFLAGS=$(CXXFLAGS) $(gb_VISIBILITY_FLAGS) $(gb_VISIBILITY_FLAGS_CXX) $(CXXFLAGS_CXX11) liborcus_LDFLAGS=$(LDFLAGS) $(gb_LTOFLAGS) ifeq ($(COM),MSC) liborcus_CXXFLAGS+=$(BOOST_CXXFLAGS) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91788] Crashing on opening odt file
https://bugs.documentfoundation.org/show_bug.cgi?id=91788 Ishayahu ishay...@mail.ru changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INVALID --- Comment #10 from Ishayahu ishay...@mail.ru --- java 8 update 45 x86 after reinstalling problem was solved -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Looking for help for clipboard in Math
Hi all,
I struggle with the clipboard. My goal is to import MathML in module
Math from clipboard, similar as it is imported from file. But I'm stuck.
Therefore some questions:
(1)
Has someone tried such already and found, that it is not possible?
(2)
The comments in file exchange.cxx refer to a document CLIP.SDW. Has
someone this document and can provide it?
(3)
I have added a .uno command which is executed in
SmViewShell::Execute(SfxRequest rReq)
My current attempt looks like this:
TransferableDataHelper aDataHelper(
TransferableDataHelper::CreateFromSystemClipboard(GetEditWindow()) );
SotFormatStringId nId;
DataFlavorExVector* pFormats;
pFormats = aDataHelper.GetDataFlavorExVector();
DataFlavorExVector::iterator aIter(
((DataFlavorExVector)*pFormats).begin() ),
aEnd(
((DataFlavorExVector)*pFormats).end() );
while ( aIter != aEnd )
{
nId = (*aIter).mnSotId;
...
aIter++;
}
I get some nId-values and for some of them I can get a stream and can
look at the content. But the clipboard content, which is generated by
the Windows program Math Input Control (mip.exe) is not noticed. But I
see that the clipboard has a content MathML and a content MathML
Presentation using the clipboard viewer Free Clipboard Viewer 2.0.
Why do I get no nId for it?
(4)
The numbers I get in nId are those from the list in exchange.cxx, and
for application/mathml+xml, which is not listed there, I get the next
one following the list. But how can I get the MimeType or the
HumanPresentableName for the detected nId? My following try does not
work, the strings are empty in all cases:
::com::sun::star::datatransfer::DataFlavor aFlavor;
SotExchange::GetFormatDataFlavor( nId, aFlavor ) )
String sHumanPresentableName(aFlavor.HumanPresentableName);
String sMimeType(aFlavor.MimeType);
(5)
I try to use SmViewShell::InsertFrom(SfxMedium rMedium). It seems to
work, but when the process arrives at SmXMLImport::endDocument(void),
the node tree is empty. Any tips, what I might have missed?
Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91865] New: FILEOPEN: CALC more than 100 rows of formula have all wrong result
https://bugs.documentfoundation.org/show_bug.cgi?id=91865 Bug ID: 91865 Summary: FILEOPEN: CALC more than 100 rows of formula have all wrong result Product: LibreOffice Version: 4.4.3.2 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sp_b...@pertoldi.net Created attachment 116292 -- https://bugs.documentfoundation.org/attachment.cgi?id=116292action=edit Wrong calculated formula after reopening and screenshots Adding a simple formula for more than 100 rows results in correct display. After saving and closing the file you reopen it. The unchanged formula shows a wrong calculating. If you want to see the wright result you delete one cell containig a formula at row 2 and copy the upper or lower cell to it. Voilà the correct result appears. used formula: B4: =C3+1 C4: =B4+1 See attached calc file. Regards Silvio P.S.: I'm a user not a developer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91864] New: Crash when closing Writer after having cancelled control setup of a shape
https://bugs.documentfoundation.org/show_bug.cgi?id=91864 Bug ID: 91864 Summary: Crash when closing Writer after having cancelled control setup of a shape Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: serval2...@yahoo.fr Created attachment 116291 -- https://bugs.documentfoundation.org/attachment.cgi?id=116291action=edit console+bt with debug symbols On pc Debian x86-64 with master sources updated today, I had a crash after having done this: - Open Writer with a brand new file - Display Form controls (Menu View/toolbars/Form Controls) - Click Push button and create one in the document - Right click on the button and select Control... - click Cancel - close document = crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91828] BASIC - CurrentValues are empty after opening a form which triggers a macro
https://bugs.documentfoundation.org/show_bug.cgi?id=91828 --- Comment #12 from christian_k...@gmx.net --- I have used Windows 8.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91677] Bughunting: Sliders on ruler are broken for some conditions
https://bugs.documentfoundation.org/show_bug.cgi?id=91677 --- Comment #8 from Yan Pashkovsky yanp...@gmail.com --- Interesting! If you delete page break (mouse over it, waut for button appears and click delete break) - then LO crashes. I'm using latest lodev 4 June -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91820] Reorganization of the menu bar for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91820 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||857 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 91857] Reorganization of the menu bar for Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91857 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||781, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||820 --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to Heiko Tietze from comment #2) I like the Slide menu, looking forward its counterpart for Writer. :-) Look forward to your suggestion for what that would contain in Writer. :D But shouldn't the Show Slide stuff go into this menu? First and Current at first level the others one down. Slide is focused on slide management and assume additional entries will likely go into the menu like for slide navigation - Next Slide (page down), Previous Slide (page up), First Slide, Last Slide. Slide Show is focused on the presentation part and may likely also expand in the future. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 91781] Reorganization of the menu bar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91781 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||857 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91857] Reorganization of the menu bar for Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91857 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||781, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||820 --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to Heiko Tietze from comment #2) I like the Slide menu, looking forward its counterpart for Writer. :-) Look forward to your suggestion for what that would contain in Writer. :D But shouldn't the Show Slide stuff go into this menu? First and Current at first level the others one down. Slide is focused on slide management and assume additional entries will likely go into the menu like for slide navigation - Next Slide (page down), Previous Slide (page up), First Slide, Last Slide. Slide Show is focused on the presentation part and may likely also expand in the future. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91820] Reorganization of the menu bar for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91820 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||857 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/source include/vcl vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/source vcl/win
canvas/source/cairo/cairo_textlayout.cxx | 97 -
include/vcl/sysdata.hxx | 16 +--
vcl/Library_vcl.mk |2
vcl/inc/quartz/salgdi.h |6 -
vcl/inc/salgdi.hxx |9 ++
vcl/inc/win/salgdi.h |6 -
vcl/quartz/salgdi.cxx| 10 --
vcl/quartz/salgdicommon.cxx | 118 --
vcl/source/outdev/font.cxx |4
vcl/source/outdev/outdev.cxx |9 --
vcl/win/source/gdi/salgdi.cxx| 139 ---
vcl/win/source/gdi/salgdi3.cxx | 15 ---
12 files changed, 29 insertions(+), 402 deletions(-)
New commits:
commit e4d55e8045c99af65a2cae57b26ec076825c9673
Author: Mox Soini m...@iki.fi
Date: Tue Jun 2 23:52:56 2015 +0300
Cleanup crossplatform cairo
Mac / Win cairo is not built / used, this cairo code can be removed to
reduce code bloat.
Change-Id: I758d674291e25e0722f5c66a0096295e903786b1
Reviewed-on: https://gerrit.libreoffice.org/16049
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
diff --git a/canvas/source/cairo/cairo_textlayout.cxx
b/canvas/source/cairo/cairo_textlayout.cxx
index 03d31947..570daaf 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -26,15 +26,6 @@
#include vcl/metric.hxx
#include vcl/virdev.hxx
-
-#ifdef WNT
-#ifdef max
-#undef max
-#endif
-#ifdef min
-#undef min
-#endif
-#endif
#include vcl/sysdata.hxx
#include basegfx/matrix/b2dhommatrix.hxx
@@ -45,21 +36,12 @@
#include cairo_textlayout.hxx
#include cairo_spritecanvas.hxx
-#ifdef CAIRO_HAS_QUARTZ_SURFACE
-#include cairo-quartz.h
-#elif defined CAIRO_HAS_WIN32_SURFACE
-# include cairo_win32_cairo.hxx
-# include cairo-win32.h
-#elif defined CAIRO_HAS_FT_FONT
+#if defined CAIRO_HAS_FT_FONT
# include cairo-ft.h
#else
# error Native API needed.
#endif
-#ifdef IOS
-#include CoreText/CoreText.h
-#endif
-
using namespace ::cairo;
using namespace ::com::sun::star;
@@ -309,7 +291,7 @@ namespace cairocanvas
**/
bool TextLayout::isCairoRenderable(SystemFontData aSysFontData) const
{
-#if defined UNX !defined MACOSX !defined IOS
+#if defined CAIRO_HAS_FT_FONT
// is font usable?
if (!aSysFontData.nFontId)
return false;
@@ -325,46 +307,6 @@ namespace cairocanvas
return true;
}
-#ifdef CAIRO_HAS_WIN32_SURFACE
-namespace
-{
-/**
- * cairo::ucs4toindex: Convert ucs4 char to glyph index
- * @param ucs4 an ucs4 char
- * @param hfont current font
- *
- * @return true if successful
- **/
-unsigned long ucs4toindex(unsigned int ucs4, HFONT hfont)
-{
-wchar_t unicode[2];
-WORD glyph_index;
-HDC hdc = NULL;
-
-hdc = CreateCompatibleDC (NULL);
-
-if (!hdc) return 0;
-if (!SetGraphicsMode (hdc, GM_ADVANCED))
-{
-DeleteDC (hdc);
-return 0;
-}
-
-SelectObject (hdc, hfont);
-SetMapMode (hdc, MM_TEXT);
-
-unicode[0] = ucs4;
-unicode[1] = 0;
-if (GetGlyphIndicesW (hdc, unicode, 1, glyph_index, 0) ==
GDI_ERROR)
-{
-glyph_index = 0;
-}
-
-DeleteDC (hdc);
-return glyph_index;
-}
-}
-#endif
/**
* TextLayout::draw
@@ -385,9 +327,6 @@ namespace cairocanvas
{
::osl::MutexGuard aGuard( m_aMutex );
SystemTextLayoutData aSysLayoutData;
-#if (defined CAIRO_HAS_WIN32_SURFACE) (OSL_DEBUG_LEVEL 1)
-LOGFONTW logfont;
-#endif
setupLayoutMode( rOutDev, mnTextDirection );
// TODO(P2): cache that
@@ -484,11 +423,6 @@ namespace cairocanvas
cairo_glyph_t aGlyph;
aGlyph.index = systemGlyph.index;
-#ifdef CAIRO_HAS_WIN32_SURFACE
-// Cairo requires standard glyph indexes (ETO_GLYPH_INDEX),
while vcl/win/* uses ucs4 chars.
-// Convert to standard indexes
-aGlyph.index = ucs4toindex((unsigned int) aGlyph.index,
rSysFontData.hFont);
-#endif
aGlyph.x = systemGlyph.x;
aGlyph.y = systemGlyph.y;
cairo_glyphs.push_back(aGlyph);
@@ -502,24 +436,7 @@ namespace cairocanvas
**/
cairo_font_face_t* font_face = NULL;
-#ifdef CAIRO_HAS_QUARTZ_SURFACE
-# ifdef MACOSX
-// TODO: use cairo_quartz_font_face_create_for_cgfont(cgFont)
-// when CGFont (Mac OS X 10.5 API) is provided by the AQUA
VCL backend.
-font_face =
cairo_quartz_font_face_create_for_atsu_font_id((ATSUFontID)
rSysFontData.aATSUFontID);
-# else // iOS
-
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - libreofficekit/source
Rebased ref, commits from common ancestor:
commit 4a8a5527b4ab7387866db1f891f34b8f795aa79d
Author: Pranav Kant pran...@gnome.org
Date: Thu Jun 4 22:09:57 2015 +0530
lokdocview, tilebuffer: clean up
Improve documentation, style fixes
Change-Id: I5000e32e90cd8e3b75e8df2907673efc303a55fd
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 50ddc76..5e90ca9 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
@@ -177,12 +177,12 @@ struct LOKDocView_Impl
/// Implementation of the timeout handler, invoked by handleTimeout().
gboolean handleTimeoutImpl();
/**
- * Renders the document to a number of tiles.
+ * Renders the document to a number of visible tiles.
*
* This method is invoked only manually, not when some Gtk signal is
* emitted.
*
- * @param pPartial if 0, then the full document is rendered, otherwise only
+ * @param pPartial if 0, then the full visible document is rendered,
otherwise only
* the tiles that intersect with pPartial.
*/
void renderDocument(GdkRectangle* pPartial);
@@ -665,7 +665,7 @@ void LOKDocView_Impl::setTilesInvalid(const GdkRectangle
rRectangle)
for (int i = aStart.x; i aEnd.x; i++)
for (int j = aStart.y; j aEnd.y; j++)
-m_pTileBuffer-tile_buffer_set_invalid(i, j);
+m_pTileBuffer-setInvalid(i, j);
}
void LOKDocView_Impl::renderHandle(cairo_t* pCairo, const GdkRectangle
rCursor, cairo_surface_t* pHandle, GdkRectangle rRectangle)
@@ -801,7 +801,8 @@ void LOKDocView_Impl::renderDocument(GdkRectangle* pPartial)
GdkRectangle aTileRectangleTwips, aTileRectanglePixels;
bool bPaint = true;
-// Determine size of the tile: the rightmost/bottommost tiles may
be smaller and we need the size to decide if we need to repaint.
+// Determine size of the tile: the rightmost/bottommost tiles may
+// be smaller, and we need the size to decide if we need to
repaint.
if (nColumn == nColumns - 1)
aTileRectanglePixels.width = nDocumentWidthPixels - nColumn *
nTileSizePixels;
else
@@ -811,7 +812,8 @@ void LOKDocView_Impl::renderDocument(GdkRectangle* pPartial)
else
aTileRectanglePixels.height = nTileSizePixels;
-// Determine size and position of the tile in document
coordinates, so we can decide if we can skip painting for partial rendering.
+// Determine size and position of the tile in document coordinates,
+// so we can decide if we can skip painting for partial rendering.
aTileRectangleTwips.x = pixelToTwip(nTileSizePixels, m_fZoom) *
nColumn;
aTileRectangleTwips.y = pixelToTwip(nTileSizePixels, m_fZoom) *
nRow;
aTileRectangleTwips.width =
pixelToTwip(aTileRectanglePixels.width, m_fZoom);
@@ -824,12 +826,14 @@ void LOKDocView_Impl::renderDocument(GdkRectangle*
pPartial)
if (bPaint)
{
-//g_info(gettile: (%d %d), nRow, nColumn);
+g_info(tile_buffer_get_tile (%d, %d), nRow, nColumn);
-Tile currentTile = m_pTileBuffer-tile_buffer_get_tile(nRow,
nColumn);
-GdkPixbuf* pPixBuf = currentTile.tile_get_buffer();
+Tile currentTile = m_pTileBuffer-getTile(nRow, nColumn);
+GdkPixbuf* pPixBuf = currentTile.getBuffer();
-gdk_cairo_set_source_pixbuf (pcairo, pPixBuf,
twipToPixel(aTileRectangleTwips.x, m_fZoom), twipToPixel(aTileRectangleTwips.y,
m_fZoom));
+gdk_cairo_set_source_pixbuf (pcairo, pPixBuf,
+
twipToPixel(aTileRectangleTwips.x, m_fZoom),
+
twipToPixel(aTileRectangleTwips.y, m_fZoom));
cairo_paint(pcairo);
}
}
@@ -942,7 +946,7 @@ gboolean LOKDocView_Impl::callbackImpl(CallbackData*
pCallback)
}
else
{
-m_pTileBuffer-tile_buffer_reset_all_tiles();
+m_pTileBuffer-resetAllTiles();
renderDocument(0);
}
}
@@ -1148,21 +1152,28 @@ static void lok_docview_init( GTypeInstance* pInstance,
gpointer )
gtk_scrolled_window_add_with_viewport( GTK_SCROLLED_WINDOW(pDocView),
pDocView-m_pImpl-m_pDrawingArea );
-g_signal_connect(GTK_OBJECT(pDocView-m_pImpl-m_pDrawingArea),
+g_signal_connect(G_OBJECT(pDocView-m_pImpl-m_pDrawingArea),
expose-event,
-
[Libreoffice-bugs] [Bug 91833] FORMATTING: Table border superimposes other images, ignores arrangement
https://bugs.documentfoundation.org/show_bug.cgi?id=91833 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Gordo gordon1dr...@yahoo.com --- Arrange - To Foreground. Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91857] Reorganization of the menu bar for Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91857 --- Comment #2 from Heiko Tietze heiko.tie...@user-prompt.com --- I like the Slide menu, looking forward its counterpart for Writer. :-) But shouldn't the Show Slide stuff go into this menu? First and Current at first level the others one down. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91857] Reorganization of the menu bar for Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91857 --- Comment #2 from Heiko Tietze heiko.tie...@user-prompt.com --- I like the Slide menu, looking forward its counterpart for Writer. :-) But shouldn't the Show Slide stuff go into this menu? First and Current at first level the others one down. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 90482] Crash on Exit
https://bugs.documentfoundation.org/show_bug.cgi?id=90482 --- Comment #7 from john b john.bertel...@almartin.com --- I just upgraded to 4.4.3 after about 3 exits from LO it crashed. Sorry did not get the details. Will add next time it happens. John B. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91801] Calculations in tables with variables would cut off part of the calculation upon print
https://bugs.documentfoundation.org/show_bug.cgi?id=91801 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Gordo gordon1dr...@yahoo.com --- Could you please attach the sample file and the pdf. Set to NEEDINFO. Please change back to UNCONFIRMED once the necessary information has been provided. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91801] Calculations in tables with variables would cut off part of the calculation upon print
https://bugs.documentfoundation.org/show_bug.cgi?id=91801 mchan...@shaw.ca changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91801] Calculations in tables with variables would cut off part of the calculation upon print
https://bugs.documentfoundation.org/show_bug.cgi?id=91801 --- Comment #2 from mchan...@shaw.ca --- Created attachment 116289 -- https://bugs.documentfoundation.org/attachment.cgi?id=116289action=edit sample file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91860] Change of Ctrl-Shift-Right selection behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=91860 drm4...@mail.ru changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from drm4...@mail.ru --- (In reply to Cor Nouws from comment #3) One of your complaints is handled in here https://bugs.documentfoundation.org/show_bug.cgi?id=89154 So, this bug thread is still in progress? What older versions do you refer to? In LibreOffice 3.3.0 the selection _does_ include the space. Strange. I haven't used LO for a year (not sure what the previous version was), but before that I was quite an active user, but never encountered such behavior (however, I do not remember when I learnt this key combination). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91801] Calculations in tables with variables would cut off part of the calculation upon print
https://bugs.documentfoundation.org/show_bug.cgi?id=91801 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Gordo gordon1dr...@yahoo.com --- You need to insert the variables into the document so that they can be referenced. If you don't want them to be seen when printing then set them to invisible before you insert them. Changed to RESOLVED WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Minutes of the Design Hangout: 2015-06-03
* Present: Heiko, Kendy, Jay, Steve * Completed Action Items: + Jay: Make sifr icons fall back on breeze icons as breeze is more complete (The styles are quite different and this looks poor in Mac. Adolfo) * Pending Action Items: + Kendy: Create a CoreHack to modify the tree view to have a Proof-of-concept of the Accordion widget + Jay: Send a mail to documentat...@global.libreoffice.org with the wiki page that collects changes in menus + Kendy: Collecting of the user information should be incremental, somewhere in the user's profile + Ahmed: Push the new Sifr icons he's done recently + Kendy: Talk to Milos wrt. https://bugs.freedesktop.org/show_bug.cgi?id=48622 + Samuel: Formulas and Navigator should open in the sidebar, not as a special window https://bugs.freedesktop.org/show_bug.cgi?id=85897 + Is that issue for the Navigator too (I dont read it from the issue) and in Writer the choice anycase was to allow opening separate too. (Cor, after discussion on 20150128) + the bug report only discusses the separate formulas sidebar in calc (Jay) + Kendy: https://bugs.freedesktop.org/show_bug.cgi?id=87794 + check how the sliders in the Audio/Video toolbar are implemented to move them to sidebar * UI changes integrated the last week: + Lower half of slide transition tab reorganized (Rishabh) + Shrink the properties sidebar sections in Calc (Rishabh) + Writer menubar reorganized (Jay) + Insert row/col before/after in Calc (Philippe) + Hide common task toolbar in master slide view (Philippe) + Tango updates (Adolfo, Jay) + Formatting, Impress and Draw toolbar improvements (Jay) * Icon Updates / Issues (Jay) + Sifr icons now fall back on breeze icons as breeze is more complete + The styles are quite different and this looks poor in Mac. (Adolfo) + unfortunately it is so with any fallback (Jay) + and breeze is closer than any other fallback (Jay) + the best would be to finish the Sifr theme :-) - designers appreciated! (Kendy) + breeze on mac - https://bug-attachments.documentfoundation.org/attachment.cgi?id=116255 + looks good! (Heiko, Jay, Kendy) + let's switch to that for the RC - and if there are complaints, revert (Kendy) + some general concerns about breeze, but in this case it seems to look work well (Heiko) + conclusion: let's switch to that now on OS X, and if there's push-back, revert + some icons have white instead of black on Windows (Jay) + bugreport: https://bugs.documentfoundation.org/show_bug.cgi?id=91432 + Tango (Alex/Adolfo/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1OErlXIDDGM7V1mOGW8oSCLuhqw5fulT1XhkTik1u2UY/edit?usp=sharing + Alex: Gnome 2.20-style 'a' icons Gnome 3-style text line icons (Adolfo) + Sifr (Papamatti/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/15ZpVaTxg7TAFYhOyQUP3mp-cVtKA1vP5uZAT38t-taA/edit?usp=sharing + Breeze (Andreas/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1dpMFgmkQy4BsyRIKH97ZLPTU6NdvXIYk3Yossj6sSQM/edit?usp=sharing + Extra-Large (32x32) Icons for large resolutions + Status - https://docs.google.com/document/d/1mPqD2gGsMkfVCI6ByUd2XYX1NJm26hcGjRVe6gcCSEU/edit?usp=sharing * UX patches to approve backporting into 5.0 by (Kendy/Jay) + https://gerrit.libreoffice.org/16030 (Bubli) + pushed + https://gerrit.libreoffice.org/16037 (Jay) https://gerrit.libreoffice.org/16032 + pushed + https://gerrit.libreoffice.org/16061/ (Phillipe) + 2 more reviews needed (Bubli? Jay?) + https://gerrit.libreoffice.org/16007 (Phillipe) https://gerrit.libreoffice.org/16034 + Waiting for ESC * Track changes sidebar (Jay) + Can we set a smaller size for the 4 buttons, so that the tab's minimum size can be smaller + asked Rishab fix this (Jay) + About the action column icons, it would be good to center it rather than having it aligned to the right and a formatting change has a plus sign, which should be changed to a 'T' icon like from textbox. Any possibility to have a tooltip above these action icons. + at the design session, did we decide to use text in the end, or not? (Kendy) + http://user-prompt.com/tracking-changes-with-libreoffice/ - use icons in the end + sw/source/ui/shells/shells.src IMG_REDLINE_INSERTED .. IMG_REDLINE_AUTOFMT + the actual icons are in icon-themes/galaxy/sw/res/redline_* + will ask Rishab to do the centering (Jay) + http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f363ce8bc563f64271744026cf0e16830cf9b06 + this implemented the icons (to
[Libreoffice-bugs] [Bug 91862] Format changes in DOC files are not displayed as tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=91862 --- Comment #1 from Pedro pedl...@gmail.com --- Created attachment 116287 -- https://bugs.documentfoundation.org/attachment.cgi?id=116287action=edit PNG image with screenshot of MS Word 2010 showing the highlighted changes -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: test infrastructure ideas appreciated ... - a11y based testing
On 05/06/2015 00:39, Michael Meeks wrote: On Thu, 2015-06-04 at 16:14 +0200, Noel Grandin wrote: mjayfrancis(IRC) is doing some interesting automated-UI testing work using the UNO accessibility API - perhaps get him on contract to finish it up and make it nice? Ah - it'd be great to use our UNO API directly, rather than via some wrapper - then it can be effortlessly cross-platform ... will split your ideas up - perhaps into threads ? The framework I've got so far is based on a UNO sandwich - setting up a test environment, and the final check of the results of actions are done through (Py)UNO, while the manipulation of the UI itself (the filling) is done through Dogtail, a Red Hat project which is itself a wrapper around the pyatspi accessibility library (and hence currently Linux only) Replacing the filling with more UNO could be done, but it would need at least a replacement for the Dogtail convenience layer (which makes a lot of the work of finding and interacting with the correct UI elements very easy), and possibly some other work on the raw UNO accessibility API. Ultimately this is an achievable volume of work, but it will take some time to investigate, and I want to get as far as possible through some other aspects of making UI testing easier before tackling it - much of the rest of the approach/framework will still be applicable. At present I'm on a side project to improve the usability of PyUNO by making UNO collections (the XIndexAccess, XNameAccess, XEnumerationAccess family) function as native Python lists, dicts and iterators. Hopefully this too should help make it easier to write tests for LO. As of today the basic functionality of this all works, and I hope to be able to push it for review some time next week. Regards Matthew Francis ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91862] New: Format changes in DOC files are not displayed as tracked changes
https://bugs.documentfoundation.org/show_bug.cgi?id=91862 Bug ID: 91862 Summary: Format changes in DOC files are not displayed as tracked changes Product: LibreOffice Version: 3.6.7.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pedl...@gmail.com Created attachment 116286 -- https://bugs.documentfoundation.org/attachment.cgi?id=116286action=edit DOC text document with tracked changes When opening a DOC file with track changes only text changes are displayed as modified. This is particularly bad if users are exchanging revisions of a document. Steps to reproduce: 1) Open the attached document in LibreOffice Observed: only two words are marked as modified Expected: format changes (including change to non-italic) are also marked. See attached image. This should be considered data loss because information that should be passed between authors is lost (just happened to me on a paper to be submitted) NOTE: I tested opening this document with LibreOffice 4.4.4, 4.3.6, 4.2.8 and 3.6.7 with the same result so I'm marking 3.6.7 as the oldest earliest affected (but maybe this occurs in all earlier releases). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Minutes of the Design Hangout: 2015-05-27
* Present: Heiko, Kendy, Andreas, Jay (late) * Completed Action Items: * Pending Action Items: + Kendy: Create a CoreHack to modify the tree view to have a Proof-of-concept of the Accordion widget + Jay: Send a mail to documentat...@global.libreoffice.org with the wiki page that collects changes in menus + Kendy: Collecting of the user information should be incremental, somewhere in the user's profile + Ahmed: Push the new Sifr icons he's done recently + Kendy: Talk to Milos wrt. https://bugs.freedesktop.org/show_bug.cgi?id=48622 + Alex: Gnome 2.20-style 'a' icons Gnome 3-style text line icons + Samuel: Formulas and Navigator should open in the sidebar, not as a special window https://bugs.freedesktop.org/show_bug.cgi?id=85897 + Is that issue for the Navigator too (I dont read it from the issue) and in Writer the choice anycase was to allow opening separate too. (Cor, after discussion on 20150128) + the bug report only discusses the separate formulas sidebar in calc (Jay) + Kendy: https://bugs.freedesktop.org/show_bug.cgi?id=87794 + check how the sliders in the Audio/Video toolbar are implemented to move them to sidebar + Kendy: Make sifr icons fall back on breeze icons as breeze is， more complete * UI changes integrated the last week: + sorting table in named ranges (Bubli) + update tango icons (Adolfo) + menubar fixes (Jay) * Artwork for LibreOffice 5.0 call for proposals (Stuart/Kendy) + Added the 5.0 Branding artwork call for proposals (Stuart) https://wiki.documentfoundation.org/Design/Whiteboards/5.0_Branding + results: + contributions from 5 people: those listed on the page + one sent by mail + conclusion: send a mail to the visual identity committee what should be chosen, and how to proceed * UI Guidelines (Heiko) + https://docs.google.com/document/d/1hSYOFoG6jnj2G0zWDbUYkrGZoj7YCSI9j3onkTZ65bU/edit + agreed menus toolbars the last week (Heiko) + menus should contain everything - Eve can work with menus + while Benjamin prefers toolbars + Heiko will transfer the content to the wiki, and then writer a summary blogpost + announce on the mailing list + and a short blopost - about the recent changes (Heiko) /done + https://wiki.documentfoundation.org/Design/MenuBar + https://wiki.documentfoundation.org/Design/ToolBar + http://user-prompt.com/libreoffice-human-interface-guidelines-the-second-step/ * How autofilter should work (Mattias, Heiko) + https://bugs.documentfoundation.org/show_bug.cgi?id=63416 Should it be smart and try to guess about header fields (and possibly sometimes fail) or should it be always consistent and just assume the first row is the header (as MSO does it) + sorting is also affected by auto filter + check the competitor's solutions (Jay) - define test scenario first - what happens when autofilter buttons are placed in the middle of data rows - what happens when autofiltered data (some rows hidden) is sorted (using usual sorting tool) - what happens when you try to filter the autofilter row out (if it's treated as data, not in MSO) + consider to ask the community in case of more than one good solutions (Heiko) + mimic the bevahior of Microsoft Excel if there isn't better (Ibrahim) + resolved in the bug (mostly comment #29) (Heiko) conclusion in: + https://bugs.documentfoundation.org/show_bug.cgi?id=63416#c29 + comparison of office suite behavior https://docs.google.com/document/d/1vW1orR4ZbXHDmQDpbJVH4N2f1w_iYP6GtDLYgJ4pWSk/edit + comment from moggi from IRC just a tip for the future (I'm not involved it in anymore): before you try to specify some calc behavior it might be a good idea to talk to the calc maintainers, calc has a few concepts that go through the whole program which might not be obvious to everyone * Icon Updates / Issues (Jay) + some icons have white instead of black on Windows (Jay) + bugreport: https://bugs.documentfoundation.org/show_bug.cgi?id=91432 + Tango (Alex/Adolfo/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1OErlXIDDGM7V1mOGW8oSCLuhqw5fulT1XhkTik1u2UY/edit?usp=sharing + Sifr (Papamatti/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/15ZpVaTxg7TAFYhOyQUP3mp-cVtKA1vP5uZAT38t-taA/edit?usp=sharing + Breeze (Andreas/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1dpMFgmkQy4BsyRIKH97ZLPTU6NdvXIYk3Yossj6sSQM/edit?usp=sharing + More icons were pushed by Andreas (Jay) + Extra-Large (32x32) Icons for large resolutions + Status -
[Libreoffice-commits] translations.git: Branch 'libreoffice-5-0' - source/sl
source/sl/extras/source/autocorr/emoji.po | 9322 ++ source/sl/officecfg/registry/data/org/openoffice/Office/UI.po | 13 source/sl/sd/source/ui/app.po | 26 source/sl/sd/uiconfig/simpress/ui.po | 51 source/sl/sfx2/uiconfig/ui.po | 10 source/sl/svtools/source/misc.po | 15 source/sl/svx/inc.po |4 source/sl/svx/source/tbxctrls.po | 16 8 files changed, 9377 insertions(+), 80 deletions(-) New commits: commit 3eedeaa4db0f95c2df2c00d2b149affaeb50e1df Author: Andras Timar andras.ti...@collabora.com Date: Thu Jun 4 19:54:03 2015 +0200 Updated Slovenian translation Change-Id: I8b2f1d37e65945873499ac8ba3029fb0b09af8e2 diff --git a/source/sl/extras/source/autocorr/emoji.po b/source/sl/extras/source/autocorr/emoji.po new file mode 100644 index 000..d1a9bc4 --- /dev/null +++ b/source/sl/extras/source/autocorr/emoji.po @@ -0,0 +1,9322 @@ +#. extracted from extras/source/autocorr/emoji +msgid +msgstr +Project-Id-Version: LibreOffice 5.0\n +Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOfficebug_status=UNCONFIRMEDcomponent=UI\n; +POT-Creation-Date: 2015-06-04 13:43+0200\n +PO-Revision-Date: 2015-06-04 18:29+0200\n +Last-Translator: Martin Srebotnjak mi...@filmsi.net\n +Language-Team: sl.libreoffice.org\n +Language: sl\n +MIME-Version: 1.0\n +Content-Type: text/plain; charset=UTF-8\n +Content-Transfer-Encoding: 8bit\n +Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n +X-Generator: Virtaal 0.7.1\n +X-Accelerator-Marker: ~\n +X-Poedit-SourceCharset: UTF-8\n +X-Project-Style: openoffice\n + +#: emoji.ulf +msgctxt +emoji.ulf\n +CENT_SIGN\n +LngText.text +msgid cent +msgstr cent + +#: emoji.ulf +msgctxt +emoji.ulf\n +POUND_SIGN\n +LngText.text +msgid pound +msgstr funt + +#: emoji.ulf +msgctxt +emoji.ulf\n +YEN_SIGN\n +LngText.text +msgid yen +msgstr jen + +#: emoji.ulf +msgctxt +emoji.ulf\n +SECTION_SIGN\n +LngText.text +msgid section +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +COPYRIGHT_SIGN\n +LngText.text +msgid copyright +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +NOT_SIGN\n +LngText.text +msgid not +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +REGISTERED_SIGN\n +LngText.text +msgid registered +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +DEGREE_SIGN\n +LngText.text +msgid degree +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +PLUS-MINUS_SIGN\n +LngText.text +msgid +- +msgstr +- + +#: emoji.ulf +msgctxt +emoji.ulf\n +MIDDLE_DOT\n +LngText.text +msgid middle dot +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +MULTIPLICATION_SIGN\n +LngText.text +msgid x +msgstr x + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_ALPHA\n +LngText.text +msgid Alpha +msgstr Alfa + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_BETA\n +LngText.text +msgid Beta +msgstr Beta + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_GAMMA\n +LngText.text +msgid Gamma +msgstr Gama + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_DELTA\n +LngText.text +msgid Delta +msgstr Delta + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_EPSILON\n +LngText.text +msgid Epsilon +msgstr Epsilon + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_ZETA\n +LngText.text +msgid Zeta +msgstr Zeta + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_ETA\n +LngText.text +msgid Eta +msgstr Eta + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_THETA\n +LngText.text +msgid Theta +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_IOTA\n +LngText.text +msgid Iota +msgstr Jota + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_KAPPA\n +LngText.text +msgid Kappa +msgstr Kapa + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_LAMDA\n +LngText.text +msgid Lambda +msgstr Lambda + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_MU\n +LngText.text +msgid Mu +msgstr Mu + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_NU\n +LngText.text +msgid Nu +msgstr Nu + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_XI\n +LngText.text +msgid Xi +msgstr + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_OMICRON\n +LngText.text +msgid Omicron +msgstr Omikron + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_PI\n +LngText.text +msgid Pi +msgstr Pi + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_RHO\n +LngText.text +msgid Rho +msgstr Ro + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_SIGMA\n +LngText.text +msgid Sigma +msgstr Sigma + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_TAU\n +LngText.text +msgid Tau +msgstr Tau + +#: emoji.ulf +msgctxt +emoji.ulf\n +GREEK_CAPITAL_LETTER_UPSILON\n +LngText.text +msgid Upsilon
[Libreoffice-bugs] [Bug 91705] LibreOffice Navigator should be editable in the Navigator window
https://bugs.documentfoundation.org/show_bug.cgi?id=91705 --- Comment #1 from Susan Cragin susancra...@earthlink.net --- Created attachment 116288 -- https://bugs.documentfoundation.org/attachment.cgi?id=116288action=edit Screenshot of a typical long document with a complete outline. Notice that this is an outline, not just chapter numbers or headings which are quite different. I don't need to see where my headings are, I need to understand my overall story arc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 72bd4796b29cab3e818289af520beca1ae100ede Author: Andras Timar andras.ti...@collabora.com Date: Thu Jun 4 19:54:03 2015 +0200 Updated core Project: translations 3eedeaa4db0f95c2df2c00d2b149affaeb50e1df Updated Slovenian translation Change-Id: I8b2f1d37e65945873499ac8ba3029fb0b09af8e2 diff --git a/translations b/translations index fd8a1ee..3eedeaa 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit fd8a1ee1c02bf02a0d116b6922b8bb00bc508846 +Subproject commit 3eedeaa4db0f95c2df2c00d2b149affaeb50e1df ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91699] Navigator does not have word wrap capability for the headings
https://bugs.documentfoundation.org/show_bug.cgi?id=91699 Susan Cragin susancra...@earthlink.net changed: What|Removed |Added Component|LibreOffice |Writer --- Comment #4 from Susan Cragin susancra...@earthlink.net --- Hi, Cor. So here are my three bugs. Sorry for my earlier sloppiness. Bug 91699 (this one) is about Writer Navigator word wrap. Bug 91858 is about Writer Navigator -- controlling the buttons at the top. Bug 91705 is about Writer Navigator being editable in the Navigator window. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91855] CRASH when Special Character opened
https://bugs.documentfoundation.org/show_bug.cgi?id=91855 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Summary|CRASH when Special Charcter |CRASH when Special |opened |Character opened -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91189] Impossible to import Access 2007/2010 Databases
https://bugs.documentfoundation.org/show_bug.cgi?id=91189 --- Comment #7 from MM plokk...@fastmail.fm --- Well no-one said anything about the error on display. Only that there was a problem when Access opened the same file as LO at the same time, and that LO couldn't write to that file. Or did I misunderstood that ?! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91801] Calculations in tables with variables would cut off part of the calculation upon print
https://bugs.documentfoundation.org/show_bug.cgi?id=91801 mchan...@shaw.ca changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- Ever confirmed|0 |1 --- Comment #4 from mchan...@shaw.ca --- That makes no sense - why would they have to be inserted if the values are already stored? It's a completely arbitrary and unintuitive extra step. Changing to REOPENED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90563] LibreOffice Calc crashes when attempting to format page
https://bugs.documentfoundation.org/show_bug.cgi?id=90563 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Caolán McNamara caol...@redhat.com --- *** This bug has been marked as a duplicate of bug 90435 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84972] Font rendering in Charts issue on OSX
https://bugs.documentfoundation.org/show_bug.cgi?id=84972 Andras Timar tima...@gmail.com changed: What|Removed |Added CC||pell...@gmail.com, ||tima...@gmail.com Whiteboard|bibisectRequest |NotBibisectable --- Comment #8 from Andras Timar tima...@gmail.com --- I did not find the wrong commit neither in Bibisect_MacOSX10.6+_lo-4.2_to_lo-4.3.tar.bz2 nor in bibisect-macosx-64-5.0.tar. So probably it occurred between 4.3 and 4.4 and was backported to release branch. There is no bibisect repo for that range. I CC you, Pierre-Eric, because a commit of yours is related. commit 162f11cdb94b415ff9d58674e94fb01a745a69eb Author: Pierre-Eric Pelloux-Prayer pell...@gmail.com Date: Thu Mar 12 22:37:54 2015 +0100 vcl/text: fix duplicate text in fontwork tdf#81876 On the screenshots we see duplicated labels, one is written with the desired font, the other is written with a narrow font. After your patch unfortunately the normal font is gone, and only the narrow one is displayed. But when the rotation is set back to 0, the font changes back to normal. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/core/fields/expfld.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit b36afd1ecd098723e3119cba81e172396bf30f45
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jun 4 21:00:13 2015 +0100
Resolves: tdf#91637 avoid -1 string index
Change-Id: I006040f4589065141310fe2a89b8d2ba3e54ad2c
(cherry picked from commit 4e96b278965875a95f02993590f30ab5859c1fed)
Reviewed-on: https://gerrit.libreoffice.org/16089
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/core/fields/expfld.cxx b/sw/source/core/fields/expfld.cxx
index 3100363..2fcdc42 100644
--- a/sw/source/core/fields/expfld.cxx
+++ b/sw/source/core/fields/expfld.cxx
@@ -739,8 +739,11 @@ bool SwSeqFldList::SeekEntry( const _SeqFldLstElem rNew,
size_t* pP ) const
sal_Int32 nNum1 = sNum1.toInt32();
nCmp = nNum2 - nNum1;
if( 0 == nCmp )
-nCmp = rCaseColl.compareString( rTmp2.copy( nFndPos2 ),
-rTmp1.copy( nFndPos1 ));
+{
+OUString aTmp1 = nFndPos1 != -1 ? rTmp1.copy(nFndPos1) :
OUString();
+OUString aTmp2 = nFndPos2 != -1 ? rTmp2.copy(nFndPos2) :
OUString();
+nCmp = rCaseColl.compareString(aTmp2, aTmp1);
+}
}
else
nCmp = rColl.compareString( rTmp2, rTmp1 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] minutes of ESC call ...
* Present: + Sophie, Norbert, Stephan, Eike, Miklos, Robinson, Kendy, Noel, Bjoern, Jacobo, Muthu, Jay, Andras, Michael M, Caolan * Completed Action Items: + kick-off a set of who wants what test infrastructure thread (Michael) + poke 2x certification candidates (Stephan) [ working through mailing list setup with Italo waiting responses ] + chasing un-translated 4.4 string (Sophie) [ a commit with hard-coded string, made translatable later but not back-ported due to the freeze = should break the rule back-port it's an important string in the UI. Please back-port commit: commit bf6a14e0ba4eb2a47da0146379ec905089ab3a6c ] + add ooenv MALLOC_CHECK etc. to script wrapper for tinderboxes (Norbert) [ Would (by now) only improve the build tooling - axe it ] * Pending Action Items: + find some developer/sysadmin'y type people to train in CI maintenance (Cloph/Norbert) [ had a chat after the call with Cloph - started this; ongoing ] + move problem writer tests from check - subsequentcheck for sw.all (Michael S) + encourage QA guys to test mork / thunderbird bits on Win64 (Robinson) [ encouraged people to build there; have only 1x tinderbox that can make builds but isn't. In the process of buying bare-metal Win64 infra boxes (Norbert) + pending delivery etc. couple of weeks ? + spec. decided on - and in TDF procurement Who runs the Win64 tinderbox ? (Michael) AI:+ Thorsten - can we get builds up-loaded (?) ] * Release Engineering update (Robinson) + 5.0.0 - Beta 2 + going to tag shortly, and get builds out soon. + Status ? (Norbert) + need Cloph's help to trigger builds (Robinson) + good to ping Bjoern/Rene/Norbert when tagging (Norbert) + build/sign machines have v. limited access (Norbert) + Late Feature Status (Michael) + LibreOfficeKit / Online tweaks (Kendy) + mostly fixes this week etc. + OpenGL / double-buffer RenderContext (Kendy) + similar - lots of fixes, some other bits for review in gerrit + gtk3+ theming, embedded video, cut/paste (Caolan) + no concerns. + toolbar search / wrap-around (Kendy) [ got its reviews went in ] + text wrapping for chart labels (Marco) [ punted to 5.1 - remove] + orcus with gnumeric import (Markus) [ build issues - will not push to 5.0 ... - remove. ] + Win64 + pending more QA work. + 4.4.4 RC2 status + freeze next week / last fixes ? + Android iOS Remote * Menu changes / help documentation handling (Jay / Sophie) + Interface / communication concerns between Help Development (Sophie) + https://bugs.documentfoundation.org/show_bug.cgi?id=91781 + How do we tell docs team wrt. change ? (Norbert) + docs team don't work on help files (Sophie) + dev. team thinks docs team is working on it they are unable to edit the help are under-resourced + talked wrt. what is technically necessary to edit help files (Kendy) + Pushing in changes to re-org the menu bar (Jay) + changes would affect docs as well as help. + how to approach that ? + editing the help XML files - easier than changing menu XML descriptions (Miklos) + documentation more problematic than help (Jay) + not reasonable to ask dev to fix documentation screenshots (Norbert) + important to fix the limbo problem between dev docs + Changes made will affect people too (Jay) + good to do that in 5.0 (Kendy) + hoping to get them in there, completing toolbars / context menus (Jay) + completed the menu-bars for writer, calc, impress, draw + reviewing the changes currently (Sophie) + don't want to loose functionality. + Wiki Help makes it easy familiar to change the help (Kendy) + grow the community of those able to lead improvements in the help. + technically barrier to entry stops those who have good writing skills but perhaps less technical / manual-XML editing familiarity. + not there yet unfortunately. + no easy path for editable 5.0 + what is the mechanism for notifying docs generally ? (Norbert) + an issue and a wiki-page about this (Sophie) + Currently a wiki page with 4.4 and 4.5 UI / string changes (Jay) + https://wiki.documentfoundation.org/Documentation/RecentStringChanges AI: + link it from the developer pages (Sophie) + ideally we'd automatically generate screenshots for docs
minutes of ESC call ...
* Present: + Sophie, Norbert, Stephan, Eike, Miklos, Robinson, Kendy, Noel, Bjoern, Jacobo, Muthu, Jay, Andras, Michael M, Caolan * Completed Action Items: + kick-off a set of who wants what test infrastructure thread (Michael) + poke 2x certification candidates (Stephan) [ working through mailing list setup with Italo waiting responses ] + chasing un-translated 4.4 string (Sophie) [ a commit with hard-coded string, made translatable later but not back-ported due to the freeze = should break the rule back-port it's an important string in the UI. Please back-port commit: commit bf6a14e0ba4eb2a47da0146379ec905089ab3a6c ] + add ooenv MALLOC_CHECK etc. to script wrapper for tinderboxes (Norbert) [ Would (by now) only improve the build tooling - axe it ] * Pending Action Items: + find some developer/sysadmin'y type people to train in CI maintenance (Cloph/Norbert) [ had a chat after the call with Cloph - started this; ongoing ] + move problem writer tests from check - subsequentcheck for sw.all (Michael S) + encourage QA guys to test mork / thunderbird bits on Win64 (Robinson) [ encouraged people to build there; have only 1x tinderbox that can make builds but isn't. In the process of buying bare-metal Win64 infra boxes (Norbert) + pending delivery etc. couple of weeks ? + spec. decided on - and in TDF procurement Who runs the Win64 tinderbox ? (Michael) AI:+ Thorsten - can we get builds up-loaded (?) ] * Release Engineering update (Robinson) + 5.0.0 - Beta 2 + going to tag shortly, and get builds out soon. + Status ? (Norbert) + need Cloph's help to trigger builds (Robinson) + good to ping Bjoern/Rene/Norbert when tagging (Norbert) + build/sign machines have v. limited access (Norbert) + Late Feature Status (Michael) + LibreOfficeKit / Online tweaks (Kendy) + mostly fixes this week etc. + OpenGL / double-buffer RenderContext (Kendy) + similar - lots of fixes, some other bits for review in gerrit + gtk3+ theming, embedded video, cut/paste (Caolan) + no concerns. + toolbar search / wrap-around (Kendy) [ got its reviews went in ] + text wrapping for chart labels (Marco) [ punted to 5.1 - remove] + orcus with gnumeric import (Markus) [ build issues - will not push to 5.0 ... - remove. ] + Win64 + pending more QA work. + 4.4.4 RC2 status + freeze next week / last fixes ? + Android iOS Remote * Menu changes / help documentation handling (Jay / Sophie) + Interface / communication concerns between Help Development (Sophie) + https://bugs.documentfoundation.org/show_bug.cgi?id=91781 + How do we tell docs team wrt. change ? (Norbert) + docs team don't work on help files (Sophie) + dev. team thinks docs team is working on it they are unable to edit the help are under-resourced + talked wrt. what is technically necessary to edit help files (Kendy) + Pushing in changes to re-org the menu bar (Jay) + changes would affect docs as well as help. + how to approach that ? + editing the help XML files - easier than changing menu XML descriptions (Miklos) + documentation more problematic than help (Jay) + not reasonable to ask dev to fix documentation screenshots (Norbert) + important to fix the limbo problem between dev docs + Changes made will affect people too (Jay) + good to do that in 5.0 (Kendy) + hoping to get them in there, completing toolbars / context menus (Jay) + completed the menu-bars for writer, calc, impress, draw + reviewing the changes currently (Sophie) + don't want to loose functionality. + Wiki Help makes it easy familiar to change the help (Kendy) + grow the community of those able to lead improvements in the help. + technically barrier to entry stops those who have good writing skills but perhaps less technical / manual-XML editing familiarity. + not there yet unfortunately. + no easy path for editable 5.0 + what is the mechanism for notifying docs generally ? (Norbert) + an issue and a wiki-page about this (Sophie) + Currently a wiki page with 4.4 and 4.5 UI / string changes (Jay) + https://wiki.documentfoundation.org/Documentation/RecentStringChanges AI: + link it from the developer pages (Sophie) + ideally we'd automatically generate screenshots for docs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/anyrefdg.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit cd17c9f96ae2ba52a07178c1b59c6efc090b45ed
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Jun 4 18:06:17 2015 +0200
Don't downcast this to derived in base ctor
Change-Id: I1a0a6a7f0ac2292a7824bd35967140a20ee93f89
diff --git a/sc/source/ui/inc/anyrefdg.hxx b/sc/source/ui/inc/anyrefdg.hxx
index cb7a087..bb6dd5b 100644
--- a/sc/source/ui/inc/anyrefdg.hxx
+++ b/sc/source/ui/inc/anyrefdg.hxx
@@ -258,19 +258,19 @@ struct ScRefHdlrImpl: ScRefHdlrImplBase TBase, bBindRef
ScRefHdlrImpl( const T1 rt1, const T2 rt2, const T3 rt3, const T4
rt4 )
: ScRefHdlrImplBaseTBase, bBindRef (rt1, rt2, rt3, rt4)
{
-SC_MOD()-RegisterRefWindow( static_castsal_uInt16(
static_castTDerived*(this)-SLOTID ), this );
+SC_MOD()-RegisterRefWindow( static_castsal_uInt16( TDerived::SLOTID
), this );
}
templateclass T1, class T2, class T3, class T4, class T5
ScRefHdlrImpl( const T1 rt1, const T2 rt2, const T3 rt3, const T4
rt4, const T5 rt5 )
: ScRefHdlrImplBaseTBase, bBindRef (rt1, rt2, rt3, rt4, rt5)
{
-SC_MOD()-RegisterRefWindow( static_castsal_uInt16(
static_castTDerived*(this)-SLOTID ), this );
+SC_MOD()-RegisterRefWindow( static_castsal_uInt16( TDerived::SLOTID
), this );
}
virtual void dispose() SAL_OVERRIDE
{
-SC_MOD()-UnregisterRefWindow( static_castsal_uInt16(
static_castTDerived*(this)-SLOTID ), this );
+SC_MOD()-UnregisterRefWindow( static_castsal_uInt16(
TDerived::SLOTID ), this );
ScRefHdlrImplBaseTBase, bBindRef ::disposeRefHandler();
TBase::dispose();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: test infrastructure ideas appreciated ...
Hi Robert, On Wed, 2015-06-03 at 15:44 +0200, Robert Antoni Buj i Gelonch wrote: We could add an automatic validation test for checking the discovery of dynamic library dependencies on OS X Linux. * OS X: otool -L file * Linux: ldd file Sounds interesting - the concern would be having added new dependencies ? or what could we check with that ? Thanks, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91425] CRASH - Calc Insert Columns Left
https://bugs.documentfoundation.org/show_bug.cgi?id=91425 Timur gti...@gmail.com changed: What|Removed |Added OS|Mac OS X (All) |All --- Comment #15 from Timur gti...@gmail.com --- Was also reproduced in Windows. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table4.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a977937927729eaff61bd670fdd45d3508b19371 Author: Mike Kaganski mikekagan...@hotmail.com Date: Fri Jun 5 00:10:24 2015 +1000 tdf#90996: don't overwrite comments in ScTable::FillFormulaVertical IDF_CONTENTS includes IDF_NOTE, which should not be used here Change-Id: I904fbdbfcb97865a5682d9073e0ce2d5a2c694fb Reviewed-on: https://gerrit.libreoffice.org/16085 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx index 46025f9..be1bc8f 100644 --- a/sc/source/core/data/table4.cxx +++ b/sc/source/core/data/table4.cxx @@ -1170,7 +1170,7 @@ void ScTable::FillFormulaVertical( if (aSpans.empty()) return; -aCol[nCol].DeleteRanges(aSpans, IDF_CONTENTS, false); +aCol[nCol].DeleteRanges(aSpans, IDF_VALUE | IDF_DATETIME | IDF_STRING | IDF_FORMULA | IDF_OUTLINE, false); aCol[nCol].CloneFormulaCell(rSrcCell, sc::CellTextAttr(), aSpans, NULL); boost::shared_ptrsc::ColumnBlockPositionSet pSet(new sc::ColumnBlockPositionSet(*pDocument)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - basctl/source basic/source chart2/source cui/source dbaccess/source editeng/source extensions/source sc/source sd/source sfx2/source svx/sour
basctl/source/basicide/baside2b.cxx |2 -
basctl/source/basicide/basides1.cxx |6 +--
basctl/source/basicide/basidesh.cxx |2 -
basic/source/runtime/basrdll.cxx |2 -
basic/source/runtime/iosys.cxx |5 +-
chart2/source/controller/dialogs/DataBrowser.cxx |8 ++--
chart2/source/controller/dialogs/tp_Scale.cxx|2 -
chart2/source/controller/main/ChartController_Window.cxx |2 -
cui/source/customize/cfg.cxx |9 ++---
cui/source/dialogs/multipat.cxx |4 +-
cui/source/options/treeopt.cxx |2 -
cui/source/tabpages/page.cxx |2 -
dbaccess/source/ui/dlg/ConnectionHelper.cxx |2 -
dbaccess/source/ui/misc/UITools.cxx |2 -
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx| 12 +++---
dbaccess/source/ui/querydesign/querycontroller.cxx |2 -
dbaccess/source/ui/relationdesign/RelationController.cxx |2 -
editeng/source/editeng/editdbg.cxx |2 -
editeng/source/editeng/editeng.cxx |2 -
editeng/source/misc/unolingu.cxx |2 -
extensions/source/propctrlr/propcontroller.cxx |2 -
sc/source/ui/dbgui/consdlg.cxx |2 -
sc/source/ui/dbgui/scendlg.cxx |4 +-
sc/source/ui/docshell/dbdocfun.cxx |4 +-
sc/source/ui/docshell/docfunc.cxx|8 ++--
sc/source/ui/miscdlgs/crnrdlg.cxx|4 +-
sc/source/ui/miscdlgs/scuiautofmt.cxx|2 -
sc/source/ui/navipi/scenwnd.cxx |2 -
sc/source/ui/optdlg/tpusrlst.cxx |6 +--
sc/source/ui/view/cellsh3.cxx|4 +-
sc/source/ui/view/dbfunc.cxx |4 +-
sc/source/ui/view/dbfunc3.cxx|4 +-
sc/source/ui/view/spelleng.cxx |4 +-
sc/source/ui/view/tabvwshf.cxx |4 +-
sc/source/ui/view/viewfunc.cxx |4 +-
sd/source/core/drawdoc3.cxx |2 -
sd/source/ui/dlg/custsdlg.cxx|4 +-
sd/source/ui/func/fudraw.cxx |2 -
sd/source/ui/view/drawview.cxx |5 +-
sd/source/ui/view/drviews2.cxx | 26 +++
sd/source/ui/view/drviews4.cxx |2 -
sd/source/ui/view/drviewse.cxx | 18 +-
sd/source/ui/view/sdview4.cxx|2 -
sfx2/source/appl/linkmgr2.cxx|2 -
sfx2/source/bastyp/fltfnc.cxx|4 +-
sfx2/source/dialog/securitypage.cxx |2 -
svx/source/svdraw/svdedtv1.cxx |2 -
svx/source/svdraw/svdedxv.cxx|2 -
svx/source/svdraw/svdpntv.cxx|2 -
sw/source/ui/misc/bookmark.cxx |2 -
sw/source/uibase/app/docsh.cxx |6 +--
sw/source/uibase/app/docsh2.cxx |2 -
sw/source/uibase/dochdl/gloshdl.cxx |2 -
sw/source/uibase/lingu/hyp.cxx |2 -
sw/source/uibase/uiview/viewling.cxx |4 +-
sw/source/uibase/uiview/viewprt.cxx |2 -
sw/source/uibase/uiview/viewsrch.cxx |2 -
sw/source/uibase/utlui/unotools.cxx |2 -
xmlsecurity/workben/signaturetest.cxx|2 -
59 files changed, 115 insertions(+), 116 deletions(-)
New commits:
commit 07074e0e072f33fe8954eded5cd2495822f5f0e4
Author: Michael Meeks michael.me...@collabora.com
Date: Thu May 28 21:35:43 2015 +0100
tdf#91702 - fix stack-based MessBox allocation.
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/basctl/source/basicide/baside2b.cxx
b/basctl/source/basicide/baside2b.cxx
index 68592f4..459449a 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -483,7 +483,7 @@ bool EditorWindow::ImpCanModify()
{
// If in Trace-mode, abort the trace or refuse input
// Remove markers in the modules in Notify at Basic::Stoped
-if ( QueryBox( 0, WB_OK_CANCEL,
IDEResId(RID_STR_WILLSTOPPRG).toString() ).Execute() ==
[Libreoffice-bugs] [Bug 91702] Assertion `mnRefCnt0' failed at include/vcl/outdev.hxx:342
https://bugs.documentfoundation.org/show_bug.cgi?id=91702 --- Comment #10 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07074e0e072f33fe8954eded5cd2495822f5f0e4h=libreoffice-5-0 tdf#91702 - fix stack-based MessBox allocation. It will be available in 5.0.0.0.beta2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91702] Assertion `mnRefCnt0' failed at include/vcl/outdev.hxx:342
https://bugs.documentfoundation.org/show_bug.cgi?id=91702 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 ||target:5.0.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 1 new defect(s) introduced to LibreOffice found with Coverity Scan. 84 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1304135: Control flow issues (MISSING_BREAK) /svx/source/sidebar/text/TextPropertyPanel.cxx: 162 in svx::sidebar::TextPropertyPanel::HandleContextChange(const sfx2::sidebar::EnumContext )() *** CID 1304135: Control flow issues (MISSING_BREAK) /svx/source/sidebar/text/TextPropertyPanel.cxx: 162 in svx::sidebar::TextPropertyPanel::HandleContextChange(const sfx2::sidebar::EnumContext )() 156 break; 157 158 case CombinedEnumContext(Application_Calc, Context_EditCell): 159 case CombinedEnumContext(Application_Calc, Context_DrawText): 160 bNeedTextSpacing = true; 161 CID 1304135: Control flow issues (MISSING_BREAK) The above case falls through to this one. 162 case CombinedEnumContext(Application_WriterVariants, Context_DrawText): 163 case CombinedEnumContext(Application_WriterVariants, Context_Annotation): 164 case CombinedEnumContext(Application_DrawImpress, Context_DrawText): 165 case CombinedEnumContext(Application_DrawImpress, Context_Text): 166 case CombinedEnumContext(Application_DrawImpress, Context_Table): 167 case CombinedEnumContext(Application_DrawImpress, Context_OutlineText): To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview To manage Coverity Scan email notifications for libreoffice@lists.freedesktop.org, click https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.orgtoken=d6481d718a775246b2340f282ebe5939 . ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: test infrastructure ideas appreciated ... - a11y based testing
On Thu, 2015-06-04 at 16:14 +0200, Noel Grandin wrote: mjayfrancis(IRC) is doing some interesting automated-UI testing work using the UNO accessibility API - perhaps get him on contract to finish it up and make it nice? Ah - it'd be great to use our UNO API directly, rather than via some wrapper - then it can be effortlessly cross-platform ... will split your ideas up - perhaps into threads ? Thanks =) Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/menubar/menubar.xml | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) New commits: commit 76a9afc9da110dbf3a00a628311a0b5d9aa6d2bc Author: Yousuf Philips philip...@hotmail.com Date: Thu Jun 4 02:03:31 2015 +0400 tdf#91781 Changes based on discussion of heiko suggestions Change-Id: I6d70e40c829e125205516d894e4fd1a36e7882fa Reviewed-on: https://gerrit.libreoffice.org/16067 Reviewed-by: Yousuf Philips philip...@hotmail.com Tested-by: Yousuf Philips philip...@hotmail.com diff --git a/sw/uiconfig/swriter/menubar/menubar.xml b/sw/uiconfig/swriter/menubar/menubar.xml index ed92ccb..cb50434 100644 --- a/sw/uiconfig/swriter/menubar/menubar.xml +++ b/sw/uiconfig/swriter/menubar/menubar.xml @@ -25,7 +25,6 @@ menu:menuitem menu:id=.uno:CloseDoc/ menu:menuseparator/ menu:menuitem menu:id=.uno:AutoPilotMenu/ - menu:menuseparator/ menu:menu menu:id=.uno:TemplateMenu menu:menupopup menu:menuitem menu:id=.uno:NewDoc/ @@ -33,6 +32,9 @@ /menu:menupopup /menu:menu menu:menuseparator/ + menu:menuitem menu:id=.uno:Reload/ + menu:menuitem menu:id=.uno:VersionDialog/ + menu:menuseparator/ menu:menuitem menu:id=.uno:Save/ menu:menuitem menu:id=.uno:SaveAs/ menu:menuitem menu:id=.uno:SaveACopy/ @@ -41,9 +43,6 @@ menu:menuitem menu:id=.uno:CancelCheckOut/ menu:menuitem menu:id=.uno:CheckIn/ menu:menuseparator/ - menu:menuitem menu:id=.uno:Reload/ - menu:menuitem menu:id=.uno:VersionDialog/ - menu:menuseparator/ menu:menuitem menu:id=.uno:ExportTo/ menu:menuitem menu:id=.uno:ExportToPDF/ menu:menu menu:id=.uno:SendToMenu @@ -86,14 +85,14 @@ menu:menuitem menu:id=.uno:Copy/ menu:menuitem menu:id=.uno:Paste/ menu:menuitem menu:id=.uno:PasteSpecial/ - menu:menuitem menu:id=.uno:SelectTextMode/ + menu:menuitem menu:id=.uno:SelectAll/ menu:menu menu:id=.uno:SelectionModeMenu menu:menupopup menu:menuitem menu:id=.uno:SelectionModeDefault menu:style=radio/ menu:menuitem menu:id=.uno:SelectionModeBlock menu:style=radio/ /menu:menupopup /menu:menu - menu:menuitem menu:id=.uno:SelectAll/ + menu:menuitem menu:id=.uno:SelectTextMode/ menu:menuseparator/ menu:menuitem menu:id=vnd.sun.star.findbar:FocusToFindbar/ menu:menuitem menu:id=.uno:SearchDialog/ @@ -145,6 +144,7 @@ menu:menuitem menu:id=.uno:Sidebar/ menu:menuitem menu:id=.uno:Gallery/ menu:menuitem menu:id=.uno:Navigator/ + menu:menuseparator/ menu:menuitem menu:id=.uno:ViewDataSourceBrowser/ menu:menuseparator/ menu:menuitem menu:id=.uno:FullScreen/ @@ -197,6 +197,7 @@ menu:menuitem menu:id=.uno:InsertObject/ menu:menuitem menu:id=.uno:InsertPlugin/ menu:menuitem menu:id=.uno:InsertObjectStarMath/ + menu:menuitem menu:id=.uno:InsertDoc/ /menu:menupopup /menu:menu menu:menu menu:id=.uno:InsertFrameMenu @@ -263,8 +264,6 @@ menu:menuseparator/ menu:menuitem menu:id=.uno:InsertSection/ menu:menuitem menu:id=.uno:InsertEnvelope/ - menu:menuseparator/ - menu:menuitem menu:id=.uno:InsertDoc/ /menu:menupopup /menu:menu menu:menu menu:id=.uno:FormatMenu @@ -537,7 +536,6 @@ menu:menuitem menu:id=.uno:InsertFormula/ menu:menuseparator/ menu:menuitem menu:id=.uno:TableNumberRecognition/ - menu:menuitem menu:id=.uno:TableBoundaries/ menu:menuseparator/ menu:menuitem menu:id=.uno:TableDialog/ /menu:menupopup ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/data/table4.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2519e0aca7c0d479f7ff381d95929dbe47942503 Author: Mike Kaganski mikekagan...@hotmail.com Date: Fri Jun 5 00:10:24 2015 +1000 tdf#90996: don't overwrite comments in ScTable::FillFormulaVertical IDF_CONTENTS includes IDF_NOTE, which should not be used here Change-Id: I904fbdbfcb97865a5682d9073e0ce2d5a2c694fb Reviewed-on: https://gerrit.libreoffice.org/16085 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx index c82469b..2a2c150 100644 --- a/sc/source/core/data/table4.cxx +++ b/sc/source/core/data/table4.cxx @@ -1170,7 +1170,7 @@ void ScTable::FillFormulaVertical( if (aSpans.empty()) return; -aCol[nCol].DeleteRanges(aSpans, IDF_CONTENTS, false); +aCol[nCol].DeleteRanges(aSpans, IDF_VALUE | IDF_DATETIME | IDF_STRING | IDF_FORMULA | IDF_OUTLINE, false); aCol[nCol].CloneFormulaCell(rSrcCell, sc::CellTextAttr(), aSpans, NULL); boost::shared_ptrsc::ColumnBlockPositionSet pSet(new sc::ColumnBlockPositionSet(*pDocument)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: sourceforge hijack libreoffice page?
On 03/06/15 12:14, Simos Xenitellis wrote: On Wed, Jun 3, 2015 at 12:58 PM, Sharuzzaman Ahmat Raslan sharuzza...@gmail.com mailto:sharuzza...@gmail.com wrote: Hi Libreoffice developers, I was reading news about Sourceforge is hijacking nmap page in Sourceforge. When I listed the page owned by user sf-editor1, it looks like LibreOffice page and installer was also hijacked. And Sourceforge staff actively add installation packages to the download page at http://sourceforge.net/projects/libreoffice.mirror/files/ There's an article on lwn about gimp being hi-jacked. My experience with downloading a package called Alcohol from its official site makes me very suspicious of all this ... :-( Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91860] Change of Ctrl-Shift-Right selection behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=91860 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||c...@nouenoff.nl Resolution|--- |WORKSFORME --- Comment #1 from Cor Nouws c...@nouenoff.nl --- (In reply to drm4567 from comment #0) This is a new behavior that mimics Microsoft Office and is very annoying and degrades usability. Please, remove it or make it optional. At your service ;) See ToolsOptionsCalc General .. Use legacy cursor movement when etc. (at bottom) regards, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91861] New: Black screen in Mission control after closing the window is maximized.
https://bugs.documentfoundation.org/show_bug.cgi?id=91861 Bug ID: 91861 Summary: Black screen in Mission control after closing the window is maximized. Product: LibreOffice Version: 4.4.3.2 rc Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: trp2...@inbox.ru If you open the window LO in full screen mode, and then shut down after CMD + W, then the Mission control is a black screen before the closure of the program (CMD + Q). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91860] Change of Ctrl-Shift-Right selection behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=91860 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #3 from Cor Nouws c...@nouenoff.nl --- Apologies! Way too fast :\ One of your complaints is handled in here https://bugs.documentfoundation.org/show_bug.cgi?id=89154 What older versions do you refer to? In LibreOffice 3.3.0 the selection _does_ include the space. Cheers, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90993] EDITING: Objects anchored to frame disappear when frame anchor is changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=90993 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Attachment #115238|0 |1 is obsolete|| --- Comment #7 from Gordo gordon1dr...@yahoo.com --- Created attachment 116285 -- https://bugs.documentfoundation.org/attachment.cgi?id=116285action=edit odt to doc, docx, and rtf test cases Test kit updated to include rtf. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91781] Reorganization of the menu bar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91781 --- Comment #38 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Yousuf Philips committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=76a9afc9da110dbf3a00a628311a0b5d9aa6d2bc tdf#91781 Changes based on discussion of heiko suggestions It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 85184] Meta: Track bugs in GSoC ’14 color drop-down
https://bugs.documentfoundation.org/show_bug.cgi?id=85184 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Depends on||91853 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91853] color picker is incorrect in RTL
https://bugs.documentfoundation.org/show_bug.cgi?id=91853 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Blocks||85184 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: test infrastructure ideas appreciated ... - layout tests ...
I'm no expert on the current state here, but my feeling is that there are a lot of document / chart layout issues that are a real problem to regression test. I imagine that funding an investigation of the best of breed of whatever we have, plus some combination of custom fonts, built-in-everything (including freetype, harfbuz), no system hyphenation data etc. etc. and basebmp rendering to ensure consistency across platforms ( so the widest default reach) -might- get us to a place that people can routinely run (at least on Linux) some layout tests (?) - assuming we can find some way to reasonably describe workable and maintainable constraints for that. Thoughts much appreciated ;-) Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: extensions/source
extensions/source/abpilot/datasourcehandling.cxx |6 ++ 1 file changed, 6 insertions(+) New commits: commit 3705cf82121667674b582e9317d972b1ac9d57f4 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu Jun 4 17:48:27 2015 +0200 abpilot: refer embedded data source from doc settings So that even if the address book data source wizard creates the embedded data source, next time the document is loaded, we can find it. Change-Id: Ibb11fa119fb27976437e54bed1d590cfd9863236 diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx index f3d6268..0115775 100644 --- a/extensions/source/abpilot/datasourcehandling.cxx +++ b/extensions/source/abpilot/datasourcehandling.cxx @@ -406,6 +406,12 @@ namespace abp }); xStorable-storeAsURL(sTmpName, aSequence); m_pImpl-sName = sTmpName; + +// Refer to the sub-storage name in the document settings, so +// we can load it again next time the file is imported. +uno::Referencelang::XMultiServiceFactory xFactory(pObjectShell-GetModel(), uno::UNO_QUERY); +uno::Referencebeans::XPropertySet xPropertySet(xFactory-createInstance(com.sun.star.document.Settings), uno::UNO_QUERY); +xPropertySet-setPropertyValue(EmbeddedDatabaseName, uno::makeAny(aStreamRelPath)); } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91860] Change of Ctrl-Shift-Right selection behavior
https://bugs.documentfoundation.org/show_bug.cgi?id=91860 drm4...@mail.ru changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- Ever confirmed|0 |1 --- Comment #2 from drm4...@mail.ru --- (In reply to Cor Nouws from comment #1) (In reply to drm4567 from comment #0) This is a new behavior that mimics Microsoft Office and is very annoying and degrades usability. Please, remove it or make it optional. At your service ;) See ToolsOptionsCalc General .. Use legacy cursor movement when etc. (at bottom) regards, Cor 1) Look at the component section. It's Writer, not Calc! 2) I do not have Calc after ToolsOptions in my version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91529] Splash screen does not show up
https://bugs.documentfoundation.org/show_bug.cgi?id=91529 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #6 from steve -_- st...@openmailbox.org --- verified as of comment #5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/paint.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 177f8e8bbdc2a554f3f795e4e766c2e184410f81
Author: László Németh laszlo.nem...@collabora.com
Date: Thu Jun 4 18:01:55 2015 +0200
fix rendercontext rendering of standard toolbar icons
Change-Id: I6e0399c16d3e900fbca56fc757f342ea893d0ad4
diff --git a/vcl/source/window/paint.cxx b/vcl/source/window/paint.cxx
index ccd2029..ad7fb72 100644
--- a/vcl/source/window/paint.cxx
+++ b/vcl/source/window/paint.cxx
@@ -177,7 +177,7 @@ void PaintHelper::DoPaint(const vcl::Region* pRegion)
{
WindowImpl* pWindowImpl = m_pWindow-ImplGetWindowImpl();
vcl::Region* pWinChildClipRegion = m_pWindow-ImplGetWinChildClipRegion();
-if (pWindowImpl-mnPaintFlags IMPL_PAINT_PAINTALL)
+if (pWindowImpl-mnPaintFlags IMPL_PAINT_PAINTALL || m_pBuffer)
{
pWindowImpl-maInvalidateRegion = *pWinChildClipRegion;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91508] Sidebar: remove the closing button
https://bugs.documentfoundation.org/show_bug.cgi?id=91508 --- Comment #11 from Adolfo Jayme f...@libreoffice.org --- (In reply to V Stuart Foote from comment #10) IMO the new modal action of Tab buttons on the SideBar's TabBar to open or close the Deck duplicate the X close button of the Deck. It can and should be removed. @Adolpho? I agree that it could be removed, but then you need to consider that there are cases in which duplication is not bad (which isn’t per se…). If Sidebar’s close button is to be removed, then we need to make it obvious for all users that they can still collapse the Sidebar by toggling one of the tab buttons in the rightmost area. And that isn’t really obvious, because those buttons do not look like toggles. In the end I have the same feeling as Jay: the current close button will be missed by many if removed altogether without working on fixing the visual issues that currently block understanding of the toggling functionality. Just my 2 ¢ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91260] DOCX frames can extend beyond the page bottom, but not in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91260 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- László Németh committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2f779fc046c9afec04b4a4500b213e77aee51ae1 tdf#91260: cleanup - textboxes extending beyond the page It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91260] DOCX frames can extend beyond the page bottom, but not in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91260 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.0.0 | target:5.0.0 target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/objectpositioning/anchoredobjectposition.cxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit 2f779fc046c9afec04b4a4500b213e77aee51ae1
Author: László Németh laszlo.nem...@collabora.com
Date: Thu Jun 4 18:15:12 2015 +0200
tdf#91260: cleanup - textboxes extending beyond the page
Storing Undo data is unnecessary here, because shrinking is applied
only on the text frame of the textbox. The shape component of the
textbox isn't modified.
Change-Id: Iaff64ff4953adbfa830832da146343cef2734547
diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
index 2957aa0..b4e63e3 100644
--- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
@@ -482,13 +482,10 @@ SwTwips SwAnchoredObjectPosition::_ImplAdjustVertRelPos(
const SwTwips nTopOfAnc
{
// shrink textboxes to extend beyond the page bottom
SwFrameFormat* pFrameFormat = ::FindFrameFormat(GetObject());
-SfxItemSet aTextBoxSet(pFrameFormat-GetDoc()-GetAttrPool(),
aFrameFormatSetRange);
SwFormatFrmSize aSize(pFormat-GetFrmSize());
SwTwips nShrinked = aSize.GetHeight() - (nProposedRelPosY -
nAdjustedRelPosY);
aSize.SetHeight( nShrinked 0 ? nShrinked : 0 );
-aTextBoxSet.Put(aSize);
-if (aTextBoxSet.Count())
-pFrameFormat-GetDoc()-SetFlyFrmAttr(*pFrameFormat,
aTextBoxSet);
+pFrameFormat-SetFormatAttr(aSize);
nAdjustedRelPosY = nProposedRelPosY;
} else if ( SwTextBoxHelper::findTextBox(pFormat) )
// when the shape has a textbox, use only the proposed
vertical position
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: test infrastructure ideas appreciated ... - junit ...
On Thu, 2015-06-04 at 16:14 +0200, Noel Grandin wrote: Perhaps a contract to convert the Java unit tests to C++? Might be interesting - I wonder if that can be partially automated in some way ;- At a minimum for JUnit it'd be good to further accelerate the tests by processing the idle messages instead of sleeping I guess. =) Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: test infrastructure ideas appreciated ... - Help / Doc screenshots ...
This was mostly a Norbert idea from the ESC call :-) * Find some way to automate the creation of (translated) screenshots for help and documentation + this can be used to keep the help up-to-date + and also to test significant dialog open/close with it + and to add more screenshots (cheaply) to the documentation * Ideally would include some way of highlighting / annotating certain bits of the UI, and intelligently cropping too. I imagine it would need some form of annotation / markup / RDF magic on images in documentation to allow those to be re-built easily. =) Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 3 commits - include/svtools svtools/source svtools/uiconfig
include/svtools/RemoteFilesDialog.hxx| 33 +++-
svtools/source/dialogs/RemoteFilesDialog.cxx | 217 ++-
svtools/uiconfig/ui/remotefilesdialog.ui | 73 -
3 files changed, 310 insertions(+), 13 deletions(-)
New commits:
commit e7359daa22f58bac005cb3d455fd4acd5353bd01
Author: Szymon KÅos eszka...@gmail.com
Date: Thu Jun 4 18:58:11 2015 +0200
empty TreeListBox splitter
Change-Id: I948b62bade41b7b7998d0e22c10c1169d78ec506
diff --git a/include/svtools/RemoteFilesDialog.hxx
b/include/svtools/RemoteFilesDialog.hxx
index 0ae497f..aac99ba 100644
--- a/include/svtools/RemoteFilesDialog.hxx
+++ b/include/svtools/RemoteFilesDialog.hxx
@@ -19,6 +19,8 @@
#include vcl/lstbox.hxx
#include vcl/dialog.hxx
#include vcl/vclptr.hxx
+#include vcl/split.hxx
+#include vcl/svapp.hxx
#include svtools/fileview.hxx
#include svtools/treelistentry.hxx
@@ -51,7 +53,7 @@ class SVT_DLLPUBLIC RemoteFilesDialog : public ModalDialog
{
public:
RemoteFilesDialog(vcl::Window* pParent, WinBits nBits);
-~RemoteFilesDialog();
+virtual ~RemoteFilesDialog();
virtual void dispose() SAL_OVERRIDE;
virtual void Resize() SAL_OVERRIDE;
@@ -70,6 +72,8 @@ private:
VclPtrMenuButton m_pAddService_btn;
VclPtrListBox m_pServices_lb;
VclPtrEdit m_pPath_ed;
+VclPtrSplitter m_pSplitter;
+VclPtrSvTreeListBox m_pTreeView;
VclPtrSvtFileView m_pFileView;
VclPtrFileViewContainer m_pContainer;
VclPtrListBox m_pFilter_lb;
@@ -92,6 +96,8 @@ private:
DECL_LINK( DoubleClickHdl, void * );
DECL_LINK( SelectHdl, void * );
+
+DECL_LINK( SplitHdl, void * );
};
#endif // INCLUDED_SVTOOLS_REMOTEFILESDIALOG_HXX
diff --git a/svtools/source/dialogs/RemoteFilesDialog.cxx
b/svtools/source/dialogs/RemoteFilesDialog.cxx
index f13aa2d..5976ea6 100644
--- a/svtools/source/dialogs/RemoteFilesDialog.cxx
+++ b/svtools/source/dialogs/RemoteFilesDialog.cxx
@@ -17,11 +17,15 @@ class FileViewContainer : public vcl::Window
{
private:
VclPtrSvtFileView m_pFileView;
+VclPtrSvTreeListBox m_pTreeView;
+VclPtrSplitter m_pSplitter;
public:
FileViewContainer(vcl::Window *pParent)
: Window(pParent)
, m_pFileView(NULL)
+, m_pTreeView(NULL)
+, m_pSplitter(NULL)
{
}
@@ -33,29 +37,51 @@ class FileViewContainer : public vcl::Window
virtual void dispose() SAL_OVERRIDE
{
m_pFileView.clear();
+m_pSplitter.clear();
vcl::Window::dispose();
}
-void init(SvtFileView* pFileView)
+void init(SvtFileView* pFileView,
+ Splitter* pSplitter,
+ SvTreeListBox* pTreeView)
{
m_pFileView = pFileView;
+m_pTreeView = pTreeView;
+m_pSplitter = pSplitter;
}
virtual void Resize() SAL_OVERRIDE
{
Window::Resize();
-if(!m_pFileView)
+if(!m_pFileView || !m_pTreeView)
return;
Size aSize = GetSizePixel();
-m_pFileView-SetSizePixel( aSize );
+Point aPos( m_pFileView-GetPosPixel() );
+Size aNewSize(aSize.Width() - aPos.X(), aSize.Height());
+
+m_pFileView-SetSizePixel( aNewSize );
+
+// Resize the Splitter to fit the height
+Size splitterNewSize = m_pSplitter-GetSizePixel( );
+splitterNewSize.Height() = aSize.Height();
+m_pSplitter-SetSizePixel( splitterNewSize );
+sal_Int32 nMinX = m_pTreeView-GetPosPixel( ).X( );
+sal_Int32 nMaxX = m_pFileView-GetPosPixel( ).X( ) +
m_pFileView-GetSizePixel( ).Width() - nMinX;
+m_pSplitter-SetDragRectPixel( Rectangle( Point( nMinX, 0 ), Size(
nMaxX, aSize.Width() ) ) );
+
+// Resize the tree list box to fit the height of the FileView
+Size placesNewSize(m_pTreeView-GetSizePixel());
+placesNewSize.Height() = aSize.Height();
+m_pTreeView-SetSizePixel( placesNewSize );
}
};
RemoteFilesDialog::RemoteFilesDialog(vcl::Window* pParent, WinBits nBits)
: ModalDialog(pParent, RemoteFilesDialog, svt/ui/remotefilesdialog.ui)
, m_context(comphelper::getProcessComponentContext())
+, m_pSplitter(NULL)
, m_pFileView(NULL)
, m_pContainer(NULL)
{
@@ -98,7 +124,24 @@ RemoteFilesDialog::RemoteFilesDialog(vcl::Window* pParent,
WinBits nBits)
m_pFileView-SetDoubleClickHdl( LINK( this, RemoteFilesDialog,
DoubleClickHdl ) );
m_pFileView-SetSelectHdl( LINK( this, RemoteFilesDialog, SelectHdl ) );
-m_pContainer-init(m_pFileView);
+m_pSplitter = VclPtrSplitter::Create( m_pContainer, WB_HSCROLL );
+m_pSplitter-SetBackground( Wallpaper(
Application::GetSettings().GetStyleSettings().GetFaceColor() ));
+m_pSplitter-SetSplitHdl( LINK( this, RemoteFilesDialog, SplitHdl ) );
+m_pSplitter-Show();
+
+m_pTreeView = VclPtrSvTreeListBox::Create( m_pContainer, WB_BORDER );
+Size aSize(100, 200);
+
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accfrmobj.cxx | 12
1 file changed, 8 insertions(+), 4 deletions(-)
New commits:
commit 4bf829ba2a4e02188b41064759d17eaf57f22dfe
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jun 4 16:20:18 2015 +0100
GetWin seen as NULL sometimes
Change-Id: I08974e3a8a3f34e2c1f0843c536e72ca0eb4b29d
diff --git a/sw/source/core/access/accfrmobj.cxx
b/sw/source/core/access/accfrmobj.cxx
index ce9d3d8..a1bd0bf 100644
--- a/sw/source/core/access/accfrmobj.cxx
+++ b/sw/source/core/access/accfrmobj.cxx
@@ -262,10 +262,14 @@ SwRect SwAccessibleChild::GetBox( const SwAccessibleMap
rAccMap ) const
}
else if ( mpWindow )
{
-aBox = SwRect( rAccMap.GetShell()-GetWin()-PixelToLogic(
-Rectangle( mpWindow-GetPosPixel(),
- mpWindow-GetSizePixel() )
) );
-}
+vcl::Window *pWin = rAccMap.GetShell()-GetWin();
+if (pWin)
+{
+aBox = SwRect( pWin-PixelToLogic(
+Rectangle( mpWindow-GetPosPixel(),
+
mpWindow-GetSizePixel() ) ) );
+}
+}
return aBox;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91215] LibO 4.4 - cropping tool regressions in draw/impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91215 --- Comment #2 from sergio.calleg...@gmail.com --- Part 1 of the is now fixed in 4.4.4.1.0 Part 2 did not exist from start. I just could not find the Format-Crop Image dialogue for some reason. I apologize for the noise. Can be closed for me. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa
sw/qa/extras/rtfimport/rtfimport.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 123dc8f836afd108ea69804546116f17438a7861
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Jun 3 19:20:02 2015 +0200
sw: fix Win-x86@51-TDF build
I forgot that the paste() method in this suite is not available on
Windows on 4-4, just on 5-0 and newer.
Change-Id: I6b625c2c5af34e8c7d7a66dd138ce860fdf18a24
Reviewed-on: https://gerrit.libreoffice.org/16064
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx
b/sw/qa/extras/rtfimport/rtfimport.cxx
index bfa13c5..66f04e7 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -2274,20 +2274,24 @@ DECLARE_RTFIMPORT_TEST(testTdf91074, tdf91074.rtf)
DECLARE_RTFIMPORT_TEST(testTdf90260Nopar, hello.rtf)
{
+#if !defined WNT
uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
uno::Referencetext::XTextRange xText(xTextDocument-getText(),
uno::UNO_QUERY);
uno::Referencetext::XTextRange xEnd = xText-getEnd();
paste(tdf90260-nopar.rtf, xEnd);
CPPUNIT_ASSERT_EQUAL(1, getParagraphs());
+#endif
}
DECLARE_RTFIMPORT_TEST(testTdf90260Par, hello.rtf)
{
+#if !defined WNT
uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
uno::Referencetext::XTextRange xText(xTextDocument-getText(),
uno::UNO_QUERY);
uno::Referencetext::XTextRange xEnd = xText-getEnd();
paste(tdf90260-par.rtf, xEnd);
CPPUNIT_ASSERT_EQUAL(2, getParagraphs());
+#endif
}
DECLARE_RTFIMPORT_TEST(testTdf86814, tdf86814.rtf)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 91781] Reorganization of the menu bar for Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91781 --- Comment #39 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to V Stuart Foote from comment #37) Currently on the View menu the Layout actions--Print Layout, Web Layout, and HTML Source (when editing an LO .html document)--are all _editing_ modes. Placement there suggests that Print Preview is also an editing mode. It is not and so might not belong as placed. Considering them to be editing modes isnt correct because if you are in print or web layout and deactivate editing (Edit Edit Mode), then you are only viewing the document in the particular layout. But if the preview actually reflected how document would be rendered, responding to the currently specified printer settings I can see the argument for that--or as Heiko suggests better in a Previews grouping on the View menu. Status quo, as a Preview of an action to Print it is an _output_. Those actions currently all reside on the File menu, where grouping with the Print and Printer Settings would remain logical. Where, besides the cluster of Print actions, the other Export _output_ buttons are located. Along with the Preview in Web Browser that could logically be repositioned on the View menu as Heiko suggests. Spoke with Heiko yesterday about 'Preview in Web Browser' and it behaves similar to exporting the document as an html and opening the file in a browser, or taken another way - Send to Web Browser, which isnt a way of viewing a document inside of LO, like you can with HTML Source. As a sidebar--this incremental process of UI/UX transition will simply take time to sort through. It won't really affect the 5.0 release. But these major UI changes should have been done prior to that major milestone, they instead will affect 5.1 or even a 6.0--IMO for issues of the UI we really should have remained at 4.x and have a 4.5 incremental pending, calling it a 5.0 release is premature but guess that is moot. We definitely need more folks working actively at this--reviewing the daily builds, commenting on, and committing appropriate changes. It would have been nice to have focused on improving the menu bar earlier but i had to clean up the context menus first to gather many of the missing commands found in the context menus that werent in the menu bar. The ESC has okayed pushing this into 5.0 as its a major release and of course it can be polished during the 5.x cycle. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91215] LibO 4.4 - cropping tool regressions in draw/impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91215 Timur gti...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
