[Libreoffice-commits] core.git: include/basegfx sax/inc shell/inc shell/source stoc/source
include/basegfx/color/bcolor.hxx | 31 -- include/basegfx/matrix/b2dhommatrixtools.hxx |1 include/basegfx/pixel/bpixel.hxx |5 - include/basegfx/range/b1drange.hxx| 22 include/basegfx/range/b2ibox.hxx | 57 include/basegfx/range/b2irange.hxx| 50 -- include/basegfx/range/b3drange.hxx| 65 -- include/basegfx/tuple/b2i64tuple.hxx | 14 --- include/basegfx/tuple/b3ituple.hxx| 18 --- include/basegfx/vector/b3dvector.hxx | 26 - sax/inc/xml2utf.hxx |4 shell/inc/internal/i_xml_parser_event_handler.hxx |7 - shell/source/unix/sysshell/recently_used_file_handler.cxx |7 - stoc/source/corereflection/base.hxx |6 - stoc/source/javavm/javavm.hxx |3 15 files changed, 316 deletions(-) New commits: commit 3b32c5898ff4e744d3f18b00421b433500426d74 Author: Noel Grandin n...@peralex.com Date: Thu Jul 2 14:21:30 2015 +0200 loplugin:unusedmethods sax,shell,stoc,basegfx Change-Id: Ia5d63f7153e4b02acc5e206739316264d6d1184e diff --git a/include/basegfx/color/bcolor.hxx b/include/basegfx/color/bcolor.hxx index 2bdd420..4358e05 100644 --- a/include/basegfx/color/bcolor.hxx +++ b/include/basegfx/color/bcolor.hxx @@ -131,15 +131,6 @@ namespace basegfx return *this; } -// blend to another color using luminance -void blend(const BColor rColor) -{ -const double fLuminance(luminance()); -mfX = rColor.getRed() * fLuminance; -mfY = rColor.getGreen() * fLuminance; -mfZ = rColor.getBlue() * fLuminance; -} - // luminance double luminance() const { @@ -164,16 +155,6 @@ namespace basegfx return sqrt(fDistR * fDistR + fDistG * fDistG + fDistB * fDistB); } -double getMinimumDistance(const BColor rColor) const -{ -const double fDistR(getDistanceRed(rColor)); -const double fDistG(getDistanceGreen(rColor)); -const double fDistB(getDistanceBlue(rColor)); - -double fRetval(fDistR fDistG ? fDistR : fDistG); -return (fRetval fDistB ? fRetval : fDistB); -} - double getMaximumDistance(const BColor rColor) const { const double fDistR(getDistanceRed(rColor)); @@ -206,18 +187,6 @@ namespace basegfx return static_castconst BColor( ::basegfx::B3DTuple::getEmptyTuple() ); } -com::sun::star::uno::Sequence double colorToDoubleSequence(const com::sun::star::uno::Reference com::sun::star::rendering::XGraphicDevice /*xGraphicDevice*/) const -{ -com::sun::star::uno::Sequence double aRet(4); -double* pRet = aRet.getArray(); - -pRet[0] = mfX; -pRet[1] = mfY; -pRet[2] = mfZ; -pRet[3] = 1.0; - -return aRet; -} }; } // end of namespace basegfx diff --git a/include/basegfx/matrix/b2dhommatrixtools.hxx b/include/basegfx/matrix/b2dhommatrixtools.hxx index b2aef89..41a17ec 100644 --- a/include/basegfx/matrix/b2dhommatrixtools.hxx +++ b/include/basegfx/matrix/b2dhommatrixtools.hxx @@ -218,7 +218,6 @@ namespace basegfx const B2DVector getScale() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return maScale; } const B2DVector getTranslate() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return maTranslate; } double getRotate() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return mfRotate; } -double getShearX() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return mfShearX; } }; } // end of namespace tools diff --git a/include/basegfx/pixel/bpixel.hxx b/include/basegfx/pixel/bpixel.hxx index cf5c7a3..fda6a79 100644 --- a/include/basegfx/pixel/bpixel.hxx +++ b/include/basegfx/pixel/bpixel.hxx @@ -95,21 +95,16 @@ namespace basegfx sal_uInt8 getGreen() const { return maPixelUnion.maRGBO.mnG; } sal_uInt8 getBlue() const { return maPixelUnion.maRGBO.mnB; } sal_uInt8 getOpacity() const { return maPixelUnion.maRGBO.mnO; } -sal_uInt32 getRedGreenBlueOpacity() const { return maPixelUnion.maCombinedRGBO.mnValue; } // data access write void setRed(sal_uInt8 nNew) { maPixelUnion.maRGBO.mnR = nNew; } void setGreen(sal_uInt8 nNew) { maPixelUnion.maRGBO.mnG = nNew; } void setBlue(sal_uInt8 nNew) { maPixelUnion.maRGBO.mnB = nNew; } void
[Libreoffice-bugs] [Bug 92516] x accelerator and mouse click not exiting StartCenter in File - Exit LibreOfficeDev menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92516 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to tommy27 from comment #1) I think the main reason is that all menu accelerator do not work in the start screen (maybe a focus problem) try hitting f or t or h and you'll see that the File, Tools and Help menus won't open No, believe movement of focus to the Main menu bar out of the SC has always required an Alt+F, Alt+T, Alt+H because they are formally short cuts and not just accelerators. And then there are the F10 and F6 focus movements, which are not affected. But once focus is moved onto the Main menu bar, the f, t or h as accelerators correctly switch between top level menus. That seems correct. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92137] Diagram/undo: Box resize undoes wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=92137 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92500] DOCX created by LibO not opened by other word processing software
https://bugs.documentfoundation.org/show_bug.cgi?id=92500 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #4 from Beluga todven...@suomi24.fi --- (In reply to Jonathan Camilleri from comment #0) Created attachment 116999 [details] attachment MSO 2013 opens it fine. Even the header image is displayed intact, while in LibO, it has a white rectangle going over it! As MSO displays it better than LibO, I'm tempted to set this as NOTOURBUG. The software these other people are using is apparently not MSO and is thus evidently lacking in the interoperability department. I'll set to NEEDINFO, while we wait for the software information. Win 8.1 32-bit MSO 2013 Version: 5.0.0.2 Build ID: a26d58f11b99b6aeddf7f7884effea188cc6e512 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91776] Start Center R accelerator conflict between Recent Files and Draw Drawing (english UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=91776 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||gautier.sop...@gmail.com --- Comment #13 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to tommy27 from comment #12) another consideration is that there can be different accelerator conflicts according to the UI language. Yes, and another facet to using the module names would be that those aren't translated in the UI--so those accelerators would be stable. Less impact on l10n/i18n @Sophi, true? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: 8 commits - include/registry registry/Executable_regview.mk registry/inc registry/Library_reg.mk registry/source registry/tools
include/registry/reflread.hxx | 286 -- include/registry/reflwrit.hxx | 221 include/registry/registry.h| 440 - registry/Executable_regview.mk |5 registry/Library_reg.mk|5 registry/inc/regapi.hxx| 432 registry/source/keyimpl.hxx|2 registry/source/reflread.cxx | 199 ++ registry/source/reflread.hxx | 119 +++ registry/source/reflwrit.cxx | 144 +++-- registry/source/reflwrit.hxx | 107 + registry/source/regimpl.cxx|4 registry/source/regimpl.hxx|2 registry/source/registry.cxx |8 registry/source/regkey.cxx |2 registry/tools/regview.cxx |2 16 files changed, 786 insertions(+), 1192 deletions(-) New commits: commit bded4ddd6da0de2c465b28a51d773720338542c3 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 3 11:22:38 2015 +0200 Make RegistryTypeWriter non-copyable (and note the operator == vs. = typo) Change-Id: I9c25149967ed9b80f5e8f014de0dfee2e8f485d8 diff --git a/registry/source/reflwrit.cxx b/registry/source/reflwrit.cxx index 288beb9..689bc2d 100644 --- a/registry/source/reflwrit.cxx +++ b/registry/source/reflwrit.cxx @@ -1165,14 +1165,6 @@ void TypeWriter::createBlop() extern C { -static void TYPEREG_CALLTYPE acquire(TypeWriterImpl hEntry) -{ -TypeWriter* pEntry = static_castTypeWriter*(hEntry); - -if (pEntry != NULL) -pEntry-m_refCount++; -} - static void TYPEREG_CALLTYPE release(TypeWriterImpl hEntry) { TypeWriter* pEntry = static_castTypeWriter*(hEntry); @@ -1374,29 +1366,11 @@ RegistryTypeWriter::RegistryTypeWriter(RTTypeClass RTTypeClass, referenceCount); } -RegistryTypeWriter::RegistryTypeWriter(const RegistryTypeWriter toCopy) -: m_hImpl(toCopy.m_hImpl) -{ -acquire(m_hImpl); -} - RegistryTypeWriter::~RegistryTypeWriter() { release(m_hImpl); } -RegistryTypeWriter RegistryTypeWriter::operator == (const RegistryTypeWriter toAssign) -{ -if (m_hImpl != toAssign.m_hImpl) -{ -release(m_hImpl); -m_hImpl = toAssign.m_hImpl; -acquire(m_hImpl); -} - -return *this; -} - void RegistryTypeWriter::setFieldData( sal_uInt16 index, const rtl::OUStringname, const rtl::OUStringtypeName, diff --git a/registry/source/reflwrit.hxx b/registry/source/reflwrit.hxx index 9bb8475..dcf2eec 100644 --- a/registry/source/reflwrit.hxx +++ b/registry/source/reflwrit.hxx @@ -58,18 +58,12 @@ public: sal_uInt16methodCount, sal_uInt16referenceCount); -/// Copy constructcor -RegistryTypeWriter(const RegistryTypeWriter toCopy); - /** Destructor. The Destructor frees the internal data block. The pointer (returned by getBlop) will be set to NULL. */ ~RegistryTypeWriter(); -/// Assign operator -RegistryTypeWriter operator == (const RegistryTypeWriter toAssign); - /** sets the data for a field member of a type blob. @param index indicates the index of the field. @@ -100,7 +94,9 @@ public: */ sal_uInt32 getBlopSize(); -protected: +private: +RegistryTypeWriter(RegistryTypeWriter ) = delete; +void operator =(RegistryTypeWriter) = delete; /// stores the handle of an implementation class TypeWriterImpl m_hImpl; commit 79429448052d4b69cc235000b74f3f8d6fa5a74c Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 3 11:19:50 2015 +0200 Remove RegistryTypeWriter_Api indirection Change-Id: I313adfb72272a631299efb3d2464873853a126be diff --git a/registry/source/reflwrit.cxx b/registry/source/reflwrit.cxx index c8ec720..288beb9 100644 --- a/registry/source/reflwrit.cxx +++ b/registry/source/reflwrit.cxx @@ -1356,26 +1356,66 @@ static TypeWriterImpl TYPEREG_CALLTYPE createEntry( return t; } -RegistryTypeWriter_Api* TYPEREG_CALLTYPE initRegistryTypeWriter_Api() +} + +RegistryTypeWriter::RegistryTypeWriter(RTTypeClass RTTypeClass, + const rtl::OUStringtypeName, + const rtl::OUString superTypeName, + sal_uInt16 fieldCount, + sal_uInt16 methodCount, + sal_uInt16 referenceCount) +: m_hImpl(NULL) { -static RegistryTypeWriter_Api aApi= {0,0,0,0,0,0}; -if (!aApi.acquire) -{ -aApi.createEntry= createEntry; -
[Libreoffice-ux-advise] [Bug 89095] Start centre: bigger thumbnails for templates
https://bugs.documentfoundation.org/show_bug.cgi?id=89095 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org| Component|ux-advise |UI Whiteboard||needsDevEval topicUI -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 89095] Start centre: bigger thumbnails for templates
https://bugs.documentfoundation.org/show_bug.cgi?id=89095 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org| Component|ux-advise |UI Whiteboard||needsDevEval topicUI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/LOOLSession.cpp
loolwsd/LOOLSession.cpp | 76 +++- 1 file changed, 43 insertions(+), 33 deletions(-) New commits: commit d788fa92e993e6d5131bd0730c631828a37829de Author: Henry Castro hcas...@collabora.com Date: Fri Jul 3 10:01:47 2015 -0400 loolwsd: let libreoffice handle http protocol diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp index df0a698..f66dbbe 100644 --- a/loolwsd/LOOLSession.cpp +++ b/loolwsd/LOOLSession.cpp @@ -597,46 +597,49 @@ void MasterProcessSession::dispatchChild() std::cout Util::logPrefix() _availableChildSessions size= _availableChildSessions.size() std::endl; lock.unlock(); -assert(jailDocumentURL[0] == '/'); -Path copy(getJailPath(childSession-_childId), jailDocumentURL.substr(1)); -Application::instance().logger().information(Util::logPrefix() + Copying + _docURL + to + copy.toString()); - -URIStreamOpener opener; -opener.registerStreamFactory(http, new HTTPStreamFactory()); -try +if (_docURL.find(http:)) { -std::istream *input = opener.open(_docURL); -std::ofstream output(copy.toString()); -if (!output) +assert(jailDocumentURL[0] == '/'); +Path copy(getJailPath(childSession-_childId), jailDocumentURL.substr(1)); +Application::instance().logger().information(Util::logPrefix() + Copying + _docURL + to + copy.toString()); + +URIStreamOpener opener; +opener.registerStreamFactory(http, new HTTPStreamFactory()); +try { -Application::instance().logger().error(Util::logPrefix() + Could not open + copy.toString() + for writing); -sendTextFrame(error: cmd=load kind=internal); +std::istream *input = opener.open(_docURL); +std::ofstream output(copy.toString()); +if (!output) +{ +Application::instance().logger().error(Util::logPrefix() + Could not open + copy.toString() + for writing); +sendTextFrame(error: cmd=load kind=internal); + +// We did not use the child session after all +// FIXME: Why do we do the same thing both here and then when we catch the IOException that we throw, a dozen line below? +lock.lock(); +_availableChildSessions.insert(childSession); +std::cout Util::logPrefix() _availableChildSessions size= _availableChildSessions.size() std::endl; +lock.unlock(); +throw IOException(copy.toString()); +} +StreamCopier::copyStream(*input, output); +output.close(); -// We did not use the child session after all -// FIXME: Why do we do the same thing both here and then when we catch the IOException that we throw, a dozen line below? +Application::instance().logger().information(Util::logPrefix() + Copying done); +} +catch (IOException exc) +{ +Application::instance().logger().error(Util::logPrefix() + Copying failed: + exc.message()); +sendTextFrame(error: cmd=load kind=failed); + +// FIXME: See above FIXME lock.lock(); _availableChildSessions.insert(childSession); std::cout Util::logPrefix() _availableChildSessions size= _availableChildSessions.size() std::endl; lock.unlock(); -throw IOException(copy.toString()); -} -StreamCopier::copyStream(*input, output); -output.close(); - -Application::instance().logger().information(Util::logPrefix() + Copying done); -} -catch (IOException exc) -{ -Application::instance().logger().error(Util::logPrefix() + Copying failed: + exc.message()); -sendTextFrame(error: cmd=load kind=failed); - -// FIXME: See above FIXME -lock.lock(); -_availableChildSessions.insert(childSession); -std::cout Util::logPrefix() _availableChildSessions size= _availableChildSessions.size() std::endl; -lock.unlock(); -throw; +throw; +} } _peer = childSession; @@ -851,7 +854,14 @@ bool ChildProcessSession::loadDocument(const char *buffer, int length, StringTok if (LIBREOFFICEKIT_HAS(_loKit, registerCallback)) _loKit-pClass-registerCallback(_loKit, myCallback, this); -if ((_loKitDocument = _loKit-pClass-documentLoad(_loKit, jailDocumentURL.c_str())) == NULL) +std::string sURL; + +if ( _docURL.find(http:) ) +sURL = _docURL; +else +sURL = jailDocumentURL; + +if ((_loKitDocument = _loKit-pClass-documentLoad(_loKit, sURL.c_str())) == NULL) { sendTextFrame(error: cmd=load kind=failed); return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 92375] Impress looses cropped image ratio on saving and re-opening in different LO versions.
https://bugs.documentfoundation.org/show_bug.cgi?id=92375 --- Comment #14 from Pascal Hingamp pascal.hing...@gmail.com --- (In reply to Beluga from comment #12) (In reply to skiani from comment #11) Total show stopper. Image crop confusion and lost images are killer. Makes a complete embarrassing mess in front of the crowd, no excuse, should have been fixed long ago. Can you reproduce the problem with attachment 116864 [details]? The attached document 116864 opens and renders slide 2 two correctly in LO Version: 4.4.2.2 Build ID: 40m0(Build:2). For the same test on my second PC, I will do that when I'm home later tonight in reach of the laptop. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91660] Encoding problem with grammar suggestions in GTK KDE4 themes
https://bugs.documentfoundation.org/show_bug.cgi?id=91660 Arnaud LE CAM a...@lecam-conseil.com changed: What|Removed |Added Version|5.0.0.0.beta1 |5.1.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sdext/source
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx | 12 1 file changed, 8 insertions(+), 4 deletions(-) New commits: commit 4ca9473d824fe37c2a63d48917cbaee79f5811e1 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jul 1 09:20:18 2015 +0200 Work around const-ness issues in the GooString API cf. https://gerrit.libreoffice.org/#/c/16357 Revert the removal of cast to build on old poppler Change-Id: I75184cec64b4f32e0cf9adedeb84c8591be4fc73 (cherry picked from commit b51ba9e383243e8248d6da1b71a5b06d841d165b) Reviewed-on: https://gerrit.libreoffice.org/16643 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx index f4fa810..b5dd4e4 100644 --- a/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx +++ b/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx @@ -103,13 +103,13 @@ namespace pdfi isUnderline(rSrc.isUnderline), size(rSrc.size) { -familyName.append(const_castGooString*(rSrc.familyName)); +familyName.append(rSrc.getFamilyName()); } FontAttributes operator=( const FontAttributes rSrc ) { familyName.clear(); -familyName.append(const_castGooString*(rSrc.familyName)); +familyName.append(rSrc.getFamilyName()); isEmbedded = rSrc.isEmbedded; isBold = rSrc.isBold; @@ -122,8 +122,7 @@ namespace pdfi bool operator==(const FontAttributes rFont) const { -return familyName.cmp( -const_castGooString*(rFont.familyName))==0 +return getFamilyName().cmp(rFont.getFamilyName())==0 isEmbedded == rFont.isEmbedded isBold == rFont.isBold isItalic == rFont.isItalic @@ -137,6 +136,11 @@ namespace pdfi boolisItalic; boolisUnderline; double size; + +private: +// Work around const-ness issues in the GooString API: +GooString getFamilyName() const +{ return const_castGooString (familyName); } }; class PDFOutDev : public OutputDev ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svx sd/source svx/source
include/svx/svdpagv.hxx |5 sd/source/ui/func/fusel.cxx |9 --- sd/source/ui/func/futext.cxx |9 --- svx/source/svdraw/svdmrkv.cxx | 51 +++--- 4 files changed, 45 insertions(+), 29 deletions(-) New commits: commit abbe4f9d64073d77c4be93b7c89c03d0651bacef Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 3 15:53:00 2015 +0100 fix deselect of textbox on slides with images in underlying master The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx index 5369616..8bf305f 100644 --- a/include/svx/svdpagv.hxx +++ b/include/svx/svdpagv.hxx @@ -235,6 +235,11 @@ public: // Beim Gruppenobjekt muss wenigstens ein Member sichtbar sein, // gesperrt sein darf keiner. bool IsObjMarkable(SdrObject* pObj) const; +// hmm, selectable is surely the same as markable, now that I +// see this as I look for a place to put it. TO-DO, +// merge these +bool IsObjSelectable(SdrObject *pObj) const; + // Betreten (Editieren) einer Objektgruppe. Anschliessend liegen alle // Memberobjekte der Gruppe im direkten Zugriff. Alle anderen Objekte diff --git a/sd/source/ui/func/fusel.cxx b/sd/source/ui/func/fusel.cxx index dd63708..000ac60 100644 --- a/sd/source/ui/func/fusel.cxx +++ b/sd/source/ui/func/fusel.cxx @@ -684,9 +684,12 @@ bool FuSelection::MouseButtonUp(const MouseEvent rMEvt) **/ if (mpView-PickObj(aMDPos, mpView-getHitTolLog(), pObj, pPV, SdrSearchOptions::ALSOONMASTER | SdrSearchOptions::BEFOREMARK)) { -mpView-UnmarkAllObj(); -mpView-MarkObj(pObj,pPV,false,false); -return true; +if (pPV-IsObjSelectable(pObj)) +{ +mpView-UnmarkAllObj(); +mpView-MarkObj(pObj,pPV,false,false); +return true; +} } /** * Toggle between selection and rotation diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx index e308e2e..c3b4090 100644 --- a/sd/source/ui/func/futext.cxx +++ b/sd/source/ui/func/futext.cxx @@ -657,9 +657,12 @@ bool FuText::MouseButtonUp(const MouseEvent rMEvt) **/ if (mpView-PickObj(aMDPos, mpView-getHitTolLog(), pObj, pPV, SdrSearchOptions::ALSOONMASTER | SdrSearchOptions::BEFOREMARK)) { -mpView-UnmarkAllObj(); -mpView-MarkObj(pObj,pPV,false,false); -return bReturn; +if (pPV-IsObjSelectable(pObj)) +{ +mpView-UnmarkAllObj(); +mpView-MarkObj(pObj,pPV,false,false); +return bReturn; +} } } } diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx index f58f88b..d281507 100644 --- a/svx/source/svdraw/svdmrkv.cxx +++ b/svx/source/svdraw/svdmrkv.cxx @@ -1226,6 +1226,33 @@ void SdrMarkView::SetRef2(const Point rPt) } } +bool SdrPageView::IsObjSelectable(SdrObject *pObj) const +{ +SdrLayerID nLay=pObj-GetLayer(); +bool bRaus=!pObj-IsInserted(); // Obj deleted? +if (!pObj-Is3DObj()) { +bRaus=bRaus || pObj-GetPage()!=GetPage(); // Obj suddenly in different Page or Group +} +bRaus=bRaus || GetLockedLayers().IsSet(nLay) || // Layer locked? + !GetVisibleLayers().IsSet(nLay); // Layer invisible? + +if( !bRaus ) +bRaus = !pObj-IsVisible(); // invisible objects can not be selected + +if (!bRaus) { +// Grouped objects can now be selected. +// After EnterGroup the higher-level objects, +// have to be deselected, though. +const SdrObjList* pOOL=pObj-GetObjList(); +const SdrObjList* pVOL=GetObjList(); +while (pOOL!=NULL pOOL!=pVOL) { +pOOL=pOOL-GetUpList(); +} +bRaus=pOOL!=pVOL; +} +return !bRaus; +} + void SdrMarkView::CheckMarked() { for (size_t nm=GetMarkedObjectCount(); nm0;) { @@ -1233,29 +1260,7 @@ void SdrMarkView::CheckMarked() SdrMark* pM=GetSdrMarkByIndex(nm); SdrObject* pObj=pM-GetMarkedSdrObj(); SdrPageView* pPV=pM-GetPageView(); -SdrLayerID nLay=pObj-GetLayer(); -bool bRaus=!pObj-IsInserted(); // Obj
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - include/svx sd/source svx/source
include/svx/svdpagv.hxx |5 sd/source/ui/func/fusel.cxx |9 --- sd/source/ui/func/futext.cxx |9 --- svx/source/svdraw/svdmrkv.cxx | 51 +++--- 4 files changed, 45 insertions(+), 29 deletions(-) New commits: commit 4189530530320a82adc785a4426735423a1188c1 Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 3 15:53:00 2015 +0100 fix deselect of textbox on slides with images in underlying master The original work of tdf#55430 tries to select an object under another one on the second click, but these images are unselectable so this fails. Red Hat has a whole new shiny bunch of templates which have such images in their masters. Check if the object is selectable before continuing Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93 (cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef) diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx index 5369616..8bf305f 100644 --- a/include/svx/svdpagv.hxx +++ b/include/svx/svdpagv.hxx @@ -235,6 +235,11 @@ public: // Beim Gruppenobjekt muss wenigstens ein Member sichtbar sein, // gesperrt sein darf keiner. bool IsObjMarkable(SdrObject* pObj) const; +// hmm, selectable is surely the same as markable, now that I +// see this as I look for a place to put it. TO-DO, +// merge these +bool IsObjSelectable(SdrObject *pObj) const; + // Betreten (Editieren) einer Objektgruppe. Anschliessend liegen alle // Memberobjekte der Gruppe im direkten Zugriff. Alle anderen Objekte diff --git a/sd/source/ui/func/fusel.cxx b/sd/source/ui/func/fusel.cxx index 9c965f7..905ee88 100644 --- a/sd/source/ui/func/fusel.cxx +++ b/sd/source/ui/func/fusel.cxx @@ -684,9 +684,12 @@ bool FuSelection::MouseButtonUp(const MouseEvent rMEvt) **/ if (mpView-PickObj(aMDPos, mpView-getHitTolLog(), pObj, pPV, SdrSearchOptions::ALSOONMASTER | SdrSearchOptions::BEFOREMARK)) { -mpView-UnmarkAllObj(); -mpView-MarkObj(pObj,pPV,false,false); -return true; +if (pPV-IsObjSelectable(pObj)) +{ +mpView-UnmarkAllObj(); +mpView-MarkObj(pObj,pPV,false,false); +return true; +} } /** * Toggle between selection and rotation diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx index ac6fb71..b848762 100644 --- a/sd/source/ui/func/futext.cxx +++ b/sd/source/ui/func/futext.cxx @@ -656,9 +656,12 @@ bool FuText::MouseButtonUp(const MouseEvent rMEvt) **/ if (mpView-PickObj(aMDPos, mpView-getHitTolLog(), pObj, pPV, SdrSearchOptions::ALSOONMASTER | SdrSearchOptions::BEFOREMARK)) { -mpView-UnmarkAllObj(); -mpView-MarkObj(pObj,pPV,false,false); -return bReturn; +if (pPV-IsObjSelectable(pObj)) +{ +mpView-UnmarkAllObj(); +mpView-MarkObj(pObj,pPV,false,false); +return bReturn; +} } } } diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx index 808f432..0eaaced 100644 --- a/svx/source/svdraw/svdmrkv.cxx +++ b/svx/source/svdraw/svdmrkv.cxx @@ -1226,6 +1226,33 @@ void SdrMarkView::SetRef2(const Point rPt) } } +bool SdrPageView::IsObjSelectable(SdrObject *pObj) const +{ +SdrLayerID nLay=pObj-GetLayer(); +bool bRaus=!pObj-IsInserted(); // Obj deleted? +if (!pObj-Is3DObj()) { +bRaus=bRaus || pObj-GetPage()!=GetPage(); // Obj suddenly in different Page or Group +} +bRaus=bRaus || GetLockedLayers().IsSet(nLay) || // Layer locked? + !GetVisibleLayers().IsSet(nLay); // Layer invisible? + +if( !bRaus ) +bRaus = !pObj-IsVisible(); // invisible objects can not be selected + +if (!bRaus) { +// Grouped objects can now be selected. +// After EnterGroup the higher-level objects, +// have to be deselected, though. +const SdrObjList* pOOL=pObj-GetObjList(); +const SdrObjList* pVOL=GetObjList(); +while (pOOL!=NULL pOOL!=pVOL) { +pOOL=pOOL-GetUpList(); +} +bRaus=pOOL!=pVOL; +} +return !bRaus; +} + void SdrMarkView::CheckMarked() { for (size_t nm=GetMarkedObjectCount(); nm0;) { @@ -1233,29 +1260,7 @@ void SdrMarkView::CheckMarked() SdrMark* pM=GetSdrMarkByIndex(nm); SdrObject* pObj=pM-GetMarkedSdrObj(); SdrPageView* pPV=pM-GetPageView(); -
[Libreoffice-bugs] [Bug 92527] docx export: File with shape can not be opened in word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=92527 --- Comment #3 from ralf.kr...@bluewin.ch --- Created attachment 117032 -- https://bugs.documentfoundation.org/attachment.cgi?id=117032action=edit Exported docx file with LO5002 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91770] Crash on closing on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91770 --- Comment #12 from Michael Meeks michael.me...@collabora.com --- Installed the profile into my dev-build; I get: vcl/opengl/win/WinDeviceInfo.cxx:914: error parsing blacklist but that looks benign; and no crash on tools-options ... looked around a lot ... 'ok', file-exit and ... nothing. Then again it doesn't appear to exit terribly cleanly either; digging. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92527] docx export: File with shape can not be opened in word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=92527 --- Comment #1 from ralf.kr...@bluewin.ch --- Created attachment 117030 -- https://bugs.documentfoundation.org/attachment.cgi?id=117030action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92527] docx export: File with shape can not be opened in word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=92527 --- Comment #2 from ralf.kr...@bluewin.ch --- Created attachment 117031 -- https://bugs.documentfoundation.org/attachment.cgi?id=117031action=edit Original odt file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92500] DOCX created by LibO not opened by other word processing software
https://bugs.documentfoundation.org/show_bug.cgi?id=92500 --- Comment #6 from Beluga todven...@suomi24.fi --- (In reply to Jonathan Camilleri from comment #1) Europass CV information at https://europass.cedefop.europa.eu/pt/documents/curriculum-vitae, this is where I originally downloaded the template. I input some test data in Europass and downloaded all those formats. If I open the .odt file in LibO and save to .docx, I don't get the white rectangle over the header image. If I open the .doc file in LibO and save to .docx, I get the white rectangle over the header image. The white rectangle appears to be a highlight in the style for the paragraph. However, we don't know, what kind of engine Europass uses. Is it actual MSO tech? I guess I can make a new report for the .doc - .docx thing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92500] DOCX created by LibO not opened by other word processing software
https://bugs.documentfoundation.org/show_bug.cgi?id=92500 --- Comment #7 from Beluga todven...@suomi24.fi --- Bug 92524 added for the highlight issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/cursor.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 4cf3dd78870456f786d39e8946648550a655d9a3 Author: Tor Lillqvist t...@collabora.com Date: Fri Jul 3 16:37:21 2015 +0300 Revert Don't belive the 'draw direct' parameter when double-buffering it introduces other problems instead. This reverts commit 05806f4603476dd150af7770543fea749cc6d10c. diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx index e1119ae..b665be7 100644 --- a/vcl/source/window/cursor.cxx +++ b/vcl/source/window/cursor.cxx @@ -167,9 +167,6 @@ void vcl::Cursor::ImplDoShow( bool bDrawDirect, bool bRestore ) if ( pWindow ) { -if ( pWindow-SupportsDoubleBuffering() ) -bDrawDirect = false; - if ( !mpData ) { mpData = new ImplCursorData; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92360] CRASH after choosing Execute Macro
https://bugs.documentfoundation.org/show_bug.cgi?id=92360 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #6 from tommy27 ba...@quipo.it --- please download, upgrade, retest and give feedback. status - NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92525] docx export: Text orentation in shape not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=92525 --- Comment #3 from ralf.kr...@bluewin.ch --- Created attachment 117024 -- https://bugs.documentfoundation.org/attachment.cgi?id=117024action=edit Exported docx file with LO5002 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx
vcl/unx/kde4/KDE4FilePicker.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7fa28a17f658c2bd15a359a5153e77667b925a20 Author: Juergen Funk juergen.funk...@cib.de Date: Fri Jun 26 15:45:00 2015 +0200 tdf#92353 FileSave: Not confirmed for overwrite a file (unix) The setConfimOverwrite function must be set after setOperationMode function Change-Id: Id5ab54be502e9c96eba3d7ab600b5e06e241c8fd Reviewed-on: https://gerrit.libreoffice.org/16517 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Katarina Behrens katarina.behr...@cib.de Reviewed-on: https://gerrit.libreoffice.org/16649 Tested-by: Katarina Behrens katarina.behr...@cib.de diff --git a/vcl/unx/kde4/KDE4FilePicker.cxx b/vcl/unx/kde4/KDE4FilePicker.cxx index ac21f81..4615bd4 100644 --- a/vcl/unx/kde4/KDE4FilePicker.cxx +++ b/vcl/unx/kde4/KDE4FilePicker.cxx @@ -129,7 +129,6 @@ KDE4FilePicker::KDE4FilePicker( const uno::Referenceuno::XComponentContext ) #endif setMultiSelectionMode( false ); -_dialog-setConfirmOverwrite( true ); // XExecutableDialog functions connect( this, SIGNAL( setTitleSignal( const OUString ) ), @@ -737,6 +736,7 @@ void SAL_CALL KDE4FilePicker::initialize( const uno::Sequenceuno::Any args ) break; case KFileDialog::Saving: resId = STR_FPICKER_SAVE; +_dialog-setConfirmOverwrite( true ); break; default: break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/tango
icon-themes/tango/framework/res/recent-documents.png |binary 1 file changed New commits: commit 5bc343cc723f993ed112cf5c700e3f397527d671 Author: Adolfo Jayme Barrientos fit...@ubuntu.com Date: Fri Jul 3 09:53:29 2015 -0500 Start Center: Better icon for Recent Files Change-Id: I99a87da22d877bc1386552a8978b0bf5e8e7f51f diff --git a/icon-themes/tango/framework/res/recent-documents.png b/icon-themes/tango/framework/res/recent-documents.png index 93fddb8..eb7d222 100644 Binary files a/icon-themes/tango/framework/res/recent-documents.png and b/icon-themes/tango/framework/res/recent-documents.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: RTF support
Can someone please identify the following RTF Controls? \facpgsxn 162 \nextcset 249 \tql371 After the control, the number is the line in the *rtfkeywd.hxx* file I assume the category RTF Control means the controls are native to RTF, but I can not find them in the documentation Please advise. Thanks, Tracey I am running LibreOffice v3.6.7.2 on Windows2K -- View this message in context: http://nabble.documentfoundation.org/RTF-support-tp3114982p4153551.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91660] Encoding problem with grammar suggestions in GTK KDE4 themes
https://bugs.documentfoundation.org/show_bug.cgi?id=91660 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92392] EDITING + UI: Calc crash when hitting Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=92392 --- Comment #6 from Caolán McNamara caol...@redhat.com --- ScSimpleRefDlg dtor never called -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92500] DOCX created by LibO not opened by other word processing software
https://bugs.documentfoundation.org/show_bug.cgi?id=92500 Beluga todven...@suomi24.fi changed: What|Removed |Added Attachment #116999|application/zip |application/vnd.openxmlform mime type||ats-officedocument.wordproc ||essingml.document -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91660] Encoding problem with grammar suggestions in GTK KDE4 themes
https://bugs.documentfoundation.org/show_bug.cgi?id=91660 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #2 from Beluga todven...@suomi24.fi --- NEEDINFO, while we wait for steps. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92378] Warning messages when inserting a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=92378 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||er...@redhat.com, ||michael.me...@collabora.com ||, phil.j...@free.fr --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- CCing phil, meeks, eike. Are these console warning messges not a problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/TileLayer.js |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 6b52fe1436c20987729a04c1a5a026676c480503 Author: Mihai Varga mihai.va...@collabora.com Date: Fri Jul 3 16:53:20 2015 +0300 Set opacity to 1 when replacing a tile diff --git a/loleaflet/src/layer/tile/TileLayer.js b/loleaflet/src/layer/tile/TileLayer.js index d3a2419..b56bcef 100644 --- a/loleaflet/src/layer/tile/TileLayer.js +++ b/loleaflet/src/layer/tile/TileLayer.js @@ -420,9 +420,11 @@ L.TileLayer = L.GridLayer.extend({ var tile = this._tiles[key]; if (tile) { if (tile.el.src) { + // cancel the animFade if there's any + L.DomUtil.setOpacity(tile.el, 1); this._skipFadeAnimated = true; } - if (this._tiles[key]._invalidCount this._tiles[key]._invalidCount 0) { + if (this._tiles[key]._invalidCount 0) { this._tiles[key]._invalidCount -= 1; } tile.el.src = 'data:image/png;base64,' + window.btoa(strBytes); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92375] Impress looses cropped image ratio on saving and re-opening in different LO versions.
https://bugs.documentfoundation.org/show_bug.cgi?id=92375 ski...@alum.mit.edu changed: What|Removed |Added CC||ski...@alum.mit.edu --- Comment #11 from ski...@alum.mit.edu --- Total show stopper. Image crop confusion and lost images are killer. Makes a complete embarrassing mess in front of the crowd, no excuse, should have been fixed long ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/sifr
icon-themes/sifr/sw/res/doublepage_10x22.png |binary icon-themes/sifr/sw/res/emptypage_10x14.png |binary icon-themes/sifr/sw/res/twopages_10x24.png |binary 3 files changed New commits: commit c6483666232a231446190d5c256857db45c5e4cc Author: Matthias Freund matti...@secure.mailbox.org Date: Tue Jun 30 18:32:43 2015 +0200 tdf#92425 - Correct the inactive pageindicators The inactive pageindicators had the same grey like the active ones, I correct this and changed the dark grey into light grey. Change-Id: Iea810d466504ceb80750c45358a01f8b8d3c8b9e Reviewed-on: https://gerrit.libreoffice.org/16621 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Yousuf Philips philip...@hotmail.com diff --git a/icon-themes/sifr/sw/res/doublepage_10x22.png b/icon-themes/sifr/sw/res/doublepage_10x22.png index ccdf656..27630e3 100644 Binary files a/icon-themes/sifr/sw/res/doublepage_10x22.png and b/icon-themes/sifr/sw/res/doublepage_10x22.png differ diff --git a/icon-themes/sifr/sw/res/emptypage_10x14.png b/icon-themes/sifr/sw/res/emptypage_10x14.png index aae3865..3a781f3 100644 Binary files a/icon-themes/sifr/sw/res/emptypage_10x14.png and b/icon-themes/sifr/sw/res/emptypage_10x14.png differ diff --git a/icon-themes/sifr/sw/res/twopages_10x24.png b/icon-themes/sifr/sw/res/twopages_10x24.png index 9aa128e..c32ee06 100644 Binary files a/icon-themes/sifr/sw/res/twopages_10x24.png and b/icon-themes/sifr/sw/res/twopages_10x24.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91660] Encoding problem with grammar suggestions in GTK KDE4 themes
https://bugs.documentfoundation.org/show_bug.cgi?id=91660 Beluga todven...@suomi24.fi changed: What|Removed |Added Version|5.1.0.0.alpha0+ Master |5.0.0.0.beta1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92527] New: docx export: File with shape can not be opened in word 2010
https://bugs.documentfoundation.org/show_bug.cgi?id=92527 Bug ID: 92527 Summary: docx export: File with shape can not be opened in word 2010 Product: LibreOffice Version: 5.0.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ralf.kr...@bluewin.ch The export of attached file goes wrong: The File can not be opened in Winword 2010. Winword says: Wrong Parameter Position: Component: /word/document.xml, row: 2, column: 0 Cheers -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91776] Start Center R accelerator conflict between Recent Files and Draw Drawing
https://bugs.documentfoundation.org/show_bug.cgi?id=91776 --- Comment #11 from tommy27 ba...@quipo.it --- (In reply to V Stuart Foote from comment #9) Thoughts on Main menu Tools vs. SC Templates, which gets the T? Also Main Menu Help vs. SC Help, which gets the H? Defer to the Main Menu (so its consistent through all panels)... or make StartCenter sidebar buttons consistent? Seems the Main Menu should have precedence. as said before in comment 6 I'd give the T to the Tools menu and leave the e to Templates -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92137] Diagram/undo: Box resize undoes wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=92137 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91776] Start Center R accelerator conflict between Recent Files and Draw Drawing (english UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=91776 tommy27 ba...@quipo.it changed: What|Removed |Added Summary|Start Center R|Start Center R |accelerator conflict|accelerator conflict |between Recent Files and |between Recent Files and |Draw Drawing |Draw Drawing (english UI) --- Comment #12 from tommy27 ba...@quipo.it --- another consideration is that there can be different accelerator conflicts according to the UI language. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92137] Diagram/undo: Box resize undoes wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=92137 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92137] Diagram/undo: Box resize undoes wrongly
https://bugs.documentfoundation.org/show_bug.cgi?id=92137 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1256611054701a2bba20225fb654814eecbf559 Resolves: tdf#92137 drawing layer resize undo in writer fails... It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 sawakaze souichi...@gmail.com changed: What|Removed |Added Priority|medium |high Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91926] crashed when processing large data
https://bugs.documentfoundation.org/show_bug.cgi?id=91926 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to bayu swandana from comment #4) sorry my late answer, I didn't check my e-mail routinely. I filtered by : Data Filter Standard Filter insert filter criteria expand option tick copy result to choose other sheet click OK I need more detailed steps as I've never done this. Do I need to create a data range before I can choose the target for copy result? If yes, can you copy here the range definition? Do I need to create a filter condition? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91651] slideshow not possible
https://bugs.documentfoundation.org/show_bug.cgi?id=91651 --- Comment #20 from Rob Muylaert i...@rmkeramiek.nl --- (In reply to tommy27 from comment #18) @pkaplanphd @Rob please answer to my previous comment Working on a deadline for an exhibition is the cause of the delay of my answer. I did try to disable the hardware acceleration. But I met some problems. First my version is in Dutch, the suggestion is probably for Windows 7 or lower. I use Windows 8.1 The explanation even on Youtube is for older versions. In the menu for the Intel HD Graphics 5300 there are no options which looks like hardware acceleration. I tried most options, no result. I looked at the site from Intel for this video card. The options they give are not applicable. The problem is still present. I put some screen shots from the control panel en from the Intel site. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92525] New: docx export: Text orentation in shape not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=92525 Bug ID: 92525 Summary: docx export: Text orentation in shape not correct Product: LibreOffice Version: 5.0.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ralf.kr...@bluewin.ch The export of attached file goes wrong: The text appears in the docx on the left side, instead of goes with the middle of the shape as in the original file. Easy to see in the screenshot. Cheers -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92392] EDITING + UI: Calc crash when hitting Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=92392 --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Created attachment 117026 -- https://bugs.documentfoundation.org/attachment.cgi?id=117026action=edit test file. Steps: 1) load file, 2) double click chart, 3) edit range 4), click 'in-sheet-selection-widget' 5) click, 6) repeat 4, 7) select A1:B4, 8) click outside chart, 9) hit enter. Looks like we trigger the still registered accelerator in the ScFormulaReferenceHelper. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92526] docx export: Line with of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 ralf.kr...@bluewin.ch changed: What|Removed |Added Version|5.0.0.1 rc |5.0.0.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92526] New: docx export: Line with of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 Bug ID: 92526 Summary: docx export: Line with of shape is wrong (0pt) Product: LibreOffice Version: 5.0.0.1 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ralf.kr...@bluewin.ch The export of attached file goes partwise wrong: The line with 0 pt is wrong exported in docx. It appears as line with 0.75 pts in winword. All other line with's are correct! Cheers -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92526] docx export: Line with of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 --- Comment #2 from ralf.kr...@bluewin.ch --- Created attachment 117028 -- https://bugs.documentfoundation.org/attachment.cgi?id=117028action=edit Original odt file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92526] docx export: Line with of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 --- Comment #1 from ralf.kr...@bluewin.ch --- Created attachment 117027 -- https://bugs.documentfoundation.org/attachment.cgi?id=117027action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92520] LibO crash when editing .odb database properties
https://bugs.documentfoundation.org/show_bug.cgi?id=92520 tommy27 ba...@quipo.it changed: What|Removed |Added Keywords|bisected|regression CC||ba...@quipo.it Summary|LibreOffice crash when |LibO crash when editing |editing odb database|.odb database properties |properties | Whiteboard||bisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92523] New: Writer paragraph style doesn't contain text highlighting attribute
https://bugs.documentfoundation.org/show_bug.cgi?id=92523 Bug ID: 92523 Summary: Writer paragraph style doesn't contain text highlighting attribute Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: yanp...@gmail.com It contains paragraph background color, but not text background... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92471] FILESAVE: New DOCX export of text with highlighting works not for all colors
https://bugs.documentfoundation.org/show_bug.cgi?id=92471 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #4 from Beluga todven...@suomi24.fi --- Confirmed the wrongess, when using the default export option: Highlighting. However, if you choose Tools - Options - Load/save - MSO - Export as: Shading, it works ok! Win 8.1 32-bit MSO 2013 Version: 5.0.0.2 Build ID: a26d58f11b99b6aeddf7f7884effea188cc6e512 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/view/viewsh.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 978033d5ed9f93f2d5d9a1ba44acf6b37bc13bfe Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Jul 3 11:52:17 2015 +0200 SwViewShell::DLPrePaint2: fix missing clipping for the non-buffered case With this, if the sw window is small enough that the page shadow is supposed to be under the sidebar, we no longer paint the shadow over the sidebar. In the non-double-buffered case the output is a window, so SdrPaintWindow::PreparePreRenderDevice() does its own buffering, and clipping is taken care of when that buffer is copied to the window in SdrPreRenderDevice::OutputPreRenderDevice(). This wasn't a problem before, as either the output was a non-screen device or UI elements were painted (like the sidebar), but never both at the same time. Change-Id: Ic02c814fc4deeea86c245c74bd69656533d9f835 diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 3e77cf1..0f27fc5 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -203,6 +203,9 @@ void SwViewShell::DLPrePaint2(const vcl::Region rRegion) mpBufferedOut = mpOut; mpOut = (mpTargetPaintWindow-GetTargetOutputDevice()); } +else +// In case mpOut is used without buffering, need to set clipping. +mpOut-SetClipRegion(rRegion); // remember original paint MapMode for wrapped FlyFrame paints maPrePostMapMode = mpOut-GetMapMode(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91651] slideshow not possible
https://bugs.documentfoundation.org/show_bug.cgi?id=91651 --- Comment #22 from pkaplan...@gmail.com --- Thanks for the efforts. I would like to go back to using libre office if the bug can be worked around. Trying WPS for now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46447] Embedded pictures/images disappear from Presentation (ODP) [Summary: comment#58, comment#67. Temporary advise: comment#69. Confirmed without autosave: comment#109]
https://bugs.documentfoundation.org/show_bug.cgi?id=46447 ski...@alum.mit.edu changed: What|Removed |Added CC||ski...@alum.mit.edu --- Comment #213 from ski...@alum.mit.edu --- Bug is present in 4.3.7.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92375] Impress looses cropped image ratio on saving and re-opening in different LO versions.
https://bugs.documentfoundation.org/show_bug.cgi?id=92375 --- Comment #13 from Pascal Hingamp pascal.hing...@gmail.com --- (In reply to skiani from comment #11) Total show stopper. Image crop confusion and lost images are killer. Makes a complete embarrassing mess in front of the crowd, no excuse, should have been fixed long ago. In my punishment I was lucky: I could spend the night before my seminar redoing my slides:) Lotsa cursing believe me. But indeed had I not tested my .odp file before the next day's seminar, it would basically have meant seminar cancellation live before the audience gathered to listen to the invited speaker. Nightmare, it's never happened to me, and I've never seen that happen before to anyone. That would be a very serious blow to one's reputation in the field. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92392] EDITING + UI: Calc crash when hitting Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=92392 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Michael Meeks michael.me...@collabora.com --- After a bit I managed to reproduce it vs. master - you need to use the range selection widget as described. I'm using a build based on ff4b8d39e649ed56770b28550158b5148432ee48 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92378] Implement a11y / invalidate all children event
https://bugs.documentfoundation.org/show_bug.cgi?id=92378 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC|er...@redhat.com, | |michael.me...@collabora.com | Summary|Warning messages when |Implement a11y / invalidate |inserting a chart |all children event Severity|normal |enhancement --- Comment #4 from Michael Meeks michael.me...@collabora.com --- Random accessibility related warning, almost certainly of no real interest =) vcl/unx/gtk/a11y/atkutil.cxx-case accessibility::AccessibleEventId::INVALIDATE_ALL_CHILDREN: vcl/unx/gtk/a11y/atkutil.cxx:g_warning( Invalidate all children called\n ); vcl/unx/gtk/a11y/atkutil.cxx-break; I guess we are missing a mapping to the native platform atk /toolkit for this event: void DocumentFocusListener::notifyEvent( const accessibility::AccessibleEventObject aEvent ) throw( uno::RuntimeException, std::exception ) has no code; same warning on OS/X ... discuss =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92309] FILESAVE: Save As and Save a Copy should not change file format by default
https://bugs.documentfoundation.org/show_bug.cgi?id=92309 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- What desktop environment are you using? KDE? There is bug 92517 KDE4-FileDialog: Save as has wrong Filter. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91770] Crash on closing on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91770 --- Comment #13 from Michael Meeks michael.me...@collabora.com --- Hmm; nope - can't reproduce this - the apparent hang was just me running something else in the console impatiently =) Can you still reproduce this Jay ? - I guess it is the ThumbnailView not stopping updating its items during shutdown which is ... odd ... sfxlo!ThumbnailView::updateItems+0x9fa2 00d4fa88 6c3bc0fd 00d4faac 6c3305f8 sfxlo!ThumbnailView::updateItems+0x3805 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source
sw/qa/extras/uiwriter/data/draw-anchor-undo.odt |binary sw/qa/extras/uiwriter/uiwriter.cxx | 27 sw/source/core/undo/unattr.cxx | 11 +++-- 3 files changed, 35 insertions(+), 3 deletions(-) New commits: commit b5a4e6974a5473c44fc239b6a9ae21f233111c2a Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 3 12:47:41 2015 +0100 add a shape resize undo test Change-Id: I88c2d7de243660ba727f057d6a2d67726b41b982 diff --git a/sw/qa/extras/uiwriter/data/draw-anchor-undo.odt b/sw/qa/extras/uiwriter/data/draw-anchor-undo.odt new file mode 100644 index 000..370799c Binary files /dev/null and b/sw/qa/extras/uiwriter/data/draw-anchor-undo.odt differ diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 6138ed2..a0c1bfe 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -113,6 +113,7 @@ public: void testEmbeddedDataSource(); void testUnoCursorPointer(); void testTextTableCellNames(); +void testShapeAnchorUndo(); CPPUNIT_TEST_SUITE(SwUiWriterTest); CPPUNIT_TEST(testReplaceForward); @@ -163,6 +164,7 @@ public: CPPUNIT_TEST(testEmbeddedDataSource); CPPUNIT_TEST(testUnoCursorPointer); CPPUNIT_TEST(testTextTableCellNames); +CPPUNIT_TEST(testShapeAnchorUndo); CPPUNIT_TEST_SUITE_END(); private: @@ -1476,6 +1478,31 @@ void SwUiWriterTest::testTextTableCellNames() CPPUNIT_ASSERT(nCol == 105); } +void SwUiWriterTest::testShapeAnchorUndo() +{ +SwDoc* pDoc = createDoc(draw-anchor-undo.odt); +SwWrtShell* pWrtShell = pDoc-GetDocShell()-GetWrtShell(); +SdrPage* pPage = pDoc-getIDocumentDrawModelAccess().GetDrawModel()-GetPage(0); +SdrObject* pObject = pPage-GetObj(0); +Rectangle aOrigLogicRect(pObject-GetLogicRect()); + +sw::UndoManager rUndoManager = pDoc-GetUndoManager(); +rUndoManager.StartUndo(UNDO_START, NULL); + +pWrtShell-SelectObj(Point(), 0, pObject); + +pWrtShell-GetDrawView()-MoveMarkedObj(Size(100, 100), false); +pWrtShell-ChgAnchor(0, true, true); + +rUndoManager.EndUndo(UNDO_END, NULL); + +CPPUNIT_ASSERT(aOrigLogicRect != pObject-GetLogicRect()); + +rUndoManager.Undo(); + +CPPUNIT_ASSERT(aOrigLogicRect == pObject-GetLogicRect()); +} + CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest); CPPUNIT_PLUGIN_IMPLEMENT(); commit f1256611054701a2bba20225fb654814eecbf559 Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 3 11:46:18 2015 +0100 Resolves: tdf#92137 drawing layer resize undo in writer fails... to restore location correctly if SwFEShell::EndDrag is tweaked to not group the anchor change undo and the draw size/pos change undo together and then you undo each step in the ui one at a time this works fine. The first undo occurs, then the layout kicks in on idle and calls MakeObjPos on the drawing item and updates it for the new anchor pos Then on triggering size undo the anchor is correct so the new pos is set correctly. If they are bundled together however, the layout at idle doesn't occur until after the anchor and size have been set, so the adjustment is too late Change-Id: I5402d851fcae7f240cc6e9a0e15159115bb663ce diff --git a/sw/source/core/undo/unattr.cxx b/sw/source/core/undo/unattr.cxx index ec5770d..9283ae2 100644 --- a/sw/source/core/undo/unattr.cxx +++ b/sw/source/core/undo/unattr.cxx @@ -480,9 +480,9 @@ bool SwUndoFormatAttr::RestoreFlyAnchor(::sw::UndoRedoContext rContext) } } +SwDrawContact *pCont = NULL; if ( RES_DRAWFRMFMT == pFrameFormat-Which() ) { -SwDrawContact *pCont = -static_castSwDrawContact*(pFrameFormat-FindContactObj()); +pCont = static_castSwDrawContact*(pFrameFormat-FindContactObj()); // The Draw model also prepared an Undo object for its right positioning // which unfortunately is relative. Therefore block here a position // change of the Contact object by setting the anchor. @@ -508,8 +508,13 @@ bool SwUndoFormatAttr::RestoreFlyAnchor(::sw::UndoRedoContext rContext) pTextNd-InsertItem( aFormat, pPos-nContent.GetIndex(), 0 ); } -if( RES_DRAWFRMFMT != pFrameFormat-Which() ) +if (RES_DRAWFRMFMT != pFrameFormat-Which()) pFrameFormat-MakeFrms(); +else +{ +SdrObject* pSdrObj = pFrameFormat-FindSdrObject(); +pCont-GetAnchoredObj(pSdrObj)-MakeObjPos(); +} rContext.SetSelections(pFrameFormat, 0); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92500] DOCX created by LibO not opened by other word processing software
https://bugs.documentfoundation.org/show_bug.cgi?id=92500 --- Comment #5 from tommy27 ba...@quipo.it --- (In reply to Beluga from comment #4) (In reply to Jonathan Camilleri from comment #0) Created attachment 116999 [details] attachment MSO 2013 opens it fine. Even the header image is displayed intact, while in LibO, it has a white rectangle going over it! we should file a separate bug report about this issue in LibO. who's gonna do it, me or you beluga? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89852] Cyrillic symbols in file name become as question marks in Subjec in email when a document sent by email
https://bugs.documentfoundation.org/show_bug.cgi?id=89852 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #3 from Beluga todven...@suomi24.fi --- For me, it says LibreOffice was unable to find a working e-mail configuration. All other files are sent to my Thunderbird! Win 7 Pro 64-bit, Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 Locale: fi_FI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91776] Start Center R accelerator conflict between Recent Files and Draw Drawing (english UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=91776 --- Comment #14 from mahfiaz mahf...@gmail.com --- (In reply to V Stuart Foote from comment #13) Yes, and another facet to using the module names would be that those aren't translated... But the menu names are translated (as for T reserved for Tools not templates). I'd say we don't worry about translators. They'll manage or report. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: include/basegfx sax/inc shell/inc shell/source stoc/source
include/basegfx/color/bcolor.hxx | 31 ++ include/basegfx/matrix/b2dhommatrixtools.hxx |1 include/basegfx/pixel/bpixel.hxx |5 + include/basegfx/range/b1drange.hxx| 22 include/basegfx/range/b2ibox.hxx | 57 include/basegfx/range/b2irange.hxx| 50 ++ include/basegfx/range/b3drange.hxx| 65 ++ include/basegfx/tuple/b2i64tuple.hxx | 14 +++ include/basegfx/tuple/b3ituple.hxx| 18 +++ include/basegfx/vector/b3dvector.hxx | 26 + sax/inc/xml2utf.hxx |4 shell/inc/internal/i_xml_parser_event_handler.hxx |7 + shell/source/unix/sysshell/recently_used_file_handler.cxx |7 + stoc/source/corereflection/base.hxx |6 + stoc/source/javavm/javavm.hxx |3 15 files changed, 316 insertions(+) New commits: commit a6f5770b46506a22eae0d641ad48f9b6d239 Author: Michael Stahl mst...@redhat.com Date: Fri Jul 3 16:53:45 2015 +0200 Revert loplugin:unusedmethods sax,shell,stoc,basegfx The basegfx changes appear to break Windows builds. This reverts commit 3b32c5898ff4e744d3f18b00421b433500426d74. diff --git a/include/basegfx/color/bcolor.hxx b/include/basegfx/color/bcolor.hxx index 4358e05..2bdd420 100644 --- a/include/basegfx/color/bcolor.hxx +++ b/include/basegfx/color/bcolor.hxx @@ -131,6 +131,15 @@ namespace basegfx return *this; } +// blend to another color using luminance +void blend(const BColor rColor) +{ +const double fLuminance(luminance()); +mfX = rColor.getRed() * fLuminance; +mfY = rColor.getGreen() * fLuminance; +mfZ = rColor.getBlue() * fLuminance; +} + // luminance double luminance() const { @@ -155,6 +164,16 @@ namespace basegfx return sqrt(fDistR * fDistR + fDistG * fDistG + fDistB * fDistB); } +double getMinimumDistance(const BColor rColor) const +{ +const double fDistR(getDistanceRed(rColor)); +const double fDistG(getDistanceGreen(rColor)); +const double fDistB(getDistanceBlue(rColor)); + +double fRetval(fDistR fDistG ? fDistR : fDistG); +return (fRetval fDistB ? fRetval : fDistB); +} + double getMaximumDistance(const BColor rColor) const { const double fDistR(getDistanceRed(rColor)); @@ -187,6 +206,18 @@ namespace basegfx return static_castconst BColor( ::basegfx::B3DTuple::getEmptyTuple() ); } +com::sun::star::uno::Sequence double colorToDoubleSequence(const com::sun::star::uno::Reference com::sun::star::rendering::XGraphicDevice /*xGraphicDevice*/) const +{ +com::sun::star::uno::Sequence double aRet(4); +double* pRet = aRet.getArray(); + +pRet[0] = mfX; +pRet[1] = mfY; +pRet[2] = mfZ; +pRet[3] = 1.0; + +return aRet; +} }; } // end of namespace basegfx diff --git a/include/basegfx/matrix/b2dhommatrixtools.hxx b/include/basegfx/matrix/b2dhommatrixtools.hxx index 41a17ec..b2aef89 100644 --- a/include/basegfx/matrix/b2dhommatrixtools.hxx +++ b/include/basegfx/matrix/b2dhommatrixtools.hxx @@ -218,6 +218,7 @@ namespace basegfx const B2DVector getScale() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return maScale; } const B2DVector getTranslate() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return maTranslate; } double getRotate() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return mfRotate; } +double getShearX() const { const_cast B2DHomMatrixBufferedOnDemandDecompose* (this)-impCheckDecompose(); return mfShearX; } }; } // end of namespace tools diff --git a/include/basegfx/pixel/bpixel.hxx b/include/basegfx/pixel/bpixel.hxx index fda6a79..cf5c7a3 100644 --- a/include/basegfx/pixel/bpixel.hxx +++ b/include/basegfx/pixel/bpixel.hxx @@ -95,16 +95,21 @@ namespace basegfx sal_uInt8 getGreen() const { return maPixelUnion.maRGBO.mnG; } sal_uInt8 getBlue() const { return maPixelUnion.maRGBO.mnB; } sal_uInt8 getOpacity() const { return maPixelUnion.maRGBO.mnO; } +sal_uInt32 getRedGreenBlueOpacity() const { return maPixelUnion.maCombinedRGBO.mnValue; } // data access write void setRed(sal_uInt8 nNew) { maPixelUnion.maRGBO.mnR = nNew; } void setGreen(sal_uInt8 nNew) { maPixelUnion.maRGBO.mnG = nNew; } void
[Libreoffice-bugs] [Bug 92526] docx export: Line with of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 --- Comment #3 from ralf.kr...@bluewin.ch --- Created attachment 117029 -- https://bugs.documentfoundation.org/attachment.cgi?id=117029action=edit Exported docx file with LO5002 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91651] slideshow not possible
https://bugs.documentfoundation.org/show_bug.cgi?id=91651 --- Comment #21 from Rob Muylaert i...@rmkeramiek.nl --- Created attachment 117020 -- https://bugs.documentfoundation.org/attachment.cgi?id=117020action=edit controle panel Intel HD Graphics 5300 see reply 20 on comment 18 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92524] New: FILESAVE from .doc to .docx - white highlight added to paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=92524 Bug ID: 92524 Summary: FILESAVE from .doc to .docx - white highlight added to paragraph style Product: LibreOffice Version: 4.4.3.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: todven...@suomi24.fi Created attachment 117021 -- https://bugs.documentfoundation.org/attachment.cgi?id=117021action=edit Doc from Europass CV generator Spin-off from bug 92500. Doc file is saved from https://europass.cedefop.europa.eu/pt/documents/curriculum-vitae Saving it from LibO to .docx, the Ansioluettelo text in the header gets a white highlight background, obscuring the header image. Odt saved from Europass does not exhibit this problem. We do not know what engine Europass uses for the doc generation. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: 8b788891796ff0571f779cdbe8ce809c35c42754 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-02_23:09:27 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92375] Impress looses cropped image ratio on saving and re-opening in different LO versions.
https://bugs.documentfoundation.org/show_bug.cgi?id=92375 --- Comment #12 from Beluga todven...@suomi24.fi --- (In reply to skiani from comment #11) Total show stopper. Image crop confusion and lost images are killer. Makes a complete embarrassing mess in front of the crowd, no excuse, should have been fixed long ago. Can you reproduce the problem with attachment 116864? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92520] LibO crash when editing .odb database properties
https://bugs.documentfoundation.org/show_bug.cgi?id=92520 Justin L jl...@mail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Justin L jl...@mail.com --- confirmed that reversing this patch in current libreoffice-5-0 fixes the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46447] Embedded pictures/images disappear from Presentation (ODP) [Summary: comment#58, comment#67. Temporary advise: comment#69. Confirmed without autosave: comment#109]
https://bugs.documentfoundation.org/show_bug.cgi?id=46447 --- Comment #214 from tommy27 ba...@quipo.it --- @Tim @skiani please open a new bug report as Caolan suggested with exact steps to reproduce and test files if needed. then put the new bug report link under the see Also field of the current report -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91660] Encoding problem with grammar suggestions in GTK KDE4 themes
https://bugs.documentfoundation.org/show_bug.cgi?id=91660 --- Comment #3 from Arnaud LE CAM a...@lecam-conseil.com --- Created attachment 117025 -- https://bugs.documentfoundation.org/attachment.cgi?id=117025action=edit Grammalecte's propositions and result Here are steps to reproduce : 1) Create a new document from the initial screen 2) Install Grammalecte extension (http://extensions.libreoffice.org/extension-center/dictionnaires-francais/releases/5.3/lo-oo-ressources-linguistiques-fr-v5-3.oxt) 3) Set language for all text to French 4) Make automatic spell checking active 5) On the first line, write the text 1er + enter (er will be automatically place on upper position, it's correct) 6) On the second line, write the texte 2eme + enter (2eme will be bluewave-underlined, it's correct) 7) Right-click on 2eme, and it will give you the Grammalecte's propositions (see attachment, please) 8) Choose the first one (it should be a 2 with a e upper-placed) 9) 2eme will be replaced by 2+square, in place of 2 with a e upper-placed Writing this, I'm asking about graphics stack relevance of this bug... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: qadevOOo/tests
qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java | 22 +++--- 1 file changed, 17 insertions(+), 5 deletions(-) New commits: commit 2a583603dec40090289ddb5b4b70d800794cf57b Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 3 16:57:50 2015 +0200 Make test code more robust Change-Id: If3b58c02b289224938b1dfd8074f9802ea6d2474 diff --git a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java index a5d0740..2971669 100644 --- a/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java +++ b/qadevOOo/tests/java/ifc/accessibility/_XAccessibleEventBroadcaster.java @@ -77,7 +77,9 @@ public class _XAccessibleEventBroadcaster extends MultiMethodTest { if (nev instanceof com.sun.star.accessibility.XAccessible) { System.out.println(New: +((XAccessible)nev).getAccessibleContext().getAccessibleName()); } -notifiedEvent = ev; +synchronized (this) { +notifiedEvent = ev; +} } public void disposing(EventObject ev) {} @@ -118,7 +120,11 @@ public class _XAccessibleEventBroadcaster extends MultiMethodTest { boolean works = true; -if (list.notifiedEvent == null) { +AccessibleEventObject ne; +synchronized (list) { +ne = list.notifiedEvent; +} +if (ne == null) { if (!isTransient) { log.println(listener wasn't called); works = false; @@ -151,17 +157,23 @@ public class _XAccessibleEventBroadcaster extends MultiMethodTest { public void _removeEventListener() throws Exception { requiredMethod(addEventListener()); -list.notifiedEvent = null; - log.println(remove listener); oObj.removeAccessibleEventListener(list); +synchronized (list) { +list.notifiedEvent = null; +} + log.println(fire event); prod.fireEvent() ; waitForEventIdle(); -if (list.notifiedEvent == null) { +AccessibleEventObject ne; +synchronized (list) { +ne = list.notifiedEvent; +} +if (ne == null) { log.println(listener wasn't called -- OK); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 31199] Click on specific paragraph will freeze Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=31199 tommy27 ba...@quipo.it changed: What|Removed |Added Summary|Click on specific paragraph |Click on specific paragraph |will freeze Writer. |will freeze Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92497] Styles Formatting sidebar has incorrect tooltip for style management group button
https://bugs.documentfoundation.org/show_bug.cgi?id=92497 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Tooltip for sidebar create |Styles Formatting sidebar |or update a char style is |has incorrect tooltip for |bad |style management group ||button --- Comment #2 from Yousuf (Jay) Philips philip...@hotmail.com --- Not sure if its a group button that is simply taking the tooltip from the first entry from the drop down, but it definitely needs to be changed to something like 'Manage Styles'. If you open Calc, the group button isnt there and two of the drop down entries (new style, update style) are regular buttons in the toolbar. I'm assuming the group button was needed in writer as there are 5 style categories, while calc only has 2. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92515] EDITING error copying formula through column
https://bugs.documentfoundation.org/show_bug.cgi?id=92515 --- Comment #2 from Muca murilolim...@gmail.com --- I fixed the spreadsheet and I can't reproduce the bug any longer, sorry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92497] Styles Formatting sidebar has incorrect tooltip for style management group button
https://bugs.documentfoundation.org/show_bug.cgi?id=92497 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Tooltip for sidebar create |Styles Formatting sidebar |or update a char style is |has incorrect tooltip for |bad |style management group ||button --- Comment #2 from Yousuf (Jay) Philips philip...@hotmail.com --- Not sure if its a group button that is simply taking the tooltip from the first entry from the drop down, but it definitely needs to be changed to something like 'Manage Styles'. If you open Calc, the group button isnt there and two of the drop down entries (new style, update style) are regular buttons in the toolbar. I'm assuming the group button was needed in writer as there are 5 style categories, while calc only has 2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92525] docx export: Text orentation in shape not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=92525 --- Comment #1 from ralf.kr...@bluewin.ch --- Created attachment 117022 -- https://bugs.documentfoundation.org/attachment.cgi?id=117022action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92525] docx export: Text orentation in shape not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=92525 --- Comment #2 from ralf.kr...@bluewin.ch --- Created attachment 117023 -- https://bugs.documentfoundation.org/attachment.cgi?id=117023action=edit Original odt file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: 4 commits - helpauthoring/Addons.xcu helpauthoring/description.xml helpauthoring/filter helpauthoring/Filter.xcu helpauthoring/help helpauthoring/HelpAuthoring hel
helpauthoring/images/emblem-symbolic-link.png |binary helpauthoring/images/favorites.png |binary helpauthoring/images/web-browser.png |binary helpauthoring/template/Help/xmlhelptemplate.ott |binary 61 files changed, 9301 insertions(+) New commits: commit 2145f670bf16c51ee417763c22d5c9b3a25659d5 Author: Jan Holesovsky ke...@collabora.com Date: Fri Jul 3 16:11:14 2015 +0200 helpauthoring: New release. To release the new .oxt, it is enough to: cd dev-tools/helpauthoring zip -r ~/HelpAuthoring-3.0-`date +%Y%m%d`.oxt . diff --git a/helpauthoring/HelpAuthoring/_Main.xba b/helpauthoring/HelpAuthoring/_Main.xba index 9e1e065..84182e1 100644 --- a/helpauthoring/HelpAuthoring/_Main.xba +++ b/helpauthoring/HelpAuthoring/_Main.xba @@ -24,7 +24,7 @@ apos; # the License at http://www.apache.org/licenses/LICENSE-2.0 . apos; # -Global Const Version = quot;v3.20150605quot; +Global Const Version = quot;v3.20150703quot; Global Const strErr_NoHelpFile = quot;Not a Help Filequot; diff --git a/helpauthoring/description.xml b/helpauthoring/description.xml index c8cdf68..ec7082d 100644 --- a/helpauthoring/description.xml +++ b/helpauthoring/description.xml @@ -21,7 +21,7 @@ identifier value=org.openoffice.helpauthoring/ -version value=3.0-20150605/ +version value=3.0-20150703/ display-name name lang=enHelp authoring extension tool/name /display-name commit 2ea6bf8143a7ca20d6bee3bff6b80d2cf5c29fbe Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Fri Jul 3 16:06:44 2015 +0200 helpauthoring: Menu entry to get filepicker set to xhp when opening files. diff --git a/helpauthoring/Addons.xcu b/helpauthoring/Addons.xcu index 2ce8e1d..7330bce 100644 --- a/helpauthoring/Addons.xcu +++ b/helpauthoring/Addons.xcu @@ -29,6 +29,15 @@ valuecom.sun.star.text.TextDocument/value /prop node oor:name=Submenu +node oor:name=m00 oor:op=replace +prop oor:name=URL oor:type=xs:string + valuevnd.sun.star.script:HelpAuthoring._Main.OpenXHP?language=Basicamp;location=application/value +/prop +prop oor:name=Title oor:type=xs:string +value/ +value xml:lang=en-USOpen Help File/value +/prop +/node node oor:name=m01 oor:op=replace prop oor:name=URL oor:type=xs:string valuevnd.sun.star.script:HelpAuthoring._Main.CreateFile?language=Basicamp;location=application/value diff --git a/helpauthoring/HelpAuthoring/_Main.xba b/helpauthoring/HelpAuthoring/_Main.xba index 317dd04..9e1e065 100644 --- a/helpauthoring/HelpAuthoring/_Main.xba +++ b/helpauthoring/HelpAuthoring/_Main.xba @@ -187,4 +187,27 @@ End Sub Sub DisplayVersion msgbox quot;LibreOffice Help Authoring Frameworkquot;+chr(13)+quot;Version quot;+Version,256 End Sub + +Sub OpenXHP +Dim ListAny(0) as Long +Dim FileProperties(1) As New com.sun.star.beans.PropertyValue + +sLastSaveDir = ReadConfig(quot;LastSaveDirquot;) +sDocRoot = ReadConfig(quot;HelpPrefixquot;) +ListAny(0) = com.sun.star.ui.dialogs.TemplateDescription.FILEOPEN_SIMPLE +oFileDialog = CreateUnoService(quot;com.sun.star.ui.dialogs.FilePickerquot;) +oFileDialog.Initialize(ListAny()) +oFileDialog.DisplayDirectory = sDocRoot +oFileDialog.AppendFilter(quot;Helpquot;, quot;*.xhpquot;) +oFileDialog.SetTitle(quot;Open Help Filequot;) +iAccept = oFileDialog.Execute() +If iAccept = 1 Then +sPath = oFileDialog.Files(0) +FileProperties(0).Name = quot;FilterNamequot; +FileProperties(0).Value =quot;XHP_Helpquot; +oDoc = StarDesktop.loadComponentFromURL(sPath, quot;_blankquot;, 0, FileProperties()) +End If +oFileDialog.Dispose() +End Sub + /script:module commit db7f60b24ad69481734d1ddab6fa1f8aee8b7152 Author: Olivier Hallot olivier.hal...@edx.srv.br Date: Fri Jul 3 15:59:09 2015 +0200 helpauthoring: Fix opening, editing and saving existing help files. diff --git a/helpauthoring/HelpAuthoring/Meta.xba b/helpauthoring/HelpAuthoring/Meta.xba index 29427c1..57d9b1c 100644 --- a/helpauthoring/HelpAuthoring/Meta.xba +++ b/helpauthoring/HelpAuthoring/Meta.xba @@ -47,7 +47,7 @@ Sub Main apos;End If oTxtTitle = oDialog.GetControl(quot;txtTitlequot;) -oTxtTitle.Text = document.DocumentInfo.Title +oTxtTitle.Text = document.DocumentProperties.Title oOpIndInc = oDialog.GetControl(quot;opIndexIncludequot;) oOpIndExc = oDialog.GetControl(quot;opIndexExcludequot;) @@ -64,7 +64,10 @@ Sub Main apos;End
HelpAuthoring.oxt: An easy way to edit help files
Hi, Olivier recently resurrected the HelpAuthoring.oxt extension that makes it much easier to edit help files, and I've pushed that to git now: http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/helpauthoring I don't want to announce it too widely yet, tough; it has a bug that from some reason, the new edits appear in bold when saved (they appear enclosed in emph / /emph). Olivier, anybody - can you please have a look why that happens? Cannot do myself ATM :-( Once this is fixed, I hope the editing of Help will get much easier, and we'll be able to get better coverage / higher quality Help even before we convert to some better editable format. Some instructions how to use it: https://wiki.documentfoundation.org/Documentation/Help Olivier - if you can make it to the next ESC, that would be great :-) Thanks so much for making this happen! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/view/viewsh.cxx | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) New commits: commit c9175a1bd3249ad573ae6827bf19963a3ebe2fbc Author: Miklos Vajna vmik...@collabora.co.uk Date: Fri Jul 3 17:52:44 2015 +0200 SwViewShell::ImplEndAction: avoid direct PaintDesktop() With double-buffering enabled and typing quickly, one saw blinks in the text sometimes. The reason was that PaintDesktop() painted directly outside SwViewShell::Paint(). The problem is more visible with VCL_DOUBLEBUFFERING_AVOID_PAINT=1, loading a simple document + pressing a key draw an unexpected white rectangle. Given that InvalidateWindows() already calls PaintDesktop() inside Paint() implicitly (via SwViewShell::Paint()), fix the problem by just avoiding the DLPrePaint2() + PaintDesktop() + DLPostPaint2() calls. Change-Id: Ib8ce26a0bdd526bf85d362f0e865dd61d29f6d11 diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 0f27fc5..9462b8f 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -405,20 +405,7 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd ) } if ( bPaint ) { -// #i75172# begin DrawingLayer paint -// need to do begin/end DrawingLayer preparation for each single rectangle of the -// repaint region. I already tried to prepare only once for the whole Region. This -// seems to work (and does technically) but fails with transparent objects. Since the -// region given to BeginDarwLayers() defines the clip region for DrawingLayer paint, -// transparent objects in the single rectangles will indeed be painted multiple times. -DLPrePaint2(vcl::Region(aRect.SVRect())); - -if ( bPaintsFromSystem ) -PaintDesktop(*GetOut(), aRect); - pCurrentLayout-GetCurrShell()-InvalidateWindows(aRect.SVRect()); - -// #i75172# end DrawingLayer paint -DLPostPaint2(true); +InvalidateWindows(aRect.SVRect()); } lcl_PaintTransparentFormControls(*this, aRect); // i#107365 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92526] docx export: Line width of shape is wrong (0pt)
https://bugs.documentfoundation.org/show_bug.cgi?id=92526 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Summary|docx export: Line with of |docx export: Line width of |shape is wrong (0pt)|shape is wrong (0pt) Ever confirmed|0 |1 --- Comment #4 from raal r...@post.cz --- I can confirm with Version: 5.1.0.0.alpha1+ Build ID: 7790b6a4544cf2d5ba0bcdfae31346cf2f9a0041 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-26_23:51:00 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92528] UsageInfo crash on exit
https://bugs.documentfoundation.org/show_bug.cgi?id=92528 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ke...@collabora.com Ever confirmed|0 |1 --- Comment #1 from Michael Meeks michael.me...@collabora.com --- Kendy - looks like one of yours (?) =) can we store the setting in some module local variable to avoid needing to fetch it again on exit (perhaps) =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92241] Preview is cut off in Symbols dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=92241 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92514] Do you want to save alert when closing table with focus in a record does not save, endless loop.
https://bugs.documentfoundation.org/show_bug.cgi?id=92514 jimrussell98...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #2 from jimrussell98...@gmail.com --- Agreed, cannot duplicate. May have been due to interference from Dropbox, which I now suspend while working on the database. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92508] : change table name support functionality not working
https://bugs.documentfoundation.org/show_bug.cgi?id=92508 --- Comment #2 from jimrussell98...@gmail.com --- Created attachment 117034 -- https://bugs.documentfoundation.org/attachment.cgi?id=117034action=edit example database illustrating problem In Tables view, try changing the name of ClipSurvey to e.g. ClipSurvey_foo (using right-click on name of ClipSurvey, Rename menu item). You should get a complaint: Table is referenced by view: TrainingSet1 in statement [ALTER TABLE ClipSurvey RENAME TO ClipSurvey_foo]. Click on OK. You should get a dialog titled Rename to, with a data field labeled Table Name, with the contents ClipSurvey_foo. If you click on OK, you should get the Table is referenced ... alert again - at least I do. Only way out is to cancel on the Rename dialog (accomplishing nothing, except a graceful exit). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92392] EDITING + UI: Calc crash when hitting Enter key
https://bugs.documentfoundation.org/show_bug.cgi?id=92392 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Michael Meeks michael.me...@collabora.com --- Fixes here: https://gerrit.libreoffice.org/16739 tdf#92392 - tolerate Window::SetText post dispose. https://gerrit.libreoffice.org/16740 tdf#92392 - Dispose ScFormulaReferenceHelper properly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91310] [META] Fallout from VclPtr merge
https://bugs.documentfoundation.org/show_bug.cgi?id=91310 Bug 91310 depends on bug 92392, which changed state. Bug 92392 Summary: EDITING + UI: Calc crash when hitting Enter key https://bugs.documentfoundation.org/show_bug.cgi?id=92392 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92528] UsageInfo crash on exit
https://bugs.documentfoundation.org/show_bug.cgi?id=92528 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Version|unspecified |5.1.0.0.alpha0+ Master OS|All |Windows (All) --- Comment #2 from Michael Meeks michael.me...@collabora.com --- I assume this is a consequence of the CheckBox to turn off UsageInfo (?) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92520] LibO crash when editing .odb database properties
https://bugs.documentfoundation.org/show_bug.cgi?id=92520 --- Comment #3 from Justin L jl...@mail.com --- I added Zolnai Tamás to the bugs CC list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx include/vcl svx/source vcl/source
include/svx/charmap.hxx |3 +++ include/vcl/ctrl.hxx |2 ++ svx/source/dialog/charmap.cxx | 19 ++- vcl/source/control/ctrl.cxx | 21 +++-- 4 files changed, 38 insertions(+), 7 deletions(-) New commits: commit b010e4074e5d5ee3a3905f1351f04efafe937c2a Author: László Németh laszlo.nem...@collabora.com Date: Fri Jul 3 18:50:05 2015 +0200 tdf#92241 fix crashes and rendering of symbol set previews Change-Id: I43397f2b0caa31c334f87acf11fc96df2e051ad8 diff --git a/include/svx/charmap.hxx b/include/svx/charmap.hxx index d50382e..e56fe98 100644 --- a/include/svx/charmap.hxx +++ b/include/svx/charmap.hxx @@ -58,6 +58,7 @@ public: Link GetPreSelectHdl() const { return aHighHdl; } voidSetPreSelectHdl( const Link rHdl ) { aPreSelectHdl = rHdl; } static sal_uInt32 getSelectedChar(); +voidSetFont( const vcl::Font rFont ); svx::SvxShowCharSetItem* ImplGetItem( int _nPos ); int FirstInView() const; @@ -108,12 +109,14 @@ private: sal_Int32 nSelectedIndex; FontCharMapPtr mpFontCharMap; +SizemaFontSize; VclPtrScrollBar aVscrollSB; bool mbRecalculateFont : 1; bool mbUpdateForeground : 1; bool mbUpdateBackground : 1; + private: voidDrawChars_Impl(vcl::RenderContext rRenderContext, int n1, int n2); voidInitSettings(vcl::RenderContext rRenderContext); diff --git a/include/vcl/ctrl.hxx b/include/vcl/ctrl.hxx index 6741a22..69a3569 100644 --- a/include/vcl/ctrl.hxx +++ b/include/vcl/ctrl.hxx @@ -41,6 +41,8 @@ protected: private: boolmbHasControlFocus; +boolmbFont; +boolmbForeground; Link maGetFocusHdl; Link maLoseFocusHdl; diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx index 9d0c9a5..f5e9595 100644 --- a/svx/source/dialog/charmap.cxx +++ b/svx/source/dialog/charmap.cxx @@ -57,6 +57,7 @@ sal_uInt32 SvxShowCharSet::getSelectedChar() SvxShowCharSet::SvxShowCharSet(vcl::Window* pParent) : Control(pParent, WB_TABSTOP | WB_BORDER) , m_pAccessible(nullptr) +, maFontSize(0, 0) , aVscrollSB( VclPtrScrollBar::Create(this, WB_VERT) ) , mbRecalculateFont(true) , mbUpdateForeground(true) @@ -114,6 +115,7 @@ void SvxShowCharSet::StateChanged(StateChangedType nType) Invalidate(); Control::StateChanged( nType ); + } @@ -331,6 +333,12 @@ void SvxShowCharSet::Paint( vcl::RenderContext rRenderContext, const Rectangle DrawChars_Impl(rRenderContext, FirstInView(), LastInView()); } +void SvxShowCharSet::SetFont( const vcl::Font rFont ) +{ +Control::SetFont(rFont); +Invalidate(); +} + void SvxShowCharSet::DeSelect() { Invalidate(); @@ -506,6 +514,14 @@ void SvxShowCharSet::InitSettings(vcl::RenderContext rRenderContext) mbUpdateBackground = false; } + +vcl::Font aFont(rRenderContext.GetFont()); +aFont.SetWeight(WEIGHT_LIGHT); +aFont.SetAlign(ALIGN_TOP); +aFont.SetSize(maFontSize); +aFont.SetTransparent(true); +rRenderContext.SetFont(aFont); + } @@ -536,7 +552,8 @@ void SvxShowCharSet::RecalculateFont(vcl::RenderContext rRenderContext) aFont.SetWeight(WEIGHT_LIGHT); aFont.SetAlign(ALIGN_TOP); int nFontHeight = (aSize.Height() - 5) * 2 / (3 * ROW_COUNT); -aFont.SetSize(rRenderContext.PixelToLogic(Size(0, nFontHeight))); +maFontSize = rRenderContext.PixelToLogic(Size(0, nFontHeight)); +aFont.SetSize(maFontSize); aFont.SetTransparent(true); rRenderContext.SetFont(aFont); rRenderContext.GetFontCharMap(mpFontCharMap); diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx index 0c40a34..21056db 100644 --- a/vcl/source/control/ctrl.cxx +++ b/vcl/source/control/ctrl.cxx @@ -36,6 +36,8 @@ using namespace vcl; void Control::ImplInitControlData() { mbHasControlFocus = false; +mbFont = false; +mbForeground= false; mpControlData = new ImplControlData; } @@ -417,16 +419,23 @@ void Control::ApplySettings(vcl::RenderContext rRenderContext) { const StyleSettings rStyleSettings = rRenderContext.GetSettings().GetStyleSettings(); -vcl::Font rFont(GetCanonicalFont(rStyleSettings)); -ApplyControlFont(rRenderContext, rFont); - -ApplyControlForeground(rRenderContext, GetCanonicalTextColor(rStyleSettings)); +if (mbFont) +{ +vcl::Font rFont(GetCanonicalFont(rStyleSettings)); +ApplyControlFont(rRenderContext, rFont); +} -rRenderContext.SetTextFillColor(); +if (mbFont || mbForeground) +{ +ApplyControlForeground(rRenderContext, GetCanonicalTextColor(rStyleSettings)); +rRenderContext.SetTextFillColor(); +} } -void Control::ImplInitSettings(const bool,
Re: HelpAuthoring.oxt: An easy way to edit help files
Hi Kendy, On Fri, Jul 3, 2015 at 5:39 PM, Jan Holesovsky ke...@collabora.com wrote: Hi, Olivier recently resurrected the HelpAuthoring.oxt extension that makes it much easier to edit help files, and I've pushed that to git now: http://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/helpauthoring I don't want to announce it too widely yet, tough; it has a bug that from some reason, the new edits appear in bold when saved (they appear enclosed in emph / /emph). Maybe I can have a look during the week-end. Olivier, anybody - can you please have a look why that happens? Cannot do myself ATM :-( Once this is fixed, I hope the editing of Help will get much easier, and we'll be able to get better coverage / higher quality Help even before we convert to some better editable format. Some instructions how to use it: https://wiki.documentfoundation.org/Documentation/Help Maybe we should merge the page you asked me to write some times ago https://wiki.documentfoundation.org/HelpContent I've begin to write a simplified guide more complete than what I wrote on the wiki There is also the two extra files that will help to locate the help files to modify that we should decide where to put. Also is the modified template on git? Olivier - if you can make it to the next ESC, that would be great :-) Thanks so much for making this happen! Cheers Sophie -- Sophie Gautier sophie.gaut...@documentfoundation.org GSM:+33683901545 IRC: sophi Co-founder - Release coordinator The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92241] Preview is cut off in Symbols dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=92241 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- László Németh committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b010e4074e5d5ee3a3905f1351f04efafe937c2a tdf#92241 fix crashes and rendering of symbol set previews It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[GSoC] Improve user experience with CMIS – Weekly report #6
My work this week: * I integrated my dialog with FileDialogHelper. Now RemoteFilesDialog could be executed using the same command like normal file picker, filters are added depending on context. * bug 84190 - user wasn't able to change password after failed authorization. * bug 83089 - Cannot select location in properties dialogue * I added support of opening multiple files * some small improvements Now I'm working on async operations. In this dialog it could be useful to cancel current action, because sometimes opening remote directory is very slow (connection to the cmis.alfresco.com/cmisatom takes 30s, which is default timeout in async mode). User should have possibility to stop this process, for example after selecting any service by mistake without waiting. Timeout also shouldn't be too short, because it may be insufficient (like 30s for alfresco example). To do: * async operations * implement support of context bits * open/save remote buttons on toolbars Regards, Szymon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92509] default value for Boolean in Table not working
https://bugs.documentfoundation.org/show_bug.cgi?id=92509 --- Comment #2 from jimrussell98...@gmail.com --- Created attachment 117033 -- https://bugs.documentfoundation.org/attachment.cgi?id=117033action=edit example database illustrating problem See ClipSurvey, newBoolean field -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92520] LibO crash when editing .odb database properties
https://bugs.documentfoundation.org/show_bug.cgi?id=92520 --- Comment #2 from tommy27 ba...@quipo.it --- are you contacting the author of the guilty committ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92528] New: UsageInfo crash on exit
https://bugs.documentfoundation.org/show_bug.cgi?id=92528 Bug ID: 92528 Summary: UsageInfo crash on exit Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: framework Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: michael.me...@collabora.com Just exited a build from: ff4b8d39e649ed56770b28550158b5148432ee48 on Windows, having run some LibreLogo foo - and I got an unhappy un-caught exception in MSVC: KernelBase.dll!_RaiseException@16()Unknown msvcr120d.dll!_CxxThrowException(void * pExceptionObject, const _s__ThrowInfo * pThrowInfo) Line 154C++ comphelper.dll!comphelper::getProcessServiceFactory() Line 64C++ comphelper.dll!comphelper::getProcessComponentContext() Line 96C++ sfxlo.dll!`anonymous namespace'::UsageInfo::save() Line 633 C++ sfxlo.dll!`anonymous namespace'::UsageInfo::~UsageInfo() Line 612C++ sfxlo.dll!`rtl::Static`anonymous namespace'::UsageInfo,A0xddb81cae::theUsageInfo::StaticInstance::operator()'::`2'::`dynamic atexit destructor for 'instance''()C++ sfxlo.dll!_CRT_INIT(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 416C sfxlo.dll!__DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 522C sfxlo.dll!_DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 472C ntdll.dll!_LdrpCallInitRoutine@16()Unknown ntdll.dll!_LdrShutdownProcess@0()Unknown ntdll.dll!_RtlExitUserProcess@4()Unknown kernel32.dll!_ExitProcessStub@4()Unknown msvcr120d.dll!__crtExitProcess(int status) Line 776C msvcr120d.dll!doexit(int code, int quick, int retcaller) Line 678C msvcr120d.dll!exit(int code) Line 417C soffice.bin!__tmainCRTStartup() Line 662C soffice.bin!WinMainCRTStartup() Line 466C kernel32.dll!@BaseThreadInitThunk@12()Unknown This is the exception: Reference XMultiServiceFactory getProcessServiceFactory() { Reference XMultiServiceFactory xReturn; xReturn = localProcessFactory( xReturn, false ); if ( !xReturn.is() ) { throw DeploymentException( null process service factory ); I guess this de-init is happening rather after it should somehow. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) New commits: commit e83cb37cf7546e8bc46d0d49b487dcd352b67093 Author: Jan Holesovsky ke...@collabora.com Date: Fri Jul 3 18:14:31 2015 +0200 LOK: Don't try to absolutize URL's. Based on a patch by Henry Castro. Change-Id: Ia7aca20feb8f6095adf7dfe510ed78b1e9882740 diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index ee47cd8..3a0ce67 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -161,13 +161,18 @@ static OUString getUString(const char* pString) return OStringToOUString(sString, RTL_TEXTENCODING_UTF8); } -// Try to convert a relative URL to an absolute one +/// Try to convert a relative URL to an absolute one, unless it already looks like an URL. static OUString getAbsoluteURL(const char* pURL) { -OUString aURL( getUString( pURL ) ); +OUString aURL(getUString(pURL)); + +// return unchanged if it likely is an URL already +if (aURL.indexOf(://) 0) +return aURL; + OUString sAbsoluteDocUrl, sWorkingDir, sDocPathUrl; -// FIXME: this would appear to kill non-file URLs. +// convert relative paths to absolute ones osl_getProcessWorkingDir(sWorkingDir.pData); osl::FileBase::getFileURLFromSystemPath( aURL, sDocPathUrl ); osl::FileBase::getAbsoluteFileURL(sWorkingDir, sDocPathUrl, sAbsoluteDocUrl); @@ -343,7 +348,7 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, SolarMutexGuard aGuard; -OUString aURL = getAbsoluteURL(pURL); +OUString aURL(getAbsoluteURL(pURL)); pLib-maLastExceptionMsg.clear(); @@ -409,7 +414,7 @@ static int doc_saveAs(LibreOfficeKitDocument* pThis, const char* sUrl, const cha LibLODocument_Impl* pDocument = static_castLibLODocument_Impl*(pThis); OUString sFormat = getUString(pFormat); -OUString aURL = getAbsoluteURL(sUrl); +OUString aURL(getAbsoluteURL(sUrl)); try { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits