[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-1.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx | 54 +-
2 files changed, 27 insertions(+), 27 deletions(-)
New commits:
commit b52ba57efaa7f54391abec08b601e749963c711e
Author: Caolán McNamara caol...@redhat.com
Date: Sun Jul 19 21:09:25 2015 +0100
in reality we are limited to max sal_Int32 here
so accept that and test if the values were accepted or limited
Change-Id: I599cf8065a6f8786d380fdba03135857766770f3
(cherry picked from commit 80c591ea9c320fee9e975ac7b0e4e2df1bf5e447)
Reviewed-on: https://gerrit.libreoffice.org/17197
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
new file mode 100644
index 000..4fa0bb9
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 4599af9..b18db6b 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -65,8 +65,8 @@ private:
sal_uLong nNewSubFile;
sal_uLong nSubFile;
-sal_uLong nImageWidth;// picture width in
pixels
-sal_uLong nImageLength; // picture height in
pixels
+sal_Int32 nImageWidth;// picture width in
pixels
+sal_Int32 nImageLength; // picture height in
pixels
sal_uLong nBitsPerSample; // bits per pixel per
layer
sal_uLong nCompression; // kind of compression
sal_uLong nPhotometricInterpretation;
@@ -116,7 +116,7 @@ private:
// Create the bitmap from the temporary bitmap pMap
// and partly deletes pMap while doing this.
-boolConvertScanline( sal_uLong nY );
+boolConvertScanline(sal_Int32 nY);
// converts a Scanline to the Windows-BMP format
bool HasAlphaChannel() const;
@@ -537,13 +537,13 @@ bool TIFFReader::ReadMap()
{
if ( nCompression == 1 || nCompression == 32771 )
{
-sal_uLong ny, np, nStrip, nStripBytesPerRow;
+sal_uLong np, nStrip, nStripBytesPerRow;
if ( nCompression == 1 )
nStripBytesPerRow = nBytesPerRow;
else
nStripBytesPerRow = ( nBytesPerRow + 1 ) 0xfffe;
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -561,7 +561,7 @@ bool TIFFReader::ReadMap()
}
else if ( nCompression == 2 || nCompression == 3 || nCompression == 4 )
{
-sal_uLong ny, np, nStrip, nOptions;
+sal_uLong np, nStrip, nOptions;
if ( nCompression == 2 )
{
nOptions = CCI_OPTION_BYTEALIGNROW;
@@ -596,7 +596,7 @@ bool TIFFReader::ReadMap()
aCCIDecom.StartDecompression( *pTIFF );
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -622,13 +622,13 @@ bool TIFFReader::ReadMap()
else if ( nCompression == 5 )
{
LZWDecompressor aLZWDecom;
-sal_uLong ny, np, nStrip;
+sal_uLong np, nStrip;
nStrip=0;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
aLZWDecom.StartDecompression(*pTIFF);
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -651,13 +651,13 @@ bool TIFFReader::ReadMap()
}
else if ( nCompression == 32773 )
{
-sal_uLong nStrip,nRecCount,nRowBytesLeft,ny,np,i;
+sal_uLong nStrip,nRecCount,nRowBytesLeft,np,i;
sal_uInt8 * pdst;
nStrip = 0;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -771,9 +771,9 @@ sal_uLong TIFFReader::GetBits( const sal_uInt8 * pSrc,
sal_uLong nBitsPos, sal_u
-bool TIFFReader::ConvertScanline( sal_uLong nY )
+bool TIFFReader::ConvertScanline(sal_Int32 nY)
{
-sal_uInt32 nRed, nGreen, nBlue, ns, nx, nVal, nByteCount;
+sal_uInt32 nRed, nGreen, nBlue, ns, nVal, nByteCount;
sal_uInt8 nByteVal;
if ( nDstBitsPerPixel == 24 )
@@ -790,7 +790,7 @@ bool TIFFReader::ConvertScanline( sal_uLong nY )
sal_uInt8 nLGreen = 0;
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - framework/source sfx2/source
framework/source/uielement/recentfilesmenucontroller.cxx | 62 +--
sfx2/source/toolbox/tbxitem.cxx |6 +
2 files changed, 45 insertions(+), 23 deletions(-)
New commits:
commit ea0ff1f9ded1725a3e42d57de73ff89483a7ae5b
Author: Maxim Monastirsky momonas...@gmail.com
Date: Fri Jul 17 10:12:06 2015 +0300
Don't show open remote entry in the recent doc menu
We use the same menu controller for both the Open toolbar
button and the Recent Documents menu. While it's
reasonable to put the open remote file command under the
open button, it has nothing to do with recent documents,
so it shouldn't appear there.
Also don't add the No Document entry in case the open
remote entry is visible. The whole point of the No
Document entry is that we can't leave the menu empty,
but if there is another visible entry, it's not needed.
Change-Id: Ibefbdc6dc7d1d49f555d8ee23f67b47eba19b445
Signed-off-by: Szymon KÅos eszka...@gmail.com
diff --git a/framework/source/uielement/recentfilesmenucontroller.cxx
b/framework/source/uielement/recentfilesmenucontroller.cxx
index a2c3432..61d2f02 100644
--- a/framework/source/uielement/recentfilesmenucontroller.cxx
+++ b/framework/source/uielement/recentfilesmenucontroller.cxx
@@ -60,7 +60,8 @@ class RecentFilesMenuController : public
svt::PopupMenuControllerBase
using svt::PopupMenuControllerBase::disposing;
public:
-RecentFilesMenuController( const uno::Reference uno::XComponentContext
xContext );
+RecentFilesMenuController( const uno::Reference uno::XComponentContext
xContext,
+ const uno::Sequence uno::Any args );
virtual ~RecentFilesMenuController();
// XServiceInfo
@@ -115,12 +116,25 @@ private:
std::vector RecentFile m_aRecentFilesItems;
bool m_bDisabled : 1;
+bool m_bShowRemote;
};
-RecentFilesMenuController::RecentFilesMenuController( const uno::Reference
uno::XComponentContext xContext ) :
+RecentFilesMenuController::RecentFilesMenuController( const uno::Reference
uno::XComponentContext xContext,
+ const uno::Sequence
uno::Any args ) :
svt::PopupMenuControllerBase( xContext ),
-m_bDisabled( false )
+m_bDisabled( false ),
+m_bShowRemote( false )
{
+css::beans::PropertyValue aPropValue;
+for ( sal_Int32 i = 0; i args.getLength(); ++i )
+{
+args[i] = aPropValue;
+if ( aPropValue.Name == ShowRemote )
+{
+aPropValue.Value = m_bShowRemote;
+break;
+}
+}
}
RecentFilesMenuController::~RecentFilesMenuController()
@@ -227,26 +241,30 @@ void RecentFilesMenuController::fillPopupMenu( Reference
css::awt::XPopupMenu
FWK_RESSTR(STR_CLEAR_RECENT_FILES_HELP) );
// Open remote menu entry
-pVCLPopupMenu-InsertItem( sal_uInt16( nCount + 2 ),
- FWK_RESSTR(STR_OPEN_REMOTE) );
-pVCLPopupMenu-SetItemCommand( sal_uInt16( nCount + 2 ),
- OUString( CMD_OPEN_REMOTE ) );
+if ( m_bShowRemote )
+{
+pVCLPopupMenu-InsertItem( sal_uInt16( nCount + 2 ),
+ FWK_RESSTR(STR_OPEN_REMOTE) );
+pVCLPopupMenu-SetItemCommand( sal_uInt16( nCount + 2 ),
+ OUString( CMD_OPEN_REMOTE ) );
+}
}
else
{
-// No recent documents = insert no document string
-pVCLPopupMenu-InsertItem( 1, FWK_RESSTR(STR_NODOCUMENT) );
-// Do not disable it, otherwise the Toolbar controller and
MenuButton
-// will display SV_RESID_STRING_NOSELECTIONPOSSIBLE instead of
STR_NODOCUMENT
-pVCLPopupMenu-SetItemBits( 1, pVCLPopupMenu-GetItemBits( 1 ) |
MenuItemBits::NOSELECT );
-
-pVCLPopupMenu-InsertSeparator();
-
-// Open remote menu entry
-pVCLPopupMenu-InsertItem( sal_uInt16( 2 ),
- FWK_RESSTR(STR_OPEN_REMOTE) );
-pVCLPopupMenu-SetItemCommand( sal_uInt16( 2 ),
- OUString( CMD_OPEN_REMOTE ) );
+if ( m_bShowRemote )
+{
+// Open remote menu entry
+pVCLPopupMenu-InsertItem( 1, FWK_RESSTR(STR_OPEN_REMOTE) );
+pVCLPopupMenu-SetItemCommand( 1, CMD_OPEN_REMOTE );
+}
+else
+{
+// No recent documents = insert no document string
+pVCLPopupMenu-InsertItem( 1, FWK_RESSTR(STR_NODOCUMENT) );
+// Do not disable it, otherwise the Toolbar controller and
MenuButton
+// will display SV_RESID_STRING_NOSELECTIONPOSSIBLE
[Libreoffice-bugs] [Bug 92753] Column width of xlsx are missing in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92753 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- @Sugam : XLSX file opens with correct width in Excel 15.10.1 for OSX 10.10.4 Not our bug. Please upgrade your version of Excel. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/hang-5.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx |7 +--
2 files changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 33d43205c341e0cce36b6a1b3082c3927490cbde
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 09:20:33 2015 +0100
test that nNumStripByteCounts value is within bounds of file
Change-Id: If119628d7f510a7db30ed2180111063781cde887
diff --git a/filter/qa/cppunit/data/tiff/fail/hang-5.tiff
b/filter/qa/cppunit/data/tiff/fail/hang-5.tiff
new file mode 100644
index 000..f1be3fa
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-5.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 7a5d487..89de8e0 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -422,14 +422,17 @@ void TIFFReader::ReadTagData( sal_uInt16 nTagType,
sal_uInt32 nDataLen)
nNumStripByteCounts = 0; // to be on the safe side
nOldNumSBC = nNumStripByteCounts;
nDataLen += nOldNumSBC;
-if ( ( nDataLen nOldNumSBC ) ( nDataLen SAL_MAX_UINT32 /
sizeof( sal_uInt32 ) ) )
+size_t nMaxAllocAllowed = SAL_MAX_UINT32 / sizeof(sal_uInt32);
+size_t nMaxRecordsAvailable = pTIFF-remainingSize() /
DataTypeSize();
+if (nDataLen nOldNumSBC nDataLen nMaxAllocAllowed
+(nDataLen - nOldNumSBC) = nMaxRecordsAvailable)
{
nNumStripByteCounts = nDataLen;
try
{
pStripByteCounts = new sal_uLong[ nNumStripByteCounts ];
}
-catch (const std::bad_alloc )
+catch (const std::bad_alloc )
{
pStripByteCounts = NULL;
nNumStripByteCounts = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 44417] shortcut left Alt-key behaves different form right Alt-key
https://bugs.documentfoundation.org/show_bug.cgi?id=44417 --- Comment #5 from Winfried Donkers winfrieddonk...@libreoffice.org --- With version 4.4.4.3 the situation seems to be different (but not OK): Left-Alt, Right-Alt and Left-Ctrl keys cannot be used for copying/moving selected range. Right-Ctrl will move selected range when dragged with the mouse. O/S Windows7 (Dutch), keyboard US. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [GSoC] Improve user experience with CMIS – Weekly report #6
Hi Szymon, Szymon Kłos píše v Pá 10. 07. 2015 v 21:16 +0200: I think this is a good moment, considering that I completed most of work needed by my dialog. And I see this has happened - great stuff, thank you! :-) It works pretty well for me, only few UX comments: * when opening the Open Remote, and there is no service added yet, the Add service dialog should open directly * when opening the Open Remote dialog, either the list of files should be populated (using the currently selected service), or some feedback should be given that some user action is expected first * [to be discussed in with the UX/Design team] should we have a Reload button in the Open Remote dialog? Where, if yes? * in the Open Remote, some kind of feedback something is happening is necessary in when reading the list of files from the remote * Label: in the Add service dialog should pre-file according to the user name; like when the user name is 'johndoe', and the service is GDrive, the Label: should pre-file with Johndoe's GDrive or something (with the possibility to change this by the user if he/she wants) * opening file from the recent documents in the start center asks for the user name (would be good to remember that or have that as part of the URL it remembers), and then does not open the file - only the busy mouse pointer keeps rolling * [to be discussed within the UX/Design team] should we merge the Save and Save As buttons now, to have a split button there - Save as the default action, and the Save As File... and Save Remote File... in the submenu? * Remote File submenu for Save As should be renamed to Save Remote File... to give more idea what's going on * no Save Remote File... submenu in the LibreOffice Impress and Draw I am sorry if this feedback comes too early, and all this is actually on your todo :-) Either way - great stuff, love the work done so far! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92838] New: Allow option to disable read-only mode
https://bugs.documentfoundation.org/show_bug.cgi?id=92838 Bug ID: 92838 Summary: Allow option to disable read-only mode Product: LibreOffice Version: 5.0.0.3 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: miho...@miho.im Every file I open from Thunderbird is opened in read-only mode. I suggest an option similiar to Excel behaviour, to DISABLE read-only mode and open read-only files directly in EDIT MODE (as file copy). Of course, when you try to save them it will open Save As dialog. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92799] formatting cells
https://bugs.documentfoundation.org/show_bug.cgi?id=92799 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- @Marc: what system OS lang/locale are you using ? what locale settings are you using generally within LibreOffice ? are you using the FR langpack ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-5.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit bca4d6f896fb12ceff37476c43ea8892898dd385
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:50:27 2015 +0100
check np bounds yet again
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
new file mode 100644
index 000..4849edf
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index b18db6b..7a5d487 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -669,6 +669,8 @@ bool TIFFReader::ReadMap()
pTIFF-Seek(pStripOffsets[nStrip]);
}
nRowBytesLeft = nBytesPerRow;
+if (np = SAL_N_ELEMENTS(pMap))
+return false;
pdst=pMap[ np ];
do
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92836] Formatting: Page grid layout function doesn't correctly dispatch a character in a grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92836 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libreoffice-design] Re: [GSoC] Improve user experience with CMIS –Weekly report #6
Dnia 2015-07-20, pon o godzinie 07:06 +, Heiko Tietze pisze: Can we get a screenshot? Or is it implemented in the nightlies? Am 20.07.2015 08:32:49, schrieb Jan Holesovsky: * [to be discussed in with the UX/Design team] Some screenshots are available here: http://eszkadev.blogspot.com/2015/07/gsoc-15-remote-files-dialog.html Szymon ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-2.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit fc3ba0cdd424e1ae2852ad9809b49a5e6e55b2f5 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 19 21:25:46 2015 +0100 check np bounds Change-Id: Id16ae9325f3c67792941b9c88d83435aa98282ca (cherry picked from commit be4e1141be7cd54cf5362d3de534050db5505437) Reviewed-on: https://gerrit.libreoffice.org/17199 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-2.tiff b/filter/qa/cppunit/data/tiff/fail/crash-2.tiff new file mode 100644 index 000..aadd99f Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-2.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index 834c437..4599af9 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -608,6 +608,8 @@ bool TIFFReader::ReadMap() pTIFF-Seek( pStripOffsets[ nStrip ] ); aCCIDecom.StartDecompression( *pTIFF ); } +if (np = SAL_N_ELEMENTS(pMap)) +return false; if ( !aCCIDecom.DecompressScanline( pMap[ np ], nImageWidth * nBitsPerSample * nSamplesPerPixel / nPlanes, np + 1 == nPlanes ) ) return false; if ( pTIFF-GetError() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-3.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit e9be8b2425eb8e013e43ef7e730a05df5e4efae9 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 19 21:32:05 2015 +0100 check np bounds again Change-Id: I0fb61954b2eaf0c015d7bdefe9f03bd459b31501 (cherry picked from commit fcdddbd30a8b5cf6a5cc4d2ff28b7d4a20f8ec6b) Reviewed-on: https://gerrit.libreoffice.org/17201 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-3.tiff b/filter/qa/cppunit/data/tiff/fail/crash-3.tiff new file mode 100644 index 000..4aa2393 Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-3.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index aed15f6..834c437 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -638,6 +638,8 @@ bool TIFFReader::ReadMap() pTIFF-Seek(pStripOffsets[nStrip]); aLZWDecom.StartDecompression(*pTIFF); } +if (np = SAL_N_ELEMENTS(pMap)) +return false; if ( ( aLZWDecom.Decompress( pMap[ np ], nBytesPerRow ) != nBytesPerRow ) || pTIFF-GetError() ) return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/inc chart2/source
chart2/inc/ChartModel.hxx |5 - chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx |9 - chart2/source/controller/chartapiwrapper/DiagramWrapper.hxx |2 chart2/source/controller/dialogs/DataBrowser.cxx|5 - chart2/source/controller/dialogs/DataBrowser.hxx|2 chart2/source/controller/dialogs/DialogModel.hxx|2 chart2/source/controller/dialogs/tp_3D_SceneGeometry.hxx|1 chart2/source/controller/dialogs/tp_DataSource.hxx |4 chart2/source/controller/inc/ChartController.hxx|6 - chart2/source/controller/inc/ChartDocumentWrapper.hxx |5 - chart2/source/controller/inc/dlg_CreationWizard_UNO.hxx |5 - chart2/source/controller/inc/dlg_DataEditor.hxx |2 chart2/source/controller/main/ChartFrameloader.hxx |5 - chart2/source/controller/main/ElementSelector.hxx |5 - chart2/source/inc/CachedDataSequence.hxx|6 - chart2/source/inc/ConfigColorScheme.hxx |6 - chart2/source/inc/DataSource.hxx|6 - chart2/source/inc/DataSourceHelper.hxx |5 - chart2/source/inc/ErrorBar.hxx | 18 --- chart2/source/inc/InternalDataProvider.hxx |5 - chart2/source/inc/LabeledDataSequence.hxx |6 - chart2/source/inc/Scaling.hxx | 24 chart2/source/inc/chartview/DrawModelWrapper.hxx|4 chart2/source/model/inc/CartesianCoordinateSystem.hxx | 12 -- chart2/source/model/inc/ChartTypeManager.hxx|7 - chart2/source/model/inc/DataSeries.hxx |6 - chart2/source/model/inc/Diagram.hxx |7 - chart2/source/model/inc/PolarCoordinateSystem.hxx | 12 -- chart2/source/model/inc/XMLFilter.hxx | 13 -- chart2/source/model/main/Axis.hxx |6 - chart2/source/model/main/FormattedString.hxx|6 - chart2/source/model/main/GridProperties.hxx |7 - chart2/source/model/main/Legend.hxx |7 - chart2/source/model/main/PageBackground.hxx |7 - chart2/source/model/main/Title.hxx |7 - chart2/source/model/template/AreaChartType.hxx |7 - chart2/source/model/template/BarChartType.hxx |7 - chart2/source/model/template/BubbleChartType.hxx|7 - chart2/source/model/template/CandleStickChartType.hxx |7 - chart2/source/model/template/ColumnChartType.hxx|7 - chart2/source/model/template/FilledNetChartType.hxx |7 - chart2/source/model/template/GL3DBarChartType.hxx |6 - chart2/source/model/template/LineChartType.hxx |7 - chart2/source/model/template/NetChartType.hxx |7 - chart2/source/model/template/PieChartType.hxx |7 - chart2/source/model/template/ScatterChartType.hxx |7 - chart2/source/tools/ErrorBar.cxx| 15 --- chart2/source/tools/RegressionCurveModel.hxx| 42 chart2/source/tools/RegressionEquation.hxx |6 - chart2/source/view/axes/Tickmarks_Equidistant.hxx |2 chart2/source/view/charttypes/AreaChart.cxx | 10 -- chart2/source/view/charttypes/AreaChart.hxx |1 chart2/source/view/charttypes/BarChart.cxx |5 - chart2/source/view/charttypes/BarChart.hxx |1 chart2/source/view/charttypes/NetChart.cxx |5 - chart2/source/view/charttypes/NetChart.hxx |1 chart2/source/view/charttypes/PieChart.cxx |7 - chart2/source/view/charttypes/PieChart.hxx |1 chart2/source/view/charttypes/VSeriesPlotter.cxx|5 - chart2/source/view/inc/3DChartObjects.hxx |4 chart2/source/view/inc/GL3DBarChart.hxx |1 chart2/source/view/inc/Stripe.hxx |5 - chart2/source/view/inc/VSeriesPlotter.hxx |1 chart2/source/view/main/DrawModelWrapper.cxx| 49
[Libreoffice-commits] core.git: compilerplugins/clang editeng/source include/editeng include/svl svl/source
compilerplugins/clang/unusedmethods.cxx |9 +
compilerplugins/clang/unusedmethods.py | 35 +-
editeng/source/items/xmlcnitm.cxx |7
include/editeng/xmlcnitm.hxx|2 -
include/svl/cintitem.hxx| 12 ---
include/svl/ctypeitm.hxx|2 -
include/svl/custritm.hxx|2 -
include/svl/documentlockfile.hxx|3 -
include/svl/eitem.hxx |3 -
include/svl/int64item.hxx |2 -
include/svl/intitem.hxx |3 -
include/svl/poolitem.hxx|1
include/svl/style.hxx |3 -
include/svl/visitem.hxx |3 -
svl/source/items/cenumitm.cxx |8 -
svl/source/items/cintitem.cxx | 49
svl/source/items/custritm.cxx | 11 ---
svl/source/items/int64item.cxx | 13
svl/source/items/intitem.cxx| 12 ---
svl/source/items/poolitem.cxx |6 ---
svl/source/items/visitem.cxx|8 -
21 files changed, 35 insertions(+), 159 deletions(-)
New commits:
commit 9f4f237a3834e5d58a87296424db5428f68d1550
Author: Noel Grandin n...@peralex.com
Date: Fri Jul 17 13:08:16 2015 +0200
loplugin:unusedmethods svl
Change-Id: If86cc43fda4d138cf7f678d81fa2b35f68f3c03b
Reviewed-on: https://gerrit.libreoffice.org/17162
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/compilerplugins/clang/unusedmethods.cxx
b/compilerplugins/clang/unusedmethods.cxx
index a137a21..6627fe9 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -124,12 +124,19 @@ static bool startsWith(const std::string s, const char*
other)
return s.compare(0, strlen(other), other) == 0;
}
-static bool isStandardStuff(const std::string s)
+static bool isStandardStuff(const std::string input)
{
+std::string s = input;
+if (startsWith(s,class ))
+s = s.substr(6);
+else if (startsWith(s,struct ))
+s = s.substr(7);
// ignore UNO interface definitions, cannot change those
return startsWith(s, com::sun::star::)
// ignore stuff in the C++ stdlib and boost
|| startsWith(s, std::) || startsWith(s, boost::) ||
startsWith(s, class boost::) || startsWith(s, __gnu_debug::)
+ // external library
+ || startsWith(s, mdds::)
// can't change our rtl layer
|| startsWith(s, rtl::)
// ignore anonymous namespace stuff, it is compilation-unit-local
and the compiler will detect any
diff --git a/compilerplugins/clang/unusedmethods.py
b/compilerplugins/clang/unusedmethods.py
index 2790408..27118b2 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -57,6 +57,7 @@ exclusionSet = set([
# instantiated from templates, not sure why it is not being picked up
class basegfx::B2DPolygon OutputDevice::PixelToLogic(const class
basegfx::B2DPolygon ,const class MapMode ) const,
type-parameter-0-0 * detail::cloner::clone(type-parameter-0-0 *const),
+const class rtl::OUString writerperfect::DocumentHandlerFor::name(),
# only used by OSX build
void StyleSettings::SetHideDisabledMenuItems(_Bool),
])
@@ -87,20 +88,38 @@ for clazz in sorted(definitionSet - callSet - exclusionSet):
or (clazz.find(::Type()) != -1)):
continue
# if this method is const, and there is a non-const variant of it, and the
non-const variant is in use, then leave it alone
-if (clazz.endswith( const)
-and clazz[6:len(clazz)-6] in definitionSet
-and clazz[6:len(clazz)-6] in callSet):
- continue
+if (clazz.startswith(const ) and clazz.endswith( const)):
+clazz2 = clazz[6:len(clazz)-12]
+if (clazz2 in callSet):
+ continue
+elif (clazz.endswith( const)):
+clazz2 = clazz[:len(clazz)-6]
+if (clazz2 in callSet):
+ continue
+if (clazz.endswith( const) and clazz.find(::iterator) != -1):
+clazz2 = clazz.replace(::const_iterator, ::iterator)
+clazz2 = clazz2[:len(clazz)-6] # strip off const
+if (clazz2 in callSet):
+ continue
# if this method is non-const, and there is a const variant of it, and the
const variant is in use, then leave it alone
-if ((not clazz.endswith( const))
-and (const + clazz + const) in definitionSet
-and (const + clazz + const) in callSet):
+if ((not clazz.endswith( const)) and (const + clazz + const) in
callSet):
continue
+if ((not clazz.endswith( const)) and clazz.find(::iterator) != -1):
+clazz2 = clazz.replace(::iterator, ::const_iterator) + const
+if (clazz2 in callSet):
+ continue
# There is lots of macro magic
[Libreoffice-bugs] [Bug 92837] New: Opening a ODS file asks to update external links even if in the options is marked as always update
https://bugs.documentfoundation.org/show_bug.cgi?id=92837 Bug ID: 92837 Summary: Opening a ODS file asks to update external links even if in the options is marked as always update Product: LibreOffice Version: 5.0.0.0.beta3 Hardware: x86 (IA32) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: roby...@gmail.com Opening a ODS file asks to update external links even if in the options is marked as always update -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92789] FILEOPEN embedded graphic of format pct is not displayed.
https://bugs.documentfoundation.org/show_bug.cgi?id=92789 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED CC||dtar...@redhat.com Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |alo...@loria.fr |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - filter/qa filter/source
filter/qa/cppunit/data/pict/pass/tdf92789.pct |binary
filter/source/graphicfilter/ipict/ipict.cxx | 60 ++
2 files changed, 24 insertions(+), 36 deletions(-)
New commits:
commit 3f0677b86f4831b011a2baece85cf93c68646cd5
Author: David Tardon dtar...@redhat.com
Date: Mon Jul 20 08:50:20 2015 +0200
add a test image
Change-Id: Ibd30ddc9c4a0e1ca440d0b62635cfab3f3ab8235
diff --git a/filter/qa/cppunit/data/pict/pass/tdf92789.pct
b/filter/qa/cppunit/data/pict/pass/tdf92789.pct
new file mode 100644
index 000..2d6f0d8
Binary files /dev/null and b/filter/qa/cppunit/data/pict/pass/tdf92789.pct
differ
commit 5fa73031aa42b62ccd167f193376565df2e635fc
Author: osnola alo...@loria.fr
Date: Mon Jul 20 08:49:59 2015 +0200
tdf92789 fix reading of some PICT images
Change-Id: I24498bc6f316e5522e716184fb8b2e17bcd76226
diff --git a/filter/source/graphicfilter/ipict/ipict.cxx
b/filter/source/graphicfilter/ipict/ipict.cxx
index 0c1960b..327b7aa0 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -879,7 +879,7 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap, bool
bBaseAddr, bool bColo
}
else
{
-nCount = static_castsal_uInt16( 1 - ( (
(sal_uInt16)nFlagCounterByte ) | 0xff00 ) );
+nCount = static_castsal_uInt16( 1 - sal_Int16( (
(sal_uInt16)nFlagCounterByte ) | 0xff00 ) );
pPict-ReadUChar( nDat );
for ( i = 0; i nCount; i++ )
{
@@ -901,21 +901,10 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap,
bool bBaseAddr, bool bColo
if (nWidth nRowBytes / 2)
BITMAPERROR;
-size_t nMinRecordSize;
-if ( nRowBytes 8 || nPackType == 1 )
-nMinRecordSize = sizeof(sal_uInt16);
-else if ( nRowBytes 250 )
-nMinRecordSize = sizeof(sal_uInt16);
-else
-nMinRecordSize = 1;
-
-const size_t nMinRowWidth = nWidth * nMinRecordSize;
-const size_t nMaxRows = pPict-remainingSize() / nMinRowWidth;
-if (nHeight nMaxRows)
-BITMAPERROR;
-const size_t nMaxCols = pPict-remainingSize() / nHeight;
-if (nWidth nMaxCols)
-BITMAPERROR;
+if ( nRowBytes 8 || nPackType == 1 ) {
+if (pPict-remainingSize() sizeof(sal_uInt16) * nHeight * nWidth)
+BITMAPERROR;
+}
for ( ny = 0; ny nHeight; ny++ )
{
@@ -952,10 +941,17 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap,
bool bBaseAddr, bool bColo
if ( (nFlagCounterByte 0x80) == 0)
{
nCount=((sal_uInt16)nFlagCounterByte)+1;
-if ( nCount + nx nWidth) // SJ: the RLE
decoding seems not to be correct here,
-nCount = nWidth - nx; // I don't
want to change this until I have a bugdoc for
-for (i=0; inCount; i++)// this case.
Have a look at 32bit, there I changed the
-{ // encoding,
so that it is used a straight forward array
+if ( nCount + nx nWidth)
+nCount = nWidth - nx;
+if (pPict-remainingSize() sizeof(sal_uInt16) *
nCount)
+BITMAPERROR;
+/* SJ: the RLE decoding seems not to be correct here,
+ I don't want to change this until I have a bugdoc
for
+ this case. Have a look at 32bit, there I changed the
+ encoding, so that it is used a straight forward
array
+ */
+for (i=0; inCount; i++)
+{
pPict-ReadUInt16( nD );
nRed = (sal_uInt8)( nD 7 );
nGreen = (sal_uInt8)( nD 2 );
@@ -965,7 +961,9 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap, bool
bBaseAddr, bool bColo
}
else
{
-nCount=(1-(((sal_uInt16)nFlagCounterByte)|0xff00));
+if (pPict-remainingSize() sizeof(sal_uInt16))
+BITMAPERROR;
+
nCount=(1-sal_Int16(((sal_uInt16)nFlagCounterByte)|0xff00));
if ( nCount + nx nWidth )
nCount = nWidth - nx;
pPict-ReadUInt16( nD );
@@ -1039,20 +1037,6 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap,
bool bBaseAddr, bool bColo
{
if ( ( nCmpCount == 3 ) || ( nCmpCount == 4 ) )
{
-size_t
[Libreoffice-commits] core.git: filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-4.tiff |binary
filter/source/graphicfilter/itiff/ccidecom.cxx |9 ++---
2 files changed, 2 insertions(+), 7 deletions(-)
New commits:
commit 5d32a4ac5c166264c2d44e8df625eb768eb42fbe
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:35:26 2015 +0100
reduce scope, etc, don't loop endlessly
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
new file mode 100644
index 000..ef0fe27
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/ccidecom.cxx
b/filter/source/graphicfilter/itiff/ccidecom.cxx
index 892f247..2f76777 100644
--- a/filter/source/graphicfilter/itiff/ccidecom.cxx
+++ b/filter/source/graphicfilter/itiff/ccidecom.cxx
@@ -628,8 +628,6 @@ void CCIDecompressor::StartDecompression( SvStream
rIStream )
bool CCIDecompressor::DecompressScanline( sal_uInt8 * pTarget, sal_uLong
nTargetBits, bool bLastLine )
{
-sal_uInt16 i;
-sal_uInt8 * pDst;
bool b2D;
if ( nEOLCount = 5 ) // RTC (Return To Controller)
@@ -678,8 +676,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
delete[] pLastLine;
nLastLineSize = ( nTargetBits + 7 ) 3;
pLastLine = new sal_uInt8[ nLastLineSize ];
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *( pDst++ ) = 0x00;
+memset(pLastLine, 0, nLastLineSize);
}
}
// conditionally align start of line to next byte:
@@ -706,9 +703,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
// if we're in 2D mode we have to remember the line:
if ( nOptions CCI_OPTION_2D bStatus )
{
-sal_uInt8 *pSrc = pTarget;
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *(pDst++)=*(pSrc++);
+memcpy(pLastLine, pTarget, nLastLineSize);
}
// #i122984#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75154] FILEOPEN: DOC Wrong positioning of text alongside text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=75154 --- Comment #6 from mloc postmas...@mlrennes.org --- Bug is still present in version 4.4.4.3 (Windows 7x64). No apparent difference. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libreoffice-design] Re: [GSoC] Improve user experience with CMIS –Weekly report #6
On Mon, 2015-07-20 at 07:06 +, Heiko Tietze wrote: Can we get a screenshot? Or is it implemented in the nightlies? It looks like the daily build are fresh enough to include Szymon's patches. Have a go at them, if it's still not included, then it'll come someday soon. -- Cedric Am 20.07.2015 08:32:49, schrieb Jan Holesovsky: * [to be discussed in with the UX/Design team] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - fpicker/source
fpicker/source/office/RemoteFilesDialog.cxx | 64 ++--
1 file changed, 52 insertions(+), 12 deletions(-)
New commits:
commit 5834cf9a85b3e18d9a601f6a02ba4fac9935e61b
Author: Szymon KÅos eszka...@gmail.com
Date: Mon Jul 20 10:04:09 2015 +0200
accessibility: correct tab-order
Change-Id: Ib554e8bb73367d5f85253f0deb083fbc5a5d454b
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index da25b9d..913f4f4 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -11,13 +11,22 @@
class FileViewContainer : public vcl::Window
{
+enum FocusState
+{
+Prev = 0,
+TreeView,
+FileView,
+Next,
+FocusCount
+};
+
private:
VclPtr SvtFileView m_pFileView;
VclPtr FolderTree m_pTreeView;
VclPtr Splitter m_pSplitter;
int m_nCurrentFocus;
-VclPtrvcl::Window m_pFocusWidgets[4];
+VclPtrvcl::Window m_pFocusWidgets[FocusState::FocusCount];
public:
FileViewContainer( vcl::Window *pParent )
@@ -50,10 +59,10 @@ class FileViewContainer : public vcl::Window
m_pFileView = pFileView;
m_pTreeView = pTreeView;
m_pSplitter = pSplitter;
-m_pFocusWidgets[0] = pPrevSibling;
-m_pFocusWidgets[1] = pTreeView;
-m_pFocusWidgets[2] = pFileView;
-m_pFocusWidgets[3] = pNextSibling;
+m_pFocusWidgets[FocusState::Prev] = pPrevSibling;
+m_pFocusWidgets[FocusState::TreeView] = pTreeView;
+m_pFocusWidgets[FocusState::FileView] = pFileView;
+m_pFocusWidgets[FocusState::Next] = pNextSibling;
}
virtual void Resize() SAL_OVERRIDE
@@ -88,14 +97,20 @@ class FileViewContainer : public vcl::Window
if( !m_pFileView || !m_pTreeView )
return;
-if( !bReverse m_nCurrentFocus 4 )
+if( bReverse m_nCurrentFocus FocusState::Prev m_nCurrentFocus
= FocusState::Next )
{
-m_pFocusWidgets[++m_nCurrentFocus]-SetFakeFocus( true );
+m_pFocusWidgets[m_nCurrentFocus]-SetFakeFocus(false);
+m_pFocusWidgets[m_nCurrentFocus]-LoseFocus();
+
+m_pFocusWidgets[--m_nCurrentFocus]-SetFakeFocus( true );
m_pFocusWidgets[m_nCurrentFocus]-GrabFocus();
}
-else if( m_nCurrentFocus 0 )
+else if( !bReverse m_nCurrentFocus = FocusState::Prev
m_nCurrentFocus FocusState::Next )
{
-m_pFocusWidgets[--m_nCurrentFocus]-SetFakeFocus( true );
+m_pFocusWidgets[m_nCurrentFocus]-SetFakeFocus(false);
+m_pFocusWidgets[m_nCurrentFocus]-LoseFocus();
+
+m_pFocusWidgets[++m_nCurrentFocus]-SetFakeFocus( true );
m_pFocusWidgets[m_nCurrentFocus]-GrabFocus();
}
}
@@ -105,13 +120,38 @@ class FileViewContainer : public vcl::Window
if( !m_pFileView || !m_pTreeView )
return;
-m_nCurrentFocus = 1;
-m_pFocusWidgets[m_nCurrentFocus]-SetFakeFocus( true );
-m_pFocusWidgets[m_nCurrentFocus]-GrabFocus();
+GetFocusFlags aFlags = GetGetFocusFlags();
+
+if( aFlags GetFocusFlags::Forward )
+m_nCurrentFocus = FocusState::TreeView;
+else if( aFlags GetFocusFlags::Backward )
+m_nCurrentFocus = FocusState::FileView;
+
+if( m_nCurrentFocus = FocusState::Prev m_nCurrentFocus =
FocusState::Next )
+{
+m_pFocusWidgets[m_nCurrentFocus]-SetFakeFocus( true );
+m_pFocusWidgets[m_nCurrentFocus]-GrabFocus();
+}
}
virtual bool Notify( NotifyEvent rNEvt ) SAL_OVERRIDE
{
+if( rNEvt.GetType() == MouseNotifyEvent::GETFOCUS )
+{
+// we must also update counter when user change focus using mouse
+for(int i = FocusState::Prev; i = FocusState::Next; i++)
+{
+if( rNEvt.GetWindow() == m_pFocusWidgets[i] )
+{
+m_nCurrentFocus = i;
+return true;
+}
+}
+
+// GETFOCUS for one of FileView's subcontrols
+m_nCurrentFocus = FocusState::FileView;
+return true;
+}
if( rNEvt.GetType() == MouseNotifyEvent::KEYINPUT )
{
const KeyEvent* pKeyEvent = rNEvt.GetKeyEvent();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92736] Toolbar: make cell border attributes easier to set and understand at a glance
https://bugs.documentfoundation.org/show_bug.cgi?id=92736 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92736] Toolbar: make cell border attributes easier to set and understand at a glance
https://bugs.documentfoundation.org/show_bug.cgi?id=92736 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|Toolbar: To format cell |Toolbar: make cell border |border attributes is a |attributes easier to set |little complicated |and understand at a glance -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92766] EDITING : Firebird Embedded database choice not available when Enable experiment feature switch is ON (Win64 bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=92766 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- This requires someone from QA with a Win64 bit LO to test and confirm. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basegfx/source
basegfx/source/polygon/b2dlinegeometry.cxx | 12 +--
basegfx/source/polygon/b2dpolygontools.cxx | 80 -
basegfx/source/polygon/b2dpolypolygontools.cxx | 26
basegfx/source/polygon/b3dpolypolygontools.cxx | 18 ++---
basegfx/source/tools/canvastools.cxx |2
basegfx/source/tools/keystoplerp.cxx |2
6 files changed, 70 insertions(+), 70 deletions(-)
New commits:
commit 852ae6dea4156955444dc469943dd1bbd446d452
Author: Noel Grandin n...@peralex.com
Date: Fri Jul 17 16:15:23 2015 +0200
com::sun::star-css in basegfx
Change-Id: I27f28e6a09e8bc9e90f0b60a7ac8519b2ab41860
Reviewed-on: https://gerrit.libreoffice.org/17166
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/basegfx/source/polygon/b2dlinegeometry.cxx
b/basegfx/source/polygon/b2dlinegeometry.cxx
index 4cccf1d..c259fef 100644
--- a/basegfx/source/polygon/b2dlinegeometry.cxx
+++ b/basegfx/source/polygon/b2dlinegeometry.cxx
@@ -783,7 +783,7 @@ namespace basegfx
const B2DPolygon rCandidate,
double fHalfLineWidth,
B2DLineJoin eJoin,
-com::sun::star::drawing::LineCap eCap,
+css::drawing::LineCap eCap,
double fMaxAllowedAngle,
double fMaxPartOfEdge,
double fMiterMinimumAngle)
@@ -828,7 +828,7 @@ namespace basegfx
B2DPolyPolygon aRetval;
const bool bIsClosed(aCandidate.isClosed());
const sal_uInt32 nEdgeCount(bIsClosed ? nPointCount :
nPointCount - 1);
-const bool bLineCap(!bIsClosed
com::sun::star::drawing::LineCap_BUTT != eCap);
+const bool bLineCap(!bIsClosed css::drawing::LineCap_BUTT
!= eCap);
if(nEdgeCount)
{
@@ -926,10 +926,10 @@ namespace basegfx
createAreaGeometryForEdge(
aEdge,
fHalfLineWidth,
-bFirst
com::sun::star::drawing::LineCap_ROUND == eCap,
-bLast
com::sun::star::drawing::LineCap_ROUND == eCap,
-bFirst
com::sun::star::drawing::LineCap_SQUARE == eCap,
-bLast
com::sun::star::drawing::LineCap_SQUARE == eCap));
+bFirst css::drawing::LineCap_ROUND ==
eCap,
+bLast css::drawing::LineCap_ROUND ==
eCap,
+bFirst css::drawing::LineCap_SQUARE ==
eCap,
+bLast css::drawing::LineCap_SQUARE ==
eCap));
}
else
{
diff --git a/basegfx/source/polygon/b2dpolygontools.cxx
b/basegfx/source/polygon/b2dpolygontools.cxx
index 8b31f7a..3c63441 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -3306,10 +3306,10 @@ namespace basegfx
return aRetval;
}
-// converters for com::sun::star::drawing::PointSequence
+// converters for css::drawing::PointSequence
B2DPolygon UnoPointSequenceToB2DPolygon(
-const com::sun::star::drawing::PointSequence rPointSequenceSource,
+const css::drawing::PointSequence rPointSequenceSource,
bool bCheckClosed)
{
B2DPolygon aRetval;
@@ -3318,8 +3318,8 @@ namespace basegfx
if(nLength)
{
aRetval.reserve(nLength);
-const com::sun::star::awt::Point* pArray =
rPointSequenceSource.getConstArray();
-const com::sun::star::awt::Point* pArrayEnd = pArray +
rPointSequenceSource.getLength();
+const css::awt::Point* pArray =
rPointSequenceSource.getConstArray();
+const css::awt::Point* pArrayEnd = pArray +
rPointSequenceSource.getLength();
for(;pArray != pArrayEnd; pArray++)
{
@@ -3338,7 +3338,7 @@ namespace basegfx
void B2DPolygonToUnoPointSequence(
const B2DPolygon rPolygon,
-com::sun::star::drawing::PointSequence rPointSequenceRetval)
+css::drawing::PointSequence rPointSequenceRetval)
{
B2DPolygon aPolygon(rPolygon);
@@ -3358,12 +3358,12 @@ namespace basegfx
const bool bIsClosed(aPolygon.isClosed());
rPointSequenceRetval.realloc(bIsClosed ? nPointCount + 1 :
nPointCount);
-com::sun::star::awt::Point* pSequence =
rPointSequenceRetval.getArray();
+css::awt::Point* pSequence = rPointSequenceRetval.getArray();
for(sal_uInt32 b(0); b nPointCount; b++)
{
const B2DPoint
[Libreoffice-bugs] [Bug 92836] New: Formatting: Page grid layout function doesn't correctly dispatch a character in a grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92836 Bug ID: 92836 Summary: Formatting: Page grid layout function doesn't correctly dispatch a character in a grid cell Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ichiro.ma...@gmail.com Created attachment 117335 -- https://bugs.documentfoundation.org/attachment.cgi?id=117335action=edit It shows how it looks. Using Japanese characters. Reproduction Procedure: 1. open LibreOfficePreferences...LibreOffice WriterGeneral 2. check the Use square page mode for text grid checkbox 3. open FormatPage...Page tab 4. set Orientation in Page Format to Landscape 5. set Text Direction in Page Format to Right-to-left (vertical) 6. apply those changes and move to Text Grid tab 7. set Grid in Text Grid to Grid (lines and characters) 8. if there is a Snap to characters checkbox, check it. This checkbox does not always appear. 9. press OK to return to document window Experienced behavior: A line of characters ignores grid cells. Expected behavior: Each grid cell has one character. Additional information: I found the Snap to grid checkbox in LibreOfficePreferences...LibreOffice WriterGrid, but I cannot find any difference regarding the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: comphelper/inc comphelper/qa comphelper/source desktop/source include/comphelper sfx2/source
comphelper/inc/pch/precompiled_comphelper.hxx |5 --- comphelper/qa/string/test_string.cxx |6 ++-- comphelper/source/compare/AnyCompareFactory.cxx |7 ++--- comphelper/source/container/IndexedPropertyValuesContainer.cxx|4 +-- comphelper/source/container/NamedPropertyValuesContainer.cxx |4 +-- comphelper/source/container/enumerablemap.cxx |6 ++-- comphelper/source/container/namecontainer.cxx |4 +-- comphelper/source/eventattachermgr/eventattachermgr.cxx |7 ++--- comphelper/source/misc/accessiblekeybindinghelper.cxx |3 -- comphelper/source/misc/docpasswordrequest.cxx |5 ++- comphelper/source/misc/documentiologring.hxx |4 +-- comphelper/source/misc/instancelocker.hxx |7 ++--- comphelper/source/misc/officerestartmanager.hxx |4 +-- comphelper/source/misc/servicedecl.cxx|4 +-- comphelper/source/officeinstdir/officeinstallationdirectories.hxx |4 +-- comphelper/source/streaming/memorystream.cxx |6 ++-- comphelper/source/streaming/seqinputstreamserv.cxx|4 +-- comphelper/source/streaming/seqoutputstreamserv.cxx |4 +-- desktop/source/deployment/manager/dp_informationprovider.cxx |4 +-- include/comphelper/ChainablePropertySetInfo.hxx |4 +-- include/comphelper/MasterPropertySetInfo.hxx |4 +-- include/comphelper/SelectionMultiplex.hxx |4 +-- include/comphelper/SettingsHelper.hxx |4 +-- include/comphelper/accessiblekeybindinghelper.hxx |6 ++-- include/comphelper/accessiblewrapper.hxx | 11 +++- include/comphelper/attributelist.hxx |4 +-- include/comphelper/containermultiplexer.hxx |4 +-- include/comphelper/docpasswordrequest.hxx |6 ++-- include/comphelper/enumhelper.hxx | 13 -- include/comphelper/evtlistenerhlp.hxx |4 +-- include/comphelper/interaction.hxx|8 +++--- include/comphelper/numberedcollection.hxx |4 +-- include/comphelper/ofopxmlhelper.hxx |4 +-- include/comphelper/oslfile2streamwrap.hxx |6 ++-- include/comphelper/propertysetinfo.hxx|4 +-- include/comphelper/propmultiplex.hxx |4 +-- include/comphelper/seekableinput.hxx |4 +-- include/comphelper/seqstream.hxx |7 ++--- include/comphelper/servicedecl.hxx| 10 +++ include/comphelper/unique_disposing_ptr.hxx |4 +-- include/comphelper/weakeventlistener.hxx |6 ++-- sfx2/source/appl/appuno.cxx |5 ++- sfx2/source/inc/fltoptint.hxx |3 +- 43 files changed, 109 insertions(+), 116 deletions(-) New commits: commit a890a7696ff5dfc3ec8a012ba59cc04db4a1473d Author: Takeshi Abe t...@fixedpoint.jp Date: Fri Jul 10 17:50:12 2015 +0900 tdf#88206 replace cppu::WeakImplHelper* etc. with the variadic variants, for comphelper. This also includes extra changes in other modules required accordingly. Change-Id: Id1537f46f1c90f760a0d8987a6dafa0e1da03b8f Reviewed-on: https://gerrit.libreoffice.org/16929 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/comphelper/inc/pch/precompiled_comphelper.hxx b/comphelper/inc/pch/precompiled_comphelper.hxx index d0de0e3..35bdc06 100644 --- a/comphelper/inc/pch/precompiled_comphelper.hxx +++ b/comphelper/inc/pch/precompiled_comphelper.hxx @@ -177,10 +177,7 @@ #include cppuhelper/compbase3.hxx #include cppuhelper/exc_hlp.hxx #include cppuhelper/factory.hxx -#include cppuhelper/implbase1.hxx -#include cppuhelper/implbase2.hxx -#include cppuhelper/implbase3.hxx -#include cppuhelper/implbase4.hxx +#include cppuhelper/implbase.hxx #include cppuhelper/implementationentry.hxx #include cppuhelper/interfacecontainer.h #include cppuhelper/interfacecontainer.hxx diff --git a/comphelper/qa/string/test_string.cxx b/comphelper/qa/string/test_string.cxx index 8971a43..478c0fb 100644 --- a/comphelper/qa/string/test_string.cxx +++ b/comphelper/qa/string/test_string.cxx @@ -18,7 +18,7 @@ */ #include comphelper/string.hxx -#include cppuhelper/implbase1.hxx +#include cppuhelper/implbase.hxx #include
[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a890a7696ff5dfc3ec8a012ba59cc04db4a1473d tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a890a7696ff5dfc3ec8a012ba59cc04db4a1473d tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92766] Can't select and create Firebird Embedded: on condition that Enable experiment feature switch on option set ON.
https://bugs.documentfoundation.org/show_bug.cgi?id=92766 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- Can't confirm on OSX either. Win64 only ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92027] Hyperlink: No right click option for the selected word
https://bugs.documentfoundation.org/show_bug.cgi?id=92027 --- Comment #6 from Heiko Tietze heiko.tie...@user-prompt.com --- (In reply to ELSUPREMO1 from comment #5) Hyperlinks are used more often in documents than the others mentioned below (i.e.tables, special characters, or formulas). Do you have data to support this statement, or is it your opinion resp. personal workflow? In this case I'd be interested in the use-case because it's hard to figure what hyperlinks are good for beyond HTML export. And there are much better tools to create websites. BTW: When I look through references about Microsoft Office and hyperlink it turns out that it is used fot writing emails. AFAIR outlook has an option to edit with Word. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92027] Hyperlink: No right click option for the selected word
https://bugs.documentfoundation.org/show_bug.cgi?id=92027 --- Comment #6 from Heiko Tietze heiko.tie...@user-prompt.com --- (In reply to ELSUPREMO1 from comment #5) Hyperlinks are used more often in documents than the others mentioned below (i.e.tables, special characters, or formulas). Do you have data to support this statement, or is it your opinion resp. personal workflow? In this case I'd be interested in the use-case because it's hard to figure what hyperlinks are good for beyond HTML export. And there are much better tools to create websites. BTW: When I look through references about Microsoft Office and hyperlink it turns out that it is used fot writing emails. AFAIR outlook has an option to edit with Word. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 41921] comment is hidden by selection block when copy/pasting
https://bugs.documentfoundation.org/show_bug.cgi?id=41921 --- Comment #7 from Winfried Donkers winfrieddonk...@libreoffice.org --- Still present with version 4.4.4.3 (Windows7) as well as with 5.1.0.0.alpha1+ (pulled last week) on openSUSE13.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-2.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit eef542a9ff26856a52a80f413173e754c4960e42 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 19 21:25:46 2015 +0100 check np bounds (cherry picked from commit be4e1141be7cd54cf5362d3de534050db5505437) Change-Id: Id16ae9325f3c67792941b9c88d83435aa98282ca Reviewed-on: https://gerrit.libreoffice.org/17200 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-2.tiff b/filter/qa/cppunit/data/tiff/fail/crash-2.tiff new file mode 100644 index 000..aadd99f Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-2.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index 6d1be66..dc556f3 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -619,6 +619,8 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong nMaxPercent ) pTIFF-Seek( pStripOffsets[ nStrip ] ); aCCIDecom.StartDecompression( *pTIFF ); } +if (np = SAL_N_ELEMENTS(pMap)) +return false; if ( aCCIDecom.DecompressScanline( pMap[ np ], nImageWidth * nBitsPerSample * nSamplesPerPixel / nPlanes, np + 1 == nPlanes ) == false ) return false; if ( pTIFF-GetError() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-3.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit ffed84552dcb03daf93e14036313bad285c3d140 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 19 21:32:05 2015 +0100 check np bounds again Change-Id: I0fb61954b2eaf0c015d7bdefe9f03bd459b31501 (cherry picked from commit fcdddbd30a8b5cf6a5cc4d2ff28b7d4a20f8ec6b) Reviewed-on: https://gerrit.libreoffice.org/17202 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-3.tiff b/filter/qa/cppunit/data/tiff/fail/crash-3.tiff new file mode 100644 index 000..4aa2393 Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-3.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index dc556f3..c35d943 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -652,6 +652,8 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong nMaxPercent ) pTIFF-Seek(pStripOffsets[nStrip]); aLZWDecom.StartDecompression(*pTIFF); } +if (np = SAL_N_ELEMENTS(pMap)) +return false; if ( ( aLZWDecom.Decompress( pMap[ np ], nBytesPerRow ) != nBytesPerRow ) || pTIFF-GetError() ) return false; MayCallback(nMinPercent+(nMaxPercent-nMinPercent)*(np*nImageLength+ny)/(nImageLength*nPlanes)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92791] L.O. automatic update
https://bugs.documentfoundation.org/show_bug.cgi?id=92791 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Component|Base|Installation -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92831] Sidebar interferes with scrollbar.
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #3 from Stefan Knorr (astron) heinzless...@gmail.com --- Infinite size refers to the fact that if you go to the edge of the screen, you can't get any further -- so no matter how much further you physically fling your mouse, you can't miss an item that is to that side of the screen. This is also called Fitts's Law, as Jiggle said in comment 0. Fitts's Law is commonly applied to important user interfaces items: the Mac OS menu bar, the Windows Start button, the X button of fullscreen windows on Windows. (You may notice that even while the graphic design of these items makes them seem as if they don't extend to the edge of the screen, their clickable area actually does. (The exception here is the Windows 95/98 start menu: it does not respect Fitts's Law.)) In any case, scrollbars have been becoming less important for actual manipulation since the advent of the mouse wheel, touchpad scrolling and outright touchscreen. Now, in many cases they are rather used as indicators. The proposed solution also seems to put cart before the horse: Instead of putting an item that has been on the right ~forever on the left (the scrollbar), it may be a better idea to rethink the position of the sidebar. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92831] Sidebar interferes with scrollbar.
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #3 from Stefan Knorr (astron) heinzless...@gmail.com --- Infinite size refers to the fact that if you go to the edge of the screen, you can't get any further -- so no matter how much further you physically fling your mouse, you can't miss an item that is to that side of the screen. This is also called Fitts's Law, as Jiggle said in comment 0. Fitts's Law is commonly applied to important user interfaces items: the Mac OS menu bar, the Windows Start button, the X button of fullscreen windows on Windows. (You may notice that even while the graphic design of these items makes them seem as if they don't extend to the edge of the screen, their clickable area actually does. (The exception here is the Windows 95/98 start menu: it does not respect Fitts's Law.)) In any case, scrollbars have been becoming less important for actual manipulation since the advent of the mouse wheel, touchpad scrolling and outright touchscreen. Now, in many cases they are rather used as indicators. The proposed solution also seems to put cart before the horse: Instead of putting an item that has been on the right ~forever on the left (the scrollbar), it may be a better idea to rethink the position of the sidebar. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92836] Formatting: Page grid layout function doesn't correctly dispatch a character in a grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92836 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||ipla...@yahoo.co.uk --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- @Ichiro : hi, I don't see an option Use square page mode for text grid in Writer General in my master build 5.1 alpha for OSX. Is this an option that is only visible when JP locale (UI/lang) is used ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52586] Mail Merge doesn't seem to respect a filter
https://bugs.documentfoundation.org/show_bug.cgi?id=52586 --- Comment #9 from paour pa...@free.fr --- Hello, I encounter the same probleme today and I read in an old documentation (French documentation for mail merge OpenOffice document 14.10.2007 http://www.openoffice.org/fr/Documentation/Guides/GuidePublipostage.odt page 25 and 27) that this bug affect mail merge wizard and not mail merge. 1-If I use a query to change my selection and if I click next after have edit my document (Mail merge wizard 7- Personnalise document), the preview, print and save merge document (Mail merge wizard 8-Save, Print or sent) are wrong. 2 If I use a table and a filter to do the same, the preview, print and save merge document are wrong. Workaround since 14.10.2007, use mail merge instead off mail merge wizard and query or filter work normally. Hope it's help you to resolved this (old) bug Regads Nicolas -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84914] Too much RAM used because of SVG page background
https://bugs.documentfoundation.org/show_bug.cgi?id=84914 Darius Daniel Grigoras daniel.grigo...@movidius.com changed: What|Removed |Added Resolution|INVALID |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75305] FORMATTING, FILEOPEN: Automatic row height doesn't work always .xls
https://bugs.documentfoundation.org/show_bug.cgi?id=75305 --- Comment #6 from tommy27 ba...@quipo.it --- still reproducible with LibO 4.4.5.1 and 5.1.0.0.alpha1+ (x64) Build ID: 449d272daf5e99f039cdfdd25f020bd798fb9e1d TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-08_08:13:06 Locale: it-IT (it_IT) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75632] Impossibility to create a table with Autovalue primary key
https://bugs.documentfoundation.org/show_bug.cgi?id=75632 --- Comment #15 from Desfontaine François francois.desfonta...@free.fr --- As I had wroten in Comment 10 my problem is solved. Now I use the 4.2.8.2 version without any more problem. The setting of autovalue to yes is maintained after saving. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92766] EDITING : Firebird Embedded database choice not available when Enable experiment feature switch is ON (Win64 bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=92766 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|Can't select and create |EDITING : Firebird Embedded |Firebird Embedded: on |database choice not |condition that Enable |available when Enable |experiment feature switch |experiment feature switch |on option set ON. |is ON (Win64 bit) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58173] PDF import does not handle rotated text correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=58173 --- Comment #6 from Winfried Donkers winfrieddonk...@libreoffice.org --- Created attachment 117334 -- https://bugs.documentfoundation.org/attachment.cgi?id=117334action=edit screenshot with LO 4.4.4.3 Problem still occurring with version 4.4.4.3 (Windows 7). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-1.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx | 54 +-
2 files changed, 27 insertions(+), 27 deletions(-)
New commits:
commit 7ad4717198ff62bac51b59b13f72c301ddd81c86
Author: Caolán McNamara caol...@redhat.com
Date: Sun Jul 19 21:09:25 2015 +0100
in reality we are limited to max sal_Int32 here
so accept that and test if the values were accepted or limited
Change-Id: I599cf8065a6f8786d380fdba03135857766770f3
(cherry picked from commit 80c591ea9c320fee9e975ac7b0e4e2df1bf5e447)
Reviewed-on: https://gerrit.libreoffice.org/17198
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
new file mode 100644
index 000..4fa0bb9
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-1.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index c35d943..20d3768 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -66,8 +66,8 @@ private:
sal_uLong nNewSubFile;
sal_uLong nSubFile;
-sal_uLong nImageWidth;// picture width in
pixels
-sal_uLong nImageLength; // picture height in
pixels
+sal_Int32 nImageWidth;// picture width in
pixels
+sal_Int32 nImageLength; // picture height in
pixels
sal_uLong nBitsPerSample; // bits per pixel per
layer
sal_uLong nCompression; // kind of compression
sal_uLong nPhotometricInterpretation;
@@ -119,7 +119,7 @@ private:
// Create the bitmap from the temporary bitmap pMap
// and partly deletes pMap while doing this.
-boolConvertScanline( sal_uLong nY );
+boolConvertScanline(sal_Int32 nY);
// converts a Scanline to the Windows-BMP format
bool HasAlphaChannel() const;
@@ -547,13 +547,13 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
{
if ( nCompression == 1 || nCompression == 32771 )
{
-sal_uLong ny, np, nStrip, nStripBytesPerRow;
+sal_uLong np, nStrip, nStripBytesPerRow;
if ( nCompression == 1 )
nStripBytesPerRow = nBytesPerRow;
else
nStripBytesPerRow = ( nBytesPerRow + 1 ) 0xfffe;
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -572,7 +572,7 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
}
else if ( nCompression == 2 || nCompression == 3 || nCompression == 4 )
{
-sal_uLong ny, np, nStrip, nOptions;
+sal_uLong np, nStrip, nOptions;
if ( nCompression == 2 )
{
nOptions = CCI_OPTION_BYTEALIGNROW;
@@ -607,7 +607,7 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
aCCIDecom.StartDecompression( *pTIFF );
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -634,13 +634,13 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
else if ( nCompression == 5 )
{
LZWDecompressor aLZWDecom;
-sal_uLong ny, np, nStrip;
+sal_uLong np, nStrip;
nStrip=0;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
aLZWDecom.StartDecompression(*pTIFF);
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -664,13 +664,13 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent,
sal_uLong nMaxPercent )
}
else if ( nCompression == 32773 )
{
-sal_uLong nStrip,nRecCount,nRowBytesLeft,ny,np,i;
+sal_uLong nStrip,nRecCount,nRowBytesLeft,np,i;
sal_uInt8 * pdst;
nStrip = 0;
if ( nStrip = nNumStripOffsets )
return false;
pTIFF-Seek(pStripOffsets[nStrip]);
-for ( ny = 0; ny nImageLength; ny++ )
+for (sal_Int32 ny = 0; ny nImageLength; ++ny)
{
for ( np = 0; np nPlanes; np++ )
{
@@ -785,9 +785,9 @@ sal_uLong TIFFReader::GetBits( const sal_uInt8 * pSrc,
sal_uLong nBitsPos, sal_u
-bool TIFFReader::ConvertScanline( sal_uLong nY )
+bool TIFFReader::ConvertScanline(sal_Int32 nY)
{
-sal_uInt32 nRed, nGreen, nBlue, ns, nx, nVal, nByteCount;
+
[Libreoffice-bugs] [Bug 49165] OpenOffice fails to display anything on screen when using cairo 1.12 (1.10 works) and enabling hardware acceleration in settings
https://bugs.documentfoundation.org/show_bug.cgi?id=49165 --- Comment #7 from Fabio Coatti fabio.coa...@gmail.com --- Still here, libreoffice 4.4.4.3 cairo 1.14.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source include/sfx2 sc/source sfx2/source starmath/inc starmath/source sw/inc sw/source
cui/source/customize/acccfg.cxx | 14 +
cui/source/inc/acccfg.hxx|4 -
include/sfx2/basedlgs.hxx|2
include/sfx2/dinfdlg.hxx |6 +-
include/sfx2/dispatch.hxx|2
include/sfx2/docinsert.hxx |8 +--
include/sfx2/filedlghelper.hxx |6 +-
include/sfx2/hintpost.hxx| 13 ++---
include/sfx2/tbxctrl.hxx |6 +-
include/sfx2/templateabstractview.hxx|4 -
include/sfx2/templatedlg.hxx |2
sc/source/ui/docshell/docsh4.cxx |3 -
sc/source/ui/inc/docsh.hxx |2
sc/source/ui/inc/instbdlg.hxx|2
sc/source/ui/inc/linkarea.hxx|2
sc/source/ui/miscdlgs/instbdlg.cxx |4 -
sc/source/ui/miscdlgs/linkarea.cxx |5 -
sfx2/source/appl/fileobj.cxx |3 -
sfx2/source/appl/fileobj.hxx |2
sfx2/source/appl/shutdownicon.cxx|3 -
sfx2/source/appl/shutdownicon.hxx|2
sfx2/source/control/dispatch.cxx |7 +-
sfx2/source/control/templateabstractview.cxx |2
sfx2/source/dialog/backingwindow.cxx |4 -
sfx2/source/dialog/backingwindow.hxx |2
sfx2/source/dialog/dinfdlg.cxx |3 -
sfx2/source/dialog/filedlghelper.cxx |2
sfx2/source/doc/docinsert.cxx|8 +--
sfx2/source/doc/templatedlg.cxx |8 +--
sfx2/source/notify/hintpost.cxx | 15 +
sfx2/source/toolbox/tbxitem.cxx |4 -
starmath/inc/view.hxx|2
starmath/source/view.cxx |3 -
sw/inc/view.hxx |2
sw/source/ui/dialog/uiregionsw.cxx |6 --
sw/source/ui/fldui/javaedit.cxx |4 -
sw/source/uibase/inc/conttree.hxx|2
sw/source/uibase/inc/javaedit.hxx|2
sw/source/uibase/inc/navipi.hxx |2
sw/source/uibase/inc/regionsw.hxx|4 -
sw/source/uibase/inc/uivwimp.hxx |2
sw/source/uibase/uiview/uivwimp.cxx |2
sw/source/uibase/uiview/view2.cxx| 69 +--
sw/source/uibase/utlui/glbltree.cxx | 39 +++
sw/source/uibase/utlui/navipi.cxx|4 -
45 files changed, 128 insertions(+), 165 deletions(-)
New commits:
commit 91b1f300cf7f357c3a39d0d5810326cc78d78f16
Author: Noel Grandin noelgran...@gmail.com
Date: Sat Jul 18 17:23:17 2015 +0200
convert to typed Link in sfx2
Change-Id: Ifa42bd14d7329ff1043fa736513c468dda30485e
Reviewed-on: https://gerrit.libreoffice.org/17195
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx
index 6bf6282..6db36dc 100644
--- a/cui/source/customize/acccfg.cxx
+++ b/cui/source/customize/acccfg.cxx
@@ -1231,7 +1231,7 @@ IMPL_LINK_NOARG(SfxAcceleratorConfigPage, RadioHdl)
}
-IMPL_LINK_NOARG(SfxAcceleratorConfigPage, LoadHdl)
+IMPL_LINK_NOARG_TYPED(SfxAcceleratorConfigPage, LoadHdl,
sfx2::FileDialogHelper*, void)
{
assert(m_pFileDlg);
@@ -1240,7 +1240,7 @@ IMPL_LINK_NOARG(SfxAcceleratorConfigPage, LoadHdl)
sCfgName = m_pFileDlg-GetPath();
if ( sCfgName.isEmpty() )
-return 0;
+return;
GetTabDialog()-EnterWait();
@@ -1312,12 +1312,10 @@ IMPL_LINK_NOARG(SfxAcceleratorConfigPage, LoadHdl)
{}
GetTabDialog()-LeaveWait();
-
-return 0;
}
-IMPL_LINK_NOARG(SfxAcceleratorConfigPage, SaveHdl)
+IMPL_LINK_NOARG_TYPED(SfxAcceleratorConfigPage, SaveHdl,
sfx2::FileDialogHelper*, void)
{
assert(m_pFileDlg);
@@ -1326,7 +1324,7 @@ IMPL_LINK_NOARG(SfxAcceleratorConfigPage, SaveHdl)
sCfgName = m_pFileDlg-GetPath();
if ( sCfgName.isEmpty() )
-return 0;
+return;
GetTabDialog()-EnterWait();
@@ -1415,8 +1413,6 @@ IMPL_LINK_NOARG(SfxAcceleratorConfigPage, SaveHdl)
{}
GetTabDialog()-LeaveWait();
-
-return 0;
}
@@ -1433,7 +1429,7 @@ void SfxAcceleratorConfigPage::StartFileDialog( WinBits
nBits, const OUString r
m_pFileDlg-AddFilter( aFilterCfgStr, OUString(*.cfg) );
m_pFileDlg-SetCurrentFilter( aFilterCfgStr );
-Link aDlgClosedLink = bSave ? LINK( this, SfxAcceleratorConfigPage,
SaveHdl )
+Linksfx2::FileDialogHelper*,void aDlgClosedLink = bSave ? LINK( this,
SfxAcceleratorConfigPage, SaveHdl )
: LINK( this, SfxAcceleratorConfigPage,
LoadHdl );
m_pFileDlg-StartExecuteModal( aDlgClosedLink );
}
diff --git a/cui/source/inc/acccfg.hxx b/cui/source/inc/acccfg.hxx
index 4a31d77..9f05168 100644
--- a/cui/source/inc/acccfg.hxx
+++
[Libreoffice-bugs] [Bug 87532] Arial Bold Italic font Times New Roman Italic font does not display Arabic characters
https://bugs.documentfoundation.org/show_bug.cgi?id=87532 --- Comment #6 from yousifjka...@yahoo.com --- Hi. I test version 5.0.0 RC3 version 4.3.5 RC1 issue is still existing without any improvement!! Is it such deficult to fix! Please is there a hope to fix it or not? And if yes, at which approximate time? If there is no hope for fix, please inform me because I use this formate Bold, 'Italic frequently. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75632] Impossibility to create a table with Autovalue primary key
https://bugs.documentfoundation.org/show_bug.cgi?id=75632 rob...@familiegrosskopf.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #16 from rob...@familiegrosskopf.de --- (In reply to Desfontaine François from comment #15) As I had wroten in Comment 10 my problem is solved. Now I use the 4.2.8.2 version without any more problem. The setting of autovalue to yes is maintained after saving. So let us set this bug to Resolved and Worksforme. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-4.tiff |binary
filter/source/graphicfilter/itiff/ccidecom.cxx |9 ++---
2 files changed, 2 insertions(+), 7 deletions(-)
New commits:
commit 1aac166075ef5a3183474449ae7d0fa3f7cf82b6
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:35:26 2015 +0100
reduce scope, etc, don't loop endlessly
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e
(cherry picked from commit 5d32a4ac5c166264c2d44e8df625eb768eb42fbe)
Reviewed-on: https://gerrit.libreoffice.org/17204
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
new file mode 100644
index 000..ef0fe27
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/ccidecom.cxx
b/filter/source/graphicfilter/itiff/ccidecom.cxx
index f7eed81..2477542 100644
--- a/filter/source/graphicfilter/itiff/ccidecom.cxx
+++ b/filter/source/graphicfilter/itiff/ccidecom.cxx
@@ -628,8 +628,6 @@ void CCIDecompressor::StartDecompression( SvStream
rIStream )
bool CCIDecompressor::DecompressScanline( sal_uInt8 * pTarget, sal_uLong
nTargetBits, bool bLastLine )
{
-sal_uInt16 i;
-sal_uInt8 * pDst;
bool b2D;
if ( nEOLCount = 5 ) // RTC (Return To Controller)
@@ -678,8 +676,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
delete[] pLastLine;
nLastLineSize = ( nTargetBits + 7 ) 3;
pLastLine = new sal_uInt8[ nLastLineSize ];
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *( pDst++ ) = 0x00;
+memset(pLastLine, 0, nLastLineSize);
}
}
// conditionally align start of line to next byte:
@@ -706,9 +703,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
// if we're in 2D mode we have to remember the line:
if ( nOptions CCI_OPTION_2D bStatus )
{
-sal_uInt8 *pSrc = pTarget;
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *(pDst++)=*(pSrc++);
+memcpy(pLastLine, pTarget, nLastLineSize);
}
// #i122984#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 81230] UI unresponsive on large spreadsheet with a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=81230 --- Comment #4 from Andrey Semashev andy...@mail.ru --- I tried the attached spreadsheet with version 4.4.2.2 Build ID: 40m0(Build:2) (the one in Ubuntu 15.04). Scrolling with (partially) visible graph seems faster now, although slightly sluggish still. I'd say scrolling is acceptable. However, when I tried to resize the graph the UI froze for a few minutes with 100% load of one CPU core. It also affected DE performance (which is currently XFCE 4.12) - the mouse cursor changed to the one that is displayed when you resize windows and it didn't change back to normal even when I switched to another application; it also appeared as if other applications were not responsive to mouse actions. After some time DE restored its functionality, while Calc was still loading the CPU. I don't remember such problems back when I reported this bug, so it looks like a regression. Keeping this bug open as resizing performance is unacceptable. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/inc basic/qa basic/source
basic/inc/sbobjmod.hxx | 10
basic/qa/cppunit/basictest.hxx |4
basic/source/basmgr/basicmanagerrepository.cxx |4
basic/source/classes/global.cxx|2
basic/source/classes/propacc.cxx | 28 -
basic/source/classes/sb.cxx|2
basic/source/classes/sbunoobj.cxx | 16
basic/source/classes/sbxmod.cxx|8
basic/source/comp/codegen.cxx |6
basic/source/comp/parser.cxx |4
basic/source/inc/date.hxx | 12
basic/source/inc/dlgcont.hxx | 59 +-
basic/source/inc/errobject.hxx |8
basic/source/inc/namecont.hxx | 497 -
basic/source/inc/propacc.hxx | 69 +--
basic/source/inc/runtime.hxx |6
basic/source/inc/sbunoobj.hxx | 80 ++--
basic/source/inc/scriptcont.hxx| 87 ++--
basic/source/runtime/comenumwrapper.hxx| 10
basic/source/runtime/methods.cxx | 30 -
basic/source/runtime/methods1.cxx |4
basic/source/runtime/runtime.cxx |6
basic/source/sbx/sbxdec.cxx|4
basic/source/sbx/sbxdec.hxx|4
basic/source/sbx/sbxvalue.cxx |4
basic/source/sbx/sbxvar.cxx|2
basic/source/uno/dlgcont.cxx | 13
basic/source/uno/namecont.cxx | 12
basic/source/uno/scriptcont.cxx| 18
29 files changed, 496 insertions(+), 513 deletions(-)
New commits:
commit b4ee16da65eab7b50b29dcd42dc0f0be6b97b174
Author: Noel Grandin n...@peralex.com
Date: Mon Jul 20 09:21:24 2015 +0200
com::sun::star-css in basic
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/basic/inc/sbobjmod.hxx b/basic/inc/sbobjmod.hxx
index c71c20a..0b178ae 100644
--- a/basic/inc/sbobjmod.hxx
+++ b/basic/inc/sbobjmod.hxx
@@ -38,21 +38,21 @@ protected:
public:
TYPEINFO_OVERRIDE();
-SbObjModule( const OUString rName, const
com::sun::star::script::ModuleInfo mInfo, bool bIsVbaCompatible );
+SbObjModule( const OUString rName, const css::script::ModuleInfo mInfo,
bool bIsVbaCompatible );
virtual SbxVariable* Find( const OUString rName, SbxClassType t )
SAL_OVERRIDE;
virtual void Notify( SfxBroadcaster rBC, const SfxHint rHint )
SAL_OVERRIDE;
using SbxValue::GetObject;
SbxVariable* GetObject();
-void SetUnoObject( const com::sun::star::uno::Any aObj )throw (
com::sun::star::uno::RuntimeException, std::exception ) ;
+void SetUnoObject( const css::uno::Any aObj )throw (
css::uno::RuntimeException, std::exception ) ;
};
class FormObjEventListenerImpl;
class BASIC_DLLPUBLIC SbUserFormModule : public SbObjModule
{
-com::sun::star::script::ModuleInfo m_mInfo;
+css::script::ModuleInfo m_mInfo;
::rtl::Reference FormObjEventListenerImpl m_DialogListener;
css::uno::Referencecss::awt::XDialog m_xDialog;
css::uno::Referencecss::frame::XModel m_xModel;
@@ -62,7 +62,7 @@ class BASIC_DLLPUBLIC SbUserFormModule : public SbObjModule
void InitObject();
public:
TYPEINFO_OVERRIDE();
-SbUserFormModule( const OUString rName, const
com::sun::star::script::ModuleInfo mInfo, bool bIsVBACompat );
+SbUserFormModule( const OUString rName, const css::script::ModuleInfo
mInfo, bool bIsVBACompat );
virtual ~SbUserFormModule();
virtual SbxVariable* Find( const OUString rName, SbxClassType t )
SAL_OVERRIDE;
void ResetApiObj( bool bTriggerTerminateEvent = true );
@@ -91,7 +91,7 @@ class BASIC_DLLPUBLIC SbUserFormModuleInstance : public
SbUserFormModule
public:
SbUserFormModuleInstance( SbUserFormModule* pParentModule, const OUString
rName,
-const com::sun::star::script::ModuleInfo mInfo, bool bIsVBACompat );
+const css::script::ModuleInfo mInfo, bool bIsVBACompat );
virtual bool IsClass( const OUString ) const SAL_OVERRIDE;
virtual SbxVariable* Find( const OUString rName, SbxClassType t )
SAL_OVERRIDE;
diff --git a/basic/qa/cppunit/basictest.hxx b/basic/qa/cppunit/basictest.hxx
index 1b9c634..49bbb29 100644
--- a/basic/qa/cppunit/basictest.hxx
+++ b/basic/qa/cppunit/basictest.hxx
@@ -88,7 +88,7 @@ class MacroSnippet
MakeModule( sSource );
}
-SbxVariableRef Run( const ::com::sun::star::uno::Sequence
::com::sun::star::uno::Any rArgs )
+SbxVariableRef Run( const css::uno::Sequence css::uno::Any rArgs )
{
SbxVariableRef pReturn = NULL;
if ( !Compile() )
@@ -114,7 +114,7 @@ class MacroSnippet
SbxVariableRef Run()
{
-
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter.cxx | 36
1 file changed, 36 insertions(+)
New commits:
commit 2062d69c390d372ab4253832012e6cbb27df6dda
Author: Varun varun.dh...@studentpartner.com
Date: Thu Jul 16 22:14:54 2015 +0530
Added UNO test coverage for SwXParagraph
Change-Id: I2779114e2655e9574003b929b1517560c21ae4b5
Reviewed-on: https://gerrit.libreoffice.org/17141
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 72e5a8c..55ae22b 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -113,6 +113,7 @@ public:
void testTextSearch();
void testTdf69282();
void testTdf69282WithMirror();
+void testUnoParagraph();
void testSearchWithTransliterate();
void testTdf80663();
void testTdf90808();
@@ -170,6 +171,7 @@ public:
CPPUNIT_TEST(testTextSearch);
CPPUNIT_TEST(testTdf69282);
CPPUNIT_TEST(testTdf69282WithMirror);
+CPPUNIT_TEST(testUnoParagraph);
CPPUNIT_TEST(testSearchWithTransliterate);
CPPUNIT_TEST(testTdf80663);
CPPUNIT_TEST(testTdf90808);
@@ -1313,6 +1315,40 @@ void SwUiWriterTest::testTdf69282WithMirror()
xSourceDoc-dispose();
}
+void SwUiWriterTest::testUnoParagraph()
+{
+SwDoc* pDoc = createDoc();
+SwWrtShell* pWrtShell = pDoc-GetDocShell()-GetWrtShell();
+//Inserting some text content in the document
+pWrtShell-Insert(This is initial text in paragraph one);
+pWrtShell-SplitNode();
+//Inserting second paragraph
+pWrtShell-Insert(This is initial text in paragraph two);
+//now testing the SwXParagraph
+uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Referencetext::XText xText(xTextDocument-getText());
+uno::Referencecontainer::XEnumerationAccess xParaAccess(xText,
uno::UNO_QUERY);
+uno::Referencecontainer::XEnumeration
xPara(xParaAccess-createEnumeration());
+//getting first paragraph
+uno::Referencetext::XTextContent xFirstParaContent(xPara-nextElement(),
uno::UNO_QUERY);
+uno::Referencetext::XTextRange xFirstPara(xFirstParaContent,
uno::UNO_QUERY);
+//testing the initial text
+CPPUNIT_ASSERT_EQUAL(OUString(This is initial text in paragraph one),
xFirstPara-getString());
+//changing the text content in first paragraph
+xFirstPara-setString(This is modified text in paragraph one);
+//testing the changes
+CPPUNIT_ASSERT_EQUAL(OUString(This is modified text in paragraph one),
xFirstPara-getString());
+//getting second paragraph
+uno::Referencetext::XTextContent
xSecondParaContent(xPara-nextElement(), uno::UNO_QUERY);
+uno::Referencetext::XTextRange xSecondPara(xSecondParaContent,
uno::UNO_QUERY);
+//testing the initial text
+CPPUNIT_ASSERT_EQUAL(OUString(This is initial text in paragraph two),
xSecondPara-getString());
+//changing the text content in second paragraph
+xSecondPara-setString(This is modified text in paragraph two);
+//testing the changes
+CPPUNIT_ASSERT_EQUAL(OUString(This is modified text in paragraph two),
xSecondPara-getString());
+}
+
void SwUiWriterTest::testSearchWithTransliterate()
{
SwDoc* pDoc = createDoc();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/gbuild-to-ide
bin/gbuild-to-ide | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 09491390e6662516339f8aa920bb8ae9493e34c0
Author: Michel Renon michel.re...@free.fr
Date: Sat Jul 11 23:56:12 2015 +0200
tdf#92560 : QtCreator integration complains about a ucpp without a .pro
file
The script gbuild-to-ide now handles correctly specific case where a module
is not a direct subfolder of LibreOffice base folder.
Currently, 3 modules :
external/neon, external/clucene, external/ucpp.
Change-Id: I9477519a530439d43919b4e1b51dc2c71ee05fe0
Reviewed-on: https://gerrit.libreoffice.org/17054
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 0452a9e..af1b20a 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -1291,7 +1291,8 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
all_libs = set(self.gbuildparser.libs) | set(self.gbuildparser.exes)
for lib in all_libs:
self._log(\nlibrary : %s, loc=%s % (lib.short_name(),
lib.location))
-lib_folder = os.path.basename(lib.location)
+lib_name = os.path.basename(lib.location)
+lib_folder = os.path.relpath(lib.location, self.base_folder)
def lopath(path):
return os.path.relpath(path, lib.location)
@@ -1336,7 +1337,8 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
'sources' : set(sources_list),
'headers' : set(headers_list),
'includepath' : set(includepath_list),
-'loc' : lib.location
+'loc' : lib.location,
+'name' : lib_name
}
def emit(self):
@@ -1356,13 +1358,14 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
headers_list = sorted(self.data_libs[lib_folder]['headers'])
includepath_list =
sorted(self.data_libs[lib_folder]['includepath'])
lib_loc = self.data_libs[lib_folder]['loc']
+lib_name = self.data_libs[lib_folder]['name']
sources = \\\n.join(sources_list)
headers = \\\n.join(headers_list)
includepath = \\\n.join(includepath_list)
# create .pro file
-qt_pro_file = '%s/%s.pro' % (lib_loc, lib_folder)
+qt_pro_file = '%s/%s.pro' % (lib_loc, lib_name)
try:
content = QtCreatorIntegrationGenerator.pro_template %
{'sources' : sources, 'headers' : headers, 'includepath' : includepath}
mode = 'w+'
@@ -1378,7 +1381,7 @@ class
QtCreatorIntegrationGenerator(IdeIntegrationGenerator):
print(\n\n, file=sys.stderr)
# create .pro.user file
-qt_pro_user_file = '%s/%s.pro.user' % (lib_loc, lib_folder)
+qt_pro_user_file = '%s/%s.pro.user' % (lib_loc, lib_name)
try:
with open(qt_pro_user_file, mode) as fprouser:
fprouser.write(self.generate_pro_user_content(lib_folder))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 81118] UI: add fit page size to drawing button to the page format window
https://bugs.documentfoundation.org/show_bug.cgi?id=81118 tommy27 ba...@quipo.it changed: What|Removed |Added CC||philip...@hotmail.com --- Comment #4 from tommy27 ba...@quipo.it --- @Jay one of you? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91882] UI: Dialogue for Advanced filter is transparent.
https://bugs.documentfoundation.org/show_bug.cgi?id=91882 --- Comment #17 from Jan Holesovsky ke...@collabora.com --- OK, from the list of commits, apparently caused by the Idle rework... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-6.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit 4b96ee2d118c7d59408f361390158b7c8375cbf8 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 20 09:24:48 2015 +0100 final check np bounds Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876 (cherry picked from commit dcbbe7741a08f6076f9e020f90cbb730c1edafb9) Reviewed-on: https://gerrit.libreoffice.org/17212 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-6.tiff b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff new file mode 100644 index 000..907b510 Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index 7a5d487..4fa050d 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -551,6 +551,8 @@ bool TIFFReader::ReadMap() if ( nStrip = nNumStripOffsets ) return false; pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny % GetRowsPerStrip() ) * nStripBytesPerRow ); +if (np = SAL_N_ELEMENTS(pMap)) +return false; pTIFF-Read( pMap[ np ], nBytesPerRow ); if ( pTIFF-GetError() ) return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-5.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit 1b50cbe9aac1f57ac325799931abcd60e88d51b6
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:50:27 2015 +0100
check np bounds yet again
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c
(cherry picked from commit bca4d6f896fb12ceff37476c43ea8892898dd385)
Reviewed-on: https://gerrit.libreoffice.org/17208
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
new file mode 100644
index 000..4849edf
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 20d3768..69067c5 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -682,6 +682,8 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong
nMaxPercent )
pTIFF-Seek(pStripOffsets[nStrip]);
}
nRowBytesLeft = nBytesPerRow;
+if (np = SAL_N_ELEMENTS(pMap))
+return false;
pdst=pMap[ np ];
do
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-5.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit 429f6b5183fa39751d949431e16bd6f4163bf78c
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:50:27 2015 +0100
check np bounds yet again
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c
(cherry picked from commit bca4d6f896fb12ceff37476c43ea8892898dd385)
Reviewed-on: https://gerrit.libreoffice.org/17207
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
new file mode 100644
index 000..4849edf
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-5.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index b18db6b..7a5d487 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -669,6 +669,8 @@ bool TIFFReader::ReadMap()
pTIFF-Seek(pStripOffsets[nStrip]);
}
nRowBytesLeft = nBytesPerRow;
+if (np = SAL_N_ELEMENTS(pMap))
+return false;
pdst=pMap[ np ];
do
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-4.tiff |binary
filter/source/graphicfilter/itiff/ccidecom.cxx |9 ++---
2 files changed, 2 insertions(+), 7 deletions(-)
New commits:
commit f379b1ace95e25798d16c4980fb6a136fcf79715
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 08:35:26 2015 +0100
reduce scope, etc, don't loop endlessly
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e
(cherry picked from commit 5d32a4ac5c166264c2d44e8df625eb768eb42fbe)
Reviewed-on: https://gerrit.libreoffice.org/17205
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
new file mode 100644
index 000..ef0fe27
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-4.tiff
differ
diff --git a/filter/source/graphicfilter/itiff/ccidecom.cxx
b/filter/source/graphicfilter/itiff/ccidecom.cxx
index 6cd2c41..de0299f 100644
--- a/filter/source/graphicfilter/itiff/ccidecom.cxx
+++ b/filter/source/graphicfilter/itiff/ccidecom.cxx
@@ -628,8 +628,6 @@ void CCIDecompressor::StartDecompression( SvStream
rIStream )
bool CCIDecompressor::DecompressScanline( sal_uInt8 * pTarget, sal_uLong
nTargetBits, bool bLastLine )
{
-sal_uInt16 i;
-sal_uInt8 * pDst;
bool b2D;
if ( nEOLCount = 5 ) // RTC (Return To Controller)
@@ -678,8 +676,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
delete[] pLastLine;
nLastLineSize = ( nTargetBits + 7 ) 3;
pLastLine = new sal_uInt8[ nLastLineSize ];
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *( pDst++ ) = 0x00;
+memset(pLastLine, 0, nLastLineSize);
}
}
// conditionally align start of line to next byte:
@@ -706,9 +703,7 @@ bool CCIDecompressor::DecompressScanline( sal_uInt8 *
pTarget, sal_uLong nTarget
// if we're in 2D mode we have to remember the line:
if ( nOptions CCI_OPTION_2D bStatus )
{
-sal_uInt8 *pSrc = pTarget;
-pDst = pLastLine;
-for ( i = 0; i nLastLineSize; i++ ) *(pDst++)=*(pSrc++);
+memcpy(pLastLine, pTarget, nLastLineSize);
}
// #i122984#
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 81230] UI unresponsive on large spreadsheet with a chart
https://bugs.documentfoundation.org/show_bug.cgi?id=81230 tommy27 ba...@quipo.it changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from tommy27 ba...@quipo.it --- @Andrey we should not mix different things in the same bug report... the original problem (according to comment 0) was UI unresponsivness which you don't see anymore, right? if yes, please set status to RESOLVED WORKSFORME then please upgrade to latest 4.4.4.3 or 4.4.5.2rc release and retest the resize problem (which I don't reproduce on Win7x64) if that persists please file a new clean report about that @Kevin would you please retest as well? set status to NEEDINFO waiting 4 users feedback -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84914] Too much RAM used because of SVG page background
https://bugs.documentfoundation.org/show_bug.cgi?id=84914 steve -_- st...@openmailbox.org changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #15 from steve -_- st...@openmailbox.org --- If this is no longer a problem in newer versions correct statuts is WORKSFORME instead of FIXED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/Util.cpp
loolwsd/LOOLSession.cpp | 15 ---
loolwsd/LOOLSession.hpp |2 ++
loolwsd/Util.cpp|6 +++---
3 files changed, 17 insertions(+), 6 deletions(-)
New commits:
commit 19d6dec3f71cc3ef7bead808bbba744312231185
Author: Mihai Varga mihai.va...@collabora.com
Date: Mon Jul 20 12:54:08 2015 +0300
loolwsd: log timestamp in microseconds
Also, separate messages by comma so we can parse them easily
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 000b319..69dccc7 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -85,6 +85,15 @@ LOOLSession::LOOLSession(std::shared_ptrWebSocket ws, Kind
kind) :
_docURL()
{
std::cout Util::logPrefix() LOOLSession ctor this= this
_kind ws= _ws.get() std::endl;
+if (kind == Kind::ToClient) {
+_kindString = ToClient;
+}
+else if (kind == Kind::ToMaster) {
+_kindString = ToMaster;
+}
+else if (kind == Kind::ToPrisoner) {
+_kindString = ToPrisoner;
+}
}
LOOLSession::~LOOLSession()
@@ -143,7 +152,7 @@ MasterProcessSession::~MasterProcessSession()
bool MasterProcessSession::handleInput(const char *buffer, int length)
{
-Application::instance().logger().information(Util::logPrefix() + Input:
+ getAbbreviatedMessage(buffer, length));
+Application::instance().logger().information(Util::logPrefix() +
_kindString + ,Input, + getAbbreviatedMessage(buffer, length));
std::string firstLine = getFirstLine(buffer, length);
StringTokenizer tokens(firstLine, , StringTokenizer::TOK_IGNORE_EMPTY |
StringTokenizer::TOK_TRIM);
@@ -555,7 +564,7 @@ void MasterProcessSession::dispatchChild()
void MasterProcessSession::forwardToPeer(const char *buffer, int length)
{
-Application::instance().logger().information(Util::logPrefix() +
forwardToPeer( + getAbbreviatedMessage(buffer, length) + ));
+Application::instance().logger().information(Util::logPrefix() +
_kindString + ,forwardToPeer, + getAbbreviatedMessage(buffer, length));
auto peer = _peer.lock();
if (!peer)
return;
@@ -583,7 +592,7 @@ bool ChildProcessSession::handleInput(const char *buffer,
int length)
std::string firstLine = getFirstLine(buffer, length);
StringTokenizer tokens(firstLine, , StringTokenizer::TOK_IGNORE_EMPTY |
StringTokenizer::TOK_TRIM);
-Application::instance().logger().information(Util::logPrefix() + Input:
+ getAbbreviatedMessage(buffer, length));
+Application::instance().logger().information(Util::logPrefix() +
_kindString + ,Input, + getAbbreviatedMessage(buffer, length));
if (tokens[0] == load)
{
diff --git a/loolwsd/LOOLSession.hpp b/loolwsd/LOOLSession.hpp
index a5381ca..aa3ac25 100644
--- a/loolwsd/LOOLSession.hpp
+++ b/loolwsd/LOOLSession.hpp
@@ -55,6 +55,8 @@ protected:
const Kind _kind;
+std::string _kindString;
+
void sendBinaryFrame(const char *buffer, int length);
virtual bool loadDocument(const char *buffer, int length,
Poco::StringTokenizer tokens) = 0;
diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index 4bdf94e..85bae00 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -51,9 +51,9 @@ namespace Util
std::string logPrefix()
{
-static Poco::Timestamp firstTimeStamp;
-Poco::Int64 now = firstTimeStamp.elapsed();
-return std::to_string(Poco::Process::id()) + : +
(Poco::Thread::current() ? std::to_string(Poco::Thread::current()-id()) : 0)
+ : + std::to_string(now / 100) + . + Poco::format(%03d, (int)((now /
1000) % 1000)) + : ;
+Poco::Timestamp timeStamp;
+Poco::Int64 now = timeStamp.epochMicroseconds();
+return std::to_string(Poco::Process::id()) + , +
(Poco::Thread::current() ? std::to_string(Poco::Thread::current()-id()) : 0)
+ , + std::to_string(now / 1000) + ,;
}
bool windowingAvailable()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [GSoC] Integrating LO with GNOME - WR#8
On Mon, Jul 20, 2015 at 3:16 PM, Michael Meeks michael.me...@collabora.com wrote: Hi Pranav, On Mon, 2015-07-20 at 01:04 +0530, Pranav Kant wrote: This week I made few enhancements to the threading infrastructure that I coded last week taking inspiration from Libreoffice Android. Now I am making use of a thread pool, instead of creating a new thread(s) everytime. All the LOK calls are now being called in thread(s) reused from this pool. Hah =) so one thing that makes this particularly non-useful is the fact that LibreOfficeKit is single-plus-epsilon threaded ;-) So you'll get no useful benefit from using more than a single thread. I am making use of thread pool, but this pool consists of only single thread. All the LOK calls will be queued and can reuse this thread, hence saving me the time that it would take to create a new thread (expensive process) for each LOK call. This was the reason behind making use of thread pool. I had no intention of using more than one thread for LOK calls. -- Regards, Pranav Kant http://pranavk.me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 60062] Language change via Format-Cell-Font is ignored by SPELL check until save-close-reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=60062 steve -_- st...@openmailbox.org changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #18 from steve -_- st...@openmailbox.org --- Since we do not have a commit, WORKSFORME as opposed to FIXED is the correct state. Thanks for the update. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48767] Page orientation is not saved/loaded in/from .xlsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=48767 tommy27 ba...@quipo.it changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||827 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92827] FILESAVE Landscape orientations reset to portrait after editing DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=92827 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||267 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88267] Page orientation doesn't export to .doc/.docx correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=88267 tommy27 ba...@quipo.it changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||827 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92827] FILESAVE Landscape orientations reset to portrait after editing DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=92827 tommy27 ba...@quipo.it changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=48 ||767 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92361] EDITING Spellcheck (F7) does not find misspelled words
https://bugs.documentfoundation.org/show_bug.cgi?id=92361 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Beluga todven...@suomi24.fi --- Bruce: there doesn't seem to be a hunspell en-nz package available for Debian. I believe this is the cause of your problem. https://packages.debian.org/search?keywords=hunspell What hunspell packages do you have installed? en-us? Does it work for text marked as American English? These are not global problems, so you shouldn't stop recommending LibreOffice just because of these. These are isolated cases related to the system and its packages. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/hang-5.tiff |binary
filter/source/graphicfilter/itiff/itiff.cxx |7 +--
2 files changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 17b1467a30895b08317f7be2079620a4d057b4b4
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 09:20:33 2015 +0100
test that nNumStripByteCounts value is within bounds of file
Change-Id: If119628d7f510a7db30ed2180111063781cde887
(cherry picked from commit 33d43205c341e0cce36b6a1b3082c3927490cbde)
Reviewed-on: https://gerrit.libreoffice.org/17210
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/filter/qa/cppunit/data/tiff/fail/hang-5.tiff
b/filter/qa/cppunit/data/tiff/fail/hang-5.tiff
new file mode 100644
index 000..f1be3fa
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-5.tiff differ
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index 4fa050d..f0c5d1e 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -422,14 +422,17 @@ void TIFFReader::ReadTagData( sal_uInt16 nTagType,
sal_uInt32 nDataLen)
nNumStripByteCounts = 0; // to be on the safe side
nOldNumSBC = nNumStripByteCounts;
nDataLen += nOldNumSBC;
-if ( ( nDataLen nOldNumSBC ) ( nDataLen SAL_MAX_UINT32 /
sizeof( sal_uInt32 ) ) )
+size_t nMaxAllocAllowed = SAL_MAX_UINT32 / sizeof(sal_uInt32);
+size_t nMaxRecordsAvailable = pTIFF-remainingSize() /
DataTypeSize();
+if (nDataLen nOldNumSBC nDataLen nMaxAllocAllowed
+(nDataLen - nOldNumSBC) = nMaxRecordsAvailable)
{
nNumStripByteCounts = nDataLen;
try
{
pStripByteCounts = new sal_uLong[ nNumStripByteCounts ];
}
-catch (const std::bad_alloc )
+catch (const std::bad_alloc )
{
pStripByteCounts = NULL;
nNumStripByteCounts = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-6.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit dcbbe7741a08f6076f9e020f90cbb730c1edafb9 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 20 09:24:48 2015 +0100 final check np bounds Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876 diff --git a/filter/qa/cppunit/data/tiff/fail/crash-6.tiff b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff new file mode 100644 index 000..907b510 Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index 89de8e0..f0c5d1e 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -554,6 +554,8 @@ bool TIFFReader::ReadMap() if ( nStrip = nNumStripOffsets ) return false; pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny % GetRowsPerStrip() ) * nStripBytesPerRow ); +if (np = SAL_N_ELEMENTS(pMap)) +return false; pTIFF-Read( pMap[ np ], nBytesPerRow ); if ( pTIFF-GetError() ) return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 87731] Tag appearing in Arabic characters when change size of fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=87731 --- Comment #4 from yousifjka...@yahoo.com --- Hi. I test version 5.0.0 RC3 version 4.4.5 RC1 bug is still existing without improvement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx
vcl/unx/gtk/window/gtksalframe.cxx |9 - 1 file changed, 8 insertions(+), 1 deletion(-) New commits: commit 19b9457ab69c05c96b2adce59e38ed8eb4bf62db Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 17 13:51:16 2015 +0100 wayland: actually show something (cherry picked from commit d9b2105e14b7f84c24ced4faea1795e32d8e21d1) Change-Id: Icd081c38de1374c6bfd6fb04d7765e07ff5d1aff Reviewed-on: https://gerrit.libreoffice.org/17196 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index ce2918f..05bd51b 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -105,6 +105,10 @@ #define IS_WIDGET_MAPPED GTK_WIDGET_MAPPED #endif +#if !GTK_CHECK_VERSION(3,0,0) +#define GDK_IS_X11_DISPLAY(foo) (true) +#endif + using namespace com::sun::star; int GtkSalFrame::m_nFloats = 0; @@ -1094,7 +1098,10 @@ void GtkSalFrame::InitCommon() m_nHudAwarenessId = 0; gtk_widget_set_app_paintable( m_pWindow, TRUE ); -gtk_widget_set_double_buffered( m_pWindow, FALSE ); +/*non-X11 displays won't show anything at all without double-buffering + enabled*/ +if (GDK_IS_X11_DISPLAY(getGdkDisplay())) +gtk_widget_set_double_buffered( m_pWindow, FALSE ); gtk_widget_set_redraw_on_allocate( m_pWindow, FALSE ); gtk_widget_add_events( m_pWindow, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional
https://bugs.documentfoundation.org/show_bug.cgi?id=91495 --- Comment #15 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c7451681a5c5408a73fc25595c228f7922fbd29h=libreoffice-5-0 tdf#91495 add property to turn off stlye previews It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional
https://bugs.documentfoundation.org/show_bug.cgi?id=91495 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 target:5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional
https://bugs.documentfoundation.org/show_bug.cgi?id=91495 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5712755e6af5318d264d7e2f5efb28e747b110fh=libreoffice-5-0 tdf#91495 don't change tree entry height when preview is disabled It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Crash test update
On Mon, 2015-07-20 at 09:08 +, Crashtest VM wrote: New crashtest update available at http://dev-builds.libreoffice.org/crashtest/b6cad3faff530a84a585a3d8bb965568fe96ef97/ caolanm-mstahl: Thanks for that final intermingled ruby+hyperlink docx export fix. That's our first 0 import + 0 export report.. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC] Integrating LO with GNOME - WR#8
Hi Pranav, On Mon, 2015-07-20 at 01:04 +0530, Pranav Kant wrote: This week I made few enhancements to the threading infrastructure that I coded last week taking inspiration from Libreoffice Android. Now I am making use of a thread pool, instead of creating a new thread(s) everytime. All the LOK calls are now being called in thread(s) reused from this pool. Hah =) so one thing that makes this particularly non-useful is the fact that LibreOfficeKit is single-plus-epsilon threaded ;-) So you'll get no useful benefit from using more than a single thread. I was facing few problems initially with making paintTile calls async, but following Michael's advice, and revisiting the code, I found a minor memory glitch which was preventing it to work like we expected. =) great. I have pushed the working patches to feature/gsoc-tiled-rendering (needs little bit of polishing, though, before merging). The tiles are being rendered asynchronously now. However, I am bit worried about the lag that we are facing sometimes, of which I will try to find the actual cause. So - what I would do is abandon the thread-pool. Instead I would have a simple queue that you can push work to in both threads - a very small critical section to push things into and across that queue. One thread for UI, and one thread for LOK. You can use LOK from multiple threads (if you're lucky) but it won't give any advantage. HTH, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSoC] Integrating LO with GNOME - WR#8
Please correct me if I am wrong. On Mon, Jul 20, 2015 at 3:25 PM, Pranav Kant pranav...@gmail.com wrote: On Mon, Jul 20, 2015 at 3:16 PM, Michael Meeks michael.me...@collabora.com wrote: Hi Pranav, On Mon, 2015-07-20 at 01:04 +0530, Pranav Kant wrote: This week I made few enhancements to the threading infrastructure that I coded last week taking inspiration from Libreoffice Android. Now I am making use of a thread pool, instead of creating a new thread(s) everytime. All the LOK calls are now being called in thread(s) reused from this pool. Hah =) so one thing that makes this particularly non-useful is the fact that LibreOfficeKit is single-plus-epsilon threaded ;-) So you'll get no useful benefit from using more than a single thread. I am making use of thread pool, but this pool consists of only single thread. All the LOK calls will be queued and can reuse this thread, hence saving me the time that it would take to create a new thread (expensive process) for each LOK call. This was the reason behind making use of thread pool. I had no intention of using more than one thread for LOK calls. -- Regards, Pranav Kant http://pranavk.me -- Regards, Pranav Kant http://pranavk.me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92766] EDITING : Firebird Embedded database choice not available when Enable experiment feature switch is ON (Win64 bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=92766 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added CC||d.ostrov...@gmx.de --- Comment #4 from Lionel Elie Mamane lio...@mamane.lu --- DavidO, you in charge of the Windows 64 bits port? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81118] UI: add fit page size to drawing button to the page format window
https://bugs.documentfoundation.org/show_bug.cgi?id=81118 --- Comment #3 from sergio.calleg...@gmail.com --- Still valid as of 5.0.0.3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87532] Arial Bold Italic font Times New Roman Italic font does not display Arabic characters
https://bugs.documentfoundation.org/show_bug.cgi?id=87532 --- Comment #7 from yousifjka...@yahoo.com --- Sorry, I mean version 4.4.5 RC1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39268] UI: Drawing tools should not switch back to Selection tool
https://bugs.documentfoundation.org/show_bug.cgi?id=39268 --- Comment #18 from tommy27 ba...@quipo.it --- still reproducible with LibO 4.4.5.1 and 5.1.0.0.alpha1+ (x64) Build ID: 449d272daf5e99f039cdfdd25f020bd798fb9e1d TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-08_08:13:06 Locale: it-IT (it_IT) I suspect it has always been like that also in the OOo era. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - officecfg/registry sfx2/source
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 13 ++-
sfx2/source/dialog/templdlg.cxx| 23 +
2 files changed, 28 insertions(+), 8 deletions(-)
New commits:
commit 6c7451681a5c5408a73fc25595c228f7922fbd29
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Tue Jul 14 14:19:23 2015 +0900
tdf#91495 add property to turn off stlye previews
Newly added property Office::Common::StylesAndFormatting::Preview
can now be used to turn off Style And Formatting style preview.
Change-Id: I2e01de2a74e2d295557c87022a7b745ce23b4800
(cherry picked from commit 210f42a318cbac62de835ccacbc1fc0e36f713f6)
Reviewed-on: https://gerrit.libreoffice.org/17177
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 6f0dcb7..730c712 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -2162,7 +2162,7 @@
!-- UIHints: Tools Options - General Save - [Section] Save --
info
descSpecifies whether to generate a thumbnail image and place it
inside the
- the odf archive file, which makes it possible to see a preview of
the document./desc
+the odf archive file, which makes it possible to see a preview of
the document./desc
labelStore a preview of this document/label
/info
valuetrue/value
@@ -6626,5 +6626,16 @@
/prop
/group
/group
+group oor:name=StylesAndFormatting
+ info
+descContains settings for Styles and Formatting./desc
+ /info
+ prop oor:name=Preview oor:type=xs:boolean oor:nillable=false
+info
+ descSpecifies if the styles and formatting preview is
enabled./desc
+/info
+valuetrue/value
+ /prop
+/group
/component
/oor:component-schema
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 722b6c8..d99a5e4 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -32,6 +32,7 @@
#include com/sun/star/beans/PropertyValue.hpp
#include com/sun/star/frame/ModuleManager.hpp
#include com/sun/star/frame/theUICommandDescription.hpp
+#include officecfg/Office/Common.hxx
#include sfx2/sfxhelp.hxx
#include sfx2/app.hxx
@@ -526,8 +527,11 @@
StyleTreeListBox_Impl::StyleTreeListBox_Impl(SfxCommonTemplateDialog_Impl* pPare
void StyleTreeListBox_Impl::Recalc()
{
-SetEntryHeight(32 * GetDPIScaleFactor());
-RecalcViewData();
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+SetEntryHeight(32 * GetDPIScaleFactor());
+RecalcViewData();
+}
}
/** Internal structure for the establishment of the hierarchical view */
@@ -638,9 +642,11 @@ SvTreeListEntry* FillBox_Impl(SvTreeListBox* pBox,
{
SvTreeListEntry* pTreeListEntry = pBox-InsertEntry(pEntry-getName(),
pParent);
-StyleLBoxString* pStyleLBoxString = new StyleLBoxString(pTreeListEntry, 0,
pEntry-getName(), eStyleFamily);
-
-pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, pEntry-getName(), eStyleFamily);
+pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+}
pBox-GetModel()-InvalidateEntry(pTreeListEntry);
@@ -1242,8 +1248,11 @@ void
SfxCommonTemplateDialog_Impl::UpdateStyles_Impl(sal_uInt16 nFlags)
for(nPos = 0; nPos nCount; ++nPos)
{
SvTreeListEntry* pTreeListEntry =
aFmtLb-InsertEntry(aStrings[nPos], 0, false, nPos);
-StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, aStrings[nPos], eFam);
-pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+if
(officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, aStrings[nPos], eFam);
+pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+}
aFmtLb-GetModel()-InvalidateEntry(pTreeListEntry);
}
aFmtLb-Recalc();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/core/data/column3.cxx |4 1 file changed, 4 insertions(+) New commits: commit 9519a22cdffbd2bd69ce3dd0f264b80b357c8409 Author: Eike Rathke er...@redhat.com Date: Fri Jul 17 18:14:27 2015 +0200 Resolves: tdf#92767 use ISO 8601 for internal date string representation Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40 (cherry picked from commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e) Reviewed-on: https://gerrit.libreoffice.org/17173 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 8173e67..d50e443 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -2020,6 +2020,10 @@ class FilterEntriesHandler fVal = rtl::math::approxFloor(fVal); mbHasDates = true; bDate = true; +// Convert string representation to ISO 8601 date to eliminate +// locale dependent behaviour later when filtering for dates. +sal_uInt32 nIndex = pFormatter-GetFormatIndex( NF_DATE_DIN_MMDD); +pFormatter-GetInputLineString( fVal, nIndex, aStr); } // maybe extend ScTypedStrData enum is also an option here mrStrings.push_back(ScTypedStrData(aStr, fVal, ScTypedStrData::Value,bDate)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92685] Add PageNumber Header option ...
https://bugs.documentfoundation.org/show_bug.cgi?id=92685 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise --- Comment #2 from Jan Holesovsky ke...@collabora.com --- Changing the component to ux-advise to collect the UX input :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92685] Add PageNumber Header option ...
https://bugs.documentfoundation.org/show_bug.cgi?id=92685 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise --- Comment #2 from Jan Holesovsky ke...@collabora.com --- Changing the component to ux-advise to collect the UX input :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/data/column3.cxx |4 1 file changed, 4 insertions(+) New commits: commit 5b0c58818bcbe921075052b2dd11000edfade28b Author: Eike Rathke er...@redhat.com Date: Fri Jul 17 18:14:27 2015 +0200 Resolves: tdf#92767 use ISO 8601 for internal date string representation Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40 (cherry picked from commit 3e17ed1fc2845da5a279d21ffa3ea51d637e515e) Reviewed-on: https://gerrit.libreoffice.org/17172 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 6c99226..40ec240 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -2020,6 +2020,10 @@ class FilterEntriesHandler fVal = rtl::math::approxFloor(fVal); mbHasDates = true; bDate = true; +// Convert string representation to ISO 8601 date to eliminate +// locale dependent behaviour later when filtering for dates. +sal_uInt32 nIndex = pFormatter-GetFormatIndex( NF_DATE_DIN_MMDD); +pFormatter-GetInputLineString( fVal, nIndex, aStr); } // maybe extend ScTypedStrData enum is also an option here mrStrings.push_back(ScTypedStrData(aStr, fVal, ScTypedStrData::Value,bDate)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - filter/qa filter/source
filter/qa/cppunit/data/tiff/fail/crash-6.tiff |binary filter/source/graphicfilter/itiff/itiff.cxx |2 ++ 2 files changed, 2 insertions(+) New commits: commit f391df6c4616910a7f3cffb4d16a2e22531e6a90 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 20 09:24:48 2015 +0100 final check np bounds Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876 (cherry picked from commit dcbbe7741a08f6076f9e020f90cbb730c1edafb9) Reviewed-on: https://gerrit.libreoffice.org/17213 Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/filter/qa/cppunit/data/tiff/fail/crash-6.tiff b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff new file mode 100644 index 000..907b510 Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/crash-6.tiff differ diff --git a/filter/source/graphicfilter/itiff/itiff.cxx b/filter/source/graphicfilter/itiff/itiff.cxx index 69067c5..3f7d728 100644 --- a/filter/source/graphicfilter/itiff/itiff.cxx +++ b/filter/source/graphicfilter/itiff/itiff.cxx @@ -561,6 +561,8 @@ bool TIFFReader::ReadMap( sal_uLong nMinPercent, sal_uLong nMaxPercent ) if ( nStrip = nNumStripOffsets ) return false; pTIFF-Seek( pStripOffsets[ nStrip ] + ( ny % GetRowsPerStrip() ) * nStripBytesPerRow ); +if (np = SAL_N_ELEMENTS(pMap)) +return false; pTIFF-Read( pMap[ np ], nBytesPerRow ); if ( pTIFF-GetError() ) return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - connectivity/source dbaccess/source filter/qa filter/source
connectivity/source/commontools/RowFunctionParser.cxx |2
dbaccess/source/ext/macromigration/macromigrationwizard.cxx |2
dbaccess/source/ext/macromigration/migrationengine.cxx |8 +-
dbaccess/source/ext/macromigration/migrationerror.hxx |2
dbaccess/source/ext/macromigration/progressmixer.cxx|4 -
dbaccess/source/ext/macromigration/progressmixer.hxx|2
dbaccess/source/ext/macromigration/rangeprogressbar.hxx |2
dbaccess/source/filter/xml/dbloader2.cxx|4 -
dbaccess/source/filter/xml/xmlAutoStyle.hxx |2
dbaccess/source/filter/xml/xmlExport.cxx|2
dbaccess/source/filter/xml/xmlfilter.hxx|2
dbaccess/source/sdbtools/connection/connectiondependent.hxx |4 -
dbaccess/source/sdbtools/connection/connectiontools.hxx |2
dbaccess/source/ui/app/AppController.cxx|4 -
filter/qa/cppunit/data/tiff/fail/hang-6.tiff|binary
filter/source/graphicfilter/itiff/ccidecom.cxx | 39 ++--
16 files changed, 43 insertions(+), 38 deletions(-)
New commits:
commit c02e79874951ba86d926186e284612806d8bc0a3
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 10:06:59 2015 +0100
ensure loop ends eventually
Change-Id: I318385286fcc27ffb2d938237d83e793564d2525
diff --git a/filter/qa/cppunit/data/tiff/fail/hang-6.tiff
b/filter/qa/cppunit/data/tiff/fail/hang-6.tiff
new file mode 100644
index 000..4e6cc0e
Binary files /dev/null and b/filter/qa/cppunit/data/tiff/fail/hang-6.tiff differ
diff --git a/filter/source/graphicfilter/itiff/ccidecom.cxx
b/filter/source/graphicfilter/itiff/ccidecom.cxx
index 2f76777..4a49f73 100644
--- a/filter/source/graphicfilter/itiff/ccidecom.cxx
+++ b/filter/source/graphicfilter/itiff/ccidecom.cxx
@@ -886,36 +886,41 @@ void CCIDecompressor::FillBits(sal_uInt8 * pTarget,
sal_uInt16 nTargetBits,
}
}
-
sal_uInt16 CCIDecompressor::CountBits(const sal_uInt8 * pData, sal_uInt16
nDataSizeBits,
sal_uInt16 nBitPos, sal_uInt8 nBlackOrWhite)
{
-sal_uInt16 nPos,nLo;
-sal_uInt8 nData;
-
// here the number of bits belonging together is being counted
// which all have the color nBlackOrWhite (0xff oder 0x00)
// from the position nBitPos on
-
-nPos=nBitPos;
-for (;;) {
-if (nPos=nDataSizeBits) {
+sal_uInt16 nPos = nBitPos;
+for (;;)
+{
+if (nPos=nDataSizeBits)
+{
nPos=nDataSizeBits;
break;
}
-nData=pData[nPos3];
-nLo=nPos 7;
-if ( nLo==0 nData==nBlackOrWhite) nPos+=8;
-else {
-if ( ((nData^nBlackOrWhite) (0x80 nLo))!=0) break;
-nPos++;
+sal_uInt8 nData = pData[nPos3];
+sal_uInt16 nLo = nPos 7;
+if (nLo==0 nData==nBlackOrWhite)
+{
+//fail on overflow attempt
+if (nPos SAL_MAX_UINT16-8)
+return 0;
+nPos+=8;
+}
+else
+{
+if ( ((nData^nBlackOrWhite) (0x80 nLo))!=0)
+break;
+++nPos;
}
}
-if (nPos=nBitPos) return 0;
-else return nPos-nBitPos;
+if (nPos=nBitPos)
+return 0;
+return nPos-nBitPos;
}
-
void CCIDecompressor::Read1DScanlineData(sal_uInt8 * pTarget, sal_uInt16
nTargetBits)
{
sal_uInt16 nCode,nCodeBits,nDataBits,nTgtFreeByteBits;
commit ff3a3bfd4bbd2fdabea887e1739faacd79aefa64
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 20 10:07:53 2015 +0100
cppcheck: noExplicitConstructor
Change-Id: Ib9373a5a75eea998a86156ff742e7950369ddc88
diff --git a/connectivity/source/commontools/RowFunctionParser.cxx
b/connectivity/source/commontools/RowFunctionParser.cxx
index 5ab..7efeb9c 100644
--- a/connectivity/source/commontools/RowFunctionParser.cxx
+++ b/connectivity/source/commontools/RowFunctionParser.cxx
@@ -228,7 +228,7 @@ class UnaryFunctionExpression : public ExpressionNode
ExpressionNodeSharedPtr mpArg;
public:
-UnaryFunctionExpression( const ExpressionNodeSharedPtr rArg ) :
+explicit UnaryFunctionExpression( const ExpressionNodeSharedPtr rArg ) :
mpArg( rArg )
{
}
diff --git a/dbaccess/source/ext/macromigration/macromigrationwizard.cxx
b/dbaccess/source/ext/macromigration/macromigrationwizard.cxx
index 740a337..a8c3018 100644
--- a/dbaccess/source/ext/macromigration/macromigrationwizard.cxx
+++ b/dbaccess/source/ext/macromigration/macromigrationwizard.cxx
@@ -60,7 +60,7 @@ namespace dbmm
,public MacroMigrationModuleClient
{
public:
-MacroMigrationDialogService( const Reference XComponentContext
_rxContext );
+explicit MacroMigrationDialogService( const Reference
XComponentContext _rxContext );
// XTypeProvider
virtual Sequence
[Libreoffice-bugs] [Bug 60062] Language change via Format-Cell-Font is ignored by SPELL check until save-close-reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=60062 Raymond Willems raymond.will...@me.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #17 from Raymond Willems raymond.will...@me.com --- The Bug is gone in LibreOffice 4.4. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/qa filter/source
filter/qa/cppunit/data/pict/pass/tdf92789.pct |binary
filter/source/graphicfilter/ipict/ipict.cxx | 62 ++
2 files changed, 25 insertions(+), 37 deletions(-)
New commits:
commit cdb14f5b40ec3da72ccd2a0258745b899b5fee62
Author: osnola alo...@loria.fr
Date: Mon Jul 20 08:49:59 2015 +0200
tdf92789 fix reading of some PICT images
(cherry picked from commit 5fa73031aa42b62ccd167f193376565df2e635fc)
Conflicts:
filter/source/graphicfilter/ipict/ipict.cxx
add a test image
(cherry picked from commit 3f0677b86f4831b011a2baece85cf93c68646cd5)
Change-Id: I6809ef52c462958eed2329fe2d32b5cbc691194c
Reviewed-on: https://gerrit.libreoffice.org/17203
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/filter/qa/cppunit/data/pict/pass/tdf92789.pct
b/filter/qa/cppunit/data/pict/pass/tdf92789.pct
new file mode 100644
index 000..2d6f0d8
Binary files /dev/null and b/filter/qa/cppunit/data/pict/pass/tdf92789.pct
differ
diff --git a/filter/source/graphicfilter/ipict/ipict.cxx
b/filter/source/graphicfilter/ipict/ipict.cxx
index 4f0c39b..53f4c3a 100644
--- a/filter/source/graphicfilter/ipict/ipict.cxx
+++ b/filter/source/graphicfilter/ipict/ipict.cxx
@@ -879,7 +879,7 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap, bool
bBaseAddr, bool bColo
}
else
{
-nCount = static_castsal_uInt16( 1 - ( (
(sal_uInt16)nFlagCounterByte ) | 0xff00 ) );
+nCount = static_castsal_uInt16( 1 - sal_Int16( (
(sal_uInt16)nFlagCounterByte ) | 0xff00 ) );
pPict-ReadUChar( nDat );
for ( i = 0; i nCount; i++ )
{
@@ -901,21 +901,10 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap,
bool bBaseAddr, bool bColo
if (nWidth nRowBytes / 2)
BITMAPERROR;
-size_t nMinRecordSize;
-if ( nRowBytes 8 || nPackType == 1 )
-nMinRecordSize = sizeof(sal_uInt16);
-else if ( nRowBytes 250 )
-nMinRecordSize = sizeof(sal_uInt16);
-else
-nMinRecordSize = 1;
-
-const size_t nMinRowWidth = nWidth * nMinRecordSize;
-const size_t nMaxRows = pPict-remainingSize() / nMinRowWidth;
-if (nHeight nMaxRows)
-BITMAPERROR;
-const size_t nMaxCols = pPict-remainingSize() / nHeight;
-if (nWidth nMaxCols)
-BITMAPERROR;
+if ( nRowBytes 8 || nPackType == 1 ) {
+if (pPict-remainingSize() sizeof(sal_uInt16) * nHeight * nWidth)
+BITMAPERROR;
+}
for ( ny = 0; ny nHeight; ny++ )
{
@@ -952,10 +941,17 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap,
bool bBaseAddr, bool bColo
if ( (nFlagCounterByte 0x80) == 0)
{
nCount=((sal_uInt16)nFlagCounterByte)+1;
-if ( nCount + nx nWidth) // SJ: the RLE
decoding seems not to be correct here,
-nCount = nWidth - nx; // I don't
want to change this until I have a bugdoc for
-for (i=0; inCount; i++)// this case.
Have a look at 32bit, there I changed the
-{ // encoding,
so that it is used a straight forward array
+if ( nCount + nx nWidth)
+nCount = nWidth - nx;
+if (pPict-remainingSize() sizeof(sal_uInt16) *
nCount)
+BITMAPERROR;
+/* SJ: the RLE decoding seems not to be correct here,
+ I don't want to change this until I have a bugdoc
for
+ this case. Have a look at 32bit, there I changed the
+ encoding, so that it is used a straight forward
array
+ */
+for (i=0; inCount; i++)
+{
pPict-ReadUInt16( nD );
nRed = (sal_uInt8)( nD 7 );
nGreen = (sal_uInt8)( nD 2 );
@@ -965,7 +961,9 @@ sal_uLong PictReader::ReadPixMapEtc( Bitmap rBitmap, bool
bBaseAddr, bool bColo
}
else
{
-nCount=(1-(((sal_uInt16)nFlagCounterByte)|0xff00));
+if (pPict-remainingSize() sizeof(sal_uInt16))
+BITMAPERROR;
+
nCount=(1-sal_Int16(((sal_uInt16)nFlagCounterByte)|0xff00));
if ( nCount + nx nWidth )
nCount = nWidth - nx;
[Libreoffice-bugs] [Bug 73390] Paste Special issue with merged cells
https://bugs.documentfoundation.org/show_bug.cgi?id=73390 --- Comment #12 from tommy27 ba...@quipo.it --- still reproducible with LibO 4.4.5.1 and 5.1.0.0.alpha1+ (x64) Build ID: 449d272daf5e99f039cdfdd25f020bd798fb9e1d TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-08_08:13:06 Locale: it-IT (it_IT) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang include/sfx2 vcl/unx
compilerplugins/clang/unusedmethods.py | 12 include/sfx2/app.hxx |1 - include/sfx2/docfac.hxx|1 - include/sfx2/docfile.hxx |1 - include/sfx2/progress.hxx |3 --- include/sfx2/sfxbasemodel.hxx |2 -- include/sfx2/tbxctrl.hxx |7 ++- vcl/unx/gtk/window/gtksalframe.cxx |2 +- 8 files changed, 11 insertions(+), 18 deletions(-) New commits: commit 63c29ff0adfc3893adf8bcb8934720312aaf11e8 Author: Noel Grandin n...@peralex.com Date: Mon Jul 20 10:55:59 2015 +0200 fix linux buildbot the GTK3 version check for the GDK_IS_X11_DISPLAY macro does not appear to work well on all the machines Change-Id: I7020afdca1b270f89910753737c2c70b61453b34 diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index 2abc94f..2cb31bc 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -105,7 +105,7 @@ #define IS_WIDGET_MAPPED GTK_WIDGET_MAPPED #endif -#if !GTK_CHECK_VERSION(3,10,0) +#ifndef GDK_IS_X11_DISPLAY #define GDK_IS_X11_DISPLAY(foo) (true) #endif commit 600ed089e242a80f5fbf3131b63995eed9d33f3f Author: Noel Grandin n...@peralex.com Date: Fri Jul 17 15:50:48 2015 +0200 loplugin:unusedmethods sfx2 Change-Id: I40be06a4859a38ef64b6267515917f625a5f176d diff --git a/compilerplugins/clang/unusedmethods.py b/compilerplugins/clang/unusedmethods.py index 27118b2..f76fcb7 100755 --- a/compilerplugins/clang/unusedmethods.py +++ b/compilerplugins/clang/unusedmethods.py @@ -89,16 +89,16 @@ for clazz in sorted(definitionSet - callSet - exclusionSet): continue # if this method is const, and there is a non-const variant of it, and the non-const variant is in use, then leave it alone if (clazz.startswith(const ) and clazz.endswith( const)): -clazz2 = clazz[6:len(clazz)-12] +clazz2 = clazz[6:len(clazz)-6] if (clazz2 in callSet): continue elif (clazz.endswith( const)): -clazz2 = clazz[:len(clazz)-6] +clazz2 = clazz[:len(clazz)-6] # strip off const if (clazz2 in callSet): continue if (clazz.endswith( const) and clazz.find(::iterator) != -1): -clazz2 = clazz.replace(::const_iterator, ::iterator) -clazz2 = clazz2[:len(clazz)-6] # strip off const +clazz2 = clazz[:len(clazz)-6] # strip off const +clazz2 = clazz2.replace(::const_iterator, ::iterator) if (clazz2 in callSet): continue # if this method is non-const, and there is a const variant of it, and the const variant is in use, then leave it alone @@ -121,6 +121,10 @@ for clazz in sorted(definitionSet - callSet - exclusionSet): or clazz.find(DdeItem::) != -1 or clazz.find(DdeGetPutItem::) != -1): continue +# the include/tools/rtti.hxx stuff +if (clazz.find(::StaticType()) != -1 +or clazz.find(::IsOf(void *(*)(void))) != -1): + continue print clazz # add an empty line at the end to make it easier for the unusedmethodsremove plugin to mmap() the output file diff --git a/include/sfx2/app.hxx b/include/sfx2/app.hxx index 1cb6fd7..77e6267 100644 --- a/include/sfx2/app.hxx +++ b/include/sfx2/app.hxx @@ -119,7 +119,6 @@ class SFX2_DLLPUBLIC SfxApplication: public SfxShell DECL_DLLPRIVATE_LINK_TYPED( GlobalBasicErrorHdl_Impl, StarBASIC*, bool ); -static SfxApplication* Create(); voidDeinitialize(); public: diff --git a/include/sfx2/docfac.hxx b/include/sfx2/docfac.hxx index 02eb345..ea8d0e8 100644 --- a/include/sfx2/docfac.hxx +++ b/include/sfx2/docfac.hxx @@ -79,7 +79,6 @@ public: SfxModule* GetModule() const; SAL_DLLPRIVATE void SetModule_Impl( SfxModule* ); -SAL_DLLPRIVATE static void UpdateFilterContainers_Impl(); SAL_DLLPRIVATE sal_uInt16 GetViewNo_Impl( const sal_uInt16 i_nViewId, const sal_uInt16 i_nFallback ) const; private: diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx index 338986e2..d5404e2 100644 --- a/include/sfx2/docfile.hxx +++ b/include/sfx2/docfile.hxx @@ -63,7 +63,6 @@ class SFX2_DLLPUBLIC SfxMedium : public SvRefBase SAL_DLLPRIVATE void CloseInStream_Impl(); SAL_DLLPRIVATE bool CloseOutStream_Impl(); SAL_DLLPRIVATE void CloseStreams_Impl(); -DECL_DLLPRIVATE_STATIC_LINK( SfxMedium, UCBHdl_Impl, sal_uInt32 * ); SAL_DLLPRIVATE void SetEncryptionDataToStorage_Impl(); diff --git a/include/sfx2/progress.hxx b/include/sfx2/progress.hxx index 4a618c5..b1c05e3 100644 --- a/include/sfx2/progress.hxx +++ b/include/sfx2/progress.hxx @@ -62,9 +62,6 @@ public: static SfxProgress* GetActiveProgress( SfxObjectShell *pDocSh = 0 ); static void EnterLock(); static void LeaveLock(); - -DECL_DLLPRIVATE_STATIC_LINK( SfxProgress, SetStateHdl,
[Libreoffice-bugs] [Bug 92036] Writer infinite spelling loop ...
https://bugs.documentfoundation.org/show_bug.cgi?id=92036 --- Comment #4 from Michael Meeks michael.me...@collabora.com --- The issue in 4.4.4.x would be not quite so bad I think - since the idle handler wont' be nearly as active - but will still be consuming CPU. I guess it prolly depends how long the paragraph is there though ;-) with a multi-page mixed-language paragraph I imagine we could see this bite us in old versions too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sfx2/source
sfx2/source/dialog/templdlg.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit a5712755e6af5318d264d7e2f5efb28e747b110f
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Sat Jul 18 17:18:25 2015 +0900
tdf#91495 don't change tree entry height when preview is disabled
Change-Id: Ic707f4407bb3aef5f2a7b9d13a0340c6d9afb3fe
(cherry picked from commit 9f75bad228ca1f410b7a450084b02ad13745110e)
Reviewed-on: https://gerrit.libreoffice.org/17178
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index d99a5e4..ad73163 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -330,8 +330,11 @@
SfxActionListBox::SfxActionListBox(SfxCommonTemplateDialog_Impl* pParent, WinBit
void SfxActionListBox::Recalc()
{
-SetEntryHeight(32 * GetDPIScaleFactor());
-RecalcViewData();
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+SetEntryHeight(32 * GetDPIScaleFactor());
+RecalcViewData();
+}
}
PopupMenu* SfxActionListBox::CreateContextMenu()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/b6cad3faff530a84a585a3d8bb965568fe96ef97/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
