[Libreoffice-commits] core.git: comphelper/source framework/source include/comphelper include/unotools unotools/source
comphelper/source/misc/stillreadwriteinteraction.cxx | 26 ++-
framework/source/loadenv/loadenv.cxx | 14 ++
include/comphelper/stillreadwriteinteraction.hxx |6 +++-
include/unotools/mediadescriptor.hxx |1
unotools/source/misc/mediadescriptor.cxx | 25 --
5 files changed, 62 insertions(+), 10 deletions(-)
New commits:
commit bc9a8ddbb7081f79e915c841e56fd1c40f0df6f9
Author: Giuseppe Castagno giuseppe.casta...@acca-esse.eu
Date: Sat Jul 18 18:29:13 2015 +0200
tdf#82744: fix WebDAV lock/unlock behaviour - part 2
Changes done to the code in framework, comphelper and unotools,
in no particular order
- add an interaction handler dedicated to WebDAV
The stock interaction handler can be missing depending on the need of
the framework performing its tasks, so a dedicated handler is
provided, this one is always present.
- force opening of a WebDAV file.
A WebDAV file sould be open r/o even if explicitly requested to open
as r/w.
This is a limitation of current WebDAV implementation, not of the
standard.
This change is needed in order to reopen correctly a file as
requested by a 'Edit Mode' GUI command.
Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082
Reviewed-on: https://gerrit.libreoffice.org/17182
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/comphelper/source/misc/stillreadwriteinteraction.cxx
b/comphelper/source/misc/stillreadwriteinteraction.cxx
index 1ad24fa..2dbe73c 100644
--- a/comphelper/source/misc/stillreadwriteinteraction.cxx
+++ b/comphelper/source/misc/stillreadwriteinteraction.cxx
@@ -23,14 +23,20 @@
#include com/sun/star/task/XInteractionAbort.hpp
+#include com/sun/star/task/XInteractionApprove.hpp
+
#include com/sun/star/ucb/UnsupportedDataSinkException.hpp
+#include com/sun/star/ucb/AuthenticationRequest.hpp
+
namespace comphelper{
-StillReadWriteInteraction::StillReadWriteInteraction(const
css::uno::Reference css::task::XInteractionHandler xHandler)
+StillReadWriteInteraction::StillReadWriteInteraction(const
css::uno::Reference css::task::XInteractionHandler xHandler,
+ const
css::uno::Reference css::task::XInteractionHandler xAuthenticationHandler)
: m_bUsed(false)
, m_bHandledByMySelf (false)
, m_bHandledByInternalHandler(false)
+ , m_xAuthenticationHandler(xAuthenticationHandler)
{
::std::vector ::ucbhelper::InterceptedInteraction::InterceptedRequest
lInterceptions;
::ucbhelper::InterceptedInteraction::InterceptedRequest
aInterceptedRequest;
@@ -47,6 +53,12 @@ StillReadWriteInteraction::StillReadWriteInteraction(const
css::uno::Reference
aInterceptedRequest.MatchExact = false;
lInterceptions.push_back(aInterceptedRequest);
+aInterceptedRequest.Handle = HANDLE_AUTHENTICATIONREQUESTEXCEPTION;
+aInterceptedRequest.Request = css::ucb::AuthenticationRequest();
+aInterceptedRequest.Continuation =
cppu::UnoTypecss::task::XInteractionApprove::get();
+aInterceptedRequest.MatchExact = false;
+lInterceptions.push_back(aInterceptedRequest);
+
setInterceptedHandler(xHandler);
setInterceptions(lInterceptions);
}
@@ -96,6 +108,18 @@ ucbhelper::InterceptedInteraction::EInterceptionState
StillReadWriteInteraction:
bAbort = true;
}
break;
+case HANDLE_AUTHENTICATIONREQUESTEXCEPTION:
+ {
+//use internal authentication dedicated handler and return
+ if (m_xAuthenticationHandler.is())
+ {
+ m_xAuthenticationHandler-handle(xRequest);
+ return ::ucbhelper::InterceptedInteraction::E_INTERCEPTED;
+ }
+ else //simply abort
+ bAbort = true;
+ }
+ break;
}
// handle interaction by ourself
diff --git a/framework/source/loadenv/loadenv.cxx
b/framework/source/loadenv/loadenv.cxx
index 8b3ebfe..79e56a0 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -325,12 +325,16 @@ void LoadEnv::initializeUIDefaults( const
css::uno::Reference css::uno::XCompon
}
}
-if (
-(xInteractionHandler.is()
)
-
(io_lMediaDescriptor.find(utl::MediaDescriptor::PROP_INTERACTIONHANDLER()) ==
io_lMediaDescriptor.end())
- )
+if ( xInteractionHandler.is() )
{
-io_lMediaDescriptor[utl::MediaDescriptor::PROP_INTERACTIONHANDLER()]
= xInteractionHandler;
+if(
io_lMediaDescriptor.find(utl::MediaDescriptor::PROP_INTERACTIONHANDLER()) ==
io_lMediaDescriptor.end() )
+
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 --- Comment #16 from Yury yury.tarasiev...@gmail.com --- Do we get anything to test? I'm not sure I'm up to building from git tree. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: distro-configs/LibreOfficeLinux.conf
distro-configs/LibreOfficeLinux.conf |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 420be486f04d99b08311151a4230699099184baa Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Wed Jul 22 18:40:32 2015 +0200 new linux baseline (CentOS 6) * enable kde4 * switch from gnome-vfs2 to gio Change-Id: Ieb115bc4632d0ce38c3f3af0ca70d707f33bd238 diff --git a/distro-configs/LibreOfficeLinux.conf b/distro-configs/LibreOfficeLinux.conf index 0175ff9..645c92f 100644 --- a/distro-configs/LibreOfficeLinux.conf +++ b/distro-configs/LibreOfficeLinux.conf @@ -22,10 +22,13 @@ --enable-odk --enable-lockdown --enable-kde +--enable-kde4 +--disable-gtk3 --enable-gstreamer-0-10 --disable-gstreamer-1-0 --enable-evolution2 ---enable-gnome-vfs +--disable-gnome-vfs +--enable-gio --enable-scripting-beanshell --enable-scripting-javascript --enable-ext-wiki-publisher @@ -34,8 +37,5 @@ --enable-python=internal --enable-online-update --disable-dconf ---disable-gio --disable-randr-link ---disable-kde4 ---disable-gtk3 --enable-mergelibs ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Need help with temporary files
On Wed, Jul 22, 2015 at 10:20 AM, Caolán McNamara caol...@redhat.com wrote: On Wed, 2015-07-22 at 13:15 +0200, Noel Grandin wrote: On 2015-07-22 01:07 PM, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:43 +0100, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:28 +0100, Caolán McNamara wrote: On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 E_MFILE, too many open files, so the problem is a file handle leak. See https://gerrit.libreoffice.org/#/c/17289/ for a possible solution. That odt has 14k files in it and in parallel deflate mode each one gets a separate ZipOutputEntry which all exist at the same time until the threads are completed. Each ZipOutputEntry has an open temp file so it runs out of file handles. We should be using some kind of task-manager/thread-pool to limit the number of active threads to something reasonable. Running more than approx no_cores * 3 threads is going to __reduce__ performance. That's already the case, there are only no_cores active threads at a time, its just that the final .zip is stitched up from 14k Entries (each with an open stream) at the end of the process. While in non-thread mode there is each entry is created, processed and disposed of serially so there's only one entry alive at a time. couldn't you have a n+1 thread whose job is to get the different threads temp work and process them as you go... I assume the last step is to get all the fragment and put them in one final big file.. that can be done with the worker thread using a pipe to send that to a 'merger' thread (one output fragment at the time with a minimal header) that pull from these pipes (select() or poll()) as each worker thread finish they post a eot message and close their pipe.. the merger thread then doing the role of the thread joiner that must likely exist today anyway You would have 2*n + 1 mx fd open n=nb_core for that. Norbert PS: I'm just bikesheeding based on generic concept.. I do not know the specific of that particular code. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92874] New: Slide show doesn't display correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=92874 Bug ID: 92874 Summary: Slide show doesn't display correctly Product: LibreOffice Version: 4.4.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mpredosin+libreoff...@gmail.com Created attachment 117379 -- https://bugs.documentfoundation.org/attachment.cgi?id=117379action=edit powerpoint file Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 Locale: en_US Steps to reproduce: 1. Open the attached powerpoint file in Impress 4.4.4.3 2. Hit F5 to start slide show Expected Result: The slide show should display correctly. Actual Results: The first slide is blank. Subsequent slides are displayed incorrectly. The powerpoint file can be viewed correctly using the Microsoft Powerpoint viewer (free download). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81118] UI: add fit page size to drawing button to the page format window
https://bugs.documentfoundation.org/show_bug.cgi?id=81118 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Severity|normal |enhancement --- Comment #5 from Yousuf (Jay) Philips philip...@hotmail.com --- Think this is a useful enhancement and think the command should also be accessible in the Format or Modify menu. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - 140 commits - basctl/source basegfx/source basic/inc basic/qa basic/source bin/gbuild-to-ide canvas/README canvas/source canvas/
Rebased ref, commits from common ancestor:
commit 0ec64ce1d2ffbbf6e17026b069d4b47bb905a9d3
Author: Pranav Kant pran...@gnome.org
Date: Wed Jul 22 20:25:36 2015 +0530
lokdocview, tilebuffer: Add DOxygen comments
Change-Id: I27377f0a758729a7877cfc6a56ea1b4bb3d1c3c9
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 0e51b13..2259d5b 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -36,6 +36,7 @@
// Number of handles around a graphic selection.
#define GRAPHIC_HANDLE_COUNT 8
+/// Private struct used by this GObject type
struct _LOKDocViewPrivate
{
gchar* m_aLOPath;
@@ -162,6 +163,7 @@ G_DEFINE_TYPE_WITH_CODE (LOKDocView, lok_doc_view,
GTK_TYPE_DRAWING_AREA,
static GThreadPool* lokThreadPool;
+/// Helper struct used to pass the data from soffice thread - main thread.
struct CallbackData
{
int m_nType;
@@ -174,8 +176,16 @@ struct CallbackData
m_pDocView(pDocView) {}
};
+/**
+ A struct that we use to store the data about the LOK call.
+
+ Object of this type is passed with all the LOK calls,
+ so that they can be idenitified. Additionally, it also contains
+ the data that LOK call needs.
+*/
struct LOEvent
{
+/// To identify the type of LOK call
int m_nType;
const gchar* m_pCommand;
const gchar* m_pArguments;
@@ -187,6 +197,8 @@ struct LOEvent
int m_nCharCode;
int m_nKeyCode;
+
+/// Constructor to easily instantiate an object for LOK call of `type'
type.
LOEvent(int type)
: m_nType(type) {}
diff --git a/libreofficekit/source/gtk/tilebuffer.hxx
b/libreofficekit/source/gtk/tilebuffer.hxx
index 50de72d..40fb2ab 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -131,6 +131,11 @@ class TileBuffer
Tile m_DummyTile;
};
+/**
+ Helper struct used to pass the data from main thread to spawned threads.
+ Spawned threads are responsible for calling paintTile, and store the result
+ in tile buffer.
+*/
struct GetTileCallbackData
{
int m_nX;
commit 8b3d8aee24c05fc3d999d58d6587c6e52f43a761
Author: Pranav Kant pran...@gnome.org
Date: Sun Jul 19 01:03:56 2015 +0530
lokdocview: Make paintTile() async
Change-Id: I57db9e3adf26996e6e1e105b8b95f53e88e7760f
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 8054c8e..0e51b13 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -520,7 +520,7 @@ setTilesInvalid (LOKDocView* pDocView, const GdkRectangle
rRectangle)
for (int i = aStart.x; i aEnd.x; i++)
for (int j = aStart.y; j aEnd.y; j++)
-priv-m_aTileBuffer.setInvalid(i, j);
+priv-m_aTileBuffer.setInvalid(i, j, priv-m_fZoom);
}
static gboolean
@@ -741,6 +741,12 @@ renderGraphicHandle(LOKDocView* pDocView,
}
}
+static void
+renderDocumentCallback(GObject* source_object, GAsyncResult*, gpointer)
+{
+LOKDocView* pDocView = LOK_DOC_VIEW(source_object);
+gtk_widget_queue_draw(GTK_WIDGET(pDocView));
+}
static gboolean
renderDocument(LOKDocView* pDocView, cairo_t* pCairo)
@@ -790,7 +796,9 @@ renderDocument(LOKDocView* pDocView, cairo_t* pCairo)
if (bPaint)
{
-Tile currentTile = priv-m_aTileBuffer.getTile(nRow, nColumn,
priv-m_fZoom);
+GTask* task = g_task_new(pDocView, NULL,
renderDocumentCallback, NULL);
+Tile currentTile = priv-m_aTileBuffer.getTile(nRow, nColumn,
priv-m_fZoom, task);
+
GdkPixbuf* pPixBuf = currentTile.getBuffer();
gdk_cairo_set_source_pixbuf (pCairo, pPixBuf,
twipToPixel(aTileRectangleTwips.x, priv-m_fZoom),
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 60aa16f..d488f8b 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -27,6 +27,42 @@ float twipToPixel(float fInput, float zoom)
return fInput / 1440.0f * DPI * zoom;
}
+static void getTileFunc(GTask*, gpointer, gpointer task_data, GCancellable*)
+{
+GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
+GetTileCallbackData* pCallback =
static_castGetTileCallbackData*(task_data);
+TileBuffer* buffer = pCallback-m_pBuffer;
+int index = pCallback-m_nX * buffer-m_nWidth + pCallback-m_nY;
+if (!pPixBuf)
+{
+g_info (Error allocating memory to pixbuf);
+return;
+}
+
+unsigned char* pBuffer = gdk_pixbuf_get_pixels(pPixBuf);
+GdkRectangle aTileRectangle;
+aTileRectangle.x = pixelToTwip(nTileSizePixels, pCallback-m_fZoom) *
pCallback-m_nY;
+aTileRectangle.y = pixelToTwip(nTileSizePixels, pCallback-m_fZoom) *
pCallback-m_nX;
[Libreoffice-bugs] [Bug 92853] Changeing Textorientation in calc can easily result in systems UI crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92853 --- Comment #7 from thack...@nexgo.de --- Hello Filip, *, thanks for your answers :) To not click on reply at every of your comments, I will try to answer a couple of questions, where I may know the answer, and add some further comments ... ;) To Comment2: I did entered the text and changed the orientation without and with hitting enter, but it still did not crash, although if I repeat the steps a couple of times ... :( I seem to be wrong with my NVidia graphics chip (or I have two ... ;) ), as glxinfo gives me quote glxinfo | grep -i opengl OpenGL vendor string: Intel Open Source Technology Center OpenGL renderer string: Mesa DRI Intel(R) Haswell Mobile OpenGL core profile version string: 3.3 (Core Profile) Mesa 10.5.9 OpenGL core profile shading language version string: 3.30 OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile OpenGL core profile extensions: OpenGL version string: 3.0 Mesa 10.5.9 OpenGL shading language version string: 1.30 OpenGL context flags: (none) OpenGL extensions: OpenGL ES profile version string: OpenGL ES 3.0 Mesa 10.5.9 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00 OpenGL ES profile extensions: /quote . To Comment3: You got me wrong: I did not mean to disable Hardware acceleration, but to look, if you have enabled Use OpenGL for all rendering and Force OpenGL, even if blacklisted To Comment4: Nice, that you have found a workaround :) Congrats :) To Comment5: Sorry, I have no idea, where you can find this :( To Comment6: Still not confirmed here, sorry ... :( Could you do me a favour and start Calc with quote /path/to/your/installation/scalc --backtrace /quote and try to crash it again, please? This would produce a file called gbdtrace.log. It would be nice, if you could attach it to this bug, though I for myself would not be able to help you with its output, sorry ... :( Sorry for the inconvenience Thomas. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - canvas/source
canvas/source/directx/dx_9rm.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 5df3725f81564a8380209881b6f2c48b2fe158b3 Author: Michael Meeks michael.me...@collabora.com Date: Tue Jul 21 22:18:09 2015 +0100 tdf#91574 - ensure we get paint events to render directx presenter console. This is an odd-one; lots of details in the bug. Change-Id: I287945eba965cc637642e9226c7fe7f2a0754130 Reviewed-on: https://gerrit.libreoffice.org/17274 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Jan Holesovsky ke...@collabora.com diff --git a/canvas/source/directx/dx_9rm.cxx b/canvas/source/directx/dx_9rm.cxx index ba03c53..2b756fe 100644 --- a/canvas/source/directx/dx_9rm.cxx +++ b/canvas/source/directx/dx_9rm.cxx @@ -683,7 +683,6 @@ namespace dxcanvas mpWindow-SetControlForeground(); mpWindow-SetControlBackground(); -mpWindow-EnablePaint(sal_False); const SystemEnvData *pData = mpWindow-GetSystemData(); const HWND hwnd(reinterpret_castHWND(pData-hWnd)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js |8 +---
loleaflet/src/layer/tile/TileLayer.js |4
2 files changed, 1 insertion(+), 11 deletions(-)
New commits:
commit 929cf9e06127312a702b3586e463b7ad7c0ec36b
Author: Mihai Varga mihai.va...@collabora.com
Date: Wed Jul 22 18:17:38 2015 +0300
loleaflet: disabled prefetching in editing mode
Because the server discards requests that are already in the queue so
we can no longer keep track of the number of requested/received tiles.
This count was used to determine if the user is idle (not editing) so
we can prefetch tiles in the meanwhile
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index 96b510c..c82490f 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -517,7 +517,6 @@ L.GridLayer = L.Layer.extend({
// we know that a new set of tiles that cover
the whole view has been requested
// so we're able to cancel the previous
requests that are being processed
this.sendMessage('canceltiles');
- this._pendingTilesCount = 0;
for (key in this._tiles) {
if (!this._tiles[key].loaded) {
L.DomUtil.remove(this._tiles[key].el);
@@ -662,7 +661,6 @@ L.GridLayer = L.Layer.extend({
if (!this._tileCache[key]) {
if (this.options.useSocket this._map.socket) {
var twips = this._coordsToTwips(coords);
- this._pendingTilesCount += 1;
this.sendMessage('tile ' +
'part=' +
coords.part + ' ' +
'width=' +
this._tileSize + ' ' +
@@ -790,17 +788,13 @@ L.GridLayer = L.Layer.extend({
},
_preFetchTiles: function () {
- if (this._pendingTilesCount 0) {
+ if (this._permission === 'edit') {
return;
}
var center = this._map.getCenter();
var zoom = this._map.getZoom();
var tilesToFetch = 10;
var maxBorderWidth = 5;
- if (this._permission === 'edit') {
- tilesToFetch = 2;
- maxBorderWidth = 2;
- }
if (!this._preFetchBorder) {
var pixelBounds = this._map.getPixelBounds(center,
zoom),
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 02ae828..67c9f88 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -90,7 +90,6 @@ L.TileLayer = L.GridLayer.extend({
}),
draggable: true
});
- this._pendingTilesCount = 0;
this._textArea = L.DomUtil.get('clipboard');
this._textArea.focus();
},
@@ -392,9 +391,6 @@ L.TileLayer = L.GridLayer.extend({
else {
this._tileCache[key] = img;
}
- if (this._pendingTilesCount 0) {
- this._pendingTilesCount -= 1;
- }
L.Log.log(textMsg, L.INCOMING, key);
}
else if (textMsg.startsWith('textselection:')) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sot/qa sot/source sw/qa
dev/null |binary
sot/qa/cppunit/data/fail/fdo41642-2.compound |binary
sot/source/sdstor/stgdir.cxx | 11 ---
sot/source/sdstor/stgdir.hxx |3 ++-
sot/source/sdstor/stgelem.cxx| 25 -
sot/source/sdstor/stgelem.hxx|2 +-
sw/qa/core/data/ww8/fail/hang-2.doc |binary
sw/qa/core/data/ww8/pass/tdf57532-1.doc |binary
8 files changed, 31 insertions(+), 10 deletions(-)
New commits:
commit 786573068dce1f71c53057f98b5822c401c9f3ff
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 09:24:53 2015 +0100
limit storage entry max size to size of underlying stream
Change-Id: Ie3772338009c07fea40b637621b1170863830e14
Reviewed-on: https://gerrit.libreoffice.org/17296
Reviewed-by: Michael Meeks michael.me...@collabora.com
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sot/qa/cppunit/data/pass/fdo41642-2.compound
b/sot/qa/cppunit/data/fail/fdo41642-2.compound
similarity index 100%
rename from sot/qa/cppunit/data/pass/fdo41642-2.compound
rename to sot/qa/cppunit/data/fail/fdo41642-2.compound
diff --git a/sot/source/sdstor/stgdir.cxx b/sot/source/sdstor/stgdir.cxx
index 6ee4a61..e2c8bf7 100644
--- a/sot/source/sdstor/stgdir.cxx
+++ b/sot/source/sdstor/stgdir.cxx
@@ -48,9 +48,9 @@
// Problem der Implementation: Keine Hierarchischen commits. Daher nur
// insgesamt transaktionsorientert oder direkt.
-StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, bool *
pbOk ) : StgAvlNode()
+StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen,
sal_uInt64 nUnderlyingStreamSize, bool * pbOk ) : StgAvlNode()
{
-*pbOk = aEntry.Load( pBuffer, nBufferLen );
+*pbOk = aEntry.Load( pBuffer, nBufferLen, nUnderlyingStreamSize );
InitMembers();
}
@@ -819,8 +819,13 @@ void StgDirStrm::SetupEntry( sal_Int32 n, StgDirEntry*
pUpper )
void* p = ( n == STG_FREE ) ? NULL : GetEntry( n );
if( p )
{
+SvStream *pUnderlyingStream = rIo.GetStrm();
+sal_uInt64 nCur = pUnderlyingStream-Tell();
+sal_uInt64 nUnderlyingStreamSize =
pUnderlyingStream-Seek(STREAM_SEEK_TO_END);
+pUnderlyingStream-Seek(nCur);
+
bool bOk(false);
-StgDirEntry* pCur = new StgDirEntry( p, STGENTRY_SIZE, bOk );
+StgDirEntry* pCur = new StgDirEntry( p, STGENTRY_SIZE,
nUnderlyingStreamSize, bOk );
if( !bOk )
{
diff --git a/sot/source/sdstor/stgdir.hxx b/sot/source/sdstor/stgdir.hxx
index c0924f1..55be53d 100644
--- a/sot/source/sdstor/stgdir.hxx
+++ b/sot/source/sdstor/stgdir.hxx
@@ -62,7 +62,8 @@ public:
bool bDirect; // true: direct mode
bool bZombie; // true: Removed From StgIo
bool bInvalid; // true: invalid entry
-StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, bool * pbOk );
+StgDirEntry(const void* pBuffer, sal_uInt32 nBufferLen,
+sal_uInt64 nUnderlyingStreamSize, bool * pbOk);
StgDirEntry( const StgEntry );
virtual ~StgDirEntry();
diff --git a/sot/source/sdstor/stgelem.cxx b/sot/source/sdstor/stgelem.cxx
index 8e2f9bd..bb85e9f 100644
--- a/sot/source/sdstor/stgelem.cxx
+++ b/sot/source/sdstor/stgelem.cxx
@@ -361,7 +361,7 @@ sal_Int32 StgEntry::Compare( const StgEntry r ) const
// These load/store operations are a bit more complicated,
// since they have to copy their contents into a packed structure.
-bool StgEntry::Load( const void* pFrom, sal_uInt32 nBufSize )
+bool StgEntry::Load(const void* pFrom, sal_uInt32 nBufSize, sal_uInt64
nUnderlyingStreamSize)
{
if ( nBufSize 128 )
return false;
@@ -392,11 +392,26 @@ bool StgEntry::Load( const void* pFrom, sal_uInt32
nBufSize )
if (n nMaxLegalStr)
return false;
-if ((cType != STG_STORAGE) ((nSize 0) || (nPage1 0
!isKnownSpecial(nPage1
+if (cType != STG_STORAGE)
{
-// the size makes no sense for the substorage
-// TODO/LATER: actually the size should be an unsigned value, but in
this case it would mean a stream of more than 2Gb
-return false;
+if (nPage1 0 !isKnownSpecial(nPage1))
+{
+//bad pageid
+return false;
+}
+if (nSize 0)
+{
+// the size makes no sense for the substorage
+// TODO/LATER: actually the size should be an unsigned value, but
+// in this case it would mean a stream of more than 2Gb
+return false;
+}
+if (static_castsal_uInt64(nSize) nUnderlyingStreamSize)
+{
+// surely an entry cannot be larger than the underlying file
+return false;
+}
+
}
aName = OUString(nName , n);
diff --git a/sot/source/sdstor/stgelem.hxx
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 197 commits - accessibility/inc accessibility/source animations/source avmedia/source basctl/Library_basctl.mk basctl
Rebased ref, commits from common ancestor:
commit 7452219d0042114381b0b3adbe0272686a77004a
Author: Szymon KÅos eszka...@gmail.com
Date: Wed Jul 22 17:20:26 2015 +0200
show error when directory doesn't exist
Change-Id: I1c8ca1a509c9187687079d86f0e637b26490a7a3
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index bd35802..4e69c9d 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -462,7 +462,7 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
if( m_pFileView )
{
-if( ContentIsFolder( sURL ) )
+if( !sURL.isEmpty() ContentIsFolder( sURL ) )
{
OUString sFilter = FILEDIALOG_FILTER_ALL;
@@ -496,6 +496,9 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
else
{
// content doesn't exist
+m_pTreeView-EndSelection();
+ErrorHandler::HandleError( ERRCODE_IO_NOTEXISTS );
+return eFailure;
}
}
@@ -689,13 +692,13 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, DoubleClickHdl )
{
OUString sURL = m_pFileView-GetCurrentURL();
-if( ContentIsFolder( sURL ) )
+if( ContentIsDocument( sURL ) )
{
-OpenURL( sURL );
+EndDialog( RET_OK );
}
else
{
-EndDialog( RET_OK );
+OpenURL( sURL );
}
}
@@ -1043,6 +1046,26 @@ bool RemoteFilesDialog::ContentIsFolder( const OUString
rURL )
return false;
}
+bool RemoteFilesDialog::ContentIsDocument( const OUString rURL )
+{
+try
+{
+Reference XComponentContext xContext =
::comphelper::getProcessComponentContext();
+Reference XInteractionHandler xInteractionHandler(
+InteractionHandler::createWithParent( xContext, 0 ),
UNO_QUERY_THROW );
+Reference XCommandEnvironment xEnv = new
::ucbhelper::CommandEnvironment( xInteractionHandler, Reference
XProgressHandler () );
+::ucbhelper::Content aContent( rURL, xEnv, xContext );
+
+return aContent.isDocument();
+}
+catch( const Exception )
+{
+// a content doesn't exist
+}
+
+return false;
+}
+
sal_Int32 RemoteFilesDialog::getTargetColorDepth()
{
// This dialog doesn't contain preview
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx
b/fpicker/source/office/RemoteFilesDialog.hxx
index ede30c7..b0f151e 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -16,6 +16,7 @@
#include svtools/breadcrumb.hxx
#include svtools/fileview.hxx
+#include tools/errinf.hxx
#include tools/resid.hxx
#include vcl/button.hxx
@@ -81,6 +82,7 @@ public:
virtual const OUString GetPath() SAL_OVERRIDE;
virtual std::vectorOUString GetPathList() const SAL_OVERRIDE;
virtual bool ContentIsFolder( const OUString rURL ) SAL_OVERRIDE;
+virtual bool ContentIsDocument( const OUString rURL );
virtual void AddFilter( const OUString rFilter, const OUString rType )
SAL_OVERRIDE;
virtual void AddFilterGroup( const OUString _rFilter,
commit 81d20fe15bc9e20e86bd2ea36d59b7c8f19d0b5e
Author: Szymon KÅos eszka...@gmail.com
Date: Wed Jul 22 16:42:47 2015 +0200
reload content while expanding node
Change-Id: I7ce281ea4e2d5c5c9fc0b2b3f315defc14364df3
diff --git a/svtools/source/contnr/foldertree.cxx
b/svtools/source/contnr/foldertree.cxx
index 63cc7e0..d597168 100644
--- a/svtools/source/contnr/foldertree.cxx
+++ b/svtools/source/contnr/foldertree.cxx
@@ -32,9 +32,14 @@ void FolderTree::RequestingChildren( SvTreeListEntry* pEntry
)
void FolderTree::FillTreeEntry( SvTreeListEntry* pEntry )
{
-// fill only empty entries
-if( pEntry GetChildCount( pEntry ) == 0 )
+if( pEntry )
{
+while( GetChildCount( pEntry ) 0 )
+{
+SvTreeListEntry* pChild = FirstChild( pEntry );
+GetModel()-Remove( pChild );
+}
+
::std::vector SortingData_Impl* aContent;
::rtl::Reference ::svt::FileViewContentEnumerator
commit bda20aacb34eac82d0297ffbcb8a34c2744c556c
Author: Szymon KÅos eszka...@gmail.com
Date: Wed Jul 22 15:19:37 2015 +0200
check if path exist before init of the fileview
Change-Id: I0c9384644cf5aabf83512c341d35d4847f36
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index 75615d1..bd35802 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -462,34 +462,41 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
if( m_pFileView )
{
-OUString sFilter = FILEDIALOG_FILTER_ALL;
-
-if( m_nCurrentFilter != LISTBOX_ENTRY_NOTFOUND )
+if( ContentIsFolder( sURL ) )
{
-
[Libreoffice-bugs] [Bug 90736] FILEOPEN: PPTX table cell border line style is not import and export as well.
https://bugs.documentfoundation.org/show_bug.cgi?id=90736 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- TESTING on Ubuntu 14.04 + Version: 5.1.0.0.alpha1+ Build ID: 85ce6a2446deb0f4c01604b6188f969603de9b16 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-07-09_02:29:43 Locale: en-US (en_US.UTF-8) (In reply to Yogesh Bharate from comment #0) Step to reproduce: 1. open attached PPTX or create similar document in MSO2010. 2. Open in LibreOffice, it does not show the line style of border which dot in my case. Just to be clear: MSO2010 renders the line as dotted? Does LibreOffice on your machine render a solid border line, or just not show anything? (testing on my machine, the box border line is visible and appears to be a solid line) 3. save as .pptx, and open the roundtrip file in MSO2010 again border lines are missing and set solid by default. (I unfortunately don't have MSO2010 right here to test that part) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Need help with temporary files
On Wed, 2015-07-22 at 13:15 +0200, Noel Grandin wrote: On 2015-07-22 01:07 PM, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:43 +0100, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:28 +0100, Caolán McNamara wrote: On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 E_MFILE, too many open files, so the problem is a file handle leak. See https://gerrit.libreoffice.org/#/c/17289/ for a possible solution. That odt has 14k files in it and in parallel deflate mode each one gets a separate ZipOutputEntry which all exist at the same time until the threads are completed. Each ZipOutputEntry has an open temp file so it runs out of file handles. We should be using some kind of task-manager/thread-pool to limit the number of active threads to something reasonable. Running more than approx no_cores * 3 threads is going to __reduce__ performance. That's already the case, there are only no_cores active threads at a time, its just that the final .zip is stitched up from 14k Entries (each with an open stream) at the end of the process. While in non-thread mode there is each entry is created, processed and disposed of serially so there's only one entry alive at a time. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 89973] Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=89973 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|NEW |UNCONFIRMED CC||qu...@runcibility.com Ever confirmed|1 |0 --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Silex from comment #0) Calc With black as back Ground there are various problems. Hi Silex, Has a 3rd party been able to confirm this bug? (moving back to UNCONFIRMED until we have verification of confirmation) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92866] Keyboard command shortcuts don't work in start centre
https://bugs.documentfoundation.org/show_bug.cgi?id=92866 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote vstuart.fo...@utsa.edu --- @Matthew, isn't this a duplicate of bug 92516 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl starmath/inc starmath/source vcl/source
include/vcl/ctrl.hxx|2 --
starmath/inc/dialog.hxx |1 +
starmath/source/dialog.cxx |4
vcl/source/control/ctrl.cxx | 20 +---
4 files changed, 10 insertions(+), 17 deletions(-)
New commits:
commit 94ceda8b2fea37587424b664e17fa9ee8b01e158
Author: Katarina Behrens katarina.behr...@cib.de
Date: Wed Jul 22 11:27:24 2015 +0200
tdf#92600: Restore ability to apply font settings to controls
SmShowSymbol handles font/fg/bg settings by itself, so make
ApplySettings noop there.
This partially reverts commit b010e4074e5d5ee3a3905f1351f04efafe937c2a
Change-Id: Ib5074684ef1277d9b9b4646bd73dce4cbff3943e
Reviewed-on: https://gerrit.libreoffice.org/17288
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/include/vcl/ctrl.hxx b/include/vcl/ctrl.hxx
index d33982b..0f689d0 100644
--- a/include/vcl/ctrl.hxx
+++ b/include/vcl/ctrl.hxx
@@ -41,8 +41,6 @@ protected:
private:
boolmbHasControlFocus;
-boolmbFont;
-boolmbForeground;
boolmbShowAccelerator;
Link maGetFocusHdl;
Link maLoseFocusHdl;
diff --git a/starmath/inc/dialog.hxx b/starmath/inc/dialog.hxx
index a34e505..968d12e 100644
--- a/starmath/inc/dialog.hxx
+++ b/starmath/inc/dialog.hxx
@@ -327,6 +327,7 @@ class SmShowSymbol : public Control
Link aDblClickHdlLink;
virtual voidPaint(vcl::RenderContext rRenderContext, const
Rectangle) SAL_OVERRIDE;
+virtual voidApplySettings(vcl::RenderContext rRenderContext)
SAL_OVERRIDE;
virtual voidMouseButtonDown(const MouseEvent rMEvt) SAL_OVERRIDE;
virtual voidResize() SAL_OVERRIDE;
diff --git a/starmath/source/dialog.cxx b/starmath/source/dialog.cxx
index 59a08b59..70e7f29 100644
--- a/starmath/source/dialog.cxx
+++ b/starmath/source/dialog.cxx
@@ -1384,6 +1384,10 @@ void SmShowSymbol::Resize()
Invalidate();
}
+void SmShowSymbol::ApplySettings(vcl::RenderContext /*rRenderContext*/ )
+{
+}
+
void SmShowSymbol::setFontSize(vcl::Font rFont) const
{
rFont.SetSize(Size(0, GetOutputSize().Height() - GetOutputSize().Height()
/ 3));
diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx
index 61a1ad7..6062d1a 100644
--- a/vcl/source/control/ctrl.cxx
+++ b/vcl/source/control/ctrl.cxx
@@ -36,8 +36,6 @@ using namespace vcl;
void Control::ImplInitControlData()
{
mbHasControlFocus = false;
-mbFont = false;
-mbForeground= false;
mbShowAccelerator = false;
mpControlData = new ImplControlData;
}
@@ -425,23 +423,15 @@ void Control::ApplySettings(vcl::RenderContext
rRenderContext)
{
const StyleSettings rStyleSettings =
rRenderContext.GetSettings().GetStyleSettings();
-if (mbFont)
-{
-vcl::Font rFont(GetCanonicalFont(rStyleSettings));
-ApplyControlFont(rRenderContext, rFont);
-}
+vcl::Font rFont(GetCanonicalFont(rStyleSettings));
+ApplyControlFont(rRenderContext, rFont);
-if (mbFont || mbForeground)
-{
-ApplyControlForeground(rRenderContext,
GetCanonicalTextColor(rStyleSettings));
-rRenderContext.SetTextFillColor();
-}
+ApplyControlForeground(rRenderContext,
GetCanonicalTextColor(rStyleSettings));
+rRenderContext.SetTextFillColor();
}
-void Control::ImplInitSettings(const bool _bFont, const bool _bForeground)
+void Control::ImplInitSettings(const bool, const bool)
{
-mbFont = _bFont;
-mbForeground = _bForeground;
ApplySettings(*this);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/webdav-neon/webdavcontent.cxx | 108 ++-
ucb/source/ucp/webdav-neon/webdavcontent.hxx |1
2 files changed, 91 insertions(+), 18 deletions(-)
New commits:
commit 26e6d4b05ab444e6a7529ffcac7fbe592fc94833
Author: Giuseppe Castagno giuseppe.casta...@acca-esse.eu
Date: Sat Jul 18 18:23:50 2015 +0200
tdf#82744: fix WebDAV lock/unlock behaviour - part 1
There are some areas in ucb outside the issue scope that should later
be addressed, among them:
- in ucb/webdav make flag m_bTransient working right, currently lock
option for WebDAV server not supporting it is suboptimal: there are
not needed lock requests;
- change the method the modified file is checked against the old
one, using DAV:etag instead of the DateTime;
- some http status code returned by the server don't seem to be
managed;
- during WebDAV operation some redundant request of properties is
carried out.
Probably some clean up to remove these not needed transactions
is to be done.
Accessing only those really supported by the referenced href would
be better.
Changes done to the code in ucb, in no particular order
- remove current WebDAV lock management
- have the lock/unlock working correctly when the webdav resource
is first created: in the case of creation is the first lock on
the non existent resource that actually creates it
- fix a problem while fetching WebDAV properties.
If a single WebDAV non-cached property was requested, it would
not be fetched from the server without this fix.
- change the lock owner name.
This should probably be different. Something to be discussed.
This same string can be read by all the applications accessing the
lock.
Spec reference is:
RFC4918 [2007]: '14.17. owner XML Element'
link (as of 20150713):
http://tools.ietf.org/html/rfc4918#section-14.17
- manage WebDAV locked file exception directly while locking.
The ucb::InteractiveLockingLockedException is thrown directly
when detected by the lock command, to avoid the user interaction
activated by the cancelCommandExecution method.
- terminate gracefully if WebDAV lock/unlock is not supported
Change-Id: I4c5cd652ac7b2c32fb1c3307c34fc31d1a0305c2
Reviewed-on: https://gerrit.libreoffice.org/17080
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Meeks michael.me...@collabora.com
diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 8862b42..3fc1755 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -93,8 +93,6 @@ using namespace com::sun::star;
using namespace webdav_ucp;
-
-
// Content Implementation.
@@ -112,7 +110,6 @@ Content::Content(
m_eResourceType( UNKNOWN ),
m_pProvider( pProvider ),
m_bTransient( false ),
- m_bLocked( false ),
m_bCollection( false ),
m_bDidGetOrHead( false )
{
@@ -145,7 +142,6 @@ Content::Content(
m_eResourceType( UNKNOWN ),
m_pProvider( pProvider ),
m_bTransient( true ),
- m_bLocked( false ),
m_bCollection( isCollection ),
m_bDidGetOrHead( false )
{
@@ -166,8 +162,6 @@ Content::Content(
// virtual
Content::~Content()
{
-if (m_bLocked)
-unlock(uno::Reference ucb::XCommandEnvironment ());
}
@@ -504,10 +498,6 @@ uno::Any SAL_CALL Content::execute(
aRet = open( aOpenCommand, Environment );
-if ( (aOpenCommand.Mode == ucb::OpenMode::DOCUMENT ||
- aOpenCommand.Mode == ucb::OpenMode::DOCUMENT_SHARE_DENY_WRITE)
- supportsExclusiveWriteLock( Environment ) )
-lock( Environment );
}
else if ( aCommand.Name == insert )
{
@@ -610,12 +600,18 @@ uno::Any SAL_CALL Content::execute(
post( aArg, Environment );
}
-else if ( aCommand.Name == lock supportsExclusiveWriteLock(
Environment ) )
+else if ( aCommand.Name == lock )
{
// lock
-
+// supportsExclusiveWriteLock() does not work if the file is being
created.
+// The lack of lock functionality is taken care of inside lock(),
+// a temporary measure.
+// This current implementation will result in a wasted lock request
issued to web site
+// that don't support it.
+// TODO: need to rewrite the managing of the m_bTransient flag, when
the resource is non yet existent
+// and the first lock on a non existed resource first creates it then
lock it.
lock( Environment );
}
else if ( aCommand.Name == unlock supportsExclusiveWriteLock(
Environment ) )
@@ -1318,7 +1314,13 @@ uno::Reference sdbc::XRow Content::getPropertyValues(
while ( it != end )
{
if ( *it == rName )
+
[Libreoffice-bugs] [Bug 91875] gnumeric format export
https://bugs.documentfoundation.org/show_bug.cgi?id=91875 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added CC||qu...@runcibility.com --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to inpost from comment #0) Please allow spreadsheets to be exported to gnumeric xml format. http://www.mail-archive.com/users@global.libreoffice.org/msg45211.html I'm not sure about this statement The xml of the gnumeric spreadsheet format seems superior (more compact) compared to the xml of the calc module, however export seems like a possible addition, so status: NEW seems fine. What's the use case for Gnumeric XML export? Are there any large companies or groups standardizing on Gnumeric XML? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92873] New: UI Preview of 3D object doesn't resize w/ the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=92873 Bug ID: 92873 Summary: UI Preview of 3D object doesn't resize w/ the dialog Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: katarina.behr...@cib.de 1. Open Draw or Impress 2. Click 3D object toolbar button, insert any 3D object 3. Right click the object, context menu 3D effects 4. A dialog pops up, with 3D object preview in the lower right corner. Resize (enlarge) the dialog = notice the preview size remains constant. I'd expect it to resize along with the dialog -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
in master: failing tests / no matching locale
Hi,
A great many tests fail in master for me (in my dev tree). I looked
into one of them and it is:
in desktop/source/deployment/registry/package/dp_package.cxx, line 1494:
LanguageTag descrTag(iter-second.m_sValue);
/usr/include/c++/5/debug/safe_iterator.h:317:error: attempt to
dereference
a past-the-end iterator.
Objects involved in the operation:
iterator this @ 0x0x7fff558f9b40 {
type =
N11__gnu_debug14_Safe_iteratorINSt8__detail14_Node_iteratorISt4pairIKN3rtl7OStringE24INetContentTypeParameterELb0ELb1EEENSt7__debug13unordered_mapIS5_S7_NS4_11OStringHashE29OString_equalsIgnoreAsciiCaseSaIS8_E
(mutable iterator);
state = past-the-end;
references sequence with type
`NSt7__debug13unordered_mapIN3rtl7OStringE24INetContentTypeParameterNS1_11OStringHashE29OString_equalsIgnoreAsciiCaseSaISt4pairIKS2_S3_'
@ 0x0x7fff558f9c90
}
iter is defined, since
commit 21834f14c97071c5bcf13ef02bf940dc1922663f
Author: Michael Stahl mst...@redhat.com
Date: Wed Jul 15 23:17:20 2015 +0200
tools: replace boost::ptr_vector with std::unordered_map
Change-Id: I530c5f95dda9aa80654e3a2a20a2e236221e7305
as
auto const iter = params.find(platform);
but there does not seem any protection against a not found
situation. This seems to be locale-related. I compile with:
--with-lang=fr de nl en-GB
and I run under:
LANG=fr_LU.utf8
LANGUAGE=
LC_MESSAGES=en_GB.UTF-8
LC_ALL=
This hunk looks suspicious to me:
@@ -1483,14 +1483,15 @@ void BackendImpl::PackageImpl::scanBundle(
subType.equalsIgnoreAsciiCase(
vnd.sun.star.package-bundle-description))
{
// check locale:
-param = params.find(locale);
-if (param == 0) {
+auto const iterLocale = params.find(locale);
+if (iterLocale == params.end())
+{
if (descrFile.isEmpty())
descrFile = url;
}
else {
// match best locale:
-LanguageTag descrTag( param-m_sValue);
+LanguageTag descrTag(iter-second.m_sValue);
if (officeLocale.getLanguage() ==
descrTag.getLanguage())
{
size_t nPenalty = nPenaltyMax;
Whereas before the call to
param = params.find(locale);
would overwrite the value previously given to param, now since there
are two separate variables, in the else branch it is the result of
params.find(platform)
that is used.
--
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac
configure.ac |4 1 file changed, 4 insertions(+) New commits: commit cdd699eacf853192686095399433384109e565a2 Author: Michael Stahl mst...@redhat.com Date: Tue Jul 21 23:07:44 2015 +0200 configure: try not to break with MSVC 2013 Express The devenv.exe /Upgrade is apparently not supported by Express, but that is currently only needed for the 2015 version, so try to keep 2013 Express working. Change-Id: I40bb8a5c9583381e89ede2e014e6e095016bbe11 Reviewed-on: https://gerrit.libreoffice.org/17275 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Vasily Melenchuk vasily.melenc...@cib.de Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de diff --git a/configure.ac b/configure.ac index e7f6872..2d36f0c 100644 --- a/configure.ac +++ b/configure.ac @@ -3568,6 +3568,10 @@ if test $_os = WINNT; then # Find the version of devenv.exe DEVENV=$VC_PRODUCT_DIR/../Common7/IDE/devenv.exe +if test ! -e $DEVENV -a $vcnum = 120; then +# for Visual Studio 2013 Express, fall back +DEVENV=$VC_PRODUCT_DIR/../Common7/IDE/WDExpress.exe +fi if test ! -e $DEVENV; then AC_MSG_ERROR([No devenv.exe found, Visual Studio installation broken?]) fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[GSoC] More and Better Tests - Weekly Report #8 (Varun Dhall)
Hi all! Eighth week of GSoC was passed in writing some new tests using UNO-API and covering some UNO holes that require coverage and testing. Here are the changes made in last 7 days - https://gerrit.libreoffice.org/#/c/17125/ https://gerrit.libreoffice.org/#/c/17141/ https://gerrit.libreoffice.org/#/c/17242/ These changes are successfully merged into the master. Present changes are on gerrit and will be merged soon. Future Goals- Adding more and better unit tests in code-base to assist in finding regressions as early as possible. Regards, Varun Dhall ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92876] INSTALLATION IMPOSSIBLE
https://bugs.documentfoundation.org/show_bug.cgi?id=92876 JACKY lize.ja...@neuf.fr changed: What|Removed |Added Priority|medium |high Version|unspecified |4.4.4.1 rc --- Comment #1 from JACKY lize.ja...@neuf.fr --- LORS DE L'INSTALLATION ERREUR 1714. LA VERSION PRECEDENTE DE LIBREOFFICE 4.4.4.3 N'A PAS PU ÊTRE SUPPRIMEE MERCI D'AVANCE. JACKY LIZE -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92875] New: System does not see 'slide change' events from the remote, thinks is idle and locks/dims screen
https://bugs.documentfoundation.org/show_bug.cgi?id=92875 Bug ID: 92875 Summary: System does not see 'slide change' events from the remote, thinks is idle and locks/dims screen Product: Impress Remote Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sergio.calleg...@gmail.com When you do a presentation, controlling it with the keyboard or the mouse, the systems sees activity and provided that you change slides frequently enough does not lock screen dim screen or start the screen saver. Hence, provided that you have sane enough delays for lock screen/dim screen/screensaver, you can happily do a presentation without any need to disable any of the above. However, if you use the remote, the system does not see any activity and after a few slides locks the screen. The remote backend in Libreoffice should be able to communicate to the system that some activity is going on (e.g. by simulating keypresses corresponding to slide changes). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/rtl
include/rtl/stringutils.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit a6c47236a4c3708398d403abf940f567d15da0a6
Author: David Ostrovsky da...@ostrovsky.org
Date: Mon Jul 6 23:56:44 2015 +0200
Apply special treatment of OUStringLiteral1 to MSVC 2015
Change-Id: I56e69fbdb555bb30cd88d75717d6f716c81ae237
Reviewed-on: https://gerrit.libreoffice.org/16804
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Thorsten Behrens thorsten.behr...@cib.de
diff --git a/include/rtl/stringutils.hxx b/include/rtl/stringutils.hxx
index ff25d4d..d1b3cc4 100644
--- a/include/rtl/stringutils.hxx
+++ b/include/rtl/stringutils.hxx
@@ -77,7 +77,7 @@ templatechar C struct SAL_WARN_UNUSED OUStringLiteral1_ {
non-ASCII character in OUStringLiteral1);
char const c = C;
};
-#if defined _MSC_VER _MSC_VER = 1800 // Visual Studio 2013
+#if defined _MSC_VER _MSC_VER = 1900 // Visual Studio 2015
templatechar C using OUStringLiteral1 = OUStringLiteral1_C;
#pragma warning(disable: 4239)
#else
@@ -216,8 +216,8 @@ template int N
struct ExceptCharArrayDetector const char[ N ]
{
};
-#if defined LIBO_INTERNAL_ONLY defined _MSC_VER _MSC_VER = 1800
-// Visual Studio 2013
+#if defined LIBO_INTERNAL_ONLY defined _MSC_VER _MSC_VER = 1900
+// Visual Studio 2015
templatechar C struct ExceptCharArrayDetectorOUStringLiteral1C {};
#endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92622] WRITER: context menu Unstyle the text from Styles Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=92622 --- Comment #7 from Yousuf (Jay) Philips philip...@hotmail.com --- It would be useful to have UNO commands to reset the various types of styles, primarily paragraph and character styles, as these command would be useful for the styles menu. Buttons for these would also be useful for inclusion in the styles formatting tab similar to the clear direct formatting button i included in this mockup - attachment 115020. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92876] New: INSTALLATION IMPOSSIBLE
https://bugs.documentfoundation.org/show_bug.cgi?id=92876 Bug ID: 92876 Summary: INSTALLATION IMPOSSIBLE Product: LibreOffice Version: unspecified Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: blocker Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lize.ja...@neuf.fr -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92880] CopyFromRecordset function not working since 4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=92880 jorgito1...@gmail.com changed: What|Removed |Added Version|unspecified |4.0 all versions -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92880] CopyFromRecordset function not working since 4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=92880 jorgito1...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx |4 +--
dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx | 14 +--
dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx|4 +--
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx|2 -
dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx|3 +-
dbaccess/source/ui/querydesign/limitboxcontroller.hxx|2 -
dbaccess/source/ui/querydesign/querycontroller.cxx |2 -
dbaccess/source/ui/tabledesign/TEditControl.hxx |2 -
dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx |2 -
dbaccess/source/ui/tabledesign/TableUndo.hxx |2 -
dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx |2 -
dbaccess/source/ui/uno/ColumnControl.hxx |2 -
dbaccess/source/ui/uno/ColumnModel.hxx |2 -
dbaccess/source/ui/uno/DBTypeWizDlg.hxx |2 -
14 files changed, 23 insertions(+), 22 deletions(-)
New commits:
commit 442ab9ceeef471a0d08a97c5d248808e2cb03e2f
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 20:12:48 2015 +0100
cppcheck: noExplicitConstructor
Change-Id: Ib80e7f6d055bead246db3028b4eab6edfabe3d2c
diff --git a/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx
b/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx
index 494e4fb..0c0db3f 100644
--- a/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx
+++ b/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx
@@ -29,7 +29,7 @@ namespace dbaui
class OQueryAddTabConnUndoAction : public OQueryTabConnUndoAction
{
public:
-OQueryAddTabConnUndoAction(OQueryTableView* pOwner);
+explicit OQueryAddTabConnUndoAction(OQueryTableView* pOwner);
virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE;
@@ -40,7 +40,7 @@ namespace dbaui
class OQueryDelTabConnUndoAction : public OQueryTabConnUndoAction
{
public:
-OQueryDelTabConnUndoAction(OQueryTableView* pOwner);
+explicit OQueryDelTabConnUndoAction(OQueryTableView* pOwner);
virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE;
diff --git a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
index a009832..b9a9f4a 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx
@@ -57,12 +57,12 @@ namespace dbaui
sal_Int32 m_nCellIndex;
public:
-OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox)
+explicit OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox)
: OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_MODIFY_CELL)
,m_nCellIndex(BROWSER_INVALIDID){ }
-inline void SetCellContents(const OUString str) {
m_strNextCellContents = str; }
-inline void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex =
nIndex; }
+void SetCellContents(const OUString str) { m_strNextCellContents =
str; }
+void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex = nIndex; }
virtual void Undo() SAL_OVERRIDE;
virtual void Redo() SAL_OVERRIDE { Undo(); }
@@ -76,7 +76,7 @@ namespace dbaui
longm_nNextWidth;
public:
-OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN),
m_nNextWidth(0) { }
+explicit OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN),
m_nNextWidth(0) { }
inline void SetOriginalWidth(long nWidth) { m_nNextWidth = nWidth; }
@@ -106,7 +106,7 @@ namespace dbaui
virtual void Redo() SAL_OVERRIDE {
pOwner-EnterUndoMode();pOwner-RemoveColumn(pDescr-GetColumnId());pOwner-LeaveUndoMode();
}
public:
-OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { }
+explicit OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { }
};
// OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes
@@ -119,7 +119,7 @@ namespace dbaui
virtual void Redo() SAL_OVERRIDE {
pOwner-EnterUndoMode();pOwner-InsertColumn(pDescr,
m_nColumnPostion);pOwner-LeaveUndoMode();}
public:
-OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { }
+explicit OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) :
OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { }
};
// OTabFieldMovedUndoAct - Undo class when a field was moved inside the
selection
@@ -134,7 +134,7 @@
[Libreoffice-bugs] [Bug 92881] New: UI: Underline button is active when Double Underline button is used
https://bugs.documentfoundation.org/show_bug.cgi?id=92881 Bug ID: 92881 Summary: UI: Underline button is active when Double Underline button is used Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gordon1dr...@yahoo.com 1. New Text Document. 2. Right click on Formatting toolbar → Visible Buttons → Double Underline. 3. Type “test”. 4. Select “test” and apply double underline. Expected Result: Double underline button is active. Result: Underline button on toolbar is also active. This report will probably become a non-issue if there is a decision to change the underline button to a dropdown. Windows Vista 64 Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92879] New: enhancement: Moving averages option in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=92879 Bug ID: 92879 Summary: enhancement: Moving averages option in charts Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kie...@gmail.com With a tick box to add moving averages and a box to enter number of data-points to average over. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92880] New: CopyFromRecordset function not working since 4.x
https://bugs.documentfoundation.org/show_bug.cgi?id=92880 Bug ID: 92880 Summary: CopyFromRecordset function not working since 4.x Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jorgito1...@gmail.com The ADODB function CopyFromRecordset does not work, returns BASIC runtime error 423. Tried several LO versions, it works on latest 3.6 but is broken from the first 4.x onwards, so it must be some regression on the 4.x branch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92878] New: Opening Word Perfect File Destroys formatting loses text
https://bugs.documentfoundation.org/show_bug.cgi?id=92878 Bug ID: 92878 Summary: Opening Word Perfect File Destroys formatting loses text Product: LibreOffice Version: 4.4.4.3 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fredow...@fireweb.com Created attachment 117382 -- https://bugs.documentfoundation.org/attachment.cgi?id=117382action=edit sample wordperfect file When opening a wordperfect document the document is blank except for a a word or two in the footer and in some cases a page number or a word in the header. The Word count and character count are correctly shown in the status bar but the words are not visible. The page shows 1 of 1 and the margins are set within the page area so the words should be visible. There are no graphics on the page just some tabs and text. It works fine with Microsoft Word files formatted like these but the WPD files blow up. I've attached a sample file for your use. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92882] New: Cannot substitute quotes in Writer documents created by right clicking wherever you want
https://bugs.documentfoundation.org/show_bug.cgi?id=92882 Bug ID: 92882 Summary: Cannot substitute quotes in Writer documents created by right clicking wherever you want Product: LibreOffice Version: 5.0.0.3 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: leopoldo.sag...@libero.it Prerequisite: In LibreOffice set Tools - Autocorrect Options - Localized Options - Single Double quotes = substitute standard quotes with special ones Then: 1. Create a new .odt file by right clicking on the desktop or whatever you want. 2. Double click on this new file to open it: in these conditions the standard font is Times New Roman 12 instead of Liberation Serif. 3. Start to write something inside the document and quote it. 4. In these conditions the standard single/double quotes are used, and no substitution with the special ones happens. On the contrary, if you: 1. Run Libre Office 2. Create a new .odt file from inside Libre Office then this file uses the correct default font (ie Liberation Serif) and the substitution of the normal single/double quotes with the special ones is ok. No idea of what happens in previous versions of Libre Office. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] please retest Bug 92861
please test this one. very easy and quick to triage. Bug 92861 - AutoCorrect Options checkboxes do not work https://bugs.documentfoundation.org/show_bug.cgi?id=92861 IMHO is an important regression and breaks the autocorrect options -- Using Opera's revolutionary email client: http://www.opera.com/mail/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-ux-advise] [Bug 92877] Bold Italic Underline icons are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=92877 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |INVALID --- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu --- Users are already free to select something they find appealing. Spend some time in Tools - Options - View: User Interface. You'll see that only Tango and Sifr exhibit use of lower case a. Galaxy, Oxygen, and the latest Breeze icon set use stylized B, I, U, even S Resolved Invalid. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92877] Bold Italic Underline icons are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=92877 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |INVALID --- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu --- Users are already free to select something they find appealing. Spend some time in Tools - Options - View: User Interface. You'll see that only Tango and Sifr exhibit use of lower case a. Galaxy, Oxygen, and the latest Breeze icon set use stylized B, I, U, even S Resolved Invalid. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92874] SLIDESHOW: first slide shown blank in .PPT
https://bugs.documentfoundation.org/show_bug.cgi?id=92874 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|Slide show doesn't display |SLIDESHOW: first slide |correctly |shown blank in .PPT --- Comment #1 from tommy27 ba...@quipo.it --- tested under Win8.1 x64 using LibO 4.4.3.2 and 4.4.5.1 I don't reproduce the issue either on a single or on a dual monitor setup. all the 6 slides are correctly shown in the slideshow with no blank first slide. please tell your O/S version then try resetting the user profile (backup first) following the instructions at this link: https://wiki.documentfoundation.org/UserProfile if the issue persists, please post a screenshot of the bug in action P.S. edited summary notes with a clearer description -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92850] Autocorrection of single quotation marks is disabled by default
https://bugs.documentfoundation.org/show_bug.cgi?id=92850 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Version|unspecified |4.4.0.3 release Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- I confirm that under Win8.1 x64 in LibO 4.3.5 that option was enabled while in 4.4.0.4 and following releases (including recent 5.1.0 daily builds) that option is disabled I don't know if that was done on purpose or not. should we call it a regression? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92877] New: Bold Italic Underline icons are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=92877 Bug ID: 92877 Summary: Bold Italic Underline icons are confusing Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marekdole...@gmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Created attachment 117380 -- https://bugs.documentfoundation.org/attachment.cgi?id=117380action=edit Bold, Underline, etc.. writer Bold Italic Underline icons are confusing because they all have A for icon. For Ex: icon for Bold should be B because it is first letter in word bold same should apply for Italic -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92877] Bold Italic Underline icons are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=92877 --- Comment #1 from Marek Dolezel marekdole...@gmail.com --- Created attachment 117381 -- https://bugs.documentfoundation.org/attachment.cgi?id=117381action=edit Font icons in MSO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92877] Bold Italic Underline icons are confusing
https://bugs.documentfoundation.org/show_bug.cgi?id=92877 --- Comment #1 from Marek Dolezel marekdole...@gmail.com --- Created attachment 117381 -- https://bugs.documentfoundation.org/attachment.cgi?id=117381action=edit Font icons in MSO -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 90376] Dragging toolbar doesnt clean up after itself
https://bugs.documentfoundation.org/show_bug.cgi?id=90376 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #4 from tommy27 ba...@quipo.it --- I'm not seeing it under Win8.1 x64 using LibO 5.1.0.0.alpha1+ (x64) Build ID: 591238e8a4f1164adb51d3bada0cd90c3e7c655e TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-22_00:03:41 Locale: en-US (it_IT) would you please guys retest if it's gone for good? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - officecfg/registry sfx2/source
officecfg/registry/schema/org/openoffice/Office/Common.xcs | 13 ++-
sfx2/source/dialog/templdlg.cxx| 23 +
2 files changed, 28 insertions(+), 8 deletions(-)
New commits:
commit 5e42fa59ff1e4f46c05b1c438dd3757dbb7a14d6
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Tue Jul 14 14:19:23 2015 +0900
tdf#91495 add property to turn off stlye previews
Newly added property Office::Common::StylesAndFormatting::Preview
can now be used to turn off Style And Formatting style preview.
Change-Id: I2e01de2a74e2d295557c87022a7b745ce23b4800
(cherry picked from commit 210f42a318cbac62de835ccacbc1fc0e36f713f6)
Reviewed-on: https://gerrit.libreoffice.org/17179
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 6f0dcb7..730c712 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -2162,7 +2162,7 @@
!-- UIHints: Tools Options - General Save - [Section] Save --
info
descSpecifies whether to generate a thumbnail image and place it
inside the
- the odf archive file, which makes it possible to see a preview of
the document./desc
+the odf archive file, which makes it possible to see a preview of
the document./desc
labelStore a preview of this document/label
/info
valuetrue/value
@@ -6626,5 +6626,16 @@
/prop
/group
/group
+group oor:name=StylesAndFormatting
+ info
+descContains settings for Styles and Formatting./desc
+ /info
+ prop oor:name=Preview oor:type=xs:boolean oor:nillable=false
+info
+ descSpecifies if the styles and formatting preview is
enabled./desc
+/info
+valuetrue/value
+ /prop
+/group
/component
/oor:component-schema
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 722b6c8..d99a5e4 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -32,6 +32,7 @@
#include com/sun/star/beans/PropertyValue.hpp
#include com/sun/star/frame/ModuleManager.hpp
#include com/sun/star/frame/theUICommandDescription.hpp
+#include officecfg/Office/Common.hxx
#include sfx2/sfxhelp.hxx
#include sfx2/app.hxx
@@ -526,8 +527,11 @@
StyleTreeListBox_Impl::StyleTreeListBox_Impl(SfxCommonTemplateDialog_Impl* pPare
void StyleTreeListBox_Impl::Recalc()
{
-SetEntryHeight(32 * GetDPIScaleFactor());
-RecalcViewData();
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+SetEntryHeight(32 * GetDPIScaleFactor());
+RecalcViewData();
+}
}
/** Internal structure for the establishment of the hierarchical view */
@@ -638,9 +642,11 @@ SvTreeListEntry* FillBox_Impl(SvTreeListBox* pBox,
{
SvTreeListEntry* pTreeListEntry = pBox-InsertEntry(pEntry-getName(),
pParent);
-StyleLBoxString* pStyleLBoxString = new StyleLBoxString(pTreeListEntry, 0,
pEntry-getName(), eStyleFamily);
-
-pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, pEntry-getName(), eStyleFamily);
+pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+}
pBox-GetModel()-InvalidateEntry(pTreeListEntry);
@@ -1242,8 +1248,11 @@ void
SfxCommonTemplateDialog_Impl::UpdateStyles_Impl(sal_uInt16 nFlags)
for(nPos = 0; nPos nCount; ++nPos)
{
SvTreeListEntry* pTreeListEntry =
aFmtLb-InsertEntry(aStrings[nPos], 0, false, nPos);
-StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, aStrings[nPos], eFam);
-pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+if
(officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+StyleLBoxString* pStyleLBoxString = new
StyleLBoxString(pTreeListEntry, 0, aStrings[nPos], eFam);
+pTreeListEntry-ReplaceItem(pStyleLBoxString, 1);
+}
aFmtLb-GetModel()-InvalidateEntry(pTreeListEntry);
}
aFmtLb-Recalc();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92753] Column width of xlsx are missing in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92753 Sugam suga...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTOURBUG |--- Ever confirmed|0 |1 --- Comment #6 from Sugam suga...@gmail.com --- @Alex Thurgood : Digged in further and found - When the files saved as xlsx from LibreOffice are opened in Excel, the Column widths are not proper. All the columns are displayed with default width. Column xml written by LibreOffice, col collapsed=false hidden=false max=1 min=1 style=0 width=47.8061224489796/ col collapsed=false hidden=false max=2 min=2 style=0 width=2.59183673469388/ col collapsed=false hidden=false max=3 min=3 style=0 width=55.4387755102041/ col collapsed=false hidden=false max=1025 min=4 style=0 width=11.5204081632653/ Column xml written by Excel, col min=1 max=1 width=55.33203125 style=1 customWidth=1/ col min=2 max=2 width=2.1640625 style=3 customWidth=1/ col min=3 max=3 width=67.83203125 style=2 customWidth=1/ LibreOffices misses to write the attribute customWidth=1. If that attribute is added manually to the xml, the file opens with proper width in Excel. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc scripting/source sc/source
sc/inc/attrib.hxx | 11 ---
sc/inc/autoform.hxx|3
sc/inc/brdcst.hxx |1
sc/inc/callform.hxx| 12 +--
sc/inc/cellvalue.hxx |1
sc/inc/cellvalues.hxx |1
sc/inc/chartarr.hxx|4 -
sc/inc/chartlis.hxx|1
sc/inc/chartpos.hxx|5 -
sc/inc/chgtrack.hxx| 27 ---
sc/inc/chgviset.hxx|1
sc/inc/colorscale.hxx |5 -
sc/inc/columnspanset.hxx |2
sc/inc/compiler.hxx|5 -
sc/inc/conditio.hxx|2
sc/inc/dbdata.hxx |4 -
sc/inc/detfunc.hxx |2
sc/inc/document.hxx| 37 +-
sc/inc/dpdimsave.hxx |1
sc/inc/dpgroup.hxx |2
sc/inc/dptabres.hxx| 12 +--
sc/inc/dptabsrc.hxx| 10 +-
sc/inc/formulacell.hxx | 15 ++--
sc/inc/global.hxx |2
sc/inc/hints.hxx |3
sc/inc/lookupcache.hxx |8 --
sc/inc/progress.hxx|6 -
sc/inc/rangenam.hxx|3
sc/inc/scdll.hxx |5 -
sc/inc/scmatrix.hxx|1
sc/inc/scmod.hxx |1
sc/inc/table.hxx | 17 -
sc/inc/tablink.hxx |1
sc/inc/textuno.hxx |1
sc/inc/tokenarray.hxx |3
sc/source/core/data/cellvalue.cxx | 24 ---
sc/source/core/data/cellvalues.cxx |7 --
sc/source/core/data/colorscale.cxx | 44 -
sc/source/core/data/columnspanset.cxx |6 -
sc/source/core/data/document.cxx | 12 ---
sc/source/core/data/document10.cxx | 16
sc/source/core/data/dpdimsave.cxx |4 -
sc/source/core/inc/bcaslot.hxx | 13 ---
sc/source/core/inc/interpre.hxx|2
sc/source/core/tool/autoform.cxx | 16
sc/source/core/tool/rangenam.cxx |3
sc/source/core/tool/token.cxx | 27 ---
sc/source/ui/inc/docsh.hxx |4 -
scripting/source/inc/util/MiscUtils.hxx| 24 ++-
scripting/source/inc/util/scriptingconstants.hxx | 71 -
scripting/source/provider/ActiveMSPList.cxx|1
scripting/source/provider/MasterScriptProvider.cxx |1
scripting/source/provider/MasterScriptProvider.hxx |2
scripting/source/provider/ProviderCache.cxx|2
54 files changed, 40 insertions(+), 454 deletions(-)
New commits:
commit 90e8ad7ab779740c7381d26ffe7d08acc3a9ff96
Author: Noel Grandin n...@peralex.com
Date: Tue Jul 21 15:39:17 2015 +0200
loplugin:unusedmethods scripting,sc
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7
Reviewed-on: https://gerrit.libreoffice.org/17263
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 0c210f5..9c930d1 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -169,12 +169,6 @@ public:
const IntlWrapper* pIntl = 0
) const SAL_OVERRIDE;
virtual SfxPoolItem*Clone( SfxItemPool *pPool = 0 ) const
SAL_OVERRIDE;
-const ScRange GetRange() const{ return aRange; }
-voidSetRange( const ScRange rNew ) { aRange = rNew; }
-
-sal_uInt16 GetFlags() const{ return nFlags; }
-voidSetFlags( sal_uInt16 nNew ) { nFlags = nNew; }
-
private:
ScRange aRange;
sal_uInt16 nFlags;
@@ -306,10 +300,6 @@ public:
virtual SfxPoolItem*Create( SvStream rStream, sal_uInt16 nVer ) const
SAL_OVERRIDE;
-double GetValue() const { return nValue; }
-
-void SetValue( const double nVal ) { nValue = nVal;}
-
private:
double nValue;
};
@@ -343,7 +333,6 @@ public:
inline void SetHeight( sal_uInt16 nHeight ) { mnHeight =
nHeight; }
inline void Set( sal_uInt16 nWidth, sal_uInt16 nHeight )
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/tdf86374.docx|binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 10 ++
writerfilter/source/dmapper/TableManager.hxx |2 ++
writerfilter/source/dmapper/TablePropertiesHandler.cxx | 10 --
4 files changed, 20 insertions(+), 2 deletions(-)
New commits:
commit 233a634a112e6dae07dca5fb1296764cb0001503
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Jul 22 09:24:06 2015 +0200
tdf#86374 DOCX import: fix btLr text table direction without w:cantSplit/
Commit 0208ead70a9412ccd554fcef3e9308f8ca17037b (DOCX import: improve
btLr table cell support, 2013-02-22) made any table row that has at
least one btLr cell fixed height. This causes problems in case a table
has a minimal height with lots of content, where the fixed height gives
wrong layout, but the minimal height is correct.
Fix the problem by only making the row fixed height if w:cantSplit/ is
set (as seen in the old bugdoc), and revert to setting the height type
to minimal in any other case.
Change-Id: Ibaf91f542e64e5caa7904df97eb6eb52618e0023
diff --git a/sw/qa/extras/ooxmlimport/data/tdf86374.docx
b/sw/qa/extras/ooxmlimport/data/tdf86374.docx
new file mode 100644
index 000..7fd772d
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf86374.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 6ae2e0b..4a8d1a9 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -2748,6 +2748,16 @@ DECLARE_OOXMLIMPORT_TEST(testTdf89702, tdf89702.docx)
CPPUNIT_ASSERT_EQUAL(OUString(Arial), getPropertyOUString(xStyle,
CharFontName));
}
+DECLARE_OOXMLIMPORT_TEST(testTdf86374, tdf86374.docx)
+{
+uno::Referencetext::XTextTablesSupplier xTextTablesSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XIndexAccess
xTables(xTextTablesSupplier-getTextTables(), uno::UNO_QUERY);
+uno::Referencetext::XTextTable xTable(xTables-getByIndex(0),
uno::UNO_QUERY);
+uno::Referencetable::XTableRows xTableRows(xTable-getRows(),
uno::UNO_QUERY);
+// btLr text direction was imported as FIX, it should be MIN to have
enough space for the additionally entered paragraphs.
+CPPUNIT_ASSERT_EQUAL(text::SizeType::MIN,
getPropertysal_Int16(xTableRows-getByIndex(0), SizeType));
+}
+
#endif
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/TableManager.hxx
b/writerfilter/source/dmapper/TableManager.hxx
index e3760d0..1a459cd 100644
--- a/writerfilter/source/dmapper/TableManager.hxx
+++ b/writerfilter/source/dmapper/TableManager.hxx
@@ -241,6 +241,7 @@ protected:
mState.resetCellProps();
}
+public:
TablePropertyMapPtr getRowProps()
{
return mState.getRowProps();
@@ -256,6 +257,7 @@ protected:
mState.resetRowProps();
}
+protected:
void setInCell(bool bInCell)
{
mState.setInCell(bInCell);
diff --git a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
index eb29b48..4db5a8c 100644
--- a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
+++ b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
@@ -90,8 +90,14 @@ namespace dmapper {
const int MINLAY = 23; // sw/inc/swtypes.hxx, minimal
possible size of frames.
if (!pManager || !pManager-HasBtlrCell() ||
pMeasureHandler-getMeasureValue()
ConversionHelper::convertTwipToMM100(MINLAY))
{
-// In case a cell already wanted fixed size, we should
not overwrite it here.
-if (!pManager || !pManager-IsRowSizeTypeInserted())
+bool bCantSplit = false;
+if (pManager pManager-getRowProps())
+{
+boost::optionalPropertyMap::Property
oIsSplitAllowed = pManager-getRowProps()-getProperty(PROP_IS_SPLIT_ALLOWED);
+bCantSplit = oIsSplitAllowed
!oIsSplitAllowed-second.getbool();
+}
+// In case a cell already wanted fixed size and the
row has w:cantSplit/, we should not overwrite it here.
+if (!pManager || !pManager-IsRowSizeTypeInserted() ||
!bCantSplit)
pPropMap-Insert( PROP_SIZE_TYPE, uno::makeAny(
pMeasureHandler-GetRowHeightSizeType() ), false);
else
pPropMap-Insert( PROP_SIZE_TYPE,
uno::makeAny(text::SizeType::FIX), false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Buttons.js | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 287ad122d70e0d20ae0e7bfa132805a65c0031b0
Author: Mihai Varga mihai.va...@collabora.com
Date: Wed Jul 22 10:48:31 2015 +0300
loleaflet: fixed paragraph alignment commands
diff --git a/loleaflet/src/control/Control.Buttons.js
b/loleaflet/src/control/Control.Buttons.js
index 70bb1e3..d544ae9 100644
--- a/loleaflet/src/control/Control.Buttons.js
+++ b/loleaflet/src/control/Control.Buttons.js
@@ -12,16 +12,16 @@ L.Control.Buttons = L.Control.extend({
container = L.DomUtil.create('div', buttonsName +
'-container' + ' leaflet-bar');
this._buttons = {
- 'bold': {title: 'Bold', uno:
'Bold',iconName: 'bold.png'},
- 'italic':{title: 'Italic', uno:
'Italic', iconName: 'italic.png'},
- 'underline': {title: 'Underline', uno:
'Underline', iconName: 'underline.png'},
- 'strikethrough': {title: 'Strike-through', uno:
'Strikeout', iconName: 'strikethrough.png'},
- 'alignleft': {title: 'Align left', uno:
'CommonAlignLeft', iconName: 'alignleft.png'},
- 'aligncenter': {title: 'Center horizontaly', uno:
'CommonAlignHorizontalCenter', iconName: 'aligncenter.png'},
- 'alignright':{title: 'Align right',uno:
'CommonAlignRight',iconName: 'alignright.png'},
- 'alignblock':{title: 'Justified', uno:
'CommonAlignJustified',iconName: 'alignblock.png'},
- 'save': {title: 'Save', uno:
'Save',iconName: 'save.png'},
- 'saveas':{title: 'Save As',uno: '',
iconName: 'saveas.png'}
+ 'bold': {title: 'Bold', uno:
'Bold',iconName: 'bold.png'},
+ 'italic':{title: 'Italic', uno:
'Italic', iconName: 'italic.png'},
+ 'underline': {title: 'Underline', uno:
'Underline', iconName: 'underline.png'},
+ 'strikethrough': {title: 'Strike-through', uno:
'Strikeout', iconName: 'strikethrough.png'},
+ 'alignleft': {title: 'Align left', uno:
'LeftPara',iconName: 'alignleft.png'},
+ 'aligncenter': {title: 'Center horizontaly', uno:
'CenterPara', iconName: 'aligncenter.png'},
+ 'alignright':{title: 'Align right',uno:
'RightPara', iconName: 'alignright.png'},
+ 'alignblock':{title: 'Justified', uno:
'JustifyPara', iconName: 'alignblock.png'},
+ 'save': {title: 'Save', uno:
'Save',iconName: 'save.png'},
+ 'saveas':{title: 'Save As',uno: '',
iconName: 'saveas.png'}
};
for (var key in this._buttons) {
var button = this._buttons[key];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional
https://bugs.documentfoundation.org/show_bug.cgi?id=91495 --- Comment #18 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to libreoffice-5-0-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e42fa59ff1e4f46c05b1c438dd3757dbb7a14d6h=libreoffice-5-0-0 tdf#91495 add property to turn off stlye previews It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - sfx2/source
sfx2/source/dialog/templdlg.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 8e957ae85f3cd9a6805296702bae41d30e6f0cef
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Sat Jul 18 17:18:25 2015 +0900
tdf#91495 don't change tree entry height when preview is disabled
Change-Id: Ic707f4407bb3aef5f2a7b9d13a0340c6d9afb3fe
(cherry picked from commit 9f75bad228ca1f410b7a450084b02ad13745110e)
Reviewed-on: https://gerrit.libreoffice.org/17180
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com
diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index d99a5e4..ad73163 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -330,8 +330,11 @@
SfxActionListBox::SfxActionListBox(SfxCommonTemplateDialog_Impl* pParent, WinBit
void SfxActionListBox::Recalc()
{
-SetEntryHeight(32 * GetDPIScaleFactor());
-RecalcViewData();
+if (officecfg::Office::Common::StylesAndFormatting::Preview::get())
+{
+SetEntryHeight(32 * GetDPIScaleFactor());
+RecalcViewData();
+}
}
PopupMenu* SfxActionListBox::CreateContextMenu()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/workben
vcl/workben/makefile.mk | 147 1 file changed, 147 deletions(-) New commits: commit 74d4168f8830f7bbec6b784c3fb774296d9adafa Author: David Tardon dtar...@redhat.com Date: Tue Jul 21 15:25:17 2015 +0200 drop old makefile Change-Id: Ifdc1b8e561e69947b1458aca691cb974071715b5 diff --git a/vcl/workben/makefile.mk b/vcl/workben/makefile.mk deleted file mode 100644 index 2a562c2..000 --- a/vcl/workben/makefile.mk +++ /dev/null @@ -1,147 +0,0 @@ -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the License); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -PRJ=.. - -PRJNAME=vcl -TARGET=svdem -LIBTARGET=NO -TARGETTYPE=GUI - -ENABLE_EXCEPTIONS=TRUE - -my_components = i18npool i18nsearch - -# --- Settings - - -.INCLUDE : settings.mk - -# --- Files - -OBJFILES= \ -$(OBJ)$/svdem.obj \ -$(OBJ)$/vcldemo.obj \ -$(OBJ)$/outdevgrind.obj - -# --- Targets -- - -.IF $(OS) == IOS -CFLAGS += -x objective-c++ -fobjc-abi-version=2 -fobjc-legacy-dispatch -D__IPHONE_OS_VERSION_MIN_REQUIRED=40300 -.ENDIF - -# svdem - -APP1NOSAL= TRUE -APP1TARGET=$(TARGET) -APP1OBJS= \ -$(OBJ)$/svdem.obj - -APP1STDLIBS= $(CPPULIB) \ -$(UNOTOOLSLIB) \ -$(CPPUHELPERLIB) \ -$(COMPHELPERLIB) \ -$(TOOLSLIB)\ -$(SALLIB) \ -$(SOTLIB) \ -$(VCLLIB) - -# outdevgrind - -APP2TARGET= outdevgrind -APP2OBJS= \ -$(OBJ)$/outdevgrind.obj - -APP2NOSAL= TRUE -APP2STDLIBS=$(TOOLSLIB)\ -vclmain.lib \ -$(COMPHELPERLIB) \ -$(CPPULIB) \ -$(CPPUHELPERLIB) \ -$(UCBHELPERLIB)\ -$(SALLIB) \ -$(VCLLIB) - -# vcldemo - -APP3NOSAL=TRUE -APP3TARGET=vcldemo -APP3OBJS= \ -$(OBJ)$/vcldemo.obj - -APP3STDLIBS= $(CPPULIB) \ -$(UNOTOOLSLIB) \ -$(CPPUHELPERLIB) \ -$(COMPHELPERLIB) \ -$(TOOLSLIB)\ -$(SALLIB) \ -$(SOTLIB) \ -$(VCLLIB) - - -# --- Targets -- -.IF $(GUIBASE) == unx - -APP4NOSAL= TRUE -APP4TARGET= svptest -APP4OBJS= $(OBJ)$/svptest.obj - -APP4STDLIBS=$(CPPULIB) \ -$(CPPUHELPERLIB)\ -$(COMPHELPERLIB)\ -$(VCLLIB) \ -$(TOOLSLIB) \ -$(SALLIB) \ -$(SOTLIB) \ -$(VCLLIB) - -APP5NOSAL= TRUE -APP5TARGET= svpclient -APP5OBJS= $(OBJ)$/svpclient.obj - -APP5STDLIBS=$(CPPULIB) \ -$(CPPUHELPERLIB)\ -$(COMPHELPERLIB)\ -$(UCBHELPERLIB)\ -$(VCLLIB) \ -$(TOOLSLIB) \ -$(SALLIB) \ -$(SOTLIB) \ -$(VCLLIB) - -.IF $(OS) == SOLARIS -APP5STDLIBS+=-lsocket -.ENDIF - -.ENDIF - -.INCLUDE : target.mk - -ALLTAR : $(BIN)/applicat.rdb $(BIN)/types.rdb - -$(BIN)/applicat.rdb .ERRREMOVE : $(SOLARENV)/bin/packcomponents.xslt \ -$(MISC)/applicat.input $(my_components:^$(SOLARXMLDIR)/:+.component) -$(XSLTPROC) --nonet --stringparam prefix $(SOLARXMLDIR)/ -o $@ \ -$(SOLARENV)/bin/packcomponents.xslt $(MISC)/applicat.input - -$(MISC)/applicat.input :
[Libreoffice-bugs] [Bug 92865] New: Row Height use-optimal-row-height differences in OO and LIBO
https://bugs.documentfoundation.org/show_bug.cgi?id=92865 Bug ID: 92865 Summary: Row Height use-optimal-row-height differences in OO and LIBO Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: critical Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suga...@gmail.com Created attachment 117374 -- https://bugs.documentfoundation.org/attachment.cgi?id=117374action=edit XLS Files row Height difference Attached XLS file shows almost collapsed rows in all LIBO versions, as the row height set to those rows are very small. But all the rows are visible in Excel and OpenOffice. I digged in further and saved the xls file as ods, both through LibreOffice and OpenOffice and analyzed the difference in the xml. LIBREOFFICE Behaviour:- The row height in 'ro2' is very small and also use-optimal-row-height is set as false. Hence LibreOffice UI displays the rows with the same small height(which almost looks like collapsed rows.). style:style style:name=ro1 style:family=table-row style:table-row-properties style:row-height=14.66pt fo:break-before=auto style:use-optimal-row-height=false/ /style:style style:style style:name=ro2 style:family=table-row style:table-row-properties style:row-height=0.74pt fo:break-beforeauto= style:use-optimal-row-height=false/ /style:style style:style style:name=ro3 style:family=table-row style:table-row-properties style:row-height=12.81pt fo:break-beforeauto= style:use-optimal-row-height=false/ /style:style OpenOffice Behaviour:- Though the row height of 'ro2' is very small in this case also, use-optimal-row-height is set as true. Hence, when the file is opened in any UI the row heights get recalculated according to the content and all the rows are visible just like the original xls file. style:style style:name=ro1 style:family=table-row style:table-row-properties style:row-height=0.1665in fo:break-beforeauto= style:use-optimal-row-height=true/ /style:style style:style style:name=ro2 style:family=table-row style:table-row-properties style:row-height=0.0102in fo:break-beforeauto= style:use-optimal-row-height=true/ /style:style style:style style:name=ro3 style:family=table-row style:table-row-properties style:row-height=0.178in fo:break-beforeauto= style:use-optimal-row-height=true/ /style:style File attached, was created in EXCEL. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92841] FILESAVE: some .xlsx files can't be opened with MS FileFormatConverter or older LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=92841 --- Comment #3 from Andrej andrej...@gmail.com --- (In reply to tommy27 from comment #2) please check the files you uploaded I can open them both on LibO 4.4.5 and 3.4.3 but they look as empty spreadsheets. am I missing something? Yes, sorry, i was testing with 3.4.3 portable version, i thought there is no difference. Now i tested with regular 3.4.3 and 3.3.3 versions, they open document without crashing. Yes, i deleted spreedsheet data from example file and it is empty, but there are some kind of metadata left, which i don't know how normal user can delete. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/SidebarWin.hxx |3 -- sw/inc/docstyle.hxx |1 sw/inc/ndgrf.hxx|3 -- sw/inc/printdata.hxx|1 sw/inc/shellio.hxx |8 - sw/inc/swabstdlg.hxx|3 -- sw/inc/swbaslnk.hxx |2 - sw/inc/unochart.hxx |4 -- sw/inc/unotxdoc.hxx | 13 - sw/inc/view.hxx | 21 --- sw/source/core/inc/SwXMLBlockImport.hxx |9 -- sw/source/core/inc/SwXMLTextBlocks.hxx |1 sw/source/core/inc/UndoNumbering.hxx|1 sw/source/core/inc/UndoRedline.hxx |1 sw/source/core/inc/flyfrms.hxx | 12 sw/source/core/inc/mvsave.hxx |9 ++ sw/source/core/inc/notxtfrm.hxx |1 sw/source/core/inc/objectformatter.hxx | 21 --- sw/source/core/inc/swblocks.hxx |1 sw/source/core/swg/SwXMLBlockImport.cxx |2 - sw/source/core/swg/SwXMLTextBlocks.cxx |5 --- sw/source/core/swg/SwXMLTextBlocks1.cxx |7 + sw/source/core/text/atrhndl.hxx | 11 sw/source/core/text/inftxt.cxx |4 -- sw/source/core/text/inftxt.hxx | 22 sw/source/core/text/itratr.hxx |2 - sw/source/core/text/itrform2.hxx|1 sw/source/core/text/itrtxt.hxx |2 - sw/source/core/text/porexp.hxx |3 -- sw/source/core/text/porfld.hxx |2 - sw/source/core/text/porlay.hxx | 29 - sw/source/core/text/porlin.hxx |7 - sw/source/core/text/pormulti.hxx|6 sw/source/core/text/txtcache.hxx|7 - sw/source/core/text/txtpaint.hxx|1 sw/source/core/text/widorp.hxx |6 sw/source/filter/html/htmlfly.hxx |2 - sw/source/filter/html/htmlnum.hxx |2 - sw/source/filter/html/htmlvsh.hxx |6 sw/source/filter/html/parcss1.hxx |3 -- sw/source/filter/html/svxcss1.hxx |3 -- sw/source/filter/html/swcss1.hxx|3 -- sw/source/filter/html/swhtml.hxx| 12 sw/source/filter/inc/fltshell.hxx |3 -- sw/source/filter/inc/msfilter.hxx |1 sw/source/filter/inc/rtf.hxx|2 - sw/source/filter/inc/wrtswtbl.hxx |2 - sw/source/filter/ww8/WW8FFData.hxx | 33 sw/source/filter/ww8/WW8Sttbf.hxx |5 --- sw/source/filter/ww8/WW8TableInfo.cxx |5 --- sw/source/filter/ww8/WW8TableInfo.hxx |6 sw/source/filter/ww8/attributeoutputbase.hxx|5 --- sw/source/filter/ww8/docxattributeoutput.cxx|5 --- sw/source/filter/ww8/docxattributeoutput.hxx|1 sw/source/filter/ww8/rtfattributeoutput.cxx |5 --- sw/source/filter/ww8/rtfattributeoutput.hxx |1 sw/source/filter/ww8/wrtw8nds.cxx | 29 - sw/source/filter/ww8/wrtww8.hxx | 12 sw/source/filter/ww8/ww8attributeoutput.hxx |2 - sw/source/filter/ww8/ww8par.hxx |5 --- sw/source/filter/ww8/ww8scan.hxx|3 -- sw/source/filter/ww8/ww8struc.hxx |1 sw/source/filter/ww8/ww8toolbar.cxx | 10 --- sw/source/filter/ww8/ww8toolbar.hxx |4 -- sw/source/filter/xml/XMLRedlineImportHelper.hxx |9 -- sw/source/filter/xml/xmlexp.hxx |4 -- sw/source/filter/xml/xmlimp.hxx | 10 --- sw/source/ui/dbui/createaddresslistdialog.hxx |4 -- sw/source/ui/dialog/swdlgfact.cxx | 24 - sw/source/ui/dialog/swdlgfact.hxx |4 -- sw/source/ui/vba/vbadocument.cxx|2 - sw/source/ui/vba/vbaheaderfooterhelper.hxx |2 - sw/source/ui/vba/vbaparagraph.cxx |2 - sw/source/ui/vba/vbarange.cxx |6 ++-- sw/source/ui/vba/vbarange.hxx | 14 -- sw/source/ui/vba/vbatable.hxx |1 sw/source/ui/vba/vbaview.hxx|5 +-- sw/source/uibase/docvw/ShadowOverlayObject.hxx |7 ++--- sw/source/uibase/inc/FrameControl.hxx |2 - sw/source/uibase/inc/actctrl.hxx|1 sw/source/uibase/inc/basesh.hxx |1 sw/source/uibase/inc/caption.hxx|2
[Libreoffice-bugs] [Bug 92866] New: Keyboard command shortcuts don't work in start centre
https://bugs.documentfoundation.org/show_bug.cgi?id=92866 Bug ID: 92866 Summary: Keyboard command shortcuts don't work in start centre Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fdb...@neosheffield.co.uk Seems to be limited to the Start Centre. Works as expected in other components Steps to reproduce - Start LibreOffice to the Start Centre - Ctrl+Q Expected result - LO closes Actual result - Nothing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92866] Keyboard command shortcuts don't work in start centre
https://bugs.documentfoundation.org/show_bug.cgi?id=92866 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected, regression Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk, ||si...@raspberrypi.org Ever confirmed|0 |1 Whiteboard||bibisected OS|All |Linux (All) --- Comment #1 from Matthew Francis fdb...@neosheffield.co.uk --- (bisected, so taking the liberty of setting to NEW) This seems to have begun at the below commit. Adding Cc: to si...@raspberrypi.org; Could you possibly take a look at this? Thanks commit 74407aef94b6d8dfdd69891c4a6e578587ef3e71 Author: Simon Long si...@raspberrypi.org Date: Wed Jul 8 18:02:50 2015 +0100 tdf#92630 Enable auto-accelerator behaviour for gtk Change-Id: I671177dd1f9e535c28a29bcbd6b74f1c789371ea Reviewed-on: https://gerrit.libreoffice.org/16883 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Need help with temporary files
Hi Matus, On Tue, Jul 21, 2015 at 10:41:45PM +0200, Matúš Kukan matus.ku...@gmail.com wrote: And/Or is there another way to get file stream? package/ does not have many dependencies, so I would not like to introduce some new. I think if that fixes the end-user problem, there is no problem in using utl::TempFile directly instead of some UNO wrapper of it. Note that using an UNO service is also a dependency, it's just not link-time but run-time. :-) Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 76682] Other: Gradients in LO are limited only to two colors
https://bugs.documentfoundation.org/show_bug.cgi?id=76682 --- Comment #6 from Michal Svec re...@atrey.karlin.mff.cuni.cz --- (In reply to Miklos Vajna from comment #3) This shape has a gradient of 3 colors: red, green then blue. In Impress, it's blue, red, then blue. I can confirm with LibreOffice 5.0.0.3, just slightly different: - MSO is indeed red-gree-blue - LO only has two-color gradient: red-green -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91495] Style preview in Styles and Formatting sidebar should be optional
https://bugs.documentfoundation.org/show_bug.cgi?id=91495 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |qui...@gmail.com |desktop.org | Whiteboard| target:5.1.0 target:5.0.1 |target:5.1.0 target:5.0.0 |target:5.0.0| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source framework/inc sw/source vcl/osx
filter/source/graphicfilter/icgm/cgm.hxx |1 -
framework/inc/properties.h |1 -
sw/source/uibase/inc/num.hxx |4
vcl/osx/salnativewidgets.cxx |9 -
4 files changed, 15 deletions(-)
New commits:
commit 01854d2d824c13be184e2e183bd4d0025315ef81
Author: Noel Grandin n...@peralex.com
Date: Wed Jul 22 10:27:09 2015 +0200
remove some unused constants
Change-Id: I8742db77a0cfd99257584d830162c1c7126da263
Reviewed-on: https://gerrit.libreoffice.org/17283
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/filter/source/graphicfilter/icgm/cgm.hxx
b/filter/source/graphicfilter/icgm/cgm.hxx
index f190365..1d941b4 100644
--- a/filter/source/graphicfilter/icgm/cgm.hxx
+++ b/filter/source/graphicfilter/icgm/cgm.hxx
@@ -24,7 +24,6 @@
#define CGM_IMPORT_CGM 0x0001
#define CGM_EXPORT_IMPRESS 0x0100
-#define CGM_EXPORT_META 0x0200
#include rtl/ustring.hxx
#include vector
diff --git a/framework/inc/properties.h b/framework/inc/properties.h
index 15a162d..5acc4b0 100644
--- a/framework/inc/properties.h
+++ b/framework/inc/properties.h
@@ -102,7 +102,6 @@ namespace framework{
#define PATHSETTINGS_PROPNAME_ASCII_USERDICTIONARY UserDictionary
#define PATHSETTINGS_PROPNAME_ASCII_WORKWork
-#define PATHSETTINGS_PROPCOUNT 24
/** properties for LayoutManager class */
diff --git a/sw/source/uibase/inc/num.hxx b/sw/source/uibase/inc/num.hxx
index 1b712e3..c4fa047 100644
--- a/sw/source/uibase/inc/num.hxx
+++ b/sw/source/uibase/inc/num.hxx
@@ -42,10 +42,6 @@ struct SwBmpItemInfo
sal_uInt16 nItemId;
};
-#define NUM_PAGETYPE_BULLET 0
-#define NUM_PAGETYPE_SINGLENUM 1
-#define NUM_PAGETYPE_NUM2
-#define NUM_PAGETYPE_BMP3
class SwNumPositionTabPage : public SfxTabPage
{
diff --git a/vcl/osx/salnativewidgets.cxx b/vcl/osx/salnativewidgets.cxx
index e69847f..c1734b2 100644
--- a/vcl/osx/salnativewidgets.cxx
+++ b/vcl/osx/salnativewidgets.cxx
@@ -321,15 +321,6 @@ bool AquaSalGraphics::hitTestNativeControl( ControlType
nType, ControlPart nPart
kThemeStateUnavailableInactive = 8
kThemeStatePressedUp = 2,
kThemeStatePressedDown = 3
-
-#define ControlState::ENABLED 0x0001
-#define ControlState::FOCUSED 0x0002
-#define ControlState::PRESSED 0x0004
-#define ControlState::ROLLOVER 0x0008
-#define ControlState::HIDDEN 0x0010
-#define ControlState::DEFAULT 0x0020
-#define ControlState::SELECTED 0x0040
-#define CTRL_CACHING_ALLOWED0x8000 // set when the control is completely
visible (i.e. not clipped)
*/
UInt32 AquaSalGraphics::getState( ControlState nState )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92868] New: test (importtest.cpp) fails to compile on OS X w/ clang (call to function operator)
https://bugs.documentfoundation.org/show_bug.cgi?id=92868 Bug ID: 92868 Summary: test (importtest.cpp) fails to compile on OS X w/ clang (call to function operator) Product: libvisio Version: unspecified Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: niederstras...@gmail.com On OS X 10.9/Xcode 6.2/libvisio-0.1.1, importtest.cpp fails to compile with this error: g++ -DHAVE_CONFIG_H -I. -I../.. -DTDOC=\../../src/test/data\ -I/sw/opt/boost-1_58/include -I/sw/include -I../../inc -I/sw/include/librevenge-0.0 -I/sw/include/libxml2 -I/sw/include -I/sw/include --std=c++0x -I/sw/include/librevenge-0.0 -I/sw/include -DNDEBUG -g -O2 -fvisibility=hidden -DLIBVISIO_VISIBILITY -Wall -Wextra -Wshadow -pedantic -MT test-importtest.o -MD -MP -MF .deps/test-importtest.Tpo -c -o test-importtest.o `test -f 'importtest.cpp' || echo './'`importtest.cpp In file included from importtest.cpp:13: In file included from /sw/include/cppunit/extensions/HelperMacros.h:9: In file included from /sw/include/cppunit/TestCaller.h:5: In file included from /sw/include/cppunit/TestCase.h:6: /sw/include/cppunit/TestAssert.h:49:13: error: call to function 'operator' that is neither visible in the template definition nor found by argument-dependent lookup ost x; ^ /sw/include/cppunit/TestAssert.h:101:50: note: in instantiation of member function 'CppUnit::assertion_traitslibrevenge::RVNGString::toString' requested here Asserter::failNotEqual( assertion_traitsT::toString(expected), ^ importtest.cpp:66:3: note: in instantiation of function template specialization 'CppUnit::assertEqualslibrevenge::RVNGString' requested here CPPUNIT_ASSERT_EQUAL_MESSAGE(message.cstr(), expectedValue, actualValue); ^ /sw/include/cppunit/TestAssert.h:214:17: note: expanded from macro 'CPPUNIT_ASSERT_EQUAL_MESSAGE' ( CPPUNIT_NS::assertEquals( (expected), \ ^ importtest.cpp:20:15: note: 'operator' should be declared prior to the call site or in namespace 'librevenge' std::ostream operator (std::ostream s, const librevenge::RVNGString string) ^ 1 error generated. Makefile:680: recipe for target 'test-importtest.o' failed make[3]: *** [test-importtest.o] Error 1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92675] White text background (titles and text from master ) in Impress?
https://bugs.documentfoundation.org/show_bug.cgi?id=92675 --- Comment #7 from Katarina Behrens (CIB) katarina.behr...@cib.de --- Think that should have been https://bugs.documentfoundation.org/show_bug.cgi?id=88055#c5 for the manual repair flushing through flat ODF for editing. yes, sorry, typos happen :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92869] New: Hyperlink Frame value not displayed if entered manually
https://bugs.documentfoundation.org/show_bug.cgi?id=92869 Bug ID: 92869 Summary: Hyperlink Frame value not displayed if entered manually Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@m.hd1.org The Help specifies the behavior of the Frame control: Enter the name of the frame that you want the linked file to open in, or select a predefined frame from the list. If you leave this box blank, the linked file opens in the current browser window. If one selects one of the predefined frames, the selection is displayed on the next opening of the dialog. When one enters a name for the frame, this name is _not_ displayed in the dialog on the next open, while it is kept in the document. One can verify that the value is remembered but not displayed if the document is _saved_ (not exported) as HTML. The HTML code have the correct link target. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/gridwin.hxx |2 -
sc/source/ui/view/gridwin4.cxx | 44 -
2 files changed, 23 insertions(+), 23 deletions(-)
New commits:
commit 561cebeeba2155a7ebedbea885c9d7bf43102ec6
Author: Krisztian Pinter pin.termina...@gmail.com
Date: Tue Jun 16 18:10:47 2015 +0200
calc mapmode: Pass RenderContext as reference in DrawPagePreview
Change-Id: I8c4834914b2061c928f4d1172b48d79c2fc4d842
Reviewed-on: https://gerrit.libreoffice.org/16348
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Jan Holesovsky ke...@collabora.com
diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 0c940e9..c05cea9 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -265,7 +265,7 @@ class ScGridWindow : public vcl::Window, public
DropTargetHelper, public DragSou
voidDrawAfterScroll();
Rectangle GetListValButtonRect( const ScAddress rButtonPos );
-voidDrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW
nY2, OutputDevice* pContentDev );
+voidDrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW
nY2, vcl::RenderContext rRenderContext);
boolGetEditUrl( const Point rPos,
OUString* pName=0, OUString* pUrl=0, OUString*
pTarget=0 );
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 2a054d6..b2e76c4 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -737,7 +737,7 @@ void ScGridWindow::DrawContent(OutputDevice rDevice, const
ScTableInfo rTableI
// DrawPagePreview draws complete lines/page numbers, must always be
clipped
if ( aOutputData.SetChangedClip() )
{
-DrawPagePreview(nX1,nY1,nX2,nY2, pContentDev);
+DrawPagePreview(nX1,nY1,nX2,nY2, *pContentDev);
pContentDev-SetClipRegion();
}
}
@@ -1112,7 +1112,7 @@ void ScGridWindow::CheckNeedsRepaint()
}
}
-void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW
nY2, OutputDevice* pContentDev )
+void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW
nY2, vcl::RenderContext rRenderContext)
{
ScPageBreakData* pPageData = pViewData-GetView()-GetPageBreakData();
if (pPageData)
@@ -1147,7 +1147,7 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1,
SCCOL nX2, SCROW nY2,
{
// use EditEngine to draw mixed-script string
pEditEng.reset(new ScEditEngineDefaulter(
EditEngine::CreatePool(), true ));
-pEditEng-SetRefMapMode( pContentDev-GetMapMode() );
+pEditEng-SetRefMapMode(rRenderContext.GetMapMode());
SfxItemSet* pEditDefaults = new SfxItemSet(
pEditEng-GetEmptyItemSet() );
rDefPattern.FillEditItemSet( pEditDefaults );
pEditDefaults-Put( SvxColorItem( Color( COL_LIGHTGRAY ),
EE_CHAR_COLOR ) );
@@ -1165,11 +1165,11 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW
nY1, SCCOL nX2, SCROW nY2,
// 3 pixel frame around the print area
// (middle pixel on the grid lines)
-pContentDev-SetLineColor();
+rRenderContext.SetLineColor();
if (rData.IsAutomatic())
-pContentDev-SetFillColor( aAutomatic );
+rRenderContext.SetFillColor( aAutomatic );
else
-pContentDev-SetFillColor( aManual );
+rRenderContext.SetFillColor( aManual );
Point aStart = pViewData-GetScrPos(
aRange.aStart.Col(), aRange.aStart.Row(),
eWhich, true );
@@ -1186,10 +1186,10 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW
nY1, SCCOL nX2, SCROW nY2,
if ( aEnd.Y() aWinSize.Height() + 10 )
aEnd.Y() = aWinSize.Height() + 10;
-pContentDev-DrawRect( Rectangle( aStart,
Point(aEnd.X(),aStart.Y()+2) ) );
-pContentDev-DrawRect( Rectangle( aStart,
Point(aStart.X()+2,aEnd.Y()) ) );
-pContentDev-DrawRect( Rectangle(
Point(aStart.X(),aEnd.Y()-2), aEnd ) );
-pContentDev-DrawRect( Rectangle(
Point(aEnd.X()-2,aStart.Y()), aEnd ) );
+rRenderContext.DrawRect( Rectangle( aStart,
Point(aEnd.X(),aStart.Y()+2) ) );
+rRenderContext.DrawRect( Rectangle( aStart,
Point(aStart.X()+2,aEnd.Y()) ) );
+rRenderContext.DrawRect( Rectangle(
Point(aStart.X(),aEnd.Y()-2), aEnd ) );
+rRenderContext.DrawRect( Rectangle(
Point(aEnd.X()-2,aStart.Y()), aEnd ) );
// Page breakes
//! Display differently (dashed )
@@ -1204,12 +1204,12 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW
nY1, SCCOL nX2, SCROW nY2,
{
//!
Re: Need help with temporary files
On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 The problem seems to be we deflate streams in parallel and run out of memory. I thought there are temporary files used for deflating since f92183833fa569006602ac7e93c906d2094e0d4d but I see this: Hmm, I think that the tempfile is *normally* backed by a real file and only with a memory stream if the filename of the tempfile is empty, so the real question is likely why does CreateTempName_Impl in unotools/source/ucbhelper/tempfile.cxx return an empty string. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Adolfo Jayme f...@libreoffice.org --- (In reply to Heiko Tietze from comment #7) I agree with Jean-Baptiste. Imagine a scrollbar that doesn't affect the direct neighbor (the properties panel aka sidebar wouldn't be scrolled). Furthermore the properties panel could have its own sidebar too left of the tab bar. You don’t need to imagine it: it is already a big problem in Basic; see bug 86568. (I’ll understand your shocked face :-] ) IMHO, it’s not worth to introduce new problems in order to resolve others. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 Bug 65138 depends on bug 92831, which changed state. Bug 92831 Summary: Position vertical scroll bar widget outboard of Sidebar https://bugs.documentfoundation.org/show_bug.cgi?id=92831 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Adolfo Jayme f...@libreoffice.org --- (In reply to Heiko Tietze from comment #7) I agree with Jean-Baptiste. Imagine a scrollbar that doesn't affect the direct neighbor (the properties panel aka sidebar wouldn't be scrolled). Furthermore the properties panel could have its own sidebar too left of the tab bar. You don’t need to imagine it: it is already a big problem in Basic; see bug 86568. (I’ll understand your shocked face :-] ) IMHO, it’s not worth to introduce new problems in order to resolve others. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: Need help with temporary files
On 2015-07-22 01:07 PM, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:43 +0100, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:28 +0100, Caolán McNamara wrote: On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 E_MFILE, too many open files, so the problem is a file handle leak. See https://gerrit.libreoffice.org/#/c/17289/ for a possible solution. That odt has 14k files in it and in parallel deflate mode each one gets a separate ZipOutputEntry which all exist at the same time until the threads are completed. Each ZipOutputEntry has an open temp file so it runs out of file handles. We should be using some kind of task-manager/thread-pool to limit the number of active threads to something reasonable. Running more than approx no_cores * 3 threads is going to __reduce__ performance. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92600] UI: No bold headings in dialogues
https://bugs.documentfoundation.org/show_bug.cgi?id=92600 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Need help with temporary files
On Wed, 2015-07-22 at 10:28 +0100, Caolán McNamara wrote: On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 The problem seems to be we deflate streams in parallel and run out of memory. I thought there are temporary files used for deflating since f92183833fa569006602ac7e93c906d2094e0d4d but I see this: Hmm, I think that the tempfile is *normally* backed by a real file and only with a memory stream if the filename of the tempfile is empty, so the real question is likely why does CreateTempName_Impl in unotools/source/ucbhelper/tempfile.cxx return an empty string. E_MFILE, too many open files, so the problem is a file handle leak. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92869] Hyperlink Frame value not displayed if entered manually
https://bugs.documentfoundation.org/show_bug.cgi?id=92869 Gil Shwartz libreoff...@m.hd1.org changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All |Linux (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92870] Export to HTML does not respect hyperlink target frame
https://bugs.documentfoundation.org/show_bug.cgi?id=92870 --- Comment #3 from Gil Shwartz libreoff...@m.hd1.org --- Created attachment 117378 -- https://bugs.documentfoundation.org/attachment.cgi?id=117378action=edit File exported as XHTML not exporting the link targets -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92870] Export to HTML does not respect hyperlink target frame
https://bugs.documentfoundation.org/show_bug.cgi?id=92870 --- Comment #2 from Gil Shwartz libreoff...@m.hd1.org --- Created attachment 117377 -- https://bugs.documentfoundation.org/attachment.cgi?id=117377action=edit File saved as HTML with correct link targets -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92870] Export to HTML does not respect hyperlink target frame
https://bugs.documentfoundation.org/show_bug.cgi?id=92870 --- Comment #1 from Gil Shwartz libreoff...@m.hd1.org --- Created attachment 117376 -- https://bugs.documentfoundation.org/attachment.cgi?id=117376action=edit Writer file with various frame target settings. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Crash test update
On Tue, 2015-07-21 at 11:51 +, Crashtest VM wrote: New crashtest update available at http://dev-builds.libreoffice.org/crashtest/97a0e7558b24792827d77217fb2d8b1106056963/ And that's our current target of two consecutive reports of 0 import and 0 export failures. These runs until now have been on a static pile of 76221 (12G) test documents, so I've now refreshed the document cache with mst's improved get_bugzilla-attachments-by-mimetype to add newly submitted documents since the last get-bugz... run so the new runs will be over 79993 (13G) My estimates last week in ESC of the amount of extra space needed to cope with refreshing the document pile were hilariously wrong because I based them on my own local cache which included an additional 30G of .docs from the digitalcorpora archives (http://digitalcorpora.org/corp/files/govdocs1/by_type/) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92725] Adding new record in table duplicates values in previous field
https://bugs.documentfoundation.org/show_bug.cgi?id=92725 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Priority|high|medium Status|NEW |ASSIGNED Severity|critical|normal --- Comment #7 from Lionel Elie Mamane lio...@mamane.lu --- OK, reproduced. It is less serious than I thought. The value from previous row (which is from the last selected row, not the last row of the table) is prefilled, but it is *not* saved unless one actually edits it. The prefilling happens only on the field that has focus, not the whole row. But in my test, it happens also in existing rows, as soon as a field is NULL (empty), it happens in that field. It is not saved unless one edits it, even if one edits another field. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92870] New: Export to HTML does not respect hyperlink target frame
https://bugs.documentfoundation.org/show_bug.cgi?id=92870 Bug ID: 92870 Summary: Export to HTML does not respect hyperlink target frame Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@m.hd1.org Unlike the option to _save_ a document in HTML, when a document is exported to HTML/XHTML, the specification of the Frame (link target) in the hyperlink dialog is not exported. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Need help with temporary files
On Wed, 2015-07-22 at 10:43 +0100, Caolán McNamara wrote: On Wed, 2015-07-22 at 10:28 +0100, Caolán McNamara wrote: On Tue, 2015-07-21 at 22:41 +0200, Matúš Kukan wrote: Hi there, I am working on a bug around saving big file in Writer: https://bugs.documentfoundation.org/show_bug.cgi?id=88314 E_MFILE, too many open files, so the problem is a file handle leak. See https://gerrit.libreoffice.org/#/c/17289/ for a possible solution. That odt has 14k files in it and in parallel deflate mode each one gets a separate ZipOutputEntry which all exist at the same time until the threads are completed. Each ZipOutputEntry has an open temp file so it runs out of file handles. So what works for me, though maybe it destroys the perf gains, is to close each entry's output stream after its processed and reopen it when we need its data. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx
vcl/inc/svdata.hxx|3 ++-
vcl/source/control/button.cxx |7 +--
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |1 +
3 files changed, 8 insertions(+), 3 deletions(-)
New commits:
commit f485b2881794244409d71ead39715373e734ed04
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 12:31:55 2015 +0100
gtk3: native focus rects are fine for flat buttons
Change-Id: I6a70696cd119e681b4850c624c9e4ff28312c152
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 4be003e..a035ae3 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -266,7 +266,8 @@ struct ImplSVNWFData
// toolbox
dropdown buttons
boolmbFlatMenu:1; // no popup 3D
border
boolmbOpenMenuOnF10:1; // on gnome the
first menu opens on F10
-boolmbNoFocusRects:1; // on Aqua focus
rects are not used
+boolmbNoFocusRects:1; // on Aqua/Gtk3
use native focus rendering, except for flat butttons
+boolmbNoFocusRectsForFlatButtons:1; // on Gtk3 native
focusing is also preferred for flat buttons
boolmbCenteredTabs:1; // on Aqua, tabs
are centered
boolmbNoActiveTabTextRaise:1; // on Aqua the
text for the selected tab
// should not
jump up a pixel
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index ca27059..a106461 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -700,8 +700,11 @@ void PushButton::ImplInitSettings( bool bFont,
EnableChildTransparentMode( true );
SetParentClipMode( ParentClipMode::NoClip );
SetPaintTransparent( true );
-mpWindowImpl-mbUseNativeFocus = (GetStyle() WB_FLATBUTTON) == 0
- ImplGetSVData()-maNWFData.mbNoFocusRects;
+
+if ((GetStyle() WB_FLATBUTTON) == 0)
+mpWindowImpl-mbUseNativeFocus =
ImplGetSVData()-maNWFData.mbNoFocusRects;
+else
+mpWindowImpl-mbUseNativeFocus =
ImplGetSVData()-maNWFData.mbNoFocusRectsForFlatButtons;
}
else
{
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index c593559..787d405 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -1935,6 +1935,7 @@ void GtkData::initNWF()
pSVData-maNWFData.mbCanDrawWidgetAnySize = true;
pSVData-maNWFData.mbDDListBoxNoTextArea = true;
pSVData-maNWFData.mbNoFocusRects = true;
+pSVData-maNWFData.mbNoFocusRectsForFlatButtons = true;
pSVData-maNWFData.mbAutoAccel = true;
pSVData-maNWFData.mbEnableAccel = true;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92871] New: Crash on export PDF/A XP SP3-SSE LBO 5.0.0.3
https://bugs.documentfoundation.org/show_bug.cgi?id=92871 Bug ID: 92871 Summary: Crash on export PDF/A XP SP3-SSE LBO 5.0.0.3 Product: LibreOffice Version: 5.0.0.3 rc Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jc.etiem...@gmail.com Install LibreOffice_5.0.0.3_Win_x86.msi on XP SP3 processeur AMD Athlon XP1800 SSE Test a writer and calc export to archive PDF/A see http://postimg.org/image/kyzbtn009/ PDF is not stored a few seconds after, I have an error message SEH Exception:ILLEGAL INSTRUCTION see http://postimg.org/image/h9suohwdv/ Other export PDF Hybryde are OK - only PDF/A Crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92872] New: CALC cell selection fails
https://bugs.documentfoundation.org/show_bug.cgi?id=92872 Bug ID: 92872 Summary: CALC cell selection fails Product: LibreOffice Version: 4.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alava...@gmail.com When selecting a range with BASIC in CALC the selected range rows and columns are highlighted in blue on the respective rulers on the left (rows) and top (columns) but the actual cells are not highlighted in the grid. As a result various uno: commands fail. In particular dispatcher.executeDispatch(document, .uno:Cut, , 0, Array()) does not actually cut the selected cells, so a subsequent Paste fails. At other times the Cut succeeds in removing the contents from the grid, but Paste still does not deliver the cut data. I am invoking the selection with args0(0).Name = By args0(0).Value = 1 dispatcher.executeDispatch(document, .uno:GoDownSel, , 0, args0()) (args0() has been properly declared previously). But I also tried args1(0).Name = By args1(0).Value = 1 args1(1).Name = Sel args1(1).Value = true dispatcher.executeDispatch(document, .uno:GoDown, , 0, args1()) and various other alternatives. In each case, the rulers on the left and top show blue for the selected range, but the actual grid cells are white, not surrounded with marching ants and colored in the grid. I am invoking the macro with a control (button) and have ensured that Take focus on Click is set to NO, but the button still keeps the focus after execution. Ensuring that the cell (not the button) has the focus by clicking in a cell before clicking the control (button) does not help. I can send the entire macro code if you wish. Thanks for all the good work. C. Andrews (Andy) Lavarre alava...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang sc/inc sc/qa sc/source
compilerplugins/clang/unusedmethods.cxx| 24 ++- compilerplugins/clang/unusedmethods.py |1 sc/inc/addincfg.hxx|2 sc/inc/clkernelthread.hxx |4 - sc/inc/convuno.hxx | 39 sc/inc/filtopt.hxx |4 - sc/inc/grouparealistener.hxx |4 - sc/inc/scabstdlg.hxx |2 sc/inc/simpleformulacalc.hxx |1 sc/qa/unit/helper/qahelper.hxx | 21 -- sc/source/core/tool/clkernelthread.cxx | 16 - sc/source/core/tool/grouparealistener.cxx | 16 - sc/source/core/tool/userlist.cxx |5 - sc/source/filter/excel/xepivot.cxx | 10 +-- sc/source/filter/excel/xestream.cxx|5 - sc/source/filter/excel/xltoolbar.hxx |1 sc/source/filter/inc/XclExpChangeTrack.hxx |5 - sc/source/filter/inc/XclImpChangeTrack.hxx |7 -- sc/source/filter/inc/addressconverter.hxx | 19 -- sc/source/filter/inc/autofilterbuffer.hxx |3 sc/source/filter/inc/biff.hxx |8 -- sc/source/filter/inc/biffinputstream.hxx |7 -- sc/source/filter/inc/defnamesbuffer.hxx|8 -- sc/source/filter/inc/drawingmanager.hxx| 13 sc/source/filter/inc/excimp8.hxx |1 sc/source/filter/inc/excrecds.hxx |1 sc/source/filter/inc/externallinkbuffer.hxx|3 sc/source/filter/inc/formel.hxx|9 -- sc/source/filter/inc/formulabase.hxx |1 sc/source/filter/inc/fprogressbar.hxx |4 - sc/source/filter/inc/htmlpars.hxx |9 -- sc/source/filter/inc/lotfntbf.hxx | 12 --- sc/source/filter/inc/lotimpop.hxx |7 -- sc/source/filter/inc/lotrange.hxx | 19 -- sc/source/filter/inc/namebuff.hxx | 15 sc/source/filter/inc/richstring.hxx|1 sc/source/filter/inc/stylesbuffer.hxx | 10 --- sc/source/filter/inc/tokstack.hxx | 26 sc/source/filter/inc/tool.h|4 - sc/source/filter/inc/worksheethelper.hxx |2 sc/source/filter/inc/xcl97rec.hxx |2 sc/source/filter/inc/xecontent.hxx |1 sc/source/filter/inc/xename.hxx|2 sc/source/filter/inc/xepage.hxx|3 sc/source/filter/inc/xepivot.hxx |9 -- sc/source/filter/inc/xerecord.hxx |2 sc/source/filter/inc/xestream.hxx |8 -- sc/source/filter/inc/xestyle.hxx |2 sc/source/filter/inc/xetable.hxx |9 -- sc/source/filter/inc/xichart.hxx | 11 --- sc/source/filter/inc/xiescher.hxx | 25 sc/source/filter/inc/xipivot.hxx |1 sc/source/filter/inc/xistream.hxx |2 sc/source/filter/inc/xistring.hxx |2 sc/source/filter/inc/xistyle.hxx |5 - sc/source/filter/inc/xladdress.hxx |2 sc/source/filter/inc/xlformula.hxx |2 sc/source/filter/inc/xlpivot.hxx |2 sc/source/filter/inc/xlroot.hxx|4 - sc/source/filter/oox/defnamesbuffer.cxx| 39 sc/source/filter/oox/drawingmanager.cxx|6 - sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx |1 sc/source/filter/xml/XMLExportIterator.hxx |3 sc/source/filter/xml/XMLStylesExportHelper.cxx | 11 --- sc/source/filter/xml/XMLStylesExportHelper.hxx |3 sc/source/filter/xml/xmlcelli.cxx |1 sc/source/filter/xml/xmlcelli.hxx |3 sc/source/filter/xml/xmldpimp.hxx |3 sc/source/filter/xml/xmlexprt.hxx |2 sc/source/filter/xml/xmlimprt.cxx |1 sc/source/filter/xml/xmlimprt.hxx |6 - sc/source/filter/xml/xmlsubti.hxx |5 - sc/source/ui/Accessibility/AccessibleDocument.cxx |8 -- sc/source/ui/Accessibility/AccessibleDocumentBase.cxx |5 - sc/source/ui/attrdlg/scdlgfact.cxx | 10 --- sc/source/ui/attrdlg/scdlgfact.hxx |
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/data/ww8/pass/crash-1.doc |binary
sw/source/filter/ww8/ww8par.cxx | 11 +++
2 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit cbea6a709f33babfb490ab1bd07cde8cc08114ac
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 13:51:19 2015 +0100
xstUsrInitl contains max 9 chars
Change-Id: Ia40d037d7af6cd3a283aa12948e4c5565dcb2ae6
diff --git a/sw/qa/core/data/ww8/pass/crash-1.doc
b/sw/qa/core/data/ww8/pass/crash-1.doc
new file mode 100644
index 000..9f6b253
Binary files /dev/null and b/sw/qa/core/data/ww8/pass/crash-1.doc differ
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 4d82b50..02d26f4 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -2170,15 +2170,18 @@ long SwWW8ImplReader::Read_And(WW8PLCFManResult* pRes)
if (pA)
sAuthor = *pA;
else
-sAuthor = OUString(pDescri-xstUsrInitl + 1,
pDescri-xstUsrInitl[0],
-RTL_TEXTENCODING_MS_1252);
+{
+const sal_uInt8 nLen = std::minsal_uInt8(pDescri-xstUsrInitl[0],
+
SAL_N_ELEMENTS(pDescri-xstUsrInitl)-1);
+sAuthor = OUString(pDescri-xstUsrInitl + 1, nLen,
RTL_TEXTENCODING_MS_1252);
+}
}
else
{
const WW8_ATRD* pDescri = static_castconst WW8_ATRD*(pSD-GetData());
-
{
-const sal_uInt16 nLen = SVBT16ToShort(pDescri-xstUsrInitl[0]);
+const sal_uInt16 nLen =
std::minsal_uInt16(SVBT16ToShort(pDescri-xstUsrInitl[0]),
+
SAL_N_ELEMENTS(pDescri-xstUsrInitl)-1);
OUStringBuffer aBuf;
aBuf.setLength(nLen);
for(sal_uInt16 nIdx = 1; nIdx = nLen; ++nIdx)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 --- Comment #15 from Caolán McNamara caol...@redhat.com --- potential solution at https://gerrit.libreoffice.org/#/c/17289/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8scan.cxx | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
New commits:
commit a64c48f523d148cd4750bc9bd26d2349fc8a3c7c
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 14:52:58 2015 +0100
read block in one swoop, rather than char by char
Change-Id: Ic879c096c6b3167a123cee352361da6c39e57de2
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 1dc8806..0c2ad80 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3889,13 +3889,8 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm,
sal_uInt32 nStart, sal_Int32 nLen
{
if (pExtraArray)
{
-ww::bytes extraData;
-for (sal_uInt16 j = 0; j nExtraLen; ++j)
-{
-sal_uInt8 iTmp(0);
-rStrm.ReadUChar( iTmp );
-extraData.push_back(iTmp);
-}
+ww::bytes extraData(nExtraLen);
+rStrm.Read(extraData.data(), nExtraLen);
pExtraArray-push_back(extraData);
}
else
@@ -3950,13 +3945,8 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm,
sal_uInt32 nStart, sal_Int32 nLen
{
if (pExtraArray)
{
-ww::bytes extraData;
-for (sal_uInt16 i=0;i nExtraLen;++i)
-{
-sal_uInt8 iTmp(0);
-rStrm.ReadUChar( iTmp );
-extraData.push_back(iTmp);
-}
+ww::bytes extraData(nExtraLen);
+rStrm.Read(extraData.data(), nExtraLen);
pExtraArray-push_back(extraData);
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #7 from Heiko Tietze heiko.tie...@user-prompt.com --- I agree with Jean-Baptiste. Imagine a scrollbar that doesn't affect the direct neighbor (the properties panel aka sidebar wouldn't be scrolled). Furthermore the properties panel could have its own sidebar too left of the tab bar. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #7 from Heiko Tietze heiko.tie...@user-prompt.com --- I agree with Jean-Baptiste. Imagine a scrollbar that doesn't affect the direct neighbor (the properties panel aka sidebar wouldn't be scrolled). Furthermore the properties panel could have its own sidebar too left of the tab bar. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/LibreOfficeKit libreofficekit/qa libreofficekit/source
include/LibreOfficeKit/LibreOfficeKitGtk.h |3 +++
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |1 +
libreofficekit/source/gtk/lokdocview.cxx|8
3 files changed, 12 insertions(+)
New commits:
commit ed9d6ef1e647b574f58ba870d71a4291d958c0ad
Author: Mihai Varga mihai.va...@collabora.com
Date: Tue Jul 21 18:49:21 2015 +0300
gtktiledviewer: method for resetting all tiles
[ Miklos Vajna: The point of the change is that without this, part
switching in
Calc does not work, as Calc does not invalidate everything after a part
switch
(unlike Impress), and we suppose the right fix for this is to let the
clients
throw away the tiles, rather than letting Calc send out invalidations, too.
]
Change-Id: Id368b955c54efb87ecf3d59278ddb5cdbb2e7856
Reviewed-on: https://gerrit.libreoffice.org/17267
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index 962f9d9..b98a856 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -63,6 +63,9 @@ char* lok_doc_view_get_part_name
(LOKDocView*
int nPart);
void lok_doc_view_set_partmode
(LOKDocView* pDocView,
int
nPartMode);
+
+void lok_doc_view_reset_view
(LOKDocView* pDocView);
+
/// Sets if the viewer is actually an editor or not.
void lok_doc_view_set_edit
(LOKDocView* pDocView,
gboolean
bEdit);
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index ec70a88..6c0de39 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -357,6 +357,7 @@ static void changePart( GtkWidget* pSelector, gpointer /*
pItem */ )
if (g_bPartSelectorBroadcast pDocView)
{
lok_doc_view_set_part( LOK_DOC_VIEW(pDocView), nPart );
+lok_doc_view_reset_view( LOK_DOC_VIEW(pDocView) );
}
}
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index bf12ca0..3823e94 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -1529,6 +1529,14 @@ lok_doc_view_set_partmode(LOKDocView* pDocView,
priv-m_pDocument-pClass-setPartMode( priv-m_pDocument, nPartMode );
}
+SAL_DLLPUBLIC_EXPORT void
+lok_doc_view_reset_view(LOKDocView* pDocView)
+{
+LOKDocViewPrivate *priv =
static_castLOKDocViewPrivate*(lok_doc_view_get_instance_private (pDocView));
+priv-m_aTileBuffer.resetAllTiles();
+gtk_widget_queue_draw(GTK_WIDGET(pDocView));
+}
+
/**
* lok_doc_view_set_edit:
* @pDocView: The #LOKDocView instance
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92841] FILESAVE: some .xlsx files can't be opened with MS FileFormatConverter or older LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=92841 --- Comment #4 from tommy27 ba...@quipo.it --- which portable version do you use? I use the winPenPack version from http://www.winpenpack.com/main/download.php?view.1354 and it opens those files without any crash either using a recent LibO version or an old one (see the whole archive here: http://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/ ) I suspect you use the PortableApps LibO version which IMHO is inferior to the winPenPack package. anyway, do you still have the issues with MS FileFormatConverter? I don't know that software, would you please explain what is it? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92867] New: UI: Filter dialog can be wider as the application on Gnome 3 desktop with 2 horizontal displays
https://bugs.documentfoundation.org/show_bug.cgi?id=92867 Bug ID: 92867 Summary: UI: Filter dialog can be wider as the application on Gnome 3 desktop with 2 horizontal displays Product: LibreOffice Version: 4.2.8.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r.loutrel+libreoff...@gmail.com Created attachment 117375 -- https://bugs.documentfoundation.org/attachment.cgi?id=117375action=edit Unexpected filter Dialog Width I checked the suggested Bugs and no one was a duplicate. Environment: lsb_release -a No LSB modules are available. Distributor ID:Ubuntu Description:Ubuntu 14.04.2 LTS Release:14.04 Codename:trusty Gnome 3 xrandr (probably usefull to understand and reproduce) Screen 0: minimum 320 x 200, current 3840 x 1080, maximum 32767 x 32767 LVDS2 connected primary 1920x1080+1920+0 (normal left inverted right x axis y axis) 344mm x 194mm 1920x1080 60.2*+ 59.9 40.1 1680x1050 60.0 59.9 1600x1024 60.2 1400x1050 60.0 1280x1024 60.0 1440x900 59.9 1280x960 60.0 1360x768 59.8 60.0 1152x864 60.0 1024x768 60.0 800x60060.3 56.2 640x48059.9 VGA2 connected 1920x1080+0+0 (normal left inverted right x axis y axis) 0mm x 0mm 1920x1080 60.2*60.2* 1024x768 60.0 800x60060.3 56.2 848x48060.0 640x48059.9 ==STEPS to reproduce== 0/ Oppen cal full screen on one display 1/ Fill A1:B3 cells with any values 2/ Replaces values of B2 with a really long value 3/ Select A1:B3 and create an automatic filter (self tested only with a title line) 4/ Click on the arrow of the B column to filter the values (important is B column because it seems that the dialog width will be computed using the current column values) 5/ Select standard filter ==IS== Dialog is bigger than the application width (probably limited by the entire desktop width and not the application width) → See screenshot ==SHOULD== Dialog is limited to the application width -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
6 new defect(s) introduced to LibreOffice found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1312089: Uninitialized members (UNINIT_CTOR)
/fpicker/source/office/RemoteFilesDialog.cxx: 218 in
RemoteFilesDialog::RemoteFilesDialog(vcl::Window *, long)()
*** CID 1312089: Uninitialized members (UNINIT_CTOR)
/fpicker/source/office/RemoteFilesDialog.cxx: 218 in
RemoteFilesDialog::RemoteFilesDialog(vcl::Window *, long)()
212
213 FillServicesListbox();
214
215 m_pServices_lb-SetSelectHdl( LINK( this, RemoteFilesDialog,
SelectServiceHdl ) );
216
217 m_pFilter_lb-SetSelectHdl( LINK( this, RemoteFilesDialog,
SelectFilterHdl ) );
CID 1312089: Uninitialized members (UNINIT_CTOR)
Non-static class member m_pFileNotifier is not initialized in this
constructor nor in any functions that it calls.
218 }
219
220 RemoteFilesDialog::~RemoteFilesDialog()
221 {
222 disposeOnce();
223 }
** CID 1312088: Uninitialized members (UNINIT_CTOR)
/fpicker/source/office/RemoteFilesDialog.cxx: 29 in
FileViewContainer::FileViewContainer(vcl::Window *)()
*** CID 1312088: Uninitialized members (UNINIT_CTOR)
/fpicker/source/office/RemoteFilesDialog.cxx: 29 in
FileViewContainer::FileViewContainer(vcl::Window *)()
23 FileViewContainer( vcl::Window *pParent )
24 : Window( pParent, WB_TABSTOP )
25 , m_pFileView( NULL )
26 , m_pTreeView( NULL )
27 , m_pSplitter( NULL )
28 {
CID 1312088: Uninitialized members (UNINIT_CTOR)
Non-static class member m_nCurrentFocus is not initialized in this
constructor nor in any functions that it calls.
29 }
30
31 virtual ~FileViewContainer()
32 {
33 disposeOnce();
34 }
** CID 1312087:(RESOURCE_LEAK)
/svtools/source/contnr/foldertree.cxx: 65 in
FolderTree::FillTreeEntry(SvTreeListEntry *)()
/svtools/source/contnr/foldertree.cxx: 65 in
FolderTree::FillTreeEntry(SvTreeListEntry *)()
*** CID 1312087:(RESOURCE_LEAK)
/svtools/source/contnr/foldertree.cxx: 65 in
FolderTree::FillTreeEntry(SvTreeListEntry *)()
59 OUString* sData = new OUString(
aContent[i]-maTargetURL );
60 pNewEntry-SetUserData( static_cast void* (
sData ) );
61 }
62 }
63 }
64 }
CID 1312087:(RESOURCE_LEAK)
Variable pContentEnumerator going out of scope leaks the storage it
points to.
65 }
66 }
67
68 void FolderTree::SetTreePath( OUString const sUrl )
69 {
70 INetURLObject aUrl( sUrl );
/svtools/source/contnr/foldertree.cxx: 65 in
FolderTree::FillTreeEntry(SvTreeListEntry *)()
59 OUString* sData = new OUString(
aContent[i]-maTargetURL );
60 pNewEntry-SetUserData( static_cast void* (
sData ) );
61 }
62 }
63 }
64 }
CID 1312087:(RESOURCE_LEAK)
Variable pContentEnumerator going out of scope leaks the storage it
points to.
65 }
66 }
67
68 void FolderTree::SetTreePath( OUString const sUrl )
69 {
70 INetURLObject aUrl( sUrl );
** CID 1312086: Memory - illegal accesses (OVERRUN)
/fpicker/source/office/RemoteFilesDialog.cxx: 93 in
FileViewContainer::changeFocus(bool)()
*** CID 1312086: Memory - illegal accesses (OVERRUN)
/fpicker/source/office/RemoteFilesDialog.cxx: 93 in
FileViewContainer::changeFocus(bool)()
87 {
88 if( !m_pFileView || !m_pTreeView )
89 return;
90
91 if( !bReverse m_nCurrentFocus 4 )
92 {
CID 1312086: Memory - illegal accesses (OVERRUN)
Overrunning array this-m_pFocusWidgets of 4 8-byte elements at
element index 4 (byte offset 32) using index ++this-m_nCurrentFocus
(which evaluates to 4).
93 m_pFocusWidgets[++m_nCurrentFocus]-SetFakeFocus( true );
94 m_pFocusWidgets[m_nCurrentFocus]-GrabFocus();
95 }
96 else if( m_nCurrentFocus 0 )
97 {
98 m_pFocusWidgets[--m_nCurrentFocus]-SetFakeFocus( true );
** CID
Some problems while I build libreoffice android on Ubuntu(15.04)
Hi, I'm newbie programming, I want to learn how to build libreoffice android on Ubuntu (15.04) environments. I followed https://wiki.documentfoundation.org/Development/Android#How_to_build_it but error occurs when executing the 'make' steps. I would like to ask what steps are what I should do and not on Wiki? I just want to study part of Android, also we need to establish whether the overall environment? There are other ways? autogen.input: --enable-werror --with-distro=LibreOfficeAndroid I got error: Making all in fontconfig Making all in fc-case Making all in fc-lang Making all in fc-glyphname Making all in fc-arch Making all in src CC fcxml.lo libtool: compile: /home/sc/core/external/android-ndk/toolchains/arm-linux-androideabi-4.9/preb uilt/linux-x86_64/bin/arm-linux-androideabi-gcc -mthumb -march=armv7-a -mfloat-abi=softfp -mfpu=neon -Wl,--fix-cortex-a8 -ffunction-sections -fdata-sections -L/home/sc/core/external/android-ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/ armeabi-v7a --sysroot=/home/sc/core/external/android-ndk/platforms/android-15/arch-arm -Wno-psabi -fuse-ld=gold -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -I/home/sc/core/workdir/UnpackedTarball/freetype/instdir/include/freetype2 -I/home/sc/core/workdir/UnpackedTarball/freetype/instdir/include -I/usr/include/libxml2 -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -fno-strict-aliasing -DFC_CACHEDIR=\/usr/local/var/cache/fontconfig\ -DFONTCONFIG_PATH=\/usr/local/etc/fonts\ -DHAVE_GCC_VISIBILITY_FEATURE -fvisibility=hidden -MT fcxml.lo -MD -MP -MF .deps/fcxml.Tpo -c fcxml.c -o fcxml.o In file included from /usr/include/libxml2/libxml/parser.h:810:0, from fcxml.c:32: /usr/include/libxml2/libxml/encoding.h:28:19: fatal error: iconv.h: No such file or directory #include iconv.h ^ compilation terminated. Makefile:468: recipe for target 'fcxml.lo' failed make[5]: *** [fcxml.lo] Error 1 Makefile:354: recipe for target 'all' failed make[4]: *** [all] Error 2 Makefile:447: recipe for target 'all-recursive' failed make[3]: *** [all-recursive] Error 1 Makefile:330: recipe for target 'all' failed make[2]: *** [all] Error 2 Thanks for reading and look forward to your reply :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92841] FILESAVE: some .xlsx files can't be opened with MS FileFormatConverter or older LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=92841 --- Comment #5 from Andrej andrej...@gmail.com --- (In reply to tommy27 from comment #4) which portable version do you use? I use the winPenPack version from http://www.winpenpack.com/main/download.php?view.1354 and it opens those files without any crash either using a recent LibO version or an old one (see the whole archive here: http://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/ ) I suspect you use the PortableApps LibO version which IMHO is inferior to the winPenPack package. anyway, do you still have the issues with MS FileFormatConverter? I don't know that software, would you please explain what is it? Now i installed and tested with LibreOffice 3.4.2 from http://www.oldapps.com/libreoffice.php?old_libreoffice=6155 and crash happens there. FileFormatConverter is compatibility pack for MS Office 2000, 2003 etc, it allows to open .xlsx files in these old versions. http://lmgtfy.com/?q=microsoft+office+2000+compatibility+pack It can be installed without MS office by the way, but may break file associations. It fails to open file if i not clean spreadsheet and delete Names data from file(see below). Yes, i deleted spreedsheet data from example file and it is empty, but there are some kind of metadata left, which i don't know how normal user can delete. Ok, this metadata is in menu Insert Names Manage... If i delete name Lapa, then MS FileFormatConverter and LibreOffice 3.4.2 Portable can open this document. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/README canvas/source canvas/workben
canvas/README |2 canvas/source/cairo/cairo_cachedbitmap.hxx | 17 - canvas/source/cairo/cairo_canvas.hxx | 30 -- canvas/source/cairo/cairo_canvasbitmap.hxx | 24 - canvas/source/cairo/cairo_canvascustomsprite.cxx |2 canvas/source/cairo/cairo_canvascustomsprite.hxx | 20 - canvas/source/cairo/cairo_canvasfont.cxx |4 canvas/source/cairo/cairo_canvasfont.hxx | 28 - canvas/source/cairo/cairo_canvashelper.cxx | 10 canvas/source/cairo/cairo_canvashelper.hxx | 267 -- canvas/source/cairo/cairo_devicehelper.cxx |2 canvas/source/cairo/cairo_devicehelper.hxx | 52 +-- canvas/source/cairo/cairo_repainttarget.hxx|4 canvas/source/cairo/cairo_spritecanvas.hxx | 40 +- canvas/source/cairo/cairo_spritecanvashelper.hxx | 26 - canvas/source/cairo/cairo_spritedevicehelper.cxx |2 canvas/source/cairo/cairo_spritedevicehelper.hxx |8 canvas/source/cairo/cairo_spritehelper.hxx |6 canvas/source/cairo/cairo_surfaceprovider.hxx |2 canvas/source/cairo/cairo_textlayout.hxx | 60 ++-- canvas/source/directx/dx_bitmap.hxx| 24 - canvas/source/directx/dx_bitmapcanvashelper.hxx| 64 ++-- canvas/source/directx/dx_canvas.hxx| 52 +-- canvas/source/directx/dx_canvasbitmap.cxx |2 canvas/source/directx/dx_canvasbitmap.hxx | 18 - canvas/source/directx/dx_canvascustomsprite.cxx|2 canvas/source/directx/dx_canvascustomsprite.hxx| 16 - canvas/source/directx/dx_canvasfont.cxx|2 canvas/source/directx/dx_canvasfont.hxx| 32 +- canvas/source/directx/dx_canvashelper.hxx | 246 canvas/source/directx/dx_config.cxx|2 canvas/source/directx/dx_config.hxx|2 canvas/source/directx/dx_devicehelper.cxx |2 canvas/source/directx/dx_devicehelper.hxx | 60 ++-- canvas/source/directx/dx_ibitmap.hxx | 24 - canvas/source/directx/dx_impltools.cxx |4 canvas/source/directx/dx_impltools.hxx | 35 +- canvas/source/directx/dx_spritecanvas.hxx | 38 +- canvas/source/directx/dx_spritecanvashelper.hxx| 30 +- canvas/source/directx/dx_spritedevicehelper.cxx|2 canvas/source/directx/dx_spritedevicehelper.hxx| 32 +- canvas/source/directx/dx_spritehelper.hxx |4 canvas/source/directx/dx_surfacebitmap.hxx | 24 - canvas/source/directx/dx_textlayout.hxx| 58 +-- canvas/source/directx/dx_textlayout_drawhelper.cxx | 34 +- canvas/source/directx/dx_textlayout_drawhelper.hxx | 35 +- canvas/source/directx/dx_vcltools.hxx |4 canvas/source/factory/cf_service.cxx |6 canvas/source/opengl/ogl_bitmapcanvashelper.hxx| 28 - canvas/source/opengl/ogl_canvasbitmap.hxx |6 canvas/source/opengl/ogl_canvascustomsprite.cxx|2 canvas/source/opengl/ogl_canvascustomsprite.hxx| 37 +- canvas/source/opengl/ogl_canvasfont.hxx| 24 - canvas/source/opengl/ogl_canvashelper.hxx | 248 - canvas/source/opengl/ogl_canvastools.hxx |2 canvas/source/opengl/ogl_spritecanvas.hxx | 44 +-- canvas/source/opengl/ogl_spritedevicehelper.cxx|2 canvas/source/opengl/ogl_spritedevicehelper.hxx| 72 ++-- canvas/source/opengl/ogl_textlayout.hxx| 52 +-- canvas/source/opengl/ogl_texturecache.hxx |2 canvas/source/simplecanvas/simplecanvasimpl.cxx|4 canvas/source/tools/canvastools.cxx|4 canvas/source/tools/verifyinput.cxx|4 canvas/source/vcl/cachedbitmap.hxx | 26 - canvas/source/vcl/canvas.cxx |2 canvas/source/vcl/canvas.hxx | 32 +- canvas/source/vcl/canvasbitmap.hxx | 28 - canvas/source/vcl/canvasbitmaphelper.hxx | 36 +- canvas/source/vcl/canvascustomsprite.hxx | 22 - canvas/source/vcl/canvasfont.cxx |4 canvas/source/vcl/canvasfont.hxx | 36 +- canvas/source/vcl/canvashelper.hxx | 306 ++--- canvas/source/vcl/devicehelper.cxx |2 canvas/source/vcl/devicehelper.hxx | 52 +-- canvas/source/vcl/impltools.hxx| 26 - canvas/source/vcl/repainttarget.hxx|4 canvas/source/vcl/spritecanvas.cxx |2 canvas/source/vcl/spritecanvas.hxx | 42 +- canvas/source/vcl/spritecanvashelper.hxx | 42 +- canvas/source/vcl/spritedevicehelper.hxx |8 canvas/source/vcl/spritehelper.hxx
[Libreoffice-commits] online.git: 3 commits - loleaflet/src loolwsd/LOOLSession.cpp
loleaflet/src/control/Control.Parts.js |3 ++-
loleaflet/src/layer/tile/TileLayer.js | 12
loolwsd/LOOLSession.cpp|2 +-
3 files changed, 11 insertions(+), 6 deletions(-)
New commits:
commit b0834709018a1f04af6802eb153fed7dfc2377c1
Author: Mihai Varga mihai.va...@collabora.com
Date: Wed Jul 22 15:26:19 2015 +0300
loleaflet: set calc sheet names in tabs
diff --git a/loleaflet/src/control/Control.Parts.js
b/loleaflet/src/control/Control.Parts.js
index ca8d5e2..f8646b6 100644
--- a/loleaflet/src/control/Control.Parts.js
+++ b/loleaflet/src/control/Control.Parts.js
@@ -58,6 +58,7 @@ L.Control.Parts = L.Control.extend({
var parts = e.parts;
var currentPart = e.currentPart;
var docType = e.docType;
+ var partNames = e.partNames;
if (currentPart === 0) {
L.DomUtil.addClass(this._prevPartButton, className);
} else {
@@ -106,7 +107,7 @@ L.Control.Parts = L.Control.extend({
for (i = 0; i parts; i++) {
id = 'spreadsheet-tab' + i;
var tab = L.DomUtil.create('li', '',
container);
- tab.innerHTML = 'Sheet ' + (i + 1);
+ tab.innerHTML = partNames[i];
tab.id = id;
L.DomEvent
.on(tab, 'click',
L.DomEvent.stopPropagation)
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 85b5ad4..02ae828 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -328,8 +328,9 @@ L.TileLayer = L.GridLayer.extend({
this._parts = command.parts;
this._currentPart = command.currentPart;
this.sendMessage('setclientpart part=' +
this._currentPart);
- var partNamesStr = bytes === undefined ?
textMsg : String.fromCharCode.apply(null, bytes.subarray(index));
- var partNames = partNamesStr.match(/[^\r\n]+/g);
+ var partNames = textMsg.match(/[^\r\n]+/g);
+ // only get the last matches
+ partNames = partNames.slice(partNames.length -
this._parts);
this._map.fire('updateparts', {
currentPart: this._currentPart,
parts: this._parts,
commit e29d7c8468647b997014f461c0110ff3d7a7e82d
Author: Mihai Varga mihai.va...@collabora.com
Date: Wed Jul 22 15:09:14 2015 +0300
loolwsd: save the whole status not only the fst line
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 3294806..3b33f13 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -195,7 +195,7 @@ bool MasterProcessSession::handleInput(const char *buffer,
int length)
}
else if (tokens[0] == status:)
{
-peer-_tileCache-saveStatus(firstLine);
+peer-_tileCache-saveStatus(std::string(buffer, length));
}
else if (tokens[0] == invalidatetiles:)
{
commit 379072c0aa2729d5a5ce59776441a12f739f785f
Author: Mihai Varga mihai.va...@collabora.com
Date: Wed Jul 22 15:08:11 2015 +0300
loleaflet: parse the whole message if it's not a tile
Some messages might have new line characters
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 99b4df1..85b5ad4 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -185,6 +185,10 @@ L.TileLayer = L.GridLayer.extend({
if (!textMsg.startsWith('tile:')) {
// log the tile msg separately as we need the tile
coordinates
L.Log.log(textMsg, L.INCOMING);
+ if (bytes !== undefined) {
+ // if it's not a tile, parse the whole message
+ textMsg = String.fromCharCode.apply(null,
bytes);
+ }
}
if (textMsg.startsWith('cursorvisible:')) {
@@ -438,7 +442,6 @@ L.TileLayer = L.GridLayer.extend({
this._onUpdateTextSelection();
}
else if (textMsg.startsWith('textselectioncontent:')) {
- textMsg += String.fromCharCode.apply(null,
bytes.subarray(index));
this._selectionTextContent = textMsg.substr(22);
}
else if (textMsg.startsWith('setpart:')) {
@@ -476,7 +479,7 @@ L.TileLayer =
[Libreoffice-bugs] [Bug 92831] Position vertical scroll bar widget outboard of Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92831 --- Comment #9 from V Stuart Foote vstuart.fo...@utsa.edu --- Closing is a bit short sighted, consider behavior when the Sidebar is undocked. Also, as I hope, at some not too distant future date behavior when we are able to split out multiple content panel decks independently. At that point the mix of docked and floating Sidebar widgets would in fact benefit from from the vertical scroll bar of the document canvas being consistently attached to right edge of frame. We lose nothing by attaching to right edge of frame now, and it simplifies design and development going forward. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92856] FILEOPEN: Incorrect table document formatting created in MS Office
https://bugs.documentfoundation.org/show_bug.cgi?id=92856 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Priority|medium |high Summary|Incorrect table document|FILEOPEN: Incorrect table |formatting created in MS|document formatting created |Office |in MS Office Whiteboard|filter:doc |filter:doc interoperability --- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu --- Setting high for regression in import filter from 4.x @bazilio, do you have any additional examples like this of MS Word originated .DOC files with table troubles that you can attach? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
