[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-2.wmf |binary
vcl/source/filter/wmf/enhwmf.cxx |7 ---
2 files changed, 4 insertions(+), 3 deletions(-)
New commits:
commit dfba79d2c2e332fca82ac5a236ee74b90892c62f
Author: Caolán McNamara caol...@redhat.com
Date: Wed Aug 12 16:30:21 2015 +0100
another avoid endless loop with busted wmf
Change-Id: Ie4068fdc1e54e0ad3e55354938a4c5e1459e7fe0
(cherry picked from commit 7ffe6aebb44ed3f7b5fd1ffe3ccfccf0f61984b3)
Reviewed-on: https://gerrit.libreoffice.org/17683
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-2.wmf
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-2.wmf
new file mode 100644
index 000..f8f1538
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-2.wmf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 63e4104..8e19bc2 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -637,14 +637,15 @@ bool EnhWMFReader::ReadEnhWMF()
break;
}
-nNextPos = pWMF-Tell() + ( nRecSize - 8 );
-
-if ( !pWMF-good() || nNextPos nEndPos )
+const sal_uInt32 nMaxPossibleRecSize = nEndPos - pWMF-Tell() + 8;
+if (nRecSize nMaxPossibleRecSize)
{
bStatus = false;
break;
}
+nNextPos = pWMF-Tell() + ( nRecSize - 8 );
+
if( !aBmpSaveList.empty()
( nRecType != EMR_STRETCHBLT )
( nRecType != EMR_STRETCHDIBITS )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92802] Calc file with large ods file slow on FILEOPEN FILESAVE REGRESSION
https://bugs.documentfoundation.org/show_bug.cgi?id=92802 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk Whiteboard|bibisectRequest perf|bibisected perf --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- If the loading and saving parts of the report were introduced separately, then this should be split into two bugs The specific commit at which loading became slow is the below (part of a series of related commits) commit a8da9a9e6b32a0479bf9fad3624ad10f329e86c1 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Mar 12 21:12:22 2013 -0400 Turns out I can't really use ScColumnImpl. Because the column source files are split; not all source files had access to the impl class definition. Change-Id: Ic8cff0eeec3504660304be9f020c40bcd98cee85 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93204] Write freeze while saving document, creating pdf (OSX El Capitan Beta)
https://bugs.documentfoundation.org/show_bug.cgi?id=93204 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||898 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93020] Landscaped Page in OS X El Capitan
https://bugs.documentfoundation.org/show_bug.cgi?id=93020 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||204 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93204] Write freeze while saving document, creating pdf (OSX El Capitan Beta)
https://bugs.documentfoundation.org/show_bug.cgi?id=93204 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||020 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||204 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93368] File recovery fails on OSX El Capitan Beta
https://bugs.documentfoundation.org/show_bug.cgi?id=93368 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||898 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93368] File recovery fails on OSX El Capitan Beta
https://bugs.documentfoundation.org/show_bug.cgi?id=93368 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||020 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93204] Write freeze while saving document, creating pdf (OSX El Capitan Beta)
https://bugs.documentfoundation.org/show_bug.cgi?id=93204 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||368 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93368] File recovery fails on OSX El Capitan Beta
https://bugs.documentfoundation.org/show_bug.cgi?id=93368 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||204 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93020] Landscaped Page in OS X El Capitan
https://bugs.documentfoundation.org/show_bug.cgi?id=93020 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||368 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93394] pages lost in saved document
https://bugs.documentfoundation.org/show_bug.cgi?id=93394 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- @Eric : sounds like either LibreOffice or Crashplan don't know how to manage file conflicts in multiple versions with each other. This may not entirely be LibreOffice's fault, although it could also be the hibernation system of OSX that has screwed up the file (which kind of rings a bell from way back). This is bugzilla, for bugs, not a user support forum. We do not recover corrupted files here. You might have better luck on the user mailing list or LibreOffice forum. Without having exact steps as to how to reproduce the problem, confirming the bug report is going to be difficult. LibreOffice can create its own backups in memory with the appropriately ticked option, but this is not particularly robust. If this option was activated, you might be able to find some of the LO backup files in your user profile folder (somewhere in /Users/username/Library/Application Support/LibreOffice. Otherwise, files, when open are stored in /tmp. Sometimes it is possible to retrieve data from such temporary files. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93394] Data lost in docx saved document after hibernation and using Crashplan
https://bugs.documentfoundation.org/show_bug.cgi?id=93394 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|pages lost in saved |Data lost in docx saved |document|document after hibernation ||and using Crashplan -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: fpicker/source fpicker/test
fpicker/source/aqua/SalAquaFilePicker.hxx |4 ++--
fpicker/source/aqua/SalAquaFolderPicker.hxx |4 ++--
fpicker/source/office/OfficeFolderPicker.hxx |4 ++--
fpicker/source/office/commonpicker.hxx|4 ++--
fpicker/source/office/fpinteraction.hxx |4 ++--
fpicker/source/win32/filepicker/FilePicker.hxx|4 ++--
fpicker/source/win32/filepicker/VistaFilePicker.hxx |4 ++--
fpicker/source/win32/filepicker/workbench/Test_fps.cxx|4 ++--
fpicker/source/win32/folderpicker/FolderPicker.hxx|4 ++--
fpicker/source/win32/folderpicker/workbench/Test_fops.cxx |1 -
fpicker/test/svdem.cxx|1 -
11 files changed, 18 insertions(+), 20 deletions(-)
New commits:
commit b73d8b16d5509d54460189547746352d5454448c
Author: Takeshi Abe t...@fixedpoint.jp
Date: Thu Aug 13 08:06:26 2015 +0900
fpicker: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.
Change-Id: I448557260d5a1a2534b40e2ad33e8f9d9e72b80e
Reviewed-on: https://gerrit.libreoffice.org/17686
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/fpicker/source/aqua/SalAquaFilePicker.hxx
b/fpicker/source/aqua/SalAquaFilePicker.hxx
index db68ae4..9a32f31 100644
--- a/fpicker/source/aqua/SalAquaFilePicker.hxx
+++ b/fpicker/source/aqua/SalAquaFilePicker.hxx
@@ -20,7 +20,7 @@
#ifndef INCLUDED_FPICKER_SOURCE_AQUA_SALAQUAFILEPICKER_HXX
#define INCLUDED_FPICKER_SOURCE_AQUA_SALAQUAFILEPICKER_HXX
-#include cppuhelper/compbase4.hxx
+#include cppuhelper/compbase.hxx
#include com/sun/star/lang/XInitialization.hpp
#include com/sun/star/lang/XServiceInfo.hpp
#include com/sun/star/ui/dialogs/XFilePicker3.hpp
@@ -35,7 +35,7 @@
// Implementation class for the XFilePicker Interface
-typedef ::cppu::WeakComponentImplHelper4
+typedef ::cppu::WeakComponentImplHelper
::com::sun::star::ui::dialogs::XFilePicker3,
::com::sun::star::ui::dialogs::XFilePickerControlAccess,
::com::sun::star::lang::XInitialization,
diff --git a/fpicker/source/aqua/SalAquaFolderPicker.hxx
b/fpicker/source/aqua/SalAquaFolderPicker.hxx
index e8f95d7..9de88bd 100644
--- a/fpicker/source/aqua/SalAquaFolderPicker.hxx
+++ b/fpicker/source/aqua/SalAquaFolderPicker.hxx
@@ -20,7 +20,7 @@
#ifndef INCLUDED_FPICKER_SOURCE_AQUA_SALAQUAFOLDERPICKER_HXX
#define INCLUDED_FPICKER_SOURCE_AQUA_SALAQUAFOLDERPICKER_HXX
-#include cppuhelper/implbase3.hxx
+#include cppuhelper/implbase.hxx
#include com/sun/star/util/XCancellable.hpp
#include com/sun/star/lang/XEventListener.hpp
#include com/sun/star/lang/XServiceInfo.hpp
@@ -37,7 +37,7 @@
class SalAquaFolderPicker :
public SalAquaPicker,
-public cppu::WeakImplHelper3
+public cppu::WeakImplHelper
::com::sun::star::ui::dialogs::XFolderPicker2,
::com::sun::star::lang::XServiceInfo,
::com::sun::star::lang::XEventListener
diff --git a/fpicker/source/office/OfficeFolderPicker.hxx
b/fpicker/source/office/OfficeFolderPicker.hxx
index b2697ae..ab72367 100644
--- a/fpicker/source/office/OfficeFolderPicker.hxx
+++ b/fpicker/source/office/OfficeFolderPicker.hxx
@@ -19,7 +19,7 @@
#ifndef INCLUDED_FPICKER_SOURCE_OFFICE_OFFICEFOLDERPICKER_HXX
#define INCLUDED_FPICKER_SOURCE_OFFICE_OFFICEFOLDERPICKER_HXX
-#include cppuhelper/implbase3.hxx
+#include cppuhelper/implbase.hxx
#include com/sun/star/ui/dialogs/XFolderPicker2.hpp
#include com/sun/star/ui/dialogs/XAsynchronousExecutableDialog.hpp
#include com/sun/star/lang/XServiceInfo.hpp
@@ -31,7 +31,7 @@
class Dialog;
typedef
-cppu::ImplInheritanceHelper3
+cppu::ImplInheritanceHelper
svt::OCommonPicker, com::sun::star::ui::dialogs::XFolderPicker2,
com::sun::star::ui::dialogs::XAsynchronousExecutableDialog,
com::sun::star::lang::XServiceInfo
diff --git a/fpicker/source/office/commonpicker.hxx
b/fpicker/source/office/commonpicker.hxx
index b74f1a9..30c1ed7 100644
--- a/fpicker/source/office/commonpicker.hxx
+++ b/fpicker/source/office/commonpicker.hxx
@@ -20,7 +20,7 @@
#ifndef INCLUDED_FPICKER_SOURCE_OFFICE_COMMONPICKER_HXX
#define INCLUDED_FPICKER_SOURCE_OFFICE_COMMONPICKER_HXX
-#include cppuhelper/compbase5.hxx
+#include cppuhelper/compbase.hxx
#include com/sun/star/ui/dialogs/XControlInformation.hpp
#include com/sun/star/ui/dialogs/XControlAccess.hpp
#include com/sun/star/lang/XMultiServiceFactory.hpp
@@ -43,7 +43,7 @@ namespace svt
{
-typedef ::cppu::WeakComponentImplHelper5
::com::sun::star::ui::dialogs::XControlAccess
+typedef ::cppu::WeakComponentImplHelper
::com::sun::star::ui::dialogs::XControlAccess
,
::com::sun::star::ui::dialogs::XControlInformation
,
[Libreoffice-commits] core.git: vcl/inc vcl/osx
vcl/inc/osx/salinst.h| 47 +++---
vcl/inc/saldatabasic.hxx |6 ++--
vcl/osx/salframeview.mm | 58 ---
vcl/osx/salmenu.cxx | 22 -
vcl/osx/salnsmenu.mm | 21 -
vcl/osx/salnstimer.mm|8 +++---
vcl/osx/saltimer.cxx |6
vcl/osx/vclnsapp.mm | 29 ---
8 files changed, 104 insertions(+), 93 deletions(-)
New commits:
commit 2c797c39478b485c0285eb351d23e0d4e0fa7585
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Wed Aug 12 21:38:20 2015 -0500
kill YIELD_GUARD macro
Change-Id: I81990df584255f4a286cd078bcf15917c00ad504
Reviewed-on: https://gerrit.libreoffice.org/17687
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h
index 24b7b6f..ba0eb12 100644
--- a/vcl/inc/osx/salinst.h
+++ b/vcl/inc/osx/salinst.h
@@ -20,18 +20,17 @@
#ifndef INCLUDED_VCL_INC_OSX_SALINST_H
#define INCLUDED_VCL_INC_OSX_SALINST_H
-#include comphelper/solarmutex.hxx
-#include osl/thread.hxx
-#include osl/conditn.h
+#include list
+
+#include comphelper/solarmutex.hxx
+#include osl/conditn.h
+#include osl/thread.hxx
#ifdef MACOSX
#include osx/osxvcltypes.h
#endif
-
#include salinst.hxx
-#include list
-
class AquaSalFrame;
class ApplicationEvent;
class Image;
@@ -39,7 +38,7 @@ class Image;
class SalYieldMutex : public comphelper::SolarMutex
{
osl::Mutex m_mutex;
-sal_uLong mnCount;
+sal_uLong mnCount;
oslThreadIdentifier mnThreadId;
public:
@@ -51,8 +50,6 @@ public:
oslThreadIdentifier GetThreadId() const { return
mnThreadId; }
};
-#define YIELD_GUARD osl::Guard comphelper::SolarMutex aGuard(
GetSalData()-mpFirstInstance-GetYieldMutex() )
-
class AquaSalInstance : public SalInstance
{
struct SalUserEvent
@@ -68,7 +65,7 @@ class AquaSalInstance : public SalInstance
public:
SalYieldMutex* mpSalYieldMutex;//
Sal-Yield-Mutex
-OUString maDefaultPrinter;
+OUStringmaDefaultPrinter;
oslThreadIdentifier maMainThread;
boolmbWaitingYield;
int mnActivePrintJobs;
@@ -86,12 +83,13 @@ public:
virtual SalFrame* CreateChildFrame( SystemParentData* pParent,
sal_uLong nStyle ) SAL_OVERRIDE;
virtual SalFrame* CreateFrame( SalFrame* pParent, sal_uLong nStyle )
SAL_OVERRIDE;
virtual voidDestroyFrame( SalFrame* pFrame ) SAL_OVERRIDE;
-virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData*
pWindowData, bool bShow = true ) SAL_OVERRIDE;
+virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData*
pWindowData,
+ bool bShow = true ) SAL_OVERRIDE;
virtual voidDestroyObject( SalObject* pObject ) SAL_OVERRIDE;
-virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics,
- long nDX, long nDY,
- sal_uInt16 nBitCount,
- const SystemGraphicsData
*pData ) SAL_OVERRIDE;
+virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics,
+ long nDX, long nDY,
+ sal_uInt16 nBitCount,
+ const SystemGraphicsData
*pData ) SAL_OVERRIDE;
virtual SalInfoPrinter* CreateInfoPrinter( SalPrinterQueueInfo* pQueueInfo,
ImplJobSetup* pSetupData )
SAL_OVERRIDE;
virtual voidDestroyInfoPrinter( SalInfoPrinter* pPrinter )
SAL_OVERRIDE;
@@ -102,28 +100,31 @@ public:
virtual voidDeletePrinterQueueInfo( SalPrinterQueueInfo* pInfo
) SAL_OVERRIDE;
virtual OUStringGetDefaultPrinter() SAL_OVERRIDE;
virtual SalTimer* CreateSalTimer() SAL_OVERRIDE;
-virtual SalI18NImeStatus* CreateI18NImeStatus() SAL_OVERRIDE;
+virtual SalI18NImeStatus* CreateI18NImeStatus() SAL_OVERRIDE;
virtual SalSystem* CreateSalSystem() SAL_OVERRIDE;
virtual SalBitmap* CreateSalBitmap() SAL_OVERRIDE;
virtual comphelper::SolarMutex* GetYieldMutex() SAL_OVERRIDE;
virtual sal_uLong ReleaseYieldMutex() SAL_OVERRIDE;
virtual voidAcquireYieldMutex( sal_uLong nCount ) SAL_OVERRIDE;
virtual boolCheckYieldMutex() SAL_OVERRIDE;
-virtual voidDoYield(bool bWait, bool bHandleAllCurrentEvents,
[Libreoffice-bugs] [Bug 93404] status indicator progress bar not shown while LoadComponentFromUrl
https://bugs.documentfoundation.org/show_bug.cgi?id=93404 Laurent Godard lgodard.li...@laposte.net changed: What|Removed |Added Keywords||bisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90878] MAILMERGE: Drag-and-Drop With the Data Source View again
https://bugs.documentfoundation.org/show_bug.cgi?id=90878 --- Comment #5 from Ingo Belka ingo_be...@grimmen.de --- And the bug still is present in LO 5.0.0.5 final on Win7. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91310] [META] Fallout from VclPtr merge
https://bugs.documentfoundation.org/show_bug.cgi?id=91310 Bug 91310 depends on bug 91782, which changed state. Bug 91782 Summary: Export draw-document to eps result in crash https://bugs.documentfoundation.org/show_bug.cgi?id=91782 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93405] FILESAVE Slowdown saving ODS
https://bugs.documentfoundation.org/show_bug.cgi?id=93405 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected, regression Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 Whiteboard||bibisected perf --- Comment #1 from Matthew Francis fdb...@neosheffield.co.uk --- One commit in a range identified on the original report at which the save time increased significantly is the below. This isn't the earliest speed regression, however. commit f9704bf73dfba50421132e5379165912a2779906 Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Tue Jun 25 11:06:43 2013 -0400 The horizontal cell iterator was *still* broken. Let's fix it again. And add a test for it. Change-Id: If76a67e02ac6ad5199d664850bd8591bd3032f32 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92324] printing of labels (Next dataset fields) via file-print is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=92324 Vasily Melenchuk vasily.melenc...@cib.de changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |vasily.melenc...@cib.de |desktop.org | Ever confirmed|0 |1 --- Comment #3 from Vasily Melenchuk vasily.melenc...@cib.de --- Bug was reproduced successfully only on Linux. No problems in Windows. Version: 5.1.0.0.alpha1+ Build ID: 71aed9185fb17ee27bdc38b4ac650713c4cabb8b Locale: en-US (en_US.UTF-8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 63e1890675ecaaf50d855a1daf85fc41798bb898 Author: Stephan Bergmann sberg...@redhat.com Date: Thu Aug 13 10:46:22 2015 +0200 loplugin:stringconstant Change-Id: I2444c480d5bd1aca814bdf1159f8857fcaa85830 diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index 2230c76..d59f3b3 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -2189,7 +2189,7 @@ void SwUiWriterTest::testUnicodeNotationToggle() pWrtShell-EndPara(); sOriginalDocString = pWrtShell-GetCrsr()-GetNode().GetTextNode()-GetText(); -CPPUNIT_ASSERT( sOriginalDocString.equals(uU+2b) ); +CPPUNIT_ASSERT_EQUAL(OUString(uU+2b), sOriginalDocString); lcl_dispatchCommand(mxComponent, .uno:UnicodeNotationToggle, aPropertyValues); sExpectedString = u+; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: another life-cycle/timing bug
On 08/12/2015 11:52 PM, Norbert Thiebaud wrote: Thread 4 Crashed: 0 libupdchklo.dylib 0x000122446611 rtl::OUString::equalsAscii(char const*) const + 33 1 libupdchklo.dylib 0x0001224401cf NamedValueByNameAccess::getValue(char const*) + 95 2 libupdchklo.dylib 0x00012244038c UpdateCheckROModel::getStringValue(char const*) const + 60 3 libupdchklo.dylib 0x000122440543 UpdateCheckROModel::getUpdateEntryVersion() const + 35 4 libupdchklo.dylib 0x0001224298c5 UpdateCheck::initialize(com::sun::star::uno::Sequencecom::sun::star::beans::NamedValue const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const) + 197 5 libupdchklo.dylib 0x00012244f25f (anonymous namespace)::InitUpdateCheckJobThread::run() + 207 6 libupdchklo.dylib 0x00012243aa3e threadFunc + 30 7 libuno_sal.dylib.30x0001023ed11f osl_thread_start_Impl(void*) + 335 (thread.cxx:248) 8 libsystem_pthread.dylib 0x7fff954bc268 _pthread_body + 131 9 libsystem_pthread.dylib 0x7fff954bc1e5 _pthread_start + 176 10 libsystem_pthread.dylib 0x7fff954ba41d thread_start + 13 The code in extensions/source/update/check/ is notorious for spawning threads that are not guaranteed to be joined well before exit, so can cause all kinds of breakage when still running during exit. For now, best avoid that with --disable-online-update. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93185] Can't change the color of text in table control field of a database form
https://bugs.documentfoundation.org/show_bug.cgi?id=93185 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||tony.sm...@wmfs.net --- Comment #16 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 93379 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93379] Libreoffice 5 Base Form grid not accepting font colour
https://bugs.documentfoundation.org/show_bug.cgi?id=93379 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- *** This bug has been marked as a duplicate of bug 93185 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93394] Data lost in docx saved document after hibernation and using Crashplan
https://bugs.documentfoundation.org/show_bug.cgi?id=93394 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- At present, there are too many variables in the scenario to be able to reproduce. I have no idea what Crashplan is, nor do I intend to use it. The only thing I could possibly try is an export to docx then hibernate the Mac, e.g. by closing the lid. However, to date, I can not recall having encountered a problem with this in current versions of LibreOffice. You are using and end of life version of LibreOffice, so you could perhaps try updating to a newer one if that is possible for you. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/vba/vbatablehelper.cxx |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
New commits:
commit 348cc2ce1e932f0fcaf90f9cf4d6dc9594f3f8a2
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 13 08:33:37 2015 +0100
wrong row/col count limits
thanks to ccsheller for noticing
Change-Id: Idb0f39c48173445b750e0b85ac20b3f6b43691a7
diff --git a/sw/source/ui/vba/vbatablehelper.cxx
b/sw/source/ui/vba/vbatablehelper.cxx
index 755ecd8..65f02fd 100644
--- a/sw/source/ui/vba/vbatablehelper.cxx
+++ b/sw/source/ui/vba/vbatablehelper.cxx
@@ -61,7 +61,6 @@ sal_Int32 SwVbaTableHelper::getTabColumnsCount( sal_Int32
nRowIndex ) throw (uno
sal_Int32 SwVbaTableHelper::getTabColumnsMaxCount( ) throw
(uno::RuntimeException)
{
sal_Int32 nRet = 0;
-//sal_Int32 nRowCount = mxTextTable-getRows()-getCount();
sal_Int32 nRowCount = pTable-GetTabLines().size();
for( sal_Int32 index = 0; index nRowCount; index++ )
{
@@ -141,15 +140,15 @@ SwTableBox* SwVbaTableHelper::GetTabBox( sal_Int32 nCol,
sal_Int32 nRow ) throw
{
SwTableLines rLines = pTable-GetTabLines();
sal_Int32 nRowCount = rLines.size();
-if( nRowCount nRow )
+if (nRow = nRowCount)
throw uno::RuntimeException();
-SwTableBox* pStart = NULL;
SwTableLine* pLine = rLines[ nRow ];
-if( (sal_Int32)pLine-GetTabBoxes().size() nCol )
+sal_Int32 nColCount = pLine-GetTabBoxes().size();
+if (nCol = nColCount)
throw uno::RuntimeException();
-pStart = pLine-GetTabBoxes()[ nCol ];
+SwTableBox* pStart = pLine-GetTabBoxes()[ nCol ];
if( !pStart )
throw uno::RuntimeException();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92802] Large ODS file slow on FILEOPEN
https://bugs.documentfoundation.org/show_bug.cgi?id=92802 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Summary|Calc file with large ods|Large ODS file slow on |file slow on FILEOPEN |FILEOPEN |FILESAVE REGRESSION | --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- Save speed regression split - bug 93405 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89525] Impress does not export slides bullets to PPTX correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=89525 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- Not clear why this was linked to the earlier report rather than just marked as a duplicate. If there's a reason please comment - thanks *** This bug has been marked as a duplicate of bug 77881 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77881] FILESAVE: Bullets are lost when saving in OOxml (.pptx or .ppsx)
https://bugs.documentfoundation.org/show_bug.cgi?id=77881 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||lili...@gmail.com --- Comment #27 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 89525 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91844] Bullet shapes are not retained when saving presentation in pptx or other microsoft format
https://bugs.documentfoundation.org/show_bug.cgi?id=91844 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- *** This bug has been marked as a duplicate of bug 77881 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77881] FILESAVE: Bullets are lost when saving in OOxml (.pptx or .ppsx)
https://bugs.documentfoundation.org/show_bug.cgi?id=77881 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||narayanvenugo...@hotmail.co ||M --- Comment #29 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 91844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93368] File recovery fails on OSX El Capitan Beta
https://bugs.documentfoundation.org/show_bug.cgi?id=93368 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||ipla...@yahoo.co.uk Summary|FILEOPEN|File recovery fails on OSX ||El Capitan Beta Severity|blocker |major --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Per QA policy, there are no blockers Without a test file that causes the crash and crash reporter to start, there is no way for us to reproduce this. Please provide a test file that causes the problem. Also, there is no one from QA currently using OSX Beta. Other issues of instability are already known for El Capitan. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93348] Base crashes when entering login information for jdbc connection to MariaDB database.
https://bugs.documentfoundation.org/show_bug.cgi?id=93348 --- Comment #2 from Andreas Gottardi andreas.gotta...@gmx.at --- Found a command line parameter to pass to JVM to force it to create this log file but it did not create it. The only thing i found in the temporary folder was a file which had the process id as name but it did not contain any useful information. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93394] Data lost in docx saved document after hibernation and using Crashplan
https://bugs.documentfoundation.org/show_bug.cgi?id=93394 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- If I attempt to open your docx file, in LibreOffice 5.0.0.5, I get the following error : rreur de format de fichier à la position SAXParseException: '[word/document.xml line 2]: Opening and ending tag mismatch: hyperlink line 0 and p ', Stream 'word/document.xml', Line 2, Column 25399(row,col). which indicates that the XML has been corrupted. As both docx and LO use XML based content, it should be possible for you to unzip this file and try and find the missing/incorrect tag at the position indicated in the message, and correct it, resave, and then try and re-open, bearing in mind that the XML processor will stop at the first error it encounters, so there may be others in the file. Perhaps there is a tool you can find that will allow you to run the XML through a checker that has some form of autocorrect mechanism for docx files. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93403] New: LO Base grid – change DataField name
https://bugs.documentfoundation.org/show_bug.cgi?id=93403 Bug ID: 93403 Summary: LO Base grid – change DataField name Product: LibreOffice Version: 4.4.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sgre...@yahoo.com Using a macro, I want to change the data displayed in a grid column from one table field to a different field of the same table. This was working fine in version 4.2.8.2 with the following code: oForm = ThisComponent.Drawpage.Forms.getByName(MainForm) oField = oForm.getByName(TestTable) oColumn = oField.getByName(FormattedField1) oColumn.DataField = MONTH3INFO oColumn.Label = MONTH3INFO oColumn.Name = MONTH3INFO oForm.Reload() I recently found out this version was ending its' life cycle so I upgraded to v5.0.0.5 and most of my code works fine except for this particular piece. It is a critical part of the system design and I haven't figured out a way around it. I receive no errors, the Label, Name and DataField all change properly (used MRI) but the data never changes. However checking BoundField (read only) I see it is still pointing to the previous data field. I have also gone back and tried v4.4.5.2 and the results were the same. Finally, I reloaded 4.2.8.2 and again the code worked correctly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93404] New: status indicator progress bar not shown while LoadComponentFromUrl
https://bugs.documentfoundation.org/show_bug.cgi?id=93404 Bug ID: 93404 Summary: status indicator progress bar not shown while LoadComponentFromUrl Product: LibreOffice Version: 5.0.1.1 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lgodard.li...@laposte.net In a macro when a file is loaded through starDesktop.loadComponentFromUrl no loading file progressbar is displayed when big files, this lead to several seconds of grey window in 5.0.1 RC1 this evolved a bit as calculating progress bar is now displayed but not in 5.0.0.5. Still loading file, the longest part, is not displayed bibisecting --- (bibisect-50max repo) 7436ddb9c4b7f3f834fb61db36994380b3ba9879 is the first bad commit commit 7436ddb9c4b7f3f834fb61db36994380b3ba9879 Author: Matthew Francis mjay.fran...@gmail.com Date: Wed May 27 21:57:00 2015 +0800 source-hash-017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 commit 017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 Author: Stephan Bergmann sberg...@redhat.com AuthorDate: Wed Apr 22 14:06:37 2015 +0200 Commit: Stephan Bergmann sberg...@redhat.com CommitDate: Wed Apr 22 14:06:37 2015 +0200 Ensure WakeUpThread is joined before exit Change-Id: If50fe94875b29043c75b581bf39ca9deea59dbe3 :04 04 5b2e9a504907dc479353d63119c15db444676b12 5ca9773561cf17673161af612b9e0deacb817e50 M opt $ git bisect log # bad: [dda106fd616b7c0b8dc2370f6f1184501b01a49e] source-hash-0db96caf0fcce09b87621c11b584a6d81cc7df86 # good: [5b9dd620df316345477f0b6e6c9ed8ada7b6c091] source-hash-2851ce5afd0f37764cbbc2c2a9a63c7adc844311 git bisect start 'latest' 'oldest' # good: [0c30a2c797b249d0cd804cb71554946e2276b557] source-hash-45aaec8206182c16025cbcb20651ddbdf558b95d git bisect good 0c30a2c797b249d0cd804cb71554946e2276b557 # good: [2ce02b2ce56f12b9fcb9efbd380596975a3a5686] source-hash-17d714eef491bda2512ba8012e5b3067ca19a5be git bisect good 2ce02b2ce56f12b9fcb9efbd380596975a3a5686 # bad: [40875247f0002056effdf6d2fbe43627691cd86c] source-hash-93f0b14458a618ad575cd446680e5c4aa7d87bdc git bisect bad 40875247f0002056effdf6d2fbe43627691cd86c # bad: [07e62597be0600b763c4d18204799dcf09d2d3d9] source-hash-b2ead407c70f71974a1eac79df09072ff8bd0cc2 git bisect bad 07e62597be0600b763c4d18204799dcf09d2d3d9 # good: [65755dc98fdc972c90f86f7102d7855c833a51ec] source-hash-a75d90740647414f55ef5a37bdfb230d624ec2eb git bisect good 65755dc98fdc972c90f86f7102d7855c833a51ec # good: [eb19ce6fbff2ae1fa908027d456b0dcf64ed17c2] source-hash-0cd0206fa4392d43724f630555994af842fc0733 git bisect good eb19ce6fbff2ae1fa908027d456b0dcf64ed17c2 # bad: [16d718cb0066025e7f219520c353d4f1052eccc3] source-hash-afd8e4093687557843427d7539c4b0e6ece8bbff git bisect bad 16d718cb0066025e7f219520c353d4f1052eccc3 # good: [51f3e5cbf50b9935010da5a03e8252e6c89900ed] source-hash-95c04e218782cb198f7851a1d9536058f98cff2a git bisect good 51f3e5cbf50b9935010da5a03e8252e6c89900ed # bad: [1a9a2461bfb15a7d0428d804dd32fe66ddb7] source-hash-fd42a226246470d5083441b976bbe0017d78fcf2 git bisect bad 1a9a2461bfb15a7d0428d804dd32fe66ddb7 # bad: [5e49b139cca7d6569ec312db416667b439efe5cc] source-hash-eaf41045822732653a0af91ac0faa28fca7f0894 git bisect bad 5e49b139cca7d6569ec312db416667b439efe5cc # good: [d739e127d31e810675befe1653d88de85fcddad2] source-hash-13df0c5a2f29f008c050fae1899ccb0eef93ad55 git bisect good d739e127d31e810675befe1653d88de85fcddad2 # good: [7abd570e7b15ea1c5a8ac2a3a2e8aa15249e00aa] source-hash-deaed8aff6de824a76d939a02edb0d2ff4a4ccec git bisect good 7abd570e7b15ea1c5a8ac2a3a2e8aa15249e00aa # bad: [7436ddb9c4b7f3f834fb61db36994380b3ba9879] source-hash-017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 git bisect bad 7436ddb9c4b7f3f834fb61db36994380b3ba9879 # first bad commit: [7436ddb9c4b7f3f834fb61db36994380b3ba9879] source-hash-017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93405] New: FILESAVE Slowdown saving ODS
https://bugs.documentfoundation.org/show_bug.cgi?id=93405 Bug ID: 93405 Summary: FILESAVE Slowdown saving ODS Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fdb...@neosheffield.co.uk Split from bug 92802 as there appear to be separate load and save speed regressions for the file attachment 117292 used to save much faster than at present - initially a few seconds, currently several minutes. Further details on the above original report. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Libreoffice 5 macro never finishes loading impress
On Wed, 2015-08-12 at 07:53 -0400, Jerry Geis wrote: Is there by chance a new command line argument that will just load and immediately start showing the presentation soffice --show presentation.odp will load it and go immediately to presentation mode. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93406] New: Writer: blinking text in .docx format
https://bugs.documentfoundation.org/show_bug.cgi?id=93406 Bug ID: 93406 Summary: Writer: blinking text in .docx format Product: LibreOffice Version: 4.4.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jc_denton_2...@yahoo.it Created attachment 117879 -- https://bugs.documentfoundation.org/attachment.cgi?id=117879action=edit Example file for blinking text In some documents in .docx format (see attached example) text blinking is always enabled. If I disable it, save the document (.docx ) and reopen it, it starts blinking again. In order to verify the bug: 1) download the attached file 2) open it with writer, the text will blink 3) disable blinking (select all Character Font effects Blinking) 4) save 5) close writer 6) open the saved document with writer again, text is still blinking -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44794] Add MacOS X Resume and Versions support
https://bugs.documentfoundation.org/show_bug.cgi?id=44794 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|Add MacOS X Lion's Resume |Add MacOS X Resume and |and Versions support|Versions support --- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk --- Changing title to remove Lion, as things have moved on since then, and it would be good to have this generally supported within LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: another life-cycle/timing bug
Trying to exit cleanly is so last century. Apps should just _exit(). (Yes, I know what you are going to say about valgrind and its cousins.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93287] Cannot TAB through all Controls on Form with Form window smaller than maximum surface occupied by controls
https://bugs.documentfoundation.org/show_bug.cgi?id=93287 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93287] Cannot TAB through all Controls on Form with Form window smaller than maximum surface occupied by controls
https://bugs.documentfoundation.org/show_bug.cgi?id=93287 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|Cannot TAB through all |Cannot TAB through all |Controls on Form|Controls on Form with Form ||window smaller than maximum ||surface occupied by ||controls -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93386] Crashes when closing a Database
https://bugs.documentfoundation.org/show_bug.cgi?id=93386 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- @PJG51 : please provide more information Is the macro editor window open for editing a macro within Base or for another module, or does it make no difference ? Please indicate version of OSX. If you have a test file that reproducible causes the problem, please provide it along with instructions on how to reproduce the buggy behaviour. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - filter/source
filter/source/graphicfilter/eps/eps.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6071bab93bae55cf037d1c31c63879cab66ad0d9 Author: Julien Nabet serval2...@yahoo.fr Date: Mon Jun 1 09:27:07 2015 +0100 tdf#91782 - fix VirtualDevice allocation crasher in eps filter. Change-Id: I59cc13cebf9a15e873cd0b7f8fccffa37a6a8f39 Reviewed-on: https://gerrit.libreoffice.org/17688 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Noel Grandin noelgran...@gmail.com diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx index 177fa35..0921b9b 100644 --- a/filter/source/graphicfilter/eps/eps.cxx +++ b/filter/source/graphicfilter/eps/eps.cxx @@ -116,7 +116,7 @@ private: SvStream* mpPS; const GDIMetaFile* pMTF; GDIMetaFile*pAMTF; // only created if Graphics is not a Metafile -ScopedVclPtrVirtualDevice pVDev; +ScopedVclPtrInstanceVirtualDevice pVDev; double nBoundingX1;// this represents the bounding box double nBoundingY1; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #25 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b73d8b16d5509d54460189547746352d5454448c fpicker: tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92305] VIEWING: Multiple page view does not render properly when scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=92305 Luke lukebe...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||150 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #25 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b73d8b16d5509d54460189547746352d5454448c fpicker: tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/qa
sw/inc/ToxLinkProcessor.hxx |5 -
sw/qa/core/test_ToxLinkProcessor.cxx | 22 +++---
2 files changed, 23 insertions(+), 4 deletions(-)
New commits:
commit 5d81c9f24fbe48a0717640c1ba6bcf882b9358e2
Author: Tobias Lippert d...@fastmail.fm
Date: Thu Aug 6 20:30:28 2015 +0200
tdf#85872 ToxLinkProcessor correct header and tests
commit 6b9ab853b6a5fa71c0b6c594ed0e6e6016d13a3b changed the
behavior of the class, but the header comments were not updated.
This commit adds comments for the new behavior.
Also: The tested behavior in the unittest was changed.
This commit adapts the unittest name to the new behavior.
Change-Id: Ia364ebbc3e2bfe1b0b8e3e26269a3c162e1a05d1
Reviewed-on: https://gerrit.libreoffice.org/17510
Reviewed-by: Noel Grandin noelgran...@gmail.com
Tested-by: Noel Grandin noelgran...@gmail.com
diff --git a/sw/inc/ToxLinkProcessor.hxx b/sw/inc/ToxLinkProcessor.hxx
index a8b06d0..3887121 100644
--- a/sw/inc/ToxLinkProcessor.hxx
+++ b/sw/inc/ToxLinkProcessor.hxx
@@ -34,7 +34,10 @@ public:
/** Close a link which has been found during processing.
*
- * @throw std::runtime_error If there are no open links.
+ * @internal
+ * If you close more links than were opened, then the method will behave
+ * as if a start link was opened at position 0 with the character style
+ * STR_POOLCHR_TOXJUMP.
*/
void
CloseLink(sal_Int32 endPosition, const OUString url);
diff --git a/sw/qa/core/test_ToxLinkProcessor.cxx
b/sw/qa/core/test_ToxLinkProcessor.cxx
index e768c21..660d745 100644
--- a/sw/qa/core/test_ToxLinkProcessor.cxx
+++ b/sw/qa/core/test_ToxLinkProcessor.cxx
@@ -20,22 +20,27 @@
#include cppunit/plugin/TestPlugIn.h
#include test/bootstrapfixture.hxx
+#include poolfmt.hrc
#include swdll.hxx
+#include swtypes.hxx
+#include SwStyleNameMapper.hxx
using namespace sw;
class ToxLinkProcessorTest : public test::BootstrapFixture
{
-void ExceptionIsThrownIfTooManyLinksAreClosed();
+void NoExceptionIsThrownIfTooManyLinksAreClosed();
void AddingAndClosingTwoLinksResultsInTwoClosedLinks();
void LinkIsCreatedCorrectly();
void LinkSequenceIsPreserved();
+void StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed();
CPPUNIT_TEST_SUITE(ToxLinkProcessorTest);
-CPPUNIT_TEST(ExceptionIsThrownIfTooManyLinksAreClosed);
+CPPUNIT_TEST(NoExceptionIsThrownIfTooManyLinksAreClosed);
CPPUNIT_TEST(AddingAndClosingTwoLinksResultsInTwoClosedLinks);
CPPUNIT_TEST(LinkIsCreatedCorrectly);
CPPUNIT_TEST(LinkSequenceIsPreserved);
+CPPUNIT_TEST(StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed);
CPPUNIT_TEST_SUITE_END();
public:
void setUp() SAL_OVERRIDE {
@@ -59,7 +64,7 @@ const sal_uInt16 ToxLinkProcessorTest::POOL_ID_1 = 42;
const sal_uInt16 ToxLinkProcessorTest::POOL_ID_2 = 43;
void
-ToxLinkProcessorTest::ExceptionIsThrownIfTooManyLinksAreClosed()
+ToxLinkProcessorTest::NoExceptionIsThrownIfTooManyLinksAreClosed()
{
ToxLinkProcessor sut;
sut.StartNewLink(0, STYLE_NAME_1);
@@ -70,6 +75,17 @@
ToxLinkProcessorTest::ExceptionIsThrownIfTooManyLinksAreClosed()
}
void
+ToxLinkProcessorTest::StandardOpenLinkIsAddedWhenMoreLinksThanAvaiableAreClosed()
+{
+ToxLinkProcessor sut;
+sut.StartNewLink(0, STYLE_NAME_1);
+sut.CloseLink(1, URL_1);
+sut.CloseLink(1, URL_1);
+CPPUNIT_ASSERT_EQUAL(2u, static_castunsigned(sut.mClosedLinks.size()));
+CPPUNIT_ASSERT_EQUAL(0u,
static_castunsigned(sut.mClosedLinks.at(1).mEndTextPos));
+}
+
+void
ToxLinkProcessorTest::AddingAndClosingTwoLinksResultsInTwoClosedLinks()
{
ToxLinkProcessor sut;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90150] Page numbering in the status bar which may cause confusion
https://bugs.documentfoundation.org/show_bug.cgi?id=90150 Luke lukebe...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||305 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93404] status indicator progress bar not shown while LoadComponentFromUrl
https://bugs.documentfoundation.org/show_bug.cgi?id=93404 Laurent Godard lgodard.li...@laposte.net changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93405] FILESAVE Slowdown saving ODS
https://bugs.documentfoundation.org/show_bug.cgi?id=93405 --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- There are too many individual fluctuations in the speed of saving this file to make further bisection of much use. It needs hitting with callgrind to analyse the current state / issue(s) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/vba/vbatablehelper.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit f3bf85b8cacb0bf43e646f3c67f704cc89b72323
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 13 09:00:25 2015 +0100
check for negative numbers too
Change-Id: I4a798a4f60d0064abd7fc4e689e4c80dff8459ff
diff --git a/sw/source/ui/vba/vbatablehelper.cxx
b/sw/source/ui/vba/vbatablehelper.cxx
index 65f02fd..8a96054 100644
--- a/sw/source/ui/vba/vbatablehelper.cxx
+++ b/sw/source/ui/vba/vbatablehelper.cxx
@@ -140,12 +140,12 @@ SwTableBox* SwVbaTableHelper::GetTabBox( sal_Int32 nCol,
sal_Int32 nRow ) throw
{
SwTableLines rLines = pTable-GetTabLines();
sal_Int32 nRowCount = rLines.size();
-if (nRow = nRowCount)
+if (nRow 0 || nRow = nRowCount)
throw uno::RuntimeException();
SwTableLine* pLine = rLines[ nRow ];
sal_Int32 nColCount = pLine-GetTabBoxes().size();
-if (nCol = nColCount)
+if (nCol 0 || nCol = nColCount)
throw uno::RuntimeException();
SwTableBox* pStart = pLine-GetTabBoxes()[ nCol ];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91587] FORMATTING FILEOPEN Impress doesn't export bullets in PPTX format
https://bugs.documentfoundation.org/show_bug.cgi?id=91587 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|NEW |RESOLVED CC||fdb...@neosheffield.co.uk Resolution|--- |DUPLICATE Whiteboard|bibisectRequest | --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- Can't reproduce this having ever worked, and specifically I can't see it having worked in 4.3.7.1 This seems to me just to be a duplicate of bug 77881 *** This bug has been marked as a duplicate of bug 77881 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77881] FILESAVE: Bullets are lost when saving in OOxml (.pptx or .ppsx)
https://bugs.documentfoundation.org/show_bug.cgi?id=77881 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||jjant...@yahoo.es --- Comment #28 from Matthew Francis fdb...@neosheffield.co.uk --- *** Bug 91587 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93406] Writer: blinking text in .docx format
https://bugs.documentfoundation.org/show_bug.cgi?id=93406 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Gordo gordon1dr...@yahoo.com --- *** This bug has been marked as a duplicate of bug 92045 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92045] Unchecking blinking font effect does not work with DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=92045 Gordo gordon1dr...@yahoo.com changed: What|Removed |Added CC||jc_denton_2...@yahoo.it --- Comment #12 from Gordo gordon1dr...@yahoo.com --- *** Bug 93406 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc-tiled-rendering' - 315 commits - accessibility/inc accessibility/source avmedia/source basctl/source basic/source bin/find-duplicated-sids.py bin/f
Rebased ref, commits from common ancestor: commit 86b5c11ffa17c3ac80b1be3b40a12b46f1fc4751 Author: Pranav Kant pran...@gnome.org Date: Thu Aug 13 02:08:21 2015 +0530 widget registration Change-Id: I7455f6b9e3a6145b25bd081dc3a28ac011d02dcd diff --git a/configure.ac b/configure.ac index 7b0f031..6742d31 100644 --- a/configure.ac +++ b/configure.ac @@ -201,6 +201,11 @@ SRC_ROOT=`pwd` cd $BUILDDIR x_Cygwin=[\#] +dnl == +dnl Required GObject introspection version +dnl == +INTROSPECTION_REQUIRED_VERSION=1.32.0 + dnl === dnl Search all the common names for GNU Make dnl === @@ -12105,6 +12110,11 @@ if test $ENABLE_JAVA != ; then fi dnl === +dnl Check GObject Introspection +dnl === +GOBJECT_INTROSPECTION_CHECK(INTROSPECTION_REQUIRED_VERSION) + +dnl === dnl Test for the presence of Ant and that it works dnl === diff --git a/m4/introspection.m4 b/m4/introspection.m4 new file mode 100644 index 000..aa7b3b4 --- /dev/null +++ b/m4/introspection.m4 @@ -0,0 +1,96 @@ +dnl -*- mode: autoconf -*- +dnl Copyright 2009 Johan Dahlin +dnl +dnl This file is free software; the author(s) gives unlimited +dnl permission to copy and/or distribute it, with or without +dnl modifications, as long as this notice is preserved. +dnl + +# serial 1 + +m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL], +[ +AC_BEFORE([AC_PROG_LIBTOOL],[$0])dnl setup libtool first +AC_BEFORE([AM_PROG_LIBTOOL],[$0])dnl setup libtool first +AC_BEFORE([LT_INIT],[$0])dnl setup libtool first + +dnl enable/disable introspection +m4_if([$2], [require], +[dnl +enable_introspection=yes +],[dnl +AC_ARG_ENABLE(introspection, + AS_HELP_STRING([--enable-introspection[=@:@no/auto/yes@:@]], + [Enable introspection for this build]),, + [enable_introspection=auto]) +])dnl + +AC_MSG_CHECKING([for gobject-introspection]) + +dnl presence/version checking +AS_CASE([$enable_introspection], +[no], [dnl +found_introspection=no (disabled, use --enable-introspection to enable) +],dnl +[yes],[dnl +PKG_CHECK_EXISTS([gobject-introspection-1.0],, + AC_MSG_ERROR([gobject-introspection-1.0 is not installed])) +PKG_CHECK_EXISTS([gobject-introspection-1.0 = $1], + found_introspection=yes, + AC_MSG_ERROR([You need to have gobject-introspection = $1 installed to build AC_PACKAGE_NAME])) +],dnl +[auto],[dnl +PKG_CHECK_EXISTS([gobject-introspection-1.0 = $1], found_introspection=yes, found_introspection=no) + dnl Canonicalize enable_introspection + enable_introspection=$found_introspection +],dnl +[dnl +AC_MSG_ERROR([invalid argument passed to --enable-introspection, should be one of @:@no/auto/yes@:@]) +])dnl + +AC_MSG_RESULT([$found_introspection]) + +INTROSPECTION_SCANNER= +INTROSPECTION_COMPILER= +INTROSPECTION_GENERATE= +INTROSPECTION_GIRDIR= +INTROSPECTION_TYPELIBDIR= +if test x$found_introspection = xyes; then + INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0` + INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0` + INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0` + INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0` + INTROSPECTION_TYPELIBDIR=$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0) + INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags gobject-introspection-1.0` + INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0` + INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection +fi +AC_SUBST(INTROSPECTION_SCANNER) +AC_SUBST(INTROSPECTION_COMPILER) +AC_SUBST(INTROSPECTION_GENERATE) +AC_SUBST(INTROSPECTION_GIRDIR) +AC_SUBST(INTROSPECTION_TYPELIBDIR) +AC_SUBST(INTROSPECTION_CFLAGS) +AC_SUBST(INTROSPECTION_LIBS) +AC_SUBST(INTROSPECTION_MAKEFILE) + +AM_CONDITIONAL(HAVE_INTROSPECTION, test x$found_introspection = xyes) +]) + + +dnl Usage: +dnl GOBJECT_INTROSPECTION_CHECK([minimum-g-i-version]) + +AC_DEFUN([GOBJECT_INTROSPECTION_CHECK], +[ + _GOBJECT_INTROSPECTION_CHECK_INTERNAL([$1]) +]) + +dnl Usage: +dnl GOBJECT_INTROSPECTION_REQUIRE([minimum-g-i-version]) + +
[Libreoffice-bugs] [Bug 93287] Cannot TAB through all Controls on Form
https://bugs.documentfoundation.org/show_bug.cgi?id=93287 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- COnfirming on Version: 5.0.0.5 Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b Locale : fr-FR (fr.UTF-8) OSX 10.10.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||368 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 90222] replace ScaList in scaddins with a std container
https://bugs.documentfoundation.org/show_bug.cgi?id=90222 --- Comment #26 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Ian committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=4498c5e1d0e0c98055d6ce6ad22c840e89b401cc tdf#90222: Removed ScaList and cleaned up usages It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scaddins/source
scaddins/source/datefunc/datefunc.cxx | 99 --
scaddins/source/datefunc/datefunc.hxx | 57 +++
2 files changed, 47 insertions(+), 109 deletions(-)
New commits:
commit 4498c5e1d0e0c98055d6ce6ad22c840e89b401cc
Author: Ian ian.gil...@gmail.com
Date: Wed Aug 12 15:00:50 2015 +0100
tdf#90222: Removed ScaList and cleaned up usages
- Removed now-unused ScaList type
- Changed ScaFuncDataMap from a map to a vector, using find_if for
lookup.
Change-Id: Ia22763f221f9a58d85dc363cab2585d7df37877c
Reviewed-on: https://gerrit.libreoffice.org/17678
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
diff --git a/scaddins/source/datefunc/datefunc.cxx
b/scaddins/source/datefunc/datefunc.cxx
index 5b48c90..cbba443 100644
--- a/scaddins/source/datefunc/datefunc.cxx
+++ b/scaddins/source/datefunc/datefunc.cxx
@@ -26,7 +26,7 @@
#include rtl/ustrbuf.hxx
#include tools/rcid.h
#include tools/resmgr.hxx
-#include utility
+#include algorithm
using namespace ::com::sun::star;
@@ -36,32 +36,6 @@ using namespace ::com::sun::star;
#define STR_FROM_ANSI( s ) OUString( s, strlen( s ),
RTL_TEXTENCODING_MS_1252 )
-const sal_uInt32 ScaList::nStartSize = 16;
-const sal_uInt32 ScaList::nIncrSize = 16;
-
-ScaList::ScaList() :
-pData( new void*[ nStartSize ] ),
-nSize( nStartSize ),
-nCount( 0 ),
-nCurr( 0 )
-{
-}
-
-ScaList::~ScaList()
-{
-delete[] pData;
-}
-
-void ScaList::_Grow()
-{
-nSize += nIncrSize;
-
-void** pNewData = new void*[ nSize ];
-memcpy( pNewData, pData, nCount * sizeof( void* ) );
-
-delete[] pData;
-pData = pNewData;
-}
ScaResId::ScaResId( sal_uInt16 nId, ResMgr rResMgr ) :
ResId( nId, rResMgr )
@@ -119,14 +93,10 @@ sal_uInt16 ScaFuncData::GetStrIndex( sal_uInt16 nParam )
const
}
-void InitScaFuncDataMap( ScaFuncDataMap rMap, ResMgr rResMgr )
+void InitScaFuncDataList( ScaFuncDataList rList, ResMgr rResMgr )
{
for( sal_uInt16 nIndex = 0; nIndex SAL_N_ELEMENTS(pFuncDataArr);
nIndex++ )
-{
-rMap.insert( std::make_pair(
- OUString::createFromAscii(pFuncDataArr[ nIndex
].pIntName),
- ScaFuncData( pFuncDataArr[ nIndex ], rResMgr ) ) );
-}
+rList.push_back( ScaFuncData( pFuncDataArr[ nIndex ], rResMgr ) );
}
ScaFuncRes::ScaFuncRes( ResId rResId, ResMgr rResMgr, sal_uInt16 nIndex,
OUString rRet ) :
@@ -175,13 +145,13 @@ SAL_DLLPUBLIC_EXPORT void * SAL_CALL
date_component_getFactory(
ScaDateAddIn::ScaDateAddIn() :
pDefLocales( NULL ),
pResMgr( NULL ),
-pFuncDataMap( NULL )
+pFuncDataList( NULL )
{
}
ScaDateAddIn::~ScaDateAddIn()
{
-delete pFuncDataMap;
+delete pFuncDataList;
delete pResMgr;
delete[] pDefLocales;
}
@@ -224,16 +194,16 @@ void ScaDateAddIn::InitData()
{
delete pResMgr;
pResMgr = ResMgr::CreateResMgr(date, LanguageTag(aFuncLoc));
-delete pFuncDataMap;
+delete pFuncDataList;
if ( pResMgr )
{
-pFuncDataMap = new ScaFuncDataMap;
-InitScaFuncDataMap( *pFuncDataMap, *pResMgr );
+pFuncDataList = new ScaFuncDataList;
+InitScaFuncDataList( *pFuncDataList, *pResMgr );
}
else
{
-pFuncDataMap = nullptr;
+pFuncDataList = nullptr;
}
if( pDefLocales )
@@ -323,12 +293,12 @@ OUString SAL_CALL ScaDateAddIn::getDisplayFunctionName(
const OUString aProgram
{
OUString aRet;
-auto fDataIt = pFuncDataMap-find( aProgrammaticName );
-if( fDataIt != pFuncDataMap-end() )
+auto fDataIt = std::find_if(pFuncDataList-begin(), pFuncDataList-end(),
+FindScaFuncData( aProgrammaticName ) );
+if( fDataIt != pFuncDataList-end() )
{
-ScaFuncData fData = fDataIt-second;
-aRet = GetDisplFuncStr( fData.GetUINameID() );
-if( fData.IsDouble() )
+aRet = GetDisplFuncStr( fDataIt-GetUINameID() );
+if( fDataIt-IsDouble() )
aRet += STR_FROM_ANSI( _ADD );
}
else
@@ -344,9 +314,10 @@ OUString SAL_CALL ScaDateAddIn::getFunctionDescription(
const OUString aProgram
{
OUString aRet;
-auto fDataIt = pFuncDataMap-find( aProgrammaticName );
-if( fDataIt != pFuncDataMap-end() )
-aRet = GetFuncDescrStr( fDataIt-second.GetDescrID(), 1 );
+auto fDataIt = std::find_if(pFuncDataList-begin(), pFuncDataList-end(),
+FindScaFuncData( aProgrammaticName ) );
+if( fDataIt != pFuncDataList-end() )
+aRet = GetFuncDescrStr( fDataIt-GetDescrID(), 1 );
return aRet;
}
@@ -356,13 +327,13 @@ OUString SAL_CALL ScaDateAddIn::getDisplayArgumentName(
{
OUString aRet;
-auto fDataIt = pFuncDataMap-find( aProgrammaticName );
-if( fDataIt != pFuncDataMap-end() (nArgument = 0x) )
+auto fDataIt = std::find_if(pFuncDataList-begin(),
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accpara.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 05d355ca19487dd3d1a86980f51a56db695e4bcc
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Aug 13 09:06:55 2015 +0200
sw: use std::unique_ptr in accpara
Change-Id: I0fcc22f987208ae9fa0e99f14253856ee6faa062
diff --git a/sw/source/core/access/accpara.cxx
b/sw/source/core/access/accpara.cxx
index 90d9248..f7e1201 100644
--- a/sw/source/core/access/accpara.cxx
+++ b/sw/source/core/access/accpara.cxx
@@ -17,6 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
+#include memory
#include txtfrm.hxx
#include flyfrm.hxx
#include ndtxt.hxx
@@ -83,7 +84,6 @@
#include unoprnms.hxx
#include com/sun/star/text/WritingMode2.hpp
#include viewimp.hxx
-#include boost/scoped_ptr.hpp
#include textmarkuphelper.hxx
#include parachangetrackinginfo.hxx
#include com/sun/star/text/TextMarkupType.hpp
@@ -1741,7 +1741,7 @@ void SwAccessibleParagraph::_getDefaultAttributesImpl(
{
// retrieve default attributes
const SwTextNode* pTextNode( GetTextNode() );
-::boost::scoped_ptrSfxItemSet pSet;
+std::unique_ptrSfxItemSet pSet;
if ( !bOnlyCharAttrs )
{
pSet.reset( new SfxItemSet(
const_castSwAttrPool(pTextNode-GetDoc()-GetAttrPool()),
@@ -2102,7 +2102,7 @@ void
SwAccessibleParagraph::_getSupplementalAttributesImpl(
tAccParaPropValMap rSupplementalAttrSeq )
{
const SwTextNode* pTextNode( GetTextNode() );
-::boost::scoped_ptrSfxItemSet pSet;
+std::unique_ptrSfxItemSet pSet;
pSet.reset( new SfxItemSet(
const_castSwAttrPool(pTextNode-GetDoc()-GetAttrPool()),
RES_PARATR_ADJUST, RES_PARATR_ADJUST,
RES_PARATR_TABSTOP, RES_PARATR_TABSTOP,
@@ -3284,7 +3284,7 @@ sal_Int32 SAL_CALL
SwAccessibleParagraph::getTextMarkupCount( sal_Int32 nTextMar
throw (lang::IllegalArgumentException,
uno::RuntimeException,
std::exception)
{
-boost::scoped_ptrSwTextMarkupHelper pTextMarkupHelper;
+std::unique_ptrSwTextMarkupHelper pTextMarkupHelper;
switch ( nTextMarkupType )
{
case text::TextMarkupType::TRACK_CHANGE_INSERTION:
@@ -3509,7 +3509,7 @@ sal_Int32 SAL_CALL SwAccessibleParagraph::addSelection(
sal_Int32, sal_Int32 sta
lang::IllegalArgumentException,
uno::RuntimeException,
std::exception)
{
-boost::scoped_ptrSwTextMarkupHelper pTextMarkupHelper;
+std::unique_ptrSwTextMarkupHelper pTextMarkupHelper;
switch ( nTextMarkupType )
{
case text::TextMarkupType::TRACK_CHANGE_INSERTION:
@@ -3544,7 +3544,7 @@ uno::Sequence /*accessibility::*/TextSegment SAL_CALL
throw lang::IndexOutOfBoundsException();
}
-boost::scoped_ptrSwTextMarkupHelper pTextMarkupHelper;
+std::unique_ptrSwTextMarkupHelper pTextMarkupHelper;
switch ( nTextMarkupType )
{
case text::TextMarkupType::TRACK_CHANGE_INSERTION:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93404] status indicator progress bar not shown while LoadComponentFromUrl
https://bugs.documentfoundation.org/show_bug.cgi?id=93404 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||fdb...@neosheffield.co.uk Ever confirmed|0 |1 Whiteboard||bibisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90652] Selecting text by double-clicking from content and title makes either element invisible in the Slide pane preview
https://bugs.documentfoundation.org/show_bug.cgi?id=90652 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added CC||fdb...@neosheffield.co.uk Whiteboard|BibisectRequest |preBibisect -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84288] Slow scrolling after a suspend
https://bugs.documentfoundation.org/show_bug.cgi?id=84288 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||ipla...@yahoo.co.uk --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- Surely this is fixed now and shouldn't be in UNCONFIRMED state ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: another life-cycle/timing bug
On 08/13/2015 11:06 AM, Tor Lillqvist wrote: Trying to exit cleanly is so last century. Apps should just _exit(). In a multithreaded app, in general there needs to be communication among the threads about process termination, no matter whether termination is done via exit() or _exit(). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93282] Several Issues Regarding Update
https://bugs.documentfoundation.org/show_bug.cgi?id=93282 --- Comment #11 from Alex Thurgood ipla...@yahoo.co.uk --- @Matthew: are you running any accessibility programs, e.g. VoiceOver, or other tools such as a screen magnifier ? It would be helpful if you could post a copy of the Apple trace that is provided by the OS when an application crashes in this way, at least that might give us a hint as to what's happening. Do you have Java installed ? If so, which version ? You need both Apple Java 1.6 and Oracle Java. Do you have any mounted network shares or intermittently mounted network shares ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/filter/ww8/ww8scan.cxx | 18 +-
sw/source/filter/ww8/ww8scan.hxx |4 ++--
sw/source/ui/app/error.src |4 ++--
3 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit ea70088895ed45dc60abf18319acc1b4fa3018dd
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 13 10:58:06 2015 +0100
convert pStatus to vector and use at to check offsets
Change-Id: I5186f6a65bb9d5ed8a0d1ab1d71f7e2c13865411
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 59b133d..ad1ef67 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3957,7 +3957,7 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm, sal_uInt32
nStart, sal_Int32 nLen
}
WW8PLCFx_Book::WW8PLCFx_Book(SvStream* pTableSt, const WW8Fib rFib)
-: WW8PLCFx(rFib.GetFIBVersion(), false), pStatus(0), nIsEnd(0),
nBookmarkId(1)
+: WW8PLCFx(rFib.GetFIBVersion(), false), nIsEnd(0), nBookmarkId(1)
{
if( !rFib.fcPlcfbkf || !rFib.lcbPlcfbkf || !rFib.fcPlcfbkl ||
!rFib.lcbPlcfbkl || !rFib.fcSttbfbkmk || !rFib.lcbSttbfbkmk )
@@ -3982,14 +3982,12 @@ WW8PLCFx_Book::WW8PLCFx_Book(SvStream* pTableSt, const
WW8Fib rFib)
nIMax = pBook[0]-GetIMax();
if( pBook[1]-GetIMax() nIMax )
nIMax = pBook[1]-GetIMax();
-pStatus = new eBookStatus[ nIMax ];
-memset( pStatus, 0, nIMax * sizeof( eBookStatus ) );
+aStatus.resize(nIMax);
}
}
WW8PLCFx_Book::~WW8PLCFx_Book()
{
-delete[] pStatus;
delete pBook[1];
delete pBook[0];
}
@@ -4109,18 +4107,20 @@ long WW8PLCFx_Book::GetLen() const
return nNum;
}
-void WW8PLCFx_Book::SetStatus(sal_uInt16 nIndex, eBookStatus eStat )
+void WW8PLCFx_Book::SetStatus(sal_uInt16 nIndex, eBookStatus eStat)
{
-OSL_ENSURE(nIndex nIMax, set status of non existing bookmark!);
-pStatus[nIndex] = (eBookStatus)( pStatus[nIndex] | eStat );
+SAL_WARN_IF(nIndex = nIMax, sw.ww8,
+bookmark index nIndex invalid);
+eBookStatus eStatus = aStatus.at(nIndex);
+aStatus[nIndex] = static_casteBookStatus(eStatus | eStat);
}
eBookStatus WW8PLCFx_Book::GetStatus() const
{
-if( !pStatus )
+if (aStatus.empty())
return BOOK_NORMAL;
long nEndIdx = GetHandle();
-return ( nEndIdx nIMax ) ? pStatus[nEndIdx] : BOOK_NORMAL;
+return ( nEndIdx nIMax ) ? aStatus[nEndIdx] : BOOK_NORMAL;
}
long WW8PLCFx_Book::GetHandle() const
diff --git a/sw/source/filter/ww8/ww8scan.hxx b/sw/source/filter/ww8/ww8scan.hxx
index 5c3970c..26a94ac 100644
--- a/sw/source/filter/ww8/ww8scan.hxx
+++ b/sw/source/filter/ww8/ww8scan.hxx
@@ -721,8 +721,8 @@ class WW8PLCFx_Book : public WW8PLCFx
{
private:
WW8PLCFspecial* pBook[2]; // Start and End Position
-::std::vectorOUString aBookNames; // Name
-eBookStatus* pStatus;
+std::vectorOUString aBookNames; // Name
+std::vectoreBookStatus aStatus;
long nIMax; // Number of Booknotes
sal_uInt16 nIsEnd;
sal_Int32 nBookmarkId; // counter incremented by GetUniqueBookmarkName.
commit 77a38b460eab172e2d19388d2ef3f5eefb981d74
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 13 10:56:48 2015 +0100
modify error messages a little
Change-Id: I5c2c5a567ffb16d3e072cba2930dffe762a744f3
diff --git a/sw/source/ui/app/error.src b/sw/source/ui/app/error.src
index 7768772..cc5266d 100644
--- a/sw/source/ui/app/error.src
+++ b/sw/source/ui/app/error.src
@@ -70,7 +70,7 @@ Resource RID_SW_ERRHDL
};
String ERR_CODE ( ERRCODE_CLASS_READ , ERR_WW6_NO_WW6_FILE_ERR )
{
-Text [ en-US ] = This is not a WinWord6 file. ;
+Text [ en-US ] = This is not a valid WinWord6 file. ;
};
String ERR_CODE ( ERRCODE_CLASS_READ , ERR_WW6_FASTSAVE_ERR )
{
@@ -86,7 +86,7 @@ Resource RID_SW_ERRHDL
};
String ERR_CODE ( ERRCODE_CLASS_READ , ERR_WW8_NO_WW8_FILE_ERR )
{
-Text [ en-US ] = This is not a WinWord97 file.;
+Text [ en-US ] = This is not a valid WinWord97 file.;
};
String ERR_CODE ( ERRCODE_CLASS_READ , ERR_FORMAT_FILE_ROWCOL )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - editeng/source sw/source
editeng/source/editeng/impedit4.cxx |3 +--
sw/source/core/view/viewsh.cxx |4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
New commits:
commit bc4904aba89bcbe267ca705ff76fc9d8629f73a3
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Aug 12 14:16:11 2015 +0200
tdf#93384 editeng rendercontext: don't paint spellcheck result directly
E.g. in Writer create a new comment, type a word that is not in the
dictionary, then a space to trigger the spelling, and that painted the
spelling error indicator outside Paint().
(cherry picked from commits 71aed9185fb17ee27bdc38b4ac650713c4cabb8b and
89bd30cf426ca54fc9e46295a60551b5bb2d3232)
Change-Id: I8f72486189e04a5596729fb52b6af39772f8e002
Reviewed-on: https://gerrit.libreoffice.org/17690
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/editeng/source/editeng/impedit4.cxx
b/editeng/source/editeng/impedit4.cxx
index 8cd007a..0c26682 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -2414,8 +2414,7 @@ void ImpEditEngine::DoOnlineSpelling( ContentNode*
pThisNodeOnly, bool bSpellAtC
{
// convert to window coordinates
aClipRect.SetPos(
pView-pImpEditView-GetWindowPos( aClipRect.TopLeft() ) );
-// If selected, then VDev ...
-Paint( pView-pImpEditView, aClipRect, 0,
pView-HasSelection() );
+
pView-pImpEditView-GetWindow()-Invalidate(aClipRect);
}
}
}
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index b934e76..9cb6941 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -1677,8 +1677,8 @@ public:
rtl::Referencesdr::overlay::OverlayManager xOldManager =
pOldPaintWindow-GetOverlayManager();
if (xOldManager.is())
{
-SdrPaintWindow* pNewPaintWindow =
m_pShell-Imp()-GetDrawView()-FindPaintWindow(*m_pRef);
-
xOldManager-completeRedraw(pNewPaintWindow-GetRedrawRegion(), m_pRef);
+if (SdrPaintWindow* pNewPaintWindow =
m_pShell-Imp()-GetDrawView()-FindPaintWindow(*m_pRef))
+
xOldManager-completeRedraw(pNewPaintWindow-GetRedrawRegion(), m_pRef);
}
m_pShell-Imp()-GetDrawView()-DeleteWindowFromPaintView(m_pRef);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/data/bcaslot.cxx | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
New commits:
commit 61fb1d4de37f88f6408a483c3713a373340d6fb3
Author: Eike Rathke er...@redhat.com
Date: Wed Aug 12 20:15:08 2015 +0200
Resolves: tdf#93388 broadcasting to removed listeners isn't a good idea
This cures only a symptom, the underlying cause is that the broadcasters
still are listed in maBulkGroupAreas.
Change-Id: I9625483016a51eb6f6a7e3d58ed42c7dad3a57b3
(cherry picked from commit 2d4edd7de2e67db5bd17e7a89e2496611ebcc165)
Reviewed-on: https://gerrit.libreoffice.org/17684
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx
index 2174216..f9d6a19 100644
--- a/sc/source/core/data/bcaslot.cxx
+++ b/sc/source/core/data/bcaslot.cxx
@@ -1155,12 +1155,22 @@ void
ScBroadcastAreaSlotMachine::BulkBroadcastGroupAreas()
for (; it != itEnd; ++it)
{
ScBroadcastArea* pArea = it-first;
-const sc::ColumnSpanSet* pSpans = it-second;
assert(pArea);
-assert(pSpans);
-aHint.setSpans(pSpans);
-pArea-GetBroadcaster().Broadcast(aHint);
-bBroadcasted = true;
+SvtBroadcaster rBC = pArea-GetBroadcaster();
+if (!rBC.HasListeners())
+{
+/* FIXME: find the cause where the last listener is removed and
+ * this area is still listed here. */
+
SAL_WARN(sc.core,ScBroadcastAreaSlotMachine::BulkBroadcastGroupAreas - pArea
has no listeners and should had been removed already);
+}
+else
+{
+const sc::ColumnSpanSet* pSpans = it-second;
+assert(pSpans);
+aHint.setSpans(pSpans);
+rBC.Broadcast(aHint);
+bBroadcasted = true;
+}
}
maBulkGroupAreas.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93348] Base crashes when entering login information for jdbc connection to MariaDB database (Windows 64bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=93348 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||lio...@mamane.lu, ||rob...@familiegrosskopf.de, ||serval2...@yahoo.fr --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- We need someone running Windows 64bit with LO 64bit to confirm. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93396] LibreOffice 5.0 Crashes on Windows 8 64-bit when making JDBC connection (Windows 64bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=93396 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Keywords||want-backtrace --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- A bt could be very useful to locate the root cause in the code. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80866] Layout of custom handouts is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=80866 --- Comment #29 from Regina Henschel rb.hensc...@t-online.de --- I have tested it in Version: 5.1.0.0.alpha1+ Build-ID: c614e711136205252ac2c72f9772c718dafc471e TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-08-12_20:36:06 Gebietsschema: de-DE (de_DE) It is OK in that version. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93407] New: Draw crashes when changing line width using sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=93407 Bug ID: 93407 Summary: Draw crashes when changing line width using sidebar Product: LibreOffice Version: 5.0.0.5 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: achat1...@free.fr Hello, If I use the properties side bar to change line width (of any type of line, i.e. box contours, connectors, etc.), Draw either, freeze then crash or crash directly after I validate my choice of width. If I right click on a line to edit its properties and change width from there, Draw behaves normally. LO 5.0.0.5 Kubuntu 15.04 x86_64 Plasma 5.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 --- Comment #28 from Timur gti...@gmail.com --- Sorry, Linux version from http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF/current/, -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92993] FILEOPEN: access violation on particular .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=92993 --- Comment #9 from Kirill kirill.pes...@gmail.com --- 5.0.1.1 ID 13f702ca819ea5b9f8605782c852d5bb513b3891 ru_RU Win8.1 Crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80866] Layout of custom handouts is ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=80866 --- Comment #27 from Jan Holesovsky ke...@collabora.com --- [and of course, 4.3.7 is past its end-of-life, there will be no further 4.3.x] -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/source sw/source
sd/source/ui/table/TableDesignPane.cxx |2 +-
sw/source/filter/ww8/wrtww8gr.cxx | 16 ++--
sw/source/filter/ww8/ww8atr.cxx|8 ++--
3 files changed, 17 insertions(+), 9 deletions(-)
New commits:
commit 8f1d6909f519526312d9c9384b715a4db730eafc
Author: Noel Grandin n...@peralex.com
Date: Tue Aug 11 15:02:05 2015 +0200
tdf#92885 - Incorrect cell border drawing in DOC file after saving in 5.0
caused by commit 4b66829390b286010b37b37ec1537a320d8cea8f
convert BOX_LINE and BOXINFO_LINE to enum class
(cherry picked from commit 78446df26f45e2a71187873726388c9d2f6ba6e5)
Conflicts:
sw/source/filter/ww8/wrtww8gr.cxx
Change-Id: I23eb359a40035dd40bdb60703de567b1c328e793
Reviewed-on: https://gerrit.libreoffice.org/17691
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sd/source/ui/table/TableDesignPane.cxx
b/sd/source/ui/table/TableDesignPane.cxx
index aac2f0f..206a08b 100644
--- a/sd/source/ui/table/TableDesignPane.cxx
+++ b/sd/source/ui/table/TableDesignPane.cxx
@@ -710,7 +710,7 @@ const Bitmap CreateDesignPreview( const Reference
XIndexAccess xTableStyle,
boost::shared_ptr CellInfo xBorderInfo(
aMatrix[nBorderCol][nBorderRow] );
if( xBorderInfo.get() )
{
-const ::editeng::SvxBorderLine* pBorderLine2 =
xBorderInfo-maBorder.GetLine(static_castSvxBoxItemLine(static_castint(nLine)^1^1));
+const ::editeng::SvxBorderLine* pBorderLine2 =
xBorderInfo-maBorder.GetLine(static_castSvxBoxItemLine(static_castint(nLine)^1));
if( pBorderLine2
pBorderLine2-HasPriority(*pBorderLine) )
continue; // other border line wins
}
diff --git a/sw/source/filter/ww8/wrtww8gr.cxx
b/sw/source/filter/ww8/wrtww8gr.cxx
index dcd3277..f7b31e6 100644
--- a/sw/source/filter/ww8/wrtww8gr.cxx
+++ b/sw/source/filter/ww8/wrtww8gr.cxx
@@ -570,14 +570,16 @@ void SwWW8WrGrf::WritePICFHeader(SvStream rStrm, const
sw::Frame rFly,
(pSI-GetWidth() != 0);
}
-for( SvxBoxItemLine i : o3tl::enumrangeSvxBoxItemLine() )
+static const SvxBoxItemLine aLnArr[4] = { SvxBoxItemLine::TOP,
SvxBoxItemLine::LEFT,
+SvxBoxItemLine::BOTTOM, SvxBoxItemLine::RIGHT
};
+for( sal_uInt8 i = 0; i 4; ++i )
{
-const ::editeng::SvxBorderLine* pLn = pBox-GetLine( i );
+const ::editeng::SvxBorderLine* pLn = pBox-GetLine( aLnArr[i]
);
WW8_BRC aBrc;
if (pLn)
{
WW8_BRCVer9 aBrc90 = rWrt.TranslateBorderLine( *pLn,
-pBox-GetDistance( i ), bShadow );
+pBox-GetDistance( aLnArr[i] ), bShadow );
sal_uInt8 ico =
msfilter::util::TransColToIco(msfilter::util::BGRToRGB(
aBrc90.cv()));
aBrc = WW8_BRC(aBrc90.dptLineWidth(), aBrc90.brcType(),
ico,
@@ -588,7 +590,7 @@ void SwWW8WrGrf::WritePICFHeader(SvStream rStrm, const
sw::Frame rFly,
// border will really be in word and adjust accordingly
short nSpacing;
short nThick = aBrc.DetermineBorderProperties(nSpacing);
-switch (i)
+switch (aLnArr[i])
{
case SvxBoxItemLine::TOP:
case SvxBoxItemLine::BOTTOM:
@@ -758,13 +760,15 @@ void SwWW8WrGrf::WritePICBulletFHeader(SvStream rStrm,
const Graphic rGrf,
sal_uInt8* pArr = aArr + 0x2E; //Do borders first
-for( SvxBoxItemLine i : o3tl::enumrangeSvxBoxItemLine() )
+static const SvxBoxItemLine aLnArr[4] = { SvxBoxItemLine::TOP,
SvxBoxItemLine::LEFT,
+SvxBoxItemLine::BOTTOM, SvxBoxItemLine::RIGHT };
+for( sal_uInt8 i = 0; i 4; ++i )
{
WW8_BRC aBrc;
short nSpacing;
short nThick = aBrc.DetermineBorderProperties(nSpacing);
-switch (i)
+switch (aLnArr[i])
{
case SvxBoxItemLine::TOP:
case SvxBoxItemLine::BOTTOM:
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index c5354b7..3ac52bb 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -4466,13 +4466,17 @@ void WW8Export::Out_SwFormatBox(const SvxBoxItem rBox,
bool bShadow)
void WW8Export::Out_SwFormatTableBox( ww::bytes rO, const SvxBoxItem * pBox )
{
// moeglich und vielleicht besser waere 0x
+static const SvxBoxItemLine aBorders[] =
+{
+SvxBoxItemLine::TOP, SvxBoxItemLine::LEFT, SvxBoxItemLine::BOTTOM,
SvxBoxItemLine::RIGHT
+
[Libreoffice-bugs] [Bug 78111] UI: Freakout-behaviour and freeze during resize of docked sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=78111 --- Comment #39 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Maxim Monastirsky committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2f218f54369c6d7fb38d0b701aa86fdf5aae843 tdf#78111 Sane preferred width for the color mode combobox It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74861] [Spreadsheet] Exporting A4-sized ODS to PDF with '--headless' creates Letter-sized PDF (where manual export via GUI creates A4) (OSX 10.9.5)
https://bugs.documentfoundation.org/show_bug.cgi?id=74861 --- Comment #10 from Alex Thurgood ipla...@yahoo.co.uk --- Problem seems limited to OSX 10.9.5. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/sidebar/graphic/GraphicPropertyPanel.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit d2f218f54369c6d7fb38d0b701aa86fdf5aae843 Author: Maxim Monastirsky momonas...@gmail.com Date: Thu Aug 13 12:55:04 2015 +0300 tdf#78111 Sane preferred width for the color mode combobox Don't let long strings (in some languages) make it request so much space. Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05 diff --git a/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx b/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx index 37b6b69..2ec906d 100644 --- a/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx +++ b/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx @@ -58,6 +58,7 @@ GraphicPropertyPanel::GraphicPropertyPanel( get(mpMtrBrightness, setbrightness); get(mpMtrContrast, setcontrast); get(mpLBColorMode, setcolormode); + mpLBColorMode-set_width_request(mpLBColorMode-get_preferred_size().Width()); get(mpMtrTrans, settransparency); get(mpMtrRed, setred); get(mpMtrGreen, setgreen); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93390] View of cell data gone in Table Data View
https://bugs.documentfoundation.org/show_bug.cgi?id=93390 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- This is similar, if not identical, to bug 92275 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 --- Comment #24 from Yury yury.tarasiev...@gmail.com --- That RESOLVED status might be in error. I've taken this one from daily builds: libreoffice-5-0~2015-08-12_15.44.50_LibreOfficeDev_5.0.2.0.0_Linux_x86-64_rpm.tar.gz and tested it with bigfile_obf.odt from attachments. On save, file seems to be formed, but with problems -- zip structure okay, open in 4.3 series shows info on 'corrupt file' (snapshot #1 forthcoming), repair finishes okay. Also, although LO doesn't bail out, I'm getting an I/O error in popup window after every (half-successful) save (snapshot #2 forthcoming). Filename in dialog is truncated on the 2nd underscore char -- see snapshot #2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91542] FORMATTING: Line box width cannot be changed and custom width causes DRAW to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=91542 --- Comment #11 from Gauthier achat1...@free.fr --- Very sorry, will do. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-4' - 12 commits - loleaflet/README loleaflet/src
loleaflet/README| 29 +
loleaflet/src/control/Control.Permission.js |1
loleaflet/src/control/Control.Search.js |8 ++--
loleaflet/src/control/Control.Selection.js |1
loleaflet/src/control/Control.js| 17 ++
loleaflet/src/control/Parts.js | 47
loleaflet/src/control/Scroll.js | 29 +++--
loleaflet/src/layer/tile/GridLayer.js | 24 --
loleaflet/src/layer/tile/TileLayer.js |5 +-
loleaflet/src/map/Map.js|9 +
loleaflet/src/map/handler/Map.Keyboard.js |5 ++
loleaflet/src/map/handler/Map.Mouse.js | 13 +--
12 files changed, 153 insertions(+), 35 deletions(-)
New commits:
commit 805aab8c9e2e9e5f27b38042c5683a106b7e3f3c
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Aug 13 13:18:56 2015 +0300
loleaflet: changed method name to getCurrent*Number
diff --git a/loleaflet/README b/loleaflet/README
index a25578b..0ce0f70 100644
--- a/loleaflet/README
+++ b/loleaflet/README
@@ -94,7 +94,7 @@ Parts (like slides in presentation, or sheets in
spreadsheets):
+ maxWidth / maxHeight are the desired dimensions of the preview,
a smaller
image might be returned in order to keep the original ratio of
the document
map.getNumberOfParts()
-map.getCurrentPart()
+map.getCurrentPartNumber()
- events:
map.on('updateparts', function (e) {}) where:
+ e.currentPart is the current part
@@ -159,7 +159,7 @@ Writer pages:
- API:
map.goToPage(page)
map.getNumberOfPages()
-map.getCurrentPart()
+map.getCurrentPageNumber()
map.getDocPreview(id, maxWidth, maxHeight, x, y, width, height)
+ id = the ID of the request so that the response can be identified
+ maxWidth / maxHeight are the desired dimensions of the preview,
a smaller
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 3d603bf..f465f2c 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -96,11 +96,11 @@ L.Map.include({
return this._docLayer._parts;
},
- getCurrentPage: function () {
+ getCurrentPageNumber: function () {
return this._docLayer._currentPage;
},
- getCurrentPart: function () {
+ getCurrentPartNumber: function () {
return this._docLayer._currentPart;
},
commit 464f47f6430c49deb123f709144afe7f7ccda964
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Aug 13 12:58:59 2015 +0300
loleaflet: method to get a preview of the document
diff --git a/loleaflet/README b/loleaflet/README
index e73726c..a25578b 100644
--- a/loleaflet/README
+++ b/loleaflet/README
@@ -160,6 +160,12 @@ Writer pages:
map.goToPage(page)
map.getNumberOfPages()
map.getCurrentPart()
+map.getDocPreview(id, maxWidth, maxHeight, x, y, width, height)
++ id = the ID of the request so that the response can be identified
++ maxWidth / maxHeight are the desired dimensions of the preview,
a smaller
+ image might be returned in order to keep the original ratio of
the document
++ x/y = starting position, where to get the preview from
+
- events
map.on('pagenumberchanged', function (e) {}) where:
+ e.currentPage = the page on which the cursor lies
diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 7264789..3d603bf 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -52,6 +52,33 @@ L.Map.include({
'id=' + id);
},
+ getDocPreview: function (id, maxWidth, maxHeight, x, y, width, height) {
+ var docLayer = this._docLayer;
+ var docRatio = width / height;
+ var imgRatio = maxWidth / maxHeight;
+ // fit into the given rectangle while maintaining the ratio
+ if (imgRatio docRatio) {
+ maxWidth = Math.round(width * maxHeight / height);
+ }
+ else {
+ maxHeight = Math.round(height * maxWidth / width);
+ }
+ x = Math.round(x / docLayer._tileSize *
docLayer._tileWidthTwips);
+ width = Math.round(width / docLayer._tileSize *
docLayer._tileWidthTwips);
+ y = Math.round(y / docLayer._tileSize *
docLayer._tileHeightTwips);
+ height = Math.round(height / docLayer._tileSize *
docLayer._tileHeightTwips);
+
+ docLayer.sendMessage('tile ' +
+ 'part=0 ' +
+ 'width=' + maxWidth + '
' +
+
[Libreoffice-bugs] [Bug 64827] FILESAVE: Changing file extension (filter) also changes file name
https://bugs.documentfoundation.org/show_bug.cgi?id=64827 --- Comment #21 from Gauthier achat1...@free.fr --- Still the same problem with LO 5.0.0.5. Haven't yet had opportunity to try on a non-KDE platform. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - framework/source
framework/source/helper/statusindicatorfactory.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit f87e86d0d04537df28a127fdabb14b68c52f626c
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Aug 13 12:04:55 2015 +0200
tdf#93404: Forgot to launch WakeUpThread
...in 017f250764ec7b4ecb82ac19f5b3f68cadf1bf56 Ensure WakeUpThread is
joined
before exit
Change-Id: Iaa5a5772f099b11229bd40c3cc10d863ef0ad5b3
(cherry picked from commit 54f10a9654b617c4c993044e52e7bd40d0151c53)
Reviewed-on: https://gerrit.libreoffice.org/17697
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/framework/source/helper/statusindicatorfactory.cxx
b/framework/source/helper/statusindicatorfactory.cxx
index 3b4001a..a0a4fde 100644
--- a/framework/source/helper/statusindicatorfactory.cxx
+++ b/framework/source/helper/statusindicatorfactory.cxx
@@ -544,6 +544,7 @@ void StatusIndicatorFactory::impl_startWakeUpThread()
if (!m_pWakeUp.is())
{
m_pWakeUp = new WakeUpThread(this);
+m_pWakeUp-launch();
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - svx/source
svx/source/sidebar/graphic/GraphicPropertyPanel.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 4c537dd82b24926bf7b4ed75763af5befcce6702 Author: Maxim Monastirsky momonas...@gmail.com Date: Thu Aug 13 12:55:04 2015 +0300 tdf#78111 Sane preferred width for the color mode combobox Don't let long strings (in some languages) make it request so much space. Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05 (cherry picked from commit d2f218f54369c6d7fb38d0b701aa86fdf5aae843) Reviewed-on: https://gerrit.libreoffice.org/17699 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx b/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx index 53806ea..1744613 100644 --- a/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx +++ b/svx/source/sidebar/graphic/GraphicPropertyPanel.cxx @@ -58,6 +58,7 @@ GraphicPropertyPanel::GraphicPropertyPanel( get(mpMtrBrightness, setbrightness); get(mpMtrContrast, setcontrast); get(mpLBColorMode, setcolormode); + mpLBColorMode-set_width_request(mpLBColorMode-get_preferred_size().Width()); get(mpMtrTrans, settransparency); get(mpMtrRed, setred); get(mpMtrGreen, setgreen); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source
sw/source/filter/ww8/ww8scan.cxx | 18 +-
sw/source/filter/ww8/ww8scan.hxx |4 ++--
2 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit c23e12ebbf49a1e290440b3a044c2ac54d569aa9
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 13 10:58:06 2015 +0100
convert pStatus to vector and use at to check offsets
Change-Id: I5186f6a65bb9d5ed8a0d1ab1d71f7e2c13865411
(cherry picked from commit ea70088895ed45dc60abf18319acc1b4fa3018dd)
Reviewed-on: https://gerrit.libreoffice.org/17693
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 165b9df..e9243ba 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3991,7 +3991,7 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm, sal_uInt32
nStart, sal_Int32 nLen
}
WW8PLCFx_Book::WW8PLCFx_Book(SvStream* pTableSt, const WW8Fib rFib)
-: WW8PLCFx(rFib.GetFIBVersion(), false), pStatus(0), nIsEnd(0),
nBookmarkId(1)
+: WW8PLCFx(rFib.GetFIBVersion(), false), nIsEnd(0), nBookmarkId(1)
{
if( !rFib.fcPlcfbkf || !rFib.lcbPlcfbkf || !rFib.fcPlcfbkl ||
!rFib.lcbPlcfbkl || !rFib.fcSttbfbkmk || !rFib.lcbSttbfbkmk )
@@ -4016,14 +4016,12 @@ WW8PLCFx_Book::WW8PLCFx_Book(SvStream* pTableSt, const
WW8Fib rFib)
nIMax = pBook[0]-GetIMax();
if( pBook[1]-GetIMax() nIMax )
nIMax = pBook[1]-GetIMax();
-pStatus = new eBookStatus[ nIMax ];
-memset( pStatus, 0, nIMax * sizeof( eBookStatus ) );
+aStatus.resize(nIMax);
}
}
WW8PLCFx_Book::~WW8PLCFx_Book()
{
-delete[] pStatus;
delete pBook[1];
delete pBook[0];
}
@@ -4141,18 +4139,20 @@ long WW8PLCFx_Book::GetLen() const
return nNum;
}
-void WW8PLCFx_Book::SetStatus(sal_uInt16 nIndex, eBookStatus eStat )
+void WW8PLCFx_Book::SetStatus(sal_uInt16 nIndex, eBookStatus eStat)
{
-OSL_ENSURE(nIndex nIMax, set status of non existing bookmark!);
-pStatus[nIndex] = (eBookStatus)( pStatus[nIndex] | eStat );
+SAL_WARN_IF(nIndex = nIMax, sw.ww8,
+bookmark index nIndex invalid);
+eBookStatus eStatus = aStatus.at(nIndex);
+aStatus[nIndex] = static_casteBookStatus(eStatus | eStat);
}
eBookStatus WW8PLCFx_Book::GetStatus() const
{
-if( !pStatus )
+if (aStatus.empty())
return BOOK_NORMAL;
long nEndIdx = GetHandle();
-return ( nEndIdx nIMax ) ? pStatus[nEndIdx] : BOOK_NORMAL;
+return ( nEndIdx nIMax ) ? aStatus[nEndIdx] : BOOK_NORMAL;
}
long WW8PLCFx_Book::GetHandle() const
diff --git a/sw/source/filter/ww8/ww8scan.hxx b/sw/source/filter/ww8/ww8scan.hxx
index 678482f..57ccae3 100644
--- a/sw/source/filter/ww8/ww8scan.hxx
+++ b/sw/source/filter/ww8/ww8scan.hxx
@@ -724,8 +724,8 @@ class WW8PLCFx_Book : public WW8PLCFx
{
private:
WW8PLCFspecial* pBook[2]; // Start and End Position
-::std::vectorOUString aBookNames; // Name
-eBookStatus* pStatus;
+std::vectorOUString aBookNames; // Name
+std::vectoreBookStatus aStatus;
long nIMax; // Number of Booknotes
sal_uInt16 nIsEnd;
sal_Int32 nBookmarkId; // counter incremented by GetUniqueBookmarkName.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89153] Math formula with root not displayed correctly in Calc or Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89153 --- Comment #12 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to Josan from comment #8) When writing fractions, only the line between numbers appears in presentation mode. example: 3 over 4 When editing: 3 --- 4 When presenting: --- This worked fine in previous version. @Josan : please open a separate bug report for this behaviour, thank you, this issue was about the display of the root symbol, which has apparently been corrected some time during 5.x developement. As the commit that fixed this is unknown, the current bug report is set to resolved worksforme. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93404] status indicator progress bar not shown while LoadComponentFromUrl
https://bugs.documentfoundation.org/show_bug.cgi?id=93404 --- Comment #1 from Laurent Godard lgodard.li...@laposte.net --- Created attachment 117880 -- https://bugs.documentfoundation.org/attachment.cgi?id=117880action=edit big file just double clicking this file to open it reproduces the problem no need of any macro -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/main/VDataSeries.cxx |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
New commits:
commit b3abc191e24bd2e812836257024d14557a6238ce
Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net
Date: Wed Jun 17 15:15:07 2015 +0200
tdf#76649 Skip NaN initial values for min and max
min and max were initiated as aValuesX[0] which could be NaN
Change-Id: I229f4c8f8fda54684e1c817ea7da06fd87eb79b9
Reviewed-on: https://gerrit.libreoffice.org/17343
Reviewed-by: Jan Holesovsky ke...@collabora.com
Tested-by: Jan Holesovsky ke...@collabora.com
diff --git a/chart2/source/view/main/VDataSeries.cxx
b/chart2/source/view/main/VDataSeries.cxx
index 3efa477..6667cbb 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -520,9 +520,13 @@ void VDataSeries::getMinMaxXValue(double fMin, double
fMax) const
if(aValuesX.getLength() 0)
{
-fMax = fMin = aValuesX[0];
+sal_Int32 i = 0;
+while ( ::rtl::math::isNan( aValuesX[i] ) i aValuesX.getLength() )
+i++;
+if ( i aValuesX.getLength() )
+fMax = fMin = aValuesX[i++];
-for (sal_Int32 i = 1; i aValuesX.getLength(); i++)
+for ( ; i aValuesX.getLength(); i++)
{
const double aValue = aValuesX[i];
if ( aValue fMax)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa
chart2/qa/extras/xshape/chart2xshape.cxx | 39 +++--
chart2/qa/extras/xshape/data/ods/tdf76649_TrendLineBug.ods |binary
2 files changed, 35 insertions(+), 4 deletions(-)
New commits:
commit 2b129825f90bf7aee51e57fd11a5b81fbd5f16d1
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Sat Jul 25 12:16:22 2015 +0900
tdf#76649 test case for this issue
Change-Id: I8b88298c79e04e972b208dd74dcd693d53d0bb98
Reviewed-on: https://gerrit.libreoffice.org/17344
Reviewed-by: Jan Holesovsky ke...@collabora.com
Tested-by: Jan Holesovsky ke...@collabora.com
diff --git a/chart2/qa/extras/xshape/chart2xshape.cxx
b/chart2/qa/extras/xshape/chart2xshape.cxx
index f48cdc9..f57fdfc 100644
--- a/chart2/qa/extras/xshape/chart2xshape.cxx
+++ b/chart2/qa/extras/xshape/chart2xshape.cxx
@@ -20,27 +20,31 @@
#include com/sun/star/qa/XDumper.hpp
#include test/xmldiff.hxx
+#include test/xmltesttools.hxx
#include fstream
-class Chart2XShapeTest : public ChartTest
+class Chart2XShapeTest : public ChartTest, public XmlTestTools
{
public:
void testFdo75075();
void testPropertyMappingBarChart();
void testPieChartLabels1();
+void testTdf76649TrendLineBug();
CPPUNIT_TEST_SUITE(Chart2XShapeTest);
CPPUNIT_TEST(testFdo75075);
CPPUNIT_TEST(testPropertyMappingBarChart);
CPPUNIT_TEST(testPieChartLabels1);
+CPPUNIT_TEST(testTdf76649TrendLineBug);
CPPUNIT_TEST_SUITE_END();
private:
void compareAgainstReference(const OUString rReferenceFile, bool
bCreateReference = false);
-
+OUString getXShapeDumpString();
+xmlDocPtr getXShapeDumpXmlDoc();
};
namespace {
@@ -58,11 +62,24 @@ bool checkDumpAgainstFile( const OUString rDump, const
OUString aFilePath)
}
-void Chart2XShapeTest::compareAgainstReference(const OUString rReferenceFile,
bool bCreateReference)
+OUString Chart2XShapeTest::getXShapeDumpString()
{
uno::Reference chart::XChartDocument xChartDoc ( getChartCompFromSheet(
0, mxComponent ), UNO_QUERY_THROW);
uno::Reference qa::XDumper xDumper( xChartDoc, UNO_QUERY_THROW );
-OUString aDump = xDumper-dump();
+return xDumper-dump();
+}
+
+xmlDocPtr Chart2XShapeTest::getXShapeDumpXmlDoc()
+{
+OUString rDump = getXShapeDumpString();
+OString aXmlDump = OUStringToOString(rDump, RTL_TEXTENCODING_UTF8);
+return xmlParseDoc(reinterpret_castconst xmlChar*(aXmlDump.getStr()));
+}
+
+void Chart2XShapeTest::compareAgainstReference(const OUString rReferenceFile,
bool bCreateReference)
+{
+OUString aDump = getXShapeDumpString();
+
OUString aReference =
getPathFromSrc(/chart2/qa/extras/xshape/data/reference/) + rReferenceFile;
if(bCreateReference)
{
@@ -96,6 +113,20 @@ void Chart2XShapeTest::testPieChartLabels1()
compareAgainstReference(tdf90839-1.xml);
}
+void Chart2XShapeTest::testTdf76649TrendLineBug()
+{
+// This bug prevents that the trendline (regression curve) is drawn
+// if the first cell is empty. See tdf#76649 for details.
+
+load(chart2/qa/extras/xshape/data/ods/, tdf76649_TrendLineBug.ods);
+
+xmlDocPtr pXmlDoc = getXShapeDumpXmlDoc();
+
+// Check if the regression curve exists (which means a XShape with a
certain
+// name should exist in the dump)
+assertXPath(pXmlDoc,
//XShape[@name='CID/D=0:CS=0:CT=0:Series=0:Curve=0'], 1);
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Chart2XShapeTest);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/chart2/qa/extras/xshape/data/ods/tdf76649_TrendLineBug.ods
b/chart2/qa/extras/xshape/data/ods/tdf76649_TrendLineBug.ods
new file mode 100644
index 000..1032e96
Binary files /dev/null and
b/chart2/qa/extras/xshape/data/ods/tdf76649_TrendLineBug.ods differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 74861] [Spreadsheet] Exporting A4-sized ODS to PDF with '--headless' creates Letter-sized PDF (where manual export via GUI creates A4)
https://bugs.documentfoundation.org/show_bug.cgi?id=74861 --- Comment #9 from Alex Thurgood ipla...@yahoo.co.uk --- No repro on OSX 10.10.4 with LO 5.0.0.5 after launching script from Terminal. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78111] UI: Freakout-behaviour and freeze during resize of docked sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=78111 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | --- Comment #40 from Maxim Monastirsky momonas...@gmail.com --- With these commits in place (the last one is also pending for 5-0), I think we can close this bug. For any additional problems in this area, please open new bugs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93396] LibreOffice 5.0 Crashes on Windows 8 64-bit when making JDBC connection (Windows 64bit)
https://bugs.documentfoundation.org/show_bug.cgi?id=93396 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- We need someone else running Windows 64bit with LO 64bit to confirm. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88314] saving big file crashes writer (and LibreOffice)
https://bugs.documentfoundation.org/show_bug.cgi?id=88314 --- Comment #26 from Yury yury.tarasiev...@gmail.com --- Created attachment 117884 -- https://bugs.documentfoundation.org/attachment.cgi?id=117884action=edit part of screen with 'corrupt file' dialog in 4.3 local build -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93390] View of cell data gone in Table Data View
https://bugs.documentfoundation.org/show_bug.cgi?id=93390 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- @Stang: it might be worth trying a recent daily/nightly build to see if the fix for bug 92275 has also fixed this behaviour/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93390] View of cell data gone in Table Data View
https://bugs.documentfoundation.org/show_bug.cgi?id=93390 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
