[Libreoffice-bugs] [Bug 94461] New: Predefined Templates and Template Folders are not Deletable in Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=94461 Bug ID: 94461 Summary: Predefined Templates and Template Folders are not Deletable in Template Manager Product: LibreOffice Version: unspecified Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.koes...@mail.de Many users, I think most of them, do not use the predefined templates. This is particularly the case, if users are not English, hence the predefined templates are only offered in English. And even a user uses these templates, he or she will not use all templates. Hence nearly in all cases the offered predefined template structure (4 times (Tab Documents, Spreadsheets,..) 8 folders with together 22 templates) is confusing and not necessary. Hence a user should be able to delete predefined templates and folders in the Template Manager: Deleting Files: [1] Start LibreOffice and open Template Manager: File > New > Templates [2] Select tab Documents and double-click “Business Correspondence”. [3] Select template "Moderate" business letter. [4] Click “Delete”. You are asked if you want to delete the selected template. [5] Click “Yes”. You are informed that the template cannot be deleted. Expected: Deletion of template. Deleting Folders: [1] Start LibreOffice and open Template Manager: File > New > Templates [2] Select tab Documents and then select folder Presentations. (By the way: I wonder why at all a folder Presentations is displayed in the tab Documents.) [3] Click “Delete”. You are asked if you want to delete the selected folder. [4] Click “Yes”. You are informed that the folder cannot be deleted. Expected: Deletion of folder. Proposal in order to fix this bug: If a user profile does not exist and LibreOffice is started the first time, the predefined templates should be copied into the new user profile. Hence the user has the right to delete files and folders in his profile, it should be possible to delete predefined templates and folders. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/inc sd/source sd/workben
sd/inc/CustomAnimationEffect.hxx | 13 - sd/inc/CustomAnimationPreset.hxx |6 sd/inc/Outliner.hxx |6 sd/inc/OutlinerIterator.hxx |8 sd/inc/TransitionPreset.hxx |4 sd/inc/pch/precompiled_sd.hxx |5 sd/inc/pch/precompiled_sdui.hxx |1 sd/inc/sdpage.hxx | 14 - sd/inc/stlsheet.hxx |1 sd/inc/undoanim.hxx |1 sd/source/core/EffectMigration.cxx |4 sd/source/core/stlsheet.cxx |4 sd/source/core/undoanim.cxx |4 sd/source/filter/eppt/epptooxml.hxx |2 sd/source/filter/eppt/pptexanimations.hxx |4 sd/source/filter/eppt/text.hxx |4 sd/source/filter/html/HtmlOptionsDialog.cxx |1 sd/source/filter/html/buttonset.cxx |6 sd/source/filter/html/htmlex.hxx |3 sd/source/filter/ppt/pptin.hxx |4 sd/source/filter/ppt/pptinanimations.cxx |4 sd/source/ui/animations/CustomAnimationDialog.cxx |2 sd/source/ui/animations/CustomAnimationList.hxx |2 sd/source/ui/animations/CustomAnimationPane.cxx |8 sd/source/ui/animations/SlideTransitionPane.cxx |2 sd/source/ui/annotations/annotationmanager.cxx |4 sd/source/ui/annotations/annotationwindow.cxx |2 sd/source/ui/app/sdmod1.cxx |7 sd/source/ui/app/sdxfer.cxx |6 sd/source/ui/dlg/RemoteDialogClientBox.cxx | 10 - sd/source/ui/dlg/RemoteDialogClientBox.hxx | 10 - sd/source/ui/dlg/sdpreslt.cxx |2 sd/source/ui/dlg/sdtreelb.cxx |2 sd/source/ui/docshell/docshel3.cxx |2 sd/source/ui/docshell/docshel4.cxx |2 sd/source/ui/docshell/docshell.cxx |2 sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.cxx |2 sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx |6 sd/source/ui/framework/configuration/ConfigurationController.cxx | 12 - sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx |4 sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.hxx | 10 - sd/source/ui/framework/configuration/ConfigurationUpdater.cxx |8 sd/source/ui/framework/configuration/ConfigurationUpdater.hxx | 12 - sd/source/ui/framework/factories/BasicPaneFactory.hxx |2 sd/source/ui/framework/factories/BasicViewFactory.cxx | 32 +-- sd/source/ui/framework/factories/BasicViewFactory.hxx | 18 +- sd/source/ui/framework/factories/FullScreenPane.hxx |2 sd/source/ui/framework/factories/ViewShellWrapper.cxx |4 sd/source/ui/framework/module/CenterViewFocusModule.cxx |2 sd/source/ui/framework/module/ResourceManager.hxx |1 sd/source/ui/framework/module/ShellStackGuard.hxx |2 sd/source/ui/framework/module/ToolBarModule.cxx |6 sd/source/ui/framework/module/ToolBarModule.hxx |2 sd/source/ui/framework/tools/FrameworkHelper.cxx | 24 +- sd/source/ui/func/fuarea.cxx |2 sd/source/ui/func/fubullet.cxx
[Libreoffice-commits] core.git: Branch 'feature/themesupport' - 4 commits - svx/source sw/source writerfilter/source
svx/source/styles/ColorSets.cxx | 40 +++ sw/source/uibase/sidebar/ThemePanel.cxx |4 +- writerfilter/source/dmapper/DomainMapper.cxx |2 - writerfilter/source/dmapper/TDefTableHandler.cxx | 10 ++--- 4 files changed, 28 insertions(+), 28 deletions(-) New commits: commit eb176615afd85fdebcecfe3ad6dacad7d585c9d7 Author: Tomaž VajngerlDate: Wed Sep 23 13:38:38 2015 +0200 adjust the conversion from theme color type to the color set index Change-Id: I8c54c8935de8acc3e2b302e10327aa2488f9ac85 diff --git a/writerfilter/source/dmapper/TDefTableHandler.cxx b/writerfilter/source/dmapper/TDefTableHandler.cxx index c3c0ce0..0f0e20f 100644 --- a/writerfilter/source/dmapper/TDefTableHandler.cxx +++ b/writerfilter/source/dmapper/TDefTableHandler.cxx @@ -301,15 +301,15 @@ sal_Int16 TDefTableHandler::getThemeColorTypeIndex(sal_Int32 nType) case NS_ooxml::LN_Value_St_ThemeColor_followedHyperlink: return 11; case NS_ooxml::LN_Value_St_ThemeColor_none: -return 12; +return -1; case NS_ooxml::LN_Value_St_ThemeColor_background1: -return 13; +return 0; case NS_ooxml::LN_Value_St_ThemeColor_text1: -return 14; +return 1; case NS_ooxml::LN_Value_St_ThemeColor_background2: -return 15; +return 2; case NS_ooxml::LN_Value_St_ThemeColor_text2: -return 16; +return 3; default: break; } commit a93a923614ae7c1f957c81084deb0516ae5bf8bc Author: Tomaž Vajngerl Date: Wed Sep 23 13:37:43 2015 +0200 convert tint value from ooxml to the value we support Change-Id: I5a79ca434be16f9dccc5aa6118a7efbf4544f0b1 diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index a98f5e1..a059e3e 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -882,7 +882,7 @@ void DomainMapper::lcl_attribute(Id nName, Value & val) case NS_ooxml::LN_CT_Color_themeTint: if (m_pImpl->GetTopContext()) { - m_pImpl->GetTopContext()->Insert(PROP_CHAR_COLOR_TINT_OR_SHADE, uno::makeAny(sal_Int16(nIntValue * 1 / 256))); + m_pImpl->GetTopContext()->Insert(PROP_CHAR_COLOR_TINT_OR_SHADE, uno::makeAny(sal_Int16((256 - nIntValue) * 1 / 256))); } m_pImpl->appendGrabBag(m_pImpl->m_aSubInteropGrabBag, "themeTint", OUString::number(nIntValue, 16)); break; commit e828a781285d843c95a2c374bc38aa10c3aab146 Author: Tomaž Vajngerl Date: Wed Sep 23 13:35:56 2015 +0200 check that the color index is valid Change-Id: Id5c7c83f50e1611af12f3b25e6c9a335a8353ba0 diff --git a/sw/source/uibase/sidebar/ThemePanel.cxx b/sw/source/uibase/sidebar/ThemePanel.cxx index 14c4436..a6db69e 100644 --- a/sw/source/uibase/sidebar/ThemePanel.cxx +++ b/sw/source/uibase/sidebar/ThemePanel.cxx @@ -257,9 +257,9 @@ void changeFont(SwFormat* pFormat, SwDocStyleSheet* pStyle, FontSet& rFontSet) void changeColor(SwTextFormatColl* pCollection, svx::ColorSet& rColorSet, StyleRedefinition* /*pRedefinition*/) { SvxColorItem aColorItem(pCollection->GetColor()); -if (aColorItem.GetThemeIndex() >= 0) +sal_Int16 nIndex = aColorItem.GetThemeIndex(); +if (nIndex >= 0 && nIndex < 12) { -sal_Int16 nIndex = aColorItem.GetThemeIndex(); Color aColor = Color(rColorSet.getColor(nIndex)); aColor.ApplyTintOrShade(aColorItem.GetTintOrShade()); aColorItem.SetValue(aColor); commit fcec4caa3d32ce76339ef8916f0d2c1e09b9600a Author: Tomaž Vajngerl Date: Wed Sep 23 13:33:59 2015 +0200 swap text and background colors in colorsets Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251 diff --git a/svx/source/styles/ColorSets.cxx b/svx/source/styles/ColorSets.cxx index 819790a..73c1637 100644 --- a/svx/source/styles/ColorSets.cxx +++ b/svx/source/styles/ColorSets.cxx @@ -31,10 +31,10 @@ void ColorSets::init() { { ColorSet aColorSet("Breeze"); -aColorSet.add(0, 0x232629); -aColorSet.add(1, 0xFCFCFC); -aColorSet.add(2, 0x31363B); -aColorSet.add(3, 0xEFF0F1); +aColorSet.add(0, 0xFCFCFC); +aColorSet.add(1, 0x232629); +aColorSet.add(2, 0xEFF0F1); +aColorSet.add(3, 0x31363B); aColorSet.add(4, 0xDA4453); aColorSet.add(5, 0xF47750); aColorSet.add(6, 0xFDBC4B); @@ -47,10 +47,10 @@ void ColorSets::init() } { ColorSet aColorSet("Tango"); -aColorSet.add(0, 0x00); -aColorSet.add(1, 0xFF); -
[Libreoffice-bugs] [Bug 93664] filter a list with merged cells does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=93664 --- Comment #9 from raal--- not bibisectable with bibisect-win32-5.0. git checkout oldest: Version: 4.5.0.0.alpha0+ Build ID: 57d6b92b69a31260dea0d84fcd1fc5866ada7adb contains the bug -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/index/swuiidxmrk.cxx | 20 ++-- sw/source/uibase/inc/swuiidxmrk.hxx |2 +- 2 files changed, 11 insertions(+), 11 deletions(-) New commits: commit aada49a5743c298e461660420fe48ef4c220e292 Author: Noel GrandinDate: Tue Sep 22 21:48:35 2015 +0200 convert Link<> to typed Change-Id: I39f08451c546865327f2f1014cfa33c78cdcdc9b Reviewed-on: https://gerrit.libreoffice.org/18798 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx index 269731c..879b27b 100644 --- a/sw/source/ui/index/swuiidxmrk.cxx +++ b/sw/source/ui/index/swuiidxmrk.cxx @@ -981,7 +981,7 @@ class SwCreateAuthEntryDlg_Impl : public ModalDialog VclPtr m_pOKBT; -Link<> aShortNameCheckLink; +Link aShortNameCheckLink; SwWrtShell& rWrtSh; @@ -1003,7 +1003,7 @@ public: OUStringGetEntryText(ToxAuthorityField eField) const; -voidSetCheckNameHdl(const Link<>& rLink) {aShortNameCheckLink = rLink;} +voidSetCheckNameHdl(const Link & rLink) {aShortNameCheckLink = rLink;} }; @@ -1332,10 +1332,10 @@ IMPL_LINK_TYPED(SwAuthorMarkPane, ChangeSourceHdl, Button*, pButton, void) IMPL_LINK(SwAuthorMarkPane, EditModifyHdl, Edit*, pEdit) { -Link<> aAllowed = LINK(this, SwAuthorMarkPane, IsEntryAllowedHdl); -long nResult = aAllowed.Call(pEdit); -m_pActionBT->Enable(nResult > 0); -if(nResult) +Link aAllowed = LINK(this, SwAuthorMarkPane, IsEntryAllowedHdl); +bool bResult = aAllowed.Call(pEdit); +m_pActionBT->Enable(bResult); +if(bResult) { OUString sEntry(pEdit->GetText()); m_sFields[AUTH_FIELD_IDENTIFIER] = sEntry; @@ -1344,14 +1344,14 @@ IMPL_LINK(SwAuthorMarkPane, EditModifyHdl, Edit*, pEdit) return 0; }; -IMPL_LINK(SwAuthorMarkPane, IsEntryAllowedHdl, Edit*, pEdit) +IMPL_LINK_TYPED(SwAuthorMarkPane, IsEntryAllowedHdl, Edit*, pEdit, bool) { OUString sEntry = pEdit->GetText(); bool bAllowed = false; if(!sEntry.isEmpty()) { if(m_pEntryLB->GetEntryPos(sEntry) != LISTBOX_ENTRY_NOTFOUND) -return 0; +return false; else if(bIsFromComponent) { const SwAuthorityFieldType* pFType = static_cast( @@ -1363,7 +1363,7 @@ IMPL_LINK(SwAuthorMarkPane, IsEntryAllowedHdl, Edit*, pEdit) bAllowed = !xBibAccess.is() || !xBibAccess->hasByName(sEntry); } } -return bAllowed ? 1 : 0; +return bAllowed; } void SwAuthorMarkPane::InitControls() @@ -1581,7 +1581,7 @@ IMPL_LINK(SwCreateAuthEntryDlg_Impl, ShortNameHdl, Edit*, pEdit) { if(aShortNameCheckLink.IsSet()) { -bool bEnable = 0 != aShortNameCheckLink.Call(pEdit); +bool bEnable = aShortNameCheckLink.Call(pEdit); m_bNameAllowed |= bEnable; m_pOKBT->Enable(pTypeListBox->GetSelectEntryCount() && bEnable); } diff --git a/sw/source/uibase/inc/swuiidxmrk.hxx b/sw/source/uibase/inc/swuiidxmrk.hxx index 40772ab..1e394b4 100644 --- a/sw/source/uibase/inc/swuiidxmrk.hxx +++ b/sw/source/uibase/inc/swuiidxmrk.hxx @@ -210,7 +210,7 @@ class SwAuthorMarkPane DECL_LINK_TYPED(CreateEntryHdl, Button*, void); DECL_LINK(CompEntryHdl, ListBox*); DECL_LINK_TYPED(ChangeSourceHdl, Button*, void); -DECL_LINK(IsEntryAllowedHdl, Edit*); +DECL_LINK_TYPED(IsEntryAllowedHdl, Edit*, bool); DECL_LINK(EditModifyHdl, Edit*); void InitControls(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/index/cnttab.cxx | 26 -- sw/source/uibase/inc/swuicnttab.hxx |2 +- 2 files changed, 13 insertions(+), 15 deletions(-) New commits: commit bd9adac7753113a9f03e52b43bf238c4889b918d Author: Noel GrandinDate: Tue Sep 22 21:45:56 2015 +0200 convert Link<> to typed Change-Id: I210ea5a66ebb78d6aa93c53e95ddf00e93fd81e0 Reviewed-on: https://gerrit.libreoffice.org/18797 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx index e663612..fdab9dc 100644 --- a/sw/source/ui/index/cnttab.cxx +++ b/sw/source/ui/index/cnttab.cxx @@ -1603,10 +1603,10 @@ void SwTOXEdit::AdjustSize() class SwTOXButton : public PushButton { -SwFormToken aFormToken; -Link<> aPrevNextControlLink; -boolbNextControl; -VclPtr m_pParent; +SwFormToken aFormToken; +Link aPrevNextControlLink; +boolbNextControl; +VclPtr m_pParent; public: SwTOXButton( vcl::Window* pParent, SwTokenWindow* pTokenWin, const SwFormToken& rToken) @@ -1623,7 +1623,7 @@ public: virtual void RequestHelp( const HelpEvent& rHEvt ) SAL_OVERRIDE; bool IsNextControl() const {return bNextControl;} -void SetPrevNextLink(const Link<>& rLink) {aPrevNextControlLink = rLink;} +void SetPrevNextLink(const Link & rLink) {aPrevNextControlLink = rLink;} const SwFormToken& GetFormToken() const {return aFormToken;} void SetCharStyleName(const OUString& rSet, sal_uInt16 nPoolId) @@ -1721,7 +1721,7 @@ void SwTOXButton::KeyInput( const KeyEvent& rKEvt ) } } if(bCall && aPrevNextControlLink.IsSet()) -aPrevNextControlLink.Call(this); +aPrevNextControlLink.Call(*this); else PushButton::KeyInput(rKEvt); } @@ -3502,19 +3502,19 @@ IMPL_LINK(SwTokenWindow, TbxFocusHdl, SwTOXEdit*, pEdit) return 0; } -IMPL_LINK(SwTokenWindow, NextItemBtnHdl, SwTOXButton*, pBtn ) +IMPL_LINK_TYPED(SwTokenWindow, NextItemBtnHdl, SwTOXButton&, rBtn, void ) { -ctrl_iterator it = std::find(aControlList.begin(),aControlList.end(),pBtn); +ctrl_iterator it = std::find(aControlList.begin(),aControlList.end(),); if (it == aControlList.end()) -return 0; +return; ctrl_iterator itTest = it; ++itTest; -if (!pBtn->IsNextControl() || (itTest != aControlList.end() && pBtn->IsNextControl())) +if (!rBtn.IsNextControl() || (itTest != aControlList.end() && rBtn.IsNextControl())) { -bool isNext = pBtn->IsNextControl(); +bool isNext = rBtn.IsNextControl(); ctrl_iterator iterFocus = it; isNext ? ++iterFocus : --iterFocus; @@ -3533,12 +3533,10 @@ IMPL_LINK(SwTokenWindow, NextItemBtnHdl, SwTOXButton*, pBtn ) static_cast (pCtrlFocus)->SetSelection(aSel); -pBtn->Check(false); +rBtn.Check(false); AdjustScrolling(); } - -return 0; } IMPL_LINK(SwTokenWindow, TbxFocusBtnHdl, SwTOXButton*, pBtn ) diff --git a/sw/source/uibase/inc/swuicnttab.hxx b/sw/source/uibase/inc/swuicnttab.hxx index e395ad2..8d74ab9 100644 --- a/sw/source/uibase/inc/swuicnttab.hxx +++ b/sw/source/uibase/inc/swuicnttab.hxx @@ -270,7 +270,7 @@ class SwTokenWindow : public VclHBox, public VclBuilderContainer DECL_LINK(EditResize, Edit*); DECL_LINK_TYPED(NextItemHdl, SwTOXEdit&, void ); DECL_LINK(TbxFocusHdl, SwTOXEdit* ); -DECL_LINK(NextItemBtnHdl, SwTOXButton* ); +DECL_LINK_TYPED(NextItemBtnHdl, SwTOXButton&, void ); DECL_LINK(TbxFocusBtnHdl, SwTOXButton* ); DECL_LINK_TYPED(ScrollHdl, Button*, void ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dochdl/swdtflvr.cxx |8 sw/source/uibase/inc/wrtsh.hxx |2 -- sw/source/uibase/wrtsh/delete.cxx|6 +++--- sw/source/uibase/wrtsh/select.cxx|2 +- 4 files changed, 8 insertions(+), 10 deletions(-) New commits: commit fd8183f7d2458fe474fe36462d2d4c23bc1d37e7 Author: Noel GrandinDate: Wed Sep 23 14:44:58 2015 +0200 no point in redeclaring methods with slightly different names Change-Id: I446ca61415e998d1f325b602cb587815af5ff425 Reviewed-on: https://gerrit.libreoffice.org/18813 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx b/sw/source/uibase/dochdl/swdtflvr.cxx index 31a5c47..97a1759 100644 --- a/sw/source/uibase/dochdl/swdtflvr.cxx +++ b/sw/source/uibase/dochdl/swdtflvr.cxx @@ -3270,12 +3270,12 @@ bool SwTransferable::PrivatePaste( SwWrtShell& rShell ) // Why not for other Scripts? If TRNSFR_DOCUMENT_WORD is set, we have a word // in the buffer, word in this context means 'something with spaces at beginning // and end'. In this case we definitely want these spaces to be inserted here. -bInWrd = rShell.IsInWrd(); +bInWrd = rShell.IsInWord(); bEndWrd = rShell.IsEndWrd(); bSmart = bInWrd || bEndWrd; if( bSmart ) { -bSttWrd = rShell.IsSttWrd(); +bSttWrd = rShell.IsStartWord(); if( bSmart && !bSttWrd && (bInWrd || bEndWrd) ) rShell.SwEditShell::Insert(' '); } @@ -3415,9 +3415,9 @@ bool SwTransferable::PrivateDrop( SwWrtShell& rSh, const Point& rDragPt, rSh.GoNextCrsr(); } -bInWrd = rSh.IsInWrd(); +bInWrd = rSh.IsInWord(); bEndWrd = rSh.IsEndWrd(); -bSttWrd = !bEndWrd && rSh.IsSttWrd(); +bSttWrd = !bEndWrd && rSh.IsStartWord(); bSttPara= rSh.IsSttPara(); Point aSttPt( SwEditWin::GetDDStartPosX(), SwEditWin::GetDDStartPosY() ); diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx index 16b4836..01db507 100644 --- a/sw/source/uibase/inc/wrtsh.hxx +++ b/sw/source/uibase/inc/wrtsh.hxx @@ -171,8 +171,6 @@ public: inline bool Is_FnDragEQBeginDrag() const; // base requests -boolIsInWrd() { return IsInWord(); } -boolIsSttWrd() { return IsStartWord(); } boolIsEndWrd(); boolIsSttOfPara() const { return IsSttPara(); } boolIsEndOfPara() const { return IsEndPara(); } diff --git a/sw/source/uibase/wrtsh/delete.cxx b/sw/source/uibase/wrtsh/delete.cxx index 897d9e7..36cde06 100644 --- a/sw/source/uibase/wrtsh/delete.cxx +++ b/sw/source/uibase/wrtsh/delete.cxx @@ -488,9 +488,9 @@ long SwWrtShell::DelNxtWord() ResetCursorStack(); EnterStdMode(); SetMark(); -if(IsEndWrd() && !IsSttWrd()) +if(IsEndWrd() && !IsStartWord()) _NxtWrdForDelete(); // #i92468# -if(IsSttWrd() || IsEndPara()) +if(IsStartWord() || IsEndPara()) _NxtWrdForDelete(); // #i92468# else _EndWrd(); @@ -512,7 +512,7 @@ long SwWrtShell::DelPrvWord() ResetCursorStack(); EnterStdMode(); SetMark(); -if ( !IsSttWrd() || +if ( !IsStartWord() || !_PrvWrdForDelete() ) // #i92468# { if (IsEndWrd() || IsSttPara()) diff --git a/sw/source/uibase/wrtsh/select.cxx b/sw/source/uibase/wrtsh/select.cxx index 7461733..5e3acf1 100644 --- a/sw/source/uibase/wrtsh/select.cxx +++ b/sw/source/uibase/wrtsh/select.cxx @@ -63,7 +63,7 @@ void SwWrtShell::Invalidate() bool SwWrtShell::SelNearestWrd() { SwMvContext aMvContext(this); -if( !IsInWrd() && !IsEndWrd() && !IsSttWrd() ) +if( !IsInWord() && !IsEndWrd() && !IsStartWord() ) PrvWrd(); if( IsEndWrd() ) Left(CRSR_SKIP_CELLS, false, 1, false ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/inputwin.hxx|2 +- sw/source/uibase/inc/wrtsh.hxx |6 +++--- sw/source/uibase/ribbar/inputwin.cxx |7 +++ sw/source/uibase/wrtsh/select.cxx|4 ++-- 4 files changed, 9 insertions(+), 10 deletions(-) New commits: commit 98680db45f51296f536b9f9889f53172fa50ee8f Author: Noel GrandinDate: Wed Sep 23 14:40:09 2015 +0200 convert Link<> to typed Change-Id: I6a4fade1688dfce9aec1530da51ea874cddfcbc0 Reviewed-on: https://gerrit.libreoffice.org/18812 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/uibase/inc/inputwin.hxx b/sw/source/uibase/inc/inputwin.hxx index 622642c..444c5b3 100644 --- a/sw/source/uibase/inc/inputwin.hxx +++ b/sw/source/uibase/inc/inputwin.hxx @@ -87,7 +87,7 @@ public: voidShowWin(); -DECL_LINK( SelTableCellsNotify, SwWrtShell * ); +DECL_LINK_TYPED( SelTableCellsNotify, SwWrtShell&, void ); voidSetFormula( const OUString& rFormula, bool bDelSel = true ); const SwView* GetView() const{return pView;} diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx index ed3b34b..16b4836 100644 --- a/sw/source/uibase/inc/wrtsh.hxx +++ b/sw/source/uibase/inc/wrtsh.hxx @@ -160,7 +160,7 @@ public: voidInvalidate(); // select table cells for editing of formulas in the ribbonbar -inline void SelTableCells( const Link<> , bool bMark = true ); +inline void SelTableCells( const Link , bool bMark = true ); inline void EndSelTableCells(); // leave per word or per line selection mode. Is usually called in MB-Up. @@ -560,7 +560,7 @@ private: boolm_bRetainSelection :1; // Do not remove selections Point m_aStart; -Link<> m_aSelTableLink; +Link m_aSelTableLink; // resets the cursor stack after movement by PageUp/-Down SAL_DLLPRIVATE void _ResetCursorStack(); @@ -609,7 +609,7 @@ inline void SwWrtShell::ResetCursorStack() _ResetCursorStack(); } -inline void SwWrtShell::SelTableCells(const Link<> , bool bMark ) +inline void SwWrtShell::SelTableCells(const Link , bool bMark ) { SetSelTableCells( true ); m_bClearMark = bMark; diff --git a/sw/source/uibase/ribbar/inputwin.cxx b/sw/source/uibase/ribbar/inputwin.cxx index 6fd9d12..9f0647b 100644 --- a/sw/source/uibase/ribbar/inputwin.cxx +++ b/sw/source/uibase/ribbar/inputwin.cxx @@ -418,12 +418,12 @@ void SwInputWindow::CancelFormula() const sal_Unicode CH_LRE = 0x202a; const sal_Unicode CH_PDF = 0x202c; -IMPL_LINK( SwInputWindow, SelTableCellsNotify, SwWrtShell *, pCaller ) +IMPL_LINK_TYPED( SwInputWindow, SelTableCellsNotify, SwWrtShell&, rCaller, void ) { if(bIsTable) { -SwFrameFormat* pTableFormat = pCaller->GetTableFormat(); -OUString sBoxNms( pCaller->GetBoxNms() ); +SwFrameFormat* pTableFormat = rCaller.GetTableFormat(); +OUString sBoxNms( rCaller.GetBoxNms() ); OUString sTableNm; if( pTableFormat && aAktTableName != pTableFormat->GetName() ) sTableNm = pTableFormat->GetName(); @@ -456,7 +456,6 @@ IMPL_LINK( SwInputWindow, SelTableCellsNotify, SwWrtShell *, pCaller ) } else aEdit->GrabFocus(); -return 0; } void SwInputWindow::SetFormula( const OUString& rFormula, bool bDelFlag ) diff --git a/sw/source/uibase/wrtsh/select.cxx b/sw/source/uibase/wrtsh/select.cxx index d530b55..7461733 100644 --- a/sw/source/uibase/wrtsh/select.cxx +++ b/sw/source/uibase/wrtsh/select.cxx @@ -783,7 +783,7 @@ long SwWrtShell::BeginDrag(const Point * /*pPt*/, bool ) long SwWrtShell::DefaultDrag(const Point *, bool ) { if( IsSelTableCells() ) -m_aSelTableLink.Call(this); +m_aSelTableLink.Call(*this); return 1; } @@ -795,7 +795,7 @@ long SwWrtShell::DefaultEndDrag(const Point * /*pPt*/, bool ) LeaveExtSel(); if( IsSelTableCells() ) -m_aSelTableLink.Call(this); +m_aSelTableLink.Call(*this); EndSelect(); return 1; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sd/qa sd/source
sd/qa/unit/data/ppt/pass/hang-22.ppt |binary sd/source/filter/ppt/pptin.cxx |3 - sd/source/filter/ppt/propread.cxx| 78 +-- sd/source/filter/ppt/propread.hxx|4 - 4 files changed, 43 insertions(+), 42 deletions(-) New commits: commit a6a46e2100f954085550f4dc6a597fd7ee234671 Author: Caolán McNamaraDate: Fri Sep 18 12:46:29 2015 +0100 check stream status and string lengths (cherry picked from commit 7af19f45b35c428d3e06972806e5a05489f45955) if nSize was 1 with unicode encoding nSize would wrap around in lcl_getMaxSafeStrLen (cherry picked from commit f6368c29bdc3a9017bcae3f064d2cd8c7e37ed10) rework this so we don't read the string, backup and re-read the string again (cherry picked from commit 8523e57e427ef5b0b7f7067dcdd07f01176d2160) Change-Id: I99f3d4a2ec760228f485d01fce856deb9c068431 Reviewed-on: https://gerrit.libreoffice.org/18691 Reviewed-by: David Tardon Tested-by: David Tardon diff --git a/sd/qa/unit/data/ppt/pass/hang-22.ppt b/sd/qa/unit/data/ppt/pass/hang-22.ppt new file mode 100644 index 000..c869b39 Binary files /dev/null and b/sd/qa/unit/data/ppt/pass/hang-22.ppt differ diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx index 27f483d..e503589 100644 --- a/sd/source/filter/ppt/pptin.cxx +++ b/sd/source/filter/ppt/pptin.cxx @@ -366,7 +366,8 @@ bool ImplSdPPTImport::Import() if ( pSection ) { Dictionary aDict; -if ( pSection->GetDictionary( aDict ) ) +pSection->GetDictionary(aDict); +if (!aDict.empty()) { Dictionary::const_iterator iter = aDict.find( OUString("_PID_HLINKS") ); diff --git a/sd/source/filter/ppt/propread.cxx b/sd/source/filter/ppt/propread.cxx index f73d26f..11552d6 100644 --- a/sd/source/filter/ppt/propread.cxx +++ b/sd/source/filter/ppt/propread.cxx @@ -269,10 +269,8 @@ void Section::AddProperty( sal_uInt32 nId, const sal_uInt8* pBuf, sal_uInt32 nBu maEntries.push_back( new PropEntry( nId, pBuf, nBufSize, mnTextEnc ) ); } -bool Section::GetDictionary( Dictionary& rDict ) +void Section::GetDictionary(Dictionary& rDict) { -bool bRetValue = false; - boost::ptr_vector::iterator iter; for (iter = maEntries.begin(); iter != maEntries.end(); ++iter) { @@ -280,48 +278,50 @@ bool Section::GetDictionary( Dictionary& rDict ) break; } -if ( iter != maEntries.end() ) +if (iter == maEntries.end()) +return; + +SvMemoryStream aStream( iter->mpBuf, iter->mnSize, STREAM_READ ); +aStream.Seek( STREAM_SEEK_TO_BEGIN ); +sal_uInt32 nDictCount(0); +aStream.ReadUInt32( nDictCount ); +for (sal_uInt32 i = 0; i < nDictCount; ++i) { -sal_uInt32 nDictCount, nId, nSize, nPos; -SvMemoryStream aStream( (sal_Int8*)iter->mpBuf, iter->mnSize, STREAM_READ ); -aStream.Seek( STREAM_SEEK_TO_BEGIN ); -aStream.ReadUInt32( nDictCount ); -for ( sal_uInt32 i = 0; i < nDictCount; i++ ) +sal_uInt32 nId(0), nSize(0); +aStream.ReadUInt32(nId).ReadUInt32(nSize); +if (!aStream.good() || nSize > aStream.remainingSize()) +break; +if (mnTextEnc == RTL_TEXTENCODING_UCS2) +nSize >>= 1; +if (!nSize) +continue; +OUString aString; +try { -aStream.ReadUInt32( nId ).ReadUInt32( nSize ); -if ( nSize ) +if ( mnTextEnc == RTL_TEXTENCODING_UCS2 ) { -OUString aString; -nPos = aStream.Tell(); -try -{ -sal_Char* pString = new sal_Char[ nSize ]; -aStream.Read( pString, nSize ); -if ( mnTextEnc == RTL_TEXTENCODING_UCS2 ) -{ -nSize >>= 1; -aStream.Seek( nPos ); -sal_Unicode* pWString = reinterpret_cast (pString); -for (sal_uInt32 j = 0; j < nSize; ++j) -aStream.ReadUInt16(pWString[j]); -aString = OUString(pWString, lcl_getMaxSafeStrLen(nSize)); -} -else -aString = OUString(pString, lcl_getMaxSafeStrLen(nSize), mnTextEnc); -delete[] pString; -} -catch( const std::bad_alloc& ) -{ -OSL_FAIL( "sd Section::GetDictionary bad alloc" ); -} -if ( aString.isEmpty() ) -break; -rDict.insert( std::make_pair(aString,nId) ); +sal_Unicode* pWString = new sal_Unicode[nSize]; +for
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/file_misc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d2a7abebf210cacf9ea357dd8b4a0772be7308df Author: Stephan BergmannDate: Wed Sep 23 14:01:33 2015 +0200 Better fail with E_EXIST if rename(3) fails ...it leads to better handling of the failure downstream, if e.g. this is an attempt to copy a file from the presets to an existing file of a previously partly generated UserInstallation, and the presets and the UserInstallation are on different drives and rename(3) fails with EXDEV. (Without this fix, removing the UserInstallation's registrymodifications.xcu caused restarting soffice to fail with "User installation could not be completed" in this case; regression introduced with 6edbcc1b231feb02f304ff646c323b5df051d9a4 "cid#1242936 handle rename failure.") Change-Id: I409698c4e2e6cc6ccd8b2be80a393c9657b5125d diff --git a/sal/osl/unx/file_misc.cxx b/sal/osl/unx/file_misc.cxx index f507581..2330f29 100644 --- a/sal/osl/unx/file_misc.cxx +++ b/sal/osl/unx/file_misc.cxx @@ -816,7 +816,7 @@ static oslFileError oslDoCopy(const sal_Char* pszSourceFileName, const sal_Char* "sal.osl", "rename(" << pszDestFileName << ", " << tmpDestFile << ") failed with errno " << e); -return osl_File_E_BUSY; // for want of a better error code +return osl_File_E_EXIST; // for want of a better error code } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94434] Libreoffice crashes during launch
https://bugs.documentfoundation.org/show_bug.cgi?id=94434 --- Comment #2 from steve -_---- Just adding a data point to say, this is not a general problem. OSX 10.10.5 LO Version: 5.1.0.0.alpha1+ Build ID: f7ef1cbb83fdc6c43fa39fd50a9e12703e4fcf5f TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-09-19_09:29:27 Locale: de-DE (de.UTF-8) No crashing. Must be machine specific. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/doc.hxx|3 +-- sw/source/core/doc/docbasic.cxx |2 +- sw/source/uibase/inc/wrtsh.hxx|3 +-- sw/source/uibase/wrtsh/wrtsh3.cxx |5 ++--- 4 files changed, 5 insertions(+), 8 deletions(-) New commits: commit f6924329e6d50edfa8d9c27292f5e402e7580a12 Author: Noel GrandinDate: Tue Sep 22 21:40:58 2015 +0200 remove unused Link<> parameter Change-Id: I9d8916b69e2e986ee1e30091cb046e7812a68ed1 Reviewed-on: https://gerrit.libreoffice.org/18795 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index e2966d2..2ddcc2d 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -1403,8 +1403,7 @@ public: // Call into intransparent Basic / JavaScript. sal_uInt16 CallEvent( sal_uInt16 nEvent, const SwCallMouseEvent& rCallEvent, -bool bChkPtr = false, SbxArray* pArgs = 0, -const Link<>* pCallBack = 0 ); +bool bChkPtr = false, SbxArray* pArgs = 0 ); /** Adjust left margin via object bar (similar to adjustment of numerations). One can either change the margin "by" adding or subtracting a given diff --git a/sw/source/core/doc/docbasic.cxx b/sw/source/core/doc/docbasic.cxx index f6daa8e..056ea75 100644 --- a/sw/source/core/doc/docbasic.cxx +++ b/sw/source/core/doc/docbasic.cxx @@ -131,7 +131,7 @@ bool SwDoc::ExecMacro( const SvxMacro& rMacro, OUString* pRet, SbxArray* pArgs ) } sal_uInt16 SwDoc::CallEvent( sal_uInt16 nEvent, const SwCallMouseEvent& rCallEvent, -bool bCheckPtr, SbxArray* pArgs, const Link<>* ) +bool bCheckPtr, SbxArray* pArgs ) { if( !mpDocShell )// we can't do that without a DocShell! return 0; diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx index db852bc..ed3b34b 100644 --- a/sw/source/uibase/inc/wrtsh.hxx +++ b/sw/source/uibase/inc/wrtsh.hxx @@ -419,8 +419,7 @@ typedef bool (SwWrtShell:: *FNSimpleMove)(); void ExecMacro( const SvxMacro& rMacro, OUString* pRet = 0, SbxArray* pArgs = 0 ); // call into the dark Basic/JavaScript sal_uInt16 CallEvent( sal_uInt16 nEvent, const SwCallMouseEvent& rCallEvent, -bool bCheckPtr = false, SbxArray* pArgs = 0, -const Link<>* pCallBack = 0 ); +bool bCheckPtr = false, SbxArray* pArgs = 0 ); // a click at the given field. the cursor is on it. // execute the predefined actions. diff --git a/sw/source/uibase/wrtsh/wrtsh3.cxx b/sw/source/uibase/wrtsh/wrtsh3.cxx index a3ef19e..c361896 100644 --- a/sw/source/uibase/wrtsh/wrtsh3.cxx +++ b/sw/source/uibase/wrtsh/wrtsh3.cxx @@ -159,10 +159,9 @@ void SwWrtShell::ExecMacro( const SvxMacro& rMacro, OUString* pRet, SbxArray* pA } sal_uInt16 SwWrtShell::CallEvent( sal_uInt16 nEvent, const SwCallMouseEvent& rCallEvent, -bool bChkPtr, SbxArray* pArgs, -const Link<>* pCallBack ) +bool bChkPtr, SbxArray* pArgs) { -return GetDoc()->CallEvent( nEvent, rCallEvent, bChkPtr, pArgs, pCallBack ); +return GetDoc()->CallEvent( nEvent, rCallEvent, bChkPtr, pArgs ); } // If a util::URL-Button is selected, return its util::URL ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75314] SVG: Some closed path and groupped path not handled properly
https://bugs.documentfoundation.org/show_bug.cgi?id=75314 --- Comment #8 from Evgeniy--- Opened figures? It's simple bug: LibreOffice Draw requires "Z" (close figure command) at end of "d" attribute in token. w3c SVG specification does not describe such a requirement. This is filled blue rectangle with horizontal line: This rectangle is not closed and respectively not filled: Difference in one command: "Z" at end of path. I hope in the next release will be fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93438] Impress generate abnormal style when copy-pasting from Writer with Chinese UI
https://bugs.documentfoundation.org/show_bug.cgi?id=93438 Miklos Vajnachanged: What|Removed |Added CC||pp...@mail.ru --- Comment #6 from Miklos Vajna --- *** Bug 91091 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91091] Copy-paste from read-only file + save hangs entire LibreOffice suite
https://bugs.documentfoundation.org/show_bug.cgi?id=91091 Miklos Vajnachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Miklos Vajna --- I could reproduce the saving error on libreoffice-5-0-branch-point, but not on master. bisect says commit 0955bfed86e55f823fb9686f52dbffc36558b5d5 Author: Mark Hung Date: Sun Aug 30 16:08:20 2015 +0800 Fix tdf#93438 Impress generate abnormal style when copy-pasting Is the commit that made the problem go away -> marking as a duplicate. *** This bug has been marked as a duplicate of bug 93438 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89696] unknown software exception 0x40000015 at address 0x0036327c
https://bugs.documentfoundation.org/show_bug.cgi?id=89696 --- Comment #15 from Massimo Sala--- Any news ? Is there anybody working on this ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/scuitphfedit.hxx |2 +- sc/source/ui/inc/tphfedit.hxx |4 ++-- sc/source/ui/pagedlg/scuitphfedit.cxx |4 +--- sc/source/ui/pagedlg/tphfedit.cxx |2 +- 4 files changed, 5 insertions(+), 7 deletions(-) New commits: commit c24ce843619416f1e6c082a6e8e512310e6e0040 Author: Noel GrandinDate: Wed Sep 23 13:30:21 2015 +0200 convert Link<> to typed Change-Id: I245ba9e550c7b833fe184a24b63b55027aeecac9 Reviewed-on: https://gerrit.libreoffice.org/18809 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/scuitphfedit.hxx b/sc/source/ui/inc/scuitphfedit.hxx index 127767f..d0767fc 100644 --- a/sc/source/ui/inc/scuitphfedit.hxx +++ b/sc/source/ui/inc/scuitphfedit.hxx @@ -85,7 +85,7 @@ private: sal_uInt16 nWhich; OUString aCmdArr[6]; -DECL_LINK( ObjectSelectHdl, ScEditWindow* ); +DECL_LINK_TYPED( ObjectSelectHdl, ScEditWindow&, void ); private: void FillCmdArr(); diff --git a/sc/source/ui/inc/tphfedit.hxx b/sc/source/ui/inc/tphfedit.hxx index aedb2e8..60cab02 100644 --- a/sc/source/ui/inc/tphfedit.hxx +++ b/sc/source/ui/inc/tphfedit.hxx @@ -71,7 +71,7 @@ public: virtual ::com::sun::star::uno::Reference< ::com::sun::star::accessibility::XAccessible > CreateAccessible() SAL_OVERRIDE; ScHeaderEditEngine* GetEditEngine() const { return pEdEngine; } -void SetObjectSelectHdl( const Link<>& aLink) { aObjectSelectLink = aLink; } +void SetObjectSelectHdl( const Link & aLink) { aObjectSelectLink = aLink; } void SetLocation(ScEditWindowLocation eLoc) { eLocation = eLoc; } protected: @@ -94,7 +94,7 @@ private: com::sun::star::uno::WeakReference< ::com::sun::star::accessibility::XAccessible > xAcc; ScAccessibleEditObject* pAcc; -Link<> aObjectSelectLink; +Link aObjectSelectLink; }; class SC_DLLPUBLIC ScExtIButton : public ImageButton diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx b/sc/source/ui/pagedlg/scuitphfedit.cxx index b043dc4..b4df75a 100644 --- a/sc/source/ui/pagedlg/scuitphfedit.cxx +++ b/sc/source/ui/pagedlg/scuitphfedit.cxx @@ -149,11 +149,9 @@ ScHFEditPage::ScHFEditPage( vcl::Window* pParent, } -IMPL_LINK( ScHFEditPage, ObjectSelectHdl, ScEditWindow*, pEdit ) +IMPL_LINK_NOARG_TYPED( ScHFEditPage, ObjectSelectHdl, ScEditWindow&, void ) { -(void)pEdit; m_pBtnText->GrabFocus(); -return 0; } ScHFEditPage::~ScHFEditPage() diff --git a/sc/source/ui/pagedlg/tphfedit.cxx b/sc/source/ui/pagedlg/tphfedit.cxx index 968886e..0452e9c 100644 --- a/sc/source/ui/pagedlg/tphfedit.cxx +++ b/sc/source/ui/pagedlg/tphfedit.cxx @@ -272,7 +272,7 @@ void ScEditWindow::KeyInput( const KeyEvent& rKEvt ) rKEvt.GetKeyCode().IsMod2() && rKEvt.GetKeyCode().GetCode() == KEY_DOWN ) { if (aObjectSelectLink.IsSet() ) -aObjectSelectLink.Call(this); +aObjectSelectLink.Call(*this); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/reffact.hxx |4 ++-- sc/source/ui/inc/simpref.hxx | 10 +- sc/source/ui/inc/tabvwsh.hxx |6 +++--- sc/source/ui/miscdlgs/simpref.cxx | 15 --- sc/source/ui/view/reffact.cxx |4 ++-- sc/source/ui/view/tabvwsh4.cxx| 21 + 6 files changed, 29 insertions(+), 31 deletions(-) New commits: commit df9dbfc1b187c6acdf864f8a169e5782aac61285 Author: Noel GrandinDate: Wed Sep 23 12:57:27 2015 +0200 convert Link<> to typed Change-Id: Ia647a53efa7bd8d0e0fe6937709b92c85a2e67a6 Reviewed-on: https://gerrit.libreoffice.org/18808 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx index e3e8bcc..ae843fc 100644 --- a/sc/source/ui/inc/reffact.hxx +++ b/sc/source/ui/inc/reffact.hxx @@ -162,8 +162,8 @@ class ScSimpleRefDlgWrapper: public SfxChildWindow static void SetDefaultPosSize(Point aPos, Size aSize, bool bSet = true); voidSetRefString(const OUString& rStr); voidSetCloseHdl( const Link& rLink ); -voidSetUnoLinks( const Link<>& rDone, const Link<>& rAbort, -const Link<>& rChange ); +voidSetUnoLinks( const Link& rDone, const Link& rAbort, +const Link& rChange ); voidSetFlags( bool bCloseOnButtonUp, bool bSingleCell, bool bMultiSelection ); static void SetAutoReOpen(bool bFlag); diff --git a/sc/source/ui/inc/simpref.hxx b/sc/source/ui/inc/simpref.hxx index d02a4f1..bca6c9c0 100644 --- a/sc/source/ui/inc/simpref.hxx +++ b/sc/source/ui/inc/simpref.hxx @@ -36,9 +36,9 @@ class ScSimpleRefDlg: public ScAnyRefDlg { private: Link aCloseHdl; -Link<> aDoneHdl; -Link<> aAbortedHdl; -Link<> aChangeHdl; +Link aDoneHdl; +Link aAbortedHdl; +Link aChangeHdl; VclPtr m_pFtAssign; VclPtr m_pEdAssign; @@ -80,8 +80,8 @@ public: virtual voidFillInfo(SfxChildWinInfo&) const SAL_OVERRIDE; voidSetCloseHdl( const Link& rLink ); -voidSetUnoLinks( const Link<>& rDone, const Link<>& rAbort, -const Link<>& rChange ); +voidSetUnoLinks( const Link& rDone, const Link& rAbort, +const Link& rChange ); voidSetFlags( bool bSetCloseOnButtonUp, bool bSetSingleCell, bool bSetMultiSelection ); }; diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index 521f2fa..9a0bf9f 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -184,9 +184,9 @@ private: ::com::sun::star::beans::PropertyValue >& rSettings ); DECL_LINK_TYPED( SimpleRefClose, const OUString*, void ); -DECL_LINK( SimpleRefDone, OUString* ); -DECL_LINK( SimpleRefAborted, OUString* ); -DECL_LINK( SimpleRefChange, OUString* ); +DECL_LINK_TYPED( SimpleRefDone, const OUString&, void ); +DECL_LINK_TYPED( SimpleRefAborted, const OUString&, void ); +DECL_LINK_TYPED( SimpleRefChange, const OUString&, void ); DECL_LINK_TYPED( FormControlActivated, LinkParamNone*, void ); protected: diff --git a/sc/source/ui/miscdlgs/simpref.cxx b/sc/source/ui/miscdlgs/simpref.cxx index 9fe9592..50309ea 100644 --- a/sc/source/ui/miscdlgs/simpref.cxx +++ b/sc/source/ui/miscdlgs/simpref.cxx @@ -123,7 +123,7 @@ void ScSimpleRefDlg::SetReference( const ScRange& rRef, ScDocument* pDocP ) else m_pEdAssign->SetRefString( aRefStr ); -aChangeHdl.Call( ); +aChangeHdl.Call( aRefStr ); } } @@ -154,8 +154,9 @@ void ScSimpleRefDlg::SetCloseHdl( const Link& rLink ) aCloseHdl=rLink; } -void ScSimpleRefDlg::SetUnoLinks( const Link<>& rDone, const Link<>& rAbort, -const Link<>& rChange ) +void ScSimpleRefDlg::SetUnoLinks( const Link& rDone, + const Link& rAbort, + const Link& rChange ) { aDoneHdl= rDone; aAbortedHdl = rAbort; @@ -195,9 +196,9 @@ IMPL_LINK_NOARG_TYPED(ScSimpleRefDlg, OkBtnHdl, Button*, void) bAutoReOpen=false; OUString aResult=m_pEdAssign->GetText(); aCloseHdl.Call(); -Link<> aUnoLink = aDoneHdl; // stack var because this is deleted in DoClose +Link aUnoLink = aDoneHdl; // stack var because this is deleted in DoClose DoClose( ScSimpleRefDlgWrapper::GetChildWindowId() ); -aUnoLink.Call( ); +aUnoLink.Call( aResult ); } IMPL_LINK_NOARG_TYPED(ScSimpleRefDlg, CancelBtnHdl, Button*, void) @@ -205,9 +206,9 @@ IMPL_LINK_NOARG_TYPED(ScSimpleRefDlg, CancelBtnHdl, Button*, void) bAutoReOpen=false;
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/scuitphfedit.hxx |2 - sc/source/ui/inc/tphfedit.hxx |4 +-- sc/source/ui/pagedlg/scuitphfedit.cxx | 38 +++--- sc/source/ui/pagedlg/tphfedit.cxx |2 - 4 files changed, 21 insertions(+), 25 deletions(-) New commits: commit 5ae90e154aa2544174f7522a5464436901152cc7 Author: Noel GrandinDate: Wed Sep 23 14:22:52 2015 +0200 convert Link<> to typed Change-Id: Ib0f043cf40f2a1b4b9f0837a5c536994bff3aeef Reviewed-on: https://gerrit.libreoffice.org/18810 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/scuitphfedit.hxx b/sc/source/ui/inc/scuitphfedit.hxx index d0767fc..4e9e06b 100644 --- a/sc/source/ui/inc/scuitphfedit.hxx +++ b/sc/source/ui/inc/scuitphfedit.hxx @@ -99,7 +99,7 @@ private: static bool IsExtFileNameEntry(EditTextObject* pTextObj); DECL_LINK( ListHdl_Impl, ListBox* ); DECL_LINK_TYPED( ClickHdl, Button*, void ); -DECL_STATIC_LINK( ScHFEditPage, MenuHdl, ScExtIButton* ); +DECL_STATIC_LINK_TYPED( ScHFEditPage, MenuHdl, ScExtIButton&, void ); }; class ScRightHeaderEditPage : public ScHFEditPage diff --git a/sc/source/ui/inc/tphfedit.hxx b/sc/source/ui/inc/tphfedit.hxx index 60cab02..b26dcde 100644 --- a/sc/source/ui/inc/tphfedit.hxx +++ b/sc/source/ui/inc/tphfedit.hxx @@ -103,7 +103,7 @@ private: IdleaIdle; PopupMenu* pPopupMenu; -Link<> aMLink; +Link aMLink; sal_uInt16 nSelected; OString aSelectedIdent; @@ -126,7 +126,7 @@ public: sal_uInt16 GetSelected() const { return nSelected;} OString GetSelectedIdent() const { return aSelectedIdent;} -voidSetMenuHdl( const Link<>& rLink ) { aMLink = rLink; } +voidSetMenuHdl( const Link & rLink ) { aMLink = rLink; } virtual boolPreNotify( NotifyEvent& rNEvt ) SAL_OVERRIDE; }; diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx b/sc/source/ui/pagedlg/scuitphfedit.cxx index b4df75a..2f1cb0d 100644 --- a/sc/source/ui/pagedlg/scuitphfedit.cxx +++ b/sc/source/ui/pagedlg/scuitphfedit.cxx @@ -823,33 +823,29 @@ IMPL_LINK_TYPED( ScHFEditPage, ClickHdl, Button*, pBtn, void ) pActiveEdWnd->GrabFocus(); } -IMPL_STATIC_LINK( ScHFEditPage, MenuHdl, ScExtIButton*, pBtn ) +IMPL_STATIC_LINK_TYPED( ScHFEditPage, MenuHdl, ScExtIButton&, rBtn, void ) { pActiveEdWnd = ::GetScEditWindow(); if ( !pActiveEdWnd ) -return 0; +return; -if(pBtn!=NULL) -{ -SAL_WARN_IF(pBtn->GetSelected() == 0, "sc.ui", "nothing selected"); -OString sSelectedId = pBtn->GetSelectedIdent(); +SAL_WARN_IF(rBtn.GetSelected() == 0, "sc.ui", "nothing selected"); +OString sSelectedId = rBtn.GetSelectedIdent(); -if (sSelectedId == "title") -{ -pActiveEdWnd->InsertField( SvxFieldItem( SvxFileField(), EE_FEATURE_FIELD ) ); -} -else if (sSelectedId == "filename") -{ -pActiveEdWnd->InsertField( SvxFieldItem( SvxExtFileField( -OUString(), SVXFILETYPE_VAR, SVXFILEFORMAT_NAME_EXT ), EE_FEATURE_FIELD ) ); -} -else if (sSelectedId == "pathname") -{ -pActiveEdWnd->InsertField( SvxFieldItem( SvxExtFileField( -OUString(), SVXFILETYPE_VAR, SVXFILEFORMAT_FULLPATH ), EE_FEATURE_FIELD ) ); -} +if (sSelectedId == "title") +{ +pActiveEdWnd->InsertField( SvxFieldItem( SvxFileField(), EE_FEATURE_FIELD ) ); +} +else if (sSelectedId == "filename") +{ +pActiveEdWnd->InsertField( SvxFieldItem( SvxExtFileField( +OUString(), SVXFILETYPE_VAR, SVXFILEFORMAT_NAME_EXT ), EE_FEATURE_FIELD ) ); +} +else if (sSelectedId == "pathname") +{ +pActiveEdWnd->InsertField( SvxFieldItem( SvxExtFileField( +OUString(), SVXFILETYPE_VAR, SVXFILEFORMAT_FULLPATH ), EE_FEATURE_FIELD ) ); } -return 0; } // class ScRightHeaderEditPage diff --git a/sc/source/ui/pagedlg/tphfedit.cxx b/sc/source/ui/pagedlg/tphfedit.cxx index 0452e9c..a152453 100644 --- a/sc/source/ui/pagedlg/tphfedit.cxx +++ b/sc/source/ui/pagedlg/tphfedit.cxx @@ -395,7 +395,7 @@ void ScExtIButton::StartPopup() if(nSelected) { aSelectedIdent = pPopupMenu->GetItemIdent(nSelected); -aMLink.Call(this); +aMLink.Call(*this); } SetPressed( false); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa sw/source
sw/qa/core/data/ww8/pass/hang-9.doc |binary sw/source/filter/ww8/ww8scan.cxx| 12 2 files changed, 8 insertions(+), 4 deletions(-) New commits: commit b477a8d5df518cd8c30a1a21e3ffccc8bac88084 Author: Caolán McNamaraDate: Mon Sep 21 12:14:19 2015 +0100 don't hang on busted subdocument offsets Change-Id: I5d1d18f864496ec98894703f0a22e211a9dd14a5 (cherry picked from commit a2b90cd04733c2ec3b9cb3bb56d95f3298571ecc) Reviewed-on: https://gerrit.libreoffice.org/18748 Reviewed-by: David Tardon Tested-by: David Tardon diff --git a/sw/qa/core/data/ww8/pass/hang-9.doc b/sw/qa/core/data/ww8/pass/hang-9.doc new file mode 100644 index 000..4e9e412 Binary files /dev/null and b/sw/qa/core/data/ww8/pass/hang-9.doc differ diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx index c8afe52..2c2a46b 100644 --- a/sw/source/filter/ww8/ww8scan.cxx +++ b/sw/source/filter/ww8/ww8scan.cxx @@ -4431,11 +4431,15 @@ void WW8PLCFxDesc::ReduceByOffset() else nStartPos -= nCpOfs; } -if( nEndPos != WW8_CP_MAX ) +if (nEndPos != WW8_CP_MAX) { -OSL_ENSURE(nCpOfs <= nEndPos, -"oh oh, so much for the subdocument piece theory"); -nEndPos -= nCpOfs; +if (nCpOfs > nEndPos) +{ +SAL_WARN("sw.ww8", "broken subdocument piece entry"); +nEndPos = WW8_CP_MAX; +} +else +nEndPos -= nCpOfs; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94434] Libreoffice crashes during launch
https://bugs.documentfoundation.org/show_bug.cgi?id=94434 --- Comment #1 from ckak...@yahoo.com --- An additional observation which might help: When LO starts to crash at launch, I reboot the computer and it launches for a while without crashing. I once suspected that it started to crash after using VirtualBox 5 but I couldn't reproduce a pattern. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 94349] Add italics to Quotations paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=94349 --- Comment #7 from Heiko Tietze--- (In reply to V Stuart Foote from comment #6) > Well we could get really ambitious and integrate *ALL* the formatting styles > from Zotero > > https://www.zotero.org/styles There seems to be a (buggy) plugin to support CSL/Zotero: https://bugs.documentfoundation.org/show_bug.cgi?id=64361 If we go with such a high flexibility we'd need a plugin system (similar to "Get Hot New Stuff" or "Eye candy"). Flexible loading of templates, plugins, icon sets, styles etc. would be a great enhancement. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 94349] Add italics to Quotations paragraph style
https://bugs.documentfoundation.org/show_bug.cgi?id=94349 --- Comment #7 from Heiko Tietze--- (In reply to V Stuart Foote from comment #6) > Well we could get really ambitious and integrate *ALL* the formatting styles > from Zotero > > https://www.zotero.org/styles There seems to be a (buggy) plugin to support CSL/Zotero: https://bugs.documentfoundation.org/show_bug.cgi?id=64361 If we go with such a high flexibility we'd need a plugin system (similar to "Get Hot New Stuff" or "Eye candy"). Flexible loading of templates, plugins, icon sets, styles etc. would be a great enhancement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94463] New: FORMATTING Microsoft Office document (doc) rendered incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=94463 Bug ID: 94463 Summary: FORMATTING Microsoft Office document (doc) rendered incorrectly Product: LibreOffice Version: 4.4.0.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vi...@freeletter.me Created attachment 118967 --> https://bugs.documentfoundation.org/attachment.cgi?id=118967=edit document I have the document rendered incorrectly. zip file is the document example, images are examples. Additional tests was performed 1. 5.0.1 - rendered incorrectly. Some of the input fields (sex, Father's name) are on the left side of the table. 2. Open Office 4.1.1 - OK 3. 4.4.0.3 - OK So, basically, this is a regression. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93191] Sheet Tab Controls Right Click Not Working Correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=93191 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- Works OK in oldest, latest range in bibisect-win32-5.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94463] FORMATTING Microsoft Office document (doc) rendered incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=94463 --- Comment #1 from vi...@freeletter.me --- Created attachment 118968 --> https://bugs.documentfoundation.org/attachment.cgi?id=118968=edit correct example -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85109] Characters of CJK Unified Ideographs Extension B do not display properly
https://bugs.documentfoundation.org/show_bug.cgi?id=85109 eran...@web.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- Ever confirmed|0 |1 --- Comment #3 from eran...@web.de --- For me the Problem persists (on Windows 10, LO version 5.0.1.2). Interestingly enough, the problem only exists if I start a new file directly or open a file which doesn't contain CJK extension characters as the first file. If the first file I open contains CJK extension characters (such as the file from the attachment), everything works as it should (including in any other files I open or create during the same session). I also noticed that whenever CJK extensions don't work, so does font preview in the selection list. To be concrete, when CJK extensions don't work (i.e. if I start a new document normally), font names are displayed in a default SansSerif font (Arial or something similar) in the font selection list instead of as a preview of the respective font. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93587] insert draw ole object
https://bugs.documentfoundation.org/show_bug.cgi?id=93587 --- Comment #4 from Emersson Augusto Suarez Ortiz--- Created attachment 118969 --> https://bugs.documentfoundation.org/attachment.cgi?id=118969=edit Explain the problem (Hope so) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94408] Tree expanders missing from "Options" when using Oxygen windeco+widgets
https://bugs.documentfoundation.org/show_bug.cgi?id=94408 --- Comment #3 from Paul--- I had made quite a few changes so started fresh with a new (KDE) user profile and new LO profile. It seems that this is an issue with the LO Oxygen icon theme - not the desktop theme or window decoration, as I at first thought. As I initially, stated I'm using: Libreoffice Icon size and style: Small / Oxygen libreoffice-icon-theme-oxygen: 5.0.1.2-1.1 With this the expanders _are_ missing. If I change this to: Libreoffice Icon size and style: Small / Breeze libreoffice-icon-theme-breeze: 5.0.1.2-1.1 The expanders are correctly shown. I decided to try other LO icon themes - the ones currently installed were: libreoffice-icon-theme-breeze libreoffice-icon-theme-hicontrast libreoffice-icon-theme-oxygen Using hicontrast the expanders are correctly shown. I then installed Tango libreoffice-icon-theme-tango: 5.0.1.2-1.1 The expanders are correctly shown. At this point I switched back to: Libreoffice Icon size and style: Small / Oxygen The expanders _are now_ correctly shown when using LO Oxygen icons I then un-installed libreoffice-icon-theme-tango: 5.0.1.2-1.1 The expanders are now again missing when using LO Oxygen icons. Now I'm guessing that what is happening is that the expander icon is actually missing from the (LO) Oxygen icon theme, and it falls back to, or inherits Tango. For the moment I will simply install, but not 'use' the Tango theme. If you remove any libreoffice-icon-themes other than: libreoffice-icon-theme-breeze libreoffice-icon-theme-hicontrast libreoffice-icon-theme-oxygen then I expect you will be able to duplicate this bug. Whether it's worth pursuing is debatable :) Many thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94050] Printing in rc 5.0.2.1. not in all colors and impress handout no background printed
https://bugs.documentfoundation.org/show_bug.cgi?id=94050 --- Comment #4 from Maarten--- Created attachment 118965 --> https://bugs.documentfoundation.org/attachment.cgi?id=118965=edit actual print output om impress and screenshot of preview pane -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/dbui/mmlayoutpage.cxx |7 +++ sw/source/ui/dbui/mmlayoutpage.hxx |2 +- sw/source/ui/envelp/labelexp.cxx|5 ++--- sw/source/ui/envelp/swuilabimp.hxx |2 +- sw/source/ui/index/cntex.cxx|3 +-- sw/source/ui/index/cnttab.cxx |2 +- sw/source/ui/misc/glossary.cxx |5 ++--- sw/source/uibase/inc/glossary.hxx |2 +- sw/source/uibase/inc/swuicnttab.hxx |2 +- sw/source/uibase/inc/unotools.hxx |4 ++-- sw/source/uibase/utlui/unotools.cxx |4 ++-- 11 files changed, 17 insertions(+), 21 deletions(-) New commits: commit b2cd2e79b6fc152072d0f1e46b5c4ed2d489c09c Author: Noel GrandinDate: Tue Sep 22 22:00:22 2015 +0200 convert Link<> to typed Change-Id: If1e53fee4b39daed44632b2395ddb42064c698fb Reviewed-on: https://gerrit.libreoffice.org/18800 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/dbui/mmlayoutpage.cxx b/sw/source/ui/dbui/mmlayoutpage.cxx index 0662cde..678db18 100644 --- a/sw/source/ui/dbui/mmlayoutpage.cxx +++ b/sw/source/ui/dbui/mmlayoutpage.cxx @@ -118,7 +118,7 @@ SwMailMergeLayoutPage::SwMailMergeLayoutPage( SwMailMergeWizard* _pParent) : uno::Reference< frame::XStorable > xStore( pView->GetDocShell()->GetModel(), uno::UNO_QUERY); xStore->storeToURL( m_sExampleURL, aValues ); -Link<> aLink(LINK(this, SwMailMergeLayoutPage, PreviewLoadedHdl_Impl)); +Link aLink(LINK(this, SwMailMergeLayoutPage, PreviewLoadedHdl_Impl)); m_pExampleFrame = new SwOneExampleFrame( *m_pExampleContainerWIN, EX_SHOW_DEFAULT_PAGE, , _sExampleURL ); @@ -619,7 +619,7 @@ void SwMailMergeLayoutPage::InsertGreeting(SwWrtShell& rShell, SwMailMergeConfig OSL_ENSURE(0 == rShell.GetTableFormat(), "What to do with a table here?"); } -IMPL_LINK_NOARG(SwMailMergeLayoutPage, PreviewLoadedHdl_Impl) +IMPL_LINK_NOARG_TYPED(SwMailMergeLayoutPage, PreviewLoadedHdl_Impl, SwOneExampleFrame&, void) { m_pExampleContainerWIN->Show(true); @@ -633,7 +633,7 @@ IMPL_LINK_NOARG(SwMailMergeLayoutPage, PreviewLoadedHdl_Impl) m_pExampleWrtShell = pDocShell->GetWrtShell(); OSL_ENSURE(m_pExampleWrtShell, "No SwWrtShell found!"); if(!m_pExampleWrtShell) -return 0; +return; SwMailMergeConfigItem& rConfigItem = m_pWizard->GetConfigItem(); if(rConfigItem.IsAddressBlock()) @@ -657,7 +657,6 @@ IMPL_LINK_NOARG(SwMailMergeLayoutPage, PreviewLoadedHdl_Impl) m_pExampleWrtShell->GetCurPageDesc()).GetMaster().GetFrmSize(); m_pLeftMF->SetMax(rPageSize.GetWidth() - DEFAULT_LEFT_DISTANCE); m_pTopMF->SetMax(rPageSize.GetHeight() - DEFAULT_TOP_DISTANCE); -return 0; } IMPL_LINK(SwMailMergeLayoutPage, ZoomHdl_Impl, ListBox*, pBox) diff --git a/sw/source/ui/dbui/mmlayoutpage.hxx b/sw/source/ui/dbui/mmlayoutpage.hxx index fcd387e..2b46221 100644 --- a/sw/source/ui/dbui/mmlayoutpage.hxx +++ b/sw/source/ui/dbui/mmlayoutpage.hxx @@ -65,7 +65,7 @@ class SwMailMergeLayoutPage : public svt::OWizardPage ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > m_xViewProperties; -DECL_LINK(PreviewLoadedHdl_Impl, void*); +DECL_LINK_TYPED(PreviewLoadedHdl_Impl, SwOneExampleFrame&, void); DECL_LINK(ZoomHdl_Impl, ListBox*); DECL_LINK(ChangeAddressHdl_Impl, void *); DECL_LINK_TYPED(GreetingsHdl_Impl, Button*, void); diff --git a/sw/source/ui/envelp/labelexp.cxx b/sw/source/ui/envelp/labelexp.cxx index 346349a..206d935 100644 --- a/sw/source/ui/envelp/labelexp.cxx +++ b/sw/source/ui/envelp/labelexp.cxx @@ -38,7 +38,7 @@ using namespace ::comphelper; void SwVisitingCardPage::InitFrameControl() { -Link<> aLink(LINK(this, SwVisitingCardPage, FrameControlInitializedHdl)); +Link aLink(LINK(this, SwVisitingCardPage, FrameControlInitializedHdl)); m_pExampleWIN->Show(); pExampleFrame = new SwOneExampleFrame( *m_pExampleWIN, EX_SHOW_BUSINESS_CARDS, ); @@ -101,7 +101,7 @@ void SwVisitingCardPage::InitFrameControl() } } -IMPL_LINK_NOARG(SwVisitingCardPage, FrameControlInitializedHdl) +IMPL_LINK_NOARG_TYPED(SwVisitingCardPage, FrameControlInitializedHdl, SwOneExampleFrame&, void) { SvTreeListEntry* pSel = m_pAutoTextLB->FirstSelected(); OUString sEntry; @@ -130,7 +130,6 @@ IMPL_LINK_NOARG(SwVisitingCardPage, FrameControlInitializedHdl) UpdateFields(); } } -return 0; } IMPL_LINK_TYPED( SwVisitingCardPage, AutoTextSelectTreeListBoxHdl, SvTreeListBox*, pBox, void ) diff --git a/sw/source/ui/envelp/swuilabimp.hxx b/sw/source/ui/envelp/swuilabimp.hxx index 4167c43..6dacd6b 100644 --- a/sw/source/ui/envelp/swuilabimp.hxx +++ b/sw/source/ui/envelp/swuilabimp.hxx @@ -99,7 +99,7 @@ class
[Libreoffice-commits] core.git: sw/source
sw/source/ui/dbui/mmmergepage.cxx |3 +-- sw/source/ui/dbui/mmmergepage.hxx |2 +- sw/source/ui/fldui/fldfunc.cxx | 13 - sw/source/ui/fldui/fldfunc.hxx |5 +++-- sw/source/uibase/cctrl/actctrl.cxx |2 +- sw/source/uibase/inc/actctrl.hxx |4 ++-- 6 files changed, 16 insertions(+), 13 deletions(-) New commits: commit 473a8e2ccad0f58430c469ac3366153db033ac25 Author: Noel GrandinDate: Wed Sep 23 09:39:17 2015 +0200 convert Link<> to typed Change-Id: Ie31b7f6ed89d684b6ec0ac8e6a144ef6024ba1d2 Reviewed-on: https://gerrit.libreoffice.org/18801 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/dbui/mmmergepage.cxx b/sw/source/ui/dbui/mmmergepage.cxx index ea35577..17cdfc7 100644 --- a/sw/source/ui/dbui/mmmergepage.cxx +++ b/sw/source/ui/dbui/mmmergepage.cxx @@ -95,10 +95,9 @@ IMPL_LINK_NOARG_TYPED(SwMailMergeMergePage, FindHdl_Impl, Button*, void) } } -IMPL_LINK_NOARG(SwMailMergeMergePage, EnteredFindStringHdl_Impl) +IMPL_LINK_NOARG_TYPED(SwMailMergeMergePage, EnteredFindStringHdl_Impl, ReturnActionEdit&, void) { m_pFindPB->GetClickHdl().Call(m_pFindPB); -return 0; } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/ui/dbui/mmmergepage.hxx b/sw/source/ui/dbui/mmmergepage.hxx index 30d8d99..6f3800c 100644 --- a/sw/source/ui/dbui/mmmergepage.hxx +++ b/sw/source/ui/dbui/mmmergepage.hxx @@ -43,7 +43,7 @@ class SwMailMergeMergePage : public svt::OWizardPage DECL_LINK_TYPED(EditDocumentHdl_Impl, Button*, void); DECL_LINK_TYPED(FindHdl_Impl, Button*, void); -DECL_LINK(EnteredFindStringHdl_Impl, void*); +DECL_LINK_TYPED(EnteredFindStringHdl_Impl, ReturnActionEdit&, void); public: SwMailMergeMergePage( SwMailMergeWizard* _pParent); diff --git a/sw/source/ui/fldui/fldfunc.cxx b/sw/source/ui/fldui/fldfunc.cxx index ad3e4f9..8836017 100644 --- a/sw/source/ui/fldui/fldfunc.cxx +++ b/sw/source/ui/fldui/fldfunc.cxx @@ -168,7 +168,7 @@ void SwFieldFuncPage::Reset(const SfxItemSet* ) m_pSelectionLB->SetDoubleClickHdl (LINK(this, SwFieldFuncPage, InsertMacroHdl)); m_pFormatLB->SetDoubleClickHdl (LINK(this, SwFieldFuncPage, ListBoxInsertHdl)); m_pMacroBT->SetClickHdl(LINK(this, SwFieldFuncPage, MacroHdl)); -Link
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/cctrl/actctrl.cxx |2 +- sw/source/uibase/inc/actctrl.hxx |4 ++-- sw/source/uibase/inc/navipi.hxx|2 +- sw/source/uibase/utlui/navipi.cxx |7 +++ 4 files changed, 7 insertions(+), 8 deletions(-) New commits: commit 28329d7cacdf8c37a9c1863530615e1b9cfa6935 Author: Noel GrandinDate: Tue Sep 22 21:53:44 2015 +0200 convert Link<> to typed Change-Id: I9a7f38b2babf6c599f0c2709b32ecb8083fd32cc Reviewed-on: https://gerrit.libreoffice.org/18799 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/uibase/cctrl/actctrl.cxx b/sw/source/uibase/cctrl/actctrl.cxx index a0f1bd7..af79651 100644 --- a/sw/source/uibase/cctrl/actctrl.cxx +++ b/sw/source/uibase/cctrl/actctrl.cxx @@ -23,7 +23,7 @@ void NumEditAction::Action() { -aActionLink.Call( this ); +aActionLink.Call( *this ); } bool NumEditAction::Notify( NotifyEvent& rNEvt ) diff --git a/sw/source/uibase/inc/actctrl.hxx b/sw/source/uibase/inc/actctrl.hxx index 5412103..dee1cc8 100644 --- a/sw/source/uibase/inc/actctrl.hxx +++ b/sw/source/uibase/inc/actctrl.hxx @@ -25,7 +25,7 @@ // numerical input class SW_DLLPUBLIC NumEditAction: public NumericField { -Link<> aActionLink; +Link aActionLink; protected: void Action(); @@ -34,7 +34,7 @@ public: NumEditAction( vcl::Window* pParent, const ResId& rResId ) : NumericField(pParent, rResId) {} -voidSetActionHdl( const Link<>& rLink ) { aActionLink = rLink;} +voidSetActionHdl( const Link & rLink ) { aActionLink = rLink;} }; // call a link when KEY_RETURN is pressed diff --git a/sw/source/uibase/inc/navipi.hxx b/sw/source/uibase/inc/navipi.hxx index cb5dae7..59b6d4c8 100644 --- a/sw/source/uibase/inc/navipi.hxx +++ b/sw/source/uibase/inc/navipi.hxx @@ -105,7 +105,7 @@ class SwNavigationPI : public vcl::Window, DECL_LINK_TYPED( ToolBoxSelectHdl, ToolBox *, void ); DECL_LINK_TYPED( ToolBoxClickHdl, ToolBox *, void ); DECL_LINK_TYPED( ToolBoxDropdownClickHdl, ToolBox*, void ); -DECL_LINK( EditAction, NumEditAction * ); +DECL_LINK_TYPED( EditAction, NumEditAction&, void ); DECL_LINK( EditGetFocus, NumEditAction * ); DECL_LINK_TYPED( DoneLink, SfxPoolItem *, void ); DECL_LINK_TYPED( MenuSelectHdl, Menu *, bool ); diff --git a/sw/source/uibase/utlui/navipi.cxx b/sw/source/uibase/utlui/navipi.cxx index d20b7e9..8386674 100644 --- a/sw/source/uibase/utlui/navipi.cxx +++ b/sw/source/uibase/utlui/navipi.cxx @@ -454,18 +454,17 @@ void SwNavHelpToolBox::RequestHelp( const HelpEvent& rHEvt ) // Action-Handler Edit: // Switches to the page if the structure view is not turned on. -IMPL_LINK( SwNavigationPI, EditAction, NumEditAction *, pEdit ) +IMPL_LINK_TYPED( SwNavigationPI, EditAction, NumEditAction&, rEdit, void ) { SwView *pView = GetCreateView(); if (pView) { if(aPageChgIdle.IsActive()) aPageChgIdle.Stop(); -pCreateView->GetWrtShell().GotoPage((sal_uInt16)pEdit->GetValue(), true); +pCreateView->GetWrtShell().GotoPage((sal_uInt16)rEdit.GetValue(), true); pCreateView->GetEditWin().GrabFocus(); pCreateView->GetViewFrame()->GetBindings().Invalidate(FN_STAT_PAGE); } -return 0; } // If the page can be set here, the maximum is set. @@ -1250,7 +1249,7 @@ IMPL_LINK_NOARG_TYPED(SwNavigationPI, ChangePageHdl, Idle *, void) { if (!IsDisposed()) { -EditAction(()); +EditAction(GetPageEdit()); GetPageEdit().GrabFocus(); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/funcpage.hxx | 28 1 file changed, 12 insertions(+), 16 deletions(-) New commits: commit 5d5465057292676e5b0ce213b7172ce0b576d32e Author: Noel GrandinDate: Wed Sep 23 10:20:19 2015 +0200 remove unused Link<> field Change-Id: Iea23f5edd60d5ac214afa89d051cd4f900564343 Reviewed-on: https://gerrit.libreoffice.org/18804 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/funcpage.hxx b/sc/source/ui/inc/funcpage.hxx index 1e99143..fcf2638 100644 --- a/sc/source/ui/inc/funcpage.hxx +++ b/sc/source/ui/inc/funcpage.hxx @@ -52,7 +52,6 @@ class ScFuncPage : public TabPage { private: -Link<> aDoubleClickLink; Link<> aSelectionLink; FixedText aFtCategory; ListBox aLbCategory; @@ -72,24 +71,21 @@ protected: public: -ScFuncPage( vcl::Window* pParent); + ScFuncPage( vcl::Window* pParent); -voidSetCategory(sal_uInt16 nCat); -voidSetFunction(sal_uInt16 nFunc); -voidSetFocus(); -sal_uInt16 GetCategory(); -sal_uInt16 GetFunction(); -sal_uInt16 GetFunctionEntryCount(); +void SetCategory(sal_uInt16 nCat); +void SetFunction(sal_uInt16 nFunc); +void SetFocus(); +sal_uInt16GetCategory(); +sal_uInt16GetFunction(); +sal_uInt16GetFunctionEntryCount(); -sal_uInt16 GetFuncPos(const ScFuncDesc*); -const ScFuncDesc* GetFuncDesc( sal_uInt16 nPos ) const; -OUStringGetSelFunctionName() const; +sal_uInt16GetFuncPos(const ScFuncDesc*); +const ScFuncDesc* GetFuncDesc( sal_uInt16 nPos ) const; +OUString GetSelFunctionName() const; -voidSetDoubleClickHdl( const Link<>& rLink ) { aDoubleClickLink = rLink; } -const Link<>& GetDoubleClickHdl() const { return aDoubleClickLink; } - -voidSetSelectHdl( const Link<>& rLink ) { aSelectionLink = rLink; } -const Link<>& GetSelectHdl() const { return aSelectionLink; } +void SetSelectHdl( const Link<>& rLink ) { aSelectionLink = rLink; } +const Link<>& GetSelectHdl() const { return aSelectionLink; } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94460] New: External component has thrown an exception, Bootstrap.Bootstrap(), .NET 4 UNO CLI, LibreOffice 5
https://bugs.documentfoundation.org/show_bug.cgi?id=94460 Bug ID: 94460 Summary: External component has thrown an exception, Bootstrap.Bootstrap(), .NET 4 UNO CLI, LibreOffice 5 Product: LibreOffice Version: 5.0.0.5 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: sdk Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tahirve...@gmail.com With the following code: static void Main() { try { var context = uno.util.Bootstrap.bootstrap(); } catch (Exception ex) { Console.WriteLine(ex.toString()); } } I can start Writer of LibreOffice. This works fine with Version 4.4.4 but after installing version 5 and with new SDK, Bootstrap.bootstrap() throws the exception: "External component has thrown an exception" Has anyone faced the same problem or some solution? (.NET 4.0, Windows 7 64-bit, LibreOffice 5.0 Lite) Stack Trace System.Runtime.InteropServices.SEHException (0x80004005): Eine externe Komponente hat eine Ausnahme ausgelöst. bei cppu.bootstrap(Reference* ) bei uno.util.Bootstrap.bootstrap() -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94460] External component has thrown an exception, Bootstrap.Bootstrap(), .NET 4 UNO CLI, LibreOffice 5
https://bugs.documentfoundation.org/show_bug.cgi?id=94460 Tahir Nazirchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Tahir Nazir --- I have tried to set UNO_PATH to LibreOffice 5 folder but still it won't work. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93115] FILESAVE: When a cell contains superscript or subscript, saving as xlsx causes all the text to be superscript/subscript
https://bugs.documentfoundation.org/show_bug.cgi?id=93115 raalchanged: What|Removed |Added CC||r...@post.cz Whiteboard||bibisected --- Comment #4 from raal --- 8e51a1a65893ccebe8650345883836f200513215 is the first bad commit commit 8e51a1a65893ccebe8650345883836f200513215 Author: Norbert Thiebaud Date: Thu Jun 4 08:47:59 2015 -0500 source sha:cc5baa41fee257498661320e24169bb3f05391fb source sha:cc5baa41fee257498661320e24169bb3f05391fb source sha:7a66dbe982623be620ad6ac426fe689a434e5f51 source sha:3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173 source sha:a878ffae876610bf7522d79685b6e07191a88214 source sha:511499b3ba08024e3d6853f096ad1d96f96b216d source sha:27491725a689d98e6b327bd1faaf4258b923783f source sha:936a49646738452f7331ed9a47ac015db9ee7295 source sha:ab81e3bff2a1844be67209bc8947d539edbaf8e6 source sha:e1ebdf38969a17af9453f674c81663187411597d source sha:4c665178f49952138835fd318edef8978ac806e3 source sha:3fd5f8919ec2256c70ff26c14cb9f8065c5cb2f1 source sha:0c129aa3df35a056ec739579002b2fc958fb3a48 source sha:4906ecb8210a8cf1b7befcfde7f867bed5d6ce43 source sha:50128d02c2883d04e12b8e6857aa1b8bef479b08 source sha:ac55ac11f66c9b8b44dc8281d6236d9e6d68ddd1 source sha:e4d4ee607efc8ec0e2284f661fd32f0e2ad99e76 source sha:23c0e00b50f7fae7a82134ef064eabf9514a941b source sha:d425cc7c73a8ad3d693216742d75b0f7f1bf5f89 source sha:0c3b96790da88fb22b5e932f9a4abaeb330b610a source sha:5ffe469a9e9c5b86dbdcbe556d23cd789a9f3a55 source sha:8865ed2efecd03722d10e522265f31c99b13b2bb source sha:686034d5ced19ea2a16127ba3f5af49e7f9e1b35 source sha:0f8f60f2bef959389d45b2dd0a535cd8848ed8e9 :04 04 9e7155375a28a9f4df4fff010ae7d730fea5e305 2bcd67321dca9f0639b5c9ef1dcf24b67a6acead M instdir git bisect log # bad: [575cd25f0560684895018d8fcfb1818dd4dd1c9b] source sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65 # good: [f449493ae11ac76cc7396bddeaa624a60c565936] source sha:57d6b92b69a31260dea0d84fcd1fc5866ada7adb git bisect start 'libreoffice-5-0-branch-point' 'oldest' # good: [da12357c491a0dce5acc0bd1f00c26f89d8f20e6] source sha:c1b9402d49a7cd4bec383f28d397d9d89541f0e0 git bisect good da12357c491a0dce5acc0bd1f00c26f89d8f20e6 # good: [2783cac5d1f18f44ce31f52eb7ae2f0ea17d0c96] source sha:5d7a203bdae1940e4846c4c42f5d733e4ffa4160 git bisect good 2783cac5d1f18f44ce31f52eb7ae2f0ea17d0c96 # good: [c6b55917df3df447007dbb29dd84f24d1203cfb3] source sha:5b8acf459e4a6728ea656e7abd5dfb08ad2ae345 git bisect good c6b55917df3df447007dbb29dd84f24d1203cfb3 # good: [ac46cb21db25e4b49f28bbe57f5846dbca57e486] source sha:dbf1e124c7fef7cae5392959ab6a697a3a89c609 git bisect good ac46cb21db25e4b49f28bbe57f5846dbca57e486 # bad: [eece862e921f0369dbf20571080344aa56577fd0] source sha:6fbda0905d4e721392038bfad9e173e180f788ee git bisect bad eece862e921f0369dbf20571080344aa56577fd0 # bad: [c0741086019d0a6a28865a6b29edbd6e149cc034] source sha:182c202d6d3fd9422bf3628a2fa4ccd7ab955c5e git bisect bad c0741086019d0a6a28865a6b29edbd6e149cc034 # bad: [168b1c2ab59630bb290e04123188b68ad4ed0af4] source sha:ceac38106de4f2657e854d5e1d657d6df9321032 git bisect bad 168b1c2ab59630bb290e04123188b68ad4ed0af4 # bad: [66933de7b1b8079f6906a517daa62f96e9b52388] source sha:c74631a0ffd32d3e0794fdd861582ca5b1d55b45 git bisect bad 66933de7b1b8079f6906a517daa62f96e9b52388 # bad: [343482dc0497e11a7237168d4ede17803cc1786e] source sha:70c4355ffd494dffb59818c225b4a3343476e9a6 git bisect bad 343482dc0497e11a7237168d4ede17803cc1786e # skip: [383068b4dde6bac406b0b37b06df7a204ec12b93] source sha:7ac254048a5698e046bbb7deccd171cb3777af61 git bisect skip 383068b4dde6bac406b0b37b06df7a204ec12b93 # good: [6d76639463289ac123a7c83935ed708cbbc4b1f8] source sha:667910530deb61563d4812db0995da94e25220e5 git bisect good 6d76639463289ac123a7c83935ed708cbbc4b1f8 # good: [2b9a67625c131d4116e9025ae6b13a86a3642121] source sha:c975bee3a7db0d318d1e460312be2922a09c7cea git bisect good 2b9a67625c131d4116e9025ae6b13a86a3642121 # bad: [8e51a1a65893ccebe8650345883836f200513215] source sha:cc5baa41fee257498661320e24169bb3f05391fb git bisect bad 8e51a1a65893ccebe8650345883836f200513215 # first bad commit: [8e51a1a65893ccebe8650345883836f200513215] source sha:cc5baa41fee257498661320e24169bb3f05391fb -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/acredlin.hxx | 20 ++-- sc/source/ui/inc/reffact.hxx |2 +- sc/source/ui/inc/simpref.hxx | 10 +- sc/source/ui/inc/tabvwsh.hxx |2 +- sc/source/ui/miscdlgs/acredlin.cxx |3 +-- sc/source/ui/miscdlgs/simpref.cxx |2 +- sc/source/ui/view/reffact.cxx |2 +- sc/source/ui/view/tabvwsh4.cxx |3 +-- 8 files changed, 21 insertions(+), 23 deletions(-) New commits: commit 9d55221ffeb4ca408e34a7cc129fa2dfa0b9149a Author: Noel GrandinDate: Wed Sep 23 10:48:47 2015 +0200 convert Link<> to typed Change-Id: Ibaab770dd369d07aeda70b5d5c6ff514350edacb Reviewed-on: https://gerrit.libreoffice.org/18807 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/acredlin.hxx b/sc/source/ui/inc/acredlin.hxx index 9ee1f8c..3516edc 100644 --- a/sc/source/ui/inc/acredlin.hxx +++ b/sc/source/ui/inc/acredlin.hxx @@ -99,19 +99,19 @@ private: DECL_LINK_TYPED( FilterHandle, SvxTPFilter*, void ); DECL_LINK_TYPED( RefHandle, SvxTPFilter*, void ); -DECL_LINK_TYPED( RejectHandle, SvxTPView*, void); -DECL_LINK_TYPED( AcceptHandle, SvxTPView*, void); -DECL_LINK_TYPED( RejectAllHandle, SvxTPView*, void); -DECL_LINK_TYPED( AcceptAllHandle, SvxTPView*, void); -DECL_LINK_TYPED( ExpandingHandle, SvTreeListBox*, bool); -DECL_LINK_TYPED( SelectHandle, SvTreeListBox*, void); -DECL_LINK( RefInfoHandle, OUString*); +DECL_LINK_TYPED( RejectHandle, SvxTPView*, void ); +DECL_LINK_TYPED( AcceptHandle, SvxTPView*, void ); +DECL_LINK_TYPED( RejectAllHandle, SvxTPView*, void ); +DECL_LINK_TYPED( AcceptAllHandle, SvxTPView*, void ); +DECL_LINK_TYPED( ExpandingHandle, SvTreeListBox*, bool ); +DECL_LINK_TYPED( SelectHandle, SvTreeListBox*, void ); +DECL_LINK_TYPED( RefInfoHandle, const OUString*, void ); DECL_LINK_TYPED( UpdateSelectionHdl, Idle*, void ); -DECL_LINK_TYPED( ChgTrackModHdl, ScChangeTrack&, void); -DECL_LINK_TYPED( CommandHdl, SvSimpleTable*, void); +DECL_LINK_TYPED( ChgTrackModHdl, ScChangeTrack&, void ); +DECL_LINK_TYPED( CommandHdl, SvSimpleTable*, void ); DECL_LINK_TYPED( ReOpenTimerHdl, Idle*, void ); -DECL_LINK_TYPED( ColCompareHdl, const SvSortData*, sal_Int32); +DECL_LINK_TYPED( ColCompareHdl, const SvSortData*, sal_Int32 ); protected: diff --git a/sc/source/ui/inc/reffact.hxx b/sc/source/ui/inc/reffact.hxx index 83a29f6..e3e8bcc 100644 --- a/sc/source/ui/inc/reffact.hxx +++ b/sc/source/ui/inc/reffact.hxx @@ -161,7 +161,7 @@ class ScSimpleRefDlgWrapper: public SfxChildWindow static void SetDefaultPosSize(Point aPos, Size aSize, bool bSet = true); voidSetRefString(const OUString& rStr); -voidSetCloseHdl( const Link<>& rLink ); +voidSetCloseHdl( const Link& rLink ); voidSetUnoLinks( const Link<>& rDone, const Link<>& rAbort, const Link<>& rChange ); voidSetFlags( bool bCloseOnButtonUp, bool bSingleCell, bool bMultiSelection ); diff --git a/sc/source/ui/inc/simpref.hxx b/sc/source/ui/inc/simpref.hxx index 47c3202..d02a4f1 100644 --- a/sc/source/ui/inc/simpref.hxx +++ b/sc/source/ui/inc/simpref.hxx @@ -35,7 +35,7 @@ class ScDocument; class ScSimpleRefDlg: public ScAnyRefDlg { private: -Link<> aCloseHdl; +Link aCloseHdl; Link<> aDoneHdl; Link<> aAbortedHdl; Link<> aChangeHdl; @@ -65,7 +65,7 @@ protected: public: ScSimpleRefDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent); -virtual ~ScSimpleRefDlg(); +virtual~ScSimpleRefDlg(); virtual voiddispose() SAL_OVERRIDE; virtual voidSetReference( const ScRange& rRef, ScDocument* pDoc ) SAL_OVERRIDE; @@ -76,10 +76,10 @@ public: voidStartRefInput(); -void SetRefString(const OUString ); -virtual void FillInfo(SfxChildWinInfo&) const SAL_OVERRIDE; +voidSetRefString(const OUString ); +virtual voidFillInfo(SfxChildWinInfo&) const SAL_OVERRIDE; -voidSetCloseHdl( const Link<>& rLink ); +voidSetCloseHdl( const Link& rLink ); voidSetUnoLinks( const Link<>& rDone, const Link<>& rAbort, const Link<>& rChange ); diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index a560d52..521f2fa 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -183,7 +183,7 @@ private: void DoReadUserDataSequence( const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& rSettings ); -DECL_LINK( SimpleRefClose, void* ); +
[Libreoffice-commits] core.git: forms/source
forms/source/richtext/richtextimplcontrol.cxx |3 +-- forms/source/richtext/richtextimplcontrol.hxx |2 +- forms/source/richtext/richtextviewport.hxx|4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 146fe08382999faf77d268a24ba3ef3bfea18a7e Author: Noel GrandinDate: Wed Sep 23 09:55:11 2015 +0200 convert Link<> to typed Change-Id: Ica5093e29630d6d6974ccba034609129887ac85b Reviewed-on: https://gerrit.libreoffice.org/18802 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/forms/source/richtext/richtextimplcontrol.cxx b/forms/source/richtext/richtextimplcontrol.cxx index 32b512a..2bece2f 100644 --- a/forms/source/richtext/richtextimplcontrol.cxx +++ b/forms/source/richtext/richtextimplcontrol.cxx @@ -311,10 +311,9 @@ namespace frm } -IMPL_LINK_NOARG( RichTextControlImpl, OnInvalidateAllAttributes ) +IMPL_LINK_NOARG_TYPED( RichTextControlImpl, OnInvalidateAllAttributes, LinkParamNone*, void ) { updateAllAttributes(); -return 0L; } diff --git a/forms/source/richtext/richtextimplcontrol.hxx b/forms/source/richtext/richtextimplcontrol.hxx index 48087c0..7d0f348 100644 --- a/forms/source/richtext/richtextimplcontrol.hxx +++ b/forms/source/richtext/richtextimplcontrol.hxx @@ -173,7 +173,7 @@ namespace frm virtual void EditEngineStatusChanged( const EditStatus& _rStatus ) SAL_OVERRIDE; private: -DECL_LINK( OnInvalidateAllAttributes, void* ); +DECL_LINK_TYPED( OnInvalidateAllAttributes, LinkParamNone*, void ); DECL_LINK_TYPED( OnHScroll, ScrollBar*, void ); DECL_LINK_TYPED( OnVScroll, ScrollBar*, void ); }; diff --git a/forms/source/richtext/richtextviewport.hxx b/forms/source/richtext/richtextviewport.hxx index f67025e..f6f380e 100644 --- a/forms/source/richtext/richtextviewport.hxx +++ b/forms/source/richtext/richtextviewport.hxx @@ -29,7 +29,7 @@ namespace frm { private: EditView* m_pView; -Link<> m_aInvalidationHandler; +Link m_aInvalidationHandler; boolm_bHideInactiveSelection; public: @@ -37,7 +37,7 @@ namespace frm voidsetView( EditView& _rView ); -inline voidsetAttributeInvalidationHandler( const Link<>& _rHandler ) { m_aInvalidationHandler = _rHandler; } +inline voidsetAttributeInvalidationHandler( const Link & _rHandler ) { m_aInvalidationHandler = _rHandler; } voidSetHideInactiveSelection( bool _bHide ); boolGetHideInactiveSelection() const { return m_bHideInactiveSelection; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: rsc/inc rsc/source
rsc/inc/rscclobj.hxx |8 +++ rsc/inc/rsctree.hxx |2 - rsc/source/parser/rscdb.cxx | 48 +-- rsc/source/tools/rsctree.cxx |4 +-- 4 files changed, 31 insertions(+), 31 deletions(-) New commits: commit 00a6992b97a806b183e368d412508801dc632f8b Author: Noel GrandinDate: Wed Sep 23 10:17:52 2015 +0200 convert Link<> to typed Change-Id: I80bd798ea5d36fa94d6b3348be713dbe2cbeab14 Reviewed-on: https://gerrit.libreoffice.org/18803 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/rsc/inc/rscclobj.hxx b/rsc/inc/rscclobj.hxx index 5eaedb6..2509e57 100644 --- a/rsc/inc/rscclobj.hxx +++ b/rsc/inc/rscclobj.hxx @@ -38,8 +38,8 @@ public: ObjNode( const RscId & rId, CLASS_DATA pData, sal_uLong lKey ); ObjNode * DelObjNode( RscTop * pClass, sal_uLong lFileKey ); sal_uInt32 GetId() const SAL_OVERRIDE; -RscId GetRscId(){ return aRscId; } -sal_uLong GetFileKey(){ return lFileKey; }; +RscId GetRscId() const { return aRscId; } +sal_uLong GetFileKey() const { return lFileKey; }; ObjNode*Search( const RscId ) const //< search the index in the b-tree { return static_cast(IdNode::Search( rName )); @@ -49,7 +49,7 @@ public: { return IdNode::Insert( static_cast(pTN) ); } -CLASS_DATA GetRscObj() //< get the Object from this Node +CLASS_DATA GetRscObj() const//< get the Object from this Node { return pRscObj; @@ -79,7 +79,7 @@ public: // insert new node in b-tree pObjBiTree ObjNode * GetObjNode( const RscId ); -ObjNode * GetObjNode() +ObjNode * GetObjNode() const { // hole pObjBiTree return pObjBiTree; diff --git a/rsc/inc/rsctree.hxx b/rsc/inc/rsctree.hxx index f2f6ac2..209c422 100644 --- a/rsc/inc/rsctree.hxx +++ b/rsc/inc/rsctree.hxx @@ -43,7 +43,7 @@ protected: NameNode* ChangeBTreeDLList(); public: -voidEnumNodes( Link<> aLink ) const; +voidEnumNodes( Link aLink ) const; NameNode* Left() const { return pLeft; } NameNode* Right() const{ return pRight; } NameNode* Search( const NameNode * pName ) const; diff --git a/rsc/source/parser/rscdb.cxx b/rsc/source/parser/rscdb.cxx index 42aa6da..627e549 100644 --- a/rsc/source/parser/rscdb.cxx +++ b/rsc/source/parser/rscdb.cxx @@ -349,8 +349,8 @@ private: sal_uLong lFileKey; // what source file RscTop *pClass; -DECL_LINK( CallBackWriteRc, ObjNode * ); -DECL_LINK( CallBackWriteSrc, ObjNode * ); +DECL_LINK_TYPED( CallBackWriteRc, const NameNode&, void ); +DECL_LINK_TYPED( CallBackWriteSrc, const NameNode&, void ); ERRTYPE WriteRc( RscTop * pCl, ObjNode * pRoot ) { @@ -369,30 +369,30 @@ public: void WriteRcFile( RscWriteRc & rMem, FILE * fOutput ); }; -IMPL_LINK( RscEnumerateObj, CallBackWriteRc, ObjNode *, pObjNode ) +IMPL_LINK_TYPED( RscEnumerateObj, CallBackWriteRc, const NameNode&, rNode, void ) { -RscWriteRc aMem( pTypCont->GetByteOrder() ); +const ObjNode& rObjNode = static_cast(rNode); +RscWriteRc aMem( pTypCont->GetByteOrder() ); -aError = pClass->WriteRcHeader( RSCINST( pClass, pObjNode->GetRscObj() ), +aError = pClass->WriteRcHeader( RSCINST( pClass, rObjNode.GetRscObj() ), aMem, pTypCont, - pObjNode->GetRscId(), 0, true ); + rObjNode.GetRscId(), 0, true ); if( aError.IsError() || aError.IsWarning() ) -pTypCont->pEH->Error( aError, pClass, pObjNode->GetRscId() ); +pTypCont->pEH->Error( aError, pClass, rObjNode.GetRscId() ); WriteRcFile( aMem, fOutput ); -return 0; } -IMPL_LINK( RscEnumerateObj, CallBackWriteSrc, ObjNode *, pObjNode ) +IMPL_LINK_TYPED( RscEnumerateObj, CallBackWriteSrc, const NameNode&, rNode, void ) { -if( pObjNode->GetFileKey() == lFileKey ) +const ObjNode& rObjNode = static_cast(rNode); +if( rObjNode.GetFileKey() == lFileKey ) { -pClass->WriteSrcHeader( RSCINST( pClass, pObjNode->GetRscObj() ), +pClass->WriteSrcHeader( RSCINST( pClass, rObjNode.GetRscObj() ), fOutput, pTypCont, 0, -pObjNode->GetRscId(), "" ); +rObjNode.GetRscId(), "" ); fprintf( fOutput, ";\n" ); } -return 0; } void RscEnumerateObj :: WriteRcFile( RscWriteRc & rMem, FILE * fOut ) @@ -445,8 +445,8 @@ class RscEnumerateRef private: RscTop *pRoot; -
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/optsolver.hxx | 10 +- sc/source/ui/miscdlgs/optsolver.cxx | 30 +- 2 files changed, 18 insertions(+), 22 deletions(-) New commits: commit b43226b9bd788bbd76d6b064eda62ebd71f71e68 Author: Noel GrandinDate: Wed Sep 23 10:25:10 2015 +0200 convert Link<> to typed Change-Id: If14f94ba6ba4732256747811ceb414b1424c4b1b Reviewed-on: https://gerrit.libreoffice.org/18805 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/inc/optsolver.hxx b/sc/source/ui/inc/optsolver.hxx index 44bf485..7706213 100644 --- a/sc/source/ui/inc/optsolver.hxx +++ b/sc/source/ui/inc/optsolver.hxx @@ -36,12 +36,12 @@ namespace com { namespace sun { namespace star { class ScCursorRefEdit : public formula::RefEdit { -Link<> maCursorUpLink; -Link<> maCursorDownLink; +Link maCursorUpLink; +Link maCursorDownLink; public: ScCursorRefEdit( vcl::Window* pParent, vcl::Window *pLabel ); -voidSetCursorLinks( const Link<>& rUp, const Link<>& rDown ); +voidSetCursorLinks( const Link & rUp, const Link & rDown ); protected: virtual voidKeyInput( const KeyEvent& rKEvt ) SAL_OVERRIDE; @@ -194,8 +194,8 @@ private: DECL_LINK( GetFocusHdl, Control* ); DECL_LINK( LoseFocusHdl, void* ); DECL_LINK_TYPED( ScrollHdl, ScrollBar*, void); -DECL_LINK( CursorUpHdl, ScCursorRefEdit* ); -DECL_LINK( CursorDownHdl, ScCursorRefEdit* ); +DECL_LINK_TYPED( CursorUpHdl, ScCursorRefEdit&, void ); +DECL_LINK_TYPED( CursorDownHdl, ScCursorRefEdit&, void ); DECL_LINK( CondModifyHdl, void* ); DECL_LINK( TargetModifyHdl, void* ); DECL_LINK( SelectHdl, void* ); diff --git a/sc/source/ui/miscdlgs/optsolver.cxx b/sc/source/ui/miscdlgs/optsolver.cxx index 94f2389..ace5271 100644 --- a/sc/source/ui/miscdlgs/optsolver.cxx +++ b/sc/source/ui/miscdlgs/optsolver.cxx @@ -135,7 +135,7 @@ ScCursorRefEdit::ScCursorRefEdit( vcl::Window* pParent, vcl::Window *pLabel ) VCL_BUILDER_FACTORY_ARGS(ScCursorRefEdit, nullptr) -void ScCursorRefEdit::SetCursorLinks( const Link<>& rUp, const Link<>& rDown ) +void ScCursorRefEdit::SetCursorLinks( const Link & rUp, const Link & rDown ) { maCursorUpLink = rUp; maCursorDownLink = rDown; @@ -149,9 +149,9 @@ void ScCursorRefEdit::KeyInput( const KeyEvent& rKEvt ) if ( !aCode.IsShift() && !aCode.IsMod1() && !aCode.IsMod2() && ( bUp || bDown ) ) { if ( bUp ) -maCursorUpLink.Call( this ); +maCursorUpLink.Call( *this ); else -maCursorDownLink.Call( this ); +maCursorDownLink.Call( *this ); } else formula::RefEdit::KeyInput( rKEvt ); @@ -408,8 +408,8 @@ void ScOptSolverDlg::Init(const ScAddress& rCursorPos) mpRightButton[nRow]->SetLoseFocusHdl( aLink ); } -Link<> aCursorUp = LINK( this, ScOptSolverDlg, CursorUpHdl ); -Link<> aCursorDown = LINK( this, ScOptSolverDlg, CursorDownHdl ); +Link aCursorUp = LINK( this, ScOptSolverDlg, CursorUpHdl ); +Link aCursorDown = LINK( this, ScOptSolverDlg, CursorDownHdl ); Link<> aCondModify = LINK( this, ScOptSolverDlg, CondModifyHdl ); for ( sal_uInt16 nRow = 0; nRow < EDIT_ROW_COUNT; ++nRow ) { @@ -736,9 +736,9 @@ IMPL_LINK_NOARG_TYPED(ScOptSolverDlg, ScrollHdl, ScrollBar*, void) mpEdActive->SetSelection( Selection( 0, SELECTION_MAX ) ); } -IMPL_LINK( ScOptSolverDlg, CursorUpHdl, ScCursorRefEdit*, pEdit ) +IMPL_LINK_TYPED( ScOptSolverDlg, CursorUpHdl, ScCursorRefEdit&, rEdit, void ) { -if ( pEdit == mpLeftEdit[0] || pEdit == mpRightEdit[0] ) +if ( == mpLeftEdit[0] || == mpRightEdit[0] ) { if ( nScrollPos > 0 ) { @@ -754,9 +754,9 @@ IMPL_LINK( ScOptSolverDlg, CursorUpHdl, ScCursorRefEdit*, pEdit ) formula::RefEdit* pFocus = NULL; for ( sal_uInt16 nRow = 1; nRow < EDIT_ROW_COUNT; ++nRow ) // second row or below: move focus { -if ( pEdit == mpLeftEdit[nRow] ) +if ( == mpLeftEdit[nRow] ) pFocus = mpLeftEdit[nRow-1]; -else if ( pEdit == mpRightEdit[nRow] ) +else if ( == mpRightEdit[nRow] ) pFocus = mpRightEdit[nRow-1]; } if (pFocus) @@ -765,13 +765,11 @@ IMPL_LINK( ScOptSolverDlg, CursorUpHdl, ScCursorRefEdit*, pEdit ) pFocus->GrabFocus(); } } - -return 0; } -IMPL_LINK( ScOptSolverDlg, CursorDownHdl, ScCursorRefEdit*, pEdit ) +IMPL_LINK_TYPED( ScOptSolverDlg, CursorDownHdl, ScCursorRefEdit&, rEdit, void ) { -if ( pEdit == mpLeftEdit[EDIT_ROW_COUNT-1] || pEdit ==
[Libreoffice-commits] core.git: sc/source
sc/source/ui/formdlg/dwfunctr.cxx |8 +++- sc/source/ui/formdlg/privsplt.cxx |2 +- sc/source/ui/inc/dwfunctr.hxx |2 +- sc/source/ui/inc/privsplt.hxx |4 ++-- 4 files changed, 7 insertions(+), 9 deletions(-) New commits: commit b198cb8f53fb442758e5abd3d271238a2d0c1b1c Author: Noel GrandinDate: Wed Sep 23 10:28:42 2015 +0200 convert Link<> to typed Change-Id: I282ea95e748ea52099a84fd3e8e8151e03ce25f9 Reviewed-on: https://gerrit.libreoffice.org/18806 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sc/source/ui/formdlg/dwfunctr.cxx b/sc/source/ui/formdlg/dwfunctr.cxx index 827371a..766575a 100644 --- a/sc/source/ui/formdlg/dwfunctr.cxx +++ b/sc/source/ui/formdlg/dwfunctr.cxx @@ -133,7 +133,7 @@ ScFunctionDockWin::ScFunctionDockWin( SfxBindings* pBindingsP, aDDFuncList->SetSelectHdl(aLink); aInsertButton->SetClickHdl(LINK( this, ScFunctionDockWin, SetSelectionClickHdl)); -Link<> a3Link=LINK( this, ScFunctionDockWin, SetSplitHdl); +Link a3Link=LINK( this, ScFunctionDockWin, SetSplitHdl); aPrivatSplit->SetCtrModifiedHdl(a3Link); StartListening( *pBindingsP, true ); @@ -978,9 +978,9 @@ IMPL_LINK_NOARG_TYPED( ScFunctionDockWin, SetSelectionHdl, ListBox&, void ) #* #/ -IMPL_LINK( ScFunctionDockWin, SetSplitHdl, ScPrivatSplit*, pCtrl ) +IMPL_LINK_TYPED( ScFunctionDockWin, SetSplitHdl, ScPrivatSplit&, rCtrl, void ) { -if (pCtrl == aPrivatSplit.get()) +if ( == aPrivatSplit.get()) { short nDeltaY=aPrivatSplit->GetDeltaY(); Size aFLSize=aFuncList->GetSizePixel(); @@ -994,8 +994,6 @@ IMPL_LINK( ScFunctionDockWin, SetSplitHdl, ScPrivatSplit*, pCtrl ) aFiFuncDesc->SetPosPixel(aFDTopLeft); aFiFuncDesc->SetSizePixel(aFDSize); } - -return 0; } void ScFunctionDockWin::ToggleFloatingMode() diff --git a/sc/source/ui/formdlg/privsplt.cxx b/sc/source/ui/formdlg/privsplt.cxx index ee8d6e3..72adb6d 100644 --- a/sc/source/ui/formdlg/privsplt.cxx +++ b/sc/source/ui/formdlg/privsplt.cxx @@ -221,7 +221,7 @@ short ScPrivatSplit::GetDeltaY() #/ void ScPrivatSplit::CtrModified() { -aCtrModifiedLink.Call( this ); +aCtrModifiedLink.Call( *this ); } void ScPrivatSplit::MoveSplitTo(Point aPos) diff --git a/sc/source/ui/inc/dwfunctr.hxx b/sc/source/ui/inc/dwfunctr.hxx index 9cad0bd..3749cb4 100644 --- a/sc/source/ui/inc/dwfunctr.hxx +++ b/sc/source/ui/inc/dwfunctr.hxx @@ -84,7 +84,7 @@ private: DECL_LINK_TYPED( SetSelectionHdl, ListBox&, void ); DECL_LINK_TYPED( SetSelectionClickHdl, Button*, void ); DECL_LINK( SelHdl, ListBox* ); -DECL_LINK(SetSplitHdl,ScPrivatSplit*); +DECL_LINK_TYPED( SetSplitHdl, ScPrivatSplit&, void ); DECL_LINK_TYPED( TimerHdl, Idle*, void ); protected: diff --git a/sc/source/ui/inc/privsplt.hxx b/sc/source/ui/inc/privsplt.hxx index a10c162..96cac4f 100644 --- a/sc/source/ui/inc/privsplt.hxx +++ b/sc/source/ui/inc/privsplt.hxx @@ -26,7 +26,7 @@ class ScPrivatSplit : public Control { private: -Link<> aCtrModifiedLink; +Link aCtrModifiedLink; boolaMovingFlag; Pointer aWinPointer; short nOldX; @@ -60,7 +60,7 @@ public: virtual voidStateChanged( StateChangedType nType ) SAL_OVERRIDE; virtual voidDataChanged( const DataChangedEvent& rDCEvt ) SAL_OVERRIDE; -voidSetCtrModifiedHdl( const Link<>& rLink ) { aCtrModifiedLink = rLink; } +voidSetCtrModifiedHdl( const Link & rLink ) { aCtrModifiedLink = rLink; } }; #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94461] Predefined Templates and Template Folders are not Deletable in Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=94461 Harald Koesterchanged: What|Removed |Added Version|unspecified |5.0.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94462] New: Dropdown menus flicker when OpenGL is enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=94462 Bug ID: 94462 Summary: Dropdown menus flicker when OpenGL is enabled Product: LibreOffice Version: 5.0.2.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hl...@gmx.at Created attachment 118966 --> https://bugs.documentfoundation.org/attachment.cgi?id=118966=edit Windows System Info When OpenGL is enabled, all the dropdown menus show first as a black for the fraction of a second before they are filled with the content. OS: Windows 10 64-bit Nvidia GeForce GTX 550 Ti graphic card The attachment shows the SystemInfo of the involved computer. It does not happen on my notebook with an Intel HD Graphic 3000 graphic chip -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/ui/index/cnttab.cxx | 24 +++- sw/source/uibase/inc/swuicnttab.hxx |2 +- 2 files changed, 12 insertions(+), 14 deletions(-) New commits: commit 4842877a91622f69ed0a861b202cf8e345119549 Author: Noel GrandinDate: Tue Sep 22 21:43:00 2015 +0200 convert Link<> to typed Change-Id: I2b8ef243a82c39174c1102c2e75f38dcf7efd376 Reviewed-on: https://gerrit.libreoffice.org/18796 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx index 2f41944..e663612 100644 --- a/sw/source/ui/index/cnttab.cxx +++ b/sw/source/ui/index/cnttab.cxx @@ -1516,9 +1516,9 @@ IMPL_LINK_TYPED(SwTOXSelectTabPage, MenuExecuteHdl, Menu*, pMenu, bool) class SwTOXEdit : public Edit { -SwFormToken aFormToken; -Link<> aPrevNextControlLink; -bool bNextControl; +SwFormToken aFormToken; +Link aPrevNextControlLink; +bool bNextControl; VclPtr m_pParent; public: SwTOXEdit( vcl::Window* pParent, SwTokenWindow* pTokenWin, @@ -1536,7 +1536,7 @@ public: virtual voidRequestHelp( const HelpEvent& rHEvt ) SAL_OVERRIDE; boolIsNextControl() const {return bNextControl;} -void SetPrevNextLink( const Link<>& rLink ) {aPrevNextControlLink = rLink;} +void SetPrevNextLink( const Link & rLink ) {aPrevNextControlLink = rLink;} const SwFormToken& GetFormToken() { @@ -1586,7 +1586,7 @@ void SwTOXEdit::KeyInput( const KeyEvent& rKEvt ) } } if(bCall && aPrevNextControlLink.IsSet()) -aPrevNextControlLink.Call(this); +aPrevNextControlLink.Call(*this); } Edit::KeyInput(rKEvt); @@ -3463,21 +3463,21 @@ IMPL_LINK(SwTokenWindow, EditResize, Edit*, pEdit) return 0; } -IMPL_LINK(SwTokenWindow, NextItemHdl, SwTOXEdit*, pEdit) +IMPL_LINK_TYPED(SwTokenWindow, NextItemHdl, SwTOXEdit&, rEdit, void) { -ctrl_iterator it = std::find(aControlList.begin(),aControlList.end(),pEdit); +ctrl_iterator it = std::find(aControlList.begin(),aControlList.end(),); if (it == aControlList.end()) -return 0; +return; ctrl_iterator itTest = it; ++itTest; -if ((it != aControlList.begin() && !pEdit->IsNextControl()) || -(itTest != aControlList.end() && pEdit->IsNextControl())) +if ((it != aControlList.begin() && !rEdit.IsNextControl()) || +(itTest != aControlList.end() && rEdit.IsNextControl())) { ctrl_iterator iterFocus = it; -pEdit->IsNextControl() ? ++iterFocus : --iterFocus; +rEdit.IsNextControl() ? ++iterFocus : --iterFocus; Control *pCtrlFocus = *iterFocus; pCtrlFocus->GrabFocus(); @@ -3485,8 +3485,6 @@ IMPL_LINK(SwTokenWindow, NextItemHdl, SwTOXEdit*, pEdit) AdjustScrolling(); } - -return 0; } IMPL_LINK(SwTokenWindow, TbxFocusHdl, SwTOXEdit*, pEdit) diff --git a/sw/source/uibase/inc/swuicnttab.hxx b/sw/source/uibase/inc/swuicnttab.hxx index f65bc91..e395ad2 100644 --- a/sw/source/uibase/inc/swuicnttab.hxx +++ b/sw/source/uibase/inc/swuicnttab.hxx @@ -268,7 +268,7 @@ class SwTokenWindow : public VclHBox, public VclBuilderContainer VclPtr m_pParent; DECL_LINK(EditResize, Edit*); -DECL_LINK(NextItemHdl, SwTOXEdit* ); +DECL_LINK_TYPED(NextItemHdl, SwTOXEdit&, void ); DECL_LINK(TbxFocusHdl, SwTOXEdit* ); DECL_LINK(NextItemBtnHdl, SwTOXButton* ); DECL_LINK(TbxFocusBtnHdl, SwTOXButton* ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/ui/index/cnttab.cxx | 48 +--- sw/source/uibase/inc/swuicnttab.hxx |8 +++--- 2 files changed, 27 insertions(+), 29 deletions(-) New commits: commit a5eaa6be75db0a9e84442fdbee69cf830b17ee85 Author: Noel GrandinDate: Wed Sep 23 14:28:14 2015 +0200 convert Link<> to typed Change-Id: If48dd5fd9ea87ca5c770424ce824998d842aacef Reviewed-on: https://gerrit.libreoffice.org/18811 Reviewed-by: Noel Grandin Tested-by: Noel Grandin diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx index d1347b8..7c32c52 100644 --- a/sw/source/ui/index/cnttab.cxx +++ b/sw/source/ui/index/cnttab.cxx @@ -2416,20 +2416,20 @@ IMPL_LINK_TYPED(SwTOXEntryTabPage, SortKeyHdl, Button*, pButton, void) m_pSortKeyFrame->Enable(bEnable); } -IMPL_LINK(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken*, pToken) +IMPL_LINK_TYPED(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken&, rToken, void) { -if (!pToken->sCharStyleName.isEmpty()) -m_pCharStyleLB->SelectEntry(pToken->sCharStyleName); +if (!rToken.sCharStyleName.isEmpty()) +m_pCharStyleLB->SelectEntry(rToken.sCharStyleName); else m_pCharStyleLB->SelectEntry(sNoCharStyle); const OUString sEntry = m_pCharStyleLB->GetSelectEntry(); m_pEditStylePB->Enable(sEntry != sNoCharStyle); -if(pToken->eTokenType == TOKEN_CHAPTER_INFO) +if(rToken.eTokenType == TOKEN_CHAPTER_INFO) { //---> i89791 -switch(pToken->nChapterFormat) +switch(rToken.nChapterFormat) { default: m_pChapterEntryLB->SetNoSelection();//to alert the user @@ -2446,19 +2446,19 @@ IMPL_LINK(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken*, pToken) } //i53420 -m_pEntryOutlineLevelNF->SetValue(pToken->nOutlineLevel); +m_pEntryOutlineLevelNF->SetValue(rToken.nOutlineLevel); } //i53420 -if(pToken->eTokenType == TOKEN_ENTRY_NO) +if(rToken.eTokenType == TOKEN_ENTRY_NO) { -m_pEntryOutlineLevelNF->SetValue(pToken->nOutlineLevel); +m_pEntryOutlineLevelNF->SetValue(rToken.nOutlineLevel); const sal_uInt16 nFormat = -pToken->nChapterFormat == CF_NUM_NOPREPST_TITLE ? 1 : 0; +rToken.nChapterFormat == CF_NUM_NOPREPST_TITLE ? 1 : 0; m_pNumberFormatLB->SelectEntryPos(nFormat); } -bool bTabStop = TOKEN_TAB_STOP == pToken->eTokenType; +bool bTabStop = TOKEN_TAB_STOP == rToken.eTokenType; m_pFillCharFT->Show(bTabStop); m_pFillCharCB->Show(bTabStop); m_pTabPosFT->Show(bTabStop); @@ -2467,9 +2467,9 @@ IMPL_LINK(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken*, pToken) m_pAutoRightCB->Enable(bTabStop); if(bTabStop) { - m_pTabPosMF->SetValue(m_pTabPosMF->Normalize(pToken->nTabStopPosition), FUNIT_TWIP); -m_pAutoRightCB->Check(SVX_TAB_ADJUST_END == pToken->eTabAlign); -m_pFillCharCB->SetText(OUString(pToken->cTabFillChar)); +m_pTabPosMF->SetValue(m_pTabPosMF->Normalize(rToken.nTabStopPosition), FUNIT_TWIP); +m_pAutoRightCB->Check(SVX_TAB_ADJUST_END == rToken.eTabAlign); +m_pFillCharCB->SetText(OUString(rToken.cTabFillChar)); m_pTabPosFT->Enable(!m_pAutoRightCB->IsChecked()); m_pTabPosMF->Enable(!m_pAutoRightCB->IsChecked()); } @@ -2478,8 +2478,8 @@ IMPL_LINK(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken*, pToken) m_pTabPosMF->Enable(false); } -bool bIsChapterInfo = pToken->eTokenType == TOKEN_CHAPTER_INFO; -bool bIsEntryNumber = pToken->eTokenType == TOKEN_ENTRY_NO; +bool bIsChapterInfo = rToken.eTokenType == TOKEN_CHAPTER_INFO; +bool bIsEntryNumber = rToken.eTokenType == TOKEN_ENTRY_NO; m_pChapterEntryFT->Show( bIsChapterInfo ); m_pChapterEntryLB->Show( bIsChapterInfo ); m_pEntryOutlineLevelFT->Show( bIsChapterInfo || bIsEntryNumber ); @@ -2493,22 +2493,22 @@ IMPL_LINK(SwTOXEntryTabPage, TokenSelectedHdl, SwFormToken*, pToken) if(m_pEntryNoPB->IsVisible()) { -m_pEntryNoPB->Enable(TOKEN_ENTRY_NO != pToken->eTokenType ); +m_pEntryNoPB->Enable(TOKEN_ENTRY_NO != rToken.eTokenType ); } if(m_pEntryPB->IsVisible()) { -m_pEntryPB->Enable(TOKEN_ENTRY_TEXT != pToken->eTokenType && +m_pEntryPB->Enable(TOKEN_ENTRY_TEXT != rToken.eTokenType && !m_pTokenWIN->Contains(TOKEN_ENTRY_TEXT) && !m_pTokenWIN->Contains(TOKEN_ENTRY)); } if(m_pChapterInfoPB->IsVisible()) { -m_pChapterInfoPB->Enable(TOKEN_CHAPTER_INFO != pToken->eTokenType); +m_pChapterInfoPB->Enable(TOKEN_CHAPTER_INFO != rToken.eTokenType); } if(m_pPageNoPB->IsVisible()) { -m_pPageNoPB->Enable(TOKEN_PAGE_NUMS != pToken->eTokenType && +
[Libreoffice-bugs] [Bug 71098] PAGE-BREAK: sub-documents force a page-break when inserted in the master document
https://bugs.documentfoundation.org/show_bug.cgi?id=71098 sm8pschanged: What|Removed |Added Version|4.1.2.3 release |5.0.0.5 release OS|All |Linux (All) Severity|enhancement |normal --- Comment #5 from sm8ps --- Confirmed in LO 5.0.0.5 running on Ubuntu 14.04. My test case: create two text-only documents and include them into a master-documents. The test case of 'LOpage-breakBUG.zip' produces the same unexpected behavior. This problem renders master-documents almost useless for people that do not want to have page breaks between the sub-documents. Thanks for considering this case! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/source
starmath/source/parse.cxx | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) New commits: commit 6e7f5c5fce198bf2f3a228e1faea7f7e9ed09f77 Author: Takeshi AbeDate: Tue Sep 22 19:34:20 2015 +0900 starmath: Use member initialization lists for SmToken Change-Id: I3c5389135054ee866ebac3122edc71ec8c163124 Reviewed-on: https://gerrit.libreoffice.org/18785 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx index 5fd8417..47ad4c6 100644 --- a/starmath/source/parse.cxx +++ b/starmath/source/parse.cxx @@ -34,24 +34,29 @@ using namespace ::com::sun::star; using namespace ::com::sun::star::i18n; -SmToken::SmToken() : -eType (TUNKNOWN), -cMathChar ('\0') +SmToken::SmToken() +: eType(TUNKNOWN) +, cMathChar('\0') +, nGroup(0) +, nLevel(0) +, nRow(0) +, nCol(0) { -nGroup = nCol = nRow = nLevel = 0; } SmToken::SmToken(SmTokenType eTokenType, sal_Unicode cMath, const sal_Char* pText, sal_uLong nTokenGroup, - sal_uInt16 nTokenLevel) { -eType = eTokenType; -cMathChar = cMath; -aText = OUString::createFromAscii(pText); -nGroup = nTokenGroup; -nLevel = nTokenLevel; -nCol = nRow = 0; + sal_uInt16 nTokenLevel) +: aText(OUString::createFromAscii(pText)) +, eType(eTokenType) +, cMathChar(cMath) +, nGroup(nTokenGroup) +, nLevel(nTokenLevel) +, nRow(0) +, nCol(0) +{ } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 94138] Form Control Text Boxes Print And Export To PDF Incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=94138 --- Comment #9 from Dave Richards--- I cannot deploy LO 5 to more of our employees until this is fixed. We have lots of documents with those form controls and they are not printing correctly. Right now this is the only known showstopper. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ucb/source writerperfect/qa writerperfect/source
ucb/source/cacher/cachedcontentresultset.cxx |4 +- ucb/source/ucp/cmis/cmis_repo_content.cxx |4 +- ucb/source/ucp/ext/ucpext_datasupplier.hxx|4 +- ucb/source/ucp/webdav-neon/webdavdatasupplier.hxx |4 +- ucb/source/ucp/webdav/ContentProperties.cxx |2 - ucb/source/ucp/webdav/ContentProperties.hxx |5 +- ucb/source/ucp/webdav/webdavcontent.cxx | 44 +++--- ucb/source/ucp/webdav/webdavcontent.hxx |9 ++-- ucb/source/ucp/webdav/webdavcontentcaps.cxx |6 +-- writerperfect/qa/unit/DirectoryStreamTest.cxx | 14 +++ writerperfect/source/common/WPXSvInputStream.cxx | 17 11 files changed, 55 insertions(+), 58 deletions(-) New commits: commit 09b637e36528165f5e937a418640d95440dac9ef Author: Caolán McNamaraDate: Wed Sep 23 12:08:32 2015 +0100 boost::scoped_ptr->std::unique_ptr Change-Id: I03020e3536ee692a96224a517794c0d0a294f607 Reviewed-on: https://gerrit.libreoffice.org/18793 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/ucb/source/cacher/cachedcontentresultset.cxx b/ucb/source/cacher/cachedcontentresultset.cxx index 97e4832..57378e9 100644 --- a/ucb/source/cacher/cachedcontentresultset.cxx +++ b/ucb/source/cacher/cachedcontentresultset.cxx @@ -30,7 +30,7 @@ #include #include #include -#include +#include using namespace com::sun::star::beans; using namespace com::sun::star::lang; @@ -477,7 +477,7 @@ CCRS_PropertySetInfo::CCRS_PropertySetInfo( if( nFetchDirection != -1 ) nDeleted++; -boost::scoped_ptr > pOrigProps(new Sequence ( *m_pProperties )); +std::unique_ptr > pOrigProps(new Sequence ( *m_pProperties )); sal_Int32 nOrigProps = pOrigProps->getLength(); m_pProperties->realloc( nOrigProps + 2 - nDeleted );//note that nDeleted is <= 2 diff --git a/ucb/source/ucp/cmis/cmis_repo_content.cxx b/ucb/source/ucp/cmis/cmis_repo_content.cxx index 82ca6b3..78b9dff 100644 --- a/ucb/source/ucp/cmis/cmis_repo_content.cxx +++ b/ucb/source/ucp/cmis/cmis_repo_content.cxx @@ -37,7 +37,7 @@ #include "cmis_provider.hxx" #include "cmis_repo_content.hxx" #include "cmis_resultset.hxx" -#include +#include #define OUSTR_TO_STDSTR(s) string( OUStringToOString( s, RTL_TEXTENCODING_UTF8 ).getStr() ) #define STD_TO_OUSTR( str ) OUString( str.c_str(), str.length( ), RTL_TEXTENCODING_UTF8 ) @@ -188,7 +188,7 @@ namespace cmis ONEDRIVE_CLIENT_ID, ONEDRIVE_CLIENT_SECRET ) ); } -boost::scoped_ptr session(libcmis::SessionFactory::createSession( +std::unique_ptr session(libcmis::SessionFactory::createSession( OUSTR_TO_STDSTR( m_aURL.getBindingUrl( ) ), rUsername, rPassword, "", false, oauth2Data )); if (!session) diff --git a/ucb/source/ucp/ext/ucpext_datasupplier.hxx b/ucb/source/ucp/ext/ucpext_datasupplier.hxx index c277a1c..bb82e77 100644 --- a/ucb/source/ucp/ext/ucpext_datasupplier.hxx +++ b/ucb/source/ucp/ext/ucpext_datasupplier.hxx @@ -23,7 +23,7 @@ #include #include -#include +#include namespace ucb { namespace ucp { namespace ext @@ -69,7 +69,7 @@ namespace ucb { namespace ucp { namespace ext virtual void validate() throw( com::sun::star::ucb::ResultSetException ) SAL_OVERRIDE; private: -::boost::scoped_ptr< DataSupplier_Impl >m_pImpl; +std::unique_ptr< DataSupplier_Impl >m_pImpl; }; diff --git a/ucb/source/ucp/webdav-neon/webdavdatasupplier.hxx b/ucb/source/ucp/webdav-neon/webdavdatasupplier.hxx index 3de88d5..9a67534 100644 --- a/ucb/source/ucp/webdav-neon/webdavdatasupplier.hxx +++ b/ucb/source/ucp/webdav-neon/webdavdatasupplier.hxx @@ -30,8 +30,8 @@ #define INCLUDED_UCB_SOURCE_UCP_WEBDAV_NEON_WEBDAVDATASUPPLIER_HXX #include +#include #include -#include #include #include @@ -42,7 +42,7 @@ class Content; class DataSupplier : public ucbhelper::ResultSetDataSupplier { -boost::scoped_ptr m_pImpl; +std::unique_ptr m_pImpl; private: bool getData(); diff --git a/ucb/source/ucp/webdav/ContentProperties.cxx b/ucb/source/ucp/webdav/ContentProperties.cxx index 0d5e074..5d31870 100644 --- a/ucb/source/ucp/webdav/ContentProperties.cxx +++ b/ucb/source/ucp/webdav/ContentProperties.cxx @@ -595,7 +595,7 @@ CachableContentProperties::CachableContentProperties( void CachableContentProperties::addProperties( const ContentProperties & rProps ) { -const boost::scoped_ptr< PropertyValueMap > & props = rProps.getProperties(); +const std::unique_ptr< PropertyValueMap > & props = rProps.getProperties(); PropertyValueMap::const_iterator it = props->begin(); const
[Libreoffice-bugs] [Bug 94465] New: if standard filter is active, that is, a filter is active on a column, and one inserts a new column to the left of the filtered column, , the filter is moved to the
https://bugs.documentfoundation.org/show_bug.cgi?id=94465 Bug ID: 94465 Summary: if standard filter is active, that is, a filter is active on a column, and one inserts a new column to the left of the filtered column, , the filter is moved to the new, empty column Product: LibreOffice Version: 4.1.6.2 release Hardware: x86-64 (AMD64) OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: re...@xs4all.nl -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-qa] Windows and OpenGL - what to do in the unlikely case that LibreOffice crashes on startup
Hi *, as LibreOffice 5.0.2 comes with OpenGL rendering by deafult that might cause problems on certain hardware/driver combinations, there is a possibility of LibreOffice crashing on startup, so you cannot go to Tools|Options → LibreOffice → View to disable it. In this case, you can use the registry setting attached to https://bugs.documentfoundation.org/show_bug.cgi?id=93546 to disable it. so in case you stumble over bugs for rWindows that involve crash on start, keep this one in mind. ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 94464] Default line spacing too big
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 Cor Nouwschanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||c...@nouenoff.nl Version|4.4.5.2 release |4.2.0.4 release Ever confirmed|0 |1 --- Comment #1 from Cor Nouws --- Thanks for your clear description and issue, RGB. Setting to new and, guess, 4.2.0 release. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94469] Calc Macro File function Input error
https://bugs.documentfoundation.org/show_bug.cgi?id=94469 Peter Richchanged: What|Removed |Added Summary|File function Input error |Calc Macro File function ||Input error --- Comment #1 from Peter Rich --- Problem with File Reading in LibreOffice Macros. I am trying to read a text file (output from a LibreOffice spreadsheet as a csv file) and create a new text file containing counts of specific records in the source file. I continually get garbage in the destination file. In an attempt to determine the cause of the garbage I altered the macro to write the input variables back (without alteration) to a new temporary file. A sample from the input file is set out below: === 19/10/2010,07:39,162,82,67,,,n,n,n1,0, 23/10/2010,07:37,175,87,61,,,n,n,n1,0, 24/10/2010,07:13,148,83,70,,,n,n,n1,0, 26/10/2010,07:22,146,84,73,,,n,n,n1,0, 27/10/2010,07:26,181,86,68,,,n,n,n1,0, 29/10/2010,07:41,165,82,68,,,n,n,n1,0, === The new file created by writing the input straight back to a temporary file is set out below. I have removed the quotation marks (") to make the output narrower === 19/10/2010,07:39,162,82,67,,,n,n,n1,0,23/10/2010 07:37,175,87,61,0,,n,n,n1,0,24/10/2010,07:13 148,83,70,0,0,n,n,n1,0,26/10/2010,07:22,146 84,73,0,0,n,n,n1,0,27/10/2010,07:26,181,86 68,0,0,n,n,n1,0,29/10/2010,07:41,165,82,68 0,0,n,n,n1,0,30/10/2010,07:54,172,88,66,0 === Each of these files have 16 'fields' per line but obviously the Spreadsheet save as csv function and the macro Input function do not understand each other. Immediately after the trailing comma (,) in the input file is a linefeed (0A) The LibreOffice help for the Input function states (in part): === The Input# statement reads numeric values or strings from an open file and assigns the data to one or more variables. A numeric variable is read up to the first carriage return (Asc=13), line feed (Asc=10), space, or comma. String variables are read to up to the first carriage return (Asc=13), line feed (Asc=10), or comma. Data and data types in the opened file must appear in the same order as the variables that are passed in the var parameter. If you assign non-numeric values to a numeric variable, var is assigned a value of 0. === Clearly, this does not occur where the expected string consists ONLY of a line feed (0A). The only work around I could find was to ignore the sixteenth 'field' when reading the file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94466] New: Empty Template Folders should not be displayed in the Template Manager
https://bugs.documentfoundation.org/show_bug.cgi?id=94466 Bug ID: 94466 Summary: Empty Template Folders should not be displayed in the Template Manager Product: LibreOffice Version: 5.0.1.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.koes...@mail.de In order to reproduce the bug: [1] Start LibreOffice and open Template Manager: File > New > Templates. [2] Select tab Documents. 8 template folders are displayed. 3 of them are empty: My templates, Presentation Backgrounds, Presentations. (By the way: In the folder styles no templates are displayed as thumbnails. This is also a bug. The folder is not empty.) The last two mentioned folders are used only for presentation templates and not for text documents. Hence the display of these folders in the tab Documents is wrong and confusing. Expected: No Display. (BTW: The expression “Writer Documents” or “Text Document” for this tab would be better) [3] Select tab Spreadsheets: All 8 displayed folders are empty! At least 7 of them are not planned to contain spreadsheet templates. Expected: No Display of these 7 folders. [4] In the tabs Presentations and Drawings there are also several folders that do not contain any templates for presentations and drawings. Expected: Also no display of these folders. By the way: To my opinion it would be better to call the folder “My templates” for each kind of template differently in order to avoid confusion: “My Text Document Templates”, “My Spreadsheet Templates, … -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94467] New: In Template Manager in Folder “styles” Thumbnails for Existing Templates are not Displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=94467 Bug ID: 94467 Summary: In Template Manager in Folder “styles” Thumbnails for Existing Templates are not Displayed Product: LibreOffice Version: 5.0.1.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: harald.koes...@mail.de In order to reproduce the bug: [1] Start LibreOffice and open Template Manager: File > New > Templates [2] Select tab Documents. Besides others the folder styles is displayed. In the frame for this folder no templates are displayed as thumbnails. [3] Double-click “styles”. The templates Defaults and Modern are displayed. Expected: At step [2] thumbnails for the existing templates Defaults and Modern should be displayed in frame of folder “styles”. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94306] Replace boost::noncopyable with plain C++11 deleted copy ctors
https://bugs.documentfoundation.org/show_bug.cgi?id=94306 Umang Jainchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |mailumangj...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94468] New: No Responde
https://bugs.documentfoundation.org/show_bug.cgi?id=94468 Bug ID: 94468 Summary: No Responde Product: LibreOffice Version: 4.4.5.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: malo...@gmail.com Cuando quiero guardar un documento con otro nombre y le doy al menú ARCHIVO/GUARDAR COMO, el libreoffice se queda bloqueado diciendo NO RESPONDE, teniendo que forzar cierre de libreoffice con administrador de tareas y finalizar tarea, no solo pasa con calc, también con write, no he probado con los demás. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94468] No Responde
https://bugs.documentfoundation.org/show_bug.cgi?id=94468 Manolochanged: What|Removed |Added Component|Calc|LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Windows and OpenGL - what to do in the unlikely case that LibreOffice crashes on startup
On 09/23/2015 07:31 AM, Christian Lohmaier wrote: > Hi *, > > as LibreOffice 5.0.2 comes with OpenGL rendering by deafult that > might cause problems on certain hardware/driver combinations, > there is a possibility of LibreOffice crashing on startup, so you > cannot go to Tools|Options → LibreOffice → View to disable it. > > In this case, you can use the registry setting attached to > https://bugs.documentfoundation.org/show_bug.cgi?id=93546 to disable > it. > > so in case you stumble over bugs for rWindows that involve crash on > start, keep this one in mind. Shouldn't this be in a wiki somewhere instead of directing to a registry setting attached to a bug report? Also, @Robinson and others - can we spam this message in the QA channel as many don't follow the mailing list. Best, Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 71098] PAGE-BREAK: sub-documents force a page-break when inserted in the master document
https://bugs.documentfoundation.org/show_bug.cgi?id=71098 --- Comment #6 from sm8ps--- Just had the chance to test things on LO 3.5.7.2 and the situation does get confusing. 1. Creating a master document and inserting new documents from therein does work as expected, i.e. without automatic page breaks. 2. 'LOpage-breakBUG.zip', however, does NOT work as expected, i.e. page breaks are inserted. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 94306] Replace boost::noncopyable with plain C++11 deleted copy ctors
https://bugs.documentfoundation.org/show_bug.cgi?id=94306 Umang Jainchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |mailumangj...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 94464] New: Default line spacing too big
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 Bug ID: 94464 Summary: Default line spacing too big Product: LibreOffice Version: 4.4.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rgb.m...@gmail.com NOTE: It seems the default line spacing was set on 2013, but I only noticed the problem with it now because someone asked me why the line spacing was so big on a new LibO's Writer document. - According to this message: http://nabble.documentfoundation.org/Default-Writer-Template-tp4076271p4076285.html Writer's default template was set to use "line-spacing proportional at 120%, as recommended by Butterick's Practical Typography" (sic), but there is a problem here: that 120% should be applied to the font "point size", **not to the "single spacing"**. In fact, in Writer "proportional line spacing" use the "single spacing" as reference and that value is NOT the point size but a distance defined on the typeface itself(1). For example, the Sukhumala typeface(2) defines a line spacing of 130% of the point size, so using a line spacing "proportional at 120%" makes the line spacing in Writer for that font a 156% of the point size! Most font makers already take care of the default line spacing so using "single spacing" is correct most of the time. If for some reason you prefer to use a larger line spacing on the default template, 105% (maximum, 110%) should be OK for most purposes (even if I do not recommend this: the font designer had a good reason to choose the default value, I think). --- (1) To see this fact in action, install both, Gentium Plus and Gentium Plus Compact on your system http://scripts.sil.org/cms/scripts/page.php?item_id=Gentium_download#801ab246 The only difference between both fonts is, indeed, the default line spacing. And it is a HUGE difference. (2) http://forum.high-logic.com/viewtopic.php?t=5108 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 --- Comment #20 from Aethralis--- I previously did not have this issue, it started with LO 5.0.1.2. Using Ubuntu 14.04. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94465] if standard filter is active, that is, a filter is active on a column, and one inserts a new column to the left of the filtered column, , the filter is moved to the new,
https://bugs.documentfoundation.org/show_bug.cgi?id=94465 --- Comment #1 from mr42--- the moved filter on the new column cannot be removed or edited. one has to delete the new empty column, the filter moves back to it's origin, and then we can edit the column's filter as normal... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94464] Default line spacing too big
https://bugs.documentfoundation.org/show_bug.cgi?id=94464 --- Comment #2 from Cor Nouws--- NB I personally agree too that it's to high ;) But just change to my liking, obviously, if needed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 94306] Replace boost::noncopyable with plain C++11 deleted copy ctors
https://bugs.documentfoundation.org/show_bug.cgi?id=94306 --- Comment #2 from Noel Grandin--- Umang, you should make changes in at most one module at a time. Where a module is all of the code under a top-level directory like vcl/ or sd/ -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 94306] Replace boost::noncopyable with plain C++11 deleted copy ctors
https://bugs.documentfoundation.org/show_bug.cgi?id=94306 --- Comment #1 from Umang Jain--- Hi, This is my first bug fix and I am a new contributor with very little experience. I successfully build libreoffice and tried git grep boost::noncopyable git grep boost/noncopyable I see that there has to be changes in the MANY files. how to approach that ? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 86397] Bookmark: no consecutive name numbering applied when copied
https://bugs.documentfoundation.org/show_bug.cgi?id=86397 --- Comment #6 from Cor Nouws--- patch in gerrit https://gerrit.libreoffice.org/#/c/18816/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94469] New: File function Input error
https://bugs.documentfoundation.org/show_bug.cgi?id=94469 Bug ID: 94469 Summary: File function Input error Product: LibreOffice Version: 4.4.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pr...@earthling.net -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82465] Permanent crashes in Writer with images
https://bugs.documentfoundation.org/show_bug.cgi?id=82465 --- Comment #17 from Ljiljan--- ... and I am using Ubuntu 14.04. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92022] Overwritten filename in Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=92022 --- Comment #4 from Ve. Elanjelian--- Wasn't able to reproduce any error. I continue to see "சாப்ட்வேர் டெஸ்டிங் 1- அறிமுகம்" as the name of the document. Should I see a different name? Version: LO 4.4.5.2, Win 10.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93352] RTL: Horizontal scrolling for right-to-left Sheet moves in opposite direction
https://bugs.documentfoundation.org/show_bug.cgi?id=93352 --- Comment #7 from Lior Kaplan--- I couldn't reproduce this with LibO 5.0.1 on Debian 64bit (both Debian's packages and LibO official build). Can anyone reproduce this on Linux/Windows? or this is a Mac OS X issue only ? (which the bug should reflect) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94471] New: Filtering does not react correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94471 Bug ID: 94471 Summary: Filtering does not react correctly Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: adolfo.lop...@gmail.com Since version 5 I have problems with the filter. I have a file in Calc with over 4000 records, which have problems with filtering this information. After making an ordinary filter, the tool has trouble re-display all data. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94463] FORMATTING Microsoft Office document (doc) rendered incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=94463 vi...@freeletter.me changed: What|Removed |Added Version|4.4.0.3 release |5.0.0.5 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77744] Trendline equation cannot be copied
https://bugs.documentfoundation.org/show_bug.cgi?id=77744 --- Comment #8 from tho...@gmx.de --- Just a kind reminder that the issue is still unsolved in Version 5.0.1.2 (Build-ID 81898c9f5c0d43f3473ba111d7b351050be20261) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94310] Names Management Bug
https://bugs.documentfoundation.org/show_bug.cgi?id=94310 --- Comment #2 from r...@hotmail.com --- Hi, today, September 23, 2015 I decide to make another test, this time i used last version of OpenOffice to open the same file. The document open without trouble and the contents were as expected, all the calculations were correct. So i decide to open the same file with LibreOffice just to find out that it was messed up. So the problem is not the document itself but somehow on LibreOffice engine. The file contains sensitive (confidential) data that's why I did not included it as an attachment. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: configmgr/source
configmgr/source/childaccess.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 12c2bbc317b355353d4f725c9439fbde803b4fc4 Author: Stephan BergmannDate: Wed Sep 23 18:34:50 2015 +0200 Report nil-valued localized property as such ...regression introduced with 879aa54e895a56cb65f93ae98e6a9e7b08981a47 "configmgr: accelerate simple config key fetches." Change-Id: Ifb732a25d902f58c76e06ebaad3a6178ff102f58 diff --git a/configmgr/source/childaccess.cxx b/configmgr/source/childaccess.cxx index a9771ff..7295f89 100644 --- a/configmgr/source/childaccess.cxx +++ b/configmgr/source/childaccess.cxx @@ -269,8 +269,7 @@ css::uno::Any ChildAccess::asValue() rtl::Reference< ChildAccess > child(getChild("*" + locale)); // As a last resort, return a nil value even though it may be // illegal for the given property: -if (child.is()) -return child->asValue(); +return child.is() ? child->asValue() : css::uno::Any(); } } value = css::uno::makeAny( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 76231] Tamil letters wrong display in latha font
https://bugs.documentfoundation.org/show_bug.cgi?id=76231 --- Comment #9 from Ve. Elanjelian--- Created attachment 118975 --> https://bugs.documentfoundation.org/attachment.cgi?id=118975=edit Fonts displayed correctly I am not able to reproduce the error. (I don't have a Lohit fonts though.) Latha fonts works fine. See attachment. I run LO 4.4.5.2 on Win 10.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 94306] Replace boost::noncopyable with plain C++11 deleted copy ctors
https://bugs.documentfoundation.org/show_bug.cgi?id=94306 --- Comment #3 from Umang Jain--- ok. So correct me if I am wrong. Have to make changes module by module, then run "make" for that particular module and examine if some error pops up ? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 94471] Filtering does not react correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=94471 Adolfochanged: What|Removed |Added Version|5.1.0.0.alpha0+ Master |5.0.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94472] Proposal for multi view( documents
https://bugs.documentfoundation.org/show_bug.cgi?id=94472 epimitheaschanged: What|Removed |Added Summary|Proposal for multi view |Proposal for multi view( |documents |documents -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94472] Proposal for sectioned ("chaptered") documents
https://bugs.documentfoundation.org/show_bug.cgi?id=94472 epimitheaschanged: What|Removed |Added Summary|Proposal for multi view(|Proposal for sectioned |documents |("chaptered") documents -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94470] ugly downscaled thumbnail images in start center
https://bugs.documentfoundation.org/show_bug.cgi?id=94470 --- Comment #1 from Andras Timar--- Created attachment 118971 --> https://bugs.documentfoundation.org/attachment.cgi?id=118971=edit LibreOffice 4.3 screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92024] Text Alignment is Changed when we change language
https://bugs.documentfoundation.org/show_bug.cgi?id=92024 --- Comment #3 from Ve. Elanjelian--- I did the above test with LO 4.4.5.2 running on Win 10. Works fine. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94470] New: ugly downscaled thumbnail images in start center
https://bugs.documentfoundation.org/show_bug.cgi?id=94470 Bug ID: 94470 Summary: ugly downscaled thumbnail images in start center Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tima...@gmail.com Created attachment 118970 --> https://bugs.documentfoundation.org/attachment.cgi?id=118970=edit LibreOffice 4.4. screenshot Please compare the two screenshots, one from LibreOffice 4.3, the other from LibreOffice 4.4. The thumbnails in 4.4 look ugly, the downscaled image is not antialiased. Tested on Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94463] FORMATTING Microsoft Office document (doc) rendered incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=94463 vi...@freeletter.me changed: What|Removed |Added Hardware|Other |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92022] Overwritten filename in Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=92022 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #5 from Beluga --- muthu1809: are you still having this problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92024] Text Alignment is Changed when we change language
https://bugs.documentfoundation.org/show_bug.cgi?id=92024 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Beluga --- muthu1809: are you still having this problem? Have you upgraded to LibreOffice 5 yet? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82370] PRINTING: incorrect orientation of #10 envelope (Brother printer)
https://bugs.documentfoundation.org/show_bug.cgi?id=82370 --- Comment #12 from konsultor--- Now on openSuse 13.2 and LibreOffice 4.4.5.2 but the problem persists with the Brother printer. I can print envelopes on an old HP LJ2100 but I'd like to include a color logo in the return address. When I get to select, I pick postscript as the printer language for both printers. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92024] Text Alignment is Changed when we change language
https://bugs.documentfoundation.org/show_bug.cgi?id=92024 --- Comment #2 from Ve. Elanjelian--- Created attachment 118972 --> https://bugs.documentfoundation.org/attachment.cgi?id=118972=edit Screen shot of the test Shows the document alignment remain justified. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94310] Names Management Bug
https://bugs.documentfoundation.org/show_bug.cgi?id=94310 --- Comment #3 from r...@hotmail.com --- Created attachment 118973 --> https://bugs.documentfoundation.org/attachment.cgi?id=118973=edit Screenshot of a messup file openned by LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82465] Permanent crashes in Writer with images
https://bugs.documentfoundation.org/show_bug.cgi?id=82465 --- Comment #16 from Ljiljan--- I don't experience frequent crashes in L.O. 5.0.1.2. but I experience it from time to time. L.O. 4.2. it was much more stable. In 5.0.1.2. Examples: - I was opening document in PPTX. LO loaded 10 slides of preview and crashed. I open the same document again and it was working just fine. - Once, I decided to enable some toolbar. Or track changes... I can't remember... and it crashed. - My work done in previous versions of LO, LO didn't want to open for three times (it tries to open and then crashes). However, fourth time (I was just repeating the process) the document was opened. ... and similar situation... I cannot find any logical explanation for this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94310] Names Management Bug
https://bugs.documentfoundation.org/show_bug.cgi?id=94310 --- Comment #5 from Beluga--- Ok, but we can't verify your report if you don't attach it. You can use this method to anonymize it: https://wiki.documentfoundation.org/QA/Bugzilla/Sanitizing_Files_Before_Submission#Sanitize_file_text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94310] Names Management Bug
https://bugs.documentfoundation.org/show_bug.cgi?id=94310 --- Comment #4 from r...@hotmail.com --- Created attachment 118974 --> https://bugs.documentfoundation.org/attachment.cgi?id=118974=edit Screenshot of file openned by OpenOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93281] LibreOffice Viewer for Android worked only once; after that, it always crashes.
https://bugs.documentfoundation.org/show_bug.cgi?id=93281 --- Comment #8 from eular.fr...@gmail.com --- The same issue appears on my Samsung Galaxy S5 with cyanogenmod (kltechnduo) and Samsung Tab2 7.0 with cyanogenmod (p3110). I fetched the app from F-Droid. The log is obtained via adb logcat from my SGS5: V/WindowManager( 690): Adding window Window{6dcc71b u0 SurfaceView} at 8 of 14 (before Window{109d1615 u0 org.documentfoundation.libreoffice/org.libreoffice.LibreOfficeMainActivity}) I/ActivityManager( 690): Displayed org.documentfoundation.libreoffice/org.libreoffice.LibreOfficeMainActivity: +2s911ms (total +3s60ms) I/Timeline( 690): Timeline: Activity_windows_visible id: ActivityRecord{2922ab3 u0 org.documentfoundation.libreoffice/org.libreoffice.LibreOfficeMainActivity t2459} time:14460738 D/audio_hw_primary( 260): out_standby: enter: stream (0xb5880740) usecase(1: low-latency-playback) D/hardware_info( 260): hw_info_append_hw_type : device_name = speaker I/stderr (17714): LOK init failed -- restart required I/LibreOffice(17714): New sal thread started and attached res=0 I/LibreOffice/androidinst(17714): Android: CreateSalInstance! F/libc(17714): Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 17740 (Thread-1369) I/DEBUG ( 256): property debug.db.uid not set; NOT waiting for gdb. I/DEBUG ( 256): HINT: adb shell setprop debug.db.uid 10 I/DEBUG ( 256): HINT: adb forward tcp:5039 tcp:5039 I/LibreOffice/androidinst(17714): AttachCurrentThread res=0 env=0x99057460 I/DEBUG ( 256): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** I/DEBUG ( 256): Build fingerprint: 'samsung/klteduoszm/klteduoszm:5.0/LRX21T/G9008WZMU1BOC2:user/release-keys' I/DEBUG ( 256): Revision: '10' I/DEBUG ( 256): ABI: 'arm' I/DEBUG ( 256): pid: 17714, tid: 17740, name: Thread-1369 >>> org.documentfoundation.libreoffice <<< I/DEBUG ( 256): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 I/DEBUG ( 256): r0 r1 af242870 r2 0deb6816 r3 I/DEBUG ( 256): r4 a2fd6ab8 r5 b6e36e04 r6 b6e36e04 r7 b6e36e04 I/DEBUG ( 256): r8 af24289c r9 sl b4aee200 fp b3506884 I/DEBUG ( 256): ip 9e7424cd sp af242848 lr 9fb9f951 pc 9fb9e1d2 cpsr 600f0030 I/DEBUG ( 256): I/DEBUG ( 256): backtrace: I/DEBUG ( 256): #00 pc 01cdf1d2 /mnt/asec/org.documentfoundation.libreoffice-1/lib/arm/liblo-native-code.so I/DEBUG ( 256): #01 pc 0deb6812 W/Thread-1369(17740): type=1701 audit(0.0:318): auid=4294967295 uid=10094 gid=10094 ses=4294967295 subj=u:r:untrusted_app:s0 reason="memory violation" sig=11 I/DEBUG ( 256): I/DEBUG ( 256): Tombstone written to: /data/tombstones/tombstone_01 W/ActivityManager( 690): Force finishing activity 1 org.documentfoundation.libreoffice/org.libreoffice.LibreOfficeMainActivity I/Choreographer(17714): Skipped 37 frames! The application may be doing too much work on its main thread. I/BootReceiver( 690): Copying /data/tombstones/tombstone_01 to DropBox (SYSTEM_TOMBSTONE) I/WindowState( 690): WIN DEATH: Window{109d1615 u0 org.documentfoundation.libreoffice/org.libreoffice.LibreOfficeMainActivity} -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94472] New: Proposal for multi view documents
https://bugs.documentfoundation.org/show_bug.cgi?id=94472 Bug ID: 94472 Summary: Proposal for multi view documents Product: LibreOffice Version: 5.0.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cyranor2...@hotmail.com Created attachment 118976 --> https://bugs.documentfoundation.org/attachment.cgi?id=118976=edit Screenshot of what i think enchantment would be like. Hello and sry to bother you , today at work i came up with a possible good feature that would be great to have in Writer. I will try to describe my idea from the user's point of view. ### Situation so far ### When you make a writer document , its always a big-chunk of text (data etc). You can add bookmarks and other stuff to move around in the document, but its always organised in a "serial" way. ### Proposal(s) ### 1.Instead of having in each document the data arranged in a "serial" way, make the data "re-arrangeable" (dunno if such a word exists) in sections that will appear as different portions of the same document. Each section will behave seperately from the rest. Just like in calc where in each file you can have many sheets included , think of a document where you can start with a page (just like now) and further while typing , add another "chapter" where u can work in parallel. You can jump at different "chapters" fast , without losing the point you were working at. 2. These "chapters" can also be used as default bookmarks while exporting to pdf. 3. The GUI can even go further , by letting the user have 2 different "chapters" from the same document, viewed side-by-side at the same time. 4. While printing , user can be asked whether to pring all chapters etc. 5. When exporting to other formats (microsfoot etc) , you can just add (in the old serial way) , one "chapter" after another to make the compatible format file. ### Typical examples where is can be usefull ### 1.Think of a book with many chapters. When u write it, instead of having to make each chapter hard to find or even save them in different files, u can now have all of them in one piece and "jump" in and out of each "chapter" fast without searching . 2. when typing an article and want to make a reference list right-away you can use another "chapter" as a temporary notepad , working at the same time and finishing it at the end. ### Worst case scenario ### Feature is not usefull and noone uses it I hope my description was usefull and understood , i add a picture of what i think it would be like. Thank you for your time !!! ETC i hope my idea isnt already included somewhere ,and i havent discovered it yet (plz dont flame me if so :/ ) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94393] if I open an MS Excel XLSX file in Calc, dropdowns in cells do not show
https://bugs.documentfoundation.org/show_bug.cgi?id=94393 --- Comment #3 from Elmar--- Created attachment 118983 --> https://bugs.documentfoundation.org/attachment.cgi?id=118983=edit MS Excel sample file Note that if I use MS Excel to save the file to a .xls file, the problem remains. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93923] UI unresponsive on resizing a chart in a large spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=93923 --- Comment #5 from Beluga--- Still not reproduced. Tested on Arch Linux 64-bit, Xfce 4.12, LibO 5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94393] if I open an MS Excel XLSX file in Calc, dropdowns in cells do not show
https://bugs.documentfoundation.org/show_bug.cgi?id=94393 Elmarchanged: What|Removed |Added CC||rob...@iafrica.com --- Comment #2 from Elmar --- Created attachment 118982 --> https://bugs.documentfoundation.org/attachment.cgi?id=118982=edit xlsx dropdown does nto work in Calc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs