[Libreoffice-commits] core.git: 3 commits - compilerplugins/clang include/svx sd/source svx/inc svx/source sw/source

[Stephan Bergmann]

 compilerplugins/clang/mergeclasses.results |2 
 include/svx/unopage.hxx|4 -
 sd/source/ui/unoidl/unopage.cxx|8 +-
 svx/inc/svdibrow.hxx   |   30 +--
 svx/source/svdraw/svddrgm1.hxx |6 +-
 svx/source/svdraw/svddrgmt.cxx |   12 ++--
 svx/source/svdraw/svdibrow.cxx |   78 ++---
 svx/source/unodraw/unopage.cxx |   12 ++--
 sw/source/core/unocore/unodraw.cxx |4 -
 9 files changed, 78 insertions(+), 78 deletions(-)

New commits:
commit b9792cb9553abb11cc3c7fb6c68a88f716b07b57
Author: Stephan Bergmann 
Date:   Thu Apr 7 07:56:44 2016 +0200

Avoid reserved identifiers

Change-Id: I63ab4de02702c6f74caa3a65f7d297e2a95a65cd

diff --git a/include/svx/unopage.hxx b/include/svx/unopage.hxx
index ebf855e..3464363 100644
--- a/include/svx/unopage.hxx
+++ b/include/svx/unopage.hxx
@@ -72,8 +72,8 @@ class SVX_DLLPUBLIC SvxDrawPage : public 
::cppu::WeakAggImplHelper6< css::drawin
 SdrModel*   mpModel;
 SdrView*mpView;
 
-void_SelectObjectsInView( const css::uno::Reference< 
css::drawing::XShapes >& aShapes, SdrPageView*   pPageView ) throw ();
-void_SelectObjectInView( const css::uno::Reference< 
css::drawing::XShape >& xShape, SdrPageView*  pPageView ) throw();
+voidSelectObjectsInView( const css::uno::Reference< 
css::drawing::XShapes >& aShapes, SdrPageView*   pPageView ) throw ();
+voidSelectObjectInView( const css::uno::Reference< 
css::drawing::XShape >& xShape, SdrPageView*  pPageView ) throw();
 
 virtual void disposing() throw();
 
diff --git a/sd/source/ui/unoidl/unopage.cxx b/sd/source/ui/unoidl/unopage.cxx
index f7f1ecc..8382605 100644
--- a/sd/source/ui/unoidl/unopage.cxx
+++ b/sd/source/ui/unoidl/unopage.cxx
@@ -1623,7 +1623,7 @@ Reference< drawing::XShape > SAL_CALL 
SdGenericDrawPage::combine( const Referenc
 
 SdrPageView* pPageView = mpView->ShowSdrPage( GetPage() );
 
-_SelectObjectsInView( xShapes, pPageView );
+SelectObjectsInView( xShapes, pPageView );
 
 mpView->CombineMarkedObjects( false );
 
@@ -1654,7 +1654,7 @@ void SAL_CALL SdGenericDrawPage::split( const Reference< 
drawing::XShape >& xGro
 return;
 
 SdrPageView* pPageView = mpView->ShowSdrPage( GetPage() );
-_SelectObjectInView( xGroup, pPageView );
+SelectObjectInView( xGroup, pPageView );
 mpView->DismantleMarkedObjects();
 mpView->HideSdrPage();
 
@@ -1674,7 +1674,7 @@ Reference< drawing::XShape > SAL_CALL 
SdGenericDrawPage::bind( const Reference<
 
 SdrPageView* pPageView = mpView->ShowSdrPage( GetPage() );
 
-_SelectObjectsInView( xShapes, pPageView );
+SelectObjectsInView( xShapes, pPageView );
 
 mpView->CombineMarkedObjects();
 
@@ -1705,7 +1705,7 @@ void SAL_CALL SdGenericDrawPage::unbind( const Reference< 
drawing::XShape >& xSh
 return;
 
 SdrPageView* pPageView = mpView->ShowSdrPage( GetPage() );
-_SelectObjectInView( xShape, pPageView );
+SelectObjectInView( xShape, pPageView );
 mpView->DismantleMarkedObjects( true );
 mpView->HideSdrPage();
 
diff --git a/svx/source/unodraw/unopage.cxx b/svx/source/unodraw/unopage.cxx
index 6fbab3e..cdc5c17 100644
--- a/svx/source/unodraw/unopage.cxx
+++ b/svx/source/unodraw/unopage.cxx
@@ -390,9 +390,9 @@ namespace
 }
 }
 
-// ATTENTION: _SelectObjectsInView selects the css::drawing::Shapes
+// ATTENTION: SelectObjectsInView selects the css::drawing::Shapes
 // only in the given SdrPageView. It hasn't to be the visible SdrPageView.
-void SvxDrawPage::_SelectObjectsInView( const Reference< drawing::XShapes > & 
aShapes, SdrPageView* pPageView ) throw ()
+void SvxDrawPage::SelectObjectsInView( const Reference< drawing::XShapes > & 
aShapes, SdrPageView* pPageView ) throw ()
 {
 SAL_WARN_IF(!pPageView, "svx", "SdrPageView is NULL!");
 SAL_WARN_IF(!mpView, "svx", "SdrView is NULL!");
@@ -412,9 +412,9 @@ void SvxDrawPage::_SelectObjectsInView( const Reference< 
drawing::XShapes > & aS
 }
 }
 
-// ATTENTION: _SelectObjectInView selects the shape only in the given 
SdrPageView.
+// ATTENTION: SelectObjectInView selects the shape only in the given 
SdrPageView.
 // It hasn't to be the visible SdrPageView.
-void SvxDrawPage::_SelectObjectInView( const Reference< drawing::XShape > & 
xShape, SdrPageView* pPageView ) throw()
+void SvxDrawPage::SelectObjectInView( const Reference< drawing::XShape > & 
xShape, SdrPageView* pPageView ) throw()
 {
 SAL_WARN_IF(!pPageView, "svx", "SdrPageView is NULL!");
 SAL_WARN_IF(!mpView, "svx", "SdrView is NULL!");
@@ -443,7 +443,7 @@ Reference< drawing::XShapeGroup > SAL_CALL 
SvxDrawPage::group( const Reference<
 
 SdrPageView* pPageView = mpView->ShowSdrPage( mpPage );
 
-_SelectObjectsInView( xShapes, pPageView );
+SelectObjectsInView( xShapes, pPageView );
 
 mpView->GroupMarked();
 
@@ -481,7 

[Libreoffice-bugs] [Bug 98026] Chinese character sort bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98026

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #2 from Kevin Suo  ---
(In reply to izdbrave from comment #0)
Hi, please provide the test sample document as m.a.riosv have asked.

Also if possible you can go to the Chinese LibreOffice discussion forum so we
can discuss if this is really a bug. 你可以到中文社区论坛里发帖我们一起讨论看看是否是个bug。

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98484] Chinese char input does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98484

Kevin Suo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||suokunl...@126.com
 Ever confirmed|0   |1

--- Comment #1 from Kevin Suo  ---
(In reply to Jun Ma from comment #0)
Hi Ma Jun, Please indicate your LibreOffice version, OS version (ubuntu?
Debian? Fedora etc...) and the input method application you installed and used.
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

--- Comment #8 from Buovjaga  ---
(In reply to Joel Madero from comment #6)
> What am I missing?

You have to use attachment 123166, the image included in it.
Use the procedure described in
https://help.libreoffice.org/Common/Adding_Graphics_to_the_Gallery

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98776] FILESAVE: Exporting to PDF crashes Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98776

--- Comment #7 from Buovjaga  ---
(In reply to SecUpwN from comment #6)
> Zypper cannot find that package. Which repo to add for Tumbleweed?

It seems there is only a debuginfo repo for Leap:
https://en.opensuse.org/Package_repositories

Debuginfo packages. Advanced users only.
Version: Leap 42.1
http://download.opensuse.org/debug/distribution/leap/42.1/repo/oss/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35418] Compiling error -- i18npool folder

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35418

Ryan McCoskrie  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---

--- Comment #2 from Ryan McCoskrie  ---
This is happening to me now.

ucnv_toUChars: ICU Error "U_STRING_NOT_TERMINATED_WARNING"
/home/ryan/libreoffice/i18npool/CustomTarget_breakiterator.mk:88: recipe for
target
'/home/ryan/libreoffice/workdir/CustomTarget/i18npool/breakiterator/char_in.brk'
failed
make[1]: ***
[/home/ryan/libreoffice/workdir/CustomTarget/i18npool/breakiterator/char_in.brk]
Error 132
make[1]: *** Waiting for unfinished jobs
createRuleBasedBreakIterator: ICU Error "U_BRK_RULE_SYNTAX"  at line 8, column
11
/home/ryan/libreoffice/i18npool/CustomTarget_breakiterator.mk:88: recipe for
target
'/home/ryan/libreoffice/workdir/CustomTarget/i18npool/breakiterator/char.brk'
failed
make[1]: ***
[/home/ryan/libreoffice/workdir/CustomTarget/i18npool/breakiterator/char.brk]
Error 3
Makefile:246: recipe for target 'build' failed
make: *** [build] Error 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes19' - 2 commits - vcl/opengl

[Tomaž Vajngerl]

 vcl/opengl/texture.cxx |   15 +++
 1 file changed, 3 insertions(+), 12 deletions(-)

New commits:
commit f04b018871efeca10d4d89e7c20c33cd664de43d
Author: Tomaž Vajngerl 
Date:   Thu Apr 7 14:22:51 2016 +0900

Revert "opengl: use GL_BGRA as default backend format on WNT"

This reverts commit f80c2dd03d9d18c06ea0a9763ca59aeb1d2ed0e5.

THis is wrong anyway...

diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx
index 0a83661..1f270bc 100644
--- a/vcl/opengl/texture.cxx
+++ b/vcl/opengl/texture.cxx
@@ -30,15 +30,6 @@
 #include "opengl/texture.hxx"
 #include "opengl/zone.hxx"
 
-namespace
-{
-#ifdef WNT
-const GLenum constDefaultBackendFormat = GL_RGBA;
-#else
-const GLenum constDefaultBackendFormat = GL_BGRA;
-#endif
-} // end anonymous namespace
-
 // texture with allocated size
 ImplOpenGLTexture::ImplOpenGLTexture( int nWidth, int nHeight, bool bAllocate 
) :
 mnRefCount( 1 ),
@@ -64,7 +55,7 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nWidth, int 
nHeight, bool bAllocate )
 CHECK_GL_ERROR();
 if( bAllocate )
 {
-glTexImage2D( GL_TEXTURE_2D, 0, constDefaultBackendFormat, nWidth, 
nHeight, 0, constDefaultBackendFormat, GL_UNSIGNED_BYTE, nullptr );
+glTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, nWidth, nHeight, 0, GL_RGBA, 
GL_UNSIGNED_BYTE, nullptr );
 CHECK_GL_ERROR();
 }
 glBindTexture( GL_TEXTURE_2D, 0 );
@@ -100,7 +91,7 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nX, int nY, int 
nWidth, int nHeight )
 CHECK_GL_ERROR();
 glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST );
 CHECK_GL_ERROR();
-glCopyTexImage2D( GL_TEXTURE_2D, 0, constDefaultBackendFormat, nX, nY, 
nWidth, nHeight, 0 );
+glCopyTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, nX, nY, nWidth, nHeight, 0 );
 CHECK_GL_ERROR();
 glBindTexture( GL_TEXTURE_2D, 0 );
 CHECK_GL_ERROR();
@@ -137,7 +128,7 @@ ImplOpenGLTexture::ImplOpenGLTexture( int nWidth, int 
nHeight, int nFormat, int
 CHECK_GL_ERROR();
 glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST );
 CHECK_GL_ERROR();
-glTexImage2D( GL_TEXTURE_2D, 0, constDefaultBackendFormat, mnWidth, 
mnHeight, 0, nFormat, nType, pData );
+glTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, mnWidth, mnHeight, 0, nFormat, 
nType, pData );
 CHECK_GL_ERROR();
 glBindTexture( GL_TEXTURE_2D, 0 );
 CHECK_GL_ERROR();
commit e79882aaef5ba71d0feb72ae745bd577f7afb23a
Author: Tomaž Vajngerl 
Date:   Thu Apr 7 14:21:49 2016 +0900

Revert "opengl: really use GL_BGRA as default backend format on WNT"

This reverts commit 7aadf84225350df2e6814f57b7a27c5d39b0f7ef.

We can't influence the internal texture format in that way.

diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx
index 68d10a9..0a83661 100644
--- a/vcl/opengl/texture.cxx
+++ b/vcl/opengl/texture.cxx
@@ -33,9 +33,9 @@
 namespace
 {
 #ifdef WNT
-const GLenum constDefaultBackendFormat = GL_BGRA;
-#else
 const GLenum constDefaultBackendFormat = GL_RGBA;
+#else
+const GLenum constDefaultBackendFormat = GL_BGRA;
 #endif
 } // end anonymous namespace
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98067] Menu bar and right tool bar are invisible, but functional in high-contrast-mode/theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98067

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|5.1.0.3 release |4.3.0.4 release
 Ever confirmed|0   |1

--- Comment #7 from Buovjaga  ---
Sorry about that, I do confirm the sidebar thing (already in 4.3).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99122] Send as microsoft Word e-mail under file menu sends as .doc instead of now prevalent .docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99122

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
  Component|Writer  |framework
 Ever confirmed|0   |1
   Severity|minor   |enhancement

--- Comment #1 from raal  ---
It's the same for Calc and Impress> xls/xlsx, ppt/pptx

Setting as new enhancement - make it configurable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99128] 'Save As' Dialog Window should allow re-size (window mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99128

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |WORKSFORME

--- Comment #2 from V Stuart Foote  ---
Thanks for filing, but the Save As dialog is implemented resizable. Both in
Windows OS integrated and the LibreOffice "native" dialogs.  Grap handle in
lower right corner. 

Please retry after clearing your User profile.

=-ref-=
https://wiki.documentfoundation.org/UserProfile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99114] PDF export breaks glyph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99114

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1
 OS|All |Windows (All)

--- Comment #5 from V Stuart Foote  ---
Confirming the visual glitch in your LibreOffice export to PDF vs. your
Ghostscript 9.14 based PDF24 virtual printer.

As you are working on Windows with an 32-bit x86 build of 5.1.1.3, is OpenGL
enabled or disabled?  And on what release of Windows?

Helpful if you copy and paste the details from the Help -> About LibreOffice
panel.  Also, as "EB Garamond 12" is not a common font on Windows builds,
please  embed in your sample ODT (File -> Properties: Font tab) and perhaps
bracket the "m" with some other text to make it possible to locate more easily
in the PDFs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/.gitignore

[Ashod Nakashian]

 loolwsd/.gitignore |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f04eee1ec4a041c113764865fd60174b16017fcb
Author: Ashod Nakashian 
Date:   Thu Apr 7 00:37:02 2016 -0400

loolwsd: updated gitignore with renamed binaries

Change-Id: I1c51db6b8254bc70291de51a6bd5f8fd3d53e8fc
Reviewed-on: https://gerrit.libreoffice.org/23882
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/.gitignore b/loolwsd/.gitignore
index a50e3e6..60d6cd2 100644
--- a/loolwsd/.gitignore
+++ b/loolwsd/.gitignore
@@ -33,8 +33,8 @@ connect
 lokitclient
 loadtest
 loolwsd
-loolkit
-loolbroker
+loolforkit
+loolmount
 loolmap
 sockettransporttest
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp loolwsd/loolwsd.xml loolwsd/Storage.hpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |5 -
 loolwsd/LOOLWSD.cpp|   11 +++
 loolwsd/LOOLWSD.hpp|1 +
 loolwsd/Storage.hpp|   12 
 loolwsd/loolwsd.xml|1 +
 5 files changed, 29 insertions(+), 1 deletion(-)

New commits:
commit 9485b4fe636758732efbd45f0abde974be472a1d
Author: Ashod Nakashian 
Date:   Thu Apr 7 00:32:28 2016 -0400

loolwsd: disable loading of local docs by default

Loading documents from the local filesystem
opens the door to security issues.

By default filesystem storage is disabled,
even if enabled in the config file. The
only way to enable it is to set the
allowlocalstorage command-line argument.

Change-Id: Ib8f57377260817436d101a16757aab38276cbdcd
Reviewed-on: https://gerrit.libreoffice.org/23881
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 393ba9a..90f60bc 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -82,7 +82,10 @@ void DocumentBroker::validate(const Poco::URI& uri)
 {
 Log::info("Validating: " + uri.toString());
 auto storage = createStorage("", "", uri);
-storage->getFileInfo(uri);
+if (storage == nullptr || !storage->getFileInfo(uri).isValid())
+{
+throw std::runtime_error("Invalid URI or access denied.");
+}
 }
 
 bool DocumentBroker::load(const std::string& jailId)
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 46860d0..47c3d62 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -964,6 +964,7 @@ std::string LOOLWSD::ChildRoot;
 std::string LOOLWSD::LoSubPath = "lo";
 std::string LOOLWSD::FileServerRoot;
 std::string LOOLWSD::AdminCreds;
+bool LOOLWSD::AllowLocalStorage = false;
 
 unsigned int LOOLWSD::NumPreSpawnedChildren = 0;
 bool LOOLWSD::DoTest = false;
@@ -1033,6 +1034,10 @@ void LOOLWSD::initialize(Application& self)
 NumPreSpawnedChildren = config().getUInt("num_prespawn_children", 10);
 }
 
+// This overrides whatever is in the config file,
+// which forces admins to set this flag on the command-line.
+config().setBool("storage.filesystem[@allow]", AllowLocalStorage);
+
 ServerApplication::initialize(self);
 }
 
@@ -1138,6 +1143,10 @@ void LOOLWSD::defineOptions(OptionSet& optionSet)
 .repeatable(false)
 .argument("directory"));
 
+optionSet.addOption(Option("allowlocalstorage", "", "When true will allow 
highly insecure loading of files from local storage.")
+.required(false)
+.repeatable(false));
+
 optionSet.addOption(Option("test", "", "Interactive testing.")
 .required(false)
 .repeatable(false));
@@ -1175,6 +1184,8 @@ void LOOLWSD::handleOption(const std::string& optionName, 
const std::string& val
 NumPreSpawnedChildren = std::stoi(value);
 else if (optionName == "admincreds")
 AdminCreds = value;
+else if (optionName == "allowlocalstorage")
+AllowLocalStorage = true;
 else if (optionName == "test")
 LOOLWSD::DoTest = true;
 }
diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index ea87f50..6cd8c80 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -46,6 +46,7 @@ public:
 static std::string LoSubPath;
 static std::string FileServerRoot;
 static std::string AdminCreds;
+static bool AllowLocalStorage;
 
 static
 std::string GenSessionId()
diff --git a/loolwsd/Storage.hpp b/loolwsd/Storage.hpp
index 9e46f3d..24023a2 100644
--- a/loolwsd/Storage.hpp
+++ b/loolwsd/Storage.hpp
@@ -13,6 +13,7 @@
 
 #include 
 
+#include 
 #include 
 
 #include "Auth.hpp"
@@ -26,6 +27,11 @@ public:
 class FileInfo
 {
 public:
+bool isValid() const
+{
+return !Filename.empty() && Size > 0;
+}
+
 std::string Filename;
 Poco::Timestamp ModifiedTime;
 size_t Size;
@@ -139,6 +145,12 @@ std::unique_ptr createStorage(const 
std::string& jailRoot, const st
 {
 if (uri.isRelative() || uri.getScheme() == "file")
 {
+if 
(!Poco::Util::Application::instance().config().getBool("storage.filesystem[@allow]",
 false))
+{
+Log::error("Local Storage is disabled by default. Specify 
allowlocalstorage on the command-line to enable.");
+return nullptr;
+}
+
 Log::info("Public URI [" + uri.toString() + "] is a file.");
 return std::unique_ptr(new LocalStorage(jailRoot, 
jailPath, uri.getPath()));
 }
diff --git a/loolwsd/loolwsd.xml b/loolwsd/loolwsd.xml
index 7d356b1..dfa909c 100644
--- a/loolwsd/loolwsd.xml
+++ b/loolwsd/loolwsd.xml
@@ -20,6 +20,7 @@
 
 
 
+
 
 localhost
 0

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp loolwsd/loolwsd.xml

[Ashod Nakashian]

 loolwsd/LOOLWSD.cpp |   38 +-
 loolwsd/LOOLWSD.hpp |9 -
 loolwsd/loolwsd.xml |9 +
 3 files changed, 50 insertions(+), 6 deletions(-)

New commits:
commit 00940d5a0bffb0c2a0224ed16a052f6989ac4062
Author: Ashod Nakashian 
Date:   Wed Apr 6 23:51:58 2016 -0400

loolwsd: configure wsd using the config file

Most all configuration values can now be defined
in the configuration XML. The command-line arguments
can be used to override some of these values (for
the convenience of developement and testing) and,
in a few cases, as a security measure to avoid
storing sensitive data in the configuration file.

Change-Id: I040b807b1a59a3537bb94646150d3c7d711f8b62
Reviewed-on: https://gerrit.libreoffice.org/23880
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 91bbf4d..46860d0 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -965,7 +965,7 @@ std::string LOOLWSD::LoSubPath = "lo";
 std::string LOOLWSD::FileServerRoot;
 std::string LOOLWSD::AdminCreds;
 
-int LOOLWSD::NumPreSpawnedChildren = 10;
+unsigned int LOOLWSD::NumPreSpawnedChildren = 0;
 bool LOOLWSD::DoTest = false;
 
 LOOLWSD::LOOLWSD()
@@ -997,6 +997,42 @@ void LOOLWSD::initialize(Application& self)
 }
 }
 
+if (Cache.empty())
+{
+Cache = getPathFromConfig("tile_cache_path");
+}
+
+if (SysTemplate.empty())
+{
+SysTemplate = getPathFromConfig("sys_template_path");
+}
+
+if (LoTemplate.empty())
+{
+LoTemplate = getPathFromConfig("lo_template_path");
+}
+
+if (ChildRoot.empty())
+{
+ChildRoot = getPathFromConfig("child_root_path");
+}
+
+if (LoSubPath.empty())
+{
+LoSubPath = getPathFromConfig("lo_jail_subpath");
+}
+
+if (FileServerRoot.empty())
+{
+FileServerRoot = getPathFromConfig("file_server_root_path");
+}
+
+if (NumPreSpawnedChildren == 0)
+{
+// Default to 10 children.
+NumPreSpawnedChildren = config().getUInt("num_prespawn_children", 10);
+}
+
 ServerApplication::initialize(self);
 }
 
diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index 76e5246..ea87f50 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -36,7 +36,7 @@ public:
 // An Application is a singleton anyway,
 // so just keep these as statics.
 static std::atomic NextSessionId;
-static int NumPreSpawnedChildren;
+static unsigned int NumPreSpawnedChildren;
 static int BrokerWritePipe;
 static bool DoTest;
 static std::string Cache;
@@ -73,6 +73,13 @@ private:
 std::string getPathFromConfig(const std::string& property) const
 {
 auto path = config().getString(property);
+if (path.empty() && config().hasProperty(property + "[@default]"))
+{
+// Use the default value if empty and a default provided.
+path = config().getString(property + "[@default]");
+}
+
+// Reconstruct absolute path if relative.
 if (config().hasProperty(property + "[@relative]") &&
 config().getBool(property + "[@relative]"))
 {
diff --git a/loolwsd/loolwsd.xml b/loolwsd/loolwsd.xml
index 96d7202..7d356b1 100644
--- a/loolwsd/loolwsd.xml
+++ b/loolwsd/loolwsd.xml
@@ -1,12 +1,13 @@
 
 
-1
-
+
+
 
-
+
 lo
-../loleaflet/
+
 
+1
 
 true
 trace
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/FileServer.hpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/FileServer.hpp |   24 
 loolwsd/LOOLWSD.cpp|2 ++
 2 files changed, 18 insertions(+), 8 deletions(-)

New commits:
commit 29c9ecba2a589417b0d5757e6169ba9c7d4332ea
Author: Ashod Nakashian 
Date:   Wed Apr 6 23:38:08 2016 -0400

loolwsd: deny access to directories outside of FileServerRoot

Change-Id: Iea92982ebd5f111c946eb1b12f5dfd7602fffd70
Reviewed-on: https://gerrit.libreoffice.org/23879
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index 2dbbc4c..5a79793 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -110,13 +110,14 @@ public:
 Poco::URI requestUri(request.getURI());
 std::vector requestSegments;
 requestUri.getPathSegments(requestSegments);
-
-// TODO: We might want to package all files from leaflet to some 
other dir and restrict
-// file serving to it (?)
-const std::string endPoint = 
requestSegments[requestSegments.size() - 1];
+if (requestSegments.size() < 1)
+{
+throw Poco::FileNotFoundException("Invalid file.");
+}
 
 if (request.getMethod() == HTTPRequest::HTTP_GET)
 {
+const std::string endPoint = 
requestSegments[requestSegments.size() - 1];
 if (endPoint == "admin.html" ||
 endPoint == "adminSettings.html" ||
 endPoint == "adminAnalytics.html")
@@ -125,7 +126,14 @@ public:
 throw Poco::Net::NotAuthenticatedException("Invalid 
admin login");
 }
 
-const std::string filePath = requestUri.getPath();
+const auto path = Poco::Path(LOOLWSD::FileServerRoot, 
requestUri.getPath());
+const auto filepath = path.absolute().toString();
+if (filepath.find(LOOLWSD::FileServerRoot) != 0)
+{
+// Accessing unauthorized path.
+throw Poco::FileNotFoundException("Invalid file path.");
+}
+
 const std::size_t extPoint = endPoint.find_last_of(".");
 if (extPoint == std::string::npos)
 throw Poco::FileNotFoundException("Invalid file.");
@@ -142,12 +150,12 @@ public:
 mimeType = "text/plain";
 
 response.setContentType(mimeType);
-response.sendFile(LOOLWSD::FileServerRoot + 
requestUri.getPath(), mimeType);
+response.sendFile(filepath, mimeType);
 }
 }
 catch (Poco::Net::NotAuthenticatedException& exc)
 {
-Log::info ("FileServerRequestHandler::NotAuthenticated");
+Log::error("FileServerRequestHandler::NotAuthenticated");
 response.set("WWW-Authenticate", "Basic realm=\"online\"");
 response.setStatus(HTTPResponse::HTTP_UNAUTHORIZED);
 response.setContentLength(0);
@@ -155,7 +163,7 @@ public:
 }
 catch (Poco::FileNotFoundException& exc)
 {
-Log::info("FileServerRequestHandler:: File " + request.getURI() + 
" not found.");
+Log::error("FileServerRequestHandler:: File [" + request.getURI() 
+ "] not found.");
 response.setStatus(HTTPResponse::HTTP_NOT_FOUND);
 response.setContentLength(0);
 response.send();
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 78b3915..91bbf4d 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1219,6 +1219,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 
 if (FileServerRoot.empty())
 FileServerRoot = 
Path(Application::instance().commandPath()).parent().parent().toString();
+FileServerRoot = Poco::Path(FileServerRoot).absolute().toString();
+Log::debug("FileServerRoot: " + FileServerRoot);
 
 if (ClientPortNumber == MASTER_PORT_NUMBER)
 throw IncompatibleOptionsException("port");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/FileServer.hpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp

[Ashod Nakashian]

 loolwsd/FileServer.hpp |   14 ++
 loolwsd/LOOLWSD.cpp|   29 +++--
 loolwsd/LOOLWSD.hpp|2 +-
 3 files changed, 38 insertions(+), 7 deletions(-)

New commits:
commit 1f88aede00b2b5a48e91d3cc652cb0a9ea0770ab
Author: Ashod Nakashian 
Date:   Wed Apr 6 23:36:54 2016 -0400

loolwsd: Admin Console credentials passed on the command line

A new command-line argument, admincreds, must be provided
to set the Admin Console credentials.

The new command-line argument specifies the username
and password in the following format: username/password

If not provided, Admin Console is disabled for security
reasons. A warning is emitted at startup and an error
on every invocation of Admin Console is logged when
no credentials are defined.

Change-Id: I348623949fd0b292f5066e4955759c708204540f
Reviewed-on: https://gerrit.libreoffice.org/23878
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index 52d4429..2dbbc4c 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -72,11 +72,17 @@ public:
 Log::info("Invalid JWT token, let the administrator re-login");
 }
 
-HTTPBasicCredentials credentials(request);
+const auto user = 
Application::instance().config().getString("admin_console_username", "");
+const auto pass = 
Application::instance().config().getString("admin_console_password", "");
+if (user.empty() || pass.empty())
+{
+Log::error("Admin Console credentials missing. Denying access 
until set.");
+return false;
+}
 
-// TODO: Read username and password from config file
-if (credentials.getUsername() == "admin"
-&& credentials.getPassword() == "admin")
+HTTPBasicCredentials credentials(request);
+if (credentials.getUsername() == user &&
+credentials.getPassword() == pass)
 {
 const std::string htmlMimeType = "text/html";
 // generate and set the cookie
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index ef4775c..78b3915 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -963,6 +963,7 @@ std::string LOOLWSD::LoTemplate;
 std::string LOOLWSD::ChildRoot;
 std::string LOOLWSD::LoSubPath = "lo";
 std::string LOOLWSD::FileServerRoot;
+std::string LOOLWSD::AdminCreds;
 
 int LOOLWSD::NumPreSpawnedChildren = 10;
 bool LOOLWSD::DoTest = false;
@@ -977,13 +978,25 @@ LOOLWSD::~LOOLWSD()
 
 void LOOLWSD::initialize(Application& self)
 {
-// load default configuration files, if present
+// Load default configuration files, if present.
 if (loadConfiguration() == 0)
 {
-std::string configPath = LOOLWSD_CONFIGDIR "/loolwsd.xml";
+// Fallback to the default path.
+const std::string configPath = LOOLWSD_CONFIGDIR "/loolwsd.xml";
 loadConfiguration(configPath);
 }
 
+if (!AdminCreds.empty())
+{
+// Set the Admin Console credentials, if provided.
+StringTokenizer tokens(AdminCreds, "/", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
+if (tokens.count() == 2)
+{
+config().setString("admin_console_username", tokens[0]);
+config().setString("admin_console_password", tokens[1]);
+}
+}
+
 ServerApplication::initialize(self);
 }
 
@@ -1084,6 +1097,11 @@ void LOOLWSD::defineOptions(OptionSet& optionSet)
 .repeatable(false)
 .argument("number"));
 
+optionSet.addOption(Option("admincreds", "", "Admin 'username/password' 
used to access the admin console.")
+.required(false)
+.repeatable(false)
+.argument("directory"));
+
 optionSet.addOption(Option("test", "", "Interactive testing.")
 .required(false)
 .repeatable(false));
@@ -1119,6 +1137,8 @@ void LOOLWSD::handleOption(const std::string& optionName, 
const std::string& val
 FileServerRoot = value;
 else if (optionName == "numprespawns")
 NumPreSpawnedChildren = std::stoi(value);
+else if (optionName == "admincreds")
+AdminCreds = value;
 else if (optionName == "test")
 LOOLWSD::DoTest = true;
 }
@@ -1206,6 +1226,11 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 if (LOOLWSD::DoTest)
 NumPreSpawnedChildren = 1;
 
+if (AdminCreds.empty())
+{
+Log::warn("No admin credentials set via 'admincreds' command-line 
argument. Admin Console will be disabled.");
+}
+
 const Path pipePath = Path::forDirectory(ChildRoot + Path::separator() + 
FIFO_PATH);
 if (!File(pipePath).exists() && !File(pipePath).createDirectory())
 {
diff 

[Libreoffice-commits] online.git: loolwsd/loolstat loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/LOOLWSD.cpp |8 
 loolwsd/loolstat|   11 +--
 2 files changed, 1 insertion(+), 18 deletions(-)

New commits:
commit d75bc16753d3550aff8c62b4d21fb0c395861ee7
Author: Ashod Nakashian 
Date:   Wed Apr 6 21:59:13 2016 -0400

loolwsd: removed loolwsd pid logging

loolstat now uses `pgrep loolwsd$` instead
of relying on pid dumping in a temp file.

With the Admin Console this tool (loolstat)
is less useful, so this cleanup is probably
a stepping stone to removing it altogether.

Change-Id: Ib7732a00c3d3ea54dffcb71e9fe1a56c4a88016e
Reviewed-on: https://gerrit.libreoffice.org/23877
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index adcde45..ef4775c 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -966,7 +966,6 @@ std::string LOOLWSD::FileServerRoot;
 
 int LOOLWSD::NumPreSpawnedChildren = 10;
 bool LOOLWSD::DoTest = false;
-static const std::string pidLog = "/tmp/loolwsd.pid";
 
 LOOLWSD::LOOLWSD()
 {
@@ -1207,13 +1206,6 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 if (LOOLWSD::DoTest)
 NumPreSpawnedChildren = 1;
 
-// log pid information
-{
-FileOutputStream filePID(pidLog);
-if (filePID.good())
-filePID << Process::id();
-}
-
 const Path pipePath = Path::forDirectory(ChildRoot + Path::separator() + 
FIFO_PATH);
 if (!File(pipePath).exists() && !File(pipePath).createDirectory())
 {
diff --git a/loolwsd/loolstat b/loolwsd/loolstat
index 57d2ba0..642c891 100755
--- a/loolwsd/loolstat
+++ b/loolwsd/loolstat
@@ -9,9 +9,6 @@ TOP='top'
 GREP='grep'
 PSTREE='pstree'
 
-# log pid file
-PIDLOG="/tmp/loolwsd.pid"
-
 # print error message
 log_failure_msg () {
   if [ -n "${1:-}" ]; then
@@ -54,14 +51,8 @@ if ! $TOP -v >/dev/null 2>&1; then
   log_failure_msg "$0: error: $TOP utility not found."
 fi
 
-# checking pid log file.
-if [ ! -f $PIDLOG ]; then
-   log_failure_msg "$0: error: $PIDLOG file not found."
-   exit 1;
-fi
-
 # get the loolwsd process id.
-LOOLWSD_PID=$(cat $PIDLOG);
+LOOLWSD_PID=`pgrep loolwsd$`;
 
 # checking if loolwsd is running.
 if ! $PS -p $LOOLWSD_PID > /dev/null; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/loolwsd.xml

[Ashod Nakashian]

 loolwsd/loolwsd.xml |   18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 05ec5054525cf7734de8753be9f8dd3971618806
Author: Ashod Nakashian 
Date:   Wed Apr 6 18:18:42 2016 -0400

loolwsd: added more configuration entries to loolwsd.xml

Change-Id: Iab5ef89b1e152605e6ea869d6c89192e824d92f2
Reviewed-on: https://gerrit.libreoffice.org/23876
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/loolwsd.xml b/loolwsd/loolwsd.xml
index d058910..96d7202 100644
--- a/loolwsd/loolwsd.xml
+++ b/loolwsd/loolwsd.xml
@@ -1,14 +1,24 @@
 
+
+1
+
+
+
+lo
+../loleaflet/
+
+
+true
+trace
+
+
 
 /etc/loolwsd/cert.pem
 /etc/loolwsd/key.pem
 /etc/loolwsd/CollaboraCloudSuiteCA_ca-chain.cert.pem
 
+
 
-
-loleaflet
-/tmp
-
 
 localhost
 0
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp

[Ashod Nakashian]

 loolwsd/LOOLWSD.cpp |   23 +++
 loolwsd/LOOLWSD.hpp |   16 
 2 files changed, 19 insertions(+), 20 deletions(-)

New commits:
commit e8ffea5d1c0d0f18334a6b07a804f66a251cf609
Author: Ashod Nakashian 
Date:   Wed Apr 6 18:17:59 2016 -0400

loolwsd: minor cleanup of path handling in config

Change-Id: I6a858e819372326ab582af91ad55a8e84b81608d
Reviewed-on: https://gerrit.libreoffice.org/23875
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 4a222e8..adcde45 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -990,30 +990,13 @@ void LOOLWSD::initialize(Application& self)
 
 void LOOLWSD::initializeSSL()
 {
-auto& conf = config();
-
-auto ssl_cert_file_path = conf.getString("ssl.cert_file_path");
-if (conf.getBool("ssl.cert_file_path[@relative]"))
-{
-ssl_cert_file_path = 
Poco::Path(Application::instance().commandPath()).parent().append(ssl_cert_file_path).toString();
-}
-
+const auto ssl_cert_file_path = getPathFromConfig("ssl.cert_file_path");
 Log::info("SSL Cert file: " + ssl_cert_file_path);
 
-auto ssl_key_file_path = conf.getString("ssl.key_file_path");
-if (conf.getBool("ssl.key_file_path[@relative]"))
-{
-ssl_key_file_path = 
Poco::Path(Application::instance().commandPath()).parent().append(ssl_key_file_path).toString();
-}
-
+const auto ssl_key_file_path = getPathFromConfig("ssl.key_file_path");
 Log::info("SSL Key file: " + ssl_key_file_path);
 
-auto ssl_ca_file_path = conf.getString("ssl.ca_file_path");
-if (conf.getBool("ssl.ca_file_path[@relative]"))
-{
-ssl_ca_file_path = 
Poco::Path(Application::instance().commandPath()).parent().append(ssl_ca_file_path).toString();
-}
-
+const auto ssl_ca_file_path = getPathFromConfig("ssl.ca_file_path");
 Log::info("SSL CA file: " + ssl_ca_file_path);
 
 Poco::Crypto::initializeCrypto();
diff --git a/loolwsd/LOOLWSD.hpp b/loolwsd/LOOLWSD.hpp
index 59d7111..f4964bb 100644
--- a/loolwsd/LOOLWSD.hpp
+++ b/loolwsd/LOOLWSD.hpp
@@ -65,6 +65,22 @@ private:
 void displayHelp();
 void displayVersion();
 Poco::Process::PID createBroker();
+
+/// Reads and processes path entries with the given property
+/// from the configuration.
+/// Converts relative paths to absolute.
+//TODO: Move to a better namespace.
+std::string getPathFromConfig(const std::string& property) const
+{
+auto path = config().getString(property);
+if (config().hasProperty(property + "[@relative]") &&
+config().getBool(property + "[@relative]"))
+{
+path = 
Poco::Path(Application::instance().commandPath()).parent().append(path).toString();
+}
+
+return path;
+}
 };
 
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 88277] Meta: SVG fileOpen filter (Draw)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88277

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99129

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99129] Some svg text can not be displayed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99129

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||88277

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99129] Some svg text can not be displayed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99129

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||filter:svgOpen
 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE
 Whiteboard||target:5.2.0

--- Comment #3 from V Stuart Foote  ---
Filter import (e.g. Open with Draw) of SVG text contained within TSPAN elements
as in this sample document has been implemented in current master for
5.2.0alpha0

See bug 32248 and 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc3eb865bd10e690dbf80f41277b062ac2253572

*** This bug has been marked as a duplicate of bug 32248 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99105] Can't close from DDE source fail

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99105

saltche...@yahoo.com changed:

   What|Removed |Added

Version|unspecified |5.0.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99133] New: GTK3 scrollbar not rendered when theme is Zukitwo

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99133

Bug ID: 99133
   Summary: GTK3 scrollbar not rendered when theme is Zukitwo
   Product: LibreOffice
   Version: 5.1.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ale.carrazz...@gmail.com

Created attachment 124143
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124143=edit
Screenshot showing missing scrollbar on the right

With the Zukitwo theme, Libreoffice 5.1.2 GTK3 does not show the scrollbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99132] GTK3 font size in UI too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99132

--- Comment #1 from ale.carrazz...@gmail.com ---
Created attachment 124142
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124142=edit
Screenshot showing UI with correct font size

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99132] New: GTK3 font size in UI too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99132

Bug ID: 99132
   Summary: GTK3 font size in UI too small
   Product: LibreOffice
   Version: 5.1.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ale.carrazz...@gmail.com

Created attachment 124141
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124141=edit
Screenshot showing small font size on UI

Libreoffice 5.1.2 with the GTK3 UI has a smaller font size than it should on
almost all UI elements. This is temporarily fixed by changing the GTK theme and
changing it back again, but restarting makes the font small again.

I'm attaching two screenshots, the first one shows Libreoffice with small font
size on the UI and the second one shows Libreoffice with the correct font size
on the UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes19' - include/sfx2 include/vcl sfx2/source vcl/source

[László Németh]

 include/sfx2/bindings.hxx|6 ++---
 include/vcl/idle.hxx |   13 +++
 sfx2/source/control/bindings.cxx |   45 +++
 vcl/source/app/idle.cxx  |   28 
 4 files changed, 71 insertions(+), 21 deletions(-)

New commits:
commit 0f60b62d972cfdebd6fcfc2ba8f0b6d94347967d
Author: László Németh 
Date:   Thu Apr 7 04:39:19 2016 +0200

Revert "Revert "process SfxBindings in idle""

This reverts commit 13e2133199a0fcfca79a21fa8be475d446b685d0.

diff --git a/include/sfx2/bindings.hxx b/include/sfx2/bindings.hxx
index bbe5cc4..4708ca2 100644
--- a/include/sfx2/bindings.hxx
+++ b/include/sfx2/bindings.hxx
@@ -44,7 +44,7 @@ class SfxItemSet;
 class SfxDispatcher;
 class SfxBindings;
 class SfxBindings_Impl;
-class Timer;
+class Idle;
 class SfxWorkWindow;
 class SfxUnoControllerItem;
 struct SfxFoundCache_Impl;
@@ -131,8 +131,8 @@ private:
 const SfxPoolItem *pItem,
 SfxItemState eItemState );
 SAL_DLLPRIVATE SfxStateCache* GetStateCache( sal_uInt16 nId, sal_uInt16 
*pPos);
-DECL_DLLPRIVATE_LINK_TYPED( NextJob, Timer *, void );
-SAL_DLLPRIVATE bool NextJob_Impl(Timer * pTimer);
+DECL_DLLPRIVATE_LINK_TYPED( NextJob, Idle *, void );
+SAL_DLLPRIVATE bool NextJob_Impl(Idle * pTimer);
 
 public:
  SfxBindings();
diff --git a/include/vcl/idle.hxx b/include/vcl/idle.hxx
index 5460d33..e3e7a99 100644
--- a/include/vcl/idle.hxx
+++ b/include/vcl/idle.hxx
@@ -27,6 +27,7 @@ class VCL_DLLPUBLIC Idle : public Scheduler
 {
 protected:
 Link maIdleHdl;  // Callback Link
+bool mbAuto;
 
 public:
 Idle( const sal_Char *pDebugName = nullptr );
@@ -39,12 +40,24 @@ public:
 voidSetIdleHdl( const Link& rLink ) { maIdleHdl 
= rLink; }
 const Link& GetIdleHdl() const { return maIdleHdl; }
 virtual void Invoke() override;
+virtual void SetDeletionFlags() override;
 virtual bool ReadyForSchedule( bool bTimerOnly, sal_uInt64 nTimeNow ) 
const override;
 virtual bool IsIdle() const override;
 virtual sal_uInt64 UpdateMinPeriod( sal_uInt64 nMinPeriod, sal_uInt64 
nTime ) const override;
 Idle&   operator=( const Idle& rIdle );
 };
 
+/// An auto-timer is a multi-shot timer re-emitting itself at
+/// interval until destroyed.
+class VCL_DLLPUBLIC AutoIdle : public Idle
+{
+public:
+AutoIdle();
+AutoIdle( const AutoIdle& rIdle );
+
+AutoIdle&  operator=( const AutoIdle& rIdle );
+};
+
 #endif // INCLUDED_VCL_IDLE_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index 5d13693..35f9f45 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -71,11 +71,11 @@ using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::util;
 
-static sal_uInt16 nTimeOut = 300;
+//static sal_uInt16 nTimeOut = 300;
 
-#define TIMEOUT_FIRST   nTimeOut
-#define TIMEOUT_UPDATING 20
-#define TIMEOUT_IDLE   2500
+//#define TIMEOUT_FIRST   nTimeOut
+//#define TIMEOUT_UPDATING 20
+//#define TIMEOUT_IDLE   2500
 
 typedef std::unordered_map< sal_uInt16, bool > InvalidateSlotMap;
 
@@ -218,7 +218,7 @@ public:
 boolbAllMsgDirty;   //  Has a MessageServer been 
invalidated?
 boolbAllDirty;  // After InvalidateAll
 boolbCtrlReleased;  // while EnterRegistrations
-AutoTimer   aTimer; // for volatile Slots
+AutoIdleaTimer; // for volatile Slots
 boolbInUpdate;  // for Assertions
 boolbInNextJob; // for Assertions
 boolbFirstRound;// First round in Update
@@ -253,7 +253,7 @@ SfxBindings::SfxBindings()
 // all caches are valid (no pending invalidate-job)
 // create the list of caches
 pImp->pCaches = new SfxStateCacheArr_Impl;
-pImp->aTimer.SetTimeoutHdl( LINK(this, SfxBindings, NextJob) );
+pImp->aTimer.SetIdleHdl( LINK(this, SfxBindings, NextJob) );
 }
 
 
@@ -708,7 +708,8 @@ void SfxBindings::InvalidateAll
 if ( !nRegLevel )
 {
 pImp->aTimer.Stop();
-pImp->aTimer.SetTimeout(TIMEOUT_FIRST);
+//pImp->aTimer.SetTimeout(TIMEOUT_FIRST);
+pImp->aTimer.SetPriority( SchedulerPriority::LOWER );
 pImp->aTimer.Start();
 }
 }
@@ -760,7 +761,8 @@ void SfxBindings::Invalidate
 if ( !nRegLevel )
 {
 pImp->aTimer.Stop();
-pImp->aTimer.SetTimeout(TIMEOUT_FIRST);
+//pImp->aTimer.SetTimeout(TIMEOUT_FIRST);
+pImp->aTimer.SetPriority( SchedulerPriority::LOWER );
 pImp->aTimer.Start();
 }
 }
@@ -814,7 +816,8 @@ void 

[Libreoffice-bugs] [Bug 99102] rendering of linejoin miter differs between edit mode and presentation mode if antialiasing is on

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99102

--- Comment #5 from Tomaz Vajngerl  ---
OpenGL rendering of polylines currently doesn't support miter limit (it doesn't
fallback to bevel at a certain angle) which is bad. When I'll implement this
then I'll make sure the document is rendered correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes19' - include/vcl vcl/source

[László Németh]

 include/vcl/scheduler.hxx|3 +--
 vcl/source/app/scheduler.cxx |6 ++
 vcl/source/app/svapp.cxx |7 +++
 3 files changed, 6 insertions(+), 10 deletions(-)

New commits:
commit 6da6d8cee72a8a6b4f784aff81eb66f4a1c39a31
Author: László Németh 
Date:   Thu Apr 7 04:37:36 2016 +0200

Revert "limit event processing for processEventsToIdle"

This reverts commit 46e0fb8714b747f1d710673c56d96bf9c3352913.

diff --git a/include/vcl/scheduler.hxx b/include/vcl/scheduler.hxx
index e9de235..a5f4059 100644
--- a/include/vcl/scheduler.hxx
+++ b/include/vcl/scheduler.hxx
@@ -96,8 +96,7 @@ public:
 static sal_uInt64 CalculateMinimumTimeout( bool ,
bool  bIgnoreLowPriority = 
false );
 /// Process one pending task ahead of time with highest priority.
-static bool   ProcessTaskScheduling( bool bTimerOnly, bool 
bEnableDisabledScheduler = false );
-
+static bool   ProcessTaskScheduling( bool bTimerOnly );
 /// Process all events until we are idle
 static void   ProcessEventsToIdle();
 };
diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx
index a1cd3f3..9cc8669 100644
--- a/vcl/source/app/scheduler.cxx
+++ b/vcl/source/app/scheduler.cxx
@@ -157,14 +157,12 @@ void Scheduler::CallbackTaskScheduling(bool ignore)
 Scheduler::ProcessTaskScheduling( false );
 }
 
-bool Scheduler::ProcessTaskScheduling( bool bTimerOnly, bool 
bEnableDisabledScheduler )
+bool Scheduler::ProcessTaskScheduling( bool bTimerOnly )
 {
 ImplSchedulerData* pSchedulerData;
 
 // tdf#91727 - NB. bTimerOnly is ultimately not used
-static bool bDisabledScheduler = !!getenv("SAL_DISABLE_SCHEDULER");
-
-if ((!bDisabledScheduler || bEnableDisabledScheduler) && (pSchedulerData = 
ImplSchedulerData::GetMostImportantTask(bTimerOnly)))
+if ((pSchedulerData = ImplSchedulerData::GetMostImportantTask(bTimerOnly)))
 {
 SAL_INFO("vcl.schedule", "Invoke task " << 
pSchedulerData->GetDebugName());
 
diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx
index fb5be8e..c9c2101 100644
--- a/vcl/source/app/svapp.cxx
+++ b/vcl/source/app/svapp.cxx
@@ -473,8 +473,7 @@ void Application::Execute()
 pSVData->maAppData.mbInAppExecute = false;
 }
 
-inline bool ImplYield(bool i_bWait, bool i_bAllEvents, sal_uLong const 
nReleased, bool bIgnoreLowPrio = false, bool bEnableDisabledScheduler = false )
-
+inline bool ImplYield(bool i_bWait, bool i_bAllEvents, sal_uLong const 
nReleased, bool bIgnoreLowPrio = false)
 {
 ImplSVData* pSVData = ImplGetSVData();
 
@@ -517,7 +516,7 @@ inline bool ImplYield(bool i_bWait, bool i_bAllEvents, 
sal_uLong const nReleased
 DBG_TESTSOLARMUTEX(); // must be locked on return from Yield
 
 // Process all Tasks
-Scheduler::ProcessTaskScheduling(eResult == SalYieldResult::EVENT, 
bEnableDisabledScheduler);
+Scheduler::ProcessTaskScheduling(eResult == SalYieldResult::EVENT);
 
 // flush lazy deleted objects
 if( pSVData->maAppData.mnDispatchLevel == 0 )
@@ -536,7 +535,7 @@ void Application::Reschedule( bool i_bAllEvents )
 void Scheduler::ProcessEventsToIdle()
 {
 int nSanity = 100;
-while(ImplYield(false, true, 0, true, true))
+while(ImplYield(false, true, 0, true))
 {
 if (nSanity-- < 0)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

--- Comment #7 from Joel Madero  ---
Created attachment 124140
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124140=edit
Preview Visible

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

Joel Madero  changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #6 from Joel Madero  ---
I'm not reproducing this on any version I try - exact reproducible steps would
be really nice.

Here's what I'm doing:
1) open draw;
2) View -> Clip Art Gallery
3) New Theme... (in sidebar)
4) Push Ok
+New theme created
5) open nemo file browswer;
6) drag a png from nemo to the gallery

Observed: I see a preview without an issue (will attach)

What am I missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/control/Toolbar.js  |4 
 loleaflet/src/layer/tile/TileLayer.js |4 
 loleaflet/src/map/handler/Map.FileInserter.js |3 +++
 3 files changed, 11 insertions(+)

New commits:
commit cec63101c5f5f14ce1bce449a3ba08fcfe4c88ea
Author: Henry Castro 
Date:   Wed Apr 6 20:48:12 2016 -0400

loleaflet: progress bar for document loading, saving, etc.

diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js
index 1488b7d..9ebdd4e 100644
--- a/loleaflet/src/control/Toolbar.js
+++ b/loleaflet/src/control/Toolbar.js
@@ -39,6 +39,8 @@ L.Map.include({
options = '';
}
id = id || -1; // not a special download
+
+   this.showBusy('Downloading...', false);
this._socket.sendMessage('downloadas ' +
'name=' + name + ' ' +
'id=' + id + ' ' +
@@ -47,6 +49,7 @@ L.Map.include({
},
 
print: function () {
+   this.showBusy('Downloading...', false);
this.downloadAs('print.pdf', 'pdf', null, 'print');
},
 
@@ -58,6 +61,7 @@ L.Map.include({
options = '';
}
 
+   this.showBusy('Saving...', false);
// TakeOwnership: we are performing a 'real' save-as, the 
document
// is just getting a new place, ie. it will get the
// '.uno:ModifiedStatus' upon completion.
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 1da6533..980f688 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -369,6 +369,7 @@ L.TileLayer = L.GridLayer.extend({
var url = this._map.options.webserver + '/' +
command.jail + '/' + command.dir + '/' + command.name;
 
+   this._map.hideBusy();
if (command.id === 'print') {
var isFirefox = typeof InstallTrigger !== 'undefined' 
|| navigator.userAgent.search('Firefox') >= 0;
if (isFirefox || this._map.options.print === false) {
@@ -624,8 +625,11 @@ L.TileLayer = L.GridLayer.extend({
else if (obj.success === 'false') {
success = false;
}
+
+   this._map.hideBusy();
// TODO when implemented in the LOK, add also obj.result
this._map.fire('commandresult', {commandName: commandName, 
success: success});
+
},
 
_onTextSelectionMsg: function (textMsg) {
diff --git a/loleaflet/src/map/handler/Map.FileInserter.js 
b/loleaflet/src/map/handler/Map.FileInserter.js
index 4484e45..3d76d78 100644
--- a/loleaflet/src/map/handler/Map.FileInserter.js
+++ b/loleaflet/src/map/handler/Map.FileInserter.js
@@ -49,8 +49,11 @@ L.Map.FileInserter = L.Handler.extend({
var url = this._url;
var xmlHttp = new XMLHttpRequest();
var socket = this._map._socket;
+   var map = this._map;
+   this._map.showBusy('Uploading...', false);
xmlHttp.onreadystatechange = function () {
if (xmlHttp.readyState === 4 && xmlHttp.status === 200) 
{
+   map.hideBusy();
socket.sendMessage('insertfile name=' + name + 
' type=graphic');
}
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98960] Crash with OpenGL image scaling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98960

--- Comment #5 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=641840dc0f63d23acceb7edd833f4a31f216009d

tdf#98960 - DrawTransformedTexture adapted to the new area scale shader

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/opengl

[Marco Cecchetti]

 vcl/opengl/gdiimpl.cxx |  162 +++--
 1 file changed, 130 insertions(+), 32 deletions(-)

New commits:
commit 641840dc0f63d23acceb7edd833f4a31f216009d
Author: Marco Cecchetti 
Date:   Wed Apr 6 13:59:50 2016 +0200

tdf#98960 - DrawTransformedTexture adapted to the new area scale shader

Change-Id: I7c911f2aaccbffacfa5673b120b6177b8bea0672
Reviewed-on: https://gerrit.libreoffice.org/23864
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 5773676..29ef7ca 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -1363,6 +1363,47 @@ void OpenGLSalGraphicsImpl::DrawTexture( OpenGLTexture& 
rTexture, const SalTwoRe
 mpProgram->Clean();
 }
 
+namespace {
+
+bool scaleTexture(const rtl::Reference< OpenGLContext > ,
+OpenGLTexture& rOutTexture, const double& ixscale, const double& iyscale, 
OpenGLTexture& rTexture)
+{
+int nWidth = rTexture.GetWidth();
+int nHeight = rTexture.GetHeight();
+int nNewWidth = nWidth / ixscale;
+int nNewHeight = nHeight / iyscale;
+
+OpenGLProgram* pProgram = xContext->UseProgram("textureVertexShader", 
OUString("areaScaleFragmentShader"));
+if (pProgram == nullptr)
+return false;
+
+OpenGLTexture aScratchTex(nNewWidth, nNewHeight);
+OpenGLFramebuffer* pFramebuffer = 
xContext->AcquireFramebuffer(aScratchTex);
+
+pProgram->SetUniform1f("xscale", ixscale);
+pProgram->SetUniform1f("yscale", iyscale);
+pProgram->SetUniform1i("swidth", nWidth);
+pProgram->SetUniform1i("sheight", nHeight);
+// For converting between <0,nWidth-1> and <0.0,1.0> coordinate systems.
+pProgram->SetUniform1f("xsrcconvert", 1.0 / (nWidth - 1));
+pProgram->SetUniform1f("ysrcconvert", 1.0 / (nHeight - 1));
+pProgram->SetUniform1f("xdestconvert", 1.0 * (nNewWidth - 1));
+pProgram->SetUniform1f("ydestconvert", 1.0 * (nNewHeight - 1));
+
+pProgram->SetTexture("sampler", rTexture);
+pProgram->DrawTexture(rTexture);
+pProgram->Clean();
+
+OpenGLContext::ReleaseFramebuffer(pFramebuffer);
+
+CHECK_GL_ERROR();
+
+rOutTexture = aScratchTex;
+return true;
+}
+
+}
+
 void OpenGLSalGraphicsImpl::DrawTransformedTexture(
 OpenGLTexture& rTexture,
 OpenGLTexture& rMask,
@@ -1377,10 +1418,6 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture(
 (float) rTexture.GetWidth(), 0, (float) rTexture.GetWidth(), (float) 
rTexture.GetHeight() };
 GLfloat aTexCoord[8];
 
-// If downscaling at a higher scale ratio, use the area scaling algorithm 
rather
-// than plain OpenGL's scaling, for better results.
-// See OpenGLSalBitmap::ImplScaleArea().
-
 const long nDestWidth = basegfx::fround(basegfx::B2DVector(rX - 
rNull).getLength());
 const long nDestHeight = basegfx::fround(basegfx::B2DVector(rY - 
rNull).getLength());
 
@@ -1388,19 +1425,24 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture(
 if( nDestHeight == 0 || nDestWidth == 0 )
 return;
 
-const double ixscale = rTexture.GetWidth()  / double(nDestWidth);
-const double iyscale = rTexture.GetHeight() / double(nDestHeight);
+// inverted scale ratios
+double ixscale = rTexture.GetWidth()  / double(nDestWidth);
+double iyscale = rTexture.GetHeight() / double(nDestHeight);
 
+// If downscaling at a higher scale ratio, use the area scaling algorithm 
rather
+// than plain OpenGL's scaling (texture mapping), for better results.
+// See OpenGLSalBitmap::ImplScaleArea().
 bool areaScaling = false;
 bool fastAreaScaling = false;
 OUString textureFragmentShader;
-if( ixscale >= 2 && iyscale >= 2 ) // Downscaling to 50% or less? 
(inverted scale ratios)
+if( ixscale >= 2 && iyscale >= 2 )  // scale ratio less than 50%
 {
 areaScaling = true;
 fastAreaScaling = ( ixscale == int( ixscale ) && iyscale == int( 
iyscale ));
-// The generic case has arrays only up to 100 ratio downscaling, which 
is hopefully enough
-// in practice, but protect against buffer overflows in case such an 
extreme case happens
-// (and in such case the precision of the generic algorithm probably 
doesn't matter anyway).
+// The generic case has arrays only up to 16 ratio downscaling and is 
performed in 2 passes,
+// when the ratio is in the 16-100 range, which is hopefully enough in 
practice, but protect
+// against buffer overflows in case such an extreme case happens (and 
in such case the precision
+// of the generic algorithm probably doesn't matter anyway).
 if( ixscale > 100 || iyscale > 100 )
 fastAreaScaling = true;
 if( fastAreaScaling )
@@ -1409,17 +1451,69 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture(
 textureFragmentShader = "areaScaleFragmentShader";
 }

Re: Broken master and newcomers.

[Norbert Thiebaud]

On Wed, Apr 6, 2016 at 6:14 PM, Anthonys Lists  wrote:
> On 07/04/2016 00:08, Norbert Thiebaud wrote:
>>>
>>> Imho, IF we do something like this, we should use the git facilities to
>>> >create a shallow clone backup, that people can then use ftp or rsync or
>>> > some
>>> >other interruptible protocol to download.
>>
>> We have been doing that for years:
>>
>> http://dev-www.libreoffice.org/bundles/
>>
> That should then make this whole discussion moot then? Just modify the
> instructtions to warn newcomers that master *can* be broken, and if they
> want a known-good build to start with, go and get a bundle rather than using
> clone. Once thye've got a good build they can "git pull" and go from there.

the bundle is not guarantee to build anymore than a random master...

It is just that we regularly (in fact is a cron iirc) tar-gz core.git
and other repo, precisely for people that have trouble doing a git
clone on a big repo

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Broken master and newcomers.

[Anthonys Lists]

On 07/04/2016 00:08, Norbert Thiebaud wrote:

Imho, IF we do something like this, we should use the git facilities to
>create a shallow clone backup, that people can then use ftp or rsync or some
>other interruptible protocol to download.

We have been doing that for years:

http://dev-www.libreoffice.org/bundles/

That should then make this whole discussion moot then? Just modify the 
instructtions to warn newcomers that master *can* be broken, and if they 
want a known-good build to start with, go and get a bundle rather than 
using clone. Once thye've got a good build they can "git pull" and go 
from there.


Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Broken master and newcomers.

[Norbert Thiebaud]

On Wed, Apr 6, 2016 at 5:58 PM, Anthonys Lists  wrote:
> On 06/04/2016 08:21, Bjoern Michaelsen wrote:
>>>
>>> An alternative (which I have seen used in another project), would be to
>>> let
>>> >jenkins generate a source tar ball, incl. the .git directory, of the
>>> > latest
>>> >sane build.
>>
>> No, thats horrible -- it make onboarding to git even harder.
>>
> What quite do you mean? If the tarball includes the .git directory, then
> it's effectively a clone, so they get a "known good" clone.
>
> That said, I'd rather not do that ...
>
> If we're going down that sort of route (and I had this discussion on the
> firebird list) then remember that "git clone" does not work well over a
> flaky internet connection, and if it bombs you typically have to restart
> from scratch. And flaky connections tend to be pay connections, making it an
> expensive business :-(
>
> Imho, IF we do something like this, we should use the git facilities to
> create a shallow clone backup, that people can then use ftp or rsync or some
> other interruptible protocol to download.


We have been doing that for years:

http://dev-www.libreoffice.org/bundles/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Broken master and newcomers.

[Anthonys Lists]

On 06/04/2016 08:21, Bjoern Michaelsen wrote:

An alternative (which I have seen used in another project), would be to let
>jenkins generate a source tar ball, incl. the .git directory, of the latest
>sane build.

No, thats horrible -- it make onboarding to git even harder.

What quite do you mean? If the tarball includes the .git directory, then 
it's effectively a clone, so they get a "known good" clone.


That said, I'd rather not do that ...

If we're going down that sort of route (and I had this discussion on the 
firebird list) then remember that "git clone" does not work well over a 
flaky internet connection, and if it bombs you typically have to restart 
from scratch. And flaky connections tend to be pay connections, making 
it an expensive business :-(


Imho, IF we do something like this, we should use the git facilities to 
create a shallow clone backup, that people can then use ftp or rsync or 
some other interruptible protocol to download. Where they go from there 
is then up to them, but this will also have the advantage of making it 
easier for people with poor internet to get on board ... :-)


Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99131] New: Alfred/Finder/Pathfinder will not open files; when opened the Title bar says Untitled 1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99131

Bug ID: 99131
   Summary: Alfred/Finder/Pathfinder will not open files; when
opened the Title bar says Untitled 1
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ro...@canhealyourself.com

Created attachment 124139
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124139=edit
text file created with LibreOffice that wont open except within LO

In all three "Finder"-type apps (Alfred, Finder, Pathfinder) some LibreOffice
files will not open. In PathFinder I get a message saying "There is no
application available to open the document ""

They will open within LIbreOffice itself without any error msg.

The GetInfo for all the files says "Application: LibreOffice" and the "Open
With" is "LibreOffice". I have tried changing all the default apps for opening
these files to LIbreOffice but it doesnt change any results.

When I open some of the files the title bar says "Untitled 1" although in the
Finder they have a name, the name I opened them from in the Folder. If I save
them they prompt me as though its a "Save As.." situation so I have to give
them a "new" name. 

I am not finding the extension for these files. 

Mac OSX 11.4, LIbreOffice 5.1.1.3, Latest versions of Alfred 2.8.3, PathFinder
7.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88257] XMLpath in FIlterxml does not work with arrayfunction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88257

--- Comment #10 from m.a.riosv  ---
Created attachment 124138
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124138=edit
New sample

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88257] XMLpath in FIlterxml does not work with arrayfunction

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88257

m.a.riosv  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 OS|Linux (All) |All

--- Comment #9 from m.a.riosv  ---
Sorry for the mistake.
Reviewing issue, it's clear that the function doesn't work properly. It doesn't
return an array where there are several values.

On the new sample attached
{=FILTERXML($A$3;"//book/title")}

Workaround it's call every row of data explicitly. 
{=FILTERXML($A$3;"//book["&(ROW()-6)&"]/title")}

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Broken master and newcomers.

[Norbert Thiebaud]

On Wed, Apr 6, 2016 at 1:04 AM, jan iversen  wrote:
> Hi.
>
> I experience quite frequently that new contributors follow the instructions, 
> but end up with a master that will not compile,

these day that is unlucky:


here are the stats for the last 14 days:

from:Wed Mar 23 21:30:24 2016
master linux rel  jobs: 296 ok: 282 ko:  11 fail ratio:  3.72 %
break:   9 broken duration: 2.12%
master linux dbg  jobs: 242 ok: 226 ko:  15 fail ratio:  6.20 %
break:  12 broken duration: 2.98%
master mac reljobs: 281 ok: 274 ko:   7 fail ratio:  2.49 %
break:   4 broken duration: 0.86%
master mac dbgjobs: 285 ok: 282 ko:   3 fail ratio:  1.05 %
break:   2 broken duration: 1.95%
master win reljobs: 222 ok: 212 ko:  10 fail ratio:  4.50 %
break:   4 broken duration: 1.00%
master win dbgjobs: 229 ok: 215 ko:  14 fail ratio:  6.11 %
break:   7 broken duration: 2.64%
master win64 dbg  jobs: 232 ok: 216 ko:  15 fail ratio:  6.47 %
break:   7 broken duration: 3.19%

broken duration is giving you the following info:
if you randomly pull master at any time in the period considered: what
was the odd that it was broken at that time
during the last 14 days your odd varied from 1 in a 115 for mac
releases build to 1 in 30 for windows64 dbg

let's look at windows dbg:

the last break right this minute on windows dbg was 1 day 9 hours ago
http://ci.libreoffice.org/job/lo_tb_master_win_dbg/5935/
"Device or resource busy"
either a parallelism problem in our build system or a bug in Windows.
master was not really red because of that.

the previous break was
http://ci.libreoffice.org/job/lo_tb_master_win_dbg/5915/
2 days 5 hours ago.. direct push by sberg

the one before was 2 hour earlier
http://ci.libreoffice.org/job/lo_tb_master_win_dbg/5913/

that one seems attributable to Windows crappy FS.

the one before that was
http://ci.libreoffice.org/job/lo_tb_master_win_dbg/5878/
5 days 13 hours ago, this one failed on win-dbg tb but passed Jenkins.


the one before that was 6 days 11 hours ago
http://ci.libreoffice.org/job/lo_tb_master_win_dbg/5851/
that was due to 41bdaa37cc62f656cc164992c4c7d39bec7e57e2 a direct push by noel


the one before that was 7 days 16 hr ago
and was not due to the commit.. but some jenkins <-> windows interaction problem
Note that these kind of 'break' would not actually impact someone
pulling master.
iow it is red in ci but not really red

so of the win dbg break... 3 where due to windows glitches. 1 was
properly vetted by Jenkins but still failed in that tinderbox
2 could have been avoided by using gerrit.

but in the end that is 3 real break in 2 weeks for a real red duration
of 2 hours 38 minutes that is 1 chance in 127 to get a random red
state.


so :"I experience quite frequently " seems to be a 'count the
his/ignore the misses' kind of thing.

IOW: my advice... let's keep nudging people to avail themselves of the
CI facility and avoid direct push...
that would have change the odd of a random red pull from 1 to 127 to 1
in 305 in this particular case.
but let's not forget that not that long ago it was easier to count how
often windows was buildable rather than hunt the commit where it was
not.

I also have another data point: the bibisect build: these are less
sensitive since I purposefully build them without Werror and I
purposfully do not run the checks
(the goal being to have binaries.. not to validate the build quality)


here are the result: this are the commit in bibisect that cover more
than 1 source commit. the number at the end of each line is the number
of unbuildable commit that are folded in that one bibisect commit

1dee09a4aa086524fd7704ad3dd6dc7e9ba201f4:1
1ebeb8fb59bfff5b9bdb3ac6db158c7c13e85e70:1
2a019e2b222ad49446c730bdbdea6c6651e36d91:1
3229e0f25f5d55d566208e42b276339a9c3c63c5:1
4c4af51cf6105e635feb206ea193f150f05e0edf:1
6d6a571cd180ee828ec8c8a5bd21a46d571d47ee:1
81168aee40fd18d7fcc475406f4c58ff7ba63455:1
8a70721672f5a1bce10547849435d7a0e286fb45:1
a54383ef92868298a368bcec871e5f2f2b2343b6:1
a9cca36433706038da0a51d6311da1bb77eb6112:1
e5c3bed99f2508b10833ccada394ce1abc37bf07:1
e72fd72eaea986ba41b8afff31ae9b77177fc685:1
f3ed988856fe00c5826781d97aaf2cae61f1abb7:1
4498e0cb3277ce65738acbc7c1faac43e9066430:2
6d46b870384fbfce0293a8fce41e373087ff681f:2
7b7852a9877e1123c60d5872ecf8ff0d78da45d7:2
ac5a57d70ad872f2dfe9d1bff73baa5318042e0e:2
b89bf27413eaf5cfab9a501a297756b8ef22eaa2:2
c6f1dc4f2407945334adef66c989f3878abc7043:2
cc822d9c6af1e8d6e937e23145471daf52ebd472:2
f73273c14261004eae364d06509b029c3a3883f2:2
45efc63eb004ebd2643cea9ebcdd810d0935bfa6:3
5de2c9cdc2e246e98ab43dde0baf14ca0947dd47:3
90fbb1101724c057d3c269f3b05f5584f701bb2f:3
b1d96f0e8acd28c6536896ed9aa70a88daa3f8fc:3
ba10b24c5f679cfcace557a920c83264b374e054:4
cebf63930f184875b7a04b3c95ad182554df5aa6:4
1d25fbbb38f0973147eda92bde66872b7cc974c0:5
1cb794851d2cbb56563a82b763da6c8a696dd465:6
326d9741e8236d3912ca55b0e9a7d4cee7b5a882:6

[Libreoffice-bugs] [Bug 99102] rendering of linejoin miter differs between edit mode and presentation mode if antialiasing is on

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99102

--- Comment #4 from Regina Henschel  ---
It seems, that the problem is, that anti-aliased line rendering uses directly
gdi+ without own decomposition. (Windows 7 here). And gdi+ handles miter limit
different from LibreOffice. And without anti-aliasing the own decomposition is
used, which switches from line join 'miter' to 'bevel', if the angle is too
small. 

In addition, there is a real bug in bool WinSalGraphicsImpl::drawPolyLine 
(line#2018).
   const Gdiplus::REAL aMiterLimit(15.0); 
   aPen.SetMiterLimit(aMiterLimit);
uses the default 15° MiterMinimum_Angle_, but gdi+ expects a MiterLimit, which
is the ratio of MiterLength to stroke-width. Correcting that error, I get
nearly the same cuts of the tips as rendered in PowerPoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99129] Some svg text can not be displayed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99129

MM  changed:

   What|Removed |Added

 OS|Windows (All)   |All

--- Comment #2 from MM  ---
If you use insert > image, the text is loaded correctly. Problem is when you
use 'open with ...' (draw, writer), then the text isn't shown. Thought I saw
this bug before, so searching a bit further...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99130] New: OpenGL Antialiasing of curve filled becomes polygon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99130

Bug ID: 99130
   Summary: OpenGL Antialiasing of curve filled becomes polygon
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jjonet...@yahoo.de

Created attachment 124137
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124137=edit
Curved area segment becomes linear with OpenGL antialiasing turned on

Error: With OpenGL rendering active curved filled area segment becomes polygon
when antialiasing turned on in high zoom levels.

OK: With OpenGL rendering off filled areas are round in high zoom levels

seems like limitation of OpenGL rendering. Since OpenGL has no curves.
OpenGL without antialiasing draws correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99008] Scolling ODT file freezes LibreOffice and the desktop session

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99008

--- Comment #15 from Yousuf (Jay) Philips  ---
(In reply to Stanislav from comment #14)
> Is it possible to port back this bug fix to 5.1.2 release?

Spoke with the release team and they said it wouldnt be feasible to build
another 5.1.2 release just for this fix, so you'll have to wait until 5.1.3 is
released or use 5.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97183] Blacked Toolbar Icon Background When Using Breeze Theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97183

--- Comment #11 from thanosshad...@yahoo.com ---
I don't see any difference regarding the blacked icons and the openGL

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99129] Some svg text can not be displayed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99129

--- Comment #1 from odinatlas  ---
Created attachment 124136
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124136=edit
Comparison

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99129] New: Some svg text can not be displayed in Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99129

Bug ID: 99129
   Summary: Some svg text can not be displayed in Draw
   Product: LibreOffice
   Version: 5.1.2.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: odinat...@gmail.com

Created attachment 124135
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124135=edit
StarOffice_major_derivatives

Some svg text can not be displayed in Draw.

Thank for you all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99128] 'Save As' Dialog Window should allow re-size (window mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99128

Rick Stockton  changed:

   What|Removed |Added

Version|unspecified |5.1.1.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99128] 'Save As' Dialog Window should allow re-size (window mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99128

--- Comment #1 from Rick Stockton  ---
Version: 5.1.1.3
Build ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
Locale: en-US (en_US)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99128] New: 'Save As' Dialog Window should allow re-size (window mode)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99128

Bug ID: 99128
   Summary: 'Save As' Dialog Window should allow re-size (window
mode)
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rickstock...@waldron-md.com

On Windows 7 (and perhaps other platforms), "Save As" Dialog Window is created
full-screen with borders. It cannot be resized and shows only a "Window Close"
Control. I am concerned primarily with "Writer", although other Components
probably share the same dialog.

This is a poor implementation, for two reasons:

First, it is desirable that the Window be reduced in size so that the user may
copy a filename from within the Document.

It is also desirable to reduce the Window size so that scrolling of the
directories can be more rapid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/dist loleaflet/src

[Henry Castro]

 loleaflet/dist/leaflet.css |   10 
 loleaflet/dist/loading.html|   35 +
 loleaflet/src/map/handler/Map.SlideShow.js |8 +-
 3 files changed, 52 insertions(+), 1 deletion(-)

New commits:
commit a06974e2b3e7c8186d2c599576021c927effad6c
Author: Henry Castro 
Date:   Wed Apr 6 15:23:50 2016 -0400

loleaflet: add loading spinner to slide show

diff --git a/loleaflet/dist/leaflet.css b/loleaflet/dist/leaflet.css
index 0fa0e5b..400246f 100644
--- a/loleaflet/dist/leaflet.css
+++ b/loleaflet/dist/leaflet.css
@@ -697,3 +697,13 @@ a.leaflet-control-buttons:hover:first-child {
 .leaflet-progress-label {
text-align: center;
}
+
+.leaflet-slideshow {
+   background: #FF;
+   }
+
+.leaflet-slideshow-spinner {
+   background-image: url(images/spinner.gif);
+   background-repeat: no-repeat;
+   background-position: center center;
+   }
diff --git a/loleaflet/dist/loading.html b/loleaflet/dist/loading.html
new file mode 100644
index 000..8c5cf1e
--- /dev/null
+++ b/loleaflet/dist/loading.html
@@ -0,0 +1,35 @@
+
+
+  
+
+
+
+  .body {
+background: #FF;
+  }
+  .spinner
+  {
+position: absolute;
+text-align: center;
+margin: auto;
+top: 0;
+right: 0;
+bottom: 0;
+left: 0;
+width: 100px;
+height: 100px;
+  }
+  .spinner img {
+display: block;
+margin-left: auto;
+margin-right: auto;
+  }
+
+  
+  
+
+  
+  Loading...
+
+  
+
diff --git a/loleaflet/src/map/handler/Map.SlideShow.js 
b/loleaflet/src/map/handler/Map.SlideShow.js
index 287699f..4b32b97 100644
--- a/loleaflet/src/map/handler/Map.SlideShow.js
+++ b/loleaflet/src/map/handler/Map.SlideShow.js
@@ -22,8 +22,14 @@ L.Map.SlideShow = L.Handler.extend({
this._map.off('slidedownloadready', this._onSlideDownloadReady, 
this);
},
 
+   _onIframeLoaded: function (e) {
+   L.DomUtil.removeClass(this._slideShow, 
'leaflet-slidshow-spinner');
+   },
+
_onFullScreen: function () {
-   this._slideShow = L.DomUtil.create('iframe', '', 
this._map._container);
+   this._slideShow = L.DomUtil.create('iframe', 'leaflet-slideshow 
leaflet-slidshow-spinner', this._map._container);
+   this._slideShow.src = this._map.options.webserver + 
'/loleaflet/dist/loading.html';
+   this._slideShow.onload = L.bind(this._onIframeLoaded, this);
if (this._slideShow.requestFullscreen) {
this._slideShow.requestFullscreen();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 47437] add a way to report missing words in the spell checker

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47437

--- Comment #4 from Kruno  ---
Well there is a list of maintainers...

It doesn't have to be complicated: right click to misspelled word already opens
context menu for suggestions and such. So it could be an entry "Report word to
a maintainer" and that could send an automated email with missing word... LO
knows which language is checking and it could cross-reference with that list
(by web or locally as xml that comes with installation).

LO can send mail directly in case of mail merge, maybe that could be used for
reporting words as well? Or it can open in dedicated e-mail client with
automated message and such.

I know this bug is old and it's probably still hard work to do that, but
couldn't help myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99127] New: Overlapping arrow key presses do not navigate correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99127

Bug ID: 99127
   Summary: Overlapping arrow key presses do not navigate
correctly
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: emo916m...@gmail.com

After updating from Ubuntu 12.04 LTS to 14.04 LTS and installing many software
updates, I discovered a bug which I hadn't encountered in previous versions of
LibreOffice.

1. Type a long line of characters followed by a blank line.
2. Place the typing cursor in the middle of the first line.
3. Press the Right and Down arrow keys in an overlapping manner (i.e. the Right
key is not released until after the Down key is pressed, but neither is held
long enough to trigger a repeated movement).
4. Press the Up arrow key.

One would expect the cursor to go back to the middle of line 1, as it does if
the Right, Down, and Up keys are pressed in discrete succession. However, it
goes instead to the beginning of line 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99068] Missing icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99068

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #4 from rob...@familiegrosskopf.de ---
(In reply to Brian from comment #3)
> Created attachment 124074 [details]
> No push button icon
> 
> Shows a form in edit mode, with all available form controls showing

Please show the following as screenshot:
Mouse on top of the toolbar > visible buttons
Your screenshot shows 13 buttons - must be 15!

Icon for push-button hasn't been gone here with OpenSUSE 42.1 64bit rpm Linux,
LO 5.1.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara]

 vcl/unx/gtk/gtkinst.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 157469896ef56720f33676222b95e81c04ab5c72
Author: Caolán McNamara 
Date:   Wed Apr 6 20:38:13 2016 +0100

caught on the way out as well as the way in

Change-Id: I436c057b8e81b9dff755f5fda2c137b2d16a9751

diff --git a/vcl/unx/gtk/gtkinst.cxx b/vcl/unx/gtk/gtkinst.cxx
index 368cdfb..a37102e 100644
--- a/vcl/unx/gtk/gtkinst.cxx
+++ b/vcl/unx/gtk/gtkinst.cxx
@@ -375,7 +375,7 @@ void GtkInstance::DestroyMenuItem( SalMenuItem* pItem )
 
 #else // not ENABLE_GMENU_INTEGRATION
 
-SalMenu* GtkInstance::CreateMenu( bool, Menu*, SystemWindow* ) { return 
nullptr; }
+SalMenu* GtkInstance::CreateMenu( bool, Menu* )  { return nullptr; 
}
 void GtkInstance::DestroyMenu( SalMenu* ){}
 SalMenuItem* GtkInstance::CreateMenuItem( const SalItemParams* ) { return 
nullptr; }
 void GtkInstance::DestroyMenuItem( SalMenuItem* ){}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: download.lst external/hunspell

[Caolán McNamara]

 download.lst   |2 
 external/hunspell/UnpackedTarball_hunspell.mk  |   10 -
 external/hunspell/hunspell-1.3.2-literal.patch |   11 -
 external/hunspell/hunspell-1.3.2-nullptr.patch |   20 --
 external/hunspell/hunspell-1.3.2-overflow.patch|   91 --
 external/hunspell/hunspell-1.3.3-rhbz1261421.patch |  191 -
 external/hunspell/hunspell-android.patch   |   20 --
 external/hunspell/hunspell-fdo48017-wfopen.patch   |   19 --
 external/hunspell/hunspell-morph-overflow.patch|   30 ---
 external/hunspell/hunspell-tdf95024-compound.patch |  108 ---
 external/hunspell/hunspell-windows.patch   |   21 ++
 external/hunspell/ubsan.patch.0|   35 ---
 12 files changed, 23 insertions(+), 535 deletions(-)

New commits:
commit ce9e8630b4df2f515bd77d77b3450890b87de30a
Author: Caolán McNamara 
Date:   Wed Apr 6 16:25:33 2016 +0100

bump hunspell to 1.3.4

Change-Id: If7c4868c4296d1ca0e485dc06fdf3472e2e8653f
Reviewed-on: https://gerrit.libreoffice.org/23863
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/download.lst b/download.lst
index 23ec620..21c95b1 100644
--- a/download.lst
+++ b/download.lst
@@ -61,7 +61,7 @@ export GRAPHITE_TARBALL := 
4311dd9ace498b57c85f611e0670df64-graphite2-minimal-1.
 export HARFBUZZ_MD5SUM := 0e27e531f4c4acff601ebff0957755c2
 export HARFBUZZ_TARBALL := harfbuzz-0.9.40.tar.bz2
 export HSQLDB_TARBALL := 17410483b5b5f267aa18b7e00b65e6e0-hsqldb_1_8_0.zip
-export HUNSPELL_TARBALL := 
4967da60b23413604c9e563beacc63b4-hunspell-1.3.3.tar.gz
+export HUNSPELL_TARBALL := 
423cff69e68c87ac11e4aa8462951954-hunspell-1.3.4.tar.gz
 export HYPHEN_TARBALL := 5ade6ae2a99bc1e9e57031ca88d36dad-hyphen-2.8.8.tar.gz
 export ICU_TARBALL := c4a2d71ff56aec5ebfab2a3f059be99d-icu4c-56_1-src.tgz
 export JFREEREPORT_FLOW_ENGINE_TARBALL := 
ba2930200c9f019c2d93a8c88c651a0f-flow-engine-0.9.4.zip
diff --git a/external/hunspell/UnpackedTarball_hunspell.mk 
b/external/hunspell/UnpackedTarball_hunspell.mk
index 8f14062..e70e33f 100644
--- a/external/hunspell/UnpackedTarball_hunspell.mk
+++ b/external/hunspell/UnpackedTarball_hunspell.mk
@@ -13,15 +13,7 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,hunspell,$(HUNSPELL_TARBALL)))
 
 $(eval $(call gb_UnpackedTarball_add_patches,hunspell,\
external/hunspell/hunspell-solaris.patch \
-   external/hunspell/hunspell-1.3.2-overflow.patch \
-   external/hunspell/hunspell-android.patch \
-   external/hunspell/hunspell-1.3.2-nullptr.patch \
-   external/hunspell/hunspell-1.3.2-literal.patch \
-   external/hunspell/hunspell-fdo48017-wfopen.patch \
-   external/hunspell/hunspell-morph-overflow.patch \
-   external/hunspell/ubsan.patch.0 \
-   external/hunspell/hunspell-1.3.3-rhbz1261421.patch \
-   external/hunspell/hunspell-tdf95024-compound.patch \
+   external/hunspell/hunspell-windows.patch \
 ))
 
 ifeq ($(COM),MSC)
diff --git a/external/hunspell/hunspell-1.3.2-literal.patch 
b/external/hunspell/hunspell-1.3.2-literal.patch
deleted file mode 100644
index b0a8fb9..000
--- a/external/hunspell/hunspell-1.3.2-literal.patch
+++ /dev/null
@@ -1,11 +0,0 @@
 misc/hunspell-1.3.2/src/tools/hunspell.cxx 2012-08-13 12:09:06.107017665 
+0200
-+++ misc/build/hunspell-1.3.2/src/tools/hunspell.cxx   2012-08-13 
12:14:12.233500532 +0200
-@@ -20,7 +20,7 @@
- #define HUNSPELL_VERSION VERSION
- #define INPUTLEN 50
- 
--#define HUNSPELL_PIPE_HEADING "@(#) International Ispell Version 3.2.06 (but 
really Hunspell "VERSION")\n"
-+#define HUNSPELL_PIPE_HEADING "@(#) International Ispell Version 3.2.06 (but 
really Hunspell " VERSION ")\n"
- #define HUNSPELL_HEADING "Hunspell "
- #define ODF_EXT "odt|ott|odp|otp|odg|otg|ods|ots"
- #define ENTITY_APOS ""
diff --git a/external/hunspell/hunspell-1.3.2-nullptr.patch 
b/external/hunspell/hunspell-1.3.2-nullptr.patch
deleted file mode 100644
index 624e6ce..000
--- a/external/hunspell/hunspell-1.3.2-nullptr.patch
+++ /dev/null
@@ -1,20 +0,0 @@
 misc/hunspell-1.3.2/src/hunspell/affentry.hxx  2010-04-15 
13:22:08.0 +0200
-+++ misc/build/hunspell-1.3.2/src/hunspell/affentry.hxx2012-08-13 
12:08:48.568996730 +0200
-@@ -27,7 +27,7 @@
-   struct hentry *  checkword(const char * word, int len, char 
in_compound, 
- const FLAG needflag = FLAG_NULL);
- 
--  struct hentry *  check_twosfx(const char * word, int len, char 
in_compound, const FLAG needflag = NULL);
-+  struct hentry *  check_twosfx(const char * word, int len, char 
in_compound, const FLAG needflag = FLAG_NULL);
- 
-   char *  check_morph(const char * word, int len, char in_compound,
- const FLAG needflag = FLAG_NULL);
-@@ -90,7 +90,7 @@
- //const FLAG 

[Libreoffice-bugs] [Bug 98729] Crash when opening ODT with formulas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98729

Terrence Enger  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected
 CC||lo_b...@iseries-guru.com

--- Comment #10 from Terrence Enger  ---
I am changing keyword bibisectRequest to bisected.

Doing a *reverse* bibisect in the daily Win dbgutil bibisect
repository 5.2, I see, from `git bisect good` (newline added) ...

8df61b71a38cbab777e01c47efdbdaaa1bd78b2f is the first bad commit
commit 8df61b71a38cbab777e01c47efdbdaaa1bd78b2f
Author: Norbert Thiebaud 
Date:   Fri Mar 18 23:52:12 2016 -0700

source sha:c5bee7b8c1055e5052a261c8755bdb150fb27494

source sha:c5bee7b8c1055e5052a261c8755bdb150fb27494

:04 04 191f04fad31a645fcac64a4fc7c8a08fdeb440b1
45718f74574dc6d5d5f46f50
afc5c0c95cce761f M  instdir

and from `git bisect log` (newlines added) ..,

# bad: [36d3af4cdd8285ce7a7d8db5088029686dea7368]
source sha:f7a75a66fa46627aa6e
dc6439650c1e3c06836d7
# good: [1f670510f08cb800cbae2a1dd6ea70d3542e4721]
source sha:49c2b9808df8a6b197
dec666dfc0cda6321a4306
git bisect start '36d3af4' 'oldest'
# good: [246ffd82f06402d47674dd166825c9a8f7e7641e]
source sha:0dfcb858c1e863f6df
225ae774bb567f8cfe00c9
git bisect good 246ffd82f06402d47674dd166825c9a8f7e7641e
# good: [0c01da0451c0040c5223a383452ee54fbad76049]
source sha:0ba96ffcd8ee2296b5
a30451a9310b5b097df514
git bisect good 0c01da0451c0040c5223a383452ee54fbad76049
# good: [ec163e0900b8419627b045624a6a6a17ec41fb9c]
source sha:0ce8320eeb1df7eb4f
54774e92c2b0e5488570e3
git bisect good ec163e0900b8419627b045624a6a6a17ec41fb9c
# bad: [aee8f9ea3aa4122ca04050cce006676cf6412b16]
source sha:5de18e6a1fe643f1cf1
5b8456587208ecb11e1c5
git bisect bad aee8f9ea3aa4122ca04050cce006676cf6412b16
# bad: [addad37cb62bc46f6c8b7ec4a747b16572dc9cd3]
source sha:00fa85e701d4a8984cf
a3a24c9b7a3963b031fa0
git bisect bad addad37cb62bc46f6c8b7ec4a747b16572dc9cd3
# bad: [14a7a9d7d9052d35e3250c8eb8d5bd6eb85dfdc9]
source sha:5b3fee11f4019820cc1
212a0441020609418dbf1
git bisect bad 14a7a9d7d9052d35e3250c8eb8d5bd6eb85dfdc9
# bad: [8b4019841c4ac319b29b877bd6dfc731b686c702]
source sha:4af2f26a955d172e8b7
2579c9bc6534e98b9f72b
git bisect bad 8b4019841c4ac319b29b877bd6dfc731b686c702
# bad: [8df61b71a38cbab777e01c47efdbdaaa1bd78b2f]
source sha:c5bee7b8c1055e5052a
261c8755bdb150fb27494
git bisect bad 8df61b71a38cbab777e01c47efdbdaaa1bd78b2f
# good: [ab39d3bd1481ea69213e7e6a6b6cae7566df747c]
source sha:89e0663c55f7f17635
36a345d6315c71ef26
git bisect good ab39d3bd1481ea69213e7e6a6b6cae7566df747c
# good: [a95a9688c324d85a78a2950da8e102cb643d8c4b]
source sha:d41c44f9048e1877c1
29704842a0c59e90dce3d8
git bisect good a95a9688c324d85a78a2950da8e102cb643d8c4b
# good: [89b229b6430575a128cb817eb343a2ab7d7a1073]
source sha:1edbb90c9e9296bec3
3f4c590f3133160b7f9702
git bisect good 89b229b6430575a128cb817eb343a2ab7d7a1073
# good: [14e59a915a12742b0ef6152452692f6df23046d5]
source sha:73443fd27881183765
0160482c34c15e8830f0d3
git bisect good 14e59a915a12742b0ef6152452692f6df23046d5
# first bad commit: [8df61b71a38cbab777e01c47efdbdaaa1bd78b2f]
source sha:c5bee7
b8c1055e5052a261c8755bdb150fb27494

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/filter/ww8/wrtww8.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 2105f5b4403fcda7cdadbd108d6578ca759af219
Author: Stephan Bergmann 
Date:   Wed Apr 6 21:08:45 2016 +0200

Elide const var

Change-Id: Idbbfd0f3e8fc96550c99a0750ff466629d6007bf

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index a038aa1..81a9f2d 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -3375,7 +3375,6 @@ void WW8Export::ExportDocument_Impl()
 
 void WW8Export::PrepareStorage()
 {
-static const char pName[] = "Microsoft Word-Document";
 static const sal_uInt8 pData[] =
 {
 0x01, 0x00, 0xFE, 0xFF, 0x03, 0x0A, 0x00, 0x00,
@@ -3401,7 +3400,8 @@ void WW8Export::PrepareStorage()
 };
 
 SvGlobalName aGName(MSO_WW8_CLASSID);
-GetWriter().GetStorage().SetClass( aGName, SotClipboardFormatId::NONE, 
pName);
+GetWriter().GetStorage().SetClass(
+aGName, SotClipboardFormatId::NONE, "Microsoft Word-Document");
 tools::SvRef xStor( 
GetWriter().GetStorage().OpenSotStream(sCompObj) );
 xStor->Write( pData, sizeof( pData ) );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/filter/ww8/wrtww8.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6720da5d7a59323df6fde12b2a24e548d6a9b812
Author: Stephan Bergmann 
Date:   Wed Apr 6 21:07:09 2016 +0200

loplugin:stringconstant

Change-Id: I0285ba64213bfd5180e09a40ea6fdf4b210f431b

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 06697ce..a038aa1 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -3401,7 +3401,7 @@ void WW8Export::PrepareStorage()
 };
 
 SvGlobalName aGName(MSO_WW8_CLASSID);
-GetWriter().GetStorage().SetClass( aGName, SotClipboardFormatId::NONE, 
OUString::createFromAscii( pName ));
+GetWriter().GetStorage().SetClass( aGName, SotClipboardFormatId::NONE, 
pName);
 tools::SvRef xStor( 
GetWriter().GetStorage().OpenSotStream(sCompObj) );
 xStor->Write( pData, sizeof( pData ) );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96896] Writer crashes when frame title is changed via API and user closes print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96896

akash...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97183] Blacked Toolbar Icon Background When Using Breeze Theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97183

--- Comment #10 from raal  ---
(In reply to thanosshadow5 from comment #9)
> Okay, how do I do this?

in terminal
export SAL_USE_VCLPLUGIN=gtk

check:
printenv | grep SAL

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90229] PROPERTIES : not able to edit the author of the document field

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90229

Yann974  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo

--- Comment #2 from Yann974  ---
That would be a great enhancement for, at least, scientists (papers with
several authors).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/Admin.cpp loolwsd/FileServer.hpp

[Jan Holesovsky]

 loolwsd/Admin.cpp  |   33 ++
 loolwsd/FileServer.hpp |  114 +
 2 files changed, 74 insertions(+), 73 deletions(-)

New commits:
commit 204a9c742f921816a1a5b658a40d9f43390223ac
Author: Jan Holesovsky 
Date:   Wed Apr 6 20:14:03 2016 +0200

loolwsd: Allow asking for credentials even during websocket setup.

It may happen that admin.html is cached, which leads to the cookie not being
set up, which then leads to endless amount of attempts to log in.

diff --git a/loolwsd/Admin.cpp b/loolwsd/Admin.cpp
index 275434e..83d0312 100644
--- a/loolwsd/Admin.cpp
+++ b/loolwsd/Admin.cpp
@@ -30,6 +30,7 @@
 #include "Admin.hpp"
 #include "AdminModel.hpp"
 #include "Common.hpp"
+#include "FileServer.hpp"
 #include "TileCache.hpp"
 #include "Storage.hpp"
 #include "LOOLProtocol.hpp"
@@ -347,34 +348,10 @@ void 
AdminRequestHandler::handleRequest(HTTPServerRequest& request, HTTPServerRe
 
 if (request.find("Upgrade") != request.end() && 
Poco::icompare(request["Upgrade"], "websocket") == 0)
 {
-if (request.find("Cookie") != request.end())
-{
-// FIXME: Handle other cookie params like '; httponly; secure'
-const std::size_t pos = request["Cookie"].find_first_of("=");
-if (pos == std::string::npos)
-throw Poco::Net::NotAuthenticatedException("Missing JWT");
-
-const std::string jwtToken = request["Cookie"].substr(pos + 1);
-Log::info("Verifying JWT token: " + jwtToken);
-// TODO: Read key from configuration file
-const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
-JWTAuth authAgent(keyPath, "admin", "admin", "admin");
-if (authAgent.verify(jwtToken))
-{
-Log::trace("JWT token is valid");
-handleWSRequests(request, response, nSessionId);
-}
-else
-{
-Log::info("Invalid JWT token");
-throw Poco::Net::NotAuthenticatedException("Invalid 
Token");
-}
-}
-else
-{
-Log::info("Missing authentication cookie. Handshake 
declined.");
-throw Poco::Net::NotAuthenticatedException("Missing token");
-}
+if (!FileServerRequestHandler::isAdminLoggedIn(request, response))
+throw Poco::Net::NotAuthenticatedException("Invalid admin 
login");
+
+handleWSRequests(request, response, nSessionId);
 }
 }
 catch(const Poco::Net::NotAuthenticatedException& exc)
diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index c1c8dd7..52d4429 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -48,6 +48,55 @@ using Poco::Util::Application;
 class FileServerRequestHandler: public HTTPRequestHandler
 {
 public:
+/// Evaluate if the cookie exists, and if not, ask for the credentials.
+static bool isAdminLoggedIn(HTTPServerRequest& request, 
HTTPServerResponse& response)
+{
+if (request.find("Cookie") != request.end())
+{
+// FIXME: Handle other cookie params like '; httponly; secure'
+const std::size_t pos = request["Cookie"].find_first_of("=");
+if (pos == std::string::npos)
+throw Poco::Net::NotAuthenticatedException("Missing JWT");
+
+const std::string jwtToken = request["Cookie"].substr(pos + 1);
+Log::info("Verifying JWT token: " + jwtToken);
+// TODO: Read key from configuration file
+const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
+JWTAuth authAgent(keyPath, "admin", "admin", "admin");
+if (authAgent.verify(jwtToken))
+{
+Log::trace("JWT token is valid");
+return true;
+}
+
+Log::info("Invalid JWT token, let the administrator re-login");
+}
+
+HTTPBasicCredentials credentials(request);
+
+// TODO: Read username and password from config file
+if (credentials.getUsername() == "admin"
+&& credentials.getPassword() == "admin")
+{
+const std::string htmlMimeType = "text/html";
+// generate and set the cookie
+// TODO: Read key from configuration file
+const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
+JWTAuth authAgent(keyPath, "admin", "admin", "admin");
+const std::string jwtToken = authAgent.getAccessToken();
+Poco::Net::HTTPCookie cookie("jwt", jwtToken);
+cookie.setPath("/adminws/");
+cookie.setSecure(true);
+cookie.setHttpOnly(true);
+response.addCookie(cookie);
+
+   

[Libreoffice-commits] online.git: Branch 'distro/collabora/cloudsuite-rc1' - loolwsd/Admin.cpp loolwsd/FileServer.hpp

[Jan Holesovsky]

 loolwsd/Admin.cpp  |   33 ++
 loolwsd/FileServer.hpp |  114 +
 2 files changed, 74 insertions(+), 73 deletions(-)

New commits:
commit c31c6fb29314cc6931e8f29071fe788bb75a1094
Author: Jan Holesovsky 
Date:   Wed Apr 6 20:14:03 2016 +0200

loolwsd: Allow asking for credentials even during websocket setup.

It may happen that admin.html is cached, which leads to the cookie not being
set up, which then leads to endless amount of attempts to log in.

diff --git a/loolwsd/Admin.cpp b/loolwsd/Admin.cpp
index 2ad3d3d..ce7b4aa 100644
--- a/loolwsd/Admin.cpp
+++ b/loolwsd/Admin.cpp
@@ -30,6 +30,7 @@
 #include "Admin.hpp"
 #include "AdminModel.hpp"
 #include "Common.hpp"
+#include "FileServer.hpp"
 #include "TileCache.hpp"
 #include "Storage.hpp"
 #include "LOOLProtocol.hpp"
@@ -347,34 +348,10 @@ void 
AdminRequestHandler::handleRequest(HTTPServerRequest& request, HTTPServerRe
 
 if (request.find("Upgrade") != request.end() && 
Poco::icompare(request["Upgrade"], "websocket") == 0)
 {
-if (request.find("Cookie") != request.end())
-{
-// FIXME: Handle other cookie params like '; httponly; secure'
-const std::size_t pos = request["Cookie"].find_first_of("=");
-if (pos == std::string::npos)
-throw Poco::Net::NotAuthenticatedException("Missing JWT");
-
-const std::string jwtToken = request["Cookie"].substr(pos + 1);
-Log::info("Verifying JWT token: " + jwtToken);
-// TODO: Read key from configuration file
-const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
-JWTAuth authAgent(keyPath, "admin", "admin", "admin");
-if (authAgent.verify(jwtToken))
-{
-Log::trace("JWT token is valid");
-handleWSRequests(request, response, nSessionId);
-}
-else
-{
-Log::info("Invalid JWT token");
-throw Poco::Net::NotAuthenticatedException("Invalid 
Token");
-}
-}
-else
-{
-Log::info("Missing authentication cookie. Handshake 
declined.");
-throw Poco::Net::NotAuthenticatedException("Missing token");
-}
+if (!FileServerRequestHandler::isAdminLoggedIn(request, response))
+throw Poco::Net::NotAuthenticatedException("Invalid admin 
login");
+
+handleWSRequests(request, response, nSessionId);
 }
 }
 catch(const Poco::Net::NotAuthenticatedException& exc)
diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index c1c8dd7..52d4429 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -48,6 +48,55 @@ using Poco::Util::Application;
 class FileServerRequestHandler: public HTTPRequestHandler
 {
 public:
+/// Evaluate if the cookie exists, and if not, ask for the credentials.
+static bool isAdminLoggedIn(HTTPServerRequest& request, 
HTTPServerResponse& response)
+{
+if (request.find("Cookie") != request.end())
+{
+// FIXME: Handle other cookie params like '; httponly; secure'
+const std::size_t pos = request["Cookie"].find_first_of("=");
+if (pos == std::string::npos)
+throw Poco::Net::NotAuthenticatedException("Missing JWT");
+
+const std::string jwtToken = request["Cookie"].substr(pos + 1);
+Log::info("Verifying JWT token: " + jwtToken);
+// TODO: Read key from configuration file
+const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
+JWTAuth authAgent(keyPath, "admin", "admin", "admin");
+if (authAgent.verify(jwtToken))
+{
+Log::trace("JWT token is valid");
+return true;
+}
+
+Log::info("Invalid JWT token, let the administrator re-login");
+}
+
+HTTPBasicCredentials credentials(request);
+
+// TODO: Read username and password from config file
+if (credentials.getUsername() == "admin"
+&& credentials.getPassword() == "admin")
+{
+const std::string htmlMimeType = "text/html";
+// generate and set the cookie
+// TODO: Read key from configuration file
+const std::string keyPath = "/etc/loolwsd/" + 
std::string(SSL_KEY_FILE);
+JWTAuth authAgent(keyPath, "admin", "admin", "admin");
+const std::string jwtToken = authAgent.getAccessToken();
+Poco::Net::HTTPCookie cookie("jwt", jwtToken);
+cookie.setPath("/adminws/");
+cookie.setSecure(true);
+cookie.setHttpOnly(true);
+response.addCookie(cookie);
+
+   

Re: Broken master and newcomers.

[Bjoern Michaelsen]

Hi,

On Wed, Apr 06, 2016 at 07:08:06PM +0200, jan iversen wrote:
> > http://people.canonical.com/~bjoern/presentations/tb3.odp
> > http://people.canonical.com/~bjoern/presentations/tb3-2014.odp
> > https://gerrit.libreoffice.org/gitweb?p=tb3-django.git;a=summary
> > https://gerrit.libreoffice.org/gitweb?p=tb3-docker.git;a=summary
> > 
> > for some abandoned work I did for that. I gave up on it as with 
> > gerrit/Jenkins, master
> > state seemed 'good enough' to me.
> 
> Interesting.

also (just found that in the attic):

https://www.youtube.com/watch?v=J2Thx4f_QvI

to maybe make some sense of what I was trying to do ...

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97183] Blacked Toolbar Icon Background When Using Breeze Theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97183

--- Comment #9 from thanosshad...@yahoo.com ---
Okay, how do I do this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/data/document.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit b6ba851c02570c17e0484c94065a2e72c5675e58
Author: Eike Rathke 
Date:   Wed Apr 6 14:38:54 2016 +0100

(re)broadcast, same as in ScDocument::SetString(), tdf#97897 related

As with ce28d83912d14bc81c455af64893842de78a8c8d

Change-Id: I7cd30509138368d73b43c82d71d520d55417d416

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 936e476..67a882a 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3379,6 +3379,11 @@ void ScDocument::SetValue( const ScAddress& rPos, double 
fVal )
 
 SetNeedsListeningGroups(aGroupPos);
 StartNeededListeners();
+
+// Listeners may just have been setup that are affected by the current
+// position thus were not notified by a ScColumn::BroadcastNewCell()
+// during ScTable::SetValue(), so do it here.
+Broadcast( ScHint( SC_HINT_DATACHANGED, rPos));
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99126] Save doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99126

--- Comment #1 from Douglas Mencken  ---
Which format do you try?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98334] Installation hangs in OS X after package verification in CoreServicesUIAgent with high CPU

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98334

Manfred  changed:

   What|Removed |Added

Version|5.1.0.3 release |5.0.5.2 release

--- Comment #6 from Manfred  ---
changed to Version 5.0.5 at earliest affected
changed importance to critical (no Mac-User can install any newer Version)

Maybe only a problem with Mac OS 10.10 Yosemite?
But a blocker for newer versions for all this users.

Installations I could not open are 5.0.5, 5.1, 5.1.1003

Last working Version is 5.0.4.2
Build-ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78
Gebietsschema: de-DE (de.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - include/sfx2 sfx2/source

[Stephan Bergmann]

 include/sfx2/sfxbasemodel.hxx|6 +++---
 include/sfx2/sidebar/EnumContext.hxx |4 ++--
 sfx2/source/notify/globalevents.cxx  |   22 +++---
 sfx2/source/sidebar/EnumContext.cxx  |   12 ++--
 4 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit 6a37ea928d2c0ef9dd7fd7031b3e4e6341a162e2
Author: Stephan Bergmann 
Date:   Wed Apr 6 19:25:20 2016 +0200

Avoid reserved identifiers

Change-Id: I57d2efee3e89a2793d0b9620c894a14f8970f284

diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx
index 638d9e8..8e678ca 100644
--- a/include/sfx2/sfxbasemodel.hxx
+++ b/include/sfx2/sfxbasemodel.hxx
@@ -586,9 +586,9 @@ public:
 //  XDocumentEventBroadcaster
 
 
-virtual void SAL_CALL addDocumentEventListener( const css::uno::Reference< 
css::document::XDocumentEventListener >& _Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
-virtual void SAL_CALL removeDocumentEventListener( const 
css::uno::Reference< css::document::XDocumentEventListener >& _Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
-virtual void SAL_CALL notifyDocumentEvent( const OUString& _EventName, 
const css::uno::Reference< css::frame::XController2 >& _ViewController, const 
css::uno::Any& _Supplement ) throw (css::lang::IllegalArgumentException, 
css::lang::NoSupportException, css::uno::RuntimeException, std::exception) 
override;
+virtual void SAL_CALL addDocumentEventListener( const css::uno::Reference< 
css::document::XDocumentEventListener >& Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
+virtual void SAL_CALL removeDocumentEventListener( const 
css::uno::Reference< css::document::XDocumentEventListener >& Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
+virtual void SAL_CALL notifyDocumentEvent( const OUString& EventName, 
const css::uno::Reference< css::frame::XController2 >& ViewController, const 
css::uno::Any& Supplement ) throw (css::lang::IllegalArgumentException, 
css::lang::NoSupportException, css::uno::RuntimeException, std::exception) 
override;
 
 
 //  XUnoTunnel
diff --git a/sfx2/source/notify/globalevents.cxx 
b/sfx2/source/notify/globalevents.cxx
index 960890d..0711b66 100644
--- a/sfx2/source/notify/globalevents.cxx
+++ b/sfx2/source/notify/globalevents.cxx
@@ -105,9 +105,9 @@ public:
 throw(css::uno::RuntimeException, std::exception) override;
 
 // css.document.XDocumentEventBroadcaster
-virtual void SAL_CALL addDocumentEventListener( const css::uno::Reference< 
css::document::XDocumentEventListener >& _Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
-virtual void SAL_CALL removeDocumentEventListener( const 
css::uno::Reference< css::document::XDocumentEventListener >& _Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
-virtual void SAL_CALL notifyDocumentEvent( const OUString& _EventName, 
const css::uno::Reference< css::frame::XController2 >& _ViewController, const 
css::uno::Any& _Supplement ) throw (css::lang::IllegalArgumentException, 
css::lang::NoSupportException, css::uno::RuntimeException, std::exception) 
override;
+virtual void SAL_CALL addDocumentEventListener( const css::uno::Reference< 
css::document::XDocumentEventListener >& Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
+virtual void SAL_CALL removeDocumentEventListener( const 
css::uno::Reference< css::document::XDocumentEventListener >& Listener ) throw 
(css::uno::RuntimeException, std::exception) override;
+virtual void SAL_CALL notifyDocumentEvent( const OUString& EventName, 
const css::uno::Reference< css::frame::XController2 >& ViewController, const 
css::uno::Any& Supplement ) throw (css::lang::IllegalArgumentException, 
css::lang::NoSupportException, css::uno::RuntimeException, std::exception) 
override;
 
 // css.document.XEventListener
 virtual void SAL_CALL notifyEvent(const css::document::EventObject& aEvent)
@@ -202,17 +202,17 @@ void SAL_CALL 
SfxGlobalEvents_Impl::removeEventListener(const uno::Reference< do
 }
 
 
-void SAL_CALL SfxGlobalEvents_Impl::addDocumentEventListener( const 
uno::Reference< document::XDocumentEventListener >& _Listener )
+void SAL_CALL SfxGlobalEvents_Impl::addDocumentEventListener( const 
uno::Reference< document::XDocumentEventListener >& Listener )
 throw(uno::RuntimeException, std::exception)
 {
-m_aDocumentListeners.addInterface( _Listener );
+m_aDocumentListeners.addInterface( Listener );
 }
 
 
-void SAL_CALL SfxGlobalEvents_Impl::removeDocumentEventListener( const 
uno::Reference< document::XDocumentEventListener >& _Listener )
+void SAL_CALL SfxGlobalEvents_Impl::removeDocumentEventListener( const 
uno::Reference< document::XDocumentEventListener >& Listener )
 throw(uno::RuntimeException, std::exception)
 {
-

[Libreoffice-bugs] [Bug 98622] Formula (Math object) is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98622

--- Comment #15 from Stanislav  ---
Thank you very much for your work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99126] New: Save doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99126

Bug ID: 99126
   Summary: Save doesn't work
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fulvio.per...@mnetwork.it

I can't save any job (either write or calc)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99060] Table copied from one document does not replace table in another

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99060

--- Comment #11 from Kruno  ---
Can't reproduce on

Linux jessie 3.16.0-4-686-pae #1 SMP Debian 3.16.7-ckt25-1 (2016-03-06) i686
GNU/Linux

with

Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: en_US.UTF-8

It's the same operating system, difference is in processor, LO version and
desktop environment: first test is under KDE (from Debian Jessie official
repository), and this one is Cinnamon (from Debian Jessie official repository).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Broken master and newcomers.

[jan iversen]

> 
> That idea is old -- and yes, having it directly in as a note, tag or brach git
> would be awesome. Personally, I would love to see a "master-ci-verfied" 
> _branch_
> that is following the master branch up to the point that is known good by CI. 
> A
> branch has the advantage that it would allow newcomers to locally rebase their
> commit from one known good state to the next easily.
> 
> However, nothing like that has been implemted yet. So: go go go.

The idea of a branch triggered ideas. Having a special "tinderbox" that 
regulary (e.g. once a day) controls master and if it builds (at least on linux) 
merges changes to a fix branch, is something easy to do.

Just today we saw a new contributor having problems due to master being broken, 
and some of us used time to identify what the problem was.

So IMHO having this feature will save time, meaning I could use time to 
implement it.

> 
> 
>> An alternative (which I have seen used in another project), would be to let
>> jenkins generate a source tar ball, incl. the .git directory, of the latest
>> sane build.
> 
> No, thats horrible -- it make onboarding to git even harder.
> 
>> I know many will say, but master is sometimes broken, you have to live with
>> that. That is a statement I agree with, for anything else than the first
>> build.
> 
> Nah, the argument was rather: If we have a last 'known good master' everyone
> will use that (including the people who broke master) and nobody will use the
> HEAD of master anymore (nor will those that broke master).
> 
> My guess is that we need automating bisecting on master to really pin down the
> guilty in these cases. See:

If we had a "check master tinderbox", it could probably easy do the bibisecting 
automatically (going from last known stable build).

> 
> http://people.canonical.com/~bjoern/presentations/tb3.odp
> http://people.canonical.com/~bjoern/presentations/tb3-2014.odp
> https://gerrit.libreoffice.org/gitweb?p=tb3-django.git;a=summary
> https://gerrit.libreoffice.org/gitweb?p=tb3-docker.git;a=summary
> 
> for some abandoned work I did for that. I gave up on it as with 
> gerrit/Jenkins, master
> state seemed 'good enough' to me.

Interesting.

> Heh, hanging those high that break master and didnt verify on Jenkins before 
> --
> esp. now that it is trivial?

New headline for ESC, top master breakers :-)

rgds
jan i.

> 
> Best,
> 
> Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99087] Closing Fullscreen leaves you a black screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99087

Call_me_Tom  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #7 from Call_me_Tom  ---
Version: 5.2.0.0.alpha0+
Build ID: b87c4d8a7539c6b36250adc5626f13458a4c3016
CPU Threads: 4; OS Version: Mac OS X 10.11.4; UI Render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-04-06_06:14:15
Locale: en-US (en.UTF-8)

Can reproduce bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99087] Closing Fullscreen leaves you a black screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99087

--- Comment #6 from Call_me_Tom  ---
Created attachment 124133
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124133=edit
Blackout Screen Shot

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99125] New: Property ParaBackColor in Writer can no longer be set via Basic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99125

Bug ID: 99125
   Summary: Property ParaBackColor in Writer can no longer be set
via Basic
   Product: LibreOffice
   Version: 4.4.6.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gerhard.we...@t-online.de

Since at least release 4.4.6 the property ParaBackColor in Writer cannot be
set.
A simple test: in a writer document with at least one paragraph execute the
code:

Sub Main
firstParagraph = Thiscomponent.text.createEnumeration.nextElement
firstParagraph.setPropertyValue("ParaBackColor", RGB(39,0,119))
'or:firstParagraph.ParaBackColor = RGB(39,0,119)
msgbox firstParagraph.ParaBackColor
End Sub

The results are:
- in the document the paragraph is coloured
- the msgbox returns -1
- after saving, closing and reopening the document the colour is no longer
visible, consistent with the msgbox return.

This worked in older versions of LibreOffice and still works in Apache
OpenOffice 4.1.2.
It still does not work in LO 5.1.1.
Similar settings for CharColor and CharBackColor do work as usual (but these
operate on a lower enumeration level).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99087] Closing Fullscreen leaves you a black screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99087

--- Comment #5 from gu...@openmailbox.org ---
ersion: 5.2.0.0.alpha0+
Build ID: 70dad291a6baf1eff59b61f9d344c10018585dd4
CPU Threads: 4; OS Version: Mac OS X 10.11.4; UI Render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-03-22_23:49:26
Locale: en-US (en.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99087] Closing Fullscreen leaves you a black screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99087

gu...@openmailbox.org changed:

   What|Removed |Added

Version|unspecified |5.2.0.0.alpha0+ Master

--- Comment #4 from gu...@openmailbox.org ---
OS X 10.11.4 rMBP 13", early 2015, 8GB RAM

I've also been able to immolate this bug.  I can close get rid of the black
screen by closing that screen using 3 finger gesture and hitting X next to the
window.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98961] German Spelling Mistake in 'About' screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98961

Kü  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 Whiteboard||target:5.1.3; target:5.2.0

--- Comment #2 from Kü  ---
Thanks for reporting!

I fixed it in Pootle for 5.1 and master.

It will be correct in version 5.1.3 and 5.2.0 of LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98622] Formula (Math object) is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98622

--- Comment #14 from raal  ---
(In reply to Stanislav from comment #13)
> No bug in LibreOfficeDev 5.1.3.0.0 on Debian GNU/Linux x86-64
> (2016-03-31_08.31.30).
> 
> Is it possible to port back this bug fix to 5.1.2 release?

No, see release plan
https://wiki.documentfoundation.org/ReleasePlan/5.1

5.1.3 will be available in May.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Douglas Mencken]

 sw/source/filter/ww8/wrtww8.cxx |   42 +++-
 1 file changed, 20 insertions(+), 22 deletions(-)

New commits:
commit 871f49e7fadb863b55c96c3f58ea7cc8fb033b40
Author: Douglas Mencken 
Date:   Thu Mar 31 09:04:29 2016 -0400

convert blob's hex bytes to ascii symbols

plus drop some auxiliary variables & assignments

Change-Id: I2e9243fb70b46ada46cee09197ba4cecbc62e7fd
Reviewed-on: https://gerrit.libreoffice.org/23701
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 3fbc18b..06697ce 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -3375,37 +3375,35 @@ void WW8Export::ExportDocument_Impl()
 
 void WW8Export::PrepareStorage()
 {
-sal_uLong nLen;
-const sal_uInt8* pData;
-const char* pName;
-
-static const char aUserName[] = "Microsoft Word-Document";
-static const sal_uInt8 aCompObj[] =
+static const char pName[] = "Microsoft Word-Document";
+static const sal_uInt8 pData[] =
 {
 0x01, 0x00, 0xFE, 0xFF, 0x03, 0x0A, 0x00, 0x00,
 0xFF, 0xFF, 0xFF, 0xFF, 0x06, 0x09, 0x02, 0x00,
 0x00, 0x00, 0x00, 0x00, 0xC0, 0x00, 0x00, 0x00,
-0x00, 0x00, 0x00, 0x46, 0x18, 0x00, 0x00, 0x00,
-0x4D, 0x69, 0x63, 0x72, 0x6F, 0x73, 0x6F, 0x66,
-0x74, 0x20, 0x57, 0x6F, 0x72, 0x64, 0x2D, 0x44,
-0x6F, 0x6B, 0x75, 0x6D, 0x65, 0x6E, 0x74, 0x00,
-0x0A, 0x00, 0x00, 0x00, 0x4D, 0x53, 0x57, 0x6F,
-0x72, 0x64, 0x44, 0x6F, 0x63, 0x00, 0x10, 0x00,
-0x00, 0x00, 0x57, 0x6F, 0x72, 0x64, 0x2E, 0x44,
-0x6F, 0x63, 0x75, 0x6D, 0x65, 0x6E, 0x74, 0x2E,
-0x38, 0x00, 0xF4, 0x39, 0xB2, 0x71, 0x00, 0x00,
-0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-0x00, 0x00
-};
+0x00, 0x00, 0x00, 0x46,
+
+0x18, 0x00, 0x00, 0x00,
+'M', 'i', 'c', 'r', 'o', 's', 'o', 'f',
+'t', ' ', 'W', 'o', 'r', 'd', '-', 'D',
+'o', 'k', 'u', 'm', 'e', 'n', 't', 0x0,
 
-pName = aUserName;
-pData = aCompObj;
-nLen = sizeof( aCompObj );
+0x0A, 0x00, 0x00, 0x00,
+'M', 'S', 'W', 'o', 'r', 'd', 'D', 'o',
+'c', 0x0,
+
+0x10, 0x00, 0x00, 0x00,
+'W', 'o', 'r', 'd', '.', 'D', 'o', 'c',
+'u', 'm', 'e', 'n', 't', '.', '8', 0x0,
+
+0xF4, 0x39, 0xB2, 0x71, 0x00, 0x00, 0x00, 0x00,
+0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
+};
 
 SvGlobalName aGName(MSO_WW8_CLASSID);
 GetWriter().GetStorage().SetClass( aGName, SotClipboardFormatId::NONE, 
OUString::createFromAscii( pName ));
 tools::SvRef xStor( 
GetWriter().GetStorage().OpenSotStream(sCompObj) );
-xStor->Write( pData, nLen );
+xStor->Write( pData, sizeof( pData ) );
 
 SwDocShell* pDocShell = m_pDoc->GetDocShell ();
 OSL_ENSURE(pDocShell, "no SwDocShell");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98622] Formula (Math object) is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98622

--- Comment #13 from Stanislav  ---
No bug in LibreOfficeDev 5.1.3.0.0 on Debian GNU/Linux x86-64
(2016-03-31_08.31.30).

Is it possible to port back this bug fix to 5.1.2 release?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99008] Scolling ODT file freezes LibreOffice and the desktop session

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99008

--- Comment #14 from Stanislav  ---
No bug in LibreOfficeDev 5.1.3.0.0 on Debian GNU/Linux x86-64
(2016-03-31_08.31.30).

Is it possible to port back this bug fix to 5.1.2 release?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98783] gtk3: menubar is missing when editing object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98783

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/source include/vcl vcl/inc vcl/osx vcl/source vcl/unx vcl/win

[Caolán McNamara]

 framework/source/layoutmanager/layoutmanager.cxx |4 ---
 framework/source/uielement/menubarwrapper.cxx|   28 +--
 framework/source/uifactory/menubarfactory.cxx|   11 +
 include/vcl/menu.hxx |3 --
 vcl/inc/osx/salinst.h|2 -
 vcl/inc/salinst.hxx  |3 --
 vcl/inc/unx/gtk/gtkinst.hxx  |2 -
 vcl/inc/unx/gtk/gtksalmenu.hxx   |2 -
 vcl/inc/win/salinst.h|2 -
 vcl/osx/salmenu.cxx  |2 -
 vcl/source/app/salvtables.cxx|2 -
 vcl/source/window/menu.cxx   |   15 +---
 vcl/unx/gtk/gtkinst.cxx  |   19 +--
 vcl/unx/gtk/gtksalmenu.cxx   |   28 +++
 vcl/win/window/salmenu.cxx   |2 -
 15 files changed, 47 insertions(+), 78 deletions(-)

New commits:
commit 95b720f6d7ba2639c06ba07c3f70aca871a45950
Author: Caolán McNamara 
Date:   Wed Apr 6 16:18:13 2016 +0100

revert to fix tdf#98783 missing menubar

Change-Id: Ia322149a7ed461f528af856d9907fe4620f9e97f

diff --git a/framework/source/layoutmanager/layoutmanager.cxx 
b/framework/source/layoutmanager/layoutmanager.cxx
index e7bbd0f..e676170 100644
--- a/framework/source/layoutmanager/layoutmanager.cxx
+++ b/framework/source/layoutmanager/layoutmanager.cxx
@@ -726,13 +726,11 @@ Reference< XUIElement > 
LayoutManager::implts_createElement( const OUString& aNa
 Reference< ui::XUIElement > xUIElement;
 
 SolarMutexGuard g;
-Sequence< PropertyValue > aPropSeq( 3 );
+Sequence< PropertyValue > aPropSeq( 2 );
 aPropSeq[0].Name = "Frame";
 aPropSeq[0].Value <<= m_xFrame;
 aPropSeq[1].Name = "Persistent";
 aPropSeq[1].Value <<= sal_True;
-aPropSeq[2].Name = "Container";
-aPropSeq[2].Value <<= m_xContainerWindow;
 
 try
 {
diff --git a/framework/source/uielement/menubarwrapper.cxx 
b/framework/source/uielement/menubarwrapper.cxx
index 4cd6730..cc5820c 100644
--- a/framework/source/uielement/menubarwrapper.cxx
+++ b/framework/source/uielement/menubarwrapper.cxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include "../layoutmanager/helpers.hxx"
 
 using namespace com::sun::star;
 using namespace com::sun::star::uno;
@@ -123,20 +122,6 @@ void SAL_CALL MenuBarWrapper::initialize( const Sequence< 
Any >& aArguments ) th
 OUString aModuleIdentifier;
 UIConfigElementWrapperBase::initialize( aArguments );
 
-bool bMenuOnly( false );
-Reference< XWindow > xContainerWindow;
-for ( sal_Int32 n = 0; n < aArguments.getLength(); n++ )
-{
-PropertyValue aPropValue;
-if ( aArguments[n] >>= aPropValue )
-{
-if ( aPropValue.Name == "MenuOnly" )
-aPropValue.Value >>= bMenuOnly;
-else if ( aPropValue.Name == "Container" )
-aPropValue.Value >>= xContainerWindow;
-}
-}
-
 Reference< XFrame > xFrame( m_xWeakFrame );
 if ( xFrame.is() && m_xConfigSource.is() )
 {
@@ -145,7 +130,7 @@ void SAL_CALL MenuBarWrapper::initialize( const Sequence< 
Any >& aArguments ) th
 VCLXMenuBar*pAwtMenuBar = nullptr;
 {
 SolarMutexGuard aSolarMutexGuard;
-pVCLMenuBar = new 
MenuBar(getTopSystemWindow(xContainerWindow));
+pVCLMenuBar = new MenuBar();
 }
 
 Reference< XModuleManager2 > xModuleManager = 
ModuleManager::create( m_xContext );
@@ -174,6 +159,17 @@ void SAL_CALL MenuBarWrapper::initialize( const Sequence< 
Any >& aArguments ) th
 {
 }
 
+bool bMenuOnly( false );
+for ( sal_Int32 n = 0; n < aArguments.getLength(); n++ )
+{
+PropertyValue aPropValue;
+if ( aArguments[n] >>= aPropValue )
+{
+if ( aPropValue.Name == "MenuOnly" )
+aPropValue.Value >>= bMenuOnly;
+}
+}
+
 if ( !bMenuOnly )
 {
 // Initialize menubar manager with our vcl menu bar. There are 
some situations where we only want to get the menu without any
diff --git a/framework/source/uifactory/menubarfactory.cxx 
b/framework/source/uifactory/menubarfactory.cxx
index 13025ad..e9d9f79 100644
--- a/framework/source/uifactory/menubarfactory.cxx
+++ b/framework/source/uifactory/menubarfactory.cxx
@@ -34,7 +34,6 @@
 #include 
 
 using namespace com::sun::star::uno;
-using namespace com::sun::star::awt;
 using namespace com::sun::star::lang;
 using namespace com::sun::star::frame;
 using namespace com::sun::star::beans;
@@ -75,7 +74,6 @@ void MenuBarFactory::CreateUIElement(const 

[Libreoffice-bugs] [Bug 98783] gtk3: menubar is missing when editing object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98783

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98783] gtk3: menubar is missing when editing object

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98783

--- Comment #2 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=95b720f6d7ba2639c06ba07c3f70aca871a45950

revert to fix tdf#98783 missing menubar

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

[Stephan Bergmann]

 include/sfx2/sidebar/Theme.hxx |   20 ++--
 sfx2/source/sidebar/Theme.cxx  |   40 
 2 files changed, 30 insertions(+), 30 deletions(-)

New commits:
commit d02a015593fc129d55e03e2b6d4caacd4e6d3787
Author: Stephan Bergmann 
Date:   Wed Apr 6 17:07:43 2016 +0200

Avoid reserved identifiers

Change-Id: I5a4415c1f722cfd57d07f656e235a824b5ef521c

diff --git a/include/sfx2/sidebar/Theme.hxx b/include/sfx2/sidebar/Theme.hxx
index 6cec998..2e12de3 100644
--- a/include/sfx2/sidebar/Theme.hxx
+++ b/include/sfx2/sidebar/Theme.hxx
@@ -60,10 +60,10 @@ class SFX2_DLLPUBLIC Theme
 public:
 enum ThemeItem
 {
-__Begin,
-__Pre_Image = __Begin,
+Begin_,
+Pre_Image_ = Begin_,
 
-__AnyItem = __Pre_Image,
+AnyItem_ = Pre_Image_,
 
 Image_Grip,
 Image_Expand,
@@ -73,7 +73,7 @@ public:
 Image_Closer,
 Image_CloseIndicator,
 
-__Image_Color,
+Image_Color_,
 
 Color_DeckTitleFont,
 Color_PanelTitleFont,
@@ -83,7 +83,7 @@ public:
 Color_Highlight,
 Color_HighlightText,
 
-__Color_Paint,
+Color_Paint_,
 
 Paint_DeckBackground,
 Paint_DeckTitleBarBackground,
@@ -100,7 +100,7 @@ public:
 Paint_ToolBoxBorderBottomRight,
 Paint_DropDownBackground,
 
-__Paint_Int,
+Paint_Int_,
 
 Int_DeckTitleBarHeight,
 Int_DeckBorderSize,
@@ -120,18 +120,18 @@ public:
 Int_TabBarBottomPadding,
 Int_ButtonCornerRadius,
 
-__Int_Bool,
+Int_Bool_,
 
 Bool_UseSystemColors,
 Bool_IsHighContrastModeActive,
 
-__Bool_Rect,
+Bool_Rect_,
 
 Rect_ToolBoxPadding,
 Rect_ToolBoxBorder,
 
-__Post_Rect,
-__End=__Post_Rect
+Post_Rect_,
+End_=Post_Rect_
 };
 
 static Image GetImage (const ThemeItem eItem);
diff --git a/sfx2/source/sidebar/Theme.cxx b/sfx2/source/sidebar/Theme.cxx
index 241767b..6c6b357 100644
--- a/sfx2/source/sidebar/Theme.cxx
+++ b/sfx2/source/sidebar/Theme.cxx
@@ -448,7 +448,7 @@ void SAL_CALL Theme::setPropertyValue (
 aOldValue,
 rValue);
 
-if (DoVetoableListenersVeto(GetVetoableListeners(__AnyItem, false), 
aEvent))
+if (DoVetoableListenersVeto(GetVetoableListeners(AnyItem_, false), aEvent))
 return;
 if (DoVetoableListenersVeto(GetVetoableListeners(eItem, false), aEvent))
 return;
@@ -456,7 +456,7 @@ void SAL_CALL Theme::setPropertyValue (
 maRawValues[eItem] = rValue;
 ProcessNewValue(rValue, eItem, eType);
 
-BroadcastPropertyChange(GetChangeListeners(__AnyItem, false), aEvent);
+BroadcastPropertyChange(GetChangeListeners(AnyItem_, false), aEvent);
 BroadcastPropertyChange(GetChangeListeners(eItem, false), aEvent);
 }
 
@@ -486,7 +486,7 @@ void SAL_CALL Theme::addPropertyChangeListener(
 css::lang::WrappedTargetException,
 css::uno::RuntimeException, std::exception)
 {
-ThemeItem eItem (__AnyItem);
+ThemeItem eItem (AnyItem_);
 if (rsPropertyName.getLength() > 0)
 {
 PropertyNameToIdMap::const_iterator iId 
(maPropertyNameToIdMap.find(rsPropertyName));
@@ -511,7 +511,7 @@ void SAL_CALL Theme::removePropertyChangeListener(
 css::lang::WrappedTargetException,
 css::uno::RuntimeException, std::exception)
 {
-ThemeItem eItem (__AnyItem);
+ThemeItem eItem (AnyItem_);
 if (rsPropertyName.getLength() > 0)
 {
 PropertyNameToIdMap::const_iterator iId 
(maPropertyNameToIdMap.find(rsPropertyName));
@@ -546,7 +546,7 @@ void SAL_CALL Theme::addVetoableChangeListener(
 css::lang::WrappedTargetException,
 css::uno::RuntimeException, std::exception)
 {
-ThemeItem eItem (__AnyItem);
+ThemeItem eItem (AnyItem_);
 if (rsPropertyName.getLength() > 0)
 {
 PropertyNameToIdMap::const_iterator iId 
(maPropertyNameToIdMap.find(rsPropertyName));
@@ -571,7 +571,7 @@ void SAL_CALL Theme::removeVetoableChangeListener(
 css::lang::WrappedTargetException,
 css::uno::RuntimeException, std::exception)
 {
-ThemeItem eItem (__AnyItem);
+ThemeItem eItem (AnyItem_);
 if (rsPropertyName.getLength() > 0)
 {
 PropertyNameToIdMap::const_iterator iId 
(maPropertyNameToIdMap.find(rsPropertyName));
@@ -603,7 +603,7 @@ css::uno::Sequence SAL_CALL 
Theme::getProperties()
 {
 ::std::vector aProperties;
 
-for (sal_Int32 nItem(__Begin),nEnd(__End); nItem!=nEnd; ++nItem)
+for (sal_Int32 nItem(Begin_),nEnd(End_); nItem!=nEnd; ++nItem)
 {
 const ThemeItem eItem (static_cast(nItem));
 const PropertyType eType (GetPropertyType(eItem));
@@ -660,13 +660,13 @@ sal_Bool SAL_CALL Theme::hasPropertyByName (const 
::rtl::OUString& rsPropertyNam
 
 void Theme::SetupPropertyMaps()
 {
-maPropertyIdToNameMap.resize(__Post_Rect);
-   

[Libreoffice-bugs] [Bug 99124] Incorrect font type displayed in master slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99124

--- Comment #1 from Alex  ---
Hmm, this seems like it could very well be related to a graphics problem. I
found this output in my terminal:

EE ../../../../../../src/gallium/drivers/r600/r600_shader.c:3662
r600_shader_from_tgsi - GPR limit exceeded - shader requires 432 registers
EE ../../../../../../src/gallium/drivers/r600/r600_shader.c:182
r600_pipe_shader_create - translation from TGSI failed !
EE ../../../../../../src/gallium/drivers/r600/r600_state_common.c:846
r600_shader_select - Failed to build shader variant (type=1) -12

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98622] Formula (Math object) is not shown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98622

Stanislav  changed:

   What|Removed |Added

 Whiteboard|target:5.2.0 target:5.1.3   |target:5.2.0 target:5.1.3
   ||backportRequest:5.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

[Michael Stahl]

 sfx2/source/view/viewfrm2.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 22fbbfe984f5da2592674f9260f5e4988b1341fe
Author: Michael Stahl 
Date:   Wed Apr 6 16:48:00 2016 +0200

Revert "Avoid deadlock when two threads call into Frame::close"

This reverts commit d2a59bb53ab6c6a364538bdc6928420d8cf72ba0.

Ironically causes a different deadlock, with a non-main thread holding
SolarMutex and blocked in SendMessage, and main thread dropping
SolarMutex now and blocking with SalYieldMutex::acquire() instead of
ImplSalYieldMutexAcquireWithWait().

vcllo.dll!SalYieldMutex::acquire() Line 139
vcllo.dll!SolarMutexGuard::SolarMutexGuard() Line 1477
tklo.dll!VCLXWindow::removeFocusListener(const 
com::sun::star::uno::Reference & 
rxListener) Line 1066
fwklo.dll!`anonymous namespace'::Frame::implts_stopWindowListening() Line 
3042
fwklo.dll!`anonymous namespace'::Frame::setComponent(const 
com::sun::star::uno::Reference & 
xComponentWindow, const 
com::sun::star::uno::Reference & 
xController) Line 1508
fwklo.dll!`anonymous namespace'::Frame::close(unsigned char 
bDeliverOwnership) Line 1770
sfxlo.dll!SfxViewFrame::Exec_Impl(SfxRequest & rReq) Line 261
sfxlo.dll!SfxStubSfxViewFrameExec_Impl(SfxShell * pShell, SfxRequest & 
rReq) Line 706
sfxlo.dll!SfxShell::CallExec(void (SfxShell *, SfxRequest &) * pFunc, 
SfxRequest & rReq) Line 204
sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & 
rSlot, SfxRequest & rReq, bool bRecord) Line 265
sfxlo.dll!SfxDispatcher::PostMsgHandler(SfxRequest * pReq) Line 1088
sfxlo.dll!SfxDispatcher::LinkStubPostMsgHandler(void * instance, SfxRequest 
* data) Line 1065
sfxlo.dll!Link::Call(SfxRequest * data) Line 84
sfxlo.dll!SfxHintPoster::DoEvent_Impl(void * pPostedHint) Line 45
sfxlo.dll!SfxHintPoster::LinkStubDoEvent_Impl(void * instance, void * data) 
Line 42
vcllo.dll!Link::Call(void * data) Line 84
vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1959
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, unsigned short 
nEvent, const void * pEvent) Line 2524
vcllo.dll!SalFrame::CallCallback(unsigned short nEvent, const void * 
pEvent) Line 273
vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, long lParam) Line 4111
vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned int 
wParam, long lParam, int & rDef) Line 5767

Change-Id: Iba97daf9cc90028c3b0ef693f928affa32bf5a0e

diff --git a/sfx2/source/view/viewfrm2.cxx b/sfx2/source/view/viewfrm2.cxx
index cb0be79..bddaede 100644
--- a/sfx2/source/view/viewfrm2.cxx
+++ b/sfx2/source/view/viewfrm2.cxx
@@ -255,7 +255,6 @@ void SfxViewFrame::Exec_Impl(SfxRequest  )
 pDocSh->SetModified( false );
 rReq.Done(); // Must call this before Close()!
 bClosed = false;
-SolarMutexReleaser rel;
 try
 {
 xTask->close(sal_True);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99124] New: Incorrect font type displayed in master slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99124

Bug ID: 99124
   Summary: Incorrect font type displayed in master slide
   Product: LibreOffice
   Version: 5.0.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: adlin...@ncsu.edu

Created attachment 124132
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124132=edit
Shows fonts being correctly updated on actual presentation but not on master
slide

I have a presentation that was originally prepared in MS PowerPoint, but that I
have long since saved in the .odp format. When I open master slide, the font
type is always displayed as being Times New Roman. I can change the font type
to some other font within the master slide properties dialog box; however,
after I make the selection, the displayed font immediately reverts to Times New
Roman. I don't actually have ms fonts installed on my computer. Maybe that's
part of the problem; I don't know.

What's interesting is that even though the master slide displays the font as
being Times New roman, when I exit the master slide and return to my
presentation, my slides have been updated to the font that I tried to select in
the master slide font dialog box (see attached slides). So functionally Impress
is doing what I want it to do, it's just that the wrong font is displayed on
the master slide.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98886] FILEOPEN: Incorrect symbols in formulas in .docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98886

--- Comment #4 from Alexander  ---
Not-not, this new file with new bugs. I create 3 bugreports about different
bugs in 3 different files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Laurent Balland-Poirier]

 chart2/source/view/axes/ScaleAutomatism.cxx |   14 ++
 1 file changed, 2 insertions(+), 12 deletions(-)

New commits:
commit 45f683a495411af8e059527c137af335ade79c37
Author: Laurent Balland-Poirier 
Date:   Sun Mar 27 22:43:11 2016 +0200

tdf#96871 Do not force auto log Y scale to B^0

Remove tests to fix automatic Y minimum log scale to 0.

Change-Id: Ic33fbbc3d5ee86db964f74976d85e5a2e1068cca
Reviewed-on: https://gerrit.libreoffice.org/23559
Tested-by: Jenkins 
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/chart2/source/view/axes/ScaleAutomatism.cxx 
b/chart2/source/view/axes/ScaleAutomatism.cxx
index adbde41..9bc8df7 100644
--- a/chart2/source/view/axes/ScaleAutomatism.cxx
+++ b/chart2/source/view/axes/ScaleAutomatism.cxx
@@ -369,26 +369,16 @@ void 
ScaleAutomatism::calculateExplicitIncrementAndScaleForLogarithmic(
 than 1, and the range has been swapped above), then: */
 if( bAutoMinimum && (fTempMinimum > 0.0) )
 {
-/*  If minimum is less than 5 (i.e. original source values less than
-B^5, B being the base of the scaling), or if minimum and maximum
-are in different increment intervals (means, if minimum and maximum
-are not both in the range [B^n,B^(n+1)] for a whole number n), set
-minimum to 0, which results in B^0=1 on the axis. */
 double fMinimumFloor = ::rtl::math::approxFloor( fTempMinimum );
 double fMaximumFloor = ::rtl::math::approxFloor( fTempMaximum );
 // handle the exact value B^(n+1) to be in the range [B^n,B^(n+1)]
 if( ::rtl::math::approxEqual( fTempMaximum, fMaximumFloor ) )
 fMaximumFloor -= 1.0;
 
-if( (fMinimumFloor < 5.0) || (fMinimumFloor < fMaximumFloor) )
+if( fMinimumFloor == fMaximumFloor )
 {
-if( m_bExpandWideValuesToZero )
-fTempMinimum = 0.0;
-}
-/*  Else (minimum and maximum are in one increment interval), expand
+/*  if minimum and maximum are in one increment interval, expand
 minimum toward 0 to make the 'shorter' data points visible. */
-else
-{
 if( m_bExpandNarrowValuesTowardZero )
 fTempMinimum -= 1.0;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92111] missing frame-view while editing text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92111

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #7 from raal  ---
(In reply to Thomas Krumbein from comment #1)
> Hmm, not everytime reproducable. Sometimes it works as expected, mostly not. 
> 
> So maybe a 64 Bit Problem? under Windows?

Hello Tomas,
I can not reproduce the bug under win7 and win10, 64bit. LO 5.1. Can you still
reproduce the bug with actual version of LO? Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/map/Map.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b6dc37fadf5e24dd34d759e55fe82a0610cbcc92
Author: Henry Castro 
Date:   Wed Apr 6 10:11:36 2016 -0400

loleaflet: fix slide show when it is used "file://" scheme

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 995a113..a1a768d 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -49,7 +49,7 @@ L.Map = L.Evented.extend({
L.Cursor.imagePath = options.cursorURL || 
L.Cursor.getCursorURL('cursors');
 
if (options.webserver === undefined) {
-   var protocol = window.location.protocol === 'file:' ? 
'http:' : window.location.protocol;
+   var protocol = window.location.protocol === 'file:' ? 
'https:' : window.location.protocol;
options.webserver = 
options.server.replace(/^(ws|wss):/i, protocol);
}
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99089] libreoffice crashes when I select a different job number on the spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99089

--- Comment #3 from tim  ---
This macro is under development ie. it is not yet complete. before the most
recent changes is did not cause a crash of libreoffice calc. (scalc)

Changing the job number is supposed to read the values from the main data sheet
and put them in the edit form. I was getting an error with a
val(somefunctionhere) statement, assumedly because the function returned a null
if the cell queried was empty. I changed it to return a blank string instead
("") but for some reason the whole scalc program crashes, so it is rather hard
to try and debug. I do have an earlier version from a few days before which
does not crash, and doesn't have the changes, but I will need to implement the
changes, and I can't see why scalc should crash.

it also crashes on linux (slackware) version 4.4.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs