date:20160409

[Libreoffice-bugs] [Bug 92802] Large but simple ODS file slow on FILEOPEN

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92802

Markus Mohrhard  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

--- Comment #12 from Markus Mohrhard  ---
(In reply to Timur from comment #11)
> Can you please explain how this was fixed?
> I have somewhat diff. results from Milos, but still I can't see an
> improvement with
> master~2016-03-22_23.57.30_LibreOfficeDev_5.2.0.0.alpha0_Win_x86: 
> 
> version   load  save
> 4.1.6 16s12s
> 4.2.0 20s25s
> 5.1.1 32s1:20 min
> 5.2+  38s3:30 min

I just tested again and in current master the file saves in about 10 to 15
seconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92314] PERF: Open file, CPU at 100%

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92314

--- Comment #5 from Markus Mohrhard  ---
Is this still a problem in current master. At least I can't reproduce any
performance problem for this document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp loolwsd/MasterProcessSession.cpp loolwsd/MasterProcessSession.hpp

2016-04-09 Thread Henry Castro

 loolwsd/LOOLWSD.cpp  |   83 +--
 loolwsd/MasterProcessSession.cpp |   48 --
 loolwsd/MasterProcessSession.hpp |2 
 3 files changed, 81 insertions(+), 52 deletions(-)

New commits:
commit 9ae7fa5b9b26ef4fa2bee1d48362ea384787ea65
Author: Henry Castro 
Date:   Sat Apr 9 11:54:22 2016 -0400

loolwsd: wait until bridge is completed

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 9e32cbd..34291f8 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -151,6 +151,12 @@ static std::mutex newChildrenMutex;
 static std::condition_variable newChildrenCV;
 static std::map docBrokers;
 static std::mutex docBrokersMutex;
+// Sessions to pre-spawned child processes that have connected but are not yet 
assigned a
+// document to work on.
+static std::mutex AvailableChildSessionMutex;
+static std::condition_variable AvailableChildSessionCV;
+static std::map 
AvailableChildSessions;
+
 
 static void forkChildren(const int number)
 {
@@ -244,6 +250,51 @@ class ClientRequestHandler: public HTTPRequestHandler
 {
 private:
 
+static bool waitBridgeCompleted(const 
std::shared_ptr& clientSession,
+const std::shared_ptr& 
docBroker)
+{
+int retries = 5;
+bool isFound = false;
+
+// Wait until the client has connected with a prison socket.
+std::shared_ptr prisonSession;
+std::unique_lock lock(AvailableChildSessionMutex);
+
+Log::debug() << "Waiting for client session [" << 
clientSession->getId() << "] to connect." << Log::end;
+while (retries-- && !isFound)
+{
+AvailableChildSessionCV.wait_for(
+lock,
+std::chrono::milliseconds(3000),
+[, ]
+{
+return (isFound = 
AvailableChildSessions.find(clientSession->getId()) != 
AvailableChildSessions.end());
+});
+
+if (!isFound)
+{
+Log::info() << "Retrying client permission... " << retries 
<< Log::end;
+// request again new URL session
+const std::string message = "request " + 
clientSession->getId() + " " + docBroker->getDocKey() + '\n';
+Log::trace("MasterToBroker: " + message.substr(0, 
message.length()-1));
+IoUtil::writeFIFO(LOOLWSD::ForKitWritePipe, message);
+}
+}
+
+if (isFound)
+{
+Log::debug("Waiting child session permission, done!");
+prisonSession = AvailableChildSessions[clientSession->getId()];
+AvailableChildSessions.erase(clientSession->getId());
+
+clientSession->setPeer(prisonSession);
+prisonSession->setPeer(clientSession);
+Log::debug("Connected " + clientSession->getName() + " - " + 
prisonSession->getName() + ".");
+}
+
+return isFound;
+}
+
 static void handlePostRequest(HTTPServerRequest& request, 
HTTPServerResponse& response, const std::string& id)
 {
 Log::info("Post request: [" + request.getURI() + "]");
@@ -295,6 +346,18 @@ private:
 docBroker->incSessions();
 lock.unlock();
 
+if (!waitBridgeCompleted(session, docBroker))
+{
+Log::error(session->getName() + ": Failed to connect 
to lokit child.");
+// Let the client know we can't serve now.
+
response.setStatusAndReason(Poco::Net::HTTPResponse::HTTP_SERVICE_UNAVAILABLE);
+response.setContentLength(0);
+response.send();
+return;
+}
+// Now the bridge beetween the client and kit process is 
connected
+// Let messages flow
+
 std::string encodedFrom;
 URI::encode(docBroker->getPublicUri().getPath(), "", 
encodedFrom);
 const std::string load = "load url=" + encodedFrom;
@@ -495,6 +558,18 @@ private:
 if (wsSessionsCount == 1)
 session->setEditLock(true);
 
+if (!waitBridgeCompleted(session, docBroker))
+{
+Log::error(session->getName() + ": Failed to connect to child. 
Client cannot serve now.");
+// Let the client know we can't serve now.
+
response.setStatusAndReason(Poco::Net::HTTPResponse::HTTP_SERVICE_UNAVAILABLE);
+response.setContentLength(0);
+response.send();
+return;
+}
+// Now the bridge beetween the client and kit process is connected
+// Let messages flow
+
 QueueHandler handler(queue, session, "wsd_queue_" + session->getId());
 
 Thread

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 21e6ac23ea7b104dcfe14d544b07ff0d9be98584
Author: Ashod Nakashian 
Date:   Sun Apr 10 00:14:20 2016 -0400

loolwsd: prevent ctrl+tab from inserting tab characters

Change-Id: I10b32a3e8ea1c8f80fadc9a8e6502b1a8bd322cc
Reviewed-on: https://gerrit.libreoffice.org/23953
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 912955e..ac6b53a 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -1042,7 +1042,17 @@ bool ChildProcessSession::keyEvent(const char* 
/*buffer*/, int /*length*/, Strin
 constexpr auto KEY_CTRL = 0x2000;
 constexpr auto KEY_W = 0x0216;
 if (keycode == (KEY_CTRL | KEY_W))
+{
+return true;
+}
+
+// Ctrl+Tab switching browser tabs,
+// Doesn't insert tabs.
+constexpr auto KEY_TAB = 0x0502;
+if (keycode == (KEY_CTRL | KEY_TAB))
+{
 return true;
+}
 
 std::unique_lock lock(Mutex);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.hpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/DocumentBroker.hpp |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit dc137081a788b9be0d372cbb518e4836813555cb
Author: Ashod Nakashian 
Date:   Sat Apr 9 23:52:52 2016 -0400

loolwsd: session container can be private to DocumentBroker

Change-Id: I1539f2ec3ab1bd11d659dab11359cf25a46e1f97
Reviewed-on: https://gerrit.libreoffice.org/23952
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.hpp b/loolwsd/DocumentBroker.hpp
index 66e2497..259572f 100644
--- a/loolwsd/DocumentBroker.hpp
+++ b/loolwsd/DocumentBroker.hpp
@@ -161,10 +161,6 @@ public:
 
 unsigned getWSSessionsCount() { return _wsSessions.size(); }
 
-public:
-std::map _wsSessions;
-std::mutex _wsSessionsMutex;
-
 private:
 const Poco::URI _uriPublic;
 const std::string _docKey;
@@ -174,6 +170,8 @@ private:
 std::string _jailId;
 std::string _filename;
 std::chrono::steady_clock::time_point _lastSaveTime;
+std::map _wsSessions;
+std::mutex _wsSessionsMutex;
 std::unique_ptr _storage;
 std::unique_ptr _tileCache;
 std::shared_ptr _childProcess;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - desktop/source rsc/source sal/osl sal/rtl sal/textenc sal/workben soltools/cpp soltools/mkdepend

2016-04-09 Thread Pedro Giffuni

 desktop/source/pagein/file_image_unx.c |   10 +-
 desktop/source/pagein/pagein.c |8 -
 rsc/source/rscpp/cpp3.c|2 
 rsc/source/rscpp/cpp4.c|2 
 rsc/source/rscpp/cpp5.c|2 
 sal/osl/os2/diagnose.c |2 
 sal/osl/os2/module.c   |4 
 sal/osl/os2/nlsupport.c|2 
 sal/osl/os2/process.c  |   28 +++---
 sal/osl/os2/profile.c  |   56 ++---
 sal/osl/os2/socket.c   |   56 ++---
 sal/osl/os2/tempfile.c |   23 ++---
 sal/osl/os2/thread.c   |   14 +--
 sal/osl/unx/backtrace.c|8 -
 sal/osl/unx/conditn.c  |   12 +-
 sal/osl/unx/diagnose.c |   14 +--
 sal/osl/unx/module.c   |2 
 sal/osl/unx/mutex.c|8 -
 sal/osl/unx/nlsupport.c|8 -
 sal/osl/unx/pipe.c |8 -
 sal/osl/unx/process.c  |   42 -
 sal/osl/unx/profile.c  |  122 ++--
 sal/osl/unx/security.c |   14 +--
 sal/osl/unx/signal.c   |   12 +-
 sal/osl/unx/socket.c   |   56 ++---
 sal/osl/unx/system.c   |6 -
 sal/osl/unx/tempfile.c |   23 ++---
 sal/osl/unx/thread.c   |2 
 sal/osl/unx/util.c |2 
 sal/osl/w32/dllentry.c |2 
 sal/osl/w32/security.c |2 
 sal/osl/w32/thread.c   |   16 +--
 sal/osl/w32/time.c |2 
 sal/rtl/source/alloc_arena.c   |   64 +++
 sal/rtl/source/alloc_cache.c   |  140 -
 sal/rtl/source/alloc_global.c  |   16 +--
 sal/rtl/source/byteseq.c   |   20 ++--
 sal/rtl/source/locale.c|8 -
 sal/rtl/source/rtl_process.c   |2 
 sal/rtl/source/tres.c  |   20 ++--
 sal/textenc/tencinfo.c |2 
 sal/workben/t_readline.c   |   12 +-
 soltools/cpp/_getopt.c |4 
 soltools/cpp/_lex.c|2 
 soltools/cpp/_mcrvalid.c   |   10 +-
 soltools/cpp/_nlist.c  |2 
 soltools/mkdepend/main.c   |8 -
 47 files changed, 441 insertions(+), 439 deletions(-)

New commits:
commit 8d94f9e44da8f3fdf55b1d814f921cb6dbdc37a3
Author: Pedro Giffuni 
Date:   Sun Apr 10 02:30:31 2016 +

Replace 0 with NULL for pointers.

Only applied to C code: common style for C++ is different.

Found with coccinelle:  http://coccinelle.lip6.fr/

diff --git a/desktop/source/pagein/file_image_unx.c 
b/desktop/source/pagein/file_image_unx.c
index c530b5a..9c8309f 100644
--- a/desktop/source/pagein/file_image_unx.c
+++ b/desktop/source/pagein/file_image_unx.c
@@ -49,7 +49,7 @@ int file_image_open (file_image * image, const char * 
filename)
 struct stat st;
 void *  p;
 
-if (image == 0)
+if (image == NULL)
 return (EINVAL);
 
 image->m_base = MAP_FAILED, image->m_size = 0;
@@ -87,10 +87,10 @@ int file_image_pagein (file_image * image)
 size_tk;
 volatile char c = 0;
 
-if (image == 0)
+if (image == NULL)
 return (EINVAL);
 
-if ((w.m_base = image->m_base) == 0)
+if ((w.m_base = image->m_base) == NULL)
 return (EINVAL);
 if ((w.m_size = image->m_size) == 0)
 return (0);
@@ -135,12 +135,12 @@ int file_image_pagein (file_image * image)
  */
 int file_image_close (file_image * image)
 {
-if (image == 0)
+if (image == NULL)
 return (EINVAL);
 
 if (munmap (image->m_base, image->m_size) == -1)
 return (errno);
 
-image->m_base = 0, image->m_size = 0;
+image->m_base = NULL, image->m_size = 0;
 return (0);
 }
diff --git a/desktop/source/pagein/pagein.c b/desktop/source/pagein/pagein.c
index 84bf302..c601efc 100644
--- a/desktop/source/pagein/pagein.c
+++ b/desktop/source/pagein/pagein.c
@@ -70,7 +70,7 @@ int  main (int argc, char **argv)
 
 for (i = 1; i < argc; i++)
 {
-FILE   * fp = 0;
+FILE   * fp = NULL;
 size_t   k  = 0;
 
 if (argv[i][0] == '-')
@@ -99,10 +99,10 @@ int  main (int argc, char **argv)
 }
 
 
-if ((argv[i][0] == '@') && ((fp = fopen (argv[i], "r")) == 0))
+if ((argv[i][0] == '@') && ((fp = fopen (argv[i], "r")) == NULL))
 {
 char path[1024];
-if ((fp = fopen (&(argv[i][1]), "r")) == 0)
+if ((fp = fopen (&(argv[i][1]), "r")) == NULL)
 {
 fprintf (stderr, "fopen: %s\n", strerror(errno));
 continue;
@@ -124,7 +124,7 @@ int  main (int argc, char **argv)
 }
 else
 {
-if (fp != 0)

[Libreoffice-bugs] [Bug 92773] Calc file with many hyperlinks slow on FILEOPEN FILESAVE VIEWING

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92773

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92773] Calc file with many hyperlinks slow on FILEOPEN FILESAVE VIEWING

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92773

--- Comment #5 from Commit Notification 
 ---
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=be829fa15777b3b1a6727eee231c89894e7c425e

don't pool SvxFieldItem, tdf#92773

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92773] Calc file with many hyperlinks slow on FILEOPEN FILESAVE VIEWING

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92773

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/source

2016-04-09 Thread Markus Mohrhard

 editeng/source/editeng/editdoc.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit be829fa15777b3b1a6727eee231c89894e7c425e
Author: Markus Mohrhard 
Date:   Sun Apr 10 05:51:19 2016 +0200

don't pool SvxFieldItem, tdf#92773

In documents with many different hyperlinks pooling them is incredibly
slow. I doubt that in most cases the hyperlinks are the same so let us
just not pool them.

Change-Id: I2387aee57ef0ab3183d9cc3486ddbf8ca2883e0b

diff --git a/editeng/source/editeng/editdoc.cxx 
b/editeng/source/editeng/editdoc.cxx
index 35f889b..f728553 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -212,7 +212,7 @@ const SfxItemInfo aItemInfos[EDITITEMCOUNT] = {
 { 0, true },   // EE_FEATURE_TAB
 { 0, true },   // EE_FEATURE_LINEBR
 { SID_ATTR_CHAR_CHARSETCOLOR, true },  // EE_FEATURE_NOTCONV
-{ SID_FIELD, true }
+{ SID_FIELD, false }
 };
 
 const sal_uInt16 aV1Map[] = {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

Joel Madero  changed:

   What|Removed |Added

   Priority|medium  |lowest
 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
Version|unspecified |Inherited From OOo
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #5 from Joel Madero  ---
Really weird. 

Verified all the way back to LibreOffice 3.3 (inherited from OOo, updating
version to reflect this).

Minor: Can slow down but won't prevent high quality work;
Lowest: Currently we have one test case, seems like it's not a widespread
problem but some weird corner case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

--- Comment #4 from Niels Kristian Bech Jensen  ---
Extra information: I use the Danish localisation package with LibreOffice.

Best regards,
Niels Kristian Bech Jensen

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/DocumentBroker.hpp loolwsd/LOOLWSD.cpp loolwsd/MasterProcessSession.cpp loolwsd/MasterProcessSession.hpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/DocumentBroker.cpp   |   37 +++
 loolwsd/DocumentBroker.hpp   |   13 +
 loolwsd/LOOLWSD.cpp  |   52 ++-
 loolwsd/MasterProcessSession.cpp |1 
 loolwsd/MasterProcessSession.hpp |1 
 5 files changed, 59 insertions(+), 45 deletions(-)

New commits:
commit e6d0882791fbf1b25b6d63e86f65c1f5224f2c4a
Author: Ashod Nakashian 
Date:   Sat Apr 9 23:20:20 2016 -0400

loolwsd: moved autosave to DocumentBroker

Autosaving is done by DocumentBroker, which
tracks the last save time.

There are two triggers: idle and auto save.
The first triggers when sufficient time passes
after the last interaction the user had with
the UI (currently 30 seconds).
The second triggers when it's been more than
5 minutes since the last save.
Both triggers are conditional on the user
being active after the last save.

The new code auto-saves doesn't issue
a save command per session, but only
one per doc.

Change-Id: Iada15c16002e70710d2c13a3dcfdab036d8935c6
Reviewed-on: https://gerrit.libreoffice.org/23951
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index aee583d..862b298 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -70,6 +70,7 @@ DocumentBroker::DocumentBroker(const Poco::URI& uriPublic,
 _docKey(docKey),
 _childRoot(childRoot),
 _cacheRoot(getCachePath(uriPublic.toString())),
+_lastSaveTime(std::chrono::steady_clock::now()),
 _childProcess(childProcess),
 _sessionsCount(0)
 {
@@ -135,6 +136,7 @@ bool DocumentBroker::save()
 assert(_storage && _tileCache);
 if (_storage->saveLocalFileToStorage())
 {
+_lastSaveTime = std::chrono::steady_clock::now();
 _tileCache->documentSaved();
 return true;
 }
@@ -142,6 +144,41 @@ bool DocumentBroker::save()
 return false;
 }
 
+void DocumentBroker::autoSave()
+{
+std::unique_lock sessionsLock(_wsSessionsMutex);
+if (_wsSessions.empty())
+{
+// Shouldn't happen.
+return;
+}
+
+// Find the most recent activity.
+double inactivityTimeMs = std::numeric_limits::max();
+for (auto& sessionIt: _wsSessions)
+{
+inactivityTimeMs = std::min(sessionIt.second->getInactivityMS(), 
inactivityTimeMs);
+}
+
+Log::trace("Most recent inactivity was " + 
std::to_string(inactivityTimeMs) + " ms ago.");
+const auto timeSinceLastSaveMs = getTimeSinceLastSaveMs();
+Log::trace("Time since last save was " + 
std::to_string(timeSinceLastSaveMs) + " ms ago.");
+
+// There has been some editing since we saved last?
+if (inactivityTimeMs < timeSinceLastSaveMs)
+{
+// Either we've been idle long enough, or it's auto-save time.
+if (inactivityTimeMs >= IdleSaveDurationMs ||
+timeSinceLastSaveMs >= AutoSaveDurationMs)
+{
+Log::info("Auto-save triggered for doc [" + _docKey + "].");
+
+// Any session can be used to save.
+_wsSessions.begin()->second->getQueue()->put("uno .uno:Save");
+}
+}
+}
+
 std::string DocumentBroker::getJailRoot() const
 {
 assert(!_jailId.empty());
diff --git a/loolwsd/DocumentBroker.hpp b/loolwsd/DocumentBroker.hpp
index 7dedb64..66e2497 100644
--- a/loolwsd/DocumentBroker.hpp
+++ b/loolwsd/DocumentBroker.hpp
@@ -131,6 +131,8 @@ public:
 
 bool save();
 
+void autoSave();
+
 Poco::URI getPublicUri() const { return _uriPublic; }
 Poco::URI getJailedUri() const { return _uriJailed; }
 const std::string& getJailId() const { return _jailId; }
@@ -140,6 +142,13 @@ public:
 unsigned getSessionsCount() { return _sessionsCount; }
 TileCache& tileCache() { return *_tileCache; }
 
+/// Returns the time in milliseconds since last save.
+double getTimeSinceLastSaveMs() const
+{
+const auto duration = (std::chrono::steady_clock::now() - 
_lastSaveTime);
+return 
std::chrono::duration_cast(duration).count();
+}
+
 std::string getJailRoot() const;
 
 /// Ignore input events from all web socket sessions
@@ -164,11 +173,15 @@ private:
 Poco::URI _uriJailed;
 std::string _jailId;
 std::string _filename;
+std::chrono::steady_clock::time_point _lastSaveTime;
 std::unique_ptr _storage;
 std::unique_ptr _tileCache;
 std::shared_ptr _childProcess;
 std::mutex _mutex;
 std::atomic _sessionsCount;
+
+static constexpr auto IdleSaveDurationMs = 30 * 1000;
+static constexpr auto AutoSaveDurationMs = 300 * 1000;
 };
 
 #endif
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index a1a3b2a..9e32cbd 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -511,9 +511,6 @@ private:
 }

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLProtocol.hpp loolwsd/MasterProcessSession.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp  |8 ++--
 loolwsd/LOOLProtocol.hpp |   11 +--
 loolwsd/MasterProcessSession.cpp |   10 +++---
 3 files changed, 22 insertions(+), 7 deletions(-)

New commits:
commit 8c1e5057fd475596a80e1184b50c923d974bf4ce
Author: Ashod Nakashian 
Date:   Sat Apr 9 23:16:09 2016 -0400

loolwsd: last activity time updates ignores non-interactive commands

Change-Id: I763c2945f6acb30bea9d04d91982e9fb0c8ca6ca
Reviewed-on: https://gerrit.libreoffice.org/23950
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 62d64ab..912955e 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -333,11 +333,15 @@ bool ChildProcessSession::_handleInput(const char 
*buffer, int length)
 //TODO: Sync cursor.
 }
 
-updateLastActivityTime();
-
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 
+if (LOOLProtocol::tokenIndicatesUserInteraction(tokens[0]))
+{
+// Keep track of timestamps of incoming client messages that indicate 
user activity.
+updateLastActivityTime();
+}
+
 if (tokens[0] == "dummymsg")
 {
 // Just to update the activity of view-only mode
diff --git a/loolwsd/LOOLProtocol.hpp b/loolwsd/LOOLProtocol.hpp
index f482041..0e7a541 100644
--- a/loolwsd/LOOLProtocol.hpp
+++ b/loolwsd/LOOLProtocol.hpp
@@ -63,11 +63,18 @@ namespace LOOLProtocol
 return getFirstToken(message.data(), message.size());
 }
 
+/// Returns true if the token is a user-interaction token.
+/// Currently this excludes commands sent automatically.
+/// Notice that this doesn't guarantee editing activity,
+/// rather just user interaction with the UI.
 inline
 bool tokenIndicatesUserInteraction(const std::string& token)
 {
-return (token != "tile" &&
-token != "status");
+// Exclude tokens that include these keywords,
+// such as canceltiles statusindicator.
+return (token.find("tile") == std::string::npos &&
+token.find("status") == std::string::npos &&
+token.find("state") == std::string::npos);
 }
 
 /// Returns the first line of a message.
diff --git a/loolwsd/MasterProcessSession.cpp b/loolwsd/MasterProcessSession.cpp
index 4fc5ecf..f9ad626 100644
--- a/loolwsd/MasterProcessSession.cpp
+++ b/loolwsd/MasterProcessSession.cpp
@@ -103,12 +103,16 @@ bool 
MasterProcessSession::handleDisconnect(Poco::StringTokenizer& tokens)
 
 bool MasterProcessSession::_handleInput(const char *buffer, int length)
 {
-updateLastActivityTime();
-
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 Log::trace(getName() + ": handling [" + firstLine + "].");
 
+if (LOOLProtocol::tokenIndicatesUserInteraction(tokens[0]))
+{
+// Keep track of timestamps of incoming client messages that indicate 
user activity.
+updateLastActivityTime();
+}
+
 if (tokens[0] == "loolclient")
 {
 const auto versionTuple = ParseVersion(tokens[1]);
@@ -141,7 +145,7 @@ bool MasterProcessSession::_handleInput(const char *buffer, 
int length)
 if (tokens[0] == "unocommandresult:")
 {
 const std::string stringMsg(buffer, length);
-Log::info(getName() +"Command: " + stringMsg);
+Log::info(getName() + "Command: " + stringMsg);
 const auto index = stringMsg.find_first_of("{");
 if (index != std::string::npos)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLForKit.cpp loolwsd/LOOLWSD.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/LOOLForKit.cpp |2 --
 loolwsd/LOOLWSD.cpp|9 +
 2 files changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 213888c45cb419e083df1b898431327137c230af
Author: Ashod Nakashian 
Date:   Sat Apr 9 17:48:48 2016 -0400

loolwsd: logging and remove unused vars

Change-Id: Iff4cf5284a959caf84ce6ca5072623b6f95315df
Reviewed-on: https://gerrit.libreoffice.org/23949
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLForKit.cpp b/loolwsd/LOOLForKit.cpp
index e5ff99b..81a83db 100644
--- a/loolwsd/LOOLForKit.cpp
+++ b/loolwsd/LOOLForKit.cpp
@@ -243,8 +243,6 @@ int main(int argc, char** argv)
 ChildDispatcher childDispatcher;
 Log::info("ForKit process is ready.");
 
-Timestamp startTime;
-
 while (!TerminationFlag)
 {
 UnitKit::get().invokeForKitTest();
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 9dd8755..a1a3b2a 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1259,11 +1259,12 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 }
 
 if (!UnitWSD::init(UnitWSD::UnitType::TYPE_WSD,
- UnitTestLibrary))
+   UnitTestLibrary))
 {
 Log::error("Failed to load wsd unit test library");
 return Application::EXIT_USAGE;
 }
+
 #ifdef ENABLE_SSL
 initializeSSL();
 #endif
@@ -1418,7 +1419,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 preForkChildren();
 
 time_t last30SecCheck = time(NULL);
-time_t lastFiveMinuteCheck = time(NULL);
+time_t lastFiveMinuteCheck = last30SecCheck;
 
 int status = 0;
 while (!TerminationFlag && !LOOLWSD::DoTest)
@@ -1488,7 +1489,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 time_t now = time(NULL);
 if (now >= last30SecCheck + 30)
 {
-Log::debug("30-second check");
+Log::trace("30-second check");
 last30SecCheck = now;
 
 std::unique_lock 
docBrokersLock(docBrokersMutex);
@@ -1512,7 +1513,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 }
 if (now >= lastFiveMinuteCheck + 300)
 {
-Log::debug("Five-minute check");
+Log::trace("Five-minute check");
 lastFiveMinuteCheck = now;
 
 std::unique_lock 
docBrokersLock(docBrokersMutex);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/MasterProcessSession.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp  |5 +++--
 loolwsd/ChildProcessSession.hpp  |   31 ---
 loolwsd/LOOLSession.cpp  |3 ++-
 loolwsd/LOOLSession.hpp  |   18 ++
 loolwsd/MasterProcessSession.cpp |2 ++
 5 files changed, 25 insertions(+), 34 deletions(-)

New commits:
commit b6d2edb0e30770fe2b722109af9e5cbda5c9b80d
Author: Ashod Nakashian 
Date:   Sat Apr 9 17:47:23 2016 -0400

loolwsd: moved activity tracking into LOOLSession

Change-Id: I87d5afc43bea29ede2ad6e2871c594c4746bc3d5
Reviewed-on: https://gerrit.libreoffice.org/23948
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index ec7dc0f..62d64ab 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -308,7 +308,7 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
 {
 if (isInactive() && _loKitDocument != nullptr)
 {
-Log::debug("Handling message after inactivity of " + 
std::to_string(_stats.getInactivityMS()) + "ms.");
+Log::debug("Handling message after inactivity of " + 
std::to_string(getInactivityMS()) + "ms.");
 
 // Client is getting active again.
 // Send invalidation and other sync-up messages.
@@ -333,7 +333,8 @@ bool ChildProcessSession::_handleInput(const char *buffer, 
int length)
 //TODO: Sync cursor.
 }
 
-_stats.updateLastActivityTime();
+updateLastActivityTime();
+
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index ab3347c..0f14842 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -30,30 +30,6 @@ class CallbackWorker;
 class ChildProcessSession final : public LOOLSession
 {
 public:
-class Statistics
-{
-public:
-Statistics() :
-_lastActivityTime(std::chrono::steady_clock::now())
-{
-}
-
-void updateLastActivityTime()
-{
-_lastActivityTime = std::chrono::steady_clock::now();
-}
-
-double getInactivityMS() const
-{
-const auto duration = (std::chrono::steady_clock::now() - 
_lastActivityTime);
-return 
std::chrono::duration_cast(duration).count();
-}
-
-private:
-std::chrono::steady_clock::time_point _lastActivityTime;
-};
-
-public:
 /// Create a new ChildProcessSession
 /// ws The socket between master and kit (jailed).
 /// loKit The LOKit instance.
@@ -88,9 +64,6 @@ public:
 
 std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
 
-const Statistics& getStatistics() const { return _stats; }
-bool isInactive() const { return _stats.getInactivityMS() >= 
InactivityThresholdMS; }
-
  protected:
 virtual bool loadDocument(const char *buffer, int length, 
Poco::StringTokenizer& tokens) override;
 
@@ -131,8 +104,6 @@ private:
 int _clientPart;
 std::function _onLoad;
 std::function _onUnload;
-/// Statistics and activity tracking.
-Statistics _stats;
 
 std::unique_ptr _callbackWorker;
 Poco::Thread _callbackThread;
@@ -141,8 +112,6 @@ private:
 /// Synchronize _loKitDocument acess.
 /// This should be owned by Document.
 static std::recursive_mutex Mutex;
-
-static constexpr auto InactivityThresholdMS = 120 * 1000;
 };
 
 #endif
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index a80b65b..1fd268c 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -55,7 +55,8 @@ LOOLSession::LOOLSession(const std::string& id, const Kind 
kind,
 _isDocPasswordProvided(false),
 _isDocLoaded(false),
 _isDocPasswordProtected(false),
-_disconnected(false)
+_disconnected(false),
+_lastActivityTime(std::chrono::steady_clock::now())
 {
 // Only a post request can have a null ws.
 if (_kind != Kind::ToClient)
diff --git a/loolwsd/LOOLSession.hpp b/loolwsd/LOOLSession.hpp
index d5fd76b..2fc5429 100644
--- a/loolwsd/LOOLSession.hpp
+++ b/loolwsd/LOOLSession.hpp
@@ -54,6 +54,15 @@ public:
 /// Called to handle disconnection command from socket.
 virtual bool handleDisconnect(Poco::StringTokenizer& tokens);
 
+bool isInactive() const { return getInactivityMS() >= 
InactivityThresholdMS; }
+
+/// Returns the inactivity time of the client in milliseconds.
+double getInactivityMS() const
+{
+const auto duration = (std::chrono::steady_clock::now() - 
_lastActivityTime);
+return

[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

--- Comment #3 from Niels Kristian Bech Jensen  ---
Created attachment 124216
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124216=edit
Output from LibreOffice Writer 5.1.2.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

--- Comment #2 from Niels Kristian Bech Jensen  ---
Created attachment 124215
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124215=edit
Output from LibreOffice Writer 5.0.5.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

--- Comment #1 from Niels Kristian Bech Jensen  ---
Created attachment 124214
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124214=edit
Expected output (from MS Office 2010)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99197] New: Rendering error of punctuation mark in Word document.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99197

Bug ID: 99197
   Summary: Rendering error of punctuation mark in Word document.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nkbj1...@hotmail.com

Created attachment 124213
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124213=edit
MS Word test case.

LibreOffice Writer renders punctuation marks at the beginning of the line in
stead of at the end of the line in some MS Word documents. It is visible both
on-screen and in the resulting PDF files.

I have attached a small test case with PDFs from MS Office 2010 (the expected
output), and from LibreOffice Writer 5.0.5.2 and 5.1.2.2.

Best regards,
Niels Kristian Bech Jensen

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLForKit.cpp loolwsd/LOOLWSD.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/LOOLForKit.cpp |   11 +--
 loolwsd/LOOLWSD.cpp|   12 
 2 files changed, 17 insertions(+), 6 deletions(-)

New commits:
commit 6a907a7a7f70a1ab3d8d99643decb419d684c43f
Author: Ashod Nakashian 
Date:   Sat Apr 9 16:53:33 2016 -0400

loolwsd: preFork is done once by ForKit already and sanity check count

Change-Id: I8ee843e35198ef88bdf191c11a2a738fae6e6c30
Reviewed-on: https://gerrit.libreoffice.org/23947
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLForKit.cpp b/loolwsd/LOOLForKit.cpp
index 66f313c..e5ff99b 100644
--- a/loolwsd/LOOLForKit.cpp
+++ b/loolwsd/LOOLForKit.cpp
@@ -71,8 +71,15 @@ private:
 if (tokens[0] == "spawn" && tokens.count() == 2)
 {
 const auto count = std::stoi(tokens[1]);
-Log::info("Spawning " + tokens[1] + " children on request.");
-ForkCounter = count;
+if (count > 0)
+{
+Log::info("Spawning " + tokens[1] + " children per request.");
+ForkCounter = count;
+}
+else
+{
+Log::warn("Cannot spawn " + std::to_string(count) + " children 
as requested.");
+}
 }
 }
 
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index b70d110..9dd8755 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -152,13 +152,16 @@ static std::condition_variable newChildrenCV;
 static std::map docBrokers;
 static std::mutex docBrokersMutex;
 
-static void forkChildren(int number)
+static void forkChildren(const int number)
 {
 assert(!newChildrenMutex.try_lock()); // check it is held.
 
-const std::string aMessage = "spawn " + std::to_string(number) + "\n";
-Log::debug("MasterToForKit: " + aMessage.substr(0, aMessage.length() - 1));
-IoUtil::writeFIFO(LOOLWSD::ForKitWritePipe, aMessage);
+if (number > 0)
+{
+const std::string aMessage = "spawn " + std::to_string(number) + "\n";
+Log::debug("MasterToForKit: " + aMessage.substr(0, aMessage.length() - 
1));
+IoUtil::writeFIFO(LOOLWSD::ForKitWritePipe, aMessage);
+}
 }
 
 static void preForkChildren()
@@ -166,6 +169,7 @@ static void preForkChildren()
 std::unique_lock lock(newChildrenMutex);
 int numPreSpawn = LOOLWSD::NumPreSpawnedChildren;
 UnitWSD::get().preSpawnCount(numPreSpawn);
+--numPreSpawn; // ForKit always spawns one child at startup.
 forkChildren(numPreSpawn);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 60589] [Template manager]: Can not copy styles between different files and templates

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=60589

--- Comment #30 from Luca Daghino  ---
Is there any chance we get this solved?
It's important for many users.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 60589] [Template manager]: Can not copy styles between different files and templates

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=60589

--- Comment #30 from Luca Daghino  ---
Is there any chance we get this solved?
It's important for many users.
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 99186] Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from V Stuart Foote  ---
(In reply to Kruno from comment #4)
> 
> I was witting in style 'Text body' and wanted to insert a horizontal line,
> and that style 'Text body' turned into a 'Horizontal line' without asking or
> notifying and that's not what I wanted to do. I see it right next to a
> losing content...
> 

Don't use Insert -> Horizontal Line then.

Rather, use the range of autocorrect triplets to apply direct formatting. 

Or edit a style to activate a border of your choice.

Or insert a graphic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #6 from V Stuart Foote  ---
Thanks for rolling back and running the two installations and posting the log.

As you say typical that you did not have a repeat--these Windows installer
issues can be very annoying to pin down.

For what it is worth, if you look in the log at line #102073 there is an
"Executing op: SetTargetFolder(Folder=C:\Windows\fonts)" from there onward are
the control and operation sequences for the font installation.

Note that many show as "To be installed; Won't patch; No existing file" but
some are "Won't Overwrite; Won't patch; Existing file is of an equal version"
and also "Overwrite; Won't patch; New file versioned - existing file
unversioned" those continue through line #102409 -- the mix of CLSID GUID
registrations earlier coupled with these "op" lines detail specifics of what
happens with the fonts during install. Installing, patching, upgrading fonts.

A similar log can be captured during an uninstallation.

The patch done for bug 76239 (cmnt#66 & cmnt#35) refined the logic of using ref
counts for font replacement.  Unfortunately to make any additional adjustments
to it we'd need solid log of things as the errant replacements/removals occur. 
It has been very hard to catch it.

Which is why this should probably be linked to bug 76239 as a continuation if
not simply duped back to it and reopen. It is not yet 100% correct, but without
detailed log we're kind of stuck.

To my mind it is Andras's call about going forward here, or just adding to
76239

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

CppCheck Report Update

2016-04-09 Thread cppcheck.libreoff...@gmail.com


A new cppcheck report is available at : 
http://dev-builds.libreoffice.org/cppcheck_reports/master/


Note:
The script generating this report was run at :
2016-10-04_02:12:39 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 72079] Adding Fonts for Lao, Thai, and Khmer

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=72079

--- Comment #8 from Adolfo Jayme  ---
(In reply to Robert M Campbell from comment #1)
> DroidSans

Note that the Droid fonts are deprecated and superseded by the Noto fonts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2016-04-09 Thread Caolán McNamara

 sw/source/filter/ww8/wrtww8.cxx |   17 -
 1 file changed, 8 insertions(+), 9 deletions(-)

New commits:
commit 7b9a5e8124328da9d81aed58cf944c91560a7c07
Author: CaolÃ¡n McNamara 
Date:   Sat Apr 9 21:05:08 2016 +0100

valgrind: leak on export of ooo98646-1.doc to docx

Change-Id: Idd1015fd9dfe12c085a61756fb9448fb6df09326

diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index a248e85..99cde14 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -3329,15 +3329,6 @@ void WW8Export::ExportDocument_Impl()
 pFib->WriteHeader( *pStrmTemp );
 }
 
-if (m_pUsedNumTable)   // all used NumRules
-{
-// clear the part of the list array that was copied from the document
-// - it's an auto delete array, so the rest of the array which are
-// duplicated lists that were added during the export will be deleted.
-m_pUsedNumTable->erase(m_pUsedNumTable->begin(), 
m_pUsedNumTable->begin() + m_pUsedNumTable->size() - m_nUniqueList);
-delete m_pUsedNumTable;
-}
-
 DELETEZ( m_pGrf );
 DELETEZ( m_pMagicTable );
 DELETEZ( m_pFieldFootnote );
@@ -3558,6 +3549,14 @@ MSWordExportBase::MSWordExportBase( SwDoc *pDocument, 
SwPaM *pCurrentPam, SwPaM
 
 MSWordExportBase::~MSWordExportBase()
 {
+if (m_pUsedNumTable)   // all used NumRules
+{
+// clear the part of the list array that was copied from the document
+// - it's an auto delete array, so the rest of the array which are
+// duplicated lists that were added during the export will be deleted.
+m_pUsedNumTable->erase(m_pUsedNumTable->begin(), 
m_pUsedNumTable->begin() + m_pUsedNumTable->size() - m_nUniqueList);
+delete m_pUsedNumTable;
+}
 delete m_pOLEExp;
 delete m_pOCXExp;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96970] Load url bar document window name

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96970

Adolfo Jayme  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||187

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99187] unable to delete contents of load url bar

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99187

Adolfo Jayme  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||970

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99196] New: Convert Text to Table does not ignore commas within double quoted text

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99196

Bug ID: 99196
   Summary: Convert Text to Table does not ignore commas within
double quoted text
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ohms...@yahoo.com

Write, Tables, Convert Text to Table has no provision for ignoring commas in
text within double quotes. 

Commas can be delimiters, or can be part of text - in which case double quotes
are placed around the text with commas.

As a result, converted table cells having commas in the double quoted text are
placed in the wrong column. 

Calc, when importing CSV files, implements this correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Implementing SVG attribute "stroke-miterlimit" ( tdf#48066)

2016-04-09 Thread Regina Henschel


Hi all,

I have put a patch to Gerrit https://gerrit.libreoffice.org/#/c/23946/
It does only rendering, MetaActions are missing. But it is already so 
large, that I think a review would be good before I continue. Because I 
can only build and test on Windows, I would be glad, if you would test 
and review it for Linux and MacOSX.




For the warning-break [1] on MacOSX from Jenkins I need some help. I 
cannot compile or test on Mac.
The value fMiterMinimumAngle has to be used in case eLineJoin == 
basegfx::B2DLineJoin::Miter in OpenGLSalGraphicsImpl::DrawPolyLine 
around line 886.

In content this has to happen in that place:
if ('current miter length' > 'miter limit')
then use the same statements as in case Bevel
else use the statement in line 892.

But I'm not sure about the meaning of variable 'length' in line#885.


The MetaPolyLineAction gets a LineInfo and a tools::Polygon, but 
LineInfo does neither contain miter minimum angle nor miter limit. 
Therefore my question is, how to resolve it. Making a total new 
MetaAction? Or extend LineInfo (similar as ExtLineInfo in pdfwriter)? Or 
extend MetaPolyLineAction to take a PolygonStrokePrimitive2D or a 
B2DPolyPolygon plus the needed line and stroke information separate?


The module com::sun::star::rendering has a struct StrokeAttributes, 
which would contain all needed information. How is that currently used? 
Is it useful?


Kind regards
Regina


[1]
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/vcl/opengl/gdiimpl.cxx:770:167: 
error: unused parameter 'fMiterMinimumAngle' [-Werror,-Wunused-parameter]
void OpenGLSalGraphicsImpl::DrawPolyLine(const basegfx::B2DPolygon& 
rPolygon, float fLineWidth, basegfx::B2DLineJoin eLineJoin, 
css::drawing::LineCap eLineCap, float fMiterMinimumAngle)


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99195] New: FILENEW ERROR App Store LibreOffice Vanilla unable to create new database on Mac OS X

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99195

Bug ID: 99195
   Summary: FILENEW ERROR App Store LibreOffice Vanilla unable to
create new database on Mac OS X
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dre...@yahoo.com

Fresh install from Apple Mac App Store--all software up to date
File > New database
LibreOffice Base
Error: The connection to the data source could not be established
The connection to the external data source could not be established
No SDBC driver was found of the URL 'sdbc:embedded:hsqldb'
The More button does not provide more information
A google search for the error message shows Linux users using app-get to
install the missing piece(s) driver.
Please translate this to the Mac and write more user friendly error messages
for this FAQ.
Great opportunity to get more users via the App Store but it should pass the
File New Smoke Test before release. This fills a gap left behind by AppleWorks
users and Windows Office users that have Microsoft Access.

LibreOffice 5.1.1.3
iMac OS X 10.11.4 El Capitan with java 7 and 8 installed along with mac ports

It is unclear what LibreOffice Vanilla vs Fresh vs Still are? Sounds like the
App Store version vs the latest version vs the stable build but the App Store
version is greater than the other two.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99185] [UI] Breeze icons for folder and Form is identical

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99185

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||f...@libreoffice.org,
   ||kain...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Adolfo Jayme  ---
@Andreas, can you look at this when you find time? Thanks! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90004] Crash of Calc in version 4.4.1.2

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90004

Adolfo Jayme  changed:

   What|Removed |Added

 Resolution|INVALID |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90151] Editing: paste missing in context menu

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90151

Adolfo Jayme  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99186] Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

Kruno  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

--- Comment #4 from Kruno  ---
But now I'm convinced it's a bug (maybe intentionally put there, but _it's_ a
bug).

It's wrong to insert _empty_ paragraph just to do formating. I would agree to
have style defined for rules and lines in manner they exist in Draw like
Graphics style or Presentation style or similar but it's plain wrong to to
formating by inserting empty paragraphs.

Horizontal rule is a question of presentation, matter of looks, but paragraph
is matter of structure.

And it's not even inserting new (empty) paragraph -- it's setting new style to
a paragraph in a way in which it did not at least since 3.3 (cant say for
earlier).

So if I want horizontal line I need to insert a new paragraph after one with
'Text body' and then apply 'Horizontal rule'. It's like you build HTML web page
and somebody tells you: you know, spacing between two paragraphs should be done
by inserting third (empty!) paragraph ( tag) instead doing some CSS stuff.
How come?

I see it as a bug because if you have even one empty paragraph in your odt
document - you've done it wrong (structurally you've done it wrong because you
do presentation with structural element).

I was witting in style 'Text body' and wanted to insert a horizontal line, and
that style 'Text body' turned into a 'Horizontal line' without asking or
notifying and that's not what I wanted to do. I see it right next to a losing
content...

I'll turn this to UNCONFIRMED ones more and promise not to thinker any more
with it (so you can turn it back to RESOLVED if necessary and I'll live it at
that then).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98831] gtk3: Cannot copy paste between libreoffice documents

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98831

--- Comment #4 from alium  ---
it looks like the same problem - in Fedora

https://bugzilla.redhat.com/show_bug.cgi?id=1323922

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99091] wmf in odg can not break and Past GDI to writer become bigger, and include some white space

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99091

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99166] mergedlo.dll error when click fast several heading in navigator

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99166

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99112] restore down can not remember previous window size and position

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99112

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99171] Sometimes can not save odt

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99171

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99164] Libreoffice portable can not use TrueType Collection (TTC) Font

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99164

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #1 from Adolfo Jayme  ---
Please do NOT mark as confirmed your own bugs. It must be done by someone else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99151] Installer optical bug

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99151

Adolfo Jayme  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Adolfo Jayme  ---


*** This bug has been marked as a duplicate of bug 93004 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96160] UI: Menu shortcuts scrambled in german

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96160

--- Comment #7 from Norbert Scheibner  ---
I understand the necessity, that some accelerators need to be changed to avoid
doubles, but now I gave 5.1.2 a try and all 3 accelerators I used as examples
changed again!

The second change in between some months.

5.1.2:
-
ALT-F-P-B - optimal column width
"Spalte" in german, easy to remember the "P"
ALT-F-I-H - optimal row height
"Zeile" in german, an "L" is there too
ALT-N-O   - sort
"Sortieren" in german

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99194] New: calc spreadsheets wont work now

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99194

Bug ID: 99194
   Summary: calc spreadsheets wont work now
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: monbay...@gmail.com

Hi,
I just foolishly updated my system and now my calc spreadsheet wont work
properly. Some of the columns wont add up and it has slowed up a lot. I am
about to file vat returns and end of years for clients, so devastating.
I am not a tech person so have no idea how to put it right. 
Regards
Monique

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99191] [Feature request] Ability to print with spell checker underlining

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99191

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
  Component|Writer  |LibreOffice
Version|unspecified |Inherited From OOo
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
Nice idea.. Set to new Enhancement.
And I set to component LibreOffice. Spell checking in other modules can have
the same option.
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99193] New: Libre Office v 5.1.2 won't install on Intel i53320M CPU, Windows 7, 64-bit Home Prem

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99193

Bug ID: 99193
   Summary: Libre Office v 5.1.2 won't install on Intel i53320M
CPU, Windows 7,64-bit Home Prem
   Product: LibreOffice
   Version: 5.1.0.2 rc
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: open.4...@hotmail.com

Downloaded Libre Office Fresh install from the Libre Office website. Opened to
install Libre Office. It goes through all the installations by popup windows
during installation. HOWEVER, it is not found on computer when finished is
clicked. Even after restart there is NO executable program to run and use Libre
Office. The computer that this is being installed upon is a new computer and no
other similar office software has been installed upon it. I have used Libre
Office on a Ubuntu computer and it works for that computer. But for this mobile
laptop it won't install to be used. Tried uninstalling it and re-installing it.
The same result is no application program. I've selected "repair" the
installation and same result no application program.

I could spend endless time looking for an answer on your community and support
website. The limited time that I looked to find a solution to this problem was
not found. And your community and support website has endless responses and
answers for all kinds of problems. That may not be very good for finding
exactly what is needed.

SUMMARY: My problem is that Libre Office fresh install ver. 5.1.2 does not
Really install on my mobile laptop. IT goes through the install process. But
even after a restart no Libre Office Application Program is found on the
computer. My computer does not crash after the installation. It just doesn't
really install the application program to where I can use it. The installation
that I selected from LibreOffice website is: SDK and Sourcecode
Download the SDK
LibreOffice_5.1.2_Win_x64_sdk.msi
28 MB (Torrent, Info)

Main Installer
Selected: LibreOffice 5.1.2 for Windows x86_64 (Vista or newer required) -
change? Download Version 5.1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95140] MAILMERGE: Email Test Setting failed

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95140

--- Comment #4 from Óvári  ---
LibreOfficeDev could not connect to the outgoing mail server. Check your
system's settings and the settings in LibreOfficeDev. Check the server name,
the port and the secure connections settings
--
: -ERR EOF, traceback follows
  C:\Program Files (x86)\LibreOfficeDev
5\program\python-core-3.3.0\lib\poplib.py:121 in function _getline() [if not
line: raise error_proto('-ERR EOF')]
  C:\Program Files (x86)\LibreOfficeDev
5\program\python-core-3.3.0\lib\poplib.py:137 in function _getresp() [resp, o =
self._getline()]
  C:\Program Files (x86)\LibreOfficeDev
5\program\python-core-3.3.0\lib\poplib.py:93 in function __init__()
[self.welcome = self._getresp()]
  C:\Program Files (x86)\LibreOfficeDev 5\program\mailmerge.py:405 in function
connect() [self.server = poplib.POP3(server, port, timeout=tout)]


Output from:
Version: 5.2.0.0.alpha0+
Build ID: 157469896ef56720f33676222b95e81c04ab5c72
CPU Threads: 2; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-04-06_20:10:15

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99190] Calc cell border thickness is not shown correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99190

--- Comment #4 from Roeland  ---
By taking a closer look the bug might indeed be related. You can close it as a
duplicate, I will retest this onces the other issue is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99190] Calc cell border thickness is not shown correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99190

--- Comment #3 from Roeland  ---
Hi Cor, I'm not really sure about this, the problem is ocurring in a ods file
I'm currently using.

It might be that this problem originates from a docx document, or was round
tripped once, but I can't remember if this is true. What makes you think this
is the same problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99190] Calc cell border thickness is not shown correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99190

--- Comment #2 from Roeland  ---
Created attachment 124212
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124212=edit
picture of the printed output

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99192] New: SIDEBAR: Drop down lists buttons in content panels sometimes disappear behind tab bar when resizing the sidebar

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99192

Bug ID: 99192
   Summary: SIDEBAR: Drop down lists buttons in content panels
sometimes disappear behind tab bar when resizing the
sidebar
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hsones...@gmail.com

Instructions to reproduce:
1. Open Impress
2. Insert image
3. Make sure that at least the 'Shadow', 'Graphic', and 'Position and Size'
content panels are open in the sidebar.
4. Resize the sidebar so that it becomes as narrow as possible.
5. Notice how the right side of the drop down lists in the 'Shadow' panel
disappears behind the tab bar.

Interestingly it only does this in some specific configurations of the content
panels in the sidebar. It also happens sometimes to each of the other content
panels, but it depends on the configuration. Furthermore, the 'Line' content
panel seems to have its content centered instead of aligned to the right as the
other content panels.

This bug appears both in 5.1.1 and the latest development build.

Version: 5.2.0.0.alpha0+
Build ID: ef34535ceb60d7d63b8d8671e4c6e9e43ffbd17d
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-03-27_09:52:41

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92314] PERF: Open file, CPU at 100%

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92314

Markus Mohrhard  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92773] Calc file with many hyperlinks slow on FILEOPEN FILESAVE VIEWING

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92773

Markus Mohrhard  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99188] Calc outer border lines do not close nicely when connected

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99188

Cor Nouws  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
Version|5.1.1.3 release |5.0.5.2 release
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #2 from Cor Nouws  ---
Hi Roeland,

Thanks for filing. I confirm the problem in 5.0.5.2 and later.
LibreOffice 3.4.4 - 4.0.6 don't have the issue > Regression

I would have thought the issue is already known, but I can't find a bug, so I
set to new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92664

Markus Mohrhard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #13 from Markus Mohrhard  ---
Missing test file so I'm closing this as INVALID.

Bug reports without public reproducers are more or less unusable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99186] Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |NOTABUG

--- Comment #3 from V Stuart Foote  ---
This is not a bug. 

A horizontal "rule" is simply a bottom edge border applied to a paragraph, and
can be applied in several methods.

There is a formal style defined "Horizontal Line" that when inserted has a
paragraph style using 6pt Liberation Serif font and setting a black .05 pt
bottom edge border for the paragraph.

The Insert -> Horizontal Line will simply insert an empty paragraph with that
style.  The Horizontal Line style can be edited to change color and width of
the border edge, as well as font size for any text that is entered into the
paragraph.

The paragraph style can also be directly formatted to add a bottom (or top)
edge border as desired.

Also, other paragraphs can receive an auto-format applied "direct formatting"
of the bottom border edge using these accelerators, the first two produce
single lines-the last four are double line bottom borders applied to the
preceding paragraph.

--- (three hyphens)
___ (three underscores)


=== (three equals)
*** (three asterisks)
~~~ (three tildes)
### (three hashes)

Removal of the horizontal line is done by removing the direct formatting, or
editing the border of the paragraph.

=-ref-=
https://help.libreoffice.org/Common/Drawing_Lines_in_Text

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87213] Cell grid lines (borders) missing or irregularly rendered on screen

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87213

Cor Nouws  changed:

   What|Removed |Added

 Resolution|INVALID |WORKSFORME
Summary|Cell borders missing or |Cell grid lines (borders)
   |irregularly rendered on |missing or irregularly
   |screen  |rendered on screen

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99191] New: [Feature request] Ability to print with spell checker underlining

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99191

Bug ID: 99191
   Summary: [Feature request] Ability to print with spell checker
underlining
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: urban.suhadol...@gmail.com

I would kindly ask for an option to print with spell checker underlining.

I am writing a long paper for school, and having a printed version of text to
sort things out, is an essential part of my workflow. It would be great if i
could see which spelling mistakes have been already recognized by the spell
checker.

Regards
Urban120

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99190] Calc cell border thickness is not shown correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99190

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
Hi Roeland,

Thanks for filing the issue.
Looking at bug 79787, and especially the explanation in a related commit
 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=51737960911d41593ffd9792a6a85aeaa86824fd
it looks to me as if your report can be marked as as duplicate..
Can you please check if that is OK?

Regards - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99189] Add option to exclude footnotes, endnotes and textboxes from word count

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99189

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
Thanks Henrik. Better indeed to have a clear separate bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83771] New feature in paragraph or character formating: "Don't Count"

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83771

Cor Nouws  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||c...@nouenoff.nl
Version|4.3.1.2 release |Inherited From OOo

--- Comment #10 from Cor Nouws  ---
Whether working with a macro or not, still a valid request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90691] Word Count section in Tools > Options

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90691

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|4.5.0.0.alpha0+ Master  |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 90691] Word Count section in Tools > Options

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90691

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|4.5.0.0.alpha0+ Master  |Inherited From OOo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

--- Comment #5 from Zsolt  ---
Created attachment 124211
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124211=edit
5.1.1.3 installation log

Well I did it. Of course unsurprisingly I don't get any removed font now.
I doesn't always happen. Too bad there's no installation log every time.
Anyway I'll attach it. I doubt it'll be of much use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95140] MAILMERGE: Email Test Setting failed

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95140

Óvári  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Óvári  ---
(In reply to Buovjaga from comment #2)
Unfortunately, Email Test Setting failed in:
Version: 5.2.0.0.alpha0+
Build ID: 157469896ef56720f33676222b95e81c04ab5c72
CPU Threads: 2; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-04-06_20:10:15

Perhaps having automatic configuration of email settings may help? For example,
this is implemented in Thunderbird.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99190] New: Calc cell border thickness is not shown correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99190

Bug ID: 99190
   Summary: Calc cell border thickness is not shown correctly
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roelandb...@hotmail.com

Created attachment 124210
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124210=edit
document with the problem

In the attached document cells D19 to D28 have a border line on their right
side. The cells with the numbers 1-4 have a width of 0,75 pt the cells with
numbers 5-10 have with 0,05pt. However, the line is shown as the same
thickness. If I print this document the difference is there (dfferent thickness
of the borders).

This is confusing behavior, as I expect to have the same result on my screen as
when printing a document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99173] OLE launch of Math component for a formula inserted into Writer has visual glitches

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99173

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Maxim Monastirsky  ---


*** This bug has been marked as a duplicate of bug 96451 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96451] UI isn't properly refreshed when inserting formula

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96451

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||odinat...@gmail.com

--- Comment #10 from Maxim Monastirsky  ---
*** Bug 99173 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99189] Add option to exclude footnotes, endnotes and textboxes from word count

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99189

Henrik  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||691

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90691] Word Count section in Tools > Options

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90691

Henrik  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||189

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 90691] Word Count section in Tools > Options

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90691

Henrik  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||189

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 99189] Add option to exclude footnotes, endnotes and textboxes from word count

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99189

Henrik  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||771
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99188] Calc outer border lines do not close nicely when connected

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99188

--- Comment #1 from Roeland  ---
Created attachment 124209
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124209=edit
The "format cells" options used

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99188] New: Calc outer border lines do not close nicely when connected

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99188

Bug ID: 99188
   Summary: Calc outer border lines do not close nicely when
connected
   Product: LibreOffice
   Version: 5.1.1.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roelandb...@hotmail.com

Created attachment 124208
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124208=edit
How the corners of my formatted cells look like

If, in calc, I want to create a cadre around some cells, there's an easy way to
do this via "format cells". The wizard shows a clean box around the cells, but
the outcome is different: the corners of my framework are not seamlessly
connected. i attached some screenshots to illustrate this.

Steps to reproduce:
1. open Calc 
2. select some cells and right click
3. click "Format cells"
4. click "borders" and select "set outer border line only"
5. select thicknes 4 pt and click "ok"
6. expected result: perfect black rectangle around cells, achieved result:
corners of the black borders do not close cleanly

I chose 6pt thickness to better illustrate the problem, but this occurs with
lesser thickness as well.

This problem was tested on 5.1.1 and 5.1.2 on Windows 7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83771] New feature in paragraph or character formating: "Don't Count"

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83771

Henrik  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||189

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99189] New: Add option to exclude footnotes, endnotes and textboxes from word count

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99189

Bug ID: 99189
   Summary: Add option to exclude footnotes, endnotes and
textboxes from word count
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hsones...@gmail.com

The most common parts of a document that people writing essays and other
assignments with a word limit need to exclude from the word count is the text
in footnotes, endnotes and textboxes. Please introduce an easy way to exclude
those from the word count, perhaps like MS Office does it with a checkbox in
the word count dialog. As in MS Office, the word count in the statusbar should
also be affected when the checkbox is ticked in the dialog.

Screenshot of the dialog in MS Office:
https://support.content.office.net/en-us/media/33190838-311d-4bb5-b657-32f915cc1871.png

This request is also mentioned in bug 83771, but there it is mentioned together
with other features so I thought it best to create a new bug for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

--- Comment #4 from Zsolt  ---
(In reply to V Stuart Foote from comment #3)
> OK, but we really need a verbose install log of the font removal as caught
> when doing "msiexec.exe /i  /L*v install.log"  from a
> command window.
> 
> Know it is a hassle of having to work backwards--uninstall, install,
> upgrade. But,
> that captures the logic of why a font is removed rather than upgraded or
> left intact.
> 
> Archive builds are available here:
> http://downloadarchive.documentfoundation.org/libreoffice/old/
> 
> Thanks!

Isn't there an install log that's saved on normal installation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47835] EDITING: Inner table lines turn to yellow when changing outer border

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47835

--- Comment #15 from Joop Lanting  ---
I could not wait so I tried it.
First it crashed in the middle of the table operation.
I gave it a second chance and it failed just like version 5.1.2

;JOOP!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99168] Some PNG printed distorted, displayed correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99168

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99168] Some PNG printed distorted, displayed correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99168

V Stuart Foote  changed:

   What|Removed |Added

Summary|Some Pictures printed   |Some PNG printed distorted,
   |distorted, displayed|displayed correctly
   |correctly   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99168] Some Pictures printed distorted, displayed correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99168

--- Comment #4 from V Stuart Foote  ---
OP replied in PM

Thanks for your fast reaction.

*Conversion to pdf* worked for the two jpgs correctly, but the png was
still distorted but less than when printed on the printer.
If I transform the png to jpg it is also converted correctly and prints
correctly, so there seems to be a problem with png.

*Printing* I print via CUPS with the driver HP Officejet Pro 8000 a809,
hpcups 3.14.6.
Printing from Windows 10 with Writer 4.4.3.2 via the same CUPS on the
same printer works correctly for all 3 pictures.

I cannot upgrade to higher than 5.0.5.1 yet as this is not yet in the
Debian package.

Hope this can help you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

--- Comment #3 from V Stuart Foote  ---
OK, but we really need a verbose install log of the font removal as caught when
doing "msiexec.exe /i  /L*v install.log"  from a command
window.

Know it is a hassle of having to work backwards--uninstall, install, upgrade.
But,
that captures the logic of why a font is removed rather than upgraded or left
intact.

Archive builds are available here:
http://downloadarchive.documentfoundation.org/libreoffice/old/

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47835] EDITING: Inner table lines turn to yellow when changing outer border

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47835

--- Comment #14 from Joop Lanting  ---
Thanks, I will try it 1st thing in the morning tomorrow.
;JOOP!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

--- Comment #2 from Zsolt  ---
(In reply to V Stuart Foote from comment #1)
> For OP, @Zsolt - what was the most recent build you had an issue with?
> 
> This was fixed for bug 76239 for 4.4.7, 5.0.5, and 5.1.0 builds.
> 

When I installed the latest one I have: 5.1.1.3 (x64). The gentium basic fonts
were wiped.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99181] CountIf ? (german: ZÄHLENWENN) with regexp does not count correctly

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99181

--- Comment #2 from Tom  ---
Thank you!
Regexp ".*(mo|mw|ma|ml|mu|my).*" works fine! 
Hope this is explained in documentation/help ...

The following comment is not too important (as it works with the above): 
still the behaviour seems to me not intuitive.
In short: if ".*mo|mw|ma|ml|mu|my.*" matches 
ml
why does it not match
mlm
as is the case?
i.e., it only matches if the cell contains exactly ml and no character before
nor any character thereafter.

So ".*mo|mw|ma|ml|mu|my.*" seems to work exactly like
"mo|mw|ma|ml|mu|my"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99152] Libreoffice installer arbitrarily removes fonts.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99152

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||tima...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---
For OP, @Zsolt - what was the most recent build you had an issue with?

This was fixed for bug 76239 for 4.4.7, 5.0.5, and 5.1.0 builds.

@Andras, depending on OPs response would you prefer we reopen bug 76239 or
collect additional details of what is happening with the Windows packaging of
fonts here?

*** This bug has been marked as a duplicate of bug 76239 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76239] OpenSymbol font is not retained after an upgrade (work around in comment 16, 32, .. install log in comment 50 )

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76239

V Stuart Foote  changed:

   What|Removed |Added

 CC||dqe...@gmail.com

--- Comment #98 from V Stuart Foote  ---
*** Bug 99152 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/IoUtil.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/IoUtil.cpp |   24 +++-
 1 file changed, 15 insertions(+), 9 deletions(-)

New commits:
commit 70e8132866f2143863ab319e783cb54349307aa6
Author: Ashod Nakashian 
Date:   Sat Apr 9 15:41:32 2016 -0400

loolwsd: correct handling socket buffer size and exception handling

Change-Id: I3eb28405c8f30a98c1b1e9644e9303d6074337e3
Reviewed-on: https://gerrit.libreoffice.org/23942
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp
index 3d8b87b..4a595ec 100644
--- a/loolwsd/IoUtil.cpp
+++ b/loolwsd/IoUtil.cpp
@@ -54,6 +54,7 @@ void SocketProcessor(std::shared_ptr ws,
 int n = 0;
 bool stop = false;
 std::vector payload(READ_BUFFER_SIZE * 100);
+payload.resize(0);
 
 for (;;)
 {
@@ -72,10 +73,7 @@ void SocketProcessor(std::shared_ptr ws,
 
 payload.resize(payload.capacity());
 n = ws->receiveFrame(payload.data(), payload.capacity(), flags);
-if (n >= 0)
-{
-payload.resize(n);
-}
+payload.resize(n > 0 ? n : 0);
 
 if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PING)
 {
@@ -149,7 +147,10 @@ void SocketProcessor(std::shared_ptr ws,
 }
 
 // Call the handler.
-if (!handler(payload))
+const auto success = handler(payload);
+payload.resize(0);
+
+if (!success)
 {
 Log::info("Socket handler flagged to finish.");
 break;
@@ -157,12 +158,13 @@ void SocketProcessor(std::shared_ptr ws,
 }
 
 Log::debug() << "SocketProcessor finishing. TerminationFlag: " << stop
+ << ", n: " << n
  << ", payload size: " << payload.size()
  << ", flags: " << std::hex << flags << Log::end;
 if (payload.size() > 1)
 {
-Log::warn("Last message will not be processed: [" +
-  LOOLProtocol::getFirstLine(payload.data(), 
payload.size()) + "].");
+Log::warn("Last message (" + std::to_string(payload.size()) + " 
bytes) will not be processed: [" +
+  std::string(payload.data(), payload.size()) + "].");
 }
 }
 catch (const WebSocketException& exc)
@@ -181,9 +183,13 @@ void SocketProcessor(std::shared_ptr ws,
 break;
 }
 }
-catch (const NetException& exc)
+catch (const Poco::Exception& exc)
+{
+Log::error("SocketProcessor: Exception: " + exc.message());
+}
+catch (const std::exception& exc)
 {
-Log::error("SocketProcessor: NetException: " + exc.message());
+Log::error("SocketProcessor: std::exception: " + 
std::string(exc.what()));
 }
 
 Log::info("SocketProcessor finished.");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Connect.cpp loolwsd/UnitHTTP.hpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/Connect.cpp  |1 +
 loolwsd/UnitHTTP.hpp |1 +
 2 files changed, 2 insertions(+)

New commits:
commit 435b706f9a687f195d65e794827845416a3931c2
Author: Ashod Nakashian 
Date:   Sat Apr 9 15:39:20 2016 -0400

loolwsd: must include Poco/Version.h to define POCO_VERSION

Change-Id: I7dbabff60a9fe100caff2af357b8539126c3c003
Reviewed-on: https://gerrit.libreoffice.org/23940
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Connect.cpp b/loolwsd/Connect.cpp
index 5233b77..91c1418 100644
--- a/loolwsd/Connect.cpp
+++ b/loolwsd/Connect.cpp
@@ -14,6 +14,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
diff --git a/loolwsd/UnitHTTP.hpp b/loolwsd/UnitHTTP.hpp
index 4585caf..1c8f77e 100644
--- a/loolwsd/UnitHTTP.hpp
+++ b/loolwsd/UnitHTTP.hpp
@@ -9,6 +9,7 @@
 #ifndef INCLUDED_UNITHTTP_HPP
 #define INCLUDED_UNITHTTP_HPP
 
+#include 
 #include 
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Util.cpp

2016-04-09 Thread Ashod Nakashian

 loolwsd/Util.cpp |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit e5846ee2ccab145e68865e13c890208a3dfdc7ec
Author: Ashod Nakashian 
Date:   Sat Apr 9 15:40:51 2016 -0400

loolwsd: supress unused-result and log error

Change-Id: I0ca04d5d9e18fdda6c2dca29386dbcc9a6df7784
Reviewed-on: https://gerrit.libreoffice.org/23941
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index f60f9a0..c26e63b 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -454,7 +454,11 @@ namespace Util
 ioVector[1+i*2+1].iov_base = (void*)"\n";
 ioVector[1+i*2+1].iov_len = 1;
 }
-writev(STDERR_FILENO, ioVector, numSlots*2+1);
+
+if (writev(STDERR_FILENO, ioVector, numSlots*2+1) == -1)
+{
+Log::syserror("Failed to dump backtrace to stderr.");
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99186] Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

--- Comment #2 from Kruno  ---
Or is it a feature? Didn't used on LO to change styles on it's own...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98366] Not working preview the galleries created with LibreOffice version 4.4 or newer.

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98366

Joel Madero  changed:

   What|Removed |Added

   Keywords||needsDevEval
Version|4.4.7.2 release |4.4.6.1 rc

--- Comment #17 from Joel Madero  ---
Fantastic - I think we've done everything we can do. Now we wait and hope a
developer finds it interesting enough to tackle.

This might even be an easy hack so I'll request some additional input from
developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99187] New: unable to delete contents of load url bar

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99187

Bug ID: 99187
   Summary: unable to delete contents of load url bar
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: inp...@gmail.com

Unable to delete list of files open previously, visible in toolbar option 'load
url bar'

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99186] Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

--- Comment #1 from Kruno  ---
And can't delete it when there is only one (first and only) row of text and it
has horizontal line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

2016-04-09 Thread Caolán McNamara

 sc/inc/fillinfo.hxx  |   31 
 sc/source/core/data/fillinfo.cxx |   72 +++
 2 files changed, 52 insertions(+), 51 deletions(-)

New commits:
commit 3ac0778c0a2b2f693a1029b7b05c1be4f71944a9
Author: CaolÃ¡n McNamara 
Date:   Sat Apr 9 20:39:48 2016 +0100

coverity#738785 reorg to silence Uninitialized pointer field

Change-Id: If2225e77215e2a6fb6b9e9dfc6021a2c20babe50

diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index a52e6a1..d35bb8e 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -96,7 +96,36 @@ struct ScIconSetInfo
 
 struct CellInfo
 {
-CellInfo() = default;
+CellInfo()
+: pPatternAttr(nullptr)
+, pConditionSet(nullptr)
+, pBackground(nullptr)   // TODO: omit?
+, pLinesAttr(nullptr)
+, mpTLBRLine(nullptr)
+, mpBLTRLine(nullptr)
+, pShadowAttr(nullptr)
+, pHShadowOrigin(nullptr)
+, pVShadowOrigin(nullptr)
+, eHShadowPart(SC_SHADOW_HSTART)
+, eVShadowPart(SC_SHADOW_HSTART)
+, nClipMark(SC_CLIPMARK_NONE)
+, nWidth(0)
+, nRotateDir(SC_ROTDIR_NONE)
+, bMarked(false)
+, bEmptyCellText(false)
+, bMerged(false)
+, bHOverlapped(false)
+, bVOverlapped(false)
+, bAutoFilter(false)
+, bPivotButton(false)
+, bPivotPopupButton(false)
+, bFilterActive(false)
+, bPrinted(false)   // view-internal
+, bHideGrid(false)  // view-internal
+, bEditEngine(false)// view-internal
+{
+}
+
 ~CellInfo() = default;
 CellInfo(const CellInfo&) = delete;
 const CellInfo& operator=(const CellInfo&) = delete;
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 53f0bce..ffeb066 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -157,11 +157,11 @@ class RowInfoFiller
 {
 alignArray(nRow);
 
-RowInfo* pThisRowInfo = [mnArrY];
-CellInfo* pInfo = >pCellInfo[mnArrX];
-pInfo->maCell = rCell;
-pThisRowInfo->bEmptyText = false;
-pInfo->bEmptyCellText = false;
+RowInfo& rThisRowInfo = mpRowInfo[mnArrY];
+CellInfo& rInfo = rThisRowInfo.pCellInfo[mnArrX];
+rInfo.maCell = rCell;
+rThisRowInfo.bEmptyText = false;
+rInfo.bEmptyCellText = false;
 ++mnArrY;
 }
 
@@ -266,55 +266,27 @@ void initCellInfo(RowInfo* pRowInfo, SCSIZE nArrCount, 
SCCOL nRotMax, bool bPain
 const SvxShadowItem* pDefShadow, SCROW nBlockStartY, SCROW nBlockEndY,
 SCCOL nBlockStartX, SCCOL nBlockEndX)
 {
-for (SCSIZE nArrRow = 0; nArrRow < nArrCount; nArrRow++)
+for (SCSIZE nArrRow = 0; nArrRow < nArrCount; ++nArrRow)
 {
-RowInfo* pThisRowInfo = [nArrRow];
-SCROW nY = pThisRowInfo->nRowNo;
-pThisRowInfo->pCellInfo = new CellInfo[ nRotMax+1+2 ];  // to delete 
the caller!
+RowInfo& rThisRowInfo = pRowInfo[nArrRow];
+SCROW nY = rThisRowInfo.nRowNo;
+rThisRowInfo.pCellInfo = new CellInfo[nRotMax + 1 + 2];  // to delete 
the caller!
 
-for (SCCOL nArrCol = 0; nArrCol <= nRotMax+2; nArrCol++)  // 
Preassign cell info
+for (SCCOL nArrCol = 0; nArrCol <= nRotMax+2; ++nArrCol) // Preassign 
cell info
 {
-SCCOL nX;
-if (nArrCol>0)
-nX = nArrCol-1;
-else
-nX = MAXCOL+1;  // invalid
-
-CellInfo* pInfo = >pCellInfo[nArrCol];
-pInfo->bEmptyCellText = true;
-pInfo->maCell.clear();
+CellInfo& rInfo = rThisRowInfo.pCellInfo[nArrCol];
 if (bPaintMarks)
-pInfo->bMarked = ( nX >= nBlockStartX && nX <= nBlockEndX
-&& nY >= nBlockStartY && nY <= nBlockEndY );
-else
-pInfo->bMarked = false;
-pInfo->nWidth = 0;
-
-pInfo->nClipMark= SC_CLIPMARK_NONE;
-pInfo->bMerged  = false;
-pInfo->bHOverlapped = false;
-pInfo->bVOverlapped = false;
-pInfo->bAutoFilter  = false;
-pInfo->bPivotButton  = false;
-pInfo->bPivotPopupButton = false;
-pInfo->bFilterActive = false;
-pInfo->nRotateDir   = SC_ROTDIR_NONE;
-
-pInfo->bPrinted = false;//  view-internal
-pInfo->bHideGrid= false;//  view-internal
-pInfo->bEditEngine  = false;//  view-internal
-
-pInfo->pBackground  = nullptr; //TODO: omit?
-pInfo->pPatternAttr = nullptr;
-pInfo->pConditionSet= nullptr;
-
-pInfo->pLinesAttr   = nullptr;
-pInfo->mpTLBRLine   = nullptr;
-pInfo->mpBLTRLine   = nullptr;
-
-

[Libreoffice-bugs] [Bug 99186] New: Inserting horizontal rule shrinks paragraph to font 6

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99186

Bug ID: 99186
   Summary: Inserting horizontal rule shrinks paragraph to font 6
   Product: LibreOffice
   Version: 5.1.2.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kruno...@gmx.com

Write something, go Insert → Horizontal rule and text shrinks to 6pt.

Version: 5.1.2.2
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: hr-HR (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98993] Rounding off entries distorts line spacing

2016-04-09 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98993

Cor Nouws  changed:

   What|Removed |Added

   Keywords||bibisectRequest
 CC||c...@nouenoff.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 >

1 - 100 of 175 matches

Mail list logo