[Libreoffice-bugs] [Bug 99385] Libreoffice installation not creating a Libreoffice Writer shortcut in the right click/New Desktop menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99385 --- Comment #2 from Martin Hooper--- New Text document is a TXT file not an ODT - Opens in Notepad on my system. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87153] Named Range Reference Updated After Deletion of Data
https://bugs.documentfoundation.org/show_bug.cgi?id=87153 mahfiazchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from mahfiaz --- Thanks for reporting back. If you say it works in a newer version, then it's safe to mark this as resolved, worksforme. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87142] LibreOffice doesn't output the correct results for formula containing ranges when cells in the range are deleted (hard recalc needed)
https://bugs.documentfoundation.org/show_bug.cgi?id=87142 mahfiazchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from mahfiaz --- I tested with 5.0.2.0, couldn't reproduce. Also as per Timur's comment and the age of this report I close this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86725] Comments disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=86725 --- Comment #5 from mahfiaz--- I opened the attached document with 5.0.5.2, all the comments were hidden (the red dot next to cell). Changed a cell, saved as to my desktop. Opened it again. Comments were still there (although hidden as they should be). Does it work for you in 5.x or am I doing something different? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93123] VIEWING: Split/frozen sheet not redrawn properly when formula with manual range selection causes page to scroll
https://bugs.documentfoundation.org/show_bug.cgi?id=93123 mahfiazchanged: What|Removed |Added Priority|medium |low Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|normal |minor --- Comment #10 from mahfiaz --- Yep, I finally am able to reproduce it. It turns out my habit to close parenthesis of expressions failed me this time. You should type =SUM(, otherwise the tooltip is hidden before the scrolling takes place. In its current form this takes place only if you drag with your mouse. Click to select, just typing or numerous other sequences won't cause this. Therefore lowering it's importance. That said there are other similar strange cases when tooltips, parts of selection area borders and possibly more are left behind. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94341] Total record number overwritten in record toolbar control on form
https://bugs.documentfoundation.org/show_bug.cgi?id=94341 raalchanged: What|Removed |Added CC||flonfl...@free.fr --- Comment #27 from raal --- *** Bug 99382 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99382] Probléme en mode formulaire
https://bugs.documentfoundation.org/show_bug.cgi?id=99382 raalchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #1 from raal --- Hello, Thank you for submitting the bug. The bug has previously been reported, so this bug will be added as a duplicate of it. You will automatically be CCed to updates made to the other bug. *** This bug has been marked as a duplicate of bug 94341 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=99383 raalchanged: What|Removed |Added Keywords||needsUXEval Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- I can confirm with LO 5.2, win10. UX team - this is for sure known problem, but I can not find duplicate, thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 99383] Problem with toolbar in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=99383 raalchanged: What|Removed |Added Keywords||needsUXEval Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- I can confirm with LO 5.2, win10. UX team - this is for sure known problem, but I can not find duplicate, thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 99384] Text box indentation marks actually belong to the main text body
https://bugs.documentfoundation.org/show_bug.cgi?id=99384 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Created attachment 124483 --> https://bugs.documentfoundation.org/attachment.cgi?id=124483=edit printscreen from 5.2 I can not confirm with Version: 5.2.0.0.alpha0+ Textbox has own ruller -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99385] Libreoffice installation not creating a Libreoffice Writer shortcut in the right click/New Desktop menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99385 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- I can not confirm with LO 5.1.2, win10. Item New text document is present. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.
https://bugs.documentfoundation.org/show_bug.cgi?id=99197 --- Comment #8 from Niels Kristian Bech Jensen--- I suspect that the problem is linked to text direction or justification. I have opened the test case in LibreOffice 5.1.2.2 and saved it without changes. Opening the saved file in MS Office 2010 renders it all right justified even though the program is set to left justified. Best regards, Niels Kristian Bech Jensen -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.
https://bugs.documentfoundation.org/show_bug.cgi?id=99197 --- Comment #6 from Niels Kristian Bech Jensen--- Created attachment 124481 --> https://bugs.documentfoundation.org/attachment.cgi?id=124481=edit The test case opened and saved in LibreOffice 5.1.2.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99197] Rendering error of punctuation mark in Word document.
https://bugs.documentfoundation.org/show_bug.cgi?id=99197 --- Comment #7 from Niels Kristian Bech Jensen--- Created attachment 124482 --> https://bugs.documentfoundation.org/attachment.cgi?id=124482=edit Output from MS Office 2010 after saving the test case in LibreOffice. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99385] Libreoffice installation not creating a Libreoffice Writer shortcut in the right click/New Desktop menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99385 Martin Hooperchanged: What|Removed |Added Hardware|All |x86-64 (AMD64) OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99385] New: Libreoffice installation not creating a Libreoffice Writer shortcut in the right click/New Desktop menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99385 Bug ID: 99385 Summary: Libreoffice installation not creating a Libreoffice Writer shortcut in the right click/New Desktop menu Product: LibreOffice Version: 5.1.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mar...@mjhooper.co.uk When I right click the Windows 10 Desktop and select the New entry there are entries for Presentations, Spreadsheets and Drawings but not one for Writer. I have only noticed this in the latest release - Have been updating between releases installing over the top of the old version every time. There should be a Libreoffice Writer entry there as well as the others. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/loolwsd.xml.in
loolwsd/loolwsd.xml.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f62f336d5c0099faba73bfec6b53de4e7c3d36c8 Author: Ashod NakashianDate: Mon Apr 18 21:43:39 2016 -0400 loolwsd: fix typo in config Change-Id: I27618137bb0b6a7162c1a03806942ee0033be74e Reviewed-on: https://gerrit.libreoffice.org/24234 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/loolwsd.xml.in b/loolwsd/loolwsd.xml.in index 59dd0bb..d44d3ee 100644 --- a/loolwsd/loolwsd.xml.in +++ b/loolwsd/loolwsd.xml.in @@ -27,7 +27,7 @@ localhost 192\.168\.[0-9]{1,3}\.[0-9]{1,3} -192\.168\.1\.1 +192\.168\.1\.1 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/loolwsd.xml.in loolwsd/Storage.cpp loolwsd/Storage.hpp
loolwsd/Storage.cpp| 19 ++- loolwsd/Storage.hpp|4 ++-- loolwsd/loolwsd.xml.in |4 +++- 3 files changed, 11 insertions(+), 16 deletions(-) New commits: commit 23003c455c5ecc0d4c882fdc66a3ea2bcd993b53 Author: Ashod NakashianDate: Mon Apr 18 21:13:17 2016 -0400 bccu#1696 - enable WOPI connection from the same host by default Since auto-discovery is problematic, this patch implements support for both regex patterned hostnames/IPs to allow, and those to block/deny. A hostname/IP must be both allowed, and not denied, to be accepted. By setting ranges of allowed hostnames/IPs, and others to block/deny, an admin can configure Online with great flexibility. Defaults updated with same values, but not exhaustive. Change-Id: Iedfcafe41d07d905b549fb450c3fe625ad44599e Reviewed-on: https://gerrit.libreoffice.org/24233 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/Storage.cpp b/loolwsd/Storage.cpp index 2e227b5..309748d 100644 --- a/loolwsd/Storage.cpp +++ b/loolwsd/Storage.cpp @@ -34,7 +34,7 @@ /// bool StorageBase::_filesystemEnabled; bool StorageBase::_wopiEnabled; -std::set StorageBase::_wopiHosts; +Util::RegexListMatcher StorageBase::_wopiHosts; std::string StorageBase::getLocalRootPath() const { @@ -76,16 +76,12 @@ void StorageBase::initialize() if (app.config().getBool(path + "[@allow]", false)) { Log::info("Adding trusted WOPI host: [" + host + "]."); -_wopiHosts.insert(host); +_wopiHosts.allow(host); } else { -if (_wopiHosts.find(host) != _wopiHosts.end()) -{ -Log::warn("Configuration of WOPI trusted hosts contains conflicting duplicates."); -} - -_wopiHosts.erase(host); +Log::info("Adding blocked WOPI host: [" + host + "]."); +_wopiHosts.deny(host); } } else if (!app.config().has(path)) @@ -118,12 +114,9 @@ std::unique_ptr StorageBase::create(const std::string& jailRoot, co { Log::info("Public URI [" + uri.toString() + "] considered WOPI."); const auto targetHost = uri.getHost(); -for (const auto& acceptedHost : _wopiHosts) +if (_wopiHosts.match(targetHost)) { -if (targetHost == acceptedHost) -{ -return std::unique_ptr(new WopiStorage(jailRoot, jailPath, uri.toString())); -} +return std::unique_ptr(new WopiStorage(jailRoot, jailPath, uri.toString())); } Log::error("No acceptable WOPI hosts found matching the target host [" + targetHost + "] in config."); diff --git a/loolwsd/Storage.hpp b/loolwsd/Storage.hpp index 7114269..564663c 100644 --- a/loolwsd/Storage.hpp +++ b/loolwsd/Storage.hpp @@ -87,8 +87,8 @@ protected: static bool _filesystemEnabled; static bool _wopiEnabled; -/// Allowed/trusted WOPI hosts, if any and if WOPI is enabled. -static std::set _wopiHosts; +/// Allowed/denied WOPI hosts, if any and if WOPI is enabled. +static Util::RegexListMatcher _wopiHosts; }; /// Trivial implementation of local storage that does not need do anything. diff --git a/loolwsd/loolwsd.xml.in b/loolwsd/loolwsd.xml.in index 86aa0cb..59dd0bb 100644 --- a/loolwsd/loolwsd.xml.in +++ b/loolwsd/loolwsd.xml.in @@ -25,7 +25,9 @@ -localhost +localhost +192\.168\.[0-9]{1,3}\.[0-9]{1,3} +192\.168\.1\.1 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/test loolwsd/Util.hpp
loolwsd/Util.hpp | 22 loolwsd/test/WhiteBoxTests.cpp | 43 + 2 files changed, 65 insertions(+) New commits: commit 3878f3b5154d64fb9416915b0924c4566312a3c9 Author: Ashod NakashianDate: Mon Apr 18 21:11:33 2016 -0400 loolwsd: initialization and resetting support in RegexListMatcher Change-Id: Ic262cf9e4a21d30b6dfd9d9fc0d895f89d7d8e7b Reviewed-on: https://gerrit.libreoffice.org/24232 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp index 1635c5d..3b466cf 100644 --- a/loolwsd/Util.hpp +++ b/loolwsd/Util.hpp @@ -127,6 +127,22 @@ namespace Util class RegexListMatcher { public: +RegexListMatcher() +{ +} + +RegexListMatcher(std::initializer_list allow) : +_allowed(allow) +{ +} + +RegexListMatcher(std::initializer_list allow, + std::initializer_list deny) : +_allowed(allow), +_denied(deny) +{ +} + void allow(const std::string& pattern) { _allowed.insert(pattern); } void deny(const std::string& pattern) { @@ -134,6 +150,12 @@ namespace Util _denied.insert(pattern); } +void clear() +{ +_allowed.clear(); +_denied.clear(); +} + bool match(const std::string& subject) const { return (match(_allowed, subject) && !match(_denied, subject)); diff --git a/loolwsd/test/WhiteBoxTests.cpp b/loolwsd/test/WhiteBoxTests.cpp index 79104f1..92b3df9 100644 --- a/loolwsd/test/WhiteBoxTests.cpp +++ b/loolwsd/test/WhiteBoxTests.cpp @@ -20,10 +20,12 @@ class WhiteBoxTests : public CPPUNIT_NS::TestFixture CPPUNIT_TEST_SUITE(WhiteBoxTests); CPPUNIT_TEST(testRegexListMatcher); +CPPUNIT_TEST(testRegexListMatcher_Init); CPPUNIT_TEST_SUITE_END(); void testRegexListMatcher(); +void testRegexListMatcher_Init(); }; void WhiteBoxTests::testRegexListMatcher() @@ -58,6 +60,47 @@ void WhiteBoxTests::testRegexListMatcher() CPPUNIT_ASSERT(!matcher.match("staging.collaboracloudsuite")); CPPUNIT_ASSERT(!matcher.match("web.collaboracloudsuite")); CPPUNIT_ASSERT(!matcher.match("staging.collaboracloudsuite.com")); + +matcher.allow("10\\.10\\.[0-9]{1,3}\\.[0-9]{1,3}"); +matcher.deny("10\\.10\\.10\\.10"); +CPPUNIT_ASSERT(matcher.match("10.10.001.001")); +CPPUNIT_ASSERT(!matcher.match("10.10.10.10")); +CPPUNIT_ASSERT(matcher.match("10.10.250.254")); +} + + +void WhiteBoxTests::testRegexListMatcher_Init() +{ +Util::RegexListMatcher matcher({"localhost", "192\\..*"}, {"192\\.168\\..*"}); + +CPPUNIT_ASSERT(matcher.match("localhost")); +CPPUNIT_ASSERT(!matcher.match("")); +CPPUNIT_ASSERT(!matcher.match("localhost2")); +CPPUNIT_ASSERT(!matcher.match("xlocalhost")); +CPPUNIT_ASSERT(!matcher.match("192.168.1.1")); +CPPUNIT_ASSERT(matcher.match("192.172.10.122")); + +matcher.deny("localhost"); +CPPUNIT_ASSERT(!matcher.match("localhost")); + +matcher.allow("www[0-9].*"); +CPPUNIT_ASSERT(matcher.match("www1example")); + +matcher.allow("192\\.168\\..*\\..*"); +CPPUNIT_ASSERT(!matcher.match("192.168.1.1")); +CPPUNIT_ASSERT(!matcher.match("192.168.159.1")); +CPPUNIT_ASSERT(!matcher.match("192.168.1.134")); +CPPUNIT_ASSERT(matcher.match("192.169.1.1")); +CPPUNIT_ASSERT(!matcher.match("192.168..")); + +matcher.clear(); + +matcher.allow("192\\.168\\..*\\..*"); +CPPUNIT_ASSERT(matcher.match("192.168.1.1")); +CPPUNIT_ASSERT(matcher.match("192.168.159.1")); +CPPUNIT_ASSERT(matcher.match("192.168.1.134")); +CPPUNIT_ASSERT(!matcher.match("192.169.1.1")); +CPPUNIT_ASSERT(matcher.match("192.168..")); } CPPUNIT_TEST_SUITE_REGISTRATION(WhiteBoxTests); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/test loolwsd/Util.hpp
loolwsd/Util.hpp | 59 + loolwsd/test/Makefile.am |2 - loolwsd/test/WhiteBoxTests.cpp | 65 + 3 files changed, 125 insertions(+), 1 deletion(-) New commits: commit 7d65e30595adef30ef8d0381cc9bca67cd41d8dd Author: Ashod NakashianDate: Mon Apr 18 18:52:10 2016 -0400 loolwsd: regex matching class against whitelist/blacklist With unittests. Change-Id: Ibb14c493cc6de61b6497ab84e34e105481afe464 Reviewed-on: https://gerrit.libreoffice.org/24231 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp index 223d0fb..1635c5d 100644 --- a/loolwsd/Util.hpp +++ b/loolwsd/Util.hpp @@ -14,11 +14,13 @@ #include #include #include +#include #include #include #include #include +#include #define LOK_USE_UNSTABLE_API #include @@ -117,6 +119,63 @@ namespace Util /// Display version information void displayVersionInfo(const char *app); + +/// Given one or more patterns to allow, and one or more to deny, +/// the match member will return true if, and only if, the subject +/// matches the allowed list, but not the deny. +/// By default, everything is denied. +class RegexListMatcher +{ +public: +void allow(const std::string& pattern) { _allowed.insert(pattern); } +void deny(const std::string& pattern) +{ +_allowed.erase(pattern); +_denied.insert(pattern); +} + +bool match(const std::string& subject) const +{ +return (match(_allowed, subject) && !match(_denied, subject)); +} + +private: +bool match(const std::set& set, const std::string& subject) const +{ +if (set.find(subject) != set.end()) +{ +return true; +} + +// Not a perfect match, try regex. +for (const auto& value : set) +{ +try +{ +// Not performance critical to warrant caching. +Poco::RegularExpression re(value, Poco::RegularExpression::RE_CASELESS); +Poco::RegularExpression::Match match; + +// Must be a full match. +if (re.match(subject, match) && match.offset == 0 && match.length == subject.size()) +{ +return true; +} +} +catch (const std::exception& exc) +{ +// Nothing to do; skip. +} +} + +return false; +} + +private: +std::set _allowed; +std::set _denied; +}; + }; #endif diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am index 721ec0c..0a40ef3 100644 --- a/loolwsd/test/Makefile.am +++ b/loolwsd/test/Makefile.am @@ -13,7 +13,7 @@ AM_LDFLAGS = -module $(MAGIC_TO_FORCE_SHLIB_CREATION) AM_CPPFLAGS = -pthread -I$(top_srcdir) test_CPPFLAGS = -DTDOC=\"$(top_srcdir)/test/data\" -test_SOURCES = httpposttest.cpp httpwstest.cpp test.cpp ../LOOLProtocol.cpp +test_SOURCES = WhiteBoxTests.cpp httpposttest.cpp httpwstest.cpp test.cpp ../LOOLProtocol.cpp test_LDADD = $(CPPUNIT_LIBS) # unit test modules: diff --git a/loolwsd/test/WhiteBoxTests.cpp b/loolwsd/test/WhiteBoxTests.cpp new file mode 100644 index 000..79104f1 --- /dev/null +++ b/loolwsd/test/WhiteBoxTests.cpp @@ -0,0 +1,65 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "config.h" + +#include + +#include +#include + +/// WhiteBox unit-tests. +class WhiteBoxTests : public CPPUNIT_NS::TestFixture +{ +CPPUNIT_TEST_SUITE(WhiteBoxTests); + +CPPUNIT_TEST(testRegexListMatcher); + +CPPUNIT_TEST_SUITE_END(); + +void testRegexListMatcher(); +}; + +void WhiteBoxTests::testRegexListMatcher() +{ +Util::RegexListMatcher matcher; + +matcher.allow("localhost"); +CPPUNIT_ASSERT(matcher.match("localhost")); +CPPUNIT_ASSERT(!matcher.match("")); +CPPUNIT_ASSERT(!matcher.match("localhost2")); +CPPUNIT_ASSERT(!matcher.match("xlocalhost")); +CPPUNIT_ASSERT(!matcher.match("192.168.1.1")); + +matcher.deny("localhost"); +CPPUNIT_ASSERT(!matcher.match("localhost")); + +matcher.allow("www[0-9].*"); +CPPUNIT_ASSERT(matcher.match("www1example")); + +matcher.allow("192\\.168\\..*\\..*"); +CPPUNIT_ASSERT(matcher.match("192.168.1.1")); +
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/stylesbuffer.hxx|3 ++- sc/source/filter/oox/sheetdatabuffer.cxx |5 +++-- sc/source/filter/oox/stylesbuffer.cxx|7 +-- 3 files changed, 10 insertions(+), 5 deletions(-) New commits: commit 1be6c440c645e441af0e04ba7711e4b2d80aad63 Author: Markus MohrhardDate: Tue Apr 19 01:47:52 2016 +0200 use the column style for as default, tdf#71897 Change-Id: I583235c28957a203df843d65887b4ca05f2a81ae Reviewed-on: https://gerrit.libreoffice.org/24230 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/source/filter/inc/stylesbuffer.hxx b/sc/source/filter/inc/stylesbuffer.hxx index dcad8cd..1b54809 100644 --- a/sc/source/filter/inc/stylesbuffer.hxx +++ b/sc/source/filter/inc/stylesbuffer.hxx @@ -624,8 +624,9 @@ public: { std::list maAttrs; bool mbLatinNumFmtOnly; +const ScPatternAttr* mpDefPattern; -AttrList(); +AttrList(const ScPatternAttr* pDefPatternAttr); }; explicitXf( const WorkbookHelper& rHelper ); diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx b/sc/source/filter/oox/sheetdatabuffer.cxx index 06768e3..3909e38 100644 --- a/sc/source/filter/oox/sheetdatabuffer.cxx +++ b/sc/source/filter/oox/sheetdatabuffer.cxx @@ -501,8 +501,9 @@ void SheetDataBuffer::finalizeImport() for ( ColStyles::iterator col = maStylesPerColumn.begin(), col_end = maStylesPerColumn.end(); col != col_end; ++col ) { RowStyles& rRowStyles = col->second; -Xf::AttrList aAttrs; SCCOL nScCol = static_cast< SCCOL >( col->first ); +const ScPatternAttr* pDefPattern = rDoc.getDoc().GetPattern(nScCol, 0, getSheetIndex()); +Xf::AttrList aAttrs(pDefPattern); for ( RowStyles::iterator rRows = rRowStyles.begin(), rRows_end = rRowStyles.end(); rRows != rRows_end; ++rRows ) { Xf* pXf = rStyles.getCellXf( rRows->mnNumFmt.first ).get(); @@ -514,7 +515,7 @@ void SheetDataBuffer::finalizeImport() { ScAttrEntry aEntry; aEntry.nRow = MAXROW; -aEntry.pPattern = rDoc.getDoc().GetPattern(nScCol, 0, getSheetIndex()); +aEntry.pPattern = pDefPattern; rDoc.getDoc().GetPool()->Put(*aEntry.pPattern); aAttrs.maAttrs.push_back(aEntry); diff --git a/sc/source/filter/oox/stylesbuffer.cxx b/sc/source/filter/oox/stylesbuffer.cxx index 1e48469..4ebe396 100644 --- a/sc/source/filter/oox/stylesbuffer.cxx +++ b/sc/source/filter/oox/stylesbuffer.cxx @@ -2051,7 +2051,10 @@ XfModel::XfModel() : { } -Xf::AttrList::AttrList() : mbLatinNumFmtOnly(true) {} +Xf::AttrList::AttrList(const ScPatternAttr* pDefPattern): +mbLatinNumFmtOnly(true), +mpDefPattern(pDefPattern) +{} Xf::Xf( const WorkbookHelper& rHelper ) : WorkbookHelper( rHelper ), @@ -2181,7 +2184,7 @@ void Xf::applyPatternToAttrList( AttrList& rAttrs, SCROW nRow1, SCROW nRow2, sal // Fill this gap with the default pattern. ScAttrEntry aEntry; aEntry.nRow = nRow1 - 1; -aEntry.pPattern = rDoc.GetDefPattern(); +aEntry.pPattern = static_cast(()->Put(*rAttrs.mpDefPattern)); rAttrs.maAttrs.push_back(aEntry); // Check if the default pattern is 'General'. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/worksheethelper.cxx |4 1 file changed, 4 deletions(-) New commits: commit a71576f1c5a2a76eaedca99c025d027b55ce8c90 Author: Markus MohrhardDate: Tue Apr 19 01:15:48 2016 +0200 setting the properties through uno is not necessary anymore Change-Id: Icdd78ffb386b6b5222558dde0a6a9439b1431781 Reviewed-on: https://gerrit.libreoffice.org/24229 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/source/filter/oox/worksheethelper.cxx b/sc/source/filter/oox/worksheethelper.cxx index fa0efef..0f1c420 100644 --- a/sc/source/filter/oox/worksheethelper.cxx +++ b/sc/source/filter/oox/worksheethelper.cxx @@ -860,10 +860,6 @@ void WorksheetGlobals::convertColumnFormat( sal_Int32 nFirstCol, sal_Int32 nLast { const StylesBuffer& rStyles = getStyles(); -// Set cell styles via UNO API. We should move these to the direct API. -PropertySet aPropSet( getCellRange( aRange ) ); -rStyles.writeCellXfToPropertySet(aPropSet, nXfId); - // Set cell styles via direct API - the preferred approach. ScDocumentImport& rDoc = getDocImport(); rStyles.writeCellXfToDoc(rDoc, aRange, nXfId); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89058] Saving spreadsheet with Calc makes Excel display its horizontal scrollbar with zero width
https://bugs.documentfoundation.org/show_bug.cgi?id=89058 Markus Mohrhardchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com --- Comment #17 from Markus Mohrhard --- While this is currently only a work around I consider this "fixed". Without going back to a one row layout we can't get perfect interoperability again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89058] Saving spreadsheet with Calc makes Excel display its horizontal scrollbar with zero width
https://bugs.documentfoundation.org/show_bug.cgi?id=89058 --- Comment #16 from Commit Notification--- Markus Mohrhard committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6342041cdd700922af5e07cde0d1bd8e6ea42f0a hard code value for scrollbar to tabbar ratio, tdf#89058 It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89058] Saving spreadsheet with Calc makes Excel display its horizontal scrollbar with zero width
https://bugs.documentfoundation.org/show_bug.cgi?id=89058 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/tabview.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 6342041cdd700922af5e07cde0d1bd8e6ea42f0a Author: Markus MohrhardDate: Tue Apr 19 03:28:30 2016 +0200 hard code value for scrollbar to tabbar ratio, tdf#89058 The regression was introduced with 1d1d1c62caf2ee6a96946e96d782e03f3ef80439 which traded interoperability for some UX "gain". Change-Id: I36517fc550e12714ad5855ce0bc5883f7a948a51 diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx index 1b015d9c..c10f418 100644 --- a/sc/source/ui/view/tabview.cxx +++ b/sc/source/ui/view/tabview.cxx @@ -896,9 +896,7 @@ long ScTabView::GetTabBarWidth() const double ScTabView::GetRelTabBarWidth() const { -if( long nFrameWidth = pFrameWin->GetSizePixel().Width() ) -return static_cast< double >( GetTabBarWidth() ) / nFrameWidth; -return 0.0; +return 0.5; } ScGridWindow* ScTabView::GetActiveWin() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89058] Saving spreadsheet with Calc makes Excel display its horizontal scrollbar with zero width
https://bugs.documentfoundation.org/show_bug.cgi?id=89058 --- Comment #15 from Markus Mohrhard--- (In reply to Andras Timar from comment #10) > Most probably the regression was caused by > commit 1d1d1c62caf2ee6a96946e96d782e03f3ef80439 > Author: Tomaž Vajngerl > Date: Mon Aug 25 18:20:58 2014 +0200 > > fdo#36772 Move the scrollbar and sheet tabs in a separate row. > > Change-Id: I57d891d9f6e89dafb4840a577ba55baa734fdcc2 Yes. This patch broke the interoperability around that feature completely. We now need to decide if interoperability or the scrollbar in an own row are more important. IMHO it is interoperability but I suppose the UX people think otherwise. For now I will hard code a factor of 0.5. It is no longer possible to handle that correctly as the scrollbar is no longer resized. It used to be that tab bar and scrollbar were on the same row and therefore we could store the relative size of them. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60778] EDITING (some?) changes of currency format should trigger a recompute/reformat/...
https://bugs.documentfoundation.org/show_bug.cgi?id=60778 Markus Mohrhardchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #6 from Markus Mohrhard --- This used to be a bug but is now expected behavior. We removed inherited number formats because they were horrible to maintain, contained many bugs (see this bug report) and a performance nightmare. Now you need to explicitly change number formats and number formats don't propagate any more. Only when the cell has not any set number format so for the first time you enter a formula the number format is calculated based on the input. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70959] HYPERLINK-function with Scriptprotocol don' work
https://bugs.documentfoundation.org/show_bug.cgi?id=70959 Markus Mohrhardchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70959] HYPERLINK-function with Scriptprotocol don' work
https://bugs.documentfoundation.org/show_bug.cgi?id=70959 --- Comment #12 from Commit Notification--- Markus Mohrhard committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=170a473597534cf59887b1d817538322e7039862 don't try to open in new window by default, tdf#70959 It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70959] HYPERLINK-function with Scriptprotocol don' work
https://bugs.documentfoundation.org/show_bug.cgi?id=70959 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/global.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 170a473597534cf59887b1d817538322e7039862 Author: Markus MohrhardDate: Tue Apr 19 02:36:28 2016 +0200 don't try to open in new window by default, tdf#70959 This fixes a regression from 99932fa89be0e041abf5ce5da3271600c841ff19 Change-Id: Idcee34c97173fb79503a560f5246230a9bfaeb51 diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx index e764bfe..e9df005 100644 --- a/sc/source/core/data/global.cxx +++ b/sc/source/core/data/global.cxx @@ -901,7 +901,8 @@ void ScGlobal::OpenURL(const OUString& rURL, const OUString& rTarget, const SdrM } SfxStringItem aUrl( SID_FILE_NAME, rURL ); SfxStringItem aTarget( SID_TARGETNAME, rTarget ); -aTarget.SetValue("_blank"); +if ( nScClickMouseModifier & KEY_SHIFT ) // control-click -> into new window +aTarget.SetValue("_blank"); SfxViewFrame* pFrame = nullptr; OUString aReferName; if ( pScActiveViewShell ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/IoUtil.cpp loolwsd/IoUtil.hpp loolwsd/LOOLKit.cpp loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/LOOLWSD.cpp loolwsd/
loolwsd/ChildProcessSession.cpp |7 +++- loolwsd/IoUtil.cpp |4 ++ loolwsd/IoUtil.hpp |1 loolwsd/LOOLKit.cpp | 21 +++-- loolwsd/LOOLSession.cpp |4 -- loolwsd/LOOLSession.hpp |7 loolwsd/LOOLWSD.cpp | 53 - loolwsd/MasterProcessSession.cpp | 61 +++ loolwsd/MasterProcessSession.hpp |5 +-- loolwsd/test/httpwstest.cpp | 47 ++ 10 files changed, 155 insertions(+), 55 deletions(-) New commits: commit c29944a386badbd7093d81ed2842e73b59f40cce Author: Henry CastroDate: Mon Apr 18 19:12:26 2016 -0400 loolwsd: fix close after close The closing handshake. Either peer can send a control frame with data containing a specified control sequence to begin the closing handshake. Upon receiving such a frame, the other peer sends a Close frame in response, if it hasn't already sent one. diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp index ac8b8a0..18bdfb6 100644 --- a/loolwsd/ChildProcessSession.cpp +++ b/loolwsd/ChildProcessSession.cpp @@ -78,7 +78,12 @@ public: Log::trace() << "CallbackWorker::callback [" << _session.getViewId() << "] " << LOKitHelper::kitCallbackTypeToString(nType) << " [" << rPayload << "]." << Log::end; -if (_session.isDisconnected()) +if (_session.isCloseFrame()) +{ +Log::trace("LOKit document begin the closing handshake"); +return; +} +else if (_session.isDisconnected()) { Log::trace("Skipping callback on disconnected session " + _session.getName()); return; diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp index 93a61ea..92b0254 100644 --- a/loolwsd/IoUtil.cpp +++ b/loolwsd/IoUtil.cpp @@ -41,6 +41,7 @@ namespace IoUtil // Handler returns false to end. void SocketProcessor(std::shared_ptr ws, std::function handler, + std::function closeFrame, std::function stopPredicate) { Log::info("SocketProcessor starting."); @@ -93,6 +94,7 @@ void SocketProcessor(std::shared_ptr ws, } else if (n <= 0 || ((flags & WebSocket::FRAME_OP_BITMASK) == WebSocket::FRAME_OP_CLOSE)) { +closeFrame(); Log::warn("Connection closed."); break; } @@ -109,6 +111,7 @@ void SocketProcessor(std::shared_ptr ws, n = ws->receiveFrame(buffer, sizeof(buffer), flags); if (n <= 0 || (flags & WebSocket::FRAME_OP_BITMASK) == WebSocket::FRAME_OP_CLOSE) { +closeFrame(); Log::warn("Connection closed while reading multiframe message."); break; } @@ -138,6 +141,7 @@ void SocketProcessor(std::shared_ptr ws, if (n <= 0 || (flags & WebSocket::FRAME_OP_BITMASK) == WebSocket::FRAME_OP_CLOSE) { +closeFrame(); Log::warn("Connection closed."); break; } diff --git a/loolwsd/IoUtil.hpp b/loolwsd/IoUtil.hpp index 476f515..2b49658 100644 --- a/loolwsd/IoUtil.hpp +++ b/loolwsd/IoUtil.hpp @@ -25,6 +25,7 @@ namespace IoUtil //. Handler returns false to end. void SocketProcessor(std::shared_ptr ws, std::function handler, + std::function closeFrame, std::function stopPredicate); /// Call WebSocket::shutdown() ignoring Poco::IOException. diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp index 28e1d68..7a95bcb 100644 --- a/loolwsd/LOOLKit.cpp +++ b/loolwsd/LOOLKit.cpp @@ -51,6 +51,7 @@ #include "LOOLProtocol.hpp" #include "QueueHandler.hpp" #include "Unit.hpp" +#include "UserMessages.hpp" #include "Util.hpp" #define LIB_SOFFICEAPP "lib" "sofficeapp" ".so" @@ -280,18 +281,31 @@ public: Thread queueHandlerThread; queueHandlerThread.start(handler); +std::shared_ptr session = _session; IoUtil::SocketProcessor(_ws, -[](const std::vector& payload) +[](const std::vector& payload) { queue->put(payload); return true; }, -[]() { return TerminationFlag; }); +[]() { session->closeFrame(); }, +[]() { return TerminationFlag && queueHandlerThread.isRunning(); }); queue->clear(); queue->put("eof"); queueHandlerThread.join(); + +if
[Libreoffice-bugs] [Bug 94792] Fileopen: performance regression for xlsx with chart (per Comment 4)
https://bugs.documentfoundation.org/show_bug.cgi?id=94792 --- Comment #7 from Markus Mohrhard--- (In reply to c.kirbach from comment #5) > Renaming as suggested by you. > > > It doesn't happen with master, LO 5.1+, although it's rather slow to open. > It opens even with 5.0.2.2, but after a "very" long time. It was some recent > regression in terms of terribly slow opening. > Looks like something is fixed, and future releases 5.0.3 and 4.4.6 should be > checked for backport. Performance improvements are nearly never backported. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 --- Comment #23 from Joel Madero--- No need to apologize! My bad - I just want to keep expectations real :) We love user feedback but sometimes users have false expectations of what is to come so I just like to clarify. No offense taken/meant and I'm happy to see users requesting this (I'd love the feature too! I wish I had the skills and/or time to implement). FWIW I poked the creator of the extension some time ago and he wasn't able to add it directly to the code sothat channel is out -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71897] FILESAVE: Format Cells (Numbers) for a whole column not retained in empty cells if saving as XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=71897 Markus Mohrhardchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail. |desktop.org |com --- Comment #15 from Markus Mohrhard --- This is an import and not an export bug. The file is correctly written by the export code. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 --- Comment #22 from Dominik Lenné--- I did not intend to offend anybody and am sorry if what i wrote came across like an offense. Maybe as a non english speaker i was not so aware of the strong negative connotations of the word "showstopper". I am well aware of this old question "Am i entitled to this or that improvement in a software or not.", and clearly the answer is "not", as i did not pay for it (even if i actually donated a small amount of money). OTOH i can imagine, that some developers might be interested in feedback, to just learn, what feature or problem is important to the users out there, who are no geeks. And yes, as i happened to stumble over this issue, i egoistically find arguments why exactly this issue is important. I am honestly convinced that it would be an improvement for a lot of people. If those arguments trigger a discussion - the better. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51964] Custom animation speed is not preserved in copy or save
https://bugs.documentfoundation.org/show_bug.cgi?id=51964 --- Comment #7 from David F Smith--- I have retested this with version 5.1.2.2 (Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f) under Win 7 Pro (v6.1.7601) and the problem still persists. The behavior is exactly the same as described in Comment 1, including the variations listed there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch
https://bugs.documentfoundation.org/show_bug.cgi?id=99258 V Stuart Footechanged: What|Removed |Added CC||noelgran...@gmail.com --- Comment #3 from V Stuart Foote --- So this exception/crash is still occurring in Windows builds of master: Looks to be hanging when falling through the try/catch here: http://opengrok.libreoffice.org/xref/core/desktop/source/deployment/manager/dp_extensionmanager.cxx?#1324 Follow a run in process monitor through to creation of the user profile where it ends with incomplete profile and errors as noted. Last working Windows TB build we've had was 2016-04-06 with Build ID: 157469896ef56720f33676222b95e81c04ab5c72 @Noel, your https://gerrit.libreoffice.org/#/c/23795/ for work on "sequence->vector in xmlscript" was the last to touch this, just coincidence it faults here? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99007] FILEOPEN: Crash when opening documents from Finder
https://bugs.documentfoundation.org/show_bug.cgi?id=99007 --- Comment #9 from Thorsten Wagner--- Tor, thanks for your build options. Using your options build works fine without problems when opening files, but issue reappears when removing "--enable-debug". I'm using the following options without problems with Xcode 7.2.1: --disable-odk --without-doxygen --disable-online-update --disable-firebird-sdbc --without-java Issue is independent from file type. It's easily reproducible by starting LO and selecting "Writer Document" or "Calc Spreadsheet" etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99384] New: Text box indentation marks actually belong to the main text body
https://bugs.documentfoundation.org/show_bug.cgi?id=99384 Bug ID: 99384 Summary: Text box indentation marks actually belong to the main text body Product: LibreOffice Version: 5.0.5.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kla...@partyheld.de When one inserts a text field into a Writer page and sets/moves the manual indentation marks shown as belonging to it, what is actually affected is the main text, not the text box. Test steps: 1. Start LibreOffice, create a new Writer document. 2. In the top ruler, set a manual indentation mark (the "edge") somewhere. 3. Hit TAB to move the carriage to the manual indentation and enter some text there. 4. Insert a text box somewhere. 5. Move the manual indentation mark shown in the text box ruler. Expected results: 4. The text box gets inserted, with a new, unmodified ruler. 5. Indentation for the text box changes. Actual results: 4. The ruler of the main text body, containing the previously manually created indentation mark is shown for the text box. Although hitting the TAB in the text box does not move the carriage to that mark, but to default tabulator positions. 5. Indentation of the text in the main text body changes. Linux Mint 17.1 64-bit LO 5.0.5.2 from ppa:libreoffice/libreoffice-5-0 (Build ID: 1:5.0.5~rc2-0ubuntu1~trusty) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93761] LibreOffice upgrade will not install due to Error 1303 insufficient privileges in program folder
https://bugs.documentfoundation.org/show_bug.cgi?id=93761 Johnny_Mchanged: What|Removed |Added CC||kla...@partyheld.de --- Comment #12 from Johnny_M --- This looks like a duplicate of https://bugs.documentfoundation.org/show_bug.cgi?id=94216 after reopening. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99383] New: Problem with toolbar in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=99383 Bug ID: 99383 Summary: Problem with toolbar in LO Writer Product: LibreOffice Version: 5.1.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nahuel.burs...@outlook.com Created attachment 124480 --> https://bugs.documentfoundation.org/attachment.cgi?id=124480=edit animation of the problem When I'm editing a file and select diferent items from the document, for example, objects, formulas, images, paragraphs, etc. the toolbar move up and down appear and disappear depending on which object I´m. This is very annoying and makes me lose the cursor and changes the position of the elements of the toolbar. Gif http://imgur.com/53eL2wb Is there any chance to block the size of the toolbar? I enabled the "block toolbar position" but that didn`t work. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 --- Comment #21 from Joel Madero--- Note we don't have "show stoppers" - we have an open source (and free) product that users "take it as they get it." If it's a show stopper, no one will be offended if those users use another product that fit their needs better. There are no paid developers under TDF, no one gives orders, it doesn't really matter how many users want an enhancement. The only way this gets done is if a volunteer finds it interesting enough to implement - I suspect this will take a long long time (and likely will never be done) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99367] Calc crash on 4th save
https://bugs.documentfoundation.org/show_bug.cgi?id=99367 MMchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from MM --- Unconfirmed with v5.1.2.2 under ubuntu 16.04 x64. Confirmed with v5.1.2.2 under windows 10 x64. Crashes indeed under windows. Hope someone can find out what's the cause (if it's fixed in dev) and backport to the 5.1 branch. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Julien Nabetchanged: What|Removed |Added Status|REOPENED|NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Julien Nabetchanged: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #4 from Julien Nabet --- About OpenCL, it may be a pb with LO. Could you check if there could be an update for your graphic card (since OpenCL uses it if I don't mistake)? And still, a backtrace could be useful. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 --- Comment #20 from Dominik Lenné--- Addendum: I mean of course the quotation marks be removed, not the columns. Best would be to spread the word to somebody, who knows the import functionality well and for whom it would be a comparatively small effort to implement such an "ignore quotes" pathway. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92218] UNO command for Single Toolbar Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=92218 --- Comment #17 from V Stuart Foote--- (In reply to Yousuf (Jay) Philips from comment #15) > (In reply to kompilainenn from comment #14) > > Yousuf, single toolbar in Writer does not fit in 1280 pixel width. It's > > default resolution of my monitor 19" (1280х1024) > > Kompilainenn, it fits if you use small icons, which is how it is intended to > fit for users by default, while users with larger screens can use large > icons if they choose. > > https://wiki.documentfoundation.org/images/9/99/Single_Toolbar_Mode.png The Standard (Single Mode) toolbar already has the double >> showing a drop menu of the remaining hidden widget buttons. So use on screens narrower than 1280px or when sized narrow the buttons are available. But can an action of the toggle into the Standard (Single Mode) include adjustment of the Icon size to small? We set Icon Size to Auto by default, can we make use of that? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 --- Comment #19 from Dominik Lenné--- As one can see from all these dupes coming up, it seems to be something wished by the public and an important improvement. The problem is a showstopper for the non-computer-savvy and is still quite annoying for the geeks. For this issue, it is not at all important if ct2n is working or not. A different - and maybe even more elegant - way to achieve the same goal would be to modify the import functionality. I could detect columns, the content of which is put between quotation marks and ask the user, if they should be removed during import. This could even be the default setting, with no disadvantages coming to my mind. Thus, the whole problem would be avoided in the first place. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source
sc/source/core/data/dpsave.cxx |6 +++--- sc/source/ui/unoobj/dapiuno.cxx |3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) New commits: commit dba0cc1edc6d778805ca8ed4b77800f1e9a95408 Author: Michael StahlDate: Wed Apr 13 16:39:38 2016 +0200 tdf#96996 sc: fix the data pilot ScDPSaveData::GetInnermostDimension() should iterate in reverse (that fixes the reported bug), and ScDataPilotFieldObj::setOrientation() loop needs an early exit. (regression from 37856f59d2351951b95cf5eb3a5e4f0c011a8762) Change-Id: I7e0309385f3444bfd3ad21268cce4d25e60d7b05 (cherry picked from commit 470f16acc2a798f0ae1ebe9ce2080084ab167e80) Reviewed-on: https://gerrit.libreoffice.org/24060 Tested-by: Jenkins Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/sc/source/core/data/dpsave.cxx b/sc/source/core/data/dpsave.cxx index 82d810c..708c8b2 100644 --- a/sc/source/core/data/dpsave.cxx +++ b/sc/source/core/data/dpsave.cxx @@ -1043,10 +1043,10 @@ ScDPSaveDimension* ScDPSaveData::GetInnermostDimension(sal_uInt16 nOrientation) // return the innermost dimension for the given orientation, // excluding data layout dimension -for (auto const& iter : m_DimList) +for (auto iter = m_DimList.rbegin(); iter != m_DimList.rend(); ++iter) { -if (iter->GetOrientation() == nOrientation && !iter->IsDataLayout()) -return &(*iter); +if ((*iter)->GetOrientation() == nOrientation && !(*iter)->IsDataLayout()) +return iter->get(); } return nullptr; diff --git a/sc/source/ui/unoobj/dapiuno.cxx b/sc/source/ui/unoobj/dapiuno.cxx index 8958182..d5881de 100644 --- a/sc/source/ui/unoobj/dapiuno.cxx +++ b/sc/source/ui/unoobj/dapiuno.cxx @@ -2071,7 +2071,10 @@ void ScDataPilotFieldObj::setOrientation(DataPilotFieldOrientation eNew) if ( !it->IsDataLayout() && (it->GetName() == maFieldId.maFieldName) ) { if ( it->GetOrientation() == DataPilotFieldOrientation_HIDDEN ) +{ pNewDim = it.get(); // use this one +break; +} else ++nFound; // count existing non-hidden occurrences } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Usman Khan license statement
All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/postgresql/pq_xcolumns.hxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit a07d5aef3f251855a4856f1e59649194a07899e5 Author: Jochen NitschkeDate: Mon Apr 18 21:00:13 2016 +0200 follow-up for clean-up declarations and includes small change for commit 150ac9cf05ed9da6a2af5bc3f820280fd853e519 use forward declaration instead of include Change-Id: Ida9742b49233dc2bd2731e816dd6dc4d5705bb07 Reviewed-on: https://gerrit.libreoffice.org/24222 Reviewed-by: Stephan Bergmann Tested-by: Stephan Bergmann diff --git a/connectivity/source/drivers/postgresql/pq_xcolumns.hxx b/connectivity/source/drivers/postgresql/pq_xcolumns.hxx index 0af1337..5daeeb2 100644 --- a/connectivity/source/drivers/postgresql/pq_xcolumns.hxx +++ b/connectivity/source/drivers/postgresql/pq_xcolumns.hxx @@ -39,7 +39,8 @@ #include "pq_xcontainer.hxx" #include "pq_xbase.hxx" -#include + +namespace com { namespace sun { namespace star { namespace sdbc { class XRow; } } } } namespace pq_sdbc_driver { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92218] UNO command for Single Toolbar Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=92218 --- Comment #16 from kompilainenn <79045_79...@mail.ru> --- (In reply to Yousuf (Jay) Philips from comment #15) > (In reply to kompilainenn from comment #14) > > Yousuf, single toolbar in Writer does not fit in 1280 pixel width. It's > > default resolution of my monitor 19" (1280х1024) > > Kompilainenn, it fits if you use small icons, which is how it is intended to > fit for users by default, while users with larger screens can use large > icons if they choose. > > https://wiki.documentfoundation.org/images/9/99/Single_Toolbar_Mode.png by default, Windows build uses large icons on Toolbars. Maybe envisage verification before activation Single Toolbar? Or show notification to the user..."Your monitor have aspect ratio 5:4. Use mode Single Toolbar with small icons or not use it's!"? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33962] Add CT2N Extension
https://bugs.documentfoundation.org/show_bug.cgi?id=33962 Joel Maderochanged: What|Removed |Added CC||dle...@web.de --- Comment #18 from Joel Madero --- *** Bug 99374 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99374] Fields in csv-imported files cannot simply be given other format because of apostrophe added
https://bugs.documentfoundation.org/show_bug.cgi?id=99374 Joel Maderochanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Joel Madero --- Then it's a dupe. Also NEW is never correct for the reporter (UNCONFIRMED is the right move). But here this can be a dupe: *** This bug has been marked as a duplicate of bug 33962 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/data/document.cxx |8 1 file changed, 8 insertions(+) New commits: commit 6c80a566d21ffc0f471f0b282929f964ab10e445 Author: Eike RathkeDate: Mon Apr 18 22:03:07 2016 +0200 Resolves: tdf#99322 re-establish group area listeners after update reference Change-Id: If2ec5f938c7278ce817de3d89dc84cc0584507ac (cherry picked from commit 44e2da58226448c5617eac08ca2ae3d9a9ad2afa) Reviewed-on: https://gerrit.libreoffice.org/24226 Reviewed-by: Markus Mohrhard Tested-by: Markus Mohrhard diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 8e57020..16be98b 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -2596,6 +2596,14 @@ void ScDocument::CopyBlockFromClip( SetInsertingFromOtherDoc( true); aRefCxt.meMode = URM_MOVE; UpdateReference(aRefCxt, rCxt.getUndoDoc(), false); + +// For URM_MOVE group listeners may have been removed, +// re-establish them. +/* TODO: actually only those in + * sc::RefUpdateContext::maRegroupCols are affected, + * come up with a start listeners that takes such. */ +StartNeededListeners(); + SetInsertingFromOtherDoc( bOldInserting); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 Bug 65138 depends on bug 87813, which changed state. Bug 87813 Summary: SIDEBAR: Incorporating the effects list into the animation tab https://bugs.documentfoundation.org/show_bug.cgi?id=87813 What|Removed |Added Status|RESOLVED|NEW Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99382] New: Probléme en mode formulaire
https://bugs.documentfoundation.org/show_bug.cgi?id=99382 Bug ID: 99382 Summary: Probléme en mode formulaire Product: LibreOffice Version: 5.1.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: flonfl...@free.fr Created attachment 124479 --> https://bugs.documentfoundation.org/attachment.cgi?id=124479=edit capture d'ecran En mode formulaire au niveau de l'affichage en bas à gauche le compteur fonctionne bien jusqu'à 41 ensuite les chiffres sont en surimpression. Le passage des fiches se passent bien seul l'indication du nombre total d'enregistrement est illisible aprés le De . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99374] Fields in csv-imported files cannot simply be given other format because of apostrophe added
https://bugs.documentfoundation.org/show_bug.cgi?id=99374 Dominik Lennéchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- Ever confirmed|0 |1 Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92218] UNO command for Single Toolbar Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=92218 --- Comment #15 from Yousuf (Jay) Philips--- (In reply to kompilainenn from comment #14) > Yousuf, single toolbar in Writer does not fit in 1280 pixel width. It's > default resolution of my monitor 19" (1280х1024) Kompilainenn, it fits if you use small icons, which is how it is intended to fit for users by default, while users with larger screens can use large icons if they choose. https://wiki.documentfoundation.org/images/9/99/Single_Toolbar_Mode.png -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99374] Fields in csv-imported files cannot simply be given other format because of apostrophe added
https://bugs.documentfoundation.org/show_bug.cgi?id=99374 --- Comment #4 from Dominik Lenné--- Thanks for clarification. I learn that it's called a feature. I would call it nevertheless a problem puzzling a lot of people, forcing them to do lengthy researches and procedures to do a thing, that could as well be done simple, if only included into the core functionality. An unsurmountable problem for the non-computer-savvy. I'll try to make a feature request out of it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] dev-tools.git: scripts/esc-bug-stats.pl
scripts/esc-bug-stats.pl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 508a98010e63feaff0784f63496759dd8b9fb618 Author: Michael MeeksDate: Mon Apr 18 21:13:06 2016 +0100 Get cell references right. diff --git a/scripts/esc-bug-stats.pl b/scripts/esc-bug-stats.pl index db0e8ec..dd88475 100755 --- a/scripts/esc-bug-stats.pl +++ b/scripts/esc-bug-stats.pl @@ -371,9 +371,9 @@ print << "EOF" $date_value - + - + EOF ; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99379] libreoffice wants to recover a saved document
https://bugs.documentfoundation.org/show_bug.cgi?id=99379 --- Comment #2 from MM--- Unconfirmed with v5.1.2.2 under ubuntu 16.04 x64. What it actually does over here (when for example start writer), is auto load the previous documents. Dunno if this is a feature ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - i18npool/source sc/source
i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx |4 +++- sc/source/core/data/document.cxx |8 2 files changed, 11 insertions(+), 1 deletion(-) New commits: commit 44e2da58226448c5617eac08ca2ae3d9a9ad2afa Author: Eike RathkeDate: Mon Apr 18 22:03:07 2016 +0200 Resolves: tdf#99322 re-establish group area listeners after update reference Change-Id: If2ec5f938c7278ce817de3d89dc84cc0584507ac diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 39c8634..ead7178 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -2593,6 +2593,14 @@ void ScDocument::CopyBlockFromClip( SetInsertingFromOtherDoc( true); aRefCxt.meMode = URM_MOVE; UpdateReference(aRefCxt, rCxt.getUndoDoc(), false); + +// For URM_MOVE group listeners may have been removed, +// re-establish them. +/* TODO: actually only those in + * sc::RefUpdateContext::maRegroupCols are affected, + * come up with a start listeners that takes such. */ +StartNeededListeners(); + SetInsertingFromOtherDoc( bOldInserting); } } commit 332ffb5e84a114ac74d209da6eb1856fbba22b66 Author: Eike Rathke Date: Mon Apr 18 19:15:38 2016 +0200 check API call argument value Change-Id: I5eb0fbd6a6671c2cded38800c3223bccf0f7ff60 diff --git a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx index d2b330e..dfec9cf 100644 --- a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx +++ b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx @@ -946,6 +946,9 @@ static const sal_Int32 nSupported_NumberingTypes = sizeof(aSupportedTypes) / siz OUString DefaultNumberingProvider::makeNumberingIdentifier(sal_Int16 index) throw(RuntimeException, std::exception) { +if (index < 0 || index >= nSupported_NumberingTypes) +throw RuntimeException(); + if (aSupportedTypes[index].cSymbol) return OUString(aSupportedTypes[index].cSymbol, strlen(aSupportedTypes[index].cSymbol), RTL_TEXTENCODING_UTF8); else { commit 0d9e0eb6173cb47d8e311384f5aa79a6d10bfac5 Author: Eike Rathke Date: Mon Apr 18 15:28:46 2016 +0200 remove old commented out code Change-Id: I6871370341c8533e93f820e8f71ce09fe3d4d7be diff --git a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx index aa7ad1d..d2b330e 100644 --- a/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx +++ b/i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx @@ -948,7 +948,6 @@ OUString DefaultNumberingProvider::makeNumberingIdentifier(sal_Int16 index) { if (aSupportedTypes[index].cSymbol) return OUString(aSupportedTypes[index].cSymbol, strlen(aSupportedTypes[index].cSymbol), RTL_TEXTENCODING_UTF8); -//return OUString::createFromAscii(aSupportedTypes[index].cSymbol); else { OUString result; Locale aLocale(OUString("en"), OUString(), OUString()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 98940] -1 Max length Multiline Input Text Box form controls are no longer editable, and the maximum max length is much less than the textbox has handled in previous versions
https://bugs.documentfoundation.org/show_bug.cgi?id=98940 --- Comment #2 from Ray--- I just tried 5.1.2.-3~bpo8+1 from Debian jessie-backports, and the bug is still there. I did notice another wrinkle. While you can't input anything in a field with a maxlength of -1, if you paste something in it (of any length, short or long) it pops up a box that says "The inserted text exceeded the maximum length of this text field. The text was truncated." and it then replaces the pasted text with "!!br0ken!!" in the input field which can then be saved and loaded but not edited. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99381] New: Base becomes unresponsive after idle for long periods of time or waking from computer sleep
https://bugs.documentfoundation.org/show_bug.cgi?id=99381 Bug ID: 99381 Summary: Base becomes unresponsive after idle for long periods of time or waking from computer sleep Product: LibreOffice Version: 5.1.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@peteonline.net This has been happening for years on many different computers / versions of Windows and versions of LibreOffice. Currently running latest version of Windows 7 x64 SP1 with all current critical windows updates installed (but also had problems on numerous previous states of Windows) Currently running LibreOffice Version: 5.1.2.2 (x64) Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f CPU Threads: 8; OS Version: Windows 6.1; UI Render: GL; Locale: en-US (en_US) Open a new database, create a few tables with a few random record in them, save file, sit idle for a while or more easily, put the computer to sleep. Wake up computer and LibreOffice window will be grey or black, clicking on it invokes the standard windows "Program Not Responding" response (in title bar and then with a dialog asking to close the program or wait) LibreOffice never recovers, document recovery is invoked upon restarting LibreOffice after force closeing. Similar to bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=35424 https://bugs.launchpad.net/df-libreoffice/+bug/745836 https://bugs.documentfoundation.org/show_bug.cgi?id=33025 https://bugs.documentfoundation.org/show_bug.cgi?id=40766 but not duplicates because this is on the Windows operating system (these bugs are Linux / "other") and neither my "home" directory nor my "swap" paging file / virtual memory are or have ever been encrypted. I verified this with run as admin cmd.exe by typing "fsutil behavior query encryptpagingfile" and got back response "EncryptPagingFile = 0" -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99163] Cannot set tab stop position of zero for ToC entry
https://bugs.documentfoundation.org/show_bug.cgi?id=99163 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- Hello, Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99167] Insert comment keyboard shortcut Microsoft Office Word
https://bugs.documentfoundation.org/show_bug.cgi?id=99167 raalchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |NOTABUG --- Comment #1 from raal --- Hello, (In reply to Robert Orzanna from comment #0) > Dear all, > > I noticed that the default keyboard shortcut for inserting a comment in > Writer is `CTRL + ALT + C`. > > In MS Office Word, on the other hand, `CTRL + ALT + M` is used as the > default shortcut. you can define your own shortcuts at menu Tools - customize - keyboard > > Is there any reason why Writer does not use the same to make it more > intuitive for the average MS Office user to switch? > Sorry, but actual writer users use `CTRL + ALT + C`. If we change it, then these users will fill new bugs :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Matthiaschanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #3 from Matthias --- The rename of the LO directory profile didn't solve the problem, but the disablement of OpenCL worked just fine. Thanks for the fast responsees. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36737] default values for optional parameters are not processed
https://bugs.documentfoundation.org/show_bug.cgi?id=36737 --- Comment #7 from jan.be...@email.cz --- Tested again and problem still occurs on LO version 5.1.2.2, Windows 7 and Windows XP -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49297] FORMATTING: Title Not Centered with First Line Indent
https://bugs.documentfoundation.org/show_bug.cgi?id=49297 raalchanged: What|Removed |Added CC||kruno...@gmx.com --- Comment #2 from raal --- *** Bug 99180 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99180] Can't center text in DOC-file
https://bugs.documentfoundation.org/show_bug.cgi?id=99180 raalchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #2 from raal --- *** This bug has been marked as a duplicate of bug 49297 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Usamachanged: What|Removed |Added CC||uahe...@gmail.com --- Comment #2 from Usama --- Unable to reproduce. Tested on Windows 7. Version: 5.2.0.0.alpha0+ Build ID: ef34535ceb60d7d63b8d8671e4c6e9e43ffbd17d CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@39, Branch:master, Time: 2016-03-27_09:52:41 Locale: ar-AE (en_US) Could you please test it on newer version, maybe fresh release? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested info is provided. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with LO Debian package 5.1.2, I don't reproduce this. 1) Could you try after having renamed your LO directory profile? (see https://wiki.documentfoundation.org/UserProfile#Windows) 2) Could you try to disable OpenCL? (see menu Tools/Options/OpenCL, uncheck both checkboxes) 3) Could you give a try to last stable LO version 5.1.2? If you still reproduce the crash, could you try to retrieve a backtrace? (see https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Martin Nathansen license statement
All my past & future contributions made to the LibreOffice project may be licensed under the MPLv2/LGPLv3+ dual license. Martin Nathansen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 39632] Consolidate GetMsiProperty()
https://bugs.documentfoundation.org/show_bug.cgi?id=39632 Mat Mchanged: What|Removed |Added Status|ASSIGNED|NEW Assignee|m...@gmx.fr |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: drawinglayer/CppunitTest_drawinglayer_border.mk drawinglayer/qa drawinglayer/source include/drawinglayer
drawinglayer/CppunitTest_drawinglayer_border.mk| 16 ++ drawinglayer/qa/unit/border.cxx| 71 - drawinglayer/source/primitive2d/borderlineprimitive2d.cxx | 15 ++ drawinglayer/source/processor2d/vclpixelprocessor2d.cxx|7 + include/drawinglayer/primitive2d/borderlineprimitive2d.hxx |2 5 files changed, 106 insertions(+), 5 deletions(-) New commits: commit 422f10c5d7ebe6f4b778636c9c1eb6dbdf708a27 Author: Miklos VajnaDate: Mon Apr 18 16:53:48 2016 +0200 tdf#99315 VclPixelProcessor2D: fix double border line width Regression from commit 2c91cb08d65cd35fa8ef6eaca3677aa82fb58cbe (better drawing support for borders of different width, fdo#33634, 2012-04-04), the problem is that previously the width of inner/outer double border lines got rounded to integer values quite early, but after the commit they are kept at a double precision for much longer, which needs pixel correction in VclPixelProcessor2D. Example: if the border with is 1.47, and the line gets moved by 0.2 pixels, then the inner and outer edge of the line will be 0.2 and 1.67, which gets rounded to 0 -> 2 in the pixel processor. Previously the input was rounded to 1, so moving by 0.2 resulted in 0.2 -> 1.2, which got rounded to 0 -> 1. The result is that sometimes the line width is 1 pixel wider than expected. Fix the problem by allowing VclPixelProcessor2D to request pixel correction from BorderLinePrimitive2D. It wouldn't be possible to do pixel correction only in VclPixelProcessor2D, as it has no idea what to correct: it only gets polygons, so it has no idea if e.g. the top of a polygon is the outer edge of a top border line or an inner edge of a bottom border line. Change-Id: I1971f3a952fbcdc598ab46c659e12d976c13cbe6 Reviewed-on: https://gerrit.libreoffice.org/24221 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/drawinglayer/CppunitTest_drawinglayer_border.mk b/drawinglayer/CppunitTest_drawinglayer_border.mk index 65f8cf6..ea72b8c 100644 --- a/drawinglayer/CppunitTest_drawinglayer_border.mk +++ b/drawinglayer/CppunitTest_drawinglayer_border.mk @@ -21,6 +21,9 @@ $(eval $(call gb_CppunitTest_use_libraries,drawinglayer_border, \ sal \ salhelper \ drawinglayer \ + vcl \ + test \ + tl \ $(gb_UWINAPI) \ )) @@ -33,4 +36,17 @@ $(eval $(call gb_CppunitTest_add_exception_objects,drawinglayer_border, \ drawinglayer/qa/unit/border \ )) +$(eval $(call gb_CppunitTest_use_ure,drawinglayer_border)) + +$(eval $(call gb_CppunitTest_use_vcl,drawinglayer_border)) + +$(eval $(call gb_CppunitTest_use_components,drawinglayer_border,\ +configmgr/source/configmgr \ +i18npool/util/i18npool \ +ucb/source/core/ucb1 \ +ucb/source/ucp/file/ucpfile1 \ +)) + +$(eval $(call gb_CppunitTest_use_configuration,drawinglayer_border)) + # vim: set noet sw=4 ts=4: diff --git a/drawinglayer/qa/unit/border.cxx b/drawinglayer/qa/unit/border.cxx index 6f49a24..9f0c621 100644 --- a/drawinglayer/qa/unit/border.cxx +++ b/drawinglayer/qa/unit/border.cxx @@ -8,7 +8,6 @@ */ #include -#include #include #include @@ -17,20 +16,27 @@ #include #include #include +#include +#include #include +#include +#include +#include using namespace com::sun::star; namespace { -class DrawinglayerBorderTest : public CppUnit::TestFixture +class DrawinglayerBorderTest : public test::BootstrapFixture { public: void testDoubleDecompositionSolid(); +void testDoublePixelProcessing(); CPPUNIT_TEST_SUITE(DrawinglayerBorderTest); CPPUNIT_TEST(testDoubleDecompositionSolid); +CPPUNIT_TEST(testDoublePixelProcessing); CPPUNIT_TEST_SUITE_END(); }; @@ -74,6 +80,67 @@ void DrawinglayerBorderTest::testDoubleDecompositionSolid() CPPUNIT_ASSERT_DOUBLES_EQUAL(fLeftWidth, rRange.getHeight(), basegfx::fTools::getSmallValue()); } +void DrawinglayerBorderTest::testDoublePixelProcessing() +{ +// Create a pixel processor. +ScopedVclPtrInstance pDev; +drawinglayer::geometry::ViewInformation2D aView; +std::unique_ptr pProcessor(drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(*pDev, aView)); +CPPUNIT_ASSERT(pProcessor); +GDIMetaFile aMetaFile; +// Start recording after the processor is created, so we can test the pixel processor. +aMetaFile.Record(pDev); + +// Create a border line primitive that's similar to the one from the bugdoc: +// 1.47 pixels is 0.03cm at 130% zoom and 96 DPI. +basegfx::B2DPoint aStart(0, 20); +basegfx::B2DPoint aEnd(100, 20); +double fLeftWidth = 1.47; +double fDistance = 1.47; +double fRightWidth = 1.47; +double fExtendLeftStart = 0; +double fExtendLeftEnd = 0; +double fExtendRightStart = 0; +
[Libreoffice-bugs] [Bug 90653] Opening .csv : Problem with rows
https://bugs.documentfoundation.org/show_bug.cgi?id=90653 Mamothchanged: What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- --- Comment #5 from Mamoth --- Sorry if I was not clear : when I wrote "tested positively", I meant that the problem is still there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50068] Incorrect spacing above paragraph on second column of section
https://bugs.documentfoundation.org/show_bug.cgi?id=50068 --- Comment #6 from Stephan Zietsman--- This bug is still reproducible (following the steps in 53304). -- LibreOffice 5.1.2.2 10m0(Build:2) Ubuntu 14.04 (x64) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] libvisio.git: src/lib
src/lib/VSD6Parser.cpp | 35 +++ src/lib/VSDParser.cpp | 40 +--- 2 files changed, 72 insertions(+), 3 deletions(-) New commits: commit 21027b7349a17cc18f74b28e9f1b32358e47135f Author: Fridrich Å trbaDate: Mon Apr 18 20:50:00 2016 +0200 Some reading of shape ids of shapes that a connector connects Change-Id: I0492fea6ad37a590580ec2c2a05ef2e990f9efa1 diff --git a/src/lib/VSD6Parser.cpp b/src/lib/VSD6Parser.cpp index 8f2bb0b..34cde71 100644 --- a/src/lib/VSD6Parser.cpp +++ b/src/lib/VSD6Parser.cpp @@ -401,11 +401,46 @@ void libvisio::VSD6Parser::readTextField(librevenge::RVNGInputStream *input) void libvisio::VSD6Parser::readMisc(librevenge::RVNGInputStream *input) { + unsigned long initialPosition = input->tell(); unsigned char flags = readU8(input); if (flags & 0x20) m_shape.m_misc.m_hideText = true; else m_shape.m_misc.m_hideText = false; + + input->seek(initialPosition+23, librevenge::RVNG_SEEK_SET); + while (!input->isEnd() && (unsigned long) input->tell() < (unsigned long)(initialPosition+m_header.dataLength+m_header.trailer)) + { +unsigned long inputPos = input->tell(); +unsigned length = readU32(input); +if (!length) + break; +unsigned blockType = readU8(input); +input->seek(1, librevenge::RVNG_SEEK_CUR); +if (blockType == 2) +{ + if (0x74 == readU8(input)) + { +if (0x604e == readU32(input)) +{ + unsigned shapeId = readU32(input); + if (0x7a == readU8(input)) + { +if (0x4073 == readU32(input)) +{ + if (!m_shape.m_xform1d) +m_shape.m_xform1d = new XForm1D(); + if (m_shape.m_xform1d->beginId == MINUS_ONE) +m_shape.m_xform1d->beginId = shapeId; + else if (m_shape.m_xform1d->endId == MINUS_ONE) +m_shape.m_xform1d->endId = shapeId; +} + } +} + } +} +input->seek(inputPos + length, librevenge::RVNG_SEEK_SET); + } } /* vim:set shiftwidth=2 softtabstop=2 expandtab: */ diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp index 22b356e..26b1d9c 100644 --- a/src/lib/VSDParser.cpp +++ b/src/lib/VSDParser.cpp @@ -1119,9 +1119,8 @@ void libvisio::VSDParser::readXFormData(librevenge::RVNGInputStream *input) void libvisio::VSDParser::readXForm1D(librevenge::RVNGInputStream *input) { - if (m_shape.m_xform1d) -delete m_shape.m_xform1d; - m_shape.m_xform1d = new XForm1D(); + if (!m_shape.m_xform1d) +m_shape.m_xform1d = new XForm1D(); input->seek(1, librevenge::RVNG_SEEK_CUR); m_shape.m_xform1d->beginX = readDouble(input); input->seek(1, librevenge::RVNG_SEEK_CUR); @@ -2155,11 +2154,46 @@ void libvisio::VSDParser::readTextField(librevenge::RVNGInputStream *input) void libvisio::VSDParser::readMisc(librevenge::RVNGInputStream *input) { + unsigned long initialPosition = input->tell(); unsigned char flags = readU8(input); if (flags & 0x20) m_shape.m_misc.m_hideText = true; else m_shape.m_misc.m_hideText = false; + + input->seek(initialPosition+45, librevenge::RVNG_SEEK_SET); + while (!input->isEnd() && (unsigned long) input->tell() < (unsigned long)(initialPosition+m_header.dataLength+m_header.trailer)) + { +unsigned long inputPos = input->tell(); +unsigned length = readU32(input); +if (!length) + break; +unsigned blockType = readU8(input); +input->seek(1, librevenge::RVNG_SEEK_CUR); +if (blockType == 2) +{ + if (0x74 == readU8(input)) + { +if (0x604e == readU32(input)) +{ + unsigned shapeId = readU32(input); + if (0x7a == readU8(input)) + { +if (0x4073 == readU32(input)) +{ + if (!m_shape.m_xform1d) +m_shape.m_xform1d = new XForm1D(); + if (m_shape.m_xform1d->beginId == MINUS_ONE) +m_shape.m_xform1d->beginId = shapeId; + else if (m_shape.m_xform1d->endId == MINUS_ONE) +m_shape.m_xform1d->endId = shapeId; +} + } +} + } +} +input->seek(inputPos + length, librevenge::RVNG_SEEK_SET); + } } libvisio::Colour libvisio::VSDParser::_colourFromIndex(unsigned idx) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97956] Don't fragment A:A conditional formatting when rows/columns are moved
https://bugs.documentfoundation.org/show_bug.cgi?id=97956 --- Comment #4 from Markus Mohrhard--- We might be able to fix the fragmentation. However I think it makes no sense to store F:F in that case. It is not a formula reference but a cell range in that case. Eike might have some additional ideas about F:F vs F1:F1048576 for ScRangeList/ScRange based references. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99380] New: Calc crashes when switching to specific tabs or when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=99380 Bug ID: 99380 Summary: Calc crashes when switching to specific tabs or when saving Product: LibreOffice Version: 5.0.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ma...@osm.de Created attachment 124478 --> https://bugs.documentfoundation.org/attachment.cgi?id=124478=edit This document crashes LO The attached document crashes LO when you switch to the tabs "Bike", "Run", "Alternativ" or "Rolle". All other tabs work fine. The attached document also crashes LO when you want to save the file. It also crashes LO when you want to save the file as xlsx. The crash also occured with LO 4. I then switched to LO 5 but the problem is still there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99373] Page Numbering doesn't work proprely
https://bugs.documentfoundation.org/show_bug.cgi?id=99373 Joel Maderochanged: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INVALID |--- --- Comment #2 from Joel Madero --- Changed my mind - NEEDINFO - provide a simple test document and then move back to UNCONFIRMED. A pdf print would also help. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99322] Error in Calculation after cut and paste (need hard recalc)
https://bugs.documentfoundation.org/show_bug.cgi?id=99322 Eike Rathkechanged: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99373] Page Numbering doesn't work proprely
https://bugs.documentfoundation.org/show_bug.cgi?id=99373 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99373] Page Numbering doesn't work proprely
https://bugs.documentfoundation.org/show_bug.cgi?id=99373 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||jmadero@gmail.com Resolution|--- |INVALID --- Comment #1 from Joel Madero --- I'm closing this as NOTABUG. If uninstalling fixed the problem it was almost definitely a local environment issue. Without a clear explanation as to how the corruption happened, it's not a valid bug report and there isn't anything we can do. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99374] Fields in csv-imported files cannot simply be given other format because of apostrophe added
https://bugs.documentfoundation.org/show_bug.cgi?id=99374 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||jmadero@gmail.com Resolution|--- |NOTABUG --- Comment #3 from Joel Madero --- This isn't a bug - the formatting of the fields comes in as text. You can use an addon to fix this: http://extensions.libreoffice.org/extension-center/ct2n-convert-text-to-number-and-dates You can google "number formatted as text" and you'll get a ton of explanations as to why this happens. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/Connect.cpp
loolwsd/Connect.cpp | 12 1 file changed, 12 insertions(+) New commits: commit 5c0788254b14eda55266074563486f9eb02bc309 Author: Tor LillqvistDate: Mon Apr 18 21:09:36 2016 +0300 Add "exit" command and comment syntax to input files for the 'connect' program diff --git a/loolwsd/Connect.cpp b/loolwsd/Connect.cpp index b7c5c70..8f64ff3 100644 --- a/loolwsd/Connect.cpp +++ b/loolwsd/Connect.cpp @@ -187,6 +187,18 @@ protected: std::cout << "Sleeping " << sleepTime << " seconds" << std::endl; Thread::sleep(sleepTime * 1000); } +else if (line == "exit") +{ +// While hacking on LOOL and editing input files for this program back and forth it +// is a good idea to be able to add an enforced exit in the middle of the input +// file. +std::cout << "Exiting" << std::endl; +break; +} +else if (line.find("#") == 0) +{ +// Also comments can be useful in input files for this program +} else { std::cout << "Sending: '" << line << "'" << std::endl; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99377] CMIS: document can't be saved via Web Service binding
https://bugs.documentfoundation.org/show_bug.cgi?id=99377 Joel Maderochanged: What|Removed |Added CC||jmadero@gmail.com --- Comment #2 from Joel Madero --- Is this a regression in current master or is the same problem around in a non-master? Would be good to identify the first version that shows this problem. If it's a recent regression - let's tag it appropriately (regression in keywords) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99378] FILESAVE: FILEOPEN: Broken conditional formatting after deleting sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=99378 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||jmadero@gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Joel Madero --- *** This bug has been marked as a duplicate of bug 73678 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73678] FORMATTING: Conditional Formatting lost when Click-drag Sheet2 tab to position 1 or adding, then removing an empty sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=73678 Joel Maderochanged: What|Removed |Added CC||rolfbarts...@hotmail.com --- Comment #15 from Joel Madero --- *** Bug 99378 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 Joel Maderochanged: What|Removed |Added Depends on||99379 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99379] libreoffice wants to recover a saved document
https://bugs.documentfoundation.org/show_bug.cgi?id=99379 Joel Maderochanged: What|Removed |Added Priority|medium |lowest CC||jmadero@gmail.com Blocks||77999 Severity|normal |trivial --- Comment #1 from Joel Madero --- Not confirming but prioritizing correctly. Trivial - not really going to hurt the creation of professional quality work; Lowest - defautl Again, not confirming as I can't restart right now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99229] Scroll bar redraws incorrectly on scroll (Adwaita, GTK+ 3.20)
https://bugs.documentfoundation.org/show_bug.cgi?id=99229 --- Comment #6 from hg.cra...@gmail.com --- (In reply to ailin.nemui from comment #3) > hi, can you confirm if you're also affected by #99319 ? I can confirm the > scrollbar issue on opensuse Hi, yes, I'm also affected by that bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99319] Active tab not visually identifiable in dialogs (Adwaita, GTK+ 3.20)
https://bugs.documentfoundation.org/show_bug.cgi?id=99319 --- Comment #4 from hg.cra...@gmail.com --- Same problem for me on Arch. Using adwaita theme on gnome 3.20.1 (gtk3 3.20.3-1). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99369] FORMATTING: Textalignment vertically dosn't apply anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=99369 Uwe Graßhoffchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99369] FORMATTING: Textalignment vertically dosn't apply anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=99369 --- Comment #3 from Uwe Graßhoff--- Created attachment 124476 --> https://bugs.documentfoundation.org/attachment.cgi?id=124476=edit pdf of the ods I attached two files to the bug. The ODS is a sample file where the text should be vertical. The PDF is generated using the Export as PDF function of "scalc". In the PDF all is fine. But in Calc itself it's wrong -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99306] formatting: Spacing to contents reset
https://bugs.documentfoundation.org/show_bug.cgi?id=99306 --- Comment #3 from foxtrot--- Created attachment 124474 --> https://bugs.documentfoundation.org/attachment.cgi?id=124474=edit file with that problem -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 Julien Nabetchanged: What|Removed |Added Status|REOPENED|NEW Whiteboard|target:5.2.0| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs