[Libreoffice-bugs] [Bug 87731] Tag appearing in Arabic characters when change size of fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=87731 --- Comment #7 from yousifjka...@yahoo.com --- Hi. I read that there is havy work on LibreOffice during May 2016: https://blog.documentfoundation.org/blog/2016/04/28/coming-up-the-month-of-libreoffice/ Please consider fixing this old & long standing bug during your work in May. This bug is one of most bad bugs regarding support of Arabic language. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87532] "Arial Bold Italic font" & "Times New Roman Italic font" does not display Arabic characters
https://bugs.documentfoundation.org/show_bug.cgi?id=87532 --- Comment #12 from yousifjka...@yahoo.com --- Hi. Just a reminder from my side to developers team about this bug. I read that there is a month of havy work on LibreOffice during May 2016: https://blog.documentfoundation.org/blog/2016/04/28/coming-up-the-month-of-libreoffice/ So, plase consider fixing this bug during this month. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99585] New: Feedback on stability
https://bugs.documentfoundation.org/show_bug.cgi?id=99585 Bug ID: 99585 Summary: Feedback on stability Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@iafrica.com Not sure how one reports the following: I have been using 5.2.0.0.alpha0+ with some big complicated spreadsheets, documents and presentations and it behaves exceptionally well - kudo's to the development team. I use calc and writer daily, many times, and impress at least 1/week. And I am using it not just for testing (against all advice - I guess that reflects my confidence.) The only issues I have in descending order of importance: 93045 - 99134 98706 99570 Thanks again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99570] Freeze cells moves when adding rows or columns
https://bugs.documentfoundation.org/show_bug.cgi?id=99570 --- Comment #2 from Elmar--- I have checked it in v4 and v5.1, so this seems always to have been like this. It is not serious just an quirk that does not make sense. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63837] Theme (previously Persona) header rendered twice when in single toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=63837 --- Comment #10 from Adolfo Jayme--- *** Bug 69865 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69865] Firefox Theme header loaded twice in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=69865 Adolfo Jaymechanged: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #18 from Adolfo Jayme --- *** This bug has been marked as a duplicate of bug 63837 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch
https://bugs.documentfoundation.org/show_bug.cgi?id=99258 --- Comment #37 from V Stuart Foote--- @Luke, if it hangs in WinDbg and !analyze -v is not helpful, you can still get useful stacktrace with a "~* kp" from the WinDbg command line. The first thread should be the main, additional can have some interesting details. @Tomaž, Pedro's WinDbg !analyze -v posted in comment 36 looks to confirm Luke's bisect result of commit 80d0b2916db81a7f47bb1d368677016bbb870df6 http://opengrok.libreoffice.org/xref/core/vcl/opengl/texture.cxx?a=true#458 and http://opengrok.libreoffice.org/xref/core/vcl/opengl/gdiimpl.cxx?a=true#1697 @Pedro, can you catch another session in WinDbg--but post up result of the "~* kp" command--which with symbols should expose code lines for more of the stack and specific calls and make it easier to follow what goes wrong. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch
https://bugs.documentfoundation.org/show_bug.cgi?id=99258 --- Comment #36 from Pedro--- Created attachment 124744 --> https://bugs.documentfoundation.org/attachment.cgi?id=124744=edit Backtrace of non-starting LO 5.2 Alpha1 under Windows 10 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/opengl vcl/source
vcl/inc/opengl/RenderState.hxx | 12 vcl/opengl/gdiimpl.cxx |7 ++- vcl/source/opengl/OpenGLContext.cxx |4 ++-- 3 files changed, 16 insertions(+), 7 deletions(-) New commits: commit 540fee2dc7553152914f7f1d8a41921e765087ef Author: Tomaž VajngerlDate: Fri Apr 29 17:17:09 2016 +0900 opengl: track the state of glViewport We don't want to set the viewport over and over again. Change-Id: I60b84a009d4058743e30587616604f9b6fc0f601 Reviewed-on: https://gerrit.libreoffice.org/24507 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/inc/opengl/RenderState.hxx b/vcl/inc/opengl/RenderState.hxx index eeac1a50..ac215a8 100644 --- a/vcl/inc/opengl/RenderState.hxx +++ b/vcl/inc/opengl/RenderState.hxx @@ -123,10 +123,22 @@ class RenderState ScissorState maScissor; StencilState maStencil; +Rectangle maCurrentViewport; + public: RenderState() {} +void viewport(Rectangle aViewPort) +{ +if (aViewPort != maCurrentViewport) +{ +glViewport(aViewPort.Left(), aViewPort.Top(), aViewPort.GetWidth(), aViewPort.GetHeight()); +CHECK_GL_ERROR(); +maCurrentViewport = aViewPort; +} +} + TextureState& texture() { return maTexture; } ScissorState& scissor() { return maScissor; } StencilState& stencil() { return maStencil; } diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index f98f5d2..4b67ed5 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -211,8 +211,7 @@ void OpenGLSalGraphicsImpl::InitializePreDrawState(XOROption eOpt) CheckOffscreenTexture(); CHECK_GL_ERROR(); -glViewport( 0, 0, GetWidth(), GetHeight() ); -CHECK_GL_ERROR(); +mpContext->state()->viewport(Rectangle(Point(0, 0), Size(GetWidth(), GetHeight(; ImplInitClipRegion(); CHECK_GL_ERROR(); @@ -2562,9 +2561,7 @@ void OpenGLSalGraphicsImpl::doFlush() mpWindowContext->AcquireDefaultFramebuffer(); CHECK_GL_ERROR(); -glViewport( 0, 0, GetWidth(), GetHeight() ); -CHECK_GL_ERROR(); - +mpWindowContext->state()->viewport(Rectangle(Point(0, 0), Size(GetWidth(), GetHeight(; mpWindowContext->state()->scissor().disable(); mpWindowContext->state()->stencil().disable(); diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 5b441db..5a8334c 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -1679,8 +1679,8 @@ OpenGLFramebuffer* OpenGLContext::AcquireFramebuffer( const OpenGLTexture& rText assert( pFramebuffer ); BindFramebuffer( pFramebuffer ); pFramebuffer->AttachTexture( rTexture ); -glViewport( 0, 0, rTexture.GetWidth(), rTexture.GetHeight() ); -CHECK_GL_ERROR(); + +state()->viewport(Rectangle(Point(), Size(rTexture.GetWidth(), rTexture.GetHeight(; return pFramebuffer; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/opengl vcl/source
vcl/inc/opengl/RenderState.hxx | 122 +--- vcl/opengl/gdiimpl.cxx | 12 ++- vcl/source/opengl/OpenGLContext.cxx |1 3 files changed, 80 insertions(+), 55 deletions(-) New commits: commit a57d048f88ba6cac3ce1550e2a8a143a8887eb05 Author: Tomaž VajngerlDate: Fri Apr 29 17:07:11 2016 +0900 opengl: sync scissor and stencil state, generic capability state Scissor and stencil test needed to be disabled in flush() (which means every postDraw call) because sometimes the state became out of sync with the current state. This commit adds sync() function which synchronises the actual OpenGL state and adds debugging mechanisms to warn when the state becomes out of sync (so we can inspect the exact moment in apitrace). Added a GenericCapabilityState for GL capabilities like GL_SCISSORS_TEST, GL_STENCIL_TEST, GL_BLEND,... and refactored existing ScissorState and StencilState to inherit from it. Change-Id: Ifc159108a5ce850c78a89b1f5b8d12ecdd84f459 Reviewed-on: https://gerrit.libreoffice.org/24506 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/vcl/inc/opengl/RenderState.hxx b/vcl/inc/opengl/RenderState.hxx index b1b0b18..eeac1a50 100644 --- a/vcl/inc/opengl/RenderState.hxx +++ b/vcl/inc/opengl/RenderState.hxx @@ -13,95 +13,110 @@ #include "opengl/TextureState.hxx" -class ScissorState +template +class GenericCapabilityState { +protected: bool mbTest; -int mX; -int mY; -int mWidth; -int mHeight; -public: - -ScissorState() -: mbTest(false) -, mX(0) -, mY(0) -, mWidth(0) -, mHeight(0) +bool readState() { -glDisable(GL_SCISSOR_TEST); -CHECK_GL_ERROR(); -} +return (glIsEnabled(ENUM_TYPE) == GL_TRUE); +}; -void set(int x, int y, int width, int height) +public: +void sync() { -if (x != mX || y != mY || width != mWidth || height != mHeight) -{ -glScissor(x, y, width, height); -CHECK_GL_ERROR(); - -mX = x; -mY = y; -mWidth = width; -mHeight = height; -} +mbTest = readState(); } void enable() { if (!mbTest) { -glEnable(GL_SCISSOR_TEST); +glEnable(ENUM_TYPE); CHECK_GL_ERROR(); mbTest = true; } +else +{ +VCL_GL_INFO(TYPE::className() << ": enable called but already set"); +} +#ifdef DBG_UTIL +checkState(); +#endif } void disable() { if (mbTest) { -glDisable(GL_SCISSOR_TEST); +glDisable(ENUM_TYPE); CHECK_GL_ERROR(); mbTest = false; } +else +{ +VCL_GL_INFO(TYPE::className() << ": disable called but already set"); +} +#ifdef DBG_UTIL +checkState(); +#endif } + +#ifdef DBG_UTIL +void checkState() +{ +bool bRealState = readState(); +if (mbTest != bRealState) +{ +VCL_GL_INFO(TYPE::className() << " mismatch! " +<< "Expected: " << (mbTest ? "enabled" : "disabled") +<< " but is: "<< (bRealState ? "enabled" : "disabled")); +} +} +#endif }; -class StencilState +class ScissorState : public GenericCapabilityState { -bool mbTest; +private: +int mX; +int mY; +int mWidth; +int mHeight; + public: +static std::string className() { return std::string("ScissorState"); } -StencilState() -: mbTest(false) -{ -glDisable(GL_STENCIL_TEST); -CHECK_GL_ERROR(); -} +ScissorState() +: mX(0) +, mY(0) +, mWidth(0) +, mHeight(0) +{} -void enable() +void set(int x, int y, int width, int height) { -if (!mbTest) +if (x != mX || y != mY || width != mWidth || height != mHeight) { -glEnable(GL_STENCIL_TEST); +glScissor(x, y, width, height); CHECK_GL_ERROR(); -mbTest = true; -} -} -void disable() -{ -if (mbTest) -{ -glDisable(GL_STENCIL_TEST); -CHECK_GL_ERROR(); -mbTest = false; +mX = x; +mY = y; +mWidth = width; +mHeight = height; } } }; +class StencilState : public GenericCapabilityState +{ +public: +static std::string className() { return std::string("StencilState"); } +}; + class RenderState { TextureState maTexture; @@ -115,6 +130,13 @@ public: TextureState& texture() { return maTexture; } ScissorState&
[Libreoffice-commits] core.git: vcl/inc vcl/opengl
vcl/inc/opengl/RenderState.hxx | 35 +++ vcl/opengl/gdiimpl.cxx | 33 ++--- vcl/opengl/salbmp.cxx |4 vcl/opengl/scale.cxx |1 + 4 files changed, 54 insertions(+), 19 deletions(-) New commits: commit b8f0e6452cc019744c44997c92831d94086b35b7 Author: Tomaž VajngerlDate: Thu Apr 28 20:01:28 2016 +0900 opengl: track the state of stencil test Change-Id: Id3e15e91316df740f04a42ed8c95b77d83240b5a Reviewed-on: https://gerrit.libreoffice.org/24505 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/vcl/inc/opengl/RenderState.hxx b/vcl/inc/opengl/RenderState.hxx index 7b3db7be..b1b0b18 100644 --- a/vcl/inc/opengl/RenderState.hxx +++ b/vcl/inc/opengl/RenderState.hxx @@ -69,10 +69,44 @@ public: } }; +class StencilState +{ +bool mbTest; +public: + +StencilState() +: mbTest(false) +{ +glDisable(GL_STENCIL_TEST); +CHECK_GL_ERROR(); +} + +void enable() +{ +if (!mbTest) +{ +glEnable(GL_STENCIL_TEST); +CHECK_GL_ERROR(); +mbTest = true; +} +} + +void disable() +{ +if (mbTest) +{ +glDisable(GL_STENCIL_TEST); +CHECK_GL_ERROR(); +mbTest = false; +} +} +}; + class RenderState { TextureState maTexture; ScissorState maScissor; +StencilState maStencil; public: RenderState() @@ -80,6 +114,7 @@ public: TextureState& texture() { return maTexture; } ScissorState& scissor() { return maScissor; } +StencilState& stencil() { return maStencil; } }; #endif // INCLUDED_VCL_INC_OPENGL_RENDER_STATE_H diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index ca5f439..70b2d65 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -234,11 +234,6 @@ void OpenGLSalGraphicsImpl::PostDraw() CHECK_GL_ERROR(); } -if( mbUseStencil ) -{ -glDisable( GL_STENCIL_TEST ); -CHECK_GL_ERROR(); -} if( mpProgram ) { mpProgram->Clean(); @@ -271,6 +266,7 @@ void OpenGLSalGraphicsImpl::freeResources() mpContext->makeCurrent(); FlushDeferredDrawing(); mpContext->state()->scissor().disable(); +mpContext->state()->stencil().disable(); mpContext->ReleaseFramebuffer( maOffscreenTex ); } ReleaseContext(); @@ -278,7 +274,7 @@ void OpenGLSalGraphicsImpl::freeResources() void OpenGLSalGraphicsImpl::ImplSetClipBit( const vcl::Region& rClip, GLuint nMask ) { -glEnable( GL_STENCIL_TEST ); +mpContext->state()->stencil().enable(); VCL_GL_INFO( "Adding complex clip / stencil" ); GLuint nStencil = maOffscreenTex.StencilId(); @@ -317,8 +313,8 @@ void OpenGLSalGraphicsImpl::ImplSetClipBit( const vcl::Region& rClip, GLuint nMa CHECK_GL_ERROR(); glStencilMask( 0x00 ); CHECK_GL_ERROR(); -glDisable( GL_STENCIL_TEST ); -CHECK_GL_ERROR(); + +mpContext->state()->stencil().disable(); } void OpenGLSalGraphicsImpl::ImplInitClipRegion() @@ -348,8 +344,11 @@ void OpenGLSalGraphicsImpl::ImplInitClipRegion() { glStencilFunc( GL_EQUAL, 1, 0x1 ); CHECK_GL_ERROR(); -glEnable( GL_STENCIL_TEST ); -CHECK_GL_ERROR(); +mpContext->state()->stencil().enable(); +} +else +{ +mpContext->state()->stencil().disable(); } } @@ -1501,11 +1500,7 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture( // so if we do not disable the scissor test, the texture produced // by the first downscaling is clipped to the current window size. mpContext->state()->scissor().disable(); -CHECK_GL_ERROR(); - -// Maybe it can give problems too. -glDisable(GL_STENCIL_TEST); -CHECK_GL_ERROR(); +mpContext->state()->stencil().disable(); // the square root of the whole inverted scale ratio double ixscalesqrt = std::floor(std::sqrt(ixscale)); @@ -1529,10 +1524,7 @@ void OpenGLSalGraphicsImpl::DrawTransformedTexture( mpContext->state()->scissor().enable(); if (mbUseStencil) -{ -glEnable(GL_STENCIL_TEST); -CHECK_GL_ERROR(); -} +mpContext->state()->stencil().enable(); } } @@ -2507,6 +2499,7 @@ void OpenGLSalGraphicsImpl::flush() FlushDeferredDrawing(); mpContext->state()->scissor().disable(); +mpContext->state()->stencil().disable(); if( IsOffscreen() ) return; @@ -2525,6 +2518,7 @@ void OpenGLSalGraphicsImpl::doFlush() FlushDeferredDrawing(); mpContext->state()->scissor().disable(); +mpContext->state()->stencil().disable(); if(
[Libreoffice-commits] core.git: vcl/inc vcl/opengl
vcl/inc/opengl/RenderState.hxx | 58 + vcl/opengl/gdiimpl.cxx | 51 ++-- vcl/opengl/salbmp.cxx | 10 +-- vcl/opengl/scale.cxx |2 + 4 files changed, 94 insertions(+), 27 deletions(-) New commits: commit 51e953a3579fb91f30f7f0d6159b737684976959 Author: Tomaž VajngerlDate: Thu Apr 28 19:34:37 2016 +0900 opengl: track the state of scissor test and the dimensions For performance reasons we shouldn't set glScissors if it is not necessary so we remember to what dimensions we set the glScissor and don't set it again if this is not necessary. The same goes for enabling/disabling the GL_SCISSOR_TEST. Change-Id: I5e1383081b4e76bdded04525c780d3a724f9db5c Reviewed-on: https://gerrit.libreoffice.org/24504 Reviewed-by: Tomaž Vajngerl Tested-by: Tomaž Vajngerl diff --git a/vcl/inc/opengl/RenderState.hxx b/vcl/inc/opengl/RenderState.hxx index a184f2e..7b3db7be 100644 --- a/vcl/inc/opengl/RenderState.hxx +++ b/vcl/inc/opengl/RenderState.hxx @@ -13,15 +13,73 @@ #include "opengl/TextureState.hxx" +class ScissorState +{ +bool mbTest; +int mX; +int mY; +int mWidth; +int mHeight; + +public: + +ScissorState() +: mbTest(false) +, mX(0) +, mY(0) +, mWidth(0) +, mHeight(0) +{ +glDisable(GL_SCISSOR_TEST); +CHECK_GL_ERROR(); +} + +void set(int x, int y, int width, int height) +{ +if (x != mX || y != mY || width != mWidth || height != mHeight) +{ +glScissor(x, y, width, height); +CHECK_GL_ERROR(); + +mX = x; +mY = y; +mWidth = width; +mHeight = height; +} +} + +void enable() +{ +if (!mbTest) +{ +glEnable(GL_SCISSOR_TEST); +CHECK_GL_ERROR(); +mbTest = true; +} +} + +void disable() +{ +if (mbTest) +{ +glDisable(GL_SCISSOR_TEST); +CHECK_GL_ERROR(); +mbTest = false; +} +} +}; + class RenderState { TextureState maTexture; +ScissorState maScissor; public: RenderState() {} TextureState& texture() { return maTexture; } +ScissorState& scissor() { return maScissor; } }; #endif // INCLUDED_VCL_INC_OPENGL_RENDER_STATE_H diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index 8bb2c1d..ca5f439 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -34,6 +34,7 @@ #include "svdata.hxx" #include "opengl/zone.hxx" #include "opengl/salbmp.hxx" +#include "opengl/RenderState.hxx" #include @@ -233,11 +234,6 @@ void OpenGLSalGraphicsImpl::PostDraw() CHECK_GL_ERROR(); } -if( mbUseScissor ) -{ -glDisable( GL_SCISSOR_TEST ); -CHECK_GL_ERROR(); -} if( mbUseStencil ) { glDisable( GL_STENCIL_TEST ); @@ -274,6 +270,7 @@ void OpenGLSalGraphicsImpl::freeResources() VCL_GL_INFO( "freeResources" ); mpContext->makeCurrent(); FlushDeferredDrawing(); +mpContext->state()->scissor().disable(); mpContext->ReleaseFramebuffer( maOffscreenTex ); } ReleaseContext(); @@ -327,27 +324,27 @@ void OpenGLSalGraphicsImpl::ImplSetClipBit( const vcl::Region& rClip, GLuint nMa void OpenGLSalGraphicsImpl::ImplInitClipRegion() { // make sure the context has the right clipping set -if( maClipRegion != mpContext->maClipRegion ) +if (maClipRegion != mpContext->maClipRegion) { mpContext->maClipRegion = maClipRegion; -if( mbUseScissor ) -{ -Rectangle aRect( maClipRegion.GetBoundRect() ); -glScissor( aRect.Left(), GetHeight() - aRect.Bottom() - 1, aRect.GetWidth(), aRect.GetHeight() ); -CHECK_GL_ERROR(); -} -else if( !maClipRegion.IsEmpty() ) +if (mbUseStencil) { -ImplSetClipBit( maClipRegion, 0x01 ); +ImplSetClipBit(maClipRegion, 0x01); } } -if( mbUseScissor ) +if (mbUseScissor) { -glEnable( GL_SCISSOR_TEST ); -CHECK_GL_ERROR(); +Rectangle aRect(maClipRegion.GetBoundRect()); +mpContext->state()->scissor().set(aRect.Left(), GetHeight() - aRect.Bottom() - 1, aRect.GetWidth(), aRect.GetHeight()); +mpContext->state()->scissor().enable(); } -if( mbUseStencil ) +else +{ +mpContext->state()->scissor().disable(); +} + +if (mbUseStencil) { glStencilFunc( GL_EQUAL, 1, 0x1 ); CHECK_GL_ERROR(); @@ -377,9 +374,9 @@ bool OpenGLSalGraphicsImpl::setClipRegion( const vcl::Region& rClip ) mbUseStencil = false; mbUseScissor = false; -if( maClipRegion.IsRectangle() ) +if
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/opengl vcl/source
include/vcl/opengl/OpenGLContext.hxx |8 +++ vcl/inc/opengl/RenderState.hxx | 29 + vcl/inc/opengl/TextureState.hxx | 76 +++ vcl/opengl/program.cxx | 26 +-- vcl/opengl/texture.cxx | 60 +-- vcl/opengl/x11/gdiimpl.cxx |5 +- vcl/source/opengl/OpenGLContext.cxx |3 + 7 files changed, 160 insertions(+), 47 deletions(-) New commits: commit ba0a5708803d899de4c40cfe2c1697ae83b4827a Author: Tomaž VajngerlDate: Thu Apr 28 14:55:45 2016 +0900 opengl: track state of active and bound textures in context Add TextureState which is responsible to track the state of texture binding (and unbinding) and changing the current active texture unit. This is necessary because all GL calls reset the internal state without checking what the current state actually is and this can accumulate to a large amount of overhead. We also unbound the textures (glBindTexture with 0 as ID) after every operation which is also a major unneeded overhead which is fixed by this commit. Change-Id: I770a6a744c0c41850c576b928f027375962088aa Reviewed-on: https://gerrit.libreoffice.org/24503 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/include/vcl/opengl/OpenGLContext.hxx b/include/vcl/opengl/OpenGLContext.hxx index 44b8d67..723a994 100644 --- a/include/vcl/opengl/OpenGLContext.hxx +++ b/include/vcl/opengl/OpenGLContext.hxx @@ -62,6 +62,7 @@ class OpenGLProgram; class OpenGLTexture; class SalGraphicsImpl; class OpenGLTests; +class RenderState; /// Holds the information of our new child window struct GLWindow @@ -166,6 +167,11 @@ public: OpenGLProgram* UseProgram( const OUString& rVertexShader, const OUString& rFragmentShader, const OString& preamble = "" ); voidUseNoProgram(); +std::unique_ptr& state() +{ +return mpRenderState; +} + /// Is this GL context the current context ? bool isCurrent(); /// release bound resources from the current context @@ -249,6 +255,8 @@ private: ProgramCollection maPrograms; OpenGLProgram* mpCurrentProgram; +std::unique_ptr mpRenderState; + public: vcl::Region maClipRegion; int mnPainting; diff --git a/vcl/inc/opengl/RenderState.hxx b/vcl/inc/opengl/RenderState.hxx new file mode 100644 index 000..a184f2e --- /dev/null +++ b/vcl/inc/opengl/RenderState.hxx @@ -0,0 +1,29 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#ifndef INCLUDED_VCL_INC_OPENGL_RENDER_STATE_H +#define INCLUDED_VCL_INC_OPENGL_RENDER_STATE_H + +#include "opengl/TextureState.hxx" + +class RenderState +{ +TextureState maTexture; + +public: +RenderState() +{} + +TextureState& texture() { return maTexture; } +}; + +#endif // INCLUDED_VCL_INC_OPENGL_RENDER_STATE_H + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/inc/opengl/TextureState.hxx b/vcl/inc/opengl/TextureState.hxx new file mode 100644 index 000..945b3b4 --- /dev/null +++ b/vcl/inc/opengl/TextureState.hxx @@ -0,0 +1,76 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#ifndef INCLUDED_VCL_INC_OPENGL_TEXTURE_STATE_H +#define INCLUDED_VCL_INC_OPENGL_TEXTURE_STATE_H + +#include + +class TextureState +{ +private: +GLuint mnCurrentTextureUnit; +std::vector maBoundTextures; + +public: +TextureState() +: mnCurrentTextureUnit(0) +, maBoundTextures(4, 0) +{} + +void generate(GLuint& nTexture) +{ +glGenTextures(1, ); +CHECK_GL_ERROR(); +} + +void active(GLuint nTextureUnit) +{ +if (mnCurrentTextureUnit != nTextureUnit) +{ +glActiveTexture(GL_TEXTURE0 + nTextureUnit); +CHECK_GL_ERROR(); +mnCurrentTextureUnit = nTextureUnit; +} + +} + +void bind(GLuint nTexture) +{ +if (maBoundTextures[mnCurrentTextureUnit] != nTexture) +{ +glBindTexture(GL_TEXTURE_2D, nTexture); +CHECK_GL_ERROR(); +maBoundTextures[mnCurrentTextureUnit] = nTexture; +} +} + +void unbindAndDelete(GLuint nTexture) +{ +unbind(nTexture); +glDeleteTextures(1, ); +
[Libreoffice-bugs] [Bug 99558] UI: Calc crashes when changing color of shape object added to chart
https://bugs.documentfoundation.org/show_bug.cgi?id=99558 --- Comment #1 from mark_t2...@outlook.com --- I tried to confirm if this issue exists in LibreOfficeDev_5.2.0.0.alpha1_Win_x64, but I'm not able to reproduce the issue in this version. Different behavior is that the side toolbar shows "Properties for the task that you are performing are not available for the current selection". This avoids the possibility of causing the crash that I saw with 5.1.2.2. Also realized that the shape colour can be changed, using right click on the object, select Area and then choose the colour. This works in both 5.1.2.2 and 5.2.0.0.alpha1. Should we mark this as resolved? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99584] Optimal-width columns too small to print (data appears as '#' chars)
https://bugs.documentfoundation.org/show_bug.cgi?id=99584 --- Comment #1 from Jim Avera--- Created attachment 124743 --> https://bugs.documentfoundation.org/attachment.cgi?id=124743=edit Screenshot (in case it depends on my fonts or something) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99584] New: Optimal-width columns too small to print (data appears as '#' chars)
https://bugs.documentfoundation.org/show_bug.cgi?id=99584 Bug ID: 99584 Summary: Optimal-width columns too small to print (data appears as '#' chars) Product: LibreOffice Version: 4.2.1.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jim.av...@gmail.com Created attachment 124742 --> https://bugs.documentfoundation.org/attachment.cgi?id=124742=edit Demo which prints wrongly If all columns are set to "Optimal Column Width", then when the spreadsheet is printed, some columns of numbers appear as "###" instead of the numbers which are visible in the normal spreadsheet view. Whether or not this happens seems to exquisitely depend on the font used and the exact magnification of the table when printing, etc. Attached is an example document. STEPS TO REPRODUCE: 1. Open attached "hashchars_when_printed.ods" 2. Click in corner to select all cells 3. Place cursor in column-header-row and RightClick->Optimal Column Width... Set "Add" to 0. Click OK. 4. Print the page, or File->PagePreview RESULTS: Nothing but "###" EXPECTED RESULTS: WYSIWYG (i.e. the numbers shown in the spreadsheet should appear) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch
https://bugs.documentfoundation.org/show_bug.cgi?id=99258 --- Comment #35 from Luke--- Created attachment 124741 --> https://bugs.documentfoundation.org/attachment.cgi?id=124741=edit 1st attempt to backtrace WinDbg doesn't seem to recognize the error as an exception. Am I doing something wrong? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99490] After upgrading, spell checker no longer works
https://bugs.documentfoundation.org/show_bug.cgi?id=99490 --- Comment #4 from Todd--- Found the offender. It is "registrymodifications.xcu". Would you like me to upload it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch
https://bugs.documentfoundation.org/show_bug.cgi?id=99258 --- Comment #34 from Luke--- Created attachment 124740 --> https://bugs.documentfoundation.org/attachment.cgi?id=124740=edit Screenshot of Fatal Error -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98521] Font in tablecontrol isn't shown in right format
https://bugs.documentfoundation.org/show_bug.cgi?id=98521 --- Comment #2 from frofa--- "Works right up to LO 4.4.7.2, fails with LO 5.0.0.5 and all newer versions up to 5.1.1.3." I can confirm this problem on my Mac OSX 10.11.4 setup (as quoted above). NOTE: A number of apparently NEW interface BUGS have appeared in LO 5.x which as far as I can see have not been seen before - such as bug numbers 93185 and 97731 - and which in my view have significantly degraded the usability of the Base component compared with the version 4.x series (to the point where I felt it necessary to back-grade to this earlier version). I really hope these new bugs will be addressed soon. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99490] After upgrading, spell checker no longer works
https://bugs.documentfoundation.org/show_bug.cgi?id=99490 --- Comment #3 from Todd--- I have my old profile still kicking around if you guys want it for troubleshooting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99490] After upgrading, spell checker no longer works
https://bugs.documentfoundation.org/show_bug.cgi?id=99490 --- Comment #2 from Todd--- This did not work: https://forum.openoffice.org/en/forum/viewtopic.php?f=74=16512 This did: https://forum.openoffice.org/en/forum/viewtopic.php?p=58403#p58403 Would you guys please come up with a way to stop this from happening every upgrade? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76523] Copy of sheet (to New File) does not copy named items
https://bugs.documentfoundation.org/show_bug.cgi?id=76523 Eike Rathkechanged: What|Removed |Added Version|4.2.0.4 release |Inherited From OOo Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||73381 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73381] Add Option to Auto-Save Duplicate in Native Format
https://bugs.documentfoundation.org/show_bug.cgi?id=73381 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74084] FILESAVE: Program greys out in a flashing type way [save issue]
https://bugs.documentfoundation.org/show_bug.cgi?id=74084 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||74084 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44453] FILESAVE FILEOPEN .xls: EXCEL Leap year bug has to be mentioned
https://bugs.documentfoundation.org/show_bug.cgi?id=44453 --- Comment #7 from sdc.bla...@youmail.dk --- LO 5.1.2.2 Windows 7 Could not reproduce (with MS Excel 2010) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94042] Improving autorecovery/autosave
https://bugs.documentfoundation.org/show_bug.cgi?id=94042 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=47 ||988 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||47988 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47988] FILESAVE: Feature request : better visibility and access to automatical backups and enabled by default
https://bugs.documentfoundation.org/show_bug.cgi?id=47988 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||042 Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 94042] Improving autorecovery/autosave
https://bugs.documentfoundation.org/show_bug.cgi?id=94042 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=47 ||988 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 76523] Copy of sheet (to New File) does not copy named items
https://bugs.documentfoundation.org/show_bug.cgi?id=76523 Eike Rathkechanged: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76523] Copy of sheet (to New File) does not copy named items
https://bugs.documentfoundation.org/show_bug.cgi?id=76523 --- Comment #19 from Commit Notification--- Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=02a8589553b5ce0e57a7ee9e66327376125b4378 Resolves: tdf#76523 copy used names or pointing to sheet to other document It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76523] Copy of sheet (to New File) does not copy named items
https://bugs.documentfoundation.org/show_bug.cgi?id=76523 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99575] spreadsheet does not save format changes
https://bugs.documentfoundation.org/show_bug.cgi?id=99575 m.a.riosvchanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #3 from m.a.riosv --- Please answer here. If you want to save the format you can't use csv type file, they are plain text files, so no format is saved with them. Once open choose SaveAs to save in the ods native format as spreadsheet, your format will be preserved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 4 commits - sc/inc sc/qa sc/source
sc/inc/document.hxx | 12 +++- sc/inc/rangenam.hxx | 20 sc/qa/unit/ucalc_formula.cxx| 16 sc/source/core/data/documen2.cxx| 18 +- sc/source/core/data/document10.cxx |7 +-- sc/source/core/data/formulacell.cxx |2 +- sc/source/core/tool/rangenam.cxx| 16 7 files changed, 86 insertions(+), 5 deletions(-) New commits: commit 02a8589553b5ce0e57a7ee9e66327376125b4378 Author: Eike RathkeDate: Fri Apr 29 22:05:05 2016 +0200 Resolves: tdf#76523 copy used names or pointing to sheet to other document Change-Id: I767ed1f212c257741fd982e8bbd0882a29d439c1 diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index a38279f..05b93f3 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -628,11 +628,21 @@ public: position of the existing name adjusted for Tab. rOldPos.nTab MUST point to the old sheet copied from. +@param bGlobalNamesToLocal +If TRUE, affected global names are copied to sheet-local names. +If FALSE, global names are copied to global names in another document. + +@param bUsedByFormula +If TRUE, forces a global name to be affected/used. +If FALSE, a global name is only affected if it evaluates to be +referencing the sheet. + @return TRUE if copied and caller may need to evaluate rpRangeData and rSheet and rIndex. FALSE if nothing to be done. */ bool CopyAdjustRangeName( SCTAB& rSheet, sal_uInt16& rIndex, ScRangeData*& rpRangeData, ScDocument& rNewDoc, -const ScAddress& rNewPos, const ScAddress& rOldPos, const bool bGlobalNamesToLocal) const; +const ScAddress& rNewPos, const ScAddress& rOldPos, const bool bGlobalNamesToLocal, +const bool bUsedByFormula ) const; /** * Call this immediately before updating all named ranges. diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx index a393463..e92b6a8 100644 --- a/sc/source/core/data/documen2.cxx +++ b/sc/source/core/data/documen2.cxx @@ -987,6 +987,14 @@ sal_uLong ScDocument::TransferTab( ScDocument* pSrcDoc, SCTAB nSrcPos, nDestPos = std::min(nDestPos, (SCTAB)(GetTableCount() - 1)); { // scope for bulk broadcast ScBulkBroadcast aBulkBroadcast( pBASM); +if (!bResultsOnly) +{ +const bool bGlobalNamesToLocal = false; +const ScRangeName* pNames = pSrcDoc->GetRangeName( nSrcPos); +if (pNames) +pNames->CopyUsedNames( nSrcPos, nSrcPos, nDestPos, *pSrcDoc, *this, bGlobalNamesToLocal); +pSrcDoc->GetRangeName()->CopyUsedNames( -1, nSrcPos, nDestPos, *pSrcDoc, *this, bGlobalNamesToLocal); +} pSrcDoc->maTabs[nSrcPos]->CopyToTable(aCxt, 0, 0, MAXCOL, MAXROW, ( bResultsOnly ? InsertDeleteFlags::ALL & ~InsertDeleteFlags::FORMULA : InsertDeleteFlags::ALL), false, maTabs[nDestPos] ); diff --git a/sc/source/core/data/document10.cxx b/sc/source/core/data/document10.cxx index f7ed6e8..4690f9b 100644 --- a/sc/source/core/data/document10.cxx +++ b/sc/source/core/data/document10.cxx @@ -656,7 +656,8 @@ ScRangeData* copyRangeNames( SheetIndexMap& rSheetIndexMap, std::vector(this)->GetPool()); if (bSameDoc && ((rSheet < 0 && !bGlobalNamesToLocal) || (rSheet >= 0 && rSheet != rOldPos.Tab( @@ -725,7 +726,9 @@ bool ScDocument::CopyAdjustRangeName( SCTAB& rSheet, sal_uInt16& rIndex, ScRange // If no range name was found copy it. if (!rpRangeData) { -bool bEarlyBailOut = (nOldSheet < 0 && bSameDoc); +// Do not copy global name if it doesn't reference sheet or is not used +// by a formula copied to another document. +bool bEarlyBailOut = (nOldSheet < 0 && (bSameDoc || !bUsedByFormula)); MightReferenceSheet eMightReference = mightRangeNameReferenceSheet( pOldRangeData, nOldTab); if (bEarlyBailOut && eMightReference == MightReferenceSheet::NONE) return false; diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index b61d89c..6e3bbca 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -430,7 +430,7 @@ void adjustRangeName(formula::FormulaToken* pToken, ScDocument& rNewDoc, const S ScRangeData* pRangeData = nullptr; SCTAB nSheet = pToken->GetSheet(); sal_uInt16 nIndex = pToken->GetIndex(); -if (!pOldDoc->CopyAdjustRangeName( nSheet, nIndex, pRangeData, rNewDoc, rNewPos, rOldPos, bGlobalNamesToLocal)) +if (!pOldDoc->CopyAdjustRangeName( nSheet, nIndex, pRangeData, rNewDoc, rNewPos, rOldPos,
[Libreoffice-bugs] [Bug 99575] spreadsheet does not save format changes
https://bugs.documentfoundation.org/show_bug.cgi?id=99575 --- Comment #2 from m.a.riosv--- Created attachment 124739 --> https://bugs.documentfoundation.org/attachment.cgi?id=124739=edit Sample file received answer. When I change font color or alignment those changes are not saved -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98512] The Undo action after that insert a new input field before an old input field should not delete the old input field
https://bugs.documentfoundation.org/show_bug.cgi?id=98512 --- Comment #2 from Commit Notification--- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b44e70e3d17c79eaf78f9bfe8bd0275d7ed9325f tdf#98512: sw: remove duplicate undo history add It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 4 commits - sw/source
sw/source/core/inc/rolbck.hxx | 20 -- sw/source/core/txtnode/ndtxt.cxx |3 sw/source/core/txtnode/thints.cxx |1 sw/source/core/undo/rolbck.cxx| 117 +++--- sw/source/core/undo/unattr.cxx| 16 - sw/source/ui/fldui/flddb.cxx |8 +- sw/source/ui/fldui/flddb.hxx |2 sw/source/ui/fldui/flddinf.cxx| 12 ++- sw/source/ui/fldui/flddinf.hxx|2 sw/source/ui/fldui/flddok.cxx |8 +- sw/source/ui/fldui/flddok.hxx |2 sw/source/ui/fldui/fldfunc.cxx|8 +- sw/source/ui/fldui/fldfunc.hxx|2 sw/source/ui/fldui/fldpage.cxx|5 - sw/source/ui/fldui/fldpage.hxx|2 sw/source/ui/fldui/fldref.cxx |8 +- sw/source/ui/fldui/fldref.hxx |2 sw/source/ui/fldui/fldtdlg.cxx|4 - sw/source/ui/fldui/fldvar.cxx | 10 +-- sw/source/ui/fldui/fldvar.hxx |2 20 files changed, 66 insertions(+), 168 deletions(-) New commits: commit 17f4fc71164a1440e6805221fee19fae322129b9 Author: Michael StahlDate: Sat Apr 30 00:19:13 2016 +0200 sw: SwHistoryResetAttrSet now unused, remove it Change-Id: I6b87b82cb359298e768dd4eb90a788cafe6b8b1c diff --git a/sw/source/core/inc/rolbck.hxx b/sw/source/core/inc/rolbck.hxx index 7f660c1..a756779 100644 --- a/sw/source/core/inc/rolbck.hxx +++ b/sw/source/core/inc/rolbck.hxx @@ -70,7 +70,6 @@ enum HISTORY_HINT { HSTRY_FLYCNT, HSTRY_BOOKMARK, HSTRY_SETATTRSET, -HSTRY_RESETATTRSET, HSTRY_CHGFLYANCHOR, HSTRY_CHGFLYCHAIN, HSTRY_CHGCHARFMT, @@ -276,25 +275,6 @@ public: }; -class SwHistoryResetAttrSet : public SwHistoryHint -{ -const sal_uLong m_nNodeIndex; -const sal_Int32 m_nStart; -const sal_Int32 m_nEnd; -std::vector m_Array; - -public: -SwHistoryResetAttrSet( const SfxItemSet& rSet, sal_uLong nNode, -sal_Int32 nStt, -sal_Int32 nEnd); -virtual void SetInDoc( SwDoc* pDoc, bool bTmpSet ) override; - -const std::vector& GetArr() const { return m_Array; } -sal_uLong GetNode() const { return m_nNodeIndex; } -sal_Int32 GetContent() const { return m_nStart; } - -}; - class SwHistoryChangeFlyAnchor : public SwHistoryHint { SwFrameFormat & m_rFormat; diff --git a/sw/source/core/undo/rolbck.cxx b/sw/source/core/undo/rolbck.cxx index 4b62d49..a8ea84e 100644 --- a/sw/source/core/undo/rolbck.cxx +++ b/sw/source/core/undo/rolbck.cxx @@ -773,90 +773,6 @@ void SwHistorySetAttrSet::SetInDoc( SwDoc* pDoc, bool ) } } -SwHistoryResetAttrSet::SwHistoryResetAttrSet( const SfxItemSet& rSet, -sal_uLong nNodePos, sal_Int32 nAttrStt, sal_Int32 nAttrEnd ) -: SwHistoryHint( HSTRY_RESETATTRSET ) -, m_nNodeIndex( nNodePos ), m_nStart( nAttrStt ), m_nEnd( nAttrEnd ) -, m_Array( (sal_uInt8)rSet.Count() ) -{ -SfxItemIter aIter( rSet ); -bool bAutoStyle = false; - -while( true ) -{ -const sal_uInt16 nWhich = aIter.GetCurItem()->Which(); - -#ifdef DBG_UTIL -switch (nWhich) -{ -case RES_TXTATR_REFMARK: -case RES_TXTATR_TOXMARK: -if (m_nStart != m_nEnd) break; // else: fall through! -case RES_TXTATR_FIELD: -case RES_TXTATR_ANNOTATION: -case RES_TXTATR_FLYCNT: -case RES_TXTATR_FTN: -case RES_TXTATR_META: -case RES_TXTATR_METAFIELD: -OSL_ENSURE(rSet.Count() == 1, -"text attribute with CH_TXTATR, but not the only one:" -"\nnot such a good idea"); -break; -} -#endif // DBG_UTIL - -// Character attribute cannot be inserted into the hints array -// anymore. Therefore we have to treat them as one RES_TXTATR_AUTOFMT: -if (isCHRATR(nWhich)) -{ -bAutoStyle = true; -} -else -{ -m_Array.push_back( aIter.GetCurItem()->Which() ); -} - -if( aIter.IsAtEnd() ) -break; - -aIter.NextItem(); -} - -if ( bAutoStyle ) -{ -m_Array.push_back( RES_TXTATR_AUTOFMT ); -} -} - -void SwHistoryResetAttrSet::SetInDoc( SwDoc* pDoc, bool ) -{ -::sw::UndoGuard const undoGuard(pDoc->GetIDocumentUndoRedo()); - -SwContentNode * pContentNd = pDoc->GetNodes()[ m_nNodeIndex ]->GetContentNode(); -OSL_ENSURE( pContentNd, "SwHistoryResetAttrSet: no ContentNode" ); - -if (pContentNd) -{ -std::vector::iterator it; -if ( USHRT_MAX == m_nEnd && USHRT_MAX == m_nStart ) -{ -// no area: use ContentNode -for ( it = m_Array.begin(); it != m_Array.end(); ++it ) -{ -pContentNd->ResetAttr( *it ); -} -} -else -{ -// area: use TextNode -for ( it = m_Array.begin(); it !=
Still able to copy text after disabling command
Hello there, I'm trying to disable Copy (ctrl + C) using java UNO API. I could find this example: https://wiki.openoffice.org/wiki/Documentation/DevGuide/WritingUNO/Disable_Commands and it works perfect for commands such as Open and Save. The problem with Copy is that even the command not being in menu, I am still able to Copy text using Ctrl + C. Is this a bug? If so, how can I prevent user from copying content from the document? Thanks in advance. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 99575] spreadsheet does not save format changes
https://bugs.documentfoundation.org/show_bug.cgi?id=99575 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Please attach a sample file where to reproduce the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98897] Open Remote File - Cannot Connect to Server via SSH
https://bugs.documentfoundation.org/show_bug.cgi?id=98897 --- Comment #10 from Richard--- (In reply to Buovjaga from comment #9) > (In reply to Richard from comment #8) > > I would be glad to try to gather more info if anyone can point out info on > > how to enable debugging logs. > > https://wiki.documentfoundation.org/QA/BugReport/Debug_Information > > On Debian, you install the libreoffice-dbg package. > > Did this work in an older version? > > NEW per comment 8. Older versions had the same issue back to 5.0 at least. I can try earlier ones as well if needed. I'll install libreoffice-dbg on debian, and gather more info with --backtrace. Thanks so much for your help! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99572] ODS sheet with many external links from other calc files crashes when updtating
https://bugs.documentfoundation.org/show_bug.cgi?id=99572 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- Hi @c.bessiere, thanks for reporting. I can't reproduce. Please test disabling Menu/Tools/Options/LibreOffce/OpenCL options. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69401] Crash after copy & pasting a large number of shapes and saving
https://bugs.documentfoundation.org/show_bug.cgi?id=69401 --- Comment #11 from MarjaE--- I don't think it was the same bug. I re-did the above work, finished the drawing, and saved several times along the way. I re-opened it to check something didn't change anything, and had LibreOffice hard freeze on quit. So the bug I'm encountering isn't linked to repeated copying and pasting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99581] Draw: Crack when change line width and can not change width at all
https://bugs.documentfoundation.org/show_bug.cgi?id=99581 --- Comment #5 from chench...@gmail.com --- (In reply to V Stuart Foote from comment #1) > Can not reproduce on Windows 8.1 Pro 64-bit en-US with > Version: 5.1.2.2 (x64) > Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f > CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; > Locale: en-US (en_US) > > > Using the sidebar Properties deck, Line content panel I can paste line width > in points. Or, using the context menu -> Line dialog the width field can be > directly edited--can be scrolled--or a value can be pasted. Interesting in > that the sidebar content panel measurments are working in point while the > dialog is working in inches for my local. > > In any case Draw is not "crashing". Yes, you are right, I can use the context munu -> Line dialog the width field to change the line width, and set the globle unit to pt, I can get the right line width use the Line dialog, but in the sidebar Properties deck, I just only can change the line width by click the up and down arrow in the Custom area in the drop down menu or select the width directly, can not tying any number in the box, when I try to left click select the box(can not select it at all, the curser can not blink in the box) and typing any charactor, the Draw is cracking... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99581] Draw: Crack when change line width and can not change width at all
https://bugs.documentfoundation.org/show_bug.cgi?id=99581 --- Comment #4 from chench...@gmail.com --- (In reply to V Stuart Foote from comment #1) > Can not reproduce on Windows 8.1 Pro 64-bit en-US with > Version: 5.1.2.2 (x64) > Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f > CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; > Locale: en-US (en_US) > > > Using the sidebar Properties deck, Line content panel I can paste line width > in points. Or, using the context menu -> Line dialog the width field can be > directly edited--can be scrolled--or a value can be pasted. Interesting in > that the sidebar content panel measurments are working in point while the > dialog is working in inches for my local. > > In any case Draw is not "crashing". Thanks for your recommends, I used the sidebar when I found the bug, I could not typing number to change the drawed line width in the sidebar Properties area where the context menu -> Line dialog the width field can. But I found the side bar Properties shows the width unit in pt, but he context menu -> Line dialog the width field in inch, when I typed width unit in pt in Line dialog, it seems work very weird, maybe the accuracy problem or something else, it won't the line width which I want in the Line dialog but the side bar. I don't know the problem only in Ubuntu or the other OS system the same. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99581] Draw: Crack when change line width and can not change width at all
https://bugs.documentfoundation.org/show_bug.cgi?id=99581 --- Comment #3 from chench...@gmail.com --- Thanks for your recommends, I used the sidebar when I found the bug, I could not typing number to change the drawed line width in the sidebar Properties area where the context menu -> Line dialog the width field can. But I found the side bar Properties shows the width unit in pt, but he context menu -> Line dialog the width field in inch, when I typed width unit in pt in Line dialog, it seems work very weird, maybe the accuracy problem or something else, it won't the line width which I want in the Line dialog but the side bar. I don't know the problem only in Ubuntu or the other OS system the same. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99583] New: Increased Text Flow Options Providing Multicultural Support
https://bugs.documentfoundation.org/show_bug.cgi?id=99583 Bug ID: 99583 Summary: Increased Text Flow Options Providing Multicultural Support Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jaqal...@embarqmail.com There are alphabets, abjads, syllaberies, etc., such as the Phags-pa, Mongolian, Chinese, Korean, and hieroglyphic systems which do not have to use or simply do not use the traditional left to right or right to left text flow. One such can be found at the following: http://www.mongolfont.com/ . If the text flow could be set to various directions (R to L, L to R, T to B, B to T) this would make the use of traditional languages, either as subjects of study or attempting to hold their own in the face of extinction in an era where technology is not produced for their needs, accessible in the modern world. Of these languages, modernizing to include Mayan might be the hardest as it operates in pictographic syllables arranged in pairs running from top to bottom. It would be like allowing two Kanji/Hanja/Chinese Characters on a row writing down the column. I cannot code. I study linquistics, history, culture, etc. Programming is not only beyond me, but the last language that made any sense to me was GFA basic decades ago. However, as a philosopher and student of history it is my hope that this change will be important to you since it will provide access to those human expressions struggling to stave off extinction or find a place in the modern world. Thank you for your time and consideration, Kenneth W. Slayor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79138] Calc crash
https://bugs.documentfoundation.org/show_bug.cgi?id=79138 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||79138 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96089] Autorecovery runs on unmodified file
https://bugs.documentfoundation.org/show_bug.cgi?id=96089 --- Comment #9 from Heiko Tietze--- Addendum: It takes about 6 seconds on my system until the undo is enabled after opening the document. Guess this time is needed to parse through the entire document. Meaning also that I always have to agree to close without saving changes. Even after 10 seconds. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98506] Calc crashes randomly and frequently
https://bugs.documentfoundation.org/show_bug.cgi?id=98506 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||138 Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79138] Calc crash
https://bugs.documentfoundation.org/show_bug.cgi?id=79138 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=98 ||506 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||98506 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96089] Autorecovery runs on unmodified file
https://bugs.documentfoundation.org/show_bug.cgi?id=96089 --- Comment #8 from Heiko Tietze--- After 4) nothing happens unless I agree with "Edit document" (notification panel at top since the file was downloaded from a suspicious place). After that 5) happens (undo change style). Not sure if this behavior is really unexpected. Version: 5.1.2.2.0+ Build ID: 5.1.2.2 Arch Linux build-1 CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; Locale: de-DE (de_DE.UTF8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99581] Draw: Crack when change line width and can not change width at all
https://bugs.documentfoundation.org/show_bug.cgi?id=99581 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with LO Debian package 5.1.2.2, I don't reproduce this. For the test, could you rename your LO directory profile (see https://wiki.documentfoundation.org/UserProfile#GNU.2FLinux) and give a new try? If you still reproduce this, please try to retrieve a backtrace by using this link: https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/test
loolwsd/test/httpwstest.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 4be73e593466efef017ac031f10b15cbdabb14c1 Author: Ashod NakashianDate: Fri Apr 29 17:17:28 2016 -0400 loolwsd: minor improvement to testing socket flags Change-Id: I87d4d6a22fccef97bf69fce249ec0374db417714 Reviewed-on: https://gerrit.libreoffice.org/24502 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp index 3840bb6..258b44f 100644 --- a/loolwsd/test/httpwstest.cpp +++ b/loolwsd/test/httpwstest.cpp @@ -232,27 +232,27 @@ void HTTPWSTest::testHandShake() socket.setReceiveTimeout(0); bytes = socket.receiveFrame(buffer, sizeof(buffer), flags); CPPUNIT_ASSERT_EQUAL(std::string(payload), std::string(buffer, bytes)); - CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags); + CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags & Poco::Net::WebSocket::FRAME_TEXT); bytes = socket.receiveFrame(buffer, sizeof(buffer), flags); if (!std::strstr(buffer, fail)) { payload = "statusindicator: connect"; CPPUNIT_ASSERT_EQUAL(payload, std::string(buffer, bytes)); - CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags); + CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags & Poco::Net::WebSocket::FRAME_TEXT); bytes = socket.receiveFrame(buffer, sizeof(buffer), flags); if (!std::strstr(buffer, fail)) { payload = "statusindicator: ready"; CPPUNIT_ASSERT_EQUAL(payload, std::string(buffer, bytes)); - CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags); + CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags & Poco::Net::WebSocket::FRAME_TEXT); } else { // check error message CPPUNIT_ASSERT(std::strstr(buffer, SERVICE_UNAVALABLE_INTERNAL_ERROR) != nullptr); - CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags); + CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags & Poco::Net::WebSocket::FRAME_TEXT); // close frame message bytes = socket.receiveFrame(buffer, sizeof(buffer), flags); @@ -264,7 +264,7 @@ void HTTPWSTest::testHandShake() { // check error message CPPUNIT_ASSERT(std::strstr(buffer, SERVICE_UNAVALABLE_INTERNAL_ERROR) != nullptr); - CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags); + CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags & Poco::Net::WebSocket::FRAME_TEXT); // close frame message bytes = socket.receiveFrame(buffer, sizeof(buffer), flags); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/test
loolwsd/test/countloolkits.hpp |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit a007a7c1d45088a59c2ea0d0ade1410463e3243d Author: Ashod NakashianDate: Fri Apr 29 17:16:53 2016 -0400 loolwsd: improved LoKit process counting Change-Id: I514ece4ce7f401a8996bc115ab00ddb7a8bec90d Reviewed-on: https://gerrit.libreoffice.org/24501 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/test/countloolkits.hpp b/loolwsd/test/countloolkits.hpp index c81bf98..c9ca40f 100644 --- a/loolwsd/test/countloolkits.hpp +++ b/loolwsd/test/countloolkits.hpp @@ -68,7 +68,7 @@ int getLoolKitProcessCount() static int countLoolKitProcesses(const int expected, const int timeoutMs = POLL_TIMEOUT_MS * 10) { -const size_t repeat = (timeoutMs + POLL_TIMEOUT_MS - 1) / POLL_TIMEOUT_MS; +const size_t repeat = 1 + (timeoutMs / POLL_TIMEOUT_MS); auto count = getLoolKitProcessCount(); for (size_t i = 0; i < repeat; ++i) { @@ -83,6 +83,11 @@ int countLoolKitProcesses(const int expected, const int timeoutMs = POLL_TIMEOUT count = getLoolKitProcessCount(); } +if (expected != count) +{ +std::cerr << "Found " << count << " LoKit processes but was expecting " << expected << "." << std::endl; +} + return count; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||77239 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77239] Other: AutoRecovery does not Work Correct if Document has not been Saved Initially by the User
https://bugs.documentfoundation.org/show_bug.cgi?id=77239 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99581] Draw: Crack when change line width and can not change width at all
https://bugs.documentfoundation.org/show_bug.cgi?id=99581 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- Can not reproduce on Windows 8.1 Pro 64-bit en-US with Version: 5.1.2.2 (x64) Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; Locale: en-US (en_US) Using the sidebar Properties deck, Line content panel I can paste line width in points. Or, using the context menu -> Line dialog the width field can be directly edited--can be scrolled--or a value can be pasted. Interesting in that the sidebar content panel measurments are working in point while the dialog is working in inches for my local. In any case Draw is not "crashing". -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 sdc.bla...@youmail.dk changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||67080 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94042] Improving autorecovery/autosave
https://bugs.documentfoundation.org/show_bug.cgi?id=94042 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||080 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67080] Higher security for normal user by changing default values
https://bugs.documentfoundation.org/show_bug.cgi?id=67080 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||042 Blocks||77999 --- Comment #3 from sdc.bla...@youmail.dk --- Maybe this is a duplicate of bug 94042 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 94042] Improving autorecovery/autosave
https://bugs.documentfoundation.org/show_bug.cgi?id=94042 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||080 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-qa] Minutes of the Design Hangout: 2016-04-29
* Present: Heiko, Samuel, Tomaz, Kendy * GSoC + https://summerofcode.withgoogle.com/dashboard/ + Approved UI projects: + Improve user experience with Table Styles (mentors: dev - kendy/miklos, ui - jay/heiko) + Review of the Area Fill dialog (mentors: dev Bubli , ui - jay/heiko) + Redesigning the Template Manager (mentors: dev - samuel, ui - jay) + Review of Sidebar and it's functionality (mentors: dev Bubli , ui - jay) + Infrastructure for defining toolbars via .ui (Glade) files (mentors: dev - kendy/samuel, ui - heiko) + Started a weekly update meeting with Rishabh (Area Fill project) and Bubli like in SCRUM + what has been done, what is planned, where are the bottlenecks + sounds great (Kendy) + encourage your students to hack already, bonding by producing code is best :-) (Kendy) * Draw (Heiko) + Started to create metabugs for better organization (tdf#99563, tdf#99525) * Sidebar survey (Heiko) + No complaints about the proposed guidelines + Added to the HIG at the wiki * Help content (Jay / Kendy) + http://vm173.documentfoundation.org/ + Olivier updated the xslt so that it produces a list of keywords now (Kendy) + see eg. http://vm173.documentfoundation.org/text/swriter/main.xhp + not sorted yet, but a good direction of developments I think :-) (Kendy) * needsUXEval (Heiko / Kendy) + now it is not necessary to use the 'ux-advise' component any more + instead, add the 'needsUXEval' keyword, and the ux-advice@ ML will be CC'd + should we kill the 'ux-advise' component? (Samuel) + probably not yet, as it shows which bugs are untriaged (Kendy) + but when we move them to the neesUXEval keyword, then yes (Kendy) * Tabs etc + https://bugs.documentfoundation.org/show_bug.cgi?id=99528 + http://i.imgur.com/aLP247v.png + Three options for navigation right now: tabs (e.g. paragraph style), tree (options), and icon view (hyperlink) + We should have one way of presentation (Heiko) * Calc Default Header (Samuel) + https://bugs.documentfoundation.org/show_bug.cgi?id=99296 + Clearing the text (Table1/Page1) doesn't solve the issue since empty space remains + Disabling the header/footer by default is better (Tomaz, Samuel, Heiko) + Worries that people can find the setting (Samuel) + Excel has no header/footer, let's do the same (Kendy) + Will research a bit more, so that there is one place to set this (Samuel) * "Custom Animation" probably should be called just "Animation" (Samuel) + https://bugs.documentfoundation.org/show_bug.cgi?id=95387 + agreed to change (all) * Drop the term "Manager" (Samuel) + Template Manager -> Templates + Extension Manager -> Extensions + Are there more? + agree (all) + Problem with "Extensions" and "Add-Ons" in the same menu then, postpone this * Add-Ons vs Extensions (Samuel) + Term "Add-Ons" used once: http://i.imgur.com/qpK5AsK.png + Rename Add-ons to Extensions and move Extensions Manager into this submenu + rename to Organize Extensions (like for Makro) (Heiko) + Drawback is a submenu with only one item by default (Samuel) * Shortcut for Extension Manager (Jay) + Is Ctrl + Alt + E a good shortcut? https://gerrit.libreoffice.org/#/c/23376/ + no objections on the ML, so pushed that (Samuel) ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Minutes of the Design Hangout: 2016-04-29
* Present: Heiko, Samuel, Tomaz, Kendy * GSoC + https://summerofcode.withgoogle.com/dashboard/ + Approved UI projects: + Improve user experience with Table Styles (mentors: dev - kendy/miklos, ui - jay/heiko) + Review of the Area Fill dialog (mentors: dev Bubli , ui - jay/heiko) + Redesigning the Template Manager (mentors: dev - samuel, ui - jay) + Review of Sidebar and it's functionality (mentors: dev Bubli , ui - jay) + Infrastructure for defining toolbars via .ui (Glade) files (mentors: dev - kendy/samuel, ui - heiko) + Started a weekly update meeting with Rishabh (Area Fill project) and Bubli like in SCRUM + what has been done, what is planned, where are the bottlenecks + sounds great (Kendy) + encourage your students to hack already, bonding by producing code is best :-) (Kendy) * Draw (Heiko) + Started to create metabugs for better organization (tdf#99563, tdf#99525) * Sidebar survey (Heiko) + No complaints about the proposed guidelines + Added to the HIG at the wiki * Help content (Jay / Kendy) + http://vm173.documentfoundation.org/ + Olivier updated the xslt so that it produces a list of keywords now (Kendy) + see eg. http://vm173.documentfoundation.org/text/swriter/main.xhp + not sorted yet, but a good direction of developments I think :-) (Kendy) * needsUXEval (Heiko / Kendy) + now it is not necessary to use the 'ux-advise' component any more + instead, add the 'needsUXEval' keyword, and the ux-advice@ ML will be CC'd + should we kill the 'ux-advise' component? (Samuel) + probably not yet, as it shows which bugs are untriaged (Kendy) + but when we move them to the neesUXEval keyword, then yes (Kendy) * Tabs etc + https://bugs.documentfoundation.org/show_bug.cgi?id=99528 + http://i.imgur.com/aLP247v.png + Three options for navigation right now: tabs (e.g. paragraph style), tree (options), and icon view (hyperlink) + We should have one way of presentation (Heiko) * Calc Default Header (Samuel) + https://bugs.documentfoundation.org/show_bug.cgi?id=99296 + Clearing the text (Table1/Page1) doesn't solve the issue since empty space remains + Disabling the header/footer by default is better (Tomaz, Samuel, Heiko) + Worries that people can find the setting (Samuel) + Excel has no header/footer, let's do the same (Kendy) + Will research a bit more, so that there is one place to set this (Samuel) * "Custom Animation" probably should be called just "Animation" (Samuel) + https://bugs.documentfoundation.org/show_bug.cgi?id=95387 + agreed to change (all) * Drop the term "Manager" (Samuel) + Template Manager -> Templates + Extension Manager -> Extensions + Are there more? + agree (all) + Problem with "Extensions" and "Add-Ons" in the same menu then, postpone this * Add-Ons vs Extensions (Samuel) + Term "Add-Ons" used once: http://i.imgur.com/qpK5AsK.png + Rename Add-ons to Extensions and move Extensions Manager into this submenu + rename to Organize Extensions (like for Makro) (Heiko) + Drawback is a submenu with only one item by default (Samuel) * Shortcut for Extension Manager (Jay) + Is Ctrl + Alt + E a good shortcut? https://gerrit.libreoffice.org/#/c/23376/ + no objections on the ML, so pushed that (Samuel) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 36311] DDE link between two spreadsheets: updated values not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=36311 Buovjagachanged: What|Removed |Added CC|libreoffice@lists.freedeskt |todven...@suomi24.fi |op.org | Hardware|x86 (IA32) |All Version|5.1.2.2 release |3.3.2 release OS|Windows (All) |All -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 36311] DDE link between two spreadsheets: updated values not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=36311 Buovjagachanged: What|Removed |Added CC|libreoffice@lists.freedeskt |todven...@suomi24.fi |op.org | Hardware|x86 (IA32) |All Version|5.1.2.2 release |3.3.2 release OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99523] Moving slides in the deck crashes Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=99523 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |WORKSFORME --- Comment #2 from V Stuart Foote --- On Windows 8.1 Pro 64-bit en-US with Version: 5.1.2.2 (x64) Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; Locale: en-US (en_US) 165 slide .ODP pick slide 5 ++ moves to end. +Z reverts to prior position. pick slide 6 ++ select and drag it upward 30 slides in the Slides pane--no issue. ++ slide positions to top of Slides pane. Drag it back to its position as slide 6. No issues. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93612] Allow selection of which documents the user would like to Recover
https://bugs.documentfoundation.org/show_bug.cgi?id=93612 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||93612 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks|43474 | Depends on||43474 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79160] Insert image does not let you choose frame style
https://bugs.documentfoundation.org/show_bug.cgi?id=79160 --- Comment #15 from Gilvan Vilarim--- Hello guys. This bug persists. Tested on Windows 10 with LibreOffice 5.1 Brazilian portuguese. Best regards, Gilvan. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93612] Allow selection of which documents the user would like to Recover
https://bugs.documentfoundation.org/show_bug.cgi?id=93612 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks|81146 | Depends on||81146 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43474] Do not show Progress Bar for Autosave action predictable shorter 2 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=43474 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 Depends on|77999 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81146] Avoid corruption of registrymodifications.xcu
https://bugs.documentfoundation.org/show_bug.cgi?id=81146 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 Depends on|77999 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks|89651 | Depends on||89651 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89651] Why dont do an autobackup option like this:
https://bugs.documentfoundation.org/show_bug.cgi?id=89651 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 Depends on|77999 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks|95229 | Depends on||95229 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98404] UX - While objects on a slide are being edited, notably text boxes, the new slide sorter Ctrl+Shift shortcut combinations (see bug 91909) incorrectly receive focus and m
https://bugs.documentfoundation.org/show_bug.cgi?id=98404 V Stuart Footechanged: What|Removed |Added Keywords||needsUXEval CC||caol...@redhat.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Summary|[EDITING] Ctrl+Shift |UX - While objects on a |combinations (Home, End,|slide are being edited, |Up/Down) move slide in |notably text boxes, the |slide sorter when editing |new slide sorter Ctrl+Shift |text on a slide |shortcut combinations (see ||bug 91909) incorrectly ||receive focus and move the ||slide --- Comment #9 from V Stuart Foote --- Movement of slides was introduced with enhancements of bug 91909 -- where Caolán later reverted use of the and the keys for slide navigation as the shortcuts broke legacy text editing. And here this remains a simple conflict with selected shortcuts--these ++[Home|Up|Down|End] text movement and selection text edit functions are still in conflict. Pretty sure they are reserved inside edit engine -- and so got missed when reviewing Accelerators.xcu for use for slide movement shortcuts. @Jay, Philippe -- if we can not isolate behavior of the Slide sorter pane from the active elements on the slide canvas then we have to change the chosen ShortCuts for slide movements. Believe the newer feature should get new shortcuts. And the legacy (and arcane) assignments in edit engine (used in all modules) should be left alone. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95229] Add autosave and backup to work with "remote files"
https://bugs.documentfoundation.org/show_bug.cgi?id=95229 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 Depends on|77999 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 95229] Add autosave and backup to work with "remote files"
https://bugs.documentfoundation.org/show_bug.cgi?id=95229 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 Depends on|77999 | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 98404] UX - While objects on a slide are being edited, notably text boxes, the new slide sorter Ctrl+Shift shortcut combinations (see bug 91909) incorrectly receive focus
https://bugs.documentfoundation.org/show_bug.cgi?id=98404 V Stuart Footechanged: What|Removed |Added Keywords||needsUXEval CC||caol...@redhat.com, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vstuart.fo...@utsa.edu Summary|[EDITING] Ctrl+Shift |UX - While objects on a |combinations (Home, End,|slide are being edited, |Up/Down) move slide in |notably text boxes, the |slide sorter when editing |new slide sorter Ctrl+Shift |text on a slide |shortcut combinations (see ||bug 91909) incorrectly ||receive focus and move the ||slide --- Comment #9 from V Stuart Foote --- Movement of slides was introduced with enhancements of bug 91909 -- where Caolán later reverted use of the and the keys for slide navigation as the shortcuts broke legacy text editing. And here this remains a simple conflict with selected shortcuts--these ++[Home|Up|Down|End] text movement and selection text edit functions are still in conflict. Pretty sure they are reserved inside edit engine -- and so got missed when reviewing Accelerators.xcu for use for slide movement shortcuts. @Jay, Philippe -- if we can not isolate behavior of the Slide sorter pane from the active elements on the slide canvas then we have to change the chosen ShortCuts for slide movements. Believe the newer feature should get new shortcuts. And the legacy (and arcane) assignments in edit engine (used in all modules) should be left alone. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 96089] Autorecovery runs on unmodified file
https://bugs.documentfoundation.org/show_bug.cgi?id=96089 Yousuf (Jay) Philipschanged: What|Removed |Added CC||c...@nouenoff.nl, ||tietze.he...@gmail.com, ||vstuart.fo...@utsa.edu --- Comment #7 from Yousuf (Jay) Philips --- @stuart, @cor, @heiko: can any of you reproduce this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96446] Error in Help for LibreLogo
https://bugs.documentfoundation.org/show_bug.cgi?id=96446 --- Comment #2 from Gilvan Vilarim--- Hello. I confirm this in LibreOffice 5.1 on Windows, brazilian portuguese. Best regards, Gilvan. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72438] LibreLogo: icons in Logo toolbar replaced by text only
https://bugs.documentfoundation.org/show_bug.cgi?id=72438 --- Comment #15 from Gilvan Vilarim--- Confirmed: The bug persists in version 5.1. Best regards, Gilvan. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - opencl/inc opencl/source
opencl/inc/opencl_device_selection.h |3 +++ opencl/source/opencl_device.cxx |2 +- 2 files changed, 4 insertions(+), 1 deletion(-) New commits: commit 478a4032da69654245d478e15902feda1e49c84c Author: Caolán McNamaraDate: Fri Apr 29 20:11:50 2016 +0100 coverity#1358844 Uninitialized pointer field Change-Id: I66f34570c49f647cb1fd7775ef263e5e720d8064 diff --git a/opencl/inc/opencl_device_selection.h b/opencl/inc/opencl_device_selection.h index 6ec506d..e2bda73 100644 --- a/opencl/inc/opencl_device_selection.h +++ b/opencl/inc/opencl_device_selection.h @@ -326,6 +326,9 @@ private: public: XmlWalker() +: mpDocPtr(nullptr) +, mpRoot(nullptr) +, mpCurrent(nullptr) {} ~XmlWalker() commit 77327a03904ad7d6f58b07ec698cd15f02a4d6fa Author: Caolán McNamara Date: Fri Apr 29 20:10:18 2016 +0100 coverity#1358843 Argument cannot be negative Change-Id: I97911406d55464f042922a2e37b33f92e2c024ef diff --git a/opencl/source/opencl_device.cxx b/opencl/source/opencl_device.cxx index 907d551..db143e3 100644 --- a/opencl/source/opencl_device.cxx +++ b/opencl/source/opencl_device.cxx @@ -435,7 +435,7 @@ ds_status pickBestDevice(std::unique_ptr& profile, int& rBestDeviceI rBestDeviceIndex = d; } } -if (profile->devices[rBestDeviceIndex].eType == DeviceType::OpenCLDevice) +if (rBestDeviceIndex != -1 && profile->devices[rBestDeviceIndex].eType == DeviceType::OpenCLDevice) { SAL_INFO("opencl.device", "Selected Device[" << rBestDeviceIndex << "]: " << profile->devices[rBestDeviceIndex].sDeviceName << "(OpenCL)."); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: 2 commits - loolwsd/test
loolwsd/test/countloolkits.hpp |2 +- loolwsd/test/httpwstest.cpp|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 2b9295e8d7d03008c1a24e33bdd68c7f25ba980e Author: Jan HolesovskyDate: Fri Apr 29 22:00:45 2016 +0200 countLoolKitProcesses() is more reliable here. diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp index 1880ab6..3840bb6 100644 --- a/loolwsd/test/httpwstest.cpp +++ b/loolwsd/test/httpwstest.cpp @@ -542,7 +542,7 @@ void HTTPWSTest::testReloadWhileDisconnecting() CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, isDocumentLoaded(socket)); // Should have no new instances. -CPPUNIT_ASSERT_EQUAL(kitcount, getLoolKitProcessCount()); +CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount)); // Check if the document contains the pasted text. sendTextFrame(socket, "uno .uno:SelectAll"); commit ce691601dd1fa48f9b15b18822426c33b0cbcbd2 Author: Jan Holesovsky Date: Fri Apr 29 21:54:42 2016 +0200 Need a longer default timeout for the httpwstest.cpp. diff --git a/loolwsd/test/countloolkits.hpp b/loolwsd/test/countloolkits.hpp index 2490f22..c81bf98 100644 --- a/loolwsd/test/countloolkits.hpp +++ b/loolwsd/test/countloolkits.hpp @@ -66,7 +66,7 @@ int getLoolKitProcessCount() } static -int countLoolKitProcesses(const int expected, const int timeoutMs = POLL_TIMEOUT_MS * 5) +int countLoolKitProcesses(const int expected, const int timeoutMs = POLL_TIMEOUT_MS * 10) { const size_t repeat = (timeoutMs + POLL_TIMEOUT_MS - 1) / POLL_TIMEOUT_MS; auto count = getLoolKitProcessCount(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||41063 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94663] Redraw during autosave while scrolling pages with mouse wheel
https://bugs.documentfoundation.org/show_bug.cgi?id=94663 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=41 ||063 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81146] Avoid corruption of registrymodifications.xcu
https://bugs.documentfoundation.org/show_bug.cgi?id=81146 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43474] Do not show Progress Bar for Autosave action predictable shorter 2 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=43474 sdc.bla...@youmail.dk changed: What|Removed |Added Depends on||77999 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77999] [META] Autosave/Autorecovery issues
https://bugs.documentfoundation.org/show_bug.cgi?id=77999 sdc.bla...@youmail.dk changed: What|Removed |Added Blocks||81146 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41063] Saving/Autosaving causes view to jump to cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=41063 sdc.bla...@youmail.dk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=94 ||663 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99582] wrong windows's icon in gnome in child windows
https://bugs.documentfoundation.org/show_bug.cgi?id=99582 --- Comment #2 from mattia.b89--- -screenshot 1 shows the problem on the print dialogue -screenshot 2 shows simply that the icon, although with graphics problem, works in fact I can click it NB: if I disable LO dialogue box from tools->options->LO->general, LO will use 'standard' GTK print dialogue and the problem disappears -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs