[Libreoffice-bugs] [Bug 99626] Crash a LibreOffice when close main window with Wizard dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=99626 --- Comment #2 from baffclan--- Created attachment 124807 --> https://bugs.documentfoundation.org/attachment.cgi?id=124807=edit Backtrace? Steps to Reproduce(2): 1. Start LibreOffice 2. Create Writer Document 3. And type "0123" in Writer 4. File -> Wizards -> Letter... 5. Appear Letter Wizard dialog 6. Click [X] in Title bar on LibreOffice main window 7. Appear "Save Document?" Dialog, Click a [Don't Save] 8. Click [X] in Title bar on LibreOffice main window, again 7. LibreOffice has close (crash?) 8. Start LibreOffice 9. Appear "Document Recovery" Dialog -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65463] index TOC entry isn't clickable
https://bugs.documentfoundation.org/show_bug.cgi?id=65463 Buovjagachanged: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/protocol.txt
loolwsd/protocol.txt | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) New commits: commit 79968ccefb299fc5915721bdb97f32ac475d164b Author: Tor LillqvistDate: Tue May 3 08:20:54 2016 +0300 Clarify binary vs text frame non-distinction Note that we currently have unit tests that incorrectly (IMHO) require some frames sent by the server to indeed be 'text' ones from the WebSocket perspective. That is an unnecessary restriction. diff --git a/loolwsd/protocol.txt b/loolwsd/protocol.txt index 5f8d780..b6afb37 100644 --- a/loolwsd/protocol.txt +++ b/loolwsd/protocol.txt @@ -1,6 +1,19 @@ All communication consists of messages that are one line of human-readable UTF-8 text (with no terminating newline), optionally -followed by a single newline and binary data. +followed by a single newline and arbitrary (potentialy even binary) +data. + +The WebSocket distinction between 'text' and 'binary' frames has no +meaning for us for messages that don't contain additional binary data; +such messages can be either 'binary' or 'text' from the WebSocket +point of view even if we require them (the single line) to be +UTF-8. In other words, an implementation is free to send such a +single-line message as a WebSocket 'binary' frame, and the receiving +implementation must treat that equally as if it was a 'text' frame. + +The WebSocket protocol says that 'text' frames are to be "interpreted" +as UTF-8, so it is probably best to indeed use 'binary' frames for +messages that contain optional non-UTF-8 data. The protocol is not a request-response one. Messages may be sent in either direction at any time, either in response to some message, or ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/protocol.txt
loolwsd/protocol.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 15e216ff7c7b683cd9c912523e1d04c7180e8022 Author: Tor LillqvistDate: Tue May 3 08:15:06 2016 +0300 Clarify that single-line don't need a newline terminator diff --git a/loolwsd/protocol.txt b/loolwsd/protocol.txt index 22e8682..5f8d780 100644 --- a/loolwsd/protocol.txt +++ b/loolwsd/protocol.txt @@ -1,6 +1,6 @@ All communication consists of messages that are one line of -human-readable UTF-8 text optionally followed by a single newline and -binary data. +human-readable UTF-8 text (with no terminating newline), optionally +followed by a single newline and binary data. The protocol is not a request-response one. Messages may be sent in either direction at any time, either in response to some message, or ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/win
vcl/win/source/gdi/winlayout.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit a55530d7ef9d48299308094ac58c8e9eaa34e3c6 Author: Tim EvesDate: Fri Mar 18 14:19:50 2016 +0700 Fix failure to print when using the D2DWrite path It seems that D2D1DCRenderrTarget cannot bind to a DC on a printer device. Now whenever that attempt to bind the DC fails we run the legacy API path as a fallback. Change-Id: I6ad8d82e5280fd2dcf669310bab0f5bfc23a138a Reviewed-on: https://gerrit.libreoffice.org/23366 Tested-by: Jenkins Reviewed-by: Martin Hosken Reviewed-on: https://gerrit.libreoffice.org/24603 diff --git a/vcl/win/source/gdi/winlayout.cxx b/vcl/win/source/gdi/winlayout.cxx index f5b3a6b..aa42a19 100644 --- a/vcl/win/source/gdi/winlayout.cxx +++ b/vcl/win/source/gdi/winlayout.cxx @@ -3694,7 +3694,11 @@ bool D2DWriteTextOutRenderer::operator ()(WinLayout const , HDC hDC, return false; if (!BindFont(hDC)) -return false; +{ +// If for any reason we can't bind fallback to legacy APIs. +return ExTextOutRenderer()(rLayout, hDC, pRectToErase, pPos, pGetNextGlypInfo); +} + #if 0 // Gather glyph positioning data. std::vector indices; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99276] Writer Graphite fonts (e.g. Linux Libertine G) don't print (blank pages)
https://bugs.documentfoundation.org/show_bug.cgi?id=99276 Tim Eveschanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |tim_e...@sil.org |desktop.org | --- Comment #5 from Tim Eves --- Back ported fix from master branch in commit 1ecd06596a99d4cf36ebcc0e4ee2292d98412eda -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99641] VIEWING
https://bugs.documentfoundation.org/show_bug.cgi?id=99641 --- Comment #1 from jlqu...@optonline.net --- Created attachment 124806 --> https://bugs.documentfoundation.org/attachment.cgi?id=124806=edit Screenshot of window with gray canvas -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99641] New: VIEWING
https://bugs.documentfoundation.org/show_bug.cgi?id=99641 Bug ID: 99641 Summary: VIEWING Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jlqu...@optonline.net Created attachment 124805 --> https://bugs.documentfoundation.org/attachment.cgi?id=124805=edit Load this gives the bug I have a Word doc I'm edit for which the complete canvas is gray - not just the document background. The document is tiny. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99141] Text written in AndikaFrenchTight-R Font disappears when printing
https://bugs.documentfoundation.org/show_bug.cgi?id=99141 Tim Eveschanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=99 ||276 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99207] Graphite fonts render in negative colors
https://bugs.documentfoundation.org/show_bug.cgi?id=99207 Tim Eveschanged: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=99 | |276 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99276] Writer Graphite fonts (e.g. Linux Libertine G) don't print (blank pages)
https://bugs.documentfoundation.org/show_bug.cgi?id=99276 Tim Eveschanged: What|Removed |Added See Also|https://bugs.documentfounda |https://bugs.documentfounda |tion.org/show_bug.cgi?id=99 |tion.org/show_bug.cgi?id=99 |207 |141 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp
loolwsd/DocumentBroker.cpp | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) New commits: commit 431bab28248c8fbfc561c8e5aba530e6c97e8e2d Author: Ashod NakashianDate: Mon May 2 22:58:53 2016 -0400 loolwsd: fix autosave regression Autosave should only save when the user has been idle for a certain time, or the periodic autosave time elapses. The document is considered for autosave only when it's modified. Change-Id: Ia239173ff6636e52c1a2b7e1f6bf9bd6860175ed Reviewed-on: https://gerrit.libreoffice.org/24602 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp index 0d88d75..5dbdf46 100644 --- a/loolwsd/DocumentBroker.cpp +++ b/loolwsd/DocumentBroker.cpp @@ -204,11 +204,11 @@ bool DocumentBroker::autoSave(const bool force, const size_t waitTimeoutMs) } bool sent = false; -if (force || _isModified) +if (force) { sent = sendUnoSave(); } -else +else if (_isModified) { // Find the most recent activity. double inactivityTimeMs = std::numeric_limits::max(); @@ -221,16 +221,11 @@ bool DocumentBroker::autoSave(const bool force, const size_t waitTimeoutMs) const auto timeSinceLastSaveMs = getTimeSinceLastSaveMs(); Log::trace("Time since last save is " + std::to_string((int)timeSinceLastSaveMs) + " ms."); -// There has been some editing since we saved last? -if (inactivityTimeMs < timeSinceLastSaveMs) +// Either we've been idle long enough, or it's auto-save time. +if (inactivityTimeMs >= IdleSaveDurationMs || +timeSinceLastSaveMs >= AutoSaveDurationMs) { -// Either we've been idle long enough, or it's auto-save time. -// Or we are asked to save anyway. -if (inactivityTimeMs >= IdleSaveDurationMs || -timeSinceLastSaveMs >= AutoSaveDurationMs) -{ -sent = sendUnoSave(); -} +sent = sendUnoSave(); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp
loolwsd/LOOLWSD.cpp | 24 1 file changed, 24 insertions(+) New commits: commit 68f24e375afd7ffa36ca4eacd86bc23281dd7fb5 Author: Ashod NakashianDate: Mon May 2 22:57:27 2016 -0400 loolwsd: replenish the child reservoir and cleanup dead ones Change-Id: I705ba01ca6254ff61ddd8ebc1248117b9fec7d20 Reviewed-on: https://gerrit.libreoffice.org/24601 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp index 3c0bdcb..77bdab1 100644 --- a/loolwsd/LOOLWSD.cpp +++ b/loolwsd/LOOLWSD.cpp @@ -177,6 +177,7 @@ static void forkChildren(const int number) } } +/// Called on startup only. static void preForkChildren() { std::unique_lock lock(newChildrenMutex); @@ -186,6 +187,24 @@ static void preForkChildren() forkChildren(numPreSpawn); } +static void prespawnChildren() +{ +std::unique_lock lock(newChildrenMutex); + +for (int i = newChildren.size() - 1; i >= 0; --i) +{ +if (!newChildren[i]->isAlive()) +{ +newChildren.erase(newChildren.begin() + i); +} +} + +const int available = newChildren.size(); +int balance = LOOLWSD::NumPreSpawnedChildren; +balance -= available; +forkChildren(balance); +} + static std::shared_ptr getNewChild() { std::unique_lock lock(newChildrenMutex); @@ -203,6 +222,7 @@ static std::shared_ptr getNewChild() else { balance -= available - 1; // Minus the one we'll dispatch just now. +std::max(balance, 0); } Log::debug("getNewChild: Have " + std::to_string(available) + " children, forking " + std::to_string(balance)); @@ -1593,7 +1613,11 @@ int LOOLWSD::main(const std::vector& /*args*/) last30SecCheck = time(nullptr); } } + sleep(WSD_SLEEP_SECS); + +// Make sure we have sufficient reserves. +prespawnChildren(); } #if ENABLE_DEBUG if (careerSpanSeconds > 0 && time(nullptr) > startTimeSpan + careerSpanSeconds) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99640] New: The character of "/" keyboard does not work to remotely access the VNC and other
https://bugs.documentfoundation.org/show_bug.cgi?id=99640 Bug ID: 99640 Summary: The character of "/" keyboard does not work to remotely access the VNC and other Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: alexandre.pess...@uol.com.br After the 5.0.3 version, began to occur in version 5.0.4 and to 5.1.2 is going to enter the "/" (Bar) accessing remotely via VNC or TeamViewer button does not work and nothing happens -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65463] index TOC entry isn't clickable
https://bugs.documentfoundation.org/show_bug.cgi?id=65463 Paulchanged: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99526] Vertically oriented text becomes horizontal after upgrade to 5.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=99526 --- Comment #9 from Adolfo Jayme--- (In reply to raal from comment #6) > Created attachment 124689 [details] > printscreen from 5.2 > > Version: 5.2.0.0.alpha0+; win7 > > Seems to be fixed with dev version. Note that OP’s screenshot has OpenGL rendering enabled, while yours does not. Maybe the problem lies there? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99446] Garbled text characters / glyphs in some dialogs with open-source radeonsi drivers
https://bugs.documentfoundation.org/show_bug.cgi?id=99446 Adolfo Jaymechanged: What|Removed |Added CC||indelibleblue...@gmail.com --- Comment #8 from Adolfo Jayme --- *** Bug 99636 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99636] Blacked Out Text in Dialog Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=99636 Adolfo Jaymechanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Adolfo Jayme --- *** This bug has been marked as a duplicate of bug 99446 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92902 --- Comment #7 from mrmister001--- Thanks a lot Bastian, I suggested the idea in 2013 and did the video... so if you consider I could help during the design process, please let me know. I would love to collaborate with the design team if they allow me to. :D -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92902 --- Comment #7 from mrmister001--- Thanks a lot Bastian, I suggested the idea in 2013 and did the video... so if you consider I could help during the design process, please let me know. I would love to collaborate with the design team if they allow me to. :D -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Dao Minh Thuc license statement
Dear libre Office team, I'm Dao Minh Thuc, I like to contributions to LibreOffice. All of my past & future contributions to LibreOffice may licensed under the MPLv2/LGPLv3+ dual license. Best Regards, Dao Minh Thuc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92902 --- Comment #6 from Bastián Díaz--- (In reply to mrmister001 from comment #5) > Hi Heiko, > In 2013 I did a video demonstration, and posted it in Youtube. The video is > hidden, so only people knowing the link can access it. > > Here is the video: > https://www.youtube.com/watch?v=LOBjTe-N_-I Wow... I knew what the survey to improve Draw, I was looking for this video because the idea is good. It provides an automated system to create different types of diagrams easily (as does SmartDraw) Thank you for showing again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99531] Visual glitches with compositor and open-source radeonsi drivers
https://bugs.documentfoundation.org/show_bug.cgi?id=99531 Dchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG --- Comment #6 from D --- This problem seems to be associated with selected desktop themes. For reference, I am using the Albatross theme and see this bug there. When I change the theme to Adwaita, the issue disappears! According to their release notes, this should be fixed in Mate 1.14 (for Cinnamon I don't know), which I unfortunately cannot test right now. However, I guess it is safe to consider this bug as resolved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/IoUtil.cpp loolwsd/LOOLWSD.cpp
loolwsd/IoUtil.cpp |3 ++- loolwsd/LOOLWSD.cpp |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit 7d03ebdf85320150b520ac84506fe8318168f6a6 Author: Ashod NakashianDate: Mon May 2 19:53:13 2016 -0400 loolwsd: corrections to terminate SocketProcessor Change-Id: I3b08d1b2f734b8736ed35f667c1ca988490c4fa4 Reviewed-on: https://gerrit.libreoffice.org/24600 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/IoUtil.cpp b/loolwsd/IoUtil.cpp index 5df6dd0..c7abe51 100644 --- a/loolwsd/IoUtil.cpp +++ b/loolwsd/IoUtil.cpp @@ -67,7 +67,8 @@ void SocketProcessor(const std::shared_ptr& ws, break; } -if (!ws->poll(waitTime, Poco::Net::Socket::SELECT_READ)) +if (!ws->poll(waitTime, Poco::Net::Socket::SELECT_READ) || +stopPredicate()) { // Wait some more. continue; diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp index 6f9aee5..3c0bdcb 100644 --- a/loolwsd/LOOLWSD.cpp +++ b/loolwsd/LOOLWSD.cpp @@ -597,7 +597,7 @@ private: return true; }, []() { session->closeFrame(); }, -[]() { return TerminationFlag && queueHandlerThread.isRunning(); }); +[]() { return TerminationFlag || !queueHandlerThread.isRunning(); }); const bool canDestroy = docBroker->canDestroy(); if (canDestroy && !session->_bLoadError) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/TileCache.cpp loolwsd/Util.hpp
loolwsd/DocumentBroker.cpp |2 +- loolwsd/LOOLWSD.cpp|2 +- loolwsd/TileCache.cpp |4 ++-- loolwsd/Util.hpp |7 +++ 4 files changed, 11 insertions(+), 4 deletions(-) New commits: commit 6c57e9be4d9992ef1ab32b667e808c6143936ebf Author: Ashod NakashianDate: Mon May 2 19:17:46 2016 -0400 loolwsd: helper to assert a lock is already taken Change-Id: Id28f7a39a4d45ea6ad391015364467dc8ded3e66 Reviewed-on: https://gerrit.libreoffice.org/24599 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp index 8f50e32..0d88d75 100644 --- a/loolwsd/DocumentBroker.cpp +++ b/loolwsd/DocumentBroker.cpp @@ -253,7 +253,7 @@ bool DocumentBroker::autoSave(const bool force, const size_t waitTimeoutMs) bool DocumentBroker::sendUnoSave() { Log::info("Autosave triggered for doc [" + _docKey + "]."); -assert(!_mutex.try_lock()); +Util::assertIsLocked(_mutex); // Save using session holding the edit-lock for (auto& sessionIt: _sessions) diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp index 5de9afc..6f9aee5 100644 --- a/loolwsd/LOOLWSD.cpp +++ b/loolwsd/LOOLWSD.cpp @@ -167,7 +167,7 @@ static int careerSpanSeconds = 0; static void forkChildren(const int number) { -assert(!newChildrenMutex.try_lock()); // check it is held. +Util::assertIsLocked(newChildrenMutex); if (number > 0) { diff --git a/loolwsd/TileCache.cpp b/loolwsd/TileCache.cpp index 6d42158..856c684 100644 --- a/loolwsd/TileCache.cpp +++ b/loolwsd/TileCache.cpp @@ -89,7 +89,7 @@ std::shared_ptr TileCache::findTileBeingRendered(i { const std::string cachedName = cacheFileName(part, width, height, tilePosX, tilePosY, tileWidth, tileHeight); -assert(!_tilesBeingRenderedMutex.try_lock()); +Util::assertIsLocked(_tilesBeingRenderedMutex); const auto tile = _tilesBeingRendered.find(cachedName); return (tile != _tilesBeingRendered.end() ? tile->second : nullptr); @@ -99,7 +99,7 @@ void TileCache::forgetTileBeingRendered(int part, int width, int height, int til { const std::string cachedName = cacheFileName(part, width, height, tilePosX, tilePosY, tileWidth, tileHeight); -assert(!_tilesBeingRenderedMutex.try_lock()); +Util::assertIsLocked(_tilesBeingRenderedMutex); assert(_tilesBeingRendered.find(cachedName) != _tilesBeingRendered.end()); _tilesBeingRendered.erase(cachedName); diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp index 00cf54c..28cdb94 100644 --- a/loolwsd/Util.hpp +++ b/loolwsd/Util.hpp @@ -56,6 +56,13 @@ namespace Util int bufferWidth, int bufferHeight, std::vector& output, LibreOfficeKitTileMode mode); +/// Assert that a lock is already taken. +template +void assertIsLocked(T& lock) +{ +assert(!lock.try_lock()); +} + /// Safely remove a file or directory. /// Supresses exception when the file is already removed. /// This can happen when there is a race (unavoidable) or when ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/test
loolwsd/test/Makefile.am |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cf717152a75261ebf53753f2ccd98a20ef5de5eb Author: Ashod NakashianDate: Mon May 2 19:04:16 2016 -0400 loolwsd: bin_PROGRAMS -> noinst_PROGRAMS Change-Id: Idfcfc9d21edafd094aa7c50b300b298e1ddfe6f5 Reviewed-on: https://gerrit.libreoffice.org/24598 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am index 2587cec..c36cc2a 100644 --- a/loolwsd/test/Makefile.am +++ b/loolwsd/test/Makefile.am @@ -1,7 +1,7 @@ AUTOMAKE_OPTION = serial-tests check_PROGRAMS = test -bin_PROGRAMS = test +noinst_PROGRAMS = test AM_CXXFLAGS = $(CPPUNIT_CFLAGS) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99594] Cannot update my Libre Office 4.4.5.2 to 5.1.2.2
https://bugs.documentfoundation.org/show_bug.cgi?id=99594 Adolfo Jaymechanged: What|Removed |Added Component|General |Installation Product|QA Tools|LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92902] Enhancement Request: Auto-Layout for flowcharts and automatic flowcharts from Calc / Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=92902 --- Comment #5 from mrmister001--- Hi Heiko, In 2013 I did a video demonstration, and posted it in Youtube. The video is hidden, so only people knowing the link can access it. Here is the video: https://www.youtube.com/watch?v=LOBjTe-N_-I Please, share the video with the design team. In the video I suggest an integrative solution, with a window called "Automation". The window basically do what you describe, it handles lists, which are considered tags... and it connect tags. Also it is able to apply a different formating to the automation process. This demonstration is even years ahead of yED. It is quite better, because give you so much control of the diagram, making true automation in seconds. I guess you are very busy, but please, I would love if you could grab 10 minutes, just to see the half of it, in which the feature is described. It shows an approach very similar to the one you have in mind, I think. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99582] wrong windows's icon in gnome in child windows
https://bugs.documentfoundation.org/show_bug.cgi?id=99582 --- Comment #3 from Adolfo Jayme--- Are you sure this is a LibreOffice problem? Apparently you’ve installed some GNOME Shell extension that is doing that… -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] Meta: HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Adolfo Jaymechanged: What|Removed |Added Depends on||99508 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99508] HiDPI scaling broken on Wayland with GTK3
https://bugs.documentfoundation.org/show_bug.cgi?id=99508 Adolfo Jaymechanged: What|Removed |Added Blocks||90796 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99628] SVG insert filter -- support for Flowed Text
https://bugs.documentfoundation.org/show_bug.cgi?id=99628 --- Comment #9 from V Stuart Foote--- Thanks Regina. Unfortunately, the Inkscape project got out in front of the SVG 1.2 Full and implemented the Flowed Text proposals--then apparently skipped the SVG 1.2 Tiny handling of textArea. Meaning a lot of SVGs generated in Inkscape come into LibreOffice with the structures--e.g. the day of week lettering in the rectangular boxes on the calendar testcase SVG here--that for bug 50114 we simply ignore, guaranteeing broken rendering for SVGs coming from Inkscape. Is anyone plugged in to what Inkscape is considering? And we probably should have been parsing the Inkscape flowed text structure in solidarity with them (at least until they abandon it and move forward with whatever the W3C publishes as SVG 2). Seems the question now for LibreOffice becomes: should we continue to ignore the Inkscape Flowed Text images, or figure a way to parse them to canvas and convert them to SVG 1.1 text when saved or exported, or to implement Inkscape's methods and retain the source SVG. Then going forward, presumably implement the SVG 2 recommendations (either the content area & wrapping area of 10.5 [1], or figure out what to do with the the HTML5/CSS3 centric text "flows" through Exclusions or Regions [2]) and *how* to push this back out as compliant ODF. See some ugliness coming in chasing the emerging SVG "standards" =-as an aside-= Is there guidance from OASIS on where to take ODF as W3C drives content towards HTML5.1 and CSS3? It is a bit alarming in that many of the accessibility requirements (e.g. US Section 508, or European Standard EN 301 549) that apply to LibreOffice as a "user agent for authoring & media delivery" derive from the W3C's WCAG 2.0 [3] perspective--not from OASIS ODF standards. We are required by statute in many locations to be functionally compliant with the WCAG 2.0/UAAG 2.0 [4] guidelines. =-refs-= [1] https://www.w3.org/TR/SVG2/text.html#TextLayout [2] https://www.w3.org/Graphics/SVG/WG/wiki/SVG2_Requirements_Mailing_List_Feedback#Text_flow_to_arbitrary_shapes [3] Web Content Accessibility Guidelines - WCAG 2.0 [4] User Agent Accessibility Guidelines - UAAG 2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63229] Hyperlink in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=63229 Adolfo Jaymechanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81741] "Orientation" should be a button, not a menu
https://bugs.documentfoundation.org/show_bug.cgi?id=81741 Adolfo Jaymechanged: What|Removed |Added Keywords||needsDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60558] Microsoft 10 file will not open correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=60558 Adolfo Jaymechanged: What|Removed |Added Keywords||filter:docx -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/shared/optionen/01011000.xhp |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) New commits: commit 7baa265c995f1d27cef325bf1583a579737e11df Author: Adolfo Jayme BarrientosDate: Mon May 2 17:40:31 2016 -0500 tdf#99637 Donât mention Undo settings now in Expert Configuration Change-Id: I5a6c8a193a1f80683a79e1e1b255d67586493a6e diff --git a/source/text/shared/optionen/01011000.xhp b/source/text/shared/optionen/01011000.xhp index df3d394..21fc92f 100644 --- a/source/text/shared/optionen/01011000.xhp +++ b/source/text/shared/optionen/01011000.xhp @@ -30,22 +30,17 @@ -undoing; number of steps graphics; cache cache for graphics Quickstarter Memory -Defines the settings for the graphics cache and the number of steps you can undo. +This tab page lets you define various settings for the graphics cache. -Undo -Defines the maximum number of reverse steps allowed. -Number of steps -You can specify the number of steps which can be undone by selecting a number from the box. Graphics cache The graphics cache saves the graphics contained in a document in your computer's main memory. This means that the attributes of a graphic stored in the cache do not have to be re-calculated if you return to the page containing the graphic after scrolling through a document. Use for $[officename] (MB) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fa6efd4511a999618fd3958c1c72811dc0ef83ee Author: Adolfo Jayme BarrientosDate: Mon May 2 17:40:31 2016 -0500 Updated core Project: help 7baa265c995f1d27cef325bf1583a579737e11df tdf#99637 Donât mention Undo settings now in Expert Configuration Change-Id: I5a6c8a193a1f80683a79e1e1b255d67586493a6e diff --git a/helpcontent2 b/helpcontent2 index 743ed49..7baa265 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 743ed49ef0759b6cbd65d707ae9b8bba90e81a4d +Subproject commit 7baa265c995f1d27cef325bf1583a579737e11df ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help
https://bugs.documentfoundation.org/show_bug.cgi?id=99637 Adolfo Jaymechanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Component|LibreOffice |Documentation Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |f...@libreoffice.org |desktop.org | --- Comment #1 from Adolfo Jayme --- Sure, but please refrain from attacking contributors — that never helps, I’d say… -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/fixes20' -
0 files changed New commits: commit 9474aa6b3661f94169db0bcbe3d4e07c83019429 Author: László NémethDate: Tue May 3 00:37:01 2016 +0200 empty commit (process idle) Change-Id: I644f8d763a4df8ff3a68a1d99e129b99cab319d9 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99639] Basic Document - Interoperability (Loss of Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=99639 Joel Maderochanged: What|Removed |Added Whiteboard||interoperability -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99639] Basic Document - Interoperability (Loss of Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=99639 --- Comment #2 from Joel Madero--- Created attachment 124804 --> https://bugs.documentfoundation.org/attachment.cgi?id=124804=edit PDF Output (MSOffice 2013) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99639] Basic Document - Interoperability (Loss of Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=99639 Joel Maderochanged: What|Removed |Added CC||jmadero@gmail.com --- Comment #1 from Joel Madero --- Created attachment 124803 --> https://bugs.documentfoundation.org/attachment.cgi?id=124803=edit Original File (Docx) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99639] New: Basic Document - Interoperability (Loss of Formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=99639 Bug ID: 99639 Summary: Basic Document - Interoperability (Loss of Formatting) Product: LibreOffice Version: 5.1.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Created attachment 124802 --> https://bugs.documentfoundation.org/attachment.cgi?id=124802=edit Original File (ODT) Windows 7 Bodhi Moksha LibreOffice 5.1.2.2 & MS Office 2013 I wrote an incredibly basic paper over the past few days with zero styles used, just bold, underline, one size font (12 Times New Roman). Because there was a page limit on the paper I had to pay close attention (and cut out substantial portions) to hit the limit. After writing the entire document in LibreOffice, I booted into Windows and opened both the odt and the docx only to find out that the 10 pages shown in LibreOffice became just over 9 pages in MS Office. I lost a substantial amount of work (cut out because I thought I was over the limit) and time (trying to add back what I had stripped out) because of this. For a document that has zero funky things going on - 1" margins, single font with a single size, a little direct formatting (bold/underline/italics) I had assumed perfect interop. I am attaching the original odt, the original docx, pdfs of both LibreOffice and Microsoft Office. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99619] Base crash when undo redo
https://bugs.documentfoundation.org/show_bug.cgi?id=99619 Julien Nabetchanged: What|Removed |Added CC||sberg...@redhat.com --- Comment #3 from Julien Nabet --- I tried to understand the problem of bt I had and noticed this new bt: #0 com::sun::star::uno::BaseReference::iquery (pInterface=0x2bacd08, rType=invalid uno::Type) at /home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.hxx:54 #1 0x2aaad9c3cd18 in com::sun::star::uno::Reference::iquery (pInterface=0x2bacd08) at /home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.hxx:69 #2 0x2aaad9c39fa5 in com::sun::star::uno::Reference::Reference (this=0x7fff3a90, rRef=...) at /home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.hxx:170 #3 0x2aaad9e127c6 in dbaui::OJoinExchObj::GetSourceDescription (_rxObject=uno::Reference to (GtkDnDTransferable *) 0x2bacd08) at /home/julien/lo/libreoffice/dbaccess/source/ui/querydesign/JoinExchange.cxx:76 #4 0x2aaad9ea2330 in dbaui::OTableWindowListBox::ExecuteDrop (this=0x3f66cc0, _rEvt=...) at /home/julien/lo/libreoffice/dbaccess/source/ui/querydesign/TableWindowListBox.cxx:308 Stephan: any thoughts? (openjdk version "1.8.0_91" OpenJDK Runtime Environment (build 1.8.0_91-8u91-b14-2-b14) OpenJDK 64-Bit Server VM (build 25.91-b14, mixed mode) ) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99619] Base crash when undo redo
https://bugs.documentfoundation.org/show_bug.cgi?id=99619 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- Created attachment 124801 --> https://bugs.documentfoundation.org/attachment.cgi?id=124801=edit bt with symbols On pc Debian x86-64 with master sources updated today, I had a crash when I tried to a create the join at the beginning. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38760] Multiple data series cannot support multiple labels in X-Y plot
https://bugs.documentfoundation.org/show_bug.cgi?id=38760 --- Comment #23 from Regina Henschel--- Created attachment 124800 --> https://bugs.documentfoundation.org/attachment.cgi?id=124800=edit Two data series with different labels As workaround you can define each data series on the whole x-range and leave the y cells empty for those x-values, which do not belong to the series. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99626] Crash a LibreOffice when close main window with Wizard dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=99626 Julien Nabetchanged: What|Removed |Added Keywords||wantBacktrace CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this (nor with LO Debian package 5.1.2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99635] Calc, Missing Text in cells in print preview and printing
https://bugs.documentfoundation.org/show_bug.cgi?id=99635 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- Please give a try to last stable version 5.1.2 If you still reproduce this: 1) rename your LO directory profile (see https://wiki.documentfoundation.org/UserProfile#Windows) 2) Attach an example doc so we can give it a try (have a look at this page first: https://wiki.documentfoundation.org/QA/Bugzilla/Sanitizing_Files_Before_Submission) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99634] UI: wrong word function instead of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=99634 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||serval2...@yahoo.fr Component|Calc|ux-advise Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. ux-team: any thoughts? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 99634] UI: wrong word function instead of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=99634 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||serval2...@yahoo.fr Component|Calc|ux-advise Ever confirmed|0 |1 --- Comment #2 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. ux-team: any thoughts? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 98644] REMOTE FILE: "The specified device is invalid." error dialog appears when wrong password entered
https://bugs.documentfoundation.org/show_bug.cgi?id=98644 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.2.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98644] REMOTE FILE: "The specified device is invalid." error dialog appears when wrong password entered
https://bugs.documentfoundation.org/show_bug.cgi?id=98644 --- Comment #2 from Commit Notification--- Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f88554edd46d2dc8d6c8eaba74c89ccd3e537104 Related tdf#98644: In login dialog, give a hint that the password was wrong It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96815] HELP: '?' inserts whitespace in number format
https://bugs.documentfoundation.org/show_bug.cgi?id=96815 --- Comment #4 from Laurent BP--- (In reply to Johannes Pfrang [:johnp] from comment #3) > Put 0.5 in a cell and format it as '# #/#'. The 1/2 will have a leading > whitespace in front of it, because the integer zero gets omitted, while the > whitespace stays. Your example is not good because whitespace is unconditionally defined in the format, so it has to be displayed. There is no whitespace with format [<=-1]# #/#;[>=1]# #/#;#/# -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: uui/source uui/uiconfig
uui/source/logindlg.cxx| 38 ++ uui/source/logindlg.hxx|5 - uui/uiconfig/ui/logindialog.ui | 28 3 files changed, 58 insertions(+), 13 deletions(-) New commits: commit f88554edd46d2dc8d6c8eaba74c89ccd3e537104 Author: Stephan BergmannDate: Mon May 2 23:20:11 2016 +0200 Related tdf#98644: In login dialog, give a hint that the password was wrong ...by changing the dialog text from "Enter user name and password for..." to "Wrong user name and password for..." when an old password is already given. Change-Id: Ie167c5ea263e9f75e0269c528dc88b69270208f3 diff --git a/uui/source/logindlg.cxx b/uui/source/logindlg.cxx index 8cf4e58..740c847 100644 --- a/uui/source/logindlg.cxx +++ b/uui/source/logindlg.cxx @@ -61,6 +61,12 @@ void LoginDialog::dispose() ModalDialog::dispose(); } +void LoginDialog::SetPassword( const OUString& rNew ) +{ +m_pPasswordED->SetText( rNew ); +SetRequest(); +} + void LoginDialog::HideControls_Impl( sal_uInt16 nFlags ) { if ( ( nFlags & LF_NO_PATH ) == LF_NO_PATH ) @@ -128,6 +134,23 @@ void LoginDialog::EnableUseSysCredsControls_Impl( bool bUseSysCredsEnabled ) m_pAccountED->Enable( !bUseSysCredsEnabled ); } +void LoginDialog::SetRequest() +{ +bool oldPwd = !m_pPasswordED->GetText().isEmpty(); +OUString aRequest; +if (m_pAccountFT->IsVisible() && !m_realm.isEmpty()) +{ +aRequest = get(oldPwd ? "wrongloginrealm" : "loginrealm") +->GetText(); +aRequest = aRequest.replaceAll("%2", m_realm); +} +else +aRequest = get(oldPwd ? "wrongrequestinfo" : "requestinfo") +->GetText(); +aRequest = aRequest.replaceAll("%1", m_server); +m_pRequestInfo->SetText(aRequest); +} + IMPL_LINK_NOARG_TYPED(LoginDialog, OKHdl_Impl, Button*, void) { // trim the strings @@ -165,7 +188,8 @@ IMPL_LINK_NOARG_TYPED(LoginDialog, UseSysCredsHdl_Impl, Button*, void) LoginDialog::LoginDialog(vcl::Window* pParent, sal_uInt16 nFlags, const OUString& rServer, const OUString& rRealm) -: ModalDialog(pParent, "LoginDialog", "uui/ui/logindialog.ui") +: ModalDialog(pParent, "LoginDialog", "uui/ui/logindialog.ui"), + m_server(rServer), m_realm(rRealm) { get(m_pErrorFT, "errorft"); get(m_pErrorInfo, "errorinfo"); @@ -183,20 +207,10 @@ LoginDialog::LoginDialog(vcl::Window* pParent, sal_uInt16 nFlags, get(m_pUseSysCredsCB, "syscreds"); get(m_pOKBtn, "ok"); -OUString aRequest; -if ((nFlags & LF_NO_ACCOUNT) != 0 && !rRealm.isEmpty()) -{ -aRequest = get("loginrealm")->GetText(); -aRequest = aRequest.replaceAll("%2", rRealm); -} -else -aRequest = m_pRequestInfo->GetText(); - if ( !( ( nFlags & LF_NO_USESYSCREDS ) == LF_NO_USESYSCREDS ) ) EnableUseSysCredsControls_Impl( m_pUseSysCredsCB->IsChecked() ); -aRequest = aRequest.replaceAll("%1", rServer); -m_pRequestInfo->SetText(aRequest); +SetRequest(); m_pPathED->SetMaxTextLen( _MAX_PATH ); m_pNameED->SetMaxTextLen( _MAX_PATH ); diff --git a/uui/source/logindlg.hxx b/uui/source/logindlg.hxx index 567c401..e5e7d98 100644 --- a/uui/source/logindlg.hxx +++ b/uui/source/logindlg.hxx @@ -55,9 +55,12 @@ class LoginDialog : public ModalDialog VclPtr m_pSavePasswdBtn; VclPtr m_pUseSysCredsCB; VclPtr m_pOKBtn; +OUString m_server; +OUString m_realm; voidHideControls_Impl( sal_uInt16 nFlags ); voidEnableUseSysCredsControls_Impl( bool bUseSysCredsEnabled ); +voidSetRequest(); DECL_LINK_TYPED(OKHdl_Impl, Button*, void); DECL_LINK_TYPED(PathHdl_Impl, Button*, void); @@ -72,7 +75,7 @@ public: OUStringGetName() const { return m_pNameED->GetText(); } voidSetName( const OUString& rNewName ) { m_pNameED->SetText( rNewName ); } OUStringGetPassword() const { return m_pPasswordED->GetText(); } -voidSetPassword( const OUString& rNew ) { m_pPasswordED->SetText( rNew ); } +voidSetPassword( const OUString& rNew ); OUStringGetAccount() const { return m_pAccountED->GetText(); } boolIsSavePassword() const { return m_pSavePasswdBtn->IsChecked(); } voidSetSavePassword( bool bSave ) { m_pSavePasswdBtn->Check( bSave ); } diff --git a/uui/uiconfig/ui/logindialog.ui b/uui/uiconfig/ui/logindialog.ui index ca47ea5..806d8f5 100644 --- a/uui/uiconfig/ui/logindialog.ui +++ b/uui/uiconfig/ui/logindialog.ui @@ -251,6 +251,34 @@ + +False +True +0 +Wrong user name and
[Libreoffice-bugs] [Bug 99599] Wizards don't work in File menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99599 Julien Nabetchanged: What|Removed |Added CC||caol...@redhat.com --- Comment #3 from Julien Nabet --- Thank you Terrence for the bibisect! I noticed that bug only happen with SAL_USE_VCLPLUGIN=gtk3 not with SAL_USE_VCLPLUGIN=gtk or with SAL_USE_VCLPLUGIN=gen Caolan: I've reverted locally https://cgit.freedesktop.org/libreoffice/core/commit/?id=66db55aa84e8401a9eccedb02c67150833a344ba and I don't reproduce this bug. Thought you might be interested in this one. Here are my gtk info: julien@debian:~/lo/libreoffice/instdir/program$ dpkg -l libgtk* | grep -e '^i' | grep -e 'libgtk-*[0-9]' ii libgtk-3-0:amd64 3.18.9-1 amd64GTK+ graphical user interface library ii libgtk-3-bin 3.18.9-1 amd64programs for the GTK+ graphical user interface library ii libgtk-3-common 3.18.9-1 all common files for the GTK+ graphical user interface library ii libgtk-3-dev:amd64 3.18.9-1 amd64development files for the GTK+ library ii libgtk2-perl 2:1.2498-1amd64Perl interface to the 2.x series of the Gimp Toolkit library ii libgtk2.0-0:amd642.24.30-1.1 amd64GTK+ graphical user interface library ii libgtk2.0-bin2.24.30-1.1 amd64programs for the GTK+ graphical user interface library ii libgtk2.0-common 2.24.30-1.1 all common files for the GTK+ graphical user interface library ii libgtk2.0-dev2.24.30-1.1 amd64development files for the GTK+ library -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51096] Allow User to Select External Image Editing Tool
https://bugs.documentfoundation.org/show_bug.cgi?id=51096 Philchanged: What|Removed |Added Severity|enhancement |normal --- Comment #3 from Phil --- Until this bug/enhancement request is assigned and solved (first report was 4 years ago) it would be less confusing for users to not have the Option "Edit with external tool..." in the pop-up menu since LO uses the system default association for the image. And that is usually an image _viewer_ and not an editor. So I suggest the menu option to read "View with external program" or "Use external default program" or something of that sort. _Until_ the edit option actually works. Also, once someone is at it, he/she could place the three dots separate from the last word. Not only it suggests that the user is going to be be given a menu to choose from but also gives a poor impression of the program, it simply looks awful. Thank you to whoever can fix it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98258] tabs option missing sometimes fin format paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=98258 Buovjagachanged: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG --- Comment #4 from Buovjaga --- You can open a new report for component Documentation explaining, what you want improved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99599] Wizards don't work in File menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99599 Terrence Engerchanged: What|Removed |Added Keywords|bibisectRequest |bibisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98804] table number format alignment issues
https://bugs.documentfoundation.org/show_bug.cgi?id=98804 Buovjagachanged: What|Removed |Added Keywords||needAdvice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99599] Wizards don't work in File menu
https://bugs.documentfoundation.org/show_bug.cgi?id=99599 Terrence Engerchanged: What|Removed |Added CC||lo_b...@iseries-guru.com --- Comment #2 from Terrence Enger --- Created attachment 124799 --> https://bugs.documentfoundation.org/attachment.cgi?id=124799=edit bibisect output, daily Linux dbgutil repository Working in the daily Linux dbgutil bibisect repository, I have narrowed down introduction of the bug ... commit date s-h --- -- --- good 8936e6d 2016-03-15 885eb42 bad 2b807c4 2016-03-16 53f645a This covers 37 source commits. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99638] New: Attaching listeners makes LibreOffice freeze
https://bugs.documentfoundation.org/show_bug.cgi?id=99638 Bug ID: 99638 Summary: Attaching listeners makes LibreOffice freeze Product: LibreOffice Version: 5.1.2.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: sdk Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lucas.cu...@softexpert.com I'm using Java UNO API to open documents via LibreOffice. The problem is that when I try to attach a listener to XTopWindow for example, LibreOffice hangs forever and I have to kill soffice via task manager. Looks like that when I had my jar in ${JAVA_INSTALL_PATH}/jre/lib/ext, it worked. As soon as I deleted the jar and modified my code to add LibreOffice install path to class path at runtime, it stopped working. I'm using juh-3.2.1.jar, jurt-3.2.1.jar, ridl-3-2-1.jar and unoil-3.2.1.jar from maven repository. Here is my code: - Main.java package com.office.test; import java.io.File; import java.lang.reflect.Method; import java.net.MalformedURLException; import java.net.URL; import java.net.URLClassLoader; import java.util.Properties; public class Main { public static void main(String[] args) { Main m = new Main(); try { m.start(); } catch (Exception e) { e.printStackTrace(); } } public void start() throws Exception { String officePath = "C:\\Program Files (x86)\\LibreOffice 5\\program"; String filePath = "file:///C:\\Docs\\test.doc"; URLClassLoader loader = new URLClassLoader(new URL[] { new File(officePath).toURI().toURL() }); try { addToClassPath(officePath); } catch (Exception e) { e.printStackTrace(); } Launcher launcher = new Launcher(loader, filePath); launcher.start(); } public static void addToClassPath(String s) throws Exception { File f = new File(s); URL u = f.toURL(); URLClassLoader urlClassLoader = (URLClassLoader) ClassLoader.getSystemClassLoader(); Class urlClass = URLClassLoader.class; Method method = urlClass.getDeclaredMethod("addURL", new Class[]{URL.class}); method.setAccessible(true); method.invoke(urlClassLoader, new Object[]{u}); } } Launcher.java package com.office.test; import java.net.URLClassLoader; import com.sun.star.awt.XTopWindow; import com.sun.star.awt.XTopWindowListener; import com.sun.star.beans.PropertyValue; import com.sun.star.frame.XComponentLoader; import com.sun.star.frame.XDesktop; import com.sun.star.lang.EventObject; import com.sun.star.lang.XComponent; import com.sun.star.lang.XMultiComponentFactory; import com.sun.star.lang.XMultiServiceFactory; import com.sun.star.uno.UnoRuntime; import com.sun.star.uno.XComponentContext; public class Launcher { private URLClassLoader loader; private String filePath; private XComponentContext xContext; private XMultiComponentFactory xMCF; private XMultiServiceFactory xConfigProvider; private XComponent xComponent; private XDesktop xDesktop; public Launcher(URLClassLoader loader, String filePath) { this.loader = loader; this.filePath = filePath; } public void launch() { boolean readOnly = false; PropertyValue[] props = this.getProperties(readOnly); try { Bootstrap bootstrap = new Bootstrap(); this.xContext = bootstrap.bootstrap(loader); this.xMCF = this.xContext.getServiceManager(); final Object configProvider = this.xMCF.createInstanceWithContext("com.sun.star.configuration.ConfigurationProvider", this.xContext); this.xConfigProvider = (XMultiServiceFactory) UnoRuntime.queryInterface(XMultiServiceFactory.class, configProvider); final Object desktop = this.xMCF.createInstanceWithContext("com.sun.star.frame.Desktop", this.xContext); this.xDesktop = (XDesktop) UnoRuntime.queryInterface(XDesktop.class, desktop); final XComponentLoader xComponentLoader = (XComponentLoader) UnoRuntime.queryInterface(XComponentLoader.class, desktop); this.xComponent = xComponentLoader.loadComponentFromURL(filePath, "_default", 0, props); XTopWindow topWindow = (XTopWindow) UnoRuntime.queryInterface(XTopWindow.class, this.xDesktop.getCurrentFrame().getContainerWindow()); topWindow.addTopWindowListener(new XTopWindowListener() { @Override public void disposing(EventObject arg0) { } @Override public void windowOpened(EventObject arg0) { } @Override public void windowNormalized(EventObject arg0) { } @Override
[Libreoffice-bugs] [Bug 98258] tabs option missing sometimes fin format paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=98258 --- Comment #3 from kengra...@yahoo.com --- you can close this bug also. i discovered that when selecting a column within a table that includes cells or data within those cells which are formatted differently the tabs option is not present. this is closely related to other issues I've encountered with tables. hopefully you can refer all of my "bug" reports tothe documentation folks. thanks ken -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99628] SVG insert filter -- support for Flowed Text
https://bugs.documentfoundation.org/show_bug.cgi?id=99628 --- Comment #8 from Regina Henschel--- Oops, wrong link, look here https://www.w3.org/TR/SVG12/. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94977] Calc: Decimal number parsing when importing CSV -- function of US English labeled filter needs to be clear (comment 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=94977 Laurent BPchanged: What|Removed |Added CC||jumbo4...@yahoo.fr Hardware|x86-64 (AMD64) |All Version|5.0.0.5 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99628] SVG insert filter -- support for Flowed Text
https://bugs.documentfoundation.org/show_bug.cgi?id=99628 Regina Henschelchanged: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #7 from Regina Henschel --- Please notice the sentence "Replacement of the previous flowing text proposal with a superset of the SVG 1.2 Tiny textArea feature." in https://www.w3.org/TR/SVG2/. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96815] HELP: '?' inserts whitespace in number format
https://bugs.documentfoundation.org/show_bug.cgi?id=96815 --- Comment #3 from Johannes Pfrang [:johnp]--- I agree with the first one ('# ?/?') setting the length of the dividend/divisor to a fixed value being an undocumented feature, but the single non-removable whitespace between the integer and the fraction part is a bug to me. Put 0.5 in a cell and format it as '# #/#'. The 1/2 will have a leading whitespace in front of it, because the integer zero gets omitted, while the whitespace stays. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93946] there are frame wrap issues with multiple frames anchored to page within a multi column page.
https://bugs.documentfoundation.org/show_bug.cgi?id=93946 --- Comment #8 from kengra...@yahoo.com --- please close this bug as it has either been fixed or another of my work arounds have eliminated the issue. keng -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84394] FILESAVE: picture in imported XLS file is not saved correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=84394 --- Comment #12 from Giuseppe Bilotta--- For what it's worth, I proposed a partial fix in https://gerrit.libreoffice.org/#/c/24292/ The fix is only partial because it fixes the XLS-specific issue of importing nested groups, but not the anchoring issue (which seems to be more general, and affects other formats as well). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99633] Some of my saved LibreOffice files start blinking off and on every 2 - 3 seconds. Why?
https://bugs.documentfoundation.org/show_bug.cgi?id=99633 MMchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from MM --- You don't give much details about which system you're on, which version of LO you've been running and which files are blinking. But could it be the same problem as bug 92045 ??? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96815] HELP: '?' inserts whitespace in number format
https://bugs.documentfoundation.org/show_bug.cgi?id=96815 Laurent BPchanged: What|Removed |Added Summary|FORMATTING: Integers in |HELP: '?' inserts |fraction format have|whitespace in number format |trailing whitespace | |attached| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96815] FORMATTING: Integers in fraction format have trailing whitespace attached
https://bugs.documentfoundation.org/show_bug.cgi?id=96815 Laurent BPchanged: What|Removed |Added CC||jumbo4...@yahoo.fr Component|Calc|Documentation Version|3.5.0 release |Inherited From OOo --- Comment #2 from Laurent BP --- It is an undocumented feature. This Help page should be improved: https://help.libreoffice.org/Common/Number_Format_Codes#Decimal_Places_and_Significant_Digits -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98804] table number format alignment issues
https://bugs.documentfoundation.org/show_bug.cgi?id=98804 --- Comment #8 from kengra...@yahoo.com --- re comment #6 by bouvjaga. i agree that this may not be a bug. it is perhaps a hopelessly inadequate documentation of how to eliminate leading zeroes & trailing decimal zeroes within a column of cells. the intent is to retain decimal alignment without using spaces (which changes the contents from number to text)so that calc like functions can be applied to that column. the 4.2 book & on line help do not. I've tried to clear direct formatting to the cells & later to the content of those cells. then format paragraph & a counter intuitive decimal. then table number format. all to no avail. thus i have to abandon my calc intentions & you can close this "bug" as resolved re my comment#6 like most of my issues with LO, a new work around is to move to a different page & then return which fixes the problem as does moving the frame containing the table in question. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98804] table number format alignment issues
https://bugs.documentfoundation.org/show_bug.cgi?id=98804 --- Comment #7 from kengra...@yahoo.com --- re comment #6 by bouvjaga. i agree that this may not be a bug. it is perhaps a hopelessly inadequate documentation of how to eliminate leading zeroes & trailing decimal zeroes within a column of cells. the intent is to retain decimal alignment without using spaces (which changes the contents from number to text)so that calc like functions can be applied to that column. the 4.2 book & on line help do not. I've tried to clear direct formatting to the cells & later to the content of those cells. then format paragraph & a counter intuitive decimal. then table number format. all to no avail. thus i have to abandon my calc intentions & you can close this "bug" as resolved re my comment#6 like most of my issues with LO, a new work around is to move to a different page & then return which fixes the problem as does moving the frame containing the table in question. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87790] Unexpected values in evaluating R2 using regr.lin (linear fit)
https://bugs.documentfoundation.org/show_bug.cgi?id=87790 Laurent BPchanged: What|Removed |Added Status|NEW |RESOLVED CC||jumbo4...@yahoo.fr Resolution|--- |NOTABUG --- Comment #12 from Laurent BP --- As GerardF said, it is not a bug. R² must not be calculated in the same in case intercept is forced. See bug 73374 and document attachment 91622 for details. Excel may have bug, and may also correct its error. With Excel 2010 and your data, I get R²=0,987462189 and R²=0,9874623358 with LibO 5.1.3.1. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89264] FILEOPEN: performance problem with particular xlsx file
https://bugs.documentfoundation.org/show_bug.cgi?id=89264 Buovjagachanged: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89264] FILEOPEN: performance problem with particular xlsx file
https://bugs.documentfoundation.org/show_bug.cgi?id=89264 --- Comment #6 from Buovjaga--- Created attachment 124798 --> https://bugs.documentfoundation.org/attachment.cgi?id=124798=edit Callgrind with 5.2 Arch Linux 64-bit, KDE Plasma 5 Version: 5.2.0.0.alpha1+ Build ID: 540fee2dc7553152914f7f1d8a41921e765087ef CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; Locale: fi-FI (fi_FI.UTF-8) Built on April 30th 2016 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99625] TEXTJOIN returns wrongly an array when "text argument" is a CSE array.
https://bugs.documentfoundation.org/show_bug.cgi?id=99625 --- Comment #5 from Dennis Roczek--- 1) Excel Online is crap. I really do not understand how that web app should replace the "fat client" (as some managers and CEOs think) 2) Excel is crap. I do want to switch to English function names! This is such a big plus in LibreOffice Calc! 3) You cannot "convert" an existing ODS to an XLSX file. You can save the open file under another name (save a copy) but not to save it under a different file format. But always a big yellow fat warning about incompatibilities... -.- 4) Warning that the formula is incorrect. Well ok, but WHAT PART of the formula? Errr. Crap. 5) I will retry that tomorrow. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92307] FORMATTING: Changing case when all cells are selected does not take effect
https://bugs.documentfoundation.org/show_bug.cgi?id=92307 Laurent BPchanged: What|Removed |Added Keywords||regression CC||jumbo4...@yahoo.fr Version|4.4.1.2 release |4.2.0.4 release --- Comment #4 from Laurent BP --- Not reproduced with: - Version: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 - Version: 4.1.6.2 Build ID: 40ff705089295be5be0aae9b15123f687c05b0a Confirmed with: - Version: 4.2.0.0.alpha0+ Build ID: 4ba92ec1d565848c86c5e802b30f17862ad6505f-2013-06-27 - Version: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 - Version: 4.3.0.1 Build ID: 67f5430184326974072b65403ef1d9d934fc4481 - Version: 5.0.6.1 (x64) Build ID: 4ce937670f417d473bfbb3d9ddf30aa5a524fb53 Locale : fr-FR (fr_FR) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62717] FILESAVE: Names Master pages are not saved properly - all change to -#
https://bugs.documentfoundation.org/show_bug.cgi?id=62717 --- Comment #33 from Cor Nouws--- (In reply to Alexis PAQUIN from comment #32) > Anyone have any something to tell about this ? Hi Alexis, Apparently not. And please realize that just looking and saying something useful may be very expensive. See the "Solving arbitrary problems..." presentation in this blog http://www.gnome.org/~michael/blog/2016-04-29.html. Ciao - Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98255] Excel keyboard shortcut bindings for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=98255 --- Comment #7 from Cor Nouws--- (In reply to Yousuf (Jay) Philips from comment #0) > After learning about the ability to use the OO.o legacy keyboard shortcuts > through Tools > Options > LibreOffice Calc > Compatibility in bug 97906, I > felt it would be a good idea to provide Excel users with that ability to > change Calc's default shortcuts to those found in Excel. This would reduce > the barrier of entry for Excel shortcut/power users and make it easy for > shortcut users who use both Excel and Calc on a regular basis. Looks as a good idea. (In reply to Yousuf (Jay) Philips from comment #5) > Look forward to seeing your cell management shortcuts, as presently are were > using only using Ctrl + Plus (insert cell) and Ctrl + Minus (delete cell). > Ideally we'd need shortcuts to insert rows and columns, delete rows and > columns, Lightning fast for me is Shft+SPACE followed by Ctrl++ / Ctrl+- > Regarding ctrl+ for text formatting, we are already using alot of > these, but it would be good to add and improve of them (e.g. Strike Through, > Superscript, Subscript) When the discussion tends to include possible change/extend of current short cuts, there is the complicated validating of costs versus gains and desired when possible consistency over the various applications :) (wishing our selves much luck and wisdom ;) ) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/a42169cdae80f88e1c4b52c333e928d239d917f5/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - formula/source sc/source
formula/source/core/api/FormulaCompiler.cxx |7 --- sc/source/core/data/formulacell.cxx | 14 +- 2 files changed, 17 insertions(+), 4 deletions(-) New commits: commit edd4370f5ba49a26a526995b6a28f623d68041ce Author: Eike RathkeDate: Mon May 2 20:37:59 2016 +0200 check presence of token, tdf#96426 follow-up Change-Id: I4c368dfd113b02d208013b4ba79dff606769a150 diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index 96bb268..ffd0f89 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -305,6 +305,9 @@ bool isRangeResultOpCode( OpCode eOp ) } /** +@param pToken +MUST be a valid token, caller has to ensure. + @param bRight If bRPN==false, bRight==false means opcodes for left side are checked, bRight==true means opcodes for right side. If bRPN==true @@ -1200,6 +1203,7 @@ bool FormulaCompiler::GetToken() pArr->nIndex--; // we advanced to the second ocColRowName, step back } else if (pSpacesToken && FormulaGrammar::isExcelSyntax( meGrammar) && +pCurrToken && mpToken && isPotentialRangeType( pCurrToken.get(), false, false) && isPotentialRangeType( mpToken.get(), false, true)) { commit b79d226017b1cb090838165f5a701f90fc278709 Author: Eike Rathke Date: Mon May 2 20:01:54 2016 +0200 Revert "crashtesting: fix ooo123540-1.xlsx etc" This reverts commit bfca69eddd3d94e74d6b73f91476b79c8f72cce7. Rather let the caller check for a valid token instead of checking it twice for other places that already do, and we usually need two valid tokens before even one call makes sens. diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index 85037d4..96bb268 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -312,9 +312,6 @@ bool isRangeResultOpCode( OpCode eOp ) */ bool isPotentialRangeType( FormulaToken* pToken, bool bRPN, bool bRight ) { -if (!pToken) -return false; - switch (pToken->GetType()) { case svByte:// could be range result, but only a few commit 8474c5f14966c9268f92499870feb3c3d21658b3 Author: Eike Rathke Date: Mon May 2 19:52:23 2016 +0200 silence ScTableRefToken::GetSheet() SAL_WARN about unhandled Change-Id: I539bad573bfc459103acc0cb0227bad7681b79aa diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 57a7e64..fefde27 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -3908,8 +3908,20 @@ ScFormulaCell::CompareState ScFormulaCell::CompareByTokenArray( ScFormulaCell& r // different OpCode values. case formula::svIndex: { -if (pThisTok->GetIndex() != pOtherTok->GetIndex() || pThisTok->GetSheet() != pOtherTok->GetSheet()) +if (pThisTok->GetIndex() != pOtherTok->GetIndex()) return NotEqual; +switch (pThisTok->GetOpCode()) +{ +case ocTableRef: +// nothing, sheet value assumed as -1, silence +// ScTableRefToken::GetSheet() SAL_WARN about +// unhandled +; +break; +default:// ocName, ocDBArea +if (pThisTok->GetSheet() != pOtherTok->GetSheet()) +return NotEqual; +} } break; default: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99637] New: Tools > Options > Memory missing Undo section but listed in help
https://bugs.documentfoundation.org/show_bug.cgi?id=99637 Bug ID: 99637 Summary: Tools > Options > Memory missing Undo section but listed in help Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jedim...@gmail.com Apparently the decision was made to remove the Undo section from Options (see Bug 97279), but the Help still points to this location. If you are going to keep this out of Options, please update the Help section appropriately. Perhaps the UI 'Experts' who advise this nonsense, could add the step whenever they remove anything. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99636] New: Blacked Out Text in Dialog Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=99636 Bug ID: 99636 Summary: Blacked Out Text in Dialog Windows Product: LibreOffice Version: 5.1.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: indelibleblue...@gmail.com Created attachment 124797 --> https://bugs.documentfoundation.org/attachment.cgi?id=124797=edit Demonstrates the text display error. Version: LibreOffice 5.1.2.2.0ubuntu1 OS: Ubuntu 16.04 LTS, Unity Graphics: AMD Gallium 0.4 (open-source driver) Various bits of text on dialog windows, usually the first one or two labels, do not display properly. The letters instead display as blacked-out blocks. (See attached screenshot). If the text is selectable, the problem resolves as soon as part or all of the label is selected. However, on some dialog windows (such as the Paragraph settings dialog), the blacked-out labels are not selectable, and thus remain unreadable. The problem is limited to ONLY LibreOffice - no other program on the system is demonstrating the issue. --- NOTE: The problem does NOT exhibit itself on a nearly identical system (Ubuntu 16.04 LTS, Unity; LibreOffice 5.1.2.2.0ubuntu1; AMD Gallium 0.4.). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99635] New: Calc, Missing Text in cells in print preview and printing
https://bugs.documentfoundation.org/show_bug.cgi?id=99635 Bug ID: 99635 Summary: Calc, Missing Text in cells in print preview and printing Product: LibreOffice Version: 5.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: msovi...@gmail.com Missing Text in cells in print preview and printing. I just went from LibreOffice Debian to Windows 10. Some text in Calc cells does not print. Print previwe shows black marks instead of text. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99572] ODS sheet with many external links from other calc files crashes when updtating
https://bugs.documentfoundation.org/show_bug.cgi?id=99572 c.bessi...@herault-habitat.fr changed: What|Removed |Added Version|unspecified |5.1.2.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99628] SVG insert filter -- support for Flowed Text
https://bugs.documentfoundation.org/show_bug.cgi?id=99628 --- Comment #6 from Nicolas Mailhot--- (In reply to V Stuart Foote from comment #4) > Also is "broken" in Mozilla Firefox, ImageMagic ImageDisplay, and has a few > visual glitches in Inkview/Inkscape as well. Well, it opens perfectly there in inkscape (win 7 32bit & Linux 64bit) and almost perfectly in Firefox (Linux 64 bit, only missing the week days) Which is really impressive Firefox-side, given it's not really supposed to be a complex vector drawing viewer, I never tested it there before, and the file was created on windows 32bit -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99516] OpenGL: Crash when attempting to print
https://bugs.documentfoundation.org/show_bug.cgi?id=99516 --- Comment #4 from D--- Created attachment 124796 --> https://bugs.documentfoundation.org/attachment.cgi?id=124796=edit valgrind.log (from standard installation) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Crash test update
Hi Caolán, On Saturday, 2016-04-30 21:18:47 +0100, Caolán McNamara wrote: > FWIW I pushed https://cgit.freedesktop.org/libreoffice/core/commit/?id= > a2565e067b903b6d6ef0ac6c38e18d085a719934 to try and fix these new xlsx > import crashes yuck.. thanks. Though I'll change that to let the caller check instead. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack signature.asc Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 99634] UI: wrong word function instead of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=99634 --- Comment #1 from Gabriele Ponzo--- Good point, I do agree. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99628] SVG insert filter -- support for Flowed Text
https://bugs.documentfoundation.org/show_bug.cgi?id=99628 V Stuart Footechanged: What|Removed |Added CC||aniste...@gmail.com, ||armin.le.gr...@me.com, ||jore...@libreoffice.org Component|Writer |graphics stack See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=50 ||114 Summary|Broken svg import |SVG insert filter -- ||support for Flowed Text Severity|normal |enhancement --- Comment #5 from V Stuart Foote --- Xisco, Armin, Joren A nice clean test file for you, no Inkscape crud. Of course opening it the import filter garbles it badly. But svgio does pretty well with it, but do see a few issues with anchoring locations for TSPANs, so something there. But seemingly no support for the SVG 1.2 Flowed Text etc. nesting. Looking at bug 50114 seems it was decided to not support Flowed Text as it was not valid to standard. Joren? A needed LO enhancement? Or, resolve won't fix? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99486] The file search functions are not functioning properly when searching for words contenting in LibreOffice Documents
https://bugs.documentfoundation.org/show_bug.cgi?id=99486 --- Comment #1 from steve -_---- My 2 cents: Sounds like you are referring to the spotlight feature in OS X. Spotlight's behavior is something (I think) LibreOffice has no influence on. I have no time to test this en detail atm but this may be notourbug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90426] Calc context menu → Insert chart
https://bugs.documentfoundation.org/show_bug.cgi?id=90426 vrothchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from vroth --- Indeed it isn't. I trusted the voice of the user, and I failed to verify it myself beforehand. I suggest this feature in case the ux becomes similar to newer offices. Sorry for the time wasted. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 90426] Calc context menu → Insert chart
https://bugs.documentfoundation.org/show_bug.cgi?id=90426 vrothchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from vroth --- Indeed it isn't. I trusted the voice of the user, and I failed to verify it myself beforehand. I suggest this feature in case the ux becomes similar to newer offices. Sorry for the time wasted. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 99625] TEXTJOIN returns wrongly an array when "text argument" is a CSE array.
https://bugs.documentfoundation.org/show_bug.cgi?id=99625 GerardFchanged: What|Removed |Added Summary|TEXTEJOIN returns wrongly |TEXTJOIN returns wrongly an |an array when "text |array when "text argument" |argument" is a CSE array. |is a CSE array. --- Comment #4 from GerardF --- (In reply to GerardF from comment #3) > Dennis, can you try entering this formula in a cell: > =TEXTJOIN(", > ",1,INDEX(B:B,N(IF(1,MODE.MULT(IF(A4:A12=D4,{1,1}*ROW(A4:A12))) > instead of > =TEXTJOIN(", ",1,INDEX(B:B,MODE.MULT(IF(A4:A12=D4,{1,1}*ROW(A4:A12) > > in Excel and save the file as .xlsx This formula was to make the same job, but you can test only a simple formula like : =TEXTJOIN(",",1,ROW(A1:A3)) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc.hxx |2 + sc/qa/unit/ucalc_sort.cxx | 76 ++ 2 files changed, 78 insertions(+) New commits: commit 4f5c97849b8d4aa4a6698e9528e39570a6d47a7a Author: Eike RathkeDate: Mon May 2 19:14:38 2016 +0200 unit test for tdf#99417 track formula cells for BROADCAST_BROADCASTERS Change-Id: I82cd43774388a426b4c7dc536952dc3f9584cf9e diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 6896c8e..028c342 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -423,6 +423,7 @@ public: void testSortRefUpdate5(); void testSortRefUpdate6(); void testSortBroadcaster(); +void testSortBroadcastBroadcaster(); void testSortOutOfPlaceResult(); void testSortPartialFormulaGroup(); @@ -687,6 +688,7 @@ public: CPPUNIT_TEST(testSortRefUpdate5); CPPUNIT_TEST(testSortRefUpdate6); CPPUNIT_TEST(testSortBroadcaster); +CPPUNIT_TEST(testSortBroadcastBroadcaster); CPPUNIT_TEST(testSortOutOfPlaceResult); CPPUNIT_TEST(testSortPartialFormulaGroup); CPPUNIT_TEST(testShiftCells); diff --git a/sc/qa/unit/ucalc_sort.cxx b/sc/qa/unit/ucalc_sort.cxx index b47b3a3..59293ba 100644 --- a/sc/qa/unit/ucalc_sort.cxx +++ b/sc/qa/unit/ucalc_sort.cxx @@ -1695,6 +1695,82 @@ void Test::testSortBroadcaster() m_pDoc->DeleteTab(0); } +// tdf#99417 check that formulas are tracked that *only* indirectly depend on +// sorted data and no other broadcasting than BroadcastBroadcasters is +// involved (for which this test can not be included in testSortBroadcaster()). +void Test::testSortBroadcastBroadcaster() +{ +SortRefNoUpdateSetter aUpdateSet; + +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. +m_pDoc->InsertTab(0, "Sort"); + +{ +const char* aData[][3] = { +{ "1", "=A1", "=B1" }, +{ "2", "=A2", "=B2" }, +}; + +ScAddress aPos(0,0,0); +ScRange aDataRange = insertRangeData(m_pDoc, aPos, aData, SAL_N_ELEMENTS(aData)); +CPPUNIT_ASSERT_EQUAL(aPos, aDataRange.aStart); + +{ +// Expected output table content. 0 = empty cell +const char* aOutputCheck[][3] = { +{ "1", "1", "1" }, +{ "2", "2", "2" }, +}; + +bool bSuccess = checkOutput<3>(m_pDoc, aDataRange, aOutputCheck, "Initial value"); +CPPUNIT_ASSERT_MESSAGE("Table output check failed", bSuccess); +} + +// Sort A1:A2. +m_pDoc->SetAnonymousDBData( +0, new ScDBData(STR_DB_LOCAL_NONAME, 0, 0, 0, 0, 1)); + +ScDBDocFunc aFunc(getDocShell()); + +// Sort A1:A2 by column A descending. +ScSortParam aSortData; +aSortData.nCol1 = 0; +aSortData.nCol2 = 0; +aSortData.nRow1 = 0; +aSortData.nRow2 = 1; +aSortData.bHasHeader = false; +aSortData.bByRow = true; +aSortData.maKeyState[0].bDoSort = true; +aSortData.maKeyState[0].nField = 0; +aSortData.maKeyState[0].bAscending = false; +bool bSorted = aFunc.Sort(0, aSortData, true, true, true); +CPPUNIT_ASSERT(bSorted); + +{ +// Expected output table content. 0 = empty cell +const char* aOutputCheck[][3] = { +{ "2", "2", "2" }, +{ "1", "1", "1" }, +}; + +bool bSuccess = checkOutput<3>(m_pDoc, aDataRange, aOutputCheck, "Sorted without reference update"); +CPPUNIT_ASSERT_MESSAGE("Table output check failed", bSuccess); +} + +// Make sure that the formulas in B1:C2 are not adjusted. +if (!checkFormula(*m_pDoc, ScAddress(1,0,0), "A1")) +CPPUNIT_FAIL("Wrong formula!"); +if (!checkFormula(*m_pDoc, ScAddress(1,1,0), "A2")) +CPPUNIT_FAIL("Wrong formula!"); +if (!checkFormula(*m_pDoc, ScAddress(2,0,0), "B1")) +CPPUNIT_FAIL("Wrong formula!"); +if (!checkFormula(*m_pDoc, ScAddress(2,1,0), "B2")) +CPPUNIT_FAIL("Wrong formula!"); +} + +m_pDoc->DeleteTab(0); +} + void Test::testSortOutOfPlaceResult() { m_pDoc->InsertTab(0, "Sort"); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99634] New: UI: wrong word function instead of formula
https://bugs.documentfoundation.org/show_bug.cgi?id=99634 Bug ID: 99634 Summary: UI: wrong word function instead of formula Product: LibreOffice Version: 5.0.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: frach...@tiscali.it Please change the tooltip "function" in "formula" when mouse over "=" in formula bar. Actually I can also write =2+3 which is not a function, but just a formula. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99633] New: Some of my saved LibreOffice files start blinking off and on every 2 - 3 seconds. Why?
https://bugs.documentfoundation.org/show_bug.cgi?id=99633 Bug ID: 99633 Summary: Some of my saved LibreOffice files start blinking off and on every 2 - 3 seconds. Why? Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pawalb...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: l10ntools/inc l10ntools/source
l10ntools/inc/gConvSrc.hxx|7 ++-- l10ntools/source/gConvSrc.cxx | 65 ++ l10ntools/source/gDiff.sh |9 + l10ntools/source/gLexSrc.l| 57 ++-- l10ntools/source/gRun.sh |2 - 5 files changed, 83 insertions(+), 57 deletions(-) New commits: commit 6a3139493857631784f64419048ee258cd0c4493 Author: jan IversenDate: Mon May 2 16:50:50 2016 + genlang macro support for .src files Added macro detection in .src filter Updated gDiff and gRun scripts with enhancements Change-Id: I3ef72e8ccee65d03fe5080e27699ceebb079 diff --git a/l10ntools/inc/gConvSrc.hxx b/l10ntools/inc/gConvSrc.hxx index 77922c9..605fffb 100644 --- a/l10ntools/inc/gConvSrc.hxx +++ b/l10ntools/inc/gConvSrc.hxx @@ -39,16 +39,19 @@ class convert_src : public convert_gen void setCmd(string& syyText); void startBlock(); void stopBlock(); +void defMacro(); +void endMacro(); //void setId (char *syyText, bool bIde); //void setText (char *syyText); -//void setMacro (char *syyText); //void setList (char *syyText); //void setListItem (char const *syyText, bool bIsStart); //void setNL (char *syyText, bool bMacro); private: vector mcStack; +int miLevel; +bool mbMacroActive; void doExecute() override; #if 0 string msValue; @@ -58,13 +61,11 @@ class convert_src : public convert_gen string msGroup; bool mbEnUs; bool mbExpectName; -bool mbExpectMacro; bool mbAutoPush; bool mbValuePresent; bool mbInList; bool mbInListItem; int miListCount; -int miMacroLevel; static void trim(string& sText); void buildKey(string& sKey); diff --git a/l10ntools/source/gConvSrc.cxx b/l10ntools/source/gConvSrc.cxx index 20085a0..213a3d2 100644 --- a/l10ntools/source/gConvSrc.cxx +++ b/l10ntools/source/gConvSrc.cxx @@ -29,13 +29,13 @@ using namespace std; convert_src::convert_src(l10nMem& crMemory) -: convert_gen(crMemory) +: convert_gen(crMemory), + miLevel(0), + mbMacroActive(false) #if 0 -, mbExpectValue(false), mbEnUs(false), mbExpectName(false), - mbExpectMacro(false), mbAutoPush(false), mbValuePresent(false), mbInList(false), @@ -62,11 +62,11 @@ void convert_src::setValue(string& syyText) for (int i = 0; i < stackSize; i++) cout << mcStack[i] << "\n"; } -string subid = (stackSize > 3) ? mcStack[2] : mcStack[0]; -l10nMem::keyToLower(subid); +string subid = (stackSize > 3) ? mcStack[stackSize - 1] : ""; +string stringid = mcStack[stackSize - 2]; +l10nMem::keyToLower(stringid); -mcMemory.setSourceKey(miLineNo, msSourceFile, mcStack[1], cleanValue, "", subid, mcStack[stackSize-1], false); -mcStack.pop_back(); +mcMemory.setSourceKey(miLineNo, msSourceFile, mcStack[1], cleanValue, "", stringid, subid, false); } @@ -98,19 +98,51 @@ void convert_src::setCmd(string& syyText) void convert_src::startBlock() { +unsigned int cnt = 2 * ++miLevel; + +while (cnt > mcStack.size()) +mcStack.push_back(""); } void convert_src::stopBlock() { +if (miLevel > 0) +miLevel--; + // check for correct node/prop relations -if (mcStack.size()) -mcStack.pop_back(); +if (mcStack.size()) { +if (miLevel) { +mcStack.pop_back(); +mcStack.pop_back(); +} +else +mcStack.clear(); +} } +void convert_src::defMacro() +{ +if (!miLevel) +miLevel++; +mbMacroActive = true; +} + + + +void convert_src::endMacro() +{ +if (mbMacroActive) { +mbMacroActive = false; +miLevel = 0; +mcStack.clear(); +} +} + + #if 0 void convert_src::setId(char *syyText, bool bId) { @@ -135,21 +167,6 @@ void convert_src::setText(char *syyText) #if 0 -void convert_src::setMacro(char *syyText) -{ -msCmd = copySource(syyText); -mbExpectName = -mbExpectMacro = -mbAutoPush = true; -miMacroLevel = mcStack.size(); -mcStack.push_back(""); -trim(msCmd); -} -#endif - - - -#if 0 void convert_src::setList(char *syyText) { msCmd = copySource(syyText); diff --git a/l10ntools/source/gDiff.sh b/l10ntools/source/gDiff.sh
[Libreoffice-commits] online.git: 4 commits - loolwsd/Connect.cpp loolwsd/LOOLTool.cpp loolwsd/test
loolwsd/Connect.cpp |1 loolwsd/LOOLTool.cpp |1 loolwsd/test/UnitAdmin.cpp | 14 +++- loolwsd/test/httpwstest.cpp | 20 ++ loolwsd/test/integration-http-server.cpp | 89 ++- 5 files changed, 50 insertions(+), 75 deletions(-) New commits: commit 511b6c1039a82b2ad95f14f0bcd1d8b6332ee945 Author: Jan HolesovskyDate: Mon May 2 18:41:57 2016 +0200 Reduce #ifdef ENABLE_SSL's. diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp index c0bc549..082ecdb 100644 --- a/loolwsd/test/httpwstest.cpp +++ b/loolwsd/test/httpwstest.cpp @@ -180,11 +180,7 @@ void HTTPWSTest::testBadRequest() Poco::Net::HTTPResponse response; Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL); -#if ENABLE_SSL -Poco::Net::HTTPSClientSession session(_uri.getHost(), _uri.getPort()); -#else -Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort()); -#endif +std::unique_ptr session(helpers::createSession(_uri)); // This should result in Bad Request, but results in: // WebSocket Exception: Missing Sec-WebSocket-Key in handshake request // So Service Unavailable is returned. @@ -194,9 +190,9 @@ void HTTPWSTest::testBadRequest() request.set("Sec-WebSocket-Version", "13"); request.set("Sec-WebSocket-Key", ""); request.setChunkedTransferEncoding(false); -session.setKeepAlive(true); -session.sendRequest(request); -session.receiveResponse(response); +session->setKeepAlive(true); +session->sendRequest(request); +session->receiveResponse(response); CPPUNIT_ASSERT(response.getStatus() == Poco::Net::HTTPResponse::HTTPResponse::HTTP_SERVICE_UNAVAILABLE); } catch (const Poco::Exception& exc) @@ -218,12 +214,8 @@ void HTTPWSTest::testHandShake() Poco::Net::HTTPResponse response; Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, documentURL); -#if ENABLE_SSL -Poco::Net::HTTPSClientSession session(_uri.getHost(), _uri.getPort()); -#else -Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort()); -#endif -Poco::Net::WebSocket socket(session, request, response); +std::unique_ptr session(helpers::createSession(_uri)); +Poco::Net::WebSocket socket(*session, request, response); const char* fail = "error:"; std::string payload("statusindicator: find"); diff --git a/loolwsd/test/integration-http-server.cpp b/loolwsd/test/integration-http-server.cpp index 4d67757..3494aeb 100644 --- a/loolwsd/test/integration-http-server.cpp +++ b/loolwsd/test/integration-http-server.cpp @@ -27,6 +27,7 @@ #include #include "countloolkits.hpp" +#include "helpers.hpp" /// Tests the HTTP GET API of loolwsd. class HTTPServerTest : public CPPUNIT_NS::TestFixture @@ -94,35 +95,27 @@ void HTTPServerTest::testCountHowManyLoolkits() void HTTPServerTest::testDiscovery() { -#if ENABLE_SSL -Poco::Net::HTTPSClientSession session(_uri.getHost(), _uri.getPort()); -#else -Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort()); -#endif +std::unique_ptr session(helpers::createSession(_uri)); Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, "/hosting/discovery"); -session.sendRequest(request); +session->sendRequest(request); Poco::Net::HTTPResponse response; -session.receiveResponse(response); +session->receiveResponse(response); CPPUNIT_ASSERT_EQUAL(Poco::Net::HTTPResponse::HTTP_OK, response.getStatus()); CPPUNIT_ASSERT_EQUAL(std::string("text/xml"), response.getContentType()); } void HTTPServerTest::testLoleafletGet() { -#if ENABLE_SSL -Poco::Net::HTTPSClientSession session(_uri.getHost(), _uri.getPort()); -#else -Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort()); -#endif +std::unique_ptr session(helpers::createSession(_uri)); Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, "/loleaflet/dist/loleaflet.html?access_token=1"); Poco::Net::HTMLForm param(request); -session.sendRequest(request); +session->sendRequest(request); Poco::Net::HTTPResponse response; -std::istream& rs = session.receiveResponse(response); +std::istream& rs = session->receiveResponse(response); CPPUNIT_ASSERT_EQUAL(Poco::Net::HTTPResponse::HTTP_OK, response.getStatus()); CPPUNIT_ASSERT_EQUAL(std::string("text/html"), response.getContentType()); @@ -136,21 +129,17 @@ void HTTPServerTest::testLoleafletGet() void HTTPServerTest::testLoleafletPost() { -#if ENABLE_SSL -Poco::Net::HTTPSClientSession session(_uri.getHost(), _uri.getPort()); -#else -Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort()); -#endif +std::unique_ptr