[Libreoffice-bugs] [Bug 100153] New: FILEOPEN: DOCX import noSmoking shape incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=100153 Bug ID: 100153 Summary: FILEOPEN: DOCX import noSmoking shape incorrectly Product: LibreOffice Version: 5.0.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: qiang_...@live.cn Created attachment 125406 --> https://bugs.documentfoundation.org/attachment.cgi?id=125406=edit This document is exported by M$Word 2010 LibreOffice Writer fails to correctly import a noSmoking shape from DOCX document Steps to reproduce: - Open the attached reduced test case with LibreOffice Writer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - svl/source xmloff/source
svl/source/numbers/zformat.cxx | 22 -- xmloff/source/style/xmlnumfe.cxx |5 +++-- 2 files changed, 15 insertions(+), 12 deletions(-) New commits: commit 7e8e2ef608c7fe2a1c6d6fa244534b85dc42362b Author: Eike RathkeDate: Tue May 31 00:02:38 2016 +0200 prevent out of bounds string access Yet another reminiscence of String to OUString conversion.. where the terminating NULL-character was obtained and SvNumberformat::InsertBlanks() effectively did nothing. Could be triggered already by entering an '_' underscore character as number format code, which is a place holder for blanks of the same width as the following character, which there isn't then yet. Change-Id: I0534e1417d4bd35e9e7ed4bd0170b9ea3b5fb575 (cherry picked from commit c75ce37560c05271ba56c9dd0d98c5001e83cc2f) Reviewed-on: https://gerrit.libreoffice.org/25693 Tested-by: Jenkins Reviewed-by: Markus Mohrhard diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 29402f8..90175f9 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -1941,8 +1941,8 @@ bool SvNumberformat::GetOutputString(const OUString& sString, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sOutBuff, sOutBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sOutBuff, sOutBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_KEY_GENERAL : // #77026# "General" is the same as "@" case NF_SYMBOLTYPE_DEL : @@ -2272,8 +2272,8 @@ bool SvNumberformat::GetOutputString(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -2904,8 +2904,8 @@ bool SvNumberformat::ImpGetTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3397,7 +3397,8 @@ bool SvNumberformat::ImpGetDateOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3690,8 +3691,8 @@ bool SvNumberformat::ImpGetDateTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -4337,7 +4338,8 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string } break; case NF_SYMBOLTYPE_BLANK: -k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); +if (rInfo.sStrArray[j].getLength() >= 2) +k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); break; case NF_SYMBOLTYPE_THSEP: // Same as in ImpNumberFillWithThousands() above, do not insert diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx index 068ca83..5bbbdd3 100644 --- a/xmloff/source/style/xmlnumfe.cxx +++ b/xmloff/source/style/xmlnumfe.cxx @@ -1295,7 +1295,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const SvNumberformat& rFormat, sal_uInt { aEmbeddedStr = *pElemStr; } -else +else if (pElemStr->getLength() >= 2) { SvNumberformat::InsertBlanks( aEmbeddedStr, 0, (*pElemStr)[1] ); } @@ -1367,7 +1367,8 @@ void
[Libreoffice-bugs] [Bug 100108] Layout labels not consistent between layout tab and layout menu
https://bugs.documentfoundation.org/show_bug.cgi?id=100108 Buovjagachanged: What|Removed |Added Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100099] Pasting conditional formatting to more cells/columns, does not update the last column
https://bugs.documentfoundation.org/show_bug.cgi?id=100099 Buovjagachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Buovjaga --- (In reply to matteazzi.antonio from comment #0) > Created attachment 125340 [details] > Colour red background on cells present in sheet E I don't see any cond. formatting in sheet E (manage shows nothing). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100098] Pixellated text in Retina Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=100098 Buovjagachanged: What|Removed |Added Blocks||90796 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Buovjagachanged: What|Removed |Added CC|todven...@suomi24.fi| Depends on||100098 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100098 [Bug 100098] Pixellated text in Retina Mac -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100094] Using character formating destroys Hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=100094 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Buovjaga --- Set to NEEDINFO. Change back to UNCONFIRMED after you have provided an example document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96603] implement GtkCellRendererText or add a makeGtkCellRendererText function
https://bugs.documentfoundation.org/show_bug.cgi?id=96603 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #2 from Buovjaga --- Confirmed on Ubuntu 16.04 Version: 5.3.0.0.alpha0+ Build ID: 73770a3722de42034f5d4cd35f29d6b92856fea4 CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF-dbg, Branch:master, Time: 2016-05-26_15:58:55 Locale: en-US (en_US.UTF-8) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99966] PRINTING: The printed paper is immaculate after printing a documents containing only black elements (e.g. text or table) !
https://bugs.documentfoundation.org/show_bug.cgi?id=99966 --- Comment #3 from Buovjaga--- It sounds really weird. Other programs print black ok? Maybe try with a fresh dev build: http://dev-builds.libreoffice.org/daily/master/Win-x86_64@62-TDF/current/ It installs alongside your stable and will not mess things up. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bin/find-german-comments
bin/find-german-comments | 74 --- 1 file changed, 38 insertions(+), 36 deletions(-) New commits: commit 88c03cd07a171e05c7fb4dcade8baa28e7c5a770 Author: Phillip SzDate: Sun May 29 13:49:39 2016 +0200 find-german-comments: clean up Most of these syntax changes are found by pylint. Also: - Use argparse instead of optparse, which is deprecated - Fix a bug where we tried to multiply by float, which does not work Change-Id: I7de5a29bd431755e6c28a8bc80b804c775a0c2cb Reviewed-on: https://gerrit.libreoffice.org/25669 Tested-by: Jenkins Reviewed-by: jan iversen diff --git a/bin/find-german-comments b/bin/find-german-comments index 0a9c0f0..40b4c9b 100755 --- a/bin/find-german-comments +++ b/bin/find-german-comments @@ -27,7 +27,12 @@ -import sys, re, subprocess, os, optparse, string +import sys +import re +import subprocess +import os +import argparse +import string class Parser: """ @@ -37,34 +42,28 @@ class Parser: def __init__(self): self.strip = string.punctuation + " \n" self.text_cat = self.start_text_cat() -op = optparse.OptionParser() -op.set_usage("%prog [options] \n\n" + -"Searches for german comments in cxx/hxx source files inside a given root\n" + -"directory recursively.") -op.add_option("-f", "--filenames-only", action="store_true", dest="filenames_only", default=False, +parser = argparse.ArgumentParser(description='Searches for german comments in cxx/hxx source files inside a given root directory recursively.') +parser.add_argument("-f", "--filenames-only", action="store_true", help="Only print the filenames of files containing German comments") -op.add_option("-v", "--verbose", action="store_true", dest="verbose", default=False, +parser.add_argument("-v", "--verbose", action="store_true", help="Turn on verbose mode (print only positives progress to stderr)") -op.add_option("-l", "--line-numbers", action="store_true", dest="line_numbers", default=False, +parser.add_argument("-l", "--line-numbers", action="store_true", help="Prints the filenames and line numbers only.") -op.add_option("-L", "--line-numbers-pos", action="store_true", dest="line_numbers_pos", default=False, +parser.add_argument("-L", "--line-numbers-pos", action="store_true", help="Prints the filenames and line numbers only (if positive).") -op.add_option("-t", "--threshold", action="store", dest="THRESHOLD", default=0, +parser.add_argument("-t", "--threshold", action="store", default=0, type=int, help="When used with '--line-numbers', only bothers outputting comment info if there are more than X number of flagged comments. Useful for weeding out false positives.") -self.options, args = op.parse_args() -try: -dir = args[0] -except IndexError: -dir = "." -self.check_source_files(dir) +parser.add_argument("directory", nargs='?', default='.', type=str, help='Give a directory to search in') +self.args = parser.parse_args() +self.check_source_files(self.args.directory) def get_comments(self, filename): """ Extracts the source code comments. """ linenum = 0 -if self.options.verbose: -sys.stderr.write("processing file '%s'...\n" % filename) +if self.args.verbose: +print("processing file '%s'...\n" % filename) sock = open(filename) # add an empty line to trigger the output of collected oneliner # comment group @@ -146,39 +145,39 @@ class Parser: s = s.replace('\n', ' ') if len(s) < 32 or len(s.split()) < 4: return False -return b"german" == self.get_lang(s) +return self.get_lang(s) == b"german" def check_file(self, path): """ checks each comment in a file """ -def tab_calc (string): +def tab_calc(path): START = 40 #Default of 10 tabs -if len(string) >= START: +if len(path) >= START: return 1 -diff = START - len(string) +diff = START - len(path) if diff % 4 is not 0: padding = 1 else: padding = 0 return (diff/4)+padding -if self.options.line_numbers or self.options.line_numbers_pos: +if self.args.line_numbers or self.args.line_numbers_pos: TABS = "\t"*10 path_linenums = [] for linenum, s in self.get_comments(path): if self.is_german(s):
[Libreoffice-bugs] [Bug 98336] invisible message in confirmation box
https://bugs.documentfoundation.org/show_bug.cgi?id=98336 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #12 from Buovjaga --- jdruel: could you try with 5.2 http://dev-builds.libreoffice.org/pre-releases/rpm/x86_64/ https://wiki.documentfoundation.org/Installing_in_parallel/Linux If all your problems go away, I think you could set this to RESOLVED DUPLICATE of bug 99446 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100152] Background colors are not applied for text
https://bugs.documentfoundation.org/show_bug.cgi?id=100152 --- Comment #2 from jvchbabu--- Created attachment 125405 --> https://bugs.documentfoundation.org/attachment.cgi?id=125405=edit Converted generated doc file to html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100087] Columns created right-left rather than left-right
https://bugs.documentfoundation.org/show_bug.cgi?id=100087 Buovjagachanged: What|Removed |Added Status|REOPENED|NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100105] Whole or most of documents go blank when writing above a link
https://bugs.documentfoundation.org/show_bug.cgi?id=100105 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- I can not reproduce with Version: 5.3.0.0.alpha0+ Build ID: 33d4f7e5624d77ef1ce51aece1c8a0ef7ea21603 CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-05-29_01:58:16 and 5.1.3 Text is not lost. In your RTF file I see the link (not in writer, but when open with notepad). Please could you attach video with reproduction steps, maybe we missed something. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100152] Background colors are not applied for text
https://bugs.documentfoundation.org/show_bug.cgi?id=100152 --- Comment #1 from jvchbabu--- Created attachment 125404 --> https://bugs.documentfoundation.org/attachment.cgi?id=125404=edit source html file and generated output source html file and generated output -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100152] New: Background colors are not applied for text
https://bugs.documentfoundation.org/show_bug.cgi?id=100152 Bug ID: 100152 Summary: Background colors are not applied for text Product: LibreOffice Version: 5.0.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jvchb...@gmail.com We use LibreOffice 5.0.4.2 to create .docx and .doc documents using UNO Java API. We use MS Word 97 filter to produce .doc documents and MS Word 2007 XML to produce .docx documents. We have content from HTML file. Background color for the text is not applied as specified. We have given color code as #F18493 but it applied as red.Another color code is #54C371, but applied as lime color. We have a bookmark in both .doc and .docx files and used XDocumentInsertable.insertDocumentFromURL API to insert text from HTML file in place of bookmark XTextCursor . But generated files shows different irrelevant colors. We tried the same in OpenOffice, they are working fine. Please find the attachment for source html generated output. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96433] New Tai Lue prevowel character selection
https://bugs.documentfoundation.org/show_bug.cgi?id=96433 Aron Budeachanged: What|Removed |Added Keywords||needAdvice CC||ba...@caesar.elte.hu --- Comment #1 from Aron Budea --- Asking a dev to set this on track. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99890] Two recovered documents get the same name
https://bugs.documentfoundation.org/show_bug.cgi?id=99890 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEW Summary|Two files get mixed up |Two recovered documents get ||the same name Ever confirmed|0 |1 Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100147] MacOS: Fatal exception: Signal 6 during building
https://bugs.documentfoundation.org/show_bug.cgi?id=100147 --- Comment #2 from Julien Nabet--- Raal: ok but I never had the solution on dev forum See http://nabble.documentfoundation.org/About-skip-SkipImages-unit-test-on-MacOs-td4149788.html + http://nabble.documentfoundation.org/About-testSkipImages-unit-test-on-MacOs-td4179552.html -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] New: crash pptx file at the end of the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 Bug ID: 100151 Summary: crash pptx file at the end of the presentation Product: LibreOffice Version: 5.1.3.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r...@post.cz Created attachment 125403 --> https://bugs.documentfoundation.org/attachment.cgi?id=125403=edit test file Steps: open file play presentation (F5) after the presentation ends, the program crash Version: 5.3.0.0.alpha0+ Build ID: 33d4f7e5624d77ef1ce51aece1c8a0ef7ea21603 CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-05-29_01:58:16 and 5.1.3.2 (x64) No problem on Linux. No crash in 4.2.8.2, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100151] crash pptx file at the end of the presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=100151 raalchanged: What|Removed |Added Keywords||regression CC||r...@post.cz -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93421] EDITING, FORMATTING: template changes do not propagate to existing documents when template is imported in newer version of LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=93421 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94817] Error when opening digital signed Writer Document with 64-Bit LibreOffice 5.0.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=94817 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@caesar.elte.hu Ever confirmed|0 |1 --- Comment #2 from Aron Budea --- Can you please check this again in a recent LibreOffice version? (preferably 5.1.3.2) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100150] New: LibreOffice Font Selection Dropdown dysfunctional in Wayland
https://bugs.documentfoundation.org/show_bug.cgi?id=100150 Bug ID: 100150 Summary: LibreOffice Font Selection Dropdown dysfunctional in Wayland Product: LibreOffice Version: 5.1.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: danloomi...@gmail.com Running Version: 5.1.3.2 from Fedora 24 Beta Build ID: 5.1.3.2-6.fc24 The Font selection dropdown is working differently in Wayland. When I left click Libreoffice will choose a font and make the change before I ever see a list. If I left click and hold I can see the list but it's difficult to select anything while holding the click. When I right click the dropdown list is displayed and libreOffice will preselect a font. This is a problem if the user is changing the font on a sheet say from a proprietary Windows font to an open source font. The expected behaviour of dropdown lists is that the list displays and lets the user select the option. Will retest this in X11 and post a followup. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100145] FILEOPEN: PPTX: Hide after animation doesn't work as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=100145 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- I can confirm with Version: 5.3.0.0.alpha0+ Build ID: 33d4f7e5624d77ef1ce51aece1c8a0ef7ea21603 CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-05-29_01:58:16 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100149] LibreOffice crashes when spreadsheet or document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=100149 Dan Loomischanged: What|Removed |Added Version|unspecified |5.1.3.2 release -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100149] New: LibreOffice crashes when spreadsheet or document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=100149 Bug ID: 100149 Summary: LibreOffice crashes when spreadsheet or document is closed Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: danloomi...@gmail.com Created attachment 125402 --> https://bugs.documentfoundation.org/attachment.cgi?id=125402=edit journalctl recorded coindicent with libreoffice crash Running Version: 5.1.3.2 from Fedora 24 Beta Build ID: 5.1.3.2-6.fc24 Every time I close a document that I have changed and saved Libre Office crashes and initiates document recovery. I added the journalctl messages for one of these crashes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100143] libreoffice 5.1 crashes on opening an XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=100143 --- Comment #2 from Petr Pisar--- The Windows machine has 64-bit CPU, but all the software including operating system is 32-bit. There is Oracle JRE 1.8. The Linux machine has everything 64-bit and OpenJDK JRE 1.8. I will check the clean profile later. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100147] MacOS: Fatal exception: Signal 6 during building
https://bugs.documentfoundation.org/show_bug.cgi?id=100147 raalchanged: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Hello Julien, please see https://wiki.documentfoundation.org/QA/BugReport#Not_all_bugs_go_to_Bugzilla It's this case Building LibreOffice ->Development/Mailing List? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99006] FORMATTING: Freeze when attempting to Insert Index/ Table of Contents and editing a Style.
https://bugs.documentfoundation.org/show_bug.cgi?id=99006 --- Comment #5 from raal--- I can not confirm with 5.1.3.2 (x64),win10. Please could you attach test file? thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97124] Paste not working from external application
https://bugs.documentfoundation.org/show_bug.cgi?id=97124 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #5 from Aron Budea --- Franco, are you still encountering this issue in a recent version of LibreOffice? I couldn't reproduce this either. Something weird I noticed when I was trying to test this in LO 5.1.3.2/Windows 7 was that sometimes Edit -> Paste menu item got disabled, when there was text on the clipboard (Ctrl-C was working fine, too). Unfortunately it happened rarely, and I couldn't reliably reproduce it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp loolwsd/Util.cpp
loolwsd/LOOLWSD.cpp |7 ++- loolwsd/Util.cpp| 19 +-- 2 files changed, 23 insertions(+), 3 deletions(-) New commits: commit 886af28bc2f6d1d27bf78de09978f3858d2db705 Author: Ashod NakashianDate: Mon May 30 21:43:18 2016 -0400 loolwsd: improved random directory generator Change-Id: Ic4ea88ba77549cc4ccba83c27fffdffcdeebb984 Reviewed-on: https://gerrit.libreoffice.org/25698 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp index da2f72c..cd89457 100644 --- a/loolwsd/LOOLWSD.cpp +++ b/loolwsd/LOOLWSD.cpp @@ -420,7 +420,8 @@ private: if (!resultURL.getPath().empty()) { const std::string mimeType = "application/octet-stream"; -response.sendFile(resultURL.getPath(), mimeType); +URI::encode(resultURL.getPath(), "", encodedTo); +response.sendFile(encodedTo, mimeType); sent = true; } @@ -504,6 +505,10 @@ private: Util::removeFile(dirPath, true); return true; } +else +{ +Log::error("Download file [" + filePath + "] not found."); +} } throw BadRequestException("Invalid or unknown request."); diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp index 4e11d38..78a90f0 100644 --- a/loolwsd/Util.cpp +++ b/loolwsd/Util.cpp @@ -81,13 +81,27 @@ namespace rng return v; } -std::string getString(const size_t length) +/// Generates a random string in Base64. +/// Note: May contain '/' characters. +std::string getB64String(const size_t length) { std::stringstream ss; Poco::Base64Encoder b64(ss); b64 << getBytes(length).data(); return ss.str().substr(0, length); } + +/// Generates a random string suitable for +/// file/directory names. +std::string getFilename(const size_t length) +{ +std::stringstream ss; +Poco::Base64Encoder b64(ss); +b64 << getBytes(length).data(); +std::string s = ss.str(); +std::replace(s.begin(), s.end(), '/', '_'); +return s.substr(0, length); +} } } @@ -109,10 +123,11 @@ namespace Util return id; } +/// Create a secure, random directory path. std::string createRandomDir(const std::string& path) { Poco::File(path).createDirectories(); -const auto name = rng::getString(64); +const auto name = rng::getFilename(64); Poco::File(Poco::Path(path, name)).createDirectories(); return name; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100076] Computer Crash after selected marking part of document with right mouse click
https://bugs.documentfoundation.org/show_bug.cgi?id=100076 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90498] getDouble wrong value
https://bugs.documentfoundation.org/show_bug.cgi?id=90498 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu, ||ipla...@yahoo.co.uk Component|LibreOffice |Extensions --- Comment #1 from Aron Budea --- Alex, I saw you reacting to bug reports on MySQL native connector, can you comment on this one? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99890] Two files get mixed up
https://bugs.documentfoundation.org/show_bug.cgi?id=99890 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #2 from Aron Budea --- (In reply to Buovjaga from comment #1) > 1. Created document A.docx with content "" > 2. Copied it to B.docx, opened and added more content > 3. Had autorecovery info save time as 2 minutes and waited for it to be saved > 4. Simulated crash by killing soffice.bin forcefully > 5. Opened LibO again and did recovery I repeated these steps with this alternation: 2. Used Saved As... to save as B.docx, added more content (some unsaved), opened A.docx, added more content (all unsaved) Results: -both recovered documents were named A.docx, (bug) -content was correct in both documents. (not bug) Tested in LO 5.1.3.2, Windows 7. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98124] Crash on copying cells (openCL)
https://bugs.documentfoundation.org/show_bug.cgi?id=98124 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #21 from raal --- (In reply to mail.geschaeftlich from comment #20) > Sorry it's my my first contribution to a bug, and so I'm not familiar with > bugzilla. I also had the problem (crash) but only after cutting and paste a > text in a table. When I disabled OpenCL as described in commetn 10, no crash > occured. So I attached the file as discribed in comment 12 > > Kind regards > > Dieter Please try to get a backtrace of the crash: https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg Setting to new. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71583] FORMATTING: There is no page count field for different page styles or sections
https://bugs.documentfoundation.org/show_bug.cgi?id=71583 --- Comment #3 from Tim Chambers--- Add my vote for this feature to be implemented! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100136] "hyphenation active" does not work in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=100136 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Version|5.0.5.2 release |3.5.0 release Ever confirmed|0 |1 --- Comment #1 from raal --- I can confirm with Version: 5.3.0.0.alpha0+ Build ID: 86d84ae4bba0d4c45bc13232645318291a8aed75 CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-05-26_14:33:24 and 3.5 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100138] Trendline equation should be resizable
https://bugs.documentfoundation.org/show_bug.cgi?id=100138 raalchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal --- setting to new. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95529] Won't open
https://bugs.documentfoundation.org/show_bug.cgi?id=95529 Robertchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Robert --- please disregard previous request...thanks! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95529] Won't open
https://bugs.documentfoundation.org/show_bug.cgi?id=95529 Robertchanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||broom...@yahoo.com Version|unspecified |5.1.0.3 release Ever confirmed|1 |0 --- Comment #2 from Robert --- libre won't open--never have used--instead get error message: 'The program can not be started. The service manager is not available.("file:///c:/Program%20Files%20(x86)/LibreOffice%205/program/types.rdb:no such File") Start setup Application to repair the installation from CD, or the folder containing the installation package. ...don't have CD and couldn't find the 2nd option -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99111] Using em-space (in Optima font) causes bad horizontal alignment and cursor position
https://bugs.documentfoundation.org/show_bug.cgi?id=99111 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |WORKSFORME --- Comment #9 from Aron Budea --- Reproduced in 5.0.5.2 and 5.0.6.3, not reproduced in 5.1.2.2, 5.1.3.2 and 5.2 beta1. Since 5.0 reached end of life just a few days ago, please use 5.1. Closing bug report as RESOLVED/WORKSFORME, if you're still encountering this bug, change status back to UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-1-0' - loolwsd/ChildProcessSession.cpp loolwsd/LOOLWSD.cpp loolwsd/Util.cpp
loolwsd/ChildProcessSession.cpp |2 - loolwsd/LOOLWSD.cpp |7 + loolwsd/Util.cpp| 47 +++- 3 files changed, 44 insertions(+), 12 deletions(-) New commits: commit 2db2da3bb2f7f066631fb28eb15a61e2d1d51464 Author: Ashod NakashianDate: Mon May 30 20:42:44 2016 -0400 loolwsd: more secure random directories Util::createRandomDirectory now uses /dev/urandom (and a complex pseudo-random generator where missing) to generate 64-byte long, Base64-encoded, names. This should provide ample security compared to 64-bit pseudo-random numbers hex-encoded, as was the case. Reviewed-on: https://gerrit.libreoffice.org/25696 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian (cherry picked from commit 8f3dcbcfb68393e3768f570c13598c3edf575dc3) Change-Id: I714810a9fb03b5dcdbad7a15305940bf7457149e Reviewed-on: https://gerrit.libreoffice.org/25697 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp index bf3b11b..0d07b44 100644 --- a/loolwsd/ChildProcessSession.cpp +++ b/loolwsd/ChildProcessSession.cpp @@ -786,12 +786,12 @@ bool ChildProcessSession::downloadAs(const char* /*buffer*/, int /*length*/, Str } } +// The file is removed upon downloading. const auto tmpDir = Util::createRandomDir(JAILED_DOCUMENT_ROOT); const auto url = JAILED_DOCUMENT_ROOT + tmpDir + "/" + name; std::unique_lock lock(Mutex); -//TODO: Cleanup the file after downloading. _loKitDocument->pClass->saveAs(_loKitDocument, url.c_str(), format.size() == 0 ? nullptr :format.c_str(), filterOptions.size() == 0 ? nullptr : filterOptions.c_str()); diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp index 404f576..65d5c3d 100644 --- a/loolwsd/LOOLWSD.cpp +++ b/loolwsd/LOOLWSD.cpp @@ -415,7 +415,8 @@ private: if (!resultURL.getPath().empty()) { const std::string mimeType = "application/octet-stream"; -response.sendFile(resultURL.getPath(), mimeType); +URI::encode(resultURL.getPath(), "", encodedTo); +response.sendFile(encodedTo, mimeType); sent = true; } @@ -495,6 +496,10 @@ private: Util::removeFile(dirPath, true); return true; } +else +{ +Log::error("Download file [" + filePath + "] not found."); +} } throw BadRequestException("Invalid or unknown request."); diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp index a814ae2..cad72a1 100644 --- a/loolwsd/Util.cpp +++ b/loolwsd/Util.cpp @@ -29,14 +29,16 @@ #include +#include #include #include #include #include #include +#include +#include #include #include -#include #include #include "Common.hpp" @@ -72,6 +74,7 @@ namespace rng { static std::random_device _rd; static std::mutex _rngMutex; +static Poco::RandomBuf _randBuf; // Create the prng with a random-device for seed. // If we don't have a hardware random-device, we will get the same seed. @@ -93,6 +96,35 @@ namespace rng std::unique_lock lock(_rngMutex); return _rng(); } + +std::vector getBytes(const size_t length) +{ +std::vector v(length); +_randBuf.readFromDevice(v.data(), v.size()); +return v; +} + +/// Generates a random string in Base64. +/// Note: May contain '/' characters. +std::string getB64String(const size_t length) +{ +std::stringstream ss; +Poco::Base64Encoder b64(ss); +b64 << getBytes(length).data(); +return ss.str().substr(0, length); +} + +/// Generates a random string suitable for +/// file/directory names. +std::string getFilename(const size_t length) +{ +std::stringstream ss; +Poco::Base64Encoder b64(ss); +b64 << getBytes(length).data(); +std::string s = ss.str(); +std::replace(s.begin(), s.end(), '/', '_'); +return s.substr(0, length); +} } } @@ -114,18 +146,13 @@ namespace Util return id; } +/// Create a secure, random directory path. std::string createRandomDir(const std::string& path) { Poco::File(path).createDirectories(); -for (;;) -{ -const auto name = Util::encodeId(rng::getNext()); -Poco::File dir(Poco::Path(path, name)); -if (dir.createDirectory()) -{ -return name; -} -} +const auto name = rng::getFilename(64); +
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/document.hxx| 44 starmath/source/cursor.cxx |4 starmath/source/document.cxx | 224 +-- 3 files changed, 136 insertions(+), 136 deletions(-) New commits: commit 27ae0020d7609973eaeb2d95ab1e2897c40685a8 Author: Takeshi AbeDate: Mon May 30 14:22:15 2016 +0900 Prefix SmDocShell's members as well as remaning aInterpreter to maParser. Change-Id: I5f86737ffe05be981477e9dc65d433de0e1d5378 Reviewed-on: https://gerrit.libreoffice.org/25650 Tested-by: Jenkins Reviewed-by: Takeshi Abe diff --git a/starmath/inc/document.hxx b/starmath/inc/document.hxx index 499bd56..03fac87 100644 --- a/starmath/inc/document.hxx +++ b/starmath/inc/document.hxx @@ -87,19 +87,19 @@ class SM_DLLPUBLIC SmDocShell : public SfxObjectShell, public SfxListener friend class SmPrinterAccess; friend class SmCursor; -OUStringaText; -SmFormataFormat; -SmParseraInterpreter; -OUStringaAccText; -SmNode *pTree; -SfxItemPool*pEditEngineItemPool; -EditEngine *pEditEngine; -VclPtr pPrinter; //q.v. comment to SmPrinter Access! -VclPtr pTmpPrinter;//ditto -sal_uInt16 nModifyCount; -boolbIsFormulaArranged; -std::unique_ptr pCursor; -std::set< OUString >aUsedSymbols; // to export used symbols only when saving +OUStringmaText; +SmFormatmaFormat; +SmParsermaParser; +OUStringmaAccText; +SmNode *mpTree; +SfxItemPool*mpEditEngineItemPool; +EditEngine *mpEditEngine; +VclPtr mpPrinter; //q.v. comment to SmPrinter Access! +VclPtr mpTmpPrinter;//ditto +sal_uInt16 mnModifyCount; +boolmbFormulaArranged; +std::unique_ptr mpCursor; +std::set< OUString >maUsedSymbols; // to export used symbols only when saving virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override; @@ -130,7 +130,7 @@ class SM_DLLPUBLIC SmDocShell : public SfxObjectShell, public SfxListener Printer *GetPrt(); OutputDevice* GetRefDev(); -voidSetFormulaArranged(bool bVal) { bIsFormulaArranged = bVal; } +voidSetFormulaArranged(bool bVal) { mbFormulaArranged = bVal; } virtual boolConvertFrom(SfxMedium ) override; @@ -160,8 +160,8 @@ public: //Access for the View. This access is not for the OLE-case! //and for the communication with the SFX! //All internal printer uses should work with the SmPrinterAccess only -boolHasPrinter(){ return pPrinter != nullptr; } -SfxPrinter *GetPrinter(){ GetPrt(); return pPrinter; } +boolHasPrinter(){ return mpPrinter != nullptr; } +SfxPrinter *GetPrinter(){ GetPrt(); return mpPrinter; } voidSetPrinter( SfxPrinter * ); const OUString GetComment() const; @@ -171,16 +171,16 @@ public: voidUpdateText(); voidSetText(const OUString& rBuffer); -const OUString& GetText() { return aText; } +const OUString& GetText() { return maText; } voidSetFormat(SmFormat& rFormat); -const SmFormat& GetFormat() { return aFormat; } +const SmFormat& GetFormat() { return maFormat; } voidParse(); -SmParser & GetParser() { return aInterpreter; } -const SmNode * GetFormulaTree() const { return pTree; } -voidSetFormulaTree(SmNode *) { pTree = rTree; } +SmParser & GetParser() { return maParser; } +const SmNode * GetFormulaTree() const { return mpTree; } +voidSetFormulaTree(SmNode *) { mpTree = rTree; } -const std::set< OUString > &GetUsedSymbols() const { return aUsedSymbols; } +const std::set< OUString > &GetUsedSymbols() const { return maUsedSymbols; } OUStringGetAccessibleText(); diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx index 36bc43d..de4439c 100644 --- a/starmath/source/cursor.cxx +++ b/starmath/source/cursor.cxx @@ -1413,7 +1413,7 @@ void SmCursor::EndEdit(){ mpDocShell->SetModified(true); //I think SmDocShell uses this value when it sends an update graphics event //Anyway comments elsewhere suggests it need to be updated... -mpDocShell->nModifyCount++; +mpDocShell->mnModifyCount++; //TODO: Consider copying the update accessibility code from SmDocShell::SetText in here... //This somehow updates the size of SmGraphicView if it is running in embedded mode @@ -1427,7 +1427,7 @@ void SmCursor::EndEdit(){ OUString formula; SmNodeToTextVisitor(mpTree, formula); //mpTree->CreateTextFromNode(formula); -mpDocShell->aText =
[Libreoffice-bugs] [Bug 100135] SVG: svgOpen filter looses text and labeling, svgInsert filter not honoring mask or clip-path in rendering a simple plot graphic
https://bugs.documentfoundation.org/show_bug.cgi?id=100135 V Stuart Footechanged: What|Removed |Added Summary|SVG: order of layers in |SVG: svgOpen filter looses |imported svg-graphics seems |text and labeling, |to be messed up |svgInsert filter not ||honoring mask or clip-path ||in rendering a simple plot ||graphic -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/Util.cpp
loolwsd/ChildSession.cpp |2 +- loolwsd/Util.cpp | 30 +- 2 files changed, 22 insertions(+), 10 deletions(-) New commits: commit 8f3dcbcfb68393e3768f570c13598c3edf575dc3 Author: Ashod NakashianDate: Mon May 30 20:42:44 2016 -0400 loolwsd: more secure random directories Util::createRandomDirectory now uses /dev/urandom (and a complex pseudo-random generator where missing) to generate 64-byte long, Base64-encoded, names. This should provide ample security compared to 64-bit pseudo-random numbers hex-encoded, as was the case. Change-Id: I714810a9fb03b5dcdbad7a15305940bf7457149e Reviewed-on: https://gerrit.libreoffice.org/25696 Reviewed-by: Ashod Nakashian Tested-by: Ashod Nakashian diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp index 59f96f7..e102405 100644 --- a/loolwsd/ChildSession.cpp +++ b/loolwsd/ChildSession.cpp @@ -787,12 +787,12 @@ bool ChildSession::downloadAs(const char* /*buffer*/, int /*length*/, StringToke } } +// The file is removed upon downloading. const auto tmpDir = Util::createRandomDir(JAILED_DOCUMENT_ROOT); const auto url = JAILED_DOCUMENT_ROOT + tmpDir + "/" + name; std::unique_lock lock(Mutex); -//TODO: Cleanup the file after downloading. _loKitDocument->saveAs(url.c_str(), format.size() == 0 ? nullptr :format.c_str(), filterOptions.size() == 0 ? nullptr : filterOptions.c_str()); diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp index 5c5ffe9..4e11d38 100644 --- a/loolwsd/Util.cpp +++ b/loolwsd/Util.cpp @@ -28,11 +28,13 @@ #include #include +#include #include #include #include #include #include +#include #include #include #include @@ -49,6 +51,7 @@ namespace rng { static std::random_device _rd; static std::mutex _rngMutex; +static Poco::RandomBuf _randBuf; // Create the prng with a random-device for seed. // If we don't have a hardware random-device, we will get the same seed. @@ -70,6 +73,21 @@ namespace rng std::unique_lock lock(_rngMutex); return _rng(); } + +std::vector getBytes(const size_t length) +{ +std::vector v(length); +_randBuf.readFromDevice(v.data(), v.size()); +return v; +} + +std::string getString(const size_t length) +{ +std::stringstream ss; +Poco::Base64Encoder b64(ss); +b64 << getBytes(length).data(); +return ss.str().substr(0, length); +} } } @@ -94,15 +112,9 @@ namespace Util std::string createRandomDir(const std::string& path) { Poco::File(path).createDirectories(); -for (;;) -{ -const auto name = Util::encodeId(rng::getNext()); -Poco::File dir(Poco::Path(path, name)); -if (dir.createDirectory()) -{ -return name; -} -} +const auto name = rng::getString(64); +Poco::File(Poco::Path(path, name)).createDirectories(); +return name; } std::string getTempFilePath(const std::string srcDir, const std::string& srcFilename) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/test
loolwsd/test/TileCacheTests.cpp |6 +- loolwsd/test/httpwstest.cpp |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 58580a45ce03f7c0105d3316381b73c9f4f6b325 Author: Henry CastroDate: Mon May 30 20:26:40 2016 -0400 loolwsd: test: update unit test getPartHashCodes diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp index bd2c307..95e46e9 100644 --- a/loolwsd/test/TileCacheTests.cpp +++ b/loolwsd/test/TileCacheTests.cpp @@ -563,8 +563,12 @@ void TileCacheTests::checkTiles(Poco::Net::WebSocket& socket, const std::string& getResponseMessage(socket, "status:", response, false); CPPUNIT_ASSERT_MESSAGE("did not receive a status: message as expected", !response.empty()); { +std::string line; +std::istringstream istr(response); +std::getline(istr, line); + std::cout << "status: " << response << std::endl; -Poco::StringTokenizer tokens(response, " ", Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM); +Poco::StringTokenizer tokens(line, " ", Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM); CPPUNIT_ASSERT_EQUAL(static_cast(5), tokens.count()); // Expected format is something like 'type= parts= current= width= height='. diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp index ea6..0572fbb 100644 --- a/loolwsd/test/httpwstest.cpp +++ b/loolwsd/test/httpwstest.cpp @@ -1245,10 +1245,14 @@ void HTTPWSTest::testNoExtraLoolKitsLeft() void HTTPWSTest::getPartHashCodes(const std::string status, std::vector& parts) { +std::string line; +std::istringstream istr(status); +std::getline(istr, line); + std::cerr << "Reading parts from [" << status << "]." << std::endl; // Expected format is something like 'type= parts= current= width= height='. -Poco::StringTokenizer tokens(status, " ", Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM); +Poco::StringTokenizer tokens(line, " ", Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM); CPPUNIT_ASSERT_EQUAL(static_cast(5), tokens.count()); const auto type = tokens[0].substr(std::string("type=").size()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/ImpressTileLayer.js |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 0fe4c89e5599bd5f1c2532bd687609df8b95ce17 Author: Henry CastroDate: Mon May 30 20:23:54 2016 -0400 loleaflet: adjust partName and partHash diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js b/loleaflet/src/layer/tile/ImpressTileLayer.js index 3d2d58a..2d8e8c0 100644 --- a/loleaflet/src/layer/tile/ImpressTileLayer.js +++ b/loleaflet/src/layer/tile/ImpressTileLayer.js @@ -126,14 +126,15 @@ L.ImpressTileLayer = L.TileLayer.extend({ this._preFetchPart = this._selectedPart; this._preFetchBorder = null; } - var partNames = textMsg.match(/[^\r\n]+/g); + var partMatch = textMsg.match(/[^\r\n]+/g); // only get the last matches - partNames = partNames.slice(partNames.length - this._parts); + var partHashes = partMatch.slice(partMatch.length - this._parts); + // var partNames = partMatch.slice(partMatch.length - 2 * this._parts, partMatch.length - this._parts - 1); this._map.fire('updateparts', { selectedPart: this._selectedPart, parts: this._parts, docType: this._docType, - partNames: partNames + partNames: partHashes }); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/LOKitHelper.hpp
loolwsd/LOKitHelper.hpp | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) New commits: commit 19acaecfc75a737a9d8048ddd39746beb09310cc Author: Henry CastroDate: Mon May 30 20:17:08 2016 -0400 loolwsd: bccu#1748, status: message send both ... the partnames and hashes (for presentations) diff --git a/loolwsd/LOKitHelper.hpp b/loolwsd/LOKitHelper.hpp index 46d40b1..00e13b9 100644 --- a/loolwsd/LOKitHelper.hpp +++ b/loolwsd/LOKitHelper.hpp @@ -127,18 +127,20 @@ namespace LOKitHelper for (auto i = 0; i < parts; ++i) { oss << "\n"; -if (type == LOK_DOCTYPE_PRESENTATION) +ptrValue = loKitDocument->pClass->getPartName(loKitDocument, i); +oss << ptrValue; +std::free(ptrValue); +} + +if (type == LOK_DOCTYPE_PRESENTATION) +{ +for (auto i = 0; i < parts; ++i) { +oss << "\n"; ptrValue = loKitDocument->pClass->getPartHash(loKitDocument, i); oss << ptrValue; std::free(ptrValue); } -else -{ -ptrValue = loKitDocument->pClass->getPartName(loKitDocument, i); -oss << ptrValue; -std::free(ptrValue); -} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/qa
svl/qa/unit/svl.cxx | 26 ++ 1 file changed, 26 insertions(+) New commits: commit 93874236610dd50a46b6db229e022ae364af582a Author: Laurent Balland-PoirierDate: Sun May 29 08:07:41 2016 +0200 tdf#97835 tdf#61996 tdf#95339 Add qa unit test tdf#97835: suppress decimal separator tdf#61996: skip quoted text tdf#95339: detect SSMM as seconds minutes Change-Id: Iee3ff723b0c5d2a298d8c7ef03112d5e30d4e4df Reviewed-on: https://gerrit.libreoffice.org/25597 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx index 7f4c1e8..ece214b 100644 --- a/svl/qa/unit/svl.cxx +++ b/svl/qa/unit/svl.cxx @@ -31,6 +31,8 @@ #include +#include + #include #include #include @@ -60,6 +62,7 @@ public: void testI116701(); void testDateInput(); void testIsNumberFormat(); +void testUserDefinedNumberFormats(); CPPUNIT_TEST_SUITE(Test); CPPUNIT_TEST(testNumberFormat); @@ -70,6 +73,7 @@ public: CPPUNIT_TEST(testI116701); CPPUNIT_TEST(testDateInput); CPPUNIT_TEST(testIsNumberFormat); +CPPUNIT_TEST(testUserDefinedNumberFormats); CPPUNIT_TEST_SUITE_END(); private: @@ -1080,6 +1084,28 @@ void Test::testIsNumberFormat() } } +void Test::testUserDefinedNumberFormats() +{ +LanguageType eLang = LANGUAGE_ENGLISH_US; +OUString sCode, sExpected; +SvNumberFormatter aFormatter(m_xContext, eLang); +{ // tdf#97835: suppress decimal separator +sCode = "0.##\" m\""; +sExpected = "12 m"; +checkPreviewString(aFormatter, sCode, 12.0, eLang, sExpected); +} +{ // tdf#61996: skip quoted text +sCode = "0.00\" ;\""; +sExpected = "-12.00 ;"; +checkPreviewString(aFormatter, sCode, -12.0, eLang, sExpected); +} +{ // tdf#995339: detect SSMM as second minute +sCode = "SS:MM:HH DD/MM/YY"; +sExpected = "54:23:03 02/01/00"; +checkPreviewString(aFormatter, sCode, M_PI, eLang, sExpected); +} +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/fixes22' - 3 commits -
0 files changed New commits: commit 1dca410695ab1b0db54da0605df4138b9382c331 Author: László NémethDate: Tue May 31 00:49:31 2016 +0200 empty commit (retest) Change-Id: I51cc82b153e978e9b1232cdf56f7d14936094bdb commit 78b62ce7febb56d15295aa7d0bd681cd23540640 Author: László Németh Date: Tue May 31 00:49:20 2016 +0200 empty commit (retest) Change-Id: If93161ee38e8e22f5f188b6e688b2266008a960d commit b508c3be71d35f1ed92cc210249228d6fa43194a Author: László Németh Date: Tue May 31 00:49:10 2016 +0200 empty commit (retest) Change-Id: Ie06fd2fdd6d95f722a11f30188071de815c1b1c5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/numbers/zformat.cxx | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) New commits: commit a3471916370c53c6627ba4010489f539c174bdf9 Author: Laurent Balland-PoirierDate: Sun May 29 16:48:38 2016 +0200 tdf#100122 Correctly treat fraction without integer part If there is no integer part (with format such as ?/?): - sStr should be skiped - SFrac should be completed with the right number of ?, j==0 must also be treated in ImpNumberFill Change-Id: I57448eb3b0c68e10779d7fa565379e2604f7f63b Reviewed-on: https://gerrit.libreoffice.org/25612 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 172f8021..a80fc53 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -2718,16 +2718,14 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber, else { bRes |= ImpNumberFill(sFrac, fNumber, k, j, nIx, NF_SYMBOLTYPE_FRACBLANK); +bCont = false; // there is no main number? if (rInfo.nTypeArray[j] == NF_SYMBOLTYPE_FRACBLANK) { sFrac.insert(0, rInfo.sStrArray[j]); if ( j ) { j--; -} -else -{ -bCont = false; +bCont = true; // Yes, there is a main number } } } @@ -4318,6 +4316,7 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string short eSymbolType )// type of stop condition { bool bRes = false; +bool bStop = false; const ImpSvNumberformatInfo& rInfo = NumFor[nIx].Info(); // no normal thousands separators if number divided by thousands bool bDoThousands = (rInfo.nThousand == 0); @@ -4325,7 +4324,7 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string k = sBuff.getLength(); // behind last digit -while (j > 0 && (nType = rInfo.nTypeArray[j]) != eSymbolType ) // Backwards +while (!bStop && (nType = rInfo.nTypeArray[j]) != eSymbolType ) // Backwards { switch ( nType ) { @@ -4400,7 +4399,10 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string sBuff.insert(k, rInfo.sStrArray[j]); break; } // of switch -j--; // Next String +if ( j ) +j--; // Next String +else +bStop = true; } // of while return bRes; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Check for update
@Pedro, Pedro wrote > Bump! > > One week later (and 18 days after 5.1.3 release) version 5.1.2.2 still > reports it is up to date under Windows. No the PHP script has been updated, if it is not offering 5.1.3.2 there is a new issue in the version signature checks... Christian? Robinson? =-ref-= See: https://cgit.freedesktop.org/libreoffice/website/tree/check.php?h=update -- View this message in context: http://nabble.documentfoundation.org/Check-for-update-tp4181351p4184796.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - svl/source xmloff/source
svl/source/numbers/zformat.cxx | 22 -- xmloff/source/style/xmlnumfe.cxx |5 +++-- 2 files changed, 15 insertions(+), 12 deletions(-) New commits: commit b20875755f9d5dd4e46acbb06b532d8522702651 Author: Eike RathkeDate: Tue May 31 00:02:38 2016 +0200 prevent out of bounds string access Yet another reminiscence of String to OUString conversion.. where the terminating NULL-character was obtained and SvNumberformat::InsertBlanks() effectively did nothing. Could be triggered already by entering an '_' underscore character as number format code, which is a place holder for blanks of the same width as the following character, which there isn't then yet. Change-Id: I0534e1417d4bd35e9e7ed4bd0170b9ea3b5fb575 (cherry picked from commit c75ce37560c05271ba56c9dd0d98c5001e83cc2f) Reviewed-on: https://gerrit.libreoffice.org/25692 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 0529f27..38efb37 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -1926,8 +1926,8 @@ void SvNumberformat::GetOutputString(const OUString& sString, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sOutBuff, sOutBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sOutBuff, sOutBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_KEY_GENERAL : // #77026# "General" is the same as "@" case NF_SYMBOLTYPE_DEL : @@ -2243,8 +2243,8 @@ bool SvNumberformat::GetOutputString(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -2875,8 +2875,8 @@ bool SvNumberformat::ImpGetTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3371,7 +3371,8 @@ bool SvNumberformat::ImpGetDateOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3664,8 +3665,8 @@ bool SvNumberformat::ImpGetDateTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -4311,7 +4312,8 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string } break; case NF_SYMBOLTYPE_BLANK: -k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); +if (rInfo.sStrArray[j].getLength() >= 2) +k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); break; case NF_SYMBOLTYPE_THSEP: // Same as in ImpNumberFillWithThousands() above, do not insert diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx index 229237c..c717790 100644 --- a/xmloff/source/style/xmlnumfe.cxx +++ b/xmloff/source/style/xmlnumfe.cxx @@ -1317,7 +1317,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const SvNumberformat& rFormat, sal_uInt { aEmbeddedStr = *pElemStr; } -else +else if (pElemStr->getLength() >= 2) { SvNumberformat::InsertBlanks( aEmbeddedStr, 0, (*pElemStr)[1] ); } @@ -1389,7 +1389,8 @@ void SvXMLNumFmtExport::ExportPart_Impl( const
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/style/xmlnumfe.cxx | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) New commits: commit b07e0a11766f2d2878a0dc2681feddb0c381c68d Author: Laurent Balland-PoirierDate: Sat May 28 21:56:14 2016 +0200 Choose ODF version for fill-character OASIS reference: https://issues.oasis-open.org/browse/OFFICE-3765 XML_TEXT in FinishTextElement_Impl follows a different logic See https://cgit.freedesktop.org/libreoffice/core/commit?id=66c6d1ef204f3507e7663a1b8b1be05b9ec71092 Change-Id: Iac966f74c26c2b72ed54db26cf17a35717263007 Reviewed-on: https://gerrit.libreoffice.org/25590 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx index 121a381..dc785d07 100644 --- a/xmloff/source/style/xmlnumfe.cxx +++ b/xmloff/source/style/xmlnumfe.cxx @@ -521,10 +521,17 @@ void SvXMLNumFmtExport::WriteMinutesElement_Impl( bool bLong ) void SvXMLNumFmtExport::WriteRepeatedElement_Impl( sal_Unicode nChar ) { -FinishTextElement_Impl(true); -SvXMLElementExport aElem( rExport, XML_NAMESPACE_LO_EXT, XML_FILL_CHARACTER, - true, false ); -rExport.Characters( OUString( nChar ) ); +// Export only for 1.2 with extensions or 1.3 and later. +SvtSaveOptions::ODFSaneDefaultVersion eVersion = rExport.getSaneDefaultVersion(); +if (eVersion > SvtSaveOptions::ODFSVER_012) +{ +FinishTextElement_Impl(true); +// For 1.2+ use loext namespace, for 1.3 use number namespace. +SvXMLElementExport aElem( rExport, + ((eVersion < SvtSaveOptions::ODFSVER_013) ? XML_NAMESPACE_LO_EXT : XML_NAMESPACE_NUMBER), + XML_FILL_CHARACTER, true, false ); +rExport.Characters( OUString( nChar ) ); +} } void SvXMLNumFmtExport::WriteSecondsElement_Impl( bool bLong, sal_uInt16 nDecimals ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source xmloff/source
svl/source/numbers/zformat.cxx | 22 -- xmloff/source/style/xmlnumfe.cxx |5 +++-- 2 files changed, 15 insertions(+), 12 deletions(-) New commits: commit c75ce37560c05271ba56c9dd0d98c5001e83cc2f Author: Eike RathkeDate: Tue May 31 00:02:38 2016 +0200 prevent out of bounds string access Yet another reminiscence of String to OUString conversion.. where the terminating NULL-character was obtained and SvNumberformat::InsertBlanks() effectively did nothing. Could be triggered already by entering an '_' underscore character as number format code, which is a place holder for blanks of the same width as the following character, which there isn't then yet. Change-Id: I0534e1417d4bd35e9e7ed4bd0170b9ea3b5fb575 diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx index 2f2d412..172f8021 100644 --- a/svl/source/numbers/zformat.cxx +++ b/svl/source/numbers/zformat.cxx @@ -1926,8 +1926,8 @@ void SvNumberformat::GetOutputString(const OUString& sString, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sOutBuff, sOutBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sOutBuff, sOutBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_KEY_GENERAL : // #77026# "General" is the same as "@" case NF_SYMBOLTYPE_DEL : @@ -2267,8 +2267,8 @@ bool SvNumberformat::GetOutputString(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -2899,8 +2899,8 @@ bool SvNumberformat::ImpGetTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks(sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks(sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3395,7 +3395,8 @@ bool SvNumberformat::ImpGetDateOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -3688,8 +3689,8 @@ bool SvNumberformat::ImpGetDateTimeOutput(double fNumber, } break; case NF_SYMBOLTYPE_BLANK: -InsertBlanks( sBuff, sBuff.getLength(), - rInfo.sStrArray[i][1] ); +if (rInfo.sStrArray[i].getLength() >= 2) +InsertBlanks( sBuff, sBuff.getLength(), rInfo.sStrArray[i][1] ); break; case NF_SYMBOLTYPE_STRING: case NF_SYMBOLTYPE_CURRENCY: @@ -4335,7 +4336,8 @@ bool SvNumberformat::ImpNumberFill( OUStringBuffer& sBuff, // number string } break; case NF_SYMBOLTYPE_BLANK: -k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); +if (rInfo.sStrArray[j].getLength() >= 2) +k = InsertBlanks(sBuff, k, rInfo.sStrArray[j][1] ); break; case NF_SYMBOLTYPE_THSEP: // Same as in ImpNumberFillWithThousands() above, do not insert diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx index 235920d..121a381 100644 --- a/xmloff/source/style/xmlnumfe.cxx +++ b/xmloff/source/style/xmlnumfe.cxx @@ -1347,7 +1347,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const SvNumberformat& rFormat, sal_uInt { aEmbeddedStr = *pElemStr; } -else +else if (pElemStr->getLength() >= 2) { SvNumberformat::InsertBlanks( aEmbeddedStr, 0, (*pElemStr)[1] ); } @@ -1419,7 +1419,8 @@ void SvXMLNumFmtExport::ExportPart_Impl( const SvNumberformat& rFormat, sal_uInt // (#i20396# the spaces may also be in embedded-text elements) OUString aBlanks; -
[Libreoffice-bugs] [Bug 93421] EDITING, FORMATTING: template changes do not propagate to existing documents when template is imported in newer version of LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=93421 --- Comment #15 from Cor Nouws--- Hi Jan-Bart, (In reply to janbart from comment #14) > Sorry to report that I still have this reported issue. Esp sorry for you :\ > When you tested, how did you separate the LO4 and LO5 template-paths? > And did you test 4.0.6.2 or 4.0.5.2? We are using 4.0.5.2. I created a template in 4.0.6.2 and copied it from my 406rc2/user/template to the 513rc2/user/template path I have little reason to expect that it's different with 4052... but.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/xmloff xmloff/source
include/xmloff/ProgressBarHelper.hxx |1 + xmloff/source/core/ProgressBarHelper.cxx | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) New commits: commit 0fac4acb32baf59558f46d42ce31751948f00da3 Author: Miklos VajnaDate: Mon May 30 09:29:22 2016 +0200 tdf#100134 xmloff: only update the progressbar twice for every percent This restores the state before commit e1b78d36008d1fd188ca8dc154ad069d3476520c (#95181#; call the setValue method of the XStatusIndicator as often as possible to enable reschedule, 2001-11-26), which doesn't seem to be necessary anymore, perhaps due to the current scheduler that has priorities. Rather than a plain revert, still allow the progressbar to jump back, as that seems to be used relatively frequently. So just filter out the calls that would increment the value, but only with a small difference, compared to the shown value. (cherry picked from commit 20ad9893d5d3be13d8aa17764e483afaa083b5c0) Change-Id: I7136b20f1c64e267b0b4a35bbe2564e5163d9468 Reviewed-on: https://gerrit.libreoffice.org/25666 Tested-by: Jenkins Reviewed-by: Michael Meeks Tested-by: Michael Meeks diff --git a/include/xmloff/ProgressBarHelper.hxx b/include/xmloff/ProgressBarHelper.hxx index 7eeed4e..6af3603 100644 --- a/include/xmloff/ProgressBarHelper.hxx +++ b/include/xmloff/ProgressBarHelper.hxx @@ -36,6 +36,7 @@ class XMLOFF_DLLPUBLIC ProgressBarHelper sal_Int32 nRange; sal_Int32 nReference; sal_Int32 nValue; +doublefOldPercent; bool bStrict; // #96469#; if the value goes over the Range the progressbar starts again bool bRepeat; diff --git a/xmloff/source/core/ProgressBarHelper.cxx b/xmloff/source/core/ProgressBarHelper.cxx index 719ab80..2419ecf2 100644 --- a/xmloff/source/core/ProgressBarHelper.cxx +++ b/xmloff/source/core/ProgressBarHelper.cxx @@ -25,6 +25,7 @@ using namespace ::com::sun::star; static const sal_Int32 nDefaultProgressBarRange = 100; +static const float fProgressStep = 0.5; ProgressBarHelper::ProgressBarHelper(const ::com::sun::star::uno::Reference < ::com::sun::star::task::XStatusIndicator>& xTempStatusIndicator, const bool bTempStrict) @@ -32,6 +33,7 @@ ProgressBarHelper::ProgressBarHelper(const ::com::sun::star::uno::Reference < :: , nRange(nDefaultProgressBarRange) , nReference(100) , nValue(0) +, fOldPercent(0.0) , bStrict(bTempStrict) , bRepeat(true) #ifdef DBG_UTIL @@ -87,9 +89,12 @@ void ProgressBarHelper::SetValue(sal_Int32 nTempValue) double fValue(nValue); double fNewValue ((fValue * nRange) / nReference); -xStatusIndicator->setValue((sal_Int32)fNewValue); - -// #95181# disabled, because we want to call setValue very often to enable a good reschedule +double fPercent((fNewValue * 100) / nRange); +if (fPercent >= (fOldPercent + fProgressStep) || fPercent < fOldPercent) +{ +xStatusIndicator->setValue((sal_Int32)fNewValue); +fOldPercent = fPercent; +} } #ifdef DBG_UTIL else if (!bFailure) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 99006] FORMATTING: Freeze when attempting to Insert Index/ Table of Contents and editing a Style.
https://bugs.documentfoundation.org/show_bug.cgi?id=99006 --- Comment #4 from R. Bingham--- Different Bugzilla user with a confirming instance this issue: Windows 8.1 Pro Version 6.3.9600 Build 9600 with MS patches through 30 May 2016. Processor: Intel(R) Core(TM) i7-2670QM CPU @ 2.20GHz, 2201 Mhz, 4 Core(s), 8 Logical Processor(s) LO Version: 5.1.2.2 (x64) Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f. LO Writer Insert TOC window comes up no issue but any mouse action in the window, even only tab selection with no parameter actions, starts an apparent "not responding" freeze. However, Win Task Manger shows about 16%-19% CPU use on the 4-core processor, so clearly in a loop. LO application can be terminated via Win TM. Have not attempted to wait out the loop beyond abut 5 minutes. Consistently reproducible. Win 8.1 Pro Task Manager does offer the capability to create a dump file as part of the right-click context menu for a process. In my instance the subject doc file is a custom .ott in development and does not contain PII or proprietary data. Win TM shows about a 70 MB memory usage for this doc process. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 V Stuart Footechanged: What|Removed |Added Status|RESOLVED|CLOSED Resolution|WORKSFORME |NOTABUG --- Comment #6 from V Stuart Foote --- I did see the mis-alignment of wmf -> svg text when converted headless with a LibreOffice "convert-to svg". But going to close this NAB... For doing these graphic format conversions the ImageMagick Convert utility, with a Ghostscript present, provides very clean format conversions--in fact internally LibreOffice makes use of these helper programs. So for example: "C:\Program Files\ImageMagick-7.0.1-Q16\convert.exe" image1.wmf image1.svg Other wise not sure there is any issue here. Taking a 345 x 221 px Windows Meta File--a vector format (the image is raster, but text is not)--and converting to raster format PNG, there will be loss of fidelity between the vector font of the WMF and the rasterized font of the resulting PNG used in the HTML conversion. RTF of course is a vector format. =-note-= And for Windows users, rather than unoconv --format=FTYPE , the CLI is: soffice.exe --headless --convert-to FTYPE [] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 Cor Nouwschanged: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87026] Move accessibility relations to .ui files
https://bugs.documentfoundation.org/show_bug.cgi?id=87026 --- Comment #6 from Commit Notification--- Muhammet Kara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d7834317c7c925e9096b464c5f5f3e7f76e3fda3 Move accessibility relations to .ui files tdf#87026 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig sw/source sw/uiconfig
cui/source/dialogs/zoom.cxx|5 -- cui/uiconfig/ui/zoomdialog.ui | 14 ++ sw/source/ui/misc/docfnote.cxx |2 sw/source/ui/misc/srtdlg.cxx | 17 sw/uiconfig/swriter/ui/footnotepage.ui | 68 ++--- sw/uiconfig/swriter/ui/sortdialog.ui | 29 +- 6 files changed, 78 insertions(+), 57 deletions(-) New commits: commit d7834317c7c925e9096b464c5f5f3e7f76e3fda3 Author: Muhammet KaraDate: Fri May 27 11:14:01 2016 +0300 Move accessibility relations to .ui files tdf#87026 Change-Id: I2ce2c236d124d31aaacacb0c24ba52b3a70b489c Reviewed-on: https://gerrit.libreoffice.org/2 Tested-by: Jenkins Reviewed-by: Katarina Behrens diff --git a/cui/source/dialogs/zoom.cxx b/cui/source/dialogs/zoom.cxx index 66b3e11..d79ed31 100644 --- a/cui/source/dialogs/zoom.cxx +++ b/cui/source/dialogs/zoom.cxx @@ -196,11 +196,6 @@ SvxZoomDialog::SvxZoomDialog( vcl::Window* pParent, const SfxItemSet& rCoreSet ) SetLimits(nMin, nMax); m_pUserEdit->SetValue(nValue); -m_pUserEdit->SetAccessibleName(m_pUserBtn->GetText()); -m_pColumnsEdit->SetAccessibleName(m_pColumnsBtn->GetText()); -m_pColumnsEdit->SetAccessibleRelationMemberOf(m_pColumnsBtn); -m_pBookModeChk->SetAccessibleRelationMemberOf(m_pColumnsBtn); - const SfxPoolItem& rItem = mrSet.Get(mrSet.GetPool()->GetWhich(SID_ATTR_ZOOM)); if (nullptr != dynamic_cast( )) diff --git a/cui/uiconfig/ui/zoomdialog.ui b/cui/uiconfig/ui/zoomdialog.ui index d822352..5d5df21 100644 --- a/cui/uiconfig/ui/zoomdialog.ui +++ b/cui/uiconfig/ui/zoomdialog.ui @@ -1,5 +1,5 @@ - + @@ -199,6 +199,11 @@ + + +Variable + + False @@ -320,7 +325,13 @@ adjustment1 + + + +Columns + + False @@ -350,6 +361,7 @@ True + diff --git a/sw/source/ui/misc/docfnote.cxx b/sw/source/ui/misc/docfnote.cxx index 8cea399..f457b98 100644 --- a/sw/source/ui/misc/docfnote.cxx +++ b/sw/source/ui/misc/docfnote.cxx @@ -102,8 +102,6 @@ SwEndNoteOptionPage::SwEndNoteOptionPage(vcl::Window *pParent, bool bEN, get(m_pPosChapterBox, "posdoccb"); m_pPosChapterBox->SetClickHdl(LINK(this, SwEndNoteOptionPage, PosChapterHdl)); get(m_pPosFT, "pos"); -m_pPosPageBox->SetAccessibleRelationMemberOf(m_pPosFT); -m_pPosChapterBox->SetAccessibleRelationMemberOf(m_pPosFT); get(m_pContEdit, "conted"); get(m_pContFromEdit, "contfromed"); } diff --git a/sw/source/ui/misc/srtdlg.cxx b/sw/source/ui/misc/srtdlg.cxx index d6adf60..d5d1f87 100644 --- a/sw/source/ui/misc/srtdlg.cxx +++ b/sw/source/ui/misc/srtdlg.cxx @@ -154,12 +154,6 @@ SwSortDlg::SwSortDlg(vcl::Window* pParent, SwWrtShell ) m_pTypDLB1->SetAccessibleName(m_pTypLbl->GetText()); m_pTypDLB2->SetAccessibleName(m_pTypLbl->GetText()); m_pTypDLB3->SetAccessibleName(m_pTypLbl->GetText()); -m_pSortUp1RB->SetAccessibleRelationMemberOf(m_pKeyCB1); -m_pSortDn1RB->SetAccessibleRelationMemberOf(m_pKeyCB1); -m_pSortUp2RB->SetAccessibleRelationMemberOf(m_pKeyCB2); -m_pSortDn2RB->SetAccessibleRelationMemberOf(m_pKeyCB2); -m_pSortUp3RB->SetAccessibleRelationMemberOf(m_pKeyCB3); -m_pSortDn3RB->SetAccessibleRelationMemberOf(m_pKeyCB3); m_pDelimEdt->SetMaxTextLen( 1 ); if(rSh.GetSelectionType() & @@ -237,17 +231,6 @@ SwSortDlg::SwSortDlg(vcl::Window* pParent, SwWrtShell ) m_pColEdt2->SetMax(nMax); m_pColEdt3->SetMax(nMax); } - -m_pDelimPB->SetAccessibleRelationMemberOf(m_pDelimFreeRB); - -m_pColEdt1->SetAccessibleRelationMemberOf(m_pKeyCB1); -m_pTypDLB1->SetAccessibleRelationMemberOf(m_pKeyCB1); - -m_pColEdt2->SetAccessibleRelationMemberOf(m_pKeyCB2); -m_pTypDLB2->SetAccessibleRelationMemberOf(m_pKeyCB2); - -m_pColEdt3->SetAccessibleRelationMemberOf(m_pKeyCB3); -
[Libreoffice-bugs] [Bug 93421] EDITING, FORMATTING: template changes do not propagate to existing documents when template is imported in newer version of LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=93421 janb...@familierem.nl changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #14 from janb...@familierem.nl --- Hi Cor, Sorry to report that I still have this reported issue. When you tested, how did you separate the LO4 and LO5 template-paths? And did you test 4.0.6.2 or 4.0.5.2? We are using 4.0.5.2. I tried earlier in Xubuntu but when I change the template path for LO4, I automatically change the path for LO% too. And I do not want to mix these templates, was afraid the conversion from 4 to 5 would render the template useless in 4. I tried again today in Win7 x64, with LO4.0.5.2 and the portable-apps 5.1.1. I did import the 4.0.5 template in LO5, and opened a 4.0.5 document that for sure gave me the dialogue in LO4. Opened in LO5, no luck. Closed, re-opened in 4.0.5, got the dialogue. Closed, reopened in LO5. Still no luck, I could not get the Update styles dialogue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98226] Undo "AutoFormat Table Styles" is incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=98226 Michael Stahlchanged: What|Removed |Added Status|NEW |RESOLVED CC||mst...@redhat.com Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |mst...@redhat.com |desktop.org | --- Comment #3 from Michael Stahl --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/doc.hxx |2 +- sw/inc/fesh.hxx |3 ++- sw/source/core/docnode/ndtbl.cxx |7 ++- sw/source/core/frmedt/fetab.cxx | 13 - sw/source/core/inc/UndoTable.hxx |1 + sw/source/core/undo/untbl.cxx| 13 ++--- 6 files changed, 28 insertions(+), 11 deletions(-) New commits: commit 7b042d2865c5bb2c2dde1dd47de124bc0df61ae8 Author: Michael StahlDate: Mon May 30 23:01:04 2016 +0200 tdf#98226: fix undo of table AutoFormat The new call to SwTable::SetTableStyleName() was not recorded in SwUndoTableAutoFormat and hence persisted even after Undo. (regression from 73f4a06c0bce51c7c8b9ae9adfdc7ffac27d06b4) Change-Id: Ia7f769dafa62f02ff8e4b0596b48266190c7a69b diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index afed50a..e9b3be5 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -1246,7 +1246,7 @@ public: /// AutoFormat for table/table selection. /// @param bResetDirect Reset direct formatting that might be applied to the cells. -bool SetTableAutoFormat(const SwSelBoxes& rBoxes, const SwTableAutoFormat& rNew, bool bResetDirect = false); +bool SetTableAutoFormat(const SwSelBoxes& rBoxes, const SwTableAutoFormat& rNew, bool bResetDirect = false, bool isSetStyleName = false); // Query attributes. bool GetTableAutoFormat( const SwSelBoxes& rBoxes, SwTableAutoFormat& rGet ); diff --git a/sw/inc/fesh.hxx b/sw/inc/fesh.hxx index edb6ff5..c66cb9a 100644 --- a/sw/inc/fesh.hxx +++ b/sw/inc/fesh.hxx @@ -727,7 +727,8 @@ public: /// Update the direct formatting according to the current table style. /// @param pTableNode Table node to update. When nullptr, current cursor position is used. /// @param bResetDirect Reset direct formatting that might be applied to the cells. -bool UpdateTableStyleFormatting(SwTableNode *pTableNode = nullptr, bool bResetDirect = false); +/// @param pStyleName new style to apply +bool UpdateTableStyleFormatting(SwTableNode *pTableNode = nullptr, bool bResetDirect = false, OUString const* pStyleName = nullptr); bool GetTableAutoFormat( SwTableAutoFormat& rGet ); diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx index 2b92de2..01752de 100644 --- a/sw/source/core/docnode/ndtbl.cxx +++ b/sw/source/core/docnode/ndtbl.cxx @@ -3742,7 +3742,7 @@ static bool lcl_SetAFormatBox(FndBox_ & rBox, SetAFormatTabPara *pSetPara, bool return true; } -bool SwDoc::SetTableAutoFormat(const SwSelBoxes& rBoxes, const SwTableAutoFormat& rNew, bool bResetDirect) +bool SwDoc::SetTableAutoFormat(const SwSelBoxes& rBoxes, const SwTableAutoFormat& rNew, bool bResetDirect, bool const isSetStyleName) { OSL_ENSURE( !rBoxes.empty(), "No valid Box list" ); SwTableNode* pTableNd = const_cast (rBoxes[0]->GetSttNd()->FindTableNode()); @@ -3781,6 +3781,11 @@ bool SwDoc::SetTableAutoFormat(const SwSelBoxes& rBoxes, const SwTableAutoFormat GetIDocumentUndoRedo().DoUndo(false); } +if (isSetStyleName) +{ // tdf#98226 do this here where undo can record it +pTableNd->GetTable().SetTableStyleName(rNew.GetName()); +} + rNew.RestoreTableProperties(table); SetAFormatTabPara aPara( rNew ); diff --git a/sw/source/core/frmedt/fetab.cxx b/sw/source/core/frmedt/fetab.cxx index d0fd94d..fc6108b 100644 --- a/sw/source/core/frmedt/fetab.cxx +++ b/sw/source/core/frmedt/fetab.cxx @@ -1186,11 +1186,11 @@ bool SwFEShell::SetTableStyle(const SwTableAutoFormat& rStyle) return false; // set the name & update -pTableNode->GetTable().SetTableStyleName(rStyle.GetName()); -return UpdateTableStyleFormatting(pTableNode); +return UpdateTableStyleFormatting(pTableNode, false, ()); } -bool SwFEShell::UpdateTableStyleFormatting(SwTableNode *pTableNode, bool bResetDirect) +bool SwFEShell::UpdateTableStyleFormatting(SwTableNode *pTableNode, +bool bResetDirect, OUString const*const pStyleName) { if (!pTableNode) { @@ -1199,7 +1199,9 @@ bool SwFEShell::UpdateTableStyleFormatting(SwTableNode *pTableNode, bool bResetD return false; } -OUString aTableStyleName(pTableNode->GetTable().GetTableStyleName()); +OUString const aTableStyleName((pStyleName) +? *pStyleName +: pTableNode->GetTable().GetTableStyleName()); SwTableAutoFormat* pTableStyle = GetDoc()->GetTableStyles().FindAutoFormat(aTableStyleName); if (!pTableStyle) return false; @@ -1227,7 +1229,8 @@ bool SwFEShell::UpdateTableStyleFormatting(SwTableNode *pTableNode, bool bResetD { SET_CURR_SHELL( this ); StartAllAction(); -bRet = GetDoc()->SetTableAutoFormat(aBoxes, *pTableStyle, bResetDirect); +bRet = GetDoc()->SetTableAutoFormat( +aBoxes, *pTableStyle, bResetDirect, pStyleName != nullptr); DELETEZ( pLastCols
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 ske...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from ske...@gmail.com --- I believe the issue is that the dpi of the raster image (PNG) is low. When the vector data (text) is placed into the low dpi image it is thus lacking the pixels to be clear. To get around this, one can open the .docx as .zip, copy out the .wmf files. # unoconv --format=pdf imageN.wmf # unoconv --format=svg imageN.pdf Oddly, one tries to export from .wmf to .svg directly there are some alignment issues. You may wish to open a new bug report up for this (if it doesn't already exist). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Check for update
Bump! One week later (and 18 days after 5.1.3 release) version 5.1.2.2 still reports it is up to date under Windows. Pedro wrote > > Pedro wrote >> >> Christian Lohmaier-3 wrote >>> On Sun, Apr 17, 2016 at 6:06 PM, Pedro <[hidden email]> wrote: Is is possible that the server is reporting that the latest version available is 5.1.2.1? >>> >>> Ah! thanks for testing and reporting - the info LO sends as the >>> user-agent was changed, but the check script wasn't adjusted properly, >>> so it doesn't recognize the request as coming from LibreOffice and >>> just errors out early. >> I know this only affects the few people who do QA and bug testing. >> But can this be fixed? Should I open a bug report? > I still haven't been able to check if this is still a problem. > > Is it possible that the version hasn't been updated to 5.1.3.2 (it was > released on May 12)? Is there a problem with 5.1.3.2? -- View this message in context: http://nabble.documentfoundation.org/Check-for-update-tp4181351p4184793.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 100039] while editing calc crashes, repeatedly.
https://bugs.documentfoundation.org/show_bug.cgi?id=100039 --- Comment #7 from Will MacGhee--- Have been testing with Portable Version. It appears to be working well. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88581] Set 'Enable regular expression' off by default
https://bugs.documentfoundation.org/show_bug.cgi?id=88581 Eike Rathkechanged: What|Removed |Added Version|3.3.2 release |Inherited From OOo --- Comment #10 from Eike Rathke --- Note that upcoming 5.2 also will have wildcards implemented same as in Excel. See https://wiki.documentfoundation.org/ReleaseNotes/5.2#Support_wildcards_to_be_compatible_with_XLS.2FXLSX_and_with_ODF_1.2 Loading an Excel document of course uses wildcards instead of regular expressions. So, should we disable regular expressions and enable wildcards instead in new installations' user profiles for all new documents? My take is yes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 88581] Set 'Enable regular expression' off by default
https://bugs.documentfoundation.org/show_bug.cgi?id=88581 Eike Rathkechanged: What|Removed |Added Version|3.3.2 release |Inherited From OOo --- Comment #10 from Eike Rathke --- Note that upcoming 5.2 also will have wildcards implemented same as in Excel. See https://wiki.documentfoundation.org/ReleaseNotes/5.2#Support_wildcards_to_be_compatible_with_XLS.2FXLSX_and_with_ODF_1.2 Loading an Excel document of course uses wildcards instead of regular expressions. So, should we disable regular expressions and enable wildcards instead in new installations' user profiles for all new documents? My take is yes. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 100148] Special Characters dialog -- the edit bar displays in system font rather than font family char map in use
https://bugs.documentfoundation.org/show_bug.cgi?id=100148 V Stuart Footechanged: What|Removed |Added Component|graphics stack |UI Version|5.2.0.0.alpha1 |5.1.1.1 rc -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100148] Special Characters dialog -- the edit bar displays in system font rather than font family char map in use
https://bugs.documentfoundation.org/show_bug.cgi?id=100148 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||vstuart.fo...@utsa.edu Version|5.2.0.0.alpha0+ Master |5.2.0.0.alpha1 Ever confirmed|0 |1 --- Comment #1 from V Stuart Foote --- Split from bug 97839 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100148] Special Characters dialog -- the edit bar displays in system font rather than font family char map in use
https://bugs.documentfoundation.org/show_bug.cgi?id=100148 V Stuart Footechanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=97 ||839 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 --- Comment #4 from ske...@gmail.com --- I tested PDF export as you stated by doing: # unoconv --format=pdf -eUseLosslessCompression=true Test.docx and it appears to function as you mentioned in Comment 1. Please adjust my bug report to be export to HTML *only*. Thanks for that! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100148] New: Special Characters dialog -- the edit bar displays in system font rather than font family char map in use
https://bugs.documentfoundation.org/show_bug.cgi?id=100148 Bug ID: 100148 Summary: Special Characters dialog -- the edit bar displays in system font rather than font family char map in use Product: LibreOffice Version: 5.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vstuart.fo...@utsa.edu In the Special Characters dialog, the edit bar widget displays character picks in system font rather than font family char map in use. A problem in that system font may not have coverage of Unicode code points being selected so shows a place holder glyph. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97899] FILEOPEN: Numbering format in (part of) docx files not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=97899 --- Comment #17 from Cor Nouws--- Created attachment 125401 --> https://bugs.documentfoundation.org/attachment.cgi?id=125401=edit Clean file from Word 2010 with ~ same contents So for reference I created the 'same' file in Word 201o, but new. That opens perfect in LibreOffice. This may help to find the odd stuff in the test file that does not open correct. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100125] PRINTING preview in the print dialog don' t take into account the vertical mirror for pictures
https://bugs.documentfoundation.org/show_bug.cgi?id=100125 --- Comment #10 from Julien Nabet--- Roger: Trusty has been released 2 years ago (see https://en.wikipedia.org/wiki/Ubuntu_%28operating_system%29) so that's normal it embeds an old LO version. You can find recent version by using ppa (see https://launchpad.net/~libreoffice/+archive/ubuntu/ppa) Anyway, I could reproduce Joren's and Trentanel's comment with master sources updated today on pc Debian x86-64. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/swriter/guide/section_insert.xhp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b1d1171b0dd1eda694c801478f183a0a15ae92ee Author: Olivier HallotDate: Mon May 30 17:18:11 2016 -0300 Fix help page with new term Change-Id: I2b18f319e176a426dac5401561910169de44f5b3 Reviewed-on: https://gerrit.libreoffice.org/25689 Reviewed-by: Olivier Hallot Tested-by: Olivier Hallot diff --git a/source/text/swriter/guide/section_insert.xhp b/source/text/swriter/guide/section_insert.xhp index 57e9bca..0a84586 100644 --- a/source/text/swriter/guide/section_insert.xhp +++ b/source/text/swriter/guide/section_insert.xhp @@ -77,7 +77,7 @@ -Click the browse button (...) next to the File name box. +Click the browse button (Browse...) next to the File name box. Locate the document containing the section that you want to link to, and then click Insert. @@ -94,4 +94,4 @@ - \ No newline at end of file + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ee8c883d8d65f77ec0dbd27948cbc49f30986cc6 Author: Olivier HallotDate: Mon May 30 17:18:11 2016 -0300 Updated core Project: help b1d1171b0dd1eda694c801478f183a0a15ae92ee Fix help page with new term Change-Id: I2b18f319e176a426dac5401561910169de44f5b3 Reviewed-on: https://gerrit.libreoffice.org/25689 Reviewed-by: Olivier Hallot Tested-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index a9a0e86..b1d1171 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a9a0e8625655eabdf702cfc754412488a79c0513 +Subproject commit b1d1171b0dd1eda694c801478f183a0a15ae92ee ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97899] FILEOPEN: Numbering format in (part of) docx files not imported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=97899 Cor Nouwschanged: What|Removed |Added Keywords||filter:docx Summary|Numbering format|FILEOPEN: Numbering format ||in (part of) docx files not ||imported correctly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100068] Automated creating of Libreoffice dialog screenshots
https://bugs.documentfoundation.org/show_bug.cgi?id=100068 --- Comment #1 from Commit Notification--- Katarina Behrens committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=697eaa91bd008e992b325e05ce3f20853ad965f7 tdf#100068: Initial implementation of ScreenshotId It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100068] Automated creating of Libreoffice dialog screenshots
https://bugs.documentfoundation.org/show_bug.cgi?id=100068 Commit Notificationchanged: What|Removed |Added Whiteboard||target:5.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl sc/source vcl/source
include/vcl/window.hxx | 10 ++ sc/source/ui/dbgui/scuiimoptdlg.cxx | 10 -- sc/source/ui/inc/scuiimoptdlg.hxx |3 +++ vcl/source/window/window2.cxx |5 + 4 files changed, 26 insertions(+), 2 deletions(-) New commits: commit 697eaa91bd008e992b325e05ce3f20853ad965f7 Author: Katarina BehrensDate: Wed May 25 16:10:23 2016 +0200 tdf#100068: Initial implementation of ScreenshotId it's the same as HelpId in default implementation and extended with '=?config=foo' string otherwise, depending on different configurations the dialog/tabpage can have (e.g. different widgets hidden/shown) Change-Id: I01312a5a88ef7ba784bca315b336420cdb63c8dc Reviewed-on: https://gerrit.libreoffice.org/25455 Reviewed-by: Katarina Behrens Tested-by: Katarina Behrens diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx index 62e8c64..e93870c 100644 --- a/include/vcl/window.hxx +++ b/include/vcl/window.hxx @@ -1180,6 +1180,16 @@ public: voidSetHelpId( const OString& ); const OString& GetHelpId() const; +/** String ID of this window for the purpose of creating a screenshot + +In default implementation this ID is the same as HelpId. Override this method +in windows (dialogs,tabpages) that need different IDs for different configurations +they can be in + +@return screenshot ID of this window +*/ +virtual OString GetScreenshotId() const; + vcl::Window*FindWindow( const Point& rPos ) const; sal_uInt16 GetChildCount() const; diff --git a/sc/source/ui/dbgui/scuiimoptdlg.cxx b/sc/source/ui/dbgui/scuiimoptdlg.cxx index 114ec3c..a32b361 100644 --- a/sc/source/ui/dbgui/scuiimoptdlg.cxx +++ b/sc/source/ui/dbgui/scuiimoptdlg.cxx @@ -107,7 +107,8 @@ ScImportOptionsDlg::ScImportOptionsDlg( boolbOnlyDbtoolsEncodings, boolbImport ) : ModalDialog ( pParent, "ImOptDialog", -"modules/scalc/ui/imoptdialog.ui" ) +"modules/scalc/ui/imoptdialog.ui" ), +m_bIsAsciiImport( bAscii ) { get(m_pFieldFrame, "fieldframe"); get(m_pFtCharset, "charsetft"); @@ -291,7 +292,7 @@ sal_uInt16 ScImportOptionsDlg::GetCodeFromCombo( const ComboBox& rEd ) const if ( aStr.isEmpty() ) { -nCode = 0; // kein Trennzeichen +nCode = 0; // no separator } else { @@ -304,6 +305,11 @@ sal_uInt16 ScImportOptionsDlg::GetCodeFromCombo( const ComboBox& rEd ) const return nCode; } +OString ScImportOptionsDlg::GetScreenshotId() const +{ +return (m_bIsAsciiImport) ? GetHelpId() : GetHelpId() + "?config=NonTextImport"; +} + IMPL_LINK_TYPED( ScImportOptionsDlg, FixedWidthHdl, Button*, pCheckBox, void ) { if (pCheckBox == m_pCbFixed) diff --git a/sc/source/ui/inc/scuiimoptdlg.hxx b/sc/source/ui/inc/scuiimoptdlg.hxx index 9848e33..f4a29ca 100644 --- a/sc/source/ui/inc/scuiimoptdlg.hxx +++ b/sc/source/ui/inc/scuiimoptdlg.hxx @@ -40,6 +40,7 @@ public: virtual void dispose() override; void GetImportOptions( ScImportOptions& rOptions ) const; +virtual OString GetScreenshotId() const override; private: VclPtr m_pFieldFrame; @@ -60,6 +61,8 @@ private: ScDelimiterTable* pFieldSepTab; ScDelimiterTable* pTextSepTab; +bool m_bIsAsciiImport; + private: sal_uInt16 GetCodeFromCombo( const ComboBox& rEd ) const; diff --git a/vcl/source/window/window2.cxx b/vcl/source/window/window2.cxx index 00475f1..801943b 100644 --- a/vcl/source/window/window2.cxx +++ b/vcl/source/window/window2.cxx @@ -909,6 +909,11 @@ const OString& Window::GetHelpId() const return mpWindowImpl->maHelpId; } +OString Window::GetScreenshotId() const +{ +return GetHelpId(); +} + // - old inline methods --- vcl::Window* Window::ImplGetWindow() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 --- Comment #3 from ske...@gmail.com --- # unoconv --format=html Thermo\ Test.docx generates an html file with the image encoded in base64 (as expected) but the text is blurry (compressed). Take a look at the 31.8 °C. It is blurry and looks almost out of phase. # unoconv --format=rtf Thermo\ Test.docx Open the generated RTF file. Take a look at the 31.8 °C. It is clear, as expected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 --- Comment #2 from ske...@gmail.com --- Created attachment 125400 --> https://bugs.documentfoundation.org/attachment.cgi?id=125400=edit png as exported with --format=html ; blurry text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100143] libreoffice 5.1 crashes on opening an XLS file
https://bugs.documentfoundation.org/show_bug.cgi?id=100143 Julien Nabetchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet --- Is Java 32 bits (1.6, 1.7, 1.8) installed or only Java 64 bits? Indeed, LO 32 bits can only work with Java 32 bits. (and LO 64 bits can only work with Java 64 bits) Also, for the test, could you rename your LO directory profile (see https://wiki.documentfoundation.org/UserProfile#Windows)? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100146] Embedded images export / convert with degraded resolution
https://bugs.documentfoundation.org/show_bug.cgi?id=100146 V Stuart Footechanged: What|Removed |Added CC||vstuart.fo...@utsa.edu Version|unspecified |5.1.2.2 release --- Comment #1 from V Stuart Foote --- On windows 10 Pro 64-bit en-US with Version: 5.1.3.2 (x64) Build ID: 644e4637d1d8544fd9f56425bd6cec110e49301b CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Locale: en-US (en_US) Can not confirm. Of three embedded images, one is PNG and the others are WMF. The main composition is a WMF at 345 x 221 px in 24-bit color. It renders correctly when exported to PDF (lossless compression) with no sign of resampling or pixelation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100140] Crash after exiting report editor
https://bugs.documentfoundation.org/show_bug.cgi?id=100140 --- Comment #2 from Caolán McNamara--- java deliberately produces SIGSEGVs which is normally handles without it getting to the app. Under gdb, gdb will stop at the SIGSEGV and you have to "cont" to get to the "real" segv. How do you know if its a "real" segv or a java-raised one. I tend to just "up" a few times and see that its all libjvm foo and do cont when I see that and do the same the next time if its also in libjvm stuff. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100057] FILEOPEN: large XML sheet files causes crash/hang in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=100057 --- Comment #8 from Commit Notification--- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bce5cdcc7f59da19c063205c6c79fc30874cb5ee=libreoffice-5-2 Resolves: tdf#100057 force libxslt to give up when we cancel a transformation It will be available in 5.2.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100057] FILEOPEN: large XML sheet files causes crash/hang in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=100057 Commit Notificationchanged: What|Removed |Added Whiteboard|target:5.3.0|target:5.3.0 target:5.2.0.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - filter/source
filter/source/xsltfilter/LibXSLTTransformer.cxx | 26 ++--- filter/source/xsltfilter/LibXSLTTransformer.hxx | 69 +++- 2 files changed, 53 insertions(+), 42 deletions(-) New commits: commit bce5cdcc7f59da19c063205c6c79fc30874cb5ee Author: Caolán McNamaraDate: Mon May 30 17:47:06 2016 +0100 Resolves: tdf#100057 force libxslt to give up when we cancel a transformation we're already using libxslt internals, so using XSLT_STATE_STOPPED isn't an additional exposure This probably isn't all that useful to the original reporter in terms of importing useful data, but it does turn a hopeless situation into something that can be cancelled. Change-Id: I08e9a1dcd9ee78e1804faec500bbcca36a546988 (cherry picked from commit 2805adb0d3cf68d7def01a93bf07fb2e8121ec10) diff --git a/filter/source/xsltfilter/LibXSLTTransformer.cxx b/filter/source/xsltfilter/LibXSLTTransformer.cxx index 3dbe7a4..55f1920 100644 --- a/filter/source/xsltfilter/LibXSLTTransformer.cxx +++ b/filter/source/xsltfilter/LibXSLTTransformer.cxx @@ -203,7 +203,8 @@ namespace XSLT Reader::Reader(LibXSLTTransformer* transformer) : Thread("LibXSLTTransformer"), m_transformer(transformer), -m_readBuf(INPUT_BUFFER_SIZE), m_writeBuf(OUTPUT_BUFFER_SIZE) +m_readBuf(INPUT_BUFFER_SIZE), m_writeBuf(OUTPUT_BUFFER_SIZE), +m_tcontext(nullptr) { LIBXML_TEST_VERSION; } @@ -288,7 +289,6 @@ namespace XSLT xsltStylesheetPtr styleSheet = xsltParseStylesheetFile( reinterpret_cast(m_transformer->getStyleSheetURL().getStr())); xmlDocPtr result = nullptr; -xsltTransformContextPtr tcontext = nullptr; exsltRegisterAll(); registerExtensionModule(); #ifdef DEBUG_FILTER_LIBXSLTTRANSFORMER @@ -298,11 +298,11 @@ namespace XSLT std::unique_ptr oh(new OleHandler(m_transformer->getComponentContext())); if (styleSheet) { -tcontext = xsltNewTransformContext(styleSheet, doc); -tcontext->_private = static_cast (oh.get()); -xsltQuoteUserParams(tcontext, [0]); +m_tcontext = xsltNewTransformContext(styleSheet, doc); +m_tcontext->_private = static_cast (oh.get()); +xsltQuoteUserParams(m_tcontext, [0]); result = xsltApplyStylesheetUser(styleSheet, doc, nullptr, nullptr, nullptr, -tcontext); + m_tcontext); } if (result) @@ -330,7 +330,8 @@ namespace XSLT closeOutput(); oh.reset(); xsltFreeStylesheet(styleSheet); -xsltFreeTransformContext(tcontext); +xsltFreeTransformContext(m_tcontext); +m_tcontext = nullptr; xmlFreeDoc(doc); xmlFreeDoc(result); } @@ -351,6 +352,16 @@ namespace XSLT } +void Reader::forceStateStopped() +{ +if (!m_tcontext) +return; +//tdf#100057 If we force a cancel, libxslt will of course just keep on going unless something +//tells it to stop. Here we force the stopped state so that libxslt will stop processing +//and so Reader::execute will complete and we can join cleanly +m_tcontext->state = XSLT_STATE_STOPPED; +} + Reader::~Reader() { } @@ -455,6 +466,7 @@ namespace XSLT if (m_Reader.is()) { m_Reader->terminate(); +m_Reader->forceStateStopped(); m_Reader->join(); } m_Reader.clear(); diff --git a/filter/source/xsltfilter/LibXSLTTransformer.hxx b/filter/source/xsltfilter/LibXSLTTransformer.hxx index d276018..9c4485b 100644 --- a/filter/source/xsltfilter/LibXSLTTransformer.hxx +++ b/filter/source/xsltfilter/LibXSLTTransformer.hxx @@ -47,6 +47,36 @@ using ::std::map; namespace XSLT { +class LibXSLTTransformer; + +/* + * Reader provides a worker thread to perform the actual transformation. + * It pipes the streams provided by a LibXSLTTransformer + * instance through libxslt. + */ +class Reader : public salhelper::Thread +{ +public: +Reader(LibXSLTTransformer* transformer); +int SAL_CALL read(char * buffer, int len); +int SAL_CALL write(const char * buffer, int len); +void forceStateStopped(); +int SAL_CALL closeOutput(); + +private: +virtual ~Reader(); + +static const sal_Int32 OUTPUT_BUFFER_SIZE; +static const sal_Int32 INPUT_BUFFER_SIZE; +LibXSLTTransformer* m_transformer; +Sequence m_readBuf; +Sequence m_writeBuf; +xsltTransformContextPtr m_tcontext; + +virtual void execute() override; +static void SAL_CALL registerExtensionModule(); +}; + /* * LibXSLTTransformer provides an transforming pipe service to XSLTFilter.
[Libreoffice-bugs] [Bug 100057] FILEOPEN: large XML sheet files causes crash/hang in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=100057 Caolán McNamarachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Caolán McNamara --- caolanm->maxim: The "cancel" didn't cancel for me straight away, it got stuck waiting for libxslt to complete. The above makes "cancel" cancel in reasonable time for me with this document. Other than that, yeah, there's not much I think we can go wrt xslt filters cause its not really the right tech for this sort of import thing. I think this is as good as it gets without a replacement custom import filter. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source
sc/source/core/data/document10.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e19be2e175e146152a08982e411b01ba8f0c2bb1 Author: Eike RathkeDate: Mon May 30 21:35:07 2016 +0200 we already have pClipDoc Change-Id: I0485f15b6771d10d4b077f5034db77e4c13ef877 (cherry picked from commit f65b29ff13211449144455668014a80aa8b331a3) Reviewed-on: https://gerrit.libreoffice.org/25687 Reviewed-by: Eike Rathke Tested-by: Eike Rathke diff --git a/sc/source/core/data/document10.cxx b/sc/source/core/data/document10.cxx index 6363265..0530566 100644 --- a/sc/source/core/data/document10.cxx +++ b/sc/source/core/data/document10.cxx @@ -82,7 +82,7 @@ bool ScDocument::CopyOneCellFromClip( if (nDestColSize < nSrcColSize) return false; -if (rCxt.getClipDoc()->maTabs.size() > 1) +if (pClipDoc->maTabs.size() > 1) // Copying from multiple source sheets is not handled here. return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/document10.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f65b29ff13211449144455668014a80aa8b331a3 Author: Eike RathkeDate: Mon May 30 21:35:07 2016 +0200 we already have pClipDoc Change-Id: I0485f15b6771d10d4b077f5034db77e4c13ef877 diff --git a/sc/source/core/data/document10.cxx b/sc/source/core/data/document10.cxx index 6363265..0530566 100644 --- a/sc/source/core/data/document10.cxx +++ b/sc/source/core/data/document10.cxx @@ -82,7 +82,7 @@ bool ScDocument::CopyOneCellFromClip( if (nDestColSize < nSrcColSize) return false; -if (rCxt.getClipDoc()->maTabs.size() > 1) +if (pClipDoc->maTabs.size() > 1) // Copying from multiple source sheets is not handled here. return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 100140] Crash after exiting report editor
https://bugs.documentfoundation.org/show_bug.cgi?id=100140 Julien Nabetchanged: What|Removed |Added Keywords||haveBacktrace Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100140] Crash after exiting report editor
https://bugs.documentfoundation.org/show_bug.cgi?id=100140 Julien Nabetchanged: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Created attachment 125399 --> https://bugs.documentfoundation.org/attachment.cgi?id=125399=edit console bt logs On pc Debian x86-64 with master sources updated today, I could reproduce the crash and attached a bt (quite different from the existing one, I don't know why). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96451] UI isn't properly refreshed when inserting formula
https://bugs.documentfoundation.org/show_bug.cgi?id=96451 V Stuart Footechanged: What|Removed |Added CC||silva...@katamail.com --- Comment #14 from V Stuart Foote --- *** Bug 100142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100142] when creating or editing math equation in calc, screen corruption ensues
https://bugs.documentfoundation.org/show_bug.cgi?id=100142 V Stuart Footechanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote --- *** This bug has been marked as a duplicate of bug 96451 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92315] Writer renders incorrectly EMF files with text in them
https://bugs.documentfoundation.org/show_bug.cgi?id=92315 Michael Stahlchanged: What|Removed |Added Component|Writer |graphics stack -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs