[Libreoffice-commits] core.git: basctl/source

[Gökhan Gurbetoğlu]

 basctl/source/basicide/baside2.hxx  |2 +-
 basctl/source/basicide/baside2b.cxx |8 
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit fbed9850fd51327b9ca5971f603a06a49483ac14
Author: Gökhan Gurbetoğlu 
Date:   Wed Jun 15 12:24:05 2016 +0300

Fixed a typo where highlighting was highlightning

Or maybe it was intentionally done by some lightning superpowered guy?

Change-Id: I76c6b6ef94dae4c97a26537451cff0179074995b
Reviewed-on: https://gerrit.libreoffice.org/26295
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/basctl/source/basicide/baside2.hxx 
b/basctl/source/basicide/baside2.hxx
index b35af38..ba5caba 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -102,7 +102,7 @@ private:
 voidImpDoHighlight( sal_uLong nLineOff );
 voidImplSetFont();
 
-boolbHighlightning;
+boolbHighlighting;
 boolbDoSyntaxHighlight;
 boolbDelayHighlight;
 
diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index 7b31978..d1159c8 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -222,7 +222,7 @@ EditorWindow::EditorWindow (vcl::Window* pParent, 
ModulWindow* pModulWindow) :
 rModulWindow(*pModulWindow),
 nCurTextWidth(0),
 aHighlighter(HighlighterLanguage::Basic),
-bHighlightning(false),
+bHighlighting(false),
 bDoSyntaxHighlight(true),
 bDelayHighlight(true),
 pCodeCompleteWnd(VclPtr::Create(this))
@@ -1263,7 +1263,7 @@ void EditorWindow::DoDelayedSyntaxHighlight( sal_uLong 
nPara )
 if ( pProgress )
 pProgress->StepProgress();
 
-if ( !bHighlightning && bDoSyntaxHighlight )
+if ( !bHighlighting && bDoSyntaxHighlight )
 {
 if ( bDelayHighlight )
 {
@@ -1282,7 +1282,7 @@ IMPL_LINK_NOARG_TYPED(EditorWindow, SyntaxTimerHdl, Idle 
*, void)
 bool const bWasModified = pEditEngine->IsModified();
 //pEditEngine->SetUpdateMode(false);
 
-bHighlightning = true;
+bHighlighting = true;
 for ( std::set::const_iterator it = aSyntaxLineTable.begin();
   it != aSyntaxLineTable.end(); ++it )
 {
@@ -1297,7 +1297,7 @@ IMPL_LINK_NOARG_TYPED(EditorWindow, SyntaxTimerHdl, Idle 
*, void)
 pEditEngine->SetModified( bWasModified );
 
 aSyntaxLineTable.clear();
-bHighlightning = false;
+bHighlighting = false;
 }
 
 void EditorWindow::ParagraphInsertedDeleted( sal_uLong nPara, bool bInserted )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 90309] FILEOPEN: Add chart support to RTF importer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90309

Luke  changed:

   What|Removed |Added

   Keywords|bibisected  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90309] FILEOPEN: Add chart support to RTF importer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90309

Luke  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
   Severity|normal  |enhancement

--- Comment #8 from Luke  ---
Miklos Vajna,
The issue is with the RTF bugdoc. On first load in Word in "Protected View",
the colors are Yellow/Red. After you click "Enable Editing", the colors switch
to Yellow/Turquoise (Word export bug?).

Since we display the same Yellow/Red colors as Word's "Protected View", I'm
going to change this from a Bug to an Enhancement. In Order to display this the
same as Word's Normal View we're going to have add Chart support to our RTF
importer instead of displaying the incorrect thumbnail. 

I don't think there's anything wrong the OOXML importer here. Writer matches
Word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/qa

[Ashod Nakashian]

 comphelper/qa/unit/threadpooltest.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 875c553f5d5f5d2329bf40b1b39118259ec6a93b
Author: Ashod Nakashian 
Date:   Thu Jun 16 01:01:45 2016 -0400

Expect fewer than MAX_CONCURRENCY threads in test (2)

Change-Id: I895ae4dea12e66fcbd0f4635c6ba5915d0431187
Reviewed-on: https://gerrit.libreoffice.org/26346
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/comphelper/qa/unit/threadpooltest.cxx 
b/comphelper/qa/unit/threadpooltest.cxx
index 388dffa..d71a111 100644
--- a/comphelper/qa/unit/threadpooltest.cxx
+++ b/comphelper/qa/unit/threadpooltest.cxx
@@ -44,7 +44,7 @@ void ThreadPoolTest::testPreferredConcurrency() {
 // Revert and check. Again, nothing should change.
 unsetenv("MAX_CONCURRENCY");
 nThreads = comphelper::ThreadPool::getPreferredConcurrency();
-CPPUNIT_ASSERT_EQUAL(nExpected, nThreads);
+CPPUNIT_ASSERT_MESSAGE("Expected no more than 4 threads", nExpected >= 
nThreads);
 #endif
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/Rosemary/change-tracking' - xmloff/source

[Rosemary Sebastian]

 xmloff/source/text/XMLRedlineExport.cxx |   35 
 xmloff/source/text/XMLRedlineExport.hxx |5 
 2 files changed, 40 deletions(-)

New commits:
commit 7b2d588fa7dd162c132103500774b278fc149e80
Author: Rosemary Sebastian 
Date:   Thu Jun 16 09:19:51 2016 +0530

No need to export changes inline

Change-Id: I11340715aa40fa490339e03c09509d334dc289dd

diff --git a/xmloff/source/text/XMLRedlineExport.cxx 
b/xmloff/source/text/XMLRedlineExport.cxx
index daa0f0b..b4451fd 100644
--- a/xmloff/source/text/XMLRedlineExport.cxx
+++ b/xmloff/source/text/XMLRedlineExport.cxx
@@ -115,10 +115,6 @@ void XMLRedlineExport::ExportChange(
 if (pCurrentChangesList != nullptr)
 ExportChangeAutoStyle(rPropSet);
 }
-else
-{
-ExportChangeInline(rPropSet);
-}
 }
 
 
@@ -324,37 +320,6 @@ void XMLRedlineExport::ExportChangesListAutoStyles()
 }
 }
 
-void XMLRedlineExport::ExportChangeInline(
-const Reference & rPropSet)
-{
-// determine element name (depending on collapsed, start/end)
-enum XMLTokenEnum eElement = XML_TOKEN_INVALID;
-Any aAny = rPropSet->getPropertyValue(sIsCollapsed);
-bool bCollapsed = *static_cast(aAny.getValue());
-if (bCollapsed)
-{
-eElement = XML_CHANGE;
-}
-else
-{
-aAny = rPropSet->getPropertyValue(sIsStart);
-const bool bStart = *static_cast(aAny.getValue());
-eElement = bStart ? XML_CHANGE_START : XML_CHANGE_END;
-}
-
-if (XML_TOKEN_INVALID != eElement)
-{
-// we always need the ID
-rExport.AddAttribute(XML_NAMESPACE_TEXT, XML_CHANGE_ID,
- GetRedlineID(rPropSet));
-
-// export the element (no whitespace because we're in the text body)
-SvXMLElementExport aChangeElem(rExport, XML_NAMESPACE_TEXT,
-   eElement, false, false);
-}
-}
-
-
 void XMLRedlineExport::ExportChangedRegion(
 const Reference & rPropSet)
 {
diff --git a/xmloff/source/text/XMLRedlineExport.hxx 
b/xmloff/source/text/XMLRedlineExport.hxx
index 08e8973..1ece917 100644
--- a/xmloff/source/text/XMLRedlineExport.hxx
+++ b/xmloff/source/text/XMLRedlineExport.hxx
@@ -146,11 +146,6 @@ public:
 
 private:
 
-/// export the change mark contained in the text body
-void ExportChangeInline(
-/// PropertySet of RedlinePortion
-const css::uno::Reference & rPropSet);
-
 /// export the auto styles used in this change
 void ExportChangeAutoStyle(
 /// PropertySet of RedlinePortion
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

--- Comment #11 from Óvári  ---
(In reply to V Stuart Foote from comment #10)
> And I still rather strongly feel that cross-platform

Zombie Keys is a cross-platform solution (Windows, Linux, Mac) and multiple
software (Firefox, Thunderbird, Postbox, …) as the video "Zombie Keys Release!"
Published on Jun 12, 2016:
https://www.youtube.com/watch?v=L6im2iWSTIM

It provides speed as it can be totally used with the keyboard, similar to:
Emoji and in-word replacement support
https://wiki.documentfoundation.org/ReleaseNotes/5.0#Emoji_and_in-word_replacement_support

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

--- Comment #11 from Óvári  ---
(In reply to V Stuart Foote from comment #10)
> And I still rather strongly feel that cross-platform

Zombie Keys is a cross-platform solution (Windows, Linux, Mac) and multiple
software (Firefox, Thunderbird, Postbox, …) as the video "Zombie Keys Release!"
Published on Jun 12, 2016:
https://www.youtube.com/watch?v=L6im2iWSTIM

It provides speed as it can be totally used with the keyboard, similar to:
Emoji and in-word replacement support
https://wiki.documentfoundation.org/ReleaseNotes/5.0#Emoji_and_in-word_replacement_support

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: starmath/source

[Takeshi Abe]

 starmath/source/parse.cxx |   41 -
 1 file changed, 20 insertions(+), 21 deletions(-)

New commits:
commit fca1c92a2b79480f7842a90698115ae862442df9
Author: Takeshi Abe 
Date:   Wed Jun 15 20:32:44 2016 +0900

starmath: more assertions hold

Change-Id: I9a7fb2f4d45c5b34c0ea1d186dd90353fedc8a6d
Reviewed-on: https://gerrit.libreoffice.org/26299
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 26f6f45..647426b 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -30,6 +30,7 @@
 #include "smdll.hxx"
 #include "smmod.hxx"
 #include "cfgitem.hxx"
+#include 
 #include 
 
 using namespace ::com::sun::star::i18n;
@@ -1573,23 +1574,22 @@ void SmParser::DoEscape()
 
 void SmParser::DoOperator()
 {
-if (TokenInGroup(TG::Oper))
-{
-std::unique_ptr pSNode(new SmOperNode(m_aCurToken));
+assert(TokenInGroup(TG::Oper));
 
-// put operator on top of stack
-DoOper();
+std::unique_ptr pSNode(new SmOperNode(m_aCurToken));
 
-if (TokenInGroup(TG::Limit) || TokenInGroup(TG::Power))
-DoSubSup(m_aCurToken.nGroup);
-SmNode *pOperator = popOrZero(m_aNodeStack);
+// put operator on top of stack
+DoOper();
 
-// get argument
-DoPower();
+if (TokenInGroup(TG::Limit) || TokenInGroup(TG::Power))
+DoSubSup(m_aCurToken.nGroup);
+SmNode *pOperator = popOrZero(m_aNodeStack);
 
-pSNode->SetSubNodes(pOperator, popOrZero(m_aNodeStack));
-m_aNodeStack.push_front(std::move(pSNode));
-}
+// get argument
+DoPower();
+
+pSNode->SetSubNodes(pOperator, popOrZero(m_aNodeStack));
+m_aNodeStack.push_front(std::move(pSNode));
 }
 
 void SmParser::DoOper()
@@ -1647,7 +1647,7 @@ void SmParser::DoOper()
 
 void SmParser::DoUnOper()
 {
-OSL_ENSURE(TokenInGroup(TG::UnOper), "Sm: wrong token");
+assert(TokenInGroup(TG::UnOper));
 
 SmToken  aNodeToken = m_aCurToken;
 SmTokenType  eType  = m_aCurToken.eType;
@@ -1747,7 +1747,7 @@ void SmParser::DoUnOper()
 
 void SmParser::DoAttribut()
 {
-OSL_ENSURE(TokenInGroup(TG::Attribute), "Sm: wrong token group");
+assert(TokenInGroup(TG::Attribute));
 
 std::unique_ptr pSNode(new SmAttributNode(m_aCurToken));
 SmNode  *pAttr;
@@ -1783,7 +1783,7 @@ void SmParser::DoAttribut()
 
 void SmParser::DoFontAttribut()
 {
-OSL_ENSURE(TokenInGroup(TG::FontAttr), "Sm: wrong token group");
+assert(TokenInGroup(TG::FontAttr));
 
 switch (m_aCurToken.eType)
 {
@@ -1815,7 +1815,7 @@ void SmParser::DoFontAttribut()
 
 void SmParser::DoColor()
 {
-OSL_ENSURE(m_aCurToken.eType == TCOLOR, "Sm : Ooops...");
+assert(m_aCurToken.eType == TCOLOR);
 
 // last color rules, get that one
 SmToken  aToken;
@@ -1835,7 +1835,7 @@ void SmParser::DoColor()
 
 void SmParser::DoFont()
 {
-OSL_ENSURE(m_aCurToken.eType == TFONT, "Sm : Ooops...");
+assert(m_aCurToken.eType == TFONT);
 
 // last font rules, get that one
 SmToken  aToken;
@@ -1878,7 +1878,7 @@ static bool lcl_IsNumber(const OUString& rText)
 
 void SmParser::DoFontSize()
 {
-OSL_ENSURE(m_aCurToken.eType == TSIZE, "Sm : Ooops...");
+assert(m_aCurToken.eType == TSIZE);
 
 FontSizeType   Type;
 std::unique_ptr pFontNode(new SmFontNode(m_aCurToken));
@@ -1944,8 +1944,7 @@ void SmParser::DoFontSize()
 
 void SmParser::DoBrace()
 {
-OSL_ENSURE(m_aCurToken.eType == TLEFT  ||  TokenInGroup(TG::LBrace),
-"Sm: kein Klammer Ausdruck");
+assert(m_aCurToken.eType == TLEFT  ||  TokenInGroup(TG::LBrace));
 
 std::unique_ptr pSNode(new SmBraceNode(m_aCurToken));
 SmNode *pBody   = nullptr,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99996] Wrong formatting of numbers if a format code of 'Fraction' type is used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=6

Aron Budea  changed:

   What|Removed |Added

   Keywords||needAdvice
 CC||ba...@caesar.elte.hu
  Component|UI  |Calc

--- Comment #1 from Aron Budea  ---
This seems to be something for Calc developers to look at.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100318] Different FreeType antialiasing style in LO 5.2 Beta, on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100318

Aron Budea  changed:

   What|Removed |Added

 OS|All |Linux (All)

--- Comment #12 from Aron Budea  ---
I'm sorry to hear that, but also understand your decision, as getting to the
end of this could take some time.

Just as a note, I wonder where you've been getting your dependency errors from,
Step 3 from [1] typically doesn't give any issues. After that, Step 4 is
important, but Step 5/6 should normally be skipped.
Also, I don't remember beta1 having install issues, bug 100284 where I saw you
commenting refers to beta2.

Thanks for your patience so far, and we'll be looking forward to hearing your
feedback after the final release.

[1] https://wiki.documentfoundation.org/Installing_in_parallel/Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98106] FILESAVE: Hidden cells became visible when saving a .XLSX file with filter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98106

Bartosz Kosiorek  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98106] FILESAVE: Hidden cells became visible when saving a .XLSX file with filter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98106

Bartosz Kosiorek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #6 from Bartosz Kosiorek  ---
I think I found possible fix in xetable.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43175] EDITING: Sheet references not correctly updated in charts when copying multiple sheets in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43175

--- Comment #15 from ryec...@gmail.com ---
When copying sheet containing a chart, for example, if i copied sheet 'A' to
sheet 'B', all data reference about A must be replaced with B in new sheet.

But chart still refers to 'A' sheet data.

Is there any way to fix this libreoffice bug ?

I am using libreoffice 4.2.8.2 under Ubuntu 14.04.4 LTS

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/qa

[Ashod Nakashian]

 comphelper/qa/unit/threadpooltest.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3ab13873ebb6dc4738be2e2184ee4433a2447c1d
Author: Ashod Nakashian 
Date:   Wed Jun 15 21:11:34 2016 -0400

Expect fewer than MAX_CONCURRENCY threads in test

Change-Id: I4346b6d79b46bccb5b79e27744c3cf80aa88fc9a
Reviewed-on: https://gerrit.libreoffice.org/26344
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/comphelper/qa/unit/threadpooltest.cxx 
b/comphelper/qa/unit/threadpooltest.cxx
index a90d5b0..388dffa 100644
--- a/comphelper/qa/unit/threadpooltest.cxx
+++ b/comphelper/qa/unit/threadpooltest.cxx
@@ -31,7 +31,7 @@ void ThreadPoolTest::testPreferredConcurrency() {
 // Check default.
 auto nThreads = comphelper::ThreadPool::getPreferredConcurrency();
 sal_Int32 nExpected = 4; // UTs are capped to 4.
-CPPUNIT_ASSERT_EQUAL(nExpected, nThreads);
+CPPUNIT_ASSERT_MESSAGE("Expected no more than 4 threads", nExpected >= 
nThreads);
 
 #ifndef _WIN32_WINNT
 // The result should be cached, so this should change anything.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100408] calc: wrong comment visualization

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100408

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #2 from Aron Budea  ---
Created attachment 125682
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125682=edit
Screenshot of comment on an old U100 netbook

This seems to be an Intel Bay Trail chipset-powered device. While I could not
reproduce the issue in a VM with LO 5.1.3.2 / Ubuntu 15.10, I could reproduce a
badly rendered comment with a 7-year-old MSI U100 netbook (see attachment),
which makes me wonder if this is more related to Intel's notoriously poor
graphics drivers (at least for older architectures).
Have you had similar experience with different devices, using different GPUs?

This page has some tips, but I can't comment on any specific one:
https://wiki.archlinux.org/index.php/intel_graphics

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100318] Different FreeType antialiasing style in LO 5.2 Beta, on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100318

--- Comment #11 from Paul  ---
I'm going to give up on this, as I haven't the time. I just went through the
whole sequence for the custom installation, but got a bunch of errors, mostly
citing dependencies, preventing the program from installing. The 5.2  beta 1
also had install problems, which were resolved with a special command flag, but
I was told that was over with beta 2. 

I will hope that when the full 5.2 comes out, and it uses my main profile, that
the rendering problem will be gone. I'll report back then.

Thanks for your input on this problem.

BW,
Paul

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39124] copy base table to calc uses wrong codepage for paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39124

kartis56  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39124] copy base table to calc uses wrong codepage for paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39124

--- Comment #14 from kartis56  ---
Created attachment 125681
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125681=edit
not solved

it's not solved in ja-JP x64
either 5.0.6.3 nor 5.1.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100320] Japanese cannot be input by ibus-anthy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100320

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #12 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 91375 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91375] ibus and complex input methods do not work at all in 4.4.x

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91375

V Stuart Foote  changed:

   What|Removed |Added

 CC||suzukiy...@gmail.com

--- Comment #10 from V Stuart Foote  ---
*** Bug 100320 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99833] ibus does not work after switching window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99833

Takeshi Abe  changed:

   What|Removed |Added

 CC||suzukiy...@gmail.com

--- Comment #2 from Takeshi Abe  ---
*** Bug 100320 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100320] Japanese cannot be input by ibus-anthy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100320

Takeshi Abe  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Takeshi Abe  ---


*** This bug has been marked as a duplicate of bug 99833 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100320] Japanese cannot be input by ibus-anthy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100320

--- Comment #10 from Takeshi Abe  ---
You would be interested in a recent discussion about this issue in ja-discuss
mailing-list:
http://listarchives.libreoffice.org/ja/discuss/msg04117.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50743] FORMATTING: Highlighting scrolls automatically

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=50743

--- Comment #7 from spesa  ---
Bug confirmed for LibreOffice Version: 5.0.3.2
Build ID: 1:5.0.3~rc2-0ubuntu1~trusty2
Locale: en-GB (en_GB.UTF-8)
on linuxmint 17.3.

tools related to the triger of this bug are: 
- highlight tool
- font color tool

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sd/source

[Markus Mohrhard]

 sd/source/ui/sidebar/SlideBackground.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 0a19e85f0c34c85f18cc9d5ade9a5ad41ed6750b
Author: Markus Mohrhard 
Date:   Wed Jun 15 23:34:33 2016 +0200

SfxObjectShell::Current may return nullptr

See

http://crashreport.libreoffice.org/stats/crash_details/caa7efba-fbe8-4c58-966d-c4bc356b5a63

Change-Id: Idc8b3a2e482a5423080735f46f50d415835f747d
Reviewed-on: https://gerrit.libreoffice.org/26343
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index fd728d6..9c3274e 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -195,6 +195,9 @@ void SlideBackground::Update()
 {
 const drawing::FillStyle eXFS = 
(drawing::FillStyle)mpFillStyle->GetSelectEntryPos();
 SfxObjectShell* pSh = SfxObjectShell::Current();
+if (!pSh)
+return;
+
 switch(eXFS)
 {
 case drawing::FillStyle_NONE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100417] Cannot set slide offset in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100417

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Based on this FAQ answer I'm afraid there's no such option:
https://wiki.documentfoundation.org/Faq/Impress/013

Would you like to keep this report open as an enhancement request?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsDevEval, needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard|BSA |

--- Comment #10 from V Stuart Foote  ---
(In reply to Óvári from comment #9)
> Perhaps the below could be implemented into LibreOffice, instead of
> reinventing the wheel. What do you think?
> 

Hmm, maybe. But then we would have the OS X camp complaining with bug 42437
that we aren't friendly to the "native" PressAndHold.app

And I still rather strongly feel that cross-platform enhancing the Special
Character dialog is the better way to implement multi-script Unicode
composition in an edit session rather than the limited range of glyph input
offered by this, and similar IME.

Implementing a well structured recently used glyph feature in the Special
Character dialog would be much more useful without the overhead of an IME.

=-ref-=
http://user-prompt.com/libreoffice-design-session-special-character/
https://drive.google.com/folderview?id=0B6qJrVIa0SAlcFV0Q2lWMmdUcW8=sharing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||needsDevEval, needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard|BSA |

--- Comment #10 from V Stuart Foote  ---
(In reply to Óvári from comment #9)
> Perhaps the below could be implemented into LibreOffice, instead of
> reinventing the wheel. What do you think?
> 

Hmm, maybe. But then we would have the OS X camp complaining with bug 42437
that we aren't friendly to the "native" PressAndHold.app

And I still rather strongly feel that cross-platform enhancing the Special
Character dialog is the better way to implement multi-script Unicode
composition in an edit session rather than the limited range of glyph input
offered by this, and similar IME.

Implementing a well structured recently used glyph feature in the Special
Character dialog would be much more useful without the overhead of an IME.

=-ref-=
http://user-prompt.com/libreoffice-design-session-special-character/
https://drive.google.com/folderview?id=0B6qJrVIa0SAlcFV0Q2lWMmdUcW8=sharing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100418] New: Feature request: runt control ( similar to widows and orphans), adjust the length of last line in paragraph.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100418

Bug ID: 100418
   Summary: Feature request: runt control (similar to widows and
orphans), adjust the length of last line in paragraph.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j...@mailplus.pl

Please see the picture. 

http://blogmsi.com/wp-content/uploads/2013/06/WidowStubOrphan.jpg

Would be great to have an option to set the last line to 5 or more characters. 

Only way now is to change the hyphenation settings which really isn't how it
should work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100384] FILEOPEN: LibreOffice freezes when opening any .ods file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100384

--- Comment #7 from Aron Budea  ---
I honestly have no idea what could've been interfering with Calc, and only
Calc.
Nevertheless, I'm glad it works now, thanks for the update.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100380] Chart in report contains no data unless y values are field 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100380

--- Comment #5 from branestawm  ---
(In reply to robert from comment #4)
> Isn't this bug a duplicate of this one:
> https://bugs.documentfoundation.org/show_bug.cgi?id=91289
> 
> You are using dates. This seems to be a special problem for charts. Have a
> look at the x-Axis: Values have nothing to do with the values you have set
> in the table.

The bug as I reported it is absence of data points in the body of the chart,
unless y values are field 0.

My 'Line chart' reports use integers (y values), not dates. They do show dates
in the x-axis but these should be ordinal integers as they are in a Calc line
chart - this may be another bug.

My bug description differs from #91289 which reports "with no X-axis value at
all", whereas my line charts show an x-axis (albeit with bad values and in date
format) - and no data points in the body of the chart.

Perhaps you were looking at the 'XY chart' reports which use dates on the
x-axis but are for my second bug report #100381 concerning the x-axis?

Useful to know that dates are a problem with charts in Base - thanks for your
interest!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71176] Key combinations to easily insert accented Latin characters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71176

--- Comment #9 from Óvári  ---
Perhaps the below could be implemented into LibreOffice, instead of reinventing
the wheel. What do you think?

Zombie Keys (Multilanguage Keyboard)
https://addons.mozilla.org/en-US/thunderbird/addon/zombie-keys/

by Realraven (Axel Grude)
https://addons.mozilla.org/en-US/thunderbird/user/kbolay/
Kai Bolay
https://addons.mozilla.org/en-US/thunderbird/user/realraven/

Enter accents, diacritics, diaeresis, umlauts, ligatures etc. with keyboards of
various countries (us,uk,ie,fr,it,ru,de,sv) - via easy to remember shortcuts or
menu. Also supports all textboxes of the application (such as search, filters).

This extension implements Microsoft's Keyboard shortcuts for international
characters
(http://office.microsoft.com/assistance/hfws.aspx?AssetID=HP051865621033), äñḍ
ţḫėņ şøṁẹ mōřẹ ¡

Use Zombie Keys and bring dead keys to life!

For support please go to http://zombiekeys.mozdev.org/

Latest Betas / Prereleases: http://downloads.mozdev.org/zombiekeys/

This extension addresses Bug 270439
(https://bugzilla.mozilla.org/show_bug.cgi?id=270439).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Markus Mohrhard]

 sd/source/ui/sidebar/SlideBackground.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 75ca2defe8edba8d198a05e7f64674418171536d
Author: Markus Mohrhard 
Date:   Wed Jun 15 23:34:33 2016 +0200

SfxObjectShell::Current may return nullptr

See

http://crashreport.libreoffice.org/stats/crash_details/caa7efba-fbe8-4c58-966d-c4bc356b5a63

Change-Id: Idc8b3a2e482a5423080735f46f50d415835f747d
Reviewed-on: https://gerrit.libreoffice.org/26341
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 3ca1d7d..279d8e4 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -159,6 +159,9 @@ void SlideBackground::Update()
 {
 const drawing::FillStyle eXFS = 
(drawing::FillStyle)mpFillStyle->GetSelectEntryPos();
 SfxObjectShell* pSh = SfxObjectShell::Current();
+if (!pSh)
+return;
+
 switch(eXFS)
 {
 case drawing::FillStyle_NONE:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/source

[Markus Mohrhard]

 desktop/source/app/sofficemain.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 4f32fcf59854fe1abe375c8702cc5c4258abbf3d
Author: Markus Mohrhard 
Date:   Wed Jun 15 22:32:44 2016 +0200

work around MSVCR2013 bug around AVX, tdf#99410


http://crashreport.libreoffice.org/stats/crash_details/d7bc6c8a-e8c2-4c1f-8291-ccab84ea892c

Change-Id: I76f9614bc54988c001c9b252707e4b5d4c588112
Reviewed-on: https://gerrit.libreoffice.org/26339
Reviewed-by: Markus Mohrhard 
Tested-by: Jenkins 

diff --git a/desktop/source/app/sofficemain.cxx 
b/desktop/source/app/sofficemain.cxx
index 755da59..146c580 100644
--- a/desktop/source/app/sofficemain.cxx
+++ b/desktop/source/app/sofficemain.cxx
@@ -107,6 +107,12 @@ static bool dumpCallback(const wchar_t* path, const 
wchar_t* id,
 #endif
 extern "C" int DESKTOP_DLLPUBLIC soffice_main()
 {
+#if defined(_WIN64) && _MSC_VER <= 1800
+// tdf#99410: MSVC 2013 runtime library has problems with some math 
functions if
+// the CPU supports them and they are disabled in the OS
+_set_FMA3_enable(0);
+#endif
+
 #if HAVE_FEATURE_BREAKPAD
 
 #if defined( UNX ) && !defined MACOSX && !defined IOS && !defined ANDROID
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100414] incorrect usage of "maj" instead of "shift" on Locale: nl-BE (nl_BE).

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100414

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #2 from Aron Budea  ---
Confirmed in LO 5.2 beta2/Windows 7, using On-Screen Keyboard for verification.

-Dutch (Belgium) locale / Belgian (Period) layout: in Writer Maj is displayed
instead of Shift (incorrect)
-French (Belgium) locale / Belgian (Comma) layout: in Writer Shift is displayed
instead of Maj (incorrect)
-French (Belgium) locale / Belgian French layout: in Writer Maj is displayed
(correct)

Note that On-Screen Keyboard does not update its layout automatically after
changing layouts in the application, only when its window is moved.

While Maxim's comment in [1] describes the general behavior of handling
keyboard shortcut translations, something seems to be working differently in
this case.

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=93738#c10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100417] New: Cannot set slide offset in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100417

Bug ID: 100417
   Summary: Cannot set slide offset in Impress
   Product: LibreOffice
   Version: 5.0.6.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: barade.bar...@web.de

After searching for one hour I did not find any solution how I can set the
offset in the page number/slide number field in impress. I excluded the slide
number at the first slide but it starts with 2 at the second. I want to start
it with 1.

I cant believe I am the only one with this problem. Do I have to create a new
Master slide for this? Why is it possible in the Writer to set a page offset
but not in Impress?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sfx2/source

[Akshay Deep]

 sfx2/source/doc/doctempl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 51034e90af7e7da683598724f9aba90953a67fa5
Author: Akshay Deep 
Date:   Wed Jun 15 12:54:23 2016 +0530

Template Export: Don't overwrite the existing template in a directory

Change-Id: I19470c7eeb961665cb5248861b030479a0796a24
Reviewed-on: https://gerrit.libreoffice.org/26290
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 
(cherry picked from commit 4f61b652323e1bde5c45bc9dece3c61b2f69b83d)
Reviewed-on: https://gerrit.libreoffice.org/26312
Tested-by: Jenkins 
Reviewed-by: Akshay Deep 

diff --git a/sfx2/source/doc/doctempl.cxx b/sfx2/source/doc/doctempl.cxx
index c3d9d34..2ed3fc6 100644
--- a/sfx2/source/doc/doctempl.cxx
+++ b/sfx2/source/doc/doctempl.cxx
@@ -721,7 +721,7 @@ bool SfxDocumentTemplates::CopyTo
 aTransferInfo.MoveData = false;
 aTransferInfo.SourceURL = pSource->GetTargetURL();
 aTransferInfo.NewTitle = aTitle;
-aTransferInfo.NameClash = NameClash::OVERWRITE;
+aTransferInfo.NameClash = NameClash::RENAME;
 
 Any aArg = makeAny( aTransferInfo );
 OUString aCmd( COMMAND_TRANSFER  );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100400] No template available according to use of MS Word 2016 for Academic Works

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100400

--- Comment #12 from Marco A.G.Pinto  ---
(In reply to Cor Nouws from comment #9)

Cor Nouws,

Next week I will search for the Portuguese Military Academy rules for
scientific publications (my Masters was taken there). I will make a summary of
it.

Tomorrow I have a meeting with my PhD supervisor so I won't have time for
anything.

On Friday it is the eve of my weekend supermarket job and I will be stressed.

In simple words: I will try to start doing it next Monday and have it finished
on Tuesday after revising it.

As a note: the Military Academy guys only gave the rules in the thesis part,
which means the students spent almost two years without knowing them, which
affected the classifications.

:)

Kind regards from your friend,


> (In reply to Marco A.G.Pinto from comment #8)
> 
> > @Cor Nouws:
> > Is this the correct procedure?
> 
> I guess not precisely, but .. ;)
>  
> > I have created the template and uploaded it here in Bugzilla.
> > 
> > Can it be shipped with LO?
> 
> Good and clear start IMO.
> 
> Would it be an idea maybe to add a simple dummy chapter, with correct
> styling/numbering?
> And maybe page numbering?
> Or are those not exactly defined?
> 
> Can you maybe use placeholders (Ctrl+F2 > Function for Header/Footer here! ?
> 
> Would it be an idea to add some (custom) properties (File > Properties) and
> use those with fields in header/footer?
> 
> Is there a defined form for a TOC ?
> 
> Sorry, not to annoy you, but if you work on a template anyway, why not make
> it really marvellous :)
> If needed, you may possibly add one/to screen shots in the template under a
> header "how to use" ?
> 
> Further, if added to LibreOffice I guess localization must be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Katarina Behrens]

 sd/source/ui/sidebar/SlideBackground.cxx |   37 +--
 1 file changed, 30 insertions(+), 7 deletions(-)

New commits:
commit 9e28a809d3e9fcd69b07933d698e1e166867b5c8
Author: Katarina Behrens 
Date:   Tue Jun 14 22:54:37 2016 +0200

tdf#100209: Master slide of master slide makes no sense

so just disable the controls when in master view

Change-Id: I9551cc5c0d123e58555d248b78859c1f77de6690
Reviewed-on: https://gerrit.libreoffice.org/26276
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 24068ac..3ca1d7d 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -24,6 +24,7 @@
 #include "TransitionPreset.hxx"
 #include "sdresid.hxx"
 #include "ViewShellBase.hxx"
+#include "FrameView.hxx"
 #include "DrawDocShell.hxx"
 #include "SlideSorterViewShell.hxx"
 #include "drawdoc.hxx"
@@ -119,7 +120,6 @@ void SlideBackground::Initialize()
 
mpPaperSizeBox->SetSelectHdl(LINK(this,SlideBackground,PaperSizeModifyHdl));
 
mpPaperOrientation->SetSelectHdl(LINK(this,SlideBackground,PaperSizeModifyHdl));
 
-populateMasterSlideDropdown();
 
 meUnit = maPaperSizeController.GetCoreMetric();
 
@@ -130,13 +130,21 @@ void SlideBackground::Initialize()
 mpFillGrad->SetSelectHdl(LINK(this, SlideBackground, FillColorHdl));
 mpFillAttr->SetSelectHdl(LINK(this, SlideBackground, FillBackgroundHdl));
 
-if (ViewShell* pMainViewShell = mrBase.GetMainViewShell().get())
+ViewShell* pMainViewShell = mrBase.GetMainViewShell().get();
+if (pMainViewShell)
 {
-DrawViewShell* pDrawViewShell = 
static_cast(pMainViewShell);
-SdPage* mpPage = pDrawViewShell->getCurrentPage();
-OUString aLayoutName( mpPage->GetLayoutName() );
-aLayoutName = aLayoutName.copy(0,aLayoutName.indexOf(SD_LT_SEPARATOR));
-mpMasterSlide->SelectEntry(aLayoutName);
+FrameView *pFrameView = pMainViewShell->GetFrameView();
+
+if ( pFrameView->GetViewShEditMode() ==  EM_PAGE )
+{
+DrawViewShell* pDrawViewShell = 
static_cast(pMainViewShell);
+SdPage* mpPage = pDrawViewShell->getCurrentPage();
+populateMasterSlideDropdown();
+
+OUString aLayoutName( mpPage->GetLayoutName() );
+aLayoutName = 
aLayoutName.copy(0,aLayoutName.indexOf(SD_LT_SEPARATOR));
+mpMasterSlide->SelectEntry(aLayoutName);
+}
 }
 
 mpFillStyle->SelectEntryPos(0);
@@ -278,6 +286,7 @@ void SlideBackground::addListener()
 mrBase.GetEventMultiplexer()->AddEventListener (
 aLink,
 tools::EventMultiplexerEvent::EID_CURRENT_PAGE |
+tools::EventMultiplexerEvent::EID_MAIN_VIEW_ADDED |
 tools::EventMultiplexerEvent::EID_SHAPE_CHANGED );
 }
 
@@ -297,6 +306,20 @@ IMPL_LINK_TYPED(SlideBackground, EventMultiplexerListener,
 case tools::EventMultiplexerEvent::EID_SHAPE_CHANGED:
 populateMasterSlideDropdown();
 break;
+case tools::EventMultiplexerEvent::EID_MAIN_VIEW_ADDED:
+{
+ViewShell* pMainViewShell = mrBase.GetMainViewShell().get();
+
+if (pMainViewShell)
+{
+DrawViewShell* pDrawViewShell = 
static_cast(pMainViewShell);
+EditMode eMode = pDrawViewShell->GetEditMode();
+
+if ( eMode == EM_MASTERPAGE)
+mpMasterSlide->Disable();
+}
+}
+break;
 case tools::EventMultiplexerEvent::EID_CURRENT_PAGE:
 {
 static sal_uInt16 SidArray[] = {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100415] docx file opens in draw instead of writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100415

JPJ  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #2 from JPJ  ---
How bizarre.  I didn't think of someone creating a PDF file and calling it a
docx file.  It does open fine with Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100416] options on background color of cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100416

--- Comment #1 from Roeland  ---
Also, there are a lot of predefined palettes to chose from when using the
toolbar, there's only one when using the right)click option. Some maybe these
two menus should be merged somehow?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100416] New: options on background color of cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100416

Bug ID: 100416
   Summary: options on background color of cell
   Product: LibreOffice
   Version: 5.1.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roelandb...@hotmail.com

Created attachment 125680
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125680=edit
I added a image of both menus. On the left option 2, on the right option 1.:

When using calc there a two ways to chose a background color of a cell:

1: You right click on the cell and navigate to background
2: You navigate on the toolbar to the background color button and click on it

The result that can be achieved is twice the same but at option 2 there's a
shortcut to pick a custom color instead of the predefined ones. This shortcut
is not present when using  option 1. Would it be possible to add this shortcut
also to the menu when right-clicking on a cell?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] [ANN] LibreOffice 5.1.4 RC2 test builds available

[Christian Lohmaier]

Hi *,

for the upcoming new version 5.1.4, the builds for RC2 are now
available on pre-releases.

5.1.4 rc2 is in release-build configuration, meaning it will update a
previous version of LibreOffice

5.1.4 will be the fourth bugfix release for the fresh 5.1 codeline

See

https://wiki.documentfoundation.org/ReleasePlan/5.1#5.1.4_release

for the complete schedule.

Grab the builds from here here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try & report any severe
bugs not yet in bugzilla here, so we can incorporate  them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to 5.1.4 rc1 is here:

http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-5-1-4-release-5.1.4.2.log

So playing with the areas touched there also greatly appreciated  -
and validation that those bugs are really fixed.

Thanks a lot for your help,
Christian
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 100415] docx file opens in draw instead of writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100415

--- Comment #1 from MM  ---
This file is a pdf with a docx extension. So it's fully correct it's opened in
draw.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100384] FILEOPEN: LibreOffice freezes when opening any .ods file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100384

mattg...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from mattg...@gmail.com ---
Well, I didn't really find the problem, but it is working again.  You were
thinking maybe it's not LibreOffice that's the problem.  So I did a system
restore to about 2 weeks ago.  And after that, LibreOffice wouldn't open at
all.  So I figured that was progress, so I reinstalled the latest release
version and it is working again!

This is all on Windows 10.  The only antivirus I use is Malwarebytes and I did
a full scan.  It was just LibreOffice calc that was having problems, writer
worked fine.  

What part of windows does LibreOffice calc depend on that could have been the
cause?  I didn't change anything on the computer recently.

I guess it will be just another one of the mysteries of windows.  Thanks for
the help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/qa sw/source

[Michael Stahl]

 sw/qa/extras/rtfexport/data/hyperlink_empty.rtf |8 ++
 sw/qa/extras/rtfexport/rtfexport.cxx|   11 +
 sw/source/filter/ww8/rtfattributeoutput.cxx |   28 
 3 files changed, 33 insertions(+), 14 deletions(-)

New commits:
commit 744bd590fd2c39638e8df41a569cb2cc376e7450
Author: Michael Stahl 
Date:   Wed Jun 15 18:07:12 2016 +0200

tdf#100105 sw: RTF export: fix empty hyperlinks

For empty hyperlinks the EndURL() is called immediately after StartURL()
Due to the way the various buffers are written, the group closing braces
are written before the groups are opened, which is rather invalid.

Using the m_aRun buffer instead of m_aStyles appears to fix the problem.

(regression from b8907bf3d3b37c686a414ffbbd2d732348aab5b9)

Change-Id: I6910e1afa0ee262ae0496cf1d3aa83ae3e537ad0
(cherry picked from commit b4855bd63c05096df1a2da339133f243bb30d902)
Reviewed-on: https://gerrit.libreoffice.org/26336
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/rtfexport/data/hyperlink_empty.rtf 
b/sw/qa/extras/rtfexport/data/hyperlink_empty.rtf
new file mode 100644
index 000..bdd263d
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/hyperlink_empty.rtf
@@ -0,0 +1,8 @@
+{\rtf1
+{\field
+{\*\fldinst HYPERLINK "http://example.net"}
+{\fldrslt }
+}
+foobar
+\par
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx 
b/sw/qa/extras/rtfexport/rtfexport.cxx
index 37a7018..f7a272d 100644
--- a/sw/qa/extras/rtfexport/rtfexport.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport.cxx
@@ -523,6 +523,17 @@ DECLARE_RTFEXPORT_TEST(testHyperlink, "hyperlink.rtf")
 CPPUNIT_ASSERT_EQUAL(OUString(""), 
getProperty(getRun(getParagraph(1), 3, "!"), "HyperLinkURL"));
 }
 
+DECLARE_RTFEXPORT_TEST(testHyperlinkTdf100105, "hyperlink_empty.rtf")
+{
+// export of empty link was invalid, group was closed before it was opened
+uno::Reference xTextDoc(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xCursor(xTextDoc->getText()->createTextCursor());
+xCursor->gotoStart(false);
+CPPUNIT_ASSERT_EQUAL(OUString("http://example.net;), 
getProperty(xCursor, "HyperLinkURL"));
+// getRun doesn't provide a 0-length hyperlink
+CPPUNIT_ASSERT_EQUAL(OUString(""), 
getProperty(getRun(getParagraph(1), 1, "foobar"), "HyperLinkURL"));
+}
+
 DECLARE_RTFEXPORT_TEST(test78758, "fdo78758.rtf")
 {
 CPPUNIT_ASSERT_EQUAL(OUString("#__RefHeading___Toc264438068"),
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx 
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index b6eebc9..2c8894d 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -553,26 +553,26 @@ bool RtfAttributeOutput::StartURL(const OUString& rUrl, 
const OUString& rTarget)
 // Ignore hyperlink without an URL.
 if (!rUrl.isEmpty())
 {
-m_aStyles.append('{');
-m_aStyles.append(OOO_STRING_SVTOOLS_RTF_FIELD);
-m_aStyles.append('{');
-m_aStyles.append(OOO_STRING_SVTOOLS_RTF_IGNORE);
-m_aStyles.append(OOO_STRING_SVTOOLS_RTF_FLDINST);
-m_aStyles.append(" HYPERLINK ");
+m_aRun->append('{');
+m_aRun->append(OOO_STRING_SVTOOLS_RTF_FIELD);
+m_aRun->append('{');
+m_aRun->append(OOO_STRING_SVTOOLS_RTF_IGNORE);
+m_aRun->append(OOO_STRING_SVTOOLS_RTF_FLDINST);
+m_aRun->append(" HYPERLINK ");
 
-m_aStyles.append("\"");
-m_aStyles.append(msfilter::rtfutil::OutString(rUrl, 
m_rExport.m_eCurrentEncoding));
-m_aStyles.append("\" ");
+m_aRun->append("\"");
+m_aRun->append(msfilter::rtfutil::OutString(rUrl, 
m_rExport.m_eCurrentEncoding));
+m_aRun->append("\" ");
 
 if (!rTarget.isEmpty())
 {
-m_aStyles.append("t \"");
-m_aStyles.append(msfilter::rtfutil::OutString(rTarget, 
m_rExport.m_eCurrentEncoding));
-m_aStyles.append("\" ");
+m_aRun->append("t \"");
+m_aRun->append(msfilter::rtfutil::OutString(rTarget, 
m_rExport.m_eCurrentEncoding));
+m_aRun->append("\" ");
 }
 
-m_aStyles.append("}");
-m_aStyles.append("{" OOO_STRING_SVTOOLS_RTF_FLDRSLT " {");
+m_aRun->append("}");
+m_aRun->append("{" OOO_STRING_SVTOOLS_RTF_FLDRSLT " {");
 }
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98797] MAILMERGE: Crash or freeze when "Send E-Mail Messages"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98797

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98797] MAILMERGE: Crash or freeze when "Send E-Mail Messages"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98797

--- Comment #5 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa35f2981334ba2e5aed4269fe851054bbc584dc

tdf#98797 sw: try to fix crash in SwMailDispatcherListener_Impl

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Michael Stahl]

 sw/source/ui/dbui/mmoutputtypepage.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit aa35f2981334ba2e5aed4269fe851054bbc584dc
Author: Michael Stahl 
Date:   Wed Jun 15 23:17:50 2016 +0200

tdf#98797 sw: try to fix crash in SwMailDispatcherListener_Impl

Commit c48df7ad7d49ac093058ceb28d6d3f272f6e2e07 added a isDisposed()
call in SwMailDispatcherListener_Impl::idle() and i can't see why that
would not be necessary in the other functions that access
m_pSendMailDialog if it is necessary in idle() - it's not obvious *why*
it would be necessary in idle() in the first place but obviously i don't
understand when SwSendMailDialog::dispose() is invoked (which is what
deletes m_pStatus, dereferencing which the backtrace crashes).

There is code in SwSendMailDialog::dispose() to handle the case that the
xMailDispatcher thread is still running, and stop it without joining,
which would obviously trigger this crash if it were ever executed.

(Maybe i should actually try what happens at runtime, but these
mail-merge dialogs are all scarily confusing.)

Change-Id: I550f6107b064b0c97f3d33bed5bd3830fa2e86f4

diff --git a/sw/source/ui/dbui/mmoutputtypepage.cxx 
b/sw/source/ui/dbui/mmoutputtypepage.cxx
index b441456..e176958 100644
--- a/sw/source/ui/dbui/mmoutputtypepage.cxx
+++ b/sw/source/ui/dbui/mmoutputtypepage.cxx
@@ -182,7 +182,8 @@ void SwMailDispatcherListener_Impl::mailDelivered(
 uno::Reference< mail::XMailMessage> xMailMessage)
 {
 SolarMutexGuard aGuard;
-m_pSendMailDialog->DocumentSent( xMailMessage, true, nullptr );
+if (!m_pSendMailDialog->isDisposed())
+m_pSendMailDialog->DocumentSent( xMailMessage, true, nullptr );
 DeleteAttachments( xMailMessage );
 }
 
@@ -192,7 +193,8 @@ void SwMailDispatcherListener_Impl::mailDeliveryError(
 const OUString& sErrorMessage)
 {
 SolarMutexGuard aGuard;
-m_pSendMailDialog->DocumentSent( xMailMessage, false,  );
+if (!m_pSendMailDialog->isDisposed())
+m_pSendMailDialog->DocumentSent( xMailMessage, false,  );
 DeleteAttachments( xMailMessage );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98797] MAILMERGE: Crash or freeze when "Send E-Mail Messages"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98797

Michael Stahl  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mst...@redhat.com
 Resolution|--- |FIXED

--- Comment #4 from Michael Stahl  ---
i might have fixed this, or maybe not, well i didn't even try to reproduce it
:)
please re-open if it still happens on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: comphelper/CppunitTest_comphelper_threadpool_test.mk comphelper/Module_comphelper.mk comphelper/qa comphelper/source include/comphelper package/source sc/source solenv/

[Ashod Nakashian]

 comphelper/CppunitTest_comphelper_threadpool_test.mk |   30 ++
 comphelper/Module_comphelper.mk  |3 -
 comphelper/qa/unit/threadpooltest.cxx|   55 +++
 comphelper/source/misc/threadpool.cxx|   24 +++-
 include/comphelper/threadpool.hxx|6 ++
 package/source/zippackage/ZipPackageStream.cxx   |2 
 sc/source/filter/excel/xetable.cxx   |2 
 sc/source/filter/oox/workbookfragment.cxx|2 
 solenv/gbuild/CppunitTest.mk |3 +
 9 files changed, 122 insertions(+), 5 deletions(-)

New commits:
commit 60e75fb276778459f6055360646d879b8c615d83
Author: Ashod Nakashian 
Date:   Tue Jun 14 07:19:20 2016 -0400

tdf#98955 hardware_concurrency not ideal for thread pools

A new static member getPreferredConcurrency added to
comphelper::ThreadPool to return a configurable max
number of threads.

By default the new function returns the hardware_concurrency
value provided by std::thread. When MAX_CONCURRENCY envar is
defined, the return value is limited to whatever is set there.

Three call-sites that used std::thread::hardware_concurrency
have been replaced with getPreferredConcurrency.

Unittests added to cover the functionality of the new member.

Unittests are capped to 4 threads.

Change-Id: I3332e393a88a5ed436316fa712ed920a4b37f4af
Reviewed-on: https://gerrit.libreoffice.org/26254
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/comphelper/CppunitTest_comphelper_threadpool_test.mk 
b/comphelper/CppunitTest_comphelper_threadpool_test.mk
new file mode 100644
index 000..aa4e0f0
--- /dev/null
+++ b/comphelper/CppunitTest_comphelper_threadpool_test.mk
@@ -0,0 +1,30 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_CppunitTest_CppunitTest,comphelper_threadpool_test))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,comphelper_threadpool_test, 
\
+comphelper/qa/unit/threadpooltest \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,comphelper_threadpool_test,\
+   boost_headers \
+))
+
+$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_threadpool_test))
+
+$(eval $(call gb_CppunitTest_use_libraries,comphelper_threadpool_test, \
+comphelper \
+cppuhelper \
+cppu \
+sal \
+   $(gb_UWINAPI) \
+))
+
+# vim: set noet sw=4 ts=4:
diff --git a/comphelper/Module_comphelper.mk b/comphelper/Module_comphelper.mk
index 2eba43d..e04d230 100644
--- a/comphelper/Module_comphelper.mk
+++ b/comphelper/Module_comphelper.mk
@@ -28,9 +28,10 @@ $(eval $(call 
gb_Module_add_subsequentcheck_targets,comphelper,\
 ))
 
 $(eval $(call gb_Module_add_check_targets,comphelper,\
+CppunitTest_comphelper_threadpool_test \
 CppunitTest_comphelper_syntaxhighlight_test \
 CppunitTest_comphelper_variadictemplates_test \
-   CppunitTest_comphelper_ifcontainer \
+CppunitTest_comphelper_ifcontainer \
 CppunitTest_comphelper_test \
 ))
 
diff --git a/comphelper/qa/unit/threadpooltest.cxx 
b/comphelper/qa/unit/threadpooltest.cxx
new file mode 100644
index 000..a90d5b0
--- /dev/null
+++ b/comphelper/qa/unit/threadpooltest.cxx
@@ -0,0 +1,55 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include "cppunit/TestAssert.h"
+#include "cppunit/TestFixture.h"
+#include "cppunit/extensions/HelperMacros.h"
+#include "cppunit/plugin/TestPlugIn.h"
+
+#include 
+#include 
+
+class ThreadPoolTest : public CppUnit::TestFixture
+{
+public:
+void testPreferredConcurrency();
+
+CPPUNIT_TEST_SUITE(ThreadPoolTest);
+CPPUNIT_TEST(testPreferredConcurrency);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void ThreadPoolTest::testPreferredConcurrency() {
+
+// Check default.
+auto nThreads = comphelper::ThreadPool::getPreferredConcurrency();
+sal_Int32 nExpected = 4; // UTs are capped to 4.
+CPPUNIT_ASSERT_EQUAL(nExpected, nThreads);
+
+#ifndef _WIN32_WINNT
+// The result should be cached, so this should change anything.
+nThreads = std::thread::hardware_concurrency() * 2;
+setenv("MAX_CONCURRENCY", std::to_string(nThreads).c_str(), true);
+nThreads = comphelper::ThreadPool::getPreferredConcurrency();
+CPPUNIT_ASSERT_MESSAGE("Expected no 

[Libreoffice-bugs] [Bug 95116] Writer will not let us save a document when using LibreOffice on our Mac Pro 2008 , but works fine on Mac Mini 2010

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95116

--- Comment #11 from Roy  ---
I will have to download a later version and see if the problem persists. It is
still a problem with the version I reported originally. Thank you for checking
in! I will try to upgrade and re-check as soon as I can.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99410] SEH Exception ILLEGAL INSTRUCTION on new document create

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99410

Markus Mohrhard  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |markus.mohrhard@googlemail.
   |desktop.org |com

--- Comment #13 from Markus Mohrhard  ---
I have a fix that I'm currently testing in a 64 bit build. This bug only
affects 64 bit builds.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - reportdesign/source

[Michael Stahl]

 reportdesign/source/core/api/ReportDefinition.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 24114cadf10aa9d843d6735d90fcddee3747724d
Author: Michael Stahl 
Date:   Wed Jun 15 14:55:06 2016 +0200

tdf#100325 reportdesign: try to set URL as DocumentBaseURL

... if it is missing, similar to what SfxObjectShell::DoLoad() does.

Change-Id: I5b0ae1f892355a5e9786d590c821656b58d29cf2
(cherry picked from commit cd7671ef5e3102e91c68588d1ccc39d2521af561)
Reviewed-on: https://gerrit.libreoffice.org/26332
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/reportdesign/source/core/api/ReportDefinition.cxx 
b/reportdesign/source/core/api/ReportDefinition.cxx
index f4ccbb0..fb30a37 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -1694,6 +1694,11 @@ void SAL_CALL OReportDefinition::load( const 
uno::Sequence< beans::PropertyValue
 throw uno::RuntimeException();
 }
 
+if (!aArguments.has("DocumentBaseURL") && !sURL.isEmpty())
+{
+aArguments.put("DocumentBaseURL", sURL);
+}
+
 impl_loadFromStorage_nolck_throw( xDocumentStorage, 
aArguments.getPropertyValues() );
 // TODO: do we need to take ownership of the storage? In opposite to 
loadFromStorage, we created the storage
 // ourself here, and perhaps this means we're also responsible for it ...?
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99843] Slide Show on Automatic Next Slide and Suppressing Bullet Point Animations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99843

--- Comment #4 from Vadim  ---
Created: morto...@gmail.com

I have successfully reproduced the bug in the latest build of the program.
When I started to look for possible duplicates in the system of this bug, i
found bug 61679:

https://bugs.documentfoundation.org/show_bug.cgi?id=61679

This bug is also connected with the presentation autoplay.
Download file «presentation created with powerpoint» and open in LibreOffice
Start a slide in automatic mode. All runs but does not change slides 10
seconds, as specified in the program settings, and after 8 seconds.
Resave the file in a format ''odp'', and start slide in automatic mode => slide
show again change after 8 seconds instead of 10 seconds.

Conclusion:
Slide, created in LibreOffice, not work in automatic mode, only in manual mode.
Slide, created in another editor (for example in Microsoft PowerPoint) work in
automatic mode, but with the wrong play time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100415] New: docx file opens in draw instead of writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100415

Bug ID: 100415
   Summary: docx file opens in draw instead of writer
   Product: LibreOffice
   Version: 5.1.1.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ja...@joines.org

The file
https://www.clemson.edu/procurement/documents/travel/TravelReimbursementQuickGuide.docx
opens in Draw instead of Writer both from within LibreOffice via the File ->
Open... dialog and from the command line.  Then the file is displayed on a
portrait oriented Draw page but it appears that the contents are landscape
oriented with text running off the sides of the Draw page.

I first noticed this behavior in LibreOfficeDev 5.2 which produces no error
when opening the file at the command line.  LibreOffice 5.1 does produce an
error:

$ /opt/libreoffice5.1/program/swriter TravelReimbursementQuickGuide.docx 
:1: parser error : Document is empty
%PDF-1.3
^
:1: parser error : Document is empty
%PDF-1.3
^
:1: parser error : Document is empty
%PDF-1.3
^
$

Version: 5.1.1.2
Build ID: fe4d9e69c82c6ee6db3c27cd5e2d47558afa80ac
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default;
Locale: en-US (en_US.UTF-8)
OS:  Kubuntu 14.04.4

Version: 5.2.0.0.beta2
Build ID: ae12e6f168ba39f137fc110174a37c482ce68fa4
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default;
Locale: en-US (en_US.UTF-8)
OS:  Kubuntu 14.04.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100414] incorrect usage of "maj" instead of "shift" on Locale: nl-BE (nl_BE).

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100414

--- Comment #1 from Roeland  ---
Created attachment 125679
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125679=edit
printscreen with the "Maj" code highlighted

printscreen with the "Maj" code highlighted

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100414] New: incorrect usage of "maj" instead of "shift" on Locale: nl-BE (nl_BE).

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100414

Bug ID: 100414
   Summary: incorrect usage of "maj" instead of "shift" on Locale:
nl-BE (nl_BE).
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roelandb...@hotmail.com

I'm using LibreOffice 5.1.3.2 on Windows with Locale: nl-BE (nl_BE). I noticed
that there's a structurally incorrect usage of "maj" instead of "shift" and
"verr maj"  instad of "Caps lock" in the menus.


This has probably originated from the settings of the French speaking part of
Belgium which uses the azerty keyboard with "maj" for "shift" and "verr maj" 
instad of Caps lock". In the dutch speaking part of Belgium "shift" and "caps
lock" are always used.

See wikipedia for more information:
https://en.wikipedia.org/wiki/AZERTY#Differences_between_the_Belgian_and_French_layouts_of_the_AZERTY_keyboard

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 100332, which changed state.

Bug 100332 Summary: With OpenGL rendering many UI labels are unreadable due to 
low or no contrast to background
https://bugs.documentfoundation.org/show_bug.cgi?id=100332

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Caolán McNamara]

 vcl/inc/svdata.hxx|3 +++
 vcl/source/window/winproc.cxx |7 +++
 2 files changed, 6 insertions(+), 4 deletions(-)

New commits:
commit b43b7a59ca24927c4f4bd90935b4f0075304abe7
Author: Caolán McNamara 
Date:   Wed Jun 15 21:20:33 2016 +0100

move aLastWheelEvent into svdata

just to keep them together and to drop the need for a static

Change-Id: I55c784f9fc075f4542542ee2ec649eff32d708ec

diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 39b5610..c1cb3e1 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -31,6 +31,7 @@
 
 #include "vcleventlisteners.hxx"
 #include "impfontcache.hxx"
+#include "salwtype.hxx"
 #include "xconnection.hxx"
 
 #include 
@@ -194,6 +195,8 @@ struct ImplSVWinData
 ImageList*  mpMsgBoxImgList;// ImageList for 
MessageBox
 VclPtr mpAutoScrollWin;// window, that is 
in AutoScrollMode mode
 VclPtr mpLastWheelWindow;  // window, that 
last received a mouse wheel event
+SalWheelMouseEvent  maLastWheelEvent;   // the last 
received mouse whell event
+
 StartTrackingFlags  mnTrackFlags;   // tracking flags
 StartAutoScrollFlagsmnAutoScrollFlags;  // auto scroll 
flags
 boolmbNoDeactivate; // true: do not 
execute Deactivate
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index 1f46253..86871b7 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -1474,8 +1474,6 @@ public:
 
 bool HandleWheelEvent::HandleEvent(const SalWheelMouseEvent& rEvt)
 {
-static SalWheelMouseEvent aPreviousEvent;
-
 if (!Setup())
 return false;
 
@@ -1486,12 +1484,13 @@ bool HandleWheelEvent::HandleEvent(const 
SalWheelMouseEvent& rEvt)
 // avoid the problem that scrolling via wheel to this point brings a widget
 // under the mouse that also accepts wheel commands, so stick with the old
 // widget if the time gap is very small
-if (shouldReusePreviousMouseWindow(aPreviousEvent, rEvt) && 
acceptableWheelScrollTarget(pSVData->maWinData.mpLastWheelWindow))
+if (shouldReusePreviousMouseWindow(pSVData->maWinData.maLastWheelEvent, 
rEvt) &&
+acceptableWheelScrollTarget(pSVData->maWinData.mpLastWheelWindow))
 {
 xMouseWindow = pSVData->maWinData.mpLastWheelWindow;
 }
 
-aPreviousEvent = rEvt;
+pSVData->maWinData.maLastWheelEvent = rEvt;
 
 pSVData->maWinData.mpLastWheelWindow = Dispatch(xMouseWindow);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 100332, which changed state.

Bug 100332 Summary: With OpenGL rendering many UI labels are unreadable due to 
low or no contrast to background
https://bugs.documentfoundation.org/show_bug.cgi?id=100332

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100332] With OpenGL rendering many UI labels are unreadable due to low or no contrast to background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100332

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from V Stuart Foote  ---
On Windows 10 Pro 64-bit en-US and Windows 8.1 Ent 64-bit en-US with
Version: 5.3.0.0.alpha0+
Build ID: 58959a946c0a412c3f997d8511eacb316626cd42
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-06-15_12:04:53
Locale: en-US (en_US)

Setting this resolved fixed, but now have bug 100411

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100175] Impress hangs when changing templates in Ubuntu 16.04 LTS 64-bit

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100175

--- Comment #2 from drhedb...@gmail.com ---
This is happening with templates other than the stock templates.  But this
happens just creating a new slide background color and trying to change the
color to all slides.

I upgraded to 5.1.3 and it is still happening but the dark screen is not as bad
as the previous version.  It is correcting itself much quicker now but it is
still happening.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source cui/uiconfig filter/source filter/uiconfig formula/source formula/uiconfig sw/source sw/uiconfig

[Muhammet Kara]

 cui/source/inc/cuires.hrc|4 -
 cui/source/options/optlingu.cxx  |8 --
 cui/source/options/optlingu.src  |   12 ---
 cui/uiconfig/ui/optlingupage.ui  |   23 -
 filter/source/xsltdialog/xmlfiltersettingsdialog.cxx |1 
 filter/uiconfig/ui/xmlfiltersettings.ui  |7 +
 formula/source/ui/dlg/formula.cxx|1 
 formula/uiconfig/ui/formuladialog.ui |   15 ++-
 sw/source/ui/index/cnttab.cxx|1 
 sw/source/ui/table/tabledlg.cxx  |6 -
 sw/uiconfig/swriter/ui/tabletextflowpage.ui  |   76 ---
 sw/uiconfig/swriter/ui/tocdialog.ui  |7 +
 12 files changed, 61 insertions(+), 100 deletions(-)

New commits:
commit a00757e75b7d55239f97c1ca9e50c68252ff227f
Author: Muhammet Kara 
Date:   Wed Jun 8 14:43:53 2016 +0300

Move accessibility relations to .ui files, Part 9: tdf#87026

By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I52e3f2a16519aee13b06f0efc6beb3385bcb0f1c
Reviewed-on: https://gerrit.libreoffice.org/26066
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/cui/source/inc/cuires.hrc b/cui/source/inc/cuires.hrc
index 4fa00c0..376117c 100644
--- a/cui/source/inc/cuires.hrc
+++ b/cui/source/inc/cuires.hrc
@@ -378,9 +378,7 @@
 #define RID_SVXSTR_HYPH_SPECIAL (RID_SVX_START + 
1232)
 #define RID_SVXSTR_NUM_MIN_WORDLEN  (RID_SVX_START + 
1233)
 #define RID_SVXSTR_GRAMMAR_AUTO (RID_SVX_START + 
1234)
-#define RID_SVXSTR_LINGU_MODULES_EDIT   (RID_SVX_START + 
1235)
-#define RID_SVXSTR_LINGU_DICS_EDIT_DIC  (RID_SVX_START + 
1236)
-#define RID_SVXSTR_LINGU_OPTIONS_EDIT   (RID_SVX_START + 
1237)
+// There is a gap here because of removed strings
 
 #define RID_SVXSTR_CHG_MATH (RID_SVX_START + 
1238)
 #define RID_SVXSTR_CHG_WRITER   (RID_SVX_START + 
1239)
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index fd1cdd5..29f30ac 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -1088,14 +1088,6 @@ SvxLinguTabPage::SvxLinguTabPage( vcl::Window* pParent, 
const SfxItemSet& rSet )
 else
 m_pMoreDictsLink->Hide();
 
-OUString sAccessibleNameModuleEdit(CUI_RES(RID_SVXSTR_LINGU_MODULES_EDIT));
-OUString sAccessibleNameDicsEdit  
(CUI_RES(RID_SVXSTR_LINGU_DICS_EDIT_DIC));
-OUString sAccessibleNameOptionEdit(CUI_RES(RID_SVXSTR_LINGU_OPTIONS_EDIT));
-
-m_pLinguModulesEditPB->SetAccessibleName(sAccessibleNameModuleEdit);
-m_pLinguDicsEditPB->SetAccessibleName(sAccessibleNameDicsEdit);
-m_pLinguOptionsEditPB->SetAccessibleName(sAccessibleNameOptionEdit);
-
 xProp = SvxGetLinguPropertySet();
 xDicList.set( SvxGetDictionaryList(), UNO_QUERY );
 if (xDicList.is())
diff --git a/cui/source/options/optlingu.src b/cui/source/options/optlingu.src
index 5621f89..084f3a9 100644
--- a/cui/source/options/optlingu.src
+++ b/cui/source/options/optlingu.src
@@ -83,17 +83,5 @@ String RID_SVXSTR_HYPH_SPECIAL
 {
 Text [ en-US ] = "Hyphenate special regions";
 };
-String RID_SVXSTR_LINGU_MODULES_EDIT
-{
-Text [ en-US ] = "Edit Available language modules";
-};
-String RID_SVXSTR_LINGU_DICS_EDIT_DIC
-{
-Text [ en-US ] = "Edit User-defined dictionaries";
-};
-String RID_SVXSTR_LINGU_OPTIONS_EDIT
-{
-Text [ en-US ] = "Edit Options";
-};
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/uiconfig/ui/optlingupage.ui b/cui/uiconfig/ui/optlingupage.ui
index ad7d577..5034a5d 100644
--- a/cui/uiconfig/ui/optlingupage.ui
+++ b/cui/uiconfig/ui/optlingupage.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -44,10 +44,10 @@
   
 True
 False
-0
 _Available 
language modules:
 True
 lingumodules:border
+0
   
   
 0
@@ -77,6 +77,11 @@
 True
 start
 True
+
+  
+Edit Available language modules
+  
+
   
   
 1
@@ -104,10 +109,10 @@
   
 True
 False
-0
 _User-defined dictionaries:

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

[Eike Rathke]

 sc/source/core/tool/interpr4.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit ef952e6c9756c3b2bde7d82202fb32a905a14daa
Author: Eike Rathke 
Date:   Wed Jun 15 21:57:23 2016 +0200

do not override nGlobalError with error from ConvertStringToValue()

... so an already existing previous error is kept.

Change-Id: Ie731f17e93afa512542cc3ba2378031e978f9462
(cherry picked from commit df149997849c1e07d735fdeefccf875e7361aa4c)
Reviewed-on: https://gerrit.libreoffice.org/26338
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 6324103..812409e 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -187,10 +187,11 @@ sal_uInt16 ScInterpreter::GetCellErrCode( const 
ScRefCellValue& rCell )
 
 double ScInterpreter::ConvertStringToValue( const OUString& rStr )
 {
-double fValue = ScGlobal::ConvertStringToValue( rStr, maCalcConfig, 
nGlobalError, mnStringNoValueError,
+sal_uInt16 nError = 0;
+double fValue = ScGlobal::ConvertStringToValue( rStr, maCalcConfig, 
nError, mnStringNoValueError,
 pFormatter, nCurFmtType);
-if (nGlobalError)
-SetError(nGlobalError);
+if (nError)
+SetError(nError);
 return fValue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/inc vcl/source

[Caolán McNamara]

 vcl/inc/svdata.hxx|1 +
 vcl/source/window/window.cxx  |4 
 vcl/source/window/winproc.cxx |   12 ++--
 3 files changed, 11 insertions(+), 6 deletions(-)

New commits:
commit 35205c6e3e2f85d9b7db935689ec949c98e7e431
Author: Caolán McNamara 
Date:   Wed Jun 15 21:05:50 2016 +0100

crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6f

drop hint of previous window to get mouse wheel event
when that window is disposed in order to drop any
references to it immediately that happens to avoid
anything else lingering too late

move the VclPtr into ImplSVData alongside the rest
of the things like this so we can remove the over-the-top
DeleteOnDeinit which itself replaced a relatively harmless
static Window*

Change-Id: I1e172071b711b6e4ded9a813ee3de730d3dfdf38
(cherry picked from commit bdfccfde308f0267965933a8273e6e9201a2c67c)

diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 5d0b719..39b5610 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -193,6 +193,7 @@ struct ImplSVWinData
 AutoTimer*  mpTrackTimer;   // tracking timer
 ImageList*  mpMsgBoxImgList;// ImageList for 
MessageBox
 VclPtr mpAutoScrollWin;// window, that is 
in AutoScrollMode mode
+VclPtr mpLastWheelWindow;  // window, that 
last received a mouse wheel event
 StartTrackingFlags  mnTrackFlags;   // tracking flags
 StartAutoScrollFlagsmnAutoScrollFlags;  // auto scroll 
flags
 boolmbNoDeactivate; // true: do not 
execute Deactivate
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 83ae01c..e13e205 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -477,6 +477,10 @@ void Window::dispose()
 if( pSVData->maWinData.mpActiveApplicationFrame == this )
 pSVData->maWinData.mpActiveApplicationFrame = nullptr;
 
+// reset hint of what was the last wheeled window
+if( pSVData->maWinData.mpLastWheelWindow == this )
+pSVData->maWinData.mpLastWheelWindow = nullptr;
+
 // reset marked windows
 if ( mpWindowImpl->mpFrameData != nullptr )
 {
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index d72d48e..1f46253 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -1475,27 +1475,27 @@ public:
 bool HandleWheelEvent::HandleEvent(const SalWheelMouseEvent& rEvt)
 {
 static SalWheelMouseEvent aPreviousEvent;
-static vcl::DeleteOnDeinit< VclPtr > xPreviousWindow( new 
VclPtr );
 
 if (!Setup())
 return false;
 
 VclPtr xMouseWindow = FindTarget();
 
+ImplSVData* pSVData = ImplGetSVData();
+
 // avoid the problem that scrolling via wheel to this point brings a widget
 // under the mouse that also accepts wheel commands, so stick with the old
 // widget if the time gap is very small
-VclPtr tmp = *xPreviousWindow.get();
-if (shouldReusePreviousMouseWindow(aPreviousEvent, rEvt) && 
acceptableWheelScrollTarget(tmp))
+if (shouldReusePreviousMouseWindow(aPreviousEvent, rEvt) && 
acceptableWheelScrollTarget(pSVData->maWinData.mpLastWheelWindow))
 {
-xMouseWindow = tmp;
+xMouseWindow = pSVData->maWinData.mpLastWheelWindow;
 }
 
 aPreviousEvent = rEvt;
 
-(*xPreviousWindow.get()) = Dispatch(xMouseWindow);
+pSVData->maWinData.mpLastWheelWindow = Dispatch(xMouseWindow);
 
-return *xPreviousWindow.get();
+return pSVData->maWinData.mpLastWheelWindow.get();
 }
 
 class HandleGestureEvent : public HandleGestureEventBase
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Caolán McNamara]

 vcl/inc/svdata.hxx|1 +
 vcl/source/window/window.cxx  |4 
 vcl/source/window/winproc.cxx |   12 ++--
 3 files changed, 11 insertions(+), 6 deletions(-)

New commits:
commit bdfccfde308f0267965933a8273e6e9201a2c67c
Author: Caolán McNamara 
Date:   Wed Jun 15 21:05:50 2016 +0100

crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6f

drop hint of previous window to get mouse wheel event
when that window is disposed in order to drop any
references to it immediately that happens to avoid
anything else lingering too late

move the VclPtr into ImplSVData alongside the rest
of the things like this so we can remove the over-the-top
DeleteOnDeinit which itself replaced a relatively harmless
static Window*

Change-Id: I1e172071b711b6e4ded9a813ee3de730d3dfdf38

diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index 5d0b719..39b5610 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -193,6 +193,7 @@ struct ImplSVWinData
 AutoTimer*  mpTrackTimer;   // tracking timer
 ImageList*  mpMsgBoxImgList;// ImageList for 
MessageBox
 VclPtr mpAutoScrollWin;// window, that is 
in AutoScrollMode mode
+VclPtr mpLastWheelWindow;  // window, that 
last received a mouse wheel event
 StartTrackingFlags  mnTrackFlags;   // tracking flags
 StartAutoScrollFlagsmnAutoScrollFlags;  // auto scroll 
flags
 boolmbNoDeactivate; // true: do not 
execute Deactivate
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 13364c9..e70cdc6 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -477,6 +477,10 @@ void Window::dispose()
 if( pSVData->maWinData.mpActiveApplicationFrame == this )
 pSVData->maWinData.mpActiveApplicationFrame = nullptr;
 
+// reset hint of what was the last wheeled window
+if( pSVData->maWinData.mpLastWheelWindow == this )
+pSVData->maWinData.mpLastWheelWindow = nullptr;
+
 // reset marked windows
 if ( mpWindowImpl->mpFrameData != nullptr )
 {
diff --git a/vcl/source/window/winproc.cxx b/vcl/source/window/winproc.cxx
index d72d48e..1f46253 100644
--- a/vcl/source/window/winproc.cxx
+++ b/vcl/source/window/winproc.cxx
@@ -1475,27 +1475,27 @@ public:
 bool HandleWheelEvent::HandleEvent(const SalWheelMouseEvent& rEvt)
 {
 static SalWheelMouseEvent aPreviousEvent;
-static vcl::DeleteOnDeinit< VclPtr > xPreviousWindow( new 
VclPtr );
 
 if (!Setup())
 return false;
 
 VclPtr xMouseWindow = FindTarget();
 
+ImplSVData* pSVData = ImplGetSVData();
+
 // avoid the problem that scrolling via wheel to this point brings a widget
 // under the mouse that also accepts wheel commands, so stick with the old
 // widget if the time gap is very small
-VclPtr tmp = *xPreviousWindow.get();
-if (shouldReusePreviousMouseWindow(aPreviousEvent, rEvt) && 
acceptableWheelScrollTarget(tmp))
+if (shouldReusePreviousMouseWindow(aPreviousEvent, rEvt) && 
acceptableWheelScrollTarget(pSVData->maWinData.mpLastWheelWindow))
 {
-xMouseWindow = tmp;
+xMouseWindow = pSVData->maWinData.mpLastWheelWindow;
 }
 
 aPreviousEvent = rEvt;
 
-(*xPreviousWindow.get()) = Dispatch(xMouseWindow);
+pSVData->maWinData.mpLastWheelWindow = Dispatch(xMouseWindow);
 
-return *xPreviousWindow.get();
+return pSVData->maWinData.mpLastWheelWindow.get();
 }
 
 class HandleGestureEvent : public HandleGestureEventBase
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100412] gtk3 Assertion failed error when creating report with wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100412

Michael Stahl  changed:

   What|Removed |Added

 CC||caol...@redhat.com,
   ||mst...@redhat.com,
   ||sberg...@redhat.com
  Component|Base|graphics stack

--- Comment #2 from Michael Stahl  ---
can't reproduce this on Fedora 23

Assertion `yieldCount == 0' failed.

#4  0x2aaac8606fd8 in GtkYieldMutex::ThreadsLeave (this=0x6d3dc0) at
/home/julien/lo/libreoffice/vcl/unx/gtk3/../gtk/gtkinst.cxx:312
#5  0x2aaac86061fb in GdkThreadsLeave () at
/home/julien/lo/libreoffice/vcl/unx/gtk3/../gtk/gtkinst.cxx:58
#6  0x2aaac8ca8375 in gtk_clipboard_wait_for_contents () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0

this #32 has a SolarMutexGuard

#32 0x2aaac8605493 in call_userEventFn (data=0x6e4780) at
/home/julien/lo/libreoffice/vcl/unx/gtk3/gtk3gtkdata.cxx:829
#33 0x2cc9105a in g_main_context_dispatch () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#34 0x2cc91400 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#35 0x2cc91722 in g_main_loop_run () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#36 0x2aaac8ca837e in gtk_clipboard_wait_for_contents () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0

so #36 must have GdkThreadsLeave?

lets see ... dnf debuginfo-install gtk3 ...
/usr/src/debug/gtk+-3.18.9/gtk/gtkclipboard.c

  if (g_main_loop_is_running (results.loop))
{
  gdk_threads_leave ();
  g_main_loop_run (results.loop);
  gdk_threads_enter ();
}

so it looks like the GtkYieldMutex isn't prepared for this sort of thing,
possibly a regression from

commit 07157e644fa9666850767ff6bd54c1511167a0a2
Author: Stephan Bergmann 
AuthorDate: Thu Feb 11 17:34:35 2016 +0100

Keep track of ThreadsEnter/Leave acquire counts per thread

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/tool/interpr4.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit df149997849c1e07d735fdeefccf875e7361aa4c
Author: Eike Rathke 
Date:   Wed Jun 15 21:57:23 2016 +0200

do not override nGlobalError with error from ConvertStringToValue()

... so an already existing previous error is kept.

Change-Id: Ie731f17e93afa512542cc3ba2378031e978f9462

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index c773f7b..f7c75a6 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -187,10 +187,11 @@ sal_uInt16 ScInterpreter::GetCellErrCode( const 
ScRefCellValue& rCell )
 
 double ScInterpreter::ConvertStringToValue( const OUString& rStr )
 {
-double fValue = ScGlobal::ConvertStringToValue( rStr, maCalcConfig, 
nGlobalError, mnStringNoValueError,
+sal_uInt16 nError = 0;
+double fValue = ScGlobal::ConvertStringToValue( rStr, maCalcConfig, 
nError, mnStringNoValueError,
 pFormatter, nCurFmtType);
-if (nGlobalError)
-SetError(nGlobalError);
+if (nError)
+SetError(nError);
 return fValue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100413] UI: default preview value in number format is different from formats list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100413

Laurent BP  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |jumbo4...@yahoo.fr
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100413] New: UI: default preview value in number format is different from formats list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100413

Bug ID: 100413
   Summary: UI: default preview value in number format is
different from formats list
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jumbo4...@yahoo.fr

Description: In Format > Cells > Numbers UI dialog, a preview string is
displayed according to the format chosen and cell's value. If an empty cell is
selected, a default value is displayed. But this value is different from the
one in format list and then create some inconsistency.

Steps to reproduce:
1. Select an empty cell
2. Format > Cells > Numbers

Actual behavior:
With Number category
  - Preview string is: 1234.56789
  - Format list uses a different value: -1234.1234
Other categories reflect more inconvenient inconsistency. For instance, for
Fraction, format list is difficult to understand (quarter format (new format in
master LibO 5.3) displays no fraction).

Expected behavior:
Default values should be the same in preview string and format list. They
should be chosen to reflect format specificity.

Entry points:
Default values for format list is defined here:
http://opengrok.libreoffice.org/xref/core/include/svx/flagsdef.hxx#74
Default value for preview string is unique whatever the category:
http://opengrok.libreoffice.org/xref/core/svx/source/items/numfmtsh.cxx#34

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100337] Message boxes showup empty with white background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100337

--- Comment #21 from V Stuart Foote  ---
(In reply to Caolán McNamara from comment #20)
> caolan->VStuart: So according to #3 and #17 we've gone from always white bg
> to opengl-only always white, right ? So the above commit appears necessary
> but not sufficient ?

Yes that would be my assessment.  Seems usable again, but not with OpenGL
rendering enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: jvmfwk/plugins

[Markus Mohrhard]

 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit b5876bfcb69a65c87d602bae687b3c0634c0a1e7
Author: Markus Mohrhard 
Date:   Wed Jun 15 20:15:20 2016 +0200

passing a NULL pointer to fileno is not allowed

See crash reports at
http://crashreport.libreoffice.org/stats/signature/do_msvcr_magic+0x7
and documentation at
https://msdn.microsoft.com/en-us/library/zs6wbdhx.aspx

Change-Id: Ia9166d3b9fa10b87585821504e39cdfecbd22eda
Reviewed-on: https://gerrit.libreoffice.org/26317
Reviewed-by: Michael Stahl 
Tested-by: Markus Mohrhard 

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index fad3c0a9..43ddc82 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -548,6 +548,9 @@ static void do_msvcr_magic(rtl_uString *jvm_dll)
 
 FILE *f = _wfopen(reinterpret_cast(Module->buffer), L"rb");
 
+if (!f)
+return;
+
 if (fstat(fileno(f), ) == -1)
 {
 fclose(f);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara]

 sd/source/ui/sidebar/MasterPagesSelector.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4d18c1de112c1439ae4e41de7c19ffa449afea68
Author: Caolán McNamara 
Date:   Wed Jun 15 20:46:19 2016 +0100

crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6f

This can be reproduced by switching to master slide sidebar in impress
, use the mouse to wheel up and down and then go straight to clicking
the window manager close button

The dispose doesn't ultimately drop its reference to the document
so keeps it open if the scroll-wheel previous event widget vclptr
keeps the widget around

Change-Id: Ic90bcadf2489094358737be7f522129bd555a1ba

diff --git a/sd/source/ui/sidebar/MasterPagesSelector.cxx 
b/sd/source/ui/sidebar/MasterPagesSelector.cxx
index 862de39..88491e0 100644
--- a/sd/source/ui/sidebar/MasterPagesSelector.cxx
+++ b/sd/source/ui/sidebar/MasterPagesSelector.cxx
@@ -112,6 +112,7 @@ void MasterPagesSelector::dispose()
 
 Link aChangeListener 
(LINK(this,MasterPagesSelector,ContainerChangeListener));
 mpContainer->RemoveChangeListener(aChangeListener);
+mpContainer.reset();
 PreviewValueSet::dispose();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sw/source

[Michael Stahl]

 sw/source/core/doc/DocumentContentOperationsManager.cxx |   45 +---
 1 file changed, 28 insertions(+), 17 deletions(-)

New commits:
commit 5c702a4b3a1ef14702b47c7d7c1c7129c7c97bfb
Author: Michael Stahl 
Date:   Wed Jun 15 00:09:15 2016 +0200

tdf#100275 sw: fix target node of bookmark copy

Replaces the defensive programming band-aid of
5c1a1d1c66aff497702abc20df5832fa348f1008 with a real fix.

The problem is that lcl_NonCopyCount() has some special case code
to ignore the first node in the target document, which erroneously is
executed for every bookmark, which results in the 2 bookmarks in the
bugdoc being created with nDelCount 1 and 2 so they land on the same
node, which is not allowed for cross-reference marks.

Extract the adjustment into a separate function that is called once.

(regression from 689962feae2054f965a7378c3408b0ccfad2bbd5)

Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c
(cherry picked from commit bc387975b11d87868884ec770a2a42a4f7092b5f)
Reviewed-on: https://gerrit.libreoffice.org/26292
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index e5218f4..f15934d 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -122,6 +122,23 @@ namespace
 return false;
 }
 
+SwNodeIndex InitDelCount(SwPaM const& rSourcePaM, sal_uLong & rDelCount)
+{
+SwNodeIndex const& rStart(rSourcePaM.Start()->nNode);
+// Special handling for SwDoc::AppendDoc
+if (rSourcePaM.GetDoc()->GetNodes().GetEndOfExtras().GetIndex() + 1
+== rStart.GetIndex())
+{
+rDelCount = 1;
+return SwNodeIndex(rStart, +1);
+}
+else
+{
+rDelCount = 0;
+return SwNodeIndex(rStart);
+}
+}
+
 /*
 The lcl_CopyBookmarks function has to copy bookmarks from the source 
to the destination nodes
 array. It is called after a call of the CopyNodes(..) function. But 
this function does not copy
@@ -133,7 +150,6 @@ namespace
 of "non-copy" nodes between rPam.Start() and rLastIdx.
 nNewIdx is the new position of interest.
 */
-
 void lcl_NonCopyCount( const SwPaM& rPam, SwNodeIndex& rLastIdx, const 
sal_uLong nNewIdx, sal_uLong& rDelCount )
 {
 sal_uLong nStart = rPam.Start()->nNode.GetIndex();
@@ -141,18 +157,14 @@ namespace
 if( rLastIdx.GetIndex() < nNewIdx ) // Moving forward?
 {
 // We never copy the StartOfContent node
-// Special handling for SwDoc::AppendDoc
-if( rPam.GetDoc()->GetNodes().GetEndOfExtras().GetIndex() + 1 == 
nStart )
-{
-++rDelCount;
-++rLastIdx;
-}
 do // count "non-copy" nodes
 {
 SwNode& rNode = rLastIdx.GetNode();
 if( ( rNode.IsSectionNode() && rNode.EndOfSectionIndex() >= 
nEnd )
 || ( rNode.IsEndNode() && 
rNode.StartOfSectionNode()->GetIndex() < nStart ) )
+{
 ++rDelCount;
+}
 ++rLastIdx;
 }
 while( rLastIdx.GetIndex() < nNewIdx );
@@ -165,7 +177,9 @@ namespace
 SwNode& rNode = rLastIdx.GetNode();
 if( ( rNode.IsSectionNode() && rNode.EndOfSectionIndex() >= 
nEnd )
 || ( rNode.IsEndNode() && 
rNode.StartOfSectionNode()->GetIndex() < nStart ) )
+{
 --rDelCount;
+}
 rLastIdx--;
 }
 }
@@ -233,8 +247,8 @@ namespace
 }
 }
 // We have to count the "non-copied" nodes..
-SwNodeIndex aCorrIdx(rStt.nNode);
-sal_uLong nDelCount = 0;
+sal_uLong nDelCount;
+SwNodeIndex aCorrIdx(InitDelCount(rPam, nDelCount));
 for(mark_vector_t::const_iterator ppMark = vMarksToCopy.begin();
 ppMark != vMarksToCopy.end();
 ++ppMark)
@@ -254,12 +268,9 @@ namespace
 aTmpPam,
 pMark->GetName(),
 IDocumentMarkAccess::GetType(*pMark));
-if (pNewMark)
-{
-// Explicitly try to get exactly the same name as in the source
-// because NavigatorReminders, DdeBookmarks etc. ignore the 
proposed name
-pDestDoc->getIDocumentMarkAccess()->renameMark(pNewMark, 
pMark->GetName());
-}
+// Explicitly try to get exactly the same name as in the source
+// because NavigatorReminders, DdeBookmarks etc. ignore the 
proposed name
+

[Libreoffice-bugs] [Bug 100337] Message boxes showup empty with white background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100337

Caolán McNamara  changed:

   What|Removed |Added

 CC||qui...@gmail.com

--- Comment #20 from Caolán McNamara  ---
caolan->VStuart: So according to #3 and #17 we've gone from always white bg to
opengl-only always white, right ? So the above commit appears necessary but not
sufficient ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100410] Help: WEEKDAY function new parameters

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100410

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99410] SEH Exception ILLEGAL INSTRUCTION on new document create

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99410

Markus Mohrhard  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #12 from Markus Mohrhard  ---
This is a valid bug report and one that seems to affect us and a few other
projects:

See 

http://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::doubleToString%3C%60anonymous%20namespace'::UStringTraits,_rtl_uString%3E%28_rtl_uString%20*%20*,long%20*,long,double,rtl_math_StringFormat,long,wchar_t,long%20const%20*,wchar_t,bool%29+0x8

and 
https://connect.microsoft.com/VisualStudio/feedback/details/809664/the-crt-function-powf-will-crash-in-win8-1-pe


We need to fix this properly in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

[Eike Rathke]

 sc/source/core/tool/scmatrix.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 7206e030e143706db9d7029a6dfa20f89f14b1c2
Author: Eike Rathke 
Date:   Wed Jun 15 20:49:31 2016 +0200

set string conversion error also at interpreter if available

Change-Id: Idedb9192938a01ecfda3dd93e69c16a896801fd7
(cherry picked from commit 68455c20cb5edf2bfc57243b44fc81b7fa5ea5db)
Reviewed-on: https://gerrit.libreoffice.org/26335
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 4a3aaf2..9dfc2e5 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -77,7 +77,10 @@ double convertStringToValue( ScInterpreter* 
pErrorInterpreter, const OUString& r
 short nCurFmtType = 0;
 double fValue = pErrorInterpreter->ConvertStringToValue( rStr, nError, 
nCurFmtType);
 if (nError)
+{
+pErrorInterpreter->SetError( nError);
 return formula::CreateDoubleError( nError);
+}
 return fValue;
 }
 return formula::CreateDoubleError( formula::errNoValue);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100400] No template available according to use of MS Word 2016 for Academic Works

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100400

Jan Holesovsky  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #11 from Jan Holesovsky  ---
Jay: You know about templates much more than me :-) - can you have a look /
integrate this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

[Eike Rathke]

 sc/source/core/tool/interpr4.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5795989729274cdf8a8e6e1a55fb7cf12ab7fe7d
Author: Eike Rathke 
Date:   Wed Jun 15 16:45:32 2016 +0200

Resolves: tdf#100409 GetDoubleWithStringConversion() in 
GetDoubleFromMatrix()

Change-Id: I1e88e9fa6361c6f1f2aebebc101d44bc8e974283
(cherry picked from commit f219bd4c3599e0933760f8a9f0155fc97a9ab23c)
Reviewed-on: https://gerrit.libreoffice.org/26334
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 7284e306..6324103 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1963,14 +1963,14 @@ double ScInterpreter::GetDoubleFromMatrix(const 
ScMatrixRef& pMat)
 return 0.0;
 
 if ( !pJumpMatrix )
-return pMat->GetDouble( 0 );
+return pMat->GetDoubleWithStringConversion( 0, 0);
 
 SCSIZE nCols, nRows, nC, nR;
 pMat->GetDimensions( nCols, nRows);
 pJumpMatrix->GetPos( nC, nR);
 // Use vector replication for single row/column arrays.
 if ( (nC < nCols || nCols == 1) && (nR < nRows || nRows == 1) )
-return pMat->GetDouble( nC, nR);
+return pMat->GetDoubleWithStringConversion( nC, nR);
 
 SetError( errNoValue);
 return 0.0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/inc sc/source

[Eike Rathke]

 sc/inc/scmatrix.hxx  |6 +
 sc/source/core/tool/scmatrix.cxx |   45 ++-
 2 files changed, 41 insertions(+), 10 deletions(-)

New commits:
commit 56c916992276baf374664d0bfca4181919b849f5
Author: Eike Rathke 
Date:   Wed Jun 15 16:28:44 2016 +0200

introduce ScMatrix::GetDoubleWithStringConversion() preparing for tdf#100409

... as GetDouble() returns 0.0 for any string and we don't want to
change that, most relevant places already check for numeric/text
beforehand.

Change-Id: Ifbc04e892f6f504040026042faa38674ced880fb
(cherry picked from commit 481b8589d135baced12469bec4ee734b23faac21)
Reviewed-on: https://gerrit.libreoffice.org/26333
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index aacb9ce..a5c810f 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -306,6 +306,8 @@ public:
 virtual double GetDouble( SCSIZE nC, SCSIZE nR) const = 0;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble( SCSIZE nIndex) const = 0;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
= 0;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString( SCSIZE nC, SCSIZE nR) const = 0;
@@ -517,6 +519,8 @@ public:
 virtual double GetDouble( SCSIZE nC, SCSIZE nR) const override;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble( SCSIZE nIndex) const override;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
override;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString( SCSIZE nC, SCSIZE nR) const override;
@@ -731,6 +735,8 @@ public:
 virtual double GetDouble(SCSIZE nC, SCSIZE nR) const override;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble(SCSIZE nIndex) const override;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
override;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString(SCSIZE nC, SCSIZE nR) const override;
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 4aa0993..4a3aaf2 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -69,6 +69,20 @@ typedef mdds::multi_type_matrix MatrixImplType;
 
 namespace {
 
+double convertStringToValue( ScInterpreter* pErrorInterpreter, const OUString& 
rStr )
+{
+if (pErrorInterpreter)
+{
+sal_uInt16 nError = 0;
+short nCurFmtType = 0;
+double fValue = pErrorInterpreter->ConvertStringToValue( rStr, nError, 
nCurFmtType);
+if (nError)
+return formula::CreateDoubleError( nError);
+return fValue;
+}
+return formula::CreateDoubleError( formula::errNoValue);
+}
+
 struct ElemEqualZero : public unary_function
 {
 double operator() (double val) const
@@ -244,6 +258,7 @@ public:
 sal_uInt16 GetError( SCSIZE nC, SCSIZE nR) const;
 double GetDouble(SCSIZE nC, SCSIZE nR) const;
 double GetDouble( SCSIZE nIndex) const;
+double GetDoubleWithStringConversion(SCSIZE nC, SCSIZE nR) const;
 svl::SharedString GetString(SCSIZE nC, SCSIZE nR) const;
 svl::SharedString GetString( SCSIZE nIndex) const;
 svl::SharedString GetString( SvNumberFormatter& rFormatter, SCSIZE nC, 
SCSIZE nR) const;
@@ -560,6 +575,14 @@ double ScMatrixImpl::GetDouble( SCSIZE nIndex) const
 return GetDouble(nC, nR);
 }
 
+double ScMatrixImpl::GetDoubleWithStringConversion(SCSIZE nC, SCSIZE nR) const
+{
+ScMatrixValue aMatVal = Get(nC, nR);
+if (aMatVal.nType == SC_MATVAL_STRING)
+return convertStringToValue( pErrorInterpreter, 
aMatVal.aStr.getString());
+return aMatVal.fVal;
+}
+
 svl::SharedString ScMatrixImpl::GetString(SCSIZE nC, SCSIZE nR) const
 {
 if (ValidColRowOrReplicated( nC, nR ))
@@ -2734,6 +2757,11 @@ double ScFullMatrix::GetDouble( SCSIZE nIndex) const
 return pImpl->GetDouble(nIndex);
 }
 
+double ScFullMatrix::GetDoubleWithStringConversion(SCSIZE nC, SCSIZE nR) const
+{
+return pImpl->GetDoubleWithStringConversion(nC, nR);
+}
+
 svl::SharedString ScFullMatrix::GetString(SCSIZE nC, SCSIZE nR) const
 {
 return pImpl->GetString(nC, nR);
@@ -3034,16 +3062,7 @@ public:
 
 double operator()(const svl::SharedString& rStr) const
 {
-if (mpErrorInterpreter)
-{
-sal_uInt16 nError = 0;
-short 

[Libreoffice-bugs] [Bug 100406] Writer: Update to external links removes nearly all contents from Rober' s Base Guide (and maybe others)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100406

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
The chapters are in sections, which get their content by linking to external
documents. These links use relative addresses and therefore LO searches for the
documents on your hard drive, when you agree to update the links. I don't know,
what the Debian version of LO does, but with a normal version you must not
update the links. You can then break the links in Edit > Links and resave the
document with a different name to preserve the whole content for you.

In case you like to keep the links, then you need to download the chapter files
as well.

I think, that it is not an error in LibreOffice, but the document should have
embedded the chapters already as it provided with label "Gesamtband". Perhaps
you ask Robert to upload a version with embedded chapters?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98514] [pre-install.sh]Installation Script terminates abnormally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98514

krishna keshav  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100412] gtk3 Assertion failed error when creating report with wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100412

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - sc/inc sc/source

[Eike Rathke]

 sc/inc/scmatrix.hxx  |6 
 sc/source/core/tool/interpr4.cxx |4 +--
 sc/source/core/tool/scmatrix.cxx |   48 ++-
 3 files changed, 46 insertions(+), 12 deletions(-)

New commits:
commit 68455c20cb5edf2bfc57243b44fc81b7fa5ea5db
Author: Eike Rathke 
Date:   Wed Jun 15 20:49:31 2016 +0200

set string conversion error also at interpreter if available

Change-Id: Idedb9192938a01ecfda3dd93e69c16a896801fd7

diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 59787d9..7133004 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -77,7 +77,10 @@ double convertStringToValue( ScInterpreter* 
pErrorInterpreter, const OUString& r
 short nCurFmtType = 0;
 double fValue = pErrorInterpreter->ConvertStringToValue( rStr, nError, 
nCurFmtType);
 if (nError)
+{
+pErrorInterpreter->SetError( nError);
 return formula::CreateDoubleError( nError);
+}
 return fValue;
 }
 return formula::CreateDoubleError( formula::errNoValue);
commit f219bd4c3599e0933760f8a9f0155fc97a9ab23c
Author: Eike Rathke 
Date:   Wed Jun 15 16:45:32 2016 +0200

Resolves: tdf#100409 GetDoubleWithStringConversion() in 
GetDoubleFromMatrix()

Change-Id: I1e88e9fa6361c6f1f2aebebc101d44bc8e974283

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index f5138bb..c773f7b 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1989,14 +1989,14 @@ double ScInterpreter::GetDoubleFromMatrix(const 
ScMatrixRef& pMat)
 return 0.0;
 
 if ( !pJumpMatrix )
-return pMat->GetDouble( 0 );
+return pMat->GetDoubleWithStringConversion( 0, 0);
 
 SCSIZE nCols, nRows, nC, nR;
 pMat->GetDimensions( nCols, nRows);
 pJumpMatrix->GetPos( nC, nR);
 // Use vector replication for single row/column arrays.
 if ( (nC < nCols || nCols == 1) && (nR < nRows || nRows == 1) )
-return pMat->GetDouble( nC, nR);
+return pMat->GetDoubleWithStringConversion( nC, nR);
 
 SetError( errNoValue);
 return 0.0;
commit 481b8589d135baced12469bec4ee734b23faac21
Author: Eike Rathke 
Date:   Wed Jun 15 16:28:44 2016 +0200

introduce ScMatrix::GetDoubleWithStringConversion() preparing for tdf#100409

... as GetDouble() returns 0.0 for any string and we don't want to
change that, most relevant places already check for numeric/text
beforehand.

Change-Id: Ifbc04e892f6f504040026042faa38674ced880fb

diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index aacb9ce..a5c810f 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -306,6 +306,8 @@ public:
 virtual double GetDouble( SCSIZE nC, SCSIZE nR) const = 0;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble( SCSIZE nIndex) const = 0;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
= 0;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString( SCSIZE nC, SCSIZE nR) const = 0;
@@ -517,6 +519,8 @@ public:
 virtual double GetDouble( SCSIZE nC, SCSIZE nR) const override;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble( SCSIZE nIndex) const override;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
override;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString( SCSIZE nC, SCSIZE nR) const override;
@@ -731,6 +735,8 @@ public:
 virtual double GetDouble(SCSIZE nC, SCSIZE nR) const override;
 /// @return 0.0 if empty or empty path, else value or DoubleError.
 virtual double GetDouble(SCSIZE nIndex) const override;
+/// @return value or DoubleError or string converted to value.
+virtual double GetDoubleWithStringConversion( SCSIZE nC, SCSIZE nR ) const 
override;
 
 /// @return empty string if empty or empty path, else string content.
 virtual svl::SharedString GetString(SCSIZE nC, SCSIZE nR) const override;
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index a693aba..59787d9 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -69,6 +69,20 @@ typedef mdds::multi_type_matrix MatrixImplType;
 
 namespace {
 
+double convertStringToValue( ScInterpreter* pErrorInterpreter, const OUString& 
rStr )
+{
+if (pErrorInterpreter)
+{
+sal_uInt16 nError = 0;
+short nCurFmtType = 0;
+double fValue = pErrorInterpreter->ConvertStringToValue( rStr, nError, 
nCurFmtType);
+  

[Libreoffice-bugs] [Bug 100412] gtk3 Assertion failed error when creating report with wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100412

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0325

--- Comment #1 from Julien Nabet  ---
Obviously I couldn't check if tdf#100325 was ok since I got another crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100409] Functions in Calc - matrix is passed as argument -> any text returns 0 instead

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100409

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100412] New: gtk3 Assertion failed error when creating report with wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100412

Bug ID: 100412
   Summary: gtk3 Assertion failed error when creating report with
wizard
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: serval2...@yahoo.fr

Created attachment 125678
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125678=edit
bt with symbols

On pc Debian x86-64 with master sources updated today
(38971bd6543143df41192b0552c51a8119d452a0) + enable-dbgutil and render=gtk3, I
got a crash when I try to create a report with wizard

Steps to reproduce:
1) Launch Base
2) Create hsqldb db file
3) Click Reports panel
4) Click "Use Wizard to create Report..."
=> Crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100400] No template available according to use of MS Word 2016 for Academic Works

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100400

Cor Nouws  changed:

   What|Removed |Added

 Status|REOPENED|NEW
 CC||ke...@collabora.com

--- Comment #10 from Cor Nouws  ---
Thanks a lot so far, of course!

@kendy: IIRC you've been involved by earlier inclusion of templates.
What route should we go (see previous comment too, please.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100400] No template available according to use of MS Word 2016 for Academic Works

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100400

Cor Nouws  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
Version|5.1.3.2 release |Inherited From OOo
 Resolution|WONTFIX |---
Summary|There should be a setting   |No template available
   |in margins to clone |according to use of MS Word
   |Microsoft Office (2016?)|2016 for Academic Works
   |page settings   |
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #9 from Cor Nouws  ---
(In reply to Marco A.G.Pinto from comment #8)

> @Cor Nouws:
> Is this the correct procedure?

I guess not precisely, but .. ;)

> I have created the template and uploaded it here in Bugzilla.
> 
> Can it be shipped with LO?

Good and clear start IMO.

Would it be an idea maybe to add a simple dummy chapter, with correct
styling/numbering?
And maybe page numbering?
Or are those not exactly defined?

Can you maybe use placeholders (Ctrl+F2 > Function for Header/Footer here! ?

Would it be an idea to add some (custom) properties (File > Properties) and use
those with fields in header/footer?

Is there a defined form for a TOC ?

Sorry, not to annoy you, but if you work on a template anyway, why not make it
really marvellous :)
If needed, you may possibly add one/to screen shots in the template under a
header "how to use" ?

Further, if added to LibreOffice I guess localization must be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/Rosemary/change-tracking' - xmloff/source

[Rosemary Sebastian]

 xmloff/source/text/XMLRedlineExport.cxx |   22 ++
 1 file changed, 18 insertions(+), 4 deletions(-)

New commits:
commit d24e473475b93f5c512a831570fa9c14f40ec0bf
Author: Rosemary Sebastian 
Date:   Wed Jun 15 23:32:49 2016 +0530

WIP Implement more types of changes

Change-Id: I2d7878bc5e328f63b5f1e17a3cb787d6aebdcc8c

diff --git a/xmloff/source/text/XMLRedlineExport.cxx 
b/xmloff/source/text/XMLRedlineExport.cxx
index 70883ec..daa0f0b 100644
--- a/xmloff/source/text/XMLRedlineExport.cxx
+++ b/xmloff/source/text/XMLRedlineExport.cxx
@@ -366,11 +366,25 @@ void XMLRedlineExport::ExportChangedRegion(
 
 // scope for (first) change element
 {
-rExport.AddAttribute(XML_NAMESPACE_C, XML_START, "2");
-rExport.AddAttribute(XML_NAMESPACE_DC, XML_TYPE, XML_PARAGRAPH);
 aAny = rPropSet->getPropertyValue(sRedlineType);
 OUString sType;
 aAny >>= sType;
+XMLTokenEnum eChangeType = XML_PARAGRAPH;
+OUString sParagraphIdx = "2", sCharStart, sCharEnd;
+rPropSet->getPropertyValue("Start") >>= sCharStart;
+rPropSet->getPropertyValue("End") >>= sCharEnd;
+if(eChangeType == XML_PARAGRAPH)
+{
+rExport.AddAttribute(XML_NAMESPACE_C, XML_START, "/" + 
sParagraphIdx);
+rExport.AddAttribute(XML_NAMESPACE_DC, XML_TYPE, XML_PARAGRAPH);
+}
+else
+{
+rExport.AddAttribute(XML_NAMESPACE_C, XML_START, "/" + 
sParagraphIdx + "/" + sCharStart);
+if( sType == sInsert )
+rExport.AddAttribute(XML_NAMESPACE_C, XML_END, "/" + 
sParagraphIdx + "/" + sCharEnd);
+rExport.AddAttribute(XML_NAMESPACE_DC, XML_TYPE, eChangeType);
+}
 SvXMLElementExport aChange(rExport, XML_NAMESPACE_TEXT,
ConvertTypeName(sType), true, true);
 
@@ -418,11 +432,11 @@ const OUString XMLRedlineExport::ConvertTypeName(
 {
 if (sApiName == sDelete)
 {
-return sDeletion;
+return sInsertion;
 }
 else if (sApiName == sInsert)
 {
-return sInsertion;
+return sDeletion;
 }
 else if (sApiName == sFormat)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 92469] Cannot change page order in Draw navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92469

--- Comment #7 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Cor Nouws from comment #5)
> > You can sort on outline levels, not on pages.
> > So IMO this is a non issue.
> 
> What is an outline level in Draw? 

I haven't found it. I mean in _Writer_ you can change the sequence of chapters,
paragraphs, based on outlines. You can't sort pages in the Navigator. In any of
the modules.

> Anyway, the Navigator is supposed to
> provide sorting capability and neither Draw nor Impress have it. 

I never sort in the Navigator. Only in Writer there is the noted possibility.
In Calc one can't change page order either.

> Of course, we can talk about what users expect from the Navigator.

Would be a long way to debate about a function that already is provided by the
Page (Impress: Slide) Pane. I would not spent my (spare) time on that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 92469] Cannot change page order in Draw navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92469

--- Comment #7 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #6)
> (In reply to Cor Nouws from comment #5)
> > You can sort on outline levels, not on pages.
> > So IMO this is a non issue.
> 
> What is an outline level in Draw? 

I haven't found it. I mean in _Writer_ you can change the sequence of chapters,
paragraphs, based on outlines. You can't sort pages in the Navigator. In any of
the modules.

> Anyway, the Navigator is supposed to
> provide sorting capability and neither Draw nor Impress have it. 

I never sort in the Navigator. Only in Writer there is the noted possibility.
In Calc one can't change page order either.

> Of course, we can talk about what users expect from the Navigator.

Would be a long way to debate about a function that already is provided by the
Page (Impress: Slide) Pane. I would not spent my (spare) time on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - libreofficekit/qa

[Pranav Kant]

 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |  122 +++-
 1 file changed, 118 insertions(+), 4 deletions(-)

New commits:
commit 57857add9cc33aa2493118a1563bfdbe27f98675
Author: Pranav Kant 
Date:   Tue Jun 7 22:36:26 2016 +0530

gtktiledviewer: add a UNO command debugger

... to fire desired UNO commands from a dialog. Helpful when you
need to check some arbitrary UNO commands not supported via UI
yet.

Change-Id: I55df75ef235f5eb6922c50619610caf1c88241fb

diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 6f2a823..7a261be 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -390,6 +390,112 @@ static void lcl_registerToolItem(TiledWindow& rWindow, 
GtkToolItem* pItem, const
 
 const float fZooms[] = { 0.25, 0.5, 0.75, 1.0, 1.5, 2.0, 3.0, 5.0 };
 
+static void iterateUnoParams(GtkWidget* pWidget, gpointer userdata)
+{
+boost::property_tree::ptree *pTree = 
static_cast(userdata);
+
+GList* pChildren = gtk_container_get_children(GTK_CONTAINER(pWidget));
+GList* pIt;
+guint i = 0;
+const gchar* unoParam[3];
+for (pIt = pChildren, i = 0; pIt != nullptr && i < 3; pIt = pIt->next, i++)
+{
+unoParam[i] = gtk_entry_get_text(GTK_ENTRY(pIt->data));
+}
+
+pTree->put(boost::property_tree::ptree::path_type(g_strconcat(unoParam[1], 
"/", "type", nullptr), '/'), unoParam[0]);
+pTree->put(boost::property_tree::ptree::path_type(g_strconcat(unoParam[1], 
"/", "value", nullptr), '/'), unoParam[2]);
+}
+
+static void removeUnoParam(GtkWidget* pWidget, gpointer userdata)
+{
+GtkWidget* pParamAreaBox = GTK_WIDGET(userdata);
+GtkWidget* pParamContainer = gtk_widget_get_parent(pWidget);
+
+gtk_container_remove(GTK_CONTAINER(pParamAreaBox), pParamContainer);
+}
+
+static void addMoreUnoParam(GtkWidget* /*pWidget*/, gpointer userdata)
+{
+GtkWidget* pUnoParamAreaBox = GTK_WIDGET(userdata);
+
+GtkWidget* pParamContainer = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
+gtk_box_pack_start(GTK_BOX(pUnoParamAreaBox), pParamContainer, TRUE, TRUE, 
2);
+
+GtkWidget* pTypeEntry = gtk_entry_new();
+gtk_box_pack_start(GTK_BOX(pParamContainer), pTypeEntry, TRUE, TRUE, 2);
+gtk_entry_set_placeholder_text(GTK_ENTRY(pTypeEntry), "Param type (Eg. 
boolean, string etc.)");
+
+GtkWidget* pNameEntry = gtk_entry_new();
+gtk_box_pack_start(GTK_BOX(pParamContainer), pNameEntry, TRUE, TRUE, 2);
+gtk_entry_set_placeholder_text(GTK_ENTRY(pNameEntry), "Param name");
+
+GtkWidget* pValueEntry = gtk_entry_new();
+gtk_box_pack_start(GTK_BOX(pParamContainer), pValueEntry, TRUE, TRUE, 2);
+gtk_entry_set_placeholder_text(GTK_ENTRY(pValueEntry), "Param value");
+
+GtkWidget* pRemoveButton = 
gtk_button_new_from_icon_name("list-remove-symbolic", GTK_ICON_SIZE_BUTTON);
+g_signal_connect(pRemoveButton, "clicked", G_CALLBACK(removeUnoParam), 
pUnoParamAreaBox);
+gtk_box_pack_start(GTK_BOX(pParamContainer), pRemoveButton, TRUE, TRUE, 2);
+
+gtk_widget_show_all(pUnoParamAreaBox);
+}
+
+static void unoCommandDebugger(GtkWidget* pButton, gpointer /* pItem */)
+{
+TiledWindow& rWindow = lcl_getTiledWindow(pButton);
+LOKDocView* pDocView = LOK_DOC_VIEW(rWindow.m_pDocView);
+
+GtkWidget* pUnoCmdDialog = gtk_dialog_new_with_buttons ("Execute UNO 
command",
+GTK_WINDOW 
(gtk_widget_get_toplevel(GTK_WIDGET(pDocView))),
+GTK_DIALOG_MODAL,
+"Execute",
+GTK_RESPONSE_OK,
+nullptr);
+g_object_set(G_OBJECT(pUnoCmdDialog), "resizable", FALSE, nullptr);
+GtkWidget* pDialogMessageArea = gtk_dialog_get_content_area (GTK_DIALOG 
(pUnoCmdDialog));
+GtkWidget* pUnoCmdAreaBox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
+gtk_box_pack_start(GTK_BOX(pDialogMessageArea), pUnoCmdAreaBox, TRUE, 
TRUE, 2);
+
+GtkWidget* pUnoCmdLabel = gtk_label_new("Enter UNO command");
+gtk_box_pack_start(GTK_BOX(pUnoCmdAreaBox), pUnoCmdLabel, TRUE, TRUE, 2);
+
+GtkWidget* pUnoCmdEntry = gtk_entry_new ();
+gtk_box_pack_start(GTK_BOX(pUnoCmdAreaBox), pUnoCmdEntry, TRUE, TRUE, 2);
+gtk_entry_set_placeholder_text(GTK_ENTRY(pUnoCmdEntry), "UNO command (Eg. 
Bold, Italic etc.)");
+
+GtkWidget* pUnoParamAreaBox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
+gtk_box_pack_start(GTK_BOX(pDialogMessageArea), pUnoParamAreaBox, TRUE, 
TRUE, 2);
+
+GtkWidget* pAddMoreButton = gtk_button_new_with_label("Add UNO parameter");
+gtk_box_pack_start(GTK_BOX(pDialogMessageArea), pAddMoreButton, TRUE, 
TRUE, 

Re: GSoC Progress

[Mohammed Abdul Azeem]

Hi,

*Progress for week3:*
We parsed the test files using XFastParser, built string out of it and
compared them with strings built from XParser (
https://gerrit.libreoffice.org/#/c/25935/ ).
We have implemented a mapping between legacy parser and XFastParser, and
again parsed all the test files using this implementation. It is just the
basic implementation which uses only unknown (unregistered) elements.

This week will try to complete this mapping, some tests for it and then we
will start profiling it.

Regards,
Azeem
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Adding a field for crash reports to bugzilla

[Markus Mohrhard]

Hey Stuart,

On Wed, Jun 15, 2016 at 7:20 PM, V Stuart Foote 
wrote:

> Markus,
>
> This sounds great,  assisting the users to post the minidump details to BZ
> should help both QA triage, and developer response.  And of course the QA
> Wiki will need to include some guidance on what to do with the minidumps.
>
> Two questions...
>
> 1.) can our BZ infrastructure grow to hold increase of  minidumps that
> would
> result? Or do all the uploaded BreakPad dumps go to other infrastructure--
> and BZ will only have links to pull?
>


This is only about the crash id which is just a long UUID. The reports go
to the crashreporting infrastructure. The minidumps are never seen directly
by a developer or a QA person. This is just a way to link the two systems.


>
> 2.) will we be doing something for the OS X builds?  Is there a way to link
> Crash Reporter.app dumps to BreakPad on OS X and upload those dumps as
> well?
> Covering Linux, and Windows but not OS X would be unfortunate.
>


There are no plans to include it for OSX right now. The server side can
handle it but I don't plan to work on it and it will surely not be part of
the 5.2 release.

Regards,
Markus


>
> Stuart
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Libreoffice-qa-Adding-a-field-for-crash-reports-to-bugzilla-tp4186278p4186284.html
> Sent from the QA mailing list archive at Nabble.com.
> ___
> List Name: Libreoffice-qa mailing list
> Mail address: Libreoffice-qa@lists.freedesktop.org
> Change settings:
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
> Problems?
> http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
> Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
> List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
>
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 100337] Message boxes showup empty with white background

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100337

--- Comment #19 from V Stuart Foote  ---
(In reply to Fernand from comment #18)
> Fernand-> Stuard
> Thanks for the testing,
> For what functionalities do we need to "enable" GL ?

Fernand,

There are few if any things in LibreOffice that require use of OpenGL
rendering. Unfortunately it is enabled by default on the Windows builds.

The OpenGL rendering unloads document and GUI elements from CPU to graphics
processor. When functioning correctly it will enhance visual appearance and for
some graphical processes can be orders of magnitude faster.

Disabled, your users may see noticeable screen "flicker" as the GUI refreshes
under CPU or non-OpenGL graphics processor control. Page scrolling and some of
the slide transitions in Impress are accelerated by OpenGL.

Some newer desktop environments are very dependent on functioning of OpenGL
calls for texturing and font rendering. On Linux it manifests with GTK2 versus
the GTK3--GPU drivers must support a wider set of features for GTK3.

In Windows there are differences between legacy GDI+ graphics and the
DirectWrite graphics calls used with OpenGL. Using default rendering uses the
GDI+, using OpenGL rendering uses DirectWrite. And have the same issues regards
determining the capabilities of GPU hardware and drivers.

So a fair amount of LibreOffice developer effort is going toward making OpenGL
functional on OS and Desktops that support it--or "blacklisting" it when
hardware/driver combinations suggest OpenGL performance would be lacking.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100380] Chart in report contains no data unless y values are field 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100380

--- Comment #4 from rob...@familiegrosskopf.de ---
Isn't this bug a duplicate of this one:
https://bugs.documentfoundation.org/show_bug.cgi?id=91289

You are using dates. This seems to be a special problem for charts. Have a look
at the x-Axis: Values have nothing to do with the values you have set in the
table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Regis Perdreau licence statement

[Regis Perdreau]

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.


Regards,

Régis Perdreau
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice