[Libreoffice-bugs] [Bug 84427] FILESAVE: Video files not saved in DOC or DOCX

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=84427

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101466] cdr import error in image and text orientation

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101466

David Tardon  changed:

   What|Removed |Added

 CC||dtar...@redhat.com
  Component|Draw|General
Version|5.2.0.4 release |unspecified
Product|LibreOffice |libcdr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/unotools include/vcl ucb/source unotools/source vcl/inc xmlhelp/source

2016-08-14 Thread Noel Grandin 
 include/unotools/configitem.hxx  |4 ---
 include/unotools/configvaluecontainer.hxx|   11 --
 include/unotools/eventcfg.hxx|2 -
 include/unotools/extendedsecurityoptions.hxx |1 
 include/unotools/itemholderbase.hxx  |3 --
 include/unotools/securityoptions.hxx |7 --
 include/vcl/bitmap.hxx   |   21 ++-
 include/vcl/commandevent.hxx |2 -
 include/vcl/inputctx.hxx |6 +
 include/vcl/outdev.hxx   |3 --
 include/vcl/outdevstate.hxx  |5 +---
 include/vcl/settings.hxx |9 +++-
 include/vcl/vclenum.hxx  |3 --
 include/vcl/window.hxx   |   10 +++--
 ucb/source/ucp/file/bc.hxx   |3 --
 unotools/source/config/eventcfg.cxx  |2 -
 unotools/source/config/pathoptions.cxx   |   29 +--
 unotools/source/ucbhelper/ucblockbytes.cxx   |1 
 vcl/inc/listbox.hxx  |1 
 vcl/inc/salwtype.hxx |3 --
 vcl/inc/unx/wmadaptor.hxx|2 -
 xmlhelp/source/treeview/tvread.cxx   |1 
 22 files changed, 29 insertions(+), 100 deletions(-)

New commits:
commit d64395704e1a41e8f39e70a219ce3be90928e04d
Author: Noel Grandin 
Date:   Thu Aug 11 14:06:49 2016 +0200

loplugin:unusedenumconstants in unotools..xmlhelp

Change-Id: Id7ddc0fc1f57c5e8e7fb002e31d54fb8e9f8ffab
Reviewed-on: https://gerrit.libreoffice.org/28050
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/unotools/configitem.hxx b/include/unotools/configitem.hxx
index a418887..00452d5 100644
--- a/include/unotools/configitem.hxx
+++ b/include/unotools/configitem.hxx
@@ -63,9 +63,7 @@ namespace utl
 CONFIG_NAME_PLAINTEXT_NAME, // unescaped local node name, for user 
display etc.
 CONFIG_NAME_LOCAL_NAME, // local node name, for use in XNameAccess 
etc. ("Item", "Q & A")
 CONFIG_NAME_LOCAL_PATH, // one-level relative path, for use when 
building paths etc.  ("Item", "Typ['Q  A']")
-CONFIG_NAME_FULL_PATH,   // full absolute path. 
("/org.openoffice.Sample/Group/Item", "/org.openoffice.Sample/Set/Typ['Q  
A']")
-
-CONFIG_NAME_DEFAULT = CONFIG_NAME_LOCAL_PATH // default format
+CONFIG_NAME_FULL_PATH   // full absolute path. 
("/org.openoffice.Sample/Group/Item", "/org.openoffice.Sample/Set/Typ['Q  
A']")
 };
 
 class ConfigChangeListener_Impl;
diff --git a/include/unotools/configvaluecontainer.hxx 
b/include/unotools/configvaluecontainer.hxx
index 664f10a..2ee3e86 100644
--- a/include/unotools/configvaluecontainer.hxx
+++ b/include/unotools/configvaluecontainer.hxx
@@ -26,17 +26,6 @@
 #include 
 
 
-enum class CVCFlags
-{
-LAZY_UPDATE = 0x,
-UPDATE_ACCESS   = 0x0001,
-IMMEDIATE_UPDATE= 0x0002,
-};
-namespace o3tl
-{
-template<> struct typed_flags : is_typed_flags 
{};
-}
-
 namespace utl
 {
 
diff --git a/include/unotools/eventcfg.hxx b/include/unotools/eventcfg.hxx
index cfe6026..046eb6a 100644
--- a/include/unotools/eventcfg.hxx
+++ b/include/unotools/eventcfg.hxx
@@ -31,8 +31,6 @@
 
 enum class GlobalEventId
 {
-STARTAPP,
-CLOSEAPP,
 DOCCREATED,
 CREATEDOC,
 LOADFINISHED,
diff --git a/include/unotools/extendedsecurityoptions.hxx 
b/include/unotools/extendedsecurityoptions.hxx
index 8726c72..b82711a 100644
--- a/include/unotools/extendedsecurityoptions.hxx
+++ b/include/unotools/extendedsecurityoptions.hxx
@@ -50,7 +50,6 @@ class SAL_WARN_UNUSED UNOTOOLS_DLLPUBLIC 
SvtExtendedSecurityOptions : public utl
 {
 OPEN_NEVER  = 0,
 OPEN_WITHSECURITYCHECK,
-OPEN_ALWAYS
 };
 
  SvtExtendedSecurityOptions();
diff --git a/include/unotools/itemholderbase.hxx 
b/include/unotools/itemholderbase.hxx
index 7071e3c..b8b075c 100644
--- a/include/unotools/itemholderbase.hxx
+++ b/include/unotools/itemholderbase.hxx
@@ -33,7 +33,6 @@ struct ItemHolderMutexBase
 enum EItem
 {
 E_ACCESSIBILITYOPTIONS  ,   // 2
-E_ADDXMLTOSTORAGEOPTIONS,
 E_APEARCFG  ,   // 2
 
 E_CJKOPTIONS,   // 2
@@ -70,8 +69,6 @@ enum EItem
 E_PRINTFILEOPTIONS  ,   // 2
 E_PRINTWARNINGOPTIONS   ,
 
-E_REGOPTIONS,
-
 E_SAVEOPTIONS   ,
 E_SEARCHOPT ,
 E_SECURITYOPTIONS   ,
diff --git a/include/unotools/securityoptions.hxx 
b/include/unotools/securityoptions.hxx
index 47160fa..4bd6e95 100644
--- a/include/unotools/securityoptions.hxx
+++ b/include/unotools/securityoptions.hxx
@@ -79,13 +79,6 @@ class SAL_WARN_UNUSED

[Libreoffice-bugs] [Bug 96401] specific docx file reported as corrupted

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96401

Aron Budea  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101471] Non-visible menu bar in Ubuntu 16.04 after upgrade to 5.2.0.4

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101471

--- Comment #12 from Jean-Baptiste Faure  ---
Hi all affected by this issue:

- did you install the libreoffice-gtk* packages?
- what happens if you launch LibreOffice from the terminal by entering the
following command (assuming libreoffice-gtk* package have been installed) : 
SAL_USE_VCLPUGIN="gtk" && libreoffice
or
SAL_USE_VCLPUGIN="gtk3" && libreoffice

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: GSoC Progress

2016-08-14 Thread Mohammed Abdul Azeem 
Hi,

Sorry, I haven't written in two weeks.

*Progress for week10 and 11:*
We made a seperate path for unknown elements and skipped tokenizing when
token handler is not set ( https://gerrit.libreoffice.org/#/c/27593/ ) and
then we moved the load of clearing the attribute list to the consumer
thread ( https://gerrit.libreoffice.org/#/c/27649/ ). Then we made the
legacyfastparser to take a blend of tokenized and non-tokenized elements
and attributes and used mapping to get back the string (
https://gerrit.libreoffice.org/#/c/27849/ ). We have added a
dummytokenhandler and registered few namespaces on the test cases in
sax/qa/cppunit/xmlimport.cxx to test the correctness.

Now, for the past week I've been working on implementing XFastParser
interface and the proxying onwards to
the legacy interface inside the SvXMLImport class. But we need to implement
a tokenhandler (for complete ODF tokens) and namespace token mapping. Once
this is done, I think we can convert XML tree context handlers to use
fastcontext directly from the leaves upwards.

Regards,
Thanks
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 98736] Legend Balloon (callouts) is not rendered in DOCX

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98736

Aron Budea  changed:

   What|Removed |Added

 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100943] Copy/ Pasting and Moving Slides become slow as presentation is becoming more complex (Ubuntu Unity)

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100943

Ljiljan  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Ljiljan  ---
I didn't notice this error in LibreOffice 5.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2016-08-14 Thread Markus Mohrhard 
 sc/qa/unit/data/functions/fods/cumprinc.fods | 1739 ---
 1 file changed, 1739 deletions(-)

New commits:
commit 9532f45ff009f67940c77dccd463f3088866b75e
Author: Markus Mohrhard 
Date:   Mon Aug 15 07:44:06 2016 +0200

Revert "add CUMPRINC test case"

This seems to break the @71 tinderbox.

This reverts commit da67f033d2a726a54ba10a1796beca50ed8b2624.

diff --git a/sc/qa/unit/data/functions/fods/cumprinc.fods 
b/sc/qa/unit/data/functions/fods/cumprinc.fods
deleted file mode 100644
index 2635870..000
--- a/sc/qa/unit/data/functions/fods/cumprinc.fods
+++ /dev/null
@@ -1,1739 +0,0 @@
-
-
-http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
- 
2016-07-12T21:05:31.156148648P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/800a196718abbfd38d93c845e563e055ef778b04
- 
-  
-   0
-   0
-   34873
-   18319
-   
-
- view1
- 
-  
-   1
-   7
-   0
-   0
-   0
-   0
-   2
-   0
-   0
-   0
-   0
-   0
-   90
-   60
-   true
-   false
-  
-  
-   2
-   21
-   0
-   0
-   0
-   0
-   2
-   0
-   0
-   0
-   0
-   0
-   90
-   60
-   true
-   false
-  
- 
- Sheet2
- 1241
- 0
- 90
- 60
- false
- true
- true
- true
- 12632256
- true
- true
- true
- true
- false
- false
- false
- 1270
- 1270
- 1
- 1
- true
- false
-
-   
-  
-  
-   7
-   false
-   false
-   true
-   true
-   false
-   false
-   false
-   1270
-   1270
-   true
-   true
-   true
-   true
-   true
-   false
-   12632256
-   false
-   Lexmark-E352dn
-   
-
- cs
- CZ
- 
- 
- 
-
-
- en
- US
- 
- 
- 
-
-
- nl
- NL
- 
- 
- 
-
-   
-   true
-   true
-   3
-   1
-   true
-   1
-   true
-   qQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAzwAEAAhSAAAEdAAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpBNAAAEgBDT01QQVRfRFVQTEVYX01PREUKAERVUExFWF9PRkY=
-   false
-   0
-  
- 
- 
-  
-   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
-
-   
-  
- 
- 
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
-  
- 
- 
-  
-   
-   
-  
-  
-   
-  
-  
-   
-
-   Kč
-  
-  
-   
-   -
-   
-
-   Kč
-   
-  
-  
-
-
-   
-
-  
-  
-
-
-   (
-   
-   )
-  
-  
-
-
-   -
-   
-
-  
-  
-   
-
-   
-   
-   
-  
-  
-   £
-   
-  
-  
-   -
-   £
-   
-   
-  
-  
-   £
-   
-  
-  
-   -
-   £
-   
-   
-  
-  
-   £
-   
-  
-  
-   
-   -
-   £
-   
-   
-  
-  
-   £
-   
-  
-  
-   
-   -
-   £
-   
-   
-  
-  
-   £
-

[Libreoffice-bugs] [Bug 98746] FORMATTING Writer error while opening Board coming from MS Word

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98746

Aron Budea  changed:

   What|Removed |Added

   Keywords|filter:docx |filter:doc
 CC||ba...@caesar.elte.hu
 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92218] UNO command for Single Toolbar Mode (see comment #13)

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92218

--- Comment #31 from Commit Notification 
 ---
Yousuf Philips committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b92999a7213c8a6918544bffd9962062bf99584

tdf#92218 Another round of tweaks to single toolbar mode

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101518] UI: Show selected functions in multiple status-bar functions only if appropriate

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101518

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |WONTFIX

--- Comment #2 from Jean-Baptiste Faure  ---
I agree with Cor.
Closing as WontFix.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/uiconfig sw/uiconfig

2016-08-14 Thread Yousuf Philips 
 sc/uiconfig/scalc/toolbar/singlemode.xml   |7 ---
 sw/uiconfig/swriter/toolbar/singlemode.xml |   12 ++--
 2 files changed, 14 insertions(+), 5 deletions(-)

New commits:
commit 9b92999a7213c8a6918544bffd9962062bf99584
Author: Yousuf Philips 
Date:   Mon Aug 15 01:20:01 2016 +0400

tdf#92218 Another round of tweaks to single toolbar mode

Change-Id: I685687df630fe1905f18476be8c0266546048ceb
Reviewed-on: https://gerrit.libreoffice.org/28108
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sc/uiconfig/scalc/toolbar/singlemode.xml 
b/sc/uiconfig/scalc/toolbar/singlemode.xml
index 61f00dc..672ecac 100644
--- a/sc/uiconfig/scalc/toolbar/singlemode.xml
+++ b/sc/uiconfig/scalc/toolbar/singlemode.xml
@@ -18,7 +18,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 http://openoffice.org/2001/toolbar; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
- 
+ 
  
  
  
@@ -41,6 +41,7 @@
  
  
  
+ 
  
  
  
@@ -61,14 +62,14 @@
  
  
  
+ 
  
+ 
  
  
  
  
  
- 
- 
  
  
  
diff --git a/sw/uiconfig/swriter/toolbar/singlemode.xml 
b/sw/uiconfig/swriter/toolbar/singlemode.xml
index fc2d6c8..1fb5891 100644
--- a/sw/uiconfig/swriter/toolbar/singlemode.xml
+++ b/sw/uiconfig/swriter/toolbar/singlemode.xml
@@ -18,7 +18,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 http://openoffice.org/2001/toolbar; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
- 
+ 
  
  
  
@@ -31,6 +31,7 @@
  
  
  
+ 
  
  
  
@@ -39,6 +40,11 @@
  
  
  
+ 
+ 
+ 
+ 
+ 
  
  
  
@@ -51,6 +57,8 @@
  
  
  
+ 
+ 
  
  
  
@@ -63,8 +71,8 @@
  
  
  
- 
  
+ 
  
  
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99273] error saving document

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99273

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest, dataLoss,
   ||regression
 CC||ba...@caesar.elte.hu
   Hardware|x86-64 (AMD64)  |All
Version|5.1.2.2 release |4.4.0.3 release
 Whiteboard||interoperability
 OS|Linux (All) |All
   Severity|normal  |critical

--- Comment #3 from Aron Budea  ---
Reproduced with v4.4.0.3 / Windows 7 (it has some other visual issues as well
that are gone in later releases).
Not reproduced with v4.3.0.4.
=> regression

Raising severity to critical, since the document can't be saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: icon-themes/tango

2016-08-14 Thread Yousuf Philips 
 icon-themes/tango/cmd/sc_gotopage.png |binary
 icon-themes/tango/cmd/sc_gotopage.xcf.bz2 |binary
 2 files changed

New commits:
commit 61da48e0b589ae4a660c9e8d858aa2e72d83645f
Author: Yousuf Philips 
Date:   Sat Aug 13 16:47:09 2016 +0400

tdf#83054 Small tango icon for go to page

Change-Id: Iaa55da9a620b16a2828964ecce894cd34e10f07a
Reviewed-on: https://gerrit.libreoffice.org/28102
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/icon-themes/tango/cmd/sc_gotopage.png 
b/icon-themes/tango/cmd/sc_gotopage.png
new file mode 100644
index 000..811d56d
Binary files /dev/null and b/icon-themes/tango/cmd/sc_gotopage.png differ
diff --git a/icon-themes/tango/cmd/sc_gotopage.xcf.bz2 
b/icon-themes/tango/cmd/sc_gotopage.xcf.bz2
new file mode 100644
index 000..3ca2be7
Binary files /dev/null and b/icon-themes/tango/cmd/sc_gotopage.xcf.bz2 differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101526] slow, several seconds/keystroke to respond.

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101526

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |INSUFFICIENTDATA

--- Comment #1 from Jean-Baptiste Faure  ---
Without more data it is impossible to try to fix the problem:
- version of LibreOffice: I assume it is 5.2.0 but, please, confirm.
- a test file
- why didn't you try to reset your user profile?
https://wiki.documentfoundation.org/UserProfile

As you already uninstalled LO, I close this bug report as insufficientdata.
Please reopen and set it as unconfirmed again if you are willing to give us
needed and helping informations.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101528] Crashes on 3D chart modification

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101528

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
Version|unspecified |5.2.0.4 release
 Ever confirmed|0   |1

--- Comment #1 from Jean-Baptiste Faure  ---
Please, attach a test file.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101529] after ppa upgrade an extra menu-bar (invisible but working) is above the icon-row when open by .desktop-icon on ubuntu

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101529

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jbfa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Jean-Baptiste Faure  ---
Please, attach a screen copy.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101530] LibraOffice would not open

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101530

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTABUG

--- Comment #1 from Jean-Baptiste Faure  ---
Probably an incomplete download in the first try.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source

2016-08-14 Thread Takeshi Abe 
 starmath/source/mathmlimport.cxx |6 ++
 starmath/source/parse.cxx|8 +++-
 2 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 93eb0896bc30163dba47e20459dd0d14fb9770f9
Author: Takeshi Abe 
Date:   Fri Aug 12 17:44:40 2016 +0900

starmath: Avoid temporary arrays

Change-Id: I5ebb0acd1e6a808f3341d9b18a4a8e87b0679c5d
Reviewed-on: https://gerrit.libreoffice.org/28068
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index 8946c6f..2690824 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -2082,15 +2082,13 @@ SvXMLImportContext 
*SmXMLDocContext_Impl::CreateChildContext(
 
 void SmXMLDocContext_Impl::EndElement()
 {
-SmNodeArray ContextArray;
-ContextArray.resize(1);
 SmNodeStack  = GetSmImport().GetNodeStack();
 
-ContextArray[0] = popOrZero(rNodeStack);
+SmNode *pContextNode = popOrZero(rNodeStack);
 
 SmToken aDummy;
 std::unique_ptr pSNode(new SmLineNode(aDummy));
-pSNode->SetSubNodes(ContextArray);
+pSNode->SetSubNodes(pContextNode, nullptr);
 rNodeStack.push_front(std::move(pSNode));
 
 SmNodeArray  LineArray;
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index 1e11be3..7a6c995 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -2138,11 +2138,9 @@ void SmParser::DoBinom()
 DoSum();
 DoSum();
 
-SmNodeArray ExpressionArray(2);
-ExpressionArray[1] = popOrZero(m_aNodeStack);
-ExpressionArray[0] = popOrZero(m_aNodeStack);
-
-pSNode->SetSubNodes(ExpressionArray);
+SmNode *pSecond = popOrZero(m_aNodeStack);
+SmNode *pFirst = popOrZero(m_aNodeStack);
+pSNode->SetSubNodes(pFirst, pSecond);
 m_aNodeStack.push_front(std::move(pSNode));
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99023] [FORMATTING, FILESAVE] Missing text background when saved as .doc

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99023

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #5 from Aron Budea  ---
Björn, isn't 587315ebd5e4417e85eb3ffafd978fcddb09b19f from 2015-03-21?
Raal confirmed with 5.2 master build (2016-03-27) in Comment 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101532] New: Upon privilege escalation, resets computer display settings to low resolution

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101532

Bug ID: 101532
   Summary: Upon privilege escalation, resets computer display
settings to low resolution
   Product: LibreOffice
   Version: 5.1.5.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bran...@301south.net

Established LibreOffice user prompted to upgrade; downloaded and installed
upgrade from website. After upgrade, running LibreOffice individual
applications (writer, calc, etc) or double-clicking to open documents fails
with "Requested operation requires elevation." message

Running LibreOffice core application exhibits very strange behavior: requests
user account elevation "Do you want to allow this program to make changes to
your computer?" Upon answering yes, the screen resolution is reset to 640x480
pixels at 8 bit color depth.  Standard windows control panel display settings
are disabled.  Upon exiting the LibreOffice application, normal screen
resolution is restored.

Tried uninstalling LibreOffice, downloaded newest 'still' 5.1.5.2 from website
and installed, same behavior.

5.0.6 same behavior

downgrade to 4.4.7.2 x86 eliminated both problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97057] Shape Background Color Lost When Resave XLSX File

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97057

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu,
   ||jaragu...@igalia.com

--- Comment #8 from Aron Budea  ---
Adding Jacobo to CC list, as per Comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |7 +++
 loolwsd/ChildSession.hpp |4 
 loolwsd/LOOLKit.cpp  |   18 ++
 3 files changed, 29 insertions(+)

New commits:
commit daad00812d6996eadaabf68975478ec0e43a0c84
Author: Ashod Nakashian 
Date:   Sun Aug 14 22:20:35 2016 -0400

loolwsd: refresh views on UI re-activation

Change-Id: I78d04abe939a91e56cb06f89184e651e7946b28b
Reviewed-on: https://gerrit.libreoffice.org/28134
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index d712c07..9ac519a 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -85,6 +85,13 @@ bool ChildSession::_handleInput(const char *buffer, int 
length)
 if (_multiView)
 _loKitDocument->setView(_viewId);
 
+// Refresh the viewIds.
+sendTextFrame("remallviews:");
+for (const auto viewId : _docManager.getViewIds())
+{
+sendTextFrame("addview: " + std::to_string(viewId));
+}
+
 const int curPart = _loKitDocument->getPart();
 sendTextFrame("curpart: part=" + std::to_string(curPart));
 sendTextFrame("setpart: part=" + std::to_string(curPart));
diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index 3cb3202..d2ffa01 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -36,6 +36,10 @@ public:
 /// if it is the last and only.
 virtual
 void onUnload(const std::string& sessionId) = 0;
+
+/// Get a list of all current view IDs.
+virtual
+std::vector getViewIds() const = 0;
 };
 
 /// Represents a client session, with the socket end-point,
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index e4fdb44..69bc462 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -893,6 +893,24 @@ private:
 }
 }
 
+std::vector getViewIds() const override
+{
+std::unique_lock lock(_mutex);
+
+std::vector v;
+v.reserve(_connections.size());
+for (const auto& connection : _connections)
+{
+const auto& session = connection.second->getSession();
+if (session)
+{
+v.push_back(session->getViewId());
+}
+}
+
+return v;
+}
+
 private:
 
 std::shared_ptr load(const std::string& sessionId,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |   10 --
 loolwsd/ChildSession.hpp |   27 ---
 loolwsd/LOOLKit.cpp  |   13 +
 3 files changed, 29 insertions(+), 21 deletions(-)

New commits:
commit 5af1f18e364068e4b0dc1cac5a71b6dc5afd3bb4
Author: Ashod Nakashian 
Date:   Sun Aug 14 18:02:51 2016 -0400

loolwsd: convert function-object callbacks to abstract interface

Change-Id: Ia2e832659f8deddd55b8be6507c2d7406f110085
Reviewed-on: https://gerrit.libreoffice.org/28133
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index 07d57ff..d712c07 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -35,14 +35,12 @@ std::recursive_mutex ChildSession::Mutex;
 ChildSession::ChildSession(const std::string& id,
std::shared_ptr ws,
const std::string& jailId,
-   OnLoadCallback onLoad,
-   OnUnloadCallback onUnload) :
+   IDocumentManager& docManager) :
 LOOLSession(id, Kind::ToMaster, ws),
 _multiView(std::getenv("LOK_VIEW_CALLBACK")),
 _jailId(jailId),
 _viewId(0),
-_onLoad(std::move(onLoad)),
-_onUnload(std::move(onUnload))
+_docManager(docManager)
 {
 Log::info("ChildSession ctor [" + getName() + "].");
 }
@@ -65,7 +63,7 @@ void ChildSession::disconnect()
 if (_multiView && _loKitDocument)
 _loKitDocument->setView(_viewId);
 
-_onUnload(getId());
+_docManager.onUnload(getId());
 
 LOOLSession::disconnect();
 }
@@ -334,7 +332,7 @@ bool ChildSession::loadDocument(const char * /*buffer*/, 
int /*length*/, StringT
 
 std::unique_lock lock(Mutex);
 
-_loKitDocument = _onLoad(getId(), _jailedFilePath, _docPassword, 
renderOpts, _haveDocPassword);
+_loKitDocument = _docManager.onLoad(getId(), _jailedFilePath, 
_docPassword, renderOpts, _haveDocPassword);
 if (!_loKitDocument)
 {
 Log::error("Failed to get LoKitDocument instance.");
diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index ce58a4e..3cb3202 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -19,9 +19,24 @@
 #include "LOOLSession.hpp"
 #include "LibreOfficeKit.hpp"
 
-class CallbackWorker;
-typedef std::function OnLoadCallback;
-typedef std::function OnUnloadCallback;
+/// An abstract interface that defines the
+/// DocumentManager interface and functionality.
+class IDocumentManager
+{
+public:
+/// Reqest loading a document, or a new view, if one exists.
+virtual
+std::shared_ptr onLoad(const std::string& sessionId,
+  const std::string& jailedFilePath,
+  const std::string& docPassword,
+  const std::string& renderOpts,
+  const bool haveDocPassword) = 0;
+
+/// Unload a client session, which unloads the document
+/// if it is the last and only.
+virtual
+void onUnload(const std::string& sessionId) = 0;
+};
 
 /// Represents a client session, with the socket end-point,
 /// and handles all incoming UI traffic.
@@ -38,8 +53,7 @@ public:
 ChildSession(const std::string& id,
  std::shared_ptr ws,
  const std::string& jailId,
- OnLoadCallback onLoad,
- OnUnloadCallback onUnload);
+ IDocumentManager& docManager);
 virtual ~ChildSession();
 
 bool getStatus(const char *buffer, int length);
@@ -87,8 +101,7 @@ private:
 /// View ID, returned by createView() or 0 by default.
 int _viewId;
 std::map _lastDocStates;
-OnLoadCallback _onLoad;
-OnUnloadCallback _onUnload;
+IDocumentManager& _docManager;
 
 /// Synchronize _loKitDocument acess.
 /// This should be owned by Document.
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index a05c7e1..e4fdb44 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -367,7 +367,7 @@ public:
 /// per process. But for security reasons don't.
 /// However, we could have a loolkit instance
 /// per user or group of users (a trusted circle).
-class Document : public Runnable
+class Document : public Runnable, public IDocumentManager
 {
 public:
 /// We have two types of password protected documents
@@ -490,10 +490,7 @@ public:
 auto ws = std::make_shared(cs, request, response);
 ws->setReceiveTimeout(0);
 
-auto session = std::make_shared(sessionId, ws, 
_jailId,
-   [this](const std::string& id, const std::string& 
uri, const

[Libreoffice-commits] online.git: loleaflet/src loolwsd/protocol.txt

2016-08-14 Thread Ashod Nakashian 
 loleaflet/src/layer/tile/TileLayer.js |9 +
 loolwsd/protocol.txt  |5 +
 2 files changed, 14 insertions(+)

New commits:
commit 59ed1bd2ff914b65cab11c841e8233da4c081480
Author: Ashod Nakashian 
Date:   Sun Aug 14 17:24:46 2016 -0400

loleaflet: new command remallviews to remove all views

This command is intended to be used when re-activating a
client. It is intended to be sent prior to sending the
list of active views, including the re-activating
client's own view.

A client UI must maintain its own view ID and info
when receiving this command.

Change-Id: Iea58c01fb30af139888e746b5cf9e7ba7e7eeab1
Reviewed-on: https://gerrit.libreoffice.org/28132
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 1d6f5d6..5e820ff 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -363,6 +363,9 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('remview:')) {
this._onRemViewMsg(textMsg);
}
+   else if (textMsg.startsWith('remallviews:')) {
+   this._onRemAllViewMsg(textMsg);
+   }
},
 
_onCommandValuesMsg: function (textMsg) {
@@ -602,6 +605,12 @@ L.TileLayer = L.GridLayer.extend({
}
},
 
+   _onRemAllViewMsg: function(textMsg) {
+   for (var viewId in this._viewCursors) {
+   this._onRemViewMsg('remview: ' + viewId);
+   }
+   },
+
_onPartPageRectanglesMsg: function (textMsg) {
textMsg = textMsg.substring(19);
var pages = textMsg.split(';');
diff --git a/loolwsd/protocol.txt b/loolwsd/protocol.txt
index 02940f5..94b2881 100644
--- a/loolwsd/protocol.txt
+++ b/loolwsd/protocol.txt
@@ -340,6 +340,11 @@ remview: 
 
 The view with the given viewId has been destroyed.
 
+remallviews:
+
+Removes all views to send only current ones.
+The UI should still maintain its own view and cursor.
+
 child -> parent
 ===
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src loolwsd/ChildSession.cpp loolwsd/protocol.txt

2016-08-14 Thread Ashod Nakashian 
 loleaflet/src/layer/tile/TileLayer.js |   40 ++
 loolwsd/ChildSession.cpp  |3 ++
 loolwsd/protocol.txt  |7 +
 3 files changed, 50 insertions(+)

New commits:
commit fbcce1b8031636456759251f41ed4ef8faabcbf4
Author: Ashod Nakashian 
Date:   Sun Aug 14 11:57:17 2016 -0400

loleaflet+loolwsd: new commands addview and remview

The new commands help the UI update the cursors and other
visual elements that track views and clients.

Currently, when remview is received loleaflet removes
the associated cursor from the screen.

Change-Id: I03e2f9e3485166adae31de84ae7ac6bd1c85b05d
Reviewed-on: https://gerrit.libreoffice.org/28131
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 62c2f1b..1d6f5d6 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -357,6 +357,12 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('viewcursorvisible:')) {
this._onViewCursorVisibleMsg(textMsg);
}
+   else if (textMsg.startsWith('addview:')) {
+   this._onAddViewMsg(textMsg);
+   }
+   else if (textMsg.startsWith('remview:')) {
+   this._onRemViewMsg(textMsg);
+   }
},
 
_onCommandValuesMsg: function (textMsg) {
@@ -562,6 +568,40 @@ L.TileLayer = L.GridLayer.extend({
this._onUpdateViewCursor(viewId);
},
 
+   _onAddViewMsg: function(textMsg) {
+   textMsg = textMsg.substring('addview:'.length + 1);
+   var viewId = parseInt(textMsg);
+
+   // Ignore if viewid is same as ours
+   if (viewId === this._viewId) {
+   return;
+   }
+
+   //TODO: We can initialize color and other properties here.
+   if (typeof this._viewCursors[viewId] !== 'undefined') {
+   this._viewCursors[viewId] = {};
+   }
+
+   this._onUpdateViewCursor(viewId);
+   },
+
+   _onRemViewMsg: function(textMsg) {
+   textMsg = textMsg.substring('remview:'.length + 1);
+   var viewId = parseInt(textMsg);
+
+   // Ignore if viewid is same as ours
+   if (viewId === this._viewId) {
+   return;
+   }
+
+   // Just remove the view and update (to refresh as needed).
+   if (typeof this._viewCursors[viewId] !== 'undefined') {
+   this._viewCursors[viewId].visible = false;
+   this._onUpdateViewCursor(viewId);
+   delete this._viewCursors[viewId];
+   }
+   },
+
_onPartPageRectanglesMsg: function (textMsg) {
textMsg = textMsg.substring(19);
var pages = textMsg.split(';');
diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index 3cda3ff..07d57ff 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -60,6 +60,8 @@ void ChildSession::disconnect()
 {
 std::unique_lock lock(Mutex);
 
+sendTextFrame("remview: " + std::to_string(_viewId));
+
 if (_multiView && _loKitDocument)
 _loKitDocument->setView(_viewId);
 
@@ -342,6 +344,7 @@ bool ChildSession::loadDocument(const char * /*buffer*/, 
int /*length*/, StringT
 if (_multiView)
 {
 _viewId = _loKitDocument->getView();
+sendTextFrame("addview: " + std::to_string(_viewId));
 }
 
 _docType = LOKitHelper::getDocumentTypeAsString(_loKitDocument->get());
diff --git a/loolwsd/protocol.txt b/loolwsd/protocol.txt
index 9eaceae..02940f5 100644
--- a/loolwsd/protocol.txt
+++ b/loolwsd/protocol.txt
@@ -332,6 +332,13 @@ viewlock:
 
 Per-view lock rectangle. JSON payload.
 
+addview: 
+
+New view with the given viewId is created.
+
+remview: 
+
+The view with the given viewId has been destroyed.
 
 child -> parent
 ===
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   26 +++---
 1 file changed, 15 insertions(+), 11 deletions(-)

New commits:
commit f64a18d5202e4c2c9a7f34f25b8b7728931693ec
Author: Ashod Nakashian 
Date:   Sun Aug 14 11:54:14 2016 -0400

loolwsd: corrected ChildSession and connection cleanup

ChildSession and Connection are run their own thread and
their destruction depends on the connection, which of course
is completely asynchronous.

This change fires the destruction of the ChildSession, which
unloads the view, without destroying the connection.

The latter is cleaned up when purgeSessions() is invoked.

Change-Id: I341bfdbdd4b37338d1813ec707a51aeb3be59497
Reviewed-on: https://gerrit.libreoffice.org/28130
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 4c9d545..a05c7e1 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -232,17 +232,18 @@ class Connection: public Runnable
 public:
 Connection(std::shared_ptr session,
std::shared_ptr ws) :
+_sessionId(session->getId()),
 _session(std::move(session)),
 _ws(std::move(ws)),
 _stop(false),
 _joined(false)
 {
-Log::info("Connection ctor in child for " + _session->getId());
+Log::info("Connection ctor in child for " + _sessionId);
 }
 
 ~Connection()
 {
-Log::info("~Connection dtor in child for " + _session->getId());
+Log::info("~Connection dtor in child for " + _sessionId);
 stop();
 join();
 }
@@ -278,7 +279,7 @@ public:
 
 void run() override
 {
-Util::setThreadName("kit_ws_" + _session->getId());
+Util::setThreadName("kit_ws_" + _sessionId);
 
 Log::debug("Thread started.");
 
@@ -324,15 +325,18 @@ public:
 Log::error("Connection::run:: Unexpected exception");
 }
 
+// Release the session and unload view.
+_session.reset();
 Log::debug("Thread finished.");
 }
 
 private:
+const std::string _sessionId;
 Thread _thread;
 std::shared_ptr _session;
 std::shared_ptr _ws;
-std::atomic _stop;
 std::mutex _threadMutex;
+std::atomic _stop;
 std::atomic _joined;
 };
 
@@ -862,22 +866,22 @@ private:
 
 void onUnload(const std::string& sessionId)
 {
+Log::info("Unloading [" + sessionId + "].");
 const unsigned intSessionId = Util::decodeId(sessionId);
+
+std::unique_lock lock(_mutex);
+
 const auto it = _connections.find(intSessionId);
 if (it == _connections.end() || !it->second || !_loKitDocument)
 {
 // Nothing to do.
+Log::error("No [" + sessionId + "] session!");
 return;
 }
 
-auto session = it->second->getSession();
-auto sessionLock = session->getLock();
-std::unique_lock lock(_mutex);
-
-Log::info("Session " + sessionId + " is unloading. Erasing 
connection.");
-_connections.erase(it);
 --_clientViews;
-Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews) + " views will remain.");
+Log::info("Session " + sessionId + " is unloading. " + 
std::to_string(_clientViews) +
+  " view" + (_clientViews != 1 ? "s" : "") + " remain.");
 
 if (_multiView && _loKitDocument)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Admin.hpp loolwsd/AdminModel.hpp loolwsd/Auth.hpp loolwsd/ChildSession.hpp loolwsd/ClientSession.hpp loolwsd/Connect.cpp loolwsd/FileServer.hpp loolwsd/IoUtil

2016-08-14 Thread Ashod Nakashian 
 loolwsd/Admin.hpp   |3 +++
 loolwsd/AdminModel.hpp  |4 
 loolwsd/Auth.hpp|2 ++
 loolwsd/ChildSession.hpp|2 ++
 loolwsd/ClientSession.hpp   |1 +
 loolwsd/Connect.cpp |5 +++--
 loolwsd/FileServer.hpp  |3 ++-
 loolwsd/IoUtil.hpp  |1 +
 loolwsd/LOKitClient.cpp |2 +-
 loolwsd/LOOLKit.cpp |1 +
 loolwsd/LOOLSession.hpp |1 +
 loolwsd/LOOLStress.cpp  |3 ++-
 loolwsd/LOOLTool.cpp|3 ++-
 loolwsd/LOOLWSD.cpp |8 +++-
 loolwsd/LOOLWSD.hpp |2 ++
 loolwsd/Log.cpp |2 +-
 loolwsd/Log.hpp |2 ++
 loolwsd/PrisonerSession.hpp |2 ++
 loolwsd/Storage.hpp |4 
 loolwsd/TileCache.cpp   |3 +++
 loolwsd/TileDesc.hpp|3 +++
 loolwsd/TraceFile.hpp   |4 
 22 files changed, 53 insertions(+), 8 deletions(-)

New commits:
commit 08909b2a3d770639fcee73d75d754438999de534
Author: Ashod Nakashian 
Date:   Sun Aug 14 00:01:13 2016 -0400

loolwsd: doxygen comments added to all classes

Change-Id: Ia485c2dcec20a6840d46836a61f75a8e7e8762ed
Reviewed-on: https://gerrit.libreoffice.org/28128
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Admin.hpp b/loolwsd/Admin.hpp
index 118d562..699b2e2 100644
--- a/loolwsd/Admin.hpp
+++ b/loolwsd/Admin.hpp
@@ -26,6 +26,7 @@
 
 class Admin;
 
+/// Admin requests over HTTP(S) handler.
 class AdminRequestHandler: public Poco::Net::HTTPRequestHandler
 {
 public:
@@ -111,6 +112,7 @@ private:
 unsigned _cpuStatsTaskInterval = 5000;
 };
 
+/// Memory statistics.
 class MemoryStats : public Poco::Util::TimerTask
 {
 public:
@@ -133,6 +135,7 @@ private:
 long _lastTotalMemory;
 };
 
+/// CPU statistics.
 class CpuStats : public Poco::Util::TimerTask
 {
 public:
diff --git a/loolwsd/AdminModel.hpp b/loolwsd/AdminModel.hpp
index 3a192b6..1fff82c 100644
--- a/loolwsd/AdminModel.hpp
+++ b/loolwsd/AdminModel.hpp
@@ -20,6 +20,7 @@
 #include "Log.hpp"
 #include "Util.hpp"
 
+/// A client view in Admin controller.
 class View
 {
 public:
@@ -38,6 +39,7 @@ private:
 std::time_t _end = 0;
 };
 
+/// A document in Admin controller.
 class Document
 {
 public:
@@ -85,6 +87,7 @@ private:
 std::time_t _end = 0;
 };
 
+/// An Admin session subscriber.
 class Subscriber
 {
 public:
@@ -123,6 +126,7 @@ private:
 std::time_t _end = 0;
 };
 
+/// The Admin controller implementation.
 class AdminModel
 {
 public:
diff --git a/loolwsd/Auth.hpp b/loolwsd/Auth.hpp
index 889de73..664cfc1 100644
--- a/loolwsd/Auth.hpp
+++ b/loolwsd/Auth.hpp
@@ -28,6 +28,7 @@ public:
 virtual bool verify(const std::string& token) = 0;
 };
 
+/// JWT Authorization.
 class JWTAuth: public AuthBase
 {
 public:
@@ -61,6 +62,7 @@ private:
 Poco::Crypto::RSADigestEngine _digestEngine;
 };
 
+/// OAuth Authorization.
 class OAuth : public AuthBase
 {
 public:
diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index 5995397..ce58a4e 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -23,6 +23,8 @@ class CallbackWorker;
 typedef std::function OnLoadCallback;
 typedef std::function OnUnloadCallback;
 
+/// Represents a client session, with the socket end-point,
+/// and handles all incoming UI traffic.
 class ChildSession final : public LOOLSession
 {
 public:
diff --git a/loolwsd/ClientSession.hpp b/loolwsd/ClientSession.hpp
index f02fcd5..b6126a5 100644
--- a/loolwsd/ClientSession.hpp
+++ b/loolwsd/ClientSession.hpp
@@ -16,6 +16,7 @@
 class DocumentBroker;
 class PrisonerSession;
 
+/// Represents client sessions and socket end-point in WSD.
 class ClientSession final : public LOOLSession, public 
std::enable_shared_from_this
 {
 public:
diff --git a/loolwsd/Connect.cpp b/loolwsd/Connect.cpp
index eef9a66..f6cc287 100644
--- a/loolwsd/Connect.cpp
+++ b/loolwsd/Connect.cpp
@@ -71,7 +71,8 @@ using Poco::Util::Application;
 static bool closeExpected = false;
 static std::mutex coutMutex;
 
-class Output: public Runnable
+/// Prints incoming data from a WebSocket.
+class Output : public Runnable
 {
 public:
 Output(WebSocket& ws) :
@@ -132,7 +133,7 @@ public:
 WebSocket& _ws;
 };
 
-/** Program for interactive or scripted testing of a lool server. */
+/// Program for interactive or scripted testing of a lool server.
 class Connect: public Poco::Util::Application
 {
 public:
diff --git a/loolwsd/FileServer.hpp b/loolwsd/FileServer.hpp
index e2afc47..04bf7f1 100644
--- a/loolwsd/FileServer.hpp
+++ b/loolwsd/FileServer.hpp
@@ -24,6 +24,7 @@
 
 #include "Log.hpp"
 
+/// Handles file requests over HTTP(S).
 class FileServerRequestHandler: public Poco::Net::HTTPRequestHandler
 {
 std::string

[Libreoffice-commits] online.git: loolwsd/Util.hpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/Util.hpp |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 359731f0969b33a8a4f387678831baba4a12c5ae
Author: Ashod Nakashian 
Date:   Sun Aug 14 00:01:45 2016 -0400

loolwsd: cleanup of RuntimeConstant class

Change-Id: If3d57e73445cdb0b92c6b3721b4b7b0ca030a2d7
Reviewed-on: https://gerrit.libreoffice.org/28129
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Util.hpp b/loolwsd/Util.hpp
index f3425fe..c69315e 100644
--- a/loolwsd/Util.hpp
+++ b/loolwsd/Util.hpp
@@ -202,28 +202,32 @@ namespace Util
 std::set _denied;
 };
 
+/// A logical constant that is allowed to initialize
+/// exactly once and checks usage before initialization.
 template
 class RuntimeConstant
 {
 T _value;
-bool _initialized;
+std::atomic _initialized;
 
 public:
 RuntimeConstant()
 : _value()
 , _initialized(false)
-{}
+{
+}
+
+/// Use a compile-time const instead.
+RuntimeConstant(const T& value) = delete;
 
 const T& get()
 {
-if(_initialized)
+if (_initialized)
 {
 return _value;
 }
-else
-{
-throw std::runtime_error("RuntimeConstant instance read before 
being initialized.");
-}
+
+throw std::runtime_error("RuntimeConstant instance read before 
being initialized.");
 }
 
 void set(const T& value)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |   20 ++--
 loolwsd/LOOLKit.cpp  |   21 -
 2 files changed, 10 insertions(+), 31 deletions(-)

New commits:
commit 6af13994e68788c5ddc5618758d7ee76932c27bd
Author: Ashod Nakashian 
Date:   Sat Aug 13 19:17:03 2016 -0400

loolwsd: cleanup and simplify

Change-Id: I48a841a3ce6638e33a96ed44c75e6d2e17dc1c37
Reviewed-on: https://gerrit.libreoffice.org/28125
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index aedcfa6..3cda3ff 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -10,42 +10,26 @@
 #include "ChildSession.hpp"
 #include "config.h"
 
-#include 
-#include 
-
-#include 
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
-#include 
 #include 
 #include 
 
-#include "Common.hpp"
 #include "LOKitHelper.hpp"
-#include "LOOLProtocol.hpp"
 #include "Log.hpp"
 #include "Png.hpp"
-#include "Rectangle.hpp"
 #include "Util.hpp"
 
-using namespace LOOLProtocol;
-
-using Poco::AutoPtr;
-using Poco::Exception;
 using Poco::JSON::Object;
 using Poco::JSON::Parser;
 using Poco::Net::WebSocket;
-using Poco::Notification;
-using Poco::NotificationQueue;
-using Poco::Runnable;
 using Poco::StringTokenizer;
 using Poco::Timestamp;
 using Poco::URI;
 
+using namespace LOOLProtocol;
+
 std::recursive_mutex ChildSession::Mutex;
 
 ChildSession::ChildSession(const std::string& id,
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index bb67ef9..994e2a7 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -64,8 +64,6 @@
 
 typedef int (LokHookPreInit)  (const char *install_path, const char 
*user_profile_path);
 
-using namespace LOOLProtocol;
-
 using Poco::AutoPtr;
 using Poco::Exception;
 using Poco::File;
@@ -85,6 +83,8 @@ using Poco::Timestamp;
 using Poco::URI;
 using Poco::Util::Application;
 
+using namespace LOOLProtocol;
+
 namespace
 {
 typedef enum { COPY_ALL, COPY_LO, COPY_NO_USR } LinkOrCopyType;
@@ -416,7 +416,8 @@ public:
   "]. There are " + std::to_string(_clientViews) + " views.");
 
 // Wait for the callback worker to finish.
-stop();
+_stop = true;
+_callbackQueue.wakeUpAll();
 _callbackThread.join();
 
 // Flag all connections to stop.
@@ -824,10 +825,10 @@ private:
 
 /// Load a document (or view) and register callbacks.
 std::shared_ptr onLoad(const std::string& sessionId,
-   const std::string& uri,
-   const std::string& docPassword,
-   const std::string& renderOpts,
-   bool haveDocPassword)
+  const std::string& uri,
+  const std::string& docPassword,
+  const std::string& renderOpts,
+  bool haveDocPassword)
 {
 Log::info("Session " + sessionId + " is loading. " + 
std::to_string(_clientViews) + " views loaded.");
 
@@ -1064,12 +1065,6 @@ private:
 Log::debug("Thread finished.");
 }
 
-void stop()
-{
-_stop = true;
-_callbackQueue.wakeUpAll();
-}
-
 private:
 
 const bool _multiView;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLForKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/LOOLForKit.cpp |   26 +++---
 1 file changed, 11 insertions(+), 15 deletions(-)

New commits:
commit 8745e24fa9322f966cb0b566751b832ca7064864
Author: Ashod Nakashian 
Date:   Sat Aug 13 23:59:10 2016 -0400

loolwsd: ChildDispatcher -> CommandDispatcher

Change-Id: I9e51e4258ae05dd0e56d52ba2f99fadbcb58257c
Reviewed-on: https://gerrit.libreoffice.org/28127
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLForKit.cpp b/loolwsd/LOOLForKit.cpp
index 2081a8f..b1b1068 100644
--- a/loolwsd/LOOLForKit.cpp
+++ b/loolwsd/LOOLForKit.cpp
@@ -56,19 +56,21 @@ int MasterPortNumber = DEFAULT_MASTER_PORT_NUMBER;
 
 static int pipeFd = -1;
 
-class ChildDispatcher : public IoUtil::PipeReader
+/// Dispatcher class to demultiplex requests from
+/// WSD and handles them.
+class CommandDispatcher : public IoUtil::PipeReader
 {
 public:
-ChildDispatcher(const int pipe) :
+CommandDispatcher(const int pipe) :
 PipeReader("wsd_pipe_rd", pipe)
 {
 }
 
-/// Polls WSD commands and dispatches them to the appropriate child.
+/// Polls WSD commands and handles them.
 bool pollAndDispatch()
 {
-std::string line;
-const auto ready = readLine(line, [](){ return TerminationFlag.load(); 
});
+std::string message;
+const auto ready = readLine(message, [](){ return 
TerminationFlag.load(); });
 if (ready == 0)
 {
 // Timeout.
@@ -85,15 +87,7 @@ public:
 return false;
 }
 
-handleInput(line);
-return true;
-}
-
-private:
-void handleInput(const std::string& message)
-{
 Log::info("ForKit command: [" + message + "].");
-
 StringTokenizer tokens(message, " ", StringTokenizer::TOK_IGNORE_EMPTY 
| StringTokenizer::TOK_TRIM);
 
 if (tokens[0] == "spawn" && tokens.count() == 2)
@@ -109,6 +103,8 @@ private:
 Log::warn("Cannot spawn " + tokens[1] + " children as 
requested.");
 }
 }
+
+return true;
 }
 };
 
@@ -316,14 +312,14 @@ int main(int argc, char** argv)
 std::_Exit(Application::EXIT_SOFTWARE);
 }
 
-ChildDispatcher childDispatcher(pipeFd);
+CommandDispatcher commandDispatcher(pipeFd);
 Log::info("ForKit process is ready.");
 
 while (!TerminationFlag)
 {
 UnitKit::get().invokeForKitTest();
 
-if (!childDispatcher.pollAndDispatch())
+if (!commandDispatcher.pollAndDispatch())
 {
 Log::info("Child dispatcher flagged for termination.");
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   37 +++--
 1 file changed, 15 insertions(+), 22 deletions(-)

New commits:
commit a30526c87ea01026f6ff3f07671ddfc614aebc5e
Author: Ashod Nakashian 
Date:   Sat Aug 13 19:32:59 2016 -0400

loolwsd: remove queue thread from child socket handler

Change-Id: Ibcdd6146bf3fc20813520213b696079b793cf830
Reviewed-on: https://gerrit.libreoffice.org/28126
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 994e2a7..5a37d42 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -52,7 +52,6 @@
 #include "LibreOfficeKit.hpp"
 #include "Log.hpp"
 #include "Png.hpp"
-#include "QueueHandler.hpp"
 #include "Rectangle.hpp"
 #include "TileDesc.hpp"
 #include "Unit.hpp"
@@ -284,27 +283,21 @@ public:
 
 try
 {
-auto queue = std::make_shared();
-QueueHandler handler(queue, _session, "kit_queue_" + 
_session->getId());
-
-Thread queueHandlerThread;
-queueHandlerThread.start(handler);
-std::shared_ptr session = _session;
-
 IoUtil::SocketProcessor(_ws,
-[](const std::vector& payload)
+[this](const std::vector& payload)
 {
-queue->put(payload);
+if (!_session->handleInput(payload.data(), payload.size()))
+{
+Log::info("Socket handler flagged for finishing.");
+return false;
+}
+
 return true;
 },
-[]() { session->closeFrame(); },
-[]() { return TerminationFlag || 
!queueHandlerThread.isRunning(); });
-
-queue->clear();
-queue->put("eof");
-queueHandlerThread.join();
+[this]() { _session->closeFrame(); },
+[]() { return !!TerminationFlag; });
 
-if (session->isCloseFrame())
+if (_session->isCloseFrame())
 {
 Log::trace("Normal close handshake.");
 _ws->shutdown();
@@ -760,15 +753,15 @@ private:
 
 static void ViewCallback(const int nType, const char* pPayload, void* 
pData)
 {
-const std::string payload = pPayload ? pPayload : "(nil)";
-Log::trace() << "Document::ViewCallback "
- << LOKitHelper::kitCallbackTypeToString(nType)
- << " [" << payload << "]." << Log::end;
-
 CallbackDescriptor* pDescr = 
reinterpret_cast(pData);
 assert(pDescr && "Null callback data.");
 assert(pDescr->Doc && "Null Document instance.");
 
+const std::string payload = pPayload ? pPayload : "(nil)";
+Log::trace() << "Document::ViewCallback [" << pDescr->ViewId
+ << "] [" << LOKitHelper::kitCallbackTypeToString(nType)
+ << "] [" << payload << "]." << Log::end;
+
 // Forward to the same view only.
 // Demultiplexing is done by Core.
 // TODO: replace with a map to be faster.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |  437 ++-
 loolwsd/ChildSession.hpp |6 
 loolwsd/LOOLKit.cpp  |  118 ++--
 3 files changed, 273 insertions(+), 288 deletions(-)

New commits:
commit e3507552b7a342b961f9a0d786294da4e13b80a4
Author: Ashod Nakashian 
Date:   Sat Aug 13 18:25:06 2016 -0400

loolwsd: one thread and queue per document

Each ChildSession had its own thread and queue,
which was an overkill. By moving the LOK callback
handler into Document and handling all events in the
same order that we receive them we reduce resource
consumption without affecting performance.

In fact, performance could improve by avoiding
unnecessary overheads.

Change-Id: Ic2bac0f08c28e91acabd512a704966c6b761fc7c
Reviewed-on: https://gerrit.libreoffice.org/28124
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index 9a89b66..aedcfa6 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -46,258 +46,6 @@ using Poco::StringTokenizer;
 using Poco::Timestamp;
 using Poco::URI;
 
-class CallbackNotification: public Notification
-{
-public:
-typedef AutoPtr Ptr;
-
-CallbackNotification(const int nType, const std::string& rPayload)
-  : _nType(nType),
-_aPayload(rPayload)
-{
-}
-
-const int _nType;
-const std::string _aPayload;
-};
-
-/// This thread handles callbacks from the lokit instance.
-class CallbackWorker: public Runnable
-{
-public:
-CallbackWorker(NotificationQueue& queue, ChildSession& session):
-_queue(queue),
-_session(session),
-_stop(false)
-{
-}
-
-void callback(const int nType, const std::string& rPayload)
-{
-auto lock = _session.getLock();
-
-// Cache important notifications to replay them when our client
-// goes inactive and loses them.
-if (nType == LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR ||
-nType == LOK_CALLBACK_CURSOR_VISIBLE ||
-nType == LOK_CALLBACK_CELL_CURSOR ||
-nType == LOK_CALLBACK_CELL_FORMULA ||
-nType == LOK_CALLBACK_GRAPHIC_SELECTION ||
-nType == LOK_CALLBACK_TEXT_SELECTION ||
-nType == LOK_CALLBACK_TEXT_SELECTION_START ||
-nType == LOK_CALLBACK_TEXT_SELECTION_END ||
-nType == LOK_CALLBACK_DOCUMENT_SIZE_CHANGED)
-{
-_session.setDocState(nType, rPayload);
-}
-
-const auto typeName = LOKitHelper::kitCallbackTypeToString(nType);
-if (_session.isCloseFrame())
-{
-Log::trace("Skipping callback [" + typeName + "] on closing 
session " + _session.getName());
-return;
-}
-else if (_session.isDisconnected())
-{
-Log::trace("Skipping callback [" + typeName + "] on disconnected 
session " + _session.getName());
-return;
-}
-else if (!_session.isActive())
-{
-// Pass save notifications through.
-if (nType != LOK_CALLBACK_UNO_COMMAND_RESULT || 
rPayload.find(".uno:Save") == std::string::npos)
-{
-Log::trace("Skipping callback [" + typeName + "] on inactive 
session " + _session.getName());
-return;
-}
-}
-
-Log::trace() << "CallbackWorker::callback [" << _session.getName() << 
"]: "
- << typeName << " [" << rPayload << "]." << Log::end;
-switch (nType)
-{
-case LOK_CALLBACK_INVALIDATE_TILES:
-{
-const auto curPart = _session.getPart();
-
-StringTokenizer tokens(rPayload, " ", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
-if (tokens.count() == 4)
-{
-int x, y, width, height;
-try
-{
-x = std::stoi(tokens[0]);
-y = std::stoi(tokens[1]);
-width = std::stoi(tokens[2]);
-height = std::stoi(tokens[3]);
-}
-catch (const std::out_of_range&)
-{
-// something went wrong, invalidate everything
-Log::warn("Ignoring integer values out of range: " + 
rPayload);
-x = 0;
-y = 0;
-width = INT_MAX;
-height = INT_MAX;
-}
-
-_session.sendTextFrame("invalidatetiles:"
-   " part=" + std::to_string(curPart) +
-   " x=" + std::to_string(x) +
-   " y=" +

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/LibreOfficeKit.hpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp   |   14 +-
 loolwsd/ChildSession.hpp   |   14 --
 loolwsd/LibreOfficeKit.hpp |8 ++--
 3 files changed, 11 insertions(+), 25 deletions(-)

New commits:
commit 58468c76be771a7b1fc0b7372c2c5cb3c4b5b44a
Author: Ashod Nakashian 
Date:   Sat Aug 13 12:14:44 2016 -0400

loolwsd: cleaned up ChildSession public members

Change-Id: I4bfc008859edb979688ece89d99af227ea3d0416
Reviewed-on: https://gerrit.libreoffice.org/28123
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index dbc1a5c..9a89b66 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -118,19 +118,7 @@ public:
 {
 case LOK_CALLBACK_INVALIDATE_TILES:
 {
-const auto lokitDoc = _session.getLoKitDocument();
-if (lokitDoc == nullptr)
-{
-return;
-}
-
-assert(lokitDoc->pClass);
-assert(lokitDoc->pClass->getPart);
-
-// Text docs have a single coordinate system.
-const auto curPart = (_session.getDocType() == "text")
-   ? 0
-   : lokitDoc->pClass->getPart(lokitDoc);
+const auto curPart = _session.getPart();
 
 StringTokenizer tokens(rPayload, " ", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
 if (tokens.count() == 4)
diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index 7045a04..1481a9f 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -42,21 +42,16 @@ public:
 
 bool getStatus(const char *buffer, int length);
 bool getPartPageRectangles(const char *buffer, int length);
-virtual void disconnect() override;
-
 unsigned getViewId() const { return _viewId; }
+int getPart() const { return _loKitDocument->getPart(); }
 
-const std::string& getDocType() const { return _docType; }
-
-LibreOfficeKitDocument *getLoKitDocument() const { return (_loKitDocument 
? _loKitDocument->get() : nullptr); }
+void setDocState(const int type, const std::string& payload) { 
_lastDocStates[type] = payload; }
 
 void loKitCallback(const int nType, const std::string& payload);
 
 static std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
 
-void setDocState(const int type, const std::string& payload) { 
_lastDocStates[type] = payload; }
-
- protected:
+private:
 bool loadDocument(const char *buffer, int length, Poco::StringTokenizer& 
tokens);
 
 bool sendFontRendering(const char *buffer, int length, 
Poco::StringTokenizer& tokens);
@@ -79,8 +74,7 @@ public:
 bool setClientPart(const char *buffer, int length, Poco::StringTokenizer& 
tokens);
 bool setPage(const char *buffer, int length, Poco::StringTokenizer& 
tokens);
 
-private:
-
+virtual void disconnect() override;
 virtual bool _handleInput(const char *buffer, int length) override;
 
 private:
diff --git a/loolwsd/LibreOfficeKit.hpp b/loolwsd/LibreOfficeKit.hpp
index 326d996..4e2aab0 100644
--- a/loolwsd/LibreOfficeKit.hpp
+++ b/loolwsd/LibreOfficeKit.hpp
@@ -41,7 +41,9 @@ public:
 }
 
 /// This lock must be held while calling
-/// one or more member of this class.
+/// one or more members of this class if
+/// the client is multi-threaded.
+/// No member function takes this lock otherwise.
 std::unique_lock getLock()
 {
 return std::unique_lock(_mutex);
@@ -110,9 +112,11 @@ public:
 }
 
 /// Get the current part of the document.
+/// Note: For Writer documents this always returns 0
+/// since text docs have a single coordinate system.
 inline int getPart()
 {
-return _pDoc->pClass->getPart(_pDoc);
+return getDocumentType() == LOK_DOCTYPE_TEXT ? 0 : 
_pDoc->pClass->getPart(_pDoc);
 }
 
 /// Set the current part of the document.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.hpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.hpp |2 -
 loolwsd/LOOLKit.cpp  |   77 +--
 2 files changed, 36 insertions(+), 43 deletions(-)

New commits:
commit ae5f47234ccc88c87d886ffa86eec422bf5043d8
Author: Ashod Nakashian 
Date:   Fri Aug 12 21:15:38 2016 -0400

loolwsd: per-session callbacks

Callbacks from Core are now per-session and not
shared among all. A new descriptor is used to
help get from the callback to the respective
session.

Change-Id: Ie72771da05eef4760cf01351f7c06c034abf5109
Reviewed-on: https://gerrit.libreoffice.org/28122
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index 15a2e18..7045a04 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -44,7 +44,7 @@ public:
 bool getPartPageRectangles(const char *buffer, int length);
 virtual void disconnect() override;
 
-int getViewId() const { return _viewId; }
+unsigned getViewId() const { return _viewId; }
 
 const std::string& getDocType() const { return _docType; }
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 50f100a..74d259c 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -342,6 +342,14 @@ private:
 /// Regex to parse the ViewId from json.
 static std::regex ViewIdRegex("\"viewId\"\\s*:\\s*\"(\\d*)\"");
 
+class Document;
+
+struct CallbackDescriptor
+{
+const Document* const Doc;
+const unsigned ViewId;
+};
+
 /// A document container.
 /// Owns LOKitDocument instance and connections.
 /// Manages the lifetime of a document.
@@ -727,49 +735,22 @@ private:
 Log::trace() << "Document::ViewCallback "
  << LOKitHelper::kitCallbackTypeToString(nType)
  << " [" << payload << "]." << Log::end;
-Document* self = reinterpret_cast(pData);
-if (self == nullptr)
-{
-return;
-}
+CallbackDescriptor* pDescr = 
reinterpret_cast(pData);
+assert(pDescr && "Null callback data.");
+assert(pDescr->Doc && "Null Document instance.");
 
-std::unique_lock lock(self->_mutex);
-
-if (nType == LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY ||
-nType == LOK_CALLBACK_DOCUMENT_PASSWORD)
-{
-// Mark the document password type.
-self->setDocumentPassword(nType);
-return;
-}
-
-// We can't invoke loKitDocument here as that could deadlock.
-// We have to parse the message to get the target view.
-// We can do it here once at the expense of the lok thread, or,
-// dispatch swiftly and prase multiple times in each session.
-int viewId = -1;
-std::smatch match;
-if (std::regex_search(payload.begin(), payload.end(), match, 
ViewIdRegex) &&
-match.length() > 1)
-{
-const auto strViewId = match[1].str();
-viewId = std::stoi(strViewId);
-}
+std::unique_lock lock(pDescr->Doc->_mutex);
 
 // Forward to the same view only.
-for (auto& it: self->_connections)
+// Demultiplexing is done by Core.
+// TODO: replace with a map to be faster.
+for (auto& it: pDescr->Doc->_connections)
 {
-if (it.second->isRunning())
+auto session = it.second->getSession();
+if (session && it.second->isRunning() &&
+session->getViewId() == pDescr->ViewId)
 {
-auto session = it.second->getSession();
-if (session)
-{
-if (viewId < 0 || session->getViewId() == viewId)
-{
-// Broadcast if not view-specific.
-session->loKitCallback(nType, payload);
-}
-}
+session->loKitCallback(nType, payload);
 }
 }
 }
@@ -879,6 +860,7 @@ private:
 << _clientViews << " views." << Log::end;
 
 const auto viewId = _loKitDocument->getView();
+_viewIdToCallbackDescr.erase(viewId);
 _loKitDocument->registerCallback(nullptr, nullptr);
 _loKitDocument->destroyView(viewId);
 }
@@ -901,7 +883,7 @@ private:
 }
 
 auto session = it->second->getSession();
-auto& callback = _multiView ? ViewCallback : DocumentCallback;
+unsigned viewId = 0;
 
 if (!_loKitDocument)
 {
@@ -986,7 +968,7 @@ private:
 if (_multiView)
 {
 Log::info("Loading view to document from URI: [" + uri + "] 
for session [" + sessionId + "].");
-const auto viewId = _loKitDocument->createView();
+viewId =

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   25 ++---
 1 file changed, 22 insertions(+), 3 deletions(-)

New commits:
commit 5a20ae67baaf95d5f63373b4f429fcdb320b9649
Author: Ashod Nakashian 
Date:   Fri Aug 12 18:42:47 2016 -0400

loolwsd: parse the ViewId of event payloads to dispatch

Change-Id: I70e603c7f9d5d63e6ca0c3fb0364310112bc03c0
Reviewed-on: https://gerrit.libreoffice.org/28121
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index bb0a42a..50f100a 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define LOK_USE_UNSTABLE_API
 #include 
@@ -338,6 +339,9 @@ private:
 std::atomic _joined;
 };
 
+/// Regex to parse the ViewId from json.
+static std::regex ViewIdRegex("\"viewId\"\\s*:\\s*\"(\\d*)\"");
+
 /// A document container.
 /// Owns LOKitDocument instance and connections.
 /// Manages the lifetime of a document.
@@ -739,7 +743,18 @@ private:
 return;
 }
 
-const auto viewId = self->_loKitDocument->getView();
+// We can't invoke loKitDocument here as that could deadlock.
+// We have to parse the message to get the target view.
+// We can do it here once at the expense of the lok thread, or,
+// dispatch swiftly and prase multiple times in each session.
+int viewId = -1;
+std::smatch match;
+if (std::regex_search(payload.begin(), payload.end(), match, 
ViewIdRegex) &&
+match.length() > 1)
+{
+const auto strViewId = match[1].str();
+viewId = std::stoi(strViewId);
+}
 
 // Forward to the same view only.
 for (auto& it: self->_connections)
@@ -747,9 +762,13 @@ private:
 if (it.second->isRunning())
 {
 auto session = it.second->getSession();
-if (session && session->getViewId() == viewId)
+if (session)
 {
-session->loKitCallback(nType, pPayload);
+if (viewId < 0 || session->getViewId() == viewId)
+{
+// Broadcast if not view-specific.
+session->loKitCallback(nType, payload);
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp loolwsd/ChildSession.hpp loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |4 ++--
 loolwsd/ChildSession.hpp |2 +-
 loolwsd/LOOLKit.cpp  |8 +---
 3 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 10737fdeab7031ad4cfc61734d76effe328ecd07
Author: Ashod Nakashian 
Date:   Fri Aug 12 18:37:10 2016 -0400

loolwsd: payload as std::string

Change-Id: Icee8a16fd18489da87e22955f3126851261332e5
Reviewed-on: https://gerrit.libreoffice.org/28120
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index f70348d..dbc1a5c 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -1185,9 +1185,9 @@ bool ChildSession::setPage(const char* /*buffer*/, int 
/*length*/, StringTokeniz
 return true;
 }
 
-void ChildSession::loKitCallback(const int nType, const char *pPayload)
+void ChildSession::loKitCallback(const int nType, const std::string& payload)
 {
-auto pNotif = new CallbackNotification(nType, pPayload ? pPayload : 
"(nil)");
+auto pNotif = new CallbackNotification(nType, payload);
 _callbackQueue.enqueueNotification(pNotif);
 }
 
diff --git a/loolwsd/ChildSession.hpp b/loolwsd/ChildSession.hpp
index 72b4883..15a2e18 100644
--- a/loolwsd/ChildSession.hpp
+++ b/loolwsd/ChildSession.hpp
@@ -50,7 +50,7 @@ public:
 
 LibreOfficeKitDocument *getLoKitDocument() const { return (_loKitDocument 
? _loKitDocument->get() : nullptr); }
 
-void loKitCallback(const int nType, const char* pPayload);
+void loKitCallback(const int nType, const std::string& payload);
 
 static std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
 
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 6a54fd1..bb0a42a 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -719,9 +719,10 @@ private:
 
 static void ViewCallback(const int nType, const char* pPayload, void* 
pData)
 {
+const std::string payload = pPayload ? pPayload : "(nil)";
 Log::trace() << "Document::ViewCallback "
  << LOKitHelper::kitCallbackTypeToString(nType)
- << " [" << (pPayload ? pPayload : "") << "]." << Log::end;
+ << " [" << payload << "]." << Log::end;
 Document* self = reinterpret_cast(pData);
 if (self == nullptr)
 {
@@ -756,9 +757,10 @@ private:
 
 static void DocumentCallback(const int nType, const char* pPayload, void* 
pData)
 {
+const std::string payload = pPayload ? pPayload : "(nil)";
 Log::trace() << "Document::DocumentCallback "
  << LOKitHelper::kitCallbackTypeToString(nType)
- << " [" << (pPayload ? pPayload : "") << "]." << Log::end;
+ << " [" << payload << "]." << Log::end;
 Document* self = reinterpret_cast(pData);
 if (self == nullptr)
 {
@@ -783,7 +785,7 @@ private:
 auto session = it.second->getSession();
 if (session)
 {
-session->loKitCallback(nType, pPayload);
+session->loKitCallback(nType, payload);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildSession.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ChildSession.cpp |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 2744caf97b4c1be26966d04e61518022f9f546a9
Author: Ashod Nakashian 
Date:   Fri Aug 12 09:42:31 2016 -0400

loolwsd: simplify status after load

Change-Id: I919e09616173d88eda8989e06da05ae54c0bdda0
Reviewed-on: https://gerrit.libreoffice.org/28119
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildSession.cpp b/loolwsd/ChildSession.cpp
index 4cc4eb9..f70348d 100644
--- a/loolwsd/ChildSession.cpp
+++ b/loolwsd/ChildSession.cpp
@@ -639,8 +639,12 @@ bool ChildSession::loadDocument(const char * /*buffer*/, 
int /*length*/, StringT
 
 // Respond by the document status, which has no arguments.
 Log::debug("Sending status after loading view " + std::to_string(_viewId) 
+ ".");
-if (!getStatus(nullptr, 0))
+const auto status = LOKitHelper::documentStatus(_loKitDocument->get());
+if (status.empty() || !sendTextFrame("status: " + status))
+{
+Log::error("Failed to get/forward document status [" + status + "].");
 return false;
+}
 
 Log::info("Loaded session " + getId());
 return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/LOOLKit.cpp |   40 +---
 1 file changed, 37 insertions(+), 3 deletions(-)

New commits:
commit dafa5d078de76aab9aaf8f0990b066fe476805a3
Author: Ashod Nakashian 
Date:   Thu Aug 11 20:09:55 2016 -0400

loolwsd: split out per-view LOK callback from default

Change-Id: I01c0bb14cabbbe06bc790920d0f74d0f106bbbde
Reviewed-on: https://gerrit.libreoffice.org/28118
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 7a7b545..6a54fd1 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -717,9 +717,41 @@ public:
 
 private:
 
-static void ViewCallback(int , const char* , void* )
+static void ViewCallback(const int nType, const char* pPayload, void* 
pData)
 {
-//TODO: Delegate the callback.
+Log::trace() << "Document::ViewCallback "
+ << LOKitHelper::kitCallbackTypeToString(nType)
+ << " [" << (pPayload ? pPayload : "") << "]." << Log::end;
+Document* self = reinterpret_cast(pData);
+if (self == nullptr)
+{
+return;
+}
+
+std::unique_lock lock(self->_mutex);
+
+if (nType == LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY ||
+nType == LOK_CALLBACK_DOCUMENT_PASSWORD)
+{
+// Mark the document password type.
+self->setDocumentPassword(nType);
+return;
+}
+
+const auto viewId = self->_loKitDocument->getView();
+
+// Forward to the same view only.
+for (auto& it: self->_connections)
+{
+if (it.second->isRunning())
+{
+auto session = it.second->getSession();
+if (session && session->getViewId() == viewId)
+{
+session->loKitCallback(nType, pPayload);
+}
+}
+}
 }
 
 static void DocumentCallback(const int nType, const char* pPayload, void* 
pData)
@@ -848,6 +880,7 @@ private:
 }
 
 auto session = it->second->getSession();
+auto& callback = _multiView ? ViewCallback : DocumentCallback;
 
 if (!_loKitDocument)
 {
@@ -858,6 +891,7 @@ private:
 auto lock(_loKit->getLock());
 if (LIBREOFFICEKIT_HAS(_loKit->get(), registerCallback))
 {
+//TODO: Use GlobalCallback for Password and statusindicator.
 _loKit->get()->pClass->registerCallback(_loKit->get(), 
DocumentCallback, this);
 const auto flags = LOK_FEATURE_DOCUMENT_PASSWORD
  | LOK_FEATURE_DOCUMENT_PASSWORD_TO_MODIFY;
@@ -943,7 +977,7 @@ private:
 // registerCallback(), as the previous creates a new view in Impress.
 _loKitDocument->initializeForRendering(_renderOpts.c_str());
 
-_loKitDocument->registerCallback(DocumentCallback, this);
+_loKitDocument->registerCallback(callback, this);
 
 return _loKitDocument;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ClientSession.cpp loolwsd/PrisonerSession.cpp

2016-08-14 Thread Ashod Nakashian 
 loolwsd/ClientSession.cpp   |   11 ---
 loolwsd/PrisonerSession.cpp |1 -
 2 files changed, 12 deletions(-)

New commits:
commit 96934590a003d6a57972da4933c1eab014486347
Author: Ashod Nakashian 
Date:   Thu Aug 11 12:52:20 2016 -0400

loolwsd: do not cache status since it has per-view info

Change-Id: Ia32383cffd7b489fe3124457897991555b918db6
Reviewed-on: https://gerrit.libreoffice.org/28117
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ClientSession.cpp b/loolwsd/ClientSession.cpp
index d2debdf..c0607a9 100644
--- a/loolwsd/ClientSession.cpp
+++ b/loolwsd/ClientSession.cpp
@@ -250,17 +250,6 @@ bool ClientSession::loadDocument(const char* /*buffer*/, 
int /*length*/, StringT
 
 bool ClientSession::getStatus(const char *buffer, int length)
 {
-const std::string status = 
_docBroker->tileCache().getTextFile("status.txt");
-if (!status.empty())
-{
-sendTextFrame(status);
-
-// And let clients know if they hold the edit lock.
-const auto msg = "editlock: " + std::to_string(isEditLocked());
-Log::debug("Returning [" + msg + "] in response to status.");
-return sendTextFrame(msg);
-}
-
 return forwardToPeer(_peer, buffer, length, false);
 }
 
diff --git a/loolwsd/PrisonerSession.cpp b/loolwsd/PrisonerSession.cpp
index 95a5fbd..1dc9cbe 100644
--- a/loolwsd/PrisonerSession.cpp
+++ b/loolwsd/PrisonerSession.cpp
@@ -183,7 +183,6 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 else if (tokens[0] == "status:")
 {
 _docBroker->setLoaded();
-_docBroker->tileCache().saveTextFile(std::string(buffer, length), 
"status.txt");
 
 // Forward the status response to the client.
 forwardToPeer(_peer, buffer, length, isBinary);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

2016-08-14 Thread Ashod Nakashian 
 loolwsd/test/TileCacheTests.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6194b043c05bb87c3956125342f5313c077339cc
Author: Ashod Nakashian 
Date:   Thu Aug 11 10:48:54 2016 -0400

loolwsd: better UT failure message

Change-Id: Iad269910b1a38f67d87811590ffecefe27ba99cd
Reviewed-on: https://gerrit.libreoffice.org/28116
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/TileCacheTests.cpp b/loolwsd/test/TileCacheTests.cpp
index 54177d4..360b849 100644
--- a/loolwsd/test/TileCacheTests.cpp
+++ b/loolwsd/test/TileCacheTests.cpp
@@ -236,7 +236,7 @@ void TileCacheTests::testUnresponsiveClient()
 for (auto i = 0; i < 8; ++i)
 {
 auto tile = getResponseMessage(socket2, "tile:", "client2 ");
-CPPUNIT_ASSERT_MESSAGE("did not receive a tile: message as 
expected", !tile.empty());
+CPPUNIT_ASSERT_MESSAGE("Did not receive tile #" + 
std::to_string(i+1) + " of 8: message as expected", !tile.empty());
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101531] New: Arrowhead does not display correctly from PPTX in impress

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101531

Bug ID: 101531
   Summary: Arrowhead does not display correctly from PPTX in
impress
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dwhee...@dwheeler.com

Created attachment 126834
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126834=edit
Sample slide in PPTX format

When importing from PPTX, arrows do not display correctly. The "arrow" part is
completely disconnected from the line-body, which looks ugly and is confusing.

I've attached a slide with an arrow on the left & a bitmapped image of the
arrow on the right.  They should look the same; they don't.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80526] FILEOPEN: DOCX frame not being stretched to accomodate text in it

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80526

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu
  Component|Writer  |filters and storage

--- Comment #6 from Aron Budea  ---
No improvement in v5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97677] Writer: Some graphic and drawing objects of a particular docx are not imported

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97677

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu
Version|unspecified |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75685] FILEOPEN: DOC formula loaded as a picture

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75685

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc
 CC||ba...@caesar.elte.hu

--- Comment #8 from Aron Budea  ---
Still reproduced in v5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101471] Non-visible menu bar in Ubuntu 16.04 after upgrade to 5.2.0.4

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101471

--- Comment #11 from Gérald Maruccia  ---
I am also affected by this bug. I use Ubuntu 14.04.5 with Unity (with Xenial
HWE stack). I've updated LO through PPA « fresh »
http://ppa.launchpad.net/libreoffice/ppa/ubuntu
http://img4.hostingpics.net/pics/803659Capturedu20160815012827.png

And I confirm Amr Ibrahim's workaround gets back menus in their expected place.

Whilst menus in LibreOffice Start Center are also broken…

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97037] Rendering of particular Word document with table, frames and backgound graphics completely broken, missing text etc

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97037

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc
 CC||ba...@caesar.elte.hu,
   ||vmik...@collabora.co.uk
 Whiteboard|filter:doc interoperability |interoperability

--- Comment #8 from Aron Budea  ---
For starters, adding Miklos to CC based on bibisect results.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101530] New: LibraOffice would not open

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101530

Bug ID: 101530
   Summary: LibraOffice would not open
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: msgtpau...@gmail.com

LibreOffice would not open from the desktop or right-click/Open. Had to
download the program again from "preferred mirror site". All seems to be good
now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94950] FILEOPEN: text line inside .doc file showed in wrong position

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94950

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc
 CC||ba...@caesar.elte.hu

--- Comment #10 from Aron Budea  ---
Still buggy in v5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94748] FILEOPEN: two pages .doc shown as single page with images superimposed on each other

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94748

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc
 CC||ba...@caesar.elte.hu

--- Comment #2 from Aron Budea  ---
Still occurring in v5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101529] New: after ppa upgrade an extra menu-bar ( invisible but working) is above the icon-row when open by .desktop-icon on ubuntu

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101529

Bug ID: 101529
   Summary: after ppa upgrade an extra menu-bar (invisible but
working) is above the icon-row when open by
.desktop-icon on ubuntu
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sandor@hotmail.com

After upgrade using ppa on ubuntu 16.04 lts libreoffice-gtk2 was removed by
intelligent upgrade and when I restarted libreoffice the entire GUI has set
back to minimum, basic like windows 3.1 style without any GUI formatting.
Reading about it, google it I had to re-install libreoffice-gtk2 manually.
Since then although GUI works but there is a second row of menu with invisible
text above the icon rows, top line basically. And of course there is the
lo-menubar or basic ubuntu menubar in the dark top row (system tray, -row). The
menu works although it is invisible.
If I start the app from within the app such as close document and reopen a new
one using libre office own menu than the problem not exist. Same with opening
the basic window of office and launching the actual app or opening document
from there.
When I open from Dash or Launcher than problem exist.
Affects all Libre Office Application.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79307] FILEOPEN: DOCX password protected files not opening from Word 2007

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=79307

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu
 Whiteboard|interoperability ooxml  |interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100512] [FILEOPEN] docx table (two rows with merged cell on top) stretches beyond the screen

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100512

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||ba...@caesar.elte.hu

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101528] New: Crashes on 3D chart modification

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101528

Bug ID: 101528
   Summary: Crashes on 3D chart modification
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: st...@designbymoonlight.com

Chart freezes when 3D bar chart modifications of several different types are
made.  On running soffice calc from commandline the following general error is
reported from the shell:

*** Error in `/usr/lib/libreoffice/program/soffice.bin': double free or
corruption (fasttop): 0x05004380 ***
*** Error in `/usr/lib/libreoffice/program/soffice.bin': double free or
corruption (fasttop): 0x03d4a800 ***

The calc file may freeze once opened without any further action on my part
except possibly for scrolling.  The problem occurred when editing the 3D bar
chart's x or y axes, including label angle.

In a couple of instances, the window disappeared and the recovery window
appeared immediately offering to restore the files.

Version is 5.2.0.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101518] UI: Show selected functions in multiple status-bar functions only if appropriate

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101518

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|Inherited From OOo  |5.2.0.1 rc

--- Comment #1 from Cor Nouws  ---
I think the advantage of the current situation is that people are (always)
seeing the many possibilities, thus bringing them to ideas :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101527] New: Impress narration does not auto-advance loading from PPTX

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101527

Bug ID: 101527
   Summary: Impress narration does not auto-advance loading from
PPTX
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dwhee...@dwheeler.com

Created attachment 126833
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126833=edit
Demo PPTX file

When loading a PPTX file with narration, the narration on a page is presented,
but the slides do not auto-advance.  That means that a presentation with
embedded narration won't play *as* a presentation.

This bug is probably easy to fix - the audio *is* presented on a given slide,
it's just that without auto-advance you don't have the full experience of a
presentation.

Compare Impress' behavior with Powerpoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/quartz

2016-08-14 Thread Stephan Bergmann 
 vcl/quartz/ctlayout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e22fc8076f347702670134cb7a36d523d046423c
Author: Stephan Bergmann 
Date:   Sun Aug 14 22:41:00 2016 +0200

loplugin:overrideparam

Change-Id: I78513a531f93f6578290107b1d71977820dac965

diff --git a/vcl/quartz/ctlayout.cxx b/vcl/quartz/ctlayout.cxx
index d4eed46..2415298 100644
--- a/vcl/quartz/ctlayout.cxx
+++ b/vcl/quartz/ctlayout.cxx
@@ -47,7 +47,7 @@ public:
 
 virtual DeviceCoordinate GetTextWidth() const override;
 virtual DeviceCoordinate FillDXArray( DeviceCoordinate* pDXArray ) const 
override;
-virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, 
DeviceCoordinate nCharExtra = 0, int nFactor = 1) const override;
+virtual sal_Int32 GetTextBreak(DeviceCoordinate nMaxWidth, 
DeviceCoordinate nCharExtra, int nFactor) const override;
 virtual voidGetCaretPositions( int nArraySize, long* pCaretXArray ) 
const override;
 virtual boolGetBoundRect( SalGraphics&, Rectangle& ) const override;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 66212] Hebrew Numbering incorrect above value ten ( seeing Kaf instead of Yod Aleph)

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=66212

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Hebrew Numbering incorrect  |Hebrew Numbering incorrect
   |above value ten |above value ten (seeing Kaf
   ||instead of Yod Aleph)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66212] Hebrew Numbering incorrect above value ten

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=66212

Eyal Rozenberg  changed:

   What|Removed |Added

Version|4.0.3.3 release |5.1.4.2 release
   Severity|minor   |normal

--- Comment #8 from Eyal Rozenberg  ---
(In reply to tommy27 from comment #7)
Bug still manifests in the release version used in Ubunutu 16.04 at the moment
(5.1.4.2).

This should actually not be incredibly hard to fix, so if any developer is
checking this page out - try devoting 15 minutes to doing this (i.e. changing
the Hebrew numerals behavior to be the same as Default numerals + Hebrew
locale).

Anyway, about the workaround and the importance setting: While it does work, it
has two issues

1. It is not at all obvious, and involves changing settings at two different
and UI-far places. I would probably not have guessed it even given some time.
2. Some people have non-Hebrew locales, and should still see Hebrew documents
rendered properly.

So, I'm upping the severity to normal.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101471] Non-visible menu bar in Ubuntu 16.04 after upgrade to 5.2.0.4

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101471

Amr Ibrahim  changed:

   What|Removed |Added

 CC||amribrahim1...@hotmail.com

--- Comment #10 from Amr Ibrahim  ---
I am also affected by this bug. I use Ubuntu 14.04.5 with Unity (with Xenial
HWE stack).

I found a workaround to make the invisible menu bar disappear. Start LO first
from the Start Centre then open the required document.

If you start LO from a document, opening a second document also makes the
invisible menu bar disappear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81085] EDITING: Slides copied from a pptx presentation are sometimes duplicated or fail to copy

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81085

Vossman  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||415

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95415] When copying one slide, LO pastes a different slide in Impress ; corrupt slide

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=95415

Vossman  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=81
   ||085

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101415] FILESAVE FILEOPEN CSV linebreaks in LINUX

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101415

--- Comment #5 from Andreas Scholz  ---
On the Linux machine (Mint 17.3 64bit): LO 5.1.5.2
On the Windows machine (W7pro 32bit): LO 4.1.4.2

Also LO 4 shows the same behavior regarding the preview as descibed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101517] UI: Improvement to the Find & Replace dialog with Special Characters dialog

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101517

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #1 from Cor Nouws  ---
I would simply include it in bug 100672 ...

Please note there is bug 76787 too. That could be closed as duplicate of 100672
if you give that a broader range.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101526] New: slow, several seconds/keystroke to respond.

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101526

Bug ID: 101526
   Summary: slow, several seconds/keystroke to respond.
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jsai...@sbcglobal.net

User-Agent:   Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101
Firefox/47.0
Build Identifier: latest  (already uninstalled)

Changing a few words can take over a minute. Uninstalled, OpenOffice works fine
on same document.

Reproducible: Always

Steps to Reproduce:
1. Open a large .ODT (600K)
2. Try editing.
3. Watch extremely slow response. Often crashes eventually.
Actual Results:  
slower than an 8088.

Expected Results:  
immediate response.




Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101471] Non-visible menu bar in Ubuntu 16.04 after upgrade to 5.2.0.4

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101471

--- Comment #9 from Cor Nouws  ---
Hi Robert,

I don't have the recent version integrated in Unity, so can't see the effect.

Can you check if there is a difference with the OS setting Appearance >
Behavior.. menu's for a window / visibility menu's ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65046] libreoffice multithreading

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=65046

--- Comment #6 from René Genz  ---
Calc experiences slow downs with charts

To recreate:
- open Calc and create small data set: rows: 0 to 2 in 0.001 steps
(approximately 2000 rows); 5 columns, all start at 0, but have different
increments
- select all data points from data set
- create chart: Chart Type=XY (Scatter) -- Points and Lines -- [Finish]
- GUI of LibreOffice considerably slows down after creation of graph

If chart is out of view, GUI is very fast again.


In LibreOffice 4.4.4.3 (distributed with Fedora 22) moving view to different
rows is:
- slow, if complete chart is in view
- slow, if chart is partly visible
- fast, if chart is not in view


At least with version 5.1.x drawing speed has improved for me.


In LibreOffice 5.1.5.2 (distributed with Fedora 24) and in LibreOffice 5.2.0.4
(tested with Flatpak on Fedora 24) moving view to different rows is:
- fast, if complete chart is in view
- slow, if chart is partly visible
- fast, if chart is not in view


It seems the whole chart is redrawn, if part of it is visible. Then again if
more is visible.
This results in slow work with those charts.
Maybe the chart can be used from memory all time and only be redrawn, if its
data has been changed?


On the same machine (Intel Core 2 Duo E8500 @ 3.16GHz; 4 GB RAM; GeForce 9500
GS) Microsoft Office 2010 32 bit on Windows 7 32 bit is fast in all 3 cases.

LibreOffice on Windows on the same machine shows the behaviour described above.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65925] FILESAVE: Ugly HTML code when changing capital letters and bold text

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=65925

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81345] FILESAVE: Image from first page appears on all pages of document after saving file on LO

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81345

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84127] FILESAVE/FILEOPEN arrangement not saved/ retained for graphics inside frame

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=84127

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:odt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47545] FILEOPEN: VIEWING some items in page header at wrong position

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47545

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:odt

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73629] FILEOPEN: paragraph spacing issues with numbered list .doc

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=73629

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90488] FILESAVE: cross reference in docx corrupted and cause a crash of LO

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90488

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96749] FILEOPEN: Cannot open specific DOCX without header.xml and footer.xml in newer versions

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96749

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81675] FILEOPEN: DOCX indent for list/heading incorrectly imported

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81675

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64789] FILEOPEN: docx opening with images containing drop shadows

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=64789

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79329] FILEOPEN: DOCX table cell frame lost

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=79329

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83309] FILEOPEN: text paragraph indentation/ tab stops in .DOCX displayed incorrectly

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83309

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87052] FILEOPEN: Heading numbers incorrectly computed after DOCX import

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=87052

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69515] FILEOPEN: Tables in floating frames are wrongly positioned ( DOCX import)

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=69515

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93624] FILESAVE: DOCX: Formatting lost after roundtrip

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93624

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80635] FILEOPEN: DOC file floating table width not imported properly

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80635

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #11 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59671] FILESAVE Tab stop in right margin different in .doc export

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=59671

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #9 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94955] FILEOPEN: image inside .doc file showed in wrong position

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94955

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #9 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80869] FILEOPEN: DOC with floating table opens with wrong left margin

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80869

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #11 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 79330] FILEOPEN: DOC Bullet point (direct) formatting ( e.g. highlighting) can't be unformatted without removing the bulleting

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=79330

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #13 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85283] FILEOPEN: DOC - Image with white fill color appearing as transparent

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=85283

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #9 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80717] FILEOPEN: DOC file has incorrect spacing between tables

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80717

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #6 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77964] FILEOPEN: DOC Image Wrapped Optimal instead of No Wrap

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=77964

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #11 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91916] FILEOPEN: Writer hangs when trying to open a certain fishy .doc file

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91916

Björn Michaelsen  changed:

   What|Removed |Added

   Keywords||filter:doc

--- Comment #4 from Björn Michaelsen  ---
adding filt:doc keyword.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80040] FILESAVE: XLSX created hyperlinks don' t show up in Excel in blue

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=80040

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:xlsx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51127] FORMATTING: import of Microsoft .doc file leaves blank page in middle (page 2) of four page document

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=51127

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75154] FILEOPEN: DOC Wrong positioning of text alongside text boxes

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75154

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: ucb/source

2016-08-14 Thread Giuseppe Castagno 
 ucb/source/ucp/webdav-neon/webdavcontent.cxx |   14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 63af1c52c534840d1f55e3041351d24b85edcaa4
Author: Giuseppe Castagno 
Date:   Sun Aug 14 13:18:44 2016 +0200

tdf#101094 (23): Simplify cache removal: MOVE, COPY

Change-Id: Ia9ef644359c34ac30b78d48c79e8bc9d5c639f92
Reviewed-on: https://gerrit.libreoffice.org/28111
Tested-by: Jenkins 
Reviewed-by: Giuseppe Castagno 

diff --git a/ucb/source/ucp/webdav-neon/webdavcontent.cxx 
b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
index 9cada12..55cbd83 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontent.cxx
@@ -2168,7 +2168,7 @@ uno::Any Content::open(
 ucb::IOErrorCode_NOT_EXISTING,
 aArgs ) ),
 xEnv );
-// Unreachable
+// Unreachable
 }
 }
 catch ( DAVException const & e )
@@ -2746,13 +2746,13 @@ void Content::transfer(
 // destination resource.  If the Overwrite header is set to
 // "F" then the operation will fail.
 
+aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
+aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 aSourceAccess.MOVE( sourceURI.GetPath(),
 targetURI.GetURI(),
 rArgs.NameClash
 == ucb::NameClash::OVERWRITE,
 Environment );
-aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
-aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 
 if ( xSource.is() )
 {
@@ -2775,13 +2775,13 @@ void Content::transfer(
 // destination resource.  If the Overwrite header is set to
 // "F" then the operation will fail.
 
+aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
+aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 aSourceAccess.COPY( sourceURI.GetPath(),
 targetURI.GetURI(),
 rArgs.NameClash
 == ucb::NameClash::OVERWRITE,
 Environment );
-aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
-aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 
 // DAV resources store all additional props on server!
 //  // Copy own and all children's Additional Core Properties.
@@ -2801,14 +2801,10 @@ void Content::transfer(
 }
 catch ( ucb::IllegalIdentifierException const & )
 {
-aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
-aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 // queryContent
 }
 catch ( DAVException const & e )
 {
-aStaticDAVOptionsCache.removeDAVOptions( sourceURI.GetURI() );
-aStaticDAVOptionsCache.removeDAVOptions( targetURI.GetURI() );
 // [RFC 2518] - WebDAV
 // 412 (Precondition Failed) - The server was unable to maintain
 // the liveness of the properties listed in the propertybehavior
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101473] [EDITING] Function wizard crashes LibO when evaluating addin that implement XVolatileResult

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101473

jeanmarczam...@gmail.com changed:

   What|Removed |Added

Version|5.1.5.2 release |4.3.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101525] New: Duplicate footer master page elements on fodp write

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101525

Bug ID: 101525
   Summary: Duplicate footer master page elements on fodp write
   Product: LibreOffice
   Version: 5.1.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: freedesk...@treblig.org

Created attachment 126832
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126832=edit
broken document showing duped entries

5.1.5.2-2 fedora 24 x86-64 build 

open the attached document
make a trivial change
save
quit
reload

  Note that the page number has changed from 1 to 11

repeat
  Note that the page number has changed from 11 to 111

Go to master page
  See that all the text in the footer gets another copy added every time you
save/load

This might be related to bug 89311

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92825] Update help for all menu changes

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92825
Bug 92825 depends on bug 101163, which changed state.

Bug 101163 Summary: HELP: the sub-submenu change case has been removed
https://bugs.documentfoundation.org/show_bug.cgi?id=101163

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101524] Seeking during media playback shouldnt pause playback

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101524

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   Keywords||needsDevEval, topicUI
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101524] Seeking during media playback shouldnt pause playback

2016-08-14 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101524

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   Keywords||needsDevEval, topicUI
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   >