[Libreoffice-commits] core.git: sw/uiconfig

[Yousuf Philips]

 sw/uiconfig/swriter/ui/notebookbar_groups.ui | 1436 ++-
 1 file changed, 1434 insertions(+), 2 deletions(-)

New commits:
commit f97bc791b0879af3fd1bc2d1f7753ce5ffa6ac5e
Author: Yousuf Philips 
Date:   Wed Aug 17 21:12:37 2016 +0400

Notebookbar: First round of changes to group implementation

Change-Id: I8d40a44e7f76580c82e3109535300e50d1eb5a0b
Reviewed-on: https://gerrit.libreoffice.org/28199
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 

diff --git a/sw/uiconfig/swriter/ui/notebookbar_groups.ui 
b/sw/uiconfig/swriter/ui/notebookbar_groups.ui
index 0154978..40d3cdc 100644
--- a/sw/uiconfig/swriter/ui/notebookbar_groups.ui
+++ b/sw/uiconfig/swriter/ui/notebookbar_groups.ui
@@ -4,6 +4,238 @@
   
   
   
+  
+True
+False
+cmd/sc_bold.png
+  
+  
+True
+False
+cmd/lc_defaultbullet.png
+  
+  
+True
+False
+cmd/sc_centerpara.png
+  
+  
+True
+False
+cmd/sc_insertobjectchart.png
+  
+  
+True
+False
+cmd/lc_copy.png
+24
+  
+  
+True
+False
+cmd/sc_grow.png
+  
+  
+True
+False
+cmd/sc_italic.png
+  
+  
+True
+False
+cmd/sc_leftpara.png
+  
+  
+True
+False
+cmd/sc_inserthyperlink.png
+  
+  
+True
+False
+
+  
+True
+False
+.uno:HyperlinkDialog
+Hyperlink
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:InsertFootnote
+Footnote
+True
+  
+
+
+  
+True
+False
+.uno:InsertEndnote
+Endnote
+True
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+.uno:InsertBookmark
+Bookmark
+True
+  
+
+
+  
+True
+False
+.uno:InsertReferenceField
+Cross-Reference
+  
+
+  
+  
+True
+False
+cmd/lc_adddirect.png
+24
+  
+  
+True
+False
+cmd/lc_defaultnumbering.png
+  
+  
+True
+False
+cmd/lc_open.png
+24
+  
+  
+True
+False
+cmd/lc_designerdialog.png
+  
+  
+True
+False
+cmd/lc_paste.png
+24
+  
+  
+True
+False
+cmd/lc_exportdirecttopdf.png
+24
+  
+  
+True
+False
+cmd/lc_print.png
+24
+  
+  
+True
+False
+cmd/lc_redo.png
+24
+  
+  
+True
+False
+cmd/sc_rightpara.png
+  
+  
+True
+False
+cmd/32/save.png
+32
+3
+  
+  
+True
+False
+cmd/sc_shrink.png
+  
+  
+True
+False
+
+  
+True
+False
+Default Paragraph
+True
+  
+
+
+  
+True
+False
+Title
+True
+  
+
+
+  
+True
+False
+Subtitle
+True
+  
+
+
+  
+True
+False
+  
+
+
+  
+True
+False
+Default Character
+True
+  
+
+
+  
+True
+False
+Emphasis
+True
+  
+
+
+  
+True
+False
+Stron Emphasis
+True
+  
+
+  
+  
+True
+False
+cmd/lc_undo.png
+24
+  
   
 True
 False
@@ -22,6 +254,9 @@
   
 True
 False
+3
+3
+3
 6
 
   
@@ -75,10 +310,1207 @@
   
 
 
-  
+  
+True
+False
+3
+3
+6
+
+  
+True
+False
+3
+3
+True
+vertical
+5
+
+  
+78
+True
+False
+6
+
+  
+True
+False
+vertical
+3
+
+  
+New
+True
+True
+True
+Create a new document
+center
+True
+.uno:AddDirect
+newi
+none
+0
+True
+  
+  

[Libreoffice-commits] core.git: officecfg/registry

[Laurent Balland-Poirier]

 officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d80ad9847e93be3cd20de6b233379ad328c8550c
Author: Laurent Balland-Poirier 
Date:   Thu Aug 18 20:46:21 2016 +0200

Correct menu Insert>Trend line

Only 1 trend line can be inserted. It is no more possible
to insert trend lines for all series at a time.
See comments in b0fbaa6fa28df570e8179f166fe0547892b2dbc7

Change-Id: I3a8548af3d3cd641b4da342ee03681647844fde3
Reviewed-on: https://gerrit.libreoffice.org/28226
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu
index 3f9b85e..2db6b4c 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/ChartCommands.xcu
@@ -37,7 +37,7 @@
   
   
 
-  Tre~nd Lines...
+  Tre~nd Line...
 
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101567] error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101567

--- Comment #6 from Urmas  ---
1. Try to remove 'lu85901r.tmp_' folder;
2. Rename your file within Windows to *.docx and it should be able to be opened
with LO or Wordpad.

(Tip: use the ruler to make indented paragraphs, not tabulation)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75734] Spell checking doesn' t warn users if the selected dictionary isn't installed, but rather returns a potentially incorrect result

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75734

--- Comment #9 from Urmas  ---
That's a bad idea, as in a multilingual text it will break the spellcheck flow,
showing a warning for each piece of unsupported language text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

[Bartosz Kosiorek]

 sc/qa/unit/data/xlsx/xf_default_values.xlsx |binary
 sc/qa/unit/subsequent_export-test.cxx   |   26 +-
 sc/source/filter/oox/stylesbuffer.cxx   |   17 -
 3 files changed, 41 insertions(+), 2 deletions(-)

New commits:
commit 9b9bcef5ef1858c63c8708bfae2ecea3d398eeb8
Author: Bartosz Kosiorek 
Date:   Fri Aug 12 10:51:11 2016 +0200

tdf#70565 Set correct default values to "0" of xfId attribute

When xfId is not exist during .xlsx import
it must have values set to "0".
It is not impacts spreadsheets created with MS Excel,
as xfId attribute is always created during export to .xlsx
Not setting "0" value is causing wrong .xlsx import by LibreOffice,
for spreadsheets created by external applications (ex. SAP BI).

Change-Id: Ia4986236d5e902d0ff6f7a7a8da8f142b2c5061f
Reviewed-on: https://gerrit.libreoffice.org/28069
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/data/xlsx/xf_default_values.xlsx 
b/sc/qa/unit/data/xlsx/xf_default_values.xlsx
new file mode 100644
index 000..79aaea7
Binary files /dev/null and b/sc/qa/unit/data/xlsx/xf_default_values.xlsx differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index 8cbb1fa..848fbb8 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -107,6 +107,7 @@ public:
 void testFormatExportODS();
 
 void testCustomColumnWidthExportXLSX();
+void testXfDefaultValuesXLSX();
 void testOutlineExportXLSX();
 void testHiddenEmptyRowsXLSX();
 void testLandscapeOrientationXLSX();
@@ -193,6 +194,7 @@ public:
 CPPUNIT_TEST(testFormatExportODS);
 
 CPPUNIT_TEST(testCustomColumnWidthExportXLSX);
+CPPUNIT_TEST(testXfDefaultValuesXLSX);
 CPPUNIT_TEST(testOutlineExportXLSX);
 CPPUNIT_TEST(testHiddenEmptyRowsXLSX);
 CPPUNIT_TEST(testLandscapeOrientationXLSX);
@@ -471,7 +473,6 @@ void ScExportTest::testFormatExportODS()
 xDocSh->DoClose();
 }
 
-
 void ScExportTest::testCustomColumnWidthExportXLSX()
 {
 //tdf#100946 FILESAVE Excel on OS X ignored column widths in XLSX last 
saved by LO
@@ -564,6 +565,29 @@ void ScExportTest::testCustomColumnWidthExportXLSX()
 assertXPath(pSheet, "/x:worksheet/x:sheetData/x:row[1]", "customHeight", 
"false");
 }
 
+void ScExportTest::testXfDefaultValuesXLSX()
+{
+//tdf#70565 FORMATTING: User Defined Custom Formatting is not applied 
during importing XLSX documents
+ScDocShellRef xShell = loadDoc("xf_default_values.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xShell.Is());
+
+std::shared_ptr pXPathFile = 
ScBootstrapFixture::exportTo(&(*xShell), FORMAT_XLSX);
+xmlDocPtr pSheet = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/styles.xml");
+CPPUNIT_ASSERT(pSheet);
+
+// cellStyleXfs don't need xfId, so we need to make sure it is not saved
+assertXPathNoAttribute(pSheet, "/x:styleSheet/x:cellStyleXfs/x:xf[1]", 
"xfId");
+
+// Because numFmtId fontId fillId borderId xfId are not existing during 
import
+// it should be created during export, with values set to "0"
+assertXPath(pSheet, "/x:styleSheet/x:cellXfs/x:xf[1]", "xfId", "0");
+assertXPath(pSheet, "/x:styleSheet/x:cellXfs/x:xf[2]", "xfId", "0");
+assertXPath(pSheet, "/x:styleSheet/x:cellXfs/x:xf[3]", "xfId", "0");
+assertXPath(pSheet, "/x:styleSheet/x:cellXfs/x:xf[4]", "xfId", "0");
+
+// We expected that exactly 15 cellXfs:xf Nodes will be produced
+assertXPath(pSheet, "/x:styleSheet/x:cellXfs/x:xf", 14);
+}
 
 void ScExportTest::testOutlineExportXLSX()
 {
diff --git a/sc/source/filter/oox/stylesbuffer.cxx 
b/sc/source/filter/oox/stylesbuffer.cxx
index 456e2a5..f6c765f 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -1982,12 +1982,27 @@ Xf::Xf( const WorkbookHelper& rHelper ) :
 void Xf::importXf( const AttributeList& rAttribs, bool bCellXf )
 {
 maModel.mbCellXf = bCellXf;
-maModel.mnStyleXfId = rAttribs.getInteger( XML_xfId, -1 );
+// tdf#70565 Set proper default value to "0" of xfId attribute
+// When xfId is not exist during .xlsx import
+// it must have values set to "0".
+// Is is not impacts spreadsheets created with MS Excel,
+// as xfId attribute is always created during export to .xlsx
+// Not setting "0" value is causing wrong .xlsx import by LibreOffice,
+// for spreadsheets created by external applications (ex. SAP BI).
+if ( maModel.mbCellXf )
+{
+maModel.mnStyleXfId = rAttribs.getInteger( XML_xfId, 0 );
+}
+else
+{
+maModel.mnStyleXfId = rAttribs.getInteger( XML_xfId, -1 );
+}
 maModel.mnFontId = rAttribs.getInteger( XML_fontId, -1 );
 maModel.mnNumFmtId = rAttribs.getInteger( XML_numFmtId, -1 );
 maModel.mnBorderId = rAttribs.getInteger( 

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

--- Comment #4 from David Lochrin  ---
Alex, the status of this bug was changed to NEEDINFO on 5th August 2015 by Joel
Madero, then to NEW on 20th August by raal .

On 22nd March I received this notification:

---
https://bugs.documentfoundation.org/show_bug.cgi?id=93127

--- Comment #10 from Commit Notification
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e655ecfe007238080941077c6dc6187005e91fa=libreoffice-5-1

Resolves: tdf#93127 copying cells does not modify named expressions

It will be available in 5.1.3.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
---

I lodged sample a spreadsheet in response to Joel Madero's email, and the bug
was solidly reproducible with LibreOffice 4.3.5.2.  I've since tested the fix
on 5.1.4.2 and it seems OK.

I notice the bug number on the above notification (93127) is different to that
now shown on Bugzilla (91744).  As mentioned above, I did describe it on the
OpenOffice Forum before lodging the bug report here, so is it possible that's
where the confusion lies?

Please email me if this doesn't resolve things.

Regards,
David Lochrin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2-1' - xmloff/source

[Eike Rathke]

 xmloff/source/style/xmlnumfi.cxx |   16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

New commits:
commit 96a8c73a44ff26e60b90fe59461af880a0c7c025
Author: Eike Rathke 
Date:   Wed Aug 10 18:33:41 2016 +0200

XML number format: do not enquote space followed by minus, tdf#97837 
follow-up

Which with
[$kr.-406] #.##0,00;[RED][$kr.-406] -#.##0,00
saved and reloaded gave
[$kr.-406] #.##0,00;[RED][$kr.-406]" -"#.##0,00
and thus an almost identical duplicated format with the built-in format.

Change-Id: Ie39b97576842bc29ac301d2fe64f7331f6c57fc4
(cherry picked from commit 4d993ae8f267e35f7c030861a92226c940bb46cc)
Reviewed-on: https://gerrit.libreoffice.org/28041
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 
Reviewed-by: Björn Michaelsen 

diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index 9ea4e74..3120bea 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -792,14 +792,16 @@ static void lcl_EnquoteIfNecessary( OUStringBuffer& 
rContent, const SvXMLNumForm
 bool bQuote = true;
 sal_Int32 nLength = rContent.getLength();
 
-if ( ( nLength == 1 &&
-lcl_ValidChar( rContent[0], rParent ) ) ||
- ( nLength == 2 &&
- lcl_ValidChar( rContent[0], rParent ) &&
- rContent[1] == ' ' ) )
+if ((nLength == 1 && lcl_ValidChar( rContent[0], rParent)) ||
+(nLength == 2 &&
+ ((rContent[0] == ' ' && rContent[1] == '-') ||
+  (rContent[1] == ' ' && lcl_ValidChar( rContent[0], rParent)
 {
-//  don't quote single separator characters like space or percent,
-//  or separator characters followed by space (used in date formats)
+//  Don't quote single separator characters like space or percent,
+//  or separator characters followed by space (used in date formats).
+//  Or space followed by minus (used in currency formats) that would
+//  lead to almost duplicated formats with built-in formats just with
+//  the difference of quotes.
 bQuote = false;
 }
 else if ( rParent.GetType() == XML_TOK_STYLES_PERCENTAGE_STYLE && nLength 
> 1 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97229] Tables are split after saving as .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97229

Aron Budea  changed:

   What|Removed |Added

   Keywords||filter:doc
 CC||ba...@caesar.elte.hu
 Whiteboard||interoperability

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99446] Garbled text characters / glyphs in some dialogs in Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99446

Aron Budea  changed:

   What|Removed |Added

 CC||rogerda...@verizon.net

--- Comment #26 from Aron Budea  ---
*** Bug 101600 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101600] Dialog "This file contains links..." is in unreadable font until selected for copy, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101600

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Aron Budea  ---
This issue is fixed in 5.1.5 and 5.2.0, please upgrade.

*** This bug has been marked as a duplicate of bug 99446 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101584] Crash in: _imp_load__CryptVerifySignatureW

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101584

m.a.riosv  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from m.a.riosv  ---
Looks crash report was reported.

Please try disabling OpenGL or Hardware acceleration:
Menu/Tools/LibreOffice/View

Back to unconfirmed, maybe someone is able to reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - external/libodfgen

[David Tardon]

 
external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 |   58 ++
 external/libodfgen/UnpackedTarball_libodfgen.mk
  |3 
 2 files changed, 61 insertions(+)

New commits:
commit fc79186d80ffa8e734727c555456165af6dd51c4
Author: David Tardon 
Date:   Fri Aug 12 13:11:38 2016 +0200

tdf#101077 make double->str conv. locale-agnostic

Change-Id: Ibb87f4a14fda6957149ca52083387760ff6e60a3
(cherry picked from commit 8d26a169794083f047a57e5c8d3f5da0aaab2583)
Reviewed-on: https://gerrit.libreoffice.org/28081
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git 
a/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 
b/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
new file mode 100644
index 000..1fc4e6b
--- /dev/null
+++ 
b/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
@@ -0,0 +1,58 @@
+From 68e0c8e4c834df57bc9a0e8da72151f69ff5e7a6 Mon Sep 17 00:00:00 2001
+From: David Tardon 
+Date: Fri, 12 Aug 2016 12:50:39 +0200
+Subject: [PATCH] tdf#101077 make double->string conversion locale-agnostic
+
+---
+ src/OdsGenerator.cxx | 19 +--
+ 1 file changed, 17 insertions(+), 2 deletions(-)
+
+diff --git a/src/OdsGenerator.cxx b/src/OdsGenerator.cxx
+index 52e135e..8cb7203 100644
+--- a/src/OdsGenerator.cxx
 b/src/OdsGenerator.cxx
+@@ -26,6 +26,8 @@
+ 
+ #include 
+ 
++#include 
++#include 
+ #include 
+ #include 
+ #include 
+@@ -46,6 +48,19 @@
+ #include "OdcGenerator.hxx"
+ #include "OdfGenerator.hxx"
+ 
++namespace
++{
++
++librevenge::RVNGString makePreciseStr(const double value)
++{
++  std::ostringstream os;
++  os.imbue(std::locale::classic());
++  os << std::fixed << std::setprecision(8) << value;
++  return os.str().c_str();
++}
++
++}
++
+ class OdsGeneratorPrivate : public OdfGenerator
+ {
+ public:
+@@ -968,10 +983,10 @@ void OdsGenerator::openSheetCell(const 
librevenge::RVNGPropertyList )
+   // we need the maximum precision here, 
so we must avoid getStr() when possible
+   librevenge::RVNGString value;
+   if 
(propList["librevenge:value"]->getUnit()==librevenge::RVNG_GENERIC)
+-  value.sprintf("%.8f", 
propList["librevenge:value"]->getDouble());
++  value = 
makePreciseStr(propList["librevenge:value"]->getDouble());
+   else if 
(propList["librevenge:value"]->getUnit()==librevenge::RVNG_PERCENT)
+   {
+-  value.sprintf("%.8f", 
propList["librevenge:value"]->getDouble()*100.);
++  value = 
makePreciseStr(propList["librevenge:value"]->getDouble()*100.);
+   value.append('%');
+   }
+   else
+-- 
+2.7.4
+
diff --git a/external/libodfgen/UnpackedTarball_libodfgen.mk 
b/external/libodfgen/UnpackedTarball_libodfgen.mk
index 3cbeb55..f6695d9 100644
--- a/external/libodfgen/UnpackedTarball_libodfgen.mk
+++ b/external/libodfgen/UnpackedTarball_libodfgen.mk
@@ -35,5 +35,8 @@ $(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
 endif
 endif
 
+$(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
+   
external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 \
+))
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: compiler (in)-compatibilities

[Luc Castermans]

actually case 1 is wrong code. Compiler is correct and code should be
corrected.

regards,

Luc

Op 17 aug. 2016 19:18 schreef "Lionel Elie Mamane" :

> Hi,
>
> Short version: do we have a way to include compiler flags only with
> some compiler version?
>
> Long version: So, firebird currently is incompatible with GCC 6. AFAIK
> there are two breaker issues:
>
> 1) compiled code aborts in free() because it free()s an address that
>was not malloc()ed
>
> 2) code that does not compile
>
>
> Issue 1 is fixed by adding
>  -fno-sized-deallocation -fno-delete-null-pointer-checks
> to CXXFLAGS.
>
> Issue 2 is fixed by backporting an upstream commit from their master
> branch.
>
> Number 2 I can do, no problem. But number 1 I feel I shouldn't do
> unconditionally, because another compiler than GCC 6 probably will not
> know these flags? Any advice there?
>
> --
> Lionel
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: download.lst

[Thorsten Behrens]

 download.lst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit af3c42704398109fd23b9289ed951e7f2d00a3f0
Author: Thorsten Behrens 
Date:   Fri Aug 19 00:50:29 2016 +0200

Update odfvalidator jar - now built with java 1.6 target

Package was inconsistent in target version, broke some tinderboxes

Change-Id: I7933df8a87288a5199a3169c4243d4ae4bb31151

diff --git a/download.lst b/download.lst
index 7977230..709671f 100644
--- a/download.lst
+++ b/download.lst
@@ -118,7 +118,7 @@ export NSS_TARBALL := 
6b254cf2f8cb4b27a3f0b8b7b9966ea7-nss-3.22.2-with-nspr-4.12
 export ODFGEN_MD5SUM := 32572ea48d9021bbd6fa317ddb697abc
 export ODFGEN_VERSION_MICRO := 6
 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.bz2
-export ODFVALIDATOR_JAR := 
e7f181c1d969dbd553644b191cb0a6d3-odfvalidator-1.1.8-incubating-SNAPSHOT-jar-with-dependencies.jar
+export ODFVALIDATOR_JAR := 
a084cd548b586552cb7d3ee51f1af969-odfvalidator-1.1.8-incubating-SNAPSHOT-jar-with-dependencies.jar
 export OFFICEOTRON_JAR := 
8249374c274932a21846fa7629c2aa9b-officeotron-0.7.4-master.jar
 export OPENCOLLADA_MD5SUM := 4ca8a6ef0afeefc864e9ef21b9f14bd6
 export OPENCOLLADA_TARBALL := OpenCOLLADA-master-6509aa13af.tar.bz2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100300] Crash upon start (LibreOffice recovers, but there's an (empty ) Document Recovery dialog ..)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100300

Aron Budea  changed:

   What|Removed |Added

  Component|framework   |LibreOffice

--- Comment #17 from Aron Budea  ---
Sure. Can't remember why I used framework there, must've been a mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101600] Dialog "This file contains links..." is in unreadable font until selected for copy, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101600

--- Comment #1 from Roger Davis  ---
Created attachment 126898
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126898=edit
Dialog box with bad font

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101600] New: Dialog "This file contains links..." is in unreadable font until selected for copy, etc.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101600

Bug ID: 101600
   Summary: Dialog "This file contains links..."  is in unreadable
font until selected for copy, etc.
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rogerda...@verizon.net

User-Agent:   Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101
Firefox/43.0 SeaMonkey/2.40
Build Identifier: LibreOffice 5.1.4.2

This dialog is unreadable until the text is selected as though to copy it.

Reproducible: Always

Steps to Reproduce:
1. Open file with links
2. Observe problem
3.
Actual Results:  
You can see the problem

Expected Results:  
Provided readable text

[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


Reset User Profile?No - can't identify user profile folder

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: offapi/com

[Eike Rathke]

 offapi/com/sun/star/sheet/MemberResult.idl |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit faf8cca6dcf3fc03739f1e14af4d2b959c82c28e
Author: Eike Rathke 
Date:   Thu Aug 18 23:38:14 2016 +0200

Value member @since LibreOffice 5.3

Change-Id: If7aa51768446eb41ce9f3a7d4493a021f380fa34

diff --git a/offapi/com/sun/star/sheet/MemberResult.idl 
b/offapi/com/sun/star/sheet/MemberResult.idl
index 7de14f3..be17a86 100644
--- a/offapi/com/sun/star/sheet/MemberResult.idl
+++ b/offapi/com/sun/star/sheet/MemberResult.idl
@@ -52,6 +52,8 @@ struct MemberResult
 com::sun::star::sheet::MemberResultFlags::NUMERIC set.
 
 May be NaN if value is not available or unknown.
+
+@since LibreOffice 5.3
  */
 double Value;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/uiconfig

[Susobhan Ghosh]

 sw/uiconfig/swriter/ui/pagestylespanel.ui |4 
 1 file changed, 4 insertions(+)

New commits:
commit 3ac60abd6f487a32fa605c1761f5f7752f1125cb
Author: Susobhan Ghosh 
Date:   Thu Aug 18 21:51:41 2016 +0530

tdf#83830: Limit width of color/gradient listbox to 150px

Change-Id: I997605edb0ec85f5e68a0b2968533cea278710eb
Reviewed-on: https://gerrit.libreoffice.org/28224
Tested-by: Jenkins 
Reviewed-by: Yousuf Philips 

diff --git a/sw/uiconfig/swriter/ui/pagestylespanel.ui 
b/sw/uiconfig/swriter/ui/pagestylespanel.ui
index 1b8ebf3..4246cde 100644
--- a/sw/uiconfig/swriter/ui/pagestylespanel.ui
+++ b/sw/uiconfig/swriter/ui/pagestylespanel.ui
@@ -146,6 +146,7 @@
 
 
   
+150
 True
 False
   
@@ -158,6 +159,7 @@
 
 
   
+150
 True
 False
   
@@ -170,6 +172,7 @@
 
 
   
+150
 True
 False
   
@@ -182,6 +185,7 @@
 
 
   
+150
 True
 False
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 89447] Android: Use SVG icon for SVG files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89447

--- Comment #2 from Robinson Tryon (qubit)  ---
TESTING with 5.3.0.0.alpha0+ (Build ID: f2da317)

(In reply to Robinson Tryon (qubit) from comment #0)
> When browsing files in a directory, SVG files are represented with a
> presentation icon (the same as ODP files). These files should have a
> separate icon that represents vector graphics/SVG specifically. The use of
> the presentation icon is confusing.

Test image: 
https://openclipart.org/detail/258803/draw-piggie

The problem persists in 5.3.x builds

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - svl/qa vcl/source

[Tor Lillqvist]

 svl/qa/unit/svl.cxx |2 +-
 vcl/source/control/combobox.cxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9f8d23d3b71efbfb72b355229dfefce1fb177612
Author: Tor Lillqvist 
Date:   Thu Aug 18 23:25:31 2016 +0300

loplugin:stringconstant

Change-Id: I6dd872afb8d96da2ceb09ee553795ae98d5c0d09

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 6eca0eb..d23620d 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -1189,7 +1189,7 @@ void Test::testUserDefinedNumberFormats()
 OUString(sal_Unicode(20336)) +  // ä½°
 OUString(sal_Unicode(36019)) +  // è²³
 OUString(sal_Unicode(25342)) +  // 拾
-OUString(sal_Unicode(' '));
+" ";
 checkPreviewString(aFormatter, sCode, 120, eLang, sExpected);
 sCode = "[DBNum2][$-0404]General\\ ";
 checkPreviewString(aFormatter, sCode, 120, eLang, sExpected);
commit c76215cf99125eb21e259383fdff15d6c621d683
Author: Tor Lillqvist 
Date:   Thu Aug 18 23:14:00 2016 +0300

loplugin:defaultparams

Change-Id: I738fa9270337b17c9373186cdcbc2e7f8cbc32d4

diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index d5e4708..ddc49a9 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -355,10 +355,10 @@ IMPL_LINK_TYPED(ComboBox::Impl, ImplAutocompleteHdl, 
Edit&, rEdit, void)
 if (!m_isMatchCase)
 {
 // Try match case insensitive from current position
-nPos = m_pImplLB->GetEntryList()->FindMatchingEntry(aStartText, 
nStart, true);
+nPos = m_pImplLB->GetEntryList()->FindMatchingEntry(aStartText, 
nStart);
 if ( nPos == LISTBOX_ENTRY_NOTFOUND )
 // Try match case insensitive, but from start
-nPos = 
m_pImplLB->GetEntryList()->FindMatchingEntry(aStartText, 0, true);
+nPos = 
m_pImplLB->GetEntryList()->FindMatchingEntry(aStartText);
 }
 
 if ( nPos == LISTBOX_ENTRY_NOTFOUND )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100300] Crash upon start (LibreOffice recovers, but there's an (empty ) Document Recovery dialog ..)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100300

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Summary|Crash upon start|Crash upon start
   ||(LibreOffice recovers, but
   ||there's an (empty) Document
   ||Recovery dialog ..)

--- Comment #16 from Cor Nouws  ---
Hi Aron,

Can we set this to component LibreOffice?

Ciao  Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/osl

[Giuseppe Castagno]

 sal/osl/all/log.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0d5804cc8e26cbf315c85c3d1c5d62929f49b470
Author: Giuseppe Castagno 
Date:   Thu Aug 18 16:56:07 2016 +0200

Fix sal log for 32 bit Linux build

Change-Id: I2644079cafa46db8689463e1d0abc1cf3bdf49de
Reviewed-on: https://gerrit.libreoffice.org/28222
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index f9a6a4e..da167a7 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -131,7 +131,7 @@ void maybeOutputTimestamp(std::ostringstream ) {
 tm.tm_year = dateTime.Year - 1900;
 strftime(ts, sizeof(ts), "%Y-%m-%d:%H:%M:%S", );
 char milliSecs[10];
-sprintf(milliSecs, "%03d", dateTime.NanoSeconds/100);
+sprintf(milliSecs, "%03d", 
static_cast(dateTime.NanoSeconds/100));
 s << ts << '.' << milliSecs << ':';
 }
 if (outputRelativeTimer) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - framework/source

[anwilli5]

 framework/source/services/autorecovery.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit e3759a3154de534a5edfd69f7face5b5c29c1ea9
Author: anwilli5 
Date:   Sun Jun 5 23:06:05 2016 -0400

tdf#96607 'Save as' doesn't update global auto-recovery state

The auto-recovery service maintains a list of structures (one for each open
document) containing information needed to carry out the auto-save
functionality. One such piece of information is the location of the backup
file, stored in a struct member named 'OldTempURL'.  At every auto-save
interval, this list is iterated through and a function (implts_saveOneDoc)
is called during each iteration to save the current state of the associated
document.

The algorithm works as follows:
 1. A new backup file URL is chosen so as not to conflict with any already
existing backup files in the backup directory.  This URL is based on the
file name and incorporates a number (starting at 0) that is incremented
until a name is chosen that doesn't conflict.

 2. The document is saved to this new backup file URL

 3. The previous backup file (indicated by its structure's 'OldTempURL') is
deleted

 4. The new backup file URL is stored (in its structure's 'OldTempURL') for 
the
next time the file needs to be saved.

Assuming you start with a new Writer doc and then make some changes, when 
it is
time to auto-save, the backup file name 'untitled_0.odt' (excluding path) 
will
be selected, the latest state of the open file will be written to that 
backup
file, and the full URL for the backup file will be saved into the struct
'OldTempURL' member.

The next time changes are made and an auto-save occurs, this algorithm will
result in the name 'untitled_1.odt' being selected, the file contents saved
into this new file, 'untitled_0.odt' being deleted, and the full URL for the
new backup file being saved in 'OldTempURL'.

The third time through results in 'untitled_0.odt' being selected (since 
this
file doesn't exist on disk), and subsequent iterations of auto-saving cause
the backup file name to alternate between the two aforementioned.

The problem occurs during a 'Save as' operation. When this happens, the 
backup
file is deleted (which is fine - it was just saved, and the next auto-save 
will
back it up) but 'OldTempURL' is not properly reset (see below for more 
info.)
During the next auto-save, 'untitled_0.odt' will be selected for the new 
backup
file name (since no file exists by this name), and one of two things will
happen (based on how many auto-saves have occurred):

 1. 'OldTempURL' points to 'untitled_1.odt', and the algorithm above 
continues
to work correctly (at least in that it continues to backup file 
contents.)

 2. 'OldTempURL' points to 'untitled_0.odt', the name chosen for the new 
backup
file.  In this case, the document contents will be saved to this file
(step 2) but then the file will be deleted (step 3).  'OldTempURL' will
maintain this URL from then on out, causing this case to be hit for all
future auto-save intervals.

So, 50% of the time (30 minutes out of every hour) auto-save will stop 
backing
up file contents on a 'Save as'.

The function that handles the 'Save as' case (implts_markDocumentAsSaved)
clears 'OldTempURL' and sets other relavent struct members for a local 
variable
copy of the global struct, but doesn't copy them back. :(  These changes are
effectively lost when the function returns.

There are several other cases where this appears to be happening as well, 
but
more work is needed to determine whether this is actually the case:
 - implts_prepareSessionShutdown
 - implts_saveDocs, handling the 'dangerousDocs' and in a few other places
 - implts_openDocs
 - implts_resetHandleStates

Also, there is some JUnitTest code for auto-save, but it is currently 
disabled
(and fails to run successfully.) It'd be great to get these working again, 
or
to just write python equivalents. Implementing this would like take me a 
while,
though, so for now I just tested manually to ensure that this fixes the 
issue.

When I have some more time I'd like to work more on this, but I wanted to 
send
this patch in for now to address bug #96607.

This may also address bug #99890, since some of the struct members that 
don't
make it into the global state relate to the file name.  I haven't explicitly
tested this case, though.

Change-Id: Ic702d6f78e60c7cf828a1564ccca118dd45d152b
Reviewed-on: https://gerrit.libreoffice.org/25948
Tested-by: Jenkins 
Reviewed-by: jan iversen 
Reviewed-on: 

[Libreoffice-bugs] [Bug 86926] page format not readed in DOCX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86926

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #7 from Yousuf (Jay) Philips  ---
*** Bug 101568 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101568] FILEOPEN: Page size not imported in docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101568

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Yousuf (Jay) Philips  ---
Yep it looks the same.

*** This bug has been marked as a duplicate of bug 86926 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 27 commits - comphelper/source cui/source desktop/source editeng/source libreofficekit/source package/inc package/source sc/source sd/source sfx2/source svtools/qa svx/

[Caolán McNamara]

 comphelper/source/misc/asyncnotification.cxx   |4 -
 cui/source/inc/cuitabarea.hxx  |   11 
 cui/source/tabpages/tparea.cxx |   56 -
 desktop/source/app/officeipcthread.cxx |   30 +--
 editeng/source/outliner/outliner.cxx   |   30 +--
 libreofficekit/source/gtk/lokdocview.cxx   |2 
 package/inc/ZipOutputStream.hxx|2 
 package/source/zipapi/ZipOutputStream.cxx  |2 
 sc/source/core/data/table3.cxx |4 -
 sc/source/filter/excel/expop2.cxx  |4 -
 sc/source/filter/oox/pagesettings.cxx  |4 -
 sc/source/filter/xml/XMLTableShapeImportHelper.cxx |   10 +--
 sc/source/filter/xml/xmlcelli.cxx  |   10 +--
 sd/source/ui/sidebar/SlideBackground.cxx   |1 
 sfx2/source/notebookbar/PriorityHBox.cxx   |   10 +--
 svtools/qa/unit/GraphicObjectTest.cxx  |4 -
 svx/source/fmcomp/gridctrl.cxx |9 ---
 svx/source/sidebar/paragraph/ParaSpacingWindow.cxx |2 
 sw/source/core/unocore/unostyle.cxx|   11 +---
 sw/source/filter/ww8/ww8par.cxx|9 +--
 sw/source/filter/ww8/ww8par6.cxx   |4 -
 sw/source/uibase/dochdl/swdtflvr.cxx   |5 +
 sw/source/uibase/lingu/olmenu.cxx  |1 
 vcl/source/control/combobox.cxx|   14 +
 vcl/unx/generic/printer/ppdparser.cxx  |1 
 vcl/workben/fftester.cxx   |2 
 xmloff/source/draw/shapeimport.cxx |3 +
 xmloff/source/style/MarkerStyle.cxx|   13 ++--
 xmloff/source/transform/StyleOOoTContext.cxx   |3 -
 29 files changed, 114 insertions(+), 147 deletions(-)

New commits:
commit b69503ea67cea885fde8a36f41af37a56455fe19
Author: Caolán McNamara 
Date:   Thu Aug 18 20:41:04 2016 +0100

WaE: -Werror=logical-op, I guess this is what was intended

Change-Id: I8646045372fc66cf459a7bd1d977ced6502ef751

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index a65e0c5..355978a 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -3252,7 +3252,7 @@ bool ScTable::HasColHeader( SCCOL nStartCol, SCROW 
nStartRow, SCCOL nEndCol, SCR
 CellType eFstCellType = GetCellType(nStartCol, nStartRow);
 CellType eSndCellType = GetCellType(nStartCol, nStartRow+1);
 return ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT) &&
-(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING));
+(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_EDIT));
 }
 
 for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
@@ -3289,7 +3289,7 @@ bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW 
nStartRow, SCCOL nEndCol, SCR
 CellType eFstCellType = GetCellType(nStartCol, nStartRow);
 CellType eSndCellType = GetCellType(nStartCol+1, nStartRow);
 return ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT) &&
-(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING));
+(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_EDIT));
 }
 
 for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
commit 88c9133b16749e33872e358aedd81ebc81593e3a
Author: Caolán McNamara 
Date:   Thu Aug 18 19:47:38 2016 +0100

coverity#1371121 Unchecked return value

Change-Id: I1413b62112922af8d6872de413ca7decc0d75875

diff --git a/svtools/qa/unit/GraphicObjectTest.cxx 
b/svtools/qa/unit/GraphicObjectTest.cxx
index f17aeca..88041df 100644
--- a/svtools/qa/unit/GraphicObjectTest.cxx
+++ b/svtools/qa/unit/GraphicObjectTest.cxx
@@ -334,8 +334,8 @@ void GraphicObjectTest::testPdf()
 CPPUNIT_ASSERT_MESSAGE("Missing image", pGraphicObject);
 
 CPPUNIT_ASSERT(pGraphicObject->GetGraphic().getPdfData().hasElements());
-pGraphicObject->SwapOut();
-pGraphicObject->SwapIn();
+CPPUNIT_ASSERT(pGraphicObject->SwapOut());
+CPPUNIT_ASSERT(pGraphicObject->SwapIn());
 // This failed, swap out + swap in lost the PDF data.
 CPPUNIT_ASSERT(pGraphicObject->GetGraphic().getPdfData().hasElements());
 
commit 0afe3e257e9d7b76e252b1022d7d0e4e0c940384
Author: Caolán McNamara 
Date:   Thu Aug 18 19:46:06 2016 +0100

coverity#1371123 Unchecked return value

Change-Id: I892b4b0531d456f73777d81cb47847cde2ed7364

diff --git a/vcl/workben/fftester.cxx b/vcl/workben/fftester.cxx
index c239638..c5542e9 100644
--- a/vcl/workben/fftester.cxx
+++ b/vcl/workben/fftester.cxx
@@ -107,7 +107,7 @@ try_again:
 SvFileStream aFileStream(out, StreamMode::READ);
 ret = (int) ReadWindowMetafile(aFileStream, aGDIMetaFile);
  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - external/libodfgen

[David Tardon]

 
external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 |   58 ++
 external/libodfgen/UnpackedTarball_libodfgen.mk
  |3 
 2 files changed, 61 insertions(+)

New commits:
commit f28ca7a3c0e846b1e516b31a981e814e3768a7d9
Author: David Tardon 
Date:   Fri Aug 12 13:11:38 2016 +0200

tdf#101077 make double->str conv. locale-agnostic

Change-Id: Ibb87f4a14fda6957149ca52083387760ff6e60a3
(cherry picked from commit 8d26a169794083f047a57e5c8d3f5da0aaab2583)
Reviewed-on: https://gerrit.libreoffice.org/28080
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git 
a/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 
b/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
new file mode 100644
index 000..1fc4e6b
--- /dev/null
+++ 
b/external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
@@ -0,0 +1,58 @@
+From 68e0c8e4c834df57bc9a0e8da72151f69ff5e7a6 Mon Sep 17 00:00:00 2001
+From: David Tardon 
+Date: Fri, 12 Aug 2016 12:50:39 +0200
+Subject: [PATCH] tdf#101077 make double->string conversion locale-agnostic
+
+---
+ src/OdsGenerator.cxx | 19 +--
+ 1 file changed, 17 insertions(+), 2 deletions(-)
+
+diff --git a/src/OdsGenerator.cxx b/src/OdsGenerator.cxx
+index 52e135e..8cb7203 100644
+--- a/src/OdsGenerator.cxx
 b/src/OdsGenerator.cxx
+@@ -26,6 +26,8 @@
+ 
+ #include 
+ 
++#include 
++#include 
+ #include 
+ #include 
+ #include 
+@@ -46,6 +48,19 @@
+ #include "OdcGenerator.hxx"
+ #include "OdfGenerator.hxx"
+ 
++namespace
++{
++
++librevenge::RVNGString makePreciseStr(const double value)
++{
++  std::ostringstream os;
++  os.imbue(std::locale::classic());
++  os << std::fixed << std::setprecision(8) << value;
++  return os.str().c_str();
++}
++
++}
++
+ class OdsGeneratorPrivate : public OdfGenerator
+ {
+ public:
+@@ -968,10 +983,10 @@ void OdsGenerator::openSheetCell(const 
librevenge::RVNGPropertyList )
+   // we need the maximum precision here, 
so we must avoid getStr() when possible
+   librevenge::RVNGString value;
+   if 
(propList["librevenge:value"]->getUnit()==librevenge::RVNG_GENERIC)
+-  value.sprintf("%.8f", 
propList["librevenge:value"]->getDouble());
++  value = 
makePreciseStr(propList["librevenge:value"]->getDouble());
+   else if 
(propList["librevenge:value"]->getUnit()==librevenge::RVNG_PERCENT)
+   {
+-  value.sprintf("%.8f", 
propList["librevenge:value"]->getDouble()*100.);
++  value = 
makePreciseStr(propList["librevenge:value"]->getDouble()*100.);
+   value.append('%');
+   }
+   else
+-- 
+2.7.4
+
diff --git a/external/libodfgen/UnpackedTarball_libodfgen.mk 
b/external/libodfgen/UnpackedTarball_libodfgen.mk
index 3cbeb55..f6695d9 100644
--- a/external/libodfgen/UnpackedTarball_libodfgen.mk
+++ b/external/libodfgen/UnpackedTarball_libodfgen.mk
@@ -35,5 +35,8 @@ $(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
 endif
 endif
 
+$(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
+   
external/libodfgen/0001-tdf-101077-make-double-string-conversion-locale-agno.patch.1
 \
+))
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Tor Lillqvist]

 sc/source/core/data/table3.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e554d2b7f6d6c6abbc89ff293944be473b0e1de4
Author: Tor Lillqvist 
Date:   Thu Aug 18 22:48:10 2016 +0300

loplugin:loopvartoosmall

Change-Id: I1b7c1172b907a9bdc513324ccb91acc0d647fdb4

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 23b7b5f..a65e0c5 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -3302,7 +3302,7 @@ bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW 
nStartRow, SCCOL nEndCol, SCR
 
 // First column all text cells, any non-text cell in second column => 
headers.
 SCROW nTestCol = nStartCol + 1;
-for (SCCOL nRow=nStartRow; nRow<=nEndRow; nRow++)
+for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
 {
 CellType eType = GetCellType( nRow, nTestCol );
 if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Laurent Balland-Poirier]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a3e3ad9007749e58b49fa457f993b7c55d660c57
Author: Laurent Balland-Poirier 
Date:   Sat Jul 23 22:15:07 2016 +0200

Updated core
Project: help  ea4100df0c087e2439ae438cfa7a3d35efb6dd27

tdf#30456 Add help to Merge Cells dialog

Describe the three options that will be introduced with commit:
https://gerrit.libreoffice.org/27463/

Change-Id: Iefe1b887d28d1845755e5beeadfa6d829c8d4acf
Reviewed-on: https://gerrit.libreoffice.org/27467
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/helpcontent2 b/helpcontent2
index 641b438..ea4100d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 641b43850cb2903e640bfbdd5df413e80aff2b68
+Subproject commit ea4100df0c087e2439ae438cfa7a3d35efb6dd27
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: source/text

[Laurent Balland-Poirier]

 source/text/scalc/01/0506.xhp |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit ea4100df0c087e2439ae438cfa7a3d35efb6dd27
Author: Laurent Balland-Poirier 
Date:   Sat Jul 23 22:15:07 2016 +0200

tdf#30456 Add help to Merge Cells dialog

Describe the three options that will be introduced with commit:
https://gerrit.libreoffice.org/27463/

Change-Id: Iefe1b887d28d1845755e5beeadfa6d829c8d4acf
Reviewed-on: https://gerrit.libreoffice.org/27467
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/source/text/scalc/01/0506.xhp 
b/source/text/scalc/01/0506.xhp
index 7103af4..567626e 100644
--- a/source/text/scalc/01/0506.xhp
+++ b/source/text/scalc/01/0506.xhp
@@ -32,6 +32,7 @@
 
 
 
+
 Merge and Center Cells
 Combines the selected cells into a single cell or 
splits merged cells. Aligns cell content centered.
 
@@ -41,6 +42,18 @@
 
 The merged cell receives the name of the first cell of the original 
cell range. Merged cells cannot be merged a second time with other cells. The 
range must form a rectangle, multiple selection is not supported.
 If the cells to be merged have any contents, a security dialog is 
shown.
+Three options are 
available:
+
+  
+Move 
the contents of the hidden cells into the first cell: the actual 
contents of the hidden cells are concatenated to the first cell, and hidden 
cells are emptied; the results of formulas referring to the hidden cells or the 
first cell will be updated.
+  
+  
+Keep 
the contents of the hidden cells: the contents of the hidden cells are 
kept; the results of formulas referring to the hidden cells will not 
change.
+  
+  
+Empty 
the contents of the hidden cells: the contents of the hidden cells are 
removed; the results of formulas referring to the hidden cells will be 
updated.
+  
+
 Merging cells 
can lead to calculation errors in formulas in the table.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101599] New: [EDITING] Inserting certain Unicode combining characters causes text in paragraph to appear corrupted.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101599

Bug ID: 101599
   Summary: [EDITING] Inserting certain Unicode combining
characters causes text in paragraph to appear
corrupted.
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mvonpreus...@gmail.com

Created attachment 126897
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126897=edit
A visual representation of the bug, showing the corrupted display of text
caused by the use of a combining character.

Using certain Unicode combining characters in LibreOffice Writer causes text in
the same paragraph block as the combining character to appear corrupted, with
arbitrary characters replaced with arbitrary other characters. The text itself
does not change—if I copy and paste the text to another application, the text I
originally typed is preserved—it is merely the display and presentation of the
text which is corrupted.

To reproduce the bug:

1. Type some text in a LibreOffice Writer document.
- Sample text:
 Everything is fine, until I combine.
2. Type or paste a Unicode combining character into the text.
- The characters in the Unicode block U+0300–036F trigger the bug.
- Sample text:
 ⃝ͤ

I expect the combining character will be displayed properly, so long as the
font supports the character. While this does happen, arbitrary other text in
the same paragraph block appears corrupted.

Included is a screenshot to demonstrate the bug. The two lines contain the same
text, with one exception: the final 'e' on the second line has been replaced by
U+0364, COMBINING LATIN SMALL LETTER E. Despite this, the visual display of the
text on the second line is substantially different.

Of note:

- Printing the document or exporting it as a PDF renders the correct text.
- Exporting as a JPEG or PNG image renders the corrupted text.
- The bug exists with multiple fonts, although which characters appear
corrupted for a given block of text varies with each.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101598] New: Not possible to add a background music on Impress presentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101598

Bug ID: 101598
   Summary: Not possible to add a background music on Impress
presentation
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: chr.hovin...@gmail.com

User-Agent:   Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0)
Gecko/20100101 Firefox/48.0
Build Identifier: Version: 5.1.4.2 Build ID: 1:5.1.4-0ubuntu1 Threads CPU : 4;
Version de l'OS :Linux 4.4; UI Render : par défaut;  Locale : fr-BE
(fr_FR.UTF-8)

When presentation is done, I select the first page, go to "transition" and try
to change "no sound" by searching a sound file (I tried wav and mp3)but after
selecting it, the field remain "no sound" in place of the name of the sound
file. 
So I cannot add a sound to my presentation.
I had already this problem with earlier versions of Libreoffice and older
version of Ubuntu. (14.04 and now 16.04)

Reproducible: Always







Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - configure.ac distro-configs/LibreOfficeAndroidAarch64.conf distro-configs/LibreOfficeAndroid.conf distro-configs/LibreOfficeAndroidX86.conf

[Tor Lillqvist]

 configure.ac  |1 +
 distro-configs/LibreOfficeAndroid.conf|3 ++-
 distro-configs/LibreOfficeAndroidAarch64.conf |3 ++-
 distro-configs/LibreOfficeAndroidX86.conf |3 ++-
 4 files changed, 7 insertions(+), 3 deletions(-)

New commits:
commit bc0abca9a743e156b8117aeccd0648247c9c308c
Author: Tor Lillqvist 
Date:   Thu Aug 18 22:35:50 2016 +0300

No export validation for the host platform when cross-compiling please

Sure, would make more sense to hardcode this in configure.ac. But
actually I guess that export validation will be turned off by default
anyway soon.

Change-Id: Icf266a0f389b9ebc8a28ee2e5f277449875ca885

diff --git a/distro-configs/LibreOfficeAndroid.conf 
b/distro-configs/LibreOfficeAndroid.conf
index 74d79b7..6259daa 100644
--- a/distro-configs/LibreOfficeAndroid.conf
+++ b/distro-configs/LibreOfficeAndroid.conf
@@ -5,5 +5,6 @@
 --disable-gstreamer-1-0
 --disable-randr
 --disable-systray
---without-junit
+--without-export-validation
 --without-helppack-integration
+--without-junit
diff --git a/distro-configs/LibreOfficeAndroidAarch64.conf 
b/distro-configs/LibreOfficeAndroidAarch64.conf
index e77d67f..4f3d2f4 100644
--- a/distro-configs/LibreOfficeAndroidAarch64.conf
+++ b/distro-configs/LibreOfficeAndroidAarch64.conf
@@ -5,5 +5,6 @@
 --disable-gstreamer-1-0
 --disable-randr
 --disable-systray
---without-junit
+--without-export-validation
 --without-helppack-integration
+--without-junit
diff --git a/distro-configs/LibreOfficeAndroidX86.conf 
b/distro-configs/LibreOfficeAndroidX86.conf
index 4f487d5..62cf17d 100644
--- a/distro-configs/LibreOfficeAndroidX86.conf
+++ b/distro-configs/LibreOfficeAndroidX86.conf
@@ -5,5 +5,6 @@
 --disable-gstreamer-1-0
 --disable-randr
 --disable-systray
---without-junit
+--without-export-validation
 --without-helppack-integration
+--without-junit
commit 809241fbb2d81bef2eab9f87268915144f22c9a0
Author: Tor Lillqvist 
Date:   Thu Aug 18 22:30:25 2016 +0300

We don't need any export validation on the build platform when 
cross-compiling

Change-Id: I3e5c92c2824f1b6503e85cff775424b48c3c38d0

diff --git a/configure.ac b/configure.ac
index 38d83c6..dcebca9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4631,6 +4631,7 @@ if test "$cross_compiling" = "yes"; then
 --with-parallelism="$with_parallelism" \
 --without-doxygen \
 --without-java \
+--without-export-validation \
 $sub_conf_opts \
 --srcdir=$srcdir \
 2>&1 | sed -e 's/^//'
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 84344] DIALOG: Unable to set custom background image in Page dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84344

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Yousuf (Jay) Philips  ---
this will be fixed in bug 94551.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87615] Custom background gradients in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87615

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Yousuf (Jay) Philips  ---
this will be fixed with bug 94551.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101587] Python extension example crashes LibreOffice.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101587

Alex  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Alex  ---
(In reply to Alex Thurgood from comment #1)
> @Alex : let's start with some questions
> 
> 1) which python extension in the SDK ?

The "toolpanel" extension in LibreOffice5.1_SDK/examples/python/toolpanel


> 2) which version of python did the compilation pick up on (when you ran
> make) ?

To my understanding, the make command only zipped the package and did not
compile anything since it's a python extension.

For information "python --version" gives "Python 2.7.10" on my system. I also
have python3.5 installed.

The python bundled in Libre Office seems to be the 3.5
$ /Applications/LibreOffice.app/Contents/MacOS/python --version
Python 3.5.0


> 3) can you start LO from the command line with the python extension included
> and provide any output you see on the terminal ?
> 
> As a general point, from what I recall, the using the SDK on Mac for
> development of extensions in languages other than StarBasic and C++ has
> always been problematic (Java and Python being most notably the two main
> languages posing a problem) :
> 
> - Java because of JNI instantiation into the threads of an LO process
> (instantiation itself depend on JRE/JDK version, attempts to instantiate an
> AWT process outside of the main LO thread, etc)
> 
> - Python because of the requirement that the python code be completely
> executable from within the LO application environment (as far as I can
> remember)
> 
> Setting to NEEDINFO

Started with the following commands does not produce any output to console upon
crash.

1. /Applications/LibreOffice.app/Contents/MacOS/soffice
 - Loads the startcenter without issues.
 - When i open an new Calc document 80% chance of crash. 
 - If it crashes, I am presented with a window "Due to an unexpected error,
LibreOffice has crashed". It not everything seems to be ok, although the
extension does not seem to run.
- The Startcenter is restarted and I am also presented with a document recovery
window.
- If I choose to "discard the recovery data" LibreOffice will crash leaving me
on the StartCenter window.
- If I choose "Start recovery" it will recover successfully and present me the
spreadsheet, but will crash again if I save, close the file and open it again.

2. /Applications/LibreOffice.app/Contents/MacOS/soffice --calc
- Crashes immediately on startup
- Loads the Startcenter
- the rest is essentially the same behavior...

Is there a debug mode I can start LibreOffice for it to be more verbose?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101587] Python extension example crashes LibreOffice.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101587

--- Comment #4 from Alex  ---
Created attachment 126896
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126896=edit
window to recover documents

window to recover documents

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 903 commits - accessibility/inc accessibility/source animations/source avmedia/inc avmedia/Library_avmedia.mk avmedia/Module_avmedia.

[Akash Jain]

Rebased ref, commits from common ancestor:
commit d218a47ca54c25bbf420d5f7770dfe837058b9a3
Author: Akash Jain 
Date:   Thu Aug 18 22:46:56 2016 +0530

GSoC: Speed up CommonSalLayout in quartz/

Cache hb face to speed up layout in quartz/

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr& rxFontMetric ) const
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index a530e2e..12b128b 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -136,7 +136,12 @@ CommonSalLayout::CommonSalLayout(const CoreTextStyle& 
rCoreTextStyle)
 maFontSelData(rCoreTextStyle.maFontSelData),
 mrCoreTextStyle(rCoreTextStyle)
 {
-mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+mpHBFace = rCoreTextStyle.GetHBFace();
+if(!mpHBFace)
+{
+mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+rCoreTextStyle.SetHBFace(mpHBFace);
+}
 }
 
 #else
@@ -156,11 +161,6 @@ CommonSalLayout::CommonSalLayout(ServerFont& rServerFont)
 
 CommonSalLayout::~CommonSalLayout()
 {
-#if defined(_WIN32)
-#elif defined(MACOSX) || defined(IOS)
-hb_face_destroy(mpHBFace);
-#else
-#endif
 }
 
 struct HbScriptRun
commit 990adf781ba58661656bf283d1be0912030e2e29
Author: Akash Jain 
Date:   Thu Aug 18 21:10:08 2016 +0530

GSoC: Speed up CommonSalLayout in win/

Cache hb face to obtain speed up.
Switch to DirectWrite from GDI for reading SFNT table data.

Change-Id: I3c00c3e3c0faf340f024d7c78199ac0c78759410

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { 

[Libreoffice-bugs] [Bug 101587] Python extension example crashes LibreOffice.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101587

--- Comment #3 from Alex  ---
Created attachment 126895
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126895=edit
Window when LibreOffice crashes

Window when LibreOffice crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svl/qa

[Laurent Balland-Poirier]

 svl/qa/unit/svl.cxx |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit 502574cb4f1c081b55445fd4b47de6693ef293e2
Author: Laurent Balland-Poirier 
Date:   Sat Aug 13 11:22:31 2016 +0200

tdf#79399 tdf#101462 Add qa unit test

Test Native Number formats NatNum and DBNum

Change-Id: I6e62586d9bfcc27162017291ee110cb70f85d425
Reviewed-on: https://gerrit.libreoffice.org/28098
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 8fb241a..6eca0eb 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -1183,6 +1183,17 @@ void Test::testUserDefinedNumberFormats()
 sExpected = "2";
 checkPreviewString(aFormatter, sCode, 1.96, eLang, sExpected);
 }
+{  // tdf#79399 tdf#101462 Native Number Formats
+sCode = "[NatNum5][$-0404]General\\ ";
+sExpected = OUString(sal_Unicode(22777)) +  // 壹
+OUString(sal_Unicode(20336)) +  // ä½°
+OUString(sal_Unicode(36019)) +  // è²³
+OUString(sal_Unicode(25342)) +  // 拾
+OUString(sal_Unicode(' '));
+checkPreviewString(aFormatter, sCode, 120, eLang, sExpected);
+sCode = "[DBNum2][$-0404]General\\ ";
+checkPreviewString(aFormatter, sCode, 120, eLang, sExpected);
+}
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] UX bugzilla queries (was: minutes of ESC call: 2016-08-18)

[jan iversen]

I am not completly sure what this is about.

But I hope you are aware, that we have a system in place, so that any bugs that 
get needsUXadvice added, get CC to the UXadvice list. 

Therefore you should already get all changes via that mail alias.

rgds
jan I.


> On 18 Aug 2016, at 19:02, Bjoern Michaelsen  
> wrote:
> 
> Hi Heiko,
> 
>> On Thu, Aug 18, 2016 at 06:36:50PM +0200, Bjoern Michaelsen wrote:
>> * UX Update (Heiko)
>>+ from: 
>> http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
>>+ ux-advice: keep it, because many bugs are not easy to file against 
>> a certain component
>>+ tracking of needsux: sure, can do that; but many people may 
>> understand enhancements similar to ux, which needs to get covered (or better 
>> we restrict our trust in the numbers)
>>+ no semantic difference between "component:LibreOffice 
>> keyword:needsUXeval" and "component:ux-advise" (Bjoern)
>>+ introduced keyword, to allow component linked (Heiko)
>>+ component for newcomers (Heiko)
>>+ personally like to keep both (Heiko)
>>+ 350 and 150 in each bucket (Bjoern)
>>+ component:LibreOffice is the catch-all (Bjoern)
>>+ watch compoment for mailing list? (Heiko)
>>+ get a email for every bug change and filter (Thorsten)
>>+ ML create false impression there might be a discussion (Thorsten)
>>+ actual discussion should happen (Eike)
>>+ RSS Feed for query: 
>> https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
>> AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
>> ninja-edit (Robinson)
>>+ get checkbox for bugzilla (Heiko)
>>+ we have 500 ux bugs, we dont need to make it much easier right now 
>> (Bjoern)
> 
> here is a query wrt. UX on bugzilla to get you started:
> 
> https://bugs.documentfoundation.org/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=RESOLVED_status=VERIFIED_status=CLOSED_status=NEEDINFO_status=PLEASETEST=-7d=Now=needsUXEval%2C%20_type=allwords_id=628531=LibreOffice_format=advanced=---
> (unresolved bugs with keyword:needsUXeval touched in the last 7 days)
> 
> you can modify and tweak this with the "edit search" button. Also note the 
> XML,
> CSV, RSS buttons which can be used in a skript. This:
> 
> https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/scripts
> 
> has a few examples of libreoffice scripts using bugzilla. As Thorsten noted,
> using:
> 
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
> 
> as an event stream and filtering that should also work.
> 
> Best,
> 
> Bjoern 
> ___
> LibreOffice mailing list
> libreoff...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: UX bugzilla queries (was: minutes of ESC call: 2016-08-18)

[jan iversen]

I am not completly sure what this is about.

But I hope you are aware, that we have a system in place, so that any bugs that 
get needsUXadvice added, get CC to the UXadvice list. 

Therefore you should already get all changes via that mail alias.

rgds
jan I.


> On 18 Aug 2016, at 19:02, Bjoern Michaelsen  
> wrote:
> 
> Hi Heiko,
> 
>> On Thu, Aug 18, 2016 at 06:36:50PM +0200, Bjoern Michaelsen wrote:
>> * UX Update (Heiko)
>>+ from: 
>> http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
>>+ ux-advice: keep it, because many bugs are not easy to file against 
>> a certain component
>>+ tracking of needsux: sure, can do that; but many people may 
>> understand enhancements similar to ux, which needs to get covered (or better 
>> we restrict our trust in the numbers)
>>+ no semantic difference between "component:LibreOffice 
>> keyword:needsUXeval" and "component:ux-advise" (Bjoern)
>>+ introduced keyword, to allow component linked (Heiko)
>>+ component for newcomers (Heiko)
>>+ personally like to keep both (Heiko)
>>+ 350 and 150 in each bucket (Bjoern)
>>+ component:LibreOffice is the catch-all (Bjoern)
>>+ watch compoment for mailing list? (Heiko)
>>+ get a email for every bug change and filter (Thorsten)
>>+ ML create false impression there might be a discussion (Thorsten)
>>+ actual discussion should happen (Eike)
>>+ RSS Feed for query: 
>> https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
>> AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
>> ninja-edit (Robinson)
>>+ get checkbox for bugzilla (Heiko)
>>+ we have 500 ux bugs, we dont need to make it much easier right now 
>> (Bjoern)
> 
> here is a query wrt. UX on bugzilla to get you started:
> 
> https://bugs.documentfoundation.org/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=RESOLVED_status=VERIFIED_status=CLOSED_status=NEEDINFO_status=PLEASETEST=-7d=Now=needsUXEval%2C%20_type=allwords_id=628531=LibreOffice_format=advanced=---
> (unresolved bugs with keyword:needsUXeval touched in the last 7 days)
> 
> you can modify and tweak this with the "edit search" button. Also note the 
> XML,
> CSV, RSS buttons which can be used in a skript. This:
> 
> https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/scripts
> 
> has a few examples of libreoffice scripts using bugzilla. As Thorsten noted,
> using:
> 
> https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
> 
> as an event stream and filtering that should also work.
> 
> Best,
> 
> Bjoern 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: distro-configs/Jenkins

[Miklos Vajna]

 distro-configs/Jenkins/linux_clang_dbgutil_64 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 686887e2cb71e4ffc1e16179b06adf938a9dc7f9
Author: Miklos Vajna 
Date:   Thu Aug 18 17:03:32 2016 +0200

distro-configs: disable firebird on linux_clang_dbgutil_64

As it's quite unstable and this way the clang tinderbox fails before
deteching interesting problems (and firebird is covered by other
platforms anyway).

Change-Id: Ieaca3a6f5d036c9df22bdbe5a48bf27d2d9ce49f
Reviewed-on: https://gerrit.libreoffice.org/28223
Tested-by: Jenkins 
Reviewed-by: Norbert Thiebaud 

diff --git a/distro-configs/Jenkins/linux_clang_dbgutil_64 
b/distro-configs/Jenkins/linux_clang_dbgutil_64
index 61c274a..e66402c 100644
--- a/distro-configs/Jenkins/linux_clang_dbgutil_64
+++ b/distro-configs/Jenkins/linux_clang_dbgutil_64
@@ -1,2 +1,3 @@
 --enable-dbgutil
 --enable-compiler-plugins
+--disable-firebird-sdbc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 4 commits - vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

[Akash Jain]

 vcl/inc/CommonSalLayout.hxx|3 
 vcl/inc/quartz/salgdi.h|4 
 vcl/inc/unx/glyphcache.hxx |4 
 vcl/inc/win/salgdi.h   |8 +
 vcl/inc/win/winlayout.hxx  |  101 
 vcl/quartz/ctfonts.cxx |3 
 vcl/source/gdi/CommonSalLayout.cxx |   70 --
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |6 +
 vcl/win/gdi/salfont.cxx|   28 +++--
 vcl/win/gdi/winlayout.cxx  |  121 -
 10 files changed, 226 insertions(+), 122 deletions(-)

New commits:
commit 9c8747c112d6e37018cde25a02a437bbb2fabb9c
Author: Akash Jain 
Date:   Thu Aug 18 22:46:56 2016 +0530

GSoC: Speed up CommonSalLayout in quartz/

Cache hb face to speed up layout in quartz/

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr& rxFontMetric ) const
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index a530e2e..12b128b 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -136,7 +136,12 @@ CommonSalLayout::CommonSalLayout(const CoreTextStyle& 
rCoreTextStyle)
 maFontSelData(rCoreTextStyle.maFontSelData),
 mrCoreTextStyle(rCoreTextStyle)
 {
-mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+mpHBFace = rCoreTextStyle.GetHBFace();
+if(!mpHBFace)
+{
+mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+rCoreTextStyle.SetHBFace(mpHBFace);
+}
 }
 
 #else
@@ -156,11 +161,6 @@ CommonSalLayout::CommonSalLayout(ServerFont& rServerFont)
 
 CommonSalLayout::~CommonSalLayout()
 {
-#if defined(_WIN32)
-#elif defined(MACOSX) || defined(IOS)
-hb_face_destroy(mpHBFace);
-#else
-#endif
 }
 
 struct HbScriptRun
commit 6e947e0fc13c8a8b0604b02304304f841c6c7d8c
Author: Akash Jain 
Date:   Thu Aug 18 21:10:08 2016 +0530

GSoC: Speed up CommonSalLayout in win/

Cache hb face to obtain speed up.
Switch to DirectWrite from GDI for reading SFNT table data.

Change-Id: I3c00c3e3c0faf340f024d7c78199ac0c78759410

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include 

[Libreoffice-bugs] [Bug 101274] White screen if Kaspersky Safe Money is used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101274

--- Comment #4 from Buovjaga  ---
Similar report:
https://www.reddit.com/r/libreoffice/comments/4wxmcw/libreoffice_52_window_appears_all_blank_after/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

UX bugzilla queries (was: minutes of ESC call: 2016-08-18)

[Bjoern Michaelsen]

Hi Heiko,

On Thu, Aug 18, 2016 at 06:36:50PM +0200, Bjoern Michaelsen wrote:
> * UX Update (Heiko)
> + from: 
> http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
> + ux-advice: keep it, because many bugs are not easy to file against 
> a certain component
> + tracking of needsux: sure, can do that; but many people may 
> understand enhancements similar to ux, which needs to get covered (or better 
> we restrict our trust in the numbers)
> + no semantic difference between "component:LibreOffice 
> keyword:needsUXeval" and "component:ux-advise" (Bjoern)
> + introduced keyword, to allow component linked (Heiko)
> + component for newcomers (Heiko)
> + personally like to keep both (Heiko)
> + 350 and 150 in each bucket (Bjoern)
> + component:LibreOffice is the catch-all (Bjoern)
> + watch compoment for mailing list? (Heiko)
> + get a email for every bug change and filter (Thorsten)
> + ML create false impression there might be a discussion (Thorsten)
> + actual discussion should happen (Eike)
> + RSS Feed for query: 
> https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
> AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
> ninja-edit (Robinson)
> + get checkbox for bugzilla (Heiko)
> + we have 500 ux bugs, we dont need to make it much easier right now 
> (Bjoern)

here is a query wrt. UX on bugzilla to get you started:

 
https://bugs.documentfoundation.org/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=RESOLVED_status=VERIFIED_status=CLOSED_status=NEEDINFO_status=PLEASETEST=-7d=Now=needsUXEval%2C%20_type=allwords_id=628531=LibreOffice_format=advanced=---
 (unresolved bugs with keyword:needsUXeval touched in the last 7 days)

you can modify and tweak this with the "edit search" button. Also note the XML,
CSV, RSS buttons which can be used in a skript. This:

 https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/scripts

has a few examples of libreoffice scripts using bugzilla. As Thorsten noted,
using:

 https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

as an event stream and filtering that should also work.

Best,

Bjoern 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-qa] UX bugzilla queries (was: minutes of ESC call: 2016-08-18)

[Bjoern Michaelsen]

Hi Heiko,

On Thu, Aug 18, 2016 at 06:36:50PM +0200, Bjoern Michaelsen wrote:
> * UX Update (Heiko)
> + from: 
> http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
> + ux-advice: keep it, because many bugs are not easy to file against 
> a certain component
> + tracking of needsux: sure, can do that; but many people may 
> understand enhancements similar to ux, which needs to get covered (or better 
> we restrict our trust in the numbers)
> + no semantic difference between "component:LibreOffice 
> keyword:needsUXeval" and "component:ux-advise" (Bjoern)
> + introduced keyword, to allow component linked (Heiko)
> + component for newcomers (Heiko)
> + personally like to keep both (Heiko)
> + 350 and 150 in each bucket (Bjoern)
> + component:LibreOffice is the catch-all (Bjoern)
> + watch compoment for mailing list? (Heiko)
> + get a email for every bug change and filter (Thorsten)
> + ML create false impression there might be a discussion (Thorsten)
> + actual discussion should happen (Eike)
> + RSS Feed for query: 
> https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
> AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
> ninja-edit (Robinson)
> + get checkbox for bugzilla (Heiko)
> + we have 500 ux bugs, we dont need to make it much easier right now 
> (Bjoern)

here is a query wrt. UX on bugzilla to get you started:

 
https://bugs.documentfoundation.org/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=RESOLVED_status=VERIFIED_status=CLOSED_status=NEEDINFO_status=PLEASETEST=-7d=Now=needsUXEval%2C%20_type=allwords_id=628531=LibreOffice_format=advanced=---
 (unresolved bugs with keyword:needsUXeval touched in the last 7 days)

you can modify and tweak this with the "edit search" button. Also note the XML,
CSV, RSS buttons which can be used in a skript. This:

 https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/scripts

has a few examples of libreoffice scripts using bugzilla. As Thorsten noted,
using:

 https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

as an event stream and filtering that should also work.

Best,

Bjoern 
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-qa] minutes of ESC call: 2016-08-18

[Bjoern Michaelsen]

* Present: Norbert, Sophie, Armin, Stephan, Robinson, Christian, Thorsten, 
Jan-Marek, Bjoern, Eike, Miklos, Lionel, Olivier, Heiko

* Completed Action Items:
+ fixed with 62c4a8aacf76771e97a8da35096e6ad69a11979a - was: explain the 
reason why "make debug=T" doesnt build with symbols anymore
  / bring it to some ESC when Stephan is here (Stephan / Bjoern)
+ for breeze etc. originals, find out who needs commit access & enable them 
to do it (Heiko)
+ Breeze & co. originals in git should be done 
http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
+ approve https://gerrit.libreoffice.org/#/c/27028/ and
  https://gerrit.libreoffice.org/#/c/27857/ (Cloph)

* Pending Action Items:
+ poke at MSDN licenses (Michael)
[ waiting for a response on new process, on holiday ? ]
+ investigate a cron job that queries & auto-merges (Norbert)
[ the solution proposed by David - using his query & a JSON script
  to refine it - will work - needs a bit more python (Norbert) ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
   + still need to get API key, rest is done
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
+ Program committee to work on the Conf. program (Kendy, Thorsten, Italo, 
Marina)

* Release Engineering update (Christian)
+ no release this week, rc1 last week rc2 next week (cloph)
+ all on track (cloph)
+ 5.1 → 5.1.6 rc1 Oct 4th
+ 5.2 → 5.2.1 rc2 next Tue (Aug 23rd)
+ 5.3 → 5.3.0 alpha 1 Oct 18th
+ Android & iOS Remote

* LibreOffice Conference in Brno (Kendy)
   + kendy away, anyone else?
   + shm_get: see ya there
   + erAck: prep slides!

* Membership Committee plug (Michael)
+ Please send nominations and self-nominations via e-mail to
  electi...@documentfoundation.org (which reaches the Board of
  Directors in private) and also (!) to
  board-disc...@documentfoundation.org (which is a public mailing
  list). We kindly ask nominees who would like to stand for
  elections to provide a statement of up to 75 words on their
  candidacy as continuous text (so no bullet lists or multiple
  paragraphs). In addition, please also provide your full name,
  e-mail address and your corporate affiliation, if any, and
  please announce that you will provide information on all future
  changes as soon as possible.
+ tooling uses git & is user-friendly for devs.

* Documentation (Olivier)
+ Help page for doc classification in.
   -> vm173.documentfoundation.org/text/swriter/classificationbar.xhp
+ Preparing help page for CMIS setup and usage
   -> Found CMIS access very slow in cmis.alfresco.com/cmisatom
   -> will install Alfresco community in laptop to study check-in/check-out 
real case
+ Writer Guide book under review by Jean Weber
+ Getting Started 5.2 open for update
   -> Community slow to jump in (vacations?).
+ Bjoern: blocking on something from dev/infra?
 + infra to put link for Q for 5.3, not urgent (askbot or something 
else)

* GSoC 2016 (Thorsten)
+ Next deadline is August 23rd 19:00 UTC for students to submit their work
+ Mentors then review, final deadline for mentor eval is August 29th
+ reminder - blogging at a minimum helps docs / QA teams etc.
+ !!! soft pen-down next Monday (15th), on 23rd deliver & package
+ to be frozen and delivered after that
+ important that the students deliver that on time, otherwise they'll 
be failed
+ 6 students attending the Conference
+ no news, make students document/blog wildly (Thorsten)

* UX Update (Heiko)
+ from: 
http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
+ ux-advice: keep it, because many bugs are not easy to file against a 
certain component
+ tracking of needsux: sure, can do that; but many people may 
understand enhancements similar to ux, which needs to get covered (or better we 
restrict our trust in the numbers)
+ no semantic difference between "component:LibreOffice 
keyword:needsUXeval" and "component:ux-advise" (Bjoern)
+ introduced keyword, to allow component linked (Heiko)
+ component for newcomers (Heiko)
+ personally like to keep both (Heiko)
+ 350 and 150 in each bucket (Bjoern)
+ component:LibreOffice is the catch-all (Bjoern)
+ watch compoment for mailing list? (Heiko)
+ get a email for every bug change and filter (Thorsten)
+ ML create false impression there might be a discussion (Thorsten)
+ actual discussion should happen (Eike)
+ RSS Feed for query: 
https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
ninja-edit 

minutes of ESC call: 2016-08-18

[Bjoern Michaelsen]

* Present: Norbert, Sophie, Armin, Stephan, Robinson, Christian, Thorsten, 
Jan-Marek, Bjoern, Eike, Miklos, Lionel, Olivier, Heiko

* Completed Action Items:
+ fixed with 62c4a8aacf76771e97a8da35096e6ad69a11979a - was: explain the 
reason why "make debug=T" doesnt build with symbols anymore
  / bring it to some ESC when Stephan is here (Stephan / Bjoern)
+ for breeze etc. originals, find out who needs commit access & enable them 
to do it (Heiko)
+ Breeze & co. originals in git should be done 
http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
+ approve https://gerrit.libreoffice.org/#/c/27028/ and
  https://gerrit.libreoffice.org/#/c/27857/ (Cloph)

* Pending Action Items:
+ poke at MSDN licenses (Michael)
[ waiting for a response on new process, on holiday ? ]
+ investigate a cron job that queries & auto-merges (Norbert)
[ the solution proposed by David - using his query & a JSON script
  to refine it - will work - needs a bit more python (Norbert) ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
   + still need to get API key, rest is done
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
+ Program committee to work on the Conf. program (Kendy, Thorsten, Italo, 
Marina)

* Release Engineering update (Christian)
+ no release this week, rc1 last week rc2 next week (cloph)
+ all on track (cloph)
+ 5.1 → 5.1.6 rc1 Oct 4th
+ 5.2 → 5.2.1 rc2 next Tue (Aug 23rd)
+ 5.3 → 5.3.0 alpha 1 Oct 18th
+ Android & iOS Remote

* LibreOffice Conference in Brno (Kendy)
   + kendy away, anyone else?
   + shm_get: see ya there
   + erAck: prep slides!

* Membership Committee plug (Michael)
+ Please send nominations and self-nominations via e-mail to
  electi...@documentfoundation.org (which reaches the Board of
  Directors in private) and also (!) to
  board-disc...@documentfoundation.org (which is a public mailing
  list). We kindly ask nominees who would like to stand for
  elections to provide a statement of up to 75 words on their
  candidacy as continuous text (so no bullet lists or multiple
  paragraphs). In addition, please also provide your full name,
  e-mail address and your corporate affiliation, if any, and
  please announce that you will provide information on all future
  changes as soon as possible.
+ tooling uses git & is user-friendly for devs.

* Documentation (Olivier)
+ Help page for doc classification in.
   -> vm173.documentfoundation.org/text/swriter/classificationbar.xhp
+ Preparing help page for CMIS setup and usage
   -> Found CMIS access very slow in cmis.alfresco.com/cmisatom
   -> will install Alfresco community in laptop to study check-in/check-out 
real case
+ Writer Guide book under review by Jean Weber
+ Getting Started 5.2 open for update
   -> Community slow to jump in (vacations?).
+ Bjoern: blocking on something from dev/infra?
 + infra to put link for Q for 5.3, not urgent (askbot or something 
else)

* GSoC 2016 (Thorsten)
+ Next deadline is August 23rd 19:00 UTC for students to submit their work
+ Mentors then review, final deadline for mentor eval is August 29th
+ reminder - blogging at a minimum helps docs / QA teams etc.
+ !!! soft pen-down next Monday (15th), on 23rd deliver & package
+ to be frozen and delivered after that
+ important that the students deliver that on time, otherwise they'll 
be failed
+ 6 students attending the Conference
+ no news, make students document/blog wildly (Thorsten)

* UX Update (Heiko)
+ from: 
http://nabble.documentfoundation.org/kendy-collabora-com-Minutes-of-ESC-call-2016-08-11-tp4190974p4190988.html
+ ux-advice: keep it, because many bugs are not easy to file against a 
certain component
+ tracking of needsux: sure, can do that; but many people may 
understand enhancements similar to ux, which needs to get covered (or better we 
restrict our trust in the numbers)
+ no semantic difference between "component:LibreOffice 
keyword:needsUXeval" and "component:ux-advise" (Bjoern)
+ introduced keyword, to allow component linked (Heiko)
+ component for newcomers (Heiko)
+ personally like to keep both (Heiko)
+ 350 and 150 in each bucket (Bjoern)
+ component:LibreOffice is the catch-all (Bjoern)
+ watch compoment for mailing list? (Heiko)
+ get a email for every bug change and filter (Thorsten)
+ ML create false impression there might be a discussion (Thorsten)
+ actual discussion should happen (Eike)
+ RSS Feed for query: 
https://www.bugzilla.org/features/#buglist-formats (Jan-Marek)
AI  + move component:ux-advise to component:LibreOffice keyword:UX as 
ninja-edit 

Code submission for GSoC

[Bunth Tamás]

Code submission for project "Finish Firebird driver integration"

List of commits:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=88346f606a16865bcf7492f67a7207d0078787a1
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ba3f703f01089361ac3ff3d2f231b17097c1d173
https://cgit.freedesktop.org/libreoffice/core/commit/?id=70a295ea33c8a8f3f3643733388f9a37dab9f967
https://cgit.freedesktop.org/libreoffice/core/commit/?id=45f42681f4d1260c42140a313560534e605f81a4
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d3a510e6ec7a42a7a30a24b7373931b8a8ef1a54
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3828e10f7c3918f89312228739b428dc5046b52e
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0a9123152387f7a742481e9f35401270e29ed695
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d

Tamás Bunth
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 101597] New: Timed presentation reset on slide change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101597

Bug ID: 101597
   Summary: Timed presentation reset on slide change
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: oliv...@churlaud.com

When choosing timed presentation (not sure of the name in english: Présentation
chronométrée in french), the time is reset each time you change the slide.

Expected: Let the chronometer run until I stop it so that I can now my overall
presentation time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101583] Range Name References Updated Incorrectly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101583

GerardF  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||gerard.farg...@orange.fr
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #4 from GerardF  ---
(In reply to m.a.riosv from comment #1)
> I think you have enable the option:
> Menu/Tools/Options/LibreOffice calc/General - Expand references when new
> columns/rows are inserted.
> Disabling it works as you expect.
> 
> Resolved as not a bug, please if you are not agree, reopen it.

Sorry, but I disagree with this.

With option unchecked, no change in named range. That's OK

With option checked, ranges must be expanded but not this way :
Insert column should expand named range *only if named range had 2 or more
columns*.

So Fruit_LUT sould expand to A7:C9, while Fruits (A7:A9, only une column)
should *not* be expended.

Same for insert row, only named range with several rows must be expended.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/unx

[Caolán McNamara]

 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit a355897f3efd562b7ac9b962877b6c104cd5a90e
Author: Caolán McNamara 
Date:   Thu Aug 11 16:17:54 2016 +0100

Resolves: tdf#100250 scrollbar has no bg

Change-Id: I48e26b775337809759f8a76be7a9c457c94cd5c9
(cherry picked from commit 17660ddfbe4b6b36b300062bab156d46b211)
Reviewed-on: https://gerrit.libreoffice.org/28059
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index b5fb915c..0365c52 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -439,6 +439,11 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext 
*context,
 gtk_render_background(gtk_widget_get_style_context(gCacheWindow), cr, 0, 0,
   scrollbarRect.GetWidth(), scrollbarRect.GetHeight() 
);
 
+gtk_render_background(context, cr, 0, 0,
+  scrollbarRect.GetWidth(), scrollbarRect.GetHeight() 
);
+gtk_render_frame(context, cr, 0, 0,
+ scrollbarRect.GetWidth(), scrollbarRect.GetHeight() );
+
 gtk_render_background(pScrollbarContentsStyle, cr, 0, 0,
   scrollbarRect.GetWidth(), scrollbarRect.GetHeight() 
);
 gtk_render_frame(pScrollbarContentsStyle, cr, 0, 0,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101165] Crashing on a filter selection, every time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101165

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0 target:5.2.2   |target:5.3.0 target:5.2.2
   ||target:5.1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source

[Caolán McNamara]

 sc/source/ui/cctrl/checklistmenu.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit ecef794528282fa7e9fba93b6eff1dac097dae99
Author: Caolán McNamara 
Date:   Tue Aug 16 11:54:38 2016 +0100

Resolves: tdf#101165 crash on deselecting all filters

(cherry picked from commit b101ff56e874824fa9f0d37a8468b07dbf3d002c)

Change-Id: I49162bb73bf6dbef5cff68d35d10da2c47d9f2b5
Reviewed-on: https://gerrit.libreoffice.org/28165
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx 
b/sc/source/ui/cctrl/checklistmenu.cxx
index e5897ec..9d3298e 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1632,8 +1632,11 @@ SvTreeListEntry* ScCheckListBox::ShowCheckEntry( const 
OUString& sName, ScCheckL
 {
 if ( !pEntry )
 {
-if ( rMember.mbDate )
+if (rMember.mbDate)
 {
+if (rMember.maDateParts.empty())
+return nullptr;
+
 SvTreeListEntry* pYearEntry = FindEntry( nullptr, 
rMember.maDateParts[0] );
 if ( !pYearEntry )
 pYearEntry = InsertEntry( rMember.maDateParts[0], nullptr, 
true );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101347] Closing a particular spreadsheet takes minutes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101347

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c1812103a6c0cd29dd18e546d29ee683f675f6d=libreoffice-5-2

Resolves: tdf#101347 conditional formatting super slow on exit

It will be available in 5.2.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101347] Closing a particular spreadsheet takes minutes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101347

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

[Caolán McNamara]

 sc/source/core/data/colorscale.cxx |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 5c1812103a6c0cd29dd18e546d29ee683f675f6d
Author: Caolán McNamara 
Date:   Tue Aug 9 16:30:23 2016 +0100

Resolves: tdf#101347 conditional formatting super slow on exit

since...

commit 88a0c7d01b7dfd085a0569030f97cc7de0f0d106
Date:   Sat Mar 26 13:11:53 2016 +0100

switch to a listener based cond format update, tdf#95437

I'm obviously assuming here that the notify doesn't matter
when the broadcasted is shutting down.

Change-Id: I0fef0ac1c1d8757199dcffb3c8ec1b05a73c1f17
Reviewed-on: https://gerrit.libreoffice.org/28006
Reviewed-by: Markus Mohrhard 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit cbab44f5eb27c8a45905167d2443f56b816b4a7b)
Reviewed-on: https://gerrit.libreoffice.org/28205
Tested-by: Jenkins 

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 1a08885..6df2b18 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -131,9 +131,14 @@ ScFormulaListener::~ScFormulaListener()
 stopListening();
 }
 
-void ScFormulaListener::Notify( const SfxHint& )
+void ScFormulaListener::Notify(const SfxHint& rHint)
 {
 mbDirty = true;
+
+const SfxSimpleHint* pSimpleHint = dynamic_cast();
+if (pSimpleHint && pSimpleHint->GetId() == SFX_HINT_DYING)
+return;
+
 if (maCallbackFunction)
 maCallbackFunction();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/uiconfig

[Laurent Balland-Poirier]

 chart2/uiconfig/ui/tp_Trendline.ui |   18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 07b25764a4c5479526951c0a0f8fbe4b43f4103e
Author: Laurent Balland-Poirier 
Date:   Thu Aug 18 11:29:41 2016 +0200

Trend Line UI: R² was hidden

Un-hide correlation coefficient
better choice of shortcut

Change-Id: I85acd8a91de2d337d8619ba164dcd14d1939fac9
Reviewed-on: https://gerrit.libreoffice.org/28212
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/chart2/uiconfig/ui/tp_Trendline.ui 
b/chart2/uiconfig/ui/tp_Trendline.ui
index e2a05d7..fb1904b 100644
--- a/chart2/uiconfig/ui/tp_Trendline.ui
+++ b/chart2/uiconfig/ui/tp_Trendline.ui
@@ -87,7 +87,7 @@
 
 
   
-E_xponential
+_Exponential
 True
 True
 False
@@ -444,7 +444,7 @@
 
 
   
-Show 
_Equation
+Show 
E_quation
 True
 True
 False
@@ -481,7 +481,7 @@
 True
 False
 0
-Trendline 
Name
+Trendline 
_Name
 True
 entry_name
   
@@ -526,13 +526,13 @@
 True
 False
 0
-X Variable 
Name
+_X Variable 
Name
 True
 entry_Xname
   
   
 0
-5
+6
 1
 1
   
@@ -545,7 +545,7 @@
 
   
 1
-5
+6
 1
 1
   
@@ -555,13 +555,13 @@
 True
 False
 0
-Y Variable 
Name
+_Y Variable 
Name
 True
 entry_Yname
   
   
 0
-6
+7
 1
 1
   
@@ -574,7 +574,7 @@
 
   
 1
-6
+7
 1
 1
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/data/table3.cxx |   68 -
 1 file changed, 48 insertions(+), 20 deletions(-)

New commits:
commit 63592999a067d76c896ed79204330e1a4b934c80
Author: Eike Rathke 
Date:   Thu Aug 18 17:16:50 2016 +0200

refine HasColHeader()/HasRowHeader() conditions, tdf#91305 related

Check not only the first row/column whether it consists only of text
cells, but also the second row/column whether there are only text cells,
and if so don't assume headers.

Change-Id: I961e93599621c297e866caaf0062f387a7318838

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 86b979c..23b7b5f 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -3241,48 +3241,76 @@ bool ScTable::CreateQueryParam(SCCOL nCol1, SCROW 
nRow1, SCCOL nCol2, SCROW nRow
 
 bool ScTable::HasColHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW nEndRow) const
 {
+if (nStartRow == nEndRow)
+// Assume only data.
+/* XXX NOTE: previous behavior still checked this one row and could
+ * evaluate it has header row, but that doesn't make much sense. */
+return false;
+
 if (nStartCol == nEndCol)
 {
-if (nEndRow > nStartRow)
-{
-CellType eFstCellType = GetCellType(nStartCol, nStartRow);
-CellType eSndCellType = GetCellType(nStartCol, nStartRow+1);
-if ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT)
-   && (eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING))
-return true;
-}
-return false;
+CellType eFstCellType = GetCellType(nStartCol, nStartRow);
+CellType eSndCellType = GetCellType(nStartCol, nStartRow+1);
+return ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT) &&
+(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING));
 }
+
 for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
 {
 CellType eType = GetCellType( nCol, nStartRow );
+// Any non-text cell in first row => not headers.
 if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
 return false;
 }
-return true;
+
+// First row all text cells, any non-text cell in second row => headers.
+SCROW nTestRow = nStartRow + 1;
+for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
+{
+CellType eType = GetCellType( nCol, nTestRow );
+if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
+return true;
+}
+
+// Also second row all text cells => first row not headers.
+return false;
 }
 
 bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW nEndRow ) const
 {
+if (nStartCol == nEndCol)
+// Assume only data.
+/* XXX NOTE: previous behavior still checked this one column and could
+ * evaluate it has header column, but that doesn't make much sense. */
+return false;
+
 if (nStartRow == nEndRow)
 {
-if (nEndCol > nStartCol)
-{
-CellType eFstCellType = GetCellType(nStartCol, nStartRow);
-CellType eSndCellType = GetCellType(nStartCol+1, nStartRow);
-if ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT)
-   && (eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING))
-return true;
-}
-return false;
+CellType eFstCellType = GetCellType(nStartCol, nStartRow);
+CellType eSndCellType = GetCellType(nStartCol+1, nStartRow);
+return ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT) &&
+(eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING));
 }
+
 for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
 {
 CellType eType = GetCellType( nStartCol, nRow );
+// Any non-text cell in first column => not headers.
 if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
 return false;
 }
-return true;
+
+// First column all text cells, any non-text cell in second column => 
headers.
+SCROW nTestCol = nStartCol + 1;
+for (SCCOL nRow=nStartRow; nRow<=nEndRow; nRow++)
+{
+CellType eType = GetCellType( nRow, nTestCol );
+if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
+return true;
+}
+
+// Also second column all text cells => first column not headers.
+return false;
 }
 
 void ScTable::GetFilterEntries(SCCOL nCol, SCROW nRow1, SCROW nRow2, 
std::vector& rStrings, bool& rHasDates)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 73451] Other: how to change code to have quickbooks ( which is looking to launch Microsoft Word, have it recognize libreoffice AS MS Word)???

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=73451

Robinson Tryon (qubit)  changed:

   What|Removed |Added

URL|http://www.quickbookssuppor |
   |thelp.com/  |

--- Comment #4 from Robinson Tryon (qubit)  ---
It'd be cool for the POTUS to use LibreOffice, but
quickbookssupporthelp(dot)com link added by user "Barack Obama" looks like
SPAM, so I'm removing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101596] While resizing window, Search Bar may disappear or Search Field may become as unusable button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101596

--- Comment #1 from Mindaugas Baranauskas  ---
... newly appeared non-functional button has label "Find Text"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101596] New: While resizing window, Search Bar may disappear or Search Field may become as unusable button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101596

Bug ID: 101596
   Summary: While resizing window, Search Bar may disappear or
Search Field may become as unusable button
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: em...@super.lt

Created attachment 126894
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126894=edit
video.ogv

While resizing window, Search Bar may disappear or Search Field may become as
unusable button.
See video.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

RE: Devart

[toki]

Norbert wrote:


>Done. these bogus 'extensions' are now removed

Until you pointed it out, I didn't realize that nothing in the install
directory was an OXT file.

jonathon


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 101595] New: String "Manage Changes" in SideBar of Writer is not provided for translation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101595

Bug ID: 101595
   Summary: String "Manage Changes" in SideBar of Writer is not
provided for translation
   Product: LibreOffice
   Version: 5.2.1.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: em...@super.lt

Created attachment 126893
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126893=edit
"Manage Changes" in SideBar of Writer

We would like to translate string "Manage Changes" in SideBar of Writer.
But in https://translations.documentfoundation.org/lt/libo_ui/ search all
strings "Styles" is already translated prior release of LibreOffice 5.2.1rc1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101594] Word "Styles" in SideBar of Writer is not provided for translation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101594

Mindaugas Baranauskas  changed:

   What|Removed |Added

 Attachment #126891|0   |1
is obsolete||

--- Comment #1 from Mindaugas Baranauskas  ---
Created attachment 126892
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126892=edit
word "Styles" in SideBar of Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97241] Move to more natural French translation for Pivot Table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97241

--- Comment #6 from Alex Thurgood  ---
FYI:

https://euipo.europa.eu/eSearch/#details/trademarks/000943019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101594] New: Word "Styles" in SideBar of Writer is not provided for translation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101594

Bug ID: 101594
   Summary: Word "Styles" in SideBar of Writer is not provided for
translation
   Product: LibreOffice
   Version: 5.2.1.1 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: em...@super.lt

Created attachment 126891
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126891=edit
word "Styles" in SideBar of Writer

We would like to translate word "Styles" in SideBar of Writer.
But in https://translations.documentfoundation.org/lt/libo_ui/ search all
strings "Styles" is already translated prior release of LibreOffice 5.2.1rc1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101519] draw:fit-to-size set by default breaking layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101519

--- Comment #7 from Dave Gilbert  ---
OK, I can confirm if I move the config out of the way it behaves sensibly; so
that leaves two questions:
  1) Whatever it is that's set in the config displays differently before and
after savings, so you don't notice it's screwed up until you reload it all.
  2) How the heck did it get set? Does it correspond to some UI button
somewhere?

The files I have in my libreoffice config directory are as follows; I'd rather
not send the lot since I can see it does have some document history in;


[dg@major libreoffice-off]$ find -type f -ls 
   809312920 -rw---   1  dg   dg 940585 Aug 18 15:38
./4/user/registrymodifications.xcu
   787995  8 -rw-r--r--   1  dg   dg   3759 Oct  7  2013
./4/user/database/evolocal.odb
   788476416 -rw-r--r--   1  dg   dg 418450 Oct  7  2013
./4/user/database/biblio/biblio.dbf
   788477604 -rw-r--r--   1  dg   dg 610825 Oct  7  2013
./4/user/database/biblio/biblio.dbt
   788478  8 -rw-r--r--   1  dg   dg   2687 Oct  7  2013
./4/user/database/biblio.odb
   930136  8 -rw-rw-r--   1  dg   dg 75 Nov 28  2013
./4/user/wordbook/standard.dic
   787975 12 -rw-rw-r--   1  dg   dg  10162 Aug 14 01:23
./4/user/store/.templdir.cache
   786558  4 -rw-rw-r--   1  dg   dg135 May 24 23:54
./4/user/uno_packages/cache/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/backenddb.xml
   786567  4 -rw-rw-r--   1  dg   dg117 May 24 23:54
./4/user/uno_packages/cache/registry/com.sun.star.comp.deployment.help.PackageRegistryBackend/backenddb.xml
   789064 12 -rw-rw-r--   1  dg   dg   8089 Aug 18 15:38
./4/user/uno_packages/cache/log.txt
   788481 16 -rw-r--r--   1  dg   dg  10766 Oct  7  2013
./4/user/config/html.soc
   788482  8 -rw-r--r--   1  dg   dg   2334 Oct  7  2013
./4/user/config/libreoffice.soc
   788483 12 -rw-r--r--   1  dg   dg   4972 Oct  7  2013
./4/user/config/standard.soe
   788321  8 -rw-rw-r--   1  dg   dg 41 Aug 18 15:38
./4/user/config/fontnameboxmruentries
   788484 12 -rw-r--r--   1  dg   dg   6840 Oct  7  2013
./4/user/config/modern.sog
   788485  8 -rw-r--r--   1  dg   dg   2171 Oct  7  2013
./4/user/config/standard.soh
   788486  8 -rw-r--r--   1  dg   dg   2331 Oct  7  2013
./4/user/config/tango.soc
   788488 12 -rw-r--r--   1  dg   dg   5238 Oct  7  2013
./4/user/config/hatching.soh
   788933  8 -rw-r--r--   1  dg   dg   2426 Oct  7  2013
./4/user/config/standard.sod
   789025 20 -rw-r--r--   1  dg   dg  14420 Oct  7  2013
./4/user/config/web.soc
   789026 12 -rw-r--r--   1  dg   dg   4408 Oct  7  2013
./4/user/config/gallery.soc
   789030 12 -rw-r--r--   1  dg   dg   4308 Oct  7  2013
./4/user/config/arrowhd.soe
   789038 16 -rw-r--r--   1  dg   dg   8838 Oct  7  2013
./4/user/config/standard.sog
   789039  8 -rw-r--r--   1  dg   dg   1708 Oct  7  2013
./4/user/config/styles.sod
   789041 52 -rw-r--r--   1  dg   dg  48408 Oct  7  2013
./4/user/config/autotbl.fmt
   789042 12 -rw-r--r--   1  dg   dg   5271 Oct  7  2013
./4/user/config/palette.soc
   789044160 -rw-r--r--   1  dg   dg 155895 Oct  7  2013
./4/user/config/standard.sob
   789045 36 -rw-r--r--   1  dg   dg  30852 Oct  7  2013
./4/user/config/classic.sog
   789046 20 -rw-r--r--   1  dg   dg  13132 Oct  7  2013
./4/user/config/cmyk.soc
   787920  8 -rw-rw-r--   1  dg   dg   2351 Aug 14 01:22
./4/user/config/javasettings_Linux_X86_64.xml
   789047 16 -rw-r--r--   1  dg   dg  10946 Oct  7  2013
./4/user/config/standard.soc
   789048 36 -rw-r--r--   1  dg   dg  31320 Oct  7  2013
./4/user/config/scribus.soc
   789050  8 -rw-r--r--   1  dg   dg567 Oct  7  2013
./4/user/autotext/mytexts.bau
   789113 52 -rw-rw-r--   1  dg   dg  49003 Aug 14 01:22
./4/user/psprint/pspfontcache
   789053  8 -rw-rw-r--   1  dg   dg406 Mar  7  2015
./4/user/basic/dialog.xlc
   789055  8 -rw-r--r--   1  dg   dg288 Oct  7  2013
./4/user/basic/Standard/dialog.xlb
   789056  8 -rw-r--r--   1  dg   dg349 Oct  7  2013
./4/user/basic/Standard/script.xlb
   789057  8 -rw-r--r--   1  dg   dg   1124 Oct  7  2013
./4/user/basic/Standard/Module1.xba
   789058  8 -rw-rw-r--   1  dg   dg406 Mar  7  2015
./4/user/basic/script.xlc
   811011  4 -rw-rw-r--   1  dg   dg367 May  1 15:11
./4/user/gallery/sg30.sdg
   789060  4 -rw-rw-r--   1  dg  

[Libreoffice-commits] core.git: connectivity/source external/firebird

[Wastack]

 connectivity/source/drivers/firebird/Connection.cxx |  304 
 connectivity/source/drivers/firebird/Connection.hxx |   37 ++
 external/firebird/ExternalPackage_firebird.mk   |1 
 3 files changed, 228 insertions(+), 114 deletions(-)

New commits:
commit 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
Author: Wastack 
Date:   Thu Aug 11 12:02:56 2016 +0200

tdf#72987 GSoC Use Firebird backup format

Store embedded database files as an archive (.fbk) file.
The firebird database file is extracted when opening an
odb file, and archived for each saving.

Change-Id: I6c985f89a0fb01b2294f728b4581053521ca0c88
Reviewed-on: https://gerrit.libreoffice.org/28045
Reviewed-by: Lionel Elie Mamane 
Tested-by: Jenkins 

diff --git a/connectivity/source/drivers/firebird/Connection.cxx 
b/connectivity/source/drivers/firebird/Connection.cxx
index ad843c4..1218785 100644
--- a/connectivity/source/drivers/firebird/Connection.cxx
+++ b/connectivity/source/drivers/firebird/Connection.cxx
@@ -58,6 +58,13 @@
 #include 
 #include 
 
+#include 
+
+#ifdef _WIN32
+// for ADD_SPB_NUMERIC
+#pragma warning(disable: 4310) // cast truncates data
+#endif
+
 using namespace connectivity::firebird;
 using namespace connectivity;
 
@@ -79,7 +86,11 @@ using namespace ::com::sun::star::uno;
  * Location within the .odb that an embedded .fdb will be stored.
  * Only relevant for embedded dbs.
  */
-static const OUStringLiteral our_sDBLocation( "firebird.fdb" );
+static const OUStringLiteral our_sFDBLocation( "firebird.fdb" );
+/**
+ * Older version of LO may store the database in a .fdb file
+ */
+static const OUStringLiteral our_sFBKLocation( "firebird.fbk" );
 
 Connection::Connection(FirebirdDriver*_pDriver)
 : Connection_BASE(m_aMutex)
@@ -141,6 +152,9 @@ void Connection::construct(const ::rtl::OUString& url, 
const Sequence< PropertyV
 m_sConnectionURL = url;
 
 bool bIsNewDatabase = false;
+// the database may be stored as an
+// fdb file in older versions
+bool bIsFdbStored = false;
 OUString aStorageURL;
 if (url == "sdbc:embedded:firebird")
 {
@@ -174,35 +188,36 @@ void Connection::construct(const ::rtl::OUString& url, 
const Sequence< PropertyV
 
 bIsNewDatabase = !m_xEmbeddedStorage->hasElements();
 
-m_pExtractedFDBFile.reset(new ::utl::TempFile(nullptr, true));
-m_sFirebirdURL = m_pExtractedFDBFile->GetFileName() + 
"/firebird.fdb";
+m_pDatabaseFileDir.reset(new ::utl::TempFile(nullptr, true));
+m_pDatabaseFileDir->EnableKillingFile();
+m_sFirebirdURL = m_pDatabaseFileDir->GetFileName() + 
"/firebird.fdb";
+m_sFBKPath = m_pDatabaseFileDir->GetFileName() + "/firebird.fbk";
 
 SAL_INFO("connectivity.firebird", "Temporary .fdb location:  " << 
m_sFirebirdURL);
 
 if (!bIsNewDatabase)
 {
-SAL_INFO("connectivity.firebird", "Extracting .fdb from .odb" 
);
-if (!m_xEmbeddedStorage->isStreamElement(our_sDBLocation))
+if (m_xEmbeddedStorage->hasByName(our_sFBKLocation) &&
+m_xEmbeddedStorage->isStreamElement(our_sFBKLocation))
 {
-::connectivity::SharedResources aResources;
-const OUString sMessage = 
aResources.getResourceString(STR_ERROR_NEW_VERSION);
-::dbtools::throwGenericSQLException(sMessage ,*this);
+SAL_INFO("connectivity.firebird", "Extracting* .fbk from 
.odb" );
+loadDatabaseFile(our_sFBKLocation, m_sFBKPath);
 }
-
-Reference< XStream > 
xDBStream(m_xEmbeddedStorage->openStreamElement(our_sDBLocation,
-
ElementModes::READ));
-
-uno::Reference< ucb::XSimpleFileAccess2 > xFileAccess(
-ucb::SimpleFileAccess::create( 
comphelper::getProcessComponentContext() ),
-
uno::UNO_QUERY );
-if ( !xFileAccess.is() )
+else if(m_xEmbeddedStorage->hasByName(our_sFDBLocation) &&
+m_xEmbeddedStorage->isStreamElement(our_sFDBLocation))
+{
+SAL_INFO("connectivity.firebird", "Found .fdb instead of 
.fbk");
+bIsFdbStored = true;
+loadDatabaseFile(our_sFDBLocation, m_sFirebirdURL);
+}
+else
 {
 ::connectivity::SharedResources aResources;
+// TODO FIXME: this does _not_ look like the right error 
message
 const OUString sMessage = 
aResources.getResourceString(STR_ERROR_NEW_VERSION);
 

[Libreoffice-commits] core.git: sdext/source

[Caolán McNamara]

 sdext/source/pdfimport/wrapper/wrapper.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 93295a069b9d6fa4da78a6b1ae98c63940f0
Author: Caolán McNamara 
Date:   Thu Aug 18 15:44:28 2016 +0100

coverity#1371125 Copy-paste error

this went wrong with

commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126
Date:   Mon Jun 20 17:40:13 2016 +0300

tdf#99589 - tolower / toupper - dangerous to Turks ...

restore the logic to the original logic, but with the new
api

Change-Id: I445064b19eeefabbd25849bae9ca569710cdfac5

diff --git a/sdext/source/pdfimport/wrapper/wrapper.cxx 
b/sdext/source/pdfimport/wrapper/wrapper.cxx
index e15ba17..b213e8e 100644
--- a/sdext/source/pdfimport/wrapper/wrapper.cxx
+++ b/sdext/source/pdfimport/wrapper/wrapper.cxx
@@ -471,9 +471,12 @@ sal_Int32 Parser::parseFontCheckForString(
 if (nCopyLen < nAttribLen)
 return 0;
 for (sal_Int32 i = 0; i < nAttribLen; ++i)
-if (rtl::toAsciiLowerCase(pCopy[i]) != 
rtl::toAsciiLowerCase(pAttrib[i])
-&& rtl::toAsciiUpperCase(pCopy[i]) != 
rtl::toAsciiLowerCase(pAttrib[i]))
+{
+sal_uInt32 nCode = pAttrib[i];
+if (rtl::toAsciiLowerCase(pCopy[i]) != nCode
+&& rtl::toAsciiUpperCase(pCopy[i]) != nCode)
 return 0;
+}
 rResult.isItalic |= bItalic;
 rResult.isBold |= bBold;
 return nAttribLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] Does LibreOffice run on El Capitan (Mac)?

[Robinson Tryon]

On Wed, Aug 17, 2016 at 8:02 AM, Steven Yanoff  wrote:
> Does LibreOffice run on El Capitan (OS X El Capitan on Mac)?

Hi Steven,

I'd suggest that you download the latest version of LibreOffice and try it out
https://www.libreoffice.org/download/libreoffice-fresh/

> If it does, are there problems?  I am running the latest - El Capitan 10.11.6.

Have you experienced any issues running LibreOffice on OSX? If there
is an issue present, please check to see if it's been reported in the
bug tracker, and file a new bug if needed:
https://bugs.documentfoundation.org/

In fact, here's an older bug report about El Capitan that needs review
and re-testing:
https://bugs.documentfoundation.org/show_bug.cgi?id=93368

If you're interested in QA on OS X, that might be a good place to start!

Thanks,
--R

-- 
Robinson Tryon
qu...@libreoffice.org
802-379-9482 | IRC: colonelqubit on Freenode
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: Devart

[Norbert Thiebaud]

Done. these bogus 'extensions' are now removed

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Does LibreOffice run on El Capitan (Mac)?

[Italo Vignoli]

On 17/08/2016 15:02, Steven Yanoff wrote:
> Does LibreOffice run on El Capitan (OS X El Capitan on Mac)?  If it does, are 
> there problems?  I am running the latest - El Capitan 10.11.6.

Yes, it works.

-- 
Italo Vignoli - LibreOffice Marketing & PR
mobile/signal +39.348.5653829 - email it...@libreoffice.org
hangout/jabber italo.vign...@gmail.com - skype italovignoli
GPG Key ID - 0xAAB8D5C0
DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 97595] Create list of misspelled and corrected words from spellcheck process ?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97595

Alex Thurgood  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Alex Thurgood  ---
Agreed. This is typically the realm of an extension. Such extensions are either
developed by the person who has that itch to scratch, or else by others in the
wider community, rather than being a core functionality of the LibreOffice
application (which it isn't).

One other possibility might be to get/sponsor a GSOC student interested in
providing the requested functionality.

Am setting as RFE and lowering importance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44167] failing subsequenttests in ScDatabaseRangeObj

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=44167

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||744

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

[Vasily Melenchuk]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0868f670374cdcf6c2610d91ff8702f59b2e0bd3
Author: Vasily Melenchuk 
Date:   Wed Aug 10 13:50:19 2016 +0300

enable export-validation in tests by default

since ODF and OOXML validators are now being downloaded, so new default
behavior is to use validation for export tests. To disable validation in
tests -without-export-validation configure switch should be used.

Change-Id: I5cfebae0375e6676ef8cba4cfdaac4b164eed97d
Reviewed-on: https://gerrit.libreoffice.org/28014
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/configure.ac b/configure.ac
index 6e14836..38d83c6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2039,7 +2039,7 @@ AC_ARG_WITH(export-validation,
 [If you want the exported files to be validated. Right now limited to 
OOXML and ODF files.
  Note: You need executable scripts officeotron and odfvalidator that 
take the path to the file.
  See 
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation]),
-,)
+,with_export_validation=yes)
 
 AC_ARG_WITH(bffvalidator,
 AS_HELP_STRING([--with-bffvalidator=],
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=44
   ||167

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/osl

[Tor Lillqvist]

 sal/osl/all/log.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 79603023925547e1a2ace7cd4e113cdf702622b4
Author: Tor Lillqvist 
Date:   Thu Aug 18 17:16:40 2016 +0300

Move comment block back where it was

Change-Id: I020c1def83d7cc37f9d5e14f2fefacb31a56bbbf

diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index c1608b1..f9a6a4e 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -207,12 +207,12 @@ bool report(sal_detail_LogLevel level, char const * area) 
{
 Sense sense;
 switch (*p++) {
 case '\0':
-// if a specific item is both positive and negative
-// (senseLen[POSITIVE] == senseLen[NEGATIVE]), default to
-// positive
 if (level == SAL_DETAIL_LOG_LEVEL_WARN && !seenWarn)
 return report(SAL_DETAIL_LOG_LEVEL_INFO, area);
 return senseLen[POSITIVE] >= senseLen[NEGATIVE];
+// if a specific item is both positive and negative
+// (senseLen[POSITIVE] == senseLen[NEGATIVE]), default to
+// positive
 case '+':
 sense = POSITIVE;
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=47
   ||479

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47479] LibO Calc Macro .getCellRangeByName with named range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47479

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||744

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Does LibreOffice run on El Capitan (Mac)?

[Steven Yanoff]

Does LibreOffice run on El Capitan (OS X El Capitan on Mac)?  If it does, are 
there problems?  I am running the latest - El Capitan 10.11.6.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 91744] Failure adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Alex Thurgood  ---
@David : in order to attempt to move this bug report from UNCONFIRMED to some
other, hopefully more positive status, we would need a sample Calc sheet
including the macro code (and any buttons) with instructions on how to use it.
I kind of understand what you are getting at, but I'm not a macro programmer
(at best a very basic one).

Setting to NEEDINFO

Please set back to UNCONFIRMED once you have provided the requested
information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

--- Comment #3 from Alex Thurgood  ---
Please also provide the version of LibreOffice with which you encountered the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91744

Alex Thurgood  changed:

   What|Removed |Added

Summary|Failure adding rows with|Macro failure when adding
   |named range scope   |rows with named range scope
   |restricted to the sheet |restricted to the sheet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sal sal/osl

[Tor Lillqvist]

 include/sal/log.hxx |3 +++
 sal/osl/all/log.cxx |   10 +++---
 2 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 99ee4ebb0e934413bed881a02e4634e4d3f813ea
Author: Tor Lillqvist 
Date:   Thu Aug 18 16:55:11 2016 +0300

If no WARN in SAL_LOG, use the INFO selection for WARNs, too

Often the choice whether some particular message is displayed with
SAL_INFO or SAL_WARN has not necessarily been that well thought
through. Many SAL_WARNs are not actually warnings but purely
informative. If you want to see the INFOs for an area it makes sense
to want to see also the WARNs for it. So make it so, unless a specific
WARN selection is specified.

Change-Id: I6286c5f856b29e68bedb7f20efadf56953f94b72

diff --git a/include/sal/log.hxx b/include/sal/log.hxx
index e879a2f..8b4ef0a 100644
--- a/include/sal/log.hxx
+++ b/include/sal/log.hxx
@@ -262,6 +262,9 @@ inline char const * unwrapStream(SAL_UNUSED_PARAMETER 
StreamIgnore const &) {
 that has a sense of "+".  (That is, if both +INFO.foo and -INFO.foo are
 present, +INFO.foo wins.)
 
+If no WARN selection is specified, but an INFO selection is, the
+INFO selection is used for WARN messages, too.
+
 For example, if SAL_LOG is "+INFO-INFO.foo+INFO.foo.bar", then calls like
 SAL_INFO("foo.bar", ...), SAL_INFO("foo.bar.baz", ...), or
 SAL_INFO("other", ...) generate output, while calls like
diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index 7f865f6..c1608b1 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -202,14 +202,17 @@ bool report(sal_detail_LogLevel level, char const * area) 
{
 // no matching switches at all, the result will be negative (and
 // initializing with 1 is safe as the length of a valid switch, even
 // without the "+"/"-" prefix, will always be > 1)
+bool seenWarn = false;
 for (char const * p = env;;) {
 Sense sense;
 switch (*p++) {
 case '\0':
+// if a specific item is both positive and negative
+// (senseLen[POSITIVE] == senseLen[NEGATIVE]), default to
+// positive
+if (level == SAL_DETAIL_LOG_LEVEL_WARN && !seenWarn)
+return report(SAL_DETAIL_LOG_LEVEL_INFO, area);
 return senseLen[POSITIVE] >= senseLen[NEGATIVE];
-// if a specific item is both positive and negative
-// (senseLen[POSITIVE] == senseLen[NEGATIVE]), default to
-// positive
 case '+':
 sense = POSITIVE;
 break;
@@ -229,6 +232,7 @@ bool report(sal_detail_LogLevel level, char const * area) {
 } else if (equalStrings(p, p1 - p, RTL_CONSTASCII_STRINGPARAM("WARN")))
 {
 match = level == SAL_DETAIL_LOG_LEVEL_WARN;
+seenWarn = true;
 } else if (equalStrings(p, p1 - p, 
RTL_CONSTASCII_STRINGPARAM("TIMESTAMP")) ||
equalStrings(p, p1 - p, 
RTL_CONSTASCII_STRINGPARAM("RELATIVETIMER")))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100927] Provide keyboard shortcut as hover popup for toolbars

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100927

--- Comment #3 from Ulrich Windl  ---
Created attachment 126890
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126890=edit
Example: The GIMP (partial screenshot)

I forgot a more obvious example: The GIMP provides it all: Iconic command
buttons, user-assignable keyboard shortcuts, and hover information showing the
assigned keyboard shortcut (as well as a description of the button)...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98281] Mail Merge Crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98281

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #7 from Alex Thurgood  ---
@Robin : I am resetting this to NOTOURBUG.

You have reported the problem against Fedora-provided packages, and moreover,
these aren't even the very latest versions of LibreOffice available from TDF
(the LibreOffice.org download page).

If anything, you should report the issue with Fedora and their own bug tracker.

If you have downloaded the latest versions available from TDF and tried those
and still have the problem, then please re-open and state which version you
tested.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Yan Pashkovsky]

 sc/source/core/data/table3.cxx |   28 ++--
 1 file changed, 26 insertions(+), 2 deletions(-)

New commits:
commit 4cd9e45a439b654c8e1ff7983fe7e4bd073b9c92
Author: Yan Pashkovsky 
Date:   Fri Aug 12 23:39:30 2016 +0300

tdf#91305 fix sort calc

Change-Id: Id8969e28d653add5ba4348ece622b2b53ce464da
Reviewed-on: https://gerrit.libreoffice.org/28094
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 6da1c7c..86b979c 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -3239,8 +3239,20 @@ bool ScTable::CreateQueryParam(SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow
 return bValid;
 }
 
-bool ScTable::HasColHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW /* nEndRow */ ) const
+bool ScTable::HasColHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW nEndRow) const
 {
+if (nStartCol == nEndCol)
+{
+if (nEndRow > nStartRow)
+{
+CellType eFstCellType = GetCellType(nStartCol, nStartRow);
+CellType eSndCellType = GetCellType(nStartCol, nStartRow+1);
+if ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT)
+   && (eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING))
+return true;
+}
+return false;
+}
 for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
 {
 CellType eType = GetCellType( nCol, nStartRow );
@@ -3250,8 +3262,20 @@ bool ScTable::HasColHeader( SCCOL nStartCol, SCROW 
nStartRow, SCCOL nEndCol, SCR
 return true;
 }
 
-bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL /* nEndCol 
*/, SCROW nEndRow ) const
+bool ScTable::HasRowHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW nEndRow ) const
 {
+if (nStartRow == nEndRow)
+{
+if (nEndCol > nStartCol)
+{
+CellType eFstCellType = GetCellType(nStartCol, nStartRow);
+CellType eSndCellType = GetCellType(nStartCol+1, nStartRow);
+if ((eFstCellType == CELLTYPE_STRING || eFstCellType == 
CELLTYPE_EDIT)
+   && (eSndCellType != CELLTYPE_STRING && eSndCellType != 
CELLTYPE_STRING))
+return true;
+}
+return false;
+}
 for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
 {
 CellType eType = GetCellType( nStartCol, nRow );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

600 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 20 of 600 defect(s)


** CID 1371317:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/svtools/source/control/collatorres.cxx: 29 in ()



*** CID 1371317:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/svtools/source/control/collatorres.cxx: 29 in ()
23 #include 
24 
25 
26 //  wrapper for locale specific translations data of collator algorithm
27 
28 
>>> CID 1371317:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>> Class "CollatorResourceData" may benefit from adding a move assignment 
>>> operator. See other events which show the copy assignment operator being 
>>> applied to rvalue(s), where a move assignment may be faster.
29 class CollatorResourceData
30 {
31 friend class CollatorResource;
32 private: /* data */
33 OUString ma_Name;
34 OUString ma_Translation;

** CID 1371316:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/lotuswordpro/source/filter/lwpcolor.hxx: 70 in ()



*** CID 1371316:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/lotuswordpro/source/filter/lwpcolor.hxx: 70 in ()
64 #include "lwpobjstrm.hxx"
65 #include "lwpheader.hxx"
66 /**
67  * @brief   lwpcolor class
68  *  (red, green, blue, extra)
69 */
>>> CID 1371316:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>> Class "LwpColor" may benefit from adding a move assignment operator. 
>>> See other events which show the copy assignment operator being applied to 
>>> rvalue(s), where a move assignment may be faster.
70 class LwpColor
71 {
72 public:
73 LwpColor():m_nRed(0), m_nGreen(0), m_nBlue(0), m_nExtra(0){}
74 ~LwpColor(){}
75 public:

** CID 1371315:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/strokeattribute.hxx: 39 in ()



*** CID 1371315:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/drawinglayer/attribute/strokeattribute.hxx: 39 in ()
33 
34 
35 namespace drawinglayer
36 {
37 namespace attribute
38 {
>>> CID 1371315:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>> Class "drawinglayer::attribute::StrokeAttribute" may benefit from 
>>> adding a move assignment operator. See other events which show the copy 
>>> assignment operator being applied to rvalue(s), where a move assignment may 
>>> be faster.
39 class DRAWINGLAYER_DLLPUBLIC StrokeAttribute
40 {
41 public:
42 typedef o3tl::cow_wrapper< ImpStrokeAttribute > ImplType;
43 
44 private:

** CID 1371314:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/cppu/source/uno/lbmap.cxx: 58 in ()



*** CID 1371314:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/cppu/source/uno/lbmap.cxx: 58 in ()
52 using ::rtl::OUStringBuffer;
53 using ::rtl::OUStringHash;
54 
55 namespace cppu
56 {
57 
>>> CID 1371314:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>> Class "cppu::Mapping" may benefit from adding a move assignment 
>>> operator. See other events which show the copy assignment operator being 
>>> applied to rvalue(s), where a move assignment may be faster.
58 class Mapping
59 {
60 uno_Mapping * _pMapping;
61 
62 public:
63 inline explicit Mapping( uno_Mapping * pMapping = nullptr );

** CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()



*** CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()
40 
41 class OConfigurationTreeRoot;
42 /** a small wrapper around a configuration node.
43 Nodes in the terminology used herein are inner nodes of 
a configuration
44 tree, which means no leafs.
45 */
>>> CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>> Class "utl::OConfigurationNode" may benefit from adding a move 
>>> assignment operator. See other events which show the copy assignment 
>>> operator being applied to rvalue(s), where a move assignment may be faster.
46 class UNOTOOLS_DLLPUBLIC OConfigurationNode : public 
::utl::OEventListenerAdapter
47 {
48 private:
49 

[Libreoffice-bugs] [Bug 101593] New: Columns width resizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101593

Bug ID: 101593
   Summary: Columns width resizing
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: clement.g...@gmail.com

Hi, In Libreoffice online (calc) , resizing the width of a column doesn't seem
to work. When the border is dragged to the desired size, nothing happens
afterwards.

Best Regards,

Clément Gamé.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91533] Tooltips are truncated if OS default font is size 12

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91533

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #13 from Caolán McNamara  ---
I could reproduce this at 1368x768 and the above patch made it go away

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91533] Tooltips are truncated if OS default font is size 12

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91533

--- Comment #12 from Commit Notification 
 ---
rpmbuild committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e527edf06f8befb45b76ee8ebabe62e6dc885e45

Resolves: tdf#91533 (rhbz#1364335) Tooltips are truncated

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91533] Tooltips are truncated if OS default font is size 12

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91533

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/tiledrendering/tiledrendering.cxx |   32 +
 sw/source/uibase/uiview/viewstat.cxx   |9 ---
 2 files changed, 38 insertions(+), 3 deletions(-)

New commits:
commit b6011f07254f8003929320ad842d8d09daca0e09
Author: Miklos Vajna 
Date:   Thu Aug 18 13:37:42 2016 +0200

sw: fix accepting/rejecting a change by index when cursor is not at a 
redline

When there is no index, then the cursor position is used to find out
which redline to accept/reject. LOK uses the index parameter instead, so
there never disable the command.

Change-Id: Icbe0905e4ebd170c6f33fe383cd3042d812a2eb0

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index d1837c7..ad8deaf 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -67,6 +67,7 @@ public:
 void testUndoRepairDispatch();
 void testShapeTextUndoShells();
 void testShapeTextUndoGroupShells();
+void testTrackChanges();
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -99,6 +100,7 @@ public:
 CPPUNIT_TEST(testUndoRepairDispatch);
 CPPUNIT_TEST(testShapeTextUndoShells);
 CPPUNIT_TEST(testShapeTextUndoGroupShells);
+CPPUNIT_TEST(testTrackChanges);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -1137,6 +1139,36 @@ void SwTiledRenderingTest::testShapeTextUndoGroupShells()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void SwTiledRenderingTest::testTrackChanges()
+{
+// Load a document.
+comphelper::LibreOfficeKit::setActive();
+SwXTextDocument* pXTextDocument = createDoc("dummy.fodt");
+
+// Turn on trak changes, type "zzz" at the end, and move to the start.
+uno::Reference xPropertySet(mxComponent, 
uno::UNO_QUERY);
+xPropertySet->setPropertyValue("RecordChanges", uno::makeAny(true));
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+pWrtShell->EndDoc();
+pWrtShell->Insert("zzz");
+pWrtShell->SttDoc();
+
+// Reject the change by index, while the cursor does not cover the tracked 
change.
+uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence(
+{
+{"RejectTrackedChange", uno::makeAny(static_cast(0))}
+}));
+comphelper::dispatchCommand(".uno:RejectTrackedChange", aPropertyValues);
+Scheduler::ProcessEventsToIdle();
+
+// Assert that the reject was performed.
+SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
+// This was 'Aaa bbb.zzz', the change wasn't rejected.
+CPPUNIT_ASSERT_EQUAL(OUString("Aaa bbb."), 
pShellCursor->GetPoint()->nNode.GetNode().GetTextNode()->GetText());
+
+comphelper::LibreOfficeKit::setActive(false);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SwTiledRenderingTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/uibase/uiview/viewstat.cxx 
b/sw/source/uibase/uiview/viewstat.cxx
index 6815a61..31d6b03 100644
--- a/sw/source/uibase/uiview/viewstat.cxx
+++ b/sw/source/uibase/uiview/viewstat.cxx
@@ -51,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -286,8 +287,10 @@ void SwView::GetState(SfxItemSet )
 SwPaM *pCursor = m_pWrtShell->GetCursor();
 if (GetDocShell()->HasChangeRecordProtection())
 rSet.DisableItem(nWhich);
-else if (pCursor->HasMark())
-{ // If the selection does not contain redlines, disable 
accepting/rejecting changes.
+else if (pCursor->HasMark() && 
!comphelper::LibreOfficeKit::isActive())
+{
+// If the selection does not contain redlines, disable 
accepting/rejecting changes.
+// Though LibreOfficeKit wants to handle changes by index, 
so always allow there.
 sal_uInt16 index = 0;
 const SwRedlineTable& table = 
pDoc->getIDocumentRedlineAccess().GetRedlineTable();
 const SwRangeRedline* redline = table.FindAtPosition( 
*pCursor->Start(), index );
@@ -310,7 +313,7 @@ void SwView::GetState(SfxItemSet )
 if( redline == nullptr )
 rSet.DisableItem(nWhich);
 }
-else
+else if (!comphelper::LibreOfficeKit::isActive())
 {
 // If the cursor position isn't on a redline, disable
 // accepting/rejecting changes.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc vcl/source

[rpmbuild]

 vcl/inc/helpwin.hxx |1 +
 vcl/source/app/help.cxx |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit e527edf06f8befb45b76ee8ebabe62e6dc885e45
Author: rpmbuild 
Date:   Mon Aug 15 15:17:11 2016 +0100

Resolves: tdf#91533 (rhbz#1364335) Tooltips are truncated

Change-Id: Id9ec91ed9652f491e4e2a0556eeed27bf6517002

diff --git a/vcl/inc/helpwin.hxx b/vcl/inc/helpwin.hxx
index e7cc81a..3864575 100644
--- a/vcl/inc/helpwin.hxx
+++ b/vcl/inc/helpwin.hxx
@@ -47,6 +47,7 @@ private:
 virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle&) 
override;
 virtual void RequestHelp( const HelpEvent& rHEvt ) override;
 virtual void ApplySettings(vcl::RenderContext& rRenderContext) override;
+virtual void StateChanged(StateChangedType nType) override;
 
 virtual OUString GetText() const override;
 void ImplShow();
diff --git a/vcl/source/app/help.cxx b/vcl/source/app/help.cxx
index 28bc632..7a8bbc8 100644
--- a/vcl/source/app/help.cxx
+++ b/vcl/source/app/help.cxx
@@ -277,6 +277,17 @@ HelpTextWindow::HelpTextWindow( vcl::Window* pParent, 
const OUString& rText, sal
 maHideTimer.SetTimeout( rHelpSettings.GetTipTimeout() );
 }
 
+void HelpTextWindow::StateChanged(StateChangedType nType)
+{
+FloatingWindow::StateChanged(nType);
+if (nType == StateChangedType::InitShow)
+{
+ApplySettings(*this);
+SetHelpText(maHelpText);
+Invalidate();
+}
+}
+
 void HelpTextWindow::ApplySettings(vcl::RenderContext& rRenderContext)
 {
 const StyleSettings& rStyleSettings = 
rRenderContext.GetSettings().GetStyleSettings();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101134] The new functions CONCAT and TEXTJOIN wrongly produce output to an array if called to evaluate parameters in array mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101134

--- Comment #4 from Wolfgang Jäger  ---
(In reply to Aron Budea from comment #3)
> Created attachment 126823 [details]
> CONCAT vs. CONCATENATE
> 
> Yes, this is the exact same report as 99625, except it includes CONCAT.
(Not quite exact. See below.)

> There are no specifications, as these functions were introduced to be
> compatible with Excel's new functions, see bug 97831.
Aiming at compatibility the first step should be thorough inspection of the
pattern to imitate and tests with it, making sure to not miss something of
relevance. Looking for a specification of the pattern may also be possible. The
second step is to mould the results into rather plain language and to derive
this way a specification for the imitation to be, regarding the changing
environment. (Already existing mandatory specifications MUST persist this
step.) Only the third step can then be the implementation of the new (imitated)
functionality. 
These steps are urgently needed to be able to distinguish a bad implementation
from a misunderstanding concerning the pattern.

> I'd prefer to see minimal examples, like the one I'm attaching. ...

I so do - within limits. The mentioned example only covers the case of a
superfluous call to array evaluation. It demonstrates the bug, but not its
severity. After all there are cases where array evaluation is relevant for the
working of a formula. I tried to demonstrate such a case, much reduced again.
OK. I used 10 rows where 3 or 4 might have done. Sorry!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Implementing l10n in an extension

[Regina Henschel]

Hi Katarina,

Katarina Behrens schrieb:

Hello world,

I've implemented a Calc extension that includes some dialogs and I'd like to
have those translated to multiple languages. The dialogs are implemented in
this funny .xdl Basic format, the handlers in Java.

However, as you might've already expected ;) l10n didn't quite work out so
far. No matter what I do, I can't get localized strings displayed. Instead of
English or German strings, I see only the references e.g.
"&3.Dialog1.CommandButton1.Label"

It has certainly something to do with the fact that I've created l10n files
manually, since GUI for that is currently completely defunct due to [1] so if
anyone can spot an obvious mistake, something missing etc. in my data below
and/or give me some useful advice, I'd be grateful


Make sure, that the files *.properties are included in the finished 
extension. If not, copy them manually.





My folder structure:

dialogs/
   +- Dialog1.xdl
   +- Dialog2.xdl
   +- DialogStrings_de_DE.properties
   +- DialogStrings_en_US.default
   +- DialogStrings_en_US.properties
   +- dialog.xlb


What is "dialogs"? The module name?



Dialog1.xdl:



DialogStrings_en_US.properties:

3.Dialog1.CommandButton1.Label=Close

DialogStrings_de_DE.properties:

3. Dialog1.CommandButton1.Label=Schließen


Without blank after 3.
You have to escape special characters
ß   \u00df



dialog.xlb:

http://openoffice.org/2000/library;
library:name="dialogs" library:readonly="false"
library:passwordprotected="false">
  
  




Are you sure about the value of library:name? If I use the Basic Macro 
Organizer, it is the name shown in the list "Library" in tab "Libraries".


Do you have used an own module? You cannot do it in Module "Standard".

I would do a mini test in AOO or a very old LO to be sure about the 
needed structure, and then add the missing parts manually.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 4 commits - chart2/source dbaccess/source desktop/qa extensions/source sc/source sdext/source sd/source svtools/source sw/source ucb/source vbahelper/source vcl/headles

[Caolán McNamara]

 chart2/source/controller/chartapiwrapper/AreaWrapper.cxx   
|6 -
 chart2/source/controller/chartapiwrapper/AreaWrapper.hxx   
|2 
 chart2/source/controller/chartapiwrapper/AxisWrapper.cxx   
|2 
 chart2/source/controller/chartapiwrapper/AxisWrapper.hxx   
|2 
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx  
|8 +-
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.hxx  
|4 -
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx  
|   28 +++
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
|   29 +++
 chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx
|6 -
 chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
|   39 --
 chart2/source/controller/chartapiwrapper/DiagramWrapper.hxx
|2 
 chart2/source/controller/chartapiwrapper/GridWrapper.cxx   
|9 +-
 chart2/source/controller/chartapiwrapper/GridWrapper.hxx   
|2 
 chart2/source/controller/chartapiwrapper/LegendWrapper.cxx 
|6 -
 chart2/source/controller/chartapiwrapper/LegendWrapper.hxx 
|2 
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx 
|2 
 chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.hxx 
|2 
 chart2/source/controller/chartapiwrapper/TitleWrapper.cxx  
|2 
 chart2/source/controller/chartapiwrapper/TitleWrapper.hxx  
|2 
 chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx  
|2 
 chart2/source/controller/chartapiwrapper/UpDownBarWrapper.hxx  
|2 
 chart2/source/controller/chartapiwrapper/WallFloorWrapper.cxx  
|2 
 chart2/source/controller/chartapiwrapper/WallFloorWrapper.hxx  
|2 
 
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 |   16 ++--
 chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx  
|6 -
 chart2/source/controller/chartapiwrapper/WrappedGapwidthProperty.cxx   
|6 -
 chart2/source/controller/chartapiwrapper/WrappedGapwidthProperty.hxx   
|6 -
 chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx   
|2 
 chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.hxx   
|2 
 chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx  
|4 -
 chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx  
|2 
 chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx
|4 -
 chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx  
|2 
 chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx  
|2 
 chart2/source/controller/chartapiwrapper/WrappedSeriesOrDiagramProperty.hxx
|2 
 chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx   
|8 +-
 chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
|   16 ++--
 chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx   
|   24 +++---
 dbaccess/source/sdbtools/connection/objectnames.cxx
|2 
 desktop/qa/desktop_app/test_desktop_app.cxx
|2 
 extensions/source/propctrlr/browserlistbox.hxx 
|2 
 extensions/source/resource/ResourceIndexAccess.cxx 
|6 -
 extensions/source/scanner/scanunx.cxx  
|7 -
 sc/source/core/opencl/formulagroupcl.cxx   
|   14 +--
 sc/source/core/opencl/opbase.cxx   
|4 -
 sc/source/core/opencl/opbase.hxx   
|4 -
 sd/source/ui/animations/CustomAnimationList.cxx
|8 +-
 sd/source/ui/dlg/RemoteDialogClientBox.cxx 
|6 -
 sd/source/ui/dlg/RemoteDialogClientBox.hxx 
|2 
 sdext/source/pdfimport/pdfparse/pdfentries.cxx 
|3 
 svtools/source/control/valueimp.hxx
|2 
 sw/source/core/docnode/finalthreadmanager.cxx  
|4 -
 sw/source/core/docnode/node2lay.cxx
|4 +