[Libreoffice-bugs] [Bug 85994] Images in DOCX are Fliped Horizontally when in Right-to-Left Format

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=85994

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=43
   ||093

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 31481] [RFE] Split pane in same window for side-by-side proof reading / translating of 2 different files

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=31481

--- Comment #73 from 670c4...@opayq.com ---
Need split pane in Writer for 'same' file as well, vertical primarily,
horizontal if possible

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75734] Spell checking doesn' t warn users if the selected dictionary isn't installed, but rather returns a potentially incorrect result

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75734

--- Comment #10 from David H. Gutteridge  ---
Yes, quite true, I alluded to that potential problem of a flurry of warnings.
But what's also a really bad idea is a software design that claims to have
compared two data sets and reports no issues when in fact it failed to do so
because it cannot retrieve one of the two sets. Something needs to be done to
try and address this, even if it's less than perfect.

Another possibility would be to build a list of any dictionaries the document
requires at the time it's loaded and determine if any are unavailable, and if
so, provide a single, concise warning. This wouldn't be perfect either, since
someone could change to or add a different language while editing, but at least
that would be an improvement and might reduce user confusion when the spell
check silently fails to work. Or maybe there's a better idea entirely. I don't
claim to have all the answers, I just think this merits attention.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101618] New: Android Viewer: calc returns to first sheet

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101618

Bug ID: 101618
   Summary: Android Viewer: calc returns to first sheet
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+
  Hardware: All
OS: Android
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Android Viewer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wthoony...@yahoo.com

When another sheet is selected via Parts in the menu, sometimes:
a) the sheet does not change (nothing happens after the new sheet is selected),
or
b) the new sheet doesn't finish rendering.  It remains blurry.

For (b), scrolling or zooming usually cause the rendering to complete. 
Sometimes, only partially.

When the screen is unlocked, or upon return to LO after using another app, calc
changes to the first sheet. With the position that was on screen with the prior
sheet. I expect it to keep the same screen view. That includes switching
sheets. If I see A1:F20 on sheet 1, then go to sheet 2 with T100:Z130 showing,
I expect to see A1:F20 again when I switch back to sheet 1. Instead, calc does
not seem to remember the view when leaving the sheet.

This was on a new Android 5.0.1 phone with a .xlsx file created by MSOffice
2013

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81234

--- Comment #20 from Miklos Vajna  ---
Does this bug have any additional benefits over the already existing filter:rtf
keyword? Sounds like a somewhat random selection of those was added as a
dependency to this one. I would like to close this one, and plan to just
monitor the result of the filter:rtf query instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 44986] FILEOPEN: Imported RTF - table cell/ row widths wrongly imported

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=44986

--- Comment #10 from Miklos Vajna  ---
I had a look at this again, this is still a problem even for docx, so probably
better to fix that first. In docx this is about the gridBefore/gridAfter
elements, gridBefore is handled by cf33af732ed0d3d553bb74636e3b14c55d44c153.
I'll look at extending that to also handle gridAfter. Once that's done,
something similar can be done in the rtf tokenizer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 93782] Add reversed line endings

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93782

Yan Pas  changed:

   What|Removed |Added

 Attachment #126640|0   |1
is obsolete||

--- Comment #15 from Yan Pas  ---
Created attachment 126913
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126913=edit
CF arrows and reversed one 3

I've reworked most of arrows, according to your notes. If I understood you
correctly, to close the path I need to enter z at the end of each path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 93782] Add reversed line endings

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93782

Yan Pas  changed:

   What|Removed |Added

 Attachment #126640|0   |1
is obsolete||

--- Comment #15 from Yan Pas  ---
Created attachment 126913
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126913=edit
CF arrows and reversed one 3

I've reworked most of arrows, according to your notes. If I understood you
correctly, to close the path I need to enter z at the end of each path.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101588] FORMATTING: Format Cells > Background > No Fill fails with non-continuous selection of colored cells

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101588

--- Comment #3 from Joseph Conner  ---
Confirmed on Ubuntu 16.04 LTS 64-bit. LibreOffice 5.2.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101609] All module settings should be accessible in the options dialog

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101609

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
And if was possible identify what are common and what are per file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101609] All module settings should be accessible in the options dialog

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101609

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
And if was possible identify what are common and what are per file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101617] New: alphabetical index is removed

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101617

Bug ID: 101617
   Summary: alphabetical index is removed
   Product: LibreOffice
   Version: 5.0.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wbkleinoe...@gmail.com

Created attachment 126912
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126912=edit
test file to reproduce problem

attached file "test doc 160819.odt") was created with libreOffice 5.1.5.
It contains one line and one entry to the alphabetical index.
Now I am adding one line with libreOffice 5.2.0.
The complete alphabetical index is removed from the file.

Problem happens with Mac OS X 10.11.6 and Windows 7.

Very easy to reproduce.
Major damage!
I would appreciate if you confirm this problem (wbkleinoe...@gmail.com)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - external_deps.lst LICENSE openssl/makefile.mk openssl/openssl-0.9.8zh-clang.patch openssl/openssllnx.patch openssl/opensslmacosx.patch openssl/open

2016-08-19 Thread Don Lewis 
 LICENSE |2 
 external_deps.lst   |6 
 openssl/makefile.mk |   42 
 openssl/openssl-0.9.8zh-clang.patch |   11 
 openssl/openssl.patch   |  170 -
 openssl/openssllnx.patch| 3823 
 openssl/opensslmacosx.patch | 3751 ---
 openssl/version.mk  |4 
 set_soenv.in|   11 
 9 files changed, 136 insertions(+), 7684 deletions(-)

New commits:
commit cd952b405afd18a7c938b5c92e2e99f1c895e3f0
Author: Don Lewis 
Date:   Fri Aug 19 18:28:06 2016 +

Update the bundled version of OpenSSL from 0.9.8zh to 1.0.2h which

fixes many vulnerabiliies and adds support for newer, more secure
ciphers and versions of the protocol.

Note: OpenSSL version 1.0.2h contains two known minor vulnerabilites,
CVE-2016-2177 and CVE-2016-2178, which will be fixed in the next
OpenSSL release.  Their potential impact is low enough that that
various Linux distros have chosen not to apply the upstream patches
to the versions that they distribute.

On Windows, there is an optional new dependency on NASM,
.  If NASM is not available, then the C
implementations of the low-level crypto code will be used instead
of the optimized assembly language versions.  Since OpenOffice is
not a heavy user of this code, the impact should be minor.  If NASM
is installed, but its location is not in $PATH, the directory
containing nasm.exe should be passed to configure using --with-nasm-home.

The fallback to the C crypto implementation also happens on Linux
if the version of gcc is sufficently old to indicate that the
toolchain is likely to not support the some of the instructions in
the assembly language versions of the code.

diff --git a/LICENSE b/LICENSE
index 47c911b..e724dd0 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1222,7 +1222,7 @@ OpenSSL License
 ---
 
 
-Copyright (c) 1998-2011 The OpenSSL Project.  All rights reserved.
+Copyright (c) 1998-2016 The OpenSSL Project.  All rights reserved.
 
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
diff --git a/external_deps.lst b/external_deps.lst
index 1123895..744f055 100644
--- a/external_deps.lst
+++ b/external_deps.lst
@@ -155,9 +155,9 @@ if (SOLAR_JAVA==TRUE && ENABLE_MEDIAWIKI==YES)
 URL2 = $(OOO_EXTRAS)$(MD5)-$(name)
 
 if (SYSTEM_OPENSSL!=YES && DISABLE_OPENSSL!=TRUE)
-MD5 = c813c065dd53d7bd0a560a870ddd0af5
-name = openssl-0.9.8zh.tar.gz
-URL1 = http://www.openssl.org/source/openssl-0.9.8zh.tar.gz
+MD5 = 9392e65072ce4b614c1392eefc1f23d0
+name = openssl-1.0.2h.tar.gz
+URL1 = http://www.openssl.org/source/openssl-1.0.2h.tar.gz
 URL2 = $(OOO_EXTRAS)$(MD5)-$(name)
 
 if ( true )
diff --git a/openssl/makefile.mk b/openssl/makefile.mk
index d67449e..6762f64 100644
--- a/openssl/makefile.mk
+++ b/openssl/makefile.mk
@@ -42,17 +42,17 @@ TARGET=openssl
 @echo "openssl disabled"
 .ENDIF
 
-OPENSSL_NAME=openssl-0.9.8zh
+OPENSSL_NAME=openssl-1.0.2h
 
 TARFILE_NAME=$(OPENSSL_NAME)
-TARFILE_MD5=c813c065dd53d7bd0a560a870ddd0af5
+TARFILE_MD5=9392e65072ce4b614c1392eefc1f23d0
 
 CONFIGURE_DIR=.
 CONFIGURE_ACTION=config
 CONFIGURE_FLAGS=-I$(SYSBASE)$/usr$/include -L$(SYSBASE)$/usr$/lib shared 
 
 BUILD_DIR=.
-BUILD_ACTION=make CC='$(CC)'
+BUILD_ACTION=make CC='$(CC)' build_libs
 
 OUT2LIB = libssl.*
 OUT2LIB += libcrypto.*
@@ -60,25 +60,32 @@ OUT2INC += include/openssl/*
 
 UNAME=$(shell uname)
 
+.IF "$(COM)"=="GCC" && "$(CCNUMVER)">="00040006" || "$(OS)"=="WNT" && 
"$(NASM_PATH)"=="NO_NASM_HOME"
+  NO_ASM="no-asm"
+.ELSE
+  NO_ASM=
+.ENDIF
+
 .IF "$(OS)" == "LINUX" || "$(OS)" == "FREEBSD"
 PATCH_FILES=openssllnx.patch
-ADDITIONAL_FILES:= \
-libcrypto_OOo_0_9_8zh.map \
-libssl_OOo_0_9_8zh.map
 .IF "$(CPU)" == "I"
 .IF "$(UNAME)" == "GNU/kFreeBSD"
-CONFIGURE_ACTION=Configure debian-kfreebsd-i386
+CONFIGURE_ACTION=Configure debian-kfreebsd-i386 no-dso no-shared 
$(NO_ASM)
+.ELIF "$(UNAME)" == "FreeBSD"
+CONFIGURE_ACTION=Configure BSD-x86-elf no-dso no-shared $(NO_ASM)
 .ELSE
-CONFIGURE_ACTION=Configure linux-elf
+CONFIGURE_ACTION=Configure linux-generic32 no-dso no-shared 
$(NO_ASM)
 .ENDIF
 .ELIF "$(BUILD64)" == "1"
 .IF "$(UNAME)" == "GNU/kFreeBSD"
-CONFIGURE_ACTION=Configure debian-kfreebsd-amd64
+CONFIGURE_ACTION=Configure debian-kfreebsd-amd64 no-dso no-shared 
$(NO_ASM)
+.ELIF "$(UNAME)" == "FreeBSD"
+CONFIGURE_ACTION=Configure BSD-x86_64 no-dso no-shared $(NO_ASM)
 .ELSE
-

[Libreoffice-bugs] [Bug 70425] EDITING: Embedded Firebird - Copying integer values from Calc to Base impossible

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=70425

--- Comment #9 from Lionel Elie Mamane  ---
(In reply to Julien Nabet from comment #8)
> With master sources updated today, I can't see tables.
> Indeed, I got this error:
> warn:connectivity.firebird:4258:1:connectivity/source/drivers/firebird/Util.
> cxx:52: firebird_sdbc error:
> *unsupported on-disk structure for file
> /tmp/lu21wdtc.tmp/lu21wdth.tmp/firebird.fdb; found 11.2, support 12.0
> caused by
> 'isc_attach_database'

That's because of the update to Firebird 3.0; I just documented that in 
https://wiki.documentfoundation.org/ReleaseNotes/5.3#Base

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75221] "Don't add space between paragraphs of the same style" also ignores line spacing

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75221

--- Comment #18 from Cor Nouws  ---
(In reply to Alexander Polkhovskiy from comment #17)
> That's it. Usually docs are formatted with 1.5x line spacing. I want to use
> this feature to add spacing after plain text before next header.
> For now, I use spacing before header, but it looks bad when u have two
> header following each other (e.g. H1 and H2, then plain text) - two spacings
> are combined. 

What about Options > Writer > compatibility > Add spacing between tables and
headers (current document) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71251] EDITING - Embedded Firebird - Creating table from default choices via wizard fails

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=71251

--- Comment #20 from Lionel Elie Mamane  ---
(In reply to Julien Nabet from comment #19)

> "Notes" VARCHAR(32767)

The maximum length of a VARCHAR in Firebird is 32,765. That's likely the
problem. What can we do about that?

 - The firebird-sdbc driver caps the length to 32765,
   even if the calling code asks for bigger.

 - We change the wizard to ask fro 32700 or 32000 or 32500,
   that is not to try to go to the extreme limit of what
   "most databases" support for VARCHAR (that is 32676)
   which will increase compatibility in general,
   not only for Firebird.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   Keywords||needsDevEval
 Status|REOPENED|NEW
Version|5.1.4.2 release |3.3.1 release

--- Comment #12 from Yousuf (Jay) Philips  ---
Hi Ziggy,

You can go into Tools > Customize > Keyboard and select the keyboard shortcut
and then select the Format category and select Highlight Fill and you'll be
able to assign the shortcut there. You can find full information here -
https://wiki.documentfoundation.org/images/b/bd/GS5014-CustomizingLibreOffice.pdf

There seems to be a bug in the assignment of the shortcut as it requires a user
to first use the Highlight Color (.uno:BackColor) toolbar button to color with
yellow before highlight fill (.uno:CharBackgroundExt) can be activated to work
with a color.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101616] European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101616

--- Comment #3 from Marco A.G.Pinto  ---
Tiago sent me the thesaurus a few hours ago for me to check and it seems a very
good work.

:-)

Minho University in Portugal has already been contacted hoping that in future
releases of the pt_PT speller OXT will also include this thesaurus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100202] FILEOPEN: Paragraph White Fill added to cell in DOCX import

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100202

Luke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Luke  ---
Justin Luth fixed this issue and the associated export issue in Bug 97090 with 

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a174c2f6fd58a31eb150b84de83e5ba1c4d3fed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101614] insert menu missing "ROW"

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101614

Ray Holme  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #3 from Ray Holme  ---
My prior look at the response did not shot the information about SHEET. I am
good and thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101614] insert menu missing "ROW"

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101614

Ray Holme  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|Documentation   |Calc
 Resolution|DUPLICATE   |---
 Ever confirmed|0   |1

--- Comment #2 from Ray Holme  ---
Someone closed this because it matches a recorded documentation bug.
Yes the tiny  part of this bug is that help did not work.

BUT THE REAL PROBLEM IS THAT I COULD NOT FIND HOW TO INSERT A ROW INTO A SPREAD
SHEET. THIS USED TO BE PART OF THE INSERT MENU.

I looked in a lot of menus (insert would be the natural one, but I looked
farther).

If I am unable to insert a row (or column) into a spread sheet, the tool's use
becomes negligible. I would need to use Microsoft to do work and import the
file to OpenOffice. I fear someone left something out of the menu somehow.

I changed the component from documentation (minor problem) to CALC (major
problem).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 70425] EDITING: Embedded Firebird - Copying integer values from Calc to Base impossible

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=70425

--- Comment #8 from Julien Nabet  ---
With master sources updated today, I can't see tables.
Indeed, I got this error:
warn:connectivity.firebird:4258:1:connectivity/source/drivers/firebird/Util.cxx:52:
firebird_sdbc error:
*unsupported on-disk structure for file
/tmp/lu21wdtc.tmp/lu21wdth.tmp/firebird.fdb; found 11.2, support 12.0
caused by
'isc_attach_database'

warn:legacy.osl:4258:1:svtools/source/uno/genericunodialog.cxx:314:
OGenericUnoDialog::OnDialogDying: where does this come from?
warn:connectivity.firebird:4258:1:connectivity/source/drivers/firebird/Util.cxx:52:
firebird_sdbc error:
*unsupported on-disk structure for file
/tmp/lu21wdtc.tmp/lu21wdti.tmp/firebird.fdb; found 11.2, support 12.0
caused by
'isc_attach_database'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101583] Range Name References Updated Incorrectly

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101583

--- Comment #6 from m.a.riosv  ---
Also in:
Version: 5.3.0.0.alpha0+ (x64)
Build ID: 327f5cc66f122979943d2c896eb1824791a854c9
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2016-08-18_00:02:16
Locale: es-ES (es_ES); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101583] Range Name References Updated Incorrectly

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101583

m.a.riosv  changed:

   What|Removed |Added

   Keywords||regression
 Status|REOPENED|NEW
Version|5.2.0.4 release |5.0.6.2 rc

--- Comment #5 from m.a.riosv  ---
Hi @GerardF I don't think the same matter.

It begins with
Win10x64
Version: 5.0.6.2 (x64)
Build ID: b3fbfa99158a1030fb79f0ba72b6851afc3c7895-GL

last working for me:
Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600

Looks like a regression from 4.4 to 5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101616] European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101616

--- Comment #2 from Tiago Santos  ---
*** Bug 101615 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101615] European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101615

Tiago Santos  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Tiago Santos  ---


*** This bug has been marked as a duplicate of bug 101616 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101616] European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101616

--- Comment #1 from Tiago Santos  ---
Created attachment 126911
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126911=edit
European Portuguese Thesaurus Update

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71251] EDITING - Embedded Firebird - Creating table from default choices via wizard fails

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=71251

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #19 from Julien Nabet  ---
With master sources updated today, I had another error:
warn:connectivity.firebird:4079:1:connectivity/source/drivers/firebird/Statement.cxx:126:
isc_dsql_execute failed
warn:connectivity.firebird:4079:1:connectivity/source/drivers/firebird/Util.cxx:52:
firebird_sdbc error:
*unsuccessful metadata update
*CREATE TABLE Invoices failed
*Dynamic SQL Error
*SQL error code = -204
*Data type unknown
*Implementation limit exceeded
*COLUMN 
caused by
'CREATE TABLE "Invoices" ("ID" INTEGER GENERATED BY DEFAULT AS IDENTITY,"Notes"
VARCHAR(32767),"Status" VARCHAR(50),"ShipDate" DATE,"InvoiceID"
INTEGER,"ShippedTo" VARCHAR(50),"CustomerID" INTEGER,"DeliveryID"
INTEGER,"EmployeeID" INTEGER,"ShippedVia" VARCHAR(50),"InvoiceDate"
DATE,"Salesperson" VARCHAR(50),"ShippingCost" DOUBLE PRECISION, PRIMARY KEY 
("ID"))'

There's a pop with a stacktrace but I can't retrieve its content.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101616] New: European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101616

Bug ID: 101616
   Summary: European Portuguese Thesaurus Update
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tiagofsanto...@sapo.pt
CC: marcoagpi...@mail.telepac.pt

In attachment I submit a proposal for new European Portuguese thesaurus based
on a merge of the existing OpenThesaurus base and project PAPEL
(http://www.linguateca.pt/PAPEL/). It was also submitted today to the team
responsible for former dictionary maintenance from Universidade do Minho, for
inclusion in their extension.
This thesaurus nearly quadruples the amount of words recognized by the former
thesaurus, with the level of quality, at least, equivalent to the one provided
by OpenThesaurus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101615] New: European Portuguese Thesaurus Update

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101615

Bug ID: 101615
   Summary: European Portuguese Thesaurus Update
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Linguistic
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tiagofsanto...@sapo.pt
CC: marcoagpi...@mail.telepac.pt

Created attachment 126910
  --> https://bugs.documentfoundation.org/attachment.cgi?id=126910=edit
Thesaurus files (possible localition /share/extensions/dict-pt-PT)

In attachment I submit a proposal for new European Portuguese thesaurus based
on a merge of the existing OpenThesaurus base and project PAPEL
(http://www.linguateca.pt/PAPEL/). It was also submitted today to the team
responsible for former dictionary maintenance from Universidade do Minho, for
inclusion in their extension.
This thesaurus nearly quadruples the amount of words recognized by the former
thesaurus, with the level of quality, at least, equivalent to the one provided
by OpenThesaurus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97954] Spell checker manual corrections of misplaced punctuation freeze

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97954

--- Comment #3 from David W Johnson  ---
Haven't had this bug since the upgrade. Currently on 5.1.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97241] Move to more natural French translation for Pivot Table

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97241

--- Comment #9 from Milan Bouchet-Valat  ---
(In reply to Alex Thurgood from comment #8)
> I'm trying to leave a positive comment without being alarmist, but
> unfortunately can't think of one, so I'll leave it at that.
What do you mean? Do you think it's a problem that the English version of LO
currently uses "Pivot Table" (even if with a space between the two words)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100567] assertion at vcl/builder.hxx:399

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100567

Terrence Enger  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Terrence Enger  ---
I am setting status RESOLVED WORKSFORME, as I see no problem in daily
build from 2016-08-09 or in a recent version in the Win daily dbgutil
repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/inc vcl/source

2016-08-19 Thread rpmbuild 
 vcl/inc/helpwin.hxx |1 +
 vcl/source/app/help.cxx |   11 +++
 2 files changed, 12 insertions(+)

New commits:
commit b04f4b4ba6768be8032ac0a43f55c11b037d43d4
Author: rpmbuild 
Date:   Mon Aug 15 15:17:11 2016 +0100

Resolves: tdf#91533 (rhbz#1364335) Tooltips are truncated

Change-Id: Id9ec91ed9652f491e4e2a0556eeed27bf6517002
(cherry picked from commit e527edf06f8befb45b76ee8ebabe62e6dc885e45)
Reviewed-on: https://gerrit.libreoffice.org/28219
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/vcl/inc/helpwin.hxx b/vcl/inc/helpwin.hxx
index e7cc81a..3864575 100644
--- a/vcl/inc/helpwin.hxx
+++ b/vcl/inc/helpwin.hxx
@@ -47,6 +47,7 @@ private:
 virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle&) 
override;
 virtual void RequestHelp( const HelpEvent& rHEvt ) override;
 virtual void ApplySettings(vcl::RenderContext& rRenderContext) override;
+virtual void StateChanged(StateChangedType nType) override;
 
 virtual OUString GetText() const override;
 void ImplShow();
diff --git a/vcl/source/app/help.cxx b/vcl/source/app/help.cxx
index 9b72256..0ebf141 100644
--- a/vcl/source/app/help.cxx
+++ b/vcl/source/app/help.cxx
@@ -277,6 +277,17 @@ HelpTextWindow::HelpTextWindow( vcl::Window* pParent, 
const OUString& rText, sal
 maHideTimer.SetTimeout( rHelpSettings.GetTipTimeout() );
 }
 
+void HelpTextWindow::StateChanged(StateChangedType nType)
+{
+FloatingWindow::StateChanged(nType);
+if (nType == StateChangedType::InitShow)
+{
+ApplySettings(*this);
+SetHelpText(maHelpText);
+Invalidate();
+}
+}
+
 void HelpTextWindow::ApplySettings(vcl::RenderContext& rRenderContext)
 {
 const StyleSettings& rStyleSettings = 
rRenderContext.GetSettings().GetStyleSettings();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94834] gnumeric import not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=94834

Pedro  changed:

   What|Removed |Added

 CC||pedl...@gmail.com

--- Comment #13 from Pedro  ---
Bug confirmed using v5.2.1.1, v5.1.5.2 and v5.1.0.3 (current and first release
in the 5.1 branch) under Windows 7 Pro x64 SP1

Confirmed with the provided file and any of my .gnumeric files.

This featured announced in the 5.1 release never worked under the Windows OS

Opening with File Open or drag-and-drop always results in a XML view in Writer
and opening as a Gnumeric file always results in "General Error. General
input/output error."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2016-08-19 Thread Thorsten Behrens 
 configure.ac |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 170105956f843047d4c79657584f0c01aa7814c7
Author: Thorsten Behrens 
Date:   Fri Aug 19 18:40:30 2016 +0200

configure.ac: configure-generated files sit in BUILDDIR

Change-Id: I2e5515063189596aaa7438197c0c9d8897e938e9

diff --git a/configure.ac b/configure.ac
index debeebd..07e3e4d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7320,7 +7320,7 @@ if test "$with_export_validation" = yes; then
 # remember to download the ODF toolkit with validator later
 AC_MSG_NOTICE([no odfvalidator found, will download it])
 BUILD_TYPE="$BUILD_TYPE ODFVALIDATOR"
-ODFVALIDATOR="$SRC_ROOT/bin/odfvalidator.sh"
+ODFVALIDATOR="$BUILDDIR/bin/odfvalidator.sh"
 
 # and fetch name of odfvalidator jar name from download.lst
 ODFVALIDATOR_JAR=`$SED -n -e "s/export *ODFVALIDATOR_JAR *:= 
*\(.*\) */\1/p" $SRC_ROOT/download.lst`
@@ -7347,7 +7347,7 @@ if test "$with_export_validation" = yes; then
 # remember to download the officeotron with validator later
 AC_MSG_NOTICE([no officeotron found, will download it])
 BUILD_TYPE="$BUILD_TYPE OFFICEOTRON"
-OFFICEOTRON="$SRC_ROOT/bin/officeotron.sh"
+OFFICEOTRON="$BUILDDIR/bin/officeotron.sh"
 
 # and fetch name of officeotron jar name from download.lst
 OFFICEOTRON_JAR=`$SED -n -e "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
@@ -7404,7 +7404,7 @@ if test "$with_bffvalidator" != "no"; then
 
 # so swap in a shell wrapper that converts paths transparently
 BFFVALIDATOR_EXE="$BFFVALIDATOR"
-BFFVALIDATOR="sh $SRC_ROOT/bin/bffvalidator.sh"
+BFFVALIDATOR="sh $BUILDDIR/bin/bffvalidator.sh"
 AC_SUBST(BFFVALIDATOR_EXE)
 AC_MSG_RESULT($BFFVALIDATOR)
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99402] FORMATTING_Black question mark for Mathtype symbols (Brackets)

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=99402

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0629

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100629] [FILEOPEN]: view of formula from files .doc imports not correctly

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100629

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||402

--- Comment #7 from Aron Budea  ---
Seems to be very similar to bug 99402. Regression introduced with the same
release, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source include/basic

2016-08-19 Thread Caolán McNamara 
 basic/source/runtime/dllmgr-x64.cxx |2 +-
 basic/source/runtime/dllmgr-x86.cxx |2 +-
 include/basic/sbxvar.hxx|2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 4a647a04a7881964ce13b541399f89e4ab042ea8
Author: Caolán McNamara 
Date:   Fri Aug 19 16:46:42 2016 +0100

Resolves: tdf#88953 byref args incorrectly passed in basic->c++

partial revert

of

commit 22b094f5d8e1e82375b135abd3a6f99a9a555244
Date:   Tue Jul 14 14:50:07 2015 +0200

loplugin:unusedmethods basic

and partial revert of...

commit e2080e70fe8b085f18e868e46340454720fa94ca
Date:   Wed Jun 18 12:14:29 2014 +0200

new compilerplugin returnbyref

and revert of...

commit 536051f8862203e0e115a5394a6379acd83cc8fe
Date:   Wed Jul 15 14:04:01 2015 +0200

fix Windows build

after commit 22b094f5d8e1e82375b135abd3a6f99a9a555244
"loplugin:unusedmethods basic"

Change-Id: I612937334fdb75365080c98a9d4da5ed7ae647e3

diff --git a/basic/source/runtime/dllmgr-x64.cxx 
b/basic/source/runtime/dllmgr-x64.cxx
index 11a514b..b78ff5d 100644
--- a/basic/source/runtime/dllmgr-x64.cxx
+++ b/basic/source/runtime/dllmgr-x64.cxx
@@ -315,7 +315,7 @@ SbError marshal(
 case SbxDOUBLE:
 case SbxBOOL:
 case SbxBYTE:
-add(blob, variable->GetValues_Impl(), 8, offset);
+add(blob, variable->data(), 8, offset);
 break;
 case SbxSTRING:
 {
diff --git a/basic/source/runtime/dllmgr-x86.cxx 
b/basic/source/runtime/dllmgr-x86.cxx
index bd8c5be..fd41317 100644
--- a/basic/source/runtime/dllmgr-x86.cxx
+++ b/basic/source/runtime/dllmgr-x86.cxx
@@ -330,7 +330,7 @@ SbError marshal(
 case SbxDOUBLE:
 case SbxBOOL:
 case SbxBYTE:
-add(blob, variable->GetValues_Impl(), 4, offset);
+add(blob, variable->data(), 4, offset);
 break;
 case SbxSTRING:
 {
diff --git a/include/basic/sbxvar.hxx b/include/basic/sbxvar.hxx
index 25ac260..c90e98b 100644
--- a/include/basic/sbxvar.hxx
+++ b/include/basic/sbxvar.hxx
@@ -119,6 +119,8 @@ public:
 const SbxValues& GetValues_Impl() const { return aData; }
 bool Put( const SbxValues& );
 
+SbxValues * data() { return  }
+
 sal_Unicode GetChar() const;
 sal_Int16   GetInteger() const;
 sal_Int32   GetLong() const;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 88953] GetExitCodeProcess call crashes Calc 4.4.0 but not 4.3.5, 4.3.4 or earlier

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88953

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 10 commits - configure.ac external/harfbuzz vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/README.vars vcl/source vcl/unx vcl

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 566a458af57f20bead84de7daf6b56b620345c32
Author: Akash Jain 
Date:   Wed Aug 17 21:31:22 2016 +0530

GSoC: Speed up CommonSalLayout by caching hb_face

Cache hb_face so it is not created again and again.
Switch from GDI to DirectWrite on Windows to obtain SFNT table data.

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..90aa84b 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
@@ -58,7 +59,6 @@ public:
 const ServerFont&   getFontData() const { return mrServerFont; };
 #endif
 
-virtual ~CommonSalLayout();
 voidSetNeedFallback(ImplLayoutArgs&, sal_Int32, bool);
 voidAdjustLayout(ImplLayoutArgs&) override;
 virtual boolLayoutText(ImplLayoutArgs&) override;
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 04723cb..1c356c5 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -35,6 +35,7 @@
 #include 
 #include "fontattributes.hxx"
 #include "impfontmetricdata.hxx"
+#include "hb-ot.h"
 
 #include 
 
@@ -181,6 +182,8 @@ public:
 sal_GlyphId FixupGlyphIndex( sal_GlyphId aGlyphId, sal_UCS4 ) 
const;
 boolGetGlyphOutline( sal_GlyphId aGlyphId, 
basegfx::B2DPolyPolygon& ) const;
 boolGetAntialiasAdvice() const;
+hb_face_t*  GetHBFace() { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) { 
mpHBFace=pHBFace; }
 
 private:
 friend class GlyphCache;
@@ -240,6 +243,7 @@ private:
 GlyphSubstitution   maGlyphSubstitution;
 
 ServerFontLayoutEngine* mpLayoutEngine;
+hb_face_t*  mpHBFace;
 };
 
 // a class for cache entries for physical font instances that are based on 
serverfonts
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { mpHBFace = 
pHBFace; }
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
@@ -354,6 +359,7 @@ private:
 sal_uLong   GetKernPairs();
 
 public:
+sal_uLong   GetTable( const char pTagName[5], const unsigned 
char*&, void*&, IDWriteFontFace*& );
 // public SalGraphics methods, the interface to the independent vcl part
 
 // get device resolution
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++

[Libreoffice-bugs] [Bug 101607] LO Writer Losing saved files

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101607

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #1 from Aron Budea  ---
Have you tried after resetting your user profile, as described here?
https://wiki.documentfoundation.org/UserProfile#Resolving_corruption_in_the_user_profile

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97241] Move to more natural French translation for Pivot Table

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97241

--- Comment #8 from Alex Thurgood  ---
(In reply to Milan Bouchet-Valat from comment #7)
> AFAICT there are no trademark results for "tableau croisé" or "tableau
> croisé dynamique", so there should be no problem in French.

I'm trying to leave a positive comment without being alarmist, but
unfortunately can't think of one, so I'll leave it at that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58038] FORMATTING: Format text toolbar commands are not working in chart titles nor text boxes drawn *inside* charts with the draw bar

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=58038

Francisco  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo

--- Comment #10 from Francisco  ---
It's been like this since before the existence if LibO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 58038] FORMATTING: Format text toolbar commands are not working in chart titles nor text boxes drawn *inside* charts with the draw bar

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=58038

Francisco  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo

--- Comment #10 from Francisco  ---
It's been like this since before the existence if LibO.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - 5 commits - desktop/qa desktop/source include/LibreOfficeKit include/sfx2 libreofficekit/qa libreofficekit/source sfx2/source sw/inc

2016-08-19 Thread Miklos Vajna 
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   38 
 desktop/source/lib/init.cxx |7 ++-
 include/LibreOfficeKit/LibreOfficeKitEnums.h|   25 +++
 include/sfx2/viewsh.hxx |4 +
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |   19 +++-
 libreofficekit/source/gtk/lokdocview.cxx|6 ++
 sfx2/source/control/unoctitm.cxx|3 -
 sfx2/source/view/viewimp.hxx|2 
 sfx2/source/view/viewsh.cxx |   14 ++
 sw/inc/unoprnms.hxx |1 
 sw/inc/viewsh.hxx   |2 
 sw/qa/extras/tiledrendering/tiledrendering.cxx  |   32 +-
 sw/source/core/doc/DocumentRedlineManager.cxx   |8 +--
 sw/source/core/doc/docredln.cxx |   45 
 sw/source/core/inc/unoport.hxx  |3 +
 sw/source/core/unocore/unomapproperties.hxx |1 
 sw/source/core/unocore/unoredline.cxx   |   18 +---
 sw/source/core/view/viewsh.cxx  |4 -
 sw/source/core/view/vnew.cxx|2 
 sw/source/uibase/uiview/view2.cxx   |8 +++
 20 files changed, 220 insertions(+), 22 deletions(-)

New commits:
commit a0c66852c3da76674510e8559e102bcc1efd0676
Author: Miklos Vajna 
Date:   Fri Aug 19 16:46:15 2016 +0200

sw redlines: expose description as part of the UNO/LOK API

A redline can have a manual comment and also an autogenerated
description, like "Insert 'abc'". Expose this later property as well, as
it provides useful additional information, especially when the comment
property is empty.

Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
(cherry picked from commit 9e310a4705ce956551059040696166aefb2388cb)

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index ffacd4c..d715329 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1203,6 +1203,10 @@ void DesktopLOKTest::testRedlineWriter()
 // Make sure that pressing a key creates exactly one redline.
 CPPUNIT_ASSERT_EQUAL(static_cast(1), 
aTree.get_child("redlines").size());
 
+for (boost::property_tree::ptree::value_type& rRedline : 
aTree.get_child("redlines"))
+// This failed with boost::property_tree::ptree_bad_path, as there 
were no description field.
+CPPUNIT_ASSERT_EQUAL(std::string("Insert 't'"), 
rRedline.second.get("description"));
+
 comphelper::LibreOfficeKit::setActive(false);
 }
 
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 0a9f2b2..b18e4d6 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1858,6 +1858,10 @@ static char* getTrackedChanges(LibreOfficeKitDocument* 
pThis)
 xRedline->getPropertyValue("RedlineComment") >>= sComment;
 aRedline.put("comment", sComment.toUtf8().getStr());
 
+OUString sDescription;
+xRedline->getPropertyValue("RedlineDescription") >>= sDescription;
+aRedline.put("description", sDescription.toUtf8().getStr());
+
 util::DateTime aDateTime;
 xRedline->getPropertyValue("RedlineDateTime") >>= aDateTime;
 OUString sDateTime = utl::toISO8601(aDateTime);
diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 2c3bcab..0805e62 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -417,6 +417,7 @@ typedef enum
  * "author": "Unknown Author",
  * "type": "Delete",
  * "comment": "",
+ * "description": "Delete 'abc'",
  * "dateTime": "2016-08-18T12:14:00"
  * }
  * }
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 1d77918..a1833d2 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -485,7 +485,7 @@ static void documentRedline(GtkWidget* pButton, gpointer 
/*pItem*/)
 GtkWidget* pContentArea = gtk_dialog_get_content_area(GTK_DIALOG 
(pDialog));
 
 // Build the table.
-GtkTreeStore* pTreeStore = gtk_tree_store_new(5, G_TYPE_INT, 
G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING);
+GtkTreeStore* pTreeStore = gtk_tree_store_new(6, G_TYPE_INT, 
G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING);
 for (const auto& rValue : aTree.get_child("redlines"))
 {
 GtkTreeIter aTreeIter;
@@ -495,11 +495,12 @@ static void documentRedline(GtkWidget* pButton, gpointer 
/*pItem*/)
1, rValue.second.get("author").c_str(),

[Libreoffice-commits] core.git: sfx2/classification

2016-08-19 Thread Cor Nouws 
 sfx2/classification/example_nl-NL.xml |   38 +-
 1 file changed, 19 insertions(+), 19 deletions(-)

New commits:
commit b6df81b609f5cc9e7cc3080ed86e0433188bf097
Author: Cor Nouws 
Date:   Fri Aug 19 15:25:53 2016 +0200

Dutch example.xml classification: Corrections - tdf#100352

Change-Id: I67812ad38e29f774e84f7685fc95c0579d718cbd
Reviewed-on: https://gerrit.libreoffice.org/28241
Tested-by: Jenkins 
Reviewed-by: Miklos Vajna 

diff --git a/sfx2/classification/example_nl-NL.xml 
b/sfx2/classification/example_nl-NL.xml
index f00e494..7afc170 100644
--- a/sfx2/classification/example_nl-NL.xml
+++ b/sfx2/classification/example_nl-NL.xml
@@ -1,23 +1,23 @@
 
 
-TSCP Example Policy 
Authority
-TSCP Voorbeeld Policy
+Voorbeeld beleidsauthoriteit 
TSCP
+Voorbeeld beleid TSCP
 
 urn:example:tscp:1
 
 
-
+
 
 
 UK-Cabinet
 0
 
 
-
+
 
 
-Document: Koptekst
-Classificatie: Bedrijfsvertrouwelijk
+Document: Header
+Classificatie: Algemeen 
bedrijfsvoering
 
 
 
@@ -25,18 +25,18 @@
 1
 
 
-
+
 
 
-Document: Koptekst
-Classificatie: Bedrijfsvertrouwelijk
+Document: Header
+Classificatie: Vertrouwelijk
 
 
-Document: Voettekst
-De inhoud van dit document is vertrouwelijk. 
Verspreid het niet extern zonder de vereiste goedkeuring.
+Document: Footer
+De inhoud van dit document is vertrouwelijk. 
Verspreid het uitsluitend met de vereiste toestemming.
 
 
-Document: Watermerk
+Document: Watermark
 Vertrouwelijk
 
 
@@ -45,19 +45,19 @@
 2
 
 
-
+
 
 
-Document: Koptekst
-Classificatie: Vertrouwelijk
+Document: Header
+Classificatie: Intern
 
 
-Document: Voettekst
-De inhoud van dit document is uitsluitend voor 
intern gebruik. Verspreid het niet extern zonder de vereiste 
goedkeuring.
+Document: Footer
+De inhoud van dit document is uitsluitend voor 
intern gebruik. Verspreid het niet buiten de organisatie.
 
 
-Document: Watermerk
-Vertrouwelijk
+Document: Watermark
+Intern
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 39052] FORMATTING single characters in titles, axis titles and other labels in charts is not possible

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=39052

Laurent BP  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=58
   ||038

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 58038] FORMATTING: Format text toolbar commands are not working in chart titles nor text boxes drawn *inside* charts with the draw bar

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=58038

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=39
   ||052

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 58038] FORMATTING: Format text toolbar commands are not working in chart titles nor text boxes drawn *inside* charts with the draw bar

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=58038

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=39
   ||052

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78027] FILEOPEN: Importing of Excel files with non-uniform formated diagram title

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=78027
Bug 78027 depends on bug 78025, which changed state.

Bug 78025 Summary: FORMATTING: Title formating has to be uniform in diagrams
https://bugs.documentfoundation.org/show_bug.cgi?id=78025

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39052] FORMATTING single characters in titles, axis titles and other labels in charts is not possible

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=39052

Laurent BP  changed:

   What|Removed |Added

 CC||kant...@sra.uni-hannover.de

--- Comment #34 from Laurent BP  ---
*** Bug 78025 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78025] FORMATTING: Title formating has to be uniform in diagrams

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=78025

Laurent BP  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jumbo4...@yahoo.fr
 Resolution|--- |DUPLICATE

--- Comment #3 from Laurent BP  ---


*** This bug has been marked as a duplicate of bug 39052 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91744] Macro failure when adding rows with named range scope restricted to the sheet

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91744

Alex Thurgood  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Alex Thurgood  ---
@David : thanks for your reply. In view of your comments, I'm going to set this
as a DUP of bug 93127

*** This bug has been marked as a duplicate of bug 93127 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 10 commits - configure.ac external/harfbuzz vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/README.vars vcl/source vcl/unx vcl

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit d9fc8e39c5456b6cbc1b4e643f58606ea2d82a7c
Author: Akash Jain 
Date:   Wed Aug 17 21:31:22 2016 +0530

GSoC: Speed up CommonSalLayout by caching hb_face

Cache hb_face so it is not created again and again.
Switch from GDI to DirectWrite on Windows to obtain SFNT table data.

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..90aa84b 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
@@ -58,7 +59,6 @@ public:
 const ServerFont&   getFontData() const { return mrServerFont; };
 #endif
 
-virtual ~CommonSalLayout();
 voidSetNeedFallback(ImplLayoutArgs&, sal_Int32, bool);
 voidAdjustLayout(ImplLayoutArgs&) override;
 virtual boolLayoutText(ImplLayoutArgs&) override;
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 04723cb..1c356c5 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -35,6 +35,7 @@
 #include 
 #include "fontattributes.hxx"
 #include "impfontmetricdata.hxx"
+#include "hb-ot.h"
 
 #include 
 
@@ -181,6 +182,8 @@ public:
 sal_GlyphId FixupGlyphIndex( sal_GlyphId aGlyphId, sal_UCS4 ) 
const;
 boolGetGlyphOutline( sal_GlyphId aGlyphId, 
basegfx::B2DPolyPolygon& ) const;
 boolGetAntialiasAdvice() const;
+hb_face_t*  GetHBFace() { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) { 
mpHBFace=pHBFace; }
 
 private:
 friend class GlyphCache;
@@ -240,6 +243,7 @@ private:
 GlyphSubstitution   maGlyphSubstitution;
 
 ServerFontLayoutEngine* mpLayoutEngine;
+hb_face_t*  mpHBFace;
 };
 
 // a class for cache entries for physical font instances that are based on 
serverfonts
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { mpHBFace = 
pHBFace; }
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
@@ -354,6 +359,7 @@ private:
 sal_uLong   GetKernPairs();
 
 public:
+sal_uLong   GetTable( const char pTagName[5], const unsigned 
char*&, void*&, IDWriteFontFace*& );
 // public SalGraphics methods, the interface to the independent vcl part
 
 // get device resolution
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++

[Libreoffice-commits] core.git: desktop/qa desktop/source include/LibreOfficeKit libreofficekit/qa sw/inc sw/source

2016-08-19 Thread Miklos Vajna 
 desktop/qa/desktop_lib/test_desktop_lib.cxx |4 
 desktop/source/lib/init.cxx |4 
 include/LibreOfficeKit/LibreOfficeKitEnums.h|1 +
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |7 ---
 sw/inc/unoprnms.hxx |1 +
 sw/source/core/doc/docredln.cxx |2 ++
 sw/source/core/unocore/unomapproperties.hxx |1 +
 sw/source/core/unocore/unoredline.cxx   |   10 +-
 8 files changed, 26 insertions(+), 4 deletions(-)

New commits:
commit 9e310a4705ce956551059040696166aefb2388cb
Author: Miklos Vajna 
Date:   Fri Aug 19 16:46:15 2016 +0200

sw redlines: expose description as part of the UNO/LOK API

A redline can have a manual comment and also an autogenerated
description, like "Insert 'abc'". Expose this later property as well, as
it provides useful additional information, especially when the comment
property is empty.

Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index b356535..d3888ff 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1434,6 +1434,10 @@ void DesktopLOKTest::testRedlineWriter()
 // Make sure that pressing a key creates exactly one redline.
 CPPUNIT_ASSERT_EQUAL(static_cast(1), 
aTree.get_child("redlines").size());
 
+for (boost::property_tree::ptree::value_type& rRedline : 
aTree.get_child("redlines"))
+// This failed with boost::property_tree::ptree_bad_path, as there 
were no description field.
+CPPUNIT_ASSERT_EQUAL(std::string("Insert 't'"), 
rRedline.second.get("description"));
+
 comphelper::LibreOfficeKit::setActive(false);
 }
 
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index dfad9b2..79129d7 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1843,6 +1843,10 @@ static char* getTrackedChanges(LibreOfficeKitDocument* 
pThis)
 xRedline->getPropertyValue("RedlineComment") >>= sComment;
 aRedline.put("comment", sComment.toUtf8().getStr());
 
+OUString sDescription;
+xRedline->getPropertyValue("RedlineDescription") >>= sDescription;
+aRedline.put("description", sDescription.toUtf8().getStr());
+
 util::DateTime aDateTime;
 xRedline->getPropertyValue("RedlineDateTime") >>= aDateTime;
 OUString sDateTime = utl::toISO8601(aDateTime);
diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 2c3bcab..0805e62 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -417,6 +417,7 @@ typedef enum
  * "author": "Unknown Author",
  * "type": "Delete",
  * "comment": "",
+ * "description": "Delete 'abc'",
  * "dateTime": "2016-08-18T12:14:00"
  * }
  * }
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index 5a134d0..9bfaa85 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -485,7 +485,7 @@ static void documentRedline(GtkWidget* pButton, gpointer 
/*pItem*/)
 GtkWidget* pContentArea = gtk_dialog_get_content_area(GTK_DIALOG 
(pDialog));
 
 // Build the table.
-GtkTreeStore* pTreeStore = gtk_tree_store_new(5, G_TYPE_INT, 
G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING);
+GtkTreeStore* pTreeStore = gtk_tree_store_new(6, G_TYPE_INT, 
G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING);
 for (const auto& rValue : aTree.get_child("redlines"))
 {
 GtkTreeIter aTreeIter;
@@ -495,11 +495,12 @@ static void documentRedline(GtkWidget* pButton, gpointer 
/*pItem*/)
1, rValue.second.get("author").c_str(),
2, rValue.second.get("type").c_str(),
3, 
rValue.second.get("comment").c_str(),
-   4, 
rValue.second.get("dateTime").c_str(),
+   4, 
rValue.second.get("description").c_str(),
+   5, 
rValue.second.get("dateTime").c_str(),
-1);
 }
 GtkWidget* pTreeView = 
gtk_tree_view_new_with_model(GTK_TREE_MODEL(pTreeStore));
-std::vector aColumns = {"Index", "Author", "Type", "Comment", 
"Timestamp"};
+std::vector aColumns = {"Index", "Author", "Type", "Comment", 
"Description", "Timestamp"};
 for (size_t nColumn = 0; nColumn < aColumns.size(); ++nColumn)
 {
 GtkCellRenderer* pRenderer = gtk_cell_renderer_text_new();
diff --git a/sw/inc/unoprnms.hxx b/sw/inc/unoprnms.hxx
index 0d1322d..c4020c5 100644

[Libreoffice-bugs] [Bug 74880] [Memory leak] LibreOffice crashing when importing data from 8+ ods files, but doesn' t crash on same xls files

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=74880

--- Comment #11 from Mikeyy - L10n HR  ---
(In reply to Caolán McNamara from comment #10)
> I went to look at this problem today, but the original reproducer zip seems
> to be gone. Is there another copy of this anywhere, or another route to
> reproduce ?

Luckily, I keept ZIP stored somewhere.
Won't share link here since it's my private cloud, but sent you copy via
e-mail.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62728] Support for PDF/A-2 (ISO 19005-2:2011)

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=62728

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #3 from Cor Nouws  ---
Support for PDF A-2 is mandatory in The Netherlands

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source connectivity/source include/connectivity include/oox include/ucbhelper include/vcl oox/inc oox/source scripting/source sfx2/source ucbhelper/source ucb/sou

2016-08-19 Thread Stephan Bergmann 
 basic/source/runtime/runtime.cxx |2 +-
 connectivity/source/commontools/dbcharset.cxx|2 +-
 include/connectivity/dbcharset.hxx   |2 +-
 include/oox/core/fragmenthandler.hxx |2 +-
 include/oox/drawingml/shapecontext.hxx   |2 +-
 include/oox/drawingml/shapegroupcontext.hxx  |2 +-
 include/oox/export/vmlexport.hxx |2 +-
 include/oox/ppt/slidemastertextstylescontext.hxx |2 +-
 include/oox/ppt/slidepersist.hxx |2 +-
 include/ucbhelper/std_inputstream.hxx|2 +-
 include/ucbhelper/std_outputstream.hxx   |2 +-
 include/vcl/fontcharmap.hxx  |2 +-
 oox/inc/drawingml/textbodycontext.hxx|2 +-
 oox/source/core/fragmenthandler.cxx  |2 +-
 oox/source/drawingml/shapecontext.cxx|2 +-
 oox/source/drawingml/shapegroupcontext.cxx   |2 +-
 oox/source/drawingml/textbodycontext.cxx |2 +-
 oox/source/export/vmlexport.cxx  |2 +-
 oox/source/ppt/extdrawingfragmenthandler.cxx |4 ++--
 oox/source/ppt/extdrawingfragmenthandler.hxx |4 ++--
 oox/source/ppt/slidemastertextstylescontext.cxx  |2 +-
 oox/source/ppt/slidepersist.cxx  |2 +-
 oox/source/shape/ShapeDrawingFragmentHandler.cxx |2 +-
 oox/source/shape/ShapeDrawingFragmentHandler.hxx |2 +-
 scripting/source/basprov/basscript.cxx   |4 ++--
 scripting/source/basprov/basscript.hxx   |4 ++--
 sfx2/source/dialog/filtergrouping.cxx|2 +-
 ucb/source/ucp/cmis/cmis_content.cxx |2 +-
 ucb/source/ucp/cmis/cmis_content.hxx |2 +-
 ucb/source/ucp/cmis/cmis_repo_content.cxx|2 +-
 ucb/source/ucp/cmis/cmis_repo_content.hxx|2 +-
 ucbhelper/source/provider/std_inputstream.cxx|2 +-
 ucbhelper/source/provider/std_outputstream.cxx   |2 +-
 unotools/source/ucbhelper/ucblockbytes.cxx   |2 +-
 vbahelper/source/vbahelper/vbacommandbar.cxx |2 +-
 vbahelper/source/vbahelper/vbacommandbar.hxx |2 +-
 vbahelper/source/vbahelper/vbacommandbarcontrols.cxx |2 +-
 vbahelper/source/vbahelper/vbacommandbarcontrols.hxx |2 +-
 vcl/source/font/fontcharmap.cxx  |2 +-
 39 files changed, 43 insertions(+), 43 deletions(-)

New commits:
commit 8f30da6386fa414b9fe4c704b294a978df77347b
Author: Stephan Bergmann 
Date:   Fri Aug 19 16:55:06 2016 +0200

Some clang-tidy misc-move-constructor-init

...by turning the relevant ctor parameters into "const &".

Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc

diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index fb8b79b..4f3fd37 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -115,7 +115,7 @@ struct SbiArgv {   // Argv stack:
 SbxArrayRefrefArgv; // Argv
 short nArgc;// Argc
 
-SbiArgv(SbxArrayRef refArgv_, short nArgc_) :
+SbiArgv(SbxArrayRef const & refArgv_, short nArgc_) :
 refArgv(refArgv_),
 nArgc(nArgc_) {}
 };
diff --git a/connectivity/source/commontools/dbcharset.cxx 
b/connectivity/source/commontools/dbcharset.cxx
index 78529a6..48a7c68 100644
--- a/connectivity/source/commontools/dbcharset.cxx
+++ b/connectivity/source/commontools/dbcharset.cxx
@@ -135,7 +135,7 @@ namespace dbtools
 {
 }
 
-OCharsetMap::CharsetIterator::CharsetIterator(const OCharsetMap* 
_pContainer, OCharsetMap::TextEncBag::const_iterator _aPos )
+OCharsetMap::CharsetIterator::CharsetIterator(const OCharsetMap* 
_pContainer, OCharsetMap::TextEncBag::const_iterator const & _aPos )
 :m_pContainer( _pContainer )
 ,m_aPos( _aPos )
 {
diff --git a/include/connectivity/dbcharset.hxx 
b/include/connectivity/dbcharset.hxx
index 8c7e9de..d4ef414 100644
--- a/include/connectivity/dbcharset.hxx
+++ b/include/connectivity/dbcharset.hxx
@@ -144,7 +144,7 @@ namespace dbtools
 const CharsetIterator&  operator--();
 
 protected:
-CharsetIterator(const OCharsetMap* _pContainer, 
OCharsetMap::TextEncBag::const_iterator _aPos );
+CharsetIterator(const OCharsetMap* _pContainer, 
OCharsetMap::TextEncBag::const_iterator const & _aPos );
 };
 
 
diff --git a/include/oox/core/fragmenthandler.hxx 
b/include/oox/core/fragmenthandler.hxx
index 3dd37ae..7077a33 100644
--- a/include/oox/core/fragmenthandler.hxx
+++ b/include/oox/core/fragmenthandler.hxx
@@ -64,7 +64,7 @@ struct FragmentBaseData
 explicitFragmentBaseData(
 XmlFilterBase& rFilter,
 const OUString& rFragmentPath,
-

[Libreoffice-commits] online.git: loolwsd/bundled loolwsd/LOKitClient.cpp

2016-08-19 Thread Miklos Vajna 
 loolwsd/LOKitClient.cpp  |1 
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h |   25 +++
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitInit.h  |   19 
 3 files changed, 36 insertions(+), 9 deletions(-)

New commits:
commit e0cd11848a0af7b5d87095a93d7139dc915895a3
Author: Miklos Vajna 
Date:   Fri Aug 19 16:52:16 2016 +0200

Update bundled headers

diff --git a/loolwsd/LOKitClient.cpp b/loolwsd/LOKitClient.cpp
index 330d521..4104e3d 100644
--- a/loolwsd/LOKitClient.cpp
+++ b/loolwsd/LOKitClient.cpp
@@ -73,6 +73,7 @@ extern "C"
 CASE(GRAPHIC_VIEW_SELECTION);
 CASE(VIEW_CURSOR_VISIBLE);
 CASE(VIEW_LOCK);
+CASE(REDLINE_TABLE_SIZE_CHANGED);
 #undef CASE
 }
 std::cout << " payload: " << pPayload << std::endl;
diff --git a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 651e9bc..0805e62 100644
--- a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -406,6 +406,31 @@ typedef enum
  */
 LOK_CALLBACK_VIEW_LOCK,
 
+/**
+ * The size of the change tracking table has changed.
+ *
+ * The payload example:
+ * {
+ * "redline": {
+ * "action": "Remove",
+ * "index": "1",
+ * "author": "Unknown Author",
+ * "type": "Delete",
+ * "comment": "",
+ * "description": "Delete 'abc'",
+ * "dateTime": "2016-08-18T12:14:00"
+ * }
+ * }
+ *
+ * The format is the same as an entry of
+ * lok::Document::getCommandValues('.uno:AcceptTrackedChanges'), extra
+ * fields:
+ *
+ * - 'action' is either 'Add' or 'Remove', depending on if this is an
+ *   insertion into the table or a removal.
+ */
+LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED,
+
 }
 LibreOfficeKitCallbackType;
 
diff --git a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitInit.h 
b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitInit.h
index bdda642..bbef7d5 100644
--- a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitInit.h
+++ b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKitInit.h
@@ -42,7 +42,7 @@ extern "C"
 #endif
 #define SEPARATOR '/'
 
-void *lok_loadlib(const char *pFN)
+inline void *lok_loadlib(const char *pFN)
 {
 return dlopen(pFN, RTLD_LAZY
 #if defined LOK_LOADLIB_GLOBAL
@@ -51,22 +51,22 @@ extern "C"
   );
 }
 
-char *lok_dlerror(void)
+inline char *lok_dlerror(void)
 {
 return dlerror();
 }
 
-void *lok_dlsym(void *Hnd, const char *pName)
+inline void *lok_dlsym(void *Hnd, const char *pName)
 {
 return dlsym(Hnd, pName);
 }
 
-int lok_dlclose(void *Hnd)
+inline int lok_dlclose(void *Hnd)
 {
 return dlclose(Hnd);
 }
 
-void extendUnoPath(const char *pPath)
+inline void extendUnoPath(const char *pPath)
 {
 (void)pPath;
 }
@@ -161,19 +161,20 @@ static void *lok_dlopen( const char *install_path, char 
** _imp_lib )
 
 // allocate large enough buffer
 partial_length = strlen(install_path);
-imp_lib = (char *) malloc(partial_length + sizeof(TARGET_LIB) + 
sizeof(TARGET_MERGED_LIB) + 2);
+size_t imp_lib_size = partial_length + sizeof(TARGET_LIB) + 
sizeof(TARGET_MERGED_LIB) + 2;
+imp_lib = (char *) malloc(imp_lib_size);
 if (!imp_lib)
 {
 fprintf( stderr, "failed to open library : not enough memory\n");
 return NULL;
 }
 
-strcpy(imp_lib, install_path);
+strncpy(imp_lib, install_path, imp_lib_size);
 
 extendUnoPath(install_path);
 
 imp_lib[partial_length++] = SEPARATOR;
-strcpy(imp_lib + partial_length, TARGET_LIB);
+strncpy(imp_lib + partial_length, TARGET_LIB, imp_lib_size - 
partial_length);
 
 dlhandle = lok_loadlib(imp_lib);
 if (!dlhandle)
@@ -191,7 +192,7 @@ static void *lok_dlopen( const char *install_path, char ** 
_imp_lib )
 return NULL;
 }
 
-strcpy(imp_lib + partial_length, TARGET_MERGED_LIB);
+strncpy(imp_lib + partial_length, TARGET_MERGED_LIB, imp_lib_size - 
partial_length);
 
 dlhandle = lok_loadlib(imp_lib);
 if (!dlhandle)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/mm-cleanup' - 0 commits -

2016-08-19 Thread Unknown 
Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 02b1fed89c0d74bc1c7898eca19266ef36f6c616
Author: Akash Jain 
Date:   Wed Aug 17 21:31:22 2016 +0530

GSoC: Speed up CommonSalLayout by caching hb_face

Cache hb_face so it is not created again and again.
Switch from GDI to DirectWrite on Windows to obtain SFNT table data.

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 04723cb..1c356c5 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -35,6 +35,7 @@
 #include 
 #include "fontattributes.hxx"
 #include "impfontmetricdata.hxx"
+#include "hb-ot.h"
 
 #include 
 
@@ -181,6 +182,8 @@ public:
 sal_GlyphId FixupGlyphIndex( sal_GlyphId aGlyphId, sal_UCS4 ) 
const;
 boolGetGlyphOutline( sal_GlyphId aGlyphId, 
basegfx::B2DPolyPolygon& ) const;
 boolGetAntialiasAdvice() const;
+hb_face_t*  GetHBFace() { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) { 
mpHBFace=pHBFace; }
 
 private:
 friend class GlyphCache;
@@ -240,6 +243,7 @@ private:
 GlyphSubstitution   maGlyphSubstitution;
 
 ServerFontLayoutEngine* mpLayoutEngine;
+hb_face_t*  mpHBFace;
 };
 
 // a class for cache entries for physical font instances that are based on 
serverfonts
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { mpHBFace = 
pHBFace; }
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
@@ -354,6 +359,7 @@ private:
 sal_uLong   GetKernPairs();
 
 public:
+sal_uLong   GetTable( const char pTagName[5], const unsigned 
char*&, void*&, IDWriteFontFace*& );
 // public SalGraphics methods, the interface to the independent vcl part
 
 // get device resolution
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease(

[Libreoffice-bugs] [Bug 92478] CRASH when open "scan > scanner source" on windows 10 x64.

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92478

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #31 from Caolán McNamara  ---
I reckon the crash should be fixed. Doesn't mean scanning actually works on
64bit windows, just that it doesn't crash. Installing the 64bit twain dll on
windows might now make it work, but someone will have to experiment to see if
that is actually the case

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Libreoffice-qa] minutes of ESC call: 2016-08-18

2016-08-19 Thread Caolán McNamara 
On Thu, 2016-08-18 at 18:36 +0200, Bjoern Michaelsen wrote:
> * all bugs tagged with 'regression'
>     + 688(+0) bugs open of 5090(+24) total 10(-1) high prio.
> 
>     * ~Component   count net * high severity regressions
>   Calc -  4 (+0)

74880, one of these calc bugs, requires a download of a zip of files
reproduce, but the document is gone from the original host. Is there a
route to reproduce this ? otherwise its futile to have it in the
regression list.

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svx/source

2016-08-19 Thread Stephan Bergmann 
 svx/source/tbxctrls/PaletteManager.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit e774d798f6734f3bcc10e74bf641efcce0dedc40
Author: Stephan Bergmann 
Date:   Fri Aug 19 16:49:42 2016 +0200

pShell can be null here

...e.g., when opening "Tools - Options... - LibreOffice - Colors" from the 
Start
Center.

Change-Id: Id83591996e03794dc7dc53ccda58df7d7624ff8d

diff --git a/svx/source/tbxctrls/PaletteManager.cxx 
b/svx/source/tbxctrls/PaletteManager.cxx
index cccf167..c2c9748 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -194,8 +194,11 @@ void PaletteManager::SetPalette( sal_Int32 nPos )
 if(pColorList->Load())
 {
 SfxObjectShell* pShell = SfxObjectShell::Current();
-SvxColorListItem aColorItem(pColorList, SID_COLOR_TABLE);
-pShell->PutItem( aColorItem );
+if (pShell != nullptr)
+{
+SvxColorListItem aColorItem(pColorList, SID_COLOR_TABLE);
+pShell->PutItem( aColorItem );
+}
 }
 }
 std::shared_ptr 
batch(comphelper::ConfigurationChanges::create(m_context));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] minutes of ESC call: 2016-08-18

2016-08-19 Thread Caolán McNamara 
On Thu, 2016-08-18 at 18:36 +0200, Bjoern Michaelsen wrote:
> * all bugs tagged with 'regression'
>     + 688(+0) bugs open of 5090(+24) total 10(-1) high prio.
> 
>     * ~Component   count net * high severity regressions
>   Calc -  4 (+0)

74880, one of these calc bugs, requires a download of a zip of files
reproduce, but the document is gone from the original host. Is there a
route to reproduce this ? otherwise its futile to have it in the
regression list.

C.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: include/LibreOfficeKit libreofficekit/source sw/qa sw/source

2016-08-19 Thread Miklos Vajna 
 include/LibreOfficeKit/LibreOfficeKitEnums.h   |   24 ++
 libreofficekit/source/gtk/lokdocview.cxx   |6 +++
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   32 ++-
 sw/source/core/doc/docredln.cxx|   42 +
 sw/source/core/inc/unoport.hxx |3 +
 sw/source/core/unocore/unoredline.cxx  |8 ++--
 6 files changed, 110 insertions(+), 5 deletions(-)

New commits:
commit 0bc553f3ef3c188a96ea4875f4722ad4d40da4a3
Author: Miklos Vajna 
Date:   Fri Aug 19 15:27:59 2016 +0200

sw lok: add callbacks for redline table insertion / removal

An alternative would be to follow the Manage Changes dialog approach and
subscribe to the SFX_HINT_DOCCHANGED notification in SwDocShell, cache
the old redline table and find out the differences to the current one,
but that way sound much more complex without benefits.

Change-Id: I20a45285b88255ccea9d6646c0b5288ac1c91879

diff --git a/include/LibreOfficeKit/LibreOfficeKitEnums.h 
b/include/LibreOfficeKit/LibreOfficeKitEnums.h
index 651e9bc..2c3bcab 100644
--- a/include/LibreOfficeKit/LibreOfficeKitEnums.h
+++ b/include/LibreOfficeKit/LibreOfficeKitEnums.h
@@ -406,6 +406,30 @@ typedef enum
  */
 LOK_CALLBACK_VIEW_LOCK,
 
+/**
+ * The size of the change tracking table has changed.
+ *
+ * The payload example:
+ * {
+ * "redline": {
+ * "action": "Remove",
+ * "index": "1",
+ * "author": "Unknown Author",
+ * "type": "Delete",
+ * "comment": "",
+ * "dateTime": "2016-08-18T12:14:00"
+ * }
+ * }
+ *
+ * The format is the same as an entry of
+ * lok::Document::getCommandValues('.uno:AcceptTrackedChanges'), extra
+ * fields:
+ *
+ * - 'action' is either 'Add' or 'Remove', depending on if this is an
+ *   insertion into the table or a removal.
+ */
+LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED,
+
 }
 LibreOfficeKitCallbackType;
 
diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index 0156330..3af5d00 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -421,6 +421,8 @@ callbackTypeToString (int nType)
 return "LOK_CALLBACK_ERROR";
 case LOK_CALLBACK_VIEW_LOCK:
 return "LOK_CALLBACK_VIEW_LOCK";
+case LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED:
+return "LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED";
 }
 g_assert(false);
 return nullptr;
@@ -1339,6 +1341,10 @@ callback (gpointer pData)
 gtk_widget_queue_draw(GTK_WIDGET(pDocView));
 break;
 }
+case LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED:
+{
+break;
+}
 default:
 g_assert(false);
 break;
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index ad8deaf..a8b7bf9 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -68,6 +68,7 @@ public:
 void testShapeTextUndoShells();
 void testShapeTextUndoGroupShells();
 void testTrackChanges();
+void testTrackChangesCallback();
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -101,6 +102,7 @@ public:
 CPPUNIT_TEST(testShapeTextUndoShells);
 CPPUNIT_TEST(testShapeTextUndoGroupShells);
 CPPUNIT_TEST(testTrackChanges);
+CPPUNIT_TEST(testTrackChangesCallback);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -116,13 +118,15 @@ private:
 int m_nSelectionBeforeSearchResult;
 int m_nSelectionAfterSearchResult;
 int m_nInvalidations;
+int m_nRedlineTableSizeChanged;
 };
 
 SwTiledRenderingTest::SwTiledRenderingTest()
 : m_bFound(true),
   m_nSelectionBeforeSearchResult(0),
   m_nSelectionAfterSearchResult(0),
-  m_nInvalidations(0)
+  m_nInvalidations(0),
+  m_nRedlineTableSizeChanged(0)
 {
 }
 
@@ -196,6 +200,11 @@ void SwTiledRenderingTest::callbackImpl(int nType, const 
char* pPayload)
 }
 }
 break;
+case LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED:
+{
+++m_nRedlineTableSizeChanged;
+}
+break;
 }
 }
 
@@ -1169,6 +1178,27 @@ void SwTiledRenderingTest::testTrackChanges()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void SwTiledRenderingTest::testTrackChangesCallback()
+{
+// Load a document.
+comphelper::LibreOfficeKit::setActive();
+SwXTextDocument* pXTextDocument = createDoc("dummy.fodt");
+SwWrtShell* pWrtShell = pXTextDocument->GetDocShell()->GetWrtShell();
+
pWrtShell->GetSfxViewShell()->registerLibreOfficeKitViewCallback(::callback,
 this);
+
+// Turn on track changes and type "x".
+uno::Reference xPropertySet(mxComponent, 
uno::UNO_QUERY);
+xPropertySet->setPropertyValue("RecordChanges",

[Libreoffice-commits] core.git: Branch 'feature/mailmerge-cleanup' - 0 commits -

2016-08-19 Thread Unknown 
Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 4255dbf16570bd5076f2885d28c5d20eb9502242
Author: Akash Jain 
Date:   Wed Aug 17 21:31:22 2016 +0530

GSoC: Speed up CommonSalLayout by caching hb_face

Cache hb_face so it is not created again and again.
Switch from GDI to DirectWrite on Windows to obtain SFNT table data.

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 04723cb..1c356c5 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -35,6 +35,7 @@
 #include 
 #include "fontattributes.hxx"
 #include "impfontmetricdata.hxx"
+#include "hb-ot.h"
 
 #include 
 
@@ -181,6 +182,8 @@ public:
 sal_GlyphId FixupGlyphIndex( sal_GlyphId aGlyphId, sal_UCS4 ) 
const;
 boolGetGlyphOutline( sal_GlyphId aGlyphId, 
basegfx::B2DPolyPolygon& ) const;
 boolGetAntialiasAdvice() const;
+hb_face_t*  GetHBFace() { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) { 
mpHBFace=pHBFace; }
 
 private:
 friend class GlyphCache;
@@ -240,6 +243,7 @@ private:
 GlyphSubstitution   maGlyphSubstitution;
 
 ServerFontLayoutEngine* mpLayoutEngine;
+hb_face_t*  mpHBFace;
 };
 
 // a class for cache entries for physical font instances that are based on 
serverfonts
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { mpHBFace = 
pHBFace; }
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
@@ -354,6 +359,7 @@ private:
 sal_uLong   GetKernPairs();
 
 public:
+sal_uLong   GetTable( const char pTagName[5], const unsigned 
char*&, void*&, IDWriteFontFace*& );
 // public SalGraphics methods, the interface to the independent vcl part
 
 // get device resolution
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease(

[Libreoffice-bugs] [Bug 74880] [Memory leak] LibreOffice crashing when importing data from 8+ ods files, but doesn' t crash on same xls files

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=74880

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #10 from Caolán McNamara  ---
I went to look at this problem today, but the original reproducer zip seems to
be gone. Is there another copy of this anywhere, or another route to reproduce
?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 6 commits - configure.ac external/harfbuzz vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 99aeb5d3f0da96c209dece6861268c5b980f07cc
Author: Akash Jain 
Date:   Wed Aug 17 21:31:22 2016 +0530

GSoC: Speed up CommonSalLayout by caching hb_face

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index 04723cb..1c356c5 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -35,6 +35,7 @@
 #include 
 #include "fontattributes.hxx"
 #include "impfontmetricdata.hxx"
+#include "hb-ot.h"
 
 #include 
 
@@ -181,6 +182,8 @@ public:
 sal_GlyphId FixupGlyphIndex( sal_GlyphId aGlyphId, sal_UCS4 ) 
const;
 boolGetGlyphOutline( sal_GlyphId aGlyphId, 
basegfx::B2DPolyPolygon& ) const;
 boolGetAntialiasAdvice() const;
+hb_face_t*  GetHBFace() { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) { 
mpHBFace=pHBFace; }
 
 private:
 friend class GlyphCache;
@@ -240,6 +243,7 @@ private:
 GlyphSubstitution   maGlyphSubstitution;
 
 ServerFontLayoutEngine* mpLayoutEngine;
+hb_face_t*  mpHBFace;
 };
 
 // a class for cache entries for physical font instances that are based on 
serverfonts
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const { mpHBFace = 
pHBFace; }
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
@@ -354,6 +359,7 @@ private:
 sal_uLong   GetKernPairs();
 
 public:
+sal_uLong   GetTable( const char pTagName[5], const unsigned 
char*&, void*&, IDWriteFontFace*& );
 // public SalGraphics methods, the interface to the independent vcl part
 
 // get device resolution
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr&

[Libreoffice-bugs] [Bug 92825] Update help for all menu changes

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=92825

Aron Budea  changed:

   What|Removed |Added

 CC||rayho...@yahoo.com

--- Comment #14 from Aron Budea  ---
*** Bug 101614 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101614] insert menu missing "ROW"

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101614

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
  Component|LibreOffice |Documentation
 Resolution|--- |DUPLICATE

--- Comment #1 from Aron Budea  ---
Sheet-related functions are now in the Sheet menu.
Indeed, Help is not up-to-date:
https://help.libreoffice.org/Calc/Insert

Since there's a generic bug report for updating menu info in the help, I'm
closing this one.

*** This bug has been marked as a duplicate of bug 92825 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 9 commits - configure.ac external/harfbuzz vcl/inc vcl/quartz vcl/README.vars vcl/source vcl/unx vcl/win

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 30c465aae39d55ac60d34431e5126f697bf30867
Author: Akash Jain 
Date:   Thu Aug 18 22:46:56 2016 +0530

GSoC: Speed up CommonSalLayout in quartz/

Cache hb face to speed up layout in quartz/

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr& rxFontMetric ) const
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 1c0e3ef..ff92000 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -136,7 +136,12 @@ CommonSalLayout::CommonSalLayout(const CoreTextStyle& 
rCoreTextStyle)
 maFontSelData(rCoreTextStyle.maFontSelData),
 mrCoreTextStyle(rCoreTextStyle)
 {
-mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+mpHBFace = rCoreTextStyle.GetHBFace();
+if(!mpHBFace)
+{
+mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+rCoreTextStyle.SetHBFace(mpHBFace);
+}
 }
 
 #else
@@ -156,11 +161,6 @@ CommonSalLayout::CommonSalLayout(ServerFont& rServerFont)
 
 CommonSalLayout::~CommonSalLayout()
 {
-#if defined(_WIN32)
-#elif defined(MACOSX) || defined(IOS)
-hb_face_destroy(mpHBFace);
-#else
-#endif
 }
 
 struct HbScriptRun
commit f7b8b2a77cb338deb13cb1aef1b78958784699f8
Author: Akash Jain 
Date:   Thu Aug 18 21:10:08 2016 +0530

GSoC: Speed up CommonSalLayout in win/

Cache hb face to obtain speed up.
Switch to DirectWrite from GDI for reading SFNT table data.

Change-Id: I3c00c3e3c0faf340f024d7c78199ac0c78759410

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const {

[Libreoffice-commits] core.git: sw/source

2016-08-19 Thread Caolán McNamara 
 sw/source/core/doc/docfld.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 3196e949bb23a33bdb8700dbe27782e0e6c8f1e6
Author: Caolán McNamara 
Date:   Fri Aug 19 15:08:35 2016 +0100

Resolves: tdf#100901 crash pressing tab in r-o document with hyperlink

rather odd union in use here. Trying to call SwTextField::GetStart
on SwTextINetFormat blows up under visual studio.

Change-Id: Ic8145d7645bd6a68ef19e018311a4de6e6958bcb

diff --git a/sw/source/core/doc/docfld.cxx b/sw/source/core/doc/docfld.cxx
index 35e3696..56ef919 100644
--- a/sw/source/core/doc/docfld.cxx
+++ b/sw/source/core/doc/docfld.cxx
@@ -322,9 +322,11 @@ sal_Int32 SetGetExpField::GetCntPosFromContent() const
 switch( eSetGetExpFieldType )
 {
 case TEXTFIELD:
-case TEXTINET:
 nRet = CNTNT.pTextField->GetStart();
 break;
+case TEXTINET:
+nRet = CNTNT.pTextINet->GetStart();
+break;
 case TEXTTOXMARK:
 nRet = CNTNT.pTextTOX->GetStart();
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100901] LibreOffice Crashes if a Document with a Hyperlink is Opened in Read-only Mode and the Tab Key is Pressed

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100901

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2016-08-19 Thread Tor Lillqvist 
 configure.ac |  109 ++-
 1 file changed, 56 insertions(+), 53 deletions(-)

New commits:
commit f351446ac8aea9dc27d200e7abe62250acfb05cd
Author: Tor Lillqvist 
Date:   Fri Aug 19 17:00:24 2016 +0300

Automatically avoid export validation if not using Java

Change-Id: Ic1c917b16a8d812b3170b14890eacf3b9859cc2d

diff --git a/configure.ac b/configure.ac
index 847651b7..debeebd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4630,7 +4630,6 @@ if test "$cross_compiling" = "yes"; then
 --with-parallelism="$with_parallelism" \
 --without-doxygen \
 --without-java \
---without-export-validation \
 $sub_conf_opts \
 --srcdir=$srcdir \
 2>&1 | sed -e 's/^//'
@@ -7307,69 +7306,73 @@ dnl Export file validation
 dnl ===
 AC_MSG_CHECKING([whether to enable export file validation])
 if test "$with_export_validation" = yes; then
-if test "$HAVE_JAVA6" != "TRUE"; then
-AC_MSG_ERROR([officeotron needs at least JRE 1.6; update or specify 
--without-export-validation])
-fi
-AC_MSG_RESULT([yes])
-AC_DEFINE(HAVE_EXPORT_VALIDATION)
+if test -z "$ENABLE_JAVA"; then
+AC_MSG_RESULT([no, as Java is disabled])
+else
+if test "$HAVE_JAVA6" != "TRUE"; then
+AC_MSG_ERROR([officeotron needs at least JRE 1.6; update or 
specify --without-export-validation])
+fi
+AC_MSG_RESULT([yes])
+AC_DEFINE(HAVE_EXPORT_VALIDATION)
 
-AC_PATH_PROGS(ODFVALIDATOR, odfvalidator)
-if test -z "$ODFVALIDATOR"; then
-# remember to download the ODF toolkit with validator later
-AC_MSG_NOTICE([no odfvalidator found, will download it])
-BUILD_TYPE="$BUILD_TYPE ODFVALIDATOR"
-ODFVALIDATOR="$SRC_ROOT/bin/odfvalidator.sh"
+AC_PATH_PROGS(ODFVALIDATOR, odfvalidator)
+if test -z "$ODFVALIDATOR"; then
+# remember to download the ODF toolkit with validator later
+AC_MSG_NOTICE([no odfvalidator found, will download it])
+BUILD_TYPE="$BUILD_TYPE ODFVALIDATOR"
+ODFVALIDATOR="$SRC_ROOT/bin/odfvalidator.sh"
 
-# and fetch name of odfvalidator jar name from download.lst
-ODFVALIDATOR_JAR=`$SED -n -e "s/export *ODFVALIDATOR_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
-AC_SUBST(ODFVALIDATOR_JAR)
+# and fetch name of odfvalidator jar name from download.lst
+ODFVALIDATOR_JAR=`$SED -n -e "s/export *ODFVALIDATOR_JAR *:= 
*\(.*\) */\1/p" $SRC_ROOT/download.lst`
+AC_SUBST(ODFVALIDATOR_JAR)
 
-if test -z "$ODFVALIDATOR_JAR"; then
-AC_MSG_ERROR([cannot determine odfvalidator jar location 
(--with-export-validation)])
+if test -z "$ODFVALIDATOR_JAR"; then
+AC_MSG_ERROR([cannot determine odfvalidator jar location 
(--with-export-validation)])
+fi
 fi
-fi
-if test "$build_os" = "cygwin"; then
-# In case of CygWin it will be executed from Windows,
-# so we need to run bash and absolute path to validator
-# so instead of "odfvalidator" it will be
-# something like "bash.exe C:\cygwin\opt\lo\bin\odfvalidator"
-ODFVALIDATOR="bash.exe `cygpath -m "$ODFVALIDATOR"`"
-else
-ODFVALIDATOR="sh $ODFVALIDATOR"
-fi
-AC_SUBST(ODFVALIDATOR)
+if test "$build_os" = "cygwin"; then
+# In case of CygWin it will be executed from Windows,
+# so we need to run bash and absolute path to validator
+# so instead of "odfvalidator" it will be
+# something like "bash.exe C:\cygwin\opt\lo\bin\odfvalidator"
+ODFVALIDATOR="bash.exe `cygpath -m "$ODFVALIDATOR"`"
+else
+ODFVALIDATOR="sh $ODFVALIDATOR"
+fi
+AC_SUBST(ODFVALIDATOR)
 
 
-AC_PATH_PROGS(OFFICEOTRON, officeotron)
-if test -z "$OFFICEOTRON"; then
-# remember to download the officeotron with validator later
-AC_MSG_NOTICE([no officeotron found, will download it])
-BUILD_TYPE="$BUILD_TYPE OFFICEOTRON"
-OFFICEOTRON="$SRC_ROOT/bin/officeotron.sh"
+AC_PATH_PROGS(OFFICEOTRON, officeotron)
+if test -z "$OFFICEOTRON"; then
+# remember to download the officeotron with validator later
+AC_MSG_NOTICE([no officeotron found, will download it])
+BUILD_TYPE="$BUILD_TYPE OFFICEOTRON"
+OFFICEOTRON="$SRC_ROOT/bin/officeotron.sh"
 
-# and fetch name of officeotron jar name from download.lst
-OFFICEOTRON_JAR=`$SED -n -e "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
-AC_SUBST(OFFICEOTRON_JAR)
+# and fetch name of officeotron jar name from download.lst
+OFFICEOTRON_JAR=`$SED -n -e "s/export *OFFICEOTRON_JAR *:= *\(.*\)

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 10 commits - configure.ac external/harfbuzz vcl/headless vcl/inc vcl/quartz vcl/README.vars vcl/source vcl/unx vcl/win

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit 4119cdc3b41e5a23fe4402727fac7d7efefd7fa0
Author: Akash Jain 
Date:   Thu Aug 18 22:46:56 2016 +0530

GSoC: Speed up CommonSalLayout in quartz/

Cache hb face to speed up layout in quartz/

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr& rxFontMetric ) const
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index a530e2e..12b128b 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -136,7 +136,12 @@ CommonSalLayout::CommonSalLayout(const CoreTextStyle& 
rCoreTextStyle)
 maFontSelData(rCoreTextStyle.maFontSelData),
 mrCoreTextStyle(rCoreTextStyle)
 {
-mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+mpHBFace = rCoreTextStyle.GetHBFace();
+if(!mpHBFace)
+{
+mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+rCoreTextStyle.SetHBFace(mpHBFace);
+}
 }
 
 #else
@@ -156,11 +161,6 @@ CommonSalLayout::CommonSalLayout(ServerFont& rServerFont)
 
 CommonSalLayout::~CommonSalLayout()
 {
-#if defined(_WIN32)
-#elif defined(MACOSX) || defined(IOS)
-hb_face_destroy(mpHBFace);
-#else
-#endif
 }
 
 struct HbScriptRun
commit 1df7f933af1643f970143112d772e1179aa64822
Author: Akash Jain 
Date:   Thu Aug 18 21:10:08 2016 +0530

GSoC: Speed up CommonSalLayout in win/

Cache hb face to obtain speed up.
Switch to DirectWrite from GDI for reading SFNT table data.

Change-Id: I3c00c3e3c0faf340f024d7c78199ac0c78759410

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const {

Re: Debugging specifics wrt visual studio

2016-08-19 Thread Caolán McNamara 
On Tue, 2016-06-07 at 10:28 +0530, Akash Jain wrote:
> I was having problems debugging with visual studio 2015, where even
> with all the relevant modules loaded and their status being "Symbols
> loaded", I was not able to set any breakpoints from the source file.
> This was happening even in WinDbg. I wondered if the pdb files even
> had the sources specified. So I found code for a tool which is
> essentially a pdb parser. On building and running it on any of the
> pdb
> files, I found that there were no sources for all the object files,
> related to lo, in that module.
> I then downloaded vs2013 and built with it. And on inspection of the
> pdb files, I found that the sources were now being specified. I was
> also able to debug properly.
> 
> Has anyone had similar experience with debugging in vs2015 without
> vs2013 being installed on their system? Better still can anyone shed
> some light on why this might be happening?

As mentioned on IRC today. I also had the same problem with vs2015. I
hacked my solenv/gbuild/platform/com_MSC_defs.mk to add -Z7 to
gb_CXXFLAGS and gb_CFLAGS to embed the debuginfo into the obj files and
debugging in msvc 2015 then works (without any --enable-debug --enable-
symbols etc configure flags).

So I can confirm that theres apparently something wrong with the pdbs
built under 2015 seeing as I can debug LibreOffice with -Z7 but not -Zi

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - configure.ac

2016-08-19 Thread Thorsten Behrens 
 configure.ac |   11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit b9ebc6e4c8b0ae72f4a208df29f99fe1404595ed
Author: Thorsten Behrens 
Date:   Fri Aug 19 15:39:55 2016 +0200

configure.ac: use sed from path_progrs macro

Change-Id: I79a6352eabba6d6f3064df2340d53c2808210f6c

diff --git a/configure.ac b/configure.ac
index 0e386be0..847651b7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7321,7 +7321,7 @@ if test "$with_export_validation" = yes; then
 ODFVALIDATOR="$SRC_ROOT/bin/odfvalidator.sh"
 
 # and fetch name of odfvalidator jar name from download.lst
-ODFVALIDATOR_JAR=`sed -ne "s/export *ODFVALIDATOR_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
+ODFVALIDATOR_JAR=`$SED -n -e "s/export *ODFVALIDATOR_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
 AC_SUBST(ODFVALIDATOR_JAR)
 
 if test -z "$ODFVALIDATOR_JAR"; then
@@ -7348,7 +7348,7 @@ if test "$with_export_validation" = yes; then
 OFFICEOTRON="$SRC_ROOT/bin/officeotron.sh"
 
 # and fetch name of officeotron jar name from download.lst
-OFFICEOTRON_JAR=`sed -ne "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
+OFFICEOTRON_JAR=`$SED -n -e "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
 AC_SUBST(OFFICEOTRON_JAR)
 
 if test -z "$OFFICEOTRON_JAR"; then
commit 53c98f01effb31c3308f0c27e4cc0bdd37fd974f
Author: Thorsten Behrens 
Date:   Fri Aug 19 15:33:17 2016 +0200

configure.ac: invert help text semantics for export-validation

Change-Id: I5444c89db7bf46b1894026aa8a2d58ce4d2294df

diff --git a/configure.ac b/configure.ac
index 81fb048..0e386be0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2035,10 +2035,9 @@ AC_ARG_WITH(symbol-config,
 [with_symbol_config=no])
 
 AC_ARG_WITH(export-validation,
-AS_HELP_STRING([--with-export-validation],
-[If you want the exported files to be validated. Right now limited to 
OOXML and ODF files.
- Note: You need executable scripts officeotron and odfvalidator that 
take the path to the file.
- See 
https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation]),
+AS_HELP_STRING([--without-export-validation],
+[Disable validating OOXML and ODF files as exported from in-tree tests.
+ Use this option e.g. if your system only provides Java 5.]),
 ,with_export_validation=yes)
 
 AC_ARG_WITH(bffvalidator,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101608] EDITING sheet causes CRASH - multi_type_vector::position#1321 : block position not found

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101608

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |DUPLICATE

--- Comment #3 from Aron Budea  ---
This issue is fixed in v5.1.5 and v5.2.0, please upgrade to either version.

*** This bug has been marked as a duplicate of bug 100764 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 12 commits - configure.ac external/harfbuzz vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/README.vars vcl/source vcl/unx vcl

2016-08-19 Thread Akash Jain 
Rebased ref, commits from common ancestor:
commit baa04d3724f9c2c8d73bbc860e00fa51d8612701
Author: Akash Jain 
Date:   Thu Aug 18 22:46:56 2016 +0530

GSoC: Speed up CommonSalLayout in quartz/

Cache hb face to speed up layout in quartz/

Change-Id: I9c532cd72e1f6b57313f3b7d42a6b9b0633eb0ef

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 7578768..678b0d1 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -45,6 +45,7 @@
 
 #include "quartz/salgdicommon.hxx"
 #include 
+#include 
 
 class AquaSalFrame;
 class FontAttributes;
@@ -98,6 +99,8 @@ public:
 void   GetFontMetric( ImplFontMetricDataPtr& ) const;
 bool   GetGlyphBoundRect( sal_GlyphId, Rectangle& ) const;
 bool   GetGlyphOutline( sal_GlyphId, basegfx::B2DPolyPolygon& ) const;
+hb_face_t* GetHBFace() const { return mpHBFace; }
+void   SetHBFace(hb_face_t* pHBFace) const { mpHBFace = pHBFace; }
 
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
@@ -109,6 +112,7 @@ public:
 private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
+mutable hb_face_t*  mpHBFace;
 
 friend class CTLayout;
 friend class AquaSalGraphics;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c7b54d3..d315705 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -50,6 +50,7 @@ CoreTextStyle::CoreTextStyle( const FontSelectPattern& rFSD )
 , mfFontRotation( 0.0 )
 , maFontSelData( rFSD )
 , mpStyleDict( nullptr )
+, mpHBFace( nullptr )
 {
 const FontSelectPattern* const pReqFont = 
 
@@ -116,6 +117,8 @@ CoreTextStyle::~CoreTextStyle()
 {
 if( mpStyleDict )
 CFRelease( mpStyleDict );
+if( mpHBFace )
+hb_face_destroy( mpHBFace );
 }
 
 void CoreTextStyle::GetFontMetric( ImplFontMetricDataPtr& rxFontMetric ) const
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index a530e2e..12b128b 100755
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -136,7 +136,12 @@ CommonSalLayout::CommonSalLayout(const CoreTextStyle& 
rCoreTextStyle)
 maFontSelData(rCoreTextStyle.maFontSelData),
 mrCoreTextStyle(rCoreTextStyle)
 {
-mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+mpHBFace = rCoreTextStyle.GetHBFace();
+if(!mpHBFace)
+{
+mpHBFace = hb_face_create_for_tables(getFontTable, 
const_cast(rCoreTextStyle.mpFontData), nullptr);
+rCoreTextStyle.SetHBFace(mpHBFace);
+}
 }
 
 #else
@@ -156,11 +161,6 @@ CommonSalLayout::CommonSalLayout(ServerFont& rServerFont)
 
 CommonSalLayout::~CommonSalLayout()
 {
-#if defined(_WIN32)
-#elif defined(MACOSX) || defined(IOS)
-hb_face_destroy(mpHBFace);
-#else
-#endif
 }
 
 struct HbScriptRun
commit db114ec56073dfe0150570ca12b9cee901729973
Author: Akash Jain 
Date:   Thu Aug 18 21:10:08 2016 +0530

GSoC: Speed up CommonSalLayout in win/

Cache hb face to obtain speed up.
Switch to DirectWrite from GDI for reading SFNT table data.

Change-Id: I3c00c3e3c0faf340f024d7c78199ac0c78759410

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 01641ad..24b4bbc 100755
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -40,6 +40,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC   mhDC;
 HFONT mhFont;
+D2DWriteTextOutRenderer* mpD2DRenderer;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle& mrCoreTextStyle;
 #else
@@ -48,7 +49,7 @@ class CommonSalLayout : public GenericSalLayout
 
 public:
 #if defined(_WIN32)
-explicitCommonSalLayout(HDC, WinFontInstance&);
+explicitCommonSalLayout(WinSalGraphics*, WinFontInstance&, 
const WinFontFace&);
 virtual voidInitFont() const override;
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index bc5165d..961cb47 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -44,6 +44,9 @@
 #  include "postwin.h"
 #endif
 
+#include 
+#include 
+
 class FontSelectPattern;
 class WinFontInstance;
 class ImplFontAttrCache;
@@ -139,10 +142,12 @@ private:
 
 mutable std::unordered_set  maGsubTable;
 mutable boolmbGsubRead;
+mutable hb_face_t*  mpHBFace;
 public:
 boolHasGSUBstitutions( HDC ) const;
 boolIsGSUBstituted( sal_UCS4 ) const;
-static int  GetTable( const char pTagName[5], const unsigned 
char*&, HDC );
+hb_face_t*  GetHBFace() const { return mpHBFace; }
+voidSetHBFace( hb_face_t* pHBFace ) const {

[Libreoffice-bugs] [Bug 101614] New: insert menu missing "ROW"

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101614

Bug ID: 101614
   Summary: insert menu missing "ROW"
   Product: LibreOffice
   Version: 5.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayho...@yahoo.com

Build ID: 5.1.5.2-3.fc24 - I went to insert a row in a spread sheet.

There is NO entry in the insert menu for ROW(s) (or slide off sub-menus).

Prior releases had this and according to your help menu, it should be there.

I would give you a screenshot but the menu disappears when I try.

This makes the spreadsheet tool essentially worthless for update.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2016-08-19 Thread Noel Grandin 
 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 54ba67e5501d0ef6191fa106d199bc5e7d345c2c
Author: Noel Grandin 
Date:   Fri Aug 19 15:22:49 2016 +0200

more of 'make the location of download.lst explicit'

Change-Id: I215c3f4cdc52eed977191fca3adaf72742cffb61

diff --git a/configure.ac b/configure.ac
index 4cd578a..81fb048 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7349,7 +7349,7 @@ if test "$with_export_validation" = yes; then
 OFFICEOTRON="$SRC_ROOT/bin/officeotron.sh"
 
 # and fetch name of officeotron jar name from download.lst
-OFFICEOTRON_JAR=`sed -ne "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" download.lst`
+OFFICEOTRON_JAR=`sed -ne "s/export *OFFICEOTRON_JAR *:= *\(.*\) 
*/\1/p" $SRC_ROOT/download.lst`
 AC_SUBST(OFFICEOTRON_JAR)
 
 if test -z "$OFFICEOTRON_JAR"; then
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101613] New: EDITING: Drag mode in Navigator from inactive document only copies

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101613

Bug ID: 101613
   Summary: EDITING: Drag mode in Navigator from inactive document
only copies
   Product: LibreOffice
   Version: 5.1.5.2 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gret...@fastmail.fm

I am trying to insert Links or Hyperlinks from one (inactive) odt text document
to another odt text document or odm master document, using the Navigator pane
of the Sidebar.

No matter if I set the Drag Mode to Link or Hyperlink, all that happens is that
a copy of the text is created in the target (active) text or master document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: scripting/java

2016-08-19 Thread Caolán McNamara 
 scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java  
   |6 ++---
 
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
 |   12 ++
 
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
   |   10 
 
scripting/java/com/sun/star/script/framework/provider/javascript/ScriptProviderForJavaScript.java
 |   10 
 4 files changed, 8 insertions(+), 30 deletions(-)

New commits:
commit d02941ebdb023a6e3151878375a0ffbd163d9d51
Author: Caolán McNamara 
Date:   Fri Aug 19 14:08:57 2016 +0100

Revert "coverity#1371372 Resource leak on an exceptional path"

seeing as it doesn't build universally, java 1.7 onwards
apparently

This reverts commit 6830d8c2083fa66cc113f587cbfc4aa5a4f8a535.

diff --git 
a/scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java 
b/scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java
index 73ba069..b3f3c50 100644
--- 
a/scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java
+++ 
b/scripting/java/com/sun/star/script/framework/provider/ClassLoaderFactory.java
@@ -31,7 +31,7 @@ public class ClassLoaderFactory {
 
 private ClassLoaderFactory() {}
 
-public static URLClassLoader getURLClassLoader(ScriptMetaData scriptData) {
+public static ClassLoader getURLClassLoader(ScriptMetaData scriptData) {
 ClassLoader parent = scriptData.getClass().getClassLoader();
 URL[] classPath = scriptData.getClassPath();
 LogUtils.DEBUG("Classpath has length " + classPath.length);
@@ -43,8 +43,8 @@ public class ClassLoaderFactory {
 return getURLClassLoader(parent, classPath);
 }
 
-private static URLClassLoader getURLClassLoader(ClassLoader parent,
+private static ClassLoader getURLClassLoader(ClassLoader parent,
 URL[] classpath) {
 return new URLClassLoader(classpath, parent);
 }
-}
+}
\ No newline at end of file
diff --git 
a/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
 
b/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
index b444cce..c832e6e 100644
--- 
a/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
+++ 
b/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptEditorForBeanShell.java
@@ -35,7 +35,6 @@ import java.io.InputStream;
 import java.io.OutputStream;
 
 import java.net.URL;
-import java.net.URLClassLoader;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -181,14 +180,15 @@ public class ScriptEditorForBeanShell implements 
ScriptEditor, ActionListener {
  */
 public void edit(final XScriptContext context, ScriptMetaData entry) {
 if (entry != null) {
-URLClassLoader cl = null;
 try {
+ClassLoader cl = null;
+
 try {
 cl = ClassLoaderFactory.getURLClassLoader(entry);
 } catch (Exception ignore) { // TODO re-examine error handling
 }
 
-final URLClassLoader theCl = cl;
+final ClassLoader theCl = cl;
 final URL url = entry.getSourceURL();
 SwingInvocation.invoke(
 new Runnable() {
@@ -210,12 +210,6 @@ public class ScriptEditorForBeanShell implements 
ScriptEditor, ActionListener {
 });
 } catch (IOException ioe) {
 showErrorMessage("Error loading file: " + ioe.getMessage());
-if (cl != null) {
-try {
-  cl.close();
-} catch (IOException e) {
-}
-}
 }
 }
 }
diff --git 
a/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
 
b/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
index 76ee4ef..2aabba7 100644
--- 
a/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
+++ 
b/scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
@@ -49,9 +49,7 @@ import com.sun.star.uno.Any;
 import com.sun.star.uno.Type;
 import com.sun.star.uno.XComponentContext;
 
-import java.io.IOException;
 import java.net.URL;
-import java.net.URLClassLoader;
 
 import java.util.StringTokenizer;
 
@@ -184,19 +182,13 @@ class ScriptImpl implements XScript {
 aOutParamIndex[0] = new short[0];
 aOutParam[0] = new Object[0];
 
-URLClassLoader cl = null;
+ClassLoader cl = null;
 URL sourceUrl = null;
 
 try {
 cl = ClassLoaderFactory.getURLClassLoader(metaData);
 sourceUrl = metaData.getSourceURL();
 } catch

[Libreoffice-commits] core.git: external/firebird

2016-08-19 Thread Stephan Bergmann 
 external/firebird/UnpackedTarball_firebird.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 3f8b89e2b0c598c1a8a6e09b0b7d3cc1dc3133a6
Author: Stephan Bergmann 
Date:   Fri Aug 19 15:04:51 2016 +0200

Undo inadvertent add

Change-Id: I2c991387dae67ee1bb2fa97e94cd8f2fcca81a60

diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 29ad0da..861b212 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -20,7 +20,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
external/firebird/firebird-cloop-compiler.patch.1 \
external/firebird/firebird-gcc6.patch.1 \
external/firebird/wnt-dbgutil.patch \
-   external/firebird/libc++.patch \
 ))
 
 ifeq ($(OS)-$(COM),WNT-MSC)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/firebird

2016-08-19 Thread Stephan Bergmann 
 external/firebird/UnpackedTarball_firebird.mk |1 +
 external/firebird/firebird-macosx.patch.1 |6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit e73dc86924ad33a1522c7e4a284a66dabf54c160
Author: Stephan Bergmann 
Date:   Fri Aug 19 15:02:52 2016 +0200

Why not just drop that $(HOME)/icu54/icu/source/lib nonsense

Change-Id: I2fed34ae680eb0bc01de90a7ef525cf8446cd940

diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index 861b212..29ad0da 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -20,6 +20,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
external/firebird/firebird-cloop-compiler.patch.1 \
external/firebird/firebird-gcc6.patch.1 \
external/firebird/wnt-dbgutil.patch \
+   external/firebird/libc++.patch \
 ))
 
 ifeq ($(OS)-$(COM),WNT-MSC)
diff --git a/external/firebird/firebird-macosx.patch.1 
b/external/firebird/firebird-macosx.patch.1
index 75f86e2..b9a685b 100644
--- a/external/firebird/firebird-macosx.patch.1
+++ b/external/firebird/firebird-macosx.patch.1
@@ -11,15 +11,15 @@
  #ifdef WIN32
 --- firebird.org/builds/posix/prefix.darwin_x86_64 2016-08-01 
20:02:48.0 +0200
 +++ firebird/builds/posix/prefix.darwin_x86_64 2016-08-01 21:42:45.0 
+0200
-@@ -19,7 +19,7 @@
+@@ -19,8 +19,6 @@
  #
  # Default build from 10.7 using Clang
  
 -DYLD_LIBRARY_PATH=$(HOME)/icu54/icu/source/lib
-+DYLD_LIBRARY_PATH:=$(HOME)/icu54/icu/source/lib:$(DYLD_LIBRARY_PATH)
- export DYLD_LIBRARY_PATH
+-export DYLD_LIBRARY_PATH
  
  #DYLD_PRINT_ENV=1
+ #export DYLD_PRINT_ENV
 @@ -31,15 +31,15 @@
  MACOSX_DEPLOYMENT_TARGET=10.7
  export MACOSX_DEPLOYMENT_TARGET
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/firebird

2016-08-19 Thread Stephan Bergmann 
 external/firebird/UnpackedTarball_firebird.mk |1 
 external/firebird/macosx-elcapitan-dyld.patch |   35 --
 2 files changed, 28 insertions(+), 8 deletions(-)

New commits:
commit e1c16a523eeb612cd25191a9c2994d8eded64b72
Author: Stephan Bergmann 
Date:   Fri Aug 19 15:02:05 2016 +0200

Revive external/firebird/macosx-elcapitan-dyld.patch

Change-Id: I382080f89b59a6cc642c829377954b72dae44abe

diff --git a/external/firebird/UnpackedTarball_firebird.mk 
b/external/firebird/UnpackedTarball_firebird.mk
index ba62597..861b212 100644
--- a/external/firebird/UnpackedTarball_firebird.mk
+++ b/external/firebird/UnpackedTarball_firebird.mk
@@ -32,6 +32,7 @@ ifeq ($(OS),MACOSX)
 $(eval $(call gb_UnpackedTarball_add_patches,firebird,\
external/firebird/firebird-configure-x86-64-macosx.patch.1 \
external/firebird/firebird-macosx.patch.1 \
+   external/firebird/macosx-elcapitan-dyld.patch \
 ))
 endif
 
diff --git a/external/firebird/macosx-elcapitan-dyld.patch 
b/external/firebird/macosx-elcapitan-dyld.patch
index b8c4c1c..134cdd9 100644
--- a/external/firebird/macosx-elcapitan-dyld.patch
+++ b/external/firebird/macosx-elcapitan-dyld.patch
@@ -9,31 +9,50 @@
  
  if (argc > 1)
  strcpy (Db_name, argv[1]);
-@@ -94,21 +94,23 @@
+@@ -94,7 +94,9 @@
  }
  
- printf ("Creating tables\n");
+ printf ("Turning forced writes off\n");
 +char const * lp = getenv("DYLD_LIBRARY_PATH");
 +if (!lp) lp = "";
+-sprintf (cmd, "gfix -write async %s", Db_name);
++sprintf (cmd, "DYLD_LIBRARY_PATH=%s gfix -write async %s", lp, Db_name);
+ if (system (cmd))
+ {
+ printf ("Couldn't turn forced writes off\n");
+@@ -104,7 +106,7 @@
+ }
+ 
+ printf ("Creating tables\n");
 -sprintf (cmd, "isql %s -q -i empddl.sql", Db_name);
 +sprintf (cmd, "DYLD_LIBRARY_PATH=%s isql %s -q -i empddl.sql", lp, Db_name);
  if (system (cmd))
  {
  printf ("Couldn't create tables \n");
- exit (FINI_ERROR);
+@@ -120,7 +122,7 @@
  }
  
  printf ("Turning  off indices and triggers \n");
 -sprintf (cmd, "isql %s -i indexoff.sql", Db_name);
 +sprintf (cmd, "DYLD_LIBRARY_PATH=%s isql %s -i indexoff.sql", lp, Db_name);
- system (cmd);
+ if (system (cmd))
+ {
+ printf ("Couldn't turn off indices and triggers \n");
+@@ -128,7 +130,7 @@
+ }
+
  printf ("Loading  column data\n");
 -sprintf (cmd, "isql %s -i empdml.sql", Db_name);
 +sprintf (cmd, "DYLD_LIBRARY_PATH=%s isql %s -i empdml.sql", lp, Db_name);
- system (cmd);
+ if (system (cmd))
+ {
+ printf ("Couldn't load column data \n");
+@@ -136,7 +138,7 @@
+ }
+ 
  printf ("Turning  on indices and triggers \n");
 -sprintf (cmd, "isql %s -i indexon.sql", Db_name);
 +sprintf (cmd, "DYLD_LIBRARY_PATH=%s isql %s -i indexon.sql", lp, Db_name);
- system (cmd);
- 
- EXEC SQL CONNECT DB;
+ if (system (cmd))
+ {
+ printf ("Couldn't turn on indices and triggers \n");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101612] New: FILESAVE: Status bar area re-appears in LibreOffice Calc after document save

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101612

Bug ID: 101612
   Summary: FILESAVE: Status bar area re-appears in LibreOffice
Calc after document save
   Product: LibreOffice
   Version: 5.2.0.4 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nsle...@hotmail.com

Unchecking the Status Bar view does cause the status bar to disappear in Calc,
but a blank status bar *area* re-appears permanently when saving a document in
Excel (xls) format.  The status bar area appears briefly when saving a document
in ODS and then disappears again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/firebird

2016-08-19 Thread Stephan Bergmann 
 external/firebird/ExternalProject_firebird.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit af9800b7bf6d19b15fff9ef9c50b4b696f7dc3b9
Author: Stephan Bergmann 
Date:   Fri Aug 19 15:00:25 2016 +0200

Excess separator

Change-Id: If86dc074ab1617837fbf771bb33e93ec1dc6ea2b

diff --git a/external/firebird/ExternalProject_firebird.mk 
b/external/firebird/ExternalProject_firebird.mk
index 2803f69..2fe2e8bc 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -75,7 +75,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build):
-L$(call 
gb_UnpackedTarball_get_dir,icu)/source/lib \
) \
" \
-   && export 
$(gb_Helper_LIBRARY_PATH_VAR)=$${$(gb_Helper_LIBRARY_PATH_VAR):+$$$(gb_Helper_LIBRARY_PATH_VAR):}":$(call
 gb_UnpackedTarball_get_dir,icu)/source/lib" \
+   && export 
$(gb_Helper_LIBRARY_PATH_VAR)=$${$(gb_Helper_LIBRARY_PATH_VAR):+$$$(gb_Helper_LIBRARY_PATH_VAR):}"$(call
 gb_UnpackedTarball_get_dir,icu)/source/lib" \
&& MAKE=$(MAKE) ./configure \
--without-editline \
--with-wire-compress=no \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

--- Comment #11 from Ziggy  ---
To be honest, I’m not entirely satisfied with the solution as proposed by Jay
in his “Comment 8” as of “2015-09-20 11:11:05 UTC”. In my opinion it would be
really useful if text highlighting using the color as suggested by the
“Highlight Color” button on Writer’s “Format” toolbar could be toggled using a
keyboard shortcut. However, I haven’t found a way to implement this (being just
a ‘casual’ user) yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

--- Comment #10 from Ziggy  ---
To be honest, I’m not entirely satisfied with the solution as proposed by Jay
in his “Comment 8” as of “2015-09-20 11:11:05 UTC”. In my opinion it would be
really useful if text highlighting using the color as suggested by the
“Highlight Color” button on Writer’s “Format” toolbar could be toggled using a
keyboard shortcut. However, I haven’t found a way to implement this (being just
a ‘casual’ user) yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101574] CONFIGURATION: Toolbar not staying parked

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101574

--- Comment #4 from carol762  ---
Please delete duplicate comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

--- Comment #9 from Ziggy  ---
To be honest, I’m not entirely satisfied with the solution as proposed by Jay
in his “Comment 8” as of “2015-09-20 11:11:05 UTC”. In my opinion it would be
really useful if text highlighting using the color as suggested by the
“Highlight Color” button on Writer’s “Format” toolbar could be toggled using a
keyboard shortcut. However, I haven’t found a way to implement this (being just
a ‘casual’ user) yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/Makefile loleaflet/src

2016-08-19 Thread Andras Timar 
 loleaflet/Makefile|3 ++-
 loleaflet/src/core/Socket.js  |2 +-
 loleaflet/src/map/handler/Map.FileInserter.js |2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit a68274c1deb0490d1f6b50825a2fe4547ac95460
Author: Andras Timar 
Date:   Fri Aug 19 14:34:21 2016 +0200

loleaflet: spinner l10n

diff --git a/loleaflet/Makefile b/loleaflet/Makefile
index e6fc663..d249a5a 100644
--- a/loleaflet/Makefile
+++ b/loleaflet/Makefile
@@ -53,7 +53,8 @@ pot:
src/control/Control.Tabs.js \
src/control/Toolbar.js \
src/core/Socket.js \
-   src/map/Map.js
+   src/map/Map.js \
+   src/map/handler/Map.FileInserter.js
 
html2po --pot --input=dist/loleaflet-help.html 
--output=po/templates/loleaflet-help.pot
 
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index 87f1ce6..f2f3672 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -192,7 +192,7 @@ L.Socket = L.Class.extend({
}
else if (textMsg.startsWith('statusindicator:')) {
//FIXME: We should get statusindicator when saving too, 
no?
-   this._map.showBusy('Connecting...', false);
+   this._map.showBusy(_('Connecting...'), false);
}
else if (!textMsg.startsWith('tile:') && 
!textMsg.startsWith('renderfont:')) {
// log the tile msg separately as we need the tile 
coordinates
diff --git a/loleaflet/src/map/handler/Map.FileInserter.js 
b/loleaflet/src/map/handler/Map.FileInserter.js
index 7e90a2a..a8a98f0 100644
--- a/loleaflet/src/map/handler/Map.FileInserter.js
+++ b/loleaflet/src/map/handler/Map.FileInserter.js
@@ -50,7 +50,7 @@ L.Map.FileInserter = L.Handler.extend({
var xmlHttp = new XMLHttpRequest();
var socket = this._map._socket;
var map = this._map;
-   this._map.showBusy('Uploading...', false);
+   this._map.showBusy(_('Uploading...'), false);
xmlHttp.onreadystatechange = function () {
if (xmlHttp.readyState === 4 && xmlHttp.status === 200) 
{
map.hideBusy();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101574] CONFIGURATION: Toolbar not staying parked

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101574

--- Comment #3 from carol762  ---
Agreed, but the toolbar still doesn't remain parked where I put it.  In my
opinion a toolbar that moves to where Calc wants it to be is useless.  This
even happens while I have a file open, not just when I close it and re-open it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41560] [Task]: Keyboard Shortcut CONFIGURATION problems

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=41560
Bug 41560 depends on bug 34804, which changed state.

Bug 34804 Summary: EDITING: Keyboard shortcut for Format-Highlighting does not 
work
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101574] CONFIGURATION: Toolbar not staying parked

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101574

--- Comment #2 from carol762  ---
Agreed, but the toolbar still doesn't remain parked where I put it.  In my
opinion a toolbar that moves to where Calc wants it to be is useless.  This
even happens while I have a file open, not just when I close it and re-open it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-08-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Ziggy  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   3   >