[Libreoffice-bugs] [Bug 104198] Copy a column and then trying to quit Calc hangs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104198

--- Comment #2 from fiftyigfuci_f...@yahoo.co.jp ---
Created attachment 129059
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129059=edit
backtrace

Calc eats a lot of memory and occurs disk accesses.
It seems like loops infinitely in pngwrite.cxx:404

#1  0x7f609ebeabc6 in vcl::PNGWriterImpl::ImplWriteIDAT
(this=0x55d671cc71c0)
at /libreoffice/vcl/source/gdi/pngwrite.cxx:404

reproduced (even if reset profiles) :
Build ID: 1:5.2.2-0ubuntu2 (my original report)
My dev build (Nov 27 f35d29c8388744be1f95ec4acfca12eec706911a)

not reproduced:
LibreOffice_5.2.2.2_Linux_x86-64_deb
LibreOffice_5.2.3.3_Linux_x86-64_deb
master~2016-11-21_22.42.51_LibreOfficeDev_5.3.0.0.alpha1_Linux_x86-64_deb.tar.gz

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source

[Arnaud Versini]

 basic/source/classes/sbxmod.cxx |   16 
 1 file changed, 16 deletions(-)

New commits:
commit 7c0873ab969f64938258b07d9e2bf6f739818a97
Author: Arnaud Versini 
Date:   Sun Nov 27 15:42:04 2016 +0100

BASIC: useless override DocObjectWrapper::acquire and release

Change-Id: Ia8fcb1c5935374376b727075c9bdcbd6a96b3c70
Reviewed-on: https://gerrit.libreoffice.org/31264
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 8b5b97e..eaeeb96 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -100,9 +100,6 @@ class DocObjectWrapper : public DocObjectWrapper_BASE
 public:
 explicit DocObjectWrapper( SbModule* pMod );
 
-virtual void SAL_CALL acquire() throw() override;
-virtual void SAL_CALL release() throw() override;
-
 virtual Sequence< sal_Int8 > SAL_CALL getImplementationId() throw 
(RuntimeException, std::exception) override
 {
 return css::uno::Sequence();
@@ -171,19 +168,6 @@ DocObjectWrapper::DocObjectWrapper( SbModule* pVar ) : 
m_pMod( pVar ), mName( pV
 }
 }
 
-void SAL_CALL
-DocObjectWrapper::acquire() throw ()
-{
-OWeakObject::acquire();
-SAL_INFO("basic","DocObjectWrapper::acquire("<< OUStringToOString( mName, 
RTL_TEXTENCODING_UTF8 ).getStr() << ") 0x" << this << " refcount is now " << 
m_refCount );
-}
-void SAL_CALL
-DocObjectWrapper::release() throw ()
-{
-SAL_INFO("basic","DocObjectWrapper::release("<< OUStringToOString( mName, 
RTL_TEXTENCODING_UTF8 ).getStr() << ") 0x" << this << " decrementing refcount, 
was " << m_refCount );
-OWeakObject::release();
-}
-
 Sequence< Type > SAL_CALL DocObjectWrapper::getTypes()
 throw ( RuntimeException, std::exception )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103236] Some Impress slide transitions crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103236

--- Comment #30 from Kumāra  ---
(In reply to Martin Sourada from comment #29)
> experiencing the same on all Windows computers I tried (all Win 7). On Linux
> this works without issues.



> Graphics card is Intel on both Win and Linux.

Are the the same type/model?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Error in ./setup script

[Jan Iversen]

> I have proxy in me internet service with user authentication. I also used 
> export=http_proxy=http://usern...@userpass...etc etc command in cywgin but 
> that not worked. 
> Can anyone give me solution?

Setup uses a ssh connection and not a http: connection, so you need to make 
sure you ssh works.

rgds
jan I.
 
>  Any help is appreciated.
> 
> Thanks
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Fwd: Bug 89387 - improve performance for some matrix operations

[Jan Iversen]

Forgot reply-all

> Begin forwarded message:
> 
> From: Jan Iversen 
> Subject: Re: Bug 89387 - improve performance for some matrix operations
> Date: 28 November 2016 at 07:57:07 GMT+1
> To: Filippo giacchè 
> 
> Hi
> 
>> --1 has anybody some material that can help me to understand mdds library 
>> ?(some example, some pdf ……)
> Google if your friend, first hit on a search is:
> http://kohei.us/2012/07/20/mdds-multi_type_vector-explained/ 
> 
> 
>> --2 what are the tool for profiling like callgrind?
> we use call grind.
> http://devcentral.libreoffice.org 
> 
> rgds
> jan I.
> 
>> 
>> Kind regards
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org 
>> https://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Error in ./setup script

[Nikhil Kumar vats]

Hello,
I have installed cywgin as mentioned here [https://wiki.
documentfoundation.org/Development/lode]

When I run ./setup its says connection time out.
Here is output:

[image: Inline image 1]


I have proxy in me internet service with user authentication. I also used
export=http_proxy=http://usern...@userpass...etc etc command in cywgin but
that not worked.
Can anyone give me solution?
 Any help is appreciated.

Thanks
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Yossi Zahn license statement

[Jan Iversen]

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svx/source

[Ulrich Gemkow]

 svx/source/sdr/properties/measureproperties.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit ae95f8b7b1b75d0e367db643ad82821ee371a84a
Author: Ulrich Gemkow 
Date:   Sun Nov 6 14:43:58 2016 +0100

tdf#98525 Commit font style change to dimension line object

Change-Id: I59e19e00fd0fdadaa7bffc4fbd1cb79d7e5a9763
Reviewed-on: https://gerrit.libreoffice.org/30609
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/svx/source/sdr/properties/measureproperties.cxx 
b/svx/source/sdr/properties/measureproperties.cxx
index 8781e6a..fe0b362 100644
--- a/svx/source/sdr/properties/measureproperties.cxx
+++ b/svx/source/sdr/properties/measureproperties.cxx
@@ -87,10 +87,15 @@ namespace sdr
 
 void MeasureProperties::SetStyleSheet(SfxStyleSheet* pNewStyleSheet, 
bool bDontRemoveHardAttr)
 {
+// get access to dimension line object
 SdrMeasureObj& rObj = static_cast(GetSdrObject());
 
 // local changes
+
+// mark dimension line text as changed (dirty) in the dimension 
line object
 rObj.SetTextDirty();
+// tdf#98525 ask the dimension line object to redraw the changed 
text
+rObj.UndirtyText();
 
 // call parent
 TextProperties::SetStyleSheet(pNewStyleSheet, bDontRemoveHardAttr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 87410] RTL font fallback in rtl layout when using uniscribe backend results in a total mess

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87410

--- Comment #9 from a6487...@neto.net.il ---
OK, I am now using Version: 5.2.2.2
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad

Good news is that at least the fonts that have full Hebrew coverage seem to
work correctly so far.
However Font fallback is still broken.
Steps to reproduce the bug:
1. Take a default installation of libreoffice.
2. It makes no difference if CTL is enabled or not.
3. Set your keyboard layout to Hebrew.
4. Start typing Hebrew characters.
5. In the default installation the font shown in the font pulldown menu will be
"Mangal" which does not contain Hebrew glyphs. The glyphs will be rendered in
"Tahoma".
6. Type a space character. All the previous Hebrew characters will show now as
boxes.
7. Type another Hebrew character. The display will revert back to Tahoma
8. Type a space. The display will revert to boxes.

and so on

definitely broken!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 77546] QA: Create introductory video

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=77546

--- Comment #9 from jan iversen  ---
(In reply to k-j from comment #7)
> Maybe ask Mike Saunders, as he made many other videos for TDF, or at lists.
> And maybe create a ticket in Redmine: e.g.
> https://redmine.documentfoundation.org/projects/development-mentoring

Videos are a lot more than development-mentoring, so that is not the place to
add it, do add it to marketing, where the other video tasks are.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: owen anderson license statement

[Jan Iversen]

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: John Paul Adrian Glaubitz license statement

[Jan Iversen]

WELCOME
Thanks for your license statement.

We suggest you add yourself to our wiki (remark this is not a demand)
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved

rgds
Jan Iversen.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 94576] Cancelling Input of Search Term in Template Manager also Cancels the Whole Manager Dialogue

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94576

jan iversen  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

[Khaled Hosny]

 vcl/source/gdi/CommonSalLayout.cxx |   76 +++--
 1 file changed, 32 insertions(+), 44 deletions(-)

New commits:
commit 8715f20644483df9fd26b5656f4f64c4ca9f5411
Author: Khaled Hosny 
Date:   Mon Nov 28 07:53:29 2016 +0200

Simplify things a bit

* Drop SortGlyphItems() and update the Kashida insertion code not depend
  on that sorting.
* IS_DIACRITIC flag can now be based solely on the General Category
  property, since it now is used for non-spacing marks not any OpenType
  mark glyph. Pending complete removal.
* Check whether a glyph can take Kashida or not in one place. We need to
  stop second-guessing here and pass explicit Kashida insertion points
  from upper layers.

Change-Id: I39caa126a07d08c5725505615acc0c8f7a14e169
Reviewed-on: https://gerrit.libreoffice.org/31300
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 
(cherry picked from commit f246542d1f61b5253189676688f59e5f952267a1)
Reviewed-on: https://gerrit.libreoffice.org/31301

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index ea7093d..4c5327e 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -598,29 +598,15 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 sal_Int32 indexUtf16 = nCharPos;
 sal_UCS4 aChar = rArgs.mrStr.iterateCodePoints(, 0);
 
-bool bDiacritic = false;
-if (hb_ot_layout_has_glyph_classes(pHbFace))
-{
-// the font has GDEF table
-if (pHbPositions[i].x_advance == 0)
-bDiacritic = hb_ot_layout_get_glyph_class(pHbFace, 
nGlyphIndex) == HB_OT_LAYOUT_GLYPH_CLASS_MARK;
-}
-else
-{
 #if HB_VERSION_ATLEAST(0, 9, 42)
-if (u_getIntPropertyValue(aChar, UCHAR_GENERAL_CATEGORY) 
== U_NON_SPACING_MARK)
-bDiacritic = true;
-#else
-// the font lacks GDEF table
-if (pHbPositions[i].x_advance == 0)
-bDiacritic = true;
-#endif
-}
-
-if (bDiacritic)
+if (u_getIntPropertyValue(aChar, UCHAR_GENERAL_CATEGORY) == 
U_NON_SPACING_MARK)
 nGlyphFlags |= GlyphItem::IS_DIACRITIC;
+#endif
 
-if ((aSubRun.maScript == HB_SCRIPT_ARABIC) || 
(aSubRun.maScript == HB_SCRIPT_SYRIAC))
+if ((aSubRun.maScript == HB_SCRIPT_ARABIC ||
+ aSubRun.maScript == HB_SCRIPT_SYRIAC) &&
+HB_DIRECTION_IS_BACKWARD(aSubRun.maDirection) &&
+!u_isUWhiteSpace(aChar))
 {
 nGlyphFlags |= GlyphItem::ALLOW_KASHIDA;
 rArgs.mnFlags |= SalLayoutFlags::KashidaJustification;
@@ -664,11 +650,6 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 
 hb_buffer_destroy(pHbBuffer);
 
-// sort glyphs in visual order
-// and then in logical order (e.g. diacritics after cluster start)
-// XXX: why?
-SortGlyphItems();
-
 return true;
 }
 
@@ -753,14 +734,10 @@ void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
 int nCharPos = m_GlyphItems[i].mnCharPos - mnMinCharPos;
 DeviceCoordinate nDiff = pNewCharWidths[nCharPos] - 
pOldCharWidths[nCharPos];
 
-// nDiff > 1 to ignore rounding errors.
-if (bKashidaJustify && m_GlyphItems[i].AllowKashida() && nDiff > 1)
-pKashidas[i] = nDiff;
-
-// Adjust the width of the first glyph belonging to current character.
+// Adjust the width of the first glyph in the cluster.
 m_GlyphItems[i].mnNewWidth += nDiff;
 
-// Apply the X position of all glyphs belonging to current character.
+// Apply the X position of all glyphs in the cluster.
 size_t j = i;
 while (j < m_GlyphItems.size())
 {
@@ -773,10 +750,31 @@ void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
 ++j;
 }
 
+// Id this glyph is Kashida-justifiable, then mark this as a Kashida
+// position. Since this must be a RTL glyph, we mark the last glyph in
+// the cluster not the fisrt as this would be the base glyph.
+// nDiff > 1 to ignore rounding errors.
+if (bKashidaJustify && m_GlyphItems[i].AllowKashida() && nDiff > 1)
+{
+pKashidas[j - 1] = nDiff;
+// Move any non-spacing marks attached to this cluster as well.
+// Looping backward because this is RTL glyph.
+if (i > 0)
+{
+auto pGlyph = m_GlyphItems.begin() + i - 1;
+while (pGlyph != m_GlyphItems.begin() && pGlyph->IsDiacritic())
+{
+

[Libreoffice-ux-advise] [Bug 104154] Add list view to template manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104154

jan iversen  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 104154] Add list view to template manager

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104154

jan iversen  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 66765] FILESAVE: saving sheet with some queries in it takes forever ( ~5 minutes)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66765

Aron Budea  changed:

   What|Removed |Added

   Keywords||perf
 CC||ba...@caesar.elte.hu

--- Comment #9 from Aron Budea  ---
Still reproduced with 5.3beta1 / Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104212] Misplaced unicode combining characters with common layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104212

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1599

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101599] [EDITING] Inserting certain Unicode combining characters causes text in paragraph to appear corrupted , when using OpenGL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101599

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4212
 Blocks|103729  |
 Depends on||89870

--- Comment #14 from Aron Budea  ---
I opened bug 104212 as advised.
Can this be closed, as the original issue is gone with the new layout engine?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=89870
[Bug 89870] Unify text layout to use HarfBuzz on all platforms
https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104212] Misplaced unicode combining characters with common layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104212

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||khaledho...@eglug.org,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Confirming based on comments in bug 101599.
I'm not sure if this is to be categorized as a HarfBuzz-regression, Khaled,
please adjust as you see fit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - libreofficekit/source

[Pranav Kant]

 libreofficekit/source/gtk/lokdocview.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 2c7365edbc1577abd9a0fa778d9f77fb7727ae27
Author: Pranav Kant 
Date:   Wed Jul 13 12:02:43 2016 +0530

lokdocview: Add missing callbacks

(cherry picked from commit 5ff1e6bdf7f5b9db3b72d62537047fc45b7d104b)

Change-Id: I2fd32bb210f1b5f0a090c29af707cb6ca6e8dd77

diff --git a/libreofficekit/source/gtk/lokdocview.cxx 
b/libreofficekit/source/gtk/lokdocview.cxx
index aa346ac..133a2ee 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -415,6 +415,10 @@ callbackTypeToString (int nType)
 return "LOK_CALLBACK_CELL_VIEW_CURSOR";
 case LOK_CALLBACK_CELL_FORMULA:
 return "LOK_CALLBACK_CELL_FORMULA";
+case LOK_CALLBACK_UNO_COMMAND_RESULT:
+return "LOK_CALLBACK_UNO_COMMAND_RESULT";
+case LOK_CALLBACK_ERROR:
+return "LOK_CALLBACK_ERROR";
 case LOK_CALLBACK_VIEW_LOCK:
 return "LOK_CALLBACK_VIEW_LOCK";
 case LOK_CALLBACK_REDLINE_TABLE_SIZE_CHANGED:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104212] New: Misplaced unicode combining characters with common layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104212

Bug ID: 104212
   Summary: Misplaced unicode combining characters with common
layout
   Product: LibreOffice
   Version: 5.3.0.0.alpha1+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

Below is a Windows-only issue of the new layout engine originally mentioned in
[1] (using an 5.3 daily build).

Open attachment 128978 (from bug 101599) in Writer.
Note how it looks like the bottom of screenshot attachment 128979.
(the top screenshot is a different issue reported in bug 101599, and not
relevant here)

As Khaled identified in [2]:
"The second line is:
Everything is fine, until I combin \u20dd\u0364.

U+20DD is a combining circle, and U+0364 is a combining superscript e. So
seeing a circle there is expect, but it looks misplaced in your screenshot."

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=101599#c7
[2] https://bugs.documentfoundation.org/show_bug.cgi?id=101599#c13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Khaled Hosny]

 vcl/inc/sallayout.hxx  |1 
 vcl/source/gdi/CommonSalLayout.cxx |   76 +++--
 vcl/source/gdi/sallayout.cxx   |   35 -
 3 files changed, 32 insertions(+), 80 deletions(-)

New commits:
commit f246542d1f61b5253189676688f59e5f952267a1
Author: Khaled Hosny 
Date:   Mon Nov 28 06:43:29 2016 +0200

Simplify things a bit

* Drop SortGlyphItems() and update the Kashida insertion code not depend
  on that sorting.
* IS_DIACRITIC flag can now be based solely on the General Category
  property, since it now is used for non-spacing marks not any OpenType
  mark glyph. Pending complete removal.
* Check whether a glyph can take Kashida or not in one place. We need to
  stop second-guessing here and pass explicit Kashida insertion points
  from upper layers.

Change-Id: I39caa126a07d08c5725505615acc0c8f7a14e169
Reviewed-on: https://gerrit.libreoffice.org/31300
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx
index c20a582..effb646 100644
--- a/vcl/inc/sallayout.hxx
+++ b/vcl/inc/sallayout.hxx
@@ -333,7 +333,6 @@ public:
 virtual voidApplyDXArray(ImplLayoutArgs&) = 0;
 voidJustify(DeviceCoordinate nNewWidth);
 voidApplyAsianKerning(const OUString& rStr);
-voidSortGlyphItems();
 
 // used by upper layers
 virtual DeviceCoordinate GetTextWidth() const override;
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 59a5d80..c61e540 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -598,29 +598,15 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 sal_Int32 indexUtf16 = nCharPos;
 sal_UCS4 aChar = rArgs.mrStr.iterateCodePoints(, 0);
 
-bool bDiacritic = false;
-if (hb_ot_layout_has_glyph_classes(pHbFace))
-{
-// the font has GDEF table
-if (pHbPositions[i].x_advance == 0)
-bDiacritic = hb_ot_layout_get_glyph_class(pHbFace, 
nGlyphIndex) == HB_OT_LAYOUT_GLYPH_CLASS_MARK;
-}
-else
-{
 #if HB_VERSION_ATLEAST(0, 9, 42)
-if (u_getIntPropertyValue(aChar, UCHAR_GENERAL_CATEGORY) 
== U_NON_SPACING_MARK)
-bDiacritic = true;
-#else
-// the font lacks GDEF table
-if (pHbPositions[i].x_advance == 0)
-bDiacritic = true;
-#endif
-}
-
-if (bDiacritic)
+if (u_getIntPropertyValue(aChar, UCHAR_GENERAL_CATEGORY) == 
U_NON_SPACING_MARK)
 nGlyphFlags |= GlyphItem::IS_DIACRITIC;
+#endif
 
-if ((aSubRun.maScript == HB_SCRIPT_ARABIC) || 
(aSubRun.maScript == HB_SCRIPT_SYRIAC))
+if ((aSubRun.maScript == HB_SCRIPT_ARABIC ||
+ aSubRun.maScript == HB_SCRIPT_SYRIAC) &&
+HB_DIRECTION_IS_BACKWARD(aSubRun.maDirection) &&
+!u_isUWhiteSpace(aChar))
 {
 nGlyphFlags |= GlyphItem::ALLOW_KASHIDA;
 rArgs.mnFlags |= SalLayoutFlags::KashidaJustification;
@@ -664,11 +650,6 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
 
 hb_buffer_destroy(pHbBuffer);
 
-// sort glyphs in visual order
-// and then in logical order (e.g. diacritics after cluster start)
-// XXX: why?
-SortGlyphItems();
-
 return true;
 }
 
@@ -753,14 +734,10 @@ void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
 int nCharPos = m_GlyphItems[i].mnCharPos - mnMinCharPos;
 DeviceCoordinate nDiff = pNewCharWidths[nCharPos] - 
pOldCharWidths[nCharPos];
 
-// nDiff > 1 to ignore rounding errors.
-if (bKashidaJustify && m_GlyphItems[i].AllowKashida() && nDiff > 1)
-pKashidas[i] = nDiff;
-
-// Adjust the width of the first glyph belonging to current character.
+// Adjust the width of the first glyph in the cluster.
 m_GlyphItems[i].mnNewWidth += nDiff;
 
-// Apply the X position of all glyphs belonging to current character.
+// Apply the X position of all glyphs in the cluster.
 size_t j = i;
 while (j < m_GlyphItems.size())
 {
@@ -773,10 +750,31 @@ void CommonSalLayout::ApplyDXArray(ImplLayoutArgs& rArgs)
 ++j;
 }
 
+// Id this glyph is Kashida-justifiable, then mark this as a Kashida
+// position. Since this must be a RTL glyph, we mark the last glyph in
+// the cluster not the fisrt as this would be the base glyph.
+// nDiff > 1 to ignore rounding errors.
+if (bKashidaJustify && 

[Libreoffice-commits] online.git: test/TileQueueTests.cpp wsd/DocumentBroker.cpp wsd/TileDesc.hpp

[Ashod Nakashian]

 test/TileQueueTests.cpp |   17 ++---
 wsd/DocumentBroker.cpp  |   24 +++-
 wsd/TileDesc.hpp|3 +--
 3 files changed, 26 insertions(+), 18 deletions(-)

New commits:
commit b8c9163ac8ddfcc3035e95013a34fa0fe2315c80
Author: Ashod Nakashian 
Date:   Sun Nov 27 21:28:21 2016 -0500

loolwsd: combine tiles strictly in the same row only

Change-Id: I1d2ba647deac8da749e7cf7b56a1c9a19fe840f8
Reviewed-on: https://gerrit.libreoffice.org/31299
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/TileQueueTests.cpp b/test/TileQueueTests.cpp
index dea692b..0491468 100644
--- a/test/TileQueueTests.cpp
+++ b/test/TileQueueTests.cpp
@@ -109,24 +109,27 @@ void TileQueueTests::testTileCombinedRendering()
 
 const std::string resHor = "tilecombine part=0 width=256 height=256 
tileposx=0,3840 tileposy=0,0 imgsize=0,0 tilewidth=3840 tileheight=3840";
 const TileQueue::Payload payloadHor(resHor.data(), resHor.data() + 
resHor.size());
-const std::string resVer = "tilecombine part=0 width=256 height=256 
tileposx=0,0 tileposy=0,3840 imgsize=0,0 tilewidth=3840 tileheight=3840";
-const TileQueue::Payload payloadVer(resVer.data(), resVer.data() + 
resVer.size());
-const std::string resFull = "tilecombine part=0 width=256 height=256 
tileposx=0,3840,0 tileposy=0,0,3840 imgsize=0,0,0 tilewidth=3840 
tileheight=3840";
+const std::string resVer1 = "tile part=0 width=256 height=256 tileposx=0 
tileposy=0 tilewidth=3840 tileheight=3840 ver=-1";
+const TileQueue::Payload payloadVer1(resVer1.data(), resVer1.data() + 
resVer1.size());
+const std::string resVer2 = "tile part=0 width=256 height=256 tileposx=0 
tileposy=3840 tilewidth=3840 tileheight=3840 ver=-1";
+const TileQueue::Payload payloadVer2(resVer2.data(), resVer2.data() + 
resVer2.size());
+const std::string resFull = "tilecombine part=0 width=256 height=256 
tileposx=0,3840 tileposy=0,0 imgsize=0,0 tilewidth=3840 tileheight=3840";
 const TileQueue::Payload payloadFull(resFull.data(), resFull.data() + 
resFull.size());
 
 TileQueue queue;
 
-// Horizontal.
+// Horizontal - combine both.
 queue.put(req1);
 queue.put(req2);
 CPPUNIT_ASSERT_EQUAL(payloadHor, queue.get());
 
-// Vertical.
+// Vertical - not combined.
 queue.put(req1);
 queue.put(req3);
-CPPUNIT_ASSERT_EQUAL(payloadVer, queue.get());
+CPPUNIT_ASSERT_EQUAL(payloadVer1, queue.get());
+CPPUNIT_ASSERT_EQUAL(payloadVer2, queue.get());
 
-// Vertical.
+// Vertical - combine first row only.
 queue.put(req1);
 queue.put(req2);
 queue.put(req3);
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 886cf98..ed5b726 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -591,18 +591,24 @@ size_t DocumentBroker::removeSession(const std::string& 
id)
 {
 Util::assertIsLocked(_mutex);
 
-auto it = _sessions.find(id);
-if (it != _sessions.end())
+try
 {
-_sessions.erase(it);
+Admin::instance().rmDoc(_docKey, id);
 
-// Let the child know the client has disconnected.
-const std::string msg("child-" + id + " disconnect");
-_childProcess->sendTextFrame(msg);
-}
+auto it = _sessions.find(id);
+if (it != _sessions.end())
+{
+_sessions.erase(it);
 
-// Lets remove this session from the admin console too
-Admin::instance().rmDoc(_docKey, id);
+// Let the child know the client has disconnected.
+const std::string msg("child-" + id + " disconnect");
+_childProcess->sendTextFrame(msg);
+}
+}
+catch (const std::exception& ex)
+{
+LOG_ERR("Error while removing session [" << id << "]: " << ex.what());
+}
 
 return _sessions.size();
 }
diff --git a/wsd/TileDesc.hpp b/wsd/TileDesc.hpp
index 765341d..3e12408 100644
--- a/wsd/TileDesc.hpp
+++ b/wsd/TileDesc.hpp
@@ -104,8 +104,7 @@ public:
 return false;
 }
 
-return other.getTilePosY() + other.getTileHeight() >= getTilePosY() &&
-   other.getTilePosY() <= getTilePosY() + getTileHeight();
+return other.getTilePosY() == getTilePosY();
 }
 
 /// Serialize this instance into a string.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src wsd/LOOLWSD.cpp wsd/protocol.txt

[Ashod Nakashian]

 loleaflet/src/core/Socket.js |   30 
 wsd/LOOLWSD.cpp  |   45 ++-
 wsd/protocol.txt |4 ++-
 3 files changed, 73 insertions(+), 6 deletions(-)

New commits:
commit 2b9ea3d4a68e7483e837426bda178e489ae7a4b2
Author: Ashod Nakashian 
Date:   Sun Nov 27 19:11:30 2016 -0500

loolwsd: notify clients before recycling wsd

Change-Id: Ib2733a6af1c27fe39c54f5c3bc6f5bd3acb72a2b
Reviewed-on: https://gerrit.libreoffice.org/31298
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index eab6ca8..40c4cf2 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -195,6 +195,36 @@ L.Socket = L.Class.extend({
else if (textMsg === 'shuttingdown') {
msg = _('Server is shutting down for 
maintenance (auto-saving)');
}
+   else if (textMsg === 'recycling') {
+   msg = _('Server is recycling and will be 
available shortly');
+
+   this._map._active = false;
+
+   // Prevent reconnecting the world at the same 
time.
+   var min = 5000;
+   var max = 1;
+   var timeoutMs = Math.floor(Math.random() * (max 
- min) + min);
+
+   socket = this;
+   map = this._map;
+   vex.timer = setInterval(function() {
+   if (socket.connected()) {
+   // We're connected: cancel 
timer and dialog.
+   clearTimeout(vex.timer);
+   if (vex.dialogID > 0) {
+   var id = vex.dialogID;
+   vex.dialogID = -1;
+   vex.close(id);
+   }
+   return;
+   }
+
+   try {
+   socket.initialize(map);
+   } catch (error) {
+   }
+   }, timeoutMs);
+   }
 
// Close any open dialogs first.
if (vex.dialogID > 0) {
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 25a4bab..6b143a4 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -175,6 +175,10 @@ static std::atomic OutstandingForks(1); // Forkit 
always spawns 1.
 static std::map DocBrokers;
 static std::mutex DocBrokersMutex;
 
+/// Used when shutting down to notify them all that the server is recycling.
+static std::vector ClientWebSockets;
+static std::mutex ClientWebSocketsMutex;
+
 #if ENABLE_DEBUG
 static int careerSpanSeconds = 0;
 #endif
@@ -983,6 +987,13 @@ private:
 }
 }
 
+if (SigUtil::isShuttingDown())
+{
+std::lock_guard lock(ClientWebSocketsMutex);
+LOG_TRC("Capturing Client WS for [" << id << "]");
+ClientWebSockets.push_back(ws);
+}
+
 LOOLWSD::dumpEventTrace(docBroker->getJailId(), id, "EndSession: " 
+ uri);
 LOG_INF("Finishing GET request handler for session [" << id << 
"].");
 }
@@ -1011,11 +1022,14 @@ private:
 }
 else
 {
-// something wrong, with internal exceptions
-LOG_TRC("Abnormal close handshake.");
-session->closeFrame();
-// FIXME: handle exception thrown from here ? ...
-ws->shutdown(WebSocket::WS_ENDPOINT_GOING_AWAY);
+if (!SigUtil::isShuttingDown())
+{
+// something wrong, with internal exceptions
+LOG_TRC("Abnormal close handshake.");
+session->closeFrame();
+// FIXME: handle exception thrown from here ? ...
+ws->shutdown(WebSocket::WS_ENDPOINT_GOING_AWAY);
+}
 }
 
 LOG_INF("Finished GET request handler for session [" << id << "].");
@@ -2149,6 +2163,27 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 FileUtil::removeFile(path, true);
 }
 
+if (SigUtil::isShuttingDown())
+{
+// At this point there should be no other thread, but...
+std::lock_guard lock(ClientWebSocketsMutex);
+
+LOG_INF("Notifying clients that 

[Libreoffice-bugs] [Bug 104159] Switching between windows is slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104159

--- Comment #7 from Khaled Hosny  ---
That is know issue on Windows, we don’t currently cache the glyphs when doing
OpenGL rendering with the new layout engine as we did before. Unfortunately I
don’t have OpenGL enabled, so someone else will need to look into this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - loleaflet/src wsd/LOOLWSD.cpp

[Ashod Nakashian]

 loleaflet/src/map/Map.js |   12 +---
 wsd/LOOLWSD.cpp  |   15 ---
 2 files changed, 13 insertions(+), 14 deletions(-)

New commits:
commit c0f9ccee425a3bef5efbebccc19afecd371eeddc
Author: Ashod Nakashian 
Date:   Sun Nov 27 18:10:50 2016 -0500

loleaflet: activate and dismiss dialogs only upon reconnection

Change-Id: I2d8b3d9788b7f66bc746537e34c90493a7cb408a
Reviewed-on: https://gerrit.libreoffice.org/31296
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index aaa04ac..317bf7c 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -746,16 +746,14 @@ L.Map = L.Evented.extend({
this._socket.sendMessage('useractive');
this._active = true;
this._docLayer._onMessage('invalidatetiles: 
EMPTY', null);
+   if (vex.dialogID > 0) {
+   var id = vex.dialogID;
+   vex.dialogID = -1;
+   return vex.close(id);
+   }
} else {
-   this._active = true;
this._socket.initialize(this);
}
-
-   if (vex.dialogID > 0) {
-   var id = vex.dialogID;
-   vex.dialogID = -1;
-   return vex.close(id);
-   }
}
 
return false;
commit 68519f09278eb2c7d35f014008b42f25fc972c77
Author: Ashod Nakashian 
Date:   Sun Nov 27 19:07:32 2016 -0500

loolwsd: destroy DocBrokers sooner

Change-Id: I10d8ea57083c3b785748062a927574a63e0dd250
Reviewed-on: https://gerrit.libreoffice.org/31297
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index bb1285a..25a4bab 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2114,10 +2114,15 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 LOG_INF("Stopping server socket listening. ShutdownFlag: " <<
 SigUtil::isShuttingDown() << ", TerminationFlag: " << 
TerminationFlag);
 
+// Wait until documents are saved and sessions closed.
 srv.stop();
 srv2.stop();
 threadPool.joinAll();
 
+// atexit handlers tend to free Admin before Documents
+LOG_INF("Cleaning up lingering documents.");
+DocBrokers.clear();
+
 // Terminate child processes
 LOG_INF("Requesting forkit process " << forKitPid << " to terminate.");
 SigUtil::killChild(forKitPid);
@@ -2133,7 +2138,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 waitpid(forKitPid, , WUNTRACED);
 close(ForKitWritePipe);
 
-// In case forkit didn't cleanup fully.'
+// In case forkit didn't cleanup properly, don't leave jails behind.
 LOG_INF("Cleaning up childroot directory [" << ChildRoot << "].");
 std::vector jails;
 File(ChildRoot).list(jails);
@@ -2144,21 +2149,17 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 FileUtil::removeFile(path, true);
 }
 
+// Finally, we no longer need SSL.
 if (LOOLWSD::isSSLEnabled())
 {
 Poco::Net::uninitializeSSL();
 Poco::Crypto::uninitializeCrypto();
 }
 
-// atexit handlers tend to free Admin before Documents
-LOG_INF("Cleaning up lingering documents.");
-DocBrokers.clear();
-
-LOG_INF("Process [loolwsd] finished.");
-
 int returnValue = Application::EXIT_OK;
 UnitWSD::get().returnValue(returnValue);
 
+LOG_INF("Process [loolwsd] finished.");
 return returnValue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104176] FILESAVE: disk error when saving an .ods spreasheet with more than 2500 rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104176

--- Comment #4 from tommy27  ---
there's no attachment here.

you have to access the bug report page with your web browser at this URL:
https://bugs.documentfoundation.org/show_bug.cgi?id=104176

then click on the "Add an attachement" button

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/SigUtil.cpp loleaflet/src wsd/protocol.txt

[Ashod Nakashian]

 common/SigUtil.cpp   |2 +-
 loleaflet/src/core/Socket.js |   16 +---
 wsd/protocol.txt |6 ++
 3 files changed, 16 insertions(+), 8 deletions(-)

New commits:
commit 2239f25684a9bf0d236246f2e716e5aa79244e97
Author: Ashod Nakashian 
Date:   Sun Nov 27 18:08:51 2016 -0500

Renamed 'shutdown' to 'shuttingdown'

Change-Id: Idae53a59af13eb54b1f18f1a8cd1dde06421b426
Reviewed-on: https://gerrit.libreoffice.org/31295
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/SigUtil.cpp b/common/SigUtil.cpp
index 02443df..4a6882e 100644
--- a/common/SigUtil.cpp
+++ b/common/SigUtil.cpp
@@ -257,7 +257,7 @@ namespace SigUtil
 if (ShutdownRequestFlag)
 {
 LOG_INF("Shutdown requested. Initiating WSD shutdown.");
-Util::alertAllUsers("close: shutdown");
+Util::alertAllUsers("close: shuttingdown");
 ShutdownFlag = true;
 return true;
 }
diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index e3799b6..eab6ca8 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -192,8 +192,8 @@ L.Socket = L.Class.extend({
if (textMsg === 'ownertermination') {
msg = _('Session terminated by document owner');
}
-   else if (textMsg === 'shutdown') {
-   msg = _('Server shutdown for maintenance');
+   else if (textMsg === 'shuttingdown') {
+   msg = _('Server is shutting down for 
maintenance (auto-saving)');
}
 
// Close any open dialogs first.
@@ -230,12 +230,14 @@ L.Socket = L.Class.extend({
$(options.appendLocation).append(options.$vex);
vex.setupBodyClassName(options.$vex);
 
-   // Disconnect the websocket manually
-   this.close();
+   if (textMsg !== 'shuttingdown') {
+   // Tell WOPI host about it which should handle 
this situation
+   this._map.fire('postMessage', {msgId: 
'Session_Closed'});
+   }
 
-   // Tell WOPI host about it which should handle this 
situation
-   this._map.fire('postMessage', {msgId: 
'Session_Closed'});
-   this._map.remove();
+   if (textMsg === 'ownertermination') {
+   this._map.remove();
+   }
 
return;
}
diff --git a/wsd/protocol.txt b/wsd/protocol.txt
index 85470a4..2ebdc33 100644
--- a/wsd/protocol.txt
+++ b/wsd/protocol.txt
@@ -248,6 +248,12 @@ close: 
 ability to kill all other sessions if EnableOwnerTermination flag in WOPI
 CheckFileInfo is 'true' (assumed to be 'false' by default).
 
+
+* shuttingdown - Sent when the server is going down in a graceful fashion.
+The server doesn't disconnect from clients yet, but starts
+saving document and tearing down internals.
+
+
 getchildid: id=
 
 Returns the child id
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104159] Switching between windows is slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104159

--- Comment #6 from Aron Budea  ---
With common layout disabled (SET SAL_NO_COMMON_LAYOUT=1), switching between
windows is instantaneous even with OpenGL enabled. That's why it wasn't present
in 5.3alpha1, and turns out bibisecting it is unnecessary.

This might actually be a slight general performance regression with the new
layout engine, I see that navigating through menus is a bit slower as well
(hardly noticeable, but noticeable).

I'm not sure if this affects Linux, with OpenGL I can only test in Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: common/Png.hpp kit/Kit.cpp

[Ashod Nakashian]

 common/Png.hpp |6 ++
 kit/Kit.cpp|   28 ++--
 2 files changed, 24 insertions(+), 10 deletions(-)

New commits:
commit b35725ab709864ad8680cc84986d27048687c5d3
Author: Ashod Nakashian 
Date:   Sun Nov 27 11:55:19 2016 -0500

loolwsd: support more efficient full-buffer hashing

Change-Id: Ie30929ad4665b51e280c1126adde645742814dad
Reviewed-on: https://gerrit.libreoffice.org/31294
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Png.hpp b/common/Png.hpp
index 96fa165..b4ff059 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -160,6 +160,12 @@ bool encodeBufferToPNG(unsigned char* pixmap, int width, 
int height,
 }
 
 inline
+uint64_t hashBuffer(unsigned char* pixmap, int width, int height)
+{
+return SpookyHash::Hash64(pixmap, width * height * 4, 1073741789);
+}
+
+inline
 uint64_t hashSubBuffer(unsigned char* pixmap, size_t startX, size_t startY,
int width, int height, int bufferWidth, int 
bufferHeight)
 {
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index f070b3a..28df0d8 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -348,15 +348,9 @@ class PngCache
 bool cacheEncodeSubBufferToPNG(unsigned char* pixmap, size_t startX, 
size_t startY,
int width, int height,
int bufferWidth, int bufferHeight,
-   std::vector& output, 
LibreOfficeKitTileMode mode)
+   std::vector& output, 
LibreOfficeKitTileMode mode,
+   const uint64_t hash)
 {
-uint64_t hash = png::hashSubBuffer(pixmap, startX, startY, width, 
height,
-   bufferWidth, bufferHeight);
-if (cacheTest(hash, output))
-{
-return true;
-}
-
 LOG_DBG("PNG cache with hash " << hash << " missed.");
 CacheEntry newEntry(bufferWidth * bufferHeight * 1);
 if (png::encodeSubBufferToPNG(pixmap, startX, startY, width, height,
@@ -390,16 +384,30 @@ public:
 bool encodeBufferToPNG(unsigned char* pixmap, int width, int height,
std::vector& output, LibreOfficeKitTileMode 
mode)
 {
+const uint64_t hash = png::hashBuffer(pixmap, width, height);
+if (cacheTest(hash, output))
+{
+return true;
+}
+
 return cacheEncodeSubBufferToPNG(pixmap, 0, 0, width, height,
- width, height, output, mode);
+ width, height, output, mode, hash);
 }
+
 bool encodeSubBufferToPNG(unsigned char* pixmap, size_t startX, size_t 
startY,
   int width, int height,
   int bufferWidth, int bufferHeight,
   std::vector& output, 
LibreOfficeKitTileMode mode)
 {
+const uint64_t hash = png::hashSubBuffer(pixmap, startX, startY, 
width, height,
+ bufferWidth, bufferHeight);
+if (cacheTest(hash, output))
+{
+return true;
+}
+
 return cacheEncodeSubBufferToPNG(pixmap, startX, startY, width, height,
- bufferWidth, bufferHeight, output, 
mode);
+ bufferWidth, bufferHeight, output, 
mode, hash);
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/Kit.cpp

[Ashod Nakashian]

 kit/Kit.cpp |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit da30dc3df3f5502586ab7da0e56b260621fdc39e
Author: Ashod Nakashian 
Date:   Sun Nov 27 11:22:21 2016 -0500

loolwsd: factor out the png cache lookup

Change-Id: Id287b136b687d9bc4f49a3583e18cb820f4eb21e
Reviewed-on: https://gerrit.libreoffice.org/31293
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 0836b1e..f070b3a 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -322,13 +322,10 @@ class PngCache
 }
 }
 
-bool cacheEncodeSubBufferToPNG(unsigned char* pixmap, size_t startX, 
size_t startY,
-   int width, int height,
-   int bufferWidth, int bufferHeight,
-   std::vector& output, 
LibreOfficeKitTileMode mode)
+/// Lookup an entry in the cache and store the data in output.
+/// Returns true on success, otherwise false.
+bool cacheTest(const uint64_t hash, std::vector& output)
 {
-uint64_t hash = png::hashSubBuffer(pixmap, startX, startY, width, 
height,
-   bufferWidth, bufferHeight);
 if (hash)
 {
 ++_cacheTests;
@@ -345,6 +342,21 @@ class PngCache
 }
 }
 
+return false;
+}
+
+bool cacheEncodeSubBufferToPNG(unsigned char* pixmap, size_t startX, 
size_t startY,
+   int width, int height,
+   int bufferWidth, int bufferHeight,
+   std::vector& output, 
LibreOfficeKitTileMode mode)
+{
+uint64_t hash = png::hashSubBuffer(pixmap, startX, startY, width, 
height,
+   bufferWidth, bufferHeight);
+if (cacheTest(hash, output))
+{
+return true;
+}
+
 LOG_DBG("PNG cache with hash " << hash << " missed.");
 CacheEntry newEntry(bufferWidth * bufferHeight * 1);
 if (png::encodeSubBufferToPNG(pixmap, startX, startY, width, height,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Png.hpp common/SpookyV2.cpp common/SpookyV2.h Makefile.am

[Ashod Nakashian]

 Makefile.am |1 
 common/Png.hpp  |   18 +-
 common/SpookyV2.cpp |  351 
 common/SpookyV2.h   |  299 
 4 files changed, 662 insertions(+), 7 deletions(-)

New commits:
commit 47fa3b1b10eb2b14a1540086cfc8555ff9095ef8
Author: Ashod Nakashian 
Date:   Sun Nov 27 10:38:35 2016 -0500

loolwsd: use a better hash function for png caching

We need a fast and good (high avalanche properties)
hash function for the png caching to avoid collissions
(even in the very limited samples we have, since tiles
are likely to have patters, such as all 0's and all 1's
etc.).

Bob Jenkins's public domain SpookyV2 is used here.
It has great avalanache properties and is fast at
~3-bytes / cycle for large messages.

Only trailing whitespace was removed from original
sources and 4 tabs converted to spaces.

Change-Id: Ife57237321625c836d85c894d939fd04a8f577bb
Reviewed-on: https://gerrit.libreoffice.org/31292
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/Makefile.am b/Makefile.am
index 63908d6..5f120ad 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -40,6 +40,7 @@ shared_sources = common/FileUtil.cpp \
  common/Session.cpp \
  common/MessageQueue.cpp \
  common/SigUtil.cpp \
+ common/SpookyV2.cpp \
  common/Unit.cpp \
  common/UnitHTTP.cpp \
  common/Util.cpp
diff --git a/common/Png.hpp b/common/Png.hpp
index eb18aa9..96fa165 100644
--- a/common/Png.hpp
+++ b/common/Png.hpp
@@ -50,6 +50,8 @@
 
 #include 
 
+#include "SpookyV2.h"
+
 namespace png
 {
 
@@ -165,16 +167,18 @@ uint64_t hashSubBuffer(unsigned char* pixmap, size_t 
startX, size_t startY,
 return 0; // magic invalid hash.
 
 // assume a consistent mode - RGBA vs. BGRA for process
-uint64_t nHash = 1073741789;
+SpookyHash hash;
+hash.Init(1073741789, 1073741789); // Seeds can be anything.
 for (int y = 0; y < height; ++y)
 {
-size_t position = ((startY + y) * bufferWidth * 4) + (startX * 4);
-uint32_t *rgba = reinterpret_cast(pixmap + position);
-// Lameness for now.
-for (int x = 0; x < width; ++x)
-nHash = (nHash << 7) + rgba[x] - nHash;
+const size_t position = ((startY + y) * bufferWidth * 4) + (startX * 
4);
+hash.Update(pixmap + position, width * 4);
 }
-return nHash;
+
+uint64_t nHash1;
+uint64_t nHash2;
+hash.Final(, );
+return nHash1;
 }
 
 static
diff --git a/common/SpookyV2.cpp b/common/SpookyV2.cpp
new file mode 100644
index 000..55f1cb1
--- /dev/null
+++ b/common/SpookyV2.cpp
@@ -0,0 +1,351 @@
+// Spooky Hash
+// A 128-bit noncryptographic hash, for checksums and table lookup
+// By Bob Jenkins.  Public domain.
+//   Oct 31 2010: published framework, disclaimer ShortHash isn't right
+//   Nov 7 2010: disabled ShortHash
+//   Oct 31 2011: replace End, ShortMix, ShortEnd, enable ShortHash again
+//   April 10 2012: buffer overflow on platforms without unaligned reads
+//   July 12 2012: was passing out variables in final to in/out in short
+//   July 30 2012: I reintroduced the buffer overflow
+//   August 5 2012: SpookyV2: d = should be d += in short hash, and remove 
extra mix from long hash
+
+#include 
+#include "SpookyV2.h"
+
+#define ALLOW_UNALIGNED_READS 1
+
+//
+// short hash ... it could be used on any message,
+// but it's used by Spooky just for short messages.
+//
+void SpookyHash::Short(
+const void *message,
+size_t length,
+uint64 *hash1,
+uint64 *hash2)
+{
+uint64 buf[2*sc_numVars];
+union
+{
+const uint8 *p8;
+uint32 *p32;
+uint64 *p64;
+size_t i;
+} u;
+
+u.p8 = (const uint8 *)message;
+
+if (!ALLOW_UNALIGNED_READS && (u.i & 0x7))
+{
+memcpy(buf, message, length);
+u.p64 = buf;
+}
+
+size_t remainder = length%32;
+uint64 a=*hash1;
+uint64 b=*hash2;
+uint64 c=sc_const;
+uint64 d=sc_const;
+
+if (length > 15)
+{
+const uint64 *end = u.p64 + (length/32)*4;
+
+// handle all complete sets of 32 bytes
+for (; u.p64 < end; u.p64 += 4)
+{
+c += u.p64[0];
+d += u.p64[1];
+ShortMix(a,b,c,d);
+a += u.p64[2];
+b += u.p64[3];
+}
+
+//Handle the case of 16+ remaining bytes.
+if (remainder >= 16)
+{
+c += u.p64[0];
+d += u.p64[1];
+ShortMix(a,b,c,d);
+u.p64 += 2;
+remainder -= 16;
+}
+}
+
+// Handle the last 0..15 bytes, and its length
+d += ((uint64)length) << 56;
+switch (remainder)
+{
+case 15:
+d += 

[Libreoffice-commits] online.git: kit/Kit.cpp

[Ashod Nakashian]

 kit/Kit.cpp |   14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

New commits:
commit ef9ab9458027d5ed3480447725f54aa51d180a40
Author: Ashod Nakashian 
Date:   Sun Nov 27 00:59:04 2016 -0500

loolwsd: less aggressive png cache eviction

The overall hit-rate improves significantly
when we don't remove entries too soon.
Here we give entries more time to show their
merrit.

There are now two limits, soft and hard.
The former is used to remove entries with no
hits at all, while the latter is used to
avoid overflowing the cache footprint too
much. Entries also get started with a single
hit, which prevents them getting evicted
too soon (i.e. right after getting added).

Finally, there is no longer need to reduce
the hit count of entries too agressively
since we have two tiers (soft and hard limits)
and zero-hit entries are removed before others.

The average cache size while auto-typing in
Writer doc is less than 180kb, which is 1.4x
the original size of 128kb.

Change-Id: I946318151638c9c64c714190084c492f9098852b
Reviewed-on: https://gerrit.libreoffice.org/31291
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 68099cf..0836b1e 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -271,13 +271,15 @@ class PngCache
 size_t_hitCount;
 CacheData _data;
 CacheEntry(size_t defaultSize) :
-_hitCount(0),
+_hitCount(1),   // Every entry is used at least once; prevent 
removal at birth.
 _data( new std::vector< char >() )
 {
 _data->reserve( defaultSize );
 }
 } ;
 size_t _cacheSize;
+static const size_t CacheSizeSoftLimit = (1024 * 4 * 32); // 128k of cache
+static const size_t CacheSizeHardLimit = CacheSizeSoftLimit * 2;
 size_t _cacheHits;
 size_t _cacheTests;
 std::map< uint64_t, CacheEntry > _cache;
@@ -286,7 +288,7 @@ class PngCache
 {
 // A normalish PNG image size for text in a writer document is
 // around 4k for a content tile, and sub 1k for a background one.
-if (_cacheSize > (1024 * 4 * 32) /* 128k of cache */)
+if (_cacheSize > CacheSizeHardLimit)
 {
 size_t avgHits = 0;
 for (auto it = _cache.begin(); it != _cache.end(); ++it)
@@ -299,14 +301,18 @@ class PngCache
 
 for (auto it = _cache.begin(); it != _cache.end();)
 {
-if (it->second._hitCount <= avgHits)
+if ((_cacheSize > CacheSizeSoftLimit && it->second._hitCount 
== 0) ||
+(_cacheSize > CacheSizeHardLimit && it->second._hitCount > 
0 && it->second._hitCount <= avgHits))
 {
+// Shrink cache when we exceed the size to maximize
+// the chance of hitting these entries in the future.
 _cacheSize -= it->second._data->size();
 it = _cache.erase(it);
 }
 else
 {
-it->second._hitCount /= 2;
+if (it->second._hitCount > 0)
+it->second._hitCount--;
 ++it;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: kit/Kit.cpp

[Ashod Nakashian]

 kit/Kit.cpp |   22 +-
 1 file changed, 17 insertions(+), 5 deletions(-)

New commits:
commit 9608935a7c2b64cc5294f491c007d9013d85d12a
Author: Ashod Nakashian 
Date:   Sun Nov 27 00:58:30 2016 -0500

loolwsd: png cache hit rate and cosmetics

Change-Id: I66ab1738503618002bb05504c608969d5aa7b9a9
Reviewed-on: https://gerrit.libreoffice.org/31290
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 15fd559..68099cf 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -278,6 +278,8 @@ class PngCache
 }
 } ;
 size_t _cacheSize;
+size_t _cacheHits;
+size_t _cacheTests;
 std::map< uint64_t, CacheEntry > _cache;
 
 void balanceCache()
@@ -291,7 +293,8 @@ class PngCache
 avgHits += it->second._hitCount;
 
 LOG_DBG("cache " << _cache.size() << " items total size " <<
-_cacheSize << " total hits " << avgHits << " at balance 
start");
+_cacheSize << " current hits " << avgHits << ", total hit 
rate " <<
+(_cacheHits * 100. / _cacheTests) << "% at balance start");
 avgHits /= _cache.size();
 
 for (auto it = _cache.begin(); it != _cache.end();)
@@ -299,7 +302,7 @@ class PngCache
 if (it->second._hitCount <= avgHits)
 {
 _cacheSize -= it->second._data->size();
-_cache.erase(it++);
+it = _cache.erase(it);
 }
 else
 {
@@ -320,10 +323,13 @@ class PngCache
 {
 uint64_t hash = png::hashSubBuffer(pixmap, startX, startY, width, 
height,
bufferWidth, bufferHeight);
-if (hash) {
+if (hash)
+{
+++_cacheTests;
 auto it = _cache.find(hash);
 if (it != _cache.end())
 {
+++_cacheHits;
 LOG_DBG("PNG cache with hash " << hash << " hit.");
 output.insert(output.end(),
   it->second._data->begin(),
@@ -332,6 +338,7 @@ class PngCache
 return true;
 }
 }
+
 LOG_DBG("PNG cache with hash " << hash << " missed.");
 CacheEntry newEntry(bufferWidth * bufferHeight * 1);
 if (png::encodeSubBufferToPNG(pixmap, startX, startY, width, height,
@@ -340,9 +347,10 @@ class PngCache
 {
 if (hash)
 {
-_cache.insert(std::pair< uint64_t, CacheEntry >( hash, 
newEntry ));
+_cache.emplace(hash, newEntry);
 _cacheSize += newEntry._data->size();
 }
+
 output.insert(output.end(),
   newEntry._data->begin(),
   newEntry._data->end());
@@ -354,9 +362,13 @@ class PngCache
 }
 
 public:
-PngCache() : _cacheSize(0)
+PngCache() :
+_cacheSize(0),
+_cacheHits(0),
+_cacheTests(0)
 {
 }
+
 bool encodeBufferToPNG(unsigned char* pixmap, int width, int height,
std::vector& output, LibreOfficeKitTileMode 
mode)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104159] Switching between windows is slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104159

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |notBibisectable
 CC||khaledho...@eglug.org
 Blocks||103729

--- Comment #5 from Aron Budea  ---
With common layout disabled (SET SAL_NO_COMMON_LAYOUT=1), switching between
windows is instantaneous even with OpenGL enabled. That's why it wasn't present
in 5.3alpha1, and turns out bibisecting it is unnecessary.

This might actually be a slight general performance regression with the new
layout engine


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |9 +
 1 file changed, 9 insertions(+)

New commits:
commit db996c7e900c0f89edda805503120860875c2f76
Author: Ashod Nakashian 
Date:   Sat Nov 26 22:47:55 2016 -0500

loolwsd: retry shutting down the WS upon exception

Change-Id: I3dc4b6f73c1ef5641c32e756099428a8ef38ee82
Reviewed-on: https://gerrit.libreoffice.org/31288
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 64eabf0..bb1285a 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -225,6 +225,15 @@ void shutdownLimitReached(LOOLWebSocket& ws)
 catch (const std::exception& ex)
 {
 LOG_ERR("Error while shuting down socket on reaching limit: " << 
ex.what());
+try
+{
+// Persist, in case it was unrelated error.
+ws.shutdown(WebSocket::WS_POLICY_VIOLATION);
+}
+catch (const std::exception&)
+{
+// Nothing to do.
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/MessageQueue.cpp common/MessageQueue.hpp

[Ashod Nakashian]

 common/MessageQueue.cpp |6 +++---
 common/MessageQueue.hpp |3 +--
 2 files changed, 4 insertions(+), 5 deletions(-)

New commits:
commit f4dd9c1e11cd266ad79d5a20f7af613d9d530d92
Author: Ashod Nakashian 
Date:   Sat Nov 26 22:47:17 2016 -0500

loolwsd: use vector instead of deque for MessageQueue

Change-Id: I879d248e54748916b30c64874ddc237fb662ac11
Reviewed-on: https://gerrit.libreoffice.org/31289
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp
index 12a2abb..d9696e1 100644
--- a/common/MessageQueue.cpp
+++ b/common/MessageQueue.cpp
@@ -78,7 +78,7 @@ bool MessageQueue::wait_impl() const
 MessageQueue::Payload MessageQueue::get_impl()
 {
 Payload result = _queue.front();
-_queue.pop_front();
+_queue.erase(_queue.begin());
 return result;
 }
 
@@ -206,7 +206,7 @@ void TileQueue::deprioritizePreviews()
 break;
 }
 
-_queue.pop_front();
+_queue.erase(_queue.begin());
 _queue.push_back(front);
 }
 }
@@ -224,7 +224,7 @@ MessageQueue::Payload TileQueue::get_impl()
 {
 // Don't combine non-tiles or tiles with id.
 LOG_TRC("MessageQueue res: " << msg);
-_queue.pop_front();
+_queue.erase(_queue.begin());
 
 // de-prioritize the other tiles with id - usually the previews in
 // Impress
diff --git a/common/MessageQueue.hpp b/common/MessageQueue.hpp
index 96834ae..3cd023b 100644
--- a/common/MessageQueue.hpp
+++ b/common/MessageQueue.hpp
@@ -13,7 +13,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -65,7 +64,7 @@ protected:
 
 void clear_impl();
 
-std::deque _queue;
+std::vector _queue;
 };
 
 /** MessageQueue specialized for priority handling of tiles.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/IoUtil.cpp

[Ashod Nakashian]

 common/IoUtil.cpp |   12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

New commits:
commit b16fb68ec61188365db40a38f7f5209b65158988
Author: Ashod Nakashian 
Date:   Sat Nov 26 22:39:48 2016 -0500

loolwsd: shrink SocketProcessor buffer when too large

When receiving large messages the dynamic socket buffer
is resized to accomodate the incoming large message.

This buffer was previously never reduced in size.
This is an obvious leak that is now avoided.

When the buffer grows beyond quadruple the default
size, it is shrunk back to the default. This gives
a decent balance between memory waste and unnecessary
resizing up and down after each large message received.

Change-Id: Ic3996c80e96592af6f12c4abd1dd737bdc07b814
Reviewed-on: https://gerrit.libreoffice.org/31287
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp
index 768ab95..b4751ac 100644
--- a/common/IoUtil.cpp
+++ b/common/IoUtil.cpp
@@ -54,12 +54,12 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 int n = -1;
 bool stop = false;
 std::vector payload(READ_BUFFER_SIZE);
+payload.resize(0);
 try
 {
+// We poll, no need for timeout.
 ws->setReceiveTimeout(0);
 
-payload.resize(0);
-
 for (;;)
 {
 stop = stopPredicate();
@@ -161,6 +161,14 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 LOG_INF("SocketProcessor [" << name << "]: Handler flagged to 
finish.");
 break;
 }
+
+if (payload.capacity() > READ_BUFFER_SIZE * 4)
+{
+LOG_INF("Compacting buffer of SocketProcessor [" << name << "] 
from " <<
+payload.capacity() / 1024 << "KB to " << 
READ_BUFFER_SIZE / 1024 << "KB.");
+payload = std::vector(READ_BUFFER_SIZE);
+payload.resize(0);
+}
 }
 }
 catch (const std::exception& exc)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Common.hpp common/IoUtil.cpp test/helpers.hpp wsd/LOOLWebSocket.hpp

[Ashod Nakashian]

 common/Common.hpp |   10 --
 common/IoUtil.cpp |9 -
 test/helpers.hpp  |4 ++--
 wsd/LOOLWebSocket.hpp |   12 +++-
 4 files changed, 17 insertions(+), 18 deletions(-)

New commits:
commit 6ab32e0aa9e5c6a292d5722ef8c943d5d510af53
Author: Ashod Nakashian 
Date:   Sat Nov 26 22:28:48 2016 -0500

loolwsd: use larger threshold to large messages

Messages larger than a certain size are preambled
with a 'nextmessage' message that hold the size
of the subsequent message.

This is a workaround to a limitation the Poco
WebSocket API where if the buffer size is
smaller than the received frame the socket
ends up in a bad state and must be closed.
Unfortunately the new API that avoids this
workaround is not yet released by Poco.

Here we minimize the need for 'nextmessage'
to truely large messages. The limit is now
raised from above 1KB to over 63KB.

We may raise this limit further, but that will
cost each socket that much dedicated buffer size.

Change-Id: I01e4c68cdbe67e413c04a9725152224a87ab8267
Reviewed-on: https://gerrit.libreoffice.org/31286
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Common.hpp b/common/Common.hpp
index 0223be8..5a002a1 100644
--- a/common/Common.hpp
+++ b/common/Common.hpp
@@ -28,11 +28,17 @@ constexpr int WS_JITTER_MS = 5;
 /// Pipe and Socket read buffer size.
 /// Should be large enough for ethernet packets
 /// which can be 1500 bytes long.
-constexpr int READ_BUFFER_SIZE = 2048;
+constexpr int READ_BUFFER_SIZE = 64 * 1024;
+
+/// Size beyond which messages will be sent preceded with
+/// 'nextmessage' frame to let the receiver know in advance
+/// the size of the larger coming message. All messages up to,
+/// but not including, this size are considered small messages.
+constexpr int LARGE_MESSAGE_SIZE = READ_BUFFER_SIZE - 512;
 
 /// Message larger than this will be dropped as invalid
 /// or as intentionally flooding the server.
-constexpr int MAX_MESSAGE_SIZE = 100 * 1024 * READ_BUFFER_SIZE;
+constexpr int MAX_MESSAGE_SIZE = 2 * 1024 * READ_BUFFER_SIZE;
 
 constexpr auto JAILED_DOCUMENT_ROOT = "/user/docs/";
 constexpr auto CHILD_URI = "/loolws/child?";
diff --git a/common/IoUtil.cpp b/common/IoUtil.cpp
index 6ae507c..768ab95 100644
--- a/common/IoUtil.cpp
+++ b/common/IoUtil.cpp
@@ -50,11 +50,10 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 
 // Timeout given is in microseconds.
 static const Poco::Timespan waitTime(POLL_TIMEOUT_MS * 1000);
-const auto bufferSize = READ_BUFFER_SIZE * 100;
 int flags = 0;
 int n = -1;
 bool stop = false;
-std::vector payload(bufferSize);
+std::vector payload(READ_BUFFER_SIZE);
 try
 {
 ws->setReceiveTimeout(0);
@@ -81,8 +80,8 @@ void SocketProcessor(const std::shared_ptr& ws,
 {
 payload.resize(payload.capacity());
 n = -1;
-n = ws->receiveFrame(payload.data(), payload.capacity(), 
flags);
-payload.resize(n > 0 ? n : 0);
+n = ws->receiveFrame(payload.data(), payload.size(), flags);
+payload.resize(std::max(n, 0));
 }
 catch (const Poco::TimeoutException&)
 {
@@ -107,7 +106,7 @@ void SocketProcessor(const std::shared_ptr& 
ws,
 LOG_WRN("SocketProcessor [" << name << "]: Receiving 
multi-parm frame.");
 while (true)
 {
-char buffer[READ_BUFFER_SIZE * 10];
+char buffer[READ_BUFFER_SIZE];
 n = ws->receiveFrame(buffer, sizeof(buffer), flags);
 if (n <= 0 || (flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_CLOSE)
 {
diff --git a/test/helpers.hpp b/test/helpers.hpp
index b33dcb4..9ab7855 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -212,7 +212,7 @@ std::vector getResponseMessage(LOOLWebSocket& ws, 
const std::string& prefi
 
 response.resize(READ_BUFFER_SIZE);
 int bytes = ws.receiveFrame(response.data(), response.size(), 
flags);
-response.resize(bytes >= 0 ? bytes : 0);
+response.resize(std::max(bytes, 0));
 std::cerr << name << "Got " << 
LOOLProtocol::getAbbreviatedFrameDump(response.data(), bytes, flags) << 
std::endl;
 const auto message = LOOLProtocol::getFirstLine(response);
 if (bytes > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE)
@@ -228,7 +228,7 @@ std::vector getResponseMessage(LOOLWebSocket& ws, 
const std::string& prefi
 {
 response.resize(size);
 bytes = ws.receiveFrame(response.data(), 

[Libreoffice-commits] online.git: common/MessageQueue.cpp test/helpers.hpp

[Ashod Nakashian]

 common/MessageQueue.cpp |   10 +-
 test/helpers.hpp|2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit a8f3263132bee4b59bb9f72fdb54113751193bbe
Author: Ashod Nakashian 
Date:   Sat Nov 26 22:24:35 2016 -0500

loolwsd: use more efficient matchPrefix

Change-Id: I6f34b314295335270ff4da2827517d818c6a62ab
Reviewed-on: https://gerrit.libreoffice.org/31285
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/MessageQueue.cpp b/common/MessageQueue.cpp
index b32fdeb..12a2abb 100644
--- a/common/MessageQueue.cpp
+++ b/common/MessageQueue.cpp
@@ -152,7 +152,7 @@ void TileQueue::put_impl(const Payload& value)
 
 void TileQueue::removeDuplicate(const std::string& tileMsg)
 {
-assert(LOOLProtocol::getFirstToken(tileMsg) == "tile");
+assert(LOOLProtocol::matchPrefix("tile", tileMsg, /*ignoreWhitespace*/ 
true));
 
 // Ver is always provided at this point and it is necessary to
 // return back to clients the last rendered version of a tile
@@ -200,7 +200,7 @@ void TileQueue::deprioritizePreviews()
 
 // stop at the first non-tile or non-'id' (preview) message
 std::string id;
-if (LOOLProtocol::getFirstToken(message) != "tile" ||
+if (!LOOLProtocol::matchPrefix("tile", message) ||
 !LOOLProtocol::getTokenStringFromMessage(message, "id", id))
 {
 break;
@@ -218,7 +218,7 @@ MessageQueue::Payload TileQueue::get_impl()
 auto msg = std::string(front.data(), front.size());
 
 std::string id;
-bool isTile = (LOOLProtocol::getFirstToken(msg) == "tile");
+bool isTile = LOOLProtocol::matchPrefix("tile", msg);
 bool isPreview = isTile && LOOLProtocol::getTokenStringFromMessage(msg, 
"id", id);
 if (!isTile || isPreview)
 {
@@ -246,7 +246,7 @@ MessageQueue::Payload TileQueue::get_impl()
 // avoid starving - stop the search when we reach a non-tile,
 // otherwise we may keep growing the queue of unhandled stuff (both
 // tiles and non-tiles)
-if (LOOLProtocol::getFirstToken(prio) != "tile" ||
+if (!LOOLProtocol::matchPrefix("tile", prio) ||
 LOOLProtocol::getTokenStringFromMessage(prio, "id", id))
 {
 break;
@@ -277,7 +277,7 @@ MessageQueue::Payload TileQueue::get_impl()
 {
 auto& it = _queue[i];
 msg = std::string(it.data(), it.size());
-if (LOOLProtocol::getFirstToken(msg) != "tile" ||
+if (!LOOLProtocol::matchPrefix("tile", msg) ||
 LOOLProtocol::getTokenStringFromMessage(msg, "id", id))
 {
 // Don't combine non-tiles or tiles with id.
diff --git a/test/helpers.hpp b/test/helpers.hpp
index a10cc53..b33dcb4 100644
--- a/test/helpers.hpp
+++ b/test/helpers.hpp
@@ -324,7 +324,7 @@ bool isDocumentLoaded(LOOLWebSocket& ws, const std::string& 
name = "", bool isVi
 {
 const std::string prefix = isView ? "status:" : "statusindicatorfinish:";
 const auto message = getResponseString(ws, prefix, name);
-return LOOLProtocol::getFirstToken(message) == prefix;
+return LOOLProtocol::matchPrefix(prefix, message);
 }
 
 inline
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Protocol.cpp

[Ashod Nakashian]

 common/Protocol.cpp |   20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)

New commits:
commit 86b38a29de0808305c928b7261463b542bcd86be
Author: Ashod Nakashian 
Date:   Sun Nov 20 16:16:13 2016 -0500

loolwsd: fast in-place getTokenStringFromMessage

Change-Id: I5a7a7402c9394ac72aca907fc8b1072f6d2df5ad
Reviewed-on: https://gerrit.libreoffice.org/31284
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Protocol.cpp b/common/Protocol.cpp
index 6cd5455..ad02f0f 100644
--- a/common/Protocol.cpp
+++ b/common/Protocol.cpp
@@ -157,8 +157,24 @@ namespace LOOLProtocol
 
 bool getTokenStringFromMessage(const std::string& message, const 
std::string& name, std::string& value)
 {
-Poco::StringTokenizer tokens(message, " \n", 
StringTokenizer::TOK_IGNORE_EMPTY | StringTokenizer::TOK_TRIM);
-return getTokenString(tokens, name, value);
+if (message.size() > name.size() + 1)
+{
+auto pos = message.find(name);
+while (pos != std::string::npos)
+{
+const auto beg = pos + name.size();
+if (message[beg] == '=')
+{
+const auto end = message.find_first_of(" \n", beg);
+value = message.substr(beg + 1, end - beg - 1);
+return true;
+}
+
+pos = message.find(name, pos + name.size());
+}
+}
+
+return false;
 }
 
 bool getTokenKeywordFromMessage(const std::string& message, const 
std::string& name, const std::map& map, int& value)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: .gitignore

[Ashod Nakashian]

 .gitignore |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 456c666cc9c9ceea98bb03d5ce5b96a816cb2dc8
Author: Ashod Nakashian 
Date:   Fri Nov 25 17:26:18 2016 -0500

.gitignore editor dot files

Change-Id: If48670b2fb0c5c9eb71dedccfc7e1b46706c109c
Reviewed-on: https://gerrit.libreoffice.org/31283
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/.gitignore b/.gitignore
index d98297b..adfe2e1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,7 @@
 .cxx_tags
 .yavide_proj
 .yavide_session
+.vscode
 Makefile
 Makefile.in
 loolwsd.spec
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 83066] [META] Tracking bug for CJK issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
Bug 83066 depends on bug 100936, which changed state.

Bug 100936 Summary: Incorrect glyph orientation of Tangut script on vertical 
layout mode
https://bugs.documentfoundation.org/show_bug.cgi?id=100936

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 100936, which changed state.

Bug 100936 Summary: Incorrect glyph orientation of Tangut script on vertical 
layout mode
https://bugs.documentfoundation.org/show_bug.cgi?id=100936

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100936] Incorrect glyph orientation of Tangut script on vertical layout mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100936

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100936] Incorrect glyph orientation of Tangut script on vertical layout mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100936

--- Comment #20 from V Stuart Foote  ---
Created attachment 129058
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129058=edit
sample Tangut text as paragraphs in a new 4 colum RTL vertical page

(In reply to Volga from comment #19)
> 
> What happened if you close OGL?

That's odd, with OpenGL _disabled_ the vertical text is not rotated in either
the original attachment 128274 document's RTL vertical Text Frame--or with the
same paragraphs copied into a multi-column RTL page in a new 5.4.0.0aplpha0+
document (attached).

Enable OpenGL and either document renders correctly.

Sample document attached uses the BableStone Tangut Wenhai (Version 1.002 May
21, 2016).

On Windows 10 Pro 64-bit (1607) en-US with
Version: 5.4.0.0.alpha0+
Build ID: 9691cea443a74885b3f81c602efdd3345de1e3f9
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; Layout Engine: new; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-11-24_14:26:28
Locale: en-US (en_US); Calc: CL

@Khaled?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - kit/ChildSession.cpp loleaflet/dist loleaflet/src

[Henry Castro]

 kit/ChildSession.cpp  |2 +-
 loleaflet/dist/toolbar/toolbar.js |5 +
 loleaflet/src/layer/tile/TileLayer.js |3 +--
 loleaflet/src/map/handler/Map.Keyboard.js |   12 
 4 files changed, 19 insertions(+), 3 deletions(-)

New commits:
commit 02095a3387fb0d32d577142b684ef425cb6e1e6d
Author: Henry Castro 
Date:   Sun Nov 27 21:19:55 2016 -0400

loleaflet: notify repair document when exists a conflict of multiple ..

.. users undo/redo

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index 80cdd08..1eb56d4 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1206,6 +1206,11 @@ map.on('commandresult', function (e) {
window.parent.documentsMain.saveDocumentBack();
}
}
+   else if ((commandName === '.uno:Undo' || commandName === '.uno:Redo') &&
+   e.success === true && e.result.value && e.result.value === 
'130') { /*UNDO_CONFLICT*/
+   $('#tb_toolbar-up_item_repair').w2overlay({ html: '' +
+   _('Conflict Undo/Redo with multiple users. Please use 
document repair to resolve') + ''});
+   }
 });
 
 map.on('cellformula', function (e) {
diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index ba5e5d7..aee3833 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -973,8 +973,7 @@ L.TileLayer = L.GridLayer.extend({
}
 
this._map.hideBusy();
-   // TODO when implemented in the LOK, add also obj.result
-   this._map.fire('commandresult', {commandName: commandName, 
success: success});
+   this._map.fire('commandresult', {commandName: commandName, 
success: success, result: obj.result});
 
},
 
diff --git a/loleaflet/src/map/handler/Map.Keyboard.js 
b/loleaflet/src/map/handler/Map.Keyboard.js
index 1a6988b..2a35423 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -383,6 +383,18 @@ L.Map.Keyboard = L.Handler.extend({
e.originalEvent.preventDefault();
}
 
+   if (e.originalEvent.ctrlKey && (e.originalEvent.key === 'z' || 
e.originalEvent.key === 'Z')) {
+   this._map._socket.sendMessage('uno .uno:Undo');
+   e.originalEvent.preventDefault();
+   return true;
+   }
+
+   if (e.originalEvent.ctrlKey && (e.originalEvent.key === 'y' || 
e.originalEvent.key === 'Y')) {
+   this._map._socket.sendMessage('uno .uno:Redo');
+   e.originalEvent.preventDefault();
+   return true;
+   }
+
if (e.originalEvent.altKey || e.originalEvent.shiftKey) {
 
// need to handle Ctrl + Alt + C separately for Firefox
commit ddd91b4251a9d98c2c84709aa5cf6f8d9cd065ce
Author: Henry Castro 
Date:   Sun Nov 27 20:53:11 2016 -0400

kit: enable notify undo/redo commands

diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index 66e532b..65868cf 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -787,7 +787,7 @@ bool ChildSession::unoCommand(const char* /*buffer*/, int 
/*length*/, StringToke
 }
 
 // we need to get LOK_CALLBACK_UNO_COMMAND_RESULT callback when saving
-const bool bNotify = (tokens[1] == ".uno:Save");
+const bool bNotify = (tokens[1] == ".uno:Save" || tokens[1] == ".uno:Undo" 
|| tokens[1] == ".uno:Redo");
 
 std::unique_lock lock(_docManager.getDocumentMutex());
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - desktop/source sw/inc sw/qa sw/source

[Henry Castro]

 desktop/source/lib/init.cxx|8 +-
 sw/inc/editsh.hxx  |1 
 sw/inc/swundo.hxx  |3 
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   99 +
 sw/source/core/edit/edws.cxx   |3 
 sw/source/core/undo/docundo.cxx|   12 +++
 sw/source/uibase/shells/annotsh.cxx|   30 ++-
 sw/source/uibase/shells/basesh.cxx |   50 +---
 sw/source/uibase/wrtsh/wrtundo.cxx |2 
 9 files changed, 186 insertions(+), 22 deletions(-)

New commits:
commit 6161b19ac5e521668e698bc22e34fce169f98d2b
Author: Henry Castro 
Date:   Thu Nov 24 07:09:38 2016 -0400

sw lok: notify repair when exist a conflict of multiple users undo/redo

Change-Id: I026f4df6239fa87ee191f92127f9fa98ac2993eb
Reviewed-on: https://gerrit.libreoffice.org/31161
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 3e91af8..ea266b1 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -323,6 +323,11 @@ static boost::property_tree::ptree 
unoAnyToPropertyTree(const uno::Any& anyItem)
 
 if (aType == "string")
 aTree.put("value", anyItem.get().toUtf8().getStr());
+else if (aType == "unsigned long")
+aTree.put("value", 
OString::number(anyItem.get()).getStr());
+else if (aType == "long")
+aTree.put("value", OString::number(anyItem.get()).getStr());
+
 // TODO: Add more as required
 
 return aTree;
@@ -1812,8 +1817,7 @@ public:
 aTree.put("success", bSuccess);
 }
 
-// TODO UNO Any rEvent.Result -> JSON
-// aTree.put("result": "...");
+aTree.add_child("result", unoAnyToPropertyTree(rEvent.Result));
 
 std::stringstream aStream;
 boost::property_tree::write_json(aStream, aTree);
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index e0ab5c7..987c5c0 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -565,6 +565,7 @@ public:
  SwUndoId *const o_pId,
  const SwView* pView = nullptr) const;
 bool GetFirstRedoInfo(OUString *const o_pStr,
+  SwUndoId *const o_pId,
   const SwView* pView = nullptr) const;
 SwUndoId GetRepeatInfo(OUString *const o_pStr) const;
 
diff --git a/sw/inc/swundo.hxx b/sw/inc/swundo.hxx
index 5c5f197..ef5e15f 100644
--- a/sw/inc/swundo.hxx
+++ b/sw/inc/swundo.hxx
@@ -168,7 +168,8 @@ enum SwUndoId
 UNDO_UI_REPLACE_STYLE,
 UNDO_UI_DELETE_PAGE_BREAK,
 UNDO_UI_TEXT_CORRECTION,
-UNDO_UI_TABLE_DELETE
+UNDO_UI_TABLE_DELETE,
+UNDO_CONFLICT
 };
 
 #endif
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index b787352..ecd32c3 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -79,6 +80,9 @@ public:
 void testCommentEndTextEdit();
 void testCursorPosition();
 void testPaintCallbacks();
+void testUndoRepairResult();
+void testRedoRepairResult();
+
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -121,6 +125,9 @@ public:
 CPPUNIT_TEST(testCommentEndTextEdit);
 CPPUNIT_TEST(testCursorPosition);
 CPPUNIT_TEST(testPaintCallbacks);
+CPPUNIT_TEST(testUndoRepairResult);
+CPPUNIT_TEST(testRedoRepairResult);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -755,6 +762,30 @@ public:
 }
 };
 
+class TestResultListener : public 
cppu::WeakImplHelper
+{
+public:
+sal_uInt32 m_nDocRepair;
+
+TestResultListener() : m_nDocRepair(0)
+{
+}
+
+virtual void SAL_CALL dispatchFinished(const 
css::frame::DispatchResultEvent& rEvent)
+throw(css::uno::RuntimeException, std::exception) override
+{
+if (rEvent.State == frame::DispatchResultState::SUCCESS)
+{
+rEvent.Result >>= m_nDocRepair;
+}
+}
+
+virtual void SAL_CALL disposing(const css::lang::EventObject&)
+throw (css::uno::RuntimeException, std::exception) override
+{
+}
+};
+
 void SwTiledRenderingTest::testMissingInvalidation()
 {
 comphelper::LibreOfficeKit::setActive();
@@ -1580,6 +1611,74 @@ void SwTiledRenderingTest::testPaintCallbacks()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void SwTiledRenderingTest::testUndoRepairResult()
+{
+// Load a document and create two views.
+comphelper::LibreOfficeKit::setActive();
+SwXTextDocument* pXTextDocument = createDoc("dummy.fodt");
+int nView1 = SfxLokHelper::getView();
+SfxLokHelper::createView();
+TestResultListener* pResult2 = 

[Libreoffice-bugs] [Bug 104211] Fails to save previous state for undo when I `Import MathML from clipboard`

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104211

--- Comment #1 from Mark Stenglein  ---
After thinking about it for a few minutes, I feel like it might be simple
enough to fix by just running whatever code is run when you click out of the
formula that saves the formula into the Writer document.

I'm not familiar with the LibreOffice code base so I can't get too specific,
but I feel like if this were run before the `Import MathML from clipboard` it
would give the History log a checkpoint to return to in case that function has
unexpected behavior for the user.

I'm a college student so I don't have a _huge_ amount of time to play with to
dive into the code base, but I might be able to look specifically at it
soon...ish.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

[Henry Castro]

 loleaflet/src/control/Control.CharacterMap.js |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 2c2d4601729509ab8d9ac6bbcde3d8330d43c58c
Author: Henry Castro 
Date:   Sun Nov 27 23:06:58 2016 -0400

loleaflet: forgot remove console.log

only debugging purpose

diff --git a/loleaflet/src/control/Control.CharacterMap.js 
b/loleaflet/src/control/Control.CharacterMap.js
index c17c443..3ec35ee 100644
--- a/loleaflet/src/control/Control.CharacterMap.js
+++ b/loleaflet/src/control/Control.CharacterMap.js
@@ -297,7 +297,6 @@ L.Control.CharacterMap = L.Control.extend({
img.src = L.Icon.Default.imagePath + 
'/loading.gif';
this.cacheGlyph[encodedFont + encodedChar] = 
img;
this._map._socket.sendMessage('renderfont 
font=' + encodedFont + ' char=' + encodedChar);
-   console.log('send=' + 
start.toString(16).toUpperCase() + ' encoded='  +encodedFont + encodedChar);
}
L.DomEvent.on(td, 'click', this._onSymbolClick, this);
L.DomEvent.on(td, 'dblclick', this._onSymbolDblClick, 
this);
@@ -442,8 +441,6 @@ L.Control.CharacterMap = L.Control.extend({
_onRenderFontPreview: function (e) {
if (this.cacheGlyph[e.font + e.char]) {
this.cacheGlyph[e.font + e.char].src = e.img;
-   } else {
-   console.log('failed to get font image' + e.font + 
e.char);
}
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: 3 commits - kit/ChildSession.cpp loleaflet/dist loleaflet/src wsd/ClientSession.cpp wsd/PrisonerSession.cpp wsd/protocol.txt

[Henry Castro]

 kit/ChildSession.cpp  |   17 --
 loleaflet/dist/images/loading.gif |binary
 loleaflet/src/control/Control.CharacterMap.js |   41 ++
 loleaflet/src/core/Socket.js  |5 ++-
 loleaflet/src/layer/tile/TileLayer.js |1 
 wsd/ClientSession.cpp |5 +--
 wsd/PrisonerSession.cpp   |7 ++--
 wsd/protocol.txt  |3 +
 8 files changed, 56 insertions(+), 23 deletions(-)

New commits:
commit 6947e914e1d71ed8ec228f2a524faff383c006c0
Author: Henry Castro 
Date:   Sun Nov 27 22:47:36 2016 -0400

loleaflet: re-work special character dialog to render all glyphs

.. on server side

diff --git a/loleaflet/dist/images/loading.gif 
b/loleaflet/dist/images/loading.gif
new file mode 100755
index 000..f8f3dff
Binary files /dev/null and b/loleaflet/dist/images/loading.gif differ
diff --git a/loleaflet/src/control/Control.CharacterMap.js 
b/loleaflet/src/control/Control.CharacterMap.js
index 550fff6..c17c443 100644
--- a/loleaflet/src/control/Control.CharacterMap.js
+++ b/loleaflet/src/control/Control.CharacterMap.js
@@ -274,22 +274,34 @@ L.Control.CharacterMap = L.Control.extend({
],
 
cacheSubset: {},
+   cacheGlyph: {},
 
fillCharacters: function (index) {
var start = this.unicodeBlocks[index].start;
var end = this.unicodeBlocks[index].end;
+   var encodedFont = 
window.encodeURIComponent(this._fontNames.options[this._fontNames.selectedIndex].value);
var it = 0;
-   var tr, td;
+   var tr, td, img, encodedChar;
L.DomUtil.empty(this._tbody);
while (start <= end) {
if (it % 20 === 0) {
tr = L.DomUtil.create('tr', '', this._tbody);
}
td = L.DomUtil.create('td', '', tr);
-   td.innerHTML = '

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - desktop/source

[Henry Castro]

 desktop/source/lib/init.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 55dacde0428bc0444648e96e3791b9733a85a4b7
Author: Henry Castro 
Date:   Sun Nov 27 19:40:57 2016 -0400

lok: avoid render font with empty rectangle

Change-Id: I58e24e0de37144ae5d67857b243e6a7091f2b77a
Reviewed-on: https://gerrit.libreoffice.org/31281
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 8b8391f..3e91af8 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2587,6 +2587,9 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* 
/*pThis*/,
 aFont.SetSize(Size(0, 25));
 aDevice->SetFont(aFont);
 aDevice->GetTextBoundRect(aRect, aText);
+if (aRect.IsEmpty())
+break;
+
 int nFontWidth = aRect.BottomRight().X() + 1;
 *pFontWidth = nFontWidth;
 int nFontHeight = aRect.BottomRight().Y() + 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104211] New: Fails to save previous state for undo when I `Import MathML from clipboard`

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104211

Bug ID: 104211
   Summary: Fails to save previous state for undo when I `Import
MathML from clipboard`
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@stengle.in

Description:
In Writer, while editing a formula, if you use the `Import MathML from
clipboard` function, it clears the entire contents of the formula and does not
allow you to undo any wrong usage of this function.

In my particular case, I was trying to get a specific element that I didn't
know the exact syntax for in LibreOffice's syntax, so I copied the specific
language in MathML, and it wiped the entire contents of the formula. It's a bit
annoying to have to retype it all.

I am running the latest version, and have not tested to see if it also does
this in other builds.

Steps to Reproduce:
1.Insert>Object>Formula
2.Type in something to show in the formula on screen.
3.Copy some xml-ish text into your clipboard `Test` should do
nicely.
4.Tools>Import MathML from Clipboard

Actual Results:  
As described, it clears the entire formula and does not let you use the `undo`
feature to get anything back.

Expected Results:
I would expect to be able to undo this operation and get my formula back.


Reproducible: Always

User Profile Reset: No

Additional Info:
Technically this causes you to lose data (the last few minutes of typing into
the formula) but I wouldn't really consider this anywhere near Critical. So
normal it is, it should be fixed.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source sw/inc sw/qa sw/source

[Henry Castro]

 desktop/source/lib/init.cxx|8 +-
 sw/inc/editsh.hxx  |1 
 sw/inc/swundo.hxx  |3 
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   99 +
 sw/source/core/edit/edws.cxx   |3 
 sw/source/core/undo/docundo.cxx|   12 +++
 sw/source/uibase/shells/annotsh.cxx|   30 ++-
 sw/source/uibase/shells/basesh.cxx |   50 +---
 sw/source/uibase/wrtsh/wrtundo.cxx |2 
 9 files changed, 186 insertions(+), 22 deletions(-)

New commits:
commit 2db42ab241d0852d89a470b18727c22d0fc06745
Author: Henry Castro 
Date:   Thu Nov 24 07:09:38 2016 -0400

sw lok: notify repair when exist a conflict of multiple users undo/redo

Change-Id: I026f4df6239fa87ee191f92127f9fa98ac2993eb
Reviewed-on: https://gerrit.libreoffice.org/31161
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 2ecfddc..fa3446e 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -329,6 +329,11 @@ static boost::property_tree::ptree 
unoAnyToPropertyTree(const uno::Any& anyItem)
 
 if (aType == "string")
 aTree.put("value", anyItem.get().toUtf8().getStr());
+else if (aType == "unsigned long")
+aTree.put("value", 
OString::number(anyItem.get()).getStr());
+else if (aType == "long")
+aTree.put("value", OString::number(anyItem.get()).getStr());
+
 // TODO: Add more as required
 
 return aTree;
@@ -1806,8 +1811,7 @@ public:
 aTree.put("success", bSuccess);
 }
 
-// TODO UNO Any rEvent.Result -> JSON
-// aTree.put("result": "...");
+aTree.add_child("result", unoAnyToPropertyTree(rEvent.Result));
 
 std::stringstream aStream;
 boost::property_tree::write_json(aStream, aTree);
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index 2bc0d30..c65d4e5 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -564,6 +564,7 @@ public:
  SwUndoId *const o_pId,
  const SwView* pView = nullptr) const;
 bool GetFirstRedoInfo(OUString *const o_pStr,
+  SwUndoId *const o_pId,
   const SwView* pView = nullptr) const;
 SwUndoId GetRepeatInfo(OUString *const o_pStr) const;
 
diff --git a/sw/inc/swundo.hxx b/sw/inc/swundo.hxx
index e33ee7b..c87b5e5 100644
--- a/sw/inc/swundo.hxx
+++ b/sw/inc/swundo.hxx
@@ -171,7 +171,8 @@ enum SwUndoId
 UNDO_UI_REPLACE_STYLE,
 UNDO_UI_DELETE_PAGE_BREAK,
 UNDO_UI_TEXT_CORRECTION,
-UNDO_UI_TABLE_DELETE
+UNDO_UI_TABLE_DELETE,
+UNDO_CONFLICT
 };
 
 #endif
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 19a4066..c9829f2 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -10,6 +10,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -78,6 +79,9 @@ public:
 void testCommentEndTextEdit();
 void testCursorPosition();
 void testPaintCallbacks();
+void testUndoRepairResult();
+void testRedoRepairResult();
+
 
 CPPUNIT_TEST_SUITE(SwTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -120,6 +124,9 @@ public:
 CPPUNIT_TEST(testCommentEndTextEdit);
 CPPUNIT_TEST(testCursorPosition);
 CPPUNIT_TEST(testPaintCallbacks);
+CPPUNIT_TEST(testUndoRepairResult);
+CPPUNIT_TEST(testRedoRepairResult);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -754,6 +761,30 @@ public:
 }
 };
 
+class TestResultListener : public 
cppu::WeakImplHelper
+{
+public:
+sal_uInt32 m_nDocRepair;
+
+TestResultListener() : m_nDocRepair(0)
+{
+}
+
+virtual void SAL_CALL dispatchFinished(const 
css::frame::DispatchResultEvent& rEvent)
+throw(css::uno::RuntimeException, std::exception) override
+{
+if (rEvent.State == frame::DispatchResultState::SUCCESS)
+{
+rEvent.Result >>= m_nDocRepair;
+}
+}
+
+virtual void SAL_CALL disposing(const css::lang::EventObject&)
+throw (css::uno::RuntimeException, std::exception) override
+{
+}
+};
+
 void SwTiledRenderingTest::testMissingInvalidation()
 {
 comphelper::LibreOfficeKit::setActive();
@@ -1572,6 +1603,74 @@ void SwTiledRenderingTest::testPaintCallbacks()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void SwTiledRenderingTest::testUndoRepairResult()
+{
+// Load a document and create two views.
+comphelper::LibreOfficeKit::setActive();
+SwXTextDocument* pXTextDocument = createDoc("dummy.fodt");
+int nView1 = SfxLokHelper::getView();
+SfxLokHelper::createView();
+TestResultListener* pResult2 = 

[Libreoffice-bugs] [Bug 100936] Incorrect glyph orientation of Tangut script on vertical layout mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100936

--- Comment #19 from Volga  ---
(In reply to V Stuart Foote from comment #18)
> Created attachment 129052 [details]
> sample Tangut script document with rotated Unicode 9.0 glyphs
> 
> (In reply to Volga from comment #17)
> >  Can anyone else confirm this on 5.3.0 beta1?
> 
> Yes it is working correctly at 5.3.0beta1. See attached screen clip...
> 
> I'll send Andrew West at BableStone a note asking his thoughts about support
> for Tangut and status of his Tangut Wenhai font.

What happened if you close OGL?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Henry Castro]

 desktop/source/lib/init.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit e2d5f1ba3fd0db00276cf48b0d9be9b16dcbf7a0
Author: Henry Castro 
Date:   Sun Nov 27 19:40:57 2016 -0400

lok: avoid render font with empty rectangle

Change-Id: I58e24e0de37144ae5d67857b243e6a7091f2b77a
Reviewed-on: https://gerrit.libreoffice.org/31281
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 0d403e3..2ecfddc 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2581,6 +2581,9 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* 
/*pThis*/,
 aFont.SetFontSize(Size(0, 25));
 aDevice->SetFont(aFont);
 aDevice->GetTextBoundRect(aRect, aText);
+if (aRect.IsEmpty())
+break;
+
 int nFontWidth = aRect.BottomRight().X() + 1;
 *pFontWidth = nFontWidth;
 int nFontHeight = aRect.BottomRight().Y() + 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 40780] Impress Animation Sound Effect not played after file moved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=40780

--- Comment #35 from ammine007  ---
(In reply to Buovjaga from comment #33)
> (In reply to Luke from comment #32)
> > Julien's on the right track. If you create slide with an Animation Sound
> > Effect and save it, it will work. If you copy that file to a different
> > directory, the sound will no longer play. The reason why there was so much
> > confusion over this bug, is that sound effect work until the file that they
> > were created in is moved to a new location. 
> 
> This is not true. If you create a custom animation with a sound effect from
> the LibO gallery *on Linux*, it will not work at any point. You don't have
> to save, you don't have to move the file - it just won't work. I can
> reproduce this from scratch on Arch Linux with 5.2.3 / 5.3 and Ubuntu with
> 5.2.3. Same for version 3.6.7.2 on Arch.
> On Windows it works perfectly.

Salamu Alaikum,

I've tested the two versions of LibreOffice Impress. The first one (LO-5.2.3.1)
on Debian 9 Stretch 64bits and the second one (5.2.3.3) on Win XP 32bits.
Here is the link to both versions :
https://www.dropbox.com/s/rigc2ctg71iel38/LibreOfficeVersions.png?dl=0

I Confirm, There is no sound, even without moving the created ODP Animation
file.
I've tried to open the content.xml inside the ODP animation; and replace all
sounds links with the Complete path from Root of my partition
/home/myuser/Documents/MySoundFile.flac

But still no sound! This is a serious bug that has now some years without being
solved.

Thank you in advance
I really hope it will be resolved very soon!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - desktop/source

[Henry Castro]

 desktop/source/lib/init.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c3d25b8b74867b5b8419d09f6e362aa6c8eae34f
Author: Henry Castro 
Date:   Sun Nov 27 19:24:16 2016 -0400

lok: in preinit stage, do not force locale

force locale load some fonts before the lokit process
is jail rooted, so it causes invalid rendering special
characters in doc_renderFont function

Reviewed-on: https://gerrit.libreoffice.org/31280
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

Conflicts:
desktop/source/lib/init.cxx

Change-Id: I25f00e5bb947753b820c6966a99a6c3849413315

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 2ea1165..8b8391f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2891,8 +2891,6 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 // Release Solar Mutex, lo_startmain thread should acquire it.
 Application::ReleaseSolarMutex();
 }
-
-force_c_locale();
 }
 
 // This is horrible crack. I really would want to go back to simply 
just call
@@ -2916,6 +2914,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 
 if (eStage != PRE_INIT)
 {
+force_c_locale();
+
 SAL_INFO("lok", "Enabling OfficeIPCThread");
 OfficeIPCThread::EnableOfficeIPCThread();
 SAL_INFO("lok", "Starting soffice_main");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104176] FILESAVE: disk error when saving an .ods spreasheet with more than 2500 rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104176

--- Comment #3 from david a austin  ---
I added a file in my original bug report you should have it. if not how do i
attach it to this bug report

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Henry Castro]

 desktop/source/lib/init.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit af18b7d60f4320fc01b84593af404dbfb4237fcf
Author: Henry Castro 
Date:   Sun Nov 27 19:24:16 2016 -0400

lok: in preinit stage, do not force locale

force locale load some fonts before the lokit process
is jail rooted, so it causes invalid rendering special
characters in doc_renderFont function

Change-Id: I25f00e5bb947753b820c6966a99a6c3849413315
Reviewed-on: https://gerrit.libreoffice.org/31280
Tested-by: Jenkins 
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 362ee61..0d403e3 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2903,8 +2903,6 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 // Release Solar Mutex, lo_startmain thread should acquire it.
 Application::ReleaseSolarMutex();
 }
-
-force_c_locale();
 }
 
 // We could use InitVCL() here -- and used to before using 
soffice_main,
@@ -2927,6 +2925,8 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 
 if (eStage != PRE_INIT)
 {
+force_c_locale();
+
 SAL_INFO("lok", "Enabling RequestHandler");
 RequestHandler::Enable(false);
 SAL_INFO("lok", "Starting soffice_main");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - starmath/source

[Takeshi Abe]

 starmath/source/node.cxx |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit b55cd9c8cc3167a9efe8d59101f4aa6bbf068337
Author: Takeshi Abe 
Date:   Sun Nov 27 03:55:57 2016 +0900

starmath: Separate color name and operand by space

Otherwise, errors happen at MathML import.

Change-Id: I17037b430710ea4d26340e7ce13c7972a76f614f
Reviewed-on: https://gerrit.libreoffice.org/31249
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index f650108..8494208 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -1787,34 +1787,34 @@ void SmFontNode::CreateTextFromNode(OUString )
 rText += "color yellow ";
 break;
 case TTEAL:
-rText += "color teal";
+rText += "color teal ";
 break;
 case TSILVER:
-rText += "color silver";
+rText += "color silver ";
 break;
 case TGRAY:
-rText += "color gray";
+rText += "color gray ";
 break;
 case TMAROON:
-rText += "color maroon";
+rText += "color maroon ";
 break;
 case TPURPLE:
-rText += "color purple";
+rText += "color purple ";
 break;
 case TLIME:
-rText += "color lime";
+rText += "color lime ";
 break;
 case TOLIVE:
-rText += "color olive";
+rText += "color olive ";
 break;
 case TNAVY:
-rText += "color navy";
+rText += "color navy ";
 break;
 case TAQUA:
-rText += "color aqua";
+rText += "color aqua ";
 break;
 case TFUCHSIA:
-rText += "color fuchsia";
+rText += "color fuchsia ";
 break;
 case TSANS:
 rText += "font sans ";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/source

[Takeshi Abe]

 starmath/source/node.cxx |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 142618ecae472e535c582c0fb357d2a9a76655f1
Author: Takeshi Abe 
Date:   Sun Nov 27 03:55:57 2016 +0900

starmath: Separate color name and operand by space

Otherwise, errors happen at MathML import.

Change-Id: I17037b430710ea4d26340e7ce13c7972a76f614f

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 3904133..ca21a7e 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -1780,34 +1780,34 @@ void SmFontNode::CreateTextFromNode(OUString )
 rText += "color yellow ";
 break;
 case TTEAL:
-rText += "color teal";
+rText += "color teal ";
 break;
 case TSILVER:
-rText += "color silver";
+rText += "color silver ";
 break;
 case TGRAY:
-rText += "color gray";
+rText += "color gray ";
 break;
 case TMAROON:
-rText += "color maroon";
+rText += "color maroon ";
 break;
 case TPURPLE:
-rText += "color purple";
+rText += "color purple ";
 break;
 case TLIME:
-rText += "color lime";
+rText += "color lime ";
 break;
 case TOLIVE:
-rText += "color olive";
+rText += "color olive ";
 break;
 case TNAVY:
-rText += "color navy";
+rText += "color navy ";
 break;
 case TAQUA:
-rText += "color aqua";
+rText += "color aqua ";
 break;
 case TFUCHSIA:
-rText += "color fuchsia";
+rText += "color fuchsia ";
 break;
 case TSANS:
 rText += "font sans ";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - Makefile.gbuild Makefile.in

[Markus Mohrhard]

 Makefile.gbuild |5 +
 Makefile.in |3 +++
 2 files changed, 8 insertions(+)

New commits:
commit 0cba580ac82eb0edd6c54c22b890eb09f9c50029
Author: Markus Mohrhard 
Date:   Mon Nov 28 01:04:17 2016 +0100

separate creation and upload of the update info

Change-Id: I809866f0425b8e85b396692f60c936351aca39ad

diff --git a/Makefile.gbuild b/Makefile.gbuild
index 140a6d7..6d625bb 100644
--- a/Makefile.gbuild
+++ b/Makefile.gbuild
@@ -38,6 +38,11 @@ create-update-info:
MAR=$(INSTDIR)/program/mar $(SRCDIR)/bin/update/create_full_mar.py 
"$(PRODUCTNAME)" "$(WORKDIR)" "$(UPDATE_DIR)" "$(MAR_DIR)/current-build/" 
"$(MAR_NAME_PREFIX)" "$(UPDATE_CONFIG)"
MAR=$(INSTDIR)/program/mar 
$(SRCDIR)/bin/update/create_full_mar_for_languages.py "$(PRODUCTNAME)" 
"$(WORKDIR)" "$(UPDATE_DIR)" "$(MAR_DIR)/language" "$(MAR_NAME_PREFIX)" 
"$(UPDATE_CONFIG)"
$(SRCDIR)/bin/update/create_build_config.py "$(PRODUCTNAME)" 
"$(VERSION)" "$(BUILDID)" "$(PLATFORM)" "$(UPDATE_DIR)" "$(UPDATE_CONFIG)" 
"$(UPDATE_CONFIG)"
+
+upload-update-info:
+   $(eval BUILDID := $(shell git -C $(SRCDIR) log -1 --format=%H))
+   $(eval PLATFORM := $(RTL_OS)_$(RTL_ARCH))
+   $(eval UPDATE_DIR := $(WORKDIR)/update-info)
$(SRCDIR)/bin/update/upload_builds.py "$(PRODUCTNAME)" "$(BUILDID)" 
"$(PLATFORM)" "$(UPDATE_DIR)" "$(UPDATE_CONFIG)"
$(SRCDIR)/bin/update/upload_build_config.py "$(UPDATE_DIR)" 
"$(UPDATE_CONFIG)"
 
diff --git a/Makefile.in b/Makefile.in
index 6f2c819..ec48644 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -414,6 +414,9 @@ upload-symbols:
 create-update-info:
$(MAKE) -f $(SRCDIR)/Makefile.gbuild create-update-info
 
+upload-update-info:
+   $(MAKE) -f $(SRCDIR)/Makefile.gbuild upload-update-info
+
 dump-deps:
@$(SRCDIR)/bin/module-deps.pl $(MAKE) $(SRCDIR)/Makefile.gbuild
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104210] can't build 5.3 branch with disable-orcus option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104210

Markus Mohrhard  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #1 from Markus Mohrhard  ---
orcus has become mandatory. The build would later fail in calc as well.

I'll update the configure option in master and 5.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65848] PRINTING: CALC doesn't set scaling factor set on xlsx files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65848

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg
Summary|PRINTING: CALC doesn't set  |PRINTING: CALC doesn't set
   |scaling factor set by   |scaling factor set on xlsx
   |PHPExcel class  |files

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104210] can't build 5.3 branch with disable-orcus option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104210

Adam Dingle  changed:

   What|Removed |Added

Summary|can't build 5.3 branch with |can't build 5.3 branch with
   ||disable-orcus option

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104210] New: can't build 5.3 branch with

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104210

Bug ID: 104210
   Summary: can't build 5.3 branch with
   Product: LibreOffice
   Version: 5.3.0.0.beta1
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: a...@medovina.org

Description:
I'm running Ubuntu 16.10.  I attempted to build Libreoffice from the
libreoffice-5.3 branch.  I passed --disable-orcus to configure, but the build
still looked for an orcus header file and failed.

Steps to Reproduce:
1. git checkout libreoffice-5.3
2. ./autogen.sh --disable-orcus ...
3. make

Actual Results:  
The build failed with this:

/home/adam/src/libreoffice/sfx2/source/control/emojiview.cxx:21:40: fatal
error: orcus/json_document_tree.hpp: No such file or directory

Expected Results:
A succesful build.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/603.1 (KHTML, like
Gecko)  Version/10.0 Safari/603.1 Ubuntu/16.10 (3.22.0-1ubuntu2)
Epiphany/3.22.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104186] FILESAVE: XLSX export fails to comply with ECMA-376 paragraph 18.17.2 concerning forbidden space characters between function name and left parenthesis , resulting in Ex

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104186

Bartosz  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104186] FILESAVE: XLSX export fails to comply with ECMA-376 paragraph 18.17.2 concerning forbidden space characters between function name and left parenthesis , resulting in Ex

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104186

Bartosz  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/mar-updater' - 3 commits - desktop/source onlineupdate/source

[Markus Mohrhard]

 desktop/source/app/updater.cxx |9 +++--
 onlineupdate/source/libmar/verify/cryptox.c|4 
 onlineupdate/source/update/updater/updater.cxx |6 +++---
 3 files changed, 14 insertions(+), 5 deletions(-)

New commits:
commit 3027deb2278779378396622309656301effd5443
Author: Markus Mohrhard 
Date:   Mon Nov 28 00:31:48 2016 +0100

fix more platform define checks

Change-Id: I2e125770fc6c21141c45ccc057d95fada8ccf74c

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index 183ad8d9..0ca03bc 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -40,9 +40,9 @@ class error_updater : public std::exception
 
 static const char kUserAgent[] = "UpdateChecker/1.0 (Linux)";
 
-#if UNX
+#ifdef UNX
 const char* pUpdaterName = "updater";
-#elif WNT
+#elif defined(WNT)
 const char* pUpdaterName = "updater.exe";
 #else
 #error "Need implementation"
diff --git a/onlineupdate/source/libmar/verify/cryptox.c 
b/onlineupdate/source/libmar/verify/cryptox.c
index f71c4cef..7edf8be 100644
--- a/onlineupdate/source/libmar/verify/cryptox.c
+++ b/onlineupdate/source/libmar/verify/cryptox.c
@@ -13,8 +13,10 @@
 
 #if defined(MAR_NSS)
 
+#ifdef _WIN32
 #pragma warning(push)
 #pragma warning(disable: 4204)
+#endif
 
 /**
  * Loads the public key for the specified cert name from the NSS store.
@@ -270,7 +272,9 @@ CryptoAPI_VerifyUpdate(HCRYPTHASH* hash, BYTE *buf, DWORD 
len)
   return result ? CryptoX_Success : CryptoX_Error;
 }
 
+#ifdef _WIN32
 #pragma warning(pop)
+#endif
 
 #endif
 
commit 124a0d7c73334d69f8f770072d88e4a748aec4ae
Author: Markus Mohrhard 
Date:   Mon Nov 28 00:25:07 2016 +0100

fix Wundef warnings

Change-Id: I36a68731e861a58d631249e6580233102cd3b702

diff --git a/onlineupdate/source/update/updater/updater.cxx 
b/onlineupdate/source/update/updater/updater.cxx
index 5c8578c..828b855 100644
--- a/onlineupdate/source/update/updater/updater.cxx
+++ b/onlineupdate/source/update/updater/updater.cxx
@@ -2518,7 +2518,7 @@ int LaunchCallbackAndPostProcessApps(int argc, NS_tchar** 
argv,
 #ifdef _WIN32
 , const WCHAR* elevatedLockFilePath
 , HANDLE updateLockFileHandle
-#elif MACOSX
+#elif defined(MACOSX)
 , bool isElevated
 #endif
 )
@@ -2542,7 +2542,7 @@ int LaunchCallbackAndPostProcessApps(int argc, NS_tchar** 
argv,
 }
 }
 EXIT_WHEN_ELEVATED(elevatedLockFilePath, updateLockFileHandle, 0);
-#elif MACOSX
+#elif defined(MACOSX)
 if (!isElevated) {
 if (gSucceeded) {
 LaunchMacPostProcess(gInstallDirPath);
@@ -3450,7 +3450,7 @@ int NS_main(int argc, NS_tchar **argv)
 #ifdef _WIN32
 , elevatedLockFilePath
 , updateLockFileHandle
-#elif XP_MACOSX
+#elif defined(MACOSX)
 , isElevated
 #endif
 );
commit e7db905a567e997166d00785386d0197d544c7a7
Author: Markus Mohrhard 
Date:   Sat Nov 26 23:32:25 2016 +0100

handle errors returned by the server

Change-Id: I91808a017123501fa28cc9b7bfa7316f3d52b7df

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index bccf677..183ad8d9 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -314,6 +314,11 @@ update_info parse_response(const std::string& rResponse)
 }
 
 auto aRootKeys = aDocumentRoot.keys();
+if (std::find(aRootKeys.begin(), aRootKeys.end(), "error") != 
aRootKeys.end())
+{
+throw invalid_update_info();
+}
+
 if (aRootKeys.size() != 5)
 {
 SAL_WARN("desktop.Update", "invalid root entries: " << rResponse);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104208] problem with square roots of fractions + sums

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104208

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
As in bug 99351 there remains work to do with the DirectWrite calls used for
OpenGL rendering on Windows builds that impact node layout for sm Math formula
editor.

Accommodated in 5.3.0 by disabling OpenGL rendering and using default GDI
rendering with the new default HarfBuzz layout engine.  

At some point the DirectWrite based OpenGL rendering will also be corrected,
unclear when.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102621] DOCX import: Incorrect Chart import

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102621

--- Comment #8 from Jean-Tiare LE BIGOT  ---
Hmmm, I see. We should store "NaN" instead of 0. I see What I can do If I have
some time this week.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92657] Questionable Default for Bullet Sizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92657

--- Comment #13 from Steve Edmonds  ---
Not so simple, but at least I have a work around. I notice in the character
style, bullets, Organizer tab that there are 3 entries (minimum) for bullets. 2
relate to the font selection in the fonts tab and one doesn't seem to change.
On a default document this is opensymbol. In my document it is starsymbol.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 92657] Questionable Default for Bullet Sizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92657

--- Comment #13 from Steve Edmonds  ---
Not so simple, but at least I have a work around. I notice in the character
style, bullets, Organizer tab that there are 3 entries (minimum) for bullets. 2
relate to the font selection in the fonts tab and one doesn't seem to change.
On a default document this is opensymbol. In my document it is starsymbol.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100245] Arrangement (front/back) of picture ignored/messed up on load

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100245

--- Comment #5 from kolAflash  ---
Still existing in 5.3.0.0 beta1.
Tested on openSUSE 42.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100246] ODG graphic copied to Writer moves on file load, if vertical position is set to "Top"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100246

--- Comment #3 from kolAflash  ---
Still a problem in 5.3.0.0 beta1.
Tested on openSUSE 42.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100419] Can't scroll to the last page in print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100419

kolAflash  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #8 from kolAflash  ---
Bug's still reproduceable in 5.3.0.0 beta1.
Tested on openSUSE 42.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104208] problem with square roots of fractions + sums

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104208

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #2 from Xisco Faulí  ---


*** This bug has been marked as a duplicate of bug 99351 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104209] FILESAVE: PPTX: .git images are flipped vertically after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104209

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104209] New: FILESAVE: PPTX: .git images are flipped vertically after RT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104209

Bug ID: 104209
   Summary: FILESAVE: PPTX: .git images are flipped vertically
after RT
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps:
1. Open attachment 46803
2. Save as a new .PPTX file
3. Open the new .PPTX file

Observed behaviour: the first two pictures are flipped vertically

Version: 5.3.0.0.alpha1+
Build ID: 757a60d01dd152aadab2ba3c8224252481ce8a88
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - cui/source svx/source

[Stephan Bergmann]

 cui/source/tabpages/tpcolor.cxx  |6 --
 svx/source/tbxctrls/tbcontrl.cxx |5 -
 2 files changed, 8 insertions(+), 3 deletions(-)

New commits:
commit 5db3eff8bea4b4d907251c46bc30d1114daba3bc
Author: Stephan Bergmann 
Date:   Fri Nov 25 17:29:09 2016 +0100

Handle cases where last-used palette disappeared

...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set
PaletteManager::mnCurrentPalette to 65535, and
PaletteManager::GetSelectedPalettePath would do out-of-bounds access into
PaletteManage::m_Palettes.

That the last-used palette (as stored under in the configuration under
/org.openoffice.Office.Common/UserColors/PaletteName) may become more common
with pending changes like 
"tdf#104047 Remove dispensable palettes".

Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281
(cherry picked from commit 8b718e3774f1ffb69f9aad565216556c798e95f4)
Reviewed-on: https://gerrit.libreoffice.org/31209
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/cui/source/tabpages/tpcolor.cxx b/cui/source/tabpages/tpcolor.cxx
index c31f57f..e4545b4 100644
--- a/cui/source/tabpages/tpcolor.cxx
+++ b/cui/source/tabpages/tpcolor.cxx
@@ -220,7 +220,10 @@ void SvxColorTabPage::FillPaletteLB()
 }
 OUString aPaletteName( 
officecfg::Office::Common::UserColors::PaletteName::get() );
 m_pSelectPalette->SelectEntry(aPaletteName);
-SelectPaletteLBHdl( *m_pSelectPalette );
+if (m_pSelectPalette->GetSelectEntryPos() != LISTBOX_ENTRY_NOTFOUND)
+{
+SelectPaletteLBHdl( *m_pSelectPalette );
+}
 }
 
 void SvxColorTabPage::Construct()
@@ -228,7 +231,6 @@ void SvxColorTabPage::Construct()
 if (pColorList.is())
 {
 FillPaletteLB();
-SelectPaletteLBHdl( *m_pSelectPalette );
 ImpColorCountChanged();
 }
 }
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index aa725a7..36b57a8 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1354,7 +1354,10 @@ SvxColorWindow::SvxColorWindow(const OUString&   
 rCommand,
 }
 OUString aPaletteName( 
officecfg::Office::Common::UserColors::PaletteName::get() );
 mpPaletteListBox->SelectEntry( aPaletteName );
-SelectPaletteHdl( *mpPaletteListBox );
+if (mpPaletteListBox->GetSelectEntryPos() != LISTBOX_ENTRY_NOTFOUND)
+{
+SelectPaletteHdl( *mpPaletteListBox );
+}
 
 mpButtonAutoColor->SetClickHdl( LINK( this, SvxColorWindow, 
AutoColorClickHdl ) );
 mpButtonNoneColor->SetClickHdl( LINK( this, SvxColorWindow, 
AutoColorClickHdl ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Lode Build Problem

[Norbert Thiebaud]

On Sun, Nov 27, 2016 at 12:04 PM, Jan Iversen
 wrote:

> Only use a-z and 0-9 in the name, NO spaces or other special characters"

actually _ is fine too.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Lode Build Problem

[Norbert Thiebaud]

On Sun, Nov 27, 2016 at 2:49 PM, Jason Marshall
 wrote:
> Dear Norbert/ Jan
>
> Having followed your advice, the setup of the dev build environment has now
> succeeded. Hopefully the build should proceed with similar success.

glad to hear.

>
> Thanks again.

welcome.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - bridges/source

[Rene Engelhard]

 bridges/source/cpp_uno/gcc3_linux_sparc64/cpp2uno.cxx |8 
 bridges/source/cpp_uno/gcc3_linux_sparc64/uno2cpp.cxx |8 
 2 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 065b4d6813ee308f819cce962da8944021b945c6
Author: Rene Engelhard 
Date:   Sun Nov 27 20:08:30 2016 +0100

fix sparc64 bridges build

Change-Id: Ic8483547966a319d3ecc1ae2fd5dfb785132f687
Reviewed-on: https://gerrit.libreoffice.org/31277
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/bridges/source/cpp_uno/gcc3_linux_sparc64/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_linux_sparc64/cpp2uno.cxx
index d8bc9a2..813f5b7 100644
--- a/bridges/source/cpp_uno/gcc3_linux_sparc64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_sparc64/cpp2uno.cxx
@@ -21,10 +21,10 @@
 #include 
 #include 
 #include 
-#include "bridges/cpp_uno/shared/bridge.hxx"
-#include "bridges/cpp_uno/shared/cppinterfaceproxy.hxx"
-#include "bridges/cpp_uno/shared/types.hxx"
-#include "bridges/cpp_uno/shared/vtablefactory.hxx"
+#include "bridge.hxx"
+#include "cppinterfaceproxy.hxx"
+#include "types.hxx"
+#include "vtablefactory.hxx"
 #include "share.hxx"
 
 #define GET_FP(n, p) \
diff --git a/bridges/source/cpp_uno/gcc3_linux_sparc64/uno2cpp.cxx 
b/bridges/source/cpp_uno/gcc3_linux_sparc64/uno2cpp.cxx
index 8caaee5..dc03e46e 100644
--- a/bridges/source/cpp_uno/gcc3_linux_sparc64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_sparc64/uno2cpp.cxx
@@ -21,10 +21,10 @@
 #include 
 #include 
 
-#include "bridges/cpp_uno/shared/bridge.hxx"
-#include "bridges/cpp_uno/shared/types.hxx"
-#include "bridges/cpp_uno/shared/unointerfaceproxy.hxx"
-#include "bridges/cpp_uno/shared/vtables.hxx"
+#include "bridge.hxx"
+#include "types.hxx"
+#include "unointerfaceproxy.hxx"
+#include "vtables.hxx"
 
 #include "share.hxx"
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - configure.ac

[John Paul Adrian Glaubitz]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ca0acb3c2757c00115b9879c4a6f044f4be1605
Author: John Paul Adrian Glaubitz 
Date:   Sun Nov 27 19:22:59 2016 +0100

Fix typo in configure.ac (mk68 -> m68k)

Change-Id: Ibbedf9444e2c43b3dff886d9513be7e3d2a99095
Reviewed-on: https://gerrit.libreoffice.org/31276
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/configure.ac b/configure.ac
index 6e3a992..2dadc7c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7127,7 +7127,7 @@ then
 my_java_arch=i386
 ;;
 m68k)
-my_java_arch=mk68
+my_java_arch=m68k
 ;;
 powerpc)
 my_java_arch=ppc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/gbuild-to-ide

[Markus Mohrhard]

 bin/gbuild-to-ide |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f567ee19954612d6ebd2c8f6a809478f7c0ee568
Author: Markus Mohrhard 
Date:   Sun Nov 27 22:55:36 2016 +0100

also strip the first -D

Change-Id: Ifc95720b47e1adaadbca879d5b8f22ada658fd3a
Reviewed-on: https://gerrit.libreoffice.org/31275
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 366b808..0c6b2b6 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -95,7 +95,7 @@ class GbuildParser:
 @staticmethod
 def __split_defs(defsline):
 defs = {}
-alldefs = [defswitch.strip() for defswitch in defsline.strip().split(' 
-D') if len(defswitch) > 2]
+alldefs = [defswitch.strip() for defswitch in 
defsline.strip().lstrip('-D').split(' -D') if len(defswitch) > 2]
 for d in alldefs:
 defparts = d.split('=')
 if len(defparts) == 1:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/gbuild-to-ide

[Markus Mohrhard]

 bin/gbuild-to-ide |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 86524159c6ce305ffe4738e7ce6b56ea166aaf00
Author: Markus Mohrhard 
Date:   Sun Nov 27 22:40:31 2016 +0100

better way to split def patterns

Change-Id: I8c7ab7e980d2ba01214c1dd15c81a309d0d2c80c
Reviewed-on: https://gerrit.libreoffice.org/31274
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 9349543..366b808 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -95,7 +95,7 @@ class GbuildParser:
 @staticmethod
 def __split_defs(defsline):
 defs = {}
-alldefs = [defswitch.strip()[2:] for defswitch in 
defsline.strip().split(' ') if len(defswitch) > 2]
+alldefs = [defswitch.strip() for defswitch in defsline.strip().split(' 
-D') if len(defswitch) > 2]
 for d in alldefs:
 defparts = d.split('=')
 if len(defparts) == 1:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104208] problem with square roots of fractions + sums

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104208

--- Comment #1 from fred L  ---
Created attachment 129056
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129056=edit
wierd result for a squareroot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104208] New: problem with square roots of fractions + sums

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104208

Bug ID: 104208
   Summary: problem with square roots of fractions + sums
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shouk...@gmail.com

Created attachment 129055
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129055=edit
wierd result for a squareroot

Hello,
When you type something like "sqrt { {a + b} over c }", you get a very wierd
result; this problem appeared on 5.1 version

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91614] Inserting of SVG containing text put on a path has incorrect offset for text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91614

--- Comment #7 from Buovjaga  ---
(In reply to zaqzaqtgbyhnujm from comment #6)
> Am I doing something wrong in my description of the error since nobody is
> trying to correct the error I have described?

There are over ten thousand reports (bugs & features) for LibO:
https://bugs.documentfoundation.org/reports.cgi?product_id=109=NEW
I think you get the point.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91614] Inserting of SVG containing text put on a path has incorrect offset for text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91614

--- Comment #6 from zaqzaqtgbyhn...@gmail.com ---
Created attachment 129054
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129054=edit
SVG graphic inserted in LibreOffice 5.3.0.0.beta1 to show the error is still
present

Am I doing something wrong in my description of the error since nobody is
trying to correct the error I have described?

The error has now been present for at least for 1½ year.

The error is present in LibreOffice 5.3.0.0.beta1

The error is also present in LibreOffice 5.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/qa

[Andras Timar]

 sd/qa/unit/import-tests.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8938ed4c660c6169759e1b3a5401174eeaad662f
Author: Andras Timar 
Date:   Sun Nov 27 22:03:35 2016 +0100

typo: Scond -> Second

Change-Id: Icea85b778375f591583732919a999cb066c40868

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index c1c4224..22bb3b7 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1606,7 +1606,7 @@ void SdImportTest::testTdf104201()
 pObj->GetMergedItem(XATTR_FILLCOLOR));
 CPPUNIT_ASSERT_EQUAL(ColorData(0x00FF00), 
rColorItem.GetColorValue().GetColor());
 }
-// Scond shape has blue fill, but this should be overwritten by green 
group fill
+// Second shape has blue fill, but this should be overwritten by green 
group fill
 {
 SdrObject *const pObj = pPage->GetObj(0);
 CPPUNIT_ASSERT_MESSAGE("Wrong object", pObj != nullptr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - oox/source sd/qa

[Tamás Zolnai]

 oox/source/drawingml/shape.cxx  |6 +++---
 sd/qa/unit/data/pptx/tdf104201.pptx |binary
 sd/qa/unit/import-tests.cxx |   36 
 3 files changed, 39 insertions(+), 3 deletions(-)

New commits:
commit 32395df104106743e5599f14b19a9a887c1a78ec
Author: Tamás Zolnai 
Date:   Sun Nov 27 17:47:03 2016 +

tdf#104201: PPTX: Group solid fill is not imported

Reviewed-on: https://gerrit.libreoffice.org/31263
Reviewed-by: Tamás Zolnai 
Tested-by: Tamás Zolnai 
(cherry picked from commit 7c5aaa254f444d54b9ebf6574f0ccd37af548ee5)

Change-Id: Iec273714108598d7017e73a9e7d384f8410d6ee1
Reviewed-on: https://gerrit.libreoffice.org/31267
Tested-by: Jenkins 
Reviewed-by: Andras Timar 

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 5f6a066..70517d4 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1462,14 +1462,14 @@ FillProperties Shape::getActualFillProperties(const 
Theme* pTheme, const FillPro
 }
 }
 
+// Properties specified directly for this shape
+aFillProperties.assignUsed(getFillProperties());
+
 // Parent shape's properties
 if ( pParentShapeFillProps != nullptr)
 if( getFillProperties().moFillType.has() && 
getFillProperties().moFillType.get() == XML_grpFill )
 aFillProperties.assignUsed( *pParentShapeFillProps );
 
-// Properties specified directly for this shape
-aFillProperties.assignUsed( getFillProperties() );
-
 return aFillProperties;
 }
 
diff --git a/sd/qa/unit/data/pptx/tdf104201.pptx 
b/sd/qa/unit/data/pptx/tdf104201.pptx
new file mode 100755
index 000..99a6532
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf104201.pptx differ
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 8aaf485..4a8da29 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -126,6 +126,7 @@ public:
 void testTdf103792();
 void testTdf103876();
 void testTdf104015();
+void testTdf104201();
 
 CPPUNIT_TEST_SUITE(SdImportTest);
 
@@ -180,6 +181,7 @@ public:
 CPPUNIT_TEST(testTdf103792);
 CPPUNIT_TEST(testTdf103876);
 CPPUNIT_TEST(testTdf104015);
+CPPUNIT_TEST(testTdf104201);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -1505,6 +1507,40 @@ void SdImportTest::testTdf104015()
 xDocShRef->DoClose();
 }
 
+void SdImportTest::testTdf104201()
+{
+// Group shape properties did not overwrite the child shapes' fill
+sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("sd/qa/unit/data/pptx/tdf104201.pptx"), 
PPTX);
+
+const SdrPage *pPage = GetPage(1, xDocShRef);
+CPPUNIT_ASSERT_MESSAGE("No page found", pPage != nullptr);
+
+// First shape has red fill, but this should be overwritten by green group 
fill
+{
+SdrObject *const pObj = pPage->GetObj(0);
+CPPUNIT_ASSERT_MESSAGE("Wrong object", pObj != nullptr);
+const XFillStyleItem& rStyleItem = dynamic_cast(
+pObj->GetMergedItem(XATTR_FILLSTYLE));
+CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_SOLID, rStyleItem.GetValue());
+const XFillColorItem& rColorItem = dynamic_cast(
+pObj->GetMergedItem(XATTR_FILLCOLOR));
+CPPUNIT_ASSERT_EQUAL(ColorData(0x00FF00), 
rColorItem.GetColorValue().GetColor());
+}
+// Scond shape has blue fill, but this should be overwritten by green 
group fill
+{
+SdrObject *const pObj = pPage->GetObj(0);
+CPPUNIT_ASSERT_MESSAGE("Wrong object", pObj != nullptr);
+const XFillStyleItem& rStyleItem = dynamic_cast(
+pObj->GetMergedItem(XATTR_FILLSTYLE));
+CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_SOLID, rStyleItem.GetValue());
+const XFillColorItem& rColorItem = dynamic_cast(
+pObj->GetMergedItem(XATTR_FILLCOLOR));
+CPPUNIT_ASSERT_EQUAL(ColorData(0x00FF00), 
rColorItem.GetColorValue().GetColor());
+}
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

RE: Lode Build Problem

[Jason Marshall]

Dear Norbert/ Jan

Having followed your advice, the setup of the dev build environment has now 
succeeded. Hopefully the build should proceed with similar success.

Thanks again.

Jason

Sent from my Windows Phone

From: Jan Iversen
Sent: ‎27/‎11/‎2016 18:04
To: Norbert Thiebaud
Cc: Jason Marshall; 
libreoffice@lists.freedesktop.org
Subject: Re: Lode Build Problem



and I'm pretty sure that confused the heck out of git to have spaces there

I can confirm that there are several problems having spaces in the directory, 
which is why we write
"A couple of warning, based on experience from earlier installations:

  *   Do not use a network drive, it will not work. There can also be problems 
with some older USB drives
  *   Do not use names longer than 8 char
  *   Only use a-z and 0-9 in the name, NO spaces or other special characters"

on the lode page:

https://wiki.documentfoundation.org/Development/lode


rgds
jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 104207] An easier way to backup custom toolbar presets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104207

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
Summary|An implementation request:  |An easier way to backup
   |Please make it easier to|custom toolbar presets
   |backup toolbar presets  |

--- Comment #1 from tommy27  ---
you may be interested reading this about the user profile
https://wiki.documentfoundation.org/UserProfile

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86791] LibreLogo Typed Command Execution Fails, Error When Syntax Highlighting Button Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86791

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #16 from Julien Nabet  ---
The bug was MacOs specific.
It's been fixed on tdf#101603 from future 5.3.0. The patch for 5.2 branch is on
gerrit review

If you need to use it now without waiting for the last LO version, you can
change your LibreLogo.py by following what's done in the patch
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3b5b0dfb0c92aa5e94a0f417950724c694ac57

*** This bug has been marked as a duplicate of bug 101603 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72438] LibreLogo: icons in Logo toolbar replaced by text only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72438

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #16 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104129] Cell borders freehand drawing tool

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104129

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Summary|Cell borders Freehands Tool |Cell borders freehand
   ||drawing tool
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Sounds fun -> NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 92657] Questionable Default for Bullet Sizing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92657

--- Comment #12 from Frank  ---
The substitution of fonts even when the font in use has the necessary
characters is actually a separate, larger problem, so don't confuse the two.

LibreOffice seems to use OS services to layout text and those seem to do the
actual substitution in many cases. These services in turn rely on what the font
file reports as the characters it contains and what it can do with them.

To simplify even further - if the font files themselves are faulty (and this
occurs more than you might think), trouble arises.

A few of us had a recent discussion about this on the Doc Foundation forum.
See:
http://nabble.documentfoundation.org/Struggling-with-Hebrew-in-LO-td4198211.html

But there is still a real issue with the bullet substitutions, which appears to
be a separate and unrelated bug, although it doesn't seem impossible that the
two might meet up someday to breed and then attack us all one day...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise