[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #43 from Kumāra  ---
Wow... Pretty serious argument over one context menu item.

I don't need it but would still vote to have it back in the menu. (I use the
function with a toolbar icon I added.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102915

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #43 from Kumāra  ---
Wow... Pretty serious argument over one context menu item.

I don't need it but would still vote to have it back in the menu. (I use the
function with a toolbar icon I added.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91823] Frutiger LT 45 Light Font Rendering

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91823

--- Comment #4 from be...@a-design.ch ---
Yes
Libre Office Version 5.2.3.3 (Latest from repository)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102906] Clear direct formatting does not clear vertical alignment in table

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102906

Kumāra  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED
 CC||kumara.bhik...@gmail.com

--- Comment #4 from Kumāra  ---
(In reply to m.a.riosv from comment #3)
> Because it is not part of the character format, those that are reset by
> clear direct format.

Sorry for being a bit pedantic, that's under paragraph formatting.

Clear Direct Formatting resets all direct character and paragraph formatting,
so that the text is only subject to the paragraph style.

> It is an option of the table properties on the 'text flow' tab.
> 
> Not a bug.

Agree. Perhaps "Clear Direct Formatting" should be called "Clear Direct Text
Formatting"...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104705] vcl OpenGL error copy string of selected text

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104705

Khaled Hosny  changed:

   What|Removed |Added

 Blocks|103729  |

--- Comment #3 from Khaled Hosny  ---
There is nothing related to HarfBuzz in the backtrace or the commit range. I
can’t reproduce the crash on master either.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99573] Clear direct formatting ignores area attributes

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99573

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #9 from Kumāra  ---
Works for me on

Version: 5.2.3.3 (x64)
Build ID: d54a8868f08a7b39642414cf2c8ef2f228f780cf
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
Locale: en-GB (en_US); Calc: group

Already fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104631] UI: Gridlines in Writer visibile through an image ( instead hidden behind)

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104631

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 47612] Exported graphics from Writer to .doc not coming out correctly

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47612

--- Comment #6 from Justin L  ---
Created attachment 129681
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129681=edit
PDF after round-tripping to .doc in LO5.3beta

It doesn't require MSWord to see that the document is messed up.  LO itself
reads it in differently.  .docx is still messed up even worse.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 104631] UI: Gridlines in Writer visibile through an image ( instead hidden behind)

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104631

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 104628] UI: Gridlines in Writer nearly invisible

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104628

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 104628] UI: Gridlines in Writer nearly invisible

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104628

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104610] Menu: Show more formatting marks even when CTL is off

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104610

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 104610] Menu: Show more formatting marks even when CTL is off

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104610

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #1 from Heiko Tietze  ---
Just CC'ing to the ux mailinglist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 100678] FILEOPEN Endless pagination loop until resources are depleted

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100678

Justin L  changed:

   What|Removed |Added

   Keywords||notBibisectable
Version|5.1.3.2 release |4.0.0.3 release

--- Comment #13 from Justin L  ---
notBibisectable: using bibisect43all, the document fails to open between Mon
Dec 3 18:04:24 2012 +0100 commit ce90f99a2d66c2b998ad3f9f028e2ea623a757f5 and
Wed May 1 14:30:14 2013 +0100 commit 2b449f5f9ad126618ec85d442ec149c5864853de. 
Just before LO4.0, it opened OK. In LO4.1, it looped endlessly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529
Bug 93529 depends on bug 104159, which changed state.

Bug 104159 Summary: Uncached glyphs cause slow UI with new layout engine in 
Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104159] Uncached glyphs cause slow UI with new layout engine in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |khaledho...@eglug.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/win

2016-12-15 Thread Khaled Hosny
 vcl/win/gdi/winlayout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1fbfe5cbc288ead6bba9d30ddb849dcb41a0d5e0
Author: Khaled Hosny 
Date:   Fri Dec 16 08:54:45 2016 +0200

Fix typo from 6c436ba09cb35235ce6f4065cf74c9a6ff14a4bd

This broke OpenGL glyph caching since we were using a different DC
than the one we selected the font on.

Change-Id: I43218891aa1bc75599700ce6e0b582a5e73ff210

diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index 1f31cfa..57ac16f 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -57,7 +57,7 @@ bool WinFontInstance::CacheGlyphToAtlas(HDC hDC, HFONT hFont, 
int nGlyphIndex, S
 SAL_WARN("vcl.gdi", "CreateCompatibleDC failed: " << 
WindowsErrorString(GetLastError()));
 return false;
 }
-HFONT hOrigFont = static_cast(SelectObject(hDC, hFont));
+HFONT hOrigFont = static_cast(SelectObject(hNewDC, hFont));
 if (hOrigFont == nullptr)
 {
 SAL_WARN("vcl.gdi", "SelectObject failed: " << 
WindowsErrorString(GetLastError()));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 4 commits - bridges/source external/python3 include/vcl

2016-12-15 Thread Stephan Bergmann
 bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx |9 ++
 external/python3/ubsan.patch.0|   60 +++---
 include/vcl/menu.hxx  |2 
 3 files changed, 47 insertions(+), 24 deletions(-)

New commits:
commit 3024e891b2ce85059069e599e411db457e4bccd1
Author: Stephan Bergmann 
Date:   Sat Nov 12 10:16:38 2016 +0100

Fix undefined misaligned writes

same as 26cf118247855bb5caeac3d8e68906fbcfcdc837 for gcc_linux_x86-64

Change-Id: Ieb7a4c0497ea485e832da937786226f09feeff31

diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
index dccb9da..e16b2f1 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx
@@ -414,11 +414,16 @@ unsigned char * codeSnippet( unsigned char * code,
 
 // movq $, %r10
 *reinterpret_cast( code ) = 0xba49;
-*reinterpret_cast( code + 2 ) = nOffsetAndIndex;
+*reinterpret_cast( code + 2 ) = nOffsetAndIndex & 0x;
+*reinterpret_cast( code + 4 ) = nOffsetAndIndex >> 16;
+*reinterpret_cast( code + 8 ) = nOffsetAndIndex >> 48;
 
 // movq $, %r11
 *reinterpret_cast( code + 10 ) = 0xbb49;
-*reinterpret_cast( code + 12 ) = 
reinterpret_cast( privateSnippetExecutor );
+*reinterpret_cast( code + 12 )
+= reinterpret_cast(privateSnippetExecutor);
+*reinterpret_cast( code + 16 )
+= reinterpret_cast(privateSnippetExecutor) >> 32;
 
 // jmpq *%r11
 *reinterpret_cast( code + 20 ) = 0x00e3ff49;
commit 291c0b8fafd4c2cb1086bb321526f951768692a5
Author: Stephan Bergmann 
Date:   Sat Nov 12 09:56:21 2016 +0100

Typo "pStaredFrom" -> "pStartedFrom"?

But function definition uses "pSFrom" instead anyway, so consistently use 
param
names from definition in declaration.

Change-Id: I03fb8dd0fbab5c84f89c7276849d62f9a17cbfea

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index 4a119a0..f2202d1 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -495,7 +495,7 @@ private:
 SAL_DLLPRIVATE MenuFloatingWindow * ImplGetFloatingWindow() const;
 
 protected:
-SAL_DLLPRIVATE sal_uInt16 ImplExecute( const VclPtr& xWindow, 
const Rectangle& rRect, FloatWinPopupFlags nPopupFlags, Menu* pStaredFrom, bool 
bPreSelectFirst );
+SAL_DLLPRIVATE sal_uInt16 ImplExecute( const VclPtr& pW, 
const Rectangle& rRect, FloatWinPopupFlags nPopupModeFlags, Menu* pSFrom, bool 
bPreSelectFirst );
 SAL_DLLPRIVATE void ImplFlushPendingSelect();
 SAL_DLLPRIVATE long ImplCalcHeight( sal_uInt16 nEntries ) const;
 SAL_DLLPRIVATE sal_uInt16 ImplCalcVisEntries( long nMaxHeight, sal_uInt16 
nStartEntry, sal_uInt16* pLastVisible = nullptr ) const;
commit 9b92834fa4ee27b0dccdd52962edb3fdbee7a340
Author: Stephan Bergmann 
Date:   Fri Nov 11 23:35:15 2016 +0100

external/python3: Work around -fsanitize=alignment

Change-Id: I26b927345594368f426ae89bfd5b645561d44c10

diff --git a/external/python3/ubsan.patch.0 b/external/python3/ubsan.patch.0
index 639e85f..ab2acd3 100644
--- a/external/python3/ubsan.patch.0
+++ b/external/python3/ubsan.patch.0
@@ -35,6 +35,26 @@
  
/* Set the carry bit iff the function uses any sse registers.
   This is clc or stc, together with the first byte of the jmp.  */
+--- Modules/_ctypes/libffi_osx/x86/x86-ffi64.c
 Modules/_ctypes/libffi_osx/x86/x86-ffi64.c
+@@ -599,9 +599,15 @@
+   tramp = (volatile unsigned short*)>tramp[0];
+ 
+   tramp[0] = 0xbb49;  /* mov , %r11 */
+-  *(void* volatile*)[1] = ffi_closure_unix64;
++  tramp[1] = (unsigned short) ffi_closure_unix64;
++  tramp[2] = (unsigned short) (ffi_closure_unix64 >> 16);
++  tramp[3] = (unsigned short) (ffi_closure_unix64 >> 32);
++  tramp[4] = (unsigned short) (ffi_closure_unix64 >> 48);
+   tramp[5] = 0xba49;  /* mov , %r10 */
+-  *(void* volatile*)[6] = closure;
++  tramp[6] = (unsigned short) closure;
++  tramp[7] = (unsigned short) (closure >> 16);
++  tramp[8] = (unsigned short) (closure >> 32);
++  tramp[9] = (unsigned short) (closure >> 48);
+ 
+   /*  Set the carry bit if the function uses any sse registers.
+   This is clc or stc, together with the first byte of the jmp.  */
 --- Objects/listobject.c
 +++ Objects/listobject.c
 @@ -641,7 +641,7 @@
commit 6928b045f09b5d983083607d63fcb2a547446d0a
Author: Stephan Bergmann 
Date:   Fri Nov 11 23:34:39 2016 +0100

Clean up patch

Change-Id: I2aa51435d0a15e507d0bf95f98d69fa4cde00b05

diff --git a/external/python3/ubsan.patch.0 b/external/python3/ubsan.patch.0
index 700f43b..639e85f 100644
--- a/external/python3/ubsan.patch.0
+++ b/external/python3/ubsan.patch.0
@@ -1,6 +1,20 @@
-diff -ru 

[Libreoffice-bugs] [Bug 104705] vcl OpenGL error copy string of selected text

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104705

--- Comment #2 from V Stuart Foote  ---
Created attachment 129680
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129680=edit
WinDbg stack trace with TB39 symbols

Sorry, symbols did not resolve well to source line. But consistent crash at
this location TB39 and TB62 x86 builds with OpenGL rendering enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72942] importing .docx file overwrites all global properties

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=72942

Justin L  changed:

   What|Removed |Added

   Keywords||notBibisectable
Version|4.1.3.2 release |3.5.0 release

--- Comment #8 from Justin L  ---
probably inherited from OOo - used bibisect43all to confirm as far back as 3.5.
The biggest difference since then is that now the default page style is not
over-written.

The current status of replacing char/paragraph styles/font/language seems
logical to me.  Inserting a document should include most of that document's
state.  If you don't want all of that stuff, then do a copy/paste instead. 
(The opposite is not true AFAIK - there is probably no other way to replace
character/paragraph styles than by importing.) I would suggest marking this bug
as fixed (because of the page style) unless there is are very specific items
that ought not to be over-written (and in that case give a clear rational).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104705] vcl OpenGL error copy string of selected text

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104705

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||bibisected

--- Comment #1 from V Stuart Foote  ---
OK
53dbc419b2e886b345a3512cf11e035ff2b7651b  2016-12-12 TB39
ae8bd4267ac2da58f9e476d24e1e894202e92dea 2016-12-12 TB62
ba6b35fc68a01aff72b39eb7809bacb326068668 2016-12-13 TB39

Crashes
d538d3d84172a74dfe97d59a6d3daf9a45459cab  2016-12-14
b5cc02ee1b582a6f19e23eb2f1deb1392b3974c0  2016-12-15

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=ba6b35fc68a01aff72b39eb7809bacb326068668..d538d3d84172a74dfe97d59a6d3daf9a45459cab

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104624] Import issues with Pagemaker 6.5 files

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104624

--- Comment #4 from Christoph Schäfer  ---
The fonts in the PM files are already substitutions, because the WinXP system I
used for the creation didn't include them. That's why the text part of the
layout looks so ugly. But I've included PDF files for comparisons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] online.git: 2 commits - test/Makefile.am test/UnitRequests.cpp wsd/LOOLWebSocket.hpp

2016-12-15 Thread Pranav Kant
 test/Makefile.am  |6 +--
 test/UnitRequests.cpp |   99 --
 wsd/LOOLWebSocket.hpp |2 +
 3 files changed, 4 insertions(+), 103 deletions(-)

New commits:
commit 9b37eed7274398a539cd5151fd0b6aa174228bd4
Author: Pranav Kant 
Date:   Fri Dec 16 11:32:16 2016 +0530

Add missing config.h

Change-Id: Ib63c0bdfc8126fea211c5311c957985de6b00129

diff --git a/wsd/LOOLWebSocket.hpp b/wsd/LOOLWebSocket.hpp
index bc51321..28d74ae 100644
--- a/wsd/LOOLWebSocket.hpp
+++ b/wsd/LOOLWebSocket.hpp
@@ -10,6 +10,8 @@
 #ifndef INCLUDED_LOOLWEBSOCKET_HPP
 #define INCLUDED_LOOLWEBSOCKET_HPP
 
+#include "config.h"
+
 #include 
 #include 
 #include 
commit dd498ed0791032d35fdcdacc2d8ce0568f29d6d3
Author: Pranav Kant 
Date:   Thu Dec 15 22:58:21 2016 +0530

Bin this unit test

This was added while debugging some problem with forward slashes
in docurl in websocket endpoint automatically being decoded on
some machines. But it turned out it was due to the apache server
setting. So, this test serves no purpose now and tests something
really obvious.

Change-Id: I4658354d53c481cf7554804383892f501bc408cd

diff --git a/test/Makefile.am b/test/Makefile.am
index 992830e..2a285bc 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -16,8 +16,7 @@ noinst_LTLIBRARIES = \
 unit-timeout.la unit-prefork.la \
 unit-storage.la unit-fonts.la \
 unit-admin.la unit-tilecache.la \
-   unit-fuzz.la unit-requests.la \
-   unit-oob.la
+   unit-fuzz.la unit-oob.la
 
 MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
 AM_LDFLAGS = -pthread -module $(MAGIC_TO_FORCE_SHLIB_CREATION)
@@ -51,7 +50,6 @@ unittest_SOURCES = TileQueueTests.cpp WhiteBoxTests.cpp 
test.cpp $(wsd_sources)
 unittest_LDADD = $(CPPUNIT_LIBS)
 
 # unit test modules:
-unit_requests_la_SOURCES = UnitRequests.cpp
 unit_oob_la_SOURCES = UnitOOB.cpp
 unit_fuzz_la_SOURCES = UnitFuzz.cpp
 unit_admin_la_SOURCES = UnitAdmin.cpp
@@ -72,7 +70,7 @@ if HAVE_LO_PATH
 check-local:
./run_unit.sh --log-file test.log --trs-file test.trs
 # FIXME unit-fonts.la is unstable, disabled for now.
-TESTS = unit-oob.la unit-tilecache.la unit-storage.la unit-timeout.la 
unit-prefork.la unit-admin.la unit-requests.la
+TESTS = unit-oob.la unit-tilecache.la unit-storage.la unit-timeout.la 
unit-prefork.la unit-admin.la
 else
 TESTS = ${top_builddir}/test/test
 endif
diff --git a/test/UnitRequests.cpp b/test/UnitRequests.cpp
deleted file mode 100644
index 2bb7b6f..000
--- a/test/UnitRequests.cpp
+++ /dev/null
@@ -1,99 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include "Log.hpp"
-#include "Unit.hpp"
-#include "UnitHTTP.hpp"
-#include "helpers.hpp"
-
-using namespace helpers;
-
-// Inside the WSD process
-class UnitRequests : public UnitWSD
-{
-enum {
-PHASE_LOAD,
-PHASE_FILTER,
-PHASE_FILTERED
-} _phase;
-
-TestResult _testResult;
-std::unique_ptr _ws;
-public:
-UnitRequests() :
-_phase(PHASE_LOAD)
-{
-std::cerr << "UnitRequests startup\n";
-}
-
-virtual bool filterHandleRequest(
-TestRequest type,
-   Poco::Net::HTTPServerRequest& request,
-   Poco::Net::HTTPServerResponse& /*response*/) override
-{
-if (_phase == PHASE_FILTER && type == 
UnitWSD::TestRequest::TEST_REQ_CLIENT)
-{
-std::string uri = request.getURI();
-// Get the embedded document URL: '/lool/docUrl/ws/'
-uri = uri.substr(uri.find("lool/") + std::string("lool/").size());
-uri = uri.substr(0, uri.find("/ws"));
-Poco::URI requestUri(uri);
-_testResult = TestResult::TEST_OK;
-// If this is a simple encoded string, it would be treated as
-// relative, otherwise non-relative.
-// We require this embedded url to be encoded as otherwise it would
-// be treated as a resource on the server due to the presence of
-// un-encoded '/'
-if (!requestUri.isRelative())
-{
-_testResult = TestResult::TEST_FAILED;
-}
-
-_phase = PHASE_FILTERED;
-}
-return false;
-}
-
-void loadDocument()
-{
-std::string docPath;
-std::string docURL;
-getDocumentPathAndURL("empty.odt", docPath, docURL);
-_ws = std::unique_ptr(new UnitWebSocket(docURL));
-assert(_ws.get());
-}
-
-virtual void invokeTest() override
-{
-

[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93529

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||104705


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104705
[Bug 104705] vcl OpenGL error copy string of selected text
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104159] Uncached glyphs cause slow UI with new layout engine in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

--- Comment #11 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d85003a8af8b454b34eea0ac67c8dd9184a0b6d3=libreoffice-5-3

tdf#104159: Re-enable OpenGL glyph caching on Windows

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104159] Uncached glyphs cause slow UI with new layout engine in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104705] vcl OpenGL error copy string of selected text

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104705

V Stuart Foote  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org,
   ||qui...@gmail.com,
   ||t...@iki.fi,
   ||vstuart.fo...@utsa.edu
 Blocks||93529, 103729
Summary|vcl OpenGL error|vcl OpenGL error copy
   ||string of selected text
 OS|All |Windows (All)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=93529
[Bug 93529] [META] VCL/OpenGL tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] tracker HarfBuzz based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/inc vcl/source vcl/win

2016-12-15 Thread Khaled Hosny
 vcl/inc/CommonSalLayout.hxx|3 +
 vcl/inc/win/salgdi.h   |3 +
 vcl/inc/win/winlayout.hxx  |2 
 vcl/source/gdi/CommonSalLayout.cxx |1 
 vcl/win/gdi/winlayout.cxx  |   95 +++--
 5 files changed, 90 insertions(+), 14 deletions(-)

New commits:
commit d85003a8af8b454b34eea0ac67c8dd9184a0b6d3
Author: Khaled Hosny 
Date:   Thu Dec 15 02:47:13 2016 +0200

tdf#104159: Re-enable OpenGL glyph caching on Windows

Reviewed-on: https://gerrit.libreoffice.org/32026
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 
(cherry picked from commit 9cf20b5f0473db0b4dd2dcf607b7884f40762995)

Change-Id: Icafec05a8cf4428d806efcb286addf3042fcf021
Reviewed-on: https://gerrit.libreoffice.org/32066
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index e5345d7..e2f3a11 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -45,6 +45,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC mhDC;
 HFONT   mhFont;
+WinFontInstance&mrWinFontInstance;
 double  mnAveWidthFactor;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle&mrCoreTextStyle;
@@ -65,6 +66,8 @@ public:
 #if defined(_WIN32)
 explicitCommonSalLayout(HDC, WinFontInstance&, const 
WinFontFace&);
 const FontSelectPattern& getFontSelData() const { return mrFontSelData; };
+HFONT   getHFONT() const { return mhFont; }
+WinFontInstance&getWinFontInstance() const { return 
mrWinFontInstance; }
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
 const CoreTextStyle&getFontData() const { return mrCoreTextStyle; };
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 3050055..14310f9 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -236,6 +236,9 @@ private:
 
 LogicalFontInstance* GetWinFontEntry(int nFallbackLevel);
 
+bool CacheGlyphs(const CommonSalLayout& rLayout);
+bool DrawCachedGlyphs(const CommonSalLayout& rLayout);
+
 public:
 HDC getHDC() const { return mhLocalDC; }
 void setHDC(HDC aNew) { mhLocalDC = aNew; }
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 7b15e7e..8ceebea 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -193,7 +193,7 @@ public:
 private:
 GlyphCache maGlyphCache;
 public:
-bool CacheGlyphToAtlas(bool bRealGlyphIndices, int nGlyphIndex, const 
WinLayout& rLayout, SalGraphics& rGraphics);
+bool CacheGlyphToAtlas(bool bRealGlyphIndices, HDC hDC, HFONT hFont, int 
nGlyphIndex, SalGraphics& rGraphics);
 
 GlyphCache& GetGlyphCache()
 {
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index dbc3fa8..8ab8eb3 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -181,6 +181,7 @@ CommonSalLayout::CommonSalLayout(HDC hDC, WinFontInstance& 
rWinFontInstance, con
 :   mrFontSelData(rWinFontInstance.maFontSelData)
 ,   mhDC(hDC)
 ,   mhFont(static_cast(GetCurrentObject(hDC, OBJ_FONT)))
+,   mrWinFontInstance(rWinFontInstance)
 ,   mnAveWidthFactor(1.0f)
 ,   mpVertGlyphs(nullptr)
 {
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index c693b31..2d35175 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -66,7 +66,7 @@ inline int WinFontInstance::GetCachedGlyphWidth( int 
nCharCode ) const
 return it->second;
 }
 
-bool WinFontInstance::CacheGlyphToAtlas(bool bRealGlyphIndices, int 
nGlyphIndex, const WinLayout& rLayout, SalGraphics& rGraphics)
+bool WinFontInstance::CacheGlyphToAtlas(bool bRealGlyphIndices, HDC hDC, HFONT 
hFont, int nGlyphIndex, SalGraphics& rGraphics)
 {
 if (nGlyphIndex == DROPPED_OUTGLYPH)
 return true;
@@ -77,17 +77,17 @@ bool WinFontInstance::CacheGlyphToAtlas(bool 
bRealGlyphIndices, int nGlyphIndex,
 std::vector aCodePointsOrGlyphIndices(1);
 aCodePointsOrGlyphIndices[0] = nGlyphIndex;
 
-HDC hDC = CreateCompatibleDC(rLayout.mhDC);
-if (hDC == nullptr)
+HDC hNewDC = CreateCompatibleDC(hDC);
+if (hNewDC == nullptr)
 {
 SAL_WARN("vcl.gdi", "CreateCompatibleDC failed: " << 
WindowsErrorString(GetLastError()));
 return false;
 }
-HFONT hOrigFont = static_cast(SelectObject(hDC, rLayout.mhFont));
+HFONT hOrigFont = static_cast(SelectObject(hNewDC, hFont));
 if (hOrigFont == nullptr)
 {
 SAL_WARN("vcl.gdi", "SelectObject failed: " << 
WindowsErrorString(GetLastError()));
-DeleteDC(hDC);
+DeleteDC(hNewDC);
 return false;
 }
 
@@ -96,26 +96,26 @@ bool 

[Libreoffice-bugs] [Bug 72942] importing .docx file overwrites all global properties

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=72942

--- Comment #7 from Justin L  ---
Created attachment 129679
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129679=edit
recipe_template.odt: starter file containing some properties.

confirmed some parts in 5.3beta by starting with recipe_template.odt and
"Insert - Document..." recipe_chessecake.docx.

--- original template ---
Default Para font and Language: Liberation English US 
Created date: 12/16/2016, 08:26:40
Default Page Size: A6 landscape

 --- with inserted document ---
Default Para Font and Language: Calibri German
Created date: 11/29/2013, 20:55:00, Nicole Gschwind
Default Page Size: still A6 landscape

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104705] New: vcl OpenGL error

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104705

Bug ID: 104705
   Summary: vcl OpenGL error
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: graphics stack
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vstuart.fo...@utsa.edu

Description:
with OpenGL rendering enabled, attempt to copy a selected block of text
crashes.

disabling OpenGL clear the issue.

On Windows 10 Pro 64-bit en-US with
Version: 5.4.0.0.alpha0+
Build ID: 0c565095983b0cc8b96a78012c611b7a03962204
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-12-16_01:40:04
Locale: en-US (en_US); Calc: CL



Steps to Reproduce:
1. open Writer with OpenGL rendering enabled
2. insert dummy text (type "DT" highlight F3 to insert autotext) 
3. select a block of text with left button mouse drag
4. release mouse button
5. Ctrl+C --or-- context menu copy --or-- Std Toolbar Copy button
6. crash

Actual Results:  
crash

Expected Results:
ability to copy string of text to be able to paste


Reproducible: Always

User Profile Reset: No

Additional Info:
Following Stack trace.

0:028> g
ModLoad: 59a1 59a27000   C:\LODev540_x86_20161216_TB39\program\dtrans.dll
WARNING: Continuing a non-continuable exception
WARNING: Continuing a non-continuable exception
(28fc.6f4): Break instruction exception - code 8003 (first chance)
eax= ebx=0c86fac4 ecx=1d96b4f7 edx= esi=0048 edi=01b8e5ec
eip=68bd3f0f esp=01b8e2b0 ebp=01b8e2c0 iopl=0 nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b efl=00200246
d3d11!ThrowFailure+0x28:
68bd3f0f cc  int 3
0:000> ~* kp

.  0  Id: 28fc.6f4 Suspend: 1 Teb: 010cd000 Unfrozen
ChildEBP RetAddr  
01b8e2c0 68bc2c89 d3d11!ThrowFailure+0x28
01b8e5b8 68bc8223 d3d11!CDevice::CreateTexture2D_Worker+0x589
01b8e624 661117c0 d3d11!CDevice::CreateTexture2D+0xb3
01b8e650 66112f14 D2d1!CD3DDeviceCommon::CreateTexture+0x43
01b8e6dc 66074702 D2d1!CD3DSurface::Create+0xa3
01b8e754 66074627 D2d1!DCPresenter::BindDC+0xc2
01b8e774 6607496c D2d1!CBaseRenderTarget::BindDC+0x2f
01b8e7fc 683a1332 D2d1!D2DDCRenderTarget::BindDC+0x14c
WARNING: Stack unwind information not available. Following frames may be wrong.
01b8e82c 683a0aeb vcllo!TabitemValue::isRightAligned+0xba92
01b8e99c 683a2868 vcllo!TabitemValue::isRightAligned+0xb24b
01b8e9cc 683a2b16 vcllo!TabitemValue::isRightAligned+0xcfc8
01b8ea94 681ff888 vcllo!TabitemValue::isRightAligned+0xd276
01b8eaa4 68023181 vcllo!WriteWallpaper+0x6108
01b8eadc 68021dd4 vcllo!OutputDevice::ImplDrawTextDirect+0x181
01b8eaf8 6801ee40 vcllo!OutputDevice::ImplDrawText+0xe4
01b8eba4 67ee262e vcllo!OutputDevice::DrawText+0x3e0
01b8ecf0 67ee3be9 vcllo!StatusBar::ImplDrawItem+0x20e
01b8ed40 67db8d6c vcllo!StatusBar::Paint+0x1a9
01b8efb8 67dba1f6 vcllo!Point::operator+=+0x7cc
01b8f070 67db7e6a vcllo!vcl::Window::ImplCallPaint+0x386
01b8f0c8 67dba236 vcllo!BitmapEx::~BitmapEx+0x3da
01b8f17c 67db7e6a vcllo!vcl::Window::ImplCallPaint+0x3c6
01b8f1d4 67dba236 vcllo!BitmapEx::~BitmapEx+0x3da
01b8f288 67db9e60 vcllo!vcl::Window::ImplCallPaint+0x3c6
01b8f2a8 67dba346 vcllo!vcl::Window::ImplCallOverlapPaint+0xd0
01b8f2bc 67dbcb7f vcllo!vcl::Window::ImplHandlePaintHdl+0xd6
01b8f2c8 67db8803 vcllo!vcl::Window::LinkStubImplHandlePaintHdl+0xf
01b8f2dc 6823bb96 vcllo!Point::operator+=+0x263
01b8f2ec 6823e180 vcllo!Idle::Invoke+0x16
01b8f2f8 6823e2c4 vcllo!Scheduler::ImplStartTimer+0x180
01b8f3b8 682570db vcllo!Scheduler::ProcessTaskScheduling+0x134
01b8f5fc 6825924e vcllo!Application::ImplCallEventListeners+0x9cb
01b8f610 682550e6 vcllo!Application::Yield+0xe
01b8f658 6bcfee69 vcllo!Application::Execute+0x1b6
01b8f660 6bd03c6d sofficeapp!desktop::Desktop::DoExecute(void)+0x9
[c:\cygwin\home\tinderbox\master\desktop\source\app\app.cxx @ 1364]
01b8fd68 6825f4f7 sofficeapp!desktop::Desktop::Main(void)+0x1acd
[c:\cygwin\home\tinderbox\master\desktop\source\app\app.cxx @ 1685]
01b8fe34 6825f99f vcllo!DeInitVCL+0xf57
01b8fe40 6bd3bc44 vcllo!SVMain+0x2f
01b8feb4 00eb100a sofficeapp!soffice_main(void)+0x74
[c:\cygwin\home\tinderbox\master\desktop\source\app\sofficemain.cxx @ 166]
01b8fec0 00eb103a soffice+0x100a
01b8fecc 00eb1078 soffice!main+0x1a
01b8fee4 00eb12ce soffice!main+0x58
01b8ff30 753462c4 soffice!main+0x2ae
01b8ff44 774e0fd9 KERNEL32!BaseThreadInitThunk+0x24
01b8ff8c 774e0fa4 ntdll!__RtlUserThreadStart+0x2f
01b8ff9c  ntdll!_RtlUserThreadStart+0x1b



User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101
Firefox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org

[Libreoffice-bugs] [Bug 98863] FILEOPEN autoshapes: textboxes and text are missing

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98863

Justin L  changed:

   What|Removed |Added

   Priority|high|low
Summary|FILEOPEN TABLE table in |FILEOPEN autoshapes:
   |.doc file appears   |textboxes and text are
   |completely empty|missing

--- Comment #3 from Justin L  ---
This document is not actually a table - it is all line-art connected as if it
was a complicated table.  The text is all in autoshape boxes. So a lot of
"artistic license" went into the creation of this document.

Set to Low priority (as per comment 2) and changed the summary (was "FILEOPEN
TABLE table in .doc file appears completely empty") since this is not truly a
table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] PS Type 1 URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

V Stuart Foote  changed:

   What|Removed |Added

Summary|URW fonts missing in|PS Type 1 URW fonts missing
   |LibreOffice 5.3.0.0.beta1   |in LibreOffice
   |and 5.3.0.0.beta2   |5.3.0.0.beta1 and
   ||5.3.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

2016-12-15 Thread Khaled Hosny
 vcl/inc/CommonSalLayout.hxx|3 +
 vcl/inc/win/salgdi.h   |3 +
 vcl/source/gdi/CommonSalLayout.cxx |1 
 vcl/win/gdi/winlayout.cxx  |   69 +
 4 files changed, 76 insertions(+)

New commits:
commit 9cf20b5f0473db0b4dd2dcf607b7884f40762995
Author: Khaled Hosny 
Date:   Thu Dec 15 02:47:13 2016 +0200

tdf#104159: Re-enable OpenGL glyph caching on Windows

Change-Id: Icafec05a8cf4428d806efcb286addf3042fcf021
Reviewed-on: https://gerrit.libreoffice.org/32026
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 05ea342..b0c9381 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -45,6 +45,7 @@ class CommonSalLayout : public GenericSalLayout
 #ifdef _WIN32
 HDC mhDC;
 HFONT   mhFont;
+WinFontInstance&mrWinFontInstance;
 double  mnAveWidthFactor;
 #elif defined(MACOSX) || defined(IOS)
 const CoreTextStyle&mrCoreTextStyle;
@@ -67,6 +68,8 @@ public:
 #if defined(_WIN32)
 explicitCommonSalLayout(HDC, WinFontInstance&, const 
WinFontFace&);
 const FontSelectPattern& getFontSelData() const { return mrFontSelData; };
+HFONT   getHFONT() const { return mhFont; }
+WinFontInstance&getWinFontInstance() const { return 
mrWinFontInstance; }
 #elif defined(MACOSX) || defined(IOS)
 explicitCommonSalLayout(const CoreTextStyle&);
 const CoreTextStyle&getFontData() const { return mrCoreTextStyle; };
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 8a493d7..65cf06f 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -180,6 +180,9 @@ private:
 
 LogicalFontInstance* GetWinFontEntry(int nFallbackLevel);
 
+bool CacheGlyphs(const CommonSalLayout& rLayout);
+bool DrawCachedGlyphs(const CommonSalLayout& rLayout);
+
 public:
 HDC getHDC() const { return mhLocalDC; }
 void setHDC(HDC aNew) { mhLocalDC = aNew; }
diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 2c059ef..d68534f 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -181,6 +181,7 @@ CommonSalLayout::CommonSalLayout(HDC hDC, WinFontInstance& 
rWinFontInstance, con
 :   mrFontSelData(rWinFontInstance.maFontSelData)
 ,   mhDC(hDC)
 ,   mhFont(static_cast(GetCurrentObject(hDC, OBJ_FONT)))
+,   mrWinFontInstance(rWinFontInstance)
 ,   mnAveWidthFactor(1.0f)
 ,   mpVertGlyphs(nullptr)
 {
diff --git a/vcl/win/gdi/winlayout.cxx b/vcl/win/gdi/winlayout.cxx
index d0d9615..1f31cfa 100644
--- a/vcl/win/gdi/winlayout.cxx
+++ b/vcl/win/gdi/winlayout.cxx
@@ -666,6 +666,70 @@ LogicalFontInstance* WinFontFace::CreateFontInstance( 
FontSelectPattern& rFSD )
 return pFontInstance;
 }
 
+bool WinSalGraphics::CacheGlyphs(const CommonSalLayout& rLayout)
+{
+static bool bDoGlyphCaching = (std::getenv("SAL_DISABLE_GLYPH_CACHING") == 
nullptr);
+if (!bDoGlyphCaching)
+return false;
+
+HDC hDC = getHDC();
+HFONT hFONT = rLayout.getHFONT();
+WinFontInstance& rFont = rLayout.getWinFontInstance();
+
+int nStart = 0;
+Point aPos(0, 0);
+const GlyphItem* pGlyph;
+while (rLayout.GetNextGlyphs(1, , aPos, nStart))
+{
+if (!rFont.GetGlyphCache().IsGlyphCached(pGlyph->maGlyphId))
+{
+if (!rFont.CacheGlyphToAtlas(hDC, hFONT, pGlyph->maGlyphId, *this))
+return false;
+}
+}
+
+return true;
+}
+
+bool WinSalGraphics::DrawCachedGlyphs(const CommonSalLayout& rLayout)
+{
+HDC hDC = getHDC();
+
+Rectangle aRect;
+rLayout.GetBoundRect(*this, aRect);
+
+COLORREF color = GetTextColor(hDC);
+SalColor salColor = MAKE_SALCOLOR(GetRValue(color), GetGValue(color), 
GetBValue(color));
+
+WinOpenGLSalGraphicsImpl *pImpl = 
dynamic_cast(mpImpl.get());
+if (!pImpl)
+return false;
+
+WinFontInstance& rFont = rLayout.getWinFontInstance();
+
+int nStart = 0;
+Point aPos(0, 0);
+const GlyphItem* pGlyph;
+while (rLayout.GetNextGlyphs(1, , aPos, nStart))
+{
+OpenGLGlyphDrawElement& 
rElement(rFont.GetGlyphCache().GetDrawElement(pGlyph->maGlyphId));
+OpenGLTexture& rTexture = rElement.maTexture;
+
+if (!rTexture)
+return false;
+
+SalTwoRect a2Rects(0, 0,
+   rTexture.GetWidth(), rTexture.GetHeight(),
+   aPos.X() - rElement.getExtraOffset() + 
rElement.maLeftOverhangs,
+   aPos.Y() - rElement.mnBaselineOffset - 
rElement.getExtraOffset(),
+   rTexture.GetWidth(), rTexture.GetHeight());
+
+pImpl->DeferredTextDraw(rTexture, salColor, a2Rects);
+

[Libreoffice-bugs] [Bug 104159] Uncached glyphs cause slow UI with new layout engine in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104159] Uncached glyphs cause slow UI with new layout engine in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104159

--- Comment #10 from Commit Notification 
 ---
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9cf20b5f0473db0b4dd2dcf607b7884f40762995

tdf#104159: Re-enable OpenGL glyph caching on Windows

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

--- Comment #8 from Khaled Hosny  ---
(In reply to Khaled Hosny from comment #7)
> Other Ghostscript fonts are also available as OpenType fonts from upstream.

http://git.ghostscript.com/?p=urw-core35-fonts.git;a=tree

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

Khaled Hosny  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #7 from Khaled Hosny  ---
You can use the TeX Gyre fonts
(http://www.gust.org.pl/projects/e-foundry/tex-gyre/) which are based on these
URW fonts but are available as OpenType fonts as well. Other Ghostscript fonts
are also available as OpenType fonts from upstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104702] German umlauts (ä, ö, ü) getting lost in exported pdf

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104702

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
A test document with example of styles dropping format would be helpful--but we
mostly need to know the font that the "title" style is corrupt with.

So we know the configuration of your system please post the Help -> About
dialog entry.

Also, please identify the version of MS Windows,  and the graphics card and
driver you are using.

All of those will impact the behavior of OpenGL or default GDI+ font fall back.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||104701


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104701
[Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 104701, which changed state.

Bug 104701 Summary: URW fonts missing in LibreOffice 5.3.0.0.beta1 and 
5.3.0.0.beta2
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Blocks||71732
 Resolution|--- |WONTFIX

--- Comment #6 from V Stuart Foote  ---
the non Unicode Type 1 PS fonts have been completely dropped with ESC approval


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=71732
[Bug 71732] [META] Bugs related to text rendering, typography and font features
in LO
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 5 commits - cui/source sc/source sfx2/source sw/source

2016-12-15 Thread Caolán McNamara
 cui/source/options/optlingu.cxx  |2 +-
 sc/source/filter/xml/xmlcondformat.cxx   |4 ++--
 sc/source/ui/docshell/dataprovider.cxx   |4 ++--
 sfx2/source/appl/appmisc.cxx |2 +-
 sw/source/core/draw/dcontact.cxx |4 ++--
 sw/source/core/layout/anchoreddrawobject.cxx |2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit a7bd6830e26d798068970684754fa23894d9f7c2
Author: Caolán McNamara 
Date:   Thu Dec 15 21:27:42 2016 +

coverity#1397206 Resource leak

Change-Id: I497388a353425811ff18d9b1937ca536b562ddfc

diff --git a/sc/source/ui/docshell/dataprovider.cxx 
b/sc/source/ui/docshell/dataprovider.cxx
index 7df702c..76f3776 100644
--- a/sc/source/ui/docshell/dataprovider.cxx
+++ b/sc/source/ui/docshell/dataprovider.cxx
@@ -106,10 +106,10 @@ void CSVFetchThread::EndThread()
 
 void CSVFetchThread::execute()
 {
-LinesType* pLines = new LinesType(10);
+LinesType aLines(10);
 
 // Read & store new lines from stream.
-for (Line & rLine : *pLines)
+for (Line & rLine : aLines)
 {
 rLine.maCells.clear();
 mpStream->ReadLine(rLine.maLine);
commit 932719a8c5e53eabe7586a7ac845ff2aaa11e46a
Author: Caolán McNamara 
Date:   Thu Dec 15 21:25:52 2016 +

coverity#1397203 Dereference after null check

Change-Id: Icd03b10226025bae28574e695ed6416f70d0f54a

diff --git a/sw/source/core/layout/anchoreddrawobject.cxx 
b/sw/source/core/layout/anchoreddrawobject.cxx
index c806f3f..1c95425 100644
--- a/sw/source/core/layout/anchoreddrawobject.cxx
+++ b/sw/source/core/layout/anchoreddrawobject.cxx
@@ -115,7 +115,7 @@ SwPosNotify::~SwPosNotify()
 }
 }
 // tdf#101464 notify SwAccessibleMap about new drawing object position
-if (mpOldPageFrame->getRootFrame()->IsAnyShellAccessible())
+if (mpOldPageFrame && 
mpOldPageFrame->getRootFrame()->IsAnyShellAccessible())
 {
 mpOldPageFrame->getRootFrame()->GetCurrShell()->Imp()->MoveAccessible(
 nullptr, mpAnchoredDrawObj->GetDrawObj(), maOldObjRect);
commit 7a9d5485a815af26c63790e3165477c68e164117
Author: Caolán McNamara 
Date:   Thu Dec 15 21:21:38 2016 +

coverity#1397207 Dereference before null check

Change-Id: I2578d59e98a2b1b040d9284b0ad0f68fd331d0df

diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index 73d2b38..0ef9fca 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -411,9 +411,9 @@ const SwAnchoredObject* SwFlyDrawContact::GetAnchoredObj( 
const SdrObject* _pSdr
 
 const SwAnchoredObject* pRetAnchoredObj = nullptr;
 
-if ( _pSdrObj && dynamic_cast( _pSdrObj) !=  
nullptr )
+if (const SwVirtFlyDrawObj* pFlyDrawObj = dynamic_cast(_pSdrObj))
 {
-pRetAnchoredObj = static_cast(_pSdrObj)->GetFlyFrame();
+pRetAnchoredObj = pFlyDrawObj->GetFlyFrame();
 }
 
 return pRetAnchoredObj;
commit f74cad45681cc0ea5706a112a0e17f14a3197e39
Author: Caolán McNamara 
Date:   Thu Dec 15 21:17:58 2016 +

coverity#1397204 Dereference null return value

Change-Id: Ief4b455b316b55ebf012a8650c96da037df0135c

diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index a982606..cd32265 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -222,7 +222,7 @@ static void lcl_SetCheckButton( SvTreeListEntry* pEntry, 
bool bCheck )
 SvLBoxButton* pItem = 
static_cast(pEntry->GetFirstItem(SvLBoxItemType::Button));
 
 DBG_ASSERT(pItem,"SetCheckButton:Item not found");
-if (pItem->GetType() == SvLBoxItemType::Button)
+if (pItem && pItem->GetType() == SvLBoxItemType::Button)
 {
 if (bCheck)
 pItem->SetStateChecked();
commit eb0e2dabde9d96892929f6902d8d10d722b83c3e
Author: Caolán McNamara 
Date:   Thu Dec 15 21:15:29 2016 +

coverity#1397200 Unchecked return value

and

coverity#1397201 Unchecked return value
coverity#1397202 Unchecked return value

Change-Id: I73cc6e3b08e6a44b27be2093ba568d46ebe0659a

diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index 6479f1b..d34c27c 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -266,7 +266,7 @@ ScXMLDataBarFormatContext::ScXMLDataBarFormatContext( 
ScXMLImport& rImport, sal_
 if(!sShowValue.isEmpty())
 {
 bool bShowValue = true;
-sax::Converter::convertBool( bShowValue, sShowValue );
+(void)sax::Converter::convertBool( bShowValue, sShowValue );
 mpFormatData->mbOnlyBar = !bShowValue;
 }
 
@@ -366,7 +366,7 @@ 
ScXMLIconSetFormatContext::ScXMLIconSetFormatContext(ScXMLImport& rImport, sal_u
 if(!sShowValue.isEmpty())
 {
 bool 

[Libreoffice-commits] core.git: 4 commits - sc/source svx/source

2016-12-15 Thread Eike Rathke
 sc/source/core/data/drwlayer.cxx  |7 +
 sc/source/ui/Accessibility/AccessibleDocument.cxx |   13 ++---
 svx/source/svdraw/svdedxv.cxx |   30 +++---
 3 files changed, 27 insertions(+), 23 deletions(-)

New commits:
commit 0c565095983b0cc8b96a78012c611b7a03962204
Author: Eike Rathke 
Date:   Fri Dec 16 00:36:00 2016 +0100

remove superfluous this->Init() call

Init() does exactly the same, just that it didn't because it was already 
done ...
Went in with IAccessible2 integration.

Change-Id: Ib29bd000e283bbb500689914f1ceb692dd0ab380

diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx 
b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index cbdc599b..e34f666 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -1555,17 +1555,12 @@ void ScAccessibleDocument::Notify( SfxBroadcaster& rBC, 
const SfxHint& rHint )
 mpAccessibleSpreadsheet.is())
 {
 FreeAccessibleSpreadsheet();
+
+// Shapes / form controls after reload not accessible, rebuild the
+// mpChildrenShapes variable.
 if (mpChildrenShapes)
 DELETEZ(mpChildrenShapes);
-
-// Accessibility: Shapes / form controls after reload not 
accessible
-if ( !mpChildrenShapes )
-{
-mpChildrenShapes = new ScChildrenShapes( this, mpViewShell, 
meSplitPos );
-}
-
-//Invoke Init() to rebuild the mpChildrenShapes variable
-this->Init();
+mpChildrenShapes = new ScChildrenShapes( this, mpViewShell, 
meSplitPos );
 
 AccessibleEventObject aEvent;
 aEvent.EventId = AccessibleEventId::INVALIDATE_ALL_CHILDREN;
commit 6a334757082be4915e7e731ce4c1b0bd4641050d
Author: Eike Rathke 
Date:   Fri Dec 16 00:18:52 2016 +0100

Resolves: tdf#103543 disable mass broadcasts from drawing objects' changes

Specifically the a11y listeners are nasty bottle necks. A11y will get
updated on paint/view. We're touching all objects on that drawing page
to reposition so interdependencies that need to be broadcasted should
not happen.

Change-Id: Ic80446e22422a3097281ba20eecf0a078ac6a7cb

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 1deb958..3689aab 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -587,6 +587,9 @@ void ScDrawLayer::SetPageSize( sal_uInt16 nPageNo, const 
Size& rSize, bool bUpda
 
 bool bNegativePage = pDoc && pDoc->IsNegativePage( 
static_cast(nPageNo) );
 
+// Disable mass broadcasts from drawing objects' position changes.
+bool bWasLocked = isLocked();
+setLock(true);
 const size_t nCount = pPage->GetObjCount();
 for ( size_t i = 0; i < nCount; ++i )
 {
@@ -595,6 +598,7 @@ void ScDrawLayer::SetPageSize( sal_uInt16 nPageNo, const 
Size& rSize, bool bUpda
 if( pData )
 RecalcPos( pObj, *pData, bNegativePage, bUpdateNoteCaptionPos 
);
 }
+setLock(bWasLocked);
 }
 }
 
commit b954f1427a9549d89d8b0800259af9374b4767df
Author: Eike Rathke 
Date:   Thu Dec 15 21:34:17 2016 +0100

prevent mutiple broadcasts during the series of changes on one drawing 
object

Change-Id: I3a26d3589cbbcb8359242f7e1709fa7c34bd2900

diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index f2e93dd..1deb958 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -821,6 +821,9 @@ void ScDrawLayer::RecalcPos( SdrObject* pObj, 
ScDrawObjData& rData, bool bNegati
 }
 else
 {
+// Prevent mutiple broadcasts during the series of changes.
+SdrDelayBroadcastObjectChange aDelayBroadcastObjectChange(*pObj);
+
 bool bCanResize = bValid2 && !pObj->IsResizeProtect();
 
 //First time positioning, must be able to at least move it
commit ba53b2d28274ad4e36ef57084b48c4ed73d15e63
Author: Eike Rathke 
Date:   Thu Dec 15 19:54:15 2016 +0100

avoid dynamic_cast

Change-Id: I9f64eac95b39adc649b2e63cd5abdd6e7a448ee6

diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx
index 512bc34..1fe56c8 100644
--- a/svx/source/svdraw/svdedxv.cxx
+++ b/svx/source/svdraw/svdedxv.cxx
@@ -216,21 +216,23 @@ void SdrObjEditView::TakeActionRect(Rectangle& rRect) 
const
 void SdrObjEditView::Notify(SfxBroadcaster& rBC, const SfxHint& rHint)
 {
 SdrGlueEditView::Notify(rBC,rHint);
-// change of printer while editing
-const SdrHint* pSdrHint = dynamic_cast();
-if (pSdrHint!=nullptr && pTextEditOutliner!=nullptr) {
-SdrHintKind eKind=pSdrHint->GetKind();
-if (eKind==SdrHintKind::RefDeviceChange) {
-

[Libreoffice-bugs] [Bug 104533] Text disappears when selecting Script font

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104533

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |khaledho...@eglug.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102985
Bug 102985 depends on bug 104533, which changed state.

Bug 104533 Summary: Text disappears when selecting Script font
https://bugs.documentfoundation.org/show_bug.cgi?id=104533

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/win

2016-12-15 Thread Khaled Hosny
 vcl/win/gdi/salfont.cxx |   48 ++--
 1 file changed, 42 insertions(+), 6 deletions(-)

New commits:
commit 641b3461dd57b73807f7f55fa2d9b08fb777ed20
Author: Khaled Hosny 
Date:   Thu Dec 15 17:17:17 2016 +0200

tdf#104533: Fix font metrics for non-SFNT fonts

They can still be used with the old layout engine, so fallback to old
code when we encounter one of them. Not needed on master as the old
layout engine is gone there.

Change-Id: Ibe3e4772cb519843eeb44cfc7efd912ae9737b69
Reviewed-on: https://gerrit.libreoffice.org/32049
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 

diff --git a/vcl/win/gdi/salfont.cxx b/vcl/win/gdi/salfont.cxx
index 10ec674..fd207a5 100644
--- a/vcl/win/gdi/salfont.cxx
+++ b/vcl/win/gdi/salfont.cxx
@@ -1252,14 +1252,17 @@ void WinSalGraphics::GetFontMetric( 
ImplFontMetricDataRef& rxFontMetric, int nFa
 
 // get the font metric
 OUTLINETEXTMETRICW aOutlineMetric;
-const bool bOK = GetOutlineTextMetricsW(getHDC(), 
sizeof(OUTLINETEXTMETRICW), );
+TEXTMETRICW aWinMetric;
+bool bOK = GetOutlineTextMetricsW(getHDC(), sizeof(OUTLINETEXTMETRICW), 
);
+if (bOK)
+aWinMetric = aOutlineMetric.otmTextMetrics;
+else
+bOK = GetTextMetricsW(getHDC(), );
 // restore the HDC to the font in the base level
 SelectFont( getHDC(), hOldFont );
 if( !bOK )
 return;
 
-TEXTMETRICW aWinMetric = aOutlineMetric.otmTextMetrics;
-
 // device independent font attributes
 rxFontMetric->SetFamilyType(ImplFamilyToSal( aWinMetric.tmPitchAndFamily 
));
 rxFontMetric->SetSymbolFlag(aWinMetric.tmCharSet == SYMBOL_CHARSET);
@@ -1290,9 +1293,42 @@ void WinSalGraphics::GetFontMetric( 
ImplFontMetricDataRef& rxFontMetric, int nFa
 // transformation dependent font metrics
 rxFontMetric->SetWidth( static_cast( mfFontScale[nFallbackLevel] * 
aWinMetric.tmAveCharWidth ) );
 
-const std::vector rHhea(aHheaRawData.get(), aHheaRawData.get() + 
aHheaRawData.size());
-const std::vector rOS2(aOS2RawData.get(), aOS2RawData.get() + 
aOS2RawData.size());
-rxFontMetric->ImplCalcLineSpacing(rHhea, rOS2, aOutlineMetric.otmEMSquare);
+if (aHheaRawData.size() > 0 || aOS2RawData.size() > 0)
+{
+const std::vector rHhea(aHheaRawData.get(), 
aHheaRawData.get() + aHheaRawData.size());
+const std::vector rOS2(aOS2RawData.get(), aOS2RawData.get() + 
aOS2RawData.size());
+rxFontMetric->ImplCalcLineSpacing(rHhea, rOS2, 
aOutlineMetric.otmEMSquare);
+}
+else
+{
+// Falback to GDI code, can only happen with non-SFNT fonts
+rxFontMetric->SetInternalLeading( static_cast( 
mfFontScale[nFallbackLevel] * aWinMetric.tmInternalLeading ) );
+rxFontMetric->SetExternalLeading( static_cast( 
mfFontScale[nFallbackLevel] * aWinMetric.tmExternalLeading ) );
+rxFontMetric->SetAscent( static_cast( mfFontScale[nFallbackLevel] 
* aWinMetric.tmAscent ) );
+rxFontMetric->SetDescent( static_cast( 
mfFontScale[nFallbackLevel] * aWinMetric.tmDescent ) );
+// #107888# improved metric compatibility for Asian fonts...
+// TODO: assess workaround below for CWS >= extleading
+// TODO: evaluate use of aWinMetric.sTypo* members for CJK
+if( mpWinFontData[nFallbackLevel] && 
mpWinFontData[nFallbackLevel]->SupportsCJK() )
+{
+rxFontMetric->SetInternalLeading( 
rxFontMetric->GetInternalLeading() + rxFontMetric->GetExternalLeading() );
+
+// #109280# The line height for Asian fonts is too small.
+// Therefore we add half of the external leading to the
+// ascent, the other half is added to the descent.
+const long nHalfTmpExtLeading = rxFontMetric->GetExternalLeading() 
/ 2;
+const long nOtherHalfTmpExtLeading = 
rxFontMetric->GetExternalLeading() - nHalfTmpExtLeading;
+
+// #110641# external leading for Asian fonts.
+// The factor 0.3 has been confirmed with experiments.
+long nCJKExtLeading = static_cast(0.30 * 
(rxFontMetric->GetAscent() + rxFontMetric->GetDescent()));
+nCJKExtLeading -= rxFontMetric->GetExternalLeading();
+rxFontMetric->SetExternalLeading( (nCJKExtLeading > 0) ? 
nCJKExtLeading : 0 );
+
+rxFontMetric->SetAscent( rxFontMetric->GetAscent() + 
nHalfTmpExtLeading );
+rxFontMetric->SetDescent(  rxFontMetric->GetDescent() + 
nOtherHalfTmpExtLeading );
+}
+}
 
 rxFontMetric->SetMinKashida( GetMinKashidaWidth() );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

JPJ  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #5 from JPJ  ---
It looks like they are type 1 fonts from the gsfonts package.  It's really
unfortunate if those are going to be dropped in LO 5.3.  These URW fonts are
pretty much the only ones I used and I only discovered them because of
LibreOffice.

> fc-list | grep URW
/usr/share/fonts/X11/Type1/p052024l.pfb: URW Palladio L:style=Bold Italic
/usr/share/fonts/X11/Type1/p052023l.pfb: URW Palladio L:style=Italic
/usr/share/fonts/X11/Type1/b018015l.pfb: URW Bookman L:style=Demi Bold
/usr/share/fonts/type1/gsfonts/p052023l.pfb: URW Palladio L:style=Italic
/usr/share/fonts/X11/Type1/z003034l.pfb: URW Chancery L:style=Medium Italic
/usr/share/fonts/type1/gsfonts/z003034l.pfb: URW Chancery L:style=Medium Italic
/usr/share/fonts/X11/Type1/a010033l.pfb: URW Gothic L:style=Book Oblique
/usr/share/fonts/X11/Type1/a010015l.pfb: URW Gothic L:style=Demi
/usr/share/fonts/X11/Type1/p052004l.pfb: URW Palladio L:style=Bold
/usr/share/fonts/type1/gsfonts/a010013l.pfb: URW Gothic L:style=Book
/usr/share/fonts/type1/gsfonts/p052004l.pfb: URW Palladio L:style=Bold
/usr/share/fonts/X11/Type1/b018032l.pfb: URW Bookman L:style=Light Italic
/usr/share/fonts/type1/gsfonts/a010015l.pfb: URW Gothic L:style=Demi
/usr/share/fonts/X11/Type1/a010035l.pfb: URW Gothic L:style=Demi Oblique
/usr/share/fonts/type1/gsfonts/a010033l.pfb: URW Gothic L:style=Book Oblique
/usr/share/fonts/type1/gsfonts/b018035l.pfb: URW Bookman L:style=Demi Bold
Italic
/usr/share/fonts/type1/gsfonts/a010035l.pfb: URW Gothic L:style=Demi Oblique
/usr/share/fonts/X11/Type1/b018035l.pfb: URW Bookman L:style=Demi Bold Italic
/usr/share/fonts/type1/gsfonts/b018012l.pfb: URW Bookman L:style=Light
/usr/share/fonts/X11/Type1/a010013l.pfb: URW Gothic L:style=Book
/usr/share/fonts/X11/Type1/b018012l.pfb: URW Bookman L:style=Light
/usr/share/fonts/type1/gsfonts/b018032l.pfb: URW Bookman L:style=Light Italic
/usr/share/fonts/type1/gsfonts/p052003l.pfb: URW Palladio L:style=Roman
/usr/share/fonts/type1/gsfonts/b018015l.pfb: URW Bookman L:style=Demi Bold
/usr/share/fonts/X11/Type1/p052003l.pfb: URW Palladio L:style=Roman
/usr/share/fonts/type1/gsfonts/p052024l.pfb: URW Palladio L:style=Bold Italic
> 

>dpkg-query -S /usr/share/fonts/type1/gsfonts/a010013l.pfb
gsfonts: /usr/share/fonts/type1/gsfonts/a010013l.pfb
>   
> 
> dpkg-query -S /usr/share/fonts/X11/Type1/a010013l.pfb
gsfonts-x11: /usr/share/fonts/X11/Type1/a010013l.pfb
>   
> 
> apt-cache show gsfonts
Package: gsfonts
Priority: optional  
Section: text   
Installed-Size: 4764
Maintainer: Ubuntu Developers    
Original-Maintainer: Masayuki Hatta (mhatta) 
Architecture: all
Version: 1:8.11+urwcyr1.0.7~pre44-4.2ubuntu1
Conflicts: gs (<< 5.50-5), gs-aladdin (<< 6.50-4), gsfonts-x11 (<< 0.13)
Filename: pool/main/g/gsfonts/gsfonts_8.11+urwcyr1.0.7~pre44-4.2ubuntu1_all.deb
Size: 3373970
MD5sum: 47126e30ae67398d61e7af8cff54f3db
SHA1: 261a68c2136932e975e50e3f053233845af09923
SHA256: fae918c51d76e993f984d0a9e108c9abb64db0dfcd75d39a40f939d740972661
Description-en: Fonts for the Ghostscript interpreter(s)
 These are free look-alike fonts of the Adobe PostScript fonts.
 Recommended for all flavors of Ghostscript (gs-gpl, gs-afpl and gs-esp).
Description-md5: c77fd616d53a8b059361ca26ef255651
Homepage: http://www.ghostscript.com/
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Origin: Ubuntu
Supported: 5y
Task: ubuntu-desktop, ubuntu-usb, print-server, kubuntu-desktop,
edubuntu-desktop, edubuntu-usb, xubuntu-core, xubuntu-desktop,
mythbuntu-frontend, mythbuntu-desktop, lubuntu-core, ubuntustudio-desktop-core,
ubuntustudio-desktop, ubuntu-gnome-desktop, ubuntu-sdk, ubuntukylin-desktop,
ubuntu-mate-core, ubuntu-mate-desktop, ubuntu-mate-cloudtop

>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 91132] FILESAVE: save a copy or export as pdf -> ending isn' t handled well

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91132

--- Comment #34 from Markus Grob  ---
1. OpenCL isn't activ. I haven't found OpenGL.
2. I always turn the ending on, if I work on a Windows-PC.

Markus

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104624] Import issues with Pagemaker 6.5 files

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104624

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Aron Budea  ---
I'm not saying they're the problem, but substituted fonts make comparison
rather difficult.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104704] New: FILESAVE as DOC: Table in footer mangled following page style change to same style

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104704

Bug ID: 104704
   Summary: FILESAVE as DOC: Table in footer mangled following
page style change to same style
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l...@deller.id.au

Created attachment 129677
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129677=edit
Sample document mangled-footer.odt

Steps to reproduce:
1. Open the attached mangled-footer.odt
2. File -> "Save a Copy" as mangled-footer.doc
3. Open mangled-footer.doc (either in MS Word or LibreOffice Writer) and see
that the footer on the second page is mangled

The key elements in this sample document are:

* The paragraph at the top of the second page has a paragraph style to insert a
page break before the paragraph, changing the page style to "Default Style"
(which is the same page style it was on already).  If this is edited to be a
simple page break without the page style change, then the problem does not
occur.

* The footer contains a table followed by a paragraph.  If the table is removed
from the footer then the problem does not occur.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

--- Comment #4 from Adolfo Jayme  ---
Support for old Type-1-format fonts has been dropped. Ensure the URW fonts you
have installed are SFNT (TrueType or OpenType).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 101563] Export to PDF with linked images creates huge PDF files.

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101563

--- Comment #52 from Aron Budea  ---
Much simpler indeed. Looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104675] Conditional Format not updated on change value in a cell it depends on by formula

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104675

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #3 from m.a.riosv  ---
I can't reproduce with:
Version: 5.3.0.0.beta2 (x64)
Build ID: a7e30712ad6d8bc9286007b37aa581983e0caba3
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: es-ES (es_ES); Calc: CL
Versión: 5.3.0.0.beta2
Id. de compilación: a7e30712ad6d8bc9286007b37aa581983e0caba3
Subprocesos de CPU: 4; Versión de SO: Windows 6.2; Repr. de IU: predet.; Motor
de trazado:HarfBuzz; 
Configuración regional: es-ES (es_ES); Calc: CL

For me no matter if OpenCL is enabled or not but maybe can affect in your case.

Please test changing OpenCL state.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104688] I believes Microsoft has tampered with my Libreoffice word

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104688

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||miguelangelrv@libreoffice.o
   ||rg
 Ever confirmed|0   |1

--- Comment #2 from m.a.riosv  ---
Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affects all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104699] FILEOPEN: DOC: Checkbox missing

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104699

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Hi Xisco, looks like a dup of #87183

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104686] Crash in: MenuFloatingWindow::ImplGetStartY()

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104686

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Buovjaga  ---
Hey, thanks for testing. I think we can set this to "works for me". If the
problem ever comes back, we can revisit.

If you want to help sometimes, you can check out this introduction to quality
assurance: https://wiki.documentfoundation.org/QA/GetInvolved
We have quite a good team, some do a little here and there, some do stuff more
regularly. Yet, there is *always* work to do in the bug tracker. It is easy to
step in and out of, because the tasks are bite-size.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


New Defects reported by Coverity Scan for LibreOffice

2016-12-15 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

12 new defect(s) introduced to LibreOffice found with Coverity Scan.
30 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 12 of 12 defect(s)


** CID 1397207:  Null pointer dereferences  (REVERSE_INULL)
/sw/source/core/draw/dcontact.cxx: 414 in 
SwFlyDrawContact::GetAnchoredObj(const SdrObject *) const()



*** CID 1397207:  Null pointer dereferences  (REVERSE_INULL)
/sw/source/core/draw/dcontact.cxx: 414 in 
SwFlyDrawContact::GetAnchoredObj(const SdrObject *) const()
408 " - wrong object type 
object provided" );
409 assert(GetUserCall(_pSdrObj) == this &&
410 " - provided object 
doesn't belong to this contact");
411 
412 const SwAnchoredObject* pRetAnchoredObj = nullptr;
413 
>>> CID 1397207:  Null pointer dereferences  (REVERSE_INULL)
>>> Null-checking "_pSdrObj" suggests that it may be null, but it has 
>>> already been dereferenced on all paths leading to the check.
414 if ( _pSdrObj && dynamic_cast( _pSdrObj) 
!=  nullptr )
415 {
416 pRetAnchoredObj = static_cast(_pSdrObj)->GetFlyFrame();
417 }
418 
419 return pRetAnchoredObj;

** CID 1397206:  Resource leaks  (RESOURCE_LEAK)
/sc/source/ui/docshell/dataprovider.cxx: 123 in sc::CSVFetchThread::execute()()



*** CID 1397206:  Resource leaks  (RESOURCE_LEAK)
/sc/source/ui/docshell/dataprovider.cxx: 123 in sc::CSVFetchThread::execute()()
117 orcus::csv_parser parser(rLine.maLine.getStr(), 
rLine.maLine.getLength(), aHdl, maConfig);
118 parser.parse();
119 }
120 
121 if (!mpStream->good())
122 RequestTerminate();
>>> CID 1397206:  Resource leaks  (RESOURCE_LEAK)
>>> Variable "pLines" going out of scope leaks the storage it points to.
123 }
124 
125 CSVDataProvider::CSVDataProvider(const OUString& rURL, const ScRange& 
rRange):
126 maURL(rURL),
127 mrRange(rRange),
128 mbImportUnderway(false)

** CID 1397205:  Memory - corruptions  (OVERRUN)



*** CID 1397205:  Memory - corruptions  (OVERRUN)
/ucb/source/ucp/file/filtask.cxx: 694 in fileaccess::TaskManager::page(int, 
const rtl::OUString &, const 
com::sun::star::uno::Reference &)()
688 
689 do
690 {
691 err = aFile.read( static_cast(BFF),bfz,nrc );
692 if(  err == osl::FileBase::E_None )
693 {
>>> CID 1397205:  Memory - corruptions  (OVERRUN)
>>> Overrunning array "BFF" of 512 8-byte elements by passing it to a 
>>> function which accesses it at element index 4095 (byte offset 32760) using 
>>> argument "(sal_uInt32)nrc" (which evaluates to 4096).
694 uno::Sequence< sal_Int8 > seq( BFF, (sal_uInt32)nrc );
695 try
696 {
697 xOutputStream->writeBytes( seq );
698 }
699 catch (const io::NotConnectedException&)

** CID 1397204:  Null pointer dereferences  (NULL_RETURNS)
/cui/source/options/optlingu.cxx: 225 in lcl_SetCheckButton(SvTreeListEntry *, 
bool)()



*** CID 1397204:  Null pointer dereferences  (NULL_RETURNS)
/cui/source/options/optlingu.cxx: 225 in lcl_SetCheckButton(SvTreeListEntry *, 
bool)()
219 
220 static void lcl_SetCheckButton( SvTreeListEntry* pEntry, bool bCheck )
221 {
222 SvLBoxButton* pItem = 
static_cast(pEntry->GetFirstItem(SvLBoxItemType::Button));
223 
224 DBG_ASSERT(pItem,"SetCheckButton:Item not found");
>>> CID 1397204:  Null pointer dereferences  (NULL_RETURNS)
>>> Dereferencing a pointer that might be null "pItem" when calling 
>>> "GetType". (The dereference happens because this is a virtual function 
>>> call.)
225 if (pItem->GetType() == SvLBoxItemType::Button)
226 {
227 if (bCheck)
228 pItem->SetStateChecked();
229 else
230 pItem->SetStateUnchecked();

** CID 1397203:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/layout/anchoreddrawobject.cxx: 66 in 
SwPosNotify::~SwPosNotify()()



*** CID 1397203:  Null pointer dereferences  (FORWARD_NULL)

[Libreoffice-bugs] [Bug 104686] Crash in: MenuFloatingWindow::ImplGetStartY()

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104686

garfieldba...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from garfieldba...@gmail.com ---
When this originally occurred, I uninstalled 5.2 and installed 5.1 and it
worked fine. After seeing your request, I uninstalled 5.1 and reinstalled 5.2
and the bug no longer occurs.

After reinstalling 5.2, I verified "Tools - Options - LibreOffice - View - Use
OpenGL for all rendering" and it was not checked. While I did not verify this
option before uninstalling the original installation, I do not believe I had
ever changed this from whatever the default was.

Thank you for efforts. Please let me know if there is anything else you would
like me to do, or any other information you would like me to provide, in order
to help make this wonderful project more stable.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: source/text

2016-12-15 Thread Gabor Kelemen
 source/text/scalc/01/0510.xhp   |2 +-
 source/text/swriter/01/0514.xhp |6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 2234be96c0865090b2e1c47e5138f011b566512c
Author: Gabor Kelemen 
Date:   Thu Dec 15 20:19:02 2016 +0100

tdf#104569 Fix icon paths on Style and Formatting pages

Change-Id: Ida5a3a066946c8d195023bfd182bae0a703bbb5c
Reviewed-on: https://gerrit.libreoffice.org/32052
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/source/text/scalc/01/0510.xhp 
b/source/text/scalc/01/0510.xhp
index 10eb59e..7ce51e5 100644
--- a/source/text/scalc/01/0510.xhp
+++ b/source/text/scalc/01/0510.xhp
@@ -81,7 +81,7 @@
 
   
 
-   Icon
+   Icon
 
 
   Page 
Styles
diff --git a/source/text/swriter/01/0514.xhp 
b/source/text/swriter/01/0514.xhp
index 48e1f80..06a70db 100644
--- a/source/text/swriter/01/0514.xhp
+++ b/source/text/swriter/01/0514.xhp
@@ -96,7 +96,7 @@
 
   
 
-   Icon
+   Icon
 
 
   Frame 
Styles
@@ -110,7 +110,7 @@
 
   
 
-   Icon
+   Icon
 
 
   Page 
Styles
@@ -124,7 +124,7 @@
 
   
 
-   Icon
+   Icon
 
 
   List 
Styles
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2016-12-15 Thread Gabor Kelemen
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4dae0f055cddb52d2be0bbf0a37281ece8486968
Author: Gabor Kelemen 
Date:   Thu Dec 15 20:19:02 2016 +0100

Updated core
Project: help  2234be96c0865090b2e1c47e5138f011b566512c

tdf#104569 Fix icon paths on Style and Formatting pages

Change-Id: Ida5a3a066946c8d195023bfd182bae0a703bbb5c
Reviewed-on: https://gerrit.libreoffice.org/32052
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/helpcontent2 b/helpcontent2
index 7d62908..2234be9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 7d62908799da6b9ec1f4c2749fbbef9d7093effd
+Subproject commit 2234be96c0865090b2e1c47e5138f011b566512c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: cui/source

2016-12-15 Thread Katarina Behrens
 cui/source/tabpages/tparea.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 4c5079791f5d985151ebc090c5a07705e76a728e
Author: Katarina Behrens 
Date:   Thu Dec 15 16:36:00 2016 +0100

tdf#104221: Make up for non-existent FillItemSet

for fill:none option

Change-Id: I12ada9276a613f157976650148f2389126d16f08
Reviewed-on: https://gerrit.libreoffice.org/32050
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index db7cd3f..0032e28 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -205,6 +205,14 @@ DeactivateRC SvxAreaTabPage::DeactivatePage( SfxItemSet* 
_pSet )
 FillType eFillType = static_cast(maBox.GetCurrentButtonPos());
 switch( eFillType )
 {
+case TRANSPARENT:
+{
+// Fill: None doesn't have its own tabpage and thus
+// implementation of FillItemSet, so we supply it here
+XFillStyleItem aStyleItem( drawing::FillStyle_NONE );
+_pSet->Put( aStyleItem );
+break;
+}
 case SOLID:
 return DeactivatePage_Impl(_pSet);
 case GRADIENT:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/source

2016-12-15 Thread Justin Luth
 sw/source/filter/ww8/ww8par6.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 426215ca6fedd13ece07463ee95dd33bdb1a9a28
Author: Justin Luth 
Date:   Thu Dec 15 20:24:46 2016 +0300

tdf#75856 SwTwips: replace with unambiguous sal_Int32

Change-Id: Ifa59f8dad31ad0445c32ac0265d7c1573da4
Reviewed-on: https://gerrit.libreoffice.org/32051
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 59112cb..68b017e 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -599,7 +599,7 @@ void wwSectionManager::SetPageULSpaceItems(SwFrameFormat 
,
 else
 {
 // #i48832# - set correct spacing between header and body.
-const SwTwips nHdLowerSpace( std::abs(rSection.maSep.dyaTop) - 
rData.nSwUp - rData.nSwHLo );
+const sal_Int32 nHdLowerSpace( std::abs(rSection.maSep.dyaTop) 
- rData.nSwUp - rData.nSwHLo );
 pHdFormat->SetFormatAttr(SwFormatFrameSize(ATT_FIX_SIZE, 0, 
rData.nSwHLo + nHdLowerSpace));
 aHdUL.SetLower( static_cast< sal_uInt16 >(nHdLowerSpace) );
 pHdFormat->SetFormatAttr(SwHeaderAndFooterEatSpacingItem(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 95958] enhancement: tune the comment box (width/padding) for visual comfort

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=95958

--- Comment #3 from al  ---
Just adding my vote, I could also use a control on the width of comment. I have
a wide screen and collaborate on documents with partner. I make me sad to see
all the empty space on each side of my document. I can zoom the main window, it
seems like I should be able to drag the width of the comment bar at the top to
increase the width of the comment window. It could be adjusting the ratio of
text window to comment window, that way zoom would still work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104703] FILEOPEN: Wrong Position of MS .docx Chart Object on Import

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104703

Luke  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||824

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104703] New: FILEOPEN: Wrong Position of MS .docx Chart Object on Import

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104703

Bug ID: 104703
   Summary: FILEOPEN: Wrong Position of MS .docx Chart Object on
Import
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lukebe...@hotmail.com

This is a follow-up to Bug 82824. With that fixed, we now correctly import
anchor settings for charts, but many position types are not properly handled.
For example the picture in attachment 128970 and the chart in attachment 115322
have the same position settings. But only the picture is correctly imported.

The correct value is 
Horiz: From left by 3.45” to Paragraph area
Vert: From top by 0.24” to Margin

The value imported is
Horiz: From left by 0.0” to Paragraph area
Vert: From top by 0.0” to Margin

So only the values need to be correctly populated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 88414] WIKIHELP: swriter/ SW_HID_NAVIGATOR_TREELIST page does not exist

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88414

Gabor Kelemen  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96878] FILESAVE: duplicate attributes inserted into docx on save

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96878

Buovjaga  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #9 from Buovjaga  ---
Adding Mike, so he can see the previous results.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70433] EDITING: Embedded Firebird - List doesn't work in queries, works in external Firebird

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70433

--- Comment #15 from rob...@familiegrosskopf.de ---

(In reply to Tamas Bunth from comment #14) 
> - Use list with an extra CAST():
> 
> SELECT CAST (LIST( "Vorname", ' and ' )  as VARCHAR(32000) ) FROM
> "Name_VarcharID"
> 
> That should work. At least it works for me.

Thanks Tamas! This is a good workaround for me. Works also here with LO
5.4.0.0.alpha0+ and with LO 5.2.4.1 (Firebird 2.5).

We shouldn't set this to WORKSFORME, but could wait a little bit with this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 99006] FORMATTING: Freeze when attempting to Insert Index/ Table of Contents and editing a Style (non-admin Windows accounts)

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99006

--- Comment #18 from Buovjaga  ---
The command ~* kp can be used with hangs, that is why I suggested it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104017] FILESAVE: DOC: New rows are displayed on table after RT

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104017

--- Comment #2 from Xisco Faulí  ---
Created attachment 129676
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129676=edit
sample2

another file affected by the same commit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

--- Comment #3 from Buovjaga  ---
Disregard my previous mention about them being proprietary. You might well be
talking about the free ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
This is obviously due to the text layout engine changes in 5.3.
Please give more information about these URW fonts. I know they are proprietary
and thus practically untestable by QA and developers.
Check the font properties and give us all the relevant data you can.
Please especially check, if they are Type1 fonts.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104488] LibO hangs/chashes when scrolling document (GTK+/GTK3)

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104488

Michael Stahl  changed:

   What|Removed |Added

 Attachment #129567|text/x-log  |text/plain
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104239] FILEOPEN: DOC: Incorrect numbering in second level

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104239

--- Comment #2 from Xisco Faulí  ---
Created attachment 129675
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129675=edit
sample2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 96878] FILESAVE: duplicate attributes inserted into docx on save

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=96878

--- Comment #8 from Telesto  ---
No repro with
Version: 5.4.0.0.alpha0+
Build ID: b52167df08511239c3d08904a3d12a3c92141f38
CPU Threads: 4; OS Version: Mac OS X 10.12.1; UI Render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-12-09_23:41:33
Locale: nl-NL (nl_NL.UTF-8); Calc: group

and also not with:
Version: 5.0.6.3
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: nl-NL (nl_NL.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: OpenCL enabled by default after OS reinstall causing Unit Test Failure

2016-12-15 Thread slacka
If someone wants to dig deeper, I’d be glad to run special debug builds like
I did for Ashod’s failing Unit tests.

Or, should we just blacklist my driver? What info do you need for that?

-Luke




--
View this message in context: 
http://nabble.documentfoundation.org/OpenCL-enabled-by-default-after-OS-reinstall-causing-Unit-Test-Failure-tp4202419p4202823.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 99006] FORMATTING: Freeze when attempting to Insert Index/ Table of Contents and editing a Style (non-admin Windows accounts)

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=99006

--- Comment #17 from R. Bingham  ---
Hmmm... the referenced Wiki article is almost entirely about capturing and
analyzing crash events.  What we have here is a hang (Windows spinner and
un-responsive window from the user's POV) with elevated CPU consumption, not a
crash.  The Wiki article does not contain the word 'hang' but does have a
section on producing a mini-dump for analysis by WinDbg using the MS tool
ProcDump (http://technet.microsoft.com/en-us/sysinternals/dd996900).  However,
the instructions for ProcDump in the Wiki article are thin and ProcDump has 26
option flags.

Perhaps if a Windows person could take a quick look at the ProcDump man page on
MS Technet and update the Wiki with a recommended ProcDump option set to get
the the most value when capturing a x64 LO Writer mini-dump.  I also suggest
the word 'hang' be included in the ProcDump section of the Wiki article.

Let me know,

R

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104702] New: German umlauts (ä, ö, ü) getting lost in exported pdf

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104702

Bug ID: 104702
   Summary: German umlauts (ä,ö,ü) getting lost in exported pdf
   Product: LibreOffice
   Version: 5.2.3.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: don-elg...@t-online.de

Description:
I hae tested this issue, it only occurs in specific stylesheets
("title"-Stylesheets). Umlauts like ä, ö or ü are getting transformed into mere
a,o and u within the resulting pdf-file, which is very very annoying.

Steps to Reproduce:
1.Set a title with an umlaut
2.give it the stylesheet title or title1-4 (german: Überschrift1-4)
3.Export the pdf-File

Actual Results:  
The ä,ö and ü-letters are transformed into a, o and u

Expected Results:
It should let the umlauts be umlauts


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101
Firefox/50.0 Cyberfox/50.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104145] on opening file formatting changes occur in random cells in random sheets

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104145

pherwo...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #10 from pherwo...@gmail.com ---
Status changed as suggested.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Cor Nouws
Hi Bjoern,

Bjoern Michaelsen wrote on 15-12-16 19:10:

> Yes, but the rationale was the extraordinary number of MM regressions we had
> during the cleanup of the old (really horrible) code. That major cleanup is
> finishe for the most part now, activity in the area is back to normal, so no
> justification anymore to highlight MM regressions over regressions elsewhere.

Ah, sure makes sense.
Thanks for explaining,

Ciao - Cor


-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 104145] on opening file formatting changes occur in random cells in random sheets

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104145

--- Comment #9 from m.a.riosv  ---
It was never confirmed, so I think resolved as "FIXED" it's not right.

I think better change the resolution to WORKSFORME OR INSUFFICIENTDATA.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Cor Nouws
Hi Bjoern,

Bjoern Michaelsen wrote on 15-12-16 19:10:

> Yes, but the rationale was the extraordinary number of MM regressions we had
> during the cleanup of the old (really horrible) code. That major cleanup is
> finishe for the most part now, activity in the area is back to normal, so no
> justification anymore to highlight MM regressions over regressions elsewhere.

Ah, sure makes sense.
Thanks for explaining,

Ciao - Cor


-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 103363] MAILMERGE: Outgoing mailserver (set in Tools > Options > Writer > Mail merge Email) not found

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103363

--- Comment #13 from Björn Michaelsen  ---
(In reply to thackert from comment #7)
> I can confirm your bug with
> LO: Version: 5.3.0.0.alpha1
> but not with
> LO: Version: 5.2.3.1

Looking at the file in question: git log
libreoffice-5-2-branch-point..remotes/fdo/master
scripting/source/pyprov/mailmerge.py

There seem to be no changes on our code. Possibly this regression is caused by
an update of bundled Python?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Bjoern Michaelsen
Hi,
On Thu, Dec 15, 2016 at 12:19:54PM +0100, Cor Nouws wrote:
> Michael Meeks wrote on 08-12-16 17:56:
> > + Mail merge regressions: http://tdf.io/mmregressions
> > + 4 open; 4 open last meeting (2 OSX, 1 Linux, 1 generic but hard 
> > repro)
> >   => drop from the QA section from now - always four.
> 
> Counting 5 at the moment.

Yes, but the rationale was the extraordinary number of MM regressions we had
during the cleanup of the old (really horrible) code. That major cleanup is
finishe for the most part now, activity in the area is back to normal, so no
justification anymore to highlight MM regressions over regressions elsewhere.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Bjoern Michaelsen
Hi,
On Thu, Dec 15, 2016 at 12:19:54PM +0100, Cor Nouws wrote:
> Michael Meeks wrote on 08-12-16 17:56:
> > + Mail merge regressions: http://tdf.io/mmregressions
> > + 4 open; 4 open last meeting (2 OSX, 1 Linux, 1 generic but hard 
> > repro)
> >   => drop from the QA section from now - always four.
> 
> Counting 5 at the moment.

Yes, but the rationale was the extraordinary number of MM regressions we had
during the cleanup of the old (really horrible) code. That major cleanup is
finishe for the most part now, activity in the area is back to normal, so no
justification anymore to highlight MM regressions over regressions elsewhere.

Best,

Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Cor Nouws
Michael Meeks wrote on 08-12-16 17:56:
> + Mail merge regressions: http://tdf.io/mmregressions
> + 4 open; 4 open last meeting (2 OSX, 1 Linux, 1 generic but hard 
> repro)
>   => drop from the QA section from now - always four.

Counting 5 at the moment.


-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 104145] on opening file formatting changes occur in random cells in random sheets

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104145

pherwo...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from pherwo...@gmail.com ---
You can close this report now. I've checked many times and there is definitely
no further formatting problems with beta 2.
alpha and beta 1 were all making the formatting changes.
Some how it appears to be fixed.
I've marked it "Resolved".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104222] FILESAVE: PPTX: performance regression at save time in Linux, write error in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104222

Rohan Kumar  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rohankanojia...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104222] FILESAVE: PPTX: performance regression at save time in Linux, write error in Windows

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104222

--- Comment #6 from Rohan Kumar  ---
Hi Raal,

I'm starting to work on this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 75856] FILEOPEN: Incorrect page height import on a .doc file

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=75856

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #16 from Justin L  ---
A "long" variable in 64bit Linux is 64bit, but under 64bit Windows it compiles
as 32bit.  Proposed fix https://gerrit.libreoffice.org/32051

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 70433] EDITING: Embedded Firebird - List doesn't work in queries, works in external Firebird

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70433

--- Comment #14 from Tamas Bunth  ---
As I see, the result is an empty Clob right now, because the getClob() function
in Resultset.cxx returns always a nullpointer. (not implemented).

Before Julien's patch, the type received from getColumnTypeFromFBType (in
Util.cxx) was the type of a blob, instead of clob. That's why the result was
"OBJECT" before, instead of and empty cell.
This experiment makes me assume, that the UI could display a non-empty clob (or
text-Blob in case of Firebird, whatever) properly.

So we have two opportunities:
- Implement the XClob interface just as XBlob is implemented, and use it in
getClob():
https://www.openoffice.org/api/docs/common/ref/com/sun/star/sdbc/XClob.html

- Use list with an extra CAST():

SELECT CAST (LIST( "Vorname", ' and ' )  as VARCHAR(32000) ) FROM
"Name_VarcharID"

That should work. At least it works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 104701] URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

--- Comment #1 from JPJ  ---
The same issue exists with 5.3.0.0.bet1 on a separate physical machine with the
same OS.

Version: 5.3.0.0.beta1
Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; VCL: kde4; Layout
Engine: new;
Locale: en-US (en_US.UTF-8); Calc: group

OS: KDE Neon User Edition 5.8 = KDE Plasma 5.8.4 on Ubuntu 16.04.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] libvisio.git: Branch 'zf.com' - build/win32 src/conv src/lib

2016-12-15 Thread Ji???­ Posp?­??il
 build/win32/libvisio.vcxproj  |   26 +
 src/conv/svg/vsd2xhtml.cpp|  276 +--
 src/lib/VSDContentCollector.cpp   |  494 
 src/lib/VSDContentCollector.h |7 
 src/lib/VSDMetaData.cpp   |2 
 src/lib/VSDOutputElementList.cpp  |  282 ---
 src/lib/VSDOutputElementList.h|  317 +
 src/lib/preprocess/SvgDC.cpp  |1 
 src/lib/preprocess/SvgDC.h|   32 +
 src/lib/preprocess/SvgFont.cpp|   61 ++
 src/lib/preprocess/SvgFont.h  |   38 +
 src/lib/preprocess/SvgParagraph.cpp   |  152 ++
 src/lib/preprocess/SvgParagraph.h |   69 ++
 src/lib/preprocess/SvgSpan.cpp|   74 +++
 src/lib/preprocess/SvgSpan.h  |   51 ++
 src/lib/preprocess/SvgTextObject.cpp  |  473 +++
 src/lib/preprocess/SvgTextObject.h|  109 
 src/lib/preprocess/SvgUtils.cpp   |   61 ++
 src/lib/preprocess/SvgUtils.h |   28 +
 src/lib/preprocess/VsdElementListPreprocessor.cpp |  521 ++
 src/lib/preprocess/VsdElementListPreprocessor.h   |   71 ++
 src/lib/preprocess/windows/WindowsSvgDC.cpp   |  188 +++
 src/lib/preprocess/windows/WindowsSvgDC.h |   61 ++
 src/lib/preprocess/windows/WindowsSvgFont.cpp |   54 ++
 src/lib/preprocess/windows/WindowsSvgFont.h   |   30 +
 25 files changed, 2964 insertions(+), 514 deletions(-)

New commits:
commit 80720108347665f6051795f3fbb7d8d0f262513a
Author: Ji???­ Posp?­??il 
Date:   Wed Dec 14 14:46:02 2016 +0100

SVG generation fixes

- text wrapping
- text decoration
- line connectors
- path filling
- unordered item lists

diff --git a/build/win32/libvisio.vcxproj b/build/win32/libvisio.vcxproj
index c8cad9f..4a96a9f 100644
--- a/build/win32/libvisio.vcxproj
+++ b/build/win32/libvisio.vcxproj
@@ -111,6 +111,16 @@
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
 
+
+
+
+
+
+
+
+
+
+
 
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
@@ -165,6 +175,8 @@
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
 
+
+
 
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
@@ -249,6 +261,16 @@
 
 
 
+
+
+
+
+
+
+
+
+
+
 
 
 
@@ -261,6 +283,8 @@
 
 
 
+
+
 
 
 
@@ -290,4 +314,4 @@
   
   
   
-
+
\ No newline at end of file
diff --git a/src/conv/svg/vsd2xhtml.cpp b/src/conv/svg/vsd2xhtml.cpp
index cc91c85..dc1b7cc 100644
--- a/src/conv/svg/vsd2xhtml.cpp
+++ b/src/conv/svg/vsd2xhtml.cpp
@@ -1,4 +1,3 @@
-/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /*
  * This file is part of the libvisio project.
  *
@@ -11,108 +10,275 @@
 #include "config.h"
 #endif
 
+#include 
 #include 
 #include 
-#include 
-#include 
+#include 
+#include 
+
+#include 
 #include 
 #include 
 #include 
 #include 
 
+using namespace librevenge;
+using namespace libvisio;
+using namespace std;
+
+
 #ifndef VERSION
 #define VERSION "UNKNOWN VERSION"
 #endif
 
+
 namespace
 {
 
+string UnquoteString(const string )
+{
+  unsigned int strSize = str.size();
+  unsigned int pos1 = strSize > 0 && str[0] == '"' ? 1 : 0;
+  unsigned int pos2 = strSize > 1 && str[strSize - 1] == '"' ? strSize - 1 : 
strSize;
+  return str.substr(pos1, pos2 - pos1);
+}
+
+bool ExpandFileNameList(const string , vector )
+{
+  if (listFileName.find(".lst") == listFileName.size() - 4)
+  {
+ifstream in(listFileName);
+
+if (in.is_open())
+{
+  while (in && !in.eof())
+  {
+string line;
+getline(in, line);
+
+if (in)
+{
+  fileNames.push_back(UnquoteString(line));
+}
+  }
+
+  return true;
+}
+  }
+
+  return false;
+}
+
+void WriteXhtmlHeader(ostream )
+{
+  out << "" << endl;
+  out << "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\;>" << endl;
+  out << "http://www.w3.org/1999/xhtml\; 
xmlns:svg=\"http://www.w3.org/2000/svg\; 
xmlns:xlink=\"http://www.w3.org/1999/xlink\;>" << endl;
+  out << "" << endl;
+  out << "http://www.w3.org/2000/svg\;?>" << 
endl;
+}
+
+void WriteXhtmlFooter(ostream )
+{
+  out << "" << endl;
+  out << "" << endl;
+}
+
+void WriteSvg(const char *svgStr, ostream )
+{
+  out << ""  << endl;
+  out << svgStr << endl;
+}
+
 int printUsage()
 {
-  printf("`vsd2xhtml' converts Microsoft Visio documents to SVG.\n");
-  printf("\n");
-  printf("Usage: vsd2xhtml [OPTION] INPUT\n");
-  printf("\n");
-  printf("Options:\n");
-  printf("\t--helpshow this help message\n");
-  

[Libreoffice-bugs] [Bug 104701] New: URW fonts missing in LibreOffice 5.3.0.0.beta1 and 5.3.0.0.beta2

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=104701

Bug ID: 104701
   Summary: URW fonts missing in LibreOffice 5.3.0.0.beta1 and
5.3.0.0.beta2
   Product: LibreOffice
   Version: 5.3.0.0.beta1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ja...@joines.org

URW fonts are missing when selecting a font in Writer or Calc via the
Formatting toolbar or the Format -> Character... menu and dialog.

Version: 5.3.0.0.beta2
Build ID: a7e30712ad6d8bc9286007b37aa581983e0caba3
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: x11; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group

OS: KDE Neon User Edition 5.8 = KDE Plasma 5.8.4 on Ubuntu 16.04.1


URW fonts are available on the same system when running earlier versions of
LibreOffice including:

Version: 5.2.4.1
Build ID: 9b50003582f07ac674d6451e411e9b77cccd2b22
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] libvisio.git: Branch 'zf.com' - build/win32

2016-12-15 Thread Jiří Pospíšil
 build/win32/libvisio.vcxproj  |   68 +++---
 build/win32/vsd2raw.vcxproj   |   40 
 build/win32/vsd2xhtml.vcxproj |   66 
 3 files changed, 97 insertions(+), 77 deletions(-)

New commits:
commit ef4ae42ce738fc2450bfc5dc205a65003c04455b
Author: Jiří Pospíšil 
Date:   Thu Dec 15 12:58:46 2016 +0100

Project build fixes

diff --git a/build/win32/libvisio.vcxproj b/build/win32/libvisio.vcxproj
index 0413aff..c8cad9f 100644
--- a/build/win32/libvisio.vcxproj
+++ b/build/win32/libvisio.vcxproj
@@ -35,24 +35,24 @@
   
   
 <_ProjectFileVersion>10.0.40219.1
-.\Debug\
-.\Debug\
-.\Release\
-.\Release\
+.\Debug\lib\
+.\Debug\lib\
+.\Release\lib\
+.\Release\lib\
   
   
 
   Disabled
-  
..\..\inc;$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(BOOST_INCLUDE_DIR);$(LIBXML_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)
+  
..\..\inc;..\..\src\lib;..\..\src\lib\preprocess;..\..\src\lib\preprocess\windows;$(BOOST_DIR);$(ICONV_DIR)\include;$(ICU_DIR)\include;$(LIBRVNG_DIR)\inc;$(LIBXML_DIR)\include;$(ZLIB_DIR)\include
   
_DEBUG;DEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)
   EnableFastChecks
   MultiThreadedDebugDLL
   false
   true
-  
.\Debug/libvisio.pch
-  .\Debug/
-  .\Debug/
-  .\Debug/
+  
$(TargetDir)/libvisio.pch
+  $(TargetDir)
+  $(TargetDir)
+  $(TargetDir)
   Level3
   true
   EditAndContinue
@@ -62,8 +62,10 @@
   0x0409
 
 
-  Debug\lib\libvisio-0.0.lib
+  $(TargetPath)
   true
+  
$(ICU_DIR)\lib\icuuc.lib;$(LIBXML_DIR)\lib\libxml2.lib;%(AdditionalDependencies)
+  true
 
 
   true
@@ -74,17 +76,17 @@
 
   MaxSpeed
   OnlyExplicitInline
-  
..\..\inc;$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);$(BOOST_INCLUDE_DIR);$(LIBXML_INCLUDE_DIR);$(ZLIB_INCLUDE_DIR);$(ICU_INCLUDE_DIR);%(AdditionalIncludeDirectories)
+  
..\..\inc;..\..\src\lib;..\..\src\lib\preprocess;..\..\src\lib\preprocess\windows;$(BOOST_DIR);$(ICONV_DIR)\include;$(ICU_DIR)\include;$(LIBRVNG_DIR)\inc;$(LIBXML_DIR)\include;$(ZLIB_DIR)\include
   
NDEBUG;WIN32;_LIB;_CRT_SECURE_NO_WARNINGS;_SCL_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)
   true
   MultiThreadedDLL
   true
   false
   true
-  
.\Release/libvisio.pch
-  .\Release/
-  .\Release/
-  .\Release/
+  
$(TargetDir)/libvisio.pch
+  $(TargetDir)
+  $(TargetDir)
+  $(TargetDir)
   Level3
   true
 
@@ -93,8 +95,9 @@
   0x0409
 
 
-  Release\lib\libvisio-0.0.lib
+  $(TargetPath)
   true
+  
$(ICU_DIR)\lib\icuuc.lib;$(LIBXML_DIR)\lib\libxml2.lib;%(AdditionalDependencies)
 
 
   true
@@ -198,12 +201,6 @@
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
 
-
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-
 
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
@@ -216,12 +213,7 @@
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
 
-
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-
+
 
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
@@ -252,17 +244,10 @@
   %(AdditionalIncludeDirectories)
   %(PreprocessorDefinitions)
 
-
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-  %(AdditionalIncludeDirectories)
-  %(PreprocessorDefinitions)
-
   
   
 
 
-
 
 
 
@@ -284,14 +269,23 @@
 
 
 
-
 
+
 
 
 
 
 
-
+  
+  
+
+  {740f0d46-431f-11e3-b75a-d067e5eab6e3}
+  true
+  false
+  false
+  false
+  false
+
   
   
   
diff --git a/build/win32/vsd2raw.vcxproj b/build/win32/vsd2raw.vcxproj
index 4669ef0..26cb047 100644
--- a/build/win32/vsd2raw.vcxproj
+++ b/build/win32/vsd2raw.vcxproj
@@ -52,30 +52,30 @@
 
 
   Disabled
-  
..\..\inc;$(LIBWPD_INCLUDE_DIR);$(LIBWPG_INCLUDE_DIR);%(AdditionalIncludeDirectories)
+  
..\..\inc;$(LIBRVNG_DIR)\inc;%(AdditionalIncludeDirectories)
   
_DEBUG;DEBUG;WIN32;_CONSOLE;%(PreprocessorDefinitions)
   EnableFastChecks
   MultiThreadedDebugDLL
   false
-  
.\Debug/vsd2raw.pch
-  .\Debug/
-  .\Debug/
-  .\Debug/
+  
$(TargetDir)/vsd2raw.pch
+  $(TargetDir)
+  $(TargetDir)
+  $(TargetDir)
   Level3
   true
-  EditAndContinue
+  ProgramDatabase
 
 
   
_DEBUG;%(PreprocessorDefinitions)
   0x0409
 
 
-  

[Libreoffice-commits] libvisio.git: Changes to 'zf.com'

2016-12-15 Thread David Tardon
New branch 'zf.com' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.1' - bin/pack-debug

2016-12-15 Thread László Németh
 bin/pack-debug |  321 +
 1 file changed, 321 insertions(+)

New commits:
commit 0c19de75b26a4b0c9d6607496fc8867d1a0117a1
Author: László Németh 
Date:   Thu Dec 15 17:33:17 2016 +0100

script for generating debug packages

Change-Id: I89be53e5fea3b9928d960604d050db47383baae3

diff --git a/bin/pack-debug b/bin/pack-debug
new file mode 100755
index 000..f5a31ac
--- /dev/null
+++ b/bin/pack-debug
@@ -0,0 +1,321 @@
+#!/bin/sh
+# create debuginfo and debugsource packages from LO rpm & deb files
+# (generated by using --enable-symbols)
+#
+# Usage:
+#
+# cd /opt/lo_installation_path
+# dbg_pkg
+# # or
+# # PACKAGENAME=collaboraoffice5.1 dbg_pkg # if building in a different path
+
+# build path
+export BUILD_PATH=$PWD
+
+# set package base name, eg. collaboraoffice5.1
+# based on the actual directory, eg. /opt/collaboraoffice5.1,
+# or checking the PACKAGENAME environmental variable
+
+if [ -z "$PACKAGENAME" ]
+then
+DEBUGSRC_PACKAGENAME=$(basename $BUILD_PATH)
+else
+DEBUGSRC_PACKAGENAME=$PACKAGENAME
+fi
+echo PACKAGE NAME: $DEBUGSRC_PACKAGENAME
+
+# set install dirname and product version
+eval $(grep ^INSTALLDIRNAME config.log)
+eval $(grep ^PRODUCTVERSION config.log)
+
+#
+# Function for re-build RPM files
+#
+function repack_rpm {
+
+# set environment based on config.log
+# for find-requires-x11.sh used by rpm __find_requires
+eval $(grep ^PLATFORMID config.log)
+export PLATFORMID
+eval $(grep ^build_cpu config.log)
+export build_cpu
+
+#
+# create source package
+# (use PACKAGENAME environmental variable
+# to find "$PACKAGENAME".spec.log)
+#
+
+DEBUGSRC="$(find workdir -name ${DEBUGSRC_PACKAGENAME}.spec.log)"
+
+echo Base spec file: $DEBUGSRC
+
+if [ -z "$DEBUGSRC" ]
+then
+ echo "Missing ${DEBUGSRC_PACKAGENAME}.spec.log in workdir/, specify spec.log 
file name in PACKAGENAME"
+ echo "For example: PACKAGENAME=collaboraoffice5.1 dbg_pkg"
+ exit 1
+fi
+
+# create spec file, based on the spec file of the brand package
+
+cat $DEBUGSRC | awk '
+   /^Name:/ { print "Summary: Debug source for package "$2; print 
$0"-debugsource";next }
+   /^Group:/ { print $1" Development/Debug";next }
+   /^Brand module/ { print gensub("Brand module", "Source files", "");next 
}
+   /^%attr/ || /^Summary:/ { next }
+   {print}
+   END { 
+   print "%defattr(-,root,root)" 
+   }
+ ' > ${DEBUGSRC}-debugsource
+ buildroot=$(cat $DEBUGSRC-debugsource | awk '/^BuildRoot/{print$2}')
+ topdir=$(dirname $(dirname $buildroot))
+ mkdir -p $buildroot $topdir/RPMS/BUILD $topdir/RPMS/RPMS
+ rm -rf $buildroot
+
+ # create source file list
+
+ find $BUILD_PATH -name '*[.][hc]xx' -o -name '*[.][hc]' | grep -Ev 
'/(workdir|qa|DEBS)/' | grep -E '/(source|inc)/' |
+
+ # list all directories for complete rpm remove
+
+ awk -v home=$BUILD_PATH '
+   {
+   split($0, a, home "/")
+   n=split(a[2], b, "/")
+   c=home
+   for(i=1;i> ${DEBUGSRC}-debugsource
+
+ echo Spec file of debug source package: ${DEBUGSRC}-debugsource
+
+ echo Start rpmbuild for debug source package...
+
+ ln -s / $buildroot
+
+ # debug build source package
+
+ rpmbuild -bb --define "_unpackaged_files_terminate_build  0" 
${DEBUGSRC}-debugsource --target $build_cpu --buildroot=$buildroot
+
+#
+# create rpm debug info packages
+# by processing logged spec files
+#
+
+for i in 
$BUILD_PATH/workdir/installation/CollaboraOffice/rpm/logging/*/*.spec.log
+do
+
+ # repackage only rpm packages with non-stripped so files
+
+ if grep -q '^%attr.*[.]\(so\|bin\)\([.].*\)\?\"' $i
+ then
+   echo  $i 
+   pack=$(cat $i | awk '/^Name/{print$2}')
+   buildroot=$(cat $i | awk '/^BuildRoot/{print$2}')
+   topdir=$(dirname $(dirname $buildroot))
+   rpmdir=$(echo $topdir | sed 's/_inprogress$//')
+   echo $rpmdir
+
+   # create empty buildroot directory
+
+   rm -rf $buildroot
+   mkdir -p $buildroot $topdir/RPMS/BUILD $topdir/RPMS/RPMS
+   cd $buildroot
+
+   echo REBUILD: $rpmdir/RPMS/${pack}-[0-9]*.rpm
+
+   # extract rpm package
+
+   rpm2cpio $rpmdir/RPMS/${pack}-[0-9]*.rpm | cpio -idmv
+
+   # create stripped libraries and linked debug info files
+
+   for j in $(cat $i | awk '/^%attr.*[.](so|bin)([.].*)?"$/{print$2}')
+   do
+   so=$(echo $j | tr -d '"')
+   cd ./$(dirname $so)
+   so=$(basename $so)
+   objcopy --only-keep-debug $so $so.dbg
+   objcopy 

[Libreoffice-qa] minutes of ESC call ...

2016-12-15 Thread Michael Meeks
* Present:
  + Andras, Caolan, Heiko, Stephan, Kendy, JanI, Thorsten, Sophie,
Xisco, Cloph, Michael S, Bubli, Michael M, Bjoern (lurking), Miklos

* Completed Action Items:
+ create & publish wiki page for ranking (JanI)
https://wiki.documentfoundation.org/Development/Budget2017
[ people need to expand their items – to be actionable / tenderable ]
+ improve QA Stats in the ESC minutes (Xisco)
+ provide information for cloph on what the large Help change is (Bubli)
+ need a diff of the kind of string change, so Cloph can write a script.
[ outcome in IRC – will be postponed; packaging of help-packs also
  changes → should not be part of 5.3 (Cloph, Olivier, Bubli) ]
 
* Pending Action Items:
+ poke at MSDN licenses (Michael)
+ move gitdm-config to gerrit (Norbert)
+ investigate https://beta.opendocumentformat.org/testsets/all/en (Xisco)
+ come up an IDE integration / easy setup compromise proposal (JanI)
[ work in progress, ETA next week, summarizing mailing-list (janI) ]
+ file a 'make clean ; make screenshot' bug report ? (Norbert)
   [ expected to be fixed (Thorsten) ]
+ poke Florian to encourage posting of Macs (Cloph)
 
* Release Engineering update (Christian)
+ 5.3.0 B2 on mirrors & available for download
+ 5.3.0 RC1 – next week – and string freeze too ...
+ pootle upgrade is happening now.
+ tag will be done on Wed. evening to match pootle.
+ Late features:
+ separating images and icons for help modules (Olivier, Bubli)
→ abandoned for 5.3.
+ Android & iOS Remote (Cloph)
+ master is green now.
+ will prepare a new build based on the branch-off tag
+ online (Michael)
+ branched for -5-3 ... will create source tarballs.
+ 5.2.4 RC2 (janI)
+ sources uploaded, but build problem with 32bit Linux
+ with a BadAlloc / MESA / EGL bits for master ?
+ trying to build RC1 on the same machine to check.
+ if so - suggest postponing 1 week to avoid RC3
 
* Documentation (Olivier)
  + Next: Will test screenshots make enabled by bubli
   ( https://wiki.documentfoundation.org/Documentation/Screenshots )
  + will screenshots have operating-system information ?
   + under discussion
+ continuing to test screenshots.
  + on Mac screenshots are reversed (Bubli)
   + but has no mac.
   + happy to test things on a Mac (JanI)
   + rendering to VirtualDevice (Thorsten)
 
* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
   256(256) (topicUI) bugs open, 496(496) (needsUXEval) needs to be 
evaluated by the UXteam
   + Updates:
   BZ changes   1 week   1 month   3 months   12 months  
added  1(-1)15(-1)57(-4) 490(1)  
commented 87(73)   254(67)   877(-49)   2707(-86)
  removed  0(0)  0(-1)18(-6)  30(0)  
 resolved  8(2) 22(5)113(-2) 135(2)  
   + top 10 contributors:
 Heiko Tietze made 41 changes in 1 month, and 518 changes in 1 year
 *UNKNOWN* made 18 changes in 1 month, and 18 changes in 1 year
 Samuel Mehrbrodt made 17 changes in 1 month, and 54 changes in 1 year
 V Stuart Foote made 15 changes in 1 month, and 198 changes in 1 year
 *UNKNOWN* made 14 changes in 1 month, and 25 changes in 1 year
 Yousuf Philips made 14 changes in 1 month, and 409 changes in 1 year
 *UNKNOWN* made 13 changes in 1 month, and 99 changes in 1 year
 Rene Engelhard made 10 changes in 1 month, and 10 changes in 1 year
 Khaled Hosny made 9 changes in 1 month, and 10 changes in 1 year
 Tor Lillqvist made 8 changes in 1 month, and 9 changes in 1 year

+ Tooltips (tdf#104413)
+ have ‘simple’ tooltips for all controls by default?
  Additionally to extended tt with help installed
+ pro: support for beginners, good ux, postive a11y side effect
+ con: huge overhead to enter good tips and to translate
 + terrible startup performance problems from XPATH nonsense (?)
 + Markus had a prototype to extract & mirror these tooltips (Kendy)
 + with plan to keep XHP as help files; consider it again.
+ should we add a tooltip on an individual item ?
 + good usability to have tooltips consistently everywhere
 + student hasn’t finished the help on this topic.
+ happy to add simple tooltips to .ui files (Sophie)
 + adding five word tooltips to everywhere is ok with translators
 + there are 111k labels on widgets in .ui files (Michael)
$ git ls-files | grep '\.ui' | xargs cat | grep label | grep -v 'gtk-' | nl
 + 500k new words, 100 langs -> 50Mb of extra install
AI: + come up with a clear proposal with input from l10n (Sophie, Heiko)
  

minutes of ESC call ...

2016-12-15 Thread Michael Meeks
* Present:
  + Andras, Caolan, Heiko, Stephan, Kendy, JanI, Thorsten, Sophie,
Xisco, Cloph, Michael S, Bubli, Michael M, Bjoern (lurking), Miklos

* Completed Action Items:
+ create & publish wiki page for ranking (JanI)
https://wiki.documentfoundation.org/Development/Budget2017
[ people need to expand their items – to be actionable / tenderable ]
+ improve QA Stats in the ESC minutes (Xisco)
+ provide information for cloph on what the large Help change is (Bubli)
+ need a diff of the kind of string change, so Cloph can write a script.
[ outcome in IRC – will be postponed; packaging of help-packs also
  changes → should not be part of 5.3 (Cloph, Olivier, Bubli) ]
 
* Pending Action Items:
+ poke at MSDN licenses (Michael)
+ move gitdm-config to gerrit (Norbert)
+ investigate https://beta.opendocumentformat.org/testsets/all/en (Xisco)
+ come up an IDE integration / easy setup compromise proposal (JanI)
[ work in progress, ETA next week, summarizing mailing-list (janI) ]
+ file a 'make clean ; make screenshot' bug report ? (Norbert)
   [ expected to be fixed (Thorsten) ]
+ poke Florian to encourage posting of Macs (Cloph)
 
* Release Engineering update (Christian)
+ 5.3.0 B2 on mirrors & available for download
+ 5.3.0 RC1 – next week – and string freeze too ...
+ pootle upgrade is happening now.
+ tag will be done on Wed. evening to match pootle.
+ Late features:
+ separating images and icons for help modules (Olivier, Bubli)
→ abandoned for 5.3.
+ Android & iOS Remote (Cloph)
+ master is green now.
+ will prepare a new build based on the branch-off tag
+ online (Michael)
+ branched for -5-3 ... will create source tarballs.
+ 5.2.4 RC2 (janI)
+ sources uploaded, but build problem with 32bit Linux
+ with a BadAlloc / MESA / EGL bits for master ?
+ trying to build RC1 on the same machine to check.
+ if so - suggest postponing 1 week to avoid RC3
 
* Documentation (Olivier)
  + Next: Will test screenshots make enabled by bubli
   ( https://wiki.documentfoundation.org/Documentation/Screenshots )
  + will screenshots have operating-system information ?
   + under discussion
+ continuing to test screenshots.
  + on Mac screenshots are reversed (Bubli)
   + but has no mac.
   + happy to test things on a Mac (JanI)
   + rendering to VirtualDevice (Thorsten)
 
* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
   256(256) (topicUI) bugs open, 496(496) (needsUXEval) needs to be 
evaluated by the UXteam
   + Updates:
   BZ changes   1 week   1 month   3 months   12 months  
added  1(-1)15(-1)57(-4) 490(1)  
commented 87(73)   254(67)   877(-49)   2707(-86)
  removed  0(0)  0(-1)18(-6)  30(0)  
 resolved  8(2) 22(5)113(-2) 135(2)  
   + top 10 contributors:
 Heiko Tietze made 41 changes in 1 month, and 518 changes in 1 year
 *UNKNOWN* made 18 changes in 1 month, and 18 changes in 1 year
 Samuel Mehrbrodt made 17 changes in 1 month, and 54 changes in 1 year
 V Stuart Foote made 15 changes in 1 month, and 198 changes in 1 year
 *UNKNOWN* made 14 changes in 1 month, and 25 changes in 1 year
 Yousuf Philips made 14 changes in 1 month, and 409 changes in 1 year
 *UNKNOWN* made 13 changes in 1 month, and 99 changes in 1 year
 Rene Engelhard made 10 changes in 1 month, and 10 changes in 1 year
 Khaled Hosny made 9 changes in 1 month, and 10 changes in 1 year
 Tor Lillqvist made 8 changes in 1 month, and 9 changes in 1 year

+ Tooltips (tdf#104413)
+ have ‘simple’ tooltips for all controls by default?
  Additionally to extended tt with help installed
+ pro: support for beginners, good ux, postive a11y side effect
+ con: huge overhead to enter good tips and to translate
 + terrible startup performance problems from XPATH nonsense (?)
 + Markus had a prototype to extract & mirror these tooltips (Kendy)
 + with plan to keep XHP as help files; consider it again.
+ should we add a tooltip on an individual item ?
 + good usability to have tooltips consistently everywhere
 + student hasn’t finished the help on this topic.
+ happy to add simple tooltips to .ui files (Sophie)
 + adding five word tooltips to everywhere is ok with translators
 + there are 111k labels on widgets in .ui files (Michael)
$ git ls-files | grep '\.ui' | xargs cat | grep label | grep -v 'gtk-' | nl
 + 500k new words, 100 langs -> 50Mb of extra install
AI: + come up with a clear proposal with input from l10n (Sophie, Heiko)
  

[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

2016-12-15 Thread jan Iversen
 esc-reporting/esc-analyze.py |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 72ce9b4a4daf10953fe0b4808b97c40b11236f67
Author: jan Iversen 
Date:   Thu Dec 15 17:15:57 2016 +0100

update to esc-analyze based on request from Xisco.

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 04e6742..7d600a9 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -74,6 +74,8 @@ def util_load_csv(fileName, split):
   fp.readline()
   for line in fp:
 line = line[:-1]
+if len(line) == 0:
+  continue
 x = line.split(split)
 if split == ';' and len(x) != 3:
   raise Exception('misformed entry ' + line + ' in filename ' + 
fileName)
@@ -118,14 +120,12 @@ def util_build_period_stat(xDate, email, base, 
peopleTarget=None, dataTarget=Non
 if dataTarget:
   statList['data'][base][xType]['total'] += 1
 
-nextDate = {'1year': cfg['3monthDate'], '3month': cfg['1monthDate'], 
'1month': cfg['1weekDate'], '1week': cfg['nowDate']}
-for i, oDate in nextDate.items():
-  if xDate >= cfg[i + 'Date'] and xDate < oDate:
+for i in '1year', '3month', '1month', '1week':
+  if xDate >= cfg[i + 'Date']:
 if peopleTarget:
   statList['people'][email][base][i][peopleTarget] += 1
 if dataTarget:
   statList['data'][base][xType][i][dataTarget] += 1
-break
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


  1   2   3   >