date:20161231

Jaiden Fairoze license statement

2016-12-31 Thread Jaiden Fairoze

   All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105023] New: Formatting

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105023

Bug ID: 105023
   Summary: Formatting
   Product: LibreOffice
   Version: 5.2.3.2 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kbri...@outlook.com

Description:
When I try to change the background color in a cell to "no fill," I first have
to change the color to a different color. (I suspect this loads the command
into the memory, and then the "no fill" command "undoes" it. If you're trying
to clear an existing color, there's no color command to be undone.) 

Steps to Reproduce:
1. Select a cell with a colored background. 
2. Format/Cells/Background
3. Click "no fill"
4. Crickets...

Actual Results:  
Like I said, crickets...

Expected Results:
Color background should clear. It just stays the same. 


Reproducible: Always

User Profile Reset: No

Additional Info:
No. It's late. I'm tired. I doubt this has anything to do with the profile.
Thx. 


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; MATBJS; rv:11.0)
like Gecko

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: test/httpwstest.cpp

2016-12-31 Thread Ashod Nakashian

 test/httpwstest.cpp |  107 +---
 1 file changed, 69 insertions(+), 38 deletions(-)

New commits:
commit 8a20e3b26509d33d7d18c3bf5696c56b94d883cf
Author: Ashod Nakashian 
Date:   Sun Dec 25 16:21:53 2016 -0500

wsd: load torture test made more stable

Change-Id: Icc1890480d7d5539dd3b855dfb775909d78a2e82
Reviewed-on: https://gerrit.libreoffice.org/32565
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 4cfed98..066a5b7 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -34,7 +34,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 #include 
@@ -156,7 +155,6 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 int loadTorture(const std::string& testname,
  const std::string& docName,
  const size_t thread_count,
- const size_t loads_per_thread,
  const size_t max_jitter_ms);
 
 void getPartHashCodes(const std::string response,
@@ -393,10 +391,9 @@ void HTTPWSTest::testLoad()
 }
 
 int HTTPWSTest::loadTorture(const std::string& testname,
- const std::string& docName,
- const size_t thread_count,
- const size_t loads_per_thread,
- const size_t max_jitter_ms)
+const std::string& docName,
+const size_t thread_count,
+const size_t max_jitter_ms)
 {
 // Load same document from many threads together.
 std::string documentPath, documentURL;
@@ -404,43 +401,81 @@ int HTTPWSTest::loadTorture(const std::string& testname,
 
 std::atomic sum_view_ids;
 sum_view_ids = 0;
+std::atomic num_of_views(0);
+std::atomic num_to_load(thread_count);
 
 std::vector threads;
 for (size_t i = 0; i < thread_count; ++i)
 {
 threads.emplace_back([&]
 {
+std::ostringstream oss;
+oss << std::hex << std::this_thread::get_id();
+const std::string id = oss.str();
+
+std::cerr << testname << ": #" << id << ", views: " << 
num_of_views << ", to load: " << num_to_load << std::endl;
 try
 {
-for (size_t j = 0; j < loads_per_thread; ++j)
+// Load a document and wait for the status.
+Poco::Net::HTTPRequest 
request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
+Poco::Net::HTTPResponse response;
+auto socket = connectLOKit(_uri, request, response, testname);
+sendTextFrame(socket, "load url=" + documentURL, testname);
+
+const auto status = assertResponseString(socket, "status:", 
testname);
+int viewid = -1;
+LOOLProtocol::getTokenIntegerFromMessage(status, "viewid", 
viewid);
+sum_view_ids += viewid;
+++num_of_views;
+--num_to_load;
+
+std::cerr << testname << ": #" << id << ", loaded views: " << 
num_of_views << ", to load: " << num_to_load << std::endl;
+
+while (true)
 {
-// Load a document and wait for the status.
-Poco::Net::HTTPRequest 
request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
-auto socket = connectLOKit(_uri, request, _response, 
testname);
-sendTextFrame(socket, "load url=" + documentURL, testname);
+if (num_to_load == 0)
+{
+// Unload at once, nothing more left to do.
+std::cerr << testname << ": #" << id << ", no more to 
load, unloading." << std::endl;
+break;
+}
 
-const auto status = assertResponseString(socket, 
"status:", testname);
-int viewid = -1;
-LOOLProtocol::getTokenIntegerFromMessage(status, "viewid", 
viewid);
-sum_view_ids += viewid;
+const auto ms = (max_jitter_ms > 0
+? 
std::chrono::milliseconds(Util::rng::getNext() % max_jitter_ms)
+: std::chrono::milliseconds(0));
+std::this_thread::sleep_for(ms);
 
-if (max_jitter_ms > 0)
+// Unload only when we aren't the last/only.
+if (--num_of_views > 0)
 {
-const auto ms = 
std::chrono::milliseconds(Util::rng::getNext() % max_jitter_ms);
-std::this_thread::sleep_for(ms);
+std::cerr << testname << ": #" << id << ", views: " << 
num_of_views << "

[Libreoffice-commits] online.git: test/httpwstest.cpp

2016-12-31 Thread Ashod Nakashian

 test/httpwstest.cpp |   73 +++-
 1 file changed, 61 insertions(+), 12 deletions(-)

New commits:
commit e9f4e67efdad801c581a798bd59b11b8041310c0
Author: Ashod Nakashian 
Date:   Fri Dec 23 16:18:31 2016 -0500

wsd: more testLoadTorture flavors

Dedicated tests for each type of document.

Change-Id: I399e32a64ad0fe25f0cf4795cf428da922eea2f5
Reviewed-on: https://gerrit.libreoffice.org/32564
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 9730f9f..4cfed98 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -64,6 +64,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testCloseAfterClose);
 CPPUNIT_TEST(testConnectNoLoad); // This fails most of the times but 
occasionally succeeds
 CPPUNIT_TEST(testLoad);
+CPPUNIT_TEST(testLoadTortureODT);
+CPPUNIT_TEST(testLoadTortureODS);
+CPPUNIT_TEST(testLoadTortureODP);
 CPPUNIT_TEST(testLoadTorture);
 CPPUNIT_TEST(testBadLoad);
 CPPUNIT_TEST(testReload);
@@ -108,6 +111,9 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testCloseAfterClose();
 void testConnectNoLoad();
 void testLoad();
+void testLoadTortureODT();
+void testLoadTortureODS();
+void testLoadTortureODP();
 void testLoadTorture();
 void testBadLoad();
 void testReload();
@@ -147,7 +153,8 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 
 void loadDoc(const std::string& documentURL, const std::string& testname);
 
-void loadTorture(const std::string& docName,
+int loadTorture(const std::string& testname,
+ const std::string& docName,
  const size_t thread_count,
  const size_t loads_per_thread,
  const size_t max_jitter_ms);
@@ -385,20 +392,16 @@ void HTTPWSTest::testLoad()
 loadDoc(documentURL, "load ");
 }
 
-void HTTPWSTest::loadTorture(const std::string& docName,
+int HTTPWSTest::loadTorture(const std::string& testname,
+ const std::string& docName,
  const size_t thread_count,
  const size_t loads_per_thread,
  const size_t max_jitter_ms)
 {
-const auto testname = "loadTorture ";
-
 // Load same document from many threads together.
 std::string documentPath, documentURL;
 getDocumentPathAndURL(docName, documentPath, documentURL);
 
-const auto number_of_loads = thread_count * loads_per_thread;
-const int exp_sum_view_ids = number_of_loads * (number_of_loads - 1) / 2; 
// 0-based view-ids.
-
 std::atomic sum_view_ids;
 sum_view_ids = 0;
 
@@ -440,23 +443,69 @@ void HTTPWSTest::loadTorture(const std::string& docName,
 thread.join();
 }
 
-CPPUNIT_ASSERT_EQUAL(exp_sum_view_ids, sum_view_ids.load());
+return sum_view_ids;
 }
 
-void HTTPWSTest::testLoadTorture()
+void HTTPWSTest::testLoadTortureODT()
 {
 const auto thread_count = 3;
-const auto loads_per_thread = 3;
+const auto loads_per_thread = 2;
+const auto max_jitter_ms = 100;
+
+const auto testname = "loadTortureODT ";
+const auto sum_view_ids = loadTorture(testname, "empty.odt", thread_count, 
loads_per_thread, max_jitter_ms);
+
+// This only works when the first view-ID is 0 and increments monotonously.
+const auto number_of_loads = thread_count * loads_per_thread;
+const int exp_sum_view_ids = number_of_loads * (number_of_loads - 1) / 2; 
// 0-based view-ids.
+CPPUNIT_ASSERT_EQUAL(exp_sum_view_ids, sum_view_ids);
+}
+
+void HTTPWSTest::testLoadTortureODS()
+{
+const auto thread_count = 2;
+const auto loads_per_thread = 2;
+const auto max_jitter_ms = 75;
+
+const auto testname = "loadTortureODS ";
+const auto sum_view_ids = loadTorture(testname, "empty.ods", thread_count, 
loads_per_thread, max_jitter_ms);
+
+// This only works when the first view-ID is 0 and increments monotonously.
+const auto number_of_loads = thread_count * loads_per_thread;
+const int exp_sum_view_ids = number_of_loads * (number_of_loads - 1) / 2; 
// 0-based view-ids.
+CPPUNIT_ASSERT_EQUAL(exp_sum_view_ids, sum_view_ids);
+}
+
+void HTTPWSTest::testLoadTortureODP()
+{
+const auto thread_count = 2;
+const auto loads_per_thread = 2;
+const auto max_jitter_ms = 75;
+
+const auto testname = "loadTortureODP ";
+const auto sum_view_ids = loadTorture(testname, "empty.odp", thread_count, 
loads_per_thread, max_jitter_ms);
+
+// For ODP the view-id is always odd, and we expect not to skip any ids.
+const auto number_of_loads = thread_count * loads_per_thread;
+const int exp_sum_view_ids = number_of_loads * number_of_loads; // Odd 
view-ids only.
+CPPUNIT_ASSERT_EQUAL(exp_sum_view_ids,

[Libreoffice-commits] online.git: kit/Kit.cpp

2016-12-31 Thread Ashod Nakashian

 kit/Kit.cpp |   19 +++
 1 file changed, 11 insertions(+), 8 deletions(-)

New commits:
commit a5440a4ab2837b7a912a3014f3b0159935e6fcb8
Author: Ashod Nakashian 
Date:   Fri Dec 23 14:24:01 2016 -0500

wsd: kit logging improvements

Change-Id: I12e0b82a45193f7a3633175667e842627be52ba5
Reviewed-on: https://gerrit.libreoffice.org/32563
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 9082997..edf03c9 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -887,9 +887,9 @@ private:
 {
 std::unique_lock lock(_mutex);
 
-LOG_INF("Loading url [" << uri <<
-"] for session [" << sessionId << "] which has " << 
_sessions.size() <<
-" views loaded. Another load in progress: " << _isLoading);
+LOG_INF("Loading url [" << uri << "] for session [" << sessionId <<
+"] which has " << (_sessions.size() - 1) <<
+" sessions. Another load in progress: " << _isLoading);
 
 while (_isLoading)
 {
@@ -954,7 +954,7 @@ private:
 
 LOG_INF("Document [" << _url << "] session [" <<
 sessionId << "] unloaded view [" << viewId << "]. Have " <<
-viewCount << " view" << (viewCount != 1 ? "s" : ""));
+viewCount << " view" << (viewCount != 1 ? "s." : "."));
 
 lockLokDoc.unlock();
 
@@ -1196,7 +1196,8 @@ private:
 Object::Ptr renderOptsObj = new Object();
 
 // Fill the object with renderoptions, if any
-if (!_renderOpts.empty()) {
+if (!_renderOpts.empty())
+{
 Parser parser;
 Poco::Dynamic::Var var = parser.parse(_renderOpts);
 renderOptsObj = var.extract();
@@ -1230,7 +1231,7 @@ private:
 const int viewCount = _loKitDocument->getViewsCount();
 LOG_INF("Document url [" << _url << "] for session [" <<
 sessionId << "] loaded view [" << viewId << "]. Have " <<
-viewCount << " view" << (viewCount != 1 ? "s" : ""));
+viewCount << " view" << (viewCount != 1 ? "s." : "."));
 
 return _loKitDocument;
 }
@@ -1251,8 +1252,6 @@ private:
 
 auto data = payload.data() + index;
 auto size = payload.size() - index;
-const auto abbrMessage = getAbbreviatedMessage(data, size);
-LOG_TRC("Forwarding payload to " << prefix << ' ' << abbrMessage);
 
 std::string name;
 std::string sessionId;
@@ -1278,6 +1277,7 @@ private:
 }
 }
 
+const auto abbrMessage = getAbbreviatedMessage(data, size);
 LOG_WRN("Child session [" << sessionId << "] not found to forward 
message: " << abbrMessage);
 }
 else
@@ -1299,8 +1299,11 @@ private:
 while (!_stop && !TerminationFlag)
 {
 const TileQueue::Payload input = _tileQueue->get();
+LOG_TRC("Kit Recv " << 
LOOLProtocol::getAbbreviatedMessage(input));
+
 if (_stop || TerminationFlag)
 {
+LOG_INF("Kit: Stop flagged.");
 break;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/LOOLWSD.cpp |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 62371e5f41c7599d1a02233aa2041c6d80bb6769
Author: Ashod Nakashian 
Date:   Thu Dec 22 19:33:46 2016 -0500

wsd: log failure in else and not unconditionally

Change-Id: I24f1ac57f350aa67cc14682d695e1e4a07453c8d
Reviewed-on: https://gerrit.libreoffice.org/32562
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 5575907..faa5a7f 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -875,9 +875,12 @@ private:
 }
 }
 }
+else
+{
+LOG_DBG("No DocumentBroker with docKey [" << docKey << "] found. 
New Child and Document.");
+}
 
 Util::assertIsLocked(docBrokersLock);
-LOG_DBG("No DocumentBroker with docKey [" << docKey << "] found. New 
Child and Document.");
 
 if (TerminationFlag)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Log.hpp

2016-12-31 Thread Ashod Nakashian

 common/Log.hpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 92bbe0b774778c27a6525700026f424c148a0b26
Author: Ashod Nakashian 
Date:   Thu Dec 22 19:32:46 2016 -0500

wsd: log bools as text

Change-Id: I0d520671704881bf1aaeb090ce452be74e43fd0c
Reviewed-on: https://gerrit.libreoffice.org/32561
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Log.hpp b/common/Log.hpp
index f4ba714..4613877 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -170,7 +170,7 @@ namespace Log
 }
 }
 
-#define LOG_BODY(LVL, X) std::ostringstream oss_; oss_ << Log::prefix(LVL) << 
X << "| " << __FILE__ << ':' << __LINE__
+#define LOG_BODY(LVL, X) std::ostringstream oss_; oss_ << Log::prefix(LVL) << 
std::boolalpha << X << "| " << __FILE__ << ':' << __LINE__
 #define LOG_TRC(X) if (Log::traceEnabled()) { LOG_BODY("TRC", X); 
Log::logger().trace(oss_.str()); }
 #define LOG_DBG(X) if (Log::debugEnabled()) { LOG_BODY("DBG", X); 
Log::logger().debug(oss_.str()); }
 #define LOG_INF(X) if (Log::infoEnabled()) { LOG_BODY("INF", X); 
Log::logger().information(oss_.str()); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/Storage.cpp wsd/Storage.hpp

2016-12-31 Thread Ashod Nakashian

 wsd/Storage.cpp |   54 ++
 wsd/Storage.hpp |   17 +
 2 files changed, 43 insertions(+), 28 deletions(-)

New commits:
commit aef5af8114b335dd3da840258c009729c73f2511
Author: Ashod Nakashian 
Date:   Thu Dec 22 16:41:05 2016 -0500

wsd: Storage logs updated

Change-Id: Ib3083e833fdc2891ab0c89231bf2ec3e81285803
Reviewed-on: https://gerrit.libreoffice.org/32560
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index 9c0f0ef..d7a7119 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -108,14 +108,14 @@ bool isLocalhost(const std::string& targetHost)
 }
 catch (const Poco::Exception& exc)
 {
-Log::warn("Poco::Net::DNS::resolveOne(\"" + targetHost + "\") failed: 
" + exc.displayText());
+LOG_WRN("Poco::Net::DNS::resolveOne(\"" << targetHost << "\") failed: 
" << exc.displayText());
 try
 {
 targetAddress = Poco::Net::IPAddress(targetHost).toString();
 }
 catch (const Poco::Exception& exc1)
 {
-Log::warn("Poco::Net::IPAddress(\"" + targetHost + "\") failed: " 
+ exc1.displayText());
+LOG_WRN("Poco::Net::IPAddress(\"" << targetHost << "\") failed: " 
<< exc1.displayText());
 }
 }
 
@@ -192,7 +192,7 @@ std::atomic LocalStorage::LastLocalStorageId;
 std::unique_ptr 
LocalStorage::getLocalFileInfo(const Poco::URI& uriPublic)
 {
 const auto path = Poco::Path(uriPublic.getPath());
-Log::debug("Getting info for local uri [" + uriPublic.toString() + "], 
path [" + path.toString() + "].");
+LOG_DBG("Getting info for local uri [" << uriPublic.toString() << "], path 
[" << path.toString() << "].");
 
 const auto& filename = path.getFileName();
 const auto file = Poco::File(path);
@@ -213,7 +213,7 @@ std::string LocalStorage::loadStorageFileToLocal()
 const auto filename = Poco::Path(_uri.getPath()).getFileName();
 _jailedFilePath = Poco::Path(rootPath, filename).toString();
 LOG_INF("Public URI [" << _uri.getPath() <<
-"] jailed to [" + _jailedFilePath + "].");
+"] jailed to [" << _jailedFilePath << "].");
 
 // Despite the talk about URIs it seems that _uri is actually just a 
pathname here
 const auto publicFilePath = _uri.getPath();
@@ -227,7 +227,7 @@ std::string LocalStorage::loadStorageFileToLocal()
 if (!Poco::File(_jailedFilePath).exists() && link(publicFilePath.c_str(), 
_jailedFilePath.c_str()) == -1)
 {
 // Failed
-Log::warn("link(\"" + publicFilePath + "\", \"" + _jailedFilePath + 
"\") failed. Will copy.");
+LOG_WRN("link(\"" << publicFilePath << "\", \"" << _jailedFilePath << 
"\") failed. Will copy.");
 }
 
 try
@@ -242,7 +242,7 @@ std::string LocalStorage::loadStorageFileToLocal()
 }
 catch (const Poco::Exception& exc)
 {
-Log::error("copyTo(\"" + publicFilePath + "\", \"" + _jailedFilePath + 
"\") failed: " + exc.displayText());
+LOG_ERR("copyTo(\"" << publicFilePath << "\", \"" << _jailedFilePath 
<< "\") failed: " << exc.displayText());
 throw;
 }
 
@@ -357,7 +357,7 @@ void getWOPIValue(const Poco::JSON::Object::Ptr , 
const std::string& key,
 
 std::unique_ptr WopiStorage::getWOPIFileInfo(const 
Poco::URI& uriPublic)
 {
-LOG_DBG("Getting info for wopi uri [" + uriPublic.toString() + "].");
+LOG_DBG("Getting info for wopi uri [" << uriPublic.toString() << "].");
 
 std::string resMsg;
 const auto startTime = std::chrono::steady_clock::now();
@@ -374,13 +374,17 @@ std::unique_ptr 
WopiStorage::getWOPIFileInfo(const Po
 std::istream& rs = psession->receiveResponse(response);
 callDuration = (std::chrono::steady_clock::now() - startTime);
 
-auto logger = Log::trace();
-logger << "WOPI::CheckFileInfo header for URI [" << 
uriPublic.toString() << "]:\n";
-for (auto& pair : response)
+if (Log::traceEnabled())
 {
-logger << '\t' + pair.first + ": " + pair.second << " / ";
+auto logger = Log::trace();
+logger << "WOPI::CheckFileInfo header for URI [" << 
uriPublic.toString() << "]:\n";
+for (const auto& pair : response)
+{
+logger << '\t' << pair.first << ": " << pair.second << " / ";
+}
+
+logger << Log::end;
 }
-logger << Log::end;
 
 Poco::StreamCopier::copyToString(rs, resMsg);
 }
@@ -408,7 +412,7 @@ std::unique_ptr 
WopiStorage::getWOPIFileInfo(const Po
 bool disableCopy = false;
 std::string lastModifiedTime;
 
-LOG_DBG("WOPI::CheckFileInfo returned: " + resMsg + ". Call duration: " + 
std::to_string(callDuration.count()) + "s");
+LOG_DBG("WOPI::CheckFileInfo returned: " << resMsg << ". Call duration: " 
<<

[Libreoffice-commits] online.git: kit/Kit.cpp

2016-12-31 Thread Ashod Nakashian

 kit/Kit.cpp |   18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

New commits:
commit de4a7a139ebf067fb400fe878ce5f0bda18e1d31
Author: Ashod Nakashian 
Date:   Wed Dec 21 21:23:04 2016 -0500

wsd: Kit comments and cosmetics

Change-Id: Ie6abd479cfce77b41597dd793687e3f862d3dbba
Reviewed-on: https://gerrit.libreoffice.org/32559
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index b727762..9082997 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -965,15 +965,16 @@ private:
 std::map getViewInfo() override
 {
 std::unique_lock lock(_mutex);
-std::map viewInfo;
 
-for (auto& pair : _sessions)
+std::map viewInfo;
+for (const auto& pair : _sessions)
 {
 const auto& session = pair.second;
 const auto viewId = session->getViewId();
 viewInfo[viewId] = UserInfo({session->getViewUserId(), 
session->getViewUserName()});
 }
 
+// Copy the old sessions to provide disconnected user info.
 viewInfo.insert(_oldSessionIds.begin(), _oldSessionIds.end());
 
 return viewInfo;
@@ -995,6 +996,7 @@ private:
 // Store the list of viewid, username mapping in a map
 std::map viewInfoMap = getViewInfo();
 std::map viewColorsMap = getViewColors();
+
 std::unique_lock lock(_mutex);
 
 // Double check if list of viewids from core and our list matches,
@@ -1028,8 +1030,10 @@ private:
 std::ostringstream ossViewInfo;
 viewInfoArray->stringify(ossViewInfo);
 
-// Broadcast updated viewinfo to all _active_ connections
-for (auto& pair : _sessions)
+// Broadcast updated viewinfo to all _active_ connections.
+// These are internal sockets, so unless WSD is chocked,
+// no need to send on separate thread.
+for (const auto& pair : _sessions)
 {
 const auto session = pair.second;
 if (!session->isCloseFrame() && session->isActive())
@@ -1207,7 +1211,6 @@ private:
 std::string decodedUserName;
 URI::decode(userName, decodedUserName);
 authorObj->set("value", decodedUserName);
-
 renderOptsObj->set(".uno:Author", authorObj);
 }
 
@@ -1218,7 +1221,8 @@ private:
 // registerCallback(), as the previous creates a new view in Impress.
 _loKitDocument->initializeForRendering(ossRenderOpts.str().c_str());
 
-session->setViewId((viewId = _loKitDocument->getView()));
+viewId = _loKitDocument->getView();
+session->setViewId(viewId);
 _viewIdToCallbackDescr.emplace(viewId,
std::unique_ptr(new 
CallbackDescriptor({ this, viewId })));
 _loKitDocument->registerCallback(ViewCallback, 
_viewIdToCallbackDescr[viewId].get());
@@ -1419,6 +1423,8 @@ private:
 std::atomic_size_t _isLoading;
 std::map _viewIdToCallbackDescr;
 std::map _sessions;
+
+/// For showing disconnected user info in the doc repair dialog.
 std::map _oldSessionIds;
 Poco::Thread _callbackThread;
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/LOOLWSD.cpp |   28 ++--
 1 file changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 759564368d9dbd24bf1ad65ebfb52f080aa81e38
Author: Ashod Nakashian 
Date:   Fri Dec 23 22:43:38 2016 -0500

wsd: reorganize DocBrokers lookup

Avoid unnecessary code under lock
or when DocBrokers is updated,
which requires removal on exception.

Change-Id: Id01aed42cd66616b910b7e16a8a1ed6c1d1e74b9
Reviewed-on: https://gerrit.libreoffice.org/32558
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 8a031df..5575907 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -787,27 +787,36 @@ private:
 LOG_INF("Sanitized url [" << uri << "] to [" << uriPublic.toString() <<
 "] and mapped to docKey [" << docKey << "].");
 
-std::shared_ptr docBroker;
+// Check if readonly session is required
+bool isReadOnly = false;
+for (const auto& param : uriPublic.getQueryParameters())
+{
+LOG_DBG("Query param: " << param.first << ", value: " << 
param.second);
+if (param.first == "permission" && param.second == "readonly")
+{
+isReadOnly = true;
+}
+}
 
 std::unique_lock docBrokersLock(DocBrokersMutex);
 
+cleanupDocBrokers();
+
 if (TerminationFlag)
 {
 LOG_ERR("Termination flag set. No loading new session [" << id << 
"]");
 return;
 }
 
-cleanupDocBrokers();
+std::shared_ptr docBroker;
 
 // Lookup this document.
 auto it = DocBrokers.find(docKey);
-if (it != DocBrokers.end())
+if (it != DocBrokers.end() && it->second)
 {
 // Get the DocumentBroker from the Cache.
 LOG_DBG("Found DocumentBroker with docKey [" << docKey << "].");
 docBroker = it->second;
-assert(docBroker);
-
 if (docBroker->isMarkedToDestroy())
 {
 // Let the waiting happen in parallel to new requests.
@@ -916,15 +925,6 @@ private:
 
 docBrokersLock.unlock();
 
-// Check if readonly session is required
-bool isReadOnly = false;
-for (const auto& param : uriPublic.getQueryParameters())
-{
-LOG_DBG("Query param: " << param.first << ", value: " << 
param.second);
-if (param.first == "permission")
-isReadOnly = param.second == "readonly";
-}
-
 // In case of WOPI and if this session is not set as readonly, it 
might be set so
 // later after making a call to WOPI host which tells us the 
permission on files
 // (UserCanWrite param)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/LOOLWSD.cpp |   29 -
 1 file changed, 16 insertions(+), 13 deletions(-)

New commits:
commit e4a04029249e52fa5d6f4cd81acfde39254453b7
Author: Ashod Nakashian 
Date:   Fri Dec 23 22:26:17 2016 -0500

wsd: improved logging of DocBrokers and NewChildren activity

And improved some comments.

Change-Id: I00605e7471e4f6354d3ff62e1e3873f7e5a7986d
Reviewed-on: https://gerrit.libreoffice.org/32557
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index dc22e7f..8a031df 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -404,7 +404,7 @@ static size_t addNewChild(const 
std::shared_ptr& child)
 NewChildren.emplace_back(child);
 const auto count = NewChildren.size();
 LOG_INF("Have " << count << " spare " <<
-(count == 1 ? "child" : "children") << " after adding.");
+(count == 1 ? "child" : "children") << " after adding [" << 
child->getPid() << "].");
 lock.unlock();
 
 NewChildrenCV.notify_one();
@@ -449,7 +449,7 @@ static std::shared_ptr getNewChild()
 auto child = NewChildren.back();
 NewChildren.pop_back();
 LOG_DBG("getNewChild: Have " << available << " spare " <<
-(available == 1 ? "child" : "children") << " after 
poping.");
+(available == 1 ? "child" : "children") << " after poping 
[" << child->getPid() << "].");
 
 // Validate before returning.
 if (child && child->isAlive())
@@ -579,7 +579,7 @@ private:
 // FIXME: What if the same document is already open? Need 
a fake dockey here?
 LOG_DBG("New DocumentBroker for docKey [" << docKey << 
"].");
 DocBrokers.emplace(docKey, docBroker);
-LOG_TRC("Have " << DocBrokers.size() << " DocBrokers after 
inserting.");
+LOG_TRC("Have " << DocBrokers.size() << " DocBrokers after 
inserting [" << docKey << "].");
 
 // Load the document.
 std::shared_ptr ws;
@@ -636,7 +636,7 @@ private:
 LOG_DBG("Removing DocumentBroker for docKey [" << 
docKey << "].");
 DocBrokers.erase(docKey);
 docBroker->terminateChild(docLock);
-LOG_TRC("Have " << DocBrokers.size() << " DocBrokers 
after removing.");
+LOG_TRC("Have " << DocBrokers.size() << " DocBrokers 
after removing [" << docKey << "].");
 }
 else
 {
@@ -775,15 +775,18 @@ private:
 /// Handle GET requests.
 static void handleGetRequest(const std::string& uri, 
std::shared_ptr& ws, const std::string& id)
 {
-LOG_INF("Starting GET request handler for session [" << id << "].");
+LOG_INF("Starting GET request handler for session [" << id << "] on 
url [" << uri << "].");
 
-// indicator to the client that document broker is searching
+// Indicate to the client that document broker is searching.
 std::string status("statusindicator: find");
 LOG_TRC("Sending to Client [" << status << "].");
 ws->sendFrame(status.data(), status.size());
 
 const auto uriPublic = DocumentBroker::sanitizeURI(uri);
 const auto docKey = DocumentBroker::getDocKey(uriPublic);
+LOG_INF("Sanitized url [" << uri << "] to [" << uriPublic.toString() <<
+"] and mapped to docKey [" << docKey << "].");
+
 std::shared_ptr docBroker;
 
 std::unique_lock docBrokersLock(DocBrokersMutex);
@@ -898,7 +901,7 @@ private:
 docBroker = std::make_shared(uriPublic, docKey, 
LOOLWSD::ChildRoot, child);
 child->setDocumentBroker(docBroker);
 DocBrokers.emplace(docKey, docBroker);
-LOG_TRC("Have " << DocBrokers.size() << " DocBrokers after 
inserting.");
+LOG_TRC("Have " << DocBrokers.size() << " DocBrokers after 
inserting [" << docKey << "].");
 }
 
 // Validate the broker.
@@ -931,7 +934,7 @@ private:
 // Below this, we need to cleanup internal references.
 try
 {
-// indicator to a client that is waiting to connect to lokit 
process
+// Indicate to the client that is waiting to connect to lokit 
process.
 status = "statusindicator: connect";
 LOG_TRC("Sending to Client [" << status << "].");
 ws->sendFrame(status.data(), status.size());
@@ -944,7 +947,7 @@ private:
 const std::string fs = 
FileUtil::checkDiskSpaceOnRegisteredFileSystems();
 if (!fs.empty())
 {
-LOG_WRN("File system of " << fs << " dangerously low on disk 
space");
+LOG_WRN("File system of [" << fs << "] is

[Libreoffice-commits] online.git: kit/Kit.cpp

2016-12-31 Thread Ashod Nakashian

 kit/Kit.cpp |   27 +++
 1 file changed, 15 insertions(+), 12 deletions(-)

New commits:
commit 94ed8393c59c124ab810dcad59000dcf0dea8c61
Author: Ashod Nakashian 
Date:   Wed Dec 21 21:21:11 2016 -0500

wsd: improved document/view loading logs in Kit

Change-Id: I51a86b73463dbbaa1875dde14be3745f69e097ef
Reviewed-on: https://gerrit.libreoffice.org/32555
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index c39a31b..b727762 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -887,8 +887,9 @@ private:
 {
 std::unique_lock lock(_mutex);
 
-LOG_INF("Loading session [" << sessionId << "] on url [" << uri <<
-"] is loading. " << _sessions.size() << " views loaded.");
+LOG_INF("Loading url [" << uri <<
+"] for session [" << sessionId << "] which has " << 
_sessions.size() <<
+" views loaded. Another load in progress: " << _isLoading);
 
 while (_isLoading)
 {
@@ -909,12 +910,13 @@ private:
 }
 catch (const std::exception& exc)
 {
-LOG_ERR("Exception while loading [" << uri << "] : " << 
exc.what());
+LOG_ERR("Exception while loading url [" << uri <<
+"] for session [" << sessionId << "]: " << exc.what());
 return false;
 }
 
 // Done loading, let the next one in (if any).
-assert(_loKitDocument && _loKitDocument->get() && "Uninitialized 
lok::Document instance");
+LOG_CHECK_RET(_loKitDocument && _loKitDocument->get() && 
"Uninitialized lok::Document instance", false);
 lock.lock();
 --_isLoading;
 _cvLoading.notify_one();
@@ -951,8 +953,8 @@ private:
 _loKitDocument->getViewIds(viewIds.data(), viewCount);
 
 LOG_INF("Document [" << _url << "] session [" <<
-sessionId << "] unloaded. Have " << viewCount <<
-" view" << (viewCount != 1 ? "s" : ""));
+sessionId << "] unloaded view [" << viewId << "]. Have " <<
+viewCount << " view" << (viewCount != 1 ? "s" : ""));
 
 lockLokDoc.unlock();
 
@@ -1180,9 +1182,9 @@ private:
 }
 }
 
-LOG_INF("Loading view to document from URI: [" << uri << "] for 
session [" << sessionId << "].");
+LOG_INF("Creating view to url [" << uri << "] for session [" << 
sessionId << "].");
 _loKitDocument->createView();
-LOG_TRC("View created.");
+LOG_TRC("View to url [" << uri << "] created.");
 }
 
 Util::assertIsLocked(lockLokDoc);
@@ -1222,8 +1224,9 @@ private:
 _loKitDocument->registerCallback(ViewCallback, 
_viewIdToCallbackDescr[viewId].get());
 
 const int viewCount = _loKitDocument->getViewsCount();
-LOG_INF("Document [" << _url << "] view [" << viewId << "] loaded. 
Have " <<
-viewCount << " view" << (viewCount != 1 ? "s." : "."));
+LOG_INF("Document url [" << _url << "] for session [" <<
+sessionId << "] loaded view [" << viewId << "]. Have " <<
+viewCount << " view" << (viewCount != 1 ? "s" : ""));
 
 return _loKitDocument;
 }
@@ -1341,8 +1344,8 @@ private:
 }
 else
 {
-LOG_ERR("Session thread for session " << 
session->getId() << " for view " <<
-viewId << " is not running. Dropping 
[" << LOKitHelper::kitCallbackTypeToString(type) <<
+LOG_ERR("Session-thread of session [" << 
session->getId() << "] for view [" <<
+viewId << "] is not running. Dropping 
[" << LOKitHelper::kitCallbackTypeToString(type) <<
 "] payload [" << payload << "].");
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: test/httpwstest.cpp

2016-12-31 Thread Ashod Nakashian

 test/httpwstest.cpp |   88 
 1 file changed, 88 insertions(+)

New commits:
commit 2f81b37c076d16810ca4588db6f86a84e43d6527
Author: Ashod Nakashian 
Date:   Wed Dec 21 21:22:03 2016 -0500

wsd: load torture test

Load multiple views on multiple documents
concurrently and verify that the number
of views for each case is consistent and
as expected.

Change-Id: Ie550dd42880da7bdd0aef6d642e9b000be5c3f84
Reviewed-on: https://gerrit.libreoffice.org/32556
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/test/httpwstest.cpp b/test/httpwstest.cpp
index 56493b3..9730f9f 100644
--- a/test/httpwstest.cpp
+++ b/test/httpwstest.cpp
@@ -64,6 +64,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testCloseAfterClose);
 CPPUNIT_TEST(testConnectNoLoad); // This fails most of the times but 
occasionally succeeds
 CPPUNIT_TEST(testLoad);
+CPPUNIT_TEST(testLoadTorture);
 CPPUNIT_TEST(testBadLoad);
 CPPUNIT_TEST(testReload);
 CPPUNIT_TEST(testGetTextSelection);
@@ -107,6 +108,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testCloseAfterClose();
 void testConnectNoLoad();
 void testLoad();
+void testLoadTorture();
 void testBadLoad();
 void testReload();
 void testGetTextSelection();
@@ -145,6 +147,11 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 
 void loadDoc(const std::string& documentURL, const std::string& testname);
 
+void loadTorture(const std::string& docName,
+ const size_t thread_count,
+ const size_t loads_per_thread,
+ const size_t max_jitter_ms);
+
 void getPartHashCodes(const std::string response,
   std::vector& parts);
 
@@ -378,6 +385,87 @@ void HTTPWSTest::testLoad()
 loadDoc(documentURL, "load ");
 }
 
+void HTTPWSTest::loadTorture(const std::string& docName,
+ const size_t thread_count,
+ const size_t loads_per_thread,
+ const size_t max_jitter_ms)
+{
+const auto testname = "loadTorture ";
+
+// Load same document from many threads together.
+std::string documentPath, documentURL;
+getDocumentPathAndURL(docName, documentPath, documentURL);
+
+const auto number_of_loads = thread_count * loads_per_thread;
+const int exp_sum_view_ids = number_of_loads * (number_of_loads - 1) / 2; 
// 0-based view-ids.
+
+std::atomic sum_view_ids;
+sum_view_ids = 0;
+
+std::vector threads;
+for (size_t i = 0; i < thread_count; ++i)
+{
+threads.emplace_back([&]
+{
+try
+{
+for (size_t j = 0; j < loads_per_thread; ++j)
+{
+// Load a document and wait for the status.
+Poco::Net::HTTPRequest 
request(Poco::Net::HTTPRequest::HTTP_GET, documentURL);
+auto socket = connectLOKit(_uri, request, _response, 
testname);
+sendTextFrame(socket, "load url=" + documentURL, testname);
+
+const auto status = assertResponseString(socket, 
"status:", testname);
+int viewid = -1;
+LOOLProtocol::getTokenIntegerFromMessage(status, "viewid", 
viewid);
+sum_view_ids += viewid;
+
+if (max_jitter_ms > 0)
+{
+const auto ms = 
std::chrono::milliseconds(Util::rng::getNext() % max_jitter_ms);
+std::this_thread::sleep_for(ms);
+}
+}
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+});
+}
+
+for (auto& thread : threads)
+{
+thread.join();
+}
+
+CPPUNIT_ASSERT_EQUAL(exp_sum_view_ids, sum_view_ids.load());
+}
+
+void HTTPWSTest::testLoadTorture()
+{
+const auto thread_count = 3;
+const auto loads_per_thread = 3;
+const auto max_jitter_ms = 75;
+
+std::vector docNames = { "setclientpart.ods", "hello.odt", 
"empty.ods" };
+
+std::vector threads;
+for (const auto& docName : docNames)
+{
+threads.emplace_back([&]
+{
+loadTorture(docName, thread_count, loads_per_thread, 
max_jitter_ms);
+});
+}
+
+for (auto& thread : threads)
+{
+thread.join();
+}
+}
+
 void HTTPWSTest::testBadLoad()
 {
 try
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/PrisonerSession.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/PrisonerSession.cpp |7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 9dfd2008d5ac837092ce03d4d825b729b44df3fc
Author: Ashod Nakashian 
Date:   Wed Dec 21 21:07:55 2016 -0500

wsd: send text messages as text not binary

Change-Id: I03dccb8035eb0f1d1fbf85f75f2e4f36af1ce689
Reviewed-on: https://gerrit.libreoffice.org/32554
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/PrisonerSession.cpp b/wsd/PrisonerSession.cpp
index 77971cf..c0d21a8 100644
--- a/wsd/PrisonerSession.cpp
+++ b/wsd/PrisonerSession.cpp
@@ -61,7 +61,6 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 throw Poco::ProtocolException("The session has not been assigned a 
peer.");
 }
 
-bool isBinary = true;
 if (tokens[0] == "unocommandresult:")
 {
 const std::string stringMsg(buffer, length);
@@ -108,7 +107,7 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 errorKind == "passwordrequired:to-modify" ||
 errorKind == "wrongpassword")
 {
-forwardToPeer(peer, buffer, length, isBinary);
+forwardToPeer(peer, buffer, length, false);
 LOG_WRN("Document load failed: " << errorKind);
 return false;
 }
@@ -174,7 +173,7 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 _docBroker->setLoaded();
 
 // Forward the status response to the client.
-return forwardToPeer(peer, buffer, length, isBinary);
+return forwardToPeer(peer, buffer, length, false);
 }
 else if (tokens[0] == "commandvalues:")
 {
@@ -253,7 +252,7 @@ bool PrisonerSession::_handleInput(const char *buffer, int 
length)
 // Detect json messages, since we must send those as text even though they 
are multiline.
 // If not, the UI will read the first line of a binary payload, assuming 
that's the only
 // text part and the rest is binary.
-isBinary = buffer[length - 1] != '}' && firstLine.find('{') == 
std::string::npos;
+const bool isBinary = buffer[length - 1] != '}' && firstLine.find('{') == 
std::string::npos;
 
 // Forward everything else.
 forwardToPeer(peer, buffer, length, isBinary);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/DocumentBroker.cpp |8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 1a902736724f541dc6fec0a6295020bfa5f63aad
Author: Ashod Nakashian 
Date:   Wed Dec 21 21:07:18 2016 -0500

wsd: log child-to-wsd messages once

Change-Id: I723f673998622416a8aa1f0f46928f530ceb252e
Reviewed-on: https://gerrit.libreoffice.org/32553
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 9901ff5..edfcb42 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -45,9 +45,6 @@ void ChildProcess::socketProcessor()
 IoUtil::SocketProcessor(_ws, name,
 [this](const std::vector& payload)
 {
-const auto message = LOOLProtocol::getAbbreviatedMessage(payload);
-LOG_TRC("Recv from child [" << message << "].");
-
 if (UnitWSD::get().filterChildMessage(payload))
 {
 return true;
@@ -63,7 +60,8 @@ void ChildProcess::socketProcessor()
 }
 
 LOG_WRN("Child " << this->_pid <<
-" has no DocumentBroker to handle message: [" << message 
<< "].");
+" has no DocumentBroker to handle message: [" <<
+LOOLProtocol::getAbbreviatedMessage(payload) << "].");
 return true;
 },
 []() { },
@@ -687,7 +685,7 @@ void DocumentBroker::alertAllUsers(const std::string& msg)
 bool DocumentBroker::handleInput(const std::vector& payload)
 {
 const auto msg = LOOLProtocol::getAbbreviatedMessage(payload);
-LOG_TRC("DocumentBroker got child message: [" << msg << "].");
+LOG_TRC("DocumentBroker handling child message: [" << msg << "].");
 
 LOOLWSD::dumpOutgoingTrace(getJailId(), "0", msg);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: wsd/ClientSession.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/ClientSession.cpp |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit ba90ea304c9680ade84e586fc09be7c338d82770
Author: Ashod Nakashian 
Date:   Wed Dec 21 18:27:37 2016 -0500

wsd: ClientSession logs updated

Change-Id: I4ec664ebd7eadbe3763ee18eb511662de6453ebb
Reviewed-on: https://gerrit.libreoffice.org/32552
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index f26fff3..9715f32 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -40,14 +40,14 @@ ClientSession::ClientSession(const std::string& id,
 _loadPart(-1),
 _stop(false)
 {
-Log::info("ClientSession ctor [" + getName() + "].");
+LOG_INF("ClientSession ctor [" << getName() << "].");
 
 _senderThread = std::thread([this]{ senderThread(); });
 }
 
 ClientSession::~ClientSession()
 {
-Log::info("~ClientSession dtor [" + getName() + "].");
+LOG_INF("~ClientSession dtor [" << getName() << "].");
 
 // Release the save-as queue.
 _saveAsQueue.put("");
@@ -77,14 +77,14 @@ void ClientSession::bridgePrisonerSession()
 
 bool ClientSession::_handleInput(const char *buffer, int length)
 {
-LOG_TRC(getName() + ": handling [" << getAbbreviatedMessage(buffer, 
length) << "].");
+LOG_TRC(getName() << ": handling [" << getAbbreviatedMessage(buffer, 
length) << "].");
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 
 auto docBroker = getDocumentBroker();
 if (!docBroker)
 {
-Log::error("No DocBroker found. Terminating session " + getName());
+LOG_ERR("No DocBroker found. Terminating session " << getName());
 return false;
 }
 
@@ -183,7 +183,7 @@ bool ClientSession::_handleInput(const char *buffer, int 
length)
 // is turned on by WOPI, let it close all sessions
 if (_isDocumentOwner && _wopiFileInfo && 
_wopiFileInfo->_enableOwnerTermination)
 {
-LOG_DBG("Session [" + getId() + "] requested owner termination");
+LOG_DBG("Session [" << getId() << "] requested owner termination");
 docBroker->closeDocument("ownertermination");
 }
 
@@ -247,7 +247,7 @@ bool ClientSession::loadDocument(const char* /*buffer*/, 
int /*length*/, StringT
 return false;
 }
 
-Log::info("Requesting document load from child.");
+LOG_INF("Requesting document load from child.");
 try
 {
 std::string timestamp;
@@ -363,7 +363,7 @@ bool ClientSession::sendTile(const char * /*buffer*/, int 
/*length*/, StringToke
 }
 catch (const std::exception& exc)
 {
-Log::error(std::string("Failed to process tile command: ") + 
exc.what() + ".");
+LOG_ERR("Failed to process tile command: " << exc.what());
 return sendTextFrame("error: cmd=tile kind=invalid");
 }
 
@@ -380,7 +380,7 @@ bool ClientSession::sendCombinedTiles(const char* 
/*buffer*/, int /*length*/, St
 }
 catch (const std::exception& exc)
 {
-Log::error(std::string("Failed to process tilecombine command: ") + 
exc.what() + ".");
+LOG_ERR("Failed to process tilecombine command: " << exc.what());
 return sendTextFrame("error: cmd=tile kind=invalid");
 }
 
@@ -458,7 +458,7 @@ void ClientSession::setReadOnly()
 
 void ClientSession::senderThread()
 {
-LOG_DBG(getName() + " SenderThread started");
+LOG_DBG(getName() << " SenderThread started");
 
 while (!stopping())
 {
@@ -485,7 +485,7 @@ void ClientSession::senderThread()
 }
 }
 
-LOG_DBG(getName() + " SenderThread finished");
+LOG_DBG(getName() << " SenderThread finished");
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Session.cpp kit/ChildSession.cpp wsd/ClientSession.cpp

2016-12-31 Thread Ashod Nakashian

 common/Session.cpp|2 --
 kit/ChildSession.cpp  |1 +
 wsd/ClientSession.cpp |2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 3a5be2926bafb0f433fd9059c2b75a1bd623ffc0
Author: Ashod Nakashian 
Date:   Wed Dec 21 18:21:48 2016 -0500

wsd: log WS incoming messages only once

Change-Id: Iee31bc649ae2d194b6418367f0e9ab8561099b17
Reviewed-on: https://gerrit.libreoffice.org/32551
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Session.cpp b/common/Session.cpp
index afebb3b..c409a57 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -228,8 +228,6 @@ bool Session::handleInput(const char *buffer, int length)
 length = replace->size();
 }
 
-LOG_TRC(getName() << ": Recv: " << getAbbreviatedMessage(buffer, 
length));
-
 return _handleInput(buffer, length);
 }
 catch (const Exception& exc)
diff --git a/kit/ChildSession.cpp b/kit/ChildSession.cpp
index cd1f404..90d6367 100644
--- a/kit/ChildSession.cpp
+++ b/kit/ChildSession.cpp
@@ -74,6 +74,7 @@ void ChildSession::disconnect()
 
 bool ChildSession::_handleInput(const char *buffer, int length)
 {
+LOG_TRC(getName() + ": handling [" << getAbbreviatedMessage(buffer, 
length) << "].");
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index faa0ba4..f26fff3 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -77,9 +77,9 @@ void ClientSession::bridgePrisonerSession()
 
 bool ClientSession::_handleInput(const char *buffer, int length)
 {
+LOG_TRC(getName() + ": handling [" << getAbbreviatedMessage(buffer, 
length) << "].");
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
-Log::trace(getName() + ": handling [" + firstLine + "].");
 
 auto docBroker = getDocumentBroker();
 if (!docBroker)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/Log.hpp common/Session.cpp

2016-12-31 Thread Ashod Nakashian

 common/Log.hpp |1 +
 common/Session.cpp |2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 9e677e268f7e4456da5d568e6a5a75fabb887ca7
Author: Ashod Nakashian 
Date:   Wed Dec 21 18:15:27 2016 -0500

wsd: new LOG_CHECK_RET to log failure and return

This is to replace assertion for non-fatal cases.

Change-Id: I6f8aedea52fb861309d0bc8f8f9cd43395da0805
Reviewed-on: https://gerrit.libreoffice.org/32550
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/Log.hpp b/common/Log.hpp
index ee7dc55..f4ba714 100644
--- a/common/Log.hpp
+++ b/common/Log.hpp
@@ -181,6 +181,7 @@ namespace Log
 #define LOG_SFL(X) if (Log::errorEnabled()) { LOG_BODY("FTL", X << " (errno: " 
<< std::strerror(errno) << ")"); Log::logger().fatal(oss_.str()); }
 
 #define LOG_CHECK(X) if (!(X)) { LOG_ERR("Check failed. Expected (" #X ")."); }
+#define LOG_CHECK_RET(X, RET) if (!(X)) { LOG_ERR("Check failed. Expected (" 
#X ")."); return RET; }
 
 #endif
 
diff --git a/common/Session.cpp b/common/Session.cpp
index 0e51de5..afebb3b 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -217,7 +217,7 @@ void Session::shutdown(Poco::UInt16 statusCode, const 
std::string& statusMessage
 
 bool Session::handleInput(const char *buffer, int length)
 {
-assert(buffer != nullptr);
+LOG_CHECK_RET(buffer != nullptr, false);
 
 try
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104813] FILEOPEN: DOC: performance regression at import time

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104813

Terrence Enger  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: wsd/LOOLWSD.cpp

2016-12-31 Thread Ashod Nakashian

 wsd/LOOLWSD.cpp |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit 8481e9c21d1f0b8435b96c35fa95aaec2100803b
Author: Ashod Nakashian 
Date:   Wed Dec 21 18:11:38 2016 -0500

wsd: improved logging of child process management

Change-Id: Iaa1f333e3fe427219f244f913834a46a80377032
Reviewed-on: https://gerrit.libreoffice.org/32549
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 607372f..dc22e7f 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -329,7 +329,7 @@ static bool cleanupChildren()
 {
 if (!NewChildren[i]->isAlive())
 {
-LOG_WRN("Removing unused dead child [" << NewChildren[i]->getPid() 
<< "].");
+LOG_WRN("Removing dead spare child [" << NewChildren[i]->getPid() 
<< "].");
 NewChildren.erase(NewChildren.begin() + i);
 removed = true;
 }
@@ -382,12 +382,16 @@ static void prespawnChildren()
 OutstandingForks = 0;
 }
 
+const auto available = NewChildren.size();
 int balance = LOOLWSD::NumPreSpawnedChildren;
-balance -= NewChildren.size();
+balance -= available;
 balance -= OutstandingForks;
 
-if (rebalance || durationMs >= CHILD_TIMEOUT_MS)
+if (balance > 0 && (rebalance || durationMs >= CHILD_TIMEOUT_MS))
 {
+LOG_DBG("prespawnChildren: Have " << available << " spare " <<
+(available == 1 ? "child" : "children") <<
+", forking " << balance << " more.");
 forkChildren(balance);
 }
 }
@@ -399,9 +403,10 @@ static size_t addNewChild(const 
std::shared_ptr& child)
 --OutstandingForks;
 NewChildren.emplace_back(child);
 const auto count = NewChildren.size();
+LOG_INF("Have " << count << " spare " <<
+(count == 1 ? "child" : "children") << " after adding.");
 lock.unlock();
 
-LOG_INF("Have " << count << " " << (count == 1 ? "child." : "children."));
 NewChildrenCV.notify_one();
 return count;
 }
@@ -430,14 +435,21 @@ static std::shared_ptr getNewChild()
 balance = std::max(balance, 0);
 }
 
-LOG_DBG("getNewChild: Have " << available << " children, forking " << 
balance);
-forkChildren(balance);
+if (balance > 0)
+{
+LOG_DBG("getNewChild: Have " << available << " spare " <<
+(available == 1 ? "child" : "children") <<
+", forking " << balance << " more.");
+forkChildren(balance);
+}
 
 const auto timeout = chrono::milliseconds(CHILD_TIMEOUT_MS);
 if (NewChildrenCV.wait_for(lock, timeout, []() { return 
!NewChildren.empty(); }))
 {
 auto child = NewChildren.back();
 NewChildren.pop_back();
+LOG_DBG("getNewChild: Have " << available << " spare " <<
+(available == 1 ? "child" : "children") << " after 
poping.");
 
 // Validate before returning.
 if (child && child->isAlive())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: common/SigUtil.cpp kit/ForKit.cpp tools/Connect.cpp tools/KitClient.cpp tools/Stress.cpp tools/Tool.cpp wsd/ClientSession.cpp wsd/DocumentBroker.hpp wsd/FileServer.cp

2016-12-31 Thread Ashod Nakashian

 common/SigUtil.cpp  |   13 -
 kit/ForKit.cpp  |1 -
 tools/Connect.cpp   |8 
 tools/KitClient.cpp |1 -
 tools/Stress.cpp|   13 -
 tools/Tool.cpp  |   10 --
 wsd/ClientSession.cpp   |   13 +++--
 wsd/DocumentBroker.hpp  |7 ---
 wsd/FileServer.cpp  |2 ++
 wsd/LOOLWSD.cpp |1 +
 wsd/LOOLWSD.hpp |6 +-
 wsd/PrisonerSession.cpp |4 +---
 12 files changed, 12 insertions(+), 67 deletions(-)

New commits:
commit ba9ffb47753cc1323fc9ebce2c4d403b4fdd9800
Author: Ashod Nakashian 
Date:   Wed Dec 21 15:37:22 2016 -0500

wsd: include cleanup

Change-Id: Id481cfbab6be12a095918bdc7318fb3584345307
Reviewed-on: https://gerrit.libreoffice.org/32548
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/common/SigUtil.cpp b/common/SigUtil.cpp
index 476fe09..bf7292c 100644
--- a/common/SigUtil.cpp
+++ b/common/SigUtil.cpp
@@ -29,23 +29,10 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
 #include "Common.hpp"
 #include "Log.hpp"
 #include "Util.hpp"
diff --git a/kit/ForKit.cpp b/kit/ForKit.cpp
index 7b04e09..115a2df 100644
--- a/kit/ForKit.cpp
+++ b/kit/ForKit.cpp
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
diff --git a/tools/Connect.cpp b/tools/Connect.cpp
index ab848bc..1131d33 100644
--- a/tools/Connect.cpp
+++ b/tools/Connect.cpp
@@ -24,21 +24,13 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
 
 #include "Common.hpp"
 #include "Protocol.hpp"
diff --git a/tools/KitClient.cpp b/tools/KitClient.cpp
index a587a28..9264a54 100644
--- a/tools/KitClient.cpp
+++ b/tools/KitClient.cpp
@@ -20,7 +20,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/tools/Stress.cpp b/tools/Stress.cpp
index 15c2a21..fac3fd0 100644
--- a/tools/Stress.cpp
+++ b/tools/Stress.cpp
@@ -15,30 +15,17 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
-#include 
 #include 
 #include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
 
-#include 
-#include 
-
 #include "TraceFile.hpp"
 #include "test/helpers.hpp"
 
diff --git a/tools/Tool.cpp b/tools/Tool.cpp
index dc54975..aeda094 100644
--- a/tools/Tool.cpp
+++ b/tools/Tool.cpp
@@ -14,10 +14,8 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -27,12 +25,7 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -43,9 +36,6 @@
 #include "Protocol.hpp"
 #include "Util.hpp"
 
-#include 
-#include 
-
 /// Simple command-line tool for file format conversion.
 class Tool: public Poco::Util::Application
 {
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 16348db..faa0ba4 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -12,22 +12,15 @@
 
 #include 
 
-#include 
-#include 
-#include 
 #include 
-#include 
 
 #include "Common.hpp"
-#include "IoUtil.hpp"
-#include "Protocol.hpp"
-#include "Session.hpp"
+#include "DocumentBroker.hpp"
 #include "LOOLWSD.hpp"
 #include "Log.hpp"
 #include "PrisonerSession.hpp"
-#include "Rectangle.hpp"
-#include "Storage.hpp"
-#include "TileCache.hpp"
+#include "Protocol.hpp"
+#include "Session.hpp"
 #include "Util.hpp"
 
 using namespace LOOLProtocol;
diff --git a/wsd/DocumentBroker.hpp b/wsd/DocumentBroker.hpp
index f2e7604..9d227f1 100644
--- a/wsd/DocumentBroker.hpp
+++ b/wsd/DocumentBroker.hpp
@@ -25,15 +25,16 @@
 
 #include "IoUtil.hpp"
 #include "Log.hpp"
-#include 
-#include "Storage.hpp"
-#include "TileCache.hpp"
+#include "LOOLWebSocket.hpp"
+#include "TileDesc.hpp"
 #include "Util.hpp"
 
 #include "common/SigUtil.hpp"
 
 // Forwards.
 class DocumentBroker;
+class StorageBase;
+class TileCache;
 
 /// Represents a new LOK child that is read
 /// to host a document.
diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index 67656f3..c91fdf1 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -35,9 +35,11 @@
 #include 
 #include 
 
+#include "Auth.hpp"
 #include "Common.hpp"
 #include "FileServer.hpp"
 #include "LOOLWSD.hpp"
+#include "Log.hpp"
 
 using Poco::FileInputStream;
 using Poco::Net::HTMLForm;
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index dc1549c..607372f 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -100,6 +100,7 @@
 #include "Auth.hpp"
 #include "ClientSession.hpp"
 #include "Common.hpp"
+#include "DocumentBroker.hpp"
 #include

CppCheck Report Failure

2016-12-31 Thread cppcheck.libreoff...@gmail.com


The cppcheck job failed with message: "Failed to run cppcheck."


Note:
The script generating this report was run at :
2017-01-01_00:01:58 with user buildslave at host vm140 as 
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s 
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w 
/home/buildslave/tmp/www

It can be found and improved here:

https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=cppcheck/cppcheck-report.sh




cppcheck-report.log.gz
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105022] New: Crash in: SalAbort(rtl::OUString const &, bool)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105022

Bug ID: 105022
   Summary: Crash in: SalAbort(rtl::OUString const &,bool)
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: a.alan.metc...@gmail.com

This bug was filed from the crash reporting server and is
br-0b4a1e20-a652-4cb2-91ca-fc1633e6dd1e.
=
Version 5.2.4.2
After initial setup of the software I was attempting to change the default
Fonts in LibreOffice Writer. When I clicked Tools> Options> LibreOffice Writer>
Basic Fonts (Western) the window turned grey and the program crashed
(LibreOffice has stopped working). Only option is "Close Program".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2016-12-31 Thread Tor Lillqvist

 configure.ac |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 879bac84cde2fc7cc27363d1bb0ca50c53162a88
Author: Tor Lillqvist 
Date:   Thu Dec 29 14:06:47 2016 +0200

It's not CygWin but Cygwin

Change-Id: I1f1e9fa67244645f695885fcb7b877b9a1ecdf4f

diff --git a/configure.ac b/configure.ac
index 85d2395..6fc1487 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7248,7 +7248,7 @@ if test "$with_export_validation" = yes; then
 fi
 fi
 if test "$build_os" = "cygwin"; then
-# In case of CygWin it will be executed from Windows,
+# In case of Cygwin it will be executed from Windows,
 # so we need to run bash and absolute path to validator
 # so instead of "odfvalidator" it will be
 # something like "bash.exe C:\cygwin\opt\lo\bin\odfvalidator"
@@ -7281,7 +7281,7 @@ if test "$with_export_validation" = yes; then
 fi
 fi
 if test "$build_os" = "cygwin"; then
-# In case of CygWin it will be executed from Windows,
+# In case of Cygwin it will be executed from Windows,
 # so we need to run bash and absolute path to validator
 # so instead of "odfvalidator" it will be
 # something like "bash.exe C:\cygwin\opt\lo\bin\odfvalidator"
@@ -7316,7 +7316,7 @@ if test "$with_bffvalidator" != "no"; then
 AC_MSG_ERROR([bffvalidator not found, but required by 
--with-bffvalidator])
 fi
 elif test -n "$BFFVALIDATOR"; then
-# We are not in CygWin but need to run Windows binary with wine
+# We are not in Cygwin but need to run Windows binary with wine
 AC_PATH_PROGS(WINE, wine)
 
 # so swap in a shell wrapper that converts paths transparently
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104894] Firebird/HSQLDB: Firebird throws error where HSQLDB reports NaN

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104894

Lionel Elie Mamane  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #1 from Lionel Elie Mamane  ---
That's a Firebird question, not LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104991] "unknown SEH exception" when trying to print on HP LaserJet 1000 series

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104991

--- Comment #7 from arielmazat...@gmail.com ---
Thanks a lot C:, I won't be able to report back until Monday though.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105008] [HELP] bold / italic error

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105008

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Yep -> NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104998] PDF images disappear after a while

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104998

Buovjaga  changed:

   What|Removed |Added

   Keywords||needsDevAdvice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104993] schematic tree enhancement

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104993

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Please give more details eg. links..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104883] It is not allowed to install fonts on request

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104883

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #3 from Buovjaga  ---
http://askubuntu.com/questions/832857/installing-fonts-on-request-isnt-supported-error-message
Does the advice help?
The error is definitely coming from Ubuntu.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Need help for building

2016-12-31 Thread slacka

clean everything up with  
$ git checkout master
$ git clean -fdx
$ git reset --hard origin/master
$ git pull

then make everything is sync'd with master
$ git status

If that doesn't do it, 
Try paring down your ./autogen.input. I'm having no issues with a simpler
version on VS2013



--
View this message in context: 
http://nabble.documentfoundation.org/Need-help-for-building-tp4203984p4203993.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 95479] Flicker in slide animation fade in

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95479

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||94691
 Ever confirmed|0   |1
 OS|Mac OS X (All)  |All


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=94691
[Bug 94691] [META] OpenGL bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94691] [META] OpenGL bugs

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94691

Buovjaga  changed:

   What|Removed |Added

 Depends on||95479


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=95479
[Bug 95479] Flicker in slide animation fade in
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104964] FILE OPEN: crash when opening file, message error: osl:: Thread::create failed

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104964

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |INSUFFICIENTDATA

--- Comment #3 from Buovjaga  ---
We would need the bad file, so I will close this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104991] "unknown SEH exception" when trying to print on HP LaserJet 1000 series

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104991

--- Comment #6 from Buovjaga  ---
(In reply to arielmazatlan from comment #5)
> Any help? The artitle says something about using a "LibreOffice debug build"
> but I'm using 5.2.4 that I downloaded from the libreoffice website, could
> that be it?

Here is a debug build:
http://dev-builds.libreoffice.org/daily/master/Win-x86@39/current/
It installs in parallel and will not mess up your stable installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Need help for building

2016-12-31 Thread Kaganski Mike

On 12/31/2016 3:59 PM, Regina Henschel wrote:
my last build was in August. Now I tried a new build, but it fails. I have 
started with
git pull -r

I may remember that wrong, but I have a feeling that it was this problem when I 
was given an advise to use ./g pull -r instead of git pull -r

--
Best regards,
Mike Kaganski
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 104991] "unknown SEH exception" when trying to print on HP LaserJet 1000 series

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104991

--- Comment #5 from arielmazat...@gmail.com ---
I tried using ProcDump as descrived in
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg#Producing_a_mini_dump
but I get trhe following error while trying to run ProcDump:

The procedure entry point CxxFrameHandler3 could not be located in the dynamic
link library msvcrt.dll

Any help? The artitle says something about using a "LibreOffice debug build"
but I'm using 5.2.4 that I downloaded from the libreoffice website, could that
be it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104860] Align to anchor should compensate for above / below indent in paragraph

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104860

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Summary|Register-true frame and |Align to anchor should
   |image anchoring |compensate for above /
   ||below indent in paragraph
 Ever confirmed|0   |1
   Severity|normal  |enhancement

--- Comment #5 from Buovjaga  ---
Ok, I think we now have the pieces to write out steps to reproduce, but
register-true does not seem relevant.

1. New Writer document, type a 1-word paragraph and maybe create one empty
paragraph
2. Insert dummy text to a new paragraph by typing dt and hitting F3
3. Drag'n'drop some small image to the right of the dummy text paragraph so it
is anchored to it
4. Right-click image, Alignment - Align top to anchor
5. Change the paragraph style of the dummy text to Heading 1, 2 or 3..

Observe that the top of the image is not aligned to the top of the paragraph.
Repeating alignment setting for image will not help.

I'm changing this to enhancement as this might just be seen as a lack of
intelligence in the anchoring system.

Aaron: note that you can always manually position the images/frames. Maybe
there is some workaround. You could do a search on the web or submit a question
to http://ask.libreoffice.org/ as a last resort.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Terrence Enger  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected, needsDevEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101216] [META] Comment bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 89147, which changed state.

Bug 89147 Summary: Calc comment text invisible when using missing font in .xls 
file
https://bugs.documentfoundation.org/show_bug.cgi?id=89147

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89147] Calc comment text invisible when using missing font in .xls file

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89147

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 Whiteboard|backportRequest:5.2 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89147] Calc comment text invisible when using missing font in .xls file

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89147

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |WORKSFORME
 Whiteboard||backportRequest:5.2

--- Comment #9 from Aron Budea  ---
Looks correct in 5.2.4.2 & 5.3.0.1 / Windows 7. Wasn't correct in 5.2.3.2.
Setting as WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104825] UI: field for SMTP server port number is spin button

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104825

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #3 from Terrence Enger  ---
Created attachment 130065
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130065=edit
details from bibisect-42max

Working on debian-stretch in bibisect-42max repository, I see the spin
button come into LibreOffice ...

status   commits-h   date
--       ---
good 11f7d374  9579db98  2013-07-10 14:17:46
bad  4445ac65  43f2c887  2013-07-10 14:27:31

I am removing keyword bibisectRequest and adding bisected.

Guessing that this might not be too hard to fix, I am adding keyword
needsDevEval.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 104008] Extension removed from document title in print

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104008

--- Comment #10 from jan iversen  ---
you are aware that you need to run twice in gdb, first time to load symbols,
sencond time to hit your breakpoint ?

hint: come on IRC ask ask.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104877] Implement support for filter import and playback of animated PNG -- APNG

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104877

--- Comment #4 from MM  ---
Would be nice if aPNG is officially supported. Until then you can try to apply
the unofficial patch.
https://sourceforge.net/projects/libpng-apng/?source=typ_redirect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Need help for building

2016-12-31 Thread jan iversen

Hmm, I thought it was a missing "make clean" because the breeze them has 
changed a lot.

I have a very similar windows vm autogen.input which builds fine. I just 
changed it to your autogen.input so will report back tomorrow

happy new year.
rgds
jan i
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 104860] Register-true frame and image anchoring

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104860

--- Comment #4 from Aaron  ---
Created attachment 130064
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130064=edit
Clearer example image register-true on

A clearer example from a paper I'm writing (text replaced by dummy text ofc).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104942] Conversion HSQLDB to Firebird, Table design issues

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104942

--- Comment #2 from Gerhard Schaber  ---
Created attachment 130063
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130063=edit
Sample HSQLDB file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: 2 commits - source/text

2016-12-31 Thread Gabor Kelemen

 source/text/shared/optionen/01030300.xhp |6 +++---
 source/text/shared/optionen/01160200.xhp |8 
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit d798499f968366e1d0277e008d1d7e4b2912f85d
Author: Gabor Kelemen 
Date:   Sat Dec 31 19:49:51 2016 +0100

Update ahelps on the Security options panel

Replace one numeric and add two new to buttons.

Change-Id: I2ca885f8d43edde863e2ff9f13c9d5b4939508a7
Reviewed-on: https://gerrit.libreoffice.org/32546
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/optionen/01030300.xhp 
b/source/text/shared/optionen/01030300.xhp
index 7a451d4..9936f0a 100644
--- a/source/text/shared/optionen/01030300.xhp
+++ b/source/text/shared/optionen/01030300.xhp
@@ -88,18 +88,18 @@
 Adjust the security level for executing macros and specify trusted 
macro authors.
 
 Macro Security
-Opens the Macro Security 
dialog.
+Opens the Macro 
Security dialog.
 
 Certificate Path
 Allows you to 
choose between different installed key store locations to use when signing ODF 
documents or exporting signed PDF. (Only on systems that use the Network 
Security Services NSS.)
 
 Certificate
-Opens the 
Certificate Path dialog.
+Opens the Certificate Path 
dialog.
 
 TSAs
 Allows you to 
maintain a list of Time Stamping Authority (TSA) URLs. TSAs issue digitally 
signed timestamps (RFC 3161) that are optionally used during signed PDF 
export.
 
 TSAs
-Opens the 
Time Stamping Authority URLs dialog.
+Opens the Time Stamping Authority 
URLs dialog.
 
 
commit f785af949d5ce93d4ce66fe8a1dda42878613827
Author: Gabor Kelemen 
Date:   Sat Dec 31 19:48:14 2016 +0100

Replace numeric ahelps in the Registered Databases options

To current, working ones

Change-Id: I98ee8ef1d40097a19db48578aa98c84f0c4f3742
Reviewed-on: https://gerrit.libreoffice.org/32545
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/source/text/shared/optionen/01160200.xhp 
b/source/text/shared/optionen/01160200.xhp
index 8be26e1..3caa559 100644
--- a/source/text/shared/optionen/01160200.xhp
+++ b/source/text/shared/optionen/01160200.xhp
@@ -39,15 +39,15 @@
 
 
 Registered Databases
-Lists the registered name and database file of 
all registered databases. Double-click an entry to edit.
+Lists the registered name and 
database file of all registered databases. Double-click an entry to 
edit.
 
 New
-Opens the Database Link dialog to create 
a new entry.
+Opens the Database Link dialog to create 
a new entry.
 
 Delete
-Removes the selected entry from the 
list.
+Removes the selected entry 
from the list.
 
 Edit
-Opens the Database Link dialog to edit 
the selected entry.
+Opens the Database Link dialog to edit 
the selected entry.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - helpcontent2

2016-12-31 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 653a805a2abbf13109553b21cbfbdf83ba857d10
Author: Gabor Kelemen 
Date:   Sat Dec 31 19:49:51 2016 +0100

Updated core
Project: help  d798499f968366e1d0277e008d1d7e4b2912f85d

Update ahelps on the Security options panel

Replace one numeric and add two new to buttons.

Change-Id: I2ca885f8d43edde863e2ff9f13c9d5b4939508a7
Reviewed-on: https://gerrit.libreoffice.org/32546
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index f785af9..d798499f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f785af949d5ce93d4ce66fe8a1dda42878613827
+Subproject commit d798499f968366e1d0277e008d1d7e4b2912f85d
commit 177936c31d57b92ab6aef578735dee0b52e6c98e
Author: Gabor Kelemen 
Date:   Sat Dec 31 19:48:14 2016 +0100

Updated core
Project: help  f785af949d5ce93d4ce66fe8a1dda42878613827

Replace numeric ahelps in the Registered Databases options

To current, working ones

Change-Id: I98ee8ef1d40097a19db48578aa98c84f0c4f3742
Reviewed-on: https://gerrit.libreoffice.org/32545
Reviewed-by: Gabor Kelemen 
Tested-by: Gabor Kelemen 

diff --git a/helpcontent2 b/helpcontent2
index 92e8586..f785af9 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 92e858687cb974b9f6074e9643f5377f24eb73a0
+Subproject commit f785af949d5ce93d4ce66fe8a1dda42878613827
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Need help for building

2016-12-31 Thread Regina Henschel


Hi all,

my last build was in August. Now I tried a new build, but it fails. I 
have started with

git pull -r

then
/opt/lo/bin/make clean

then
/opt/lo/bin/make

It gives the error
/usr/bin/cp: der Aufruf von stat für 
„C:/LO_buildSymbol/core/workdir/CustomTarget/postprocess/images/images_breeze.zip“ 
ist nicht möglich: No such file or directory


My current autogen.input is
--with-external-tar=/cygdrive/c/LO_buildSymbol/externalsrc
--with-junit=/cygdrive/c/LO_buildSymbol/junit-4.10.jar
--with-ant-home=/cygdrive/c/cygwin/ant195
--enable-pch
--disable-ccache
--enable-symbols
--with-help

What do I miss?

Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 104860] Register-true frame and image anchoring

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104860

--- Comment #3 from Aaron  ---
Created attachment 130062
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130062=edit
Example image register-true off

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104860] Register-true frame and image anchoring

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104860

--- Comment #2 from Aaron  ---
Created attachment 130061
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130061=edit
Example image register-true on

Sorry if I was unclear in my original post. I'll add a picture as an attachment
to better show what I mean. When anchoring a frame or image to a paragraph and
selecting the vertical position to be "from top by 0" or "top" to paragraph
text area, you expect the top of the frame to be at the same height on the page
as the top of the paragraph text area. This is how it normally behaves when
register-true is turned off (see image register-true off), when register-true
is turned on this doesn't work anymore and the top of the frame doesn't line up
with the top of the paragraph ext area. (See image register-true on) I assume
this is a bug because it makes documents which use both register-true and
paragraph anchoring look ugly and wonky. Seeing as how I really want to use
both these features for the layout of my master's thesis, I will gladly help
anyway I can. 

P.s.: I know that in the files I sent you this difference in height might be
rather subtle, but when using other fonts (which I couldn't use here since they
aren't normally included with libreoffice) or using different amounts of
spacing, the difference in vertical position can become a lot more noticeable.
(You can try this for yourself by actually playing with the fonts and spacing.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104901] Image object cumulative placement error affecting display/ print & cell anchor behavior with irregular row height

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104901

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #2 from Buovjaga  ---
(In reply to R. Bingham from comment #0)
> Steps to Reproduce:
> 1) The grid in the sample .ods was constructed by save-as of the live data
> .ods then a global Delete of all cell content and formatting performed,
> leaving the irregular grid.  In the result there are rows that are
> inexplicably small in height compared to the original but I left them as is.
> 2) Via C/P, paste a thumbnail size image object in a low-numbered row.  If
> not already, select the image and set Anchor property to Cell Anchor.  Note
> if the anchor is in the originally selected cell.  If not, this fails
> expectations.
> 3) Repeat the paste every 100 rows and note any vertical offset jitter of
> the image UL corner to the selected cell UL corner.  If not congruent fails
> expectations.

I copied the image from E3 and pasted to I3 and then to all the yellow rows to
the I column up to row 400.
The jitter is only shown after save & reload.

The good news is that it is fine in 3.6, so can be bibisected.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104892] Adding a bunch of very small images (jpg/png) will cause a high CPU load

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104892

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |trivial

--- Comment #2 from Buovjaga  ---
I repro, but only, if I drag'n'drop all of them at once. On Linux, the time of
the CPU load is only a couple of secs. On Win it was more like that 5-8 secs.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104899] Data Analysis T test error in formula for standard error of the difference of sample means

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104899

Buovjaga  changed:

   What|Removed |Added

 CC||r...@post.cz,
   ||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
raal: any idea about this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104813] FILEOPEN: DOC: performance regression at import time

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104813

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #7 from Terrence Enger  ---
Created attachment 130060
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130060=edit
bibisect in daily Linux dbgutil bibisect repository

Working on debian-stretch in the daily Linux dbgutil bibisect
repository, I see that the slowness came into LibreOffice somewhere in
the 68 commits ...

status   commits-h   date
--       ---
good 61bf95ee  634589b3  2016-12-11 21:34:40
bad  c4a4f801  08fa2e93  2016-12-12 23:38:19

In the versions I deemed good, the program renders the document and
becomes responsive after about 10 seconds.  In the bad versions, the
program is still unresponsive after a minute; the one time I waited,
the program was responsive after 15 minutes 26 seconds of CPU time.

I am removing keyword bibisectRequest and adding bibisected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104890] Firebird: Function ABS gives wrong value, when length of field is less than 10

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104890

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89329] convert pImpl pointers to use std::unique_ptr

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89329

--- Comment #129 from Commit Notification 
 ---
G_Zoltan committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f5bf80568eee020ccfe972831b9280859c798836

tdf#89329 pImpl changed to unique_ptr

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2016-12-31 Thread G_Zoltan

 sw/source/ui/envelp/mailmrge.cxx  |2 +-
 sw/source/uibase/inc/mailmrge.hxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f5bf80568eee020ccfe972831b9280859c798836
Author: G_Zoltan 
Date:   Tue Dec 27 23:54:05 2016 +0200

tdf#89329 pImpl changed to unique_ptr

In mailmrge.cxx/mailmrge.hxx manula allocated pImpl pointer is changed to
std::unique_ptr.

Change-Id: Icb973cdb449e59184a24c359c0ca9fe2da4a8ebd
Reviewed-on: https://gerrit.libreoffice.org/32464
Reviewed-by: TamÃ¡s Zolnai 
Tested-by: TamÃ¡s Zolnai 

diff --git a/sw/source/ui/envelp/mailmrge.cxx b/sw/source/ui/envelp/mailmrge.cxx
index 9074bbc..e6e35e67 100644
--- a/sw/source/ui/envelp/mailmrge.cxx
+++ b/sw/source/ui/envelp/mailmrge.cxx
@@ -375,7 +375,7 @@ void SwMailMergeDlg::dispose()
 OUString* pData = static_cast< OUString* >( 
m_pFilterLB->GetEntryData(nFilter) );
 delete pData;
 }
-delete pImpl;
+pImpl.reset();
 m_pBeamerWin.clear();
 m_pAllRB.clear();
 m_pMarkedRB.clear();
diff --git a/sw/source/uibase/inc/mailmrge.hxx 
b/sw/source/uibase/inc/mailmrge.hxx
index 77036d0..8dfe824 100644
--- a/sw/source/uibase/inc/mailmrge.hxx
+++ b/sw/source/uibase/inc/mailmrge.hxx
@@ -91,7 +91,7 @@ class SwMailMergeDlg : public SvxStandardDialog
 
 VclPtrm_pOkBTN;
 
-SwMailMergeDlg_Impl* pImpl;
+std::unique_ptr pImpl;
 
 SwWrtShell& rSh;
 SwModuleOptions* pModOpt;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 104888] "Ctrl + Shift + Enter" hotkey after "F2" on the cell that I carelessly forgot to hold "Ctrl + Shift" when I entered matrix related formula should be treated as a modifi

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104888

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
Reproduced.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104886] Comment toolbar button doesn' t reactivate right away upon deletion of previous comment

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104886

Buovjaga  changed:

   What|Removed |Added

   Keywords||implementationError
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Repro.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104882] Lots of tmp file read/ writes while scrolling a document containing PNG compared to LibO4.2

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104882

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #2 from Buovjaga  ---
Yep, megabyte after megabyte being written when viewed in Process Explorer.

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104832] CRASH when selecting OLE (Visio?) object (in a DOC file)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104832

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #6 from Buovjaga  ---
No crash.

Telesto: if you can get it to crash with a TB39 build, you could get a
backtrace with WinDbg.

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104866] Let the glyph not be clipped within text line

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104866

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Summary|Let the glyph not being |Let the glyph not be
   |clipped within text line|clipped within text line
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
Sounds fair -> NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103859] [META] EMF/WMF (Windows Metafile) bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103859
Bug 103859 depends on bug 99651, which changed state.

Bug 99651 Summary: PRINTING - text in an embedded EMF not printed/exported to 
PDF correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=99651

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104252] Embedded EMF/ WMF and SVM images shows text content on screen but not in print or PDF export on Windows (with HW acceleration and GDI, but not with OpenGL)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104252

V Stuart Foote  changed:

   What|Removed |Added

 CC||bureautiquelibre@nantesmetr
   ||opole.fr

--- Comment #24 from V Stuart Foote  ---
*** Bug 99651 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99651] PRINTING - text in an embedded EMF not printed/ exported to PDF correctly

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99651

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #11 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 104252 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104991] "unknown SEH exception" when trying to print on HP LaserJet 1000 series

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104991

--- Comment #4 from arielmazat...@gmail.com ---
I'll be making a new back track today following the additional procedures shown
in
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg#Producing_a_mini_dump

Thank you all for your help. I'll report back as soon I get the chance.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99651] PRINTING - text in an embedded EMF not printed/ exported to PDF correctly

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99651

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |preBibisect

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104867] Impress not compress copied images with Minimize Presentation

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104867

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Blocks||104238
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
I chose optimize for screen size and it truly increases the file size.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104238
[Bug 104238] [META] Impress image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104238] [META] Impress image bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104238

Buovjaga  changed:

   What|Removed |Added

 Depends on||104867


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104867
[Bug 104867] Impress not compress copied images with Minimize Presentation
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104862] When opening password protected documents of multiple types at the same time , they open as untitled on Windows

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104862

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Summary|Password protected  |When opening password
   |documents open as untitled  |protected documents of
   ||multiple types at the same
   ||time, they open as untitled
   ||on Windows
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #4 from Buovjaga  ---
Confirmed, but only a problem on Windows

Version: 5.2.4.1 (x64)
Build ID: 9b50003582f07ac674d6451e411e9b77cccd2b22
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
Locale: fi-FI (fi_FI); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.4.2.0+
Build ID: 5.2.4-1
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104860] Register-true frame and image anchoring

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104860

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #1 from Buovjaga  ---
Not sure I understand the vertical alignment issue. I am able to freely change
the vertical alignment by dragging and dropping the objects. Is there something
I am missing? Perhaps you need to provide step-by-step instructions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104844] Writer split table function when more than one row header. Only one row is picked for next table

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104844

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|5.2.2.2 release |Inherited From OOo
 Blocks||103100
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
(In reply to Ken from comment #0)
> When splitting a table that has more than one row designated for the header.
> The new table (next) loses any row other than row one. This behavior is
> reasonably new as I have used this function many times in the past. I

Reproduced, but the behavior cannot be new as it is already in LibO 3.3, thus
inherited from OOo.

Steps:
1. Table - Insert Table
2. Something like 8 rows so we can split, tick Heading, Heading rows: 2
3. Go to middle of table, menu Table - Split table. Go with the default Copy
heading.

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Buovjaga  changed:

   What|Removed |Added

 Depends on||104844


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104844
[Bug 104844] Writer split table function when more than one row header. Only
one row is picked for next table
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104844] Writer split table function when more than one row header. Only one row is picked for next table

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104844

Buovjaga  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92673] Split table & Merge table as icons in the Table toolbar

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92673

Buovjaga  changed:

   What|Removed |Added

 Blocks||103239
Summary|NEW TABLE FUNCTION: "Split  |Split table & Merge table
   |table" & "Merge table"  |as icons in the Table
   ||toolbar


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
[Bug 103239] [META] Toolbars bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103239

Buovjaga  changed:

   What|Removed |Added

 Depends on||92673


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=92673
[Bug 92673] Split table & Merge table as icons in the Table toolbar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 92673] Split table & Merge table as icons in the Table toolbar

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92673

Buovjaga  changed:

   What|Removed |Added

 Blocks||103239
Summary|NEW TABLE FUNCTION: "Split  |Split table & Merge table
   |table" & "Merge table"  |as icons in the Table
   ||toolbar


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
[Bug 103239] [META] Toolbars bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 105021] New: Menus and windows broken (text not visible) when EDITING a slide with an animated GIF in "Notes" mode

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105021

Bug ID: 105021
   Summary: Menus and windows broken (text not visible) when
EDITING a slide with an animated GIF in "Notes" mode
   Product: LibreOffice
   Version: 5.2.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: amit.fink...@gmail.com

Created attachment 130058
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130058=edit
Help | About menu in "Notes" mode with a slide having an animated GIF

When writing notes to a slide (View | Notes) which has an animated GIF in it,
the text being typed does not show up. It is in effect being written, but to
see it I need to, for example, minimize and restore the window, or go to a
different slide and then back again.

Similarly, when opening the menus, e.g. Help | About, I cannot see the menu
entries.

Everything is normal, of course, with slides having no animated GIFs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104799] UI: Styles dropdown colors unreadable with GNOME dark theme

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104799

--- Comment #8 from Matthew Bunt  ---
Created attachment 130056
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130056=edit
colors mismatch screenshot

Thank you for looking into this for me Kartikeya. I was not as clear or using
the wrong terminology but here is a screenshot showing the affected menu. If
this is still looking ok on your end I'll just let this bug go, but I know I
was using this drop down for writing my paper just a couple months ago.

The menu I am experiencing the problem is the menu in the tool bar and in the
properties side panel, but not the menu from your screenshot. My screenshot
shows the problem with the tool bar menu.

It appears the menu is displaying fonts EXACTLY as they would appear on the
page, including font color, which may be the source if this problem. I don't
know for sure if that is the case, that is just what it looks like from my user
perspective.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35021] DOC TabOverMargin doesn't work for Left or Center margins

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=35021

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98868] FILESAVE: crash if try save ODT file with track changes compared

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98868

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi
   Severity|major   |critical

--- Comment #8 from Buovjaga  ---
(In reply to kompilainenn from comment #6)
> crash LO is not critical? how long ago is this? Or status "critical" spoils
> statistic?

No, Timur is reading the flowchart wrong. Reverting severity to critical.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104837] Every time when leaving the settings "User Data" "General" or "Memory" 280kb gets written

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104837

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
For me, it wrote about 900 kB every time.

In Process Explorer, I right-clicked the columns, Select columns, Process I/O,
Write bytes.

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104836] Draw dimension line measurement changes from cm to mm when copying to Writer

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104836

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|4.4.6.3 release |Inherited From OOo
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
Repro.

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104833] Scroll panes in Check for Updates dialog do not expose names to assistive technologies

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104833

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Repro with NVDA 2016.4.

Also, it did not read the contents of the Status scroll pane "LibreOfficeDev
5.4 is up to date".

Win 10
Version: 5.4.0.0.alpha0+
Build ID: 7ed40deee74a9869b7da073ad473241187420ff8
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-30_23:18:54
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105015] Crash in: ImplReleaseTempFonts(SalData &)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105015

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
For the test, could you rename your LO directory profile (see
https://wiki.documentfoundation.org/UserProfile#Windows) and give a new try?

If you still reproduce the crash, did you install any specific fonts? If yes,
could you disable them just for the test?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50097] FILESAVE: FORMCONTROLS: Form controls not saved in .docx

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=50097

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4823

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Buovjaga  changed:

   What|Removed |Added

 Depends on||104823


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104823
[Bug 104823] For Word 2016 Content Controls Placeholder Text is Being Displayed
Instead of Text from XML
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104823] For Word 2016 Content Controls Placeholder Text is Being Displayed Instead of Text from XML

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104823

Buovjaga  changed:

   What|Removed |Added

   Keywords||filter:docx
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=50
   ||097
 Blocks||104520
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Confirmed.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.4.0.0.alpha0+
Build ID: fc0d4e6bc43d5f982452df07930f5ecf5927ad22
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on December 31st 2016


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

   Keywords||regression
   Priority|medium  |high
 OS|Windows (All)   |All

--- Comment #3 from Julien Nabet  ---
If I don't detach side bar, LO hangs when clicking first time on "New theme..."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105020] envelop generation

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105020

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Did you check in the preview of step4 there was no message like "No matching
found"?
If there's some, you must click on "Matching fields..."

BTW, LO 5.2.4 has been released, you may give it a try.

Waiting for your feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104819] Formatting: Corrupt Document/ Format After Save When Starting With Empty .docx Document

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104819

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #6 from Buovjaga  ---
(In reply to junk_2010 from comment #5)
> Created attachment 129824 [details]
> zipped New Microsoft Word Document .docx Created In Folder By Right Mouse
> Button Click And Menu Item Selection

For me, it offers to save as Text format. If I save as .DOCX, my created header
and footer are intact.
Maybe I could try opening my own produced file in MSO2013 later.

Win 10
Version: 5.2.4.1 (x64)
Build ID: 9b50003582f07ac674d6451e411e9b77cccd2b22
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
Locale: fi-FI (fi_FI); Calc: group

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.4.2.0+
Build ID: 5.2.4-1
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104980] Notebook bar: no indication if document modified/to be saved

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104980

--- Comment #1 from Helmut Leininger  ---
There is a little icon in the status bar at bottom, but less obvious than
within the save icon

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104798] Autocorrect cannot be set to two (or more) languages in one document (Options and Localized options)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104798

Buovjaga  changed:

   What|Removed |Added

 Blocks||103341


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103341
[Bug 103341] [META] Auto Correct and Completion bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103341] [META] Auto Correct and Completion bugs and enhancements

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103341

Buovjaga  changed:

   What|Removed |Added

 Depends on||104798


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104798
[Bug 104798] Autocorrect cannot be set to two (or more) languages in one
document (Options and Localized options)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104798] Autocorrect cannot be set to two (or more) languages in one document (Options and Localized options)

2016-12-31 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104798

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Summary|Autocorrect cannot be set   |Autocorrect cannot be set
   |to two (or more) languages  |to two (or more) languages
   |in one document |in one document (Options
   ||and Localized options)
 Ever confirmed|0   |1
 OS|Windows (All)   |All
   Severity|normal  |minor

--- Comment #1 from Buovjaga  ---
As you talk about quotes, I guess you mean Localized options tab specifically.

I confirm the problem.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.2.4.2.0+
Build ID: 5.2.4-1
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2016-12-31 Thread Caolán McNamara

 vcl/source/window/window.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit dd801a6231bc0f7de2fe2d240869c34028aa70b3
Author: CaolÃ¡n McNamara 
Date:   Sat Dec 31 14:36:28 2016 +

coverity#1398232 Uninitialized scalar field

Change-Id: Ia5e9ebecc032e59bf98d32b0de0f11617da8b2ba

diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index dc2b81f..e3c102b 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -822,6 +822,8 @@ ImplFrameData::ImplFrameData( vcl::Window *pWindow )
 maResizeIdle.SetDebugName( "vcl::Window maResizeIdle" );
 mbInternalDragGestureRecognizer = false;
 mbInBufferedPaint = false;
+mnDPIX = 96;
+mnDPIY = 96;
 }
 
 namespace vcl {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/inc

2016-12-31 Thread Caolán McNamara

 vcl/inc/window.h |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 697ccf11f93a625af762f6e08eb924de71b1840e
Author: CaolÃ¡n McNamara 
Date:   Sat Dec 31 14:35:22 2016 +

unused maMapUnitRes member

since

commit 7abd369964a0c7f9f80cdbc9e47c7dc120fe8257
Author: Noel Grandin 
Date:   Thu Nov 3 14:00:28 2016 +0200

loplugin:unusedmethods

Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e
Reviewed-on: https://gerrit.libreoffice.org/30524
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

Change-Id: I4cb8167698d460df6a56c5b3b7d01841e3f1a69a

diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index 8abe5d1..7c4d116 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -118,7 +118,6 @@ struct ImplFrameData
 ImplFontCache*  mpFontCache;//< Font-Cache for this frame
 sal_Int32   mnDPIX; //< Original Screen Resolution
 sal_Int32   mnDPIY; //< Original Screen Resolution
-ImplMapRes  maMapUnitRes;   //< for LogicUnitToPixel
 ImplSVEvent *   mnFocusId;  //< FocusId for PostUserLink
 ImplSVEvent *   mnMouseMoveId;  //< MoveId for PostUserLink
 longmnLastMouseX;   //< last x mouse position
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 >

1 - 100 of 156 matches

Mail list logo