[Libreoffice-commits] core.git: framework/source officecfg/registry

[Szymon Kłos]

 framework/source/uielement/toolbarmodemenucontroller.cxx   |9 
+
 officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs |5 -
 2 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 6d1e22a9b8c197673f43dcb00f3270dae812c8ae
Author: Szymon Kłos 
Date:   Thu Feb 23 17:24:31 2017 +0100

Make ToolbarMode's "IsExperimental" property non-nillable

Change-Id: Ia83776d7ee23fa56c0fc541c228c68b1832c3d11
Reviewed-on: https://gerrit.libreoffice.org/34585
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/framework/source/uielement/toolbarmodemenucontroller.cxx 
b/framework/source/uielement/toolbarmodemenucontroller.cxx
index 1e6cc36..018253b 100644
--- a/framework/source/uielement/toolbarmodemenucontroller.cxx
+++ b/framework/source/uielement/toolbarmodemenucontroller.cxx
@@ -128,14 +128,7 @@ void ToolbarModeMenuController::fillPopupMenu( Reference< 
css::awt::XPopupMenu >
 OUString aLabel = comphelper::getString( aModeNode.getNodeValue( 
"Label" ) );
 OUString aCommandArg = comphelper::getString( aModeNode.getNodeValue( 
"CommandArg" ) );
 long nPosition = comphelper::getINT32( aModeNode.getNodeValue( 
"MenuPosition" ) );
-
-bool isExperimental = false;
-if ( aModeNode.hasByName( "IsExperimental" ) )
-{
-Any aExperimentalNode = aModeNode.getNodeValue( "IsExperimental" );
-if( aExperimentalNode.hasValue() )
-isExperimental = comphelper::getBOOL( aExperimentalNode );
-}
+bool isExperimental = comphelper::getBOOL( aModeNode.getNodeValue( 
"IsExperimental" ) );
 
 // Allow Notebookbar only in experimental mode
 if ( isExperimental && !aMiscOptions.IsExperimentalMode() )
diff --git a/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs 
b/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
index 50759f8..5d0f418 100644
--- a/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/UI/ToolbarMode.xcs
@@ -41,10 +41,13 @@
   Position in the menu.
 
   
-  
+  
 
   Enables entry only in the experimental mode.
 
+
+  false
+
   
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

MSVC 2015 Error C2664

[Luke Benes]

After commit: 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f28672a077375a360879ad34edfbd06b611ea6d8

Don't inherit SwSpellPopup from PopupMenu

I'm getting the following build error with MSVC 2015:

[build CXX] sw/source/uibase/lingu/olmenu.cxx
[build CXX] sw/source/uibase/misc/numberingtypelistbox.cxx
C:/core/include\vcl/vclptr.hxx(415): error C2664: 'PopupMenu::PopupMenu(const 
PopupMenu &)': cannot convert argument 1 from 'ScopedVclPtrInstance' 
to 'const ResId &'
C:/core/include\vcl/vclptr.hxx(415): note: Reason: cannot convert from 
'ScopedVclPtrInstance' to 'const ResId'
C:/core/include\vcl/vclptr.hxx(415): note: No user-defined-conversion operator 
available that can perform this conversion, or the operator cannot be called
C:/core/sw/source/uibase/inc\olmenu.hxx(85): note: see reference to function 
template instantiation 
'ScopedVclPtrInstance::ScopedVclPtrInstance(ScopedVclPtrInstance
 &&)' being compiled
C:/core/sw/source/uibase/inc\olmenu.hxx(85): note: see reference to function 
template instantiation 
'ScopedVclPtrInstance::ScopedVclPtrInstance(ScopedVclPtrInstance
 &&)' being compiled
C:/core/include\vcl/vclptr.hxx(415): error C2664: 
'ScopedVclPtr::ScopedVclPtr(const ScopedVclPtr 
&)': cannot convert argument 1 from '__sal_NoAcquire' to 'PopupMenu *'
with
[
reference_type=PopupMenu
]
C:/core/include\vcl/vclptr.hxx(415): note: Conversion from integral type to 
pointer type requires reinterpret_cast, C-style cast or function-style cast
make[1]:
make[1]:
Makefile:259: recipe for target 'build' failed
make: *** [build] Error 2

Since the ESC decided to switch to MSVC 2015, shouldn't Jenkins be upgraded to 
avoid these kinds of issues?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106155] LO 5.3.0.3 does not start when opengl activated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106155

--- Comment #3 from Friedmann Bruno  ---
Created attachment 131435
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131435=edit
backtrace when UseOpenGL  =true

NVIDIA drivers 378.18
Mesa 17.0.0-155.1
xorg 1.19.1-3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Question about Memory options

[Tor Lillqvist]

>
>
> If someone can provide an explanation of how the Memory settings affect
> performance, and under what circumstances, I would really appreciate it.
>

I don't think anybody can give a general answer that would apply in all
situations. (After all, if there was a generic way to speed up LO by simply
changing some parameter, why wouldn't it do that automatically then,
instead of leaving it to the user?) What settings you think "work" or you
might not "work" for another person's use case on a different computer.
Also, you have to be very careful to avoid placebo effects.

I think those options should be removed. They best way to speed up LO is to
buy a more powerful computer.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105229] Crash when hitting Quit in Safe Mode dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105229

Aron Budea  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105229] Crash when hitting Quit in Safe Mode dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105229

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Aron Budea  ---
I confirm that there's no crash anymore in the daily build referenced below.

Btw, when I was retesting now with the crashing old version, the crash only
occurred if safe mode was initiated from Writer/Calc/etc. (+ the Quit step),
and not from the Start Center. Just to be clear about the original repro steps.

It's all good now, so closing as FIXED.


Version: 5.4.0.0.alpha0+
Build ID: a8538f0774bd0fabf6012d735d1e86b3ff1c291f
CPU threads: 4; OS: Windows 6.1; UI render: GL; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-02-23_23:42:53
Locale: hu-HU (hu_HU); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svl/source

[Jochen Nitschke]

 svl/source/items/itempool.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit b65f742d7a3d843570c75ffcab99d5029b01a772
Author: Jochen Nitschke 
Date:   Thu Feb 23 16:53:38 2017 +

fix inverted warning logic

warning says the item pool is not empty,
so test item pointers for not null.
ever since initial commit cf7e1f9cc99e7c260cfab823f2c47f56035bdbd0

and make warning more descriptive by adding pool names

Change-Id: I3a8a6ca69e319d01418eac527b15f61adfd0fb13
Reviewed-on: https://gerrit.libreoffice.org/34589
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx
index 679a097..ef2a481 100644
--- a/svl/source/items/itempool.cxx
+++ b/svl/source/items/itempool.cxx
@@ -413,10 +413,11 @@ void SfxItemPool::SetSecondaryPool( SfxItemPool *pPool )
 break;
 if (rSecArrayPtr)
 {
-for (auto const& rItemPtr : *rSecArrayPtr)
-if (!rItemPtr)
+for (const SfxPoolItem* pItem : *rSecArrayPtr)
+if (pItem)
 {
-OSL_FAIL( "old secondary pool must be empty" );
+SAL_WARN("svl.items", "old secondary pool: " << 
pImpl->mpSecondary->pImpl->aName
+<< " of pool: " << pImpl->aName << 
" must be empty.");
 bOK = false;
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106169] New: LibreOffice won' t save new data created in a document file and errors out. Can' t close program unless selecting "cancel edit". If selecting cancel edit, then Lib

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106169

Bug ID: 106169
   Summary: LibreOffice won't save new data created in a document
file and errors out.  Can't close program unless
selecting "cancel edit".  If selecting cancel edit,
then LibreOffice destroys all the work previously
performed.
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugrepor...@sonic.net

Description:
If editing an existing file, and adding new content, LibreOffice crashes, and
won't allow the edit to be created.  Additionally LibreOffice corrupts and
destroys work previously done in the document file. LibreOffice for the Mac,
Version 5.2.5.1 is a very unstable version..


Steps to Reproduce:
1. Open existing document file with content.
2. Edit document with new content.
3. Attempt to save document.
4. LibreOffice errors out and crashes.


Actual Results:  
1. LibreOffice won't allow you to save edits, and destroys the file if you
select the "cancel edit option".

Expected Results:
LibreOffice document should have saved the edits, without displaying an error
message.  Additionally LibreOffice Document shouldn't have destroyed existing
content.


Reproducible: Always

User Profile Reset: No.  I don't have a profile setup on the MacBook Pro.

Additional Info:
Problem appears to have occurred with the last update to LibreOffice.  I am
running LibreOffice 5.2.5.1 on the OSX El Capitain Operating System.


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0)
Gecko/20100101 Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105490] FILEOPEN DOCX: LibO will add a empty page after each page break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105490

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105490] FILEOPEN DOCX: LibO will add a empty page after each page break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105490

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105490] FILEOPEN DOCX: LibO will add a empty page after each page break

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105490

--- Comment #7 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1dadd312e5cb3c95f1e3cd5a1776830b7056bc6b

tdf#105490: writerfilter exception - ULSpace must be >= 0

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Justin Luth]

 sw/qa/extras/ooxmlexport/data/tdf105490_negativeMargins.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport9.cxx|6 ++
 writerfilter/source/dmapper/PropertyMap.cxx  |4 ++--
 3 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 1dadd312e5cb3c95f1e3cd5a1776830b7056bc6b
Author: Justin Luth 
Date:   Fri Feb 24 07:16:00 2017 +0300

tdf#105490: writerfilter exception - ULSpace must be >= 0

Instead of a minimal margin, default margins were being applied
because an exception was thrown when trying to set a negative
value to top and bottom margins in SvxULSpaceItem::PutValue

Change-Id: I0a9fc2c7cb996efbd26abfdbed27ea0bcb86d9a5
Reviewed-on: https://gerrit.libreoffice.org/34598
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf105490_negativeMargins.docx 
b/sw/qa/extras/ooxmlexport/data/tdf105490_negativeMargins.docx
new file mode 100644
index 000..6acb9f3
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf105490_negativeMargins.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
index 6f31ba0..0ffd692 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport9.cxx
@@ -67,6 +67,12 @@ DECLARE_OOXMLEXPORT_TEST(testTdf41542_borderlessPadding, 
"tdf41542_borderlessPad
 CPPUNIT_ASSERT_EQUAL( 3, getPages() );
 }
 
+DECLARE_OOXMLEXPORT_TEST(tdf105490_negativeMargins, 
"tdf105490_negativeMargins.docx")
+{
+// negative margins should change to minimal margins, not default margins.
+CPPUNIT_ASSERT_EQUAL( 1, getPages() );
+}
+
 
DECLARE_OOXMLEXPORT_TEST(testTdf104061_tableSectionColumns,"tdf104061_tableSectionColumns.docx")
 {
 CPPUNIT_ASSERT_MESSAGE("There should be two or three pages", getPages() <= 
3 );
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 7cba5a1..354be34 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1005,8 +1005,8 @@ void SectionPropertyMap::PrepareHeaderFooterProperties( 
bool bFirstPage )
 }
 
 //now set the top/bottom margin for the follow page style
-Insert(PROP_TOP_MARGIN, uno::makeAny( nTopMargin ));
-Insert(PROP_BOTTOM_MARGIN, uno::makeAny( nBottomMargin ));
+Insert(PROP_TOP_MARGIN, uno::makeAny( nTopMargin > 0 ? nTopMargin : 0 ));
+Insert(PROP_BOTTOM_MARGIN, uno::makeAny( nBottomMargin > 0 ? nBottomMargin 
: 0 ));
 }
 
 uno::Reference lcl_GetRangeProperties(bool 
bIsFirstSection,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Can tb73 be upgraded to VS 2015 Update 3, to avoid false negative?

[David Ostrovsky]

On Mon Feb 20 09:14:32 UTC 2017 Stephan Bergmann wrote:

>On 02/18/2017 06:04 PM, David Ostrovsky wrote:
>> Conclusion: tb73 and probably other TBs need to be upgraded to the
>> latest MSVC 2015 update 3.
>
>If we want to only support latest update 3 (and it probably makes
>sense to do so), can we check that during configure?

Thanks, Stephan, your check: [1] to detect and reject MSVC < SP3 works
like a charm: [2]:

checking whether MSVC 2015 compiler
C:/PROGRA~2/MICROS~3.0/VC/bin/cl.exe -arch:SSE is at least SP3... no
configure: error: When using MSVC 2015, at least SP3 must be installed

The better question is: who can upgrade the TBs now, that still have
MSVC 2015 SP1 on them installed, and there are quite of them tb73 ...
tb80. I know, that we are all very busy people and do it all in our
spare free time, so if all other options fail, please contact me
privately, give me the credentials and I volunteer to do the upgrade.

Should be straight forward: de-install MSVC 2015 prof. and install MSVC
2015 SP3 community edition. Estimated time 60 min. pro TB. 4 affected
TBs(?) we are talking approx. about 4 hours of work, that would allow
us to discontinue MSVC 2013 (as per ESC decision, TBs upgrade is the
only blocking issue here) [3] and move forward with code and build tool
chain cleanups pending for review and verification: [4].

* [1] When using MSVC 2015, require at least SP3
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8538f0774bd0f
abf6012d735d1e86b3ff1c291f
* [2] https://ci.libreoffice.org/job/lo_gerrit/7550/Config=windows_msc_
dbgutil_32/console
* [3] https://gerrit.libreoffice.org/#/q/topic:raise-compiler-baseline-
msvc-2015
* [4] https://gerrit.libreoffice.org/#/q/topic:toolchain-clenaup

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106168] New: Blinking thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106168

Bug ID: 106168
   Summary: Blinking thumbnails
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gio...@gmail.com

Description:
Very often (not always) the thumbnails of linked images blink. To stop them I
have to click over the blinking thumbnail, then another thumbnail (usually the
one beneath) starts to blink as well. Only when I have clicked over all the
thumbnails visible in the screen, the blinking thing stops.

Steps to Reproduce:
1.Link some jpg images to different slides
2.Save & close
3.Re-open and enjoy

Actual Results:  
Thumbnails blink.

Expected Results:
Thumbnails shouldn't blink. Version 4.3.4 didn't have this bug.E


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/56.0.2924.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103830] Form field names not update in python macro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103830

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected
 CC||noelgran...@gmail.com

--- Comment #8 from Aron Budea  ---
Verified that the commit referenced below is causing this bug. Adding Cc: Noel
Grandin.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5f15cc01b31ccaed0c6482a36556dece084ce302
author  Noel Grandin  2014-11-05 12:48:20 (GMT)
committer   Noel Grandin  2014-11-05 13:59:23 (GMT)

"new loplugin: use more efficient find() methods"

In particular this change:
http://opengrok.libreoffice.org/xref/core/forms/source/misc/InterfaceContainer.cxx#665
old: if (i != m_aMap.end())
new: if (i != m_aMap.end() && (*i).second != evt.Source)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103830] Form field names not update in python macro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103830

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

--- Comment #7 from Aron Budea  ---
Bibisected using bibisect_win_44 repo.

# good: [8aa9fc9a0c92172593d6cd97662116a965db229d]
source-hash-dea4a3b9d7182700abeb4dc756a24a9e8dea8474
git bisect good 8aa9fc9a0c92172593d6cd97662116a965db229d
# bad: [489ffd1df414698b6cea9ab03bf6f663b8b5af7e]
source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
git bisect bad 489ffd1df414698b6cea9ab03bf6f663b8b5af7e
# bad: [489ffd1df414698b6cea9ab03bf6f663b8b5af7e]
source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
git bisect bad 489ffd1df414698b6cea9ab03bf6f663b8b5af7e
# good: [897913acd244cb6a5d2f4c2da1d625d9b978edb6]
source-hash-ac57362b23859591c088e36b7218f4a606dcf3bb
git bisect good 897913acd244cb6a5d2f4c2da1d625d9b978edb6
# good: [897913acd244cb6a5d2f4c2da1d625d9b978edb6]
source-hash-ac57362b23859591c088e36b7218f4a606dcf3bb
git bisect good 897913acd244cb6a5d2f4c2da1d625d9b978edb6
# good: [860f6172be84c3d801e1e533ab3d12a28815cb4c]
source-hash-80c11d648e88f3195f7e4fb465cd6902bcf46867
git bisect good 860f6172be84c3d801e1e533ab3d12a28815cb4c
# good: [860f6172be84c3d801e1e533ab3d12a28815cb4c]
source-hash-80c11d648e88f3195f7e4fb465cd6902bcf46867
git bisect good 860f6172be84c3d801e1e533ab3d12a28815cb4c
# good: [fe0abc50dc1e45fd73635394f8df41e0dfc3eec8]
source-hash-4e223fab04279c3583689e69fa1342966e81de36
git bisect good fe0abc50dc1e45fd73635394f8df41e0dfc3eec8
# bad: [247d0249eb9794ccedec0ca2e3309b8d970593cc]
source-hash-1535f39388223de53e4b923c6f7bb71ee32c1858
git bisect bad 247d0249eb9794ccedec0ca2e3309b8d970593cc
# bad: [247d0249eb9794ccedec0ca2e3309b8d970593cc]
source-hash-1535f39388223de53e4b923c6f7bb71ee32c1858
git bisect bad 247d0249eb9794ccedec0ca2e3309b8d970593cc
# good: [6cf25fb7af89cc58453d4bda5135e05ca220b1a4]
source-hash-ddd549c7873404d0c09aca676a13660404b0bcd2
git bisect good 6cf25fb7af89cc58453d4bda5135e05ca220b1a4
# bad: [bfea3b2558107a049b038c756f63169782a2909c]
source-hash-a9a9718bb1f64318429562ecdaa3d3763d9e2f4a
git bisect bad bfea3b2558107a049b038c756f63169782a2909c
# good: [ea9607c5d8d01daea4116f869c7a5b8be2d56c34]
source-hash-f3798fa1584dd63b8547eec00c92584d906f6979
git bisect good ea9607c5d8d01daea4116f869c7a5b8be2d56c34
# good: [f3cf88475275189bc454cc1b84bf4c25af2e6182]
source-hash-0fd046c571eb9a5a4597e374c453c2515a1388c3
git bisect good f3cf88475275189bc454cc1b84bf4c25af2e6182
# bad: [232925ac49ba4e65c39aa8a0c4c74026ffe23f9e]
source-hash-e90ba3912747b67873344dea14e2a5821ec766c8
git bisect bad 232925ac49ba4e65c39aa8a0c4c74026ffe23f9e
# good: [11da988db49265ba4cc99af001d60c500f908a10]
source-hash-16f18fb34b5cfae86a48e8e360d98b95d458ee85
git bisect good 11da988db49265ba4cc99af001d60c500f908a10
# first bad commit: [232925ac49ba4e65c39aa8a0c4c74026ffe23f9e]
source-hash-e90ba3912747b67873344dea14e2a5821ec766c8

Bibisected down to a range of 8 commits:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=16f18fb34b5cfae86a48e8e360d98b95d458ee85..e90ba3912747b67873344dea14e2a5821ec766c8

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106167] LOKDocView: Print option in the widget

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106167

Pranav Kant  changed:

   What|Removed |Added

 Depends on||106166


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106166
[Bug 106166] [META] LOKDocView bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106166] [META] LOKDocView bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106166

Pranav Kant  changed:

   What|Removed |Added

 Blocks||106167


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106167
[Bug 106167] LOKDocView: Print option in the widget
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106166] [META] LOKDocView bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106166

Pranav Kant  changed:

   What|Removed |Added

  Alias||LOKDocView

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106167] New: LOKDocView: Print option in the widget

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106167

Bug ID: 106167
   Summary: LOKDocView: Print option in the widget
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pran...@collabora.co.uk

>From downstream bug report here[1] - indeed, it would be great if clients are
able to print the document. In LibreOffice ONline, it is done by giving a PDF
to client which they can then print, we can do the same here too.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1419928

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101201] paper size and orientation cannot be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101201

--- Comment #2 from Alan  ---
Checked "Use only paper size from printer preferences" as requested.

Paper size still wrong.

Then clicked "Properties" button on General tab. On Paper tab of Properties the
Paper Tray was set to Paper Cassette, Duplex was set to 2-sided long edge, and
paper size options could now be selected. However the only Paper Size options
available were A4, A5, JIS B5, US Letter, and US Letter (Borderless).

Changed Paper Tray setting to Rear Paper Feed Slot. Changed duplex to Off.
Paper size settings now included envelope sizes including #10.

Then, for giggles and grins, set Paper Tray back to Paper Cassette and checked
Paper Size now available. The full list of sizes including envelopes was still
available.

So appears is possible to select envelope size. However very obtuse and opaque
route to make it happen.

I expect I will forget it before the next time I need to print an envelope!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106166] [META] LOKDocView bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106166

--- Comment #1 from Pranav Kant  ---
Its the gtk widget that resides in libreofficekit/source/gtk/lokdocview.cxx and
is used by gnome-documents to open ODF files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106166] [META] LOKDocView bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106166

Pranav Kant  changed:

   What|Removed |Added

 Blocks||96319


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=96319
[Bug 96319] LOKView allow choosing dual/single-page view
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96422] LOKView No signal when search was successful

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96422

Pranav Kant  changed:

   What|Removed |Added

 Depends on||106166


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106166
[Bug 106166] [META] LOKDocView bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96319] LOKView allow choosing dual/single-page view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96319

Pranav Kant  changed:

   What|Removed |Added

 Depends on||106166


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106166
[Bug 106166] [META] LOKDocView bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106166] New: [META] LOKDocView bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106166

Bug ID: 106166
   Summary: [META] LOKDocView bugs
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: pran...@collabora.co.uk

Meta bug for tracking all bugs related to LOKDocView

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Question about Memory options

[Lori Kaufman]

I'm a writer with How-To Geek and I'm writing an article about how to speed
up LibreOffice. I was trying to understand the Memory settings in the
Options and how they all affect the performance of LibreOffice. The help
does not explain that.

If you don't use inserted objects often, does decreasing the number of
objects stored in the cache release memory that can be made available to the
image cache? Or, does one not affect the other?

Also, does disabling the Java runtime environment help speed up the
performance of the LibreOffice programs that don't use it, such as Writer or
Calc?

If someone can provide an explanation of how the Memory settings affect
performance, and under what circumstances, I would really appreciate it.

Thanks,

Lori Kaufman

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: sha1sum problem

[Norbert Thiebaud]

On Thu, Feb 23, 2017 at 10:54 AM, Necdet Yücel  wrote:
> Hi,
>
> Since SHA1 has been broken in practice [1] maybe we should consider to move
> to safer alteratives, such as SHA-256.

What are you talking about ? (yes I read the news this morning too,
but what concretely are you talking about in the context of this
project ? )

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build Time Query

[Norbert Thiebaud]

On Thu, Feb 23, 2017 at 3:53 PM, Jason Marshall
 wrote:
> Dear Sir/ Madam
>
> I am attempting to build LibreOffice on the following platform:
>
> OS: Lubuntu
> Processor: Intel Atom Z530 1.6 GHz
> RAM: 1Gb
> Disk: 60Gb SSD
>
> Would greater than ten hours be expected,
> as I am aware that the hardware specification above is quite low.

The spec of your processor are at least 70 times slower than the cpu
we use to build the product in our ci system, and 25 to 30 times
slower than an average modern laptop.
1GB RAM is also not a lot, and you will prolly swap out during some of
the link phases.

a full cold build on our ci sytem takes ~30 minutes

>  In
> addition, if the failed build is simply re-started by running the ‘make'

yes

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106119] LibreOffice Writer label dimension of 1/100" is too coarse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106119

David Chamberlin  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from David Chamberlin  ---
(In reply to Joel Madero from comment #1)
> Please attach a sample document then set to UNCONFIRMED.

No sample document required.  Use File/New/Labels, then select Avery Letter
Size for Brand, and 5266 File Folder-Assorted for the Type on the Labels tab if
you need a document.

If you need more explanation, let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - officecfg/registry vcl/source

[Maxim Monastirsky]

 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |4 -
 vcl/source/helper/commandinfoprovider.cxx|   22 
+++---
 vcl/source/window/menu.cxx   |   17 
+++
 3 files changed, 26 insertions(+), 17 deletions(-)

New commits:
commit fe7c8e4ec1990f33d325d3fcabdce30ef4f74465
Author: Maxim Monastirsky 
Date:   Thu Feb 23 22:20:18 2017 +0200

Closing popup menu should close the parent toolbox

... if that toolbox is in popup mode (e.g. shapes toolbar
dropdowns, or the toolbar overflow floater). Same behavior
was introduced for non menu based dropdowns in
81d4fbc0daa54889ccb09e6a3fadff9c70d99448 ("tdf#42029 Use a
floating toolbar to show clipped items"), and is similar
to what we had already in ToolBox::Select, i.e. when the
user made a selection, the floating windows should close.

This must be done before executing the menu selection
handler, because such handler might execute stuff
synchronously (e.g. MenuBarManager::Select), and if it
will open a modal dialog, the floating toolbox will stay
visible after the dialog shows.

Change-Id: Ie93e71fa4dea80ba444aebccacf6adb926a39224

diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 48055ff..e76662b 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -113,6 +113,20 @@ static void ImplSetMenuItemData( MenuItemData* pData )
 pData->eType = MenuItemType::STRINGIMAGE;
 }
 
+namespace {
+
+void ImplClosePopupToolBox( const VclPtr& pWin )
+{
+if ( pWin->GetType() == WindowType::TOOLBOX && 
ImplGetDockingManager()->IsInPopupMode( pWin ) )
+{
+ImplDockingWindowWrapper* pWrapper = 
ImplGetDockingManager()->GetDockingWindowWrapper( pWin );
+if ( pWrapper && pWrapper->GetFloatingWindow() )
+pWrapper->GetFloatingWindow()->EndPopupMode( 
FloatWinPopupEndFlags::CloseAll );
+}
+}
+
+}
+
 Menu::Menu()
 : mpFirstDel(nullptr),
   pItemList(new MenuItemList),
@@ -3022,6 +3036,7 @@ sal_uInt16 PopupMenu::ImplExecute( const 
VclPtr& pW, const Rectangl
 pWin->doShutdown();
 pWindow->doLazyDelete();
 pWindow = nullptr;
+ImplClosePopupToolBox(pW);
 ImplFlushPendingSelect();
 return nSelectedId;
 }
@@ -3082,7 +3097,7 @@ sal_uInt16 PopupMenu::ImplExecute( const 
VclPtr& pW, const Rectangl
 pWin->doShutdown();
 pWindow->doLazyDelete();
 pWindow = nullptr;
-
+ImplClosePopupToolBox(pW);
 ImplFlushPendingSelect();
 }
 
commit 6dc453db7ad693cd960170c35245929ea539ba15
Author: Maxim Monastirsky 
Date:   Thu Feb 23 09:52:46 2017 +0200

Adapt insert image label for the context menu

... after commit fde6bbe41d3d8e13b6d3dc3f18e5ddcd10cfe5f0
("right click to insert image"), added .uno:InsertGraphic
to the slide's context menu.

Change-Id: Ib801899c17cc4f765f46fd4b8884e6b57b455f6d

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 0b860f7..d9733de 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -3549,8 +3549,8 @@
 
   ~Image...
 
-
-  Insert Image
+
+  Insert Image...
 
 
   1
commit 89c05973ff57eea1bc6c9cdc9e7dc13796e7d339
Author: Maxim Monastirsky 
Date:   Thu Feb 23 09:43:24 2017 +0200

Remove the intermediate xModel variables

And make sure to check for a nullptr xController
in GetBitmapForCommand.

Change-Id: Ib62bc06d0708847cfec54a71209cf68a4c32a50d

diff --git a/vcl/source/helper/commandinfoprovider.cxx 
b/vcl/source/helper/commandinfoprovider.cxx
index 755d41f..931900a 100644
--- a/vcl/source/helper/commandinfoprovider.cxx
+++ b/vcl/source/helper/commandinfoprovider.cxx
@@ -85,18 +85,14 @@ Reference const 
GetDocumentAcceleratorConfigurati
 Reference xController = rxFrame->getController();
 if (xController.is())
 {
-Reference xModel (xController->getModel());
-if (xModel.is())
+Reference 
xSupplier(xController->getModel(), UNO_QUERY);
+if (xSupplier.is())
 {
-Reference xSupplier (xModel, 
UNO_QUERY);
-if (xSupplier.is())
+Reference xConfigurationManager(
+xSupplier->getUIConfigurationManager());
+if (xConfigurationManager.is())
 {
-Reference xConfigurationManager(
-xSupplier->getUIConfigurationManager());
-if (xConfigurationManager.is())
-{
-return 

[Libreoffice-bugs] [Bug 106165] New: Dismissed status bar re-appears while pasting unformatted text.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106165

Bug ID: 106165
   Summary: Dismissed status bar re-appears while pasting
unformatted text.
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marcus.knapp...@gmx.de

Description:
The Status Bar is shown by default but it can be dismissed via View -> Status
Bar. When the Status Bar is dismissed it does reappear when pasting something
via Paste special -> Unformatted text. 

The content is pasted without problems. Pasting content via Edit -> Paste does
not show the Status Bar. 

The Status Bar which reappears is empty and does not show any content. 

Steps to Reproduce:
1. Remove Status Bar via View -> Status Bar.
2. Copy arbitrary content
3. Edit -> Paste special -> Unformatted text. 

Actual Results:  
Pasting some text does work fine. However, additionally the dismissed Status
Bar shows up.

Expected Results:
The Status Bar should be unaffected by pasting something and stay hidden.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/55.0.2883.87 Chrome/55.0.2883.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97391] [META] Tracker bug for OpenCL and "Software Interpreter" issues in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97391
Bug 97391 depends on bug 106162, which changed state.

Bug 106162 Summary: UseOpenCL reset to false
https://bugs.documentfoundation.org/show_bug.cgi?id=106162

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106162] UseOpenCL reset to false

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106162

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #1 from m.a.riosv  ---
Because LibO does a test to verify it's safe for use.

In any case software interpreter also gets a goof improvement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106119] LibreOffice Writer label dimension of 1/100" is too coarse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106119

--- Comment #3 from David Chamberlin  ---
This seems to be an internationalization issue with the overall implementation
of the software units of measurement for US and Imperial measurements.  

Inch denominations are typically 1/2, 1/4, 1/8, 1/16 increments for paper
sizes, labels and forms.  1/8 of an inch (0.125) will require 3 decimal places
of precision to accurately represent the units of measure. 1/16 of an inch
(0.0625) will require 4 decimal places.

Although the metric system typically doesn't require more than 2 decimal
places, it presents a usability issue for the US market.

Anywhere where Imperial/US units of measure are used this could present a
reduction in functionality of the product.  This is more of an issue of
precision on values that are derived and repetitive such as in the case of the
label's vertical pitch.  

It would also be an issue for any spacing or margins that can not handle 1/8"
or finer because of the 2 decimal place limitation.   This is essential for the
proper creation of US forms or layout for printing on pre-printed forms.

This issue is a major usability flaw and still exists in the current 5.3
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #23 from Matt K.  ---
(In reply to V Stuart Foote from comment #9)
> No, removing the scaling was correct as it was affecting implementation of
> HiDPI support.
> 
> Believe same effect can/should be achieved with better integration with
> assistive technology "magnifier" tools of the OS.  And that would probably
> be the correct way for the project to go especially as HiDPI gains
> prominence.  
> 
> Believe transient exposure to a magnification tool, rather than scaling the
> whole UI, would have more practical application.

It was affecting implementation of hidpi?  Why not leave it in until you can
actually support hidpi?  In v5.3, hidpi support is terrible and incompatible
with the built in scaling of Windows.  I relied on that setting to adjust the
UI of libreoffice because it's the only application I run that doesn't scale
nicely out of the box with the Windows scaling setting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101646

--- Comment #23 from Matt K.  ---
(In reply to V Stuart Foote from comment #9)
> No, removing the scaling was correct as it was affecting implementation of
> HiDPI support.
> 
> Believe same effect can/should be achieved with better integration with
> assistive technology "magnifier" tools of the OS.  And that would probably
> be the correct way for the project to go especially as HiDPI gains
> prominence.  
> 
> Believe transient exposure to a magnification tool, rather than scaling the
> whole UI, would have more practical application.

It was affecting implementation of hidpi?  Why not leave it in until you can
actually support hidpi?  In v5.3, hidpi support is terrible and incompatible
with the built in scaling of Windows.  I relied on that setting to adjust the
UI of libreoffice because it's the only application I run that doesn't scale
nicely out of the box with the Windows scaling setting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106151] Add a new CELL function for Excel compatibility

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106151

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
I think LibreOffice help information it's clear

https://help.libreoffice.org/index.php?title=Calc/Information_Functions=en-US=WIN=5.4#bm_id3159412
"
Reference (list of options) is the position of the cell to be examined. If
Reference is a range, the cell moves to the top left of the range. If Reference
is missing, LibreOffice Calc uses the position of the cell in which this
formula is located. Microsoft Excel uses the reference of the cell in which the
cursor is positioned.
"

BTW on the top it's possible select the language.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75218] Letter Wizard should be improved to follow locale customs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=75218

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr,
   ||xiscofa...@libreoffice.org

--- Comment #15 from Julien Nabet  ---
Xisco: noticing this commit
https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc85befb7a25a5a70a17c259b4d54a2f17f90123,
it seems that there was still some localization part in 2011 but nothing now
with Python conversion.
Any idea why? (lack of time or due to some decision at these times)
In comparison Apache Openoffice extras/source/templates/wizard/letter contains
a subdirectory lang which itself contains 28 subdirectories representing
languages each containing ott files

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

[Stephan Bergmann]

 configure.ac |   25 +
 1 file changed, 25 insertions(+)

New commits:
commit a8538f0774bd0fabf6012d735d1e86b3ff1c291f
Author: Stephan Bergmann 
Date:   Thu Feb 23 21:34:40 2017 +0100

When using MSVC 2015, require at least SP3

Change-Id: Ia5495f2eedfdbc9e42e06d95657bc01e3904b7e7
Reviewed-on: https://gerrit.libreoffice.org/34594
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index b787dc5..2882aec 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5519,6 +5519,31 @@ else
 fi
 fi
 
+dnl At least MSVC 2015 SP1 is known to sporadically emit warning C4592
+dnl ("implementation limitation" when defining OUStringLiteral variables in
+dnl vcl/source/app/IconThemeInfo.cxx), while SP3 is known good, and it is
+dnl probably a good idea to require that anyway.  A reliable way to check for
+dnl MSVC 2015 SP3 appears to be to check for support of C++17 nested namespace
+dnl definitions (which requires /std:c++latest to be enabled):
+if test "$COM" = MSC -a "$VCVER" = 140; then
+AC_MSG_CHECKING([whether MSVC 2015 compiler $MSVC_CXX is at least SP3])
+save_CXX=$CXX
+save_CXXFLAGS=$CXXFLAGS
+CXX=$MSVC_CXX
+CXXFLAGS="$CXXFLAGS /std:c++latest"
+AC_LANG_PUSH([C++])
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+namespace A::B {}
+]])], [good=yes], [good=no])
+AC_LANG_POP([C++])
+CXX=$save_CXX
+CXXFLAGS=$save_CXXFLAGS
+AC_MSG_RESULT([$good])
+if test "$good" = no; then
+AC_MSG_ERROR([When using MSVC 2015, at least SP3 must be installed])
+fi
+fi
+
 dnl check for GNU C++ compiler version
 if test "$GXX" = "yes"; then
 AC_MSG_CHECKING([the GNU C++ compiler version])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 92164] FILESAVE: excessive number of rows warning saving .xls

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92164

gmarco  changed:

   What|Removed |Added

   Assignee|gmmell...@inwind.it |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #25 from gmarco  ---
(In reply to m.a.riosv from comment #24)
> Because you do it, take a look to the history, top-right.

OK, thanks, but I do not know how and why this happened.
I can not fix the bug, so I think corrected unassign myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106153] Text boxes overlapping the page borders are handled wrong

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106153

--- Comment #3 from Luke  ---
> So my guess is the logic of commit a4dee94afed9ade6ac50237c8d99a6e49d3bebc1
> is wrong, as it breaks the synchronization of the text and shape frame.
> Probably this really has to be handled separately.

The issue of imported TextBoxes not moving with the shape is likely an
implementation bug. See Comment 14 on Bug 84678#c14

"And when you move [our TextBoxes] the text doesn't stay in the Text Box, which
kind of defeats the whole point of Text Boxes."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91070] opposite result in conditioned format in Libreoff CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91070

Julien Nabet  changed:

   What|Removed |Added

   Assignee|gmmell...@inwind.it |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Build Time Query

[Jason Marshall]

Dear Sir/ Madam

I am attempting to build LibreOffice on the following platform:


  *
OS: Lubuntu
  *
Processor: Intel Atom Z530 1.6 GHz
  *
RAM: 1Gb
  *
Disk: 60Gb SSD

I have successfully done the following:


  *
Installed build dependencies
  *
Cloned the repository
  *
Run autogen.sh with the parameters --without-java --without-help 
--without-myspell-dicts
  *
Run make

The actual build triggered by running ‘make' initially ran for approximately 
ten hours, but unfortunately the battery failed on my computer meaning that the 
build presumably was interrupted.  Clearly, the battery failure issue was 
unfortunate, but I am unclear as to the expected build times on the above 
specification of platform.  Would greater than ten hours be expected, as I am 
aware that the hardware specification above is quite low.  In addition, if the 
failed build is simply re-started by running the ‘make' command, will it simply 
pick-up from the point that the failure occurred, or is this not possible?

Thanks

Jason
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106035] Contextual Group Toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106035

--- Comment #11 from andreas_k  ---
Created attachment 131434
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131434=edit
Writer Grouped Layout for 1920px size

First Default Group
Second Table Group
Third Image Group

now it has the functionality of the default notebook_group.ui but I'd like to
add an group for Print, Draw, References, Review and View.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106035] Contextual Group Toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106035

--- Comment #11 from andreas_k  ---
Created attachment 131434
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131434=edit
Writer Grouped Layout for 1920px size

First Default Group
Second Table Group
Third Image Group

now it has the functionality of the default notebook_group.ui but I'd like to
add an group for Print, Draw, References, Review and View.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106119] LibreOffice Writer label dimension of 1/100" is too coarse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106119

David Chamberlin  changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106119] LibreOffice Writer label dimension of 1/100" is too coarse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106119

--- Comment #2 from David Chamberlin  ---
This is issue on 5.2 as well, but may have not been fixed for 5.3, the Vertical
Pitch only allows granularity of 1/100 of an inch.  

This results in an error in alignment on Avery form 5266 in addition to the
form vertical pitch being incorrect at 0.68.  Avery form 5266 is 1/2" top and
bottom margin and 10" of 15 labels at 0.67 per label.  With vertical pitch
set at 0.67 it results in a shift of 0.05" at the end of the sheet, or about
3.6 pts.  If using 0.66 it results in a negative shift of 0.10" at the end of
the sheet, or about 7.2 pts.  The default for the label is being set to 0.68"
vertical pitch, so this results in a 0.15" shift, or about 10.8 pts.  That's a
10 pt line shift by the end of the page, and unacceptable.  Even the 3.6 pts.
error in rounding is unacceptable for label or form work.  

If the vertical pitch is revised to have a higher precision, then the resulting
positions that are used for the frames being at 1/100" would only be off for 2
out of 3 labels, since 3 x 0.67" would be 2.".  But better to increase
precision on the frame's vertical position as well.  1/1000" would reduce the
amount of rounding error, and accommodate for denominators of 8 (i.e. 0.125).

Sample document, please just do File/New/Labels and select Avery (US) and Label
sheet 5266.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94125] Assertion failed in function wizard

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94125

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday or with LO Debian
package 5.2.5, I don't reproduce this anymore.
Let's put this one to WFM.

Oliver: don't hesitate to reopen this tracker if you still reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105582] [META] Function wizard dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105582
Bug 105582 depends on bug 94125, which changed state.

Bug 94125 Summary: Assertion failed in function wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=94125

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106035] Contextual Group Toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106035

--- Comment #10 from andreas_k  ---
Created attachment 131433
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131433=edit
LO grouped toolbar for writer with selected table extension

now also the table view is finished. Screenshot is with 1920px.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 106035] Contextual Group Toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106035

--- Comment #10 from andreas_k  ---
Created attachment 131433
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131433=edit
LO grouped toolbar for writer with selected table extension

now also the table view is finished. Screenshot is with 1920px.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106164] beginning of sentence not capitalized on some text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106164

--- Comment #1 from James Falksen  ---
just discovered it has nothing to do with autotext. I began a sentence with
"we've" and it did not get capitalized.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85994] Images in DOCX are Fliped Horizontally when in Right-to-Left Format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85994

Luke  changed:

   What|Removed |Added

   Priority|medium  |high
   Severity|normal  |major

--- Comment #14 from Luke  ---
Based on the dupes this seems to be an issue affecting many people. Bumping the
priority.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/core/doc/docbm.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 5d6b5bb57bb82a0dc480ca2ea17da5396f598af7
Author: Caolán McNamara 
Date:   Thu Feb 16 11:18:41 2017 +

assert on export of ooo59665-1.sxw to odt

rSecondStart.nContent in this case has no m_pIndexReg

just move on with our lives wrt this sorting

Change-Id: I9642c5d345dabd02f3feea83bc2ffbf3f7adb082
Reviewed-on: https://gerrit.libreoffice.org/34336
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index dccb6ff..0192bbb 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -84,9 +84,11 @@ namespace
 {
 return rFirstStart.nNode < rSecondStart.nNode;
 }
-if (rFirstStart.nContent != 0 || rSecondStart.nContent != 0)
+const sal_Int32 nFirstContent = rFirstStart.nContent.GetIndex();
+const sal_Int32 nSecondContent = rSecondStart.nContent.GetIndex();
+if (nFirstContent != 0 || nSecondContent != 0)
 {
-return rFirstStart.nContent < rSecondStart.nContent;
+return nFirstContent < nSecondContent;
 }
 auto *const pCRFirst (dynamic_cast<::sw::mark::CrossRefBookmark 
const*>(rpFirst.get()));
 auto *const pCRSecond(dynamic_cast<::sw::mark::CrossRefBookmark 
const*>(rpSecond.get()));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 97/a6b18acdb26a98f9f3f627431b8a7e999662a5

[Caolán McNamara]

 97/a6b18acdb26a98f9f3f627431b8a7e999662a5 |1 +
 1 file changed, 1 insertion(+)

New commits:
commit a37f4b105ed5c66e6ac74dcc57244946ed2f46da
Author: Caolán McNamara 
Date:   Thu Feb 23 20:26:47 2017 +

Notes added by 'git notes add'

diff --git a/97/a6b18acdb26a98f9f3f627431b8a7e999662a5 
b/97/a6b18acdb26a98f9f3f627431b8a7e999662a5
new file mode 100644
index 000..8e5c182
--- /dev/null
+++ b/97/a6b18acdb26a98f9f3f627431b8a7e999662a5
@@ -0,0 +1 @@
+ignore: aoo
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106163] Create Table toolbar tool creates wrong number of columns in rtl environment [rtl, gtk3, regression]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106163

--- Comment #2 from Yotam Benshalom  ---
Sorry, I was unclear. This is not related to the directionality of text input,
but rather to the directionality of your desktop environment. In order to set
Gnome3 to right-to-left, use gnome-control-center->languages and put an rtl
language, such as Hebrew, on the top of the list, then restart gnome. You know
that you made it when your menus are in Hebrew, and are aligned to the top
right instead of the top left.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106164] New: beginning of sentence not capitalized on some text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106164

Bug ID: 106164
   Summary: beginning of sentence not capitalized on some text
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jfalk...@yahoo.com

Description:
I have an autotext replacement of "didnt"->"didn't".
When this is used at the beginning of a sentence, it is not capitalized.

Steps to Reproduce:
1. set up such an autotext. turn on "capitalize sentences"
2. type "didnt" at the beginning of a sentence
3.

Actual Results:  
this happens with any replace value containing "'".

Expected Results:
"Didn't"


Reproducible: Always

User Profile Reset: No

Additional Info:
instead got "didn't"


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 100897, which changed state.

Bug 100897 Summary: Crash mailings
https://bugs.documentfoundation.org/show_bug.cgi?id=100897

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100897] Crash mailings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100897

Julien Nabet  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||serval2...@yahoo.fr
 Resolution|--- |INSUFFICIENTDATA

--- Comment #3 from Julien Nabet  ---
No feedback after 6 months, let's put this one to INSUFFICIENT DATA.

Florian: don't hesitate to reopen this tracker if you still reproduce this with
5.3.0 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106157] Nonprinting Characters color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106157

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Eike Rathke]

 sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods |  529 
+-
 1 file changed, 290 insertions(+), 239 deletions(-)

New commits:
commit 029d55f91983e39297bd8b8dbdda16393724f6e2
Author: Eike Rathke 
Date:   Thu Feb 23 13:33:50 2017 +0100

let's try if using the new ROUNDSIG(...,12) helps

... against sporadic tinderbox failures.

Change-Id: I54dab5665575802b5fe9051d215399c3554e8fd8
Reviewed-on: https://gerrit.libreoffice.org/34578
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 

diff --git a/sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods 
b/sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods
index 608ec05..dc39d78 100644
--- a/sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods
+++ b/sc/qa/unit/data/functions/statistical/fods/forecast.ets.add.fods
@@ -1,13 +1,13 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
- 
2016-07-24T08:15:55.36200P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/a7bd6830e26d798068970684754fa23894d9f7c2
+ 
2016-07-24T08:15:55.36200P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/36de6c50684c8241969a2064d30aff41e0bc5d97
  
   
0
0
100804
-   85714
+   85760

 
  view1
@@ -132,7 +132,7 @@
true
1
true
-   lQH+/0dlbmVyaWMgUHJpbnRlcgAAU0dFTlBSVAAWAAMAtgAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9R2VuZXJpYyBQcmludGVyCm9yaWVudGF0aW9uPVBvcnRyYWl0CmNvcGllcz0xCm1hcmdpbmRhanVzdG1lbnQ9MCwwLDAsMApjb2xvcmRlcHRoPTI0CnBzbGV2ZWw9MApwZGZkZXZpY2U9MApjb2xvcmRldmljZT0wClBQRENvbnRleERhdGEKRHVwbGV4Ok5vbmUAUGFnZVNpemU6TGV0dGVyAAASAENPTVBBVF9EVVBMRVhfTU9ERQ8ARHVwbGV4TW9kZTo6T2Zm
+   lQH+/0dlbmVyaWMgUHJpbnRlcgAAU0dFTlBSVAAWAAMAtgAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9R2VuZXJpYyBQcmludGVyCm9yaWVudGF0aW9uPVBvcnRyYWl0CmNvcGllcz0xCm1hcmdpbmRhanVzdG1lbnQ9MCwwLDAsMApjb2xvcmRlcHRoPTI0CnBzbGV2ZWw9MApwZGZkZXZpY2U9MApjb2xvcmRldmljZT0wClBQRENvbnRleERhdGEKUGFnZVNpemU6TGV0dGVyAER1cGxleDpOb25lAAASAENPTVBBVF9EVVBMRVhfTU9ERQ8ARHVwbGV4TW9kZTo6T2Zm
false
0
   
@@ -2838,15 +2838,63 @@


   
-  
-   
-  
-  
   



   
+  
+   
+  
+  
+   
+  
+  
+  
+   
+   
+  
+  
+   
+  
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
   

   
@@ -2942,10 +2990,10 @@

   
   
-   
+   
   
   
-   
+   
   
   

@@ -2967,92 +3015,95 @@
   

   
-  
+  
+   
+  
+  



   
-  
+  



   
-  
+  



   
-  
+  


   
-  
+  





   
-  
+  





   
-  
+  





   
-  
+  


   
   
-  
+  



   
-  
+  

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sd/source

[Katarina Behrens]

 sd/source/ui/sidebar/SlideBackground.cxx |4 +++-
 sd/source/ui/view/drviews7.cxx   |   17 ++---
 2 files changed, 17 insertions(+), 4 deletions(-)

New commits:
commit e28fd26d69553733778a86c84cd74e284a079e15
Author: Katarina Behrens 
Date:   Sun Feb 12 21:56:18 2017 +0100

tdf#99908: Ensure non-empty unique gradient names

for user-defined (!preset) gradients. ODF doesn't cope with nameless
gradients so well ...

Change-Id: I7a4ca32ccf58b22fc55ceeac8778029cd6d5cea3
Reviewed-on: https://gerrit.libreoffice.org/34001
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 
(cherry picked from commit 529162307e9d6191fe43d50597504474b2c1a5ba)
Reviewed-on: https://gerrit.libreoffice.org/34335
Reviewed-by: Michael Stahl 

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 07e43ed..854929f 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -816,7 +816,9 @@ IMPL_LINK_NOARG(SlideBackground, FillColorHdl, 
SvxColorListBox&, void)
 aGradient.SetStartColor(mpFillLB->GetSelectEntryColor());
 aGradient.SetEndColor(mpFillGrad->GetSelectEntryColor());
 
-XFillGradientItem aItem(aGradient);
+// the name doesn't really matter, it'll be converted to unique 
one eventually,
+// but it has to be non-empty
+XFillGradientItem aItem("gradient", aGradient);
 
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_GRADIENT, 
SfxCallMode::RECORD, {  });
 }
 break;
diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index f8570a4..6539152 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -1675,8 +1675,8 @@ void DrawViewShell::GetPageProperties( SfxItemSet  )
 
 case (drawing::FillStyle_GRADIENT):
 {
-const XGradient& xGradient =  static_cast( rPageAttr.GetItem( XATTR_FILLGRADIENT ) 
)->GetGradientValue();
-XFillGradientItem aFillGradientItem( OUString(), xGradient, 
SID_ATTR_PAGE_GRADIENT  );
+const XFillGradientItem *pGradient =  static_cast( rPageAttr.GetItem( XATTR_FILLGRADIENT ) );
+XFillGradientItem aFillGradientItem( pGradient->GetName(), 
pGradient->GetGradientValue(), SID_ATTR_PAGE_GRADIENT );
 rSet.Put( aFillGradientItem );
 }
 break;
@@ -1716,6 +1716,9 @@ void DrawViewShell::SetPageProperties (SfxRequest& rReq)
 if ( ( nSlotId >= SID_ATTR_PAGE_COLOR ) && ( nSlotId <= 
SID_ATTR_PAGE_FILLSTYLE ) )
 {
 SdrPageProperties& rPageProperties = pPage->getSdrPageProperties();
+const SfxItemSet  = rPageProperties.GetItemSet();
+SfxItemSet *pTempSet = aPageItemSet.Clone(false, 
>GetModel()->GetItemPool());
+
 rPageProperties.ClearItem(XATTR_FILLSTYLE);
 rPageProperties.ClearItem(XATTR_FILLGRADIENT);
 rPageProperties.ClearItem(XATTR_FILLHATCH);
@@ -1744,8 +1747,14 @@ void DrawViewShell::SetPageProperties (SfxRequest& rReq)
 case(SID_ATTR_PAGE_GRADIENT):
 {
 XFillGradientItem aGradientItem( static_cast(pArgs->Get( XATTR_FILLGRADIENT )) );
+
+// MigrateItemSet guarantees unique gradient names
+SfxItemSet aMigrateSet( 
mpDrawView->GetModel()->GetItemPool(), XATTR_FILLGRADIENT, XATTR_FILLGRADIENT );
+aMigrateSet.Put( aGradientItem );
+SdrModel::MigrateItemSet( , pTempSet, 
mpDrawView->GetModel() );
+
+rPageProperties.PutItemSet( *pTempSet );
 rPageProperties.PutItem( XFillStyleItem( 
drawing::FillStyle_GRADIENT ) );
-rPageProperties.PutItem( XFillGradientItem( aGradientItem 
) );
 }
 break;
 
@@ -1769,6 +1778,8 @@ void DrawViewShell::SetPageProperties (SfxRequest& rReq)
 break;
 }
 
+delete pTempSet;
+
 rReq.Done();
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106155] LO 5.3.0.3 does not start when opengl activated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106155

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rob...@familiegrosskopf.de
  Component|Base|graphics stack
 Ever confirmed|0   |1

--- Comment #2 from rob...@familiegrosskopf.de ---
Could confirm the buggy behavior with
OpenSUSE 42.1 64bit rpm Linux.
LibreOffice Version: 5.3.0.3
Build-ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU-Threads: 4; BS-Version: Linux 4.1; UI-Render: Standard; VCL: kde4;
Layout-Engine: neu; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

Isn't a special Base-bug. So I will switch it to "graphics stack"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106163] Create Table toolbar tool creates wrong number of columns in rtl environment [rtl, gtk3, regression]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106163

Julien Nabet  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday + gtk3, I don't
reproduce this.

I created a brand new doc + enabled CTL then I typed Ctrl-Shift-D to switch in
RTL mode.

Do you reproduce this with a brand new file?
Did you try to rename your LO directory profile (see
https://wiki.documentfoundation.org/UserProfile#GNU.2FLinux)?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106150] Creation of radio button or check box does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106150

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #2 from rob...@familiegrosskopf.de ---
Isn't this a duplicate of bug 105463?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106155] LO 5.3.0.3 does not start when opengl activated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106155

--- Comment #1 from Friedmann Bruno  ---
To add informations those specific flags can we used to save old profiles

You can save your old configuration by editing the file

~/.config/libreoffice/4/user/registrymodifications.xcu

and set the following values to false

false

false

the values are true if you try to activate opengl

openSUSE Tumbleweed 20170219
Linux 4.9.10-1-default x86_64 GNU/Linux, nvidia: 378.13
Qt: 5.7.1, KDE Frameworks: 5.30.0, Plasma: 5.9.2, kmail2 5.4.2
Libreoffice 5.3.0.3-1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105845] Edit form, save it. Quit Base without initial explicit save - hangs and crashes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105845

Julien Nabet  changed:

   What|Removed |Added

 CC|serval2...@yahoo.fr |

--- Comment #15 from Julien Nabet  ---
I can't help here, I don't even reproduce the pb with master sources updated
yesterday => uncc myself

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106159] Left clicking after right clicking on Comments in Navigator crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106159

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #5 from Caolán McNamara  ---
fixed in master, backports to 5-3 and 5-2 in gerrit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106159] Left clicking after right clicking on Comments in Navigator crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106159

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=58659cbaa8c955b135737bf9d77e4e57813310e5

Resolves: tdf#106159 right click + left click with comments in navigator

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106159] Left clicking after right clicking on Comments in Navigator crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106159

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/uibase/utlui/content.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 58659cbaa8c955b135737bf9d77e4e57813310e5
Author: Caolán McNamara 
Date:   Thu Feb 23 17:15:04 2017 +

Resolves: tdf#106159 right click + left click with comments in navigator

results in a disposed submenu in the menu, we need to flag with bSubPop4
that we have inserted the submenu into the parent menu to not dispose
it

Change-Id: I5b9711c0bba750c11d64dc175efd452f4bc8f4e5

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index c9b9c65..2eb92b3 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1243,6 +1243,7 @@ VclPtr SwContentTree::CreateContextMenu()
 SwContentType* pType = 
static_cast(pEntry->GetUserData());
 if ( (pType->GetType() == ContentTypeId::POSTIT) &&  
(!m_pActiveShell->GetView().GetDocShell()->IsReadOnly()) && ( 
pType->GetMemberCount() > 0) )
 {
+bSubPop4 = true;
 pSubPop4->InsertItem(600, m_sPostItShow );
 pSubPop4->InsertItem(601, m_sPostItHide );
 pSubPop4->InsertItem(602, m_sPostItDelete );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - Makefile.am net/loolnb.cpp net/Socket.hpp net/WebSocketHandler.cpp net/WebSocketHandler.hpp

[Jan Holesovsky]

 Makefile.am  |1 
 net/Socket.hpp   |4 
 net/WebSocketHandler.cpp |   95 +
 net/WebSocketHandler.hpp |  185 ++
 net/loolnb.cpp   |  250 ---
 5 files changed, 289 insertions(+), 246 deletions(-)

New commits:
commit 70a473b081063a04bb22e79e569cb0b19fdf6b88
Author: Jan Holesovsky 
Date:   Thu Feb 23 17:57:59 2017 +0100

nb: Moved the WebSocketHandler to an own header & cpp.

The cpp is there to keep the header free from the POCO dependency.

Change-Id: I2202c4ed403084ec1ed40001e10b1ec4fc226f7b

diff --git a/Makefile.am b/Makefile.am
index e4d4f75..cc5f9f7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -92,6 +92,7 @@ loolwsd_fuzzer_SOURCES = $(loolwsd_sources) \
 
 loolnb_SOURCES = net/loolnb.cpp \
  net/Ssl.cpp \
+ net/WebSocketHandler.cpp \
  common/Log.cpp \
  common/Util.cpp
 
diff --git a/net/Socket.hpp b/net/Socket.hpp
index 6020ca8..08112c5 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -16,9 +16,13 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
 #include 
 
 #include 
diff --git a/net/WebSocketHandler.cpp b/net/WebSocketHandler.cpp
new file mode 100644
index 000..8ad433e
--- /dev/null
+++ b/net/WebSocketHandler.cpp
@@ -0,0 +1,95 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "WebSocketHandler.hpp"
+
+#include 
+#include 
+#include 
+#include 
+
+void WebSocketHandler::handleWebsocketUpgrade()
+{
+int number = 0;
+Poco::MemoryInputStream message(&_socket->_inBuffer[0], 
_socket->_inBuffer.size());
+Poco::Net::HTTPRequest req;
+req.read(message);
+
+// if we succeeded - remove that from our input buffer
+// FIXME: We should check if this is GET or POST. For GET, we only
+// can have a single request (headers only). For POST, we can/should
+// use Poco HTMLForm to parse the post message properly.
+// Otherwise, we should catch exceptions from the previous read/parse
+// and assume we don't have sufficient data, so we wait some more.
+_socket->_inBuffer.clear();
+
+Poco::StringTokenizer tokens(req.getURI(), "/?");
+if (tokens.count() == 4)
+{
+std::string subpool = tokens[2];
+number = std::stoi(tokens[3]);
+
+// complex algorithmic core:
+number = number + 1;
+
+std::string numberString = std::to_string(number);
+std::ostringstream oss;
+oss << "HTTP/1.1 200 OK\r\n"
+<< "Date: Once, Upon a time GMT\r\n" // Mon, 27 Jul 2009 12:28:53 
GMT
+<< "Server: madeup string (Linux)\r\n"
+<< "Content-Length: " << numberString.size() << "\r\n"
+<< "Content-Type: text/plain\r\n"
+<< "Connection: Closed\r\n"
+<< "\r\n"
+<< numberString;
+;
+std::string str = oss.str();
+_socket->_outBuffer.insert(_socket->_outBuffer.end(), str.begin(), 
str.end());
+}
+else if (tokens.count() == 2 && tokens[1] == "ws")
+{ // create our websocket goodness ...
+_wsVersion = std::stoi(req.get("Sec-WebSocket-Version", "13"));
+_wsKey = req.get("Sec-WebSocket-Key", "");
+_wsProtocol = req.get("Sec-WebSocket-Protocol", "chat");
+std::cerr << "version " << _wsVersion << " key '" << _wsKey << "\n";
+// FIXME: other sanity checks ...
+
+std::ostringstream oss;
+oss << "HTTP/1.1 101 Switching Protocols\r\n"
+<< "Upgrade: websocket\r\n"
+<< "Connection: Upgrade\r\n"
+<< "Sec-Websocket-Accept: " << computeAccept(_wsKey) << "\r\n"
+<< "\r\n";
+std::string str = oss.str();
+_socket->_outBuffer.insert(_socket->_outBuffer.end(), str.begin(), 
str.end());
+_wsState = WEBSOCKET;
+}
+else
+std::cerr << " unknown tokens " << tokens.count() << std::endl;
+}
+
+namespace {
+
+/// To make the protected 'computeAccept' accessible.
+class PublicComputeAccept : public Poco::Net::WebSocket {
+public:
+static std::string doComputeAccept(const std::string )
+{
+return computeAccept(key);
+}
+};
+
+}
+
+std::string WebSocketHandler::computeAccept(const std::string )
+{
+return PublicComputeAccept::doComputeAccept(key);
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
new file mode 100644
index 000..286ac53
--- /dev/null
+++ b/net/WebSocketHandler.hpp
@@ -0,0 +1,185 @@
+/* 

[Libreoffice-bugs] [Bug 101244] doc(x) protected areas – Cursor cannot be disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101244

Justin L  changed:

   What|Removed |Added

 Blocks||66398


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=66398
[Bug 66398] FILESAVE: DOCX export document: 'Restrict Editing' is lost on
roundtrip (because not imported)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66398] FILESAVE: DOCX export document: 'Restrict Editing' is lost on roundtrip (because not imported)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66398

Justin L  changed:

   What|Removed |Added

 Depends on||101244
Summary|FILESAVE: DOCX export   |FILESAVE: DOCX export
   |document with 'Restrict |document: 'Restrict
   |Editing' is not protected   |Editing' is lost on
   |anymore |roundtrip (because not
   ||imported)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101244
[Bug 101244] doc(x) protected areas – Cursor cannot be disabled
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100158] grouping processes doesn't work in gnome-shell/wayland

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100158

--- Comment #3 from Caolán McNamara  ---
https://bugzilla.gnome.org/show_bug.cgi?id=779143 for my proposed change to let
me at the property we need via gtk

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

sha1sum problem

[Necdet Yücel]

Hi,

Since SHA1 has been broken in practice [1] maybe we should consider to move
to safer alteratives, such as SHA-256.

Best regards

[1] http://shattered.it/

---
Necdet Yücel
http://about.me/nyucel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |   16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)

New commits:
commit 4c9383e1354be0954c5f7cf8906f334ae079baeb
Author: Caolán McNamara 
Date:   Thu Feb 23 11:01:00 2017 +

ofz: don't read data that isn't there

Change-Id: I7fdcb78bde8f650c1a57d34177d8993a6d8a0a2f
(cherry picked from commit ee619fb344c7e8f491e09bd256df7f8567af9bef)

improve scoping

Change-Id: Ic79d46da4e322a0f52981c3a3df65f7f0294fdd8
(cherry picked from commit 840ad0a88045021c58644404a099a3678a371020)

make this a little clearer

no logic change intended

Change-Id: Ibfc46d0aba9e220be54270734e0cdfbc123be9a5
(cherry picked from commit 46b1b5dd2a5368663fd56434160fa126f1a54d84)
Reviewed-on: https://gerrit.libreoffice.org/34573
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index c5438d1..f744baf 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -788,7 +788,7 @@ sal_uLong TIFFReader::GetBits( const sal_uInt8 * pSrc, 
sal_uLong nBitsPos, sal_u
 
 bool TIFFReader::ConvertScanline(sal_Int32 nY)
 {
-sal_uInt32  nRed, nGreen, nBlue, ns, nVal, nByteCount;
+sal_uInt32  nRed, nGreen, nBlue, ns, nVal;
 sal_uInt8   nByteVal;
 
 if ( nDstBitsPerPixel == 24 )
@@ -999,11 +999,18 @@ bool TIFFReader::ConvertScanline(sal_Int32 nY)
 
 case 1 :
 {
+sal_uInt32 nByteCount = nImageWidth >> 3;
+
+sal_uInt32 nBytesNeeded = nByteCount;
+if (nImageWidth & 7)
+++nBytesNeeded;
+if (pt + nBytesNeeded > ptend)
+return false;
+
 if ( bByteSwap )
 {
 sal_Int32 nx = 0;
-nByteCount = ( nImageWidth >> 3 ) + 1;
-while ( --nByteCount )
+while (nByteCount--)
 {
 nByteVal = *pt++;
 pAcc->SetPixelIndex( nY, nx++, nByteVal & 1 );
@@ -1035,8 +1042,7 @@ bool TIFFReader::ConvertScanline(sal_Int32 nY)
 else
 {
 sal_Int32 nx = 7;
-nByteCount = ( nImageWidth >> 3 ) + 1;
-while ( --nByteCount )
+while (nByteCount--)
 {
 nByteVal = *pt++;
 pAcc->SetPixelIndex( nY, nx, nByteVal & 1 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)

New commits:
commit 2a0b6d152839e4b4cb26abbdabbc2ec77528f365
Author: Caolán McNamara 
Date:   Thu Feb 23 12:02:06 2017 +

Resolves: ofz#668 check for massive row lengths before trying to allocate 
them

Change-Id: I7b3f1abf5dcf457e8ff7d04a7cf48ffee70817a2
Reviewed-on: https://gerrit.libreoffice.org/34575
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index 0ef0081..c5438d1 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -68,7 +68,7 @@ private:
 sal_uLong   nSubFile;
 sal_Int32   nImageWidth;// picture width in 
pixels
 sal_Int32   nImageLength;   // picture height in 
pixels
-sal_uLong   nBitsPerSample; // bits per pixel per 
layer
+sal_uInt32  nBitsPerSample; // bits per pixel per 
layer
 sal_uLong   nCompression;   // kind of compression
 sal_uLong   nPhotometricInterpretation;
 sal_uLong   nThresholding;
@@ -78,7 +78,7 @@ private:
 sal_uLong*  pStripOffsets;  // field of offsets to 
the Bitmap-Data-"Strips"
 sal_uLong   nNumStripOffsets;   // size of the field 
above
 sal_uLong   nOrientation;
-sal_uLong   nSamplesPerPixel;   // number of layers
+sal_uInt32  nSamplesPerPixel;   // number of layers
 sal_uLong   nRowsPerStrip;  // if it's not 
compressed: number of rows per Strip
 sal_uLong*  pStripByteCounts;   // if compressed (in a 
certain way): size of the strips
 sal_uLong   nNumStripByteCounts;// number of entries 
in the field above
@@ -94,9 +94,9 @@ private:
 sal_uLong*  pColorMap;  // color palette
 sal_uLong   nNumColors; // number of colors 
within the color palette
 
-sal_uLong   nPlanes;// number of layers 
within the Tiff file
+sal_uInt32  nPlanes;// number of layers 
within the Tiff file
 sal_uLong   nStripsPerPlane;// number of Strips 
per layer
-sal_uLong   nBytesPerRow;   // Bytes per line per 
Layer in the Tiff file ( uncompressed )
+sal_uInt32  nBytesPerRow;   // Bytes per line per 
Layer in the Tiff file ( uncompressed )
 sal_uInt8*  pMap[ 4 ];  // temporary Scanline
 
 
@@ -1371,8 +1371,18 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 
 if (bStatus)
 {
-nBytesPerRow = ( nImageWidth * nSamplesPerPixel / 
nPlanes * nBitsPerSample + 7 ) >> 3;
+sal_uInt64 nRowSize = 
(static_cast(nImageWidth) * nSamplesPerPixel / nPlanes * 
nBitsPerSample + 7) >> 3;
+if (nRowSize > SAL_MAX_INT32 / SAL_N_ELEMENTS(pMap))
+{
+SAL_WARN("filter.tiff", "Ludicrous row size of: " 
<< nRowSize << " required");
+bStatus = false;
+}
+else
+nBytesPerRow = nRowSize;
+}
 
+if (bStatus)
+{
 for (sal_uInt8*& j : pMap)
 {
 try
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmlsecurity/source

[Samuel Mehrbrodt]

 xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx |3 ---
 xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx  |3 ---
 2 files changed, 6 deletions(-)

New commits:
commit baee96e04a3e6b717a23b4e8744ab781ba60a4ce
Author: Samuel Mehrbrodt 
Date:   Thu Feb 23 16:42:09 2017 +

Remove commented out code

Change-Id: I1da07c52380e543b80c7725a8420c1927743257d
Reviewed-on: https://gerrit.libreoffice.org/34587
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx
index 804e69b..b058fc6 100644
--- a/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx
@@ -329,9 +329,6 @@ Reference< XInterface > SAL_CALL 
XMLEncryption_NssImpl::impl_createInstance( con
 }
 
 Reference< XSingleServiceFactory > XMLEncryption_NssImpl::impl_createFactory( 
const Reference< XMultiServiceFactory >& aServiceManager ) {
-//Reference< XSingleServiceFactory > xFactory ;
-//xFactory = ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName , impl_createInstance , 
impl_getSupportedServiceNames ) ;
-//return xFactory ;
 return ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName() , impl_createInstance , 
impl_getSupportedServiceNames() ) ;
 }
 
diff --git a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
index 3271b54..39aa6e9 100644
--- a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
@@ -301,9 +301,6 @@ Reference< XInterface > SAL_CALL 
XMLSignature_NssImpl::impl_createInstance( cons
 }
 
 Reference< XSingleServiceFactory > XMLSignature_NssImpl::impl_createFactory( 
const Reference< XMultiServiceFactory >& aServiceManager ) {
-//Reference< XSingleServiceFactory > xFactory ;
-//xFactory = ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName , impl_createInstance , 
impl_getSupportedServiceNames ) ;
-//return xFactory ;
 return ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName() , impl_createInstance , 
impl_getSupportedServiceNames() ) ;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - filter/source

[Caolán McNamara]

 filter/source/graphicfilter/itiff/itiff.cxx |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)

New commits:
commit 86efcdb9279a72408063653f1e99855bf0ca00c4
Author: Caolán McNamara 
Date:   Thu Feb 23 12:02:06 2017 +

Resolves: ofz#668 check for massive row lengths before trying to allocate 
them

Change-Id: I7b3f1abf5dcf457e8ff7d04a7cf48ffee70817a2
Reviewed-on: https://gerrit.libreoffice.org/34574
Reviewed-by: Markus Mohrhard 
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/filter/source/graphicfilter/itiff/itiff.cxx 
b/filter/source/graphicfilter/itiff/itiff.cxx
index df21268..96c7f0c 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -67,7 +67,7 @@ private:
 sal_uLong   nSubFile;
 sal_Int32   nImageWidth;// picture width in 
pixels
 sal_Int32   nImageLength;   // picture height in 
pixels
-sal_uLong   nBitsPerSample; // bits per pixel per 
layer
+sal_uInt32  nBitsPerSample; // bits per pixel per 
layer
 sal_uLong   nCompression;   // kind of compression
 sal_uLong   nPhotometricInterpretation;
 sal_uLong   nThresholding;
@@ -77,7 +77,7 @@ private:
 sal_uLong*  pStripOffsets;  // field of offsets to 
the Bitmap-Data-"Strips"
 sal_uLong   nNumStripOffsets;   // size of the field 
above
 sal_uLong   nOrientation;
-sal_uLong   nSamplesPerPixel;   // number of layers
+sal_uInt32  nSamplesPerPixel;   // number of layers
 sal_uLong   nRowsPerStrip;  // if it's not 
compressed: number of rows per Strip
 sal_uLong*  pStripByteCounts;   // if compressed (in a 
certain way): size of the strips
 sal_uLong   nNumStripByteCounts;// number of entries 
in the field above
@@ -93,9 +93,9 @@ private:
 sal_uLong*  pColorMap;  // color palette
 sal_uLong   nNumColors; // number of colors 
within the color palette
 
-sal_uLong   nPlanes;// number of layers 
within the Tiff file
+sal_uInt32  nPlanes;// number of layers 
within the Tiff file
 sal_uLong   nStripsPerPlane;// number of Strips 
per layer
-sal_uLong   nBytesPerRow;   // Bytes per line per 
Layer in the Tiff file ( uncompressed )
+sal_uInt32  nBytesPerRow;   // Bytes per line per 
Layer in the Tiff file ( uncompressed )
 sal_uInt8*  pMap[ 4 ];  // temporary Scanline
 
 
@@ -1368,8 +1368,18 @@ bool TIFFReader::ReadTIFF(SvStream & rTIFF, Graphic & 
rGraphic )
 
 if (bStatus)
 {
-nBytesPerRow = ( nImageWidth * nSamplesPerPixel / 
nPlanes * nBitsPerSample + 7 ) >> 3;
+sal_uInt64 nRowSize = 
(static_cast(nImageWidth) * nSamplesPerPixel / nPlanes * 
nBitsPerSample + 7) >> 3;
+if (nRowSize > SAL_MAX_INT32 / SAL_N_ELEMENTS(pMap))
+{
+SAL_WARN("filter.tiff", "Ludicrous row size of: " 
<< nRowSize << " required");
+bStatus = false;
+}
+else
+nBytesPerRow = nRowSize;
+}
 
+if (bStatus)
+{
 for (sal_uInt8*& j : pMap)
 {
 try
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 53976] Calc FILESAVE: File loses it' s VBA functionality after saving in latest version(after 3.4)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=53976

--- Comment #14 from Justin L  ---
Confirmed still a problem in 5.4.  (The button works again somewhere between
late 5.2 or early 5.3.)
Steps:
1. Open document and verify that the button opens a form.
2. Save document.
3. Open document.  Error occurs when the button is pressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmlsecurity/source

[Samuel Mehrbrodt]

 xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 3788d6a264b8716fde4a73f2a34bb9b24e1f57d0
Author: Samuel Mehrbrodt 
Date:   Thu Feb 23 16:34:03 2017 +

Remove commented out code

Change-Id: I36e5f4072ac52a3073d13e4ad5185ead7611e722
Reviewed-on: https://gerrit.libreoffice.org/34586
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx
index 6cf9085..825fdb7 100644
--- a/xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/xmlsecuritycontext_nssimpl.cxx
@@ -154,9 +154,6 @@ Reference< XInterface > SAL_CALL 
XMLSecurityContext_NssImpl::impl_createInstance
 }
 
 Reference< XSingleServiceFactory > 
XMLSecurityContext_NssImpl::impl_createFactory( const Reference< 
XMultiServiceFactory >& aServiceManager ) {
-//Reference< XSingleServiceFactory > xFactory ;
-//xFactory = ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName , impl_createInstance , 
impl_getSupportedServiceNames ) ;
-//return xFactory ;
 return ::cppu::createSingleFactory( aServiceManager , 
impl_getImplementationName() , impl_createInstance , 
impl_getSupportedServiceNames() ) ;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

[Stephan Bergmann]

 sal/osl/unx/file_volume.cxx |  114 ++--
 1 file changed, 6 insertions(+), 108 deletions(-)

New commits:
commit 35f3759e5ca44bc7bc8f275833e1be54494c5ff3
Author: Stephan Bergmann 
Date:   Thu Feb 23 17:27:08 2017 +0100

There's no way to create an oslVolumeDeviceHandle for unx

...so the functions operating on them can all just return osl_File_E_INVAL. 
(The
way to create an oslVolumeDeviceHandle is via osl_getVolumeInformation 
storing
it into oslVolumeInfo.pDeviceHandle.  But the unx implementation of
osl_getVolumeInformation never sets that, so it'll stay at the null value 
that
callers must initialize it to.)

Change-Id: Ibabd89e8f9de0892a0e815d30b6397f869e7df70

diff --git a/sal/osl/unx/file_volume.cxx b/sal/osl/unx/file_volume.cxx
index 5462368..6db0beb 100644
--- a/sal/osl/unx/file_volume.cxx
+++ b/sal/osl/unx/file_volume.cxx
@@ -19,8 +19,6 @@
 
 #include 
 
-#include 
-
 #include "osl/file.h"
 
 #include "osl/diagnose.h"
@@ -79,21 +77,8 @@
  *   ToDo
  *
  *   - Fix: check for corresponding struct sizes in exported functions
- *   - check size/use of oslVolumeDeviceHandle
  *   - check size/use of oslVolumeInfo
  ***/
-/**
- *
- *  Data Type Definition
- *
- 
**/
-
-struct oslVolumeDeviceHandleImpl
-{
-sal_Char pszMountPoint[PATH_MAX];
-sal_Char ident[4];
-sal_uInt32   RefCount;
-};
 
 /**
  *
@@ -332,106 +317,19 @@ static oslFileError osl_psz_getVolumeInformation (
 return osl_File_E_None;
 }
 
-/**
- *
- *  GENERIC FLOPPY FUNCTIONS
- *
- */
-
-/*
- * osl_getVolumeDeviceMountPath
- /
-static rtl_uString* oslMakeUStrFromPsz(const sal_Char* pszStr, rtl_uString** 
ustrValid)
-{
-rtl_string2UString(
-ustrValid,
-pszStr,
-rtl_str_getLength( pszStr ),
-osl_getThreadTextEncoding(),
-OUSTRING_TO_OSTRING_CVTFLAGS );
-OSL_ASSERT(*ustrValid != nullptr);
-
-return *ustrValid;
-}
-
-oslFileError osl_getVolumeDeviceMountPath( oslVolumeDeviceHandle Handle, 
rtl_uString **pstrPath )
+oslFileError osl_getVolumeDeviceMountPath( oslVolumeDeviceHandle, rtl_uString 
** )
 {
-oslVolumeDeviceHandleImpl* pItem = 
static_cast(Handle);
-sal_Char Buffer[RTL_CONSTASCII_LENGTH("file://") + PATH_MAX];
-
-Buffer[0] = '\0';
-
-if ( pItem == nullptr || pstrPath == nullptr )
-{
-return osl_File_E_INVAL;
-}
-
-if ( pItem->ident[0] != 'O' || pItem->ident[1] != 'V' || pItem->ident[2] 
!= 'D' || pItem->ident[3] != 'H' )
-{
-return osl_File_E_INVAL;
-}
-
-int n = snprintf(Buffer, sizeof(Buffer), "file://%s", 
pItem->pszMountPoint);
-assert(n >= 0 && unsigned(n) < sizeof(Buffer)); (void) n;
-
-#ifdef DEBUG_OSL_FILE
-fprintf(stderr,"Mount Point is: '%s'\n",Buffer);
-#endif
-
-oslMakeUStrFromPsz(Buffer, pstrPath);
-
-return osl_File_E_None;
+return osl_File_E_INVAL;
 }
 
-/*
- * osl_acquireVolumeDeviceHandle
- /
-
-oslFileError SAL_CALL osl_acquireVolumeDeviceHandle( oslVolumeDeviceHandle 
Handle )
+oslFileError osl_acquireVolumeDeviceHandle( oslVolumeDeviceHandle )
 {
-oslVolumeDeviceHandleImpl* pItem 
=static_cast(Handle);
-
-if ( pItem == nullptr )
-{
-return osl_File_E_INVAL;
-}
-
-if ( pItem->ident[0] != 'O' || pItem->ident[1] != 'V' || pItem->ident[2] 
!= 'D' || pItem->ident[3] != 'H' )
-{
-return osl_File_E_INVAL;
-}
-
-++pItem->RefCount;
-
-return osl_File_E_None;
+return osl_File_E_INVAL;
 }
 
-/*
- * osl_releaseVolumeDeviceHandle
- /
-
-oslFileError osl_releaseVolumeDeviceHandle( oslVolumeDeviceHandle Handle )
+oslFileError osl_releaseVolumeDeviceHandle( oslVolumeDeviceHandle )
 {
-oslVolumeDeviceHandleImpl* pItem 
=static_cast(Handle);
-
-if ( pItem == nullptr )
-{
-return osl_File_E_INVAL;
-}
-
-if ( pItem->ident[0] != 'O' || pItem->ident[1] != 'V' || pItem->ident[2] 
!= 'D' || pItem->ident[3] != 'H' )
-{
-return osl_File_E_INVAL;
-}
-
---pItem->RefCount;
-
-if ( pItem->RefCount == 0 )
-{
-rtl_freeMemory(pItem);
-}
-
-return osl_File_E_None;
+return osl_File_E_INVAL;
 }
 

[Libreoffice-bugs] [Bug 106163] Create Table toolbar tool creates wrong number of columns in rtl environment [rtl, gtk3, regression]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106163

Yotam Benshalom  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106163] New: Create Table toolbar tool creates wrong number of columns in rtl environment [rtl, gtk3, regression]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106163

Bug ID: 106163
   Summary: Create Table toolbar tool creates wrong number of
columns in rtl environment [rtl, gtk3, regression]
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bensha...@gmail.com

Create table toolbar tool creates wrong number of columns in rtl environment.
More specifically, the number of columns created is the difference between the
requested number of columns and 11.

Example:
In rtl environment with gtk3, press the Create Table tool on the toolbar and
drag the mouse to create a table with 3 columns. You will get a table with 3
columns instead.

This is a regression of the 5.3 series. It exists in 5.3.1.1
(1:5.3.1~rc1-0ubuntu1~zesty0).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105845] Edit form, save it. Quit Base without initial explicit save - hangs and crashes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105845

--- Comment #14 from t...@tim-passingham.co.uk ---
Seems OK in Version: 5.3.1.1
Build ID: 1:5.3.1~rc1-0ubuntu1~yakkety0

Has something been fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68747] Libreoffice hangs when opening that xlsx file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68747

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|Libreoffice 4.0 crash when  |Libreoffice hangs when
   |opening that xlsx file  |opening that xlsx file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105845] Edit form, save it. Quit Base without initial explicit save - hangs and crashes.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105845

--- Comment #13 from t...@tim-passingham.co.uk ---
Seems OK in Version: 5.3.1.1
Build ID: 1:5.3.1~rc1-0ubuntu1~yakkety0

Has something been fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97391] [META] Tracker bug for OpenCL and "Software Interpreter" issues in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97391

Aron Budea  changed:

   What|Removed |Added

 Depends on||106162


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106162
[Bug 106162] UseOpenCL reset to false
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106162] UseOpenCL reset to false

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106162

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu
 Blocks||97391


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97391
[Bug 97391] [META] Tracker bug for OpenCL and "Software Interpreter" issues in
Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105463] Checkbox in Base form corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105463

--- Comment #19 from t...@tim-passingham.co.uk ---
Just to say this is still an issue for me in Version: 5.3.1.1
Build ID: 1:5.3.1~rc1-0ubuntu1~yakkety0

I've set all my checkboxes to 3D, which seems to help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105857] MultiSelection list box not working with Dropdown > Yes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105857

--- Comment #4 from t...@tim-passingham.co.uk ---
Just to say this is still an issue in Version: 5.3.1.1
Build ID: 1:5.3.1~rc1-0ubuntu1~yakkety0 

I've changed my listboxes to single selection for now, which means I've lost
functionality, but it's the best compromise for me for the time being.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97898] CMIS: "generic input / output error" when attempting to access Google Drive

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97898

pva  changed:

   What|Removed |Added

 CC||peter.vol...@gmail.com

--- Comment #27 from pva  ---
Guys, is there any way to debug this problem somehow? The message itself it not
usefull at all, but there are no errors in console. I've tried to rebuild
libreoffice on gentoo with different options: +java, with/without extensions,
but problem still persists. This is 5.3.0.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106159] Left clicking after right clicking on Comments in Navigator crashes LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106159

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
   Priority|medium  |highest
 CC||caol...@redhat.com
   Severity|normal  |critical

--- Comment #3 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2016-09-14 09:04:28 (GMT)
committer   Caolán McNamara 2016-09-14 09:27:00
(GMT)
commit  fc6744603ab8bb5a00c4f97435b5e509bdeaeb94 (patch)
tree6f46eb2096cb6856c918186663755a2f7212325e
parent  ecc29bf323a83b0379ffed31057c8ab409e0d2d2 (diff)
Resolves: tdf#101859 dispose unused popupmenu before dtor

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101652] Allow to disable readonly infobar via configuration

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101652

--- Comment #8 from christian.rufe...@actelion.com ---
I open the documents with UNO API in read-only mode, so I assume this should
work. Nevertheless, I will need to perform a test on this. I'll come back with
feedback later.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source writerfilter/source

[Michael Stahl]

 sw/qa/extras/rtfimport/data/hexcrlf.rtf|4 
 sw/qa/extras/rtfimport/rtfimport.cxx   |   10 ++
 sw/source/core/unocore/unotext.cxx |2 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   14 +-
 4 files changed, 29 insertions(+), 1 deletion(-)

New commits:
commit f1bd815f60c78495259ae19ea68eacdb8b43a9e8
Author: Michael Stahl 
Date:   Thu Feb 23 16:07:18 2017 +0100

sw: fix cursor backup in SwXText::insertTextPortion()

If the inserted string contains "\r", such as when importing
lp556169-2.rtf before the previous fix, the given cursor has one of its
positions mangled because its nNode will be on the new node, but the
nContent that is restored here is on the old node.

The invalid cursor causes an assert in the subsequent SetPropertyValues.

Change-Id: I73a2e6ecd02ccf75f7b9ffd89d90ae1e3a93ceb2

diff --git a/sw/source/core/unocore/unotext.cxx 
b/sw/source/core/unocore/unotext.cxx
index f32836a..78cce48 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -1352,10 +1352,12 @@ SwXText::insertTextPortion(
 
 if (!rText.isEmpty())
 {
+SwNodeIndex const nodeIndex(rCursor.GetPoint()->nNode, -1);
 const sal_Int32 nContentPos = rCursor.GetPoint()->nContent.GetIndex();
 SwUnoCursorHelper::DocInsertStringSplitCR(
 *m_pImpl->m_pDoc, rCursor, rText, false);
 SwUnoCursorHelper::SelectPam(rCursor, true);
+rCursor.GetPoint()->nNode = SwNodeIndex(nodeIndex, +1);
 rCursor.GetPoint()->nContent = nContentPos;
 }
 
commit 10e733908038407791f9c14af2a86417cc4a653c
Author: Michael Stahl 
Date:   Thu Feb 23 15:33:55 2017 +0100

writerfilter: RTF import: hex-escaped \r and \n create paragraph break

... in Word 2010, while the spec doesn't say what they do.
So just handle \'0d and \'0a like \par.

This fixes an assert failure on importing lp556169-2.rtf, where
insertTextPortion was called with a string containing "\r", which split
the paragraph and that messed up the SwPaM.

Change-Id: Iee8b5b47e15d18232de841adfbc9c6498727c384

diff --git a/sw/qa/extras/rtfimport/data/hexcrlf.rtf 
b/sw/qa/extras/rtfimport/data/hexcrlf.rtf
new file mode 100644
index 000..7c7ed1a
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/hexcrlf.rtf
@@ -0,0 +1,4 @@
+{\rtf1
+foo\'0dba
+r\'0abaz\'0d\'0aquux
+\par }
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 855b2da..64a6dc9 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1101,6 +1101,16 @@ DECLARE_RTFIMPORT_TEST(testFdo59419, "fdo59419.rtf")
 CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
 }
 
+DECLARE_RTFIMPORT_TEST(testHexCRLF, "hexcrlf.rtf")
+{
+// hex-escaped \r and \n should create a paragraph break
+getParagraph(1, "foo");
+getParagraph(2, "bar");
+getParagraph(3, "baz");
+getParagraph(4, "");
+getParagraph(5, "quux");
+}
+
 DECLARE_RTFIMPORT_TEST(testFdo58076_2, "fdo58076-2.rtf")
 {
 // Position of the picture wasn't correct.
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index a42b528..ef5e086 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1120,7 +1120,19 @@ RTFError RTFDocumentImpl::resolveChars(char ch)
 if (m_aStates.top().nInternalState == RTFInternalState::HEX && 
m_aStates.top().eDestination != Destination::LEVELNUMBERS)
 {
 if (!bSkipped)
-m_aHexBuffer.append(ch);
+{
+// note: apparently \'0d\'0a is interpreted as 2 breaks, not 1
+if (m_aStates.top().eDestination != Destination::DOCCOMM
+&& (ch == '\r' || ch == '\n'))
+{
+checkUnicode(/*bUnicode =*/ false, /*bHex =*/ true);
+dispatchSymbol(RTF_PAR);
+}
+else
+{
+m_aHexBuffer.append(ch);
+}
+}
 return RTFError::OK;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 67254] VBAProject Macros: Apostrophe (comment indicator) does not cancel underscore (split line) at the end of the line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67254

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67254] VBAProject Macros: Apostrophe (comment indicator) does not cancel underscore (split line) at the end of the line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67254

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #8 from Justin L  ---
Created attachment 131432
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131432=edit
extendedComment.xls: button macro with 'comment _

(In reply to Cor Nouws from comment #1)
Here is an .xls document containing this macro...

Private Sub CommandButton1_Click()
 MsgBox " test 67254" ', Collate:= _
End Sub

It fails to compile/execute also on MSOffice 2003/2007/2013, so it seems like
Microsoft ALSO evaluates an ending _ regardless of whether it is part of a
comment or not.

Closing this old issue.  Please provide an example document that works in
MSExcel, but fails in LO if you reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106154] Extremely slow basic operations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106154

--- Comment #2 from Albert Wiedemann  ---
The same ist true for LibreOffice Draw, especially entering and leaving a text
field takes several seconds (did not take any visual time in 5.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs