[Libreoffice-bugs] [Bug 97898] CMIS: "generic input / output error" when attempting to access Google Drive

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97898

--- Comment #28 from pva  ---
Ok, I've build libreoffice with debug enabled, but all I noticed is this:

info:ucb.ucp.cmis:15923:1:ucb/source/ucp/cmis/cmis_content.cxx:584: Unexpected
libcmis exception: Object not found
...
warn:uui:15923:1:uui/source/iahndl.cxx:246: replaceMessageWithArguments: No
arguments passed!

Is there any way to ask libreoffice report what was called in libcmis?
Currently I've asked for help at libcmis issue tracker as well:
https://github.com/tdf/libcmis/issues/13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106174] FILEOPEN: Paragraph alignment inherited from parent style not loaded from docx file

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106174

--- Comment #8 from Aron Budea  ---
In the exported files the difference is in styles.xml. The one that is imported
incorrectly has this attribute for center/right aligned paragraph styles (two
of each):


-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104193] Writer' s AutoCorrect Word Completion list is deleted during a LibO version upgrade

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104193

--- Comment #6 from tommy27  ---
any news my fried?
in the meantime 5.2.5 and 5.3.0 have been released.
please retest.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103156] Some AutoCorrect Replacements for German (Switzerland, Liechtenstein) are Wrong

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103156

tommy27  changed:

   What|Removed |Added

   Keywords||easyHack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106183] New: filenames (mostly) not displayed in title bar - title bar empty for all LO applcations

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106183

Bug ID: 106183
   Summary: filenames (mostly) not displayed in title bar - title
bar empty for all LO applcations
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephan.ob...@onlinehome.de

Description:
Only when having one document opened via fime manager the doc, title is
displayed in title bar. 
As far as doc is opened directly from LO or if more than one doc is open, title
bar is empty and does not display any file name.
Makes work a bit difficult when several docs (e.g. all LO Writer) are open and
I have to switch between them.

Steps to Reproduce:
1. just open LO and afterwards one, two, etc. files

Actual Results:  
nothing displayed on top

Expected Results:
expected to get the file names displayed on top to see what doc is open in the
actual window


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106181] FILESAVE: Check boxes get lost when saving as .XLSX

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106181

tommy27  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|5.2.5.1 release |4.0.1.2 release
Summary|FILESAVE: Check boxes get   |FILESAVE: Check boxes get
   |lost when saving in .XLSX   |lost when saving as .XLSX
   |format  |
 Ever confirmed|0   |1

--- Comment #4 from tommy27  ---
I confirm bug in LibO 5.2.5.1 and 5.4.0.0.alpha0+ (*)

the issue is not new and is already present in LibO 4.0.1.2 as well.
I did not test earlier releases.

status NEW



(*) Build ID: 5bb5a9dacb84ec14f7148a5a5d9ba38b7e9f1039
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-02-17_23:30:45
Locale: it-IT (it_IT); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61096] FILESAVE: XHTML export of doc with image broken

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=61096

--- Comment #7 from Greg Ross  ---
Two updates to the above code, use correct variable for the href name and use
ends-with() to ensure not to catches files like "name.jpeg.txt":



data:image/jpg;base64,


data:image/svg;base64,


data:image/png;base64,



-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61096] FILESAVE: XHTML export of doc with image broken

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=61096

--- Comment #6 from Greg Ross  ---
I did some digging, this appears to be an issue in
"filter/source/xslt/odf2xhtml/export/common/body.xsl", see line 335:

data:image/*;base64,

When the ODF is converted to XHTML it sets *all* image files to the "image:/*"
media type instead of specifying what kind of image it is.

A wildcard subtype is not a supported mime type and is therefore completely
dependent on the browser being used.

Instead I think line 335 should be replace with (may contain errors, first
attempt at writing XSLT):



data:image/jpg;base64,


data:image/svg;base64,


data:image/png;base64,



-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

2017-02-24 Thread scan-admin 

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

8 new defect(s) introduced to LibreOffice found with Coverity Scan.
30 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1401475:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 342 in 
std::unique_ptr::reset(sd::slidesorter::view::SlideSorterView::DrawLock
 *)()



*** CID 1401475:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 342 in 
std::unique_ptr::reset(sd::slidesorter::view::SlideSorterView::DrawLock
 *)()
336*
337* @param __p  The new pointer to store.
338*
339* The deleter will be invoked if a pointer is already owned.
340*/
341   void
>>> CID 1401475:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected() which usually calls terminate().
342   reset(pointer __p = pointer()) noexcept
343   {
344 using std::swap;
345 swap(std::get<0>(_M_t), __p);
346 if (__p != pointer())
347   get_deleter()(__p);

** CID 1401474:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 235 in 
std::unique_ptr::~unique_ptr()()



*** CID 1401474:  Error handling issues  (UNCAUGHT_EXCEPT)
/usr/include/c++/6.3.1/bits/unique_ptr.h: 235 in 
std::unique_ptr::~unique_ptr()()
229   template, is_same<_Dp, 
default_delete<_Tp
231 unique_ptr(auto_ptr<_Up>&& __u) noexcept;
232 #endif
233 
234   /// Destructor, invokes the deleter if the stored pointer is not 
null.
>>> CID 1401474:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected() which usually calls terminate().
235   ~unique_ptr() noexcept
236   {
237 auto& __ptr = std::get<0>(_M_t);
238 if (__ptr != nullptr)
239   get_deleter()(__ptr);
240 __ptr = pointer();

** CID 1401473:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx: 238 in 
sd::slidesorter::controller::FocusManager::FocusHider::~FocusHider()()



*** CID 1401473:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx: 238 in 
sd::slidesorter::controller::FocusManager::FocusHider::~FocusHider()()
232 : mbFocusVisible(rManager.IsFocusShowing())
233 , mrManager(rManager)
234 {
235 mrManager.HideFocus();
236 }
237 
>>> CID 1401473:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected() which usually calls terminate().
238 FocusManager::FocusHider::~FocusHider()
239 {
240 if (mbFocusVisible)
241 mrManager.ShowFocus();
242 }
243 
244 } } } // end of namespace ::sd::slidesorter::controller
245 

** CID 1401472:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsSelectionObserver.cxx: 41 in 
sd::slidesorter::controller::SelectionObserver::Context::~Context()()



*** CID 1401472:  Error handling issues  (UNCAUGHT_EXCEPT)
/sd/source/ui/slidesorter/controller/SlsSelectionObserver.cxx: 41 in 
sd::slidesorter::controller::SelectionObserver::Context::~Context()()
35 
rSlideSorter.GetController().GetSelectionManager()->GetSelectionObserver())
36 {
37 if (mpSelectionObserver)
38 mpSelectionObserver->StartObservation();
39 }
40 
>>> CID 1401472:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "std::runtime_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected()

[Libreoffice-commits] core.git: 2 commits - sc/source sw/inc sw/source sw/uiconfig sw/UIConfig_swriter.mk

2017-02-24 Thread Markus Mohrhard 
 sc/source/core/data/document.cxx|2 
 sw/UIConfig_swriter.mk  |3 
 sw/inc/helpid.h |3 
 sw/source/uibase/inc/olmenu.hxx |   16 
 sw/source/uibase/lingu/olmenu.cxx   |  113 
 sw/source/uibase/lingu/olmenu.hrc   |9 ++
 sw/source/uibase/lingu/olmenu.src   |   90 ++
 sw/uiconfig/swriter/ui/spellmenu.ui |  142 
 8 files changed, 140 insertions(+), 238 deletions(-)

New commits:
commit 73f2944618e637762125fabd214b09b4fa50fb90
Author: Markus Mohrhard 
Date:   Sat Feb 25 03:21:12 2017 +0100

Revert "convert spell menu to .ui"

This reverts commit 51d5cb5de245245fc7a3498cf87743d33eede525.

diff --git a/sw/UIConfig_swriter.mk b/sw/UIConfig_swriter.mk
index 8d51e8c..95495a2 100644
--- a/sw/UIConfig_swriter.mk
+++ b/sw/UIConfig_swriter.mk
@@ -242,9 +242,8 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/swriter,\
sw/uiconfig/swriter/ui/pagefooterpanel \
sw/uiconfig/swriter/ui/sidebarwrap \
sw/uiconfig/swriter/ui/sidebarstylepresets \
-   sw/uiconfig/swriter/ui/sidebartheme \
+sw/uiconfig/swriter/ui/sidebartheme \
sw/uiconfig/swriter/ui/sortdialog \
-   sw/uiconfig/swriter/ui/spellmenu \
sw/uiconfig/swriter/ui/splittable \
sw/uiconfig/swriter/ui/statisticsinfopage \
sw/uiconfig/swriter/ui/stringinput \
diff --git a/sw/inc/helpid.h b/sw/inc/helpid.h
index f06dac6..559d40c 100644
--- a/sw/inc/helpid.h
+++ b/sw/inc/helpid.h
@@ -99,6 +99,9 @@
 #define HID_MN_READONLY_LOADGRAPHIC 
"SW_HID_MN_READONLY_LOADGRAPHIC"
 #define HID_MN_READONLY_GRAPHICOFF  
"SW_HID_MN_READONLY_GRAPHICOFF"
 
+#define HID_LINGU_ADD_WORD  
"SW_HID_LINGU_ADD_WORD"
+#define HID_LINGU_IGNORE_WORD   
"SW_HID_LINGU_IGNORE_WORD"
+#define HID_LINGU_SPELLING_DLG  
"SW_HID_LINGU_SPELLING_DLG"
 #define HID_LINGU_AUTOCORR  
"SW_HID_LINGU_AUTOCORR"
 #define HID_LINGU_REPLACE   
"SW_HID_LINGU_REPLACE"
 #define HID_SMARTTAG_MAIN   
"SW_HID_SMARTTAG_MAIN"// SMARTTAGS
diff --git a/sw/source/uibase/inc/olmenu.hxx b/sw/source/uibase/inc/olmenu.hxx
index a2077cd..af1156b 100644
--- a/sw/source/uibase/inc/olmenu.hxx
+++ b/sw/source/uibase/inc/olmenu.hxx
@@ -25,7 +25,6 @@
 #include 
 
 #include 
-#include 
 #include 
 #include 
 
@@ -36,20 +35,7 @@ class SwWrtShell;
 
 class SW_DLLPUBLIC SwSpellPopup
 {
-VclBuilder m_aBuilder;
-VclPtr m_xPopupMenu;
-sal_uInt16 m_nIgnoreWordId;
-sal_uInt16 m_nAddMenuId;
-sal_uInt16 m_nAddId;
-sal_uInt16 m_nSpellDialogId;
-sal_uInt16 m_nCorrectMenuId;
-sal_uInt16 m_nCorrectDialogId;
-sal_uInt16 m_nLangSelectionMenuId;
-sal_uInt16 m_nLangParaMenuId;
-sal_uInt16 m_nRedlineAcceptId;
-sal_uInt16 m_nRedlineRejectId;
-sal_uInt16 m_nRedlineNextId;
-sal_uInt16 m_nRedlinePrevId;
+ScopedVclPtrInstance m_xPopupMenu;
 SwWrtShell* m_pSh;
 css::uno::Sequence< css::uno::Reference< css::linguistic2::XDictionary >  
> m_aDics;
 css::uno::Reference< css::linguistic2::XSpellAlternatives > m_xSpellAlt;
diff --git a/sw/source/uibase/lingu/olmenu.cxx 
b/sw/source/uibase/lingu/olmenu.cxx
index 39a52d8..2932585 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -259,20 +259,7 @@ SwSpellPopup::SwSpellPopup(
 SwWrtShell* pWrtSh,
 const uno::Reference< linguistic2::XSpellAlternatives >  ,
 const OUString )
-: m_aBuilder(nullptr, VclBuilderContainer::getUIRootDir(), 
"modules/swriter/ui/spellmenu.ui", "")
-, m_xPopupMenu(m_aBuilder.get_menu("menu"))
-, m_nIgnoreWordId(m_xPopupMenu->GetItemId("ignoreall"))
-, m_nAddMenuId(m_xPopupMenu->GetItemId("addmenu"))
-, m_nAddId(m_xPopupMenu->GetItemId("add"))
-, m_nSpellDialogId(m_xPopupMenu->GetItemId("spelldialog"))
-, m_nCorrectMenuId(m_xPopupMenu->GetItemId("correctmenu"))
-, m_nCorrectDialogId(m_xPopupMenu->GetItemId("correctdialog"))
-, m_nLangSelectionMenuId(m_xPopupMenu->GetItemId("langselection"))
-, m_nLangParaMenuId(m_xPopupMenu->GetItemId("langpara"))
-, m_nRedlineAcceptId(m_xPopupMenu->GetItemId("accept"))
-, m_nRedlineRejectId(m_xPopupMenu->GetItemId("reject"))
-, m_nRedlineNextId(m_xPopupMenu->GetItemId("next"))
-, m_nRedlinePrevId(m_xPopupMenu->GetItemId("prev"))
+: m_xPopupMenu( SW_RES(MN_SPELL_POPUP) )
 , m_pSh( pWrtSh )
 , m_xSpellAlt(xAlt)
 , m_nGrammarError(0)
@@ -293,7 +280,7 @@ SwSpellPopup::SwSpellPopup(
 
 SvtLinguConfig aCfg;
 
-PopupMenu *pMenu = m_xPopupMenu->GetPopupMenu(m_nCorrectMenuId);
+PopupMenu *pMenu = m_xPopupMenu->GetPopupMenu(MN_AUTOCORR);

[Libreoffice-bugs] [Bug 61096] FILESAVE: XHTML export of doc with image broken

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=61096

--- Comment #5 from Greg Ross  ---
Confirmed the bug still exists.

LibreOffice 5.3.0.3
OS: Windows 10 (x64)

Some additional notes:

- Broken in IE and Edge, but not Firefox or Vivaldi.
- Looks to be a problem with the "src="data:image/*;base64" header as if you
replace it with "src="data:image/png;base64" all works correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106182] highlight button toggling does not toggle highlighting of selected text

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106182

Eben Stewart  changed:

   What|Removed |Added

  Alias||foolishmountainman

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106182] New: highlight button toggling does not toggle highlighting of selected text

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106182

Bug ID: 106182
   Summary: highlight button toggling does not toggle highlighting
of selected text
   Product: LibreOffice
   Version: 5.1.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eben.stew...@alum.vassar.edu

it should not be necessary to go into highlight colour picker menu and select
'no fill' to un-highlight text that is selected. This  should happen with
highlight button toggling.
this should be set up in such a way as to enable the setting up of a highlight
on/off toggling keyboard shortcut.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Question about Memory options

2017-02-24 Thread m.a.riosv 
Some information on this bug reports.

https://bugs.documentfoundation.org/show_bug.cgi?id=94760
https://bugs.documentfoundation.org/show_bug.cgi?id=96095

Miguel Ángel.



--
View this message in context: 
http://nabble.documentfoundation.org/Question-about-Memory-options-tp4208833p4208939.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: chart2/qa

2017-02-24 Thread Tamás Zolnai 
 chart2/qa/extras/chart2dump/chart2dump.cxx 
  |   27 --
 chart2/qa/extras/chart2dump/data/chartwall_auto_adjust_with_titles.ods 
  |binary
 chart2/qa/extras/chart2dump/data/chartwall_auto_adjust_without_titles.ods  
  |binary
 chart2/qa/extras/chart2dump/data/chartwall_custom_positioning.ods  
  |binary
 chart2/qa/extras/chart2dump/data/custom_legend_position.odp
  |binary
 chart2/qa/extras/chart2dump/data/default_formated_axis.odp 
  |binary
 chart2/qa/extras/chart2dump/data/formated_axis_labels.odp  
  |binary
 chart2/qa/extras/chart2dump/data/legend_on_bottom.odp  
  |binary
 chart2/qa/extras/chart2dump/data/legend_on_left_side.odp   
  |binary
 chart2/qa/extras/chart2dump/data/legend_on_right_side.odp  
  |binary
 chart2/qa/extras/chart2dump/data/legend_on_top.odp 
  |binary
 chart2/qa/extras/chart2dump/data/many_legend_entries.odp   
  |binary
 chart2/qa/extras/chart2dump/data/multiple_categories.odp   
  |binary
 chart2/qa/extras/chart2dump/data/percent_stacked_column_chart.odp  
  |binary
 chart2/qa/extras/chart2dump/data/rotated_axis_labels.odp   
  |binary
 chart2/qa/extras/chart2dump/reference/axislabeltest/default_formated_axis.txt  
  |   90 +++
 chart2/qa/extras/chart2dump/reference/axislabeltest/formated_axis_labels.txt   
  |  122 +-
 
chart2/qa/extras/chart2dump/reference/axislabeltest/percent_stacked_column_chart.txt
 |   90 +++
 chart2/qa/extras/chart2dump/reference/axislabeltest/rotated_axis_labels.txt
  |   72 ++---
 
chart2/qa/extras/chart2dump/reference/chartwalltest/chartwall_auto_adjust_with_titles.txt
|   10 
 
chart2/qa/extras/chart2dump/reference/chartwalltest/chartwall_auto_adjust_without_titles.txt
 |6 
 chart2/qa/extras/chart2dump/reference/legendtest/custom_legend_position.txt
  |   32 +-
 chart2/qa/extras/chart2dump/reference/legendtest/legend_on_bottom.txt  
  |   16 -
 chart2/qa/extras/chart2dump/reference/legendtest/legend_on_left_side.txt   
  |2 
 chart2/qa/extras/chart2dump/reference/legendtest/legend_on_right_side.txt  
  |   12 
 chart2/qa/extras/chart2dump/reference/legendtest/legend_on_top.txt 
  |   16 -
 chart2/qa/extras/chart2dump/reference/legendtest/many_legend_entries.txt   
  |   64 ++---
 chart2/qa/extras/chart2dump/reference/legendtest/multiple_categories.txt   
  |   54 ++--
 28 files changed, 305 insertions(+), 308 deletions(-)

New commits:
commit 7a66f9491cd9f07d365c5f8b6b49f6e200e2f9ff
Author: Tamás Zolnai 
Date:   Fri Feb 24 18:02:57 2017 +0100

ChartDumpTest: Convert test docs to use Liberation Mono font

Liberation Mono is a bundled, monospaced font, which
is better for testing, shows smaller differences.

Change-Id: If56597cede90fc81c722a69fd71e099d22a65d1f
Reviewed-on: https://gerrit.libreoffice.org/34618
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index bd25d20..a883ec4 100755
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -391,10 +391,9 @@ DECLARE_DUMP_TEST(ChartDataTest, Chart2DumpTest, false)
 }
 }
 
-#if !defined(MACOSX)
-
 DECLARE_DUMP_TEST(LegendTest, Chart2DumpTest, false)
 {
+const double fLocalEPS = 550.1;
 const std::vector aTestFiles =
 {
 "legend_on_right_side.odp",
@@ -424,11 +423,11 @@ DECLARE_DUMP_TEST(LegendTest, Chart2DumpTest, false)
 
 // Check legend position and size
 awt::Point aLegendPosition = xLegend->getPosition();
-CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendPosition.X, INT_EPS);
-CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendPosition.Y, INT_EPS);
+CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendPosition.X, 
std::max(fLocalEPS, INT_EPS));
+CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendPosition.Y, 
std::max(fLocalEPS, INT_EPS));
 awt::Size aLegendSize = xLegend->getSize();
-CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendSize.Width, INT_EPS);
-CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendSize.Height, INT_EPS);
+CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendSize.Width, 
std::max(fLocalEPS, INT_EPS));
+CPPUNIT_DUMP_ASSERT_DOUBLES_EQUAL(aLegendSize.Height, 
std::max(fLocalEPS, INT_EPS));
 
 // Check legend entries

[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=50916

--- Comment #49 from Commit Notification 
 ---
Bartosz Kosiorek committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1b1ed766d1110acf843b807d554f9375963234c

tdf#50916 Allow dynamically increase number of columns according to needs

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

2017-02-24 Thread Bartosz Kosiorek 
 sc/inc/colcontainer.hxx  |2 ++
 sc/inc/table.hxx |   17 -
 sc/source/core/data/colcontainer.cxx |   10 +-
 sc/source/core/data/table2.cxx   |   35 +--
 4 files changed, 56 insertions(+), 8 deletions(-)

New commits:
commit a1b1ed766d1110acf843b807d554f9375963234c
Author: Bartosz Kosiorek 
Date:   Tue Jan 31 00:25:12 2017 +0100

tdf#50916 Allow dynamically increase number of columns according to needs

Change-Id: I08b1d70b6aafb01738bb5dec3f4eafd7b21e6bb5
Reviewed-on: https://gerrit.libreoffice.org/33724
Tested-by: Jenkins 
Reviewed-by: Bartosz Kosiorek 

diff --git a/sc/inc/colcontainer.hxx b/sc/inc/colcontainer.hxx
index c3e0398..925104d 100644
--- a/sc/inc/colcontainer.hxx
+++ b/sc/inc/colcontainer.hxx
@@ -55,6 +55,8 @@ public:
 return static_cast( aCols.size() );
 }
 
+void resize( const size_t aNewSize );
+
 void Clear();
 
 const ScColumn& back() const
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 3d446ad..5f8711c 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -241,6 +241,21 @@ public:
 
 ScOutlineTable* GetOutlineTable()   { return pOutlineTable; }
 
+ScColumn& CreateColumnIfNotExists( SCCOL nScCol )
+{
+if ( nScCol >= aCol.size() )
+{
+SCCOL aOldColSize = aCol.size();
+bool bUseEmptyAttrArray = false;
+if ( aOldColSize == 0 )
+bUseEmptyAttrArray = true;
+aCol.resize( static_cast< size_t >( nScCol + 1 ) );
+for (SCCOL i = aOldColSize; i <= nScCol; i++)
+aCol[i].Init( i, nTab, pDocument, bUseEmptyAttrArray );
+
+}
+return aCol[nScCol];
+}
 sal_uLong   GetCellCount() const;
 sal_uLong   GetWeightedCount() const;
 sal_uLong   GetCodeCount() const;   // RPN code in formula
@@ -544,7 +559,7 @@ public:
 
 FormulaErrorGetErrCode( const ScAddress& rPos ) const
 {
-return ValidColRow(rPos.Col(),rPos.Row()) ?
+return IsColRowValid(rPos.Col(),rPos.Row()) ?
 aCol[rPos.Col()].GetErrCode( rPos.Row() ) :
 FormulaError::NONE;
 }
diff --git a/sc/source/core/data/colcontainer.cxx 
b/sc/source/core/data/colcontainer.cxx
index 7433240..fa2a18f 100644
--- a/sc/source/core/data/colcontainer.cxx
+++ b/sc/source/core/data/colcontainer.cxx
@@ -35,7 +35,6 @@ ScColContainer::~ScColContainer()
 Clear();
 }
 
-
 void ScColContainer::Clear()
 {
 SCCOL nSize = size();
@@ -46,4 +45,13 @@ void ScColContainer::Clear()
 }
 aCols.clear();
 }
+
+void ScColContainer::resize( const size_t aNewColSize )
+{
+size_t aOldColSize = aCols.size();
+aCols.resize( aNewColSize );
+for ( size_t nCol = aOldColSize; nCol < aNewColSize; ++nCol )
+aCols[nCol] = new ScColumn;
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index d740767..f1f03f8 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -2509,7 +2509,8 @@ void ScTable::RemoveCondFormatData( const ScRangeList& 
rRange, sal_uInt32 nIndex
 void ScTable::ApplyStyle( SCCOL nCol, SCROW nRow, const ScStyleSheet* rStyle )
 {
 if (ValidColRow(nCol,nRow))
-aCol[nCol].ApplyStyle( nRow, rStyle );
+// If column not exists then we need to create it
+CreateColumnIfNotExists( nCol ).ApplyStyle( nRow, rStyle );
 }
 
 void ScTable::ApplyStyleArea( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, 
SCROW nEndRow, const ScStyleSheet& rStyle )
@@ -2518,8 +2519,28 @@ void ScTable::ApplyStyleArea( SCCOL nStartCol, SCROW 
nStartRow, SCCOL nEndCol, S
 {
 PutInOrder(nStartCol, nEndCol);
 PutInOrder(nStartRow, nEndRow);
-for (SCCOL i = nStartCol; i <= nEndCol; i++)
-aCol[i].ApplyStyleArea(nStartRow, nEndRow, rStyle);
+if ( nEndCol == MAXCOL )
+{
+if ( nStartCol < aCol.size() )
+{
+// If we would like set all columns to specific style, then 
change only default style for not existing columns
+nEndCol = aCol.size() - 1;
+for (SCCOL i = nStartCol; i <= nEndCol; i++)
+aCol[i].ApplyStyleArea(nStartRow, nEndRow, rStyle);
+aNextColAttrArray.ApplyStyleArea(nStartRow, nEndRow, 
const_cast(  ) );
+}
+else
+{
+CreateColumnIfNotExists( nStartCol - 1 );
+aNextColAttrArray.ApplyStyleArea(nStartRow, nEndRow, 
const_cast(  ) );
+}
+}
+else
+{
+CreateColumnIfNotExists( nEndCol );
+for (SCCOL

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/Socket.hpp

2017-02-24 Thread Michael Meeks 
 net/Socket.hpp |   64 +
 1 file changed, 38 insertions(+), 26 deletions(-)

New commits:
commit 6a34272fdd10b2c4a5ba2ad6c7fb8a9e56e3dc6a
Author: Michael Meeks 
Date:   Fri Feb 24 23:14:09 2017 +

Add thread-safe cross-thread callbacks, split out wakeup and simplify

diff --git a/net/Socket.hpp b/net/Socket.hpp
index d78e3c9..4b49b08 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -217,49 +217,60 @@ public:
 // Process the wakeup pipe (always the last entry).
 if (_pollFds[size].revents)
 {
-// Add new sockets first.
-addNewSocketsToPoll();
+std::vector invoke;
+{
+std::lock_guard lock(_mutex);
+
+// Clear the data.
+int dump = ::read(_wakeup[0], , sizeof(dump));
 
-// Clear the data.
-int dump = ::read(_wakeup[0], , sizeof(dump));
+// Copy the new sockets over and clear.
+_pollSockets.insert(_pollSockets.end(),
+_newSockets.begin(), _newSockets.end());
+_newSockets.clear();
+
+// Extract list of callbacks to process
+std::swap(_newCallbacks, invoke);
+}
+
+for (size_t i = 0; i < invoke.size(); ++i)
+invoke[i]();
 }
 }
 
+/// Wakeup the main polling loop in another thread
+void wakeup()
+{
+// wakeup the main-loop.
+int rc;
+do {
+rc = ::write(_wakeup[1], "w", 1);
+} while (rc == -1 && errno == EINTR);
+
+assert (rc != -1 || errno == EAGAIN || errno == EWOULDBLOCK);
+}
+
 /// Insert a new socket to be polled.
 /// Sockets are removed only when the handler return false.
 void insertNewSocket(const std::shared_ptr& newSocket)
 {
 std::lock_guard lock(_mutex);
-
 _newSockets.emplace_back(newSocket);
-
-// wakeup the main-loop.
-int rc;
-do
-{
-// wakeup pipe is already full.
-rc = ::write(_wakeup[1], "w", 1);
-}
-while (rc == -1 && errno == EINTR);
-
-if (rc == -1)
-{
-assert(errno == EAGAIN || errno == EWOULDBLOCK);
-}
+wakeup();
 }
 
-private:
+typedef std::function CallbackFn;
 
-/// Add the new sockets to list of those to poll.
-void addNewSocketsToPoll()
+/// Add a callback to be invoked in the polling thread
+void addCallback(CallbackFn fn)
 {
 std::lock_guard lock(_mutex);
-
-// Copy the new sockets over and clear.
-_pollSockets.insert(_pollSockets.end(), _newSockets.begin(), 
_newSockets.end());
-_newSockets.clear();
+_newCallbacks.emplace_back(fn);
+wakeup();
 }
 
+private:
+
 void removeSocketFromPoll(const std::shared_ptr& socket)
 {
 auto it = std::find(_pollSockets.begin(), _pollSockets.end(), socket);
@@ -296,6 +307,7 @@ private:
 /// Protects _newSockets
 std::mutex _mutex;
 std::vector _newSockets;
+std::vector _newCallbacks;
 /// The fds to poll.
 std::vector _pollFds;
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106181] FILESAVE: Check boxes get lost when saving in .XLSX format

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106181

--- Comment #3 from Johannes Schneider  ---
Created attachment 131461
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131461=edit
spreadsheet in .ODS format, working properley

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106181] FILESAVE: Check boxes get lost when saving in .XLSX format

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106181

--- Comment #2 from Johannes Schneider  ---
Created attachment 131460
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131460=edit
spreadsheet in .XLSX format containing the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100926] PPTX: Table with rotated text rendering wrong

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100926

Volga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4353

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104353] FORMATTING: Rotated text with new lines in text boxes from DOCX not properly displayed (not supported?)

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104353

Volga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0926

--- Comment #8 from Volga  ---
This file including two sideways directions that have not implemented in
LibreOffice. On this page I found MS Word have already provided related options
in 2010:
http://www.mgzwz.com/post-383.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103718] FORMATTING: brackets rotates depending on surrounding text in vertical layout

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103718

Volga  changed:

   What|Removed |Added

 Blocks||106045


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
[Bug 106045] [META] Bugs and enhancements related to vertical text direction
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106045] [META] Bugs and enhancements related to vertical text direction

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106045

Volga  changed:

   What|Removed |Added

 Depends on||103718, 98879, 105286


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=98879
[Bug 98879] Some CJK characters are wrongly converted in vertical layout (Noto
CJK font)
https://bugs.documentfoundation.org/show_bug.cgi?id=103718
[Bug 103718] FORMATTING: brackets rotates depending on surrounding text in
vertical layout
https://bugs.documentfoundation.org/show_bug.cgi?id=105286
[Bug 105286] Ellipsis do not rotate in vertical layout.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98879] Some CJK characters are wrongly converted in vertical layout ( Noto CJK font)

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=98879

Volga  changed:

   What|Removed |Added

 Blocks||106045


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
[Bug 106045] [META] Bugs and enhancements related to vertical text direction
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105286] Ellipsis do not rotate in vertical layout.

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105286

Volga  changed:

   What|Removed |Added

 Blocks||106045


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106045
[Bug 106045] [META] Bugs and enhancements related to vertical text direction
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/ServerSocket.hpp net/Socket.hpp

2017-02-24 Thread Michael Meeks 
 net/ServerSocket.hpp |2 +-
 net/Socket.hpp   |   28 
 2 files changed, 21 insertions(+), 9 deletions(-)

New commits:
commit ba0cc1fc6b75e08b91734c90425dd695e6ebf398
Author: Michael Meeks 
Date:   Fri Feb 24 22:56:20 2017 +

Add initial support for socket timeouts.

diff --git a/net/ServerSocket.hpp b/net/ServerSocket.hpp
index a206e7c..1d0f2a5 100644
--- a/net/ServerSocket.hpp
+++ b/net/ServerSocket.hpp
@@ -73,7 +73,7 @@ public:
 return POLLIN;
 }
 
-HandleResult handlePoll(int events) override
+HandleResult handlePoll(const Poco::Timestamp &/* now */, int events) 
override
 {
 if (events & POLLIN)
 {
diff --git a/net/Socket.hpp b/net/Socket.hpp
index 59be92b..d78e3c9 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -25,6 +25,8 @@
 #include 
 #include 
 
+#include 
+#include 
 #include 
 
 #include "Log.hpp"
@@ -47,15 +49,18 @@ public:
 close(_fd);
 }
 
-// Returns the OS native socket fd.
+/// Returns the OS native socket fd.
 int getFD() const { return _fd; }
 
 /// Return a mask of events we should be polling for
 virtual int getPollEvents() = 0;
 
+/// Contract the poll timeout to match our needs
+virtual void updateTimeout(Poco::Timestamp &/*timeout*/) { /* do nothing 
*/ }
+
 /// Handle results of events returned from poll
 enum class HandleResult { CONTINUE, SOCKET_CLOSED };
-virtual HandleResult handlePoll( int events ) = 0;
+virtual HandleResult handlePoll(const Poco::Timestamp , int events) = 
0;
 
 /// manage latency issues around packet aggregation
 void setNoDelay(bool noDelay = true)
@@ -175,26 +180,31 @@ public:
 }
 
 /// Poll the sockets for available data to read or buffer to write.
-void poll(const int timeoutMs)
+void poll(const int timeoutMaxMs)
 {
 const size_t size = _pollSockets.size();
 
+Poco::Timestamp now;
+Poco::Timestamp timeout = now;
+timeout += Poco::Timespan(0 /* s */, timeoutMaxMs * 1000 /* us */);
+
 // The events to poll on change each spin of the loop.
-setupPollFds();
+setupPollFds(timeout);
 
 int rc;
 do
 {
-rc = ::poll(&_pollFds[0], size + 1, timeoutMs);
+rc = ::poll(&_pollFds[0], size + 1, (timeout - now)/1000);
 }
 while (rc < 0 && errno == EINTR);
 
 // Fire the callback and remove dead fds.
+Poco::Timestamp newNow;
 for (int i = static_cast(size) - 1; i >= 0; --i)
 {
 if (_pollFds[i].revents)
 {
-if (_pollSockets[i]->handlePoll(_pollFds[i].revents) ==
+if (_pollSockets[i]->handlePoll(newNow, _pollFds[i].revents) ==
 Socket::HandleResult::SOCKET_CLOSED)
 {
 std::cout << "Removing client #" << _pollFds[i].fd << 
std::endl;
@@ -258,7 +268,7 @@ private:
 }
 
 /// Initialize the poll fds array with the right events
-void setupPollFds()
+void setupPollFds(Poco::Timestamp )
 {
 const size_t size = _pollSockets.size();
 
@@ -268,6 +278,7 @@ private:
 {
 _pollFds[i].fd = _pollSockets[i]->getFD();
 _pollFds[i].events = _pollSockets[i]->getPollEvents();
+_pollSockets[i]->updateTimeout(timeout);
 _pollFds[i].revents = 0;
 }
 
@@ -315,7 +326,8 @@ public:
 
 /// Called when a polling event is received.
 /// @events is the mask of events that triggered the wake.
-HandleResult handlePoll(const int events) override
+HandleResult handlePoll(const Poco::Timestamp & /* now */,
+const int events) override
 {
 // FIXME: need to close input, but not output (?)
 bool closeSocket = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Various MacOS extension issues.

2017-02-24 Thread Jan Iversen 
Hi

I use LibreOffice daily on my Mac (Sierra), I happen to also be a developer and 
build LO for the Mac.


> 2. There are no decent ways to do debug logging on MacOS; none of the
> commandline options are available
> https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Mac_OSX:_How_to_get_debug_information
>  
> 
I normally work with versions compiled with —enable-debug, which give me plenty 
of debug.


> 
> 4. Since MacOS Sierra LibreOffice is generally very slow. We have been
> getting reports of people having issues after performing a couple of actions
> with our extension, but there have been no changes on our end since 2015.
> Moreover, it seems that LibreOffice itself is terribly slow -- on my 2014
> MacBook Pro it takes some good 5 seconds to open Character..., Paragraph...
> or Bullets and Numbering... dialogs. On a 2016 linux machine with similar
> specs it's essentially instantaneous. There are some reports of this
> slowness online, but no bugs on the bugtracker that I could find.
> https://ask.libreoffice.org/en/question/79342/libreoffice-extremely-slow-in-mac-os-sierra/
> https://ask.libreoffice.org/en/question/77793/libreoffice-hangs-on-macos-sierra/
>  
> 
I cannot recognise your timing, on my mac the example takes far less than a 
second.

There was a startup issue, with libreoffice, but that has nothing to do with 
slow performance.

> What is the current state of MacOS LO development
> and is it possible to get some love for the MacOS version?

We are some developers that work on Mac, so the love is there, but it seems a 
bit as if you have some other problems.

rgds
jan I.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/clientnb.cpp

2017-02-24 Thread Michael Meeks 
 net/clientnb.cpp |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit cb76f20350f83f706e8d83741e4acb4817ab2800
Author: Michael Meeks 
Date:   Fri Feb 24 22:18:38 2017 +

Use pseudo-random-ness in test to make strace cleaner.

diff --git a/net/clientnb.cpp b/net/clientnb.cpp
index 0f7c796..311491e 100644
--- a/net/clientnb.cpp
+++ b/net/clientnb.cpp
@@ -222,9 +222,13 @@ struct Client : public Poco::Util::Application
 std::shared_ptr ws = session.getWebSocket();
 
 std::vector res;
+
+std::srand(std::time(0));
+
+std::vector data;
 for (size_t i = 1; i < (1 << 14); ++i)
 {
-const std::vector data = Util::rng::getBytes(i);
+data.push_back((char)(std::rand() / (RAND_MAX/256)));
 ws->sendFrame(data.data(), data.size(), 
WebSocket::SendFlags::FRAME_BINARY);
 
 res.resize(i);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 45313] com.sun.star.uno.RuntimeException when starting any macro after using " .uno:EditDoc" once

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=45313

Luis  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #16 from Luis  ---
Improperly I set status to resolved-fixed by mistake.
Changed status to resolved-worksforme.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59354] File Locked dialog doesn't unescape URL fully

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=59354

Luis  changed:

   What|Removed |Added

 CC||luismiguel.laco...@gmail.co
   ||m

--- Comment #8 from Luis  ---
The bug is still present.
Tested using Windows 7 and 8 with 5.3.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45313] com.sun.star.uno.RuntimeException when starting any macro after using " .uno:EditDoc" once

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=45313

Luis  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Luis  ---
Tested in 5.2.5.1 (Windows 8) -> Bug present.
Tested in 5.3.0.3 (Windows 8) -> Bug NOT present

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103931] FILEOPEN: DOCX Columns no longer keep their positions/ column breaks ignored

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103931

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

--- Comment #2 from Miklos Vajna  ---
No, it doesn't fix this bug. The root cause here is that the bugdoc contains 3
sections and the 3rd one is empty. Given that the current DOCX import code
creates the new section in the first paragraph of the next section such empty
sections are ignored.

As a consequence of this problem the 2nd section is handled as the last section
and that's how the above commit made the already existing problem more visible.

I'll look into fixing this if I'm here anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106008] Scroll zooming from touchpad barely controllable

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106008

Severo Raz  changed:

   What|Removed |Added

Version|5.1.6.2 release |5.3.0.3 release

--- Comment #2 from Severo Raz  ---
Ok, just installed version 5.3.0.3 and the problem also exists in this version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sdext/source

2017-02-24 Thread Markus Mohrhard 
 sdext/source/pdfimport/tree/imagecontainer.cxx |   13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

New commits:
commit cffa23b8d0c0b2d660505a11784addb7715a9937
Author: Markus Mohrhard 
Date:   Fri Feb 24 18:14:01 2017 +0100

fix crash in pdfimport

Found by the crashreporter:

http://crashreport.libreoffice.org/stats/crash_details/2eaeda85-849d-4098-b215-a8e64fe82089

Change-Id: I113f4dfc4a4f45511102c417d39fe15db6050daa
Reviewed-on: https://gerrit.libreoffice.org/34628
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sdext/source/pdfimport/tree/imagecontainer.cxx 
b/sdext/source/pdfimport/tree/imagecontainer.cxx
index 650b584..64d17c6 100644
--- a/sdext/source/pdfimport/tree/imagecontainer.cxx
+++ b/sdext/source/pdfimport/tree/imagecontainer.cxx
@@ -126,12 +126,19 @@ void ImageContainer::writeBase64EncodedStream( ImageId 
nId, EmitContext& rContex
 [] (beans::PropertyValue const& v) -> bool {
 return v.Name == "InputSequence";
 }));
-OSL_ENSURE( pValue != pAry+nLen,
-"InputSequence not found" );
+
+if (pValue == pAry + nLen )
+{
+SAL_WARN("pdfimport", "InputSequence not found");
+return;
+}
 
 uno::Sequence aData;
 if( !(pValue->Value >>= aData) )
-OSL_FAIL("Wrong data type");
+{
+SAL_WARN("pdfimport", "Wrong data type");
+return;
+}
 
 rContext.rEmitter.write( encodeBase64( aData.getConstArray(), 
aData.getLength() ));
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 105829] Infobar design needs an update

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105829

--- Comment #5 from Heiko Tietze  ---
Created attachment 131459
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131459=edit
Latest layout

Icons added (vcl/res/* and cmd/lc_apply for success); InfoBarType is reverted
back to info for readonly and CMIS following Samuel's request. 

The success example is not an actual infobar, not yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: svx/source

2017-02-24 Thread Markus Mohrhard 
 svx/source/tbxctrls/PaletteManager.cxx |   14 --
 1 file changed, 8 insertions(+), 6 deletions(-)

New commits:
commit ece3c97ca6c9aaffbf9dd51785ae2f1d4d3e2c9b
Author: Markus Mohrhard 
Date:   Fri Feb 24 18:08:39 2017 +0100

prevent crash in PaletteManager

Found by the crashreporter:

http://crashreport.libreoffice.org/stats/signature/PaletteManager::ReloadColorSet(SvxColorValueSet%20&)

Change-Id: I82c5e3f7588615700ec3b5540ac94e331df783bb
Reviewed-on: https://gerrit.libreoffice.org/34627
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/svx/source/tbxctrls/PaletteManager.cxx 
b/svx/source/tbxctrls/PaletteManager.cxx
index 1dc3a46..bdd9701 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -120,8 +120,6 @@ void PaletteManager::LoadPalettes()
 
 void PaletteManager::ReloadColorSet(SvxColorValueSet )
 {
-SfxObjectShell* pDocSh = SfxObjectShell::Current();
-
 if( mnCurrentPalette == 0)
 {
 rColorSet.Clear();
@@ -138,10 +136,14 @@ void PaletteManager::ReloadColorSet(SvxColorValueSet 
)
 else if( mnCurrentPalette == mnNumOfPalettes - 1 )
 {
 // Add doc colors to palette
-std::set aColors = pDocSh->GetDocColors();
-mnColorCount = aColors.size();
-rColorSet.Clear();
-rColorSet.addEntriesForColorSet(aColors, SVX_RESSTR( 
RID_SVXSTR_DOC_COLOR_PREFIX ) + " " );
+SfxObjectShell* pDocSh = SfxObjectShell::Current();
+if (pDocSh)
+{
+std::set aColors = pDocSh->GetDocColors();
+mnColorCount = aColors.size();
+rColorSet.Clear();
+rColorSet.addEntriesForColorSet(aColors, SVX_RESSTR( 
RID_SVXSTR_DOC_COLOR_PREFIX ) + " " );
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2017-02-24 Thread Caolán McNamara 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d1ef5f86a251b95bee37725a01f54b1d8d020fc3
Author: Caolán McNamara 
Date:   Fri Feb 24 20:59:21 2017 +

Updated core
Project: help  a43b8eb31d44f4a3193029f7593281152ed2e5f9

update helpids for .ui spell menu conversion

Change-Id: I89488bd75c33fb732e780c5ffc4515c0615b

diff --git a/helpcontent2 b/helpcontent2
index 4653c09..a43b8eb 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4653c092350d627d43e895039fa17c37a1fd0251
+Subproject commit a43b8eb31d44f4a3193029f7593281152ed2e5f9
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: helpers/help_hid.lst source/text

2017-02-24 Thread Caolán McNamara 
 helpers/help_hid.lst   |3 ---
 source/text/shared/01/06040500.xhp |   14 --
 2 files changed, 8 insertions(+), 9 deletions(-)

New commits:
commit a43b8eb31d44f4a3193029f7593281152ed2e5f9
Author: Caolán McNamara 
Date:   Fri Feb 24 20:59:21 2017 +

update helpids for .ui spell menu conversion

Change-Id: I89488bd75c33fb732e780c5ffc4515c0615b

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index ef53254..df93635 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -1841,12 +1841,9 @@ HID_LETTER_PAGE6,53274,
 HID_LETTER_PAGE7,53275,
 HID_LETTER_PAGE8,53276,
 HID_LETTER_PAGE9,53277,
-HID_LINGU_ADD_WORD,53430,
 HID_LINGU_AUTOCORR,53433,
-HID_LINGU_IGNORE_WORD,53431,
 HID_LINGU_PARA_LANGUAGE,53438,
 HID_LINGU_REPLACE,53434,
-HID_LINGU_SPELLING_DLG,53432,
 HID_LINGU_WORD_LANGUAGE,53437,
 HID_LISTWIZARD_CANCEL,34819,
 HID_LISTWIZARD_FINISH,34820,
diff --git a/source/text/shared/01/06040500.xhp 
b/source/text/shared/01/06040500.xhp
index 4647634..1a938b7 100644
--- a/source/text/shared/01/06040500.xhp
+++ b/source/text/shared/01/06040500.xhp
@@ -36,20 +36,22 @@
 Replacement Suggestions
 Click the word to replace the 
highlighted word. Use the AutoCorrect submenu for permanent 
replacement.UFI: see i60431
 
-
+
 Spellcheck
-Opens the Spellcheck 
dialog.
+Opens the 
Spellcheck 
dialog.
 
 
-
+
+
 Add
-Adds the highlighted word to a 
user-defined dictionary.
+Adds the highlighted 
word to a user-defined dictionary.
 
-
+
 Ignore all
-Ignores all instances of the 
highlighted word in the current document.
+Ignores all 
instances of the highlighted word in the current document.
 
 
+
 
 AutoCorrect
 To always replace the highlighted word, click a word 
in the list. The word pair is stored in the replacement table under Tools - 
AutoCorrect - AutoCorrect Options - Replace.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/inc sw/source sw/uiconfig sw/UIConfig_swriter.mk

2017-02-24 Thread Caolán McNamara 
 sw/UIConfig_swriter.mk  |3 
 sw/inc/helpid.h |3 
 sw/source/uibase/inc/olmenu.hxx |   16 +++-
 sw/source/uibase/lingu/olmenu.cxx   |  113 +++-
 sw/source/uibase/lingu/olmenu.hrc   |9 --
 sw/source/uibase/lingu/olmenu.src   |   90 --
 sw/uiconfig/swriter/ui/spellmenu.ui |  142 
 7 files changed, 237 insertions(+), 139 deletions(-)

New commits:
commit 51d5cb5de245245fc7a3498cf87743d33eede525
Author: Caolán McNamara 
Date:   Fri Feb 24 16:40:24 2017 +

convert spell menu to .ui

Change-Id: I96a4b852fd396883385d5e2d43728dc8c2b20ce3

diff --git a/sw/UIConfig_swriter.mk b/sw/UIConfig_swriter.mk
index 95495a2..8d51e8c 100644
--- a/sw/UIConfig_swriter.mk
+++ b/sw/UIConfig_swriter.mk
@@ -242,8 +242,9 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/swriter,\
sw/uiconfig/swriter/ui/pagefooterpanel \
sw/uiconfig/swriter/ui/sidebarwrap \
sw/uiconfig/swriter/ui/sidebarstylepresets \
-sw/uiconfig/swriter/ui/sidebartheme \
+   sw/uiconfig/swriter/ui/sidebartheme \
sw/uiconfig/swriter/ui/sortdialog \
+   sw/uiconfig/swriter/ui/spellmenu \
sw/uiconfig/swriter/ui/splittable \
sw/uiconfig/swriter/ui/statisticsinfopage \
sw/uiconfig/swriter/ui/stringinput \
diff --git a/sw/inc/helpid.h b/sw/inc/helpid.h
index 559d40c..f06dac6 100644
--- a/sw/inc/helpid.h
+++ b/sw/inc/helpid.h
@@ -99,9 +99,6 @@
 #define HID_MN_READONLY_LOADGRAPHIC 
"SW_HID_MN_READONLY_LOADGRAPHIC"
 #define HID_MN_READONLY_GRAPHICOFF  
"SW_HID_MN_READONLY_GRAPHICOFF"
 
-#define HID_LINGU_ADD_WORD  
"SW_HID_LINGU_ADD_WORD"
-#define HID_LINGU_IGNORE_WORD   
"SW_HID_LINGU_IGNORE_WORD"
-#define HID_LINGU_SPELLING_DLG  
"SW_HID_LINGU_SPELLING_DLG"
 #define HID_LINGU_AUTOCORR  
"SW_HID_LINGU_AUTOCORR"
 #define HID_LINGU_REPLACE   
"SW_HID_LINGU_REPLACE"
 #define HID_SMARTTAG_MAIN   
"SW_HID_SMARTTAG_MAIN"// SMARTTAGS
diff --git a/sw/source/uibase/inc/olmenu.hxx b/sw/source/uibase/inc/olmenu.hxx
index af1156b..a2077cd 100644
--- a/sw/source/uibase/inc/olmenu.hxx
+++ b/sw/source/uibase/inc/olmenu.hxx
@@ -25,6 +25,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -35,7 +36,20 @@ class SwWrtShell;
 
 class SW_DLLPUBLIC SwSpellPopup
 {
-ScopedVclPtrInstance m_xPopupMenu;
+VclBuilder m_aBuilder;
+VclPtr m_xPopupMenu;
+sal_uInt16 m_nIgnoreWordId;
+sal_uInt16 m_nAddMenuId;
+sal_uInt16 m_nAddId;
+sal_uInt16 m_nSpellDialogId;
+sal_uInt16 m_nCorrectMenuId;
+sal_uInt16 m_nCorrectDialogId;
+sal_uInt16 m_nLangSelectionMenuId;
+sal_uInt16 m_nLangParaMenuId;
+sal_uInt16 m_nRedlineAcceptId;
+sal_uInt16 m_nRedlineRejectId;
+sal_uInt16 m_nRedlineNextId;
+sal_uInt16 m_nRedlinePrevId;
 SwWrtShell* m_pSh;
 css::uno::Sequence< css::uno::Reference< css::linguistic2::XDictionary >  
> m_aDics;
 css::uno::Reference< css::linguistic2::XSpellAlternatives > m_xSpellAlt;
diff --git a/sw/source/uibase/lingu/olmenu.cxx 
b/sw/source/uibase/lingu/olmenu.cxx
index 2932585..39a52d8 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -259,7 +259,20 @@ SwSpellPopup::SwSpellPopup(
 SwWrtShell* pWrtSh,
 const uno::Reference< linguistic2::XSpellAlternatives >  ,
 const OUString )
-: m_xPopupMenu( SW_RES(MN_SPELL_POPUP) )
+: m_aBuilder(nullptr, VclBuilderContainer::getUIRootDir(), 
"modules/swriter/ui/spellmenu.ui", "")
+, m_xPopupMenu(m_aBuilder.get_menu("menu"))
+, m_nIgnoreWordId(m_xPopupMenu->GetItemId("ignoreall"))
+, m_nAddMenuId(m_xPopupMenu->GetItemId("addmenu"))
+, m_nAddId(m_xPopupMenu->GetItemId("add"))
+, m_nSpellDialogId(m_xPopupMenu->GetItemId("spelldialog"))
+, m_nCorrectMenuId(m_xPopupMenu->GetItemId("correctmenu"))
+, m_nCorrectDialogId(m_xPopupMenu->GetItemId("correctdialog"))
+, m_nLangSelectionMenuId(m_xPopupMenu->GetItemId("langselection"))
+, m_nLangParaMenuId(m_xPopupMenu->GetItemId("langpara"))
+, m_nRedlineAcceptId(m_xPopupMenu->GetItemId("accept"))
+, m_nRedlineRejectId(m_xPopupMenu->GetItemId("reject"))
+, m_nRedlineNextId(m_xPopupMenu->GetItemId("next"))
+, m_nRedlinePrevId(m_xPopupMenu->GetItemId("prev"))
 , m_pSh( pWrtSh )
 , m_xSpellAlt(xAlt)
 , m_nGrammarError(0)
@@ -280,7 +293,7 @@ SwSpellPopup::SwSpellPopup(
 
 SvtLinguConfig aCfg;
 
-PopupMenu *pMenu = m_xPopupMenu->GetPopupMenu(MN_AUTOCORR);
+PopupMenu *pMenu = m_xPopupMenu->GetPopupMenu(m_nCorrectMenuId);
 pMenu->SetMenuFlags(MenuFlags::NoAutoMnemonics);
 bool bEnable = false;
 if(

[Libreoffice-bugs] [Bug 106181] FILESAVE: Check boxes get lost when saving in .XLSX format

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106181

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
Summary|Check boxes get lost when   |FILESAVE: Check boxes get
   |file has been saved in the  |lost when saving in .XLSX
   |.XLSX-format.   |format

--- Comment #1 from tommy27  ---
please post a test file where you exactly replicate your bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106181] New: Check boxes get lost when file has been saved in the .XLSX-format.

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106181

Bug ID: 106181
   Summary: Check boxes get lost when file has been saved in the
.XLSX-format.
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: johannes_f.schnei...@gmx.de

When I create a check box in a spread sheet and then save the file in the
format "Microsoft Excel 7 - 2013 XML (.XLSX)", the check box is disappeared
after closing and reopening the file. Obviously calc doesn' t save check boxes
in this format.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - 3 commits - common/Session.cpp common/Session.hpp kit/ChildSession.cpp kit/Kit.cpp Makefile.am test/Makefile.am wsd/ClientSession

2017-02-24 Thread Jan Holesovsky 
 Makefile.am|5 -
 common/Session.cpp |   89 ++--
 common/Session.hpp |   18 ++--
 kit/ChildSession.cpp   |2 
 kit/Kit.cpp|   10 +-
 test/Makefile.am   |3 
 wsd/ClientSession.cpp  |3 
 wsd/ClientSession.hpp  |1 
 wsd/DocumentBroker.cpp |3 
 wsd/LOOLWSD.cpp|  177 -
 10 files changed, 210 insertions(+), 101 deletions(-)

New commits:
commit 45188ec7c565a3d40cdc30fccdb7558b99430264
Author: Jan Holesovsky 
Date:   Fri Feb 24 20:52:36 2017 +0100

nb: Use the non-blocking socket in the loolwsd.

This so far only builds, but I did not even try to run it yet.

Change-Id: Iceacb5fc5c8994726508e8ea00bd495d758391a8

diff --git a/Makefile.am b/Makefile.am
index cc5f9f7..0a31018 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -25,7 +25,7 @@ endif
 ACLOCAL_AMFLAGS = -I m4
 
 # quick and easy for now.
-include_paths = -I${top_srcdir}/common -I${top_srcdir}/wsd -I${top_srcdir}/kit
+include_paths = -I${top_srcdir}/common -I${top_srcdir}/net -I${top_srcdir}/wsd 
-I${top_srcdir}/kit
 
 AM_CPPFLAGS = -pthread -DLOOLWSD_DATADIR='"@LOOLWSD_DATADIR@"' 
-DLOOLWSD_CONFIGDIR='"@LOOLWSD_CONFIGDIR@"' ${include_paths}
 AM_LDFLAGS = -pthread -Wl,-E
@@ -48,7 +48,8 @@ shared_sources = common/FileUtil.cpp \
  common/SpookyV2.cpp \
  common/Unit.cpp \
  common/UnitHTTP.cpp \
- common/Util.cpp
+ common/Util.cpp \
+ net/WebSocketHandler.cpp
 
 loolwsd_sources = wsd/Admin.cpp \
   wsd/AdminModel.cpp \
diff --git a/common/Session.cpp b/common/Session.cpp
index e30dce1..3f7fcca 100644
--- a/common/Session.cpp
+++ b/common/Session.cpp
@@ -26,7 +26,6 @@
 #include 
 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -35,7 +34,6 @@
 #include "Common.hpp"
 #include "IoUtil.hpp"
 #include "Protocol.hpp"
-#include 
 #include "Log.hpp"
 #include "TileCache.hpp"
 #include "Util.hpp"
@@ -44,13 +42,10 @@
 using namespace LOOLProtocol;
 
 using Poco::Exception;
-using Poco::Net::Socket;
-using Poco::Net::WebSocket;
 
-Session::Session(const std::string& name, const std::string& id, const 
std::shared_ptr& ws) :
+Session::Session(const std::string& name, const std::string& id) :
 _id(id),
 _name(name),
-_ws(ws),
 _disconnected(false),
 _isActive(true),
 _lastActivityTime(std::chrono::steady_clock::now()),
@@ -68,51 +63,19 @@ Session::~Session()
 bool Session::sendTextFrame(const char* buffer, const int length)
 {
 LOG_TRC(getName() << ": Send: " << getAbbreviatedMessage(buffer, length));
-try
-{
-std::unique_lock lock(_mutex);
-
-if (!_ws || _ws->poll(Poco::Timespan(0), 
Socket::SelectMode::SELECT_ERROR))
-{
-LOG_ERR(getName() << ": Bad socket while sending [" << 
getAbbreviatedMessage(buffer, length) << "].");
-return false;
-}
-
-_ws->sendFrame(buffer, length);
-return true;
-}
-catch (const Exception& exc)
-{
-LOG_ERR("Session::sendTextFrame: Exception: " << exc.displayText() <<
-(exc.nested() ? "( " + exc.nested()->displayText() + ")" : 
""));
-}
-
-return false;
+std::vector data(length);
+data.assign(buffer, buffer + length);
+sendMessage(data, WSOpCode::Text);
+return true;
 }
 
 bool Session::sendBinaryFrame(const char *buffer, int length)
 {
 LOG_TRC(getName() << ": Send: " << std::to_string(length) << " bytes.");
-try
-{
-std::unique_lock lock(_mutex);
-
-if (!_ws || _ws->poll(Poco::Timespan(0), 
Socket::SelectMode::SELECT_ERROR))
-{
-LOG_ERR(getName() << ": Bad socket while sending binary frame of " 
<< length << " bytes.");
-return false;
-}
-
-_ws->sendFrame(buffer, length, WebSocket::FRAME_BINARY);
-return true;
-}
-catch (const Exception& exc)
-{
-LOG_ERR("Session::sendBinaryFrame: Exception: " << exc.displayText() <<
-(exc.nested() ? "( " + exc.nested()->displayText() + ")" : 
""));
-}
-
-return false;
+std::vector data(length);
+data.assign(buffer, buffer + length);
+sendMessage(data);
+return true;
 }
 
 void Session::parseDocOptions(const std::vector& tokens, int& 
part, std::string& timestamp)
@@ -190,47 +153,43 @@ bool Session::handleDisconnect()
 
 void Session::shutdown(Poco::UInt16 statusCode, const std::string& 
statusMessage)
 {
-if (_ws)
-{
-LOG_TRC("Shutting down WS [" << getName() << "] with statusCode [" <<
-statusCode << "] and reason [" << statusMessage << "].");
+LOG_TRC("Shutting down WS [" << getName() << "] with statusCode [" <<
+statusCode << "] and reason [" << statusMessage << "].");
 
-// See protocol.txt for this application-level close frame.
-const

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - hwpfilter/source

2017-02-24 Thread Caolán McNamara 
 hwpfilter/source/hiodev.cxx |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit fddffda26287dec1f42a04bd40b8b2782982a7e0
Author: Caolán McNamara 
Date:   Thu Feb 23 12:17:33 2017 +

ofz: don't loop endlessly on failed skip

(cherry picked from commit a438651d2b94f14a2a0e54024f69280917df37b5)

Change-Id: Ibc105d8156e1b1ddf22948fb02165f8d03b4cfd5
Reviewed-on: https://gerrit.libreoffice.org/34576
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/hwpfilter/source/hiodev.cxx b/hwpfilter/source/hiodev.cxx
index 98001e9..48d105f 100644
--- a/hwpfilter/source/hiodev.cxx
+++ b/hwpfilter/source/hiodev.cxx
@@ -242,8 +242,12 @@ int HStreamIODev::skipBlock(int size)
   else{
 int remain = size;
 while(remain){
- if( remain > BUFSIZE )
-  remain -= GZREAD(rBuf, BUFSIZE);
+ if( remain > BUFSIZE ) {
+  int read = GZREAD(rBuf, BUFSIZE);
+  remain -= read;
+  if (read != BUFSIZE)
+  break;
+ }
  else{
   remain -= GZREAD(rBuf, remain);
   break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - hwpfilter/source

2017-02-24 Thread Caolán McNamara 
 hwpfilter/source/hiodev.cxx |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 0215845ddae1d0bb060a44d2cac0cf0f723024a5
Author: Caolán McNamara 
Date:   Thu Feb 23 12:17:33 2017 +

ofz: don't loop endlessly on failed skip

(cherry picked from commit a438651d2b94f14a2a0e54024f69280917df37b5)

Change-Id: Ibc105d8156e1b1ddf22948fb02165f8d03b4cfd5
Reviewed-on: https://gerrit.libreoffice.org/34608
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/hwpfilter/source/hiodev.cxx b/hwpfilter/source/hiodev.cxx
index a5e0357..b7be367 100644
--- a/hwpfilter/source/hiodev.cxx
+++ b/hwpfilter/source/hiodev.cxx
@@ -248,8 +248,12 @@ int HStreamIODev::skipBlock(int size)
   else{
 int remain = size;
 while(remain){
- if( remain > BUFSIZE )
-  remain -= GZREAD(rBuf, BUFSIZE);
+ if( remain > BUFSIZE ) {
+  int read = GZREAD(rBuf, BUFSIZE);
+  remain -= read;
+  if (read != BUFSIZE)
+  break;
+ }
  else{
   remain -= GZREAD(rBuf, remain);
   break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: download.lst

2017-02-24 Thread Eike Rathke 
 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 49e6d5e49673011149c94788a86cf899a54a8085
Author: Eike Rathke 
Date:   Fri Feb 24 20:58:36 2017 +0100

update to language-subtag-registry-2017-01-20

Change-Id: Ia62815e19b3414b6ba78c70ccb2520a0836b22c4

diff --git a/download.lst b/download.lst
index 50136f8..5faff1d 100644
--- a/download.lst
+++ b/download.lst
@@ -83,8 +83,8 @@ export JPEG_MD5SUM := 3353992aecaee1805ef4109aadd433e7
 export JPEG_TARBALL := jpegsrc.v9a.tar.gz
 export JPEG_TURBO_MD5SUM := 55deb139b0cac3c8200b75d485fc13f3
 export JPEG_TURBO_TARBALL := libjpeg-turbo-1.5.1.tar.gz
-export LANGTAGREG_MD5SUM := 8a037dc60b16bf8c5fe871b33390a4a2
-export LANGTAGREG_TARBALL := language-subtag-registry-2016-07-19.tar.bz2
+export LANGTAGREG_MD5SUM := 36b8266c1ec4a5049c3e0637a671fbd9
+export LANGTAGREG_TARBALL := language-subtag-registry-2017-01-20.tar.bz2
 export LANGUAGETOOL_TARBALL := 
b63e6340a02ff1cacfeadb2c42286161-JLanguageTool-1.7.0.tar.bz2
 export LCMS2_MD5SUM := 87a5913f1a52464190bb655ad230539c
 export LCMS2_TARBALL := lcms2-2.8.tar.gz
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: sha1sum problem

2017-02-24 Thread Michael Stahl 
On 24.02.2017 16:45, Bryan Quigley wrote:
> I'm going to look at adding the SHA256SUM for all the files in
> download.lst.  It looks like we can add them without breaking
> anything.  Then we can test out how we want to switch or if we need to
> support both for a bit (platform dependent?).

right, and as just discussed on IRC that can even be done without having
to rename all the md5-containing filenames on the server, by adding a
variable for the SHA256SUM and just ignoring the hash contained in the
filename.

> On Fri, Feb 24, 2017 at 10:25 AM, Stephan Bergmann  
> wrote:
>> On 02/24/2017 03:47 PM, Norbert Thiebaud wrote:
>>>
>>> The situation with checksum of 'external' files is much worse that you
>>> thought.
>>> They are actually checked with md5.
>>> That being said they are not truly external, since they are hosted on
>>> the project infrastructure

>>> and the original motivation was not so much malicious injection
>>> detection but faulty transfer.
>>> using sha1 there would actually be an 'improvement' :-)

actually AFAICS the MD5 usage here is not currently a problem.

there are 2 different problems with hash functions, collision attacks
and preimage attacks.

https://en.wikipedia.org/wiki/Preimage_attack

the big news about SHA1 is that somebody successfully performed a
collision attack, where they created 2 files from scratch that have the
same SHA1.

but here we have files that already exist and worry[1] that someone
could create another file with the same hash - that is a preimage attack.

https://en.wikipedia.org/wiki/MD5#Preimage_vulnerability

"In April 2009, a preimage attack against MD5 was published that breaks
MD5's preimage resistance. This attack is only theoretical, with a
computational complexity of 2^123.4 for full preimage."

the SHA1 collision brute-force require 2^80, and less with some clever
mathematical insight, so md5 preimage appears at least 2^43 harder.

still, if somebody wants to implement using a better hash function,
there is no reason to object :)

[1] unless the upstream that creates the tarball is actively malicious,
but in that case we have other problems


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Chart test failures on mac: text size differences

2017-02-24 Thread Khaled Hosny 
On Fri, Feb 24, 2017 at 05:41:25PM +, Tamas Zolnai wrote:
> Hi Khaled,
> 
> I see you're working on text rendering, so I thought that my findings
> might be usefull for you. I had a look at chart test failures on Mac
> and found that it is because of text size differences. (I checked your
> latest change [1], but the differences are still there.)
> Both text width and height is different (comparing Windows and Mac).
> Interestingly when I changed the font to a bundled, monospace font
> (e.g. Liberation Mono, DejaVu Sans Mono), width differences
> disappeared and only height differences remained. So there are at
> least two kind of issues here. One which is about the proportional
> fonts character width and one related to the text height.
> I added a minimal test case to the source [2] with which it's easier
> to debug the second issue (for the first issue the test case's font
> need to be changed to a bundled, proportional font).

We need to first who Chart is calculating the text width and depth,
namely which function(s) it uses from vcl, to be able to debug it and
see where are these differences coming from.

Regards,
Khaled
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105855] Some drop-down menus higher than others

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105855

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-02-24 Thread Eike Rathke 
 sc/source/ui/view/tabview4.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 6db32fab2ecdf94bbbfc8efdb10a105aaf3a0fbc
Author: Eike Rathke 
Date:   Fri Feb 24 19:59:41 2017 +0100

adapt comment to reality

The code now does what the original questioning comment suggested.

Change-Id: I359c99a30d2e6822fe9164bb9f903876095c9f6f

diff --git a/sc/source/ui/view/tabview4.cxx b/sc/source/ui/view/tabview4.cxx
index 89fe6d9..b93fab3 100644
--- a/sc/source/ui/view/tabview4.cxx
+++ b/sc/source/ui/view/tabview4.cxx
@@ -91,8 +91,7 @@ void ScTabView::ShowRefTip()
 
 Rectangle aRect( pWin->OutputToScreenPixel( aPos ), Size(1,1) 
);
 
-//! Test, ob geaendert ??
-
+// Test if changed.
 if (!nTipVisible || nFlags != nTipAlign || aRect != 
aTipRectangle || sTipString != aHelp || sTopParent != pWin)
 {
 HideTip();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=72504

--- Comment #31 from Justin L  ---
(In reply to Justin L from comment #30)
> It's a long shot, but do you want to try again and see if it is fixed now
> (in 5.2.4 or higher).  There was a similar sounding .xls problem in Bug
> 62625 that has been resolved.
I should have tested myself first.  No, that doesn't work in this situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=72504

--- Comment #30 from Justin L  ---
(In reply to Guillermo Lo Coco from comment #26)
> Maybe you can point me out an alternative.
It's a long shot, but do you want to try again and see if it is fixed now (in
5.2.4 or higher).  There was a similar sounding .xls problem in Bug 62625 that
has been resolved.

Alternatively, I know you don't want an fstab solution, but perhaps if you add
options ,noauto,x-systemd.automount it might be acceptable?  Then the mount
will only happen if you try to access the database folder, and not
automatically on every start.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83983] FILEOPEN: Regression in 4.4 master loading an ODT which contains a style with style :font-independent-line-spacing="true"

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83983

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from Justin L  ---
Some clarity is needed on this bug report.  The inability to open was resolved
already in 4.4development.

This is a very odd document.  The text is in color WHITE, and it is only a blue
frame (without any associated textbox) in the background that makes the white
characters visible. The page size is huge 90cm x 140cm

In 4.3, it looks like the AREA color spills far outside of the frame.  That was
fixed in 4.4 by Miklos Vajna CommitDate: Tue Jun 17 01:16:20 2014 +0200
svx: fix VML export of rectangles imported from drawingML

Closing this bug. The specific problem of not being able to open has been
resolved. The vague "mis-rendering" problem is only because something broken
was tweaked to look like nice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106175] Help viewer: tag is not supported in localized (l10n) help

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106175

Laurent BP  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Laurent BP  ---
Thanks Jacques for your confirmation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106174] FILEOPEN: Paragraph alignment inherited from parent style not loaded from docx file

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106174

Aron Budea  changed:

   What|Removed |Added

   Priority|medium  |high
 Blocks||104520
 Whiteboard||interoperability

--- Comment #7 from Aron Budea  ---
This bug started with the comment referenced below. I assume there's no point
in CC-ing anyone from KACST.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837
author  Faisal M. Al-Otaibi    2013-11-15
15:09:21 (GMT)
committer   Faisal M. Al-Otaibi    2013-11-15
15:16:36 (GMT)

"DOCX:fdo#71646 fix wrong direction when save the file."


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104520] [META] DOCX (OOXML) bug tracker

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104520

Aron Budea  changed:

   What|Removed |Added

 Depends on||106174


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106174
[Bug 106174] FILEOPEN: Paragraph alignment inherited from parent style not
loaded from docx file
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106174] FILEOPEN: Paragraph alignment inherited from parent style not loaded from docx file

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106174

Aron Budea  changed:

   What|Removed |Added

   Keywords||bisected

--- Comment #6 from Aron Budea  ---
f2e68c240c286653a944401b117756b3f8e89a71 is the first bad commit
commit f2e68c240c286653a944401b117756b3f8e89a71
Author: Matthew Francis 
Date:   Sat Sep 5 23:01:58 2015 +0800

source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837

commit 84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837
Author: Faisal M. Al-Otaibi 
AuthorDate: Fri Nov 15 18:09:21 2013 +0300
Commit: Faisal M. Al-Otaibi 
CommitDate: Fri Nov 15 18:16:36 2013 +0300

DOCX:fdo#71646 fix wrong direction when save the file.

Change-Id: I6f3dcf1007e91551e1f3335f4c40424add1c45c3

# bad: [6ae1bee52feeb4b006fb472cd3a073902d3d2c1a]
source-hash-d00e0bcd60304835f5c10a71b22b6a4f483dd6ec
# good: [47243472f676e7bd3c4bc3732a57be69d5371447]
source-hash-d7867b28623e4220f62b8ed9259bed5d8878a3b3
git bisect start '6ae1bee52feeb4b006fb472cd3a073902d3d2c1a'
'47243472f676e7bd3c4bc3732a57be69d5371447'
# bad: [e1240a17572838c4aa9b53b92c51d3f65705ca65]
source-hash-b8a4abdda4e6a95535992c26a906226ede7f050a
git bisect bad e1240a17572838c4aa9b53b92c51d3f65705ca65
# bad: [c4c07bb40b76318048298abc8f826dbe837d5a2d]
source-hash-3ea4d26865c645fa76ea77bb94f084b2a435e20a
git bisect bad c4c07bb40b76318048298abc8f826dbe837d5a2d
# good: [b9fadd8d3b9371c753e1fd7be02e6d72aa8315f0]
source-hash-6abfb890a2fad1931a79d53018f932205a668264
git bisect good b9fadd8d3b9371c753e1fd7be02e6d72aa8315f0
# bad: [01c62e8bda11becc51550f17d339c368a8f95f2f]
source-hash-8b853bde21ca26a44207f791d9ef8f07f1202f6a
git bisect bad 01c62e8bda11becc51550f17d339c368a8f95f2f
# good: [1f932d7e1981ec10922465e0c4f7ed83855d03fa]
source-hash-2dec3d1d4f3e91ce005bb3b5362b826e7c7590c8
git bisect good 1f932d7e1981ec10922465e0c4f7ed83855d03fa
# good: [5c734aba6b3554be6e9760d143de5801aab6732f]
source-hash-13d36ad94937fa278690a5cc5287e8997aecb10f
git bisect good 5c734aba6b3554be6e9760d143de5801aab6732f
# good: [29f53505ee34f1dad8456e2dcf1666ae2a8fcd59]
source-hash-9389cf78e304a5a99bcf1745b9388e14ac36281a
git bisect good 29f53505ee34f1dad8456e2dcf1666ae2a8fcd59
# bad: [f2e68c240c286653a944401b117756b3f8e89a71]
source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837
git bisect bad f2e68c240c286653a944401b117756b3f8e89a71
# first bad commit: [f2e68c240c286653a944401b117756b3f8e89a71]
source-hash-84b3d6dc3a7d5ba52b00285e59e7aa6b5ca15837

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102058] No screen reader notification that there is a comment

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102058

Buovjaga  changed:

   What|Removed |Added

  Component|LibreOffice |Calc

--- Comment #2 from Buovjaga  ---
Created a separate report for Writer by dev request: bug 106180

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106180] No screen reader notification that there is a comment

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106180

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106180] New: No screen reader notification that there is a comment

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106180

Bug ID: 106180
   Summary: No screen reader notification that there is a comment
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: accessibility
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: todven...@suomi24.fi
Blocks: 101912, 106179

When you navigate by keyboard on a piece of text that has a comment, there is
no screen reader notification about the comment. This is similar to the feature
of being notified that a word is mispelt.

Split from bug 102058 per developer request.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
[Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179
[Bug 106179] [META] Writer comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101912

Buovjaga  changed:

   What|Removed |Added

 Depends on||106180


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106180
[Bug 106180] No screen reader notification that there is a comment
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106179

Buovjaga  changed:

   What|Removed |Added

 Depends on||106180


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106180
[Bug 106180] No screen reader notification that there is a comment
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sc/source

2017-02-24 Thread Caolán McNamara 
 sc/source/ui/inc/tabview.hxx   |5 +
 sc/source/ui/view/tabview.cxx  |1 +
 sc/source/ui/view/tabview4.cxx |   26 ++
 3 files changed, 28 insertions(+), 4 deletions(-)

New commits:
commit 0acb7b80667b83ad05782dafa23721d0030c3b16
Author: Caolán McNamara 
Date:   Mon Feb 20 15:40:31 2017 +

Resolves: tdf#105854 retain popover if it has the same pos, size and 
settings

Change-Id: I102874867020a3c471567cbdc97162c564351635
Reviewed-on: https://gerrit.libreoffice.org/34485
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index 948f599..0056063 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -20,6 +20,7 @@
 #define INCLUDED_SC_SOURCE_UI_INC_TABVIEW_HXX
 
 #include 
+#include 
 
 #include 
 
@@ -169,6 +170,10 @@ private:
 ScExtraEditViewManager aExtraEditViewManager;
 
 sal_uLong   nTipVisible;
+Rectangle   aTipRectangle;
+QuickHelpFlags  nTipAlign;
+OUStringsTipString;
+VclPtr sTopParent;
 
 longnPrevDragPos;
 
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 81ae3c7..e12b89a 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -210,6 +210,7 @@ ScTabView::ScTabView( vcl::Window* pParent, ScDocShell& 
rDocSh, ScTabViewShell*
 pTimerWindow( nullptr ),
 aExtraEditViewManager( pViewShell, pGridWin ),
 nTipVisible( 0 ),
+nTipAlign( QuickHelpFlags::NONE ),
 nPrevDragPos( 0 ),
 meBlockMode(None),
 nBlockStartX( 0 ),
diff --git a/sc/source/ui/view/tabview4.cxx b/sc/source/ui/view/tabview4.cxx
index fbb40fa..772677c 100644
--- a/sc/source/ui/view/tabview4.cxx
+++ b/sc/source/ui/view/tabview4.cxx
@@ -41,6 +41,10 @@ void ScTabView::HideTip()
 vcl::Window* pWin = pGridWin[eWhich];
 Help::HidePopover(pWin, nTipVisible);
 nTipVisible = 0;
+aTipRectangle = Rectangle();
+nTipAlign = QuickHelpFlags::NONE;
+sTipString.clear();
+sTopParent.clear();
 }
 }
 
@@ -91,8 +95,15 @@ void ScTabView::ShowRefTip()
 
 //! Test, ob geaendert ??
 
-HideTip();
-nTipVisible = Help::ShowPopover(pWin, aRect, aHelp, nFlags);
+if (!nTipVisible || nFlags != nTipAlign || aRect != 
aTipRectangle || sTipString != aHelp || sTopParent != pWin)
+{
+HideTip();
+nTipVisible = Help::ShowPopover(pWin, aRect, aHelp, 
nFlags);
+aTipRectangle = aRect;
+nTipAlign = nFlags;
+sTipString = aHelp;
+sTopParent = pWin;
+}
 bDone = true;
 }
 }
@@ -278,8 +289,15 @@ void ScTabView::UpdateRef( SCCOL nCurX, SCROW nCurY, SCTAB 
nCurZ )
 aPos = pWin->OutputToScreenPixel( aPos );
 Rectangle aRect( aPos, aPos );
 QuickHelpFlags nAlign = 
QuickHelpFlags::Left|QuickHelpFlags::Top;
-HideTip();
-nTipVisible = Help::ShowPopover(pWin, aRect, aHelpStr, nAlign);
+if (!nTipVisible || nAlign != nTipAlign || aRect != 
aTipRectangle || sTipString != aHelpStr || sTopParent != pWin)
+{
+HideTip();
+nTipVisible = Help::ShowPopover(pWin, aRect, aHelpStr, 
nAlign);
+aTipRectangle = aRect;
+nTipAlign = nAlign;
+sTipString = aHelpStr;
+sTopParent = pWin;
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101216] [META] Comment bugs and enhancements

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 83065, which changed state.

Bug 83065 Summary: Allow Comment Location to be Moved Upon Creation of Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=83065

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83065] Allow Comment Location to be Moved Upon Creation of Comment

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83065

Buovjaga  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||todven...@suomi24.fi
 Resolution|--- |DUPLICATE

--- Comment #3 from Buovjaga  ---


*** This bug has been marked as a duplicate of bug 68695 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68695] EDITING: Comments cannot be resized while editing - missing squares around the comment /note

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=68695

Buovjaga  changed:

   What|Removed |Added

 CC||didier.t...@free.fr

--- Comment #32 from Buovjaga  ---
*** Bug 83065 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: rsc/Executable_rsc.mk

2017-02-24 Thread Caolán McNamara 
 rsc/Executable_rsc.mk |5 +
 1 file changed, 5 insertions(+)

New commits:
commit a14efb9b2c9d0235c5cac1879068a02b25da9b31
Author: Caolán McNamara 
Date:   Fri Feb 24 16:30:43 2017 +

start to get make fuzzers working again

Change-Id: I36dc621e8a69bf6d22fdce62bb7de6c18208931d

diff --git a/rsc/Executable_rsc.mk b/rsc/Executable_rsc.mk
index 2f77a89..18030f5 100644
--- a/rsc/Executable_rsc.mk
+++ b/rsc/Executable_rsc.mk
@@ -31,6 +31,11 @@ $(eval $(call gb_Executable_use_libraries,rsc,\
$(gb_UWINAPI) \
 ))
 
+$(eval $(call gb_Executable_use_externals,rsc,\
+$(if $(filter TRUE,$(DISABLE_DYNLOADING)),liblangtag) \
+$(if $(filter TRUE,$(DISABLE_DYNLOADING)),libxml2) \
+))
+
 $(eval $(call gb_Executable_add_grammars,rsc,\
rsc/source/parser/rscyacc \
 ))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Chart test failures on mac: text size differences

2017-02-24 Thread Tamas Zolnai 
Hi Khaled,

I see you're working on text rendering, so I thought that my findings might be 
usefull for you. I had a look at chart test failures on Mac and found that it 
is because of text size differences. (I checked your latest change [1], but the 
differences are still there.)
Both text width and height is different (comparing Windows and Mac). 
Interestingly when I changed the font to a bundled, monospace font (e.g. 
Liberation Mono, DejaVu Sans Mono), width differences disappeared and only 
height differences remained. So there are at least two kind of issues here. One 
which is about the proportional fonts character width and one related to the 
text height.
I added a minimal test case to the source [2] with which it's easier to debug 
the second issue (for the first issue the test case's font need to be changed 
to a bundled, proportional font).

[1] 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=04d086531ff4a3ab24b704489270c7c23792bd20
[2] 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4b8cb3e3b9c597108697f46bcc93045b06cc0633

Best Regards,
Tamás

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106178] Page break slow repaint

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106178

--- Comment #3 from Dmitry  ---
I have downloaded and installed previous version
(LibreOffice_5.2.5_Linux_x86-64_deb.tar.gz), does not have this 
bug. My video-card is "ATI Mobility Radeon HD5400".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106176] Custom animation Emphasis "Spin" does not

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106176

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #1 from Regina Henschel  ---
Please try, whether a number of repeats work. The problem with "until slide
ends" is already tracked in bug 77186. If you have no other problems in case of
a number repeat count, this would be a duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-02-24 Thread Eike Rathke 
 sc/source/core/tool/interpr5.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9f77a73e2da7da51b318699c477aa071c0b8c324
Author: Eike Rathke 
Date:   Fri Feb 24 18:19:35 2017 +0100

grml.. and do that right

Change-Id: I71bc423bde1f7df576175120741c8a08100b08dd

diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx
index 1fba10b..efd1029 100644
--- a/sc/source/core/tool/interpr5.cxx
+++ b/sc/source/core/tool/interpr5.cxx
@@ -759,7 +759,7 @@ static void lcl_LUP_solve( const ScMatrix* mLU, const 
SCSIZE n,
 fSum -= mLU->GetDouble( j, i) * X[j];   // X[j] === x[j]
 X[i] = fSum / mLU->GetDouble( i, i);// X[i] === x[i]
 }
-#if DEBUG_SC_LUP_DECOMPOSITION
+#ifdef DEBUG_SC_LUP_DECOMPOSITION
 fprintf( stderr, "\n%s\n", "lcl_LUP_solve():");
 for (SCSIZE i=0; i < n; ++i)
 fprintf( stderr, "%8.2g  ", X[i]);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106178] Page break slow repaint

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106178

--- Comment #2 from Dmitry  ---
Created attachment 131458
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131458=edit
page footer during repaint

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106178] Page break slow repaint

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106178

--- Comment #1 from Dmitry  ---
Created attachment 131457
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131457=edit
page break during repaint

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106178] New: Page break slow repaint

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106178

Bug ID: 106178
   Summary: Page break slow repaint
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: udv.my...@gmail.com

Description:
When during mouse scroll page break become visible it is repainted twice time
per single mouse scroll. During repaint I see ow dashes are running from left
to right. This process takes about 3 seconds.


Steps to Reproduce:
1. open libreoffice writer
2. insert page break by CTRL+ENTER
3. scroll mouse down, wait until page interval will become visible
Reboot does not help.
Also this happens when page Headers and Footers lines are becoming visible.


Actual Results:  
CPU load during repainting for several seconds.


Expected Results:
Quick repaint.



Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-02-24 Thread Eike Rathke 
 sc/source/core/tool/interpr5.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7c6902cf8f19fc944c6d9e66cdb27887961301a5
Author: Eike Rathke 
Date:   Fri Feb 24 18:14:44 2017 +0100

replace a leftover OSL_DEBUG_LEVEL >1

Change-Id: Ic5e5e72a2c79e68752c3108de9f3722fbcb8e7b3

diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx
index fe3b6e4..1fba10b 100644
--- a/sc/source/core/tool/interpr5.cxx
+++ b/sc/source/core/tool/interpr5.cxx
@@ -759,7 +759,7 @@ static void lcl_LUP_solve( const ScMatrix* mLU, const 
SCSIZE n,
 fSum -= mLU->GetDouble( j, i) * X[j];   // X[j] === x[j]
 X[i] = fSum / mLU->GetDouble( i, i);// X[i] === x[i]
 }
-#if OSL_DEBUG_LEVEL >1
+#if DEBUG_SC_LUP_DECOMPOSITION
 fprintf( stderr, "\n%s\n", "lcl_LUP_solve():");
 for (SCSIZE i=0; i < n; ++i)
 fprintf( stderr, "%8.2g  ", X[i]);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/qa

2017-02-24 Thread Tamás Zolnai 
 chart2/qa/extras/chart2dump/chart2dump.cxx   |
3 
 chart2/qa/extras/chart2dump/data/minimal_legend_test.odp 
|binary
 chart2/qa/extras/chart2dump/reference/legendtest/minimal_legend_test.txt |   
32 ++
 3 files changed, 34 insertions(+), 1 deletion(-)

New commits:
commit 4b8cb3e3b9c597108697f46bcc93045b06cc0633
Author: Tamás Zolnai 
Date:   Fri Feb 24 15:43:54 2017 +0100

ChartDumpTest: Add a minimal test showing text size issue

Change-Id: Iea0f7f6cfaee546c3478b936053659b3ecd27e6c
Reviewed-on: https://gerrit.libreoffice.org/34617
Tested-by: Jenkins 
Reviewed-by: Tamás Zolnai 

diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx 
b/chart2/qa/extras/chart2dump/chart2dump.cxx
index 99515de..bd25d20 100755
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -403,7 +403,8 @@ DECLARE_DUMP_TEST(LegendTest, Chart2DumpTest, false)
 "legend_on_top.odp",
 "many_legend_entries.odp",
 "custom_legend_position.odp",
-"multiple_categories.odp"
+"multiple_categories.odp",
+"minimal_legend_test.odp"
 };
 
 for (const OUString& aTestFile : aTestFiles)
diff --git a/chart2/qa/extras/chart2dump/data/minimal_legend_test.odp 
b/chart2/qa/extras/chart2dump/data/minimal_legend_test.odp
new file mode 100755
index 000..63911f1
Binary files /dev/null and 
b/chart2/qa/extras/chart2dump/data/minimal_legend_test.odp differ
diff --git 
a/chart2/qa/extras/chart2dump/reference/legendtest/minimal_legend_test.txt 
b/chart2/qa/extras/chart2dump/reference/legendtest/minimal_legend_test.txt
new file mode 100755
index 000..00f666c
--- /dev/null
+++ b/chart2/qa/extras/chart2dump/reference/legendtest/minimal_legend_test.txt
@@ -0,0 +1,32 @@
+// aLegendPosition.X
+15382
+// aLegendPosition.Y
+4235
+// aLegendSize.Width
+2404
+// aLegendSize.Height
+545
+// nLegendEntryCount
+1
+// aLegendEntryPosition.X
+15498
+// aLegendEntryPosition.Y
+4402
+// aLegendEntrySize.Height
+211
+// aLegendEntrySize.Width
+800
+// aLegendEntryTransformation
+801;0;15498;0;212;4402;0;0;1
+// xLegendEntryContainer->getCount()
+3
+// sEntryGeomShapeType
+com.sun.star.drawing.LineShape
+// static_cast(aEntryGeomColor)
+7512015
+// sEntryGeomShapeType
+com.sun.star.drawing.PolyPolygonShape
+// static_cast(aEntryGeomColor)
+17798
+// xLegendEntryText->getString()
+Inkjet
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106169] LibreOffice won' t save new data created in a document file and errors out. Can' t close program unless selecting "cancel edit". If selecting cancel edit, then LibreOff

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106169

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Also need this info:

What LO module? Writer, Calc, Draw, Impress?

What build of Apple hardware and GPU?

Does this happen with a newly created document?  And, if that is saved and
reopened does it happen then?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'private/Ashod/nonblocking' - net/loolnb.cpp net/Socket.hpp net/WebSocketHandler.hpp

2017-02-24 Thread Michael Meeks 
 net/Socket.hpp   |   15 +++
 net/WebSocketHandler.hpp |5 +-
 net/loolnb.cpp   |   89 ++-
 3 files changed, 69 insertions(+), 40 deletions(-)

New commits:
commit 0903776a57fda95ea6b59e33a632636c585cf0c1
Author: Michael Meeks 
Date:   Fri Feb 24 16:45:31 2017 +

Cleanup logging, and add message tracing / dumper.

diff --git a/net/Socket.hpp b/net/Socket.hpp
index 08112c5..59be92b 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -27,6 +27,8 @@
 
 #include 
 
+#include "Log.hpp"
+
 /// A non-blocking, streaming socket.
 class Socket
 {
@@ -321,6 +323,13 @@ public:
 // Always try to read.
 closeSocket = !readIncomingData();
 
+auto& log = Log::logger();
+if (log.trace()) {
+LOG_TRC("Incoming data buffer " << _inBuffer.size() <<
+" closeSocket? " << closeSocket << "\n");
+log.dump("", &_inBuffer[0], _inBuffer.size());
+}
+
 // If we have data, allow the app to consume.
 size_t oldSize = 0;
 while (!_inBuffer.empty() && oldSize != _inBuffer.size())
@@ -383,6 +392,12 @@ public:
 do
 {
 len = writeData(&_outBuffer[0], _outBuffer.size());
+
+auto& log = Log::logger();
+if (log.trace()) {
+LOG_TRC("Wrote outgoing data " << len << " bytes\n");
+log.dump("", &_outBuffer[0], len);
+}
 }
 while (len < 0 && errno == EINTR);
 
diff --git a/net/WebSocketHandler.hpp b/net/WebSocketHandler.hpp
index 286ac53..324da6b 100644
--- a/net/WebSocketHandler.hpp
+++ b/net/WebSocketHandler.hpp
@@ -10,6 +10,7 @@
 #ifndef INCLUDED_WEBSOCKETHANDLER_HPP
 #define INCLUDED_WEBSOCKETHANDLER_HPP
 
+#include "Log.hpp"
 #include "Socket.hpp"
 
 class WebSocketHandler : public SocketHandlerInterface
@@ -55,7 +56,7 @@ public:
 /// Implementation of the SocketHandlerInterface.
 virtual void handleIncomingMessage() override
 {
-std::cerr << "incoming message with buffer size " << 
_socket->_inBuffer.size() << "\n";
+LOG_TRC("incoming WebSocket message");
 if (_wsState == HTTP)
 {
 handleWebsocketUpgrade();
@@ -129,7 +130,7 @@ public:
 }
 
 void sendMessage(const std::vector ,
-WSOpCode code = WSOpCode::Binary)
+ WSOpCode code = WSOpCode::Binary)
 {
 size_t len = data.size();
 bool fin = false;
diff --git a/net/loolnb.cpp b/net/loolnb.cpp
index 201f8a4..489cfa7 100644
--- a/net/loolnb.cpp
+++ b/net/loolnb.cpp
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -145,54 +146,66 @@ void server(const Poco::Net::SocketAddress& addr, 
SocketPoll& clientPoller,
 }
 }
 
-int main(int argc, const char**argv)
+class LOOLNB : public Poco::Util::ServerApplication
 {
-// TODO: These would normally come from config.
-SslContext::initialize("/etc/loolwsd/cert.pem",
-   "/etc/loolwsd/key.pem",
-   "/etc/loolwsd/ca-chain.cert.pem");
-
-// Used to poll client sockets.
-SocketPoll poller;
-
-// Start the client polling thread.
-Thread threadPoll([](std::atomic& stop)
+public:
+int main(const std::vector& args) override
 {
-while (!stop)
+const char* logLevel = std::getenv("LOOL_LOGLEVEL");
+std::map props;
+if (logLevel)
+Log::initialize("loolnb", logLevel ? logLevel : "",
+false, false, props);
+
+// TODO: These would normally come from config.
+SslContext::initialize("/etc/loolwsd/cert.pem",
+   "/etc/loolwsd/key.pem",
+   "/etc/loolwsd/ca-chain.cert.pem");
+
+// Used to poll client sockets.
+SocketPoll poller;
+
+// Start the client polling thread.
+Thread threadPoll([](std::atomic& stop)
+  {
+  while (!stop)
+  {
+  poller.poll(5000);
+  }
+  });
+
+class PlainSocketFactory : public SocketFactory
 {
-poller.poll(5000);
-}
-});
+std::shared_ptr create(const int fd) override
+{
+return std::make_shared(fd, new 
SimpleResponseClient());
+}
+};
 
-class PlainSocketFactory : public SocketFactory
-{
-std::shared_ptr create(const int fd) override
+class SslSocketFactory : public SocketFactory
 {
-return std::make_shared(fd, new 
SimpleResponseClient());
-}
-};
+std::shared_ptr create(const int fd) override
+

[Libreoffice-commits] core.git: sw/source

2017-02-24 Thread Stephan Bergmann 
 sw/source/core/layout/atrfrm.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 653a3c259905a1d05b471423821bc83da7f9ef20
Author: Stephan Bergmann 
Date:   Fri Feb 24 17:41:24 2017 +0100

loplugin:loopvartoosmall

Change-Id: Ic85a715e11bc1eac531fa23e8b4a9b6c6520b862

diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx
index 7b16eaa..d55d6ba 100644
--- a/sw/source/core/layout/atrfrm.cxx
+++ b/sw/source/core/layout/atrfrm.cxx
@@ -1020,9 +1020,8 @@ void SwFormatCol::Calc( sal_uInt16 nGutterWidth, 
sal_uInt16 nAct )
 rLastCol.SetRight(0);
 
 //Convert the current width to the requested width.
-for (sal_uInt16 i = 0; i < m_aColumns.size(); ++i)
+for (SwColumn : m_aColumns)
 {
-SwColumn  = m_aColumns[i];
 long nTmp = rCol.GetWishWidth();
 nTmp *= GetWishWidth();
 nTmp /= nAct;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/qa include/editeng

2017-02-24 Thread Varun Dhall 
 editeng/qa/unit/core-test.cxx |   36 
 include/editeng/editeng.hxx   |   10 +-
 2 files changed, 41 insertions(+), 5 deletions(-)

New commits:
commit 685767dbe7dc6677eaee8edf3c9f94105705fafa
Author: Varun Dhall 
Date:   Wed Feb 22 21:57:44 2017 +0530

Added Test for EditEngine - Copy/Paste using Legacy Format

Change-Id: I3153010f4e327abd2ef48bdefa50ade1c0ba2f81
Reviewed-on: https://gerrit.libreoffice.org/34552
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index 8048fea..23defaa 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -52,6 +52,9 @@ public:
 /// AutoCorrect tests
 void testAutocorrect();
 
+/// Test Copy/Paste using Legacy Format
+void testCopyPaste();
+
 /// Test hyperlinks
 void testHyperlinkSearch();
 
@@ -61,6 +64,7 @@ public:
 CPPUNIT_TEST(testConstruction);
 CPPUNIT_TEST(testUnoTextFields);
 CPPUNIT_TEST(testAutocorrect);
+CPPUNIT_TEST(testCopyPaste);
 CPPUNIT_TEST(testHyperlinkSearch);
 CPPUNIT_TEST(testSectionAttributes);
 CPPUNIT_TEST_SUITE_END();
@@ -363,6 +367,38 @@ void Test::testAutocorrect()
 }
 }
 
+void Test::testCopyPaste()
+{
+// Create EditEngine's instance
+EditEngine aEditEngine( mpItemPool );
+
+// Get EditDoc for current EditEngine's instance
+EditDoc  = aEditEngine.GetEditDoc();
+
+// Initially no text should be there
+CPPUNIT_ASSERT_EQUAL( sal_uLong(0), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString(""), rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Set initial text
+OUString aText = "This is custom initial text";
+sal_Int32 aTextLen = aText.getLength();
+aEditEngine.SetText( aText );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( aText, rDoc.GetParaAsString(sal_Int32(0)) );
+
+// Copy initial text using legacy format
+uno::Reference< datatransfer::XTransferable > xData = 
aEditEngine.CreateTransferable( ESelection(0,0,0,aTextLen) );
+
+// Paste text at the end
+aEditEngine.InsertText( xData, OUString(), rDoc.GetEndPaM(), true );
+
+// Assert changes
+CPPUNIT_ASSERT_EQUAL( sal_uLong(aTextLen + aTextLen), rDoc.GetTextLen() );
+CPPUNIT_ASSERT_EQUAL( OUString(aText + aText), 
rDoc.GetParaAsString(sal_Int32(0)) );
+}
+
 namespace {
 class UrlEditEngine : public EditEngine
 {
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index d3e3f7e..921b60f 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -157,6 +157,10 @@ class EDITENG_DLLPUBLIC EditEngine
 public:
 typedef std::vector ViewsType;
 
+EditSelection InsertText(
+css::uno::Reference const & 
rxDataObj,
+const OUString& rBaseURL, const EditPaM& rPaM, bool bUseSpecial);
+
 private:
 std::unique_ptr  pImpEditEngine;
 
@@ -175,10 +179,6 @@ private:
 css::datatransfer::XTransferable>
 CreateTransferable(const EditSelection& rSelection);
 
-EDITENG_DLLPRIVATE EditSelection InsertText(
-css::uno::Reference const & 
rxDataObj,
-const OUString& rBaseURL, const EditPaM& rPaM, bool bUseSpecial);
-
 EDITENG_DLLPRIVATE EditPaM EndOfWord(const EditPaM& rPaM);
 
 EDITENG_DLLPRIVATE EditPaM GetPaM(const Point& aDocPos, bool bSmart = 
true);
@@ -370,7 +370,7 @@ public:
 voidDraw( OutputDevice* pOutDev, const Rectangle& rOutRect, 
const Point& rStartDocPos, bool bClip );
 voidDraw( OutputDevice* pOutDev, const Point& rStartPos, short 
nOrientation = 0 );
 
-//  sal_uInt32: Error code of the stream.
+//  sal_uInt32: Error code of the stream.
 sal_uLong   Read( SvStream& rInput, const OUString& rBaseURL, 
EETextFormat, SvKeyValueIterator* pHTTPHeaderAttrs = nullptr );
 voidWrite( SvStream& rOutput, EETextFormat );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 81426] FILESAVE: Data from header and footer is getting lost

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=81426

Justin L  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||jl...@mail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106177] New: copy and paste special (formulas only) destroys merged cells

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106177

Bug ID: 106177
   Summary: copy and paste special (formulas only) destroys merged
cells
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: byrn...@harte-lyne.ca

If a formula is entered into a cell that has been merged with adjacent cells
and that cell is then copied and pasted (special) into another group of merged
cells with only the formula specified then the merged target cells are split. 
They then need to be manually merged again.

This happens if only one group of merged cells are copied from/to or if an
entire row is copied.  If the formatting is copied as well then the format from
the source is properly applied to the target, which in the present case, is not
desired.

This happens on Linux as well as the Microsoft versions of LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106176] New: Custom animation Emphasis "Spin" does not

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106176

Bug ID: 106176
   Summary: Custom animation Emphasis "Spin" does not
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gregor.shap...@gmail.com

Description:
Custom animation "Spin" dosn't do anything to the shape I have tried to apply
it to.

Steps to Reproduce:
1.On a slide create a shape 
2.Go to the   item 
3.Select the shape choose  select "Emphasis"; "Spin" 
4.Choose whatever options you want (I didn't ever get it to preview or play
during a slideshow)I chose: On click; Full spin, until slide ends.
5.Save
6.Play slide: notice that the shape does not spin

Actual Results:  
No shape spin

Expected Results:
The shape should start to spin when I click it and not stop until I continue to
next slide.


Reproducible: Always

User Profile Reset: No

Additional Info:
I tried removing and reinstalling from the Ubuntu Software Manager hoping for a
newer version but it gave me the 5.1.6.2 that I had already. I could not figure
out how to install the 5.3.0.3 tar.gz that I downloaded... (I'm not enough of a
Linux geek to do even that simple task, and the readme said to use the
Manager...).


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Ubuntu Chromium/55.0.2883.87 Chrome/55.0.2883.87 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105986] EDITING - FILEOPEN - LOo crashes and enters document recovery loop

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105986

James B. Byrne  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #7 from James B. Byrne  ---
OpenCL Not Used

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106170] CRASHING Photoshop CS3 - 5.3.0.3 Causing ntdll.dll to CRASH

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106170

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Whiteboard||needs32bitAdobeCS3Photoshop

--- Comment #1 from V Stuart Foote  ---
Can not confirm on Windows 10 Pro 64-bit en-US with nVidia GPU
Version: 5.3.0.3 (x64)
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: group

and

Adobe CS4 Photoshop 11.0.2 (64-bit, or 32-bit).

Kind of doubt that the packaging for LO would touch this MS .dll--it is not
referenced in the MSI package for the 5.3.0.3 installer.  But, possible that
GPU is being changed set active/deactivated by the LibreOffice installation and
that impacts Photoshop. Have you tried forcing the GPU off, or disabling OpenGL
rendering?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106144] Multi monitor tooltip/palette position

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106144

Eric Owens  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Eric Owens  ---
My apologies for not updating to the newest release prior to submitting the bug
report.

That said, prior to updating, I restored the original user directory in
%UserProfile%\AppData\Roaming\LibreOffice\4 and made an attempt to ensure the
undesirable behavior still existed.  Interestingly, the behavior did not carry
over and behaved as expected.  I then updated to the newest release and was
able to confirm that the behavior continued as expected.  I also confirmed the
behavior was as expected after disconnecting the external monitors from the
laptop, running libreoffice, and then reconnecting the external monitors.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38902] UTF-8 contents should be detected and this codepage should be suggested for FILESAVE as ".txt coded"

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=38902

--- Comment #22 from Justin L  ---
Unable to reproduce in Linux (went back to oldest50 alpha), so it might
actually be windows only (as is already marked).  After making changes and then
saving over top of an existing .txt file, or as a new Text(.txt) format, I
never got ?'s when re-opening.

I was able to confirm the problem still exists in Windows with 5.1.6.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Various MacOS extension issues.

2017-02-24 Thread Stephan Bergmann 

On 02/24/2017 01:17 PM, Stephan Bergmann wrote:

On 02/23/2017 02:12 PM, Adomas Venčkauskas wrote:
I can reproduce that problem, LO produces


JDWP exit error AGENT_ERROR_ILLEGAL_ARGUMENT(202): saveGlobalRef obj
[util.c:60]
FATAL ERROR in native method: JDWP saveGlobalRef obj,
jvmtiError=AGENT_ERROR_ILLEGAL_ARGUMENT(202)
JavaVM: JNI_CreateJavaVM called os::abort(), caught by abort_handler
in javavm.cxx
[Java framework] sunjavaplugin.dylibCan not create JavaVirtualMachine,
abort handler was called.


on stdout/stderr (where the first two lines are from whatever happens
inside the JNI Invocation API's JNI_CrateJavaVM, while the last two are
from LO itself).

This is with Oracle's JDK 1.8.0_121 on macOS 10.12.3, and a simple
command-line invocation of


java -Xdebug -Xrunjdwp:transport=dt_socket,server=y,address=8000 Test


with a trivial Test class succeeds, so it smells like there is a problem
in that JDK's Invocation API implementation.  I'll dig further...


should work now on master with 
 
"Make JVM -Xrunjdwp option work on macOS"


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106175] Help viewer: tag is not supported in localized (l10n) help

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106175

Jacques Guilleron  changed:

   What|Removed |Added

 CC||guillero...@aol.com

--- Comment #1 from Jacques Guilleron  ---
Created attachment 131456
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131456=edit
Help display In English(US) and French

Hi Laurent,

I reproduce with:
LO 5.3.1.1 Build ID: 72fee18f394a980128dc111963f2eefb05998eeb
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Moteur
de mise en page : nouveau; Locale : fr-FR (fr_FR); Calc: CL

Local Help tried for English(US) and French.
See attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: jvmfwk/plugins

2017-02-24 Thread Stephan Bergmann 
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit f21994e7a240563283b7a17dcb435ce7c5156b60
Author: Stephan Bergmann 
Date:   Fri Feb 24 17:00:28 2017 +0100

Make JVM -Xrunjdwp option work on macOS

I hope loading the jvm library as SAL_LOADMODULE_GLOBAL has no negative
consequences (at least, there is prior art in the LINUX case already).

Change-Id: If18b65bd96f7205fdf9fd41389e64e786c15af16

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index 5053fda..63791bc 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -670,6 +670,16 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 osl::Module moduleRt;
 #if defined(LINUX)
 if (!moduleRt.load(sRuntimeLib, SAL_LOADMODULE_GLOBAL | 
SAL_LOADMODULE_NOW))
+#elif defined MACOSX
+// Must be SAL_LOADMODULE_GLOBAL when e.g. specifying a
+// -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=8000 option to
+// JDK 1.8.0_121 at least, as JNI_CreateJavaVM -> Threads::create_vm ->
+// JvmtiExport::post_vm_initialized -> cbEarlyVMInit -> initialize ->
+// util_initialize -> sun.misc.VMSupport.getAgentProperties ->
+// Java_sun_misc_VMSupport_initAgentProperties ->
+// JDK_FindJvmEntry("JVM_INitAgentProperties") ->
+// dlsym(RTLD_DEFAULT, "JVM_INitAgentProperties"):
+if (!moduleRt.load(sRuntimeLib, SAL_LOADMODULE_GLOBAL))
 #else
 #if defined(_WIN32)
 do_msvcr_magic(sRuntimeLib.pData);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106161] Writer crashes immediately after opening this .docx in Windows 7

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106161

Pedro  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Pedro  ---
I'm taking the liberty of changing the Status to NEW since it has been
confirmed by Stuart

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43808] [META] Right to left language issues (RTL/CTL)

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=43808

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||106161


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106161
[Bug 106161] Writer crashes immediately after opening this .docx in Windows 7
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104450] [META] DOCX file opening issues

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=104450

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||106161


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106161
[Bug 106161] Writer crashes immediately after opening this .docx in Windows 7
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106161] Writer crashes immediately after opening this .docx in Windows 7

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106161

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||filter:docx
 CC||caol...@redhat.com
 Blocks||104450, 43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right to left language issues (RTL/CTL)
https://bugs.documentfoundation.org/show_bug.cgi?id=104450
[Bug 104450] [META] DOCX file opening issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: sha1sum problem

2017-02-24 Thread Norbert Thiebaud 
On Fri, Feb 24, 2017 at 9:45 AM, Bryan Quigley
 wrote:
> I'm going to look at adding the SHA256SUM for all the files in
> download.lst.  It looks like we can add them without breaking
> anything.  Then we can test out how we want to switch or if we need to
> support both for a bit (platform dependent?).

shasum is already present and working on the supported platform
(I checked earlier on mac and windows)
so yeah that should be doable pretty much transparently.

Supporting a mix of method would be more painful and really not that
useful I think.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/xmlsecurity vcl/CppunitTest_vcl_pdfexport.mk vcl/Module_vcl.mk vcl/qa xmlsecurity/inc xmlsecurity/qa xmlsecurity/source xmlsecurity/workben

2017-02-24 Thread Miklos Vajna 
 include/xmlsecurity/pdfio/pdfdocument.hxx|  278 +++
 include/xmlsecurity/xmlsecuritydllapi.h  |   23 +
 vcl/CppunitTest_vcl_pdfexport.mk |   42 +++
 vcl/Module_vcl.mk|1 
 vcl/qa/cppunit/pdfexport/data/tdf106059.odt  |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx   |  103 
 xmlsecurity/inc/documentsignaturehelper.hxx  |2 
 xmlsecurity/inc/documentsignaturemanager.hxx |2 
 xmlsecurity/inc/pdfio/pdfdocument.hxx|  250 
 xmlsecurity/inc/pdfsignaturehelper.hxx   |2 
 xmlsecurity/inc/xmlsecuritydllapi.h  |   23 -
 xmlsecurity/inc/xmlsignaturehelper.hxx   |2 
 xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx|2 
 xmlsecurity/source/helper/pdfsignaturehelper.cxx |2 
 xmlsecurity/source/pdfio/pdfdocument.cxx |   41 +--
 xmlsecurity/workben/pdfverify.cxx|4 
 16 files changed, 471 insertions(+), 306 deletions(-)

New commits:
commit 58eac1105f8504bd5320911fc6fe967ccaa3d469
Author: Miklos Vajna 
Date:   Fri Feb 24 13:46:52 2017 +0100

vcl: add initial CppunitTest_vcl_pdfexport

Invoke the PDF export filter and then use the PDF tokenizer from
xmlsecurity to assert the contents of created PDF file. The testcase
fails with commit 6db0f1feb1d9931d2726dd11a889c58815710ce0 (tdf#106059
PDF export: create a reference XObject for PDF images, 2017-02-22)
reverted.

Change-Id: I90526fef41d9560ae447f586df766bc50a491c43
Reviewed-on: https://gerrit.libreoffice.org/34609
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/xmlsecurity/inc/pdfio/pdfdocument.hxx 
b/include/xmlsecurity/pdfio/pdfdocument.hxx
similarity index 85%
rename from xmlsecurity/inc/pdfio/pdfdocument.hxx
rename to include/xmlsecurity/pdfio/pdfdocument.hxx
index acf873c..0b27014 100644
--- a/xmlsecurity/inc/pdfio/pdfdocument.hxx
+++ b/include/xmlsecurity/pdfio/pdfdocument.hxx
@@ -8,8 +8,8 @@
  *
  */
 
-#ifndef INCLUDED_XMLSECURITY_INC_PDFIO_PDFDOCUMENT_HXX
-#define INCLUDED_XMLSECURITY_INC_PDFIO_PDFDOCUMENT_HXX
+#ifndef INCLUDED_XMLSECURITY_PDFIO_PDFDOCUMENT_HXX
+#define INCLUDED_XMLSECURITY_PDFIO_PDFDOCUMENT_HXX
 
 #include 
 #include 
@@ -18,8 +18,9 @@
 
 #include 
 
-#include 
-#include 
+#include 
+
+struct SignatureInformation;
 
 namespace xmlsecurity
 {
@@ -103,6 +104,33 @@ public:
 sal_uInt64 GetLength() const;
 };
 
+/// Dictionary object: a set key-value pairs.
+class XMLSECURITY_DLLPUBLIC PDFDictionaryElement : public PDFElement
+{
+/// Key-value pairs when the dictionary is a nested value.
+std::map m_aItems;
+/// Offset after the '<<' token.
+sal_uInt64 m_nLocation = 0;
+/// Position after the '/' token.
+std::map m_aDictionaryKeyOffset;
+/// Length of the dictionary key and value, till (before) the next token.
+std::map m_aDictionaryKeyValueLength;
+
+public:
+PDFDictionaryElement();
+bool Read(SvStream& rStream) override;
+
+static size_t Parse(const std::vector< std::unique_ptr >& 
rElements, PDFElement* pThis, std::map& rDictionary);
+static PDFElement* Lookup(const std::map& 
rDictionary, const OString& rKey);
+void SetKeyOffset(const OString& rKey, sal_uInt64 nOffset);
+sal_uInt64 GetKeyOffset(const OString& rKey) const;
+void SetKeyValueLength(const OString& rKey, sal_uInt64 nLength);
+sal_uInt64 GetKeyValueLength(const OString& rKey) const;
+const std::map& GetItems() const;
+/// Looks up an object which is only referenced in this dictionary.
+PDFObjectElement* LookupObject(const OString& rDictionaryKey);
+};
+
 enum class TokenizeMode
 {
 /// Full file.
@@ -245,6 +273,6 @@ public:
 } // namespace pdfio
 } // namespace xmlsecurity
 
-#endif // INCLUDED_XMLSECURITY_INC_PDFIO_PDFDOCUMENT_HXX
+#endif // INCLUDED_XMLSECURITY_PDFIO_PDFDOCUMENT_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmlsecurity/inc/xmlsecuritydllapi.h 
b/include/xmlsecurity/xmlsecuritydllapi.h
similarity index 79%
rename from xmlsecurity/inc/xmlsecuritydllapi.h
rename to include/xmlsecurity/xmlsecuritydllapi.h
index 2349d23..48da546 100644
--- a/xmlsecurity/inc/xmlsecuritydllapi.h
+++ b/include/xmlsecurity/xmlsecuritydllapi.h
@@ -7,8 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_XMLSECURITY_INCDLLAPI_H
-#define INCLUDED_XMLSECURITY_INCDLLAPI_H
+#ifndef INCLUDED_XMLSECURITY_XMLSECURITYDLLAPI_H
+#define INCLUDED_XMLSECURITY_XMLSECURITYDLLAPI_H
 
 #include 
 
@@ -18,6 +18,6 @@
 #define XMLSECURITY_DLLPUBLIC SAL_DLLPUBLIC_IMPORT
 #endif
 
-#endif // INCLUDED_XMLSECURITY_INCDLLAPI_H
+#endif // INCLUDED_XMLSECURITY_XMLSECURITYDLLAPI_H
 
 /*

[Libreoffice-bugs] [Bug 106161] Writer crashes immediately after opening this .docx in Windows 7

2017-02-24 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106161

V Stuart Foote  changed:

   What|Removed |Added

Crash report or|["rtl_uString_acquire"] |["rtl_uString_acquire","cpp
crash signature||u::checkInterface"]

--- Comment #1 from V Stuart Foote  ---
Confirmed.

On a VM of Windows 7sp1 Ultimate 32-bit with
Version: 5.3.1.1
Build ID: 72fee18f394a980128dc111963f2eefb05998eeb
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: group

But a different crash signature, but similar stack for the reflow:

http://crashreport.libreoffice.org/stats/crash_details/fd85713a-797e-4338-86fc-7f8d1b2ae04a

http://crashreport.libreoffice.org/stats/crash_details/2267982d-6039-4625-8af5-2b939798973a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 4 commits - basegfx/source hwpfilter/qa include/oox oox/source sc/source sdext/source sd/source sfx2/source sw/source vcl/source vcl/unx

2017-02-24 Thread Caolán McNamara 
 basegfx/source/polygon/b2dpolypolygon.cxx |   16 +++
 basegfx/source/polygon/b3dpolypolygon.cxx |   16 +++
 hwpfilter/qa/cppunit/data/fail/skipblock-1.hwp|binary
 hwpfilter/qa/cppunit/test_hwpfilter.cxx   |   16 +--
 include/oox/helper/binaryinputstream.hxx  |2 
 include/oox/helper/containerhelper.hxx|2 
 oox/source/dump/dumperbase.cxx|4 -
 oox/source/helper/binaryinputstream.cxx   |2 
 oox/source/ole/vbainputstream.cxx |2 
 sc/source/filter/excel/excimp8.cxx|2 
 sc/source/filter/excel/xiescher.cxx   |4 -
 sc/source/filter/excel/xistream.cxx   |8 +--
 sc/source/filter/excel/xlformula.cxx  |6 +-
 sc/source/filter/inc/fapihelper.hxx   |2 
 sc/source/filter/inc/xlformula.hxx|2 
 sc/source/filter/oox/biffcodec.cxx|6 +-
 sd/source/ui/remotecontrol/BluetoothServer.cxx|2 
 sdext/source/presenter/PresenterAccessibility.cxx |2 
 sfx2/source/doc/oleprops.cxx  |6 +-
 sfx2/source/sidebar/Theme.cxx |2 
 sw/source/core/layout/atrfrm.cxx  |   49 ++
 sw/source/filter/ww8/wrtw8sty.cxx |6 +-
 sw/source/filter/ww8/ww8par.cxx   |   12 ++---
 sw/source/uibase/dochdl/gloshdl.cxx   |   12 ++---
 vcl/source/control/tabctrl.cxx|   16 +++
 vcl/source/gdi/dibtools.cxx   |4 -
 vcl/source/gdi/embeddedfontshelper.cxx|2 
 vcl/unx/generic/window/salframe.cxx   |4 -
 28 files changed, 98 insertions(+), 109 deletions(-)

New commits:
commit 3cc3dc176e00062d8395d9f3d83b49ab24542a61
Author: Caolán McNamara 
Date:   Fri Feb 24 15:16:27 2017 +

hwpfilter needs a new filter for each document

setUp is called just once at the start of the sequence of loads
so we're reusing the previous import state which isn't what this
filter expects

This reverts commit 0af436083e12516eb9251d4cc6f594f80ed06d3d.

Change-Id: Iae355ed6099086fd3cc1c79203786017507d4ed4

diff --git a/hwpfilter/qa/cppunit/data/fail/skipblock-1.hwp 
b/hwpfilter/qa/cppunit/data/fail/skipblock-1.hwp
new file mode 100644
index 000..8fd8e7a
Binary files /dev/null and b/hwpfilter/qa/cppunit/data/fail/skipblock-1.hwp 
differ
diff --git a/hwpfilter/qa/cppunit/test_hwpfilter.cxx 
b/hwpfilter/qa/cppunit/test_hwpfilter.cxx
index f497d12..040c98e 100644
--- a/hwpfilter/qa/cppunit/test_hwpfilter.cxx
+++ b/hwpfilter/qa/cppunit/test_hwpfilter.cxx
@@ -24,7 +24,6 @@ namespace
 , public test::BootstrapFixture
 {
 public:
-virtual void setUp() override;
 
 virtual bool load(const OUString &,
 const OUString , const OUString &,
@@ -35,26 +34,19 @@ namespace
 CPPUNIT_TEST_SUITE(HwpFilterTest);
 CPPUNIT_TEST(test);
 CPPUNIT_TEST_SUITE_END();
-private:
-uno::Reference m_xFilter;
 };
 
-void HwpFilterTest::setUp()
-{
-test::BootstrapFixture::setUp();
-
-
m_xFilter.set(m_xSFactory->createInstance("com.sun.comp.hwpimport.HwpImportFilter"),
-  uno::UNO_QUERY_THROW);
-}
-
 bool HwpFilterTest::load(const OUString &,
 const OUString , const OUString &,
 SfxFilterFlags, SotClipboardFormatId, unsigned int)
 {
+uno::Reference 
xFilter(m_xSFactory->createInstance("com.sun.comp.hwpimport.HwpImportFilter"),
+  uno::UNO_QUERY_THROW);
+
 uno::Sequence< beans::PropertyValue > aDescriptor(1);
 aDescriptor[0].Name = "URL";
 aDescriptor[0].Value <<= rURL;
-return m_xFilter->filter(aDescriptor);
+return xFilter->filter(aDescriptor);
 }
 
 void HwpFilterTest::test()
commit 3a74745367a73ed9351379fc32bbe9253cdae697
Author: Caolán McNamara 
Date:   Fri Feb 24 14:09:52 2017 +

vector::data seems more natural than ::front

Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1

diff --git a/basegfx/source/polygon/b2dpolypolygon.cxx 
b/basegfx/source/polygon/b2dpolypolygon.cxx
index f1032f1..9c6b1eb 100644
--- a/basegfx/source/polygon/b2dpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dpolypolygon.cxx
@@ -137,34 +137,34 @@ public:
 
 const basegfx::B2DPolygon* begin() const
 {
-if(maPolygons.empty())
+if (maPolygons.empty())
 return nullptr;
 else
-return ();
+return maPolygons.data();
 }
 
 const basegfx::B2DPolygon* end() const
 {
-if(maPolygons.empty())
+if (maPolygons.empty())
 return nullptr;
 else
-return (())+1;
+return maPolygons.data() + maPolygons.size();
 }

[Libreoffice-commits] core.git: config_host/config_liblangtag.h.in config_host.mk.in configure.ac distro-configs/LibreOfficeOssFuzz.conf external/libetonyek i18nlangtag/CppunitTest_i18nlangtag_test_la

2017-02-24 Thread Khaled Hosny 
 RepositoryExternal.mk |7 
 config_host.mk.in |1 
 config_host/config_liblangtag.h.in|1 
 configure.ac  |   53 
 distro-configs/LibreOfficeOssFuzz.conf|1 
 external/libetonyek/UnpackedTarball_libetonyek.mk |1 
 external/libetonyek/libetonyek-support-disable-liblangtag.patch.0 |  130 --
 i18nlangtag/CppunitTest_i18nlangtag_test_languagetag.mk   |2 
 i18nlangtag/Library_i18nlangtag.mk|2 
 i18nlangtag/qa/cppunit/test_languagetag.cxx   |   34 
 i18nlangtag/source/languagetag/languagetag.cxx|9 
 i18nlangtag/source/languagetag/simple-langtag.cxx |  590 
--
 12 files changed, 18 insertions(+), 813 deletions(-)

New commits:
commit 8dc27a0bbf74646969074414c071410ad7d07b74
Author: Khaled Hosny 
Date:   Tue Feb 21 12:36:55 2017 +0200

Always enable liblangtag

The license should not be an issue any more since liblangtag now has an
LGPL/MPLv2 dual licence.

Change-Id: I4dfffcccf5d710bd16b21c3254c1449ae041b8ab
Reviewed-on: https://gerrit.libreoffice.org/34511
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 429e3c3..650c1b7 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -926,7 +926,6 @@ endef
 
 endif # SYSTEM_LIBXSLT
 
-ifeq ($(ENABLE_LIBLANGTAG),TRUE)
 
 ifneq ($(SYSTEM_LIBLANGTAG),)
 
@@ -985,12 +984,6 @@ endef
 
 endif # SYSTEM_LIBLANGTAG
 
-else
-
-gb_LinkTarget__use_liblangtag :=
-gb_ExternalProject__use_liblangtag :=
-
-endif # ENABLE_LIBLANGTAG
 
 gb_ExternalProject__use_apr :=
 
diff --git a/config_host.mk.in b/config_host.mk.in
index 5c35440..68309d3 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -142,7 +142,6 @@ export ENABLE_GTK_PRINT=@ENABLE_GTK_PRINT@
 export ENABLE_HEADLESS=@ENABLE_HEADLESS@
 export ENABLE_JAVA=@ENABLE_JAVA@
 export ENABLE_KDE4=@ENABLE_KDE4@
-export ENABLE_LIBLANGTAG=@ENABLE_LIBLANGTAG@
 export ENABLE_LPSOLVE=@ENABLE_LPSOLVE@
 export ENABLE_LTO=@ENABLE_LTO@
 export ENABLE_LWP=@ENABLE_LWP@
diff --git a/config_host/config_liblangtag.h.in 
b/config_host/config_liblangtag.h.in
index 18a9c12..f639fb7 100644
--- a/config_host/config_liblangtag.h.in
+++ b/config_host/config_liblangtag.h.in
@@ -1,7 +1,6 @@
 #ifndef CONFIG_LIBLANGTAG_H
 #define CONFIG_LIBLANGTAG_H
 
-#define ENABLE_LIBLANGTAG 0
 #define LIBLANGTAG_INLINE_FIX 0
 
 #endif
diff --git a/configure.ac b/configure.ac
index a2448e4..8756e52 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1485,12 +1485,6 @@ libo_FUZZ_ARG_ENABLE(firebird-sdbc,
 [Disable the build of the Firebird-SDBC driver if it doesn't compile 
for you.]),
 ,test "${enable_firebird_sdbc+set}" = set || enable_firebird_sdbc=yes)
 
-libo_FUZZ_ARG_ENABLE(liblangtag,
-AS_HELP_STRING([--disable-liblangtag],
-[Disable use of liblangtag, and instead use an own simple
- implementation.]),
-)
-
 AC_ARG_ENABLE(bogus-pkg-config,
 AS_HELP_STRING([--enable-bogus-pkg-config],
 [MACOSX only: on MacOSX pkg-config can cause trouble. by default if 
one is found in the PATH, an error is issued. This flag turn that error into a 
warning.]),
@@ -11585,39 +11579,28 @@ AC_SUBST(AVAHI_LIBS)
 dnl ===
 dnl Test whether to use liblangtag
 dnl ===
-ENABLE_LIBLANGTAG=
 SYSTEM_LIBLANGTAG=
-AC_MSG_CHECKING([whether to use liblangtag])
-if test "$enable_liblangtag" = "yes" -o "$enable_liblangtag" = ""; then
-ENABLE_LIBLANGTAG=TRUE
+AC_MSG_CHECKING([whether to use system liblangtag])
+if test "$with_system_liblangtag" = yes; then
+SYSTEM_LIBLANGTAG=TRUE
 AC_MSG_RESULT([yes])
-AC_MSG_CHECKING([whether to use system liblangtag])
-if test "$with_system_liblangtag" = yes; then
-SYSTEM_LIBLANGTAG=TRUE
-AC_MSG_RESULT([yes])
-PKG_CHECK_MODULES( LIBLANGTAG, liblangtag >= 0.4.0)
-dnl cf.  
"Fix a build issue with inline keyword"
-PKG_CHECK_EXISTS([liblangtag >= 0.5.5], [], 
[AC_DEFINE([LIBLANGTAG_INLINE_FIX])])
-LIBLANGTAG_CFLAGS=$(printf '%s' "$LIBLANGTAG_CFLAGS" | sed -e 
"s/-I/${ISYSTEM?}/g")
-FilterLibs "${LIBLANGTAG_LIBS}"
-LIBLANGTAG_LIBS="${filteredlibs}"
-else
-SYSTEM_LIBLANGTAG=
-AC_MSG_RESULT([no])
-BUILD_TYPE="$BUILD_TYPE LIBLANGTAG"
-LIBLANGTAG_CFLAGS="-I${WORKDIR}/UnpackedTarball/langtag"
-if test "$COM" = "MSC"; then
-

  1   2   3   >