[Libreoffice-bugs] [Bug 102779] Notebookbar: Add spacing/padding around tab labels

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102779

--- Comment #12 from andreas_k  ---
can you test if additional padding could help? That's not only an issue of the
tabbed toolbar all tabs (dialogues) are very tiny, so maybe add an padding
could help.

Issue is for me on windows and kde only in gnome it look (and work) good.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106321] Impress slide object needs focus to update export jpg

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106321

--- Comment #3 from Tor Lillqvist  ---
Just a note: I don't understand why Impress even has such an "export to JPEG"
functionality. JPEG is very unsuitable for Impress slides, by definition. (The
'P' stands for 'Photography'. Slides consist of text and line art.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100853] HiDPI: Check marks in Windows menus are drawn pixellated

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100853

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #6 from andreas_k  ---
I already want to report this bug. Is there any solution?

On Linux there is no problem but I have it on windows 7 and it look really out
of place. maybe a windows solution only could help.

In general I'm not really happy with the windows theme (I know it comes from
the os maybe that's the reason MS Office has a custom style.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

2017-03-09 Thread scan-admin 

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/core/tool/chartlis.cxx: 152 in ScChartListener::~ScChartListener()()



*** CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/core/tool/chartlis.cxx: 152 in ScChartListener::~ScChartListener()()
146 pRefMgr->addLinkListener(*itr, mpExtRefListener.get());
147 mpExtRefListener->addFileId(*itr);
148 }
149 }
150 }
151 
>>> CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::DeploymentException" is 
>>> thrown but the throw list "throw()" doesn't allow it to be thrown. This 
>>> will cause a call to unexpected() which usually calls terminate().
152 ScChartListener::~ScChartListener()
153 {
154 if ( HasBroadcaster() )
155 EndListeningTo();
156 delete pUnoData;
157 

** CID 1402153:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 117 in BitmapReadAccess::BitmapReadAccess(Bitmap 
&)()



*** CID 1402153:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 117 in BitmapReadAccess::BitmapReadAccess(Bitmap 
&)()
111 BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
112 BitmapInfoAccess( rBitmap, BitmapAccessMode::Read ),
113 mFncGetPixel( nullptr ),
114 mFncSetPixel( nullptr )
115 {
116 ImplInitScanBuffer( rBitmap );
>>> CID 1402153:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mpScanBuf" is not initialized in this 
>>> constructor nor in any functions that it calls.
117 }
118 
119 BitmapReadAccess::~BitmapReadAccess()
120 {
121 }
122 

** CID 1402152:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 109 in BitmapReadAccess::BitmapReadAccess(Bitmap &, 
BitmapAccessMode)()



*** CID 1402152:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 109 in BitmapReadAccess::BitmapReadAccess(Bitmap &, 
BitmapAccessMode)()
103 BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap, BitmapAccessMode 
nMode ) :
104 BitmapInfoAccess( rBitmap, nMode ),
105 mFncGetPixel( nullptr ),
106 mFncSetPixel( nullptr )
107 {
108 ImplInitScanBuffer( rBitmap );
>>> CID 1402152:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mpScanBuf" is not initialized in this 
>>> constructor nor in any functions that it calls.
109 }
110 
111 BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
112 BitmapInfoAccess( rBitmap, BitmapAccessMode::Read ),
113 mFncGetPixel( nullptr ),
114 mFncSetPixel( nullptr )

** CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 3142 in 
ScDocShellModificator::~ScDocShellModificator()()



*** CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 3142 in 
ScDocShellModificator::~ScDocShellModificator()()
3136 bAutoCalcShellDisabled = rDoc.IsAutoCalcShellDisabled();
3137 bIdleEnabled = rDoc.IsIdleEnabled();
3138 rDoc.SetAutoCalcShellDisabled( true );
3139 rDoc.EnableIdle(false);
3140 }
3141 
>>> CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
>>> An exception of type "mdds::general_error" is thrown but the throw list 
>>> "throw()" doesn't allow it to be thrown. This will cause a call to 
>>> unexpected() which usually calls terminate().
3142 ScDocShellModificator::~ScDocShellModificator()
3143 {
3144 ScDocument& rDoc = rDocShell.GetDocument();
3145 rDoc.SetAutoCalcShellDisabled( bAutoCalcShellDisabled );
3146 if ( !bAutoCalcShellDisabled && 
rDocShell.IsDocumentModifiedPending() )
3147 rDocShell.SetDocumentModified();// last one shuts off the 
lights

** CID 1402150:  API usage errors  (INVALIDATE_ITERATOR)
/cui/source/options/treeopt.cxx: 2003 in OfaTreeOptionsDialog::LoadNodes(Module 
*, const rtl::OUString &)()

[Libreoffice-bugs] [Bug 106469] New: I can't save the file in LibreOffice Writer

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106469

Bug ID: 106469
   Summary: I can't save the file in LibreOffice Writer
   Product: LibreOffice
   Version: 4.4 all versions
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: willitc9...@gmail.com

Description:
When i open my LibreOffice and try save a document, i can't save the file. The
option save is the principal problem. 

Steps to Reproduce:
1.Open the program 
2.Write a text 
3.After try save a file, i can't save a file. 

Actual Results:  
blink the window of the program after of give an click on the button save. 

Expected Results:
Save the file 


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101
Firefox/51.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

2017-03-09 Thread Zdeněk Crhonek 
 sc/qa/unit/data/functions/financial/fods/effect.fods | 3667 +++
 1 file changed, 3667 insertions(+)

New commits:
commit a6df0c3434678dfe4f28d97cdb7a37248fb24d50
Author: Zdeněk Crhonek 
Date:   Thu Mar 9 18:20:59 2017 +0100

add EFFECT function test case

Change-Id: I22b40a76c296efdfb59786edb37a8d5380a03777
Reviewed-on: https://gerrit.libreoffice.org/35015
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/financial/fods/effect.fods 
b/sc/qa/unit/data/functions/financial/fods/effect.fods
new file mode 100644
index 000..93ba060
--- /dev/null
+++ b/sc/qa/unit/data/functions/financial/fods/effect.fods
@@ -0,0 +1,3667 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-03-09T18:18:12.897598562P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/a5a6694128728c48c1a8482450a21ad49025c40c
+ 
+  
+   0
+   0
+   47120
+   6688
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   1
+   17
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1191
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ false
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+   
+
+   Kč
+   
+  
+

[Libreoffice-bugs] [Bug 105481] Formula disappears after file save and re-open

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105481

Buovjaga  changed:

   What|Removed |Added

Version|5.0.6.3 release |Inherited From OOo

--- Comment #9 from Buovjaga  ---
(In reply to john from comment #8)
> Could the 'importance' of this bug please be increased, since no work-around
> is known?

I could raise it, if the formulas disappeared for real, but now they are just
invisible upon opening.

Confirmed with 3.3 already.

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42346] FILESAVE: Cross-references to certain numbered items (object, graphic, table) turn to plain text on export to .doc or .docx ( works OK for headings and bookmarks)

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=42346

--- Comment #76 from andis.lazd...@gmail.com ---
(In reply to john from comment #74)
> 
> With many documents required to be distributed in Word format in various
> contexts it is CRITICAL that files exported from LibreOffice not lose
> content! This is a high priority bug, in my view.

Completely agree! Our company has some funding possibilities if there are
volunteers ready elaborate a solution. We are wasting enormous amount of time
and we have to keep a copy of Word to be able to collaborate with our
contractors because of this really critical bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42346] FILESAVE: Cross-references to certain numbered items (object, graphic, table) turn to plain text on export to .doc or .docx ( works OK for headings and bookmarks)

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=42346

--- Comment #75 from andis.lazd...@gmail.com ---
(In reply to john from comment #74)
> 
> With many documents required to be distributed in Word format in various
> contexts it is CRITICAL that files exported from LibreOffice not lose
> content! This is a high priority bug, in my view.

Completely agree! Our company has some funding possibilities if there are
volunteers ready elaborate a solution. We are wasting enormous amount of time
and we have to keep a copy of Word to be able to collaborate with our
contractors because of this really critical bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103227] Clicking on link to go to external document (e.g., to play movie) during presentation does not work any longer

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103227

--- Comment #10 from Buovjaga  ---
Matthias: could you try with 5.3 and if still seeing a problem: Help - Restart
in safe mode and then Continue in safe mode without doing anything else.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106241] Mail Merge connects to gmail smtp server but emails are not sent

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106241

Buovjaga  changed:

   What|Removed |Added

 CC||glo...@fbihome.de

--- Comment #11 from Buovjaga  ---
(In reply to Reto from comment #10)
> I made it working in 5.2.5 64bit with an odd workaround. Going through the
> mail merge dialog, in step 3 I have to click "Choose address list" I find my
> registered base file and the relevant table is already selected. Despite of
> that I have click "Other table" and choose preview of the selected address
> list, then select twice OK, then still in step 3 choose Complete. Then I can
> prepare mail and send it. That's the only way I got it working. No one will
> believe it, but I was going through that procedure and varyied everytime one
> piece of it and eventually only that combination worked.

Jan-Marek: what do you think of the above?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106468] editing viewing fileopen unable to open edit or view older wordperfect documents

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106468

--- Comment #1 from sandhillsinvestm...@gmail.com ---
Created attachment 131786
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131786=edit
wpd file created early 2008 which will not open

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106468] New: editing viewing fileopen unable to open edit or view older wordperfect documents

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106468

Bug ID: 106468
   Summary: editing viewing fileopen unable to open edit or view
older wordperfect documents
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sandhillsinvestm...@gmail.com

A friend has many wpd documents from the late 90s to present.
LO 5.2.6.2 easily opens those created with a version of WP installed about
August 2008 but does not recognize the format of documents created with an
earlier version of WP.  All documents causing the problem were created on
Windows 7 or earlier versions and due to hardware failure have been moved to a
Linux platform where they cannot be opened in readable form.

The attached file "Failed.wpd" was created and saved March 13, 2008 and is
unable to be opened in readable form by LO. Any file created at this time or
earlier will import only as scrambled unreadable gibberish in LO.

I know that I was using star office / open office in 2005 & 2006 and IIRC was
able to read/open/edit wpd documents being created by WP at that time so I
anticipated LO would be able to read those also, but it does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106467] New: editing viewing fileopen unable to open edit or view older wordperfect documents

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106467

Bug ID: 106467
   Summary: editing viewing fileopen unable to open edit or view
older wordperfect documents
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sandhillsinvestm...@gmail.com

Created attachment 131785
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131785=edit
early 2008 wpd file that will not open in LO

A friend has many wpd documents from the late 90s to present.
LO 5.2.6.2 easily opens those created with a version of WP installed about
August 2008 but does not recognize the format of documents created with an
earlier version of WP.  All documents causing the problem were created on
Windows 7 or earlier versions and due to hardware failure have been moved to a
Linux platform where they cannot be opened in readable form.

The attached file "Failed.wpd" was created and saved March 13, 2008 and is
unable to be opened in readable form by LO. Any file created at this time or
earlier will import only as scrambled unreadable gibberish in LO.

I know that I was using star office / open office in 2005 & 2006 and IIRC was
able to read/open/edit wpd documents being created by WP at that time so I
anticipated LO would be able to read those also, but it does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/source sd/qa xmloff/inc xmloff/source

2017-03-09 Thread Rosemary Sebastian 
 editeng/source/items/flditem.cxx |   15 +--
 sd/qa/unit/data/odp/author_fixed.odp |binary
 sd/qa/unit/export-tests.cxx  |   19 +++
 xmloff/inc/txtfldi.hxx   |4 
 xmloff/source/text/txtflde.cxx   |7 +--
 xmloff/source/text/txtfldi.cxx   |   10 ++
 6 files changed, 47 insertions(+), 8 deletions(-)

New commits:
commit 5de40734af30a8b897c6c5b7f681759e36a25557
Author: Rosemary Sebastian 
Date:   Wed Jan 25 12:56:47 2017 +0530

Implement export and import of author field in fixed format

Change-Id: I1975bfcdc8436f2b05e2fab2a4c9c09838330b30
Reviewed-on: https://gerrit.libreoffice.org/33520
Tested-by: Jenkins 
Reviewed-by: Rosemary Sebastian 

diff --git a/editeng/source/items/flditem.cxx b/editeng/source/items/flditem.cxx
index 1d5ba3f..6904255 100644
--- a/editeng/source/items/flditem.cxx
+++ b/editeng/source/items/flditem.cxx
@@ -181,13 +181,16 @@ SvxFieldData* SvxFieldData::Create(const 
uno::Reference& xTe
 SvxAuthorField* pData = new SvxAuthorField(
 aFirstName, aLastName, OUString(), bIsFixed ? 
SVXAUTHORTYPE_FIX : SVXAUTHORTYPE_VAR);
 
-if (!bFullName)
+if (!bIsFixed)
 {
-pData->SetFormat(SVXAUTHORFORMAT_SHORTNAME);
-}
-else if (nFmt >= SVXAUTHORFORMAT_FULLNAME && nFmt <= 
SVXAUTHORFORMAT_SHORTNAME)
-{
-pData->SetFormat(static_cast(nFmt));
+if (!bFullName)
+{
+pData->SetFormat(SVXAUTHORFORMAT_SHORTNAME);
+}
+else if (nFmt >= SVXAUTHORFORMAT_FULLNAME && nFmt <= 
SVXAUTHORFORMAT_SHORTNAME)
+{
+
pData->SetFormat(static_cast(nFmt));
+}
 }
 
 return pData;
diff --git a/sd/qa/unit/data/odp/author_fixed.odp 
b/sd/qa/unit/data/odp/author_fixed.odp
new file mode 100644
index 000..2e666ad
Binary files /dev/null and b/sd/qa/unit/data/odp/author_fixed.odp differ
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 797bf36..dd57ec0 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -92,6 +92,7 @@ public:
 void testTdf62176();
 void testTransparentBackground();
 void testEmbeddedPdf();
+void testAuthorField();
 
 CPPUNIT_TEST_SUITE(SdExportTest);
 
@@ -106,6 +107,7 @@ public:
 CPPUNIT_TEST(testTdf62176);
 CPPUNIT_TEST(testTransparentBackground);
 CPPUNIT_TEST(testEmbeddedPdf);
+CPPUNIT_TEST(testAuthorField);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -552,6 +554,23 @@ void SdExportTest::testEmbeddedPdf()
 #endif
 }
 
+void SdExportTest::testAuthorField()
+{
+::sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/odp/author_fixed.odp"), 
ODP);
+
+xDocShRef = saveAndReload( xDocShRef.get(), ODP );
+
+uno::Reference< text::XTextField > xField = getTextFieldFromPage(0, 0, 0, 
0, xDocShRef);
+CPPUNIT_ASSERT_MESSAGE("Where is the text field?", xField.is() );
+
+uno::Reference< beans::XPropertySet > xPropSet( xField, 
uno::UNO_QUERY_THROW );
+bool bFixed = false;
+xPropSet->getPropertyValue("IsFixed") >>= bFixed;
+CPPUNIT_ASSERT_MESSAGE("Author field is not fixed", bFixed);
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/xmloff/inc/txtfldi.hxx b/xmloff/inc/txtfldi.hxx
index 106545c..ed154c7 100644
--- a/xmloff/inc/txtfldi.hxx
+++ b/xmloff/inc/txtfldi.hxx
@@ -234,6 +234,10 @@ protected:
 virtual void StartElement(
 const css::uno::Reference< css::xml::sax::XAttributeList> & xAttrList) 
override;
 
+/// process attribute values
+virtual void ProcessAttribute( sal_uInt16 nAttrToken,
+   const OUString& sAttrValue ) override;
+
 /// prepare XTextField for insertion into document
 virtual void PrepareField(
 const css::uno::Reference< css::beans::XPropertySet> & xPropertySet) 
override;
diff --git a/xmloff/source/text/txtflde.cxx b/xmloff/source/text/txtflde.cxx
index 4037bab..72dc79a 100644
--- a/xmloff/source/text/txtflde.cxx
+++ b/xmloff/source/text/txtflde.cxx
@@ -1067,8 +1067,11 @@ void XMLTextFieldExport::ExportFieldHelper(
 switch (nToken) {
 case FIELD_ID_AUTHOR:
 // author field: fixed, field (sub-)type
-ProcessBoolean(XML_FIXED,
-   GetBoolProperty(sPropertyIsFixed, rPropSet), true);
+if (xPropSetInfo->hasPropertyByName(sPropertyIsFixed))
+{
+GetExport().AddAttribute(XML_NAMESPACE_TEXT, XML_FIXED,
+

[Libreoffice-bugs] [Bug 106466] Graphite font features cannot be activated on Mac OS X if the font also contains AAT tables

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106466

--- Comment #3 from livingfi...@gmail.com ---
Created attachment 131783
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131783=edit
Test document

Test document (requires Charis SIL and Khmer Busra Bunong fonts)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106466] Graphite font features cannot be activated on Mac OS X if the font also contains AAT tables

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106466

--- Comment #4 from EricP  ---
Created attachment 131784
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131784=edit
Khmer Busra Bunong font

The Khmer Busra Bunong font is a Khmer font in the Mondulkiri font series
(http://scripts.sil.org/mondulkiri), which has not yet been publicly released.

The Charis SIL font is available at http://software.sil.org/charis/. It does
not contain AAT tables (http://scripts.sil.org/SILFontList).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106466] Graphite font features cannot be activated on Mac OS X if the font also contains AAT tables

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106466

--- Comment #2 from livingfi...@gmail.com ---
Created attachment 131782
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131782=edit
Screenshot showing active font features for Charis SIL but not rendering for
Khmer Busra Bunong

Left side: LibreOffice 5.3.1.1 on macOS shows working graphite features for
Charis SIL but not Khmer Busra Bunong

Right side: LibreOffice 5.3.1.1 on Windows 10 in a VM shows working graphite
features in both Charts SIL and Khmer Busra Bunong

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106466] Graphite font features cannot be activated on Mac OS X if the font also contains AAT tables

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106466

livingfi...@gmail.com changed:

   What|Removed |Added

 CC||livingfi...@gmail.com

--- Comment #1 from livingfi...@gmail.com ---
Created attachment 131781
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131781=edit
Screenshot showing font features settings

Note font features have been specified with, e.g. ":litr=1" appended to the
font name.

LO in macOS on the left and Windows in a VM on the right.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106466] New: Graphite font features cannot be activated on Mac OS X if the font also contains AAT tables

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106466

Bug ID: 106466
   Summary: Graphite font features cannot be activated on Mac OS X
if the font also contains AAT tables
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: livingfi...@gmail.com

Description:
Graphite font features in the "Khmer Busra Bunong" font (attached) work fine in
LO 5.3 on Windows and Linux but are not activated on macOS Sierra 10.12.3 (see
screenshots). I'm guessing that this is because the font includes both graphite
and AAT tables, but I haven't confirmed this.

LO 5.3 includes a new cross-platform text layout engine which supports Graphite
and OpenType Font Features on all platforms.
(https://wiki.documentfoundation.org/ReleaseNotes/5.3#Text_Layout)

Enabling graphite font features in Charis SIL font works on all platforms.
(http://software.sil.org/charis/support/smart-font-features/) as does Libertine
G (http://www.numbertext.org/linux/fontfeatures.pdf).

The Khmer Busra Bunong font (attached) contains both graphite and AAT tables.
Bug 105516, comment 1 states that Graphite or AAT takes precedence over
OpenType but it appears here that AAT is taking precedence over graphite. This
is problematic because it causes different rendering on different platforms. I
think I would prefer that Graphite take precedence over AAT.





Reproducible: Always

User Profile Reset: Yes

Additional Info:
Related Bugs:
Bug 58941 and bug 105710 are discussions about implementing a GUI control for
enabling OpenType or graphite features.
Bug 71732 (Font-Rendering) - [META] Bugs related to text rendering, typography
and font features in LO


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/602.4.8
(KHTML, like Gecko) Version/10.0.3 Safari/602.4.8

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

I will like to report a bug on libreoffice 5.3.0.3

2017-03-09 Thread M. Alpizar 
I will like to report a bug on libreoffice 5.3.0.3

  1.  Writer document with header and footers options used. When importing or 
pasting an image. The image is not get aliened and awful difficult to 
manipulate.


Thanks

Keep working.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Where does the download repository exists

2017-03-09 Thread Shoaib Noor 
Hi
Where does the downloaded repository exists if i install the cgywin in some 
other partition (E:) when i am cloning the repository it is`t show the files i 
am using windows 8 (32-bit) i have downloaded the core from the github source 
and i am unable to integrate it with cygwin
Please tell me what to do?
Regards
Shoaib
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

must press enter/return thrice to force new paragraph (sometimes)

2017-03-09 Thread Dwain Alford 
hello,

i had this same problem with open office. i don't understand. i set style prefs 
and added some new ones. there is a problem with the new one i call block 0.5. 
i also created a new default document. i set line spacing to single and no 
bottom paragraph spacing. seems this is where the problem begins.


the new default document:

i type a line. press enter/return twice and the cursor stays under the line 
until i press enter/return again. then the problem goes away, until later in 
the document or not again. hit or miss.


the block 0.5 settings are based on the text body indent settings. the before 
and after text is set at 0.5. i highlight all of the text to be blocked and 
double click the style setting. the second and third paragraphs change, and the 
first one does not change.


i have attached a test document to see if anyone else gets the same result. i 
typed a two line paragraph and the same press three times to force a paragraph 
is still a problem. i have duplicated this on the windows os as well. i can't 
remember if i had the same problem when i was using linux or not.


sure would like to resolve this problem.


system:

macbook pro (2015)

mac os x sierra (same problem on lion - imac (2011), core i5 2.7 ghz, 16gb ram)

core i 7 2.8 ghz

16gb ram

intel iris pro 1536 mb


cheers,
dwain


force paragraph test.odt
Description: force paragraph test.odt
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loleaflet/build loleaflet/dist loleaflet/src

2017-03-09 Thread Henry Castro 
 loleaflet/build/deps.js|6 
 loleaflet/dist/loleaflet.css   |   60 +
 loleaflet/src/control/Control.Scroll.Annotation.js |   62 +
 loleaflet/src/layer/marker/Annotation.js   |5 
 loleaflet/src/layer/tile/ImpressTileLayer.js   |  139 +++--
 loleaflet/src/layer/tile/TileLayer.js  |4 
 6 files changed, 265 insertions(+), 11 deletions(-)

New commits:
commit bd911ff9d55d3945e9d10c02aacc77b1b7c5e59b
Author: Henry Castro 
Date:   Thu Mar 9 22:39:48 2017 -0400

loleaflet: rework Impress annotations

LO Impress does not have an anchor position of the annotation object

Change-Id: Ifaa08bb3f62f442f3ee58242e835b6377901a592

diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index e1b2786..6cce092 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -435,6 +435,12 @@ var deps = {
desc: 'Group Annotations to put on the map.'
},
 
+   AnnotationScroll: {
+   src: ['control/Control.js',
+ 'control/Control.Scroll.Annotation.js'],
+   desc: 'Basic scroll control'
+   },
+
Annotation: {
src: ['layer/marker/Annotation.js'],
desc: 'Annotation to put on the map.'
diff --git a/loleaflet/dist/loleaflet.css b/loleaflet/dist/loleaflet.css
index 8225027..fbecbf7 100644
--- a/loleaflet/dist/loleaflet.css
+++ b/loleaflet/dist/loleaflet.css
@@ -247,3 +247,63 @@ body {
 .loleaflet-annotation-caption {
 font-weight: bold;
 }
+
+.loleaflet-bar {
+   box-shadow: 0 1px 5px rgba(0,0,0,0.65);
+   border-radius: 4px;
+   display: inline-block;
+   margin: 3px;
+   vertical-align: middle;
+}
+
+.loleaflet-bar a,
+.loleaflet-bar a:hover {
+   background-color: #fff;
+   border-bottom: 1px solid #ccc;
+   width: 30px;
+   height: 30px;
+   line-height: 30px;
+   display: block;
+   text-align: center;
+   text-decoration: none;
+   color: black;
+}
+
+.loleaflet-bar a {
+   background-position: 50% 50%;
+   background-repeat: no-repeat;
+   display: block;
+}
+
+.loleaflet-bar a:hover {
+   background-color: #f4f4f4;
+}
+
+.loleaflet-bar a:first-child {
+   border-top-left-radius: 4px;
+   border-top-right-radius: 4px;
+}
+
+.loleaflet-bar a:last-child {
+   border-bottom-left-radius: 4px;
+   border-bottom-right-radius: 4px;
+   border-bottom: none;
+}
+
+.loleaflet-bar a.leaflet-disabled {
+   cursor: default;
+   background-color: #f4f4f4;
+   color: #bbb;
+}
+
+.loleaflet-bar a {
+   width: 30px;
+   height: 30px;
+   line-height: 30px;
+}
+
+.loleaflet-control-scroll-up,
+.loleaflet-control-scroll-down {
+   font: bold 18px 'Lucida Console', Monaco, monospace;
+   text-indent: 1px;
+}
diff --git a/loleaflet/src/control/Control.Scroll.Annotation.js 
b/loleaflet/src/control/Control.Scroll.Annotation.js
new file mode 100644
index 000..0eb3b2c
--- /dev/null
+++ b/loleaflet/src/control/Control.Scroll.Annotation.js
@@ -0,0 +1,62 @@
+/*
+ * L.Control.Scroll.Annotation
+ */
+
+L.Control.Scroll.Annotation = L.Control.extend({
+   options: {
+   position: 'topright',
+   arrowUp: '0x25b2',
+   arrowUpTitle: _('Scroll up annotations'),
+   arrowDown: '0x25bc',
+   arrowDownTitle: _('Scroll down annotations')
+   },
+
+   onAdd: function (map) {
+   var scrollName = 'leaflet-control-scroll',
+   container = L.DomUtil.create('div', 'loleaflet-bar');
+
+   this._map = map;
+
+   this._buttonUp  = this._createButton(
+   this.options.arrowUp, this.options.arrowUpTitle,
+   scrollName + '-up',  container, this._onScrollUp,  
this);
+   this._buttonDown = this._createButton(
+   this.options.arrowDown, this.options.arrowDownTitle,
+   scrollName + '-down', container, this._onScrollDown, 
this);
+
+   return container;
+   },
+
+   onRemove: function (map) {
+   },
+
+   _onScrollUp: function (e) {
+   this._map.fire('AnnotationScrollUp');
+   },
+
+   _onScrollDown: function (e) {
+   this._map.fire('AnnotationScrollDown');
+   },
+
+   _createButton: function (html, title, className, container, fn, 
context) {
+   var link = L.DomUtil.create('a', className, container);
+   link.innerHTML = String.fromCharCode(html);
+   link.href = '#';
+   link.title = title;
+
+   var stop = L.DomEvent.stopPropagation;
+
+   L.DomEvent
+   .on(link, 'click', stop)
+   .on(link, 'mousedown', stop)
+   .on(link, 'dblclick', stop)
+

[Libreoffice-bugs] [Bug 106465] Unable To Open Files Associated To LO Format Using Mouse Double Click or Laptop 's keyboard button

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106465

--- Comment #1 from Sivraj  ---
Created attachment 131780
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131780=edit
Screenshot of the folders generated

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106465] New: Unable To Open Files Associated To LO Format Using Mouse Double Click or Laptop 's keyboard button

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106465

Bug ID: 106465
   Summary: Unable To Open Files Associated To LO Format Using
Mouse Double Click or Laptop's keyboard button
   Product: LibreOffice
   Version: 5.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: linuxnewbi...@gmail.com

Description:
Files cannot be opened using the mouse via double click or even using the
keyboard button in laptop. Whenever I do it, it creates a folder which contains
the metadata of the file. It seems that the file is being extracted although
the default application set for each file type is LibreOffice. Other file types
are working fine.

Issue started when I upgraded my system. I tried reverting to previous kernel
but the behaviour is the same. Tried reverting the version of LO but I'm
getting an error saying it "cannot be undone"

Steps to Reproduce:
1. Update the system
2. Double click a file ( odt, odp, ods, or even docx, xslx)
3. A folder will be created containing the metadata of the file you tried to
open.

Actual Results:  
The file will not open but it will create a folder.

Expected Results:
It should open the file normally using LibreOffice Writer, Calc or Impress.


Reproducible: Always

User Profile Reset: No

Additional Info:
Details:

Kernel: 4.9.13.-200
LibreOffice: 5.2.6.2
OS: Korora 25


User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:52.0) Gecko/20100101
Firefox/52.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106241] Mail Merge connects to gmail smtp server but emails are not sent

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106241

Adolfo Jayme  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106426] Calc UI visual glitch- edited cell font jumps above baseline

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106426

Adolfo Jayme  changed:

   What|Removed |Added

   Priority|medium  |low
  Component|LibreOffice |Calc
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90627] Saving presentation results in invalid PPTX file

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90627

--- Comment #5 from Luke  ---
Still corrupted when saved as PPTX by Version: 5.4.0.0.alpha0+
Build ID: 5b805de10a1b05647b616e726f0a8b88ff30ae77

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42346] FILESAVE: Cross-references to certain numbered items (object, graphic, table) turn to plain text on export to .doc or .docx ( works OK for headings and bookmarks)

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=42346

--- Comment #74 from j...@curioussymbols.com ---
In LibreOffice 5.2.5.1, I have found that instead of plain text, some
references get converted to nonsense ("Eq. 1" --> "Eq. Text", literally the
word 'Text' appears in Word) or else disappear completely ("Figure 1" --> "
Figure", number disappears, space inserted before the word 'Figure'.

With many documents required to be distributed in Word format in various
contexts it is CRITICAL that files exported from LibreOffice not lose content!
This is a high priority bug, in my view.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93597] FILEOPEN: Round-tripping OOXML chart with non-default styles results in blank chart

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93597

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||057

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97057] Shapes with Theme Color Lost When Resaved as XLSX File

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97057

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||597

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97993] EDITING: Copy and Paste for Images / Shapes Wonky in Writer

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97993

--- Comment #3 from Luke  ---
Version: 5.4.0.0.alpha0+
Build ID: 5b805de10a1b05647b616e726f0a8b88ff30ae77

Shapes and images are still placed directly on top of each other after CTRL+C
then CTRL+V.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93597] FILEOPEN: Round-tripping OOXML chart with non-default styles results in blank chart

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93597

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=90
   ||497

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90497] Implementing document themes

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90497

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=93
   ||597

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93597] FILEOPEN: Round-tripping OOXML chart with non-default styles results in blank chart

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=93597

--- Comment #6 from Luke  ---
Chart still disappear in Version: 5.4.0.0.alpha0+
Build ID: 5b805de10a1b05647b616e726f0a8b88ff30ae77

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103227] Clicking on link to go to external document (e.g., to play movie) during presentation does not work any longer

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103227

Victor  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #9 from Victor  ---
Hmm… I tried to downgrade. In the process I completely uninstalled libreoffice
and all dependencies. I didn’t succeed to install an older version and
therefore reinstalled the same version available in debian testing.
Surprisingly, this solved the problem. I don’t understand why, exactly the same
interactions work now, with exactly the same Libreoffice version apparently. It
may have been  some weird dependecy entanglement… Anyway, I can’t reproduce it
anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97625] UI: AutoCorrect button on toolbar poorly defined functionality

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=97625

--- Comment #8 from Luke  ---
Steps from Comment #2 still have same results.

Version: 5.4.0.0.alpha0+
Build ID: 5b805de10a1b05647b616e726f0a8b88ff30ae77

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47148] [meta] image caching / management is utterly shambolic

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47148

Luke  changed:

   What|Removed |Added

 Depends on||41006


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=41006
[Bug 41006] Z-order lost for objects within a frame
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41006] Z-order lost for objects within a frame

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=41006

Luke  changed:

   What|Removed |Added

 Blocks||47148


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
[Bug 47148] [meta] image caching / management is utterly shambolic
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47148] [meta] image caching / management is utterly shambolic

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47148

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||315

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96315] Multiple graphics inside frame do not keep arrangement after re-opening document

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96315

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=41
   ||006,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=47
   ||148

--- Comment #5 from Luke  ---
Z order still lost after save and reopening with Version: 5.4.0.0.alpha0+
Build ID: 5b805de10a1b05647b616e726f0a8b88ff30ae77

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41006] Z-order lost for objects within a frame

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=41006

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||315

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105248] disappearing frame in cut/paste in multi-section document

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105248

--- Comment #2 from j...@curioussymbols.com ---
Please could the importance of this bug be increased? Bug leads to corruption
of documents during normal use of LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105481] Formula disappears after file save and re-open

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105481

--- Comment #8 from j...@curioussymbols.com ---
Ping, any thoughts on this issue? Trying to work on this document is
infuriating, as the formula disappear every time I re-open it. 

Could the 'importance' of this bug please be increased, since no work-around is
known?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106455] Export to Wiki-Publisher

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106455

Mario  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Mario  ---
Also after update to fresh version libreoffice bug is present.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106241] Mail Merge connects to gmail smtp server but emails are not sent

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106241

Reto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Reto  ---
I made it working in 5.2.5 64bit with an odd workaround. Going through the mail
merge dialog, in step 3 I have to click "Choose address list" I find my
registered base file and the relevant table is already selected. Despite of
that I have click "Other table" and choose preview of the selected address
list, then select twice OK, then still in step 3 choose Complete. Then I can
prepare mail and send it. That's the only way I got it working. No one will
believe it, but I was going through that procedure and varyied everytime one
piece of it and eventually only that combination worked.

Not with having it resolved but having a workaround I will close the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102998
Bug 102998 depends on bug 106241, which changed state.

Bug 106241 Summary: Mail Merge connects to gmail smtp server but emails are not 
sent
https://bugs.documentfoundation.org/show_bug.cgi?id=106241

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103227] Clicking on link to go to external document (e.g., to play movie) during presentation does not work any longer

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103227

Victor  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #8 from Victor  ---
I think I’m running into this bug on Debian testing with

Version: 5.2.5.1
Build ID: 1:5.2.5-2
CPU Threads: 4; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; 
Locale: fr-FR (en_GB.utf8); Calc: group

It actually affects also the "run program" Interaction. "Go to document" and
"run program" work in edit mode: clicking on the object runs the action.
Clicking on the object in presentation mode just advances to the next slide. 

Deactivating the setting "Change slides by clicking on backgrund" in the "Slide
show settings" should prevent this but doesn’t. 

I used extensively the "Run program" interaction in the past. Older
presentations, which used to work fine, don’t work anymore as expected. I can’t
tell precisely when the change happened because I haven’t used Impress in a few
months maybe. I’ll try to downgrade and see if it solves anything…

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source

2017-03-09 Thread Eike Rathke 
 sc/qa/unit/ucalc.cxx   |   15 +++
 sc/source/core/data/postit.cxx |4 +++-
 2 files changed, 18 insertions(+), 1 deletion(-)

New commits:
commit da3d56b077ce81f6f399a68f53895590dbb1357f
Author: Eike Rathke 
Date:   Thu Mar 9 23:15:42 2017 +0100

finally turn this into a hard assert

Change-Id: Iba6abafeaa2542fc94b76a642ddb0eb5b70b572d

diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index c01b6d7..3addea4 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -959,7 +959,9 @@ void ScPostIt::UpdateCaptionPos( const ScAddress& rPos )
 
 void ScPostIt::CreateCaptionFromInitData( const ScAddress& rPos ) const
 {
-OSL_ENSURE( maNoteData.mxCaption || maNoteData.mxInitData.get(), 
"ScPostIt::CreateCaptionFromInitData - need caption object or initial caption 
data" );
+// Captions are not created in Undo documents and only rarely in Clipboard,
+// but otherwise we need caption or initial data.
+assert((maNoteData.mxCaption || maNoteData.mxInitData.get()) || 
mrDoc.IsUndo() || mrDoc.IsClipboard());
 if( maNoteData.mxInitData.get() )
 {
 /*  This function is called from ScPostIt::Clone() when copying cells
commit 96175e7ed24fc007f88c418f8d449b6bd07563ad
Author: Eike Rathke 
Date:   Thu Mar 9 22:38:57 2017 +0100

it's raining drawing layers

Change-Id: Ieee5cb5792535185ef09c3775072ed739fb0e4b0

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index dcb9a90..40a2801 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -776,6 +776,9 @@ void Test::testCopyToDocument()
 {
 CPPUNIT_ASSERT_MESSAGE ("failed to insert sheet", m_pDoc->InsertTab (0, 
"src"));
 
+// We need a drawing layer in order to create caption objects.
+m_pDoc->InitDrawLayer(());
+
 m_pDoc->SetString(0, 0, 0, "Header");
 m_pDoc->SetString(0, 1, 0, "1");
 m_pDoc->SetString(0, 2, 0, "2");
@@ -1986,6 +1989,9 @@ void Test::testSheetCopy()
 CPPUNIT_ASSERT_EQUAL_MESSAGE("document should have one sheet to begin 
with.",
static_cast(1), m_pDoc->GetTableCount());
 
+// We need a drawing layer in order to create caption objects.
+m_pDoc->InitDrawLayer(());
+
 // Insert text in A1.
 m_pDoc->SetString(ScAddress(0,0,0), "copy me");
 
@@ -5247,6 +5253,9 @@ void Test::testNoteDeleteCol()
 ScDocument& rDoc = getDocShell().GetDocument();
 rDoc.InsertTab(0, "Sheet1");
 
+// We need a drawing layer in order to create caption objects.
+m_pDoc->InitDrawLayer(());
+
 ScAddress rAddr(1, 1, 0);
 ScPostIt* pNote = m_pDoc->GetOrCreateNote(rAddr);
 pNote->SetText(rAddr, "Hello");
@@ -5471,6 +5480,9 @@ void Test::testAreasWithNotes()
 ScDocument& rDoc = getDocShell().GetDocument();
 rDoc.InsertTab(0, "Sheet1");
 
+// We need a drawing layer in order to create caption objects.
+m_pDoc->InitDrawLayer(());
+
 ScAddress rAddr(1, 5, 0);
 ScPostIt* pNote = m_pDoc->GetOrCreateNote(rAddr);
 pNote->SetText(rAddr, "Hello");
@@ -6270,6 +6282,9 @@ void Test::testSetStringAndNote()
 {
 m_pDoc->InsertTab(0, "Test");
 
+// We need a drawing layer in order to create caption objects.
+m_pDoc->InitDrawLayer(());
+
 //note on A1
 ScAddress aAdrA1 (0, 0, 0);
 ScPostIt* pNote = m_pDoc->GetOrCreateNote(aAdrA1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - solenv/gbuild

2017-03-09 Thread Stephan Bergmann 
 solenv/gbuild/platform/filter-showIncludes.awk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 62c837748662d304de8a70a1825c304d72f11178
Author: Stephan Bergmann 
Date:   Thu Mar 9 10:10:57 2017 +0100

Remove stray CR from input

...that remained there with recent Cygwin/Bash version, which apparently had
changes to their Unix-vs.-DOS line end handling

Change-Id: Ib4c7c924362f9e93066e544ed5214fe589aa5336
Reviewed-on: https://gerrit.libreoffice.org/34990
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 
(cherry picked from commit 9166569da389de44075b3d03413b353046a4)
Reviewed-on: https://gerrit.libreoffice.org/35019
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/solenv/gbuild/platform/filter-showIncludes.awk 
b/solenv/gbuild/platform/filter-showIncludes.awk
index 21a4585..6ec13e2 100755
--- a/solenv/gbuild/platform/filter-showIncludes.awk
+++ b/solenv/gbuild/platform/filter-showIncludes.awk
@@ -40,6 +40,7 @@ BEGIN {
 }
 
 {
+sub(/\r$/, "")
 sub(/^ */, "")
 if (index($0, showincludes_prefix) == 1) {
 $0 = substr($0, length(showincludes_prefix) + 1)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2017-03-09 Thread Caolán McNamara 
 vcl/source/gdi/svmconverter.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8645f6d866427bfd82bce1bf96721533c113c077
Author: Caolán McNamara 
Date:   Tue Jan 31 09:23:09 2017 +

ofz#502 negative index

Change-Id: I2eb3da9d378cd8fdace5ccd644f501f5119f6698

diff --git a/vcl/source/gdi/svmconverter.cxx b/vcl/source/gdi/svmconverter.cxx
index efcc250..e4a00a1 100644
--- a/vcl/source/gdi/svmconverter.cxx
+++ b/vcl/source/gdi/svmconverter.cxx
@@ -974,7 +974,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 // #106172# Add last DX array elem, if missing
 if( nAryLen != nStrLen )
 {
-if( nAryLen+1 == nStrLen )
+if (nAryLen+1 == nStrLen && nIndex >= 0)
 {
 std::unique_ptr pTmpAry(new 
long[nStrLen]);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: connectivity/source

2017-03-09 Thread Michael Stahl 
 connectivity/source/drivers/file/FResultSet.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 567ee77154c9f5a67a663edfe2f897e00d084124
Author: Michael Stahl 
Date:   Thu Mar 9 22:41:51 2017 +0100

connectivity: warning C4389: '==' : signed/unsigned mismatch

Change-Id: I95e3d7ac5c78aa18dabcdcff19ec1844e45aee3c

diff --git a/connectivity/source/drivers/file/FResultSet.cxx 
b/connectivity/source/drivers/file/FResultSet.cxx
index 88c7ef4..4919d37 100644
--- a/connectivity/source/drivers/file/FResultSet.cxx
+++ b/connectivity/source/drivers/file/FResultSet.cxx
@@ -1262,7 +1262,8 @@ bool OResultSet::OpenImpl()
  i < m_aColMapping.size(); ++i)
 {
 if (std::find(m_aOrderbyColumnNumber.begin(),
-m_aOrderbyColumnNumber.end(), i)
+m_aOrderbyColumnNumber.end(),
+sal::static_int_cast(i))
 == m_aOrderbyColumnNumber.end())
 {
 m_aOrderbyColumnNumber.push_back(i);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106241] Mail Merge connects to gmail smtp server but emails are not sent

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106241

--- Comment #9 from Reto  ---
I checked out which older versions still work. So 5.04 and 5.1.6 still work
with the same settings as described. 5.2.5 and 5.3.1 do not work.

Any ideas what has led to that behaviour?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106372] FORMATTING: Wrap with "text in line" missing

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106372

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl
Version|unspecified |Inherited From OOo
 Ever confirmed|0   |1

--- Comment #2 from Cor Nouws  ---
So an example:

in stead of 

-frame--
|.. |
 ...(picture)..
 ..
 ..
 ..
   caption text |
-frame--


make this possible in a frame

-frame
|..  caption text/description |
 ...(picture)..   |
 ..
 ..
 ..
-frame

thanks for filing, and the document with samples, Thomas!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

2017-03-09 Thread Caolán McNamara 
 vcl/source/gdi/pngread.cxx |   17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)

New commits:
commit 0f0f02d633e2f9e69220d3d47de17b9e34b00765
Author: Caolán McNamara 
Date:   Wed Feb 8 14:23:27 2017 +

ofz#574 sanitize png palette indexes

Change-Id: I006ffdf5c8c751e7e07b133716022e2a9b154478
Reviewed-on: https://gerrit.libreoffice.org/34034
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/gdi/pngread.cxx b/vcl/source/gdi/pngread.cxx
index bea6e07..6cf9828 100644
--- a/vcl/source/gdi/pngread.cxx
+++ b/vcl/source/gdi/pngread.cxx
@@ -1114,6 +1114,19 @@ void PNGReaderImpl::ImplApplyFilter()
 
 namespace
 {
+sal_uInt8 SanitizePaletteIndex(sal_uInt8 nIndex, sal_uInt16 
nPaletteEntryCount)
+{
+if (nIndex >= nPaletteEntryCount)
+{
+auto nSanitizedIndex = nIndex % nPaletteEntryCount;
+SAL_WARN_IF(nIndex != nSanitizedIndex, "vcl", "invalid colormap 
index: "
+<< static_cast(nIndex) << ", colormap 
len is: "
+<< nPaletteEntryCount);
+nIndex = nSanitizedIndex;
+}
+return nIndex;
+}
+
 void SanitizePaletteIndexes(sal_uInt8* pEntries, int nLen, const 
Bitmap::ScopedWriteAccess& rAcc)
 {
 sal_uInt16 nPaletteEntryCount = rAcc->GetPaletteEntryCount();
@@ -1602,7 +1615,7 @@ void PNGReaderImpl::ImplSetPixel( sal_uInt32 nY, 
sal_uInt32 nX, sal_uInt8 nPalIn
 return;
 nX >>= mnPreviewShift;
 
-mxAcc->SetPixelIndex( nY, nX, nPalIndex );
+mxAcc->SetPixelIndex(nY, nX, SanitizePaletteIndex(nPalIndex, 
mxAcc->GetPaletteEntryCount()));
 }
 
 void PNGReaderImpl::ImplSetTranspPixel( sal_uInt32 nY, sal_uInt32 nX, const 
BitmapColor& rBitmapColor, bool bTrans )
@@ -1628,7 +1641,7 @@ void PNGReaderImpl::ImplSetAlphaPixel( sal_uInt32 nY, 
sal_uInt32 nX,
 return;
 nX >>= mnPreviewShift;
 
-mxAcc->SetPixelIndex( nY, nX, nPalIndex );
+mxAcc->SetPixelIndex(nY, nX, SanitizePaletteIndex(nPalIndex, 
mxAcc->GetPaletteEntryCount()));
 mpMaskAcc->SetPixel(nY, nX, BitmapColor(~nAlpha));
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: RepositoryExternal.mk

2017-03-09 Thread Michael Stahl 
 RepositoryExternal.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3e23beda17b12e35da3be3ca65f0c3d41c60d79d
Author: Michael Stahl 
Date:   Thu Mar 9 22:07:12 2017 +0100

RepositoryExternal: fix MSVC 2017 python3 library directory

Change-Id: I74514993ca1cbeb1a7e7bf1ba121b28ce9dab2f3

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index e97e14e..00cae64 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3075,7 +3075,7 @@ endif
 
 ifeq ($(OS),WNT)
 $(call gb_LinkTarget_add_libs,$(1),\
-   $(call gb_UnpackedTarball_get_dir,python3)/PCbuild$(if $(filter 
X86_64,$(CPUNAME)),/amd64)$(if $(filter 
140-INTEL,$(VCVER)-$(CPUNAME)),/win32)/python$(PYTHON_VERSION_MAJOR)$(PYTHON_VERSION_MINOR)$(if
 $(MSVC_USE_DEBUG_RUNTIME),_d).lib \
+   $(call gb_UnpackedTarball_get_dir,python3)/PCbuild$(if $(filter 
X86_64,$(CPUNAME)),/amd64)$(if $(filter 
INTEL,$(CPUNAME)),/win32)/python$(PYTHON_VERSION_MAJOR)$(PYTHON_VERSION_MINOR)$(if
 $(MSVC_USE_DEBUG_RUNTIME),_d).lib \
 )
 else ifeq ($(OS),MACOSX)
 $(call gb_LinkTarget_add_libs,$(1),\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 6 commits - sc/inc sc/qa sc/source

2017-03-09 Thread Eike Rathke 
 sc/inc/postit.hxx  |   18 ++-
 sc/qa/unit/ucalc.cxx   |   49 +++-
 sc/qa/unit/ucalc_sort.cxx  |3 +
 sc/source/core/data/postit.cxx |   62 +++--
 4 files changed, 102 insertions(+), 30 deletions(-)

New commits:
commit 646a1d20974ff13b908a85cdff37c2701d582d8f
Author: Eike Rathke 
Date:   Thu Mar 9 22:09:55 2017 +0100

add/use ScCaptionPtr::removeFromDrawPage()

Change-Id: Ibe073f071b120b61738b7e813a14824248f1fcfc

diff --git a/sc/inc/postit.hxx b/sc/inc/postit.hxx
index dfb88c1..c61df47 100644
--- a/sc/inc/postit.hxx
+++ b/sc/inc/postit.hxx
@@ -63,6 +63,11 @@ public:
  */
 void insertToDrawPage( SdrPage& rDrawPage );
 
+/** Remove from draw page. The caption object is not owned anymore by the
+draw page then.
+ */
+void removeFromDrawPage( SdrPage& rDrawPage );
+
 /** Release all management of the SdrCaptionObj* in all instances of this
 list and dissolve. The SdrCaptionObj pointer returned is ready to be
 managed elsewhere.
diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index 8ed2e9f..c01b6d7 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -710,6 +710,20 @@ void ScCaptionPtr::insertToDrawPage( SdrPage& rDrawPage )
 mpHead->mbInDrawPage = true;
 }
 
+void ScCaptionPtr::removeFromDrawPage( SdrPage& rDrawPage )
+{
+assert(mpHead && mpCaption);
+
SAL_WARN_IF(!mpHead->mbInDrawPage,"sc.core","ScCaptionPtr::removeFromDrawPage - 
not in draw page");
+/* FIXME: that should assert, but currently fails in
+ * Test::testCopyToDocument() probably due to CopyStaticToDocument()
+ * lacking something. */
+//assert(mpHead->mbInDrawPage);   // did we lose track anywhere?
+
+SdrObject* pObj = rDrawPage.RemoveObject( mpCaption->GetOrdNum() );
+assert(pObj == mpCaption); (void)pObj;
+mpHead->mbInDrawPage = false;
+}
+
 SdrCaptionObj* ScCaptionPtr::release()
 {
 SdrCaptionObj* pTmp = mpCaption;
@@ -1081,10 +1095,10 @@ void ScPostIt::RemoveCaption()
 if( bRecording )
 pDrawLayer->AddCalcUndo( new SdrUndoDelObj( 
*maNoteData.mxCaption.get() ) );
 // remove the object from the drawing page, delete if undo is 
disabled
-SdrObject* pObj = pDrawPage->RemoveObject( 
maNoteData.mxCaption->GetOrdNum() );
+maNoteData.mxCaption.removeFromDrawPage( *pDrawPage );
 if( !bRecording )
 {
-maNoteData.mxCaption.release();
+SdrObject* pObj = maNoteData.mxCaption.release();
 SdrObject::Free( pObj );
 }
 }
commit b3354ad2482737b49bd8d7593d355671197c4551
Author: Eike Rathke 
Date:   Thu Mar 9 22:08:38 2017 +0100

sprinkle some drawing layers over test cases

... so things actually work like intended and creation of caption objects
doesn't silently fail. Well, it does SAL_WARN or OSL_ENSURE but that's never
displayed unless a test fails.

Change-Id: Ibf4cc075cc3d6dadbe8f6208b2949310124b5749

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index af2e645..dcb9a90 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -790,22 +790,29 @@ void Test::testCopyToDocument()
 
 // Copy statically to another document.
 
-ScDocument aDestDoc(SCDOCMODE_DOCUMENT);
-aDestDoc.InsertTab(0, "src");
-m_pDoc->CopyStaticToDocument(ScRange(0,1,0,0,3,0), 0, ); // Copy 
A2:A4
-m_pDoc->CopyStaticToDocument(ScAddress(0,0,0), 0, ); // Copy A1
-m_pDoc->CopyStaticToDocument(ScRange(0,4,0,0,7,0), 0, ); // Copy 
A5:A8
-
-CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,0,0), aDestDoc.GetString(0,0,0));
-CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,1,0), aDestDoc.GetString(0,1,0));
-CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,2,0), aDestDoc.GetString(0,2,0));
-CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,3,0), aDestDoc.GetString(0,3,0));
-CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,4,0), aDestDoc.GetString(0,4,0));
+ScDocShellRef xDocSh2;
+getNewDocShell(xDocSh2);
+ScDocument* pDestDoc = >GetDocument();
+pDestDoc->InsertTab(0, "src");
+pDestDoc->InitDrawLayer(xDocSh2.get()); // for note caption objects
+
+m_pDoc->CopyStaticToDocument(ScRange(0,1,0,0,3,0), 0, pDestDoc); // Copy 
A2:A4
+m_pDoc->CopyStaticToDocument(ScAddress(0,0,0), 0, pDestDoc); // Copy A1
+m_pDoc->CopyStaticToDocument(ScRange(0,4,0,0,7,0), 0, pDestDoc); // Copy 
A5:A8
+
+CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,0,0), pDestDoc->GetString(0,0,0));
+CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,1,0), pDestDoc->GetString(0,1,0));
+CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,2,0), pDestDoc->GetString(0,2,0));
+CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,3,0), pDestDoc->GetString(0,3,0));
+CPPUNIT_ASSERT_EQUAL(m_pDoc->GetString(0,4,0),

[Libreoffice-bugs] [Bug 106464] Text unreadable when editing cell

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106464

Carl N  changed:

   What|Removed |Added

 CC||carlniko...@gmail.com

--- Comment #1 from Carl N  ---
Created attachment 131779
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131779=edit
Example of Mixed up text

See Cell number D89

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source

2017-03-09 Thread Caolán McNamara 
 filter/source/graphicfilter/ieps/ieps.cxx |   88 +++---
 1 file changed, 57 insertions(+), 31 deletions(-)

New commits:
commit e897f9d74d0210c500fda918e891f3b3499518c7
Author: Caolán McNamara 
Date:   Sun Jan 29 20:54:56 2017 +

Resolves: ofz#488 check remaining size while parsing

Change-Id: Ibb2b6c59a159f9fafa6a065be438b59a6d2d3f21

diff --git a/filter/source/graphicfilter/ieps/ieps.cxx 
b/filter/source/graphicfilter/ieps/ieps.cxx
index 41802f8..af4ab68 100644
--- a/filter/source/graphicfilter/ieps/ieps.cxx
+++ b/filter/source/graphicfilter/ieps/ieps.cxx
@@ -466,7 +466,6 @@ void MakePreview(sal_uInt8* pBuf, sal_uInt32 nBytesRead,
 pVDev->SetFillColor();
 
 aFont.SetColor( COL_LIGHTRED );
-//  aFont.SetSize( Size( 0, 32 ) );
 
 pVDev->Push( PushFlags::FONT );
 pVDev->SetFont( aFont );
@@ -477,54 +476,81 @@ void MakePreview(sal_uInt8* pBuf, sal_uInt32 nBytesRead,
 OUString aString;
 int nLen;
 sal_uInt8* pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%Title:"), nBytesRead - 32, 8 );
-if ( pDest )
+sal_uInt32 nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 8)
 {
 pDest += 8;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+nRemainingBytes -= 8;
+if (nRemainingBytes && *pDest == ' ')
 {
-const char* pStr = reinterpret_cast(pDest);
-aString += " Title:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
+{
+sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
+if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+{
+const char* pStr = reinterpret_cast(pDest);
+aString += " Title:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
+}
+pDest[ nLen ] = aOldValue;
 }
-pDest[ nLen ] = aOldValue;
 }
 pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%Creator:"), nBytesRead - 32, 10 );
-if ( pDest )
+nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 10)
 {
 pDest += 10;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-const char* pStr = reinterpret_cast(pDest);
-aString += " Creator:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
-pDest[ nLen ] = aOldValue;
+nRemainingBytes -= 10;
+if (nRemainingBytes && *pDest == ' ')
+{
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
+{
+sal_uInt8 aOldValue(pDest[nLen]); pDest[nLen] = 0;
+const char* pStr = reinterpret_cast(pDest);
+aString += " Creator:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
+pDest[nLen] = aOldValue;
+}
 }
 pDest = ImplSearchEntry( pBuf, reinterpret_cast("%%CreationDate:"), nBytesRead - 32, 15 );
-if ( pDest )
+nRemainingBytes = pDest ? (nBytesRead - (pDest - pBuf)) : 0;
+if (nRemainingBytes >= 15)
 {
 pDest += 15;
-if ( *pDest == ' ' )
-pDest++;
-nLen = ImplGetLen( pDest, 32 );
-sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
-if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+nRemainingBytes -= 15;
+if (nRemainingBytes && *pDest == ' ')
 {
-const char* pStr = reinterpret_cast(pDest);
-aString += " CreationDate:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
+++pDest;
+--nRemainingBytes;
+}
+nLen = ImplGetLen(pDest, std::min(nRemainingBytes, 32));
+if (static_cast(nLen) < nRemainingBytes)
+{
+sal_uInt8 aOldValue(pDest[ nLen ]); pDest[ nLen ] = 0;
+if ( strcmp( reinterpret_cast(pDest), "none" ) != 0 )
+{
+aString += " CreationDate:" + OUString::createFromAscii( 
reinterpret_cast(pDest) ) + "\n";
+const char* pStr = reinterpret_cast(pDest);
+aString += " CreationDate:" + OUString(pStr, strlen(pStr), 
RTL_TEXTENCODING_ASCII_US) + "\n";
+}
+pDest[ nLen ] = aOldValue;
 }
-pDest[ nLen ] = aOldValue;
 }

[Libreoffice-bugs] [Bug 106464] New: Text unreadable when editing cell

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106464

Bug ID: 106464
   Summary: Text unreadable when editing cell
   Product: LibreOffice
   Version: 5.2.5.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: carlniko...@gmail.com

Description:
When I edit a cell the text seems to display oddly
I am running debian linux stretch using the proper graphics card driver

Steps to Reproduce:
1.click a cell
2.edit the text
3.text appears mixed up

Actual Results:  
See above

Expected Results:
You expect to see the new text without seeing any of the old text running into
the new text.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/56.0.2924.76 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: slideshow/source svx/source

2017-03-09 Thread Caolán McNamara 
 slideshow/source/engine/activitiesqueue.cxx|7 +-
 slideshow/source/engine/eventqueue.cxx |7 +-
 slideshow/source/engine/rehearsetimingsactivity.cxx|7 +-
 slideshow/source/engine/shapesubset.cxx|7 +-
 slideshow/source/engine/slide/userpaintoverlay.cxx |7 +-
 slideshow/source/engine/transitions/shapetransitionfactory.cxx |   10 +
 slideshow/source/engine/usereventqueue.cxx |8 ++-
 svx/source/svdraw/svdoole2.cxx |   11 
+++---
 8 files changed, 19 insertions(+), 45 deletions(-)

New commits:
commit 01112d2a6383bbb777db973c60b809b29576f39f
Author: Caolán McNamara 
Date:   Thu Mar 9 20:57:31 2017 +

some OSL_FAIL to SAL_WARN

Change-Id: I5101e42b7a34cca9055fc805d9a392ba4f920a3d

diff --git a/slideshow/source/engine/activitiesqueue.cxx 
b/slideshow/source/engine/activitiesqueue.cxx
index 8ece2a3..4a159c2 100644
--- a/slideshow/source/engine/activitiesqueue.cxx
+++ b/slideshow/source/engine/activitiesqueue.cxx
@@ -55,12 +55,9 @@ namespace slideshow
 for( const auto& pActivity : maCurrentActivitiesReinsert )
 pActivity->dispose();
 }
-catch (uno::Exception &)
+catch (const uno::Exception&)
 {
-OSL_FAIL( OUStringToOString(
-comphelper::anyToString(
-cppu::getCaughtException() ),
-RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_WARN( "slideshow", "" << 
comphelper::anyToString(cppu::getCaughtException() ) );
 }
 }
 
diff --git a/slideshow/source/engine/eventqueue.cxx 
b/slideshow/source/engine/eventqueue.cxx
index 4a34400..bcf8d1b 100644
--- a/slideshow/source/engine/eventqueue.cxx
+++ b/slideshow/source/engine/eventqueue.cxx
@@ -73,12 +73,9 @@ namespace slideshow
 {
 maEvents.top().pEvent->dispose();
 }
-catch (uno::Exception &)
+catch (const uno::Exception&)
 {
-OSL_FAIL( OUStringToOString(
-comphelper::anyToString(
-cppu::getCaughtException() ),
-RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_WARN( "slideshow", "" << 
comphelper::anyToString(cppu::getCaughtException() ) );
 }
 maEvents.pop();
 }
diff --git a/slideshow/source/engine/rehearsetimingsactivity.cxx 
b/slideshow/source/engine/rehearsetimingsactivity.cxx
index a08b50d..788f043 100644
--- a/slideshow/source/engine/rehearsetimingsactivity.cxx
+++ b/slideshow/source/engine/rehearsetimingsactivity.cxx
@@ -179,12 +179,9 @@ RehearseTimingsActivity::~RehearseTimingsActivity()
 {
 stop();
 }
-catch (uno::Exception &)
+catch (const uno::Exception&)
 {
-OSL_FAIL( OUStringToOString(
-comphelper::anyToString(
-cppu::getCaughtException() ),
-RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_WARN( "slideshow", "" << 
comphelper::anyToString(cppu::getCaughtException() ) );
 }
 }
 
diff --git a/slideshow/source/engine/shapesubset.cxx 
b/slideshow/source/engine/shapesubset.cxx
index 23fd809..46c0d0c 100644
--- a/slideshow/source/engine/shapesubset.cxx
+++ b/slideshow/source/engine/shapesubset.cxx
@@ -79,12 +79,9 @@ namespace slideshow
 // if not done yet: revoke subset from original
 disableSubsetShape();
 }
-catch (uno::Exception &)
+catch (const uno::Exception&)
 {
-OSL_FAIL( OUStringToOString(
-comphelper::anyToString(
-cppu::getCaughtException() ),
-RTL_TEXTENCODING_UTF8 ).getStr() );
+SAL_WARN( "slideshow", "" << 
comphelper::anyToString(cppu::getCaughtException() ) );
 }
 }
 
diff --git a/slideshow/source/engine/slide/userpaintoverlay.cxx 
b/slideshow/source/engine/slide/userpaintoverlay.cxx
index 3e720c3..3657de8 100644
--- a/slideshow/source/engine/slide/userpaintoverlay.cxx
+++ b/slideshow/source/engine/slide/userpaintoverlay.cxx
@@ -487,12 +487,9 @@ namespace slideshow
 mrMultiplexer.removeViewHandler( mpHandler );
 mpHandler->dispose();
 }
-catch (uno::Exception &)
+catch (const uno::Exception&)
 {
-OSL_FAIL( OUStringToOString(
-comphelper::anyToString(
-cppu::getCaughtException() ),
-

[Libreoffice-bugs] [Bug 100462] Locale en-GB-oxendict (previously en-GB-oed) is missing or broken -> corresponding spell-checker does not work.

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100462

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
Ok, then let's move it to NEW since you confirmed it. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106321] Impress slide object needs focus to update export jpg

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106321

--- Comment #2 from Umang Jain  ---
I confirm the bug however I am confused. The description provided is up to the
mark and accurate. If the textbox is still in-focus and export for JPG is done,
the changes would not appear in the exported JPG. 

I would like to take up this bug and solve it as my first contribution to
LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90631] UI: Format-Area dialog, color tab is extremely confusing, with further regression in 5.3

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=90631

--- Comment #13 from sergio.calleg...@gmail.com ---
Hope I'm not abusing of your patience in providing explanations and guidelines.
Just two more questions with thanks in advance for the answer!

1) You say:

> You do not only have the chance to share palettes but also to create own 
> collections via the Custom palette. This one is the replacement for Tools > 
> Options > Colors. And eventually the Document colors should also provide a 
> way to have a unique coloring.

can you help me with a best practice workflow?

Suppose that I create a custom palette for some activity. For instance, imagine
that I'm in a project with some other people and that we want all the material
related to the project to have its own identity, by using certain shapes,
colors, etc. To assure the color consistency, I define a custom palette. Now,
how do I pass it to the other people in the project? How do I store it for
later, assuming that some other activity will require a different custom
palette?

2) Apparently, I have a standard.soc, a libreoffice.soc and an html.soc file in
my LibO profile (a legacy of previous LibO versions?), which means that I am
getting repeated entries in the palette selector. Is this expected?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106463] missing commit to external firebird database file

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106463

--- Comment #1 from Terrence Enger  ---
Created attachment 131778
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131778=edit
example database over /tmp/bug_20170307a/example.odb

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106463] missing commit to external firebird database file

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106463

Terrence Enger  changed:

   What|Removed |Added

   Keywords||dataLoss

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106463] New: missing commit to external firebird database file

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106463

Bug ID: 106463
   Summary: missing commit to external firebird database file
   Product: LibreOffice
   Version: 5.4.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

Description:
In daily Linux dbgutil bibisect repository version 2017-03-07 running on
debian-stretch with firebird 3.0 installed, I lose data entered into a table

Steps to Reproduce:
(1) download attached example.odb.

(2) mkdir /tmp/bug_20170307a/ and download example.fdb attached to bug
106427

into that directory.  This is a firebird database with one
table with one column and no records.

(3) Open example.odb from the command line.  Program presents main
database window.

(4) open table authors and insert data
author
--
Knuth, Donald E.
Else, Somebody
and close the data entry window

(5) open table authors.  Observe the two rows you entered.  Close the
data entry window.

(6) File > Close.  Program prompts to save the data.

(7) Click .  Program closes the database window and shows Start
Center.

(8) From list of recently opened files, open domained.odb.  Program
presents database window.

(9) Open table authors.


Actual Results:  
two rows, as entered in step (4).

Expected Results:
no data.


Reproducible: Always

User Profile Reset: No

Additional Info:
It is possible to work around the problem by using Tools > "SQL..." to issue a
commit command after step (5).

I am adding keyword dataloss


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bin/oss-fuzz-build.sh configure.ac

2017-03-09 Thread Caolán McNamara 
 bin/oss-fuzz-build.sh |7 +--
 configure.ac  |6 +-
 2 files changed, 10 insertions(+), 3 deletions(-)

New commits:
commit 3b7054e0bb86cec2db08b7c7654710a21cf66a94
Author: Caolán McNamara 
Date:   Thu Mar 9 10:24:22 2017 +

use a different resource dir for oss-fuzz

This reverts commit 754854674859560506b617ebf07e6563c197aac8.

Change-Id: I0863fb5e34608911c784bbdf19e76297b3c2d13e

diff --git a/bin/oss-fuzz-build.sh b/bin/oss-fuzz-build.sh
index 2c54e13..b0d3d6e 100755
--- a/bin/oss-fuzz-build.sh
+++ b/bin/oss-fuzz-build.sh
@@ -24,10 +24,13 @@ make fuzzers
 cp $SRC/libreoffice/extras/source/truetype/symbol/opens___.ttf 
instdir/share/fonts/truetype/Liberation* $OUT
 #minimal runtime requirements
 rm -rf $OUT/services $OUT/types $OUT/resource $OUT/*rdb
-pushd instdir/program
-cp -r *fuzzer *rc *rdb services types resource $OUT
+pushd instdir
+cp -r resource $OUT
+pushd program
+cp -r *fuzzer *rc *rdb services types $OUT
 mv $OUT/services/services.rdb $OUT/services.rdb
 popd
+popd
 
 #starting corpuses
 cp $SRC/*_seed_corpus.zip $OUT
diff --git a/configure.ac b/configure.ac
index fb4441c..dd945c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3129,7 +3129,11 @@ else
 LIBO_SHARE_JAVA_FOLDER=program/classes
 LIBO_SHARE_PRESETS_FOLDER=presets
 LIBO_SHARE_READMES_FOLDER=readmes
-LIBO_SHARE_RESOURCE_FOLDER=program/resource
+if test "$enable_fuzzers" != yes; then
+LIBO_SHARE_RESOURCE_FOLDER=program/resource
+else
+LIBO_SHARE_RESOURCE_FOLDER=resource
+fi
 LIBO_SHARE_SHELL_FOLDER=program/shell
 LIBO_URE_BIN_FOLDER=program
 LIBO_URE_ETC_FOLDER=program
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 47666] improve calc's filters test cases

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47666

--- Comment #9 from Mayank  ---
Can you please help me get started with this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47666] improve calc's filters test cases

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=47666

Mayank  changed:

   What|Removed |Added

 CC||fireball4...@gmail.com

--- Comment #8 from Mayank  ---
Can you please help me get started with this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2017-03-09 Thread Samuel Mehrbrodt 
 cui/source/options/optjava.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit a831608576f5411e143bb09b5d135fe3d1bfda8f
Author: Samuel Mehrbrodt 
Date:   Thu Mar 9 20:27:44 2017 +0100

Remove newlines at end of file

Change-Id: I538bff61cbbd69c17f871698cf983b275dd68761
Reviewed-on: https://gerrit.libreoffice.org/35025
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index 871c43a..f7a9097 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -1148,5 +1148,3 @@ void SvxJavaClassPathDlg::SetClassPath( const OUString& 
_rPath )
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
-
-
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: jvmfwk/plugins

2017-03-09 Thread Samuel Mehrbrodt 
 jvmfwk/plugins/sunmajor/pluginlib/util.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 89bfaa58e5b6421ee272f77e8d542eb2344e3fa5
Author: Samuel Mehrbrodt 
Date:   Thu Mar 9 15:41:52 2017 +0100

jvmfwk: Improve logging output

Change-Id: I476fc3190902e44bedfd2e713bd1a7cfb0733688
Reviewed-on: https://gerrit.libreoffice.org/35024
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
index 5694256..3c31e60 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/util.cxx
@@ -499,6 +499,7 @@ bool getJavaProps(const OUString & exePath,
 
 //Use this thread to read output stream
 FileHandleReader::Result rs = FileHandleReader::RESULT_OK;
+JFW_TRACE2("Properties found:");
 while (true)
 {
 OString aLine;
@@ -508,7 +509,7 @@ bool getJavaProps(const OUString & exePath,
 OUString sLine;
 if (!decodeOutput(aLine, ))
 continue;
-JFW_TRACE2(" \"" << sLine << " \"");
+JFW_TRACE2("  \"" << sLine << "\"");
 sLine = sLine.trim();
 if (sLine.isEmpty())
 continue;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/qa

2017-03-09 Thread Zdeněk Crhonek 
 sc/qa/unit/data/functions/financial/fods/pduration.fods | 5702 
 1 file changed, 5702 insertions(+)

New commits:
commit e877fd1b6abb8ad89f30737bb9091c28f3695848
Author: Zdeněk Crhonek 
Date:   Thu Mar 9 18:40:57 2017 +0100

add PDURATION test case

Change-Id: I19ca8ccbcd724fc616b8a2bba8bc158e71a4de36
Reviewed-on: https://gerrit.libreoffice.org/35016
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/financial/fods/pduration.fods 
b/sc/qa/unit/data/functions/financial/fods/pduration.fods
new file mode 100644
index 000..2e8854f
--- /dev/null
+++ b/sc/qa/unit/data/functions/financial/fods/pduration.fods
@@ -0,0 +1,5702 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-03-09T18:30:05.068266319P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/a5a6694128728c48c1a8482450a21ad49025c40c
+ 
+  
+   0
+   0
+   92625
+   359233
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+  
+   3
+   19
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   75
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1191
+ 0
+ 75
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   -
+

[Libreoffice-commits] core.git: sc/qa

2017-03-09 Thread Zdeněk Crhonek 
 sc/qa/unit/data/functions/logical/fods/ifs.fods| 5811 +
 sc/qa/unit/data/functions/logical/fods/switch.fods | 5705 
 2 files changed, 11516 insertions(+)

New commits:
commit 1d8d2da126687c7419106933010c22ac56e73209
Author: Zdeněk Crhonek 
Date:   Thu Mar 9 19:05:13 2017 +0100

add IFS, SWITCh test  case

Change-Id: Ia6afcf81ea2c4e5e7f4f4ddacf9abbd2f75a77de
Reviewed-on: https://gerrit.libreoffice.org/35017
Tested-by: Jenkins 
Reviewed-by: Zdenek Crhonek 

diff --git a/sc/qa/unit/data/functions/logical/fods/ifs.fods 
b/sc/qa/unit/data/functions/logical/fods/ifs.fods
new file mode 100644
index 000..ef0ba77
--- /dev/null
+++ b/sc/qa/unit/data/functions/logical/fods/ifs.fods
@@ -0,0 +1,5811 @@
+
+
+http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+ 
2017-03-09T19:04:04.605319757P0D1LibreOfficeDev/5.4.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/a5a6694128728c48c1a8482450a21ad49025c40c
+ 
+  
+   0
+   0
+   76616
+   359233
+   
+
+ view1
+ 
+  
+   2
+   8
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   85
+   60
+   true
+   false
+  
+  
+   5
+   7
+   0
+   0
+   0
+   0
+   2
+   0
+   0
+   0
+   0
+   0
+   85
+   60
+   true
+   false
+  
+ 
+ Sheet2
+ 1191
+ 0
+ 85
+ 60
+ false
+ true
+ true
+ true
+ 12632256
+ true
+ true
+ true
+ true
+ true
+ false
+ false
+ 1270
+ 1270
+ 1
+ 1
+ true
+ false
+
+   
+  
+  
+   7
+   false
+   false
+   true
+   true
+   false
+   false
+   false
+   1270
+   1270
+   true
+   true
+   true
+   true
+   true
+   false
+   12632256
+   false
+   Lexmark-E352dn
+   
+
+ cs
+ CZ
+ 
+ 
+ 
+
+
+ de
+ DE
+ 
+ 
+ 
+
+
+ en
+ US
+ 
+ 
+ 
+
+
+ nl
+ NL
+ 
+ 
+ 
+
+   
+   true
+   true
+   3
+   1
+   true
+   1
+   true
+   sgH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMA0wAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhCkR1cGxleDpOb25lAElucHV0U2xvdDpUcmF5MQBQYWdlU2l6ZTpMZXR0ZXIAABIAQ09NUEFUX0RVUExFWF9NT0RFDwBEdXBsZXhNb2RlOjpPZmY=
+   false
+   0
+  
+ 
+ 
+  
+   http://openoffice.org/2004/office; 
xmlns:xlink="http://www.w3.org/1999/xlink;>
+
+   
+  
+ 
+ 
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   Kč
+  
+  
+   
+   -
+   
+
+   Kč
+   
+  
+  
+
+   
+
+  
+  
+
+   (
+   
+   )
+  
+  
+
+   -
+   
+
+  
+  
+   
+
+   
+   
+   
+  
+  
+

[Libreoffice-bugs] [Bug 100462] Locale en-GB-oxendict (previously en-GB-oed) is missing or broken -> corresponding spell-checker does not work.

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=100462

mrwli...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from mrwli...@gmail.com ---
@Xisco Fauli

I am not the reporter, but I see no change in behaviour with the latest LO
version 5.3.0.3. So this bug still exists. And I confirm it. 

I suspect that what may be required is an en-gb-oed locale definition, or some
such, to support the use of the dictionary. I don't think one has ever been
included in either OO or LO. This bug applies to earlier LO releases -
certainly back to 4.4.

I think that the reason that the entry "English, OED spelling (UK)" appears in
the LibreOffice language options is due to the introduction of support for
"language variants" at some time in the past. But it would seem that this is
not sufficient to make the dictionary operable.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: forms/source

2017-03-09 Thread Lionel Elie Mamane 
 forms/source/component/ListBox.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4f4b06ce320305413bcac123a27b6f3f14655cdf
Author: Lionel Elie Mamane 
Date:   Thu Mar 9 19:44:38 2017 +0100

tdf#106462 old value and new value were swapped

in

commit 66ccfcd2908445b8194c364c89778056374b02af
Author: Jochen Nitschke 
Date:   Fri Oct 21 09:36:10 2016 +0200

remove use of tryPropertyValue Any specialisation

Change-Id: I3180cf5b9e63a3da9257b03ba02967a2d5402ec3
Reviewed-by: Stephan Bergmann 

Change-Id: I90dd3f6dba799eec9210dbb7560be105cb50e6d1
Reviewed-on: https://gerrit.libreoffice.org/35023
Reviewed-by: Lionel Elie Mamane 
Tested-by: Lionel Elie Mamane 

diff --git a/forms/source/component/ListBox.cxx 
b/forms/source/component/ListBox.cxx
index 2e1d52c..a57322e 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -425,8 +425,8 @@ namespace frm
 Any _rCurrentValue = getCurrentSingleValue();
 if (_rCurrentValue != _rValue)
 {
-_rOldValue = _rValue;
-_rConvertedValue = _rCurrentValue;
+_rOldValue = _rCurrentValue;
+_rConvertedValue = _rValue;
 bModified = true;
 }
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

2017-03-09 Thread Tor Lillqvist 
 configure.ac |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 8458530312344198d7c63817831efa9223a09660
Author: Tor Lillqvist 
Date:   Thu Mar 9 20:44:23 2017 +0200

One AC_MSG_RESULT per AC_MSG_CHECKING please

Change-Id: Iffbfc75772219cc27b28013c35c20e98cd3cacc7

diff --git a/configure.ac b/configure.ac
index c970c39..fb4441c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5446,21 +5446,18 @@ if test "$build_os" = "cygwin"; then
 AL_PATH=`win_short_path_for_make "$AL_PATH"`
 
 dnl Check mscoree.lib / .NET Framework dir
-AC_MSG_CHECKING(.NET Framework find_dotnetsdk)
+AC_MSG_CHECKING(.NET Framework)
 find_dotnetsdk
 if test -f "$frametest/lib/mscoree.lib"; then
 DOTNET_FRAMEWORK_HOME="$frametest"
 else
-AC_MSG_CHECKING(.NET Framework find_winsdk)
 find_winsdk
 if test -f "$winsdktest/lib/mscoree.lib" -o -f 
"$winsdktest/lib/$winsdklibsubdir/um/$WINDOWS_SDK_ARCH/mscoree.lib"; then
 DOTNET_FRAMEWORK_HOME="$winsdktest"
 else
-AC_MSG_CHECKING(.NET Framework find_dotnetsdk46)
 find_dotnetsdk46
 PathFormat "$frametest"
 frametest="$formatted_path"
-AC_MSG_CHECKING(found: $frametest/um/$WINDOWS_SDK_ARCH/mscoree.lib)
 if test -f "$frametest/Lib/um/$WINDOWS_SDK_ARCH/mscoree.lib"; then
  DOTNET_FRAMEWORK_HOME="$frametest"
 fi
@@ -5470,7 +5467,7 @@ if test "$build_os" = "cygwin"; then
 if test ! -f "$DOTNET_FRAMEWORK_HOME/lib/mscoree.lib" -a ! -f 
"$DOTNET_FRAMEWORK_HOME/lib/$winsdklibsubdir/um/$WINDOWS_SDK_ARCH/mscoree.lib" 
-a ! -f "$DOTNET_FRAMEWORK_HOME/Lib/um/$WINDOWS_SDK_ARCH/mscoree.lib"; then
 AC_MSG_ERROR([mscoree.lib not found])
 fi
-AC_MSG_RESULT(found)
+AC_MSG_RESULT([found: $DOTNET_FRAMEWORK_HOME])
 
 PathFormat "$MIDL_PATH"
 MIDL_PATH="$formatted_path"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106282] Crash in: windows.storage.dll

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106282

--- Comment #7 from Buovjaga  ---
(In reply to Michael Meeks from comment #5)
> Can you reproduce this in some other application like notepad ?

Tried with Notepad - Open dialog. No crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106462] Assigning ListBox "SelectedValue" property is a no-op

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106462

Lionel Elie Mamane  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 CC||j.nitschke+td...@ok.de,
   ||pa...@gestman.lu,
   ||sberg...@redhat.com
   Assignee|libreoffice-b...@lists.free |lio...@mamane.lu
   |desktop.org |
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106462] New: Assigning ListBox "SelectedValue" property is a no-op

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106462

Bug ID: 106462
   Summary: Assigning ListBox "SelectedValue" property is a no-op
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lio...@mamane.lu

Description:
Programatically set a ListBox's "SelectedValue" property. It is not changed.

That's because in OListBoxModel::convertFastPropertyValue, case 
PROPERTY_ID_SELECT_VALUE, _rCurrentValue and _rValue are used where the other
should be used.

Patch pending

Steps to Reproduce:
.

Actual Results:  
.

Expected Results:
.


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - configure.ac solenv/gbuild

2017-03-09 Thread Jan-Marek Glogowski 
 configure.ac   |   32 ++---
 solenv/gbuild/platform/filter-showIncludes.awk |1 
 2 files changed, 19 insertions(+), 14 deletions(-)

New commits:
commit 86bb733f6a9af9af253afe896e315b463e592dc7
Author: Jan-Marek Glogowski 
Date:   Wed Mar 8 12:00:03 2017 +0100

Fix build with latest Cygwin updates

Stop bash complaining about \0 bytes in input
(cherry picked from commit 8800292351dcf1f538c47ac6acf834ac2633ce6b)

Strip newlines from UCRT detecion using tr
(cherry picked from commit 37baabe6436037de604bfbc2702bfb0bc156c41b)

Remove stray CR from input
(cherry picked from commit 9166569da389de44075b3d03413b353046a4)

Just get rid of CR when parsing .bat output
(cherry picked from commit 019ea173701eae4b8c5ffd45bb0063fc0a688ce0)

Change-Id: Ieef2f8eb98181f5a4ea6a5527bc36de9b88716b5
Reviewed-on: https://gerrit.libreoffice.org/35010
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/configure.ac b/configure.ac
index 1eff083..5eb20d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3147,28 +3147,32 @@ dnl 
===
 dnl Windows specific tests and stuff
 dnl ===
 
-# Get a value from the 32-bit side of the Registry
-reg_get_value_32()
+reg_get_value()
 {
 # Return value: $regvalue
 unset regvalue
-_regvalue=`cat "/proc/registry32/$1" 2> /dev/null`
 
-if test $? -eq 0; then
-regvalue=$_regvalue
+local _regentry="/proc/registry${1}/${2}"
+if test -f "$_regentry"; then
+# Stop bash complaining about \0 bytes in input, as it can't handle 
them.
+# Registry keys read via /proc/registry* are always \0 terminated!
+local _regvalue=$(tr -d '\0' < "$_regentry")
+if test $? -eq 0; then
+regvalue=$_regvalue
+fi
 fi
 }
 
+# Get a value from the 32-bit side of the Registry
+reg_get_value_32()
+{
+reg_get_value "32" "$1"
+}
+
 # Get a value from the 64-bit side of the Registry
 reg_get_value_64()
 {
-# Return value: $regvalue
-unset regvalue
-_regvalue=`cat "/proc/registry64/$1" 2> /dev/null`
-
-if test $? -eq 0; then
-regvalue=$_regvalue
-fi
+reg_get_value "64" "$1"
 }
 
 if test "$_os" = "WINNT"; then
@@ -3300,7 +3304,7 @@ win_get_env_from_vsvars32bat()
 echo -e "@echo %$1%\r\n" >> $WRAPPERBATCHFILEPATH
 echo -e "@endlocal\r\n" >> $WRAPPERBATCHFILEPATH
 chmod +x $WRAPPERBATCHFILEPATH
-_win_get_env_from_vsvars32bat="`$WRAPPERBATCHFILEPATH | $SED -e s/^M^J//`"
+_win_get_env_from_vsvars32bat=$($WRAPPERBATCHFILEPATH | tr -d "\r")
 rm -f $WRAPPERBATCHFILEPATH
 echo $_win_get_env_from_vsvars32bat
 }
@@ -6792,7 +6796,7 @@ if test "$ENABLE_JAVA" != ""; then
 
 if test -z "$with_jdk_home"; then
 for ver in 1.8 1.7 1.6; do
-reg_get_value_$bitness 
"HKEY_LOCAL_MACHINE/SOFTWARE/JavaSoft/Java Development Kit/$ver/JavaHome"
+reg_get_value "$bitness" 
"HKEY_LOCAL_MACHINE/SOFTWARE/JavaSoft/Java Development Kit/$ver/JavaHome"
 if test -n "$regvalue"; then
 _jdk_home=$regvalue
 break
diff --git a/solenv/gbuild/platform/filter-showIncludes.awk 
b/solenv/gbuild/platform/filter-showIncludes.awk
index 21a4585..6ec13e2 100755
--- a/solenv/gbuild/platform/filter-showIncludes.awk
+++ b/solenv/gbuild/platform/filter-showIncludes.awk
@@ -40,6 +40,7 @@ BEGIN {
 }
 
 {
+sub(/\r$/, "")
 sub(/^ */, "")
 if (index($0, showincludes_prefix) == 1) {
 $0 = substr($0, length(showincludes_prefix) + 1)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: uitest/writer_tests

2017-03-09 Thread Xisco Fauli 
 uitest/writer_tests/backgrounds.py |  147 +
 1 file changed, 147 insertions(+)

New commits:
commit 3a639085a43b886828c49a86cf761bc92f26e6e1
Author: Xisco Fauli 
Date:   Thu Mar 9 16:34:48 2017 +0100

uitest: test backgrounds in writer

Change-Id: If3bf2848bb9437c7cb7ffec37c315888fef47c88
Reviewed-on: https://gerrit.libreoffice.org/35008
Tested-by: Jenkins 
Reviewed-by: Xisco Faulí 

diff --git a/uitest/writer_tests/backgrounds.py 
b/uitest/writer_tests/backgrounds.py
new file mode 100644
index 000..da49a75
--- /dev/null
+++ b/uitest/writer_tests/backgrounds.py
@@ -0,0 +1,147 @@
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+from uitest.uihelper.common import select_pos
+from com.sun.star.uno import RuntimeException
+from com.sun.star.awt.GradientStyle import LINEAR
+from com.sun.star.drawing.HatchStyle import SINGLE
+from com.sun.star.drawing.BitmapMode import REPEAT
+from com.sun.star.drawing.RectanglePoint import MIDDLE_MIDDLE
+
+class WriterBackgrounds(UITestCase):
+
+def checkDefaultBackground(self, btn):
+document = self.ui_test.get_component()
+if btn == 'btnnone':
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.BackColor, -1)
+elif btn == 'btncolor':
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.BackColor, 7512015)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillColor, 7512015)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillColor, 7512015)
+elif btn == 'btngradient':
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillGradient.Style, 
LINEAR)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.StartColor, 9101876)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillGradient.Angle, 
300)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.Border, 0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.XOffset, 0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.YOffset, 0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.StartIntensity, 100)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillGradient.EndIntensity, 100)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillGradientName, 
'Tango Green')
+elif btn == 'btnhatch':
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillHatch.Style, 
SINGLE )
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillHatch.Color, 0)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillHatch.Distance, 
102)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillHatch.Angle, 0)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillHatchName, 
'Black 0 Degrees')
+elif btn == 'btnbitmap':
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapMode, 
REPEAT)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillBitmapPositionOffsetX, 0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillBitmapPositionOffsetY, 0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillBitmapRectanglePoint, 
MIDDLE_MIDDLE)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapStretch, 
False)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapTile, 
True)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapOffsetX, 
0)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapOffsetY, 
0)
+self.assertEqual(
+
document.StyleFamilies.PageStyles.Standard.FillBitmapLogicalSize, True)
+self.assertEqual(
+document.StyleFamilies.PageStyles.Standard.FillBitmapSizeX, 0)
+self.assertEqual(
+

[Libreoffice-bugs] [Bug 106461] New: UI: Text fields in Form Properties dialog cover other widget

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106461

Bug ID: 106461
   Summary: UI: Text fields in Form Properties dialog cover other
widget
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hiunnhue...@ymail.com

Created attachment 131777
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131777=edit
screenshot_form_properties_dialog

In the dialog windows of Form Properties/Form Controls, items are too close to
each other, and the text fields cover other widget. 

Please see attachment.

Tested on ...

* Version: 5.3.0.3
Build ID: 1:5.3.0~rc3-0ubuntu1~xenial1.1
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2;
Locale: zh-TW (zh_TW.UTF-8); Calc: group

* Version: 5.4.0.0.alpha0+
Build ID: a5a6694128728c48c1a8482450a21ad49025c40c
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-03-07_02:52:26
Locale: zh-TW (zh_TW.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: extensions/Library_so_activex_x64.mk

2017-03-09 Thread Michael Stahl 
 extensions/Library_so_activex_x64.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 15d46079a5b6429dba0d501e7db218188294587a
Author: Michael Stahl 
Date:   Thu Mar 9 18:42:09 2017 +0100

oops, forgot to commit that

Change-Id: I7b0a08ca47996f80112f68daef3e2ba5e3be221b

diff --git a/extensions/Library_so_activex_x64.mk 
b/extensions/Library_so_activex_x64.mk
index e1c4b9a..64f6440 100644
--- a/extensions/Library_so_activex_x64.mk
+++ b/extensions/Library_so_activex_x64.mk
@@ -52,7 +52,7 @@ $(eval $(call 
gb_Library_use_system_win32_libs,so_activex_x64,\
 $(eval $(call gb_Library_add_libs,so_activex_x64,\
$(if $(filter 140,$(VCVER)),\
$(ATL_LIB)/amd64/atls.lib, \
-   $(subst /x86,/x64,$(ATL_LIB)/amd64/atls.lib)) \
+   $(subst /x86,/x64,$(ATL_LIB)/atls.lib)) \
 ))
 
 # vim:set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: extensions/Library_so_activex_x64.mk

2017-03-09 Thread Michael Stahl 
 extensions/Library_so_activex_x64.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 869a249cebaf58d13812194297561fc361dd3a36
Author: Michael Stahl 
Date:   Thu Mar 9 18:40:40 2017 +0100

extensions: fix MSVC 2017 build of Library_so_activex_x64

Change-Id: Ia98c2ba085d6b7705b53dafd5368d69f0e0727c5

diff --git a/extensions/Library_so_activex_x64.mk 
b/extensions/Library_so_activex_x64.mk
index d330ca8..e1c4b9a 100644
--- a/extensions/Library_so_activex_x64.mk
+++ b/extensions/Library_so_activex_x64.mk
@@ -50,7 +50,9 @@ $(eval $(call 
gb_Library_use_system_win32_libs,so_activex_x64,\
 ))
 
 $(eval $(call gb_Library_add_libs,so_activex_x64,\
-   $(ATL_LIB)/amd64/atls.lib \
+   $(if $(filter 140,$(VCVER)),\
+   $(ATL_LIB)/amd64/atls.lib, \
+   $(subst /x86,/x64,$(ATL_LIB)/amd64/atls.lib)) \
 ))
 
 # vim:set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101189] Libreoffice Scrolling very slow for even moderately sized documents

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101189

--- Comment #10 from Buovjaga  ---
(In reply to matthieupepin from comment #9)
> - This issue does not happen with the mouse wheel, only with the touchpad of
> my Dell XPS 13

Other touchpad scroll issues:
https://bugs.documentfoundation.org/buglist.cgi?list_id=682144_format=advanced=---_desc=touchpad%20scroll_desc_type=allwordssubstr

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svtools svtools/source

2017-03-09 Thread Stephan Bergmann 
 include/svtools/brwbox.hxx|2 
 svtools/source/brwbox/brwbox1.cxx |  138 ++
 svtools/source/brwbox/brwbox2.cxx |  108 ++---
 svtools/source/brwbox/datwin.cxx  |   16 ++--
 4 files changed, 131 insertions(+), 133 deletions(-)

New commits:
commit 5b25275002e12d2c9794ca0dd014e5d25efe486e
Author: Stephan Bergmann 
Date:   Thu Mar 9 18:26:40 2017 +0100

No need for extra heap allocation

Change-Id: I0844a0a8a3476cdb007ab1d587b15ce26c68783e

diff --git a/include/svtools/brwbox.hxx b/include/svtools/brwbox.hxx
index 4e9f2df..fd6b18b 100644
--- a/include/svtools/brwbox.hxx
+++ b/include/svtools/brwbox.hxx
@@ -240,7 +240,7 @@ private:
 TriStatebHideCursor;// hide cursor (frame)
 Range   aSelRange;  // for selection expansion
 
-BrowserColumns* pCols;  // array of column-descriptions
+BrowserColumns pCols;   // array of column-descriptions
 union
 {
 MultiSelection* pSel;   // selected rows for multi-selection
diff --git a/svtools/source/brwbox/brwbox1.cxx 
b/svtools/source/brwbox/brwbox1.cxx
index c4a0ab9..35ff282 100644
--- a/svtools/source/brwbox/brwbox1.cxx
+++ b/svtools/source/brwbox/brwbox1.cxx
@@ -63,7 +63,6 @@ void BrowseBox::ConstructImpl( BrowserMode nMode )
 pColSel = nullptr;
 pVScroll = nullptr;
 pDataWin = VclPtr::Create( this ).get();
-pCols = new BrowserColumns;
 m_pImpl.reset( new ::svt::BrowseBoxImpl() );
 
 aGridLineColor = Color( COL_LIGHTGRAY );
@@ -140,10 +139,9 @@ void BrowseBox::dispose()
 aHScroll.disposeAndClear();
 
 // free columns-space
-for (BrowserColumn* pCol : *pCols)
+for (BrowserColumn* pCol : pCols)
 delete pCol;
-pCols->clear();
-delete pCols;
+pCols.clear();
 delete pColSel;
 if ( bMultiSelection )
 delete uRow.pSel;
@@ -220,17 +218,17 @@ void BrowseBox::InsertHandleColumn( sal_uLong nWidth )
 {
 
 #if OSL_DEBUG_LEVEL > 0
-OSL_ENSURE( ColCount() == 0 || (*pCols)[0]->GetId() != HandleColumnId , 
"BrowseBox::InsertHandleColumn: there is already a handle column" );
+OSL_ENSURE( ColCount() == 0 || pCols[0]->GetId() != HandleColumnId , 
"BrowseBox::InsertHandleColumn: there is already a handle column" );
 {
-BrowserColumns::iterator iCol = pCols->begin();
-const BrowserColumns::iterator colsEnd = pCols->end();
+BrowserColumns::iterator iCol = pCols.begin();
+const BrowserColumns::iterator colsEnd = pCols.end();
 if ( iCol != colsEnd )
 for (++iCol; iCol != colsEnd; ++iCol)
 OSL_ENSURE( (*iCol)->GetId() != HandleColumnId, 
"BrowseBox::InsertHandleColumn: there is a non-Handle column with handle ID" );
 }
 #endif
 
-pCols->insert( pCols->begin(), new BrowserColumn( 0, OUString(), nWidth, 
GetZoom() ) );
+pCols.insert( pCols.begin(), new BrowserColumn( 0, OUString(), nWidth, 
GetZoom() ) );
 FreezeColumn( 0 );
 
 // adjust headerbar
@@ -255,21 +253,21 @@ void BrowseBox::InsertDataColumn( sal_uInt16 nItemId, 
const OUString& rText,
 
 #if OSL_DEBUG_LEVEL > 0
 {
-const BrowserColumns::iterator colsEnd = pCols->end();
-for (BrowserColumns::iterator iCol = pCols->begin(); iCol != colsEnd; 
++iCol)
+const BrowserColumns::iterator colsEnd = pCols.end();
+for (BrowserColumns::iterator iCol = pCols.begin(); iCol != colsEnd; 
++iCol)
 OSL_ENSURE( (*iCol)->GetId() != nItemId, 
"BrowseBox::InsertDataColumn: duplicate column Id" );
 }
 #endif
 
-if ( nPos < pCols->size() )
+if ( nPos < pCols.size() )
 {
-BrowserColumns::iterator it = pCols->begin();
+BrowserColumns::iterator it = pCols.begin();
 ::std::advance( it, nPos );
-pCols->insert( it, new BrowserColumn( nItemId, rText, nWidth, 
GetZoom() ) );
+pCols.insert( it, new BrowserColumn( nItemId, rText, nWidth, GetZoom() 
) );
 }
 else
 {
-pCols->push_back( new BrowserColumn( nItemId, rText, nWidth, GetZoom() 
) );
+pCols.push_back( new BrowserColumn( nItemId, rText, nWidth, GetZoom() 
) );
 }
 if ( nCurColId == 0 )
 nCurColId = nItemId;
@@ -295,7 +293,7 @@ sal_uInt16 BrowseBox::ToggleSelectedColumn()
 ToggleSelection();
 long nSelected = pColSel->FirstSelected();
 if (nSelected != static_cast(SFX_ENDOFSELECTION))
-nSelectedColId = (*pCols)[nSelected]->GetId();
+nSelectedColId = pCols[nSelected]->GetId();
 pColSel->SelectAll(false);
 }
 return nSelectedColId;
@@ -316,30 +314,30 @@ void BrowseBox::FreezeColumn( sal_uInt16 nItemId )
 {
 // get the position in the current array
 size_t nItemPos = GetColumnPos( nItemId );
-if ( nItemPos >= pCols->size() )
+if ( nItemPos >= pCols.size() )
 // not available!
 return;
 
 // doesn't the state change?
-if (

[Libreoffice-bugs] [Bug 103455] Draw: Edit with external tool only reload first image

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=103455

--- Comment #3 from John Maier  ---
I have experienced the same issue in Draw:
Version: 5.3.0.3 (x64)
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1

My Environment is:
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine:
new; 
Locale: en-US (en_US); Calc: group

The default editor for bmp is mspaint.

If just close the file, not the entire Draw Program. I can reopen the file and
then 'Edit with external tool' will work again, but only for one image.

-

As a double blind test, I tried the same file under LibreOffice Draw on Linux,
and discovered the same issue with being unable to edit a subsequent image.
Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/gbuild

2017-03-09 Thread Michael Stahl 
 solenv/gbuild/platform/com_MSC_class.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 51a6fa350566350c84ceadb5df65a9b047ca77e8
Author: Michael Stahl 
Date:   Thu Mar 9 17:54:39 2017 +0100

gbuild: fix LIBPATH for LIBRARY_X64 with MSVC 2017

Change-Id: I88601e8ad3d21554d6b8166bd7689e0a3b8b3a9f

diff --git a/solenv/gbuild/platform/com_MSC_class.mk 
b/solenv/gbuild/platform/com_MSC_class.mk
index 1aef938..23bb57e 100644
--- a/solenv/gbuild/platform/com_MSC_class.mk
+++ b/solenv/gbuild/platform/com_MSC_class.mk
@@ -175,7 +175,7 @@ $(call gb_Helper_abbreviate_dirs,\
$(if $(filter YES,$(LIBRARY_X64)),,$(if $(filter 
YES,$(TARGETGUI)), -SUBSYSTEM:WINDOWS$(MSC_SUBSYSTEM_VERSION), 
-SUBSYSTEM:CONSOLE$(MSC_SUBSYSTEM_VERSION))) \
$(if $(filter YES,$(LIBRARY_X64)), -MACHINE:X64) \
$(if $(filter YES,$(LIBRARY_X64)), \
-   -LIBPATH:$(COMPATH)/lib/amd64 \
+   -LIBPATH:$(COMPATH)/lib/$(if $(filter 
140,$(VCVER)),amd64,x64) \
-LIBPATH:$(WINDOWS_SDK_HOME)/lib/x64 \
$(if $(filter 80 81 
10,$(WINDOWS_SDK_VERSION)),-LIBPATH:$(WINDOWS_SDK_HOME)/lib/$(WINDOWS_SDK_LIB_SUBDIR)/um/x64)
 \
$(if $(filter-out 
120,$(VCVER)),-LIBPATH:$(UCRTSDKDIR)lib/$(UCRTVERSION)/ucrt/x64)) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Removing support of the Express Edition of Visual Studio 2015 in master?

2017-03-09 Thread Tor Lillqvist 
Visual Studio 2015 has two variants that are no-cost: The Community Edition
and the Express Edition. The Community Edition is much preferable. Visual
Studio 2017 no longer has an Express Edition.

Is anybody using the Express Edition of VS2015 to build LibreOffice (master
branch)? If you do, any good reason you don't use the Community Edition
instead?

Removing support for the Express Edition would simplify our configure.ac a
bit. Not hugely, but any simplification is always good.

Change in gerrit: https://gerrit.libreoffice.org/#/c/35009/

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 106459] incorrect results in dragged sum formula spanning multiple sheets ( 3d reference)

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106459

--- Comment #5 from Stefan Walsen  ---
In my installation,
"OpenCL" was disabled, and apparently I cannot enable it.
(I assume this is because I'd need to install additional libraries for this to
work?) 

Disabling "Software Interpreter" and restarting LibreOffice does fix the
problem for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: configure.ac

2017-03-09 Thread Jan-Marek Glogowski 
 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 019ea173701eae4b8c5ffd45bb0063fc0a688ce0
Author: Jan-Marek Glogowski 
Date:   Thu Mar 9 17:11:28 2017 +0100

Just get rid of CR when parsing .bat output

Converts Windows to Unix newlines, so bash will handle the
result correctly.

Since $(..) or `..` will already remove trailing newlines,
this reverts the unneeded changes of commit
37baabe6436037de604bfbc2702bfb0bc156c41b

Change-Id: I0071237f0600c2d71da066eb2e2b541e338e7016

diff --git a/configure.ac b/configure.ac
index dc837c5..c970c39 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3313,9 +3313,9 @@ win_get_env_from_vsvars32bat()
 echo -e "@echo %$1%\r\n" >> $WRAPPERBATCHFILEPATH
 echo -e "@endlocal\r\n" >> $WRAPPERBATCHFILEPATH
 chmod +x $WRAPPERBATCHFILEPATH
-_win_get_env_from_vsvars32bat=$($WRAPPERBATCHFILEPATH | tr -d "\n\r\0")
+_win_get_env_from_vsvars32bat=$($WRAPPERBATCHFILEPATH | tr -d "\r")
 rm -f $WRAPPERBATCHFILEPATH
-echo -n $_win_get_env_from_vsvars32bat
+echo $_win_get_env_from_vsvars32bat
 }
 
 find_ucrt()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 106459] incorrect results in dragged sum formula spanning multiple sheets ( 3d reference)

2017-03-09 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106459

Eike Rathke  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #4 from Eike Rathke  ---
Maybe due to OpenCL or Software Interpreter that don't handle 3D ranges and get
triggered with rows>100. Could you try to disable OpenCL and/or Software
Interpreter under Tools-Options-LibreOffice-OpenCL?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/pivotcharts' - 2 commits - chart2/source

2017-03-09 Thread Tomaž Vajngerl 
 chart2/source/view/main/ChartView.cxx |6 +++---
 chart2/source/view/main/VLegend.cxx   |9 +
 2 files changed, 8 insertions(+), 7 deletions(-)

New commits:
commit 097a3ecf20d2e00101619b6bbd61acce09de0864
Author: Tomaž Vajngerl 
Date:   Thu Mar 9 17:22:55 2017 +0100

chart: change field button CID so it is easier to parse

Change-Id: If75e6a247ff619e850e6f07f308d3863754db5d4

diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 54b1297..9d1fe9c 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -2514,7 +2514,7 @@ void lcl_createButtons(const uno::Reference< 
drawing::XShapes>& xPageShapes,
 pButton->init(xPageShapes, xShapeFactory);
 awt::Point aNewPosition = awt::Point(rRemainingSpace.X + x + 100, 
rRemainingSpace.Y + 100);
 pButton->setLabel(rPageField);
-pButton->setCID("PageFieldButton." + OUString::number(nCIDIndex));
+pButton->setCID("FieldButton.Page." + OUString::number(nCIDIndex));
 pButton->createShapes(aNewPosition, aSize, xModelPage);
 x += aSize.Width + 100;
 nCIDIndex += 1;
@@ -2533,7 +2533,7 @@ void lcl_createButtons(const uno::Reference< 
drawing::XShapes>& xPageShapes,
 pButton->init(xPageShapes, xShapeFactory);
 awt::Point aNewPosition = awt::Point(rRemainingSpace.X + x + 100, 
rRemainingSpace.Y + 100);
 pButton->setLabel(rDataField);
-pButton->setCID("DataFieldButton." + OUString::number(nCIDIndex));
+pButton->setCID("FieldButton.Data." + OUString::number(nCIDIndex));
 pButton->createShapes(aNewPosition, aSize, xModelPage);
 x += aSize.Width + 100;
 nCIDIndex += 1;
@@ -2553,7 +2553,7 @@ void lcl_createButtons(const uno::Reference< 
drawing::XShapes>& xPageShapes,
 awt::Point aNewPosition = awt::Point(rRemainingSpace.X + x + 100,
  rRemainingSpace.Y + 
rRemainingSpace.Height - aSize.Height - 100);
 pButton->setLabel(rRowField);
-pButton->setCID("ColumnFieldButton." + 
OUString::number(nCIDIndex));
+pButton->setCID("FieldButton.Column." + 
OUString::number(nCIDIndex));
 pButton->createShapes(aNewPosition, aSize, xModelPage);
 x += aSize.Width + 100;
 nCIDIndex += 1;
diff --git a/chart2/source/view/main/VLegend.cxx 
b/chart2/source/view/main/VLegend.cxx
index eda2fd4..3688411 100644
--- a/chart2/source/view/main/VLegend.cxx
+++ b/chart2/source/view/main/VLegend.cxx
@@ -788,7 +788,7 @@ std::vector lcl_createButtons(
 pButton->init(xLegendContainer, xShapeFactory);
 awt::Point aNewPosition = awt::Point(100, y);
 pButton->setLabel(sColumnField);
-pButton->setCID("RowFieldButton." + OUString::number(nCIDIndex));
+pButton->setCID("FieldButton.Row." + OUString::number(nCIDIndex));
 pButton->createShapes(aNewPosition, aSize, xModelPage);
 nCIDIndex += 1;
 y += aSize.Height + 100;;
commit 1dd706e7644c8055b272d4f863a79fd264ab1e88
Author: Tomaž Vajngerl 
Date:   Thu Mar 9 17:19:29 2017 +0100

charts: fix drawing multiple buttons in legend

Change-Id: I101d6ee6e06e78ba5e0748a796b6640c47fa67cf

diff --git a/chart2/source/view/main/VLegend.cxx 
b/chart2/source/view/main/VLegend.cxx
index b79c95a..eda2fd4 100644
--- a/chart2/source/view/main/VLegend.cxx
+++ b/chart2/source/view/main/VLegend.cxx
@@ -780,19 +780,20 @@ std::vector lcl_createButtons(
 
 int nCIDIndex = 0;
 awt::Size aSize(2000, 700);
-
+int y = 100;
 for (OUString const & sColumnField : aColumnFields)
 {
 std::shared_ptr pButton(new VButton);
 aButtons.push_back(pButton);
 pButton->init(xLegendContainer, xShapeFactory);
-awt::Point aNewPosition = awt::Point(100, 100);
+awt::Point aNewPosition = awt::Point(100, y);
 pButton->setLabel(sColumnField);
 pButton->setCID("RowFieldButton." + OUString::number(nCIDIndex));
 pButton->createShapes(aNewPosition, aSize, xModelPage);
 nCIDIndex += 1;
+y += aSize.Height + 100;;
 }
-nUsedHeight += aSize.Height + 100;
+nUsedHeight += y + 100;
 
 return aButtons;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/source

2017-03-09 Thread Caolán McNamara 
 include/vcl/bitmapaccess.hxx |   23 +--
 vcl/source/gdi/bmpacc.cxx|   39 +++
 2 files changed, 12 insertions(+), 50 deletions(-)

New commits:
commit 25a5458e751f34063686c4fecd7b8bfc8a78302d
Author: Caolán McNamara 
Date:   Thu Mar 9 14:18:35 2017 +

just calculate the scanline positions

rather than generating a big offset table to dramatically reduce the amount 
of
memory loading graphics takes

Change-Id: I8a4b1dc5cbcb686d6b8570f2eeef61ee0fe25515
Reviewed-on: https://gerrit.libreoffice.org/35005
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/vcl/bitmapaccess.hxx b/include/vcl/bitmapaccess.hxx
index 5bab9a3..50eb37c 100644
--- a/include/vcl/bitmapaccess.hxx
+++ b/include/vcl/bitmapaccess.hxx
@@ -115,7 +115,6 @@ protected:
 FncSetPixel mFncSetPixel;
 
 SAL_DLLPRIVATE void ImplInitScanBuffer( Bitmap& rBitmap );
-SAL_DLLPRIVATE void ImplClearScanBuffer();
 SAL_DLLPRIVATE bool ImplSetAccessPointers( ScanlineFormat nFormat );
 
 public:
@@ -303,13 +302,11 @@ inline const BitmapColor& 
BitmapInfoAccess::GetPaletteColor( sal_uInt16 nColor )
 return mpBuffer->maPalette[nColor];
 }
 
-
 inline const BitmapColor& BitmapInfoAccess::GetBestPaletteColor(const 
BitmapColor& rBitmapColor) const
 {
 return GetPaletteColor(GetBestPaletteIndex(rBitmapColor));
 }
 
-
 inline ColorMask& BitmapInfoAccess::GetColorMask() const
 {
 assert(mpBuffer && "Access is not valid!");
@@ -317,7 +314,6 @@ inline ColorMask& BitmapInfoAccess::GetColorMask() const
 return mpBuffer->maColorMask;
 }
 
-
 inline Scanline BitmapReadAccess::GetBuffer() const
 {
 assert(mpBuffer && "Access is not valid!");
@@ -325,32 +321,32 @@ inline Scanline BitmapReadAccess::GetBuffer() const
 return mpBuffer ? mpBuffer->mpBits : nullptr;
 }
 
-
 inline Scanline BitmapReadAccess::GetScanline(long nY) const
 {
-assert(mpBuffer && mpScanBuf && "Access is not valid!");
+assert(mpBuffer && "Access is not valid!");
 assert(nY < mpBuffer->mnHeight && "y-coordinate out of range!");
 
-return mpScanBuf[nY];
+if (mpBuffer->mnFormat & ScanlineFormat::TopDown)
+{
+return mpBuffer->mpBits + (nY * mpBuffer->mnScanlineSize);
+}
+return mpBuffer->mpBits + ((mpBuffer->mnHeight - 1 - nY) * 
mpBuffer->mnScanlineSize);
 }
 
-
 inline BitmapColor BitmapReadAccess::GetPixel(long nY, long nX) const
 {
-assert(mpBuffer && mpScanBuf && "Access is not valid!");
+assert(mpBuffer && "Access is not valid!");
 assert(nX < mpBuffer->mnWidth && "x-coordinate out of range!");
 assert(nY < mpBuffer->mnHeight && "y-coordinate out of range!");
 
-return mFncGetPixel(mpScanBuf[nY], nX, maColorMask );
+return mFncGetPixel(GetScanline(nY), nX, maColorMask );
 }
 
-
 inline sal_uInt8 BitmapReadAccess::GetPixelIndex(long nY, long nX) const
 {
 return GetPixel(nY, nX).GetBlueOrIndex();
 }
 
-
 inline BitmapColor BitmapReadAccess::GetPixelFromData(const sal_uInt8* pData, 
long nX) const
 {
 assert(pData && "Access is not valid!");
@@ -358,7 +354,6 @@ inline BitmapColor BitmapReadAccess::GetPixelFromData(const 
sal_uInt8* pData, lo
 return mFncGetPixel( pData, nX, maColorMask );
 }
 
-
 inline void BitmapReadAccess::SetPixelOnData(sal_uInt8* pData, long nX, const 
BitmapColor& rBitmapColor)
 {
 assert(pData && "Access is not valid!");
@@ -413,7 +408,7 @@ inline void BitmapWriteAccess::SetPixel(long nY, long nX, 
const BitmapColor& rBi
 assert(nX < mpBuffer->mnWidth && "x-coordinate out of range!");
 assert(nY < mpBuffer->mnHeight && "y-coordinate out of range!");
 
-mFncSetPixel(mpScanBuf[nY], nX, rBitmapColor, maColorMask);
+mFncSetPixel(GetScanline(nY), nX, rBitmapColor, maColorMask);
 }
 
 
diff --git a/vcl/source/gdi/bmpacc.cxx b/vcl/source/gdi/bmpacc.cxx
index 2e987fa..cddc121 100644
--- a/vcl/source/gdi/bmpacc.cxx
+++ b/vcl/source/gdi/bmpacc.cxx
@@ -102,7 +102,6 @@ sal_uInt16 BitmapInfoAccess::GetBestPaletteIndex( const 
BitmapColor& rBitmapColo
 
 BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap, BitmapAccessMode nMode ) :
 BitmapInfoAccess( rBitmap, nMode ),
-mpScanBuf   ( nullptr ),
 mFncGetPixel( nullptr ),
 mFncSetPixel( nullptr )
 {
@@ -111,7 +110,6 @@ BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap, 
BitmapAccessMode nMode ) :
 
 BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
 BitmapInfoAccess( rBitmap, BitmapAccessMode::Read ),
-mpScanBuf   ( nullptr ),
 mFncGetPixel( nullptr ),
 mFncSetPixel( nullptr )
 {
@@ -120,7 +118,6 @@ BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
 
 BitmapReadAccess::~BitmapReadAccess()
 {
-ImplClearScanBuffer();
 }
 
 void BitmapReadAccess::ImplInitScanBuffer( Bitmap& rBitmap )
@@ -134,45

[Libreoffice-commits] core.git: include/svl svl/source

2017-03-09 Thread Stephan Bergmann 
 include/svl/aeitem.hxx  |4 +++-
 svl/source/items/aeitem.cxx |5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 82e92bb15d26fff2d07736e2a6193cac1915b44d
Author: Stephan Bergmann 
Date:   Thu Mar 9 17:08:14 2017 +0100

Clean up uses of integer types

Change-Id: I1155dfe3e2bcfe2c15c101c7373fcc9e161aa366

diff --git a/include/svl/aeitem.hxx b/include/svl/aeitem.hxx
index d203e23..c004e48 100644
--- a/include/svl/aeitem.hxx
+++ b/include/svl/aeitem.hxx
@@ -22,6 +22,8 @@
 #include 
 #include 
 #include 
+
+#include 
 #include 
 
 class SfxAllEnumValueArr;
@@ -44,7 +46,7 @@ class SVL_DLLPUBLIC SfxAllEnumItem: public SfxAllEnumItem_Base
 std::vector* pDisabledValues;
 
 sal_uInt16  GetPosByValue( sal_uInt16 nValue ) const;
-sal_uInt16  GetPosByValue_( sal_uInt16 nValue ) const;
+std::size_t GetPosByValue_( sal_uInt16 nValue ) const;
 
 public:
 static SfxPoolItem* CreateDefault();
diff --git a/svl/source/items/aeitem.cxx b/svl/source/items/aeitem.cxx
index b10b36d..fdbca83 100644
--- a/svl/source/items/aeitem.cxx
+++ b/svl/source/items/aeitem.cxx
@@ -20,6 +20,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 SfxPoolItem* SfxAllEnumItem::CreateDefault() { return new SfxAllEnumItem; }
@@ -117,13 +118,13 @@ SfxPoolItem* SfxAllEnumItem::Create( SvStream & rStream, 
sal_uInt16 ) const
  * In contrast to @see GetPosByValue(sal_uInt16) const
  * this internal method returns the position the value would be for 
non-present values.
  */
-sal_uInt16 SfxAllEnumItem::GetPosByValue_( sal_uInt16 nVal ) const
+std::size_t SfxAllEnumItem::GetPosByValue_( sal_uInt16 nVal ) const
 {
 if ( !pValues )
 return 0;
 
 //FIXME: Optimisation: use binary search or SortArray
-sal_uInt16 nPos;
+std::size_t nPos;
 for ( nPos = 0; nPos < pValues->size(); ++nPos )
 if ( (*pValues)[nPos].nValue >= nVal )
 return nPos;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sal/textenc

2017-03-09 Thread Caolán McNamara 
 sal/textenc/tcvtkr6.tab |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 87c783c4a463969984e660f0b5bc57f4910f7856
Author: Caolán McNamara 
Date:   Thu Mar 9 09:40:58 2017 +

ofz#770 JOHAB_73 table starts at 0xA not 0x2

the start value is out by one row

Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3
Reviewed-on: https://gerrit.libreoffice.org/34993
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sal/textenc/tcvtkr6.tab b/sal/textenc/tcvtkr6.tab
index 384c120..de68d62 100644
--- a/sal/textenc/tcvtkr6.tab
+++ b/sal/textenc/tcvtkr6.tab
@@ -1039,7 +1039,7 @@ static ImplUniToDBCSHighTab const aJOHABDBCSHighTab[256] =
 { 0x01, 0xFD, aImplUniToDBCSTab_JOHAB_70 }, /* 0x70 */
 { 0x04, 0xFF, aImplUniToDBCSTab_JOHAB_71 }, /* 0x71 */
 { 0x00, 0xFD, aImplUniToDBCSTab_JOHAB_72 }, /* 0x72 */
-{ 0x02, 0xFE, aImplUniToDBCSTab_JOHAB_73 }, /* 0x73 */
+{ 0x0A, 0xFE, aImplUniToDBCSTab_JOHAB_73 }, /* 0x73 */
 { 0x01, 0xF7, aImplUniToDBCSTab_JOHAB_74 }, /* 0x74 */
 { 0x01, 0xFC, aImplUniToDBCSTab_JOHAB_75 }, /* 0x75 */
 { 0x00, 0xFE, aImplUniToDBCSTab_JOHAB_76 }, /* 0x76 */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2017-03-09 Thread Caolán McNamara 
 vcl/source/gdi/svmconverter.cxx |   65 
 1 file changed, 40 insertions(+), 25 deletions(-)

New commits:
commit ff8f6629287d0d1bdbcf4f8ed16cb8d077d08c7a
Author: Caolán McNamara 
Date:   Thu Jan 19 16:56:34 2017 +

Resolves: ofz#424 guard against broken dxary length

Change-Id: Ia2569e963edd75cd6c27399d33e73bafe8b3f073
Reviewed-on: https://gerrit.libreoffice.org/33319
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/gdi/svmconverter.cxx b/vcl/source/gdi/svmconverter.cxx
index c1161a4..efcc250 100644
--- a/vcl/source/gdi/svmconverter.cxx
+++ b/vcl/source/gdi/svmconverter.cxx
@@ -939,6 +939,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 OUString aStr(OStringToOUString(aByteStr, eActualCharSet));
 
 std::unique_ptr pDXAry;
+sal_Int32 nDXAryLen = 0;
 if (nAryLen > 0)
 {
 const size_t nMinRecordSize = sizeof(sal_Int32);
@@ -952,36 +953,50 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 
 sal_Int32 nStrLen( aStr.getLength() );
 
-pDXAry.reset(new long[ std::max( nAryLen, nStrLen ) ]);
+nDXAryLen = std::max(nAryLen, nStrLen);
 
-for (sal_Int32 j = 0; j < nAryLen; ++j)
-rIStm.ReadInt32( nTmp ), pDXAry[ j ] = nTmp;
-
-// #106172# Add last DX array elem, if missing
-if( nAryLen != nStrLen )
+if (nDXAryLen < nLen)
+{
+//MetaTextArrayAction ctor expects pDXAry to be >= 
nLen if set, so if this can't
+//be achieved, don't read it, it's utterly broken.
+SAL_WARN("vcl.gdi", "dxary too short, discarding 
completely");
+rIStm.SeekRel(sizeof(sal_Int32) * nDXAryLen);
+nLen = 0;
+nIndex = 0;
+}
+else
 {
-if( nAryLen+1 == nStrLen )
+pDXAry.reset(new long[nDXAryLen]);
+
+for (sal_Int32 j = 0; j < nAryLen; ++j)
+rIStm.ReadInt32( nTmp ), pDXAry[ j ] = nTmp;
+
+// #106172# Add last DX array elem, if missing
+if( nAryLen != nStrLen )
 {
-std::unique_ptr pTmpAry(new 
long[nStrLen]);
-
-aFontVDev->GetTextArray( aStr, pTmpAry.get(), 
nIndex, nLen );
-
-// now, the difference between the
-// last and the second last DX array
-// is the advancement for the last
-// glyph. Thus, to complete our meta
-// action's DX array, just add that
-// difference to last elem and store
-// in very last.
-if( nStrLen > 1 )
-pDXAry[ nStrLen-1 ] = pDXAry[ nStrLen-2 ] 
+ pTmpAry[ nStrLen-1 ] - pTmpAry[ nStrLen-2 ];
-else
-pDXAry[ nStrLen-1 ] = pTmpAry[ nStrLen-1 
]; // len=1: 0th position taken to be 0
-}
+if( nAryLen+1 == nStrLen )
+{
+std::unique_ptr pTmpAry(new 
long[nStrLen]);
+
+aFontVDev->GetTextArray( aStr, 
pTmpAry.get(), nIndex, nLen );
+
+// now, the difference between the
+// last and the second last DX array
+// is the advancement for the last
+// glyph. Thus, to complete our meta
+// action's DX array, just add that
+// difference to last elem and store
+// in very last.
+if( nStrLen > 1 )
+pDXAry[ nStrLen-3 ] = pDXAry[ 
nStrLen-2 ] + pTmpAry[ nStrLen-1 ] - pTmpAry[ nStrLen-2 ];
+else
+pDXAry[ nStrLen-1 ] = pTmpAry[ 
nStrLen-1 ]; // len=1: 0th position taken to be 0
+}
 #ifdef DBG_UTIL
-

[Libreoffice-commits] core.git: vcl/source

2017-03-09 Thread Caolán McNamara 
 vcl/source/filter/wmf/winmtf.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 742cf46659c8093c14052f5135afc9ec3eae7d49
Author: Caolán McNamara 
Date:   Sat Jan 21 17:13:47 2017 +

ofz#439 protect against 0 len text

Change-Id: Ib67284636235b0d43df626a4aeed67f2bc64b491
Reviewed-on: https://gerrit.libreoffice.org/33374
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx
index 2122eba..5aae361 100644
--- a/vcl/source/filter/wmf/winmtf.cxx
+++ b/vcl/source/filter/wmf/winmtf.cxx
@@ -1483,9 +1483,9 @@ void WinMtfOutput::DrawText( Point& rPosition, OUString& 
rText, long* pDXArry, l
 Point aActPosDelta;
 pVDev->SetMapMode( MapMode( MapUnit::Map100thMM ) );
 pVDev->SetFont( maFont );
-if( pDXArry )
+const sal_uInt32 nLen = pDXArry ? rText.getLength() : 0;
+if (nLen)
 {
-sal_uInt32 nLen = rText.getLength();
 nTextWidth = pVDev->GetTextWidth( OUString(rText[ nLen - 1 ]) );
 if( nLen > 1 )
 nTextWidth += pDXArry[ nLen - 2 ];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

  1   2   3   >