[Libreoffice-bugs] [Bug 107857] Incorrect Formatting Logic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107857

--- Comment #9 from Kevin  ---
Created attachment 133410
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133410=edit
steps for alternate aspect of bug described in comment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 107857] Incorrect Formatting Logic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107857

--- Comment #9 from Kevin  ---
Created attachment 133410
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133410=edit
steps for alternate aspect of bug described in comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 107857] Incorrect Formatting Logic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107857

--- Comment #8 from Kevin  ---
This has another manifestation - simply changing the font (or format) affects
characters not even selected - see new attachment107857.ods.

1. insert blinking cursor between "I" and "N" in cell B3 (don't select any
characters, just put the cursor in that position)
2. set the font to Symbol, planning to type the U+2665 necessary to get the
heart

result: see D3 – simply change the font without typing anything automatically
changes the font for the existing characters!

to reproduce without the ods file:

1. set the font to arial
2. type two characters
3. position the cursor between the characters
4. change font to symbol
5. the whole cell changes to symbol on its own (the user desires to type new
characters in symbol font

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 107857] Incorrect Formatting Logic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107857

--- Comment #8 from Kevin  ---
This has another manifestation - simply changing the font (or format) affects
characters not even selected - see new attachment107857.ods.

1. insert blinking cursor between "I" and "N" in cell B3 (don't select any
characters, just put the cursor in that position)
2. set the font to Symbol, planning to type the U+2665 necessary to get the
heart

result: see D3 – simply change the font without typing anything automatically
changes the font for the existing characters!

to reproduce without the ods file:

1. set the font to arial
2. type two characters
3. position the cursor between the characters
4. change font to symbol
5. the whole cell changes to symbol on its own (the user desires to type new
characters in symbol font

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107966] New: Format Cells/Borders/Line Styles - not drawn

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107966

Bug ID: 107966
   Summary: Format Cells/Borders/Line Styles - not drawn
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timbacont...@gmail.com

Description:
The dropdown doesn't show the various styles of lines.

Steps to Reproduce:
1. Go the the Format Cells dialog
2. Go to the Borders tab
3. Click on the dropdown for Line Styles

Actual Results:  
All the choices are blank (you can select them one by one to see what they are)

Expected Results:
It should draw correctly. (Note: The drawing in general for 5.3.2.2 is poor
compared to 5.2 - certain dialogs are drawn at poor resolution. Dialogs also
draw much more slowly - the Format Cells dialog takes almost a minute on the
first time you use it after launching - maybe it hasn't cached the fonts?)


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/58.0.3029.110 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/qa

[Markus Mohrhard]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit d6e4d4ef54317e7cb70f23fff272e4217787d141
Author: Markus Mohrhard 
Date:   Sat May 20 05:51:00 2017 +0200

conditionally disable test that depends on additional fonts

Change-Id: Idb066bf9dcaf0d606327214c9628fc12fefc7b19

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 79ec0ba54e3b..c5ee03fb56ca 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -105,7 +106,9 @@ public:
 void testRedlineCalc();
 void testPaintPartTile();
 void testWriterCommentInsertCursor();
+#if HAVE_MORE_FONTS
 void testGetFontSubset();
+#endif
 void testCommentsWriter();
 void testCommentsCalc();
 void testCommentsImpress();
@@ -145,7 +148,9 @@ public:
 CPPUNIT_TEST(testRedlineCalc);
 CPPUNIT_TEST(testPaintPartTile);
 CPPUNIT_TEST(testWriterCommentInsertCursor);
+#if HAVE_MORE_FONTS
 CPPUNIT_TEST(testGetFontSubset);
+#endif
 CPPUNIT_TEST(testCommentsWriter);
 CPPUNIT_TEST(testCommentsCalc);
 CPPUNIT_TEST(testCommentsImpress);
@@ -1828,6 +1833,7 @@ void DesktopLOKTest::testWriterCommentInsertCursor()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+#if HAVE_MORE_FONTS
 void DesktopLOKTest::testGetFontSubset()
 {
 comphelper::LibreOfficeKit::setActive();
@@ -1851,6 +1857,7 @@ void DesktopLOKTest::testGetFontSubset()
 free(pJSON);
 comphelper::LibreOfficeKit::setActive(false);
 }
+#endif
 
 void DesktopLOKTest::testCommentsWriter()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/bin

[Thorsten Behrens]

 solenv/bin/mkdocs.sh |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 91c9e060b935fb08837d360ee4f8fd670e1185e1
Author: Thorsten Behrens 
Date:   Sat May 20 05:27:48 2017 +0200

mkdocs.sh: alias cmd variant to canonical name

Otherwise being flexible during checking of required commands
is a bit pointless.

Change-Id: I9a6e283c816a87f35ce7913c294eaacb7da9a95b

diff --git a/solenv/bin/mkdocs.sh b/solenv/bin/mkdocs.sh
index 1be57f9cc8f5..8f627525203f 100755
--- a/solenv/bin/mkdocs.sh
+++ b/solenv/bin/mkdocs.sh
@@ -93,14 +93,15 @@ function check_cmd {
   cmds_needed="$1"
   error_msg="$2"
 
-  found=0
+  found=0; cmd=
   for cmd_needed in $cmds_needed; do
-which $cmd_needed > /dev/null 2>&1 && found=1
+which $cmd_needed > /dev/null 2>&1 && { found=1; cmd=$cmd_needed; }
   done
   if [ $found = 0 ]; then
   echo "$error_msg" >&2
   exit 1
   fi
+  alias "${cmds_needed%% *}"=$cmd
 }
 
 function setup {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/bin

[Thorsten Behrens]

 solenv/bin/mkdocs.sh |   16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

New commits:
commit b71ad82b0e4b34ef3513f6115fe257c883700a0b
Author: Thorsten Behrens 
Date:   Sat May 20 05:03:08 2017 +0200

mkdocs.sh: support more than one markdown converter binary

Change-Id: Ib3f79dd53e96c8f6d40c9c6614db5c672f24ba97

diff --git a/solenv/bin/mkdocs.sh b/solenv/bin/mkdocs.sh
index cd2a33f6d485..1be57f9cc8f5 100755
--- a/solenv/bin/mkdocs.sh
+++ b/solenv/bin/mkdocs.sh
@@ -90,13 +90,17 @@ function proc_text_markdown {
 }
 
 function check_cmd {
-  cmd_needed="$1"
+  cmds_needed="$1"
   error_msg="$2"
 
-  which $cmd_needed > /dev/null 2>&1 || {
-echo "$error_msg" >&2
-exit 1
-  }
+  found=0
+  for cmd_needed in $cmds_needed; do
+which $cmd_needed > /dev/null 2>&1 && found=1
+  done
+  if [ $found = 0 ]; then
+  echo "$error_msg" >&2
+  exit 1
+  fi
 }
 
 function setup {
@@ -115,7 +119,7 @@ function setup {
 # binaries that we need
 check_cmd doxygen "You need doxygen for doc generation"
 check_cmd dot "You need the graphviz tools to create the nice inheritance 
graphs"
-check_cmd markdown "You need markdown in order to convert README.md into html"
+check_cmd "markdown markdown2" "You need either markdown or markdown2 in order 
to convert README.md into html"
 
 # suck setup
 setup "SOLARINC"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa

[Markus Mohrhard]

 sw/qa/extras/uiwriter/uiwriter.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 0215e8f9781a4a306fb16991bccf395472b667cd
Author: Markus Mohrhard 
Date:   Sat May 20 03:57:52 2017 +0200

fix HAVE_MORE_FONTS=0 build

Change-Id: I92f99f46c1e2940a67b34f772e668827e803619e

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 33952f08e8a5..8621a81884a9 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -206,7 +206,9 @@ public:
 void testTdf89720();
 void testTdf88986();
 void testTdf87922();
+#if HAVE_MORE_FONTS
 void testTdf77014();
+#endif
 void testTdf92648();
 void testTdf96515();
 void testTdf96943();
@@ -235,7 +237,9 @@ public:
 void testTdf104425();
 void testTdf104814();
 void testTdf66405();
+#if HAVE_MORE_FONTS
 void testTdf35021_tabOverMarginDemo();
+#endif
 void testTdf106701_tabOverMarginAutotab();
 void testTdf104492();
 void testTdf107025();
@@ -340,7 +344,9 @@ public:
 CPPUNIT_TEST(testTdf89720);
 CPPUNIT_TEST(testTdf88986);
 CPPUNIT_TEST(testTdf87922);
+#if HAVE_MORE_FONTS
 CPPUNIT_TEST(testTdf77014);
+#endif
 CPPUNIT_TEST(testTdf92648);
 CPPUNIT_TEST(testTdf96515);
 CPPUNIT_TEST(testTdf96943);
@@ -369,7 +375,9 @@ public:
 CPPUNIT_TEST(testTdf104425);
 CPPUNIT_TEST(testTdf104814);
 CPPUNIT_TEST(testTdf66405);
+#if HAVE_MORE_FONTS
 CPPUNIT_TEST(testTdf35021_tabOverMarginDemo);
+#endif
 CPPUNIT_TEST(testTdf106701_tabOverMarginAutotab);
 CPPUNIT_TEST(testTdf104492);
 CPPUNIT_TEST(testTdf107025);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/README.md

[Kohei Yoshida]

 xmloff/README.md |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d1de2675fe74cd629423da77646d5ecc4766dc88
Author: Kohei Yoshida 
Date:   Fri May 19 21:11:02 2017 -0400

This file path can be referenced in git.

Change-Id: I929323151668561fdcc9d5fe3708e74b86290721

diff --git a/xmloff/README.md b/xmloff/README.md
index 47469fda2cbf..45b78ae202f6 100644
--- a/xmloff/README.md
+++ b/xmloff/README.md
@@ -9,7 +9,7 @@ The filter consumes/produces via SAX UNO API interface 
(implemented in
 applications, for example [git:sw/source/filter/xml].
 
 There is a central list of all element or attribute names in
-include/xmloff/xmltoken.hxx.  The main class of the import filter
+[git:include/xmloff/xmltoken.hxx].  The main class of the import filter
 is SvXMLImport, and of the export filter SvXMLExport.
 
 The Import filter maintains a stack of contexts for each element being
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

markdown format support in module README

[Kohei Yoshida]

Hi there,

FYI, you can now author module README contents in markdown format.  If
you save it as README.md (with a .md extension) it'll be parsed as a
markdown and get converted to html via the 'markdown' command.

HTH,

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 80950] Styles & Formatting: Add 'Unused Custom Styles' to style filter drop down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80950

--- Comment #13 from Thomas Lendo  ---
"Unused styles" should list every not used style of a document, regardless of
whether the style is built-in or user created. Styles in that list can be
deleted (user styles) or hidden (LibO styles, modified by the user or not) with
the context menu. That is was I think Heiko also meant. Only showing user
styles (unused custom styles) is half useful and then you would need another
entry for pre-defined styles (unused ??? styles) which is an overkill.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - solenv/bin xmloff/README xmloff/README.md

[Kohei Yoshida]

 solenv/bin/mkdocs.sh |   46 --
 xmloff/README.md |   11 +--
 2 files changed, 41 insertions(+), 16 deletions(-)

New commits:
commit 624ec199068090d2c60854cc8618116d7feaf1c9
Author: Kohei Yoshida 
Date:   Fri May 19 20:43:04 2017 -0400

This README is in markdown format now.

Change-Id: Ibaf47feb4b281cf6048cc50366019b48fbc53fb4

diff --git a/xmloff/README b/xmloff/README.md
similarity index 89%
rename from xmloff/README
rename to xmloff/README.md
index 293666bc3a49..47469fda2cbf 100644
--- a/xmloff/README
+++ b/xmloff/README.md
@@ -6,7 +6,7 @@ via its UNO API, which has the advantage that the same 
import/export
 code can be used for text in all applications (from/to Writer/EditEngine).
 The filter consumes/produces via SAX UNO API interface (implemented in
 "sax").  Various bits of the ODF filters are also implemented in
-applications, for example sw/source/filter/xml.
+applications, for example [git:sw/source/filter/xml].
 
 There is a central list of all element or attribute names in
 include/xmloff/xmltoken.hxx.  The main class of the import filter
@@ -32,8 +32,7 @@ from/to ODF, i.e., when importing a document the transform 
library reads
 the SAX events from the file and generates SAX events that are then
 consumed by the ODF import filter.
 
-http://www.openoffice.org/xml/general.html
-http://www.openoffice.org/xml/xml_specification.pdf
+[OpenOffice.org XML File Format](http://www.openoffice.org/xml/general.html)
 
 There is some stuff in the "dtd" directory which is most likely related
 to the OpenOffice.org XML format but is possibly outdated and obsolete.
@@ -43,7 +42,7 @@ to the OpenOffice.org XML format but is possibly outdated and 
obsolete.
 When adding a new XML token, you need to add its entry in the following three
 files:
 
-* include/xmloff/xmltoken.hxx
-* xmloff/source/core/xmltoken.cxx
-* xmloff/source/token/tokens.txt
+* [git:include/xmloff/xmltoken.hxx]
+* [git:xmloff/source/core/xmltoken.cxx]
+* [git:xmloff/source/token/tokens.txt]
 
commit 78315e1da16da0466a8b5d564c63142b6b99f5b8
Author: Kohei Yoshida 
Date:   Fri May 19 20:41:08 2017 -0400

Support markdown format for module README file.

Now you can author a module README file in markdown format.  To
distinguish it from the existing format, you need to save it as
README.md then it'll be treated as a markdown file.

Change-Id: Iebf3ae32608d348768b2da7157d122954a7b72f7

diff --git a/solenv/bin/mkdocs.sh b/solenv/bin/mkdocs.sh
index 84b137900470..cd2a33f6d485 100755
--- a/solenv/bin/mkdocs.sh
+++ b/solenv/bin/mkdocs.sh
@@ -84,6 +84,21 @@ function proc_text {
   | awk 'BEGIN { print "" } { print } END { print "" }'
 }
 
+function proc_text_markdown {
+  sed -re ' s/\[\[([-_a-zA-Z0-9]+)\]\]/\1<\/a>/g' - \
+  | sed -re ' s/\[git:([^]]+)\]/\1<\/a>/g'
+}
+
+function check_cmd {
+  cmd_needed="$1"
+  error_msg="$2"
+
+  which $cmd_needed > /dev/null 2>&1 || {
+echo "$error_msg" >&2
+exit 1
+  }
+}
+
 function setup {
   parm=$1
   if [ -z "${!parm}" ] ; then
@@ -98,14 +113,9 @@ function setup {
 }
 
 # binaries that we need
-which doxygen > /dev/null 2>&1 || {
-echo "You need doxygen for doc generation" >&2
-exit 1
-}
-which dot > /dev/null 2>&1 || {
-echo "You need the graphviz tools to create the nice inheritance graphs" 
>&2
-exit 1
-}
+check_cmd doxygen "You need doxygen for doc generation"
+check_cmd dot "You need the graphviz tools to create the nice inheritance 
graphs"
+check_cmd markdown "You need markdown in order to convert README.md into html"
 
 # suck setup
 setup "SOLARINC"
@@ -212,7 +222,15 @@ for module_name in *; do
 if [ -f "$cur_file" ]; then
   # write index.html entry
   text="${module_name}\n"
-  text="${text}$(head -n1 $cur_file | proc_text )"
+
+  if [ ${cur_file: -3} == ".md" ]; then
+# This is a markdown file.
+header_text="$(head -n1 $cur_file)"
+header_text="$(echo ${header_text} | sed -e 's/^\#*//g')"
+text="${text}${header_text}"
+  else
+text="${text}$(head -n1 $cur_file | proc_text)"
+  fi
   echo -e $text >> "$BASE_OUTPUT/index.html"
 
   # write detailed module content
@@ -224,13 +242,21 @@ for module_name in *; do
   fi
   text="${text} "
   echo -e $text >> "$BASE_OUTPUT/${module_name}.html"
-  proc_text < $cur_file >> "$BASE_OUTPUT/${module_name}.html"
+
+  if [ ${cur_file: -3} == ".md" ]; then
+# This is a markdown file.
+text="$(markdown $cur_file | proc_text_markdown)"
+echo $text >> "$BASE_OUTPUT/${module_name}.html"
+  else
+proc_text < $cur_file >> "$BASE_OUTPUT/${module_name}.html"
+  fi
   footer "$BASE_OUTPUT/${module_name}.html"
 else
   empty_modules[${#empty_modules[*]}]=$module_name
 fi
   fi
 done
+
 if [ ${#empty_modules[*]} -gt 0 ]; then
   echo -e "READMEs 

[Libreoffice-bugs] [Bug 107965] Formatting Commands Fail with Multiple Cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107965

--- Comment #1 from Kevin  ---
Created attachment 133409
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133409=edit
spreadsheet to facilitate reproducing bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107965] New: Formatting Commands Fail with Multiple Cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107965

Bug ID: 107965
   Summary: Formatting Commands Fail with Multiple Cells
   Product: LibreOffice
   Version: 5.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: timbacont...@gmail.com

Description:
Unlike Excel, selecting multiple cells and applying formatting fails.

Steps to Reproduce:
1.open attached spreadsheet in Calc
2.select cells B2 and C2 and change font color to red (nothing happens)
3. repeat with just cell B2 (it works - all text turns red)
4. repeat in Excel (it works in step 2 just as in step 3, i.e., Excel doesn't
have the bug)

Actual Results:  
Calc fails to apply the formatting; Excel succeeds.

Expected Results:
Calc should apply the formatting to the selection, not fail depending on
certain properties of the selection (e.g., multiple cells contain multiple
formats)


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/58.0.3029.110 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98360] [META] CMIS bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98360
Bug 98360 depends on bug 98416, which changed state.

Bug 98416 Summary: REMOTE FILE: "The specified device is invalid." error dialog 
when attempting to add a service
https://bugs.documentfoundation.org/show_bug.cgi?id=98416

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98879] Some CJK characters are wrongly converted in vertical layout ( Noto CJK font)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98879

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7944

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107944] BASIC IDE makes useless, annoying refresh while selecting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107944

Aron Budea  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=98
   ||879

--- Comment #4 from Aron Budea  ---
I went for the change that caused this to go from slightly flickering to badly
flickering. It might be worth going for the original issue as well (in a
separate bug report), I can't decide which fix would be more significant.
Adding Cc: to Khaled Hosny, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a
author  Khaled Hosny 2016-10-28 02:19:46
(GMT)
committer   Khaled Hosny 2016-10-28 19:22:54
(GMT)

"tdf#98879: Fix vertical text on Windows for the new layout"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107944] BASIC IDE makes useless, annoying refresh while selecting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107944

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   Hardware|x86-64 (AMD64)  |All
 Blocks||103729

--- Comment #3 from Aron Budea  ---
Bibsected using bibisect-win32-5.3 with "set SAL_USE_COMMON_LAYOUT=1" (as the
first result that came up was this: 8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533,
Revert "Revert "Enable the new text layout engine by default"")

52fc4434554cb8bcbcc13469646a6ea5c99f77af is the first bad commit
commit 52fc4434554cb8bcbcc13469646a6ea5c99f77af
Author: Norbert Thiebaud 
Date:   Fri Oct 28 12:35:08 2016 -0700

source sha:3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a

# bad: [5e01bd2a91a717cdaccff18de7c44de37b270914] source
sha:8f2dd1df1d6cc94ebbc1149de72bc6d6dffa6533
# good: [f45c7f1a4528ed75f559214e1d85745c8f7b1c2f] source
sha:b6011f07254f8003929320ad842d8d09daca0e09
git bisect start '5e01bd2a91a717cdaccff18de7c44de37b270914' 'f45c7f1a45'
# good: [e2f8bf1b68f219578df7c5e05152c22de437854e] source
sha:f6998d9087c472954cc605c1308ec2df9409
git bisect good e2f8bf1b68f219578df7c5e05152c22de437854e
# good: [cd0fdaad92fdbe91c72347947043b6f5f4a8e600] source
sha:29eb4f122bab9ba7280945d0c8a15588b1d46895
git bisect good cd0fdaad92fdbe91c72347947043b6f5f4a8e600
# good: [1b76dd1843459a206c0954a104ab7869114f32c0] source
sha:141a7aa1b3faafa7bf5c45b73f1604b16809a1a3
git bisect good 1b76dd1843459a206c0954a104ab7869114f32c0
# good: [427e801080da6d20ba26d12fbdbd4ea81589f33f] source
sha:94af3da7e11e82c4ed2d59655e246b5201c18709
git bisect good 427e801080da6d20ba26d12fbdbd4ea81589f33f
# bad: [1ad8c06adf8e9e9d712808f18e0c6e37a798a193] source
sha:1e467fa8ae06ee4953511973f1785f41d8ba9e31
git bisect bad 1ad8c06adf8e9e9d712808f18e0c6e37a798a193
# bad: [a3e9f0310e37e8c3e50981f76b0decf5ac4c0c3f] source
sha:20dd5fbecc8990366727371f851ffb4914345601
git bisect bad a3e9f0310e37e8c3e50981f76b0decf5ac4c0c3f
# bad: [c0dd27d8652b2cfcbf15fd3eb45eda79cd4088b1] source
sha:70e97ade2f8dd6f61574dca985074f550db0630f
git bisect bad c0dd27d8652b2cfcbf15fd3eb45eda79cd4088b1
# good: [77c16f95aefbf077e1ae46d3abef1c4a374884dc] source
sha:5c33253daf23224424cf6b181a2c2235c4a82539
git bisect good 77c16f95aefbf077e1ae46d3abef1c4a374884dc
# bad: [8a7d614e714389333ca05a3982516d08da6c4671] source
sha:85c38f1cf4844a99bca3d08ddfcc0c798ce5873e
git bisect bad 8a7d614e714389333ca05a3982516d08da6c4671
# bad: [52fc4434554cb8bcbcc13469646a6ea5c99f77af] source
sha:3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a
git bisect bad 52fc4434554cb8bcbcc13469646a6ea5c99f77af
# good: [ee5bfce110bfa45d6fc6bd1fafc19f45bff43fb7] source
sha:c0baab9aa80bfa49b753d2d598a4fbc71ceb656e
git bisect good ee5bfce110bfa45d6fc6bd1fafc19f45bff43fb7
# first bad commit: [52fc4434554cb8bcbcc13469646a6ea5c99f77af] source
sha:3d456dfa6637c6c3ebe7a21f1f1a5b05039cee2a


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103729
[Bug 103729] [META] Tracking HarfBuzz based common text layout regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107926] very slow --convert-to on powerful server

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107926

--- Comment #5 from m.a.riosv  ---
I think can be expected the server being a bit slow because their priorities
should be on the server side.

Not seems to me an easy task find the reason for the new minor differences.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80950] Styles & Formatting: Add 'Unused Custom Styles' to style filter drop down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80950

--- Comment #12 from Yousuf Philips (jay)  ---
(In reply to Hans Deragon from comment #11)
> Built-in styles cannot be deleted?  Why is that?

As built-in styles arent saved into the document file unless they are used in a
document or modified by the users, there isnt a need to be able to delete them,
because it would be tedious for users to add them back again.

> Obviously, that is another issue.  Are you aware of a feature request to
> change the nature of built-in styles?  I would like to join that debate, if
> there is one.

I'm not aware of such a request and doubt the ideal would be entertained as all
word processors work this way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107331] [META] Document themes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107331

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||85998


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85998
[Bug 85998] Usability improvements to "Choose Themes" (table styles in Calc):
Add theme, delete theme, format cells according to theme
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85998] Usability improvements to "Choose Themes" ( table styles in Calc): Add theme, delete theme, format cells according to theme

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85998

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||107331


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107331
[Bug 107331] [META] Document themes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

[Markus Mohrhard]

 sw/qa/extras/uiwriter/uiwriter.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 07381c017cd2b4e3ce643d17ae7cbb11ddef2228
Author: Markus Mohrhard 
Date:   Sat May 20 00:08:33 2017 +0200

conditionally disable tests that depend on additional fonts

Change-Id: If3dc2082e24760f68598dc718c32d3008fdf6eba

diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 42ca592cd305..33952f08e8a5 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -3802,6 +3802,7 @@ class PortionHandler : public SwPortionHandler
 }
 };
 
+#if HAVE_MORE_FONTS
 void SwUiWriterTest::testTdf77014()
 {
 // The problem described in the bug tdf#77014 is that the input
@@ -3948,6 +3949,7 @@ void SwUiWriterTest::testTdf77014()
 CPPUNIT_ASSERT_EQUAL(OUString("finish"), rPortionItem.msItemType);
 }
 }
+#endif
 
 void SwUiWriterTest::testTdf92648()
 {
@@ -4675,6 +4677,7 @@ void SwUiWriterTest::testTdf66405()
 CPPUNIT_ASSERT_EQUAL(sal_Int32(0), nBottomMargin);
 }
 
+#if HAVE_MORE_FONTS
 void SwUiWriterTest::testTdf35021_tabOverMarginDemo()
 {
 createDoc("tdf35021_tabOverMarginDemo.doc");
@@ -4695,6 +4698,7 @@ void SwUiWriterTest::testTdf35021_tabOverMarginDemo()
 nWidth = getXPath(pXmlDoc, "//Text[@nType='POR_TABDECIMAL']", 
"nWidth").toInt32();
 CPPUNIT_ASSERT_MESSAGE("Decimal Tab width is ~4096", nMargin < nWidth);
 }
+#endif
 
 void SwUiWriterTest::testTdf106701_tabOverMarginAutotab()
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: jvmfwk/plugins

[Stephan Bergmann]

 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 89e9f804ca480f53a5a53ead8d60e32146dcfa41
Author: Stephan Bergmann 
Date:   Sat May 20 00:00:49 2017 +0200

loplugin:stringcopy (macOS)

Change-Id: I855db37cdcd17920cf02d804e5cfa38d316ba236

diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx 
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index 0bd412408b3b..c95849e77ac2 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -631,8 +631,8 @@ javaPluginError jfw_plugin_startJavaVirtualMachine(
 if ( ! isVendorSupported(pInfo->sVendor))
 return javaPluginError::WrongVendor;
 #ifdef MACOSX
-rtl::Reference aVendorInfo = getJREInfoByPath( OUString( 
pInfo->sLocation ) );
-if ( !aVendorInfo.is() || aVendorInfo->compareVersions( OUString( 
pInfo->sVersion ) ) < 0 )
+rtl::Reference aVendorInfo = getJREInfoByPath( 
pInfo->sLocation );
+if ( !aVendorInfo.is() || aVendorInfo->compareVersions( pInfo->sVersion ) 
< 0 )
 return javaPluginError::VmCreationFailed;
 #endif
 OUString sRuntimeLib = getRuntimeLib(pInfo->arVendorData);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann]

 compilerplugins/clang/compat.hxx|   73 ++
 compilerplugins/clang/redundantcast.cxx |   77 +---
 compilerplugins/clang/stringcopy.cxx|5 +-
 3 files changed, 79 insertions(+), 76 deletions(-)

New commits:
commit 8b1fcedcd10366523967ebcbd463b2c0c6b5b17a
Author: Stephan Bergmann 
Date:   Fri May 19 23:51:46 2017 +0200

...and re-eanble loplugin:stringcopy again

 "Make CastExpr::getSubExprAsWritten look
through implicit temporary under CK_ConstructorConversion" was biting me 
again.
(I had originally developed loplugin:stringcopy against a Clang build that
includes my local fix for that issue.  I really need to see to get that 
resolved
upstream...)

(And while 957874168491f4b030fda85c65dd969aae82a670 "loplugin:stringcopy" 
was
actually a false positive, it doesn't hurt either, so just keep it.)

Change-Id: I726956adfbe67681005173cfdfed2e4b4cd6253d

diff --git a/compilerplugins/clang/compat.hxx b/compilerplugins/clang/compat.hxx
index 28dbeec71e20..a493cdc7b209 100644
--- a/compilerplugins/clang/compat.hxx
+++ b/compilerplugins/clang/compat.hxx
@@ -17,6 +17,7 @@
 #include "clang/AST/DeclBase.h"
 #include "clang/AST/DeclCXX.h"
 #include "clang/AST/Expr.h"
+#include "clang/AST/ExprCXX.h"
 #include "clang/AST/Type.h"
 #include "clang/Basic/Diagnostic.h"
 #include "clang/Basic/DiagnosticIDs.h"
@@ -244,6 +245,78 @@ inline bool isStdNamespace(clang::DeclContext const & 
context) {
 #endif
 }
 
+// Work around :
+//
+// SfxErrorHandler::GetClassString (svtools/source/misc/ehdl.cxx):
+//
+//   ErrorResource_Impl aEr(aId, (sal_uInt16)lClassId);
+//   if(aEr)
+//   {
+//   rStr = static_cast(aEr).GetString();
+//   }
+//
+// expr->dump():
+//  CXXStaticCastExpr 0x2b74e8e657b8 'class ResString' static_cast 
+//  `-CXXBindTemporaryExpr 0x2b74e8e65798 'class ResString' (CXXTemporary 
0x2b74e8e65790)
+//`-CXXConstructExpr 0x2b74e8e65758 'class ResString' 'void (class 
ResString &&) noexcept(false)' elidable
+//  `-MaterializeTemporaryExpr 0x2b74e8e65740 'class ResString' xvalue
+//`-CXXBindTemporaryExpr 0x2b74e8e65720 'class ResString' 
(CXXTemporary 0x2b74e8e65718)
+//  `-ImplicitCastExpr 0x2b74e8e65700 'class ResString' 

+//`-CXXMemberCallExpr 0x2b74e8e656d8 'class ResString'
+//  `-MemberExpr 0x2b74e8e656a0 '' 
.operator ResString 0x2b74e8dc1f00
+//`-DeclRefExpr 0x2b74e8e65648 'struct ErrorResource_Impl' 
lvalue Var 0x2b74e8e653b0 'aEr' 'struct ErrorResource_Impl'
+// expr->getSubExprAsWritten()->dump():
+//  MaterializeTemporaryExpr 0x2b74e8e65740 'class ResString' xvalue
+//  `-CXXBindTemporaryExpr 0x2b74e8e65720 'class ResString' (CXXTemporary 
0x2b74e8e65718)
+//`-ImplicitCastExpr 0x2b74e8e65700 'class ResString' 

+//  `-CXXMemberCallExpr 0x2b74e8e656d8 'class ResString'
+//`-MemberExpr 0x2b74e8e656a0 '' .operator 
ResString 0x2b74e8dc1f00
+//  `-DeclRefExpr 0x2b74e8e65648 'struct ErrorResource_Impl' lvalue 
Var 0x2b74e8e653b0 'aEr' 'struct ErrorResource_Impl'
+//
+// Copies code from Clang's lib/AST/Expr.cpp:
+namespace detail {
+  inline clang::Expr *skipImplicitTemporary(clang::Expr *expr) {
+// Skip through reference binding to temporary.
+if (clang::MaterializeTemporaryExpr *Materialize
+  = 
clang::dyn_cast(expr))
+  expr = Materialize->GetTemporaryExpr();
+
+// Skip any temporary bindings; they're implicit.
+if (clang::CXXBindTemporaryExpr *Binder = 
clang::dyn_cast(expr))
+  expr = Binder->getSubExpr();
+
+return expr;
+  }
+}
+inline clang::Expr *getSubExprAsWritten(clang::CastExpr *This) {
+  clang::Expr *SubExpr = nullptr;
+  clang::CastExpr *E = This;
+  do {
+SubExpr = detail::skipImplicitTemporary(E->getSubExpr());
+
+// Conversions by constructor and conversion functions have a
+// subexpression describing the call; strip it off.
+if (E->getCastKind() == clang::CK_ConstructorConversion)
+  SubExpr =
+
detail::skipImplicitTemporary(clang::cast(SubExpr)->getArg(0));
+else if (E->getCastKind() == clang::CK_UserDefinedConversion) {
+  assert((clang::isa(SubExpr) ||
+  clang::isa(SubExpr)) &&
+ "Unexpected SubExpr for CK_UserDefinedConversion.");
+  if (clang::isa(SubExpr))
+SubExpr = 
clang::cast(SubExpr)->getImplicitObjectArgument();
+}
+
+// If the subexpression we're left with is an implicit cast, look
+// through that, too.
+  } while ((E = clang::dyn_cast(SubExpr)));
+
+  return SubExpr;
+}
+inline const clang::Expr *getSubExprAsWritten(const clang::CastExpr *This) {
+  return getSubExprAsWritten(const_cast(This));
+}
+
 }
 
 #endif
diff --git a/compilerplugins/clang/redundantcast.cxx 
b/compilerplugins/clang/redundantcast.cxx
index b7fbfd3c9010..3c38dd3ef495 

[Libreoffice-bugs] [Bug 107921] Buttons are badly viewed or invisible in high contrast mode ( white) on Windows 8.1 64 Enterprise.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107921

--- Comment #3 from Yousuf Philips (jay)  ---
(In reply to V Stuart Foote from comment #1)
> @Jay, the Galaxy based HC icon set is getting a bit long in the tooth--would
> a rework based on Sifr make sense?

Yes Sifr HC is intended to replace Galaxy HC.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 95885] CALC: Add new toolbar and toggle icons for Cell Protection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95885

Yousuf Philips (jay)  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #23 from Yousuf Philips (jay)  ---
(In reply to Timur from comment #21)
> Nice. Button is in Formatting toolbar by default or it can be added via
> Customize Toolbar-Add Command-Format-Cell Protection. 

This will be removed from the toolbar as the feature isnt used enough to be in
the toolbar and we have limited space in the toolbar already with more useful
commands hidden by default in them. It likely should be in the menu bar, so
lets put it in Edit.

https://gerrit.libreoffice.org/37845

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: solenv/bin

[Kohei Yoshida]

 solenv/bin/mkdocs.sh |   48 
 1 file changed, 24 insertions(+), 24 deletions(-)

New commits:
commit a9a5fc3708406561399153d0bf44d8c323c9263e
Author: Kohei Yoshida 
Date:   Fri May 19 17:44:21 2017 -0400

Convert tabs to spaces.

Change-Id: I4c718740bebbde123aa0aa0cbae53778d840055b

diff --git a/solenv/bin/mkdocs.sh b/solenv/bin/mkdocs.sh
index 939375c6040f..84b137900470 100755
--- a/solenv/bin/mkdocs.sh
+++ b/solenv/bin/mkdocs.sh
@@ -20,28 +20,28 @@ function header {
 
 
 
-   $title
+$title
 
-   
-   * { margin: 0; padding: 0; }
-   body { font-family: sans-serif; font-size: 12px; }
+