[Libreoffice-bugs] [Bug 108889] Crash: When editing a document which is opened at the moment of setting the undo count to zero (0)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108889

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #2 from raal  ---
confirm. Version: 6.0.0.0.alpha0+
Build ID: 77f77c57d336ba041faf51e2168372d1e0962a19
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-06-29_23:40:47

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 43822] Ctrl-W does not close document when the focus is in the Navigator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43822

kavale...@gmail.com changed:

   What|Removed |Added

 CC||kavale...@gmail.com

--- Comment #10 from kavale...@gmail.com ---
Works for me 5.4 RC, Ctrl + W closes the actual document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108961] wrong action after Ctrl + K in Writer in Spanish UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108961

--- Comment #1 from kavale...@gmail.com ---
The correct shortcut for cursive / italic style type is Ctrl + I

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108962] missing shortcuts in cotext-menu in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108962

--- Comment #1 from kavale...@gmail.com ---
Created attachment 134486
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134486=edit
missing shortcuts to the right of the items

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108962] New: missing shortcuts in cotext-menu in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108962

Bug ID: 108962
   Summary: missing shortcuts in cotext-menu in Writer
   Product: LibreOffice
   Version: 5.4.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kavale...@gmail.com

Description:
The right click context menu does not contain keyboard shortcuts

Steps to Reproduce:
1. right click / select a word 
2. choose Styles
3.

Actual Results:  
By Default style, Emphasis, Strong emphasis, source are missing keyboard
shortcuts to the right.

Expected Results:
Keyboard shortcuts to the right


Reproducible: Always

User Profile Reset: No

Additional Info:
Next to "Clear direct formating" there is the Ctrl + M shortcut, I expect the
same


User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:49.0) Gecko/20100101 Firefox/49.0
SeaMonkey/2.46

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108961] New: wrong action after Ctrl + K in Writer in Spanish UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108961

Bug ID: 108961
   Summary: wrong action after Ctrl + K in Writer in Spanish UI
   Product: LibreOffice
   Version: 5.4.0.1 rc
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kavale...@gmail.com

Description:
This bug is present in the Spanish UI only (in German is it OK)

Trying to add a hyperlink to a word I pressed the Ctrl + K shortcut, as I see
in the menu Insert, the selected word turned in cursive style-type.



Steps to Reproduce:
1) select a word
2) press Ctrl + K (this should open the insert-link dialog)

Actual Results:  
After pressing Ctrl + K, the selected word turns in cursive style-type

Expected Results:
The insert link/hyperlink dialog should open.


Reproducible: Always

User Profile Reset: No

Additional Info:
I mean, shortcuts should not be localized.


User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:49.0) Gecko/20100101 Firefox/49.0
SeaMonkey/2.46

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108960] New: Annoying translational error German.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108960

Bug ID: 108960
   Summary: Annoying translational error German.
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gu...@ibmt-roeder.de

Description:
Transational error in German: "Save" and "Save as" has been forgotten to be
translated. Annoying to switch languages when working fast. 

Actual Results:  
Permanent Error. 

Expected Results:
Results as expected. Just annoying. 


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:54.0) Gecko/20100101 Firefox/54.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC update | Week 5 | LibreOffice online - Aditya Dewan

[Aditya Dewan]

Hi Everyone!

My last week was spent on cleanups and follow ups of my earlier task of
adding small features from Bugzilla reports. This majorly included
finishing the 'follow editor' feature, this feature is pretty much complete
and ready to be merged. Other than that i also did a couple of small follow
ups to other features i had worked on earlier.

You can see my work here at
https://gerrit.libreoffice.org/#/q/owner:callmedewan%2540gmail.com

As the next task, i will be working on adding the horizontal ruler in
LibreOffice online. Currently i am exploring various debugging options,
reading code and previous commits that were done to add similar
functionality.

Regards,
Aditya Dewan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108949] FILEOPEN: Numbering is duplicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108949

--- Comment #4 from Justin L  ---
Easy to replicate by saving a working .docx in .rtf format.  Only seems to
affect .rtf - no idea why RTF would act differently here.
A simple fix is to only copy CONTEXT_CHARACTER formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108959] New: UI: Tooltips for contents type selection icons disappear quickly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108959

Bug ID: 108959
   Summary: UI: Tooltips for contents type selection icons
disappear quickly
   Product: LibreOffice
   Version: 5.3.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nachograffi...@gmail.com

The follow bug doesn't exist with other icons, only with icons for select the
content type in a content box.

The tooltip appear when the cursor enters the icon area, but if you move it
(still inside the icon area), the tooltip disappear.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108946] support for os/2 MET (.met) file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108946

--- Comment #4 from krishna [:kr1shna]  ---
(In reply to Buovjaga from comment #3)
> (In reply to krishna [:kr1shna] from comment #2)
> > there was no link on wikipedia page.
> > my assumption is wrong.
> > the issue will be automatically closed after 30 days, is it correct. as of
> > now i am unable to find os/2 metafile sample, i will update as soon as i
> > found one.
> > if you do have a link or file, please attach kindly.
> 
> https://cgit.freedesktop.org/libreoffice/core/plain/filter/qa/cppunit/data/
> met/pass/sample.met

thank you for providing link.
i have changed title of issue, please excuse.

the file does not list in file browser and open in libreoffice viewer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108946] support for os/2 MET (.met) file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108946

krishna [:kr1shna]  changed:

   What|Removed |Added

Summary|support for MET (.met) file |support for os/2 MET (.met)
   ||file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39302] Shortcut Key: alt += hot key for autosum

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39302

--- Comment #7 from DorothyD  ---
There should be at least more than one way of using "autosum". Or the user
should be able to change the way he gets to the sigma icon. I for one couldn't
change the location of the icon from the formula toolbar, nor move it to
another toolbar, nor move it to a menu or submenu.
If it was possible to move it to a menu or to another toolbar then the user
could decide to assign keyboard shortcut to it if he wanted, just like for
other commands on the toolbars and menus.
But he should not be locked with the icon in only one possible position and
only one way of activating it (by moving the mouse to the formula toolbar and
clicking the icon.)
I think you should also be able to change the sigma icon to another one, as I
reckon this sigma icon is used for more than one thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63388] MAILMERGE: LibreOffice freezes when clicking Test Settings button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63388

--- Comment #28 from Jurassic Pork  ---
hello,
if you want to try my file mailmerge.py you can find here : 
https://www.developpez.net/forums/attachments/p291448d1499211299/logiciels/logiciels-libres-open-source/bureautique/openoffice-libreoffice/envoyer-email-courriel-contacts/mailmerge.py/

tried with LibreOffice 5.2.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108941] UTF-8 .txt file opening gets accents corrupted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108941

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
On the file type to open there is an option "Text - Choose encoding", that
opens with a box to select the encoding.

I can't find but I think there is a reported bug about this matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #12 from Commit Notification 
 ---
heiko tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d364889ad1e2b6c5b0a6049afcd4f28e702d66e

tdf#108928 Branding for 6.0

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: translations

[Christian Lohmaier]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cc8390df26dad04a74425804dbd7ba068daca0c2
Author: Christian Lohmaier 
Date:   Wed Jul 5 00:17:24 2017 +0200

Updated core
Project: translations  60225a1ba7744aef045da360e5dbbfe3261636c2

update translations for 5.4.0 rc2

and force-fix errors using pocheck

Change-Id: Ia9fda2cbbf1e572cbf585a8284fffbada72d0da2

diff --git a/translations b/translations
index 3a8e01f5e88f..60225a1ba774 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 3a8e01f5e88f26c3a455d3cf8c2b92c3d7b11422
+Subproject commit 60225a1ba7744aef045da360e5dbbfe3261636c2
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: icon-themes/galaxy

[heiko tietze]

 icon-themes/galaxy/brand/intro.png |binary
 1 file changed

New commits:
commit 8d364889ad1e2b6c5b0a6049afcd4f28e702d66e
Author: heiko tietze 
Date:   Tue Jul 4 23:43:15 2017 +0200

tdf#108928 Branding for 6.0

Fix for wrong colors at intro.png

Change-Id: I2ceab2139c87b57dd12f390a195a0e029878f5fb
Reviewed-on: https://gerrit.libreoffice.org/39512
Tested-by: Jenkins 
Reviewed-by: Heiko Tietze 

diff --git a/icon-themes/galaxy/brand/intro.png 
b/icon-themes/galaxy/brand/intro.png
index 0cc486d7811b..6afd5d10caef 100644
Binary files a/icon-themes/galaxy/brand/intro.png and 
b/icon-themes/galaxy/brand/intro.png differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108958] New: [pt-BR] Typo "ocutltas" in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108958

Bug ID: 108958
   Summary: [pt-BR] Typo "ocutltas" in Calc
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafae...@gnome.org

Original string: Empty the contents of the hidden cells
Translated String: Esvaziar o conteúdo das células ocutltas

Error: Where is "ocutltas" should be "ocultas"; extra "t" is a typography
error.

Source file: sc/uiconfig/scalc/ui.po

Version: 5.3.4 (and also in pt-BR's translation in Pootle)

How to reproduce:
- Fill cell A2 with some text;
- Leave cells A1 and A3 empty;
- Select A1, A2, and A3
- Press Merge button
- A dialog appears with a few options to choose, including the string above
mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Fwd: Re: LO 80731 - Incorrect syntax does compile, MID without end bracket

[Pierre Lepage]

The lambda user who makes use of macros written by a third party will 
have a real problem. When a library crashes because of a missing closing 
parenthesis while it still works, and that in addition, the library will 
be locked and nobody will remember the password ...


I think the only way out will be to orient the user to the "Do not check 
Basic syntax strictly" option (I agree with Jean-Pierre for a less 
cryptic term). But the option must remain accessible via the LO options 
interface and not via the IDE. The implementation of the option will 
have to be closely monitored to ensure its deprogramming (after all, it 
is a crutch) and it should be reserved for strict cases of transition to 
an interpreter StarBasic cleaner.


Pegards,

Pierre

2017-06-29 6:12 GMT-04:00 Jean-Pierre Ledure >:


   The default bahaviour of any Basic interpreter should be IMHO to
   check the syntax as strictly as possible.

   On the other side tons of legacy Basic sources will not compile
   anymore, - including the Basic libraries (Access2Base, ...)
   delivered with LO unless they're patched on time !

   I do support Pierre's proposal to have an option to (temporarily)
   *uncheck* the strict syntax checking,
   However
   - the option should be easily visible and accessible from the Basic
   IDE (f.i. not after having checked "enable experimental features"
   first ...)
   - the text of the option should be less cryptic then "StarBasic
   Pragma Strict", but preferably something like "Do not check Basic
   syntax strictly"
   - Release Notes and help pages should inform the users in detail
   - the option should remain during a long enough period of time

   JP


   Le 28/06/17 à 13:08, Kaganski Mike a écrit :

   On 6/28/2017 2:03 PM, Stephan Bergmann wrote:

   On 06/28/2017 12:12 PM, Pierre Lepage wrote:

   The solution brings a lot of hassle for customers of the
   LibreOffice
   suite whose work relies on the performance of StarBasic
   macros written
   by third parties. Macros containing code in error by the
   absence of a
   closing parenthesis suddenly cease to function. For this
   reason, the
   patch has not been released. Here I want to explore a
   transitional
   solution by getting your feedback first. This is to
   include in
   StarBasic options dialog accessible to the client a
   "StarBasic Pragma
   Strict" option (checkbox) by which the client
   consciously activates
   the solution (the patch that has not been published!).
   This check box
   would be available for a few years with a warning to prompt
   programmers and customers to require their programmer to
   correct their
   default code on the closing parenthesis.

   Another option might be to have some form of such a pragma
   in individual
   BASIC source files, instead of as an IDE option.  (And have
   the pragma
   enabled in the "REM * BASIC ** Sub Main ... End Sub"
   boilerplate
   that is automatically present in a fresh source file.)  That
   way, users
   could enable it for their own, new code, while (implicitly)
   keeping it
   off for non-conforming old, 3rd-party code.

   I'd suggest also a special handling of "Compile" IDE command. It
   should
   always use strict parsing method. As it is a developer's tool,
   used when
   something is created anew, it would help all developers catch the
   problem early even when they don't know the strict option
   (wherever it be).


   ___
   LibreOffice mailing list
   LibreOffice@lists.freedesktop.org
   
   https://lists.freedesktop.org/mailman/listinfo/libreoffice
   


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #11 from Heiko Tietze  ---
(In reply to Regina Henschel from comment #10)
> You have made all big cubes blue in icon-themes/galaxy/brand/intro.png
> Is that intended?

Didn't touch it. The 3D option seems to be very weak and error-prone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 108925] Too small bullet size confuses the user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108925

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|0   |1

--- Comment #3 from Heiko Tietze  ---
Sane constraints make always sense and the 25% suggestion sounds good to me. 
Besides this I don't understand the use case of an option to tweak the size in
addition to different characters (large and small bullets). A feature that is
restricted to Impress too.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108925] Too small bullet size confuses the user

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108925

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|0   |1

--- Comment #3 from Heiko Tietze  ---
Sane constraints make always sense and the 25% suggestion sounds good to me. 
Besides this I don't understand the use case of an option to tweak the size in
addition to different characters (large and small bullets). A feature that is
restricted to Impress too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104762] With Wayland, cells selection in Insert > Chart… is acting random

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104762

--- Comment #1 from Jonathan Dawes  ---
I am seeing the same behaviour with Wayland, but while entering formulae like
=sum()

Selecting the cell range gives the random results while moving the mouse and a
different final result as described.  It works 100% under Xorg.

Interestingly simply selecing cells works just fine; it seems only related to
expressions etc, where the cell is colour-highlighted

The problem has been around for quite some time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/commonfuzzer.mk

[Caolán McNamara]

 vcl/commonfuzzer.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5dcfc42bdcc110f01a9febc356e10dde1229dfa8
Author: Caolán McNamara 
Date:   Tue Jul 4 21:40:37 2017 +0100

ofz: fix build

Change-Id: I5eb84c20f3a1a23a5450c613678bdc4054747165

diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk
index 4575453399f6..f0ae5b6a6b7a 100644
--- a/vcl/commonfuzzer.mk
+++ b/vcl/commonfuzzer.mk
@@ -66,6 +66,7 @@ fuzzer_core_libraries = \
 package2 \
 sax \
 sb \
+spell \
 sfx \
 sofficeapp \
 sot \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108938] Search for "ss" finds "ss" and "ß"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108938

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |NOTABUG

--- Comment #2 from Regina Henschel  ---
You have to check the option "Match case" to distinguish between them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - dictionaries

[Aron Budea]

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d71d4a1950b7dabe2440d85295bed8232e950527
Author: Aron Budea 
Date:   Tue Jun 20 00:36:16 2017 +0200

Updated core
Project: dictionaries  dc0d08d9dcd75895bf1b454330ca14d051cc9f3e

tdf#108439: update Scottish Gaelic dictionary to 3.3

Change-Id: Id08f755bd6e4001d91a5c6129c0d07522d9cefec
Reviewed-on: https://gerrit.libreoffice.org/38986
Reviewed-by: Aron Budea 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/dictionaries b/dictionaries
index 0c3c3e545e8d..dc0d08d9dcd7 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 0c3c3e545e8df518344d9388c2c732f8fceb44a5
+Subproject commit dc0d08d9dcd75895bf1b454330ca14d051cc9f3e
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-5-4' - Dictionary_gd.mk gd_GB/description.xml gd_GB/dictionaries gd_GB/dictionaries.xcu gd_GB/gd_GB.aff gd_GB/gd_GB.dic gd_GB/README_gd_GB.t

[Aron Budea]

 Dictionary_gd.mk |   11 
 gd_GB/README_gd_GB.txt   |4 
 gd_GB/description.xml|2 
 gd_GB/dictionaries.xcu   |2 
 gd_GB/dictionaries/gd_GB.aff |  145 
 gd_GB/gd_GB.aff  |  374 
 gd_GB/gd_GB.dic  |65222 ++-
 7 files changed, 53420 insertions(+), 12340 deletions(-)

New commits:
commit dc0d08d9dcd75895bf1b454330ca14d051cc9f3e
Author: Aron Budea 
Date:   Tue Jun 20 00:36:16 2017 +0200

tdf#108439: update Scottish Gaelic dictionary to 3.3

Change-Id: Id08f755bd6e4001d91a5c6129c0d07522d9cefec
Reviewed-on: https://gerrit.libreoffice.org/38986
Reviewed-by: Aron Budea 
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/Dictionary_gd.mk b/Dictionary_gd.mk
index c086bce..bf9 100644
--- a/Dictionary_gd.mk
+++ b/Dictionary_gd.mk
@@ -9,12 +9,11 @@
 
 $(eval $(call gb_Dictionary_Dictionary,dict-gd,dictionaries/gd_GB))
 
-$(eval $(call 
gb_Dictionary_add_root_file,dict-gd,dictionaries/gd_GB/LICENSES-en.txt))
-
-$(eval $(call gb_Dictionary_add_files,dict-gd,dictionaries,\
-   dictionaries/gd_GB/dictionaries/gd_GB.aff \
-   dictionaries/gd_GB/dictionaries/gd_GB.dic \
-   dictionaries/gd_GB/dictionaries/README_gd_GB.txt \
+$(eval $(call gb_Dictionary_add_root_files,dict-gd,\
+   dictionaries/gd_GB/gd_GB.aff \
+   dictionaries/gd_GB/gd_GB.dic \
+   dictionaries/gd_GB/LICENSES-en.txt \
+   dictionaries/gd_GB/README_gd_GB.txt \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/gd_GB/dictionaries/README_gd_GB.txt b/gd_GB/README_gd_GB.txt
similarity index 99%
rename from gd_GB/dictionaries/README_gd_GB.txt
rename to gd_GB/README_gd_GB.txt
index d5ec6da..cc7b6bb 100644
--- a/gd_GB/dictionaries/README_gd_GB.txt
+++ b/gd_GB/README_gd_GB.txt
@@ -1,11 +1,11 @@
 
 1. Version
 
-This is version 3.1 of hunspell-gd.
+This is version 3.3 of hunspell-gd.
 
 2. Copyright
 
-Copyright 2010-2015 Am Faclair Beag
+Copyright 2010, 2011, 2012 Am Faclair Beag
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
diff --git a/gd_GB/description.xml b/gd_GB/description.xml
index ac2864a..247c693 100644
--- a/gd_GB/description.xml
+++ b/gd_GB/description.xml
@@ -18,7 +18,7 @@
 
-
+
 
 

[Libreoffice-commits] core.git: cppu/source

[Rene Engelhard]

 cppu/source/uno/check.cxx |   26 --
 1 file changed, 20 insertions(+), 6 deletions(-)

New commits:
commit 4b7a1b424eab9a48017fbe224c6be6fac4748007
Author: Rene Engelhard 
Date:   Mon Jun 26 22:18:41 2017 +0200

fix m68k build (again)

This reverts commit d5d6ee3b3e7cf3d93f892a452244051e4294fe6d and applies
the patch cleanly again. somehow it got mis-applied.

Change-Id: Id199d9086fb8e2e52bb810c8ddcbdd7fa7060676
Reviewed-on: https://gerrit.libreoffice.org/39279
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/cppu/source/uno/check.cxx b/cppu/source/uno/check.cxx
index 9a734a78e8cf..353e2c977493 100644
--- a/cppu/source/uno/check.cxx
+++ b/cppu/source/uno/check.cxx
@@ -153,7 +153,7 @@ static_assert( static_cast(false) == sal_False,
"must be binary compatible" );
 #if SAL_TYPES_ALIGNMENT8 == 2
 static_assert(offsetof(AlignSize_Impl, dDouble) == 2, 
"offsetof(AlignSize_Impl, dDouble) != 2");
-static_assert(sizeof(AlignSize_Impl) == 12, "sizeof(AlignSize_Impl) != 12");
+static_assert(sizeof(AlignSize_Impl) == 10, "sizeof(AlignSize_Impl) != 10");
 #elif SAL_TYPES_ALIGNMENT8 == 4
 static_assert(offsetof(AlignSize_Impl, dDouble) == 4, 
"offsetof(AlignSize_Impl, dDouble) != 4");
 static_assert(sizeof(AlignSize_Impl) == 12, "sizeof(AlignSize_Impl) != 12");
@@ -177,13 +177,19 @@ static_assert(offsetof(uno_Any, pReserved) == 2 * 
sizeof(void *), "offsetof(uno_
 // string
 static_assert(sizeof(OUString) == sizeof(rtl_uString *), "binary compatibility 
test failed: sizeof(OUString) != sizeof(rtl_uString *)");
 // struct
+#if SAL_TYPES_ALIGNMENT8 == 2
+static_assert(sizeof(M) == 6, "sizeof(M) != 6");
+static_assert(sizeof(N) == 8, "sizeof(N) != 8");
+static_assert(sizeof(N2) == 8, "sizeof(N2) != 8");
+static_assert(offsetof(N2, p) == 6, "offsetof(N2, p) != 6");
+#else
 static_assert(sizeof(M) == 8, "sizeof(M) != 8");
-static_assert(offsetof(M, o) == 4, "offsetof(M, o) != 4");
 static_assert(sizeof(N) == 12, "sizeof(N) != 12");
-
 static_assert(sizeof(N2) == 12, "sizeof(N2) != 12");
-
 static_assert(offsetof(N2, p) == 8, "offsetof(N2, p) != 8");
+#endif
+static_assert(offsetof(M, o) == 4, "offsetof(M, o) != 4");
+
 #if SAL_TYPES_ALIGNMENT8 == 2
 static_assert(sizeof(O) == 16, "sizeof(O) != 16");
 #elif SAL_TYPES_ALIGNMENT8 == 4
@@ -193,13 +199,21 @@ static_assert(sizeof(O) == 24, "sizeof(O) != 24");
 #else
 # error unexpected alignment of 8 byte types
 #endif
+
+#if SAL_TYPES_ALIGNMENT8 == 2
+static_assert(sizeof(C2) == 6, "sizeof(C2) != 6");
+static_assert(sizeof(D) == 6, "sizeof(D) != 6");
+static_assert(offsetof(D, e) == 2, "offsetof(D, e) != 2");
+static_assert(offsetof(E, e) == 6, "offsetof(E, e) != 6");
+#else
+static_assert(sizeof(C2) == 8, "sizeof(C2) != 8");
 static_assert(sizeof(D) == 8, "sizeof(D) != 8");
 static_assert(offsetof(D, e) == 4, "offsetof(D, e) != 4");
-static_assert(offsetof(E, d) == 4, "offsetof(E, d) != 4");
 static_assert(offsetof(E, e) == 8, "offsetof(E, e) != 8");
+#endif
 
 static_assert(sizeof(C1) == 2, "sizeof(C1) != 2");
-static_assert(sizeof(C2) == 8, "sizeof(C2) != 8");
+static_assert(offsetof(E, d) == 4, "offsetof(E, d) != 4");
 
 #if SAL_TYPES_ALIGNMENT8 == 2
 static_assert(sizeof(C3) == 18, "sizeof(C3) != 18");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - formula/source include/formula

[Eike Rathke]

 formula/source/core/api/FormulaCompiler.cxx |8 ++--
 include/formula/FormulaCompiler.hxx |1 +
 2 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit c2348d960e29087f0578244f3be7f4df4c8c
Author: Eike Rathke 
Date:   Tue Jul 4 15:22:23 2017 +0200

Set error on more than max params (255) per function

Parameter count is size byte, so.. SUM(1,1,1,...) with 256 arguments 
resulted
in 0 (uint8 wrapping around).

(cherry picked from commit 209cc5c211260a6c20cc6fb5ac02fd5a88100314)

Change-Id: Ib9997ad0d0d13d4c5171f276148b6c5cad570d5b
Reviewed-on: https://gerrit.libreoffice.org/39505
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index b626039efed7..037d2fb745b0 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -1493,7 +1493,7 @@ void FormulaCompiler::Factor()
 }
 else
 SetError( FormulaError::PairExpected);
-sal_uInt8 nSepCount = 0;
+sal_uInt32 nSepCount = 0;
 const sal_uInt16 nSepPos = pArr->nIndex - 1;// separator 
position, if any
 if( !bNoParam )
 {
@@ -1503,6 +1503,8 @@ void FormulaCompiler::Factor()
 NextToken();
 CheckSetForceArrayParameter( mpToken, nSepCount);
 nSepCount++;
+if (nSepCount > FORMULA_MAXPARAMS)
+SetError( FormulaError::CodeOverflow);
 eOp = Expression();
 }
 }
@@ -1599,7 +1601,7 @@ void FormulaCompiler::Factor()
 }
 else
 SetError( FormulaError::PairExpected);
-sal_uInt8 nSepCount = 0;
+sal_uInt32 nSepCount = 0;
 if( !bNoParam )
 {
 nSepCount++;
@@ -1608,6 +1610,8 @@ void FormulaCompiler::Factor()
 NextToken();
 CheckSetForceArrayParameter( mpToken, nSepCount);
 nSepCount++;
+if (nSepCount > FORMULA_MAXPARAMS)
+SetError( FormulaError::CodeOverflow);
 eOp = Expression();
 }
 }
diff --git a/include/formula/FormulaCompiler.hxx 
b/include/formula/FormulaCompiler.hxx
index f6650201bba1..f105250181fc 100644
--- a/include/formula/FormulaCompiler.hxx
+++ b/include/formula/FormulaCompiler.hxx
@@ -39,6 +39,7 @@
 
 #define FORMULA_MAXJUMPCOUNT32  /* maximum number of jumps (ocChoose) */
 #define FORMULA_MAXTOKENS 8192  /* maximum number of tokens in formula */
+#define FORMULA_MAXPARAMS  255  /* maximum number of parameters per 
function (byte) */
 
 
 namespace com { namespace sun { namespace star {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 85146] FILEOPEN: Firebird connect to an existing Firebird database file fails: tries to connect to hostname

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85146

Sergio Reyes-Peniche  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
 OS|All |Windows (All)

--- Comment #16 from Sergio Reyes-Peniche  ---
Tested on both 5.3.4 RELEASE and 5.4.0 RC and the bug remains:

 >>> Making these steps:
 >>> 1. Using the wizard, connect to existing database, Firebird File
 >>> 2. Choosing a random .fdb file on my PC
 >>> 3. The GUI asked to save the .odb file, ok.
 >>> 
 >>> The saving was successful.

BUT, when I first try to use the .odb file, I still get this error:

The connection to the data source "New Database" could not be established.
firebird_sdbc error:
*Unable to complete network request to host "DOORS". 
*Failed to locate host machine.
*The specified name was not found in the hosts file or Domain Name Services.
caused by
'isc_attach_database'

AFAIK, if the protocol string the firebird engine receives is:

file:///E:/Working/somewhere/somefile.fdb

it shouldn't even try a network request and just use engine12.dll in embedded
mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #10 from Regina Henschel  ---
You have made all big cubes blue in icon-themes/galaxy/brand/intro.png
Is that intended?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #9 from Commit Notification 
 ---
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e1c89b12c94c06309032250da0ac7c84d3f96bb6

tdf#108928 - Branding for 6.0

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: icon-themes/galaxy instsetoo_native/inc_common setup_native/source

[Heiko Tietze]

 icon-themes/galaxy/brand/flat_logo.svg  |13147 
+-
 icon-themes/galaxy/brand/intro.png  |binary
 icon-themes/galaxy/brand/shell/about.svg| 9206 
---
 icon-themes/galaxy/brand_dev/intro.png  |binary
 instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp |binary
 instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp  |binary
 setup_native/source/packinfo/osxdndinstall.png  |binary
 7 files changed, 2457 insertions(+), 19896 deletions(-)

New commits:
commit e1c89b12c94c06309032250da0ac7c84d3f96bb6
Author: Heiko Tietze 
Date:   Tue Jul 4 16:36:23 2017 +0200

tdf#108928 - Branding for 6.0

Initial proposal for branding

Change-Id: I9fffe6b1c319505cd8a6b54a84ed585151a93122
Reviewed-on: https://gerrit.libreoffice.org/39507
Reviewed-by: Heiko Tietze 
Tested-by: Heiko Tietze 

diff --git a/icon-themes/galaxy/brand/flat_logo.svg 
b/icon-themes/galaxy/brand/flat_logo.svg
index 2dfb854fd250..028862d9ffaa 100644
--- a/icon-themes/galaxy/brand/flat_logo.svg
+++ b/icon-themes/galaxy/brand/flat_logo.svg
@@ -1,10751 +1,2396 @@
-
-
-http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd; [
-   http://ns.adobe.com/Extensibility/1.0/;>
-   http://ns.adobe.com/AdobeIllustrator/10.0/;>
-   http://ns.adobe.com/Graphs/1.0/;>
-   http://ns.adobe.com/Variables/1.0/;>
-   http://ns.adobe.com/ImageReplacement/1.0/;>
-   http://ns.adobe.com/SaveForWeb/1.0/;>
-   http://ns.adobe.com/GenericCustomNamespace/1.0/;>
-   http://ns.adobe.com/XPath/1.0/;>
-]>
-http://www.inkscape.org/namespaces/inkscape; 
xmlns:cc="http://creativecommons.org/ns#; 
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#; 
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd; 
xmlns:svg="http://www.w3.org/2000/svg; 
xmlns:dc="http://purl.org/dc/elements/1.1/; sodipodi:docname="flat_logo.svg" 
inkscape:version="0.48.4 r9939"
-xmlns="http://www.w3.org/2000/svg; 
xmlns:xlink="http://www.w3.org/1999/xlink; x="0px" y="0px" width="486px" 
height="80px"
-viewBox="0 0 486 80" enable-background="new 0 0 486 80" 
xml:space="preserve">
-
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   
-   https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108953] FILESAVE - SAVE AS cause Calc to hang for one particular file ,

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108953

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108956] New: EDITING: LibO unresponsive after HTML paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108956

Bug ID: 108956
   Summary: EDITING: LibO unresponsive after HTML paste
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
LibO unresponsive after HTML paste

Steps to Reproduce:
1. Open a random page (for example
https://bugs.documentfoundation.org/show_bug.cgi?id=108867)
2. Select everything CTRL+A and copy CTRL+C (I copied it from Firefox)
3. Paste it intro writer (CTRL+V)

Actual Results:  
LibO doesn't respond anymore

Expected Results:
Should work like LibO5400rc1


Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 6.0.0.0.alpha0+
Build ID: cac5c9f6081590b0548d3116bc4cd4a2509ec576
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-01_00:41:48
Locale: nl-NL (nl_NL); Calc: CL

but not with
Versie: 5.4.0.1 
Build ID: 962a9c4e2f56d1dbdd354b1becda28edd471f4f2
CPU-threads: 4; Besturingssysteem:Windows 6.2; UI-render: standaard; 
Locale: nl-NL (nl_NL); Calc: CL


User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:45.0) Gecko/20100101
Firefox/45.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108955] FILESAVE: RTF: Background colour lost after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108955

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:rtf, regression
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||xiscofa...@libreoffice.org
Version|6.0.0.0.alpha0+ Master  |5.4.0.0.alpha0+
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna   2017-01-03 07:49:43 (GMT)
committer   Miklos Vajna   2017-01-03 10:56:29
(GMT)
commit  a9e029ace41562e28e9242d63230ad1ca275f5d3 (patch)
tree605fee980e467c8a5896bdf5053fd7422865091a
parent  c9c5c94771f22919ec82351b3b9b3096af96a508 (diff)
tdf#104744 RTF import: fix unexpected zero para left margin wrt style dedup
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305:
writerfilter RTF import: override style properties like Word,
2014-06-17) for the details on style override in RTF.

Here the problem was that we added an unneeded "reset to 0" property, the
opposite situation that commit 657c6cc3acec0528209a8584b838cd6de581c437
(tdf#104228 RTF import: fix override of style left/right para margin,
2016-12-13) was fixing (there a "reset to 0" was missing).

Bisected with bibisect-linux-64-5.4

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108955] New: FILESAVE: RTF: Background colour lost after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108955

Bug ID: 108955
   Summary: FILESAVE: RTF: Background colour lost after roundtrip
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps:
1. Open attachment 60783 from bug 49179
2. Save it as .RTF
3. Open it again

Observed behaviour: Yellow background is gone

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #8 from Heiko Tietze  ---
Created attachment 134484
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134484=edit
Initial proposal - 2nd try

Added a white background to into.png, intro_dev.png, and osx*.png

Removed "The Document Foundation" from the logo (see comment at gerrit). That's
not correct from the branding POV and due to the fact that I have to vertically
center the text with the cubes the design becomes more boring.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 59977] EDITING: Copy table and paste as unformatted text not properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59977

--- Comment #5 from Telesto  ---
Repro with:
Version: 6.0.0.0.alpha0+
Build ID: cac5c9f6081590b0548d3116bc4cd4a2509ec576
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-07-01_00:41:48
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104643] FILESAVE: Frozen row is not saved in XLS or XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104643

--- Comment #13 from pavelz  ---
(In reply to Buovjaga from comment #12)
> Hmm, I think we should leave open, because you used gtk2 backend with the
> master build. I'm not sure, if we have a master build with gtk3 included.

Probably you are right, when SAL_USE_VCLPLUGIN=gtk is set the issue is not even
in 5.2.7.2-4.fc25 under wayland (gtk2 is used).

SAL_USE_VCLPLUGIN=gtk3 has no effect on master build, gtk2 is still used.
SAL_USE_VCLPLUGIN=gen works for both.

So from my lay view it looks like a problem with gtk3 under wayland, not sure
what the proper status should be set.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108949] FILEOPEN: Numbering is duplicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108949

--- Comment #3 from Xisco Faulí  ---
Same result with attachment 104064 from bug 81944

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108953] FILESAVE - SAVE AS cause Calc to hang for one particular file ,

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108953

--- Comment #1 from nv  ---
I would like to send the file so that the person anlyzing the problem can
recreate the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #14 from Buovjaga  ---
I checked with Áron and he asked me to use next instead of step. This is with
copying A10 while A4 is already in the clipboard:

385 if (IsClipboardSource())
(gdb) n
397 mxFormulaParserPool.reset();
(gdb) n
400 pExternalRefMgr.reset();
(gdb) n
402 ScAddInAsync::RemoveDocument( this );

So I understand the if is evaluated to false.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100156
Bug 100156 depends on bug 104643, which changed state.

Bug 104643 Summary: FILESAVE: Frozen row is not saved in XLS or XLSX
https://bugs.documentfoundation.org/show_bug.cgi?id=104643

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100156

Buovjaga  changed:

   What|Removed |Added

 Depends on||104643


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104643
[Bug 104643] FILESAVE: Frozen row is not saved in XLS or XLSX
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104643] FILESAVE: Frozen row is not saved in XLS or XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104643

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Blocks||100156
 Resolution|WORKSFORME  |---
 Ever confirmed|1   |0

--- Comment #12 from Buovjaga  ---
Hmm, I think we should leave open, because you used gtk2 backend with the
master build. I'm not sure, if we have a master build with gtk3 included.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100156
[Bug 100156] [META] Wayland-related bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:docx, regression
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna   2017-06-13 07:05:06 (GMT)
committer   Miklos Vajna   2017-06-13 09:30:43
(GMT)
commit  2a73e7d88c19cab69733a4f6433d8576856285ac (patch)
treed448994c4d8877a8cddccc7d4302bb3797b97264
parent  16265a1f84f0ac7c16beee6a3591653eaaa90323 (diff)
tdf#107618 DOCX export: fix missing header when doc ends with section
See commit b6e62dc0dc2b284c825f1182a67bb2f9259a30ce (tdf#106492 DOCX
export: fix duplicated section break at doc end, 2017-03-21) for the
context, this is one more case where it's not OK to suppress the two
section breaks at the end of a document, since the suppressed section
break is the one that provides the headers / footers.

Bisected with bibisect-linux64-6.0

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] New: FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Bug ID: 108954
   Summary: FILESAVE: DOCX: new line added every roundtrip
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps:
1. Open attachment 59921 from bug 48658
2. Save it as DOCX
3. Open the new file

Observed behaviour: A new line has been added to the end


[Bug found by office-interoperability-tools]

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108953] New: FILESAVE - SAVE AS cause Calc to hang for one particular file,

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108953

Bug ID: 108953
   Summary: FILESAVE - SAVE AS cause Calc to hang for one
particular file,
   Product: LibreOffice
   Version: 5.1.6.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: neelanshu_va...@yahoo.co.in

Description:
I have one file that I am not able to "save as" or "save".The file has three
sheets, one of the sheets gives problems while editing, saving. Librecalc just
hangs and I have to FORCE QUIT the application. One I deleted that problematic
sheet, I was able to save the file.
Editing issues - Even deleting rows or columns causes Calc to freeze and then I
have to Force Quit.

Steps to Reproduce:
1.Open the file
2.Click on SAVE AS
3.Give filename in the dialogue box and click to save.

4. For editing column choose Column 'H' of teh problematic Sheet or choose more
than 1000 rows to delete.

Actual Results:  
Librecalc freezes

Expected Results:
A new file should be created when save as is done. Edits such as delete
multiple(>1000) rows should get carried out. 


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/59.0.3071.115 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108944] FILEOPEN: DOCX: footnote separators missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108944

--- Comment #3 from Justin L  ---
Created attachment 134483
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134483=edit
Simple footnote.docx: just one footnote is not enough to show the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108782] Replace std::bind2nd() call with lambda

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108782

--- Comment #2 from Commit Notification 
 ---
Jochen Nitschke committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=db714f4d76cb71c1124eb2f4902a816168f6513b

make binary functors unary, related tdf#108782

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108782] Replace std::bind2nd() call with lambda

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108782

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104643] FILESAVE: Frozen row is not saved in XLS or XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104643

--- Comment #11 from pavelz  ---
(In reply to pavelz from comment #10)
> Cannot reproduce it more with the current version, so changing status to
> resolved.
> 
> Version: 5.2.7.2
> Build ID: 5.2.7.2-4.fc25
> CPU Threads: 2; OS Version: Linux 4.11; UI Render: default; VCL: gtk3; 
> Locale: cs-CZ (cs_CZ.UTF-8); Calc: group

Sorry, I was too quick, the issue is still present in 5.2.7.2-4.fc25, but it
only manifests under wayland session.

Leaving status as resolved, because it works in fresh master even under
wayland:

Version: 6.0.0.0.alpha0+
Build ID: 6e7300d1046a195068fa97a0d91a95f19cc5c056
CPU threads: 2; OS: Linux 4.11; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2017-07-03_23:43:13
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source include/dbaccess

[Jochen Nitschke]

 dbaccess/source/ui/browser/genericcontroller.cxx |   10 +-
 include/dbaccess/genericcontroller.hxx   |   22 +++---
 2 files changed, 20 insertions(+), 12 deletions(-)

New commits:
commit db714f4d76cb71c1124eb2f4902a816168f6513b
Author: Jochen Nitschke 
Date:   Tue Jul 4 12:23:19 2017 +0200

make binary functors unary, related tdf#108782

These functors were always used as unary functors with std::bind2nd.

This patch is a preparation of removal of deprecated
std::binary_function.

Change-Id: Ifd120227ab0a0db4c93dd56a9d46feb602b1ae4c
Reviewed-on: https://gerrit.libreoffice.org/39500
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/dbaccess/source/ui/browser/genericcontroller.cxx 
b/dbaccess/source/ui/browser/genericcontroller.cxx
index 5e5d83a5e8fd..6c0057e2eea8 100644
--- a/dbaccess/source/ui/browser/genericcontroller.cxx
+++ b/dbaccess/source/ui/browser/genericcontroller.cxx
@@ -506,7 +506,7 @@ bool OGenericUnoController::isFeatureSupported( sal_Int32 
_nId )
 SupportedFeatures::const_iterator aFeaturePos = std::find_if(
 m_aSupportedFeatures.begin(),
 m_aSupportedFeatures.end(),
-std::bind2nd( CompareFeatureById(), _nId )
+CompareFeatureById(_nId)
 );
 
 return ( m_aSupportedFeatures.end() != aFeaturePos && 
!aFeaturePos->first.isEmpty());
@@ -539,7 +539,7 @@ void OGenericUnoController::InvalidateFeature_Impl()
 SupportedFeatures::const_iterator aFeaturePos = std::find_if(
 m_aSupportedFeatures.begin(),
 m_aSupportedFeatures.end(),
-std::bind2nd( CompareFeatureById(), aNextFeature.nId )
+CompareFeatureById( aNextFeature.nId )
 );
 
 #if OSL_DEBUG_LEVEL > 0
@@ -575,7 +575,7 @@ void OGenericUnoController::ImplInvalidateFeature( 
sal_Int32 _nId, const Referen
 SupportedFeatures::const_iterator aFeaturePos = std::find_if(
 m_aSupportedFeatures.begin(),
 m_aSupportedFeatures.end(),
-std::bind2nd( CompareFeatureById(), _nId )
+CompareFeatureById( _nId )
 );
 OSL_ENSURE( aFeaturePos != m_aSupportedFeatures.end(), 
"OGenericUnoController::ImplInvalidateFeature: invalidating an unsupported 
feature is suspicious, at least!" );
 }
@@ -760,7 +760,7 @@ void OGenericUnoController::removeStatusListener(const 
Reference< XStatusListene
 m_aFeaturesToInvalidate.erase(
 std::remove_if(   m_aFeaturesToInvalidate.begin(),
 m_aFeaturesToInvalidate.end(),
-std::bind2nd(FindFeatureListener(),aListener))
+FindFeatureListener(aListener))
 ,m_aFeaturesToInvalidate.end());
 }
 
@@ -899,7 +899,7 @@ URL OGenericUnoController::getURLForId(sal_Int32 _nId) const
 SupportedFeatures::const_iterator aIter = std::find_if(
 m_aSupportedFeatures.begin(),
 m_aSupportedFeatures.end(),
-std::bind2nd( CompareFeatureById(), _nId )
+CompareFeatureById( _nId )
 );
 
 if ( m_aSupportedFeatures.end() != aIter && !aIter->first.isEmpty() )
diff --git a/include/dbaccess/genericcontroller.hxx 
b/include/dbaccess/genericcontroller.hxx
index a23dfa8d4f70..20bbc7688210 100644
--- a/include/dbaccess/genericcontroller.hxx
+++ b/include/dbaccess/genericcontroller.hxx
@@ -24,7 +24,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -177,12 +176,16 @@ namespace dbaui
 >   SupportedFeatures;
 
 
-struct CompareFeatureById : ::std::binary_function< 
SupportedFeatures::value_type, sal_Int32, bool >
+class CompareFeatureById
 {
+const sal_Int32 m_nId;
+public:
+CompareFeatureById(sal_Int32 _nId) : m_nId(_nId)
+{}
 
-bool operator()( const SupportedFeatures::value_type& _aType, 
sal_Int32 _nId ) const
+bool operator()( const SupportedFeatures::value_type& _aType ) const
 {
-return !!( _nId == _aType.second.nFeatureId );
+return m_nId == _aType.second.nFeatureId;
 }
 };
 
@@ -199,12 +202,17 @@ namespace dbaui
 typedef ::std::deque< FeatureListener > FeatureListeners;
 
 
-struct FindFeatureListener : ::std::binary_function< FeatureListener, 
css::uno::Reference< css::frame::XStatusListener >, bool >
+class FindFeatureListener
 {
+const css::uno::Reference< css::frame::XStatusListener >& m_xListener;
+public:
+FindFeatureListener(const css::uno::Reference< 
css::frame::XStatusListener >& _xListener)
+: m_xListener(_xListener)
+{}
 
-bool operator()( const FeatureListener& lhs, const 
css::uno::Reference< css::frame::XStatusListener >& rhs ) const
+bool operator()( const FeatureListener& lhs ) const
 {

[Libreoffice-commits] core.git: sc/source

[Jochen Nitschke]

 sc/source/core/tool/rangelst.cxx |   13 -
 1 file changed, 13 deletions(-)

New commits:
commit 27f61c4cfb88c23ef3c370921e6f9c186c602175
Author: Jochen Nitschke 
Date:   Tue Jul 4 11:35:29 2017 +0200

sc: remove trivial copy ctors for functors

The compiler will generate the same default copy ctors if needed.

Change-Id: I0029e2162ab7d3da9b0cd9bfcf8c06d55c59e2b7
Reviewed-on: https://gerrit.libreoffice.org/39497
Tested-by: Jochen Nitschke 
Reviewed-by: Noel Grandin 

diff --git a/sc/source/core/tool/rangelst.cxx b/sc/source/core/tool/rangelst.cxx
index cb5c8e831458..9ef8cfeea77d 100644
--- a/sc/source/core/tool/rangelst.cxx
+++ b/sc/source/core/tool/rangelst.cxx
@@ -42,7 +42,6 @@ class FindEnclosingRange
 {
 public:
 explicit FindEnclosingRange(const T& rTest) : mrTest(rTest) {}
-FindEnclosingRange(const FindEnclosingRange& r) : mrTest(r.mrTest) {}
 bool operator() (const ScRange* pRange) const
 {
 return pRange->In(mrTest);
@@ -56,7 +55,6 @@ class FindRangeIn
 {
 public:
 FindRangeIn(const T& rTest) : mrTest(rTest) {}
-FindRangeIn(const FindRangeIn& r) : mrTest(r.mrTest) {}
 bool operator() (const ScRange* pRange) const
 {
 return mrTest.In(*pRange);
@@ -70,7 +68,6 @@ class FindIntersectingRange
 {
 public:
 explicit FindIntersectingRange(const T& rTest) : mrTest(rTest) {}
-FindIntersectingRange(const FindIntersectingRange& r) : mrTest(r.mrTest) {}
 bool operator() (const ScRange* pRange) const
 {
 return pRange->Intersects(mrTest);
@@ -83,7 +80,6 @@ class AppendToList
 {
 public:
 explicit AppendToList(vector& rRanges) : mrRanges(rRanges) {}
-AppendToList(const AppendToList& r) : mrRanges(r.mrRanges) {}
 void operator() (const ScRange* p)
 {
 mrRanges.push_back(new ScRange(*p));
@@ -96,7 +92,6 @@ class CountCells
 {
 public:
 CountCells() : mnCellCount(0) {}
-CountCells(const CountCells& r) : mnCellCount(r.mnCellCount) {}
 
 void operator() (const ScRange* p)
 {
@@ -123,14 +118,6 @@ public:
 mcDelim(cDelim),
 mbFirst(true) {}
 
-FormatString(const FormatString& r) :
-mrStr(r.mrStr),
-mnFlags(r.mnFlags),
-mpDoc(r.mpDoc),
-meConv(r.meConv),
-mcDelim(r.mcDelim),
-mbFirst(r.mbFirst) {}
-
 void operator() (const ScRange* p)
 {
 OUString aStr(p->Format(mnFlags, mpDoc, meConv));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: avmedia/source

[Jochen Nitschke]

 avmedia/source/framework/mediaitem.cxx |   15 ---
 1 file changed, 15 deletions(-)

New commits:
commit 9a5769dd1b30b7aa369affa93e38bfffe972a300
Author: Jochen Nitschke 
Date:   Tue Jul 4 12:39:46 2017 +0200

avmedia: remove trivial copy ctor

Change-Id: I650067c981f2fd3582687ffd562a1f8057e49fc2
Reviewed-on: https://gerrit.libreoffice.org/39501
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/avmedia/source/framework/mediaitem.cxx 
b/avmedia/source/framework/mediaitem.cxx
index 831f4a90fe9e..6b54e8d43271 100644
--- a/avmedia/source/framework/mediaitem.cxx
+++ b/avmedia/source/framework/mediaitem.cxx
@@ -71,21 +71,6 @@ struct MediaItem::Impl
 , m_eZoom( css::media::ZoomLevel_NOT_AVAILABLE )
 {
 }
-Impl(Impl const& rOther)
-: m_URL( rOther.m_URL )
-, m_TempFileURL( rOther.m_TempFileURL )
-, m_Referer( rOther.m_Referer )
-, m_sMimeType( rOther.m_sMimeType )
-, m_nMaskSet( rOther.m_nMaskSet )
-, m_eState( rOther.m_eState )
-, m_fTime( rOther.m_fTime )
-, m_fDuration( rOther.m_fDuration )
-, m_nVolumeDB( rOther.m_nVolumeDB )
-, m_bLoop( rOther.m_bLoop )
-, m_bMute( rOther.m_bMute )
-, m_eZoom( rOther.m_eZoom )
-{
-}
 };
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #7 from Heiko Tietze  ---
(In reply to Regina Henschel from comment #6)
> What should be in file 6_about.svg? Currently the content is an empty group.

It is the background of the about dialog, which was the gray triangle thing.
Keep the file since I'm afraid it is accessed by code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 95287] 1000(?) images generated after turning on record changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95287

--- Comment #17 from Aron Boss  ---
Well, in the document is an image multiple times. There will be no crash - only
after adding notes in multiple layers by multiple writers- but there are
multiple instances of a image generated. They can become very numerous and
hence kill the machine because it takes a very, very, long time to process
hundreds of images. The copies are generated when logging the changes. The
exact trigger is not known to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - solenv/bin

[Stephan Bergmann]

 solenv/bin/assemble-flatpak.sh |  110 +
 1 file changed, 110 insertions(+)

New commits:
commit 4f3f3542b8925564a673b9d000aee03e3043f4e0
Author: Stephan Bergmann 
Date:   Tue Jul 4 17:09:16 2017 +0200

Break solenv/bin/assemble-flatpak.sh out of dev-tools flatpak/build.sh

,,,in preparation of moving to a flatpak-builder manifest.json approach

Change-Id: Ie9e90a85cc6e94ff7191161085c6e607512db0c4
(cherry picked from commit 19c13650c81ae7e0ad6cf0d7b8661f8440ee7892)
Reviewed-on: https://gerrit.libreoffice.org/39508
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/solenv/bin/assemble-flatpak.sh b/solenv/bin/assemble-flatpak.sh
new file mode 100755
index ..e73848b6e050
--- /dev/null
+++ b/solenv/bin/assemble-flatpak.sh
@@ -0,0 +1,110 @@
+#! /bin/bash
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# Assemble Flatpak app files and metadata under /app/, copying from the
+# installation tree generated by 'make distro-pack-install-strip' (at
+# $PREFIXDIR):
+
+set -e
+
+cp -r "${PREFIXDIR?}"/lib/libreoffice /app/
+
+## libreoffice-startcenter.desktop -> org.libreoffice.LibreOffice.desktop,
+## combining all libreoffice-*.desktop MimeType= lines:
+mkdir /app/share
+mkdir /app/share/applications
+my_mimetypes=$(awk -d 'BEGIN { FS="="; ORS=""; semi=0 }; \
+ /^MimeType=/ && length($2) \
+  { if (semi) print ";"; print $2; semi = match($2, ";$") == 0 }' \
+ "${PREFIXDIR?}"/share/applications/libreoffice-*.desktop)
+sed -e 's,^Exec=libreoffice,Exec=/app/libreoffice/program/soffice,' \
+ -e 's/^Icon=libreoffice-/Icon=org.libreoffice.LibreOffice-/' \
+ -e 's|^MimeType=.*$|MimeType='"$my_mimetypes"'|' \
+ "${PREFIXDIR?}"/share/applications/libreoffice-startcenter.desktop \
+ >/app/share/applications/org.libreoffice.LibreOffice.desktop
+
+## icons/hicolor/*/apps/libreoffice-startcenter.* ->
+## icons/hicolor/*/apps/org.libreoffice.LibreOffice-startcenter.*:
+mkdir /app/share/icons
+for i in "${PREFIXDIR?}"/share/icons/hicolor/*/apps/libreoffice-startcenter.*
+do
+ mkdir -p \
+  "$(dirname 
/app/share/icons/hicolor/"${i#"${PREFIXDIR?}"/share/icons/hicolor/}")"
+ cp -a "$i" \
+  "$(dirname 
/app/share/icons/hicolor/"${i#"${PREFIXDIR?}"/share/icons/hicolor/}")"/org.libreoffice.LibreOffice-startcenter."${i##*/apps/libreoffice-startcenter.}"
+done
+
+## org.libreoffice.LibreOffice.appdata.xml is manually derived from the various
+## inst/share/appdata/libreoffice-*.appdata.xml (at least recent GNOME Software
+## doesn't show more than five screenshots anyway, so restrict to one each from
+## the five libreoffice-*.appdata.xml: Writer, Calc, Impress, Draw, Base):
+mkdir /app/share/appdata
+cat <<\EOF >/app/share/appdata/org.libreoffice.LibreOffice.appdata.xml
+
+
+ org.libreoffice.LibreOffice.desktop
+ CC0-1.0
+ MPL-2.0
+ LibreOffice
+ The LibreOffice productivity suite
+ 
+  LibreOffice is a powerful office suite.  Its clean interface and
+  feature-rich tools help you unleash your creativity and enhance your
+  productivity.  LibreOffice includes several applications that make it the 
most
+  powerful Free and Open Source office suite on the market: Writer (word
+  processing), Calc (spreadsheets), Impress (presentations), Draw (vector
+  graphics and flowcharts), Base (databases), and Math (formula editing).
+  LibreOffice supports opening and saving into a wide variety of formats, so
+  you can easily share documents with users of other popular office suites
+  without worrying about compatibility.
+ 
+ http://www.libreoffice.org/discover/libreoffice/
+ https://bugs.documentfoundation.org/
+ https://donate.libreoffice.org/
+ https://wiki.documentfoundation.org/Faq
+ http://www.libreoffice.org/get-help/documentation/
+ https://wiki.documentfoundation.org/Translating_LibreOffice
+ 
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Writer-02-Table-of-Contents-Getting-Started-Guide-4-2.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Calc-02-exemple-ods.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Impress-01-Blank.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Draw-02-Tiger-fdo82219.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Screenshots/Base/Screenshot-78.png
+   
+  
+ 
+ The Document Foundation
+ libreoffice_at_lists.freedesktop.org
+ 
+  HiDpiIcon
+  HighContrast
+  ModernToolkit
+  UserDocs
+ 
+
+EOF
+
+## see 

[Libreoffice-bugs] [Bug 108949] FILEOPEN: Numbering is duplicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108949

--- Comment #2 from Xisco Faulí  ---
Same behaviour seen in attachment 56090 from bug 45182

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105861] Formulas shown in cells instead of results of formulas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105861

cmfe...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104643] FILESAVE: Frozen row is not saved in XLS or XLSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104643

pavelz  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #10 from pavelz  ---
Cannot reproduce it more with the current version, so changing status to
resolved.

Version: 5.2.7.2
Build ID: 5.2.7.2-4.fc25
CPU Threads: 2; OS Version: Linux 4.11; UI Render: default; VCL: gtk3; 
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105861] Formulas shown in cells instead of results of formulas

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105861

cmfe...@gmail.com changed:

   What|Removed |Added

 OS|Windows (All)   |Linux (All)

--- Comment #8 from cmfe...@gmail.com ---
Hi 
I use LibreOffice 5.2.6.2 on Debian Linux. 
When i try make a calculation like an sum, the cell with the total showed only
the formula.

Anybody know if there are the patch to resolved this error?.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95287] 1000(?) images generated after turning on record changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95287

--- Comment #16 from Buovjaga  ---
(In reply to Aron Boss from comment #15)
> Created attachment 134474 [details]
> Orginial documen. Will crash on demand after a recorded chang of text
> 
> Just change some text around an image and record it. The recording will
> place multiple entries of the images in the document and therefore it will
> become unresponsive.

I enabled Record changes and changed/typed text around the images on page 14
and 16. No crash.
I saved the file under a new name and the file size is about the same as the
original.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha0+
Build ID: 98befbb26217b0bf3f35354e418a355280c52cfc
CPU threads: 8; OS: Linux 4.11; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on June 29th 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108612] FORMATTING Comment boxes: dimensions and position lost at copy

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108612

--- Comment #13 from Buovjaga  ---
Ok, I launched LibO and then in a terminal

sudo gdb --pid `pgrep soffice`

I let it attach and then in the (gdb) prompt gave

break documen2.cxx:385

ie. this line:
https://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/data/documen2.cxx#n385

Then I gave c to continue. The breakpoint is hit the first time already when I
pasted A4 to E4. I continued and this is what I got when copying A10:

Thread 1 "soffice.bin" hit Breakpoint 1, ScDocument::~ScDocument
(this=0x6a45170, 
__in_chrg=) at
/home/user/libreoffice/sc/source/core/data/documen2.cxx:385
385 if (IsClipboardSource())
(gdb) step
ScDocument::IsClipboardSource (this=this@entry=0x6a45170)
at /home/user/libreoffice/sc/source/core/data/document.cxx:2544
2544{

It was a bit disturbing along the way that gdb grabbed my mouse click focus. I
managed to solve it with this: https://unix.stackexchange.com/a/40472

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108943] FILEOPEN: RTF: left margin on first paragraph' s line is ignored

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108943

--- Comment #2 from Xisco Faulí  ---
Same commit also affects attachment 56100 from bug 45192 being the table in
first page divided in 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - config_host.mk.in configure.ac external/Module_external.mk RepositoryExternal.mk Repository.mk xmlsecurity/inc xmlsecurity/Library_xsec_xmlse

[Miklos Vajna]

 Repository.mk |1 
 RepositoryExternal.mk |   28 ++
 config_host.mk.in |3 +
 configure.ac  |5 +
 external/Module_external.mk   |2 
 xmlsecurity/Library_xsec_xmlsec.mk|8 ++
 xmlsecurity/inc/xmlsec-wrapper.h  |2 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |9 +++
 8 files changed, 55 insertions(+), 3 deletions(-)

New commits:
commit 0d3f1a50d7bea8a1709e8ba065116d22547e48a4
Author: Miklos Vajna 
Date:   Wed Jun 21 21:59:11 2017 +0200

xmlsecurity: implement support for building against system-xmlsec

The only remaining difference is that in the system-xmlsec case we work
with the default key manager, not with the one that's only added by our
xmlsec patches.

This works for me for the uses I know of (see


for the motivation): signing and verifying of different signatures (bad
signature, good with non-trusted CA, good with trusted CA) with
software-based certificates all behave as expected.

Change-Id: If3f3e2b8373ab7397db3f98070a5a2ce51fa7c06
Reviewed-on: https://gerrit.libreoffice.org/39075
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 
Reviewed-on: https://gerrit.libreoffice.org/39274
Reviewed-by: Michael Stahl 
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/Repository.mk b/Repository.mk
index 8df60d4d7a51..184f5661ee10 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -933,7 +933,6 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
wizards_basicsrvtools \
wizards_basicsrvtutorials \
wizards_basicusr \
-   xmlsec \
$(if $(ENABLE_HEADLESS),, \
chart2_opengl_shader \
) \
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index eb0b3e2c9d40..8ce8555a7233 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -921,6 +921,34 @@ endef
 endif # SYSTEM_LIBXSLT
 
 
+ifneq ($(SYSTEM_XMLSEC),)
+
+define gb_LinkTarget__use_xmlsec
+$(call gb_LinkTarget_add_defs,$(1),\
+   -DSYSTEM_XMLSEC \
+)
+$(call gb_LinkTarget_set_include,$(1),\
+   $$(INCLUDE) \
+   $(XMLSEC_CFLAGS) \
+)
+$(call gb_LinkTarget_add_libs,$(1),$(XMLSEC_LIBS))
+
+endef
+
+gb_ExternalProject__use_xmlsec:=
+
+else # !SYSTEM_XMLSEC
+
+$(eval $(call gb_Helper_register_packages_for_install,ooo,\
+   xmlsec \
+))
+
+define gb_LinkTarget__use_xmlsec
+
+endef
+
+endif # SYSTEM_XMLSEC
+
 ifneq ($(SYSTEM_LIBLANGTAG),)
 
 define gb_LinkTarget__use_liblangtag
diff --git a/config_host.mk.in b/config_host.mk.in
index 880895e3c00f..60e1f781b377 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -561,6 +561,7 @@ export SYSTEM_VISIO=@SYSTEM_VISIO@
 export SYSTEM_WPD=@SYSTEM_WPD@
 export SYSTEM_WPG=@SYSTEM_WPG@
 export SYSTEM_WPS=@SYSTEM_WPS@
+export SYSTEM_XMLSEC=@SYSTEM_XMLSEC@
 export SYSTEM_ZLIB=@SYSTEM_ZLIB@
 export SYSTEM_ZMF=@SYSTEM_ZMF@
 export TARFILE_LOCATION=@TARFILE_LOCATION@
@@ -617,6 +618,8 @@ export XCODE_ARCHS=@XCODE_ARCHS@
 export XCODEBUILD_SDK=@XCODEBUILD_SDK@
 export XINERAMA_LINK=@XINERAMA_LINK@
 export XMLLINT=@XMLLINT@
+export XMLSEC_CFLAGS=$(gb_SPACE)@XMLSEC_CFLAGS@
+export XMLSEC_LIBS=$(gb_SPACE)@XMLSEC_LIBS@
 export XRANDR_CFLAGS=$(gb_SPACE)@XRANDR_CFLAGS@
 export XRANDR_LIBS=$(gb_SPACE)@XRANDR_LIBS@
 export XRENDER_CFLAGS=$(gb_SPACE)@XRENDER_CFLAGS@
diff --git a/configure.ac b/configure.ac
index 34610c473bb3..456c553f6c79 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7821,6 +7821,11 @@ dnl Check for system expat
 dnl ===
 libo_CHECK_SYSTEM_MODULE([expat], [EXPAT], [expat])
 
+dnl ===
+dnl Check for system xmlsec
+dnl ===
+libo_CHECK_SYSTEM_MODULE([xmlsec], [XMLSEC], [xmlsec1-nss >= 1.2.24])
+
 AC_MSG_CHECKING([whether to enable Embedded OpenType support])
 if test "$_os" != "WINNT" -a "$_os" != "Darwin" -a "$enable_eot" = "yes"; then
 ENABLE_EOT="TRUE"
diff --git a/external/Module_external.mk b/external/Module_external.mk
index 2de9c095feab..2f5373535f78 100644
--- a/external/Module_external.mk
+++ b/external/Module_external.mk
@@ -14,7 +14,7 @@ $(eval $(call gb_Module_add_moduledir,external,msc-externals))
 endif
 
 $(eval $(call gb_Module_add_moduledirs,external,\
-   $(if $(filter-out IOS,$(OS)),libxmlsec) \
+   $(if $(filter-out IOS,$(OS)),$(call 
gb_Helper_optional,XMLSEC,libxmlsec)) \
$(call 

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - xmlsecurity/inc xmlsecurity/source

[Miklos Vajna]

 xmlsecurity/inc/xmlsec-wrapper.h  |3 
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx |   39 ++
 xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.hxx |2 
 3 files changed, 29 insertions(+), 15 deletions(-)

New commits:
commit c349af53490d5e883ec791fb743092243c7ad46e
Author: Miklos Vajna 
Date:   Tue Jun 20 21:47:38 2017 +0200

xmlsecurity nss: adopt the private key of the signing certificate explicitly

xmlsec1-customkeymanage.patch.1 of our bundled xmlsec extends
xmlSecNssKeyDataX509VerifyAndExtractKey(), so that it calls
xmlSecNssPKIAdoptKey() for the private key of the signing certificate.
Make this explicit in xmlsecurity/ code, so we don't depend on the
patched xmlSecNssKeyDataX509VerifyAndExtractKey().

This is harmless for the patched xmlsec, but it prevents this error:


warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: 
keys.c:1246: xmlSecKeysMngrGetKey() '' 'xmlSecKeysMngrFindKey' 1 ' '

warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: 
xmldsig.c:790: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL'

warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: 
xmldsig.c:503: xmlSecDSigCtxProcessSignatureNode() '' 
'xmlSecDSigCtxProcessKeyInfoNode' 1 ' '

warn:xmlsecurity.xmlsec:26221:1:xmlsecurity/source/xmlsec/errorcallback.cxx:48: 
xmldsig.c:286: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxSignatureProcessNode' 1 ' '

when xmlsec is not patched.

(This is needed, but not enough to build against system xmlsec.)

Change-Id: I5d68a8be7aefcb529566213f9b9c2985eab6a80a
Reviewed-on: https://gerrit.libreoffice.org/39023
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 
Reviewed-on: https://gerrit.libreoffice.org/39273
Reviewed-by: Rene Engelhard 
Tested-by: Rene Engelhard 

diff --git a/xmlsecurity/inc/xmlsec-wrapper.h b/xmlsecurity/inc/xmlsec-wrapper.h
index 3d5c24b9b6f1..4a8a6554311b 100644
--- a/xmlsecurity/inc/xmlsec-wrapper.h
+++ b/xmlsecurity/inc/xmlsec-wrapper.h
@@ -40,6 +40,9 @@
 #include "xmlsec/xmlenc.h"
 #include "xmlsec/xmlsec.h"
 #include "xmlsec/xmltree.h"
+#ifdef XMLSEC_CRYPTO_NSS
+#include "xmlsec/nss/pkikeys.h"
+#endif
 
 #endif
 
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
index 959e62cc34e0..a5b29017d180 100644
--- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
@@ -474,6 +474,9 @@ Reference< XCertificate > 
SecurityEnvironment_NssImpl::getCertificate( const OUS
 }
 
 Sequence< Reference < XCertificate > > 
SecurityEnvironment_NssImpl::buildCertificatePath( const Reference< 
XCertificate >& begin ) {
+// Remember the signing certificate.
+m_xSigningCertificate = begin;
+
 const X509Certificate_NssImpl* xcert ;
 const CERTCertificate* cert ;
 CERTCertList* certChain ;
@@ -881,19 +884,8 @@ X509Certificate_NssImpl* NssPrivKeyToXCert( 
SECKEYPrivateKey* priKey )
 return xcert ;
 }
 
-
-/* Native methods */
 xmlSecKeysMngrPtr SecurityEnvironment_NssImpl::createKeysManager() {
 
-unsigned int i ;
-CERTCertDBHandle* handler = nullptr ;
-PK11SymKey* symKey = nullptr ;
-SECKEYPublicKey* pubKey = nullptr ;
-SECKEYPrivateKey* priKey = nullptr ;
-xmlSecKeysMngrPtr pKeysMngr = nullptr ;
-
-handler = m_pHandler;
-
 /*-
  * The following lines is based on the private version of xmlSec-NSS
  * crypto engine
@@ -905,14 +897,15 @@ xmlSecKeysMngrPtr 
SecurityEnvironment_NssImpl::createKeysManager() {
 for (CIT_SLOTS islots = m_Slots.begin();islots != m_Slots.end(); ++islots, 
++count)
 slots[count] = *islots;
 
-pKeysMngr = xmlSecNssAppliedKeysMngrCreate(slots, cSlots, handler ) ;
+xmlSecKeysMngrPtr pKeysMngr = xmlSecNssAppliedKeysMngrCreate(slots, 
cSlots, m_pHandler ) ;
 if( pKeysMngr == nullptr )
 throw RuntimeException() ;
 
 /*-
  * Adopt symmetric key into keys manager
  */
-for( i = 0 ; ( symKey = this->getSymKey( i ) ) != nullptr ; i ++ ) {
+PK11SymKey* symKey = nullptr ;
+for( unsigned int i = 0 ; ( symKey = this->getSymKey( i ) ) != nullptr ; i 
++ ) {
 if( xmlSecNssAppliedKeysMngrSymKeyLoad( pKeysMngr, symKey ) < 0 ) {
 throw RuntimeException() ;
 }
@@ -921,7 +914,8 @@ xmlSecKeysMngrPtr 
SecurityEnvironment_NssImpl::createKeysManager() {
 /*-
  * Adopt asymmetric public key into keys manager
  */
-for( i = 0 ; ( pubKey = this->getPubKey( i ) ) != nullptr ; i ++ ) {
+SECKEYPublicKey* pubKey = nullptr ;
+for( unsigned int i = 0 ; ( pubKey = this->getPubKey( i ) ) != nullptr ; i 
++ ) {
 

[Libreoffice-bugs] [Bug 108952] New: FILESAVE: DOCX: VML connectors lost after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108952

Bug ID: 108952
   Summary: FILESAVE: DOCX: VML connectors lost after roundtrip
   Product: LibreOffice
   Version: 4.4 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 134482
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134482=edit
sample

Steps:
1. Open attached document
2. Save it as .DOCX
3. Open the new document

Observed behaviour: Connector are lost

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group

and

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

not reproduced when saved to .DOC

console output:

TODO VMLExport::Commit(), unimplemented id: 135, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 6003403, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 771, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 4507, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 383, value: 4097, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 771, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 4507, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 383, value: 4097, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 771, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 4507, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 383, value: 4097, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 771, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 4507, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 383, value: 4097, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 3600, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 135, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 129, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 131, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 130, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 132, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 191, value: 262148, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 3600, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 135, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 129, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 131, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 130, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 132, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 191, value: 262148, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 327, value: 3600, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 135, value: 1, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 450, value: 16777215, data: [0,
(nil)]
TODO VMLExport::Commit(), unimplemented id: 449, value: 65536, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 129, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 131, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 130, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 132, value: 0, data: [0, (nil)]
TODO VMLExport::Commit(), unimplemented id: 

[Libreoffice-bugs] [Bug 108864] Debian-Repositories: W: Size of file is not what the server reported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108864

Andras Timar  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |tima...@gmail.com
   |desktop.org |

--- Comment #5 from Andras Timar  ---
I fixed https://www.collaboraoffice.com/code/ page, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108864] Debian-Repositories: W: Size of file is not what the server reported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108864

Aron Budea  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||tima...@gmail.com

--- Comment #4 from Aron Budea  ---
Okay, we can fix that (likely by using the first option), thanks for the
details.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108950] FILESAVE: Document is displayed in one page in MSO Word 2010 after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108950

--- Comment #2 from Xisco Faulí  ---
Same result with attachment 67935 from bug 55504

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108951] FILEOPEN: RTF: Custom bullets are displayed as standard bullets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108951

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:rtf, regression
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||xiscofa...@libreoffice.org
Version|6.0.0.0.alpha0+ Master  |5.4.0.0.alpha1+
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna   2017-05-16 06:34:40 (GMT)
committer   Miklos Vajna   2017-05-16 08:05:30
(GMT)
commit  f528f9499bd91b700c549575e88fa102cfffede9 (patch)
tree3f6f1f61de123f5329cfc175ebd3bbaffac98574
parent  6170d7c6063da89929577702189e4e4bfe564cc7 (diff)
tdf#106953 RTF import: fix missing paragraph left margin
See commit 3915bf2dc877d5f1140798e24933db0f21386a4a (tdf#95376 DOCX
import: fix incorrectly indented tab stops, 2016-01-26) for the various
sources that can determine the paragraph indentation.

In this case the problem was that too aggressive RTF style deduplication
removed a direct indent, which then meant a fallback to the ind-from-num
value, not to the ind-from-parastyle one.

Bisected with bibisect-linux-64-5.4

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108951] New: FILEOPEN: RTF: Custom bullets are displayed as standard bullets

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108951

Bug ID: 108951
   Summary: FILEOPEN: RTF: Custom bullets are displayed as
standard bullets
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 134481
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134481=edit
sample

Steps:
1. Open attached document

Observed behaviour: Custom bullets are displayed as standard bullets


[Bug found by office-interoperability-tools]

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: GSoC Week 5 special characters

[Akshay Deep]

Hi all, I'm working on recent characters dropdown which is almost complete.
https://gerrit.libreoffice.org/#/c/38944/

Regards,
Akshay
ᐧ

On Tue, Jul 4, 2017 at 9:53 PM, Akshay Deep 
wrote:

> Hi all, I'm working on recent characters dropdown which is almost complete.
> ᐧ
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

GSoC Week 5 special characters

[Akshay Deep]

Hi all, I'm working on recent characters dropdown which is almost complete.
ᐧ
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108950] FILESAVE: Document is displayed in one page in MSO Word 2010 after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108950

Xisco Faulí  changed:

   What|Removed |Added

 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58521] Endnotes always start on a new page, no option to have it directly at the end (non-ODF format)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=58521

Luke  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #12 from Luke  ---
Justin, 
I noticed you're working in this area. Is this something you could take a look
at?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108950] FILESAVE: Document is displayed in one page in MSO Word 2010 after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108950

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
Version|6.0.0.0.alpha0+ Master  |5.4.0.0.alpha0+
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Caolán McNamara 2017-04-27 14:25:20 (GMT)
committer   Caolán McNamara 2017-04-27 14:28:00
(GMT)
commit  3eda8234acf09cd5a31cdcde76f04631a51fcc37 (patch)
treef038f1554670fd2ca315c7213ae8d14e84bf5e85
parent  e31c535b574fc37e6961c5ce7bd507a30e6abff1 (diff)
Resolves: tdf#107411 LibreOffice hangs at RTF import time
regression from...

commit b993942622897fc64a1f7462189fa0463eb30e1c
Author: Caolán McNamara 
Date:   Sat Apr 1 16:43:04 2017 +0100

ubsan: use WrapTextMode_MAKE_FIXED_SIZE instead of -1 as unset flag

cause WrapTextMode_MAKE_FIXED_SIZE is >= 0

Bisected with bibisect-linux-64-5.4

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108950] New: FILESAVE: Document is displayed in one page in MSO Word 2010 after roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108950

Bug ID: 108950
   Summary: FILESAVE: Document is displayed in one page in MSO
Word 2010 after roundtrip
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 134480
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134480=edit
How it looks in MSO 2010

Steps:
1. Open attachment 98599 from bug 78370
2. Save it as .DOCX
3. Open it in MSO Word ( See the screenshot attached )

[Bug found by office-interoperability-tools]

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: 08f6f9dded1b142b858c455da03319abac691655
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108946] support for MET (.met) file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108946

--- Comment #3 from Buovjaga  ---
(In reply to krishna [:kr1shna] from comment #2)
> there was no link on wikipedia page.
> my assumption is wrong.
> the issue will be automatically closed after 30 days, is it correct. as of
> now i am unable to find os/2 metafile sample, i will update as soon as i
> found one.
> if you do have a link or file, please attach kindly.

https://cgit.freedesktop.org/libreoffice/core/plain/filter/qa/cppunit/data/met/pass/sample.met

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #6 from Regina Henschel  ---
What should be in file 6_about.svg? Currently the content is an empty group.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann]

 sc/source/filter/excel/xelink.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit b93abe9e72409b9bfec23c1090cfab0c6f9d
Author: Stephan Bergmann 
Date:   Tue Jul 4 17:15:55 2017 +0200

Fix "TODO: remove?"

...from previous 18713e10451b017784c7a1f783612074c5f84c42
"XclExpXct::StoreCell(Range) rToken param is unused", according to Eike's
replies at 

Change-Id: I525b428eb6853bc19be9f9c3cd08a206d031ed51

diff --git a/sc/source/filter/excel/xelink.cxx 
b/sc/source/filter/excel/xelink.cxx
index 1e51bcf160cc..b2e8c329f323 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -1866,11 +1866,6 @@ void XclExpSupbookBuffer::StoreCell( sal_uInt16 nFileId, 
const OUString& rTabNam
 nSupbookId = Append(xSupbook);
 }
 
-//TODO: remove?
-ScExternalRefCache::TokenRef pToken = pRefMgr->getSingleRefToken(nFileId, 
rTabName, rCell, nullptr, nullptr);
-if (!pToken.get())
-return;
-
 sal_uInt16 nSheetId = xSupbook->GetTabIndex(rTabName);
 if (nSheetId == EXC_NOTAB)
 // specified table name not found in this SUPBOOK.
@@ -1907,7 +1902,7 @@ void XclExpSupbookBuffer::StoreCellRange( sal_uInt16 
nFileId, const OUString& rT
 
 // If this is a multi-table range, get token for each table.
 using namespace ::formula;
-SCTAB aMatrixListSize = 0; //TODO: remove?
+SCTAB aMatrixListSize = 0;
 
 // This is a new'ed instance, so we must manage its life cycle here.
 ScExternalRefCache::TokenArrayRef pArray = 
pRefMgr->getDoubleRefTokens(nFileId, rTabName, rRange, nullptr);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102187] [META] Options dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102187
Bug 102187 depends on bug 108427, which changed state.

Bug 108427 Summary: Direct cursor: Add option to insert only spaces
https://bugs.documentfoundation.org/show_bug.cgi?id=108427

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108949] FILEOPEN: Numbering is duplicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108949

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||jl...@mail.com,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Justin Luth    2017-05-30 14:13:47 (GMT)
committer   Justin Luth    2017-06-09 05:35:18
(GMT)
commit  fdfdea4d5af51a68f2d497cc5c3359d74c385fd5 (patch)
tree04f33b8186ac602769a0495193a664f6faae1229
parent  691d1e90f62ce3f1930d3faf74af385d92f00d59 (diff)
tdf#82173 writerfilter: apply char properties to footnote
The char property values as defined in w:rPr were not connected
to the in-text footnote or endnote.

Bisected with bibisect-linux64-6.0

Adding Cc: to Justin Luth

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC Weekly Report 4 & 5: LibreOffice for Android - Gautam Prajapati

[Gautam Prajapati]

Hello,

During week 4, I completed the task of switching clang for Android
building. Link to the relevant patches:

   - https://gerrit.libreoffice.org/39127 - android: update configure.ac to
   support building only with NDK>=15
   - https://gerrit.libreoffice.org/39122 - android: update configure.ac
   for supporting Clang5.0
   - https://gerrit.libreoffice.org/39123 - android: Set clang as default
   compiler for building
   - https://gerrit.libreoffice.org/39125 - android: Remove GCC support for
   building

I completed the GSoC evaluations and moved on to my next task which will
add NSS support to LO Android.

During week 5, I explored NSS library and tried to build it on my system
separately. Then enabled the NSS building for Android in our build system.
There were a lot of errors while building which I'm trying to resolve one
by one.

Regards,
Gautam
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 108949] New: FILEOPEN: Numbering is duplicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108949

Bug ID: 108949
   Summary: FILEOPEN: Numbering is duplicated
   Product: LibreOffice
   Version: 6.0.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps:
1. Open attachment 103959 from bug 82107

Observed behaviour: Numbering is duplicated in page 2

[Bug found by office-interoperability-tools]

Reproduced in

Version: 6.0.0.0.alpha0+
Build ID: cb37c5f0f3de7b545231a53d46a5271058af76ad
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-23_06:55:41
Locale: es-ES (es_ES); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] dev-tools.git: flatpak/build.sh

[Stephan Bergmann]

 flatpak/build.sh |   96 +--
 1 file changed, 2 insertions(+), 94 deletions(-)

New commits:
commit 777b01d4d7ea0ca2a855e36e87d366b458b8bd56
Author: Stephan Bergmann 
Date:   Tue Jul 4 17:13:40 2017 +0200

Break core solenv/bin/assemble-flatpak.sh out of flatpak/build.sh

,,,in preparation of moving to a flatpak-builder manifest.json approach

(corresponding core commit is 19c13650c81ae7e0ad6cf0d7b8661f8440ee7892 
"Break
solenv/bin/assemble-flatpak.sh out of dev-tools flatpak/build.sh")

diff --git a/flatpak/build.sh b/flatpak/build.sh
index 5ff7b44..dc1fd8f 100755
--- a/flatpak/build.sh
+++ b/flatpak/build.sh
@@ -63,105 +63,13 @@ mkdir "${my_dir?}"/build
 flatpak build --build-dir="${my_dir?}"/build --share=network "${my_dir?}"/app \
  bash -c \
  '"${1?}"/lo/autogen.sh --prefix="${1?}"/inst --with-distro=LibreOfficeFlatpak 
\
-  && make && make distro-pack-install-strip' \
+  && make && make distro-pack-install-strip \
+  && make cmd cmd='\''$(SRCDIR)/solenv/bin/assemble-flatpak.sh'\' \
  bash "${my_dir?}"
 
 
 # 3  Assemble the app files and metadata:
 
-cp -r "${my_dir?}"/inst/lib/libreoffice "${my_dir?}"/app/files/
-## libreoffice-startcenter.desktop -> org.libreoffice.LibreOffice.desktop,
-## combining all libreoffice-*.desktop MimeType= lines:
-mkdir "${my_dir?}"/app/files/share
-mkdir "${my_dir?}"/app/files/share/applications
-my_mimetypes=$(awk -d 'BEGIN { FS="="; ORS=""; semi=0 }; \
- /^MimeType=/ && length($2) \
-  { if (semi) print ";"; print $2; semi = match($2, ";$") == 0 }' \
- "${my_dir?}"/inst/share/applications/libreoffice-*.desktop)
-sed -e 's,^Exec=libreoffice,Exec=/app/libreoffice/program/soffice,' \
- -e 's/^Icon=libreoffice-/Icon=org.libreoffice.LibreOffice-/' \
- -e 's|^MimeType=.*$|MimeType='"$my_mimetypes"'|' \
- "${my_dir?}"/inst/share/applications/libreoffice-startcenter.desktop \
- > 
"${my_dir?}"/app/files/share/applications/org.libreoffice.LibreOffice.desktop
-## icons/hicolor/*/apps/libreoffice-startcenter.* ->
-## icons/hicolor/*/apps/org.libreoffice.LibreOffice-startcenter.*:
-mkdir "${my_dir?}"/app/files/share/icons
-for i in "${my_dir?}"/inst/share/icons/hicolor/*/apps/libreoffice-startcenter.*
-do
- mkdir -p \
-  "$(dirname 
"${my_dir?}"/app/files/share/icons/hicolor/"${i#"${my_dir?}"/inst/share/icons/hicolor/}")"
- cp -a "$i" \
-  "$(dirname 
"${my_dir?}"/app/files/share/icons/hicolor/"${i#"${my_dir?}"/inst/share/icons/hicolor/}")"/org.libreoffice.LibreOffice-startcenter."${i##*/apps/libreoffice-startcenter.}"
-done
-## org.libreoffice.LibreOffice.appdata.xml is manually derived from the various
-## inst/share/appdata/libreoffice-*.appdata.xml (at least recent GNOME Software
-## doesn't show more than five screenshots anyway, so restrict to one each from
-## the five libreoffice-*.appdata.xml: Writer, Calc, Impress, Draw, Base):
-mkdir "${my_dir?}"/app/files/share/appdata
-cat <<\EOF > \
- "${my_dir?}"/app/files/share/appdata/org.libreoffice.LibreOffice.appdata.xml
-
-
- org.libreoffice.LibreOffice.desktop
- CC0-1.0
- MPL-2.0
- LibreOffice
- The LibreOffice productivity suite
- 
-  LibreOffice is a powerful office suite.  Its clean interface and
-  feature-rich tools help you unleash your creativity and enhance your
-  productivity.  LibreOffice includes several applications that make it the 
most
-  powerful Free and Open Source office suite on the market: Writer (word
-  processing), Calc (spreadsheets), Impress (presentations), Draw (vector
-  graphics and flowcharts), Base (databases), and Math (formula editing).
-  LibreOffice supports opening and saving into a wide variety of formats, so
-  you can easily share documents with users of other popular office suites
-  without worrying about compatibility.
- 
- http://www.libreoffice.org/discover/libreoffice/
- https://bugs.documentfoundation.org/
- https://donate.libreoffice.org/
- https://wiki.documentfoundation.org/Faq
- http://www.libreoffice.org/get-help/documentation/
- https://wiki.documentfoundation.org/Translating_LibreOffice
- 
-  
-   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Writer-02-Table-of-Contents-Getting-Started-Guide-4-2.png
-   
-  
-  
-   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Calc-02-exemple-ods.png
-   
-  
-  
-   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Impress-01-Blank.png
-   
-  
-  
-   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Draw-02-Tiger-fdo82219.png
-   
-  
-  
-   
http://www.libreoffice.org/assets/Uploads/Screenshots/Base/Screenshot-78.png
-   
-  
- 
- The Document Foundation
- libreoffice_at_lists.freedesktop.org
- 
-  HiDpiIcon
-  HighContrast
-  ModernToolkit
-  UserDocs
- 
-
-EOF
-## see 

[Libreoffice-commits] core.git: solenv/bin

[Stephan Bergmann]

 solenv/bin/assemble-flatpak.sh |  110 +
 1 file changed, 110 insertions(+)

New commits:
commit 19c13650c81ae7e0ad6cf0d7b8661f8440ee7892
Author: Stephan Bergmann 
Date:   Tue Jul 4 17:09:16 2017 +0200

Break solenv/bin/assemble-flatpak.sh out of dev-tools flatpak/build.sh

,,,in preparation of moving to a flatpak-builder manifest.json approach

Change-Id: Ie9e90a85cc6e94ff7191161085c6e607512db0c4

diff --git a/solenv/bin/assemble-flatpak.sh b/solenv/bin/assemble-flatpak.sh
new file mode 100755
index ..e73848b6e050
--- /dev/null
+++ b/solenv/bin/assemble-flatpak.sh
@@ -0,0 +1,110 @@
+#! /bin/bash
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# Assemble Flatpak app files and metadata under /app/, copying from the
+# installation tree generated by 'make distro-pack-install-strip' (at
+# $PREFIXDIR):
+
+set -e
+
+cp -r "${PREFIXDIR?}"/lib/libreoffice /app/
+
+## libreoffice-startcenter.desktop -> org.libreoffice.LibreOffice.desktop,
+## combining all libreoffice-*.desktop MimeType= lines:
+mkdir /app/share
+mkdir /app/share/applications
+my_mimetypes=$(awk -d 'BEGIN { FS="="; ORS=""; semi=0 }; \
+ /^MimeType=/ && length($2) \
+  { if (semi) print ";"; print $2; semi = match($2, ";$") == 0 }' \
+ "${PREFIXDIR?}"/share/applications/libreoffice-*.desktop)
+sed -e 's,^Exec=libreoffice,Exec=/app/libreoffice/program/soffice,' \
+ -e 's/^Icon=libreoffice-/Icon=org.libreoffice.LibreOffice-/' \
+ -e 's|^MimeType=.*$|MimeType='"$my_mimetypes"'|' \
+ "${PREFIXDIR?}"/share/applications/libreoffice-startcenter.desktop \
+ >/app/share/applications/org.libreoffice.LibreOffice.desktop
+
+## icons/hicolor/*/apps/libreoffice-startcenter.* ->
+## icons/hicolor/*/apps/org.libreoffice.LibreOffice-startcenter.*:
+mkdir /app/share/icons
+for i in "${PREFIXDIR?}"/share/icons/hicolor/*/apps/libreoffice-startcenter.*
+do
+ mkdir -p \
+  "$(dirname 
/app/share/icons/hicolor/"${i#"${PREFIXDIR?}"/share/icons/hicolor/}")"
+ cp -a "$i" \
+  "$(dirname 
/app/share/icons/hicolor/"${i#"${PREFIXDIR?}"/share/icons/hicolor/}")"/org.libreoffice.LibreOffice-startcenter."${i##*/apps/libreoffice-startcenter.}"
+done
+
+## org.libreoffice.LibreOffice.appdata.xml is manually derived from the various
+## inst/share/appdata/libreoffice-*.appdata.xml (at least recent GNOME Software
+## doesn't show more than five screenshots anyway, so restrict to one each from
+## the five libreoffice-*.appdata.xml: Writer, Calc, Impress, Draw, Base):
+mkdir /app/share/appdata
+cat <<\EOF >/app/share/appdata/org.libreoffice.LibreOffice.appdata.xml
+
+
+ org.libreoffice.LibreOffice.desktop
+ CC0-1.0
+ MPL-2.0
+ LibreOffice
+ The LibreOffice productivity suite
+ 
+  LibreOffice is a powerful office suite.  Its clean interface and
+  feature-rich tools help you unleash your creativity and enhance your
+  productivity.  LibreOffice includes several applications that make it the 
most
+  powerful Free and Open Source office suite on the market: Writer (word
+  processing), Calc (spreadsheets), Impress (presentations), Draw (vector
+  graphics and flowcharts), Base (databases), and Math (formula editing).
+  LibreOffice supports opening and saving into a wide variety of formats, so
+  you can easily share documents with users of other popular office suites
+  without worrying about compatibility.
+ 
+ http://www.libreoffice.org/discover/libreoffice/
+ https://bugs.documentfoundation.org/
+ https://donate.libreoffice.org/
+ https://wiki.documentfoundation.org/Faq
+ http://www.libreoffice.org/get-help/documentation/
+ https://wiki.documentfoundation.org/Translating_LibreOffice
+ 
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Writer-02-Table-of-Contents-Getting-Started-Guide-4-2.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Calc-02-exemple-ods.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Impress-01-Blank.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Discover/Screenshots/_resampled/ResizedImage400300-Draw-02-Tiger-fdo82219.png
+   
+  
+  
+   
http://www.libreoffice.org/assets/Uploads/Screenshots/Base/Screenshot-78.png
+   
+  
+ 
+ The Document Foundation
+ libreoffice_at_lists.freedesktop.org
+ 
+  HiDpiIcon
+  HighContrast
+  ModernToolkit
+  UserDocs
+ 
+
+EOF
+
+## see  for further places where build-finish would
+## look for data:
+## cp ... /app/share/dbus-1/services/
+## cp ... /app/share/gnome-shell/search-providers/
___

[Libreoffice-bugs] [Bug 108938] Search for "ss" finds "ss" and "ß"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108938

--- Comment #1 from Sophia Schroeder  ---
I don't see a problem here, this is intended behavior AFAIK.
But others with more insight should decide how to continue.
Erack, cloph maybe?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92871] Crash on export PDF/A XP SP3-SSE "SEH Exception: ILLEGAL INSTRUCTION"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92871

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108948] New: Crash using UNO java to show dialog and close document afterwards (vcl:: Window::SetWindowPeer())

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108948

Bug ID: 108948
   Summary: Crash using UNO java to show dialog and close document
afterwards (vcl::Window::SetWindowPeer())
   Product: LibreOffice
   Version: 5.2.7.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: sdk
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ms...@digithurst.de

Created attachment 134479
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134479=edit
Minimal Example Program

This bug was filed from the crash reporting server and is
br-bb006f30-81ad-485a-92f4-dbdbf103222d.
=

Crash occurs only on Windows.

I attached a short program which reproduces the crash.
Just open a quickstart.exe which accepts connections from UNO.
Start the program and repeatedly close the Dialog and afterwards the document.
The remote bridge does not crash on every try, but on every 2nd try at least on
my system and on those of my colleagues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107340] Undo label shows "Delete $1" after deleting text with Track Changes set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107340

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107340] Undo label shows "Delete $1" after deleting text with Track Changes set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107340

--- Comment #2 from Commit Notification 
 ---
Rosemary Sebastian committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe25f95c3de542f15f6043c85f7385cd7569f237

tdf#107340 - Incorrect undo label with Track Changes set

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 108928] Branding for 6.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108928

--- Comment #5 from Heiko Tietze  ---
Created attachment 134478
  --> https://bugs.documentfoundation.org/attachment.cgi?id=134478=edit
Initial proposal

Submitted the patch https://gerrit.libreoffice.org/39507 with the included
artwork. 
_Banner.fodg: Draw source for Banner.bmp
_Image.fodg: Draw source for Image.png
_intro.fodg: Draw source for brand/intro.png and brand_dev/intro.png
_osxdndinstall.fodg: Draw source for osxdndinstall.png

Windows installer files Banner.bmp/Image.png keep the 5.0 style. I had to
simulate the realistic shadows by gradients. And turned the dark into bright.
No idea if that looks good. The into.png and osxdndinstall.png are based on
Regina's cubes while the about.png uses only small hexagons and since
ungrouping breaks everything I used my proposal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sw/source

[Rosemary Sebastian]

 sw/source/core/doc/DocumentContentOperationsManager.cxx |4 ++-
 sw/source/core/inc/UndoRedline.hxx  |5 
 sw/source/core/undo/unredln.cxx |   18 
 3 files changed, 26 insertions(+), 1 deletion(-)

New commits:
commit fe25f95c3de542f15f6043c85f7385cd7569f237
Author: Rosemary Sebastian 
Date:   Mon Jul 3 17:18:39 2017 +0530

tdf#107340 - Incorrect undo label with Track Changes set

Override the GetRewriter() function for the class SwUndoRedlineDelete

Change-Id: I4f7080d9d8eb79757e3e915b51f157bee29e9334
Reviewed-on: https://gerrit.libreoffice.org/39472
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index f934965cb3b9..362d6c8efc02 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -3556,8 +3556,10 @@ bool 
DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl( SwPaM & rPa
 m_rDoc.getIDocumentRedlineAccess().SetRedlineFlags(
 RedlineFlags::On | RedlineFlags::ShowInsert | 
RedlineFlags::ShowDelete );
 
-m_rDoc.GetIDocumentUndoRedo().StartUndo( SwUndoId::DELETE, nullptr 
);
 pUndo = new SwUndoRedlineDelete( rPam, SwUndoId::DELETE );
+const SwRewriter aRewriter = pUndo->GetRewriter();
+const SwRewriter* const pRewriter = 
+m_rDoc.GetIDocumentUndoRedo().StartUndo( SwUndoId::DELETE, 
pRewriter );
 m_rDoc.GetIDocumentUndoRedo().AppendUndo( pUndo );
 }
 
diff --git a/sw/source/core/inc/UndoRedline.hxx 
b/sw/source/core/inc/UndoRedline.hxx
index 8a62b33937a5..8cf4e63f3f57 100644
--- a/sw/source/core/inc/UndoRedline.hxx
+++ b/sw/source/core/inc/UndoRedline.hxx
@@ -56,17 +56,22 @@ class SwUndoRedlineDelete : public SwUndoRedline
 bool bIsDelim : 1;
 bool bIsBackspace : 1;
 
+OUString m_sRedlineText;
+
 virtual void UndoRedlineImpl(SwDoc & rDoc, SwPaM & rPam) override;
 virtual void RedoRedlineImpl(SwDoc & rDoc, SwPaM & rPam) override;
 
 public:
 SwUndoRedlineDelete( const SwPaM& rRange, SwUndoId nUserId );
+virtual SwRewriter GetRewriter() const override;
 
 bool CanGrouping( const SwUndoRedlineDelete& rPrev );
 
 // SwUndoTableCpyTable needs this information:
 long NodeDiff() const { return nSttNode - nEndNode; }
 sal_Int32 ContentStart() const { return nSttContent; }
+
+void SetRedlineText(const OUString & rText);
 };
 
 class SwUndoRedlineSort : public SwUndoRedline
diff --git a/sw/source/core/undo/unredln.cxx b/sw/source/core/undo/unredln.cxx
index 2f9cd4f49b87..2f08ed55d893 100644
--- a/sw/source/core/undo/unredln.cxx
+++ b/sw/source/core/undo/unredln.cxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -146,6 +147,7 @@ SwUndoRedlineDelete::SwUndoRedlineDelete( const SwPaM& 
rRange, SwUndoId nUsrId )
 bCanGroup( false ), bIsDelim( false ), bIsBackspace( false )
 {
 const SwTextNode* pTNd;
+SetRedlineText(rRange.GetText());
 if( SwUndoId::DELETE == mnUserId &&
 nSttNode == nEndNode && nSttContent + 1 == nEndContent &&
 nullptr != (pTNd = rRange.GetNode().GetTextNode()) )
@@ -163,6 +165,22 @@ SwUndoRedlineDelete::SwUndoRedlineDelete( const SwPaM& 
rRange, SwUndoId nUsrId )
 bCacheComment = false;
 }
 
+SwRewriter SwUndoRedlineDelete::GetRewriter() const
+{
+SwRewriter aResult;
+OUString aStr = m_sRedlineText;
+aStr = DenoteSpecialCharacters(aStr);
+aStr = ShortenString(aStr, nUndoStringLength, SwResId(STR_LDOTS));
+aResult.AddRule(UndoArg1, aStr);
+return aResult;
+}
+
+
+void SwUndoRedlineDelete::SetRedlineText(const OUString & rText)
+{
+m_sRedlineText = rText;
+}
+
 void SwUndoRedlineDelete::UndoRedlineImpl(SwDoc & rDoc, SwPaM & rPam)
 {
 rDoc.getIDocumentRedlineAccess().DeleteRedline(rPam, true, USHRT_MAX);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108946] support for MET (.met) file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108946

--- Comment #2 from krishna [:kr1shna]  ---
there was no link on wikipedia page.
my assumption is wrong.
the issue will be automatically closed after 30 days, is it correct. as of now
i am unable to find os/2 metafile sample, i will update as soon as i found one.
if you do have a link or file, please attach kindly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 105831] UI enhancement: Add a donate button in Help menu / About box / elsewhere

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105831

--- Comment #9 from Eike Rathke  ---
The legal aspect is one, but a company who paid for migration and support
probably would not want that menu entry..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise