[Libreoffice-bugs] [Bug 113201] Charts invisible or transparent
https://bugs.documentfoundation.org/show_bug.cgi?id=113201 --- Comment #5 from Mohamed--- Sorry for the late reply. The issue is not reproduced, I was able to draw and display the graph properly with the following environment including Wayland running on Ubuntu: • Ubuntu 17.10 x64-bits • LibreOffice: Version: 5.4.2.2 Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4 CPU threads: 1; OS: Linux 4.13; UI render: default; VCL: gtk2; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/filtask.cxx | 131 ucb/source/ucp/file/filtask.hxx | 27 +++- 2 files changed, 67 insertions(+), 91 deletions(-) New commits: commit eb9525a6aedb05dbb98c7d37abf05abcbfea4e48 Author: Julien NabetDate: Thu Oct 26 22:44:43 2017 +0200 Replace lists by vectors in filtask (ucb) Change-Id: I5b4359727ebf58bc121325d490e63f2c919dd7ab Reviewed-on: https://gerrit.libreoffice.org/43921 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx index 403e8fc0bd5d..d81ecd6b9992 100644 --- a/ucb/source/ucp/file/filtask.cxx +++ b/ucb/source/ucp/file/filtask.cxx @@ -538,9 +538,9 @@ TaskManager::registerNotifier( const OUString& aUnqPath, Notifier* pNotifier ) if( ! it->second.notifier ) it->second.notifier = new NotifierList; -std::list< Notifier* >& nlist = *( it->second.notifier ); +std::vector< Notifier* >& nlist = *( it->second.notifier ); -std::list ::iterator it1 = nlist.begin(); +std::vector ::iterator it1 = nlist.begin(); while( it1 != nlist.end() ) // Every "Notifier" only once { if( *it1 == pNotifier ) return; @@ -559,7 +559,7 @@ TaskManager::deregisterNotifier( const OUString& aUnqPath,Notifier* pNotifier ) if( it == m_aContent.end() ) return; -it->second.notifier->remove( pNotifier ); +it->second.notifier->erase(std::remove(it->second.notifier->begin(), it->second.notifier->end(), pNotifier), it->second.notifier->end()); if( it->second.notifier->empty() ) m_aContent.erase( it ); @@ -1991,16 +1991,10 @@ void SAL_CALL TaskManager::insertDefaultProperties( const OUString& aUnqPath ) PropertySet& properties = *(it->second.properties); bool ContentNotDefau = properties.find( ContentTProperty ) != properties.end(); -TaskManager::PropertySet::iterator it1 = m_aDefaultProperties.begin(); -while( it1 != m_aDefaultProperties.end() ) +for (auto const& defaultprop : m_aDefaultProperties) { -if( ContentNotDefau && it1->getPropertyName() == ContentType ) -{ -// No insertion -} -else -properties.insert( *it1 ); -++it1; +if( !ContentNotDefau || defaultprop.getPropertyName() != ContentType ) +properties.insert( defaultprop ); } } @@ -2610,25 +2604,22 @@ TaskManager::getv( // EventListener -std::list< ContentEventNotifier* >* SAL_CALL +std::vector< ContentEventNotifier* >* SAL_CALL TaskManager::getContentEventListeners( const OUString& aName ) { -std::list< ContentEventNotifier* >* p = new std::list< ContentEventNotifier* >; -std::list< ContentEventNotifier* >& listeners = *p; +std::vector< ContentEventNotifier* >* p = new std::vector< ContentEventNotifier* >; +std::vector< ContentEventNotifier* >& listeners = *p; { osl::MutexGuard aGuard( m_aMutex ); TaskManager::ContentMap::iterator it = m_aContent.find( aName ); if( it != m_aContent.end() && it->second.notifier ) { -std::list & listOfNotifiers = *( it->second.notifier ); -std::list ::iterator it1 = listOfNotifiers.begin(); -while( it1 != listOfNotifiers.end() ) +std::vector & listOfNotifiers = *( it->second.notifier ); +for (auto const& pointer : listOfNotifiers) { -Notifier* pointer = *it1; ContentEventNotifier* notifier = pointer->cCEL(); if( notifier ) listeners.push_back( notifier ); -++it1; } } } @@ -2636,25 +2627,22 @@ TaskManager::getContentEventListeners( const OUString& aName ) } -std::list< ContentEventNotifier* >* SAL_CALL +std::vector< ContentEventNotifier* >* SAL_CALL TaskManager::getContentDeletedEventListeners( const OUString& aName ) { -std::list< ContentEventNotifier* >* p = new std::list< ContentEventNotifier* >; -std::list< ContentEventNotifier* >& listeners = *p; +std::vector< ContentEventNotifier* >* p = new std::vector< ContentEventNotifier* >; +std::vector< ContentEventNotifier* >& listeners = *p; { osl::MutexGuard aGuard( m_aMutex ); TaskManager::ContentMap::iterator it = m_aContent.find( aName ); if( it != m_aContent.end() && it->second.notifier ) { -std::list & listOfNotifiers = *( it->second.notifier ); -std::list ::iterator it1 = listOfNotifiers.begin(); -while( it1 != listOfNotifiers.end() ) +std::vector & listOfNotifiers = *( it->second.notifier ); +for (auto const& pointer : listOfNotifiers) { -Notifier*
[Libreoffice-commits] core.git: filter/source sw/qa
filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl |2 +- sw/qa/extras/uiwriter/uiwriter.cxx|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 21fe5ef04dbea6b620e45453b8567f32ebd8526f Author: Andrea GelminiDate: Thu Oct 26 16:46:37 2017 +0200 Fix typos Change-Id: I96f64b7c259f04a67684bb699ea3cc43b68e40fa Reviewed-on: https://gerrit.libreoffice.org/43913 Reviewed-by: Julien Nabet Tested-by: Julien Nabet diff --git a/filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl b/filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl index 6a1b01078eeb..dc378058ca8f 100644 --- a/filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl +++ b/filter/source/xslt/import/spreadsheetml/spreadsheetml2ooo.xsl @@ -4327,7 +4327,7 @@ + but set on paragraph properties not cell paragraphs --> fix diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx b/sw/qa/extras/uiwriter/uiwriter.cxx index f77f603658e0..f1ba4ef19960 100644 --- a/sw/qa/extras/uiwriter/uiwriter.cxx +++ b/sw/qa/extras/uiwriter/uiwriter.cxx @@ -5360,7 +5360,7 @@ void SwUiWriterTest::testTdf113445() // Make sure that page 2 is on the right hand side of page 1, not below it. CPPUNIT_ASSERT_GREATER(nPage1Left, nPage2Left); -// Insert a new paragaph at the start of the document. +// Insert a new paragraph at the start of the document. SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell(); pWrtShell->SttDoc(); pWrtShell->SplitNode(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: ucb/source
ucb/source/core/ucbstore.cxx | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) New commits: commit 98895a5fd21125e41c423d3af318d9f082e83df4 Author: Julien NabetDate: Thu Oct 26 22:59:32 2017 +0200 Replace list by vector in ucbstore (ucb) Change-Id: I1ff394ecd1fe805d671d666d8bc2522c33c40b50 Reviewed-on: https://gerrit.libreoffice.org/43922 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/ucb/source/core/ucbstore.cxx b/ucb/source/core/ucbstore.cxx index 62e154b9553c..6c2cbeaad3c8 100644 --- a/ucb/source/core/ucbstore.cxx +++ b/ucb/source/core/ucbstore.cxx @@ -1890,8 +1890,7 @@ void SAL_CALL PersistentPropertySet::setPropertyValues( { const PropertyValue* pNewValues = aProps.getConstArray(); -typedef std::list< PropertyChangeEvent > Events; -Events aEvents; +std::vector< PropertyChangeEvent > aEvents; OUString aFullPropNamePrefix( getFullKey() ); aFullPropNamePrefix += "/"; @@ -1980,13 +1979,9 @@ void SAL_CALL PersistentPropertySet::setPropertyValues( if ( m_pImpl->m_pPropertyChangeListeners ) { // Notify property changes. -Events::const_iterator it = aEvents.begin(); -Events::const_iterator end = aEvents.end(); - -while ( it != end ) +for (auto const& event : aEvents) { -notifyPropertyChangeEvent( *it ); -++it; +notifyPropertyChangeEvent( event ); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106703] Poor Performance on macOS 10.12.3
https://bugs.documentfoundation.org/show_bug.cgi?id=106703 --- Comment #2 from Ivan--- I confirm this bug with 5.4.2 and 5.3.6. It's very slow with draw too. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113454] Mouse pointer/ arrow misses the buttons by millimeters
https://bugs.documentfoundation.org/show_bug.cgi?id=113454 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Component|LibreOffice |Android Viewer Product|LibreOffice Online |LibreOffice --- Comment #2 from Aron Budea --- And I assume the component is Android as well, then. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 34438] [feature request, FORMATTING] group selection does not work with raster images
https://bugs.documentfoundation.org/show_bug.cgi?id=34438 Aron Budeachanged: What|Removed |Added CC||barry.scriv...@hotmail.com --- Comment #24 from Aron Budea --- *** Bug 113461 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113461] Grouping does not work because cannot multiple select
https://bugs.documentfoundation.org/show_bug.cgi?id=113461 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |DUPLICATE --- Comment #1 from Aron Budea --- Yes, this is a long-time missing feature. *** This bug has been marked as a duplicate of bug 34438 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - connectivity/java connectivity/prj scp2/source
connectivity/java/dbtools/build.xml | 249 + connectivity/java/dbtools/makefile.mk | 41 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/comphelper/CompHelper.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/comphelper/OArrayEnumeration.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OCatalog.java |7 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OColumn.java | 13 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OColumnContainer.java | 15 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OContainer.java | 15 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/ODescriptor.java | 11 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OIndexColumn.java | 11 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OIndexContainer.java | 15 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OKey.java | 13 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OKeyColumnContainer.java |9 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OKeyContainer.java | 13 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/OTable.java |7 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/SqlTableHelper.java | 13 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxColumnDescriptor.java | 11 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxDescriptorContainer.java | 11 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxIndexColumnDescriptorContainer.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxKeyColumnDescriptor.java |9 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxKeyColumnDescriptorContainer.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/sdbcx/descriptors/SdbcxKeyDescriptorContainer.java |5 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/ComposeRule.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/DBTypeConversion.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/DbTools.java |7 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/ISQLStatementHelper.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/MapToXNameAccessAdapter.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/ORowSetValue.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/Osl.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/PropertyIds.java |2 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/SharedResources.java |6 connectivity/java/dbtools/src/org/apache/openoffice/comp/sdbc/dbtools/util/StandardSQLState.java |2 connectivity/java/sdbc_postgresql/build.xml | 11 connectivity/java/sdbc_postgresql/src/com/sun/star/sdbcx/comp/postgresql/DatabaseMetaDataResultSet.java | 481 ++ connectivity/java/sdbc_postgresql/src/com/sun/star/sdbcx/comp/postgresql/PostgresqlCatalog.java |7
[Libreoffice-commits] core.git: i18npool/inc i18npool/source i18npool/util
i18npool/inc/localedata.hxx |9 +++-- i18npool/source/localedata/localedata.cxx | 46 +- i18npool/util/i18npool.component |1 3 files changed, 52 insertions(+), 4 deletions(-) New commits: commit ba9f44d6ee560bbba09834b1070d19ec62d35783 Author: Eike RathkeDate: Thu Oct 26 21:34:17 2017 +0200 Implement LocaleData2, XLocaleData5, LocaleDataItem2, tdf#81671 Change-Id: Idba5a30bc44c7b2bd951f954ea3bfd048b022660 Reviewed-on: https://gerrit.libreoffice.org/43920 Tested-by: Jenkins Reviewed-by: Eike Rathke diff --git a/i18npool/inc/localedata.hxx b/i18npool/inc/localedata.hxx index c3aa6cf57d2c..4a83d44375b2 100644 --- a/i18npool/inc/localedata.hxx +++ b/i18npool/inc/localedata.hxx @@ -23,7 +23,7 @@ #include -#include +#include #include @@ -35,7 +35,7 @@ #include #include #include -#include +#include #include #include #include @@ -61,7 +61,7 @@ namespace i18npool { class LocaleDataImpl : public cppu::WeakImplHelper < -css::i18n::XLocaleData4, +css::i18n::XLocaleData5, css::lang::XServiceInfo > { @@ -108,6 +108,9 @@ public: // XLocaleData4 virtual css::uno::Sequence< OUString > SAL_CALL getDateAcceptancePatterns( const css::lang::Locale& rLocale ) override; +// XLocaleData5 +virtual css::i18n::LocaleDataItem2 SAL_CALL getLocaleItem2( const css::lang::Locale& rLocale ) override; + // following methods are used by indexentry service /// @throws css::uno::RuntimeException css::uno::Sequence< OUString > SAL_CALL getIndexAlgorithm( const css::lang::Locale& rLocale ); diff --git a/i18npool/source/localedata/localedata.cxx b/i18npool/source/localedata/localedata.cxx index 500a9408136e..e84f2b6282e7 100644 --- a/i18npool/source/localedata/localedata.cxx +++ b/i18npool/source/localedata/localedata.cxx @@ -423,6 +423,47 @@ LocaleDataImpl::getLocaleItem( const Locale& rLocale ) } } + +LocaleDataItem2 SAL_CALL +LocaleDataImpl::getLocaleItem2( const Locale& rLocale ) +{ +MyFunc_Type func = reinterpret_cast(getFunctionSymbol( rLocale, "getLocaleItem" )); + +if ( func ) { +sal_Int16 dataItemCount = 0; +sal_Unicode **dataItem = func(dataItemCount); + +assert(dataItemCount >= 18); + +LocaleDataItem2 item( +dataItem[0], +dataItem[1], +dataItem[2], +dataItem[3], +dataItem[4], +dataItem[5], +dataItem[6], +dataItem[7], +dataItem[8], +dataItem[9], +dataItem[10], +dataItem[11], +dataItem[12], +dataItem[13], +dataItem[14], +dataItem[15], +dataItem[16], +dataItem[17], +dataItemCount >= 19 ? dataItem[18] : OUString() +); +return item; +} +else { +LocaleDataItem2 item1; +return item1; +} +} + #ifndef DISABLE_DYNLOADING extern "C" { static void SAL_CALL thisModule() {} } @@ -1560,7 +1601,10 @@ sal_Bool SAL_CALL LocaleDataImpl::supportsService(const OUString& rServiceName) Sequence< OUString > SAL_CALL LocaleDataImpl::getSupportedServiceNames() { -Sequence< OUString > aRet { "com.sun.star.i18n.LocaleData" }; +Sequence< OUString > aRet { +"com.sun.star.i18n.LocaleData", +"com.sun.star.i18n.LocaleData2" +}; return aRet; } diff --git a/i18npool/util/i18npool.component b/i18npool/util/i18npool.component index 1b74fd736f54..3598ffa8b781 100644 --- a/i18npool/util/i18npool.component +++ b/i18npool/util/i18npool.component @@ -128,6 +128,7 @@ + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 112795] UI Buttons misalignment after error message
https://bugs.documentfoundation.org/show_bug.cgi?id=112795 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- I can't reproduce it in Version: 6.0.0.0.alpha1+ Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); Calc: group Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113040] UI Cannot cancel customize master toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=113040 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |WORKSFORME --- Comment #3 from Xisco Faulí --- The customize dialog has been reworked in 6.0 and now it's not possible to change the style. Well, at least I couldn't... but you're free to try it yourself with a daily build Closing as RESOLVED WORKSFORME. Change it back to UNCONFIRMED if there's a way to reproduce it in master. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113180] Style based Heading numbering broken or unusable
https://bugs.documentfoundation.org/show_bug.cgi?id=113180 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113175] Full Screen command does not operate properly.
https://bugs.documentfoundation.org/show_bug.cgi?id=113175 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Could you please try to reproduce it with version 5.4.2 of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113471] No digital certificates in menu after thorough reading from token and entering pin
https://bugs.documentfoundation.org/show_bug.cgi?id=113471 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113114] flatpak: Gtk-Message: Failed to load module "pk-gtk-module"
https://bugs.documentfoundation.org/show_bug.cgi?id=113114 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Do you get the same message using a version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113471] New: No digital certificates in menu after thorough reading from token and entering pin
https://bugs.documentfoundation.org/show_bug.cgi?id=113471 Bug ID: 113471 Summary: No digital certificates in menu after thorough reading from token and entering pin Product: LibreOffice Version: 5.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephan.ra...@gmail.com Description: No matter how I try to sign just an odt document or pdf the menu stays empty even though the token with the signature shows reading and LibreOffice asks for pin code every time Steps to Reproduce: 1. Plug in the token 2. Open LibreOffice 3. Create document 4. Save the document 5. File -> Digital Signatures 6. Sign document 7. Enter pin Actual Results: The list with digital certificates still empty Expected Results: List with the certificates on the token like in Firefox or Thunderbird Reproducible: Always User Profile Reset: No Additional Info: I've tried for many versions now and never had luck to see how it should work. I could test further yet I don't know how. Версия: 5.1.6.2 Build ID: 1:5.1.6~rc2-0ubuntu1~xenial2 Нишки в ЦП: 4; Версия на ОС: Linux 4.4; Рендиране на ПИ: по подразбиране; Локал: bg-BG (bg_BG.UTF-8); Calc: group User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113327] UI A vertical line appears in media player timer
https://bugs.documentfoundation.org/show_bug.cgi?id=113327 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112919] Don' t allowed to insert numbering and bullets inside the forms
https://bugs.documentfoundation.org/show_bug.cgi?id=112919 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |NOTABUG --- Comment #1 from Xisco Faulí --- Yes, it's not possible to use bullets inside shapes or textboxes due to specifications. Please use frames instead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113015] “Online updates” checks the updates of extensions installed too
https://bugs.documentfoundation.org/show_bug.cgi?id=113015 Xisco Faulíchanged: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113015] “Online updates” checks the updates of extensions installed too
https://bugs.documentfoundation.org/show_bug.cgi?id=113015 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Any reason why it should be mentioned? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113066] Mis-interpreting of graphics semicircles
https://bugs.documentfoundation.org/show_bug.cgi?id=113066 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Hello, I see 6 files attached, which one should I use? Could you please attach a minimize document showing the issue instead? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107200] [META] Writer table and cell selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107200 Bug 107200 depends on bug 113257, which changed state. Bug 113257 Summary: "Select table" works different from expectations https://bugs.documentfoundation.org/show_bug.cgi?id=113257 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113257] "Select table" works different from expectations
https://bugs.documentfoundation.org/show_bug.cgi?id=113257 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |NOTABUG --- Comment #1 from Xisco Faulí --- It's the expected behaviour and how LibreOffice works -> https://ask.libreoffice.org/en/question/257/how-can-i-move-tables-in-writer/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113293] Text outside of textbox boundary get cropped during and after animation
https://bugs.documentfoundation.org/show_bug.cgi?id=113293 Xisco Faulíchanged: What|Removed |Added Keywords|bibisectRequest, regression |bibisected, bisected Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- The cropping after the presentation ends changed after 94d935eecbba0161de2616c2234b4a5d9d3cad88. However, I don' thing it's a regression, as it's rendering the textbox, which is correct. In order to fix this issue, the root cause should be fixed instead, which is the text being cropped even in normal mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113026] EDITING Legend placement dropdown not disabled when showing/ hiding legend from main toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=113026 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED CC||xiscofa...@libreoffice.org Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #1 from Xisco Faulí --- Gerrit patch: https://gerrit.libreoffice.org/#/c/43924/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113306] [Regression] Error dialog when selecting File -> Templates -> Open Template on fresh profile
https://bugs.documentfoundation.org/show_bug.cgi?id=113306 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- I can't reproduce it in Version: 6.0.0.0.alpha1+ Build ID: 43d6b11a5c1dda0cc2c1e06c768eece25051a56c CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group I've tried with -env:UserInstallation=file:///tmp/lo-test/` and --safe-mode, Do you reproduce it if you try with --safe-mode as well? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112865] FILEOPEN ODT: File opening is slower previously
https://bugs.documentfoundation.org/show_bug.cgi?id=112865 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Version|5.4.0.3 release |4.1 all versions Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- I can reproduce it back to Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) not a regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113139] EDITING: Applying/ undo formatting for a large document is a bit slower as it has been before
https://bugs.documentfoundation.org/show_bug.cgi?id=113139 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #3 from Xisco Faulí --- Could you please try with LibreOffice 6.0 alpha1 http://dev-builds.libreoffice.org/pre-releases/? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113350] Opening the Print Preview for a large document is slower as it has been before
https://bugs.documentfoundation.org/show_bug.cgi?id=113350 --- Comment #2 from Xisco Faulí--- OTOH, for this kind of tests, it would be good to try to many times, let's say, 10, and have an average number. Sometimes, it might be slower the first time... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113350] Opening the Print Preview for a large document is slower as it has been before
https://bugs.documentfoundation.org/show_bug.cgi?id=113350 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- > Version: 6.0.0.0.alpha0+ > Build ID: a4a182e24d2e3e954831a0a7c70a7299f28950cb > CPU threads: 4; OS: Windows 6.3; UI render: default; > TinderBox: Win-x86@42, Branch:master, Time: 2017-10-18_04:47:29 > Locale: nl-NL (nl_NL); Calc: CL Out of curiosity, is it a daily build ? Could you please check with LibreOffice 6.0 alpha1+ ? I'm wordering if daily builds are slower than production releases... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113391] Opening the “save as” dialog unsets the setting “place folders before files“ in Nautilus
https://bugs.documentfoundation.org/show_bug.cgi?id=113391 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |WORKSFORME --- Comment #3 from Xisco Faulí --- (In reply to zyklon87 from comment #0) > Description: > This isn’t the case in 6.0, but it makes me crazy! Please fix this > misbehaviour! Normally when it's fixed in master, we set the bug to RESOLVED WORKSFORME. In some cases, we can bisect the problem to see where it was fixed, but in this particular case, we can't as this is specific to the Flatpak -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113467] Random hangs -- multiple situations
https://bugs.documentfoundation.org/show_bug.cgi?id=113467 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. To be certain the reported issue is not related to corruption in the user profile, could you please reset your Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and re-test? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the issue is still present -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113398] average as sum
https://bugs.documentfoundation.org/show_bug.cgi?id=113398 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #6 from Xisco Faulí --- You don't need to add it to the formula bar explicitly, you can add it to another toolbar as well. I'm sorry but we get hundred of requests like this one all the time. In the end we will end up with a formula bar with many icons, and that's not convenient. LibreOffice already has the ability to customize the toolbars. Please, use this feature instead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103238 Bug 103238 depends on bug 113398, which changed state. Bug 113398 Summary: average as sum https://bugs.documentfoundation.org/show_bug.cgi?id=113398 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 --- Comment #71 from Geoffrey Wagner--- I'm using 5.3.4.2 because of this print issue. I'm able to duplex print from Calc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85966] No ability to copy / duplicate master slides
https://bugs.documentfoundation.org/show_bug.cgi?id=85966 Xisco Faulíchanged: What|Removed |Added CC||o...@prosa.dk --- Comment #6 from Xisco Faulí --- *** Bug 113407 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113407] Duplicate slide disabled in Slide Master View
https://bugs.documentfoundation.org/show_bug.cgi?id=113407 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #1 from Xisco Faulí --- *** This bug has been marked as a duplicate of bug 85966 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113457] "Version" should be pre-filled from 'Help > Send feedback'
https://bugs.documentfoundation.org/show_bug.cgi?id=113457 Xisco Faulíchanged: What|Removed |Added CC||cl...@documentfoundation.or ||g, ||xiscofa...@libreoffice.org --- Comment #1 from Xisco Faulí --- @cloph, is it possible to do so? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113468] Sudden High CPU Usage by "Idle" LO
https://bugs.documentfoundation.org/show_bug.cgi?id=113468 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Xisco Faulí --- Thank you for reporting the bug. Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. Please provide a clearer set of step-by-step instructions on how to reproduce the problem. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the steps are provided -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113469] Font display corruption with freeze rows and right or center align
https://bugs.documentfoundation.org/show_bug.cgi?id=113469 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Xisco Faulí --- Thank you for reporting the bug. it seems you're using an old version of LibreOffice. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Regarding Google Summer of Code'18
Sir/Ma'am, This is in reference to GSOC'18. First, a little about me: I am a second year computer science engineering student from India. I have programming experience of 3 years in C++ and C. I have not yet started to contribute to any Free and open source software till the date. But I'm looking forward to do so. I've been using LibreOffice open source softwares like writer, impress and many more for a long time and now I want to contribute towards an open source project, but before that I'd want to know a few things which are probably not mentioned in Libre's wiki page and other links since I want to enter GSOC'18 and also to make real use of my programming skills. So here are my queries: 1.As far as I know, there are various ways in which a user can contribute to FOSS. One being bug finding, another being providing working codes, suggestion for enhancements, etc. In order to get into GSOC, which type of contribution should I make more? 2. How many projects should I contribute to to get selected in GSOC? 3. If I make contributions to a project and it gets pulled into master, who would know that I did it? I mean will there be any proof of my successful contributions so that I can add it to my CV or something like that. 4. What is the magnitude of projects that I have to contribute? One, two, three or more? 5. Do I need to create a project on behalf of LibreOffice before I apply for the program? Or do I have to do it alone.. - That's all I had in mind. I apologize if I've asked a query whose answer is already mentioned on your website.. I hope you answer to the queries; really important for career :-) Thanks! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 --- Comment #70 from Alfred Ayache--- Reverted to LO 5.2.7, and landscape issue has gone away, but still not printing double-sided in Calc. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111846] Find & Replace: Rename diacritics and kashida search options
https://bugs.documentfoundation.org/show_bug.cgi?id=111846 --- Comment #25 from Heiko Tietze--- (In reply to Adolfo Jayme from comment #24) > The XP XPS Viewer has “Include kashida” and Office 2010 has “Match kashida” > [1], > which for me are better wording choices. Include Diacritics/Kashida was the first proposal and rejected here. MSDN writes about Diacritics Sensitivity and IIRC some other big players too. (OT: This topic was like some other for a couple of weeks on the agenda and no one commented. It's better to discuss beforehand the patch is submitted.) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92190] PRINTs landscape despite configured as portrait (Mac OS)
https://bugs.documentfoundation.org/show_bug.cgi?id=92190 --- Comment #69 from Alfred Ayache--- With the workaround where you slightly resize the page, it won't print double-sided. This is on macOS Sierra (10.12.6), LO 5.3.6.1, and Brother HL-2270DW, using Calc. Please, please, please, someone look into this and fix it. Thanks for all you do. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Draft of FOSDEM DevRoom Call for Papers
I will publish it on Sunday on FOSDEM lists, and on TDF blog. It is almost identical to last year's Call for Papers. -- FOSDEM is one of the largest gatherings of Free Software contributors in the world and happens each year in Brussels (Belgium) at the ULB Campus Solbosch. In 2018, it will be held on Saturday, February 3, and Sunday, February 4. As usual, the Open Document Editors DevRoom will be jointly organized by Apache OpenOffice and LibreOffice, on Saturday, February 3 (from 10:30AM to 6:30PM, room AW1.120). The shared devroom gives every project in this area a chance to present ODF related developments and innovations. We are now inviting proposals for talks about Open Document Editors or the ODF standard document format, on topics such as code, localization, QA, UX, tools, extensions and adoption related cases. This is a unique opportunity to show new ideas and developments to a wide technical audience. Please do keep in mind, though, that product pitches are not allowed at FOSDEM. Length of talks should be limited to a maximum of 30 minutes, as we would like to have questions after each presentation, and to fit as many presenters as possible in the schedule. Exceptions must be explicitly requested and justified. You may be assigned LESS time than you request. All submissions have to be made in the Pentabarf event planning tool: https://penta.fosdem.org/submission/FOSDEM18. While filing your proposal, please provide the title of your talk, a short abstract (one or two paragraphs), some information about yourself (name, bio and photo, but please do remember that your profile might be already stored at Pentabarf). To submit your talk, click on “Create Event”, then make sure to select the “Open Document Editors” devroom as the “Track”. Otherwise, your talk will not be even considered for any devroom at all. If you already have a Pentabarf account from a previous year, even if your talk was not accepted, please reuse it. Create an account if, and only if, you don’t have one from a previous year. If you have any issues with Pentabarf, please contact ode-devroom-mana...@fosdem.org. The deadline is Monday, December 4th, 2017. Accepted speakers will be notified by Monday, December 11th, 2017. The schedule will be published before Friday, December 15, 2017. Recording Permission The talks in the Open Document Editors DevRoom will be audio and video recorded, and possibly streamed live too. In the “Submission notes” field, please indicate that you agree to have your presentation recorded and published under the same license as all FOSDEM content (CC-BY). For example: “If my speech is accepted for FOSDEM, I hereby agree to be recorded and to have recordings - including slides and other presentation related documents - published under the Creative Commons Attribution (CC-BY) 4.0 International License. Sincerely, Name”. -- Italo Vignoli - it...@italovignoli.com mobile/signal +39.348.5653829 - skype italovignoli hangout/jabber italo.vign...@gmail.com GPG Key ID - 0xAAB8D5C0 DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] online.git: Changes to 'refs/tags/2.1.5-rc1'
Tag '2.1.5-rc1' created by Andras Timarat 2017-10-26 22:02 + 2.1.5-rc1 Changes since 2.1.4-3-16: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - configure.ac debian/changelog loolwsd.spec.in
configure.ac |2 +- debian/changelog |6 ++ loolwsd.spec.in |4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) New commits: commit df9557e95e0090b3e20a241ef480a4d011492d32 Author: Andras TimarDate: Fri Oct 27 00:02:01 2017 +0200 Bump version to 2.1.5 Change-Id: Ie7b188da26a244d877ff2181c829b5ed9994739b diff --git a/configure.ac b/configure.ac index 3b082a53..24c8c4d3 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ AC_PREREQ([2.63]) -AC_INIT([loolwsd], [2.1.4], [libreoffice@lists.freedesktop.org]) +AC_INIT([loolwsd], [2.1.5], [libreoffice@lists.freedesktop.org]) LT_INIT([shared, disable-static, dlopen]) AM_INIT_AUTOMAKE([1.10 subdir-objects tar-pax -Wno-portability]) diff --git a/debian/changelog b/debian/changelog index 5cf9d05c..ada4761d 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +loolwsd (2.1.5-1) unstable; urgency=medium + + * see the git log: http://col.la/cool21 + + -- Andras Timar Thu, 26 Oct 2017 23:10:00 +0200 + loolwsd (2.1.4-3) unstable; urgency=medium * see the git log: http://col.la/cool21 diff --git a/loolwsd.spec.in b/loolwsd.spec.in index f5ce40ed..ef545acf 100644 --- a/loolwsd.spec.in +++ b/loolwsd.spec.in @@ -12,7 +12,7 @@ Name: loolwsd%{name_suffix} Name: loolwsd %endif Version:@PACKAGE_VERSION@ -Release:3%{?dist} +Release:1%{?dist} %if 0%{?suse_version} == 1110 Group: Productivity/Office/Suite BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -60,7 +60,7 @@ Requires: atk avahi-glib avahi-libs bzip2-libs cairo cups-libs dbus-glib d # loolwsd dependencies Requires(post): libcap-progs Requires: libcap2 libpng12-0 %{fillup_prereq} -Requires: libPocoCrypto48 >= 1.7.8 libPocoFoundation48 >= 1.7.8 libPocoJSON48 >= 1.7.8 libPocoNet48 >= 1.7.8 libPocoNetSSL48 >= 1.7.8 libPocoUtil48 >= 1.7.8 libPocoXML48 >= 1.7.8 +Requires: libPocoCrypto49 >= 1.7.9 libPocoFoundation49 >= 1.7.9 libPocoJSON49 >= 1.7.9 libPocoNet49 >= 1.7.9 libPocoNetSSL49 >= 1.7.9 libPocoUtil49 >= 1.7.9 libPocoXML49 >= 1.7.9 %endif %if 0%{?suse_version} >= 1300 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 111846] Find & Replace: Rename diacritics and kashida search options
https://bugs.documentfoundation.org/show_bug.cgi?id=111846 --- Comment #24 from Adolfo Jayme--- I don’t like the wording used in the patch. The XP XPS Viewer has “Include kashida” and Office 2010 has “Match kashida” [1], which for me are better wording choices. [1] https://blogs.technet.microsoft.com/office_global_experience/2010/08/11/find-and-replace-for-the-arabic-script/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: external/gpgme external/libassuan external/libgpg-error
external/gpgme/ExternalPackage_gpgme.mk |2 +- external/libassuan/ExternalPackage_libassuan.mk |2 +- external/libgpg-error/ExternalPackage_libgpg-error.mk |3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) New commits: commit 91987a559bf1fde4a8d1eadc81e5711a7670fe69 Author: Thorsten BehrensDate: Thu Oct 26 19:15:26 2017 +0200 fix windows packaging Change-Id: Id9e306877125b66f908d24048d236c55483330d0 Reviewed-on: https://gerrit.libreoffice.org/43916 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/external/gpgme/ExternalPackage_gpgme.mk b/external/gpgme/ExternalPackage_gpgme.mk index a09726e82bc8..8f772ec8e7e4 100644 --- a/external/gpgme/ExternalPackage_gpgme.mk +++ b/external/gpgme/ExternalPackage_gpgme.mk @@ -18,7 +18,7 @@ ifeq ($(OS),LINUX) $(eval $(call gb_ExternalPackage_add_file,gpgme,$(LIBO_LIB_FOLDER)/libgpgmepp.so.6,lang/cpp/src/.libs/libgpgmepp.so.6.4.0)) $(eval $(call gb_ExternalPackage_add_file,gpgme,$(LIBO_LIB_FOLDER)/libgpgme.so.11,src/.libs/libgpgme.so.11.18.0)) -else +else ifeq ($(OS),MACOSX) $(eval $(call gb_ExternalPackage_add_file,gpgme,$(LIBO_LIB_FOLDER)/libgpgmepp.6.dylib,lang/cpp/src/.libs/libgpgmepp.6.dylib)) $(eval $(call gb_ExternalPackage_add_file,gpgme,$(LIBO_LIB_FOLDER)/libgpgme.11.dylib,src/.libs/libgpgme.11.dylib)) diff --git a/external/libassuan/ExternalPackage_libassuan.mk b/external/libassuan/ExternalPackage_libassuan.mk index 837e0ce49f56..41af53b2c373 100644 --- a/external/libassuan/ExternalPackage_libassuan.mk +++ b/external/libassuan/ExternalPackage_libassuan.mk @@ -17,7 +17,7 @@ ifeq ($(OS),LINUX) $(eval $(call gb_ExternalPackage_add_file,libassuan,$(LIBO_LIB_FOLDER)/libassuan.so.0,src/.libs/libassuan.so.0.7.3)) -else +else ifeq ($(OS),MACOSX) $(eval $(call gb_ExternalPackage_add_file,libassuan,$(LIBO_LIB_FOLDER)/libassuan.0.dylib,src/.libs/libassuan.0.dylib)) diff --git a/external/libgpg-error/ExternalPackage_libgpg-error.mk b/external/libgpg-error/ExternalPackage_libgpg-error.mk index e5e60685ac3f..a7c04ff9c900 100644 --- a/external/libgpg-error/ExternalPackage_libgpg-error.mk +++ b/external/libgpg-error/ExternalPackage_libgpg-error.mk @@ -17,11 +17,10 @@ ifeq ($(OS),LINUX) $(eval $(call gb_ExternalPackage_add_file,libgpg-error,$(LIBO_LIB_FOLDER)/libgpg-error.so.0,src/.libs/libgpg-error.so.0.22.0)) -else +else ifeq ($(OS),MACOSX) $(eval $(call gb_ExternalPackage_add_file,libgpg-error,$(LIBO_LIB_FOLDER)/libgpg-error.0.dylib,src/.libs/libgpg-error.0.dylib)) - endif endif # $(DISABLE_DYNLOADING) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - bin/gbuild-to-ide bin/gbuild-to-ideNS RepositoryExternal.mk
RepositoryExternal.mk |2 +- bin/gbuild-to-ide |7 ++- bin/gbuild-to-ideNS |7 ++- 3 files changed, 13 insertions(+), 3 deletions(-) New commits: commit 55ad81533a7ed5bd9d22dc78688b9852f292bd11 Author: Mike KaganskiDate: Fri Oct 27 00:06:17 2017 +0300 gbuild-to-ide: handle -U undefs correctly Previously, defines string like this: -DDBG_UTIL -DNOMINMAX -D_DLL -UNOMINMAX would produce this defines list: DBG_UTIL;NOMINMAX;_DLL -UNOMINMAX where last "define" is incorrect; proper list should be DBG_UTIL;_DLL so that the undef'ed element would be properly eliminated from the result. This patch takes care of this. Change-Id: Ia66a1d6d0a6e0bbfd0022b22285b005609871336 Reviewed-on: https://gerrit.libreoffice.org/43923 Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide index 0ff7579e1c84..d50801c3e6ca 100755 --- a/bin/gbuild-to-ide +++ b/bin/gbuild-to-ide @@ -67,10 +67,15 @@ class GbuildParser: defs = {} alldefs = [defswitch.strip() for defswitch in defsline.strip().lstrip('-D').split(' -D') if len(defswitch) > 2] for d in alldefs: -defparts = d.split('=') +dparts = d.split(' -U') +"""after dparts.pop(0), dparts will contain only undefs""" +defparts = dparts.pop(0).strip().split('=') if len(defparts) == 1: defparts.append(None) defs[defparts[0]] = defparts[1] +"""Drop undefed items (if any) from previous defs""" +for u in dparts: +defs.pop(u.strip(), '') defs["LIBO_INTERNAL_ONLY"] = None return defs diff --git a/bin/gbuild-to-ideNS b/bin/gbuild-to-ideNS index 44970c466b77..5fca58cf227d 100755 --- a/bin/gbuild-to-ideNS +++ b/bin/gbuild-to-ideNS @@ -106,10 +106,15 @@ class GbuildParser: defs = {} alldefs = [defswitch.strip() for defswitch in defsline.strip().lstrip('-D').split(' -D') if len(defswitch) > 2] for d in alldefs: -defparts = d.split('=') +dparts = d.split(' -U') +"""after dparts.pop(0), dparts will contain only undefs""" +defparts = dparts.pop(0).strip().split('=') if len(defparts) == 1: defparts.append(None) defs[defparts[0]] = defparts[1] +"""Drop undefed items (if any) from previous defs""" +for u in dparts: +defs.pop(u.strip(), '') defs["LIBO_INTERNAL_ONLY"] = None return defs commit dd35dccdf6c20922c51d2a8d4acb8a94a30522fb Author: Michael Stahl Date: Thu Oct 26 23:25:34 2017 +0200 RepositoryExternal.mk: fix inverted gpg condition (regression from 16598d526e9cc79698152daa5acc1e2718da933c) Change-Id: Ic621979926a9629aa8d8fb95a80957850ae0661b diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 0e90180cb474..282dc53f6ced 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -3467,7 +3467,7 @@ $(call gb_LinkTarget_use_package,$(1),gpgme) endef -ifneq ($(filter-out MACOSX LINUX,$(OS)),) +ifneq ($(filter MACOSX LINUX,$(OS)),) $(eval $(call gb_Helper_register_packages_for_install,ooo,\ gpgme \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/bastyp/bitset.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 6f065a7aff86528e5c780dccb50aeaecdb7896fb Author: Stephan BergmannDate: Thu Oct 26 23:24:41 2017 +0200 Avoid undefined left shift of signed integer ...after 022b1b2a40fcaf8d201081dead44c1d3346d1972 "tdf#96505 Get rid of cargo cult long integer literals" Change-Id: I9e5cc9d63c2eddd1ad766c2f6b01a9ff49a09bfd diff --git a/sfx2/source/bastyp/bitset.cxx b/sfx2/source/bastyp/bitset.cxx index 665209b4c554..8a49a02661c9 100644 --- a/sfx2/source/bastyp/bitset.cxx +++ b/sfx2/source/bastyp/bitset.cxx @@ -29,7 +29,7 @@ IndexBitSet& IndexBitSet::operator-=(sal_uInt16 nBit) { sal_uInt16 nBlock = nBit / 32; -sal_uInt32 nBitVal = 1 << (nBit % 32); +sal_uInt32 nBitVal = 1U << (nBit % 32); if ( nBlock >= nBlocks ) return *this; @@ -48,7 +48,7 @@ IndexBitSet& IndexBitSet::operator-=(sal_uInt16 nBit) IndexBitSet& IndexBitSet::operator|=( sal_uInt16 nBit ) { sal_uInt16 nBlock = nBit / 32; -sal_uInt32 nBitVal = 1 << (nBit % 32); +sal_uInt32 nBitVal = 1U << (nBit % 32); if ( nBlock >= nBlocks ) { @@ -78,7 +78,7 @@ IndexBitSet& IndexBitSet::operator|=( sal_uInt16 nBit ) bool IndexBitSet::Contains( sal_uInt16 nBit ) const { sal_uInt16 nBlock = nBit / 32; -sal_uInt32 nBitVal = 1 << (nBit % 32); +sal_uInt32 nBitVal = 1U << (nBit % 32); if ( nBlock >= nBlocks ) return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-ux-advise] [Bug 113421] When UI open on widescreen monitor allow horizontal packing of toolbars, i.e. another toolbar packed to right of Standard toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=113421 V Stuart Footechanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Better usage of wide-screen |When UI open on widescreen |monitors in the top bar |monitor allow horizontal ||packing of toolbars, i.e. ||another toolbar packed to ||right of Standard toolbar -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 113421] When UI open on widescreen monitor allow horizontal packing of toolbars, i.e. another toolbar packed to right of Standard toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=113421 V Stuart Footechanged: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Better usage of wide-screen |When UI open on widescreen |monitors in the top bar |monitor allow horizontal ||packing of toolbars, i.e. ||another toolbar packed to ||right of Standard toolbar -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113470] New: DRAW: add functional for convert any figure to any figure
https://bugs.documentfoundation.org/show_bug.cgi?id=113470 Bug ID: 113470 Summary: DRAW: add functional for convert any figure to any figure Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: add to Draw functional for convert any figure to any figure. For example, circle to rectangle, or star to triangle. All properties of figure must be saved: fill color, border color, text, arrange, etc. If we want to convert many figures in one time, then all properties for new figures must be set to default, but text must be saved as it was. It functional would be need for fast editing flowcharts Steps to Reproduce: 1. It is Enhancement 2. 3. Actual Results: there is not functional for convert any figure to any figure Expected Results: there is functional for convert any figure to any figure Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:56.0) Gecko/20100101 Firefox/56.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - oox/source
oox/source/drawingml/table/tableproperties.cxx | 106 ++--- 1 file changed, 61 insertions(+), 45 deletions(-) New commits: commit 8cd958a48e93efa4c21fd7687652ded8f9432c84 Author: Tor LillqvistDate: Thu Oct 26 23:30:42 2017 +0300 Add a comment in CreateTableStyle() related to the AOO fix for #i120723# Change-Id: Ic2eadf1942927efb6a6b209db591e869b61362f4 diff --git a/oox/source/drawingml/table/tableproperties.cxx b/oox/source/drawingml/table/tableproperties.cxx index a20191e05633..e5bc4f0cc3d5 100644 --- a/oox/source/drawingml/table/tableproperties.cxx +++ b/oox/source/drawingml/table/tableproperties.cxx @@ -144,6 +144,22 @@ static void SetTableStyleProperties(TableStyle* , sal_Int32 tblFill TableStyle* CreateTableStyle(const OUString& styleId) { TableStyle* pTableStyle = nullptr; + +// It is a bit silly to handle styleIds specifically and separately like this. Also note that +// the first two code blocks below are mostly copy-pasted, modulo the comments and the fact that +// one uses XML_accent1 and the other XML_accent2. Presumably it would be better to use a +// table-based approach, to have a mapping from style ids to the parameters that actually change +// between styles. See +// https://msdn.microsoft.com/en-us/library/office/hh273476(v=office.14).aspx for an unofficial +// list of these ids (that is said on that page to be undocumented, which doesn't sound credible?). + +// But the odd thing is that even if the code here handles only three specific style ids, if I +// edit the bug doc from AOO bug #i120723# (for which this code was added) and choose some other +// style, the table shows up mostly fine in Impress anyway. Thus I wonder whether this whole +// code is actually unnecessary, and the .pptx contains explicit values for all the components +// of a style anyway, and LibreOffice's code (at least now, maybe not when this code was added +// to AOO in 2012) knows to look at that? + if(styleId == "{5C22544A-7EE6-4342-B048-85BDC9FD1C3A}") { //Medium Style 2 Accent 1 pTableStyle = new TableStyle(); //first row style commit 84eb42728a3ceedaac382a8212230e3960732c41 Author: Tor Lillqvist Date: Thu Oct 26 22:00:57 2017 +0300 Don't abbreviate "First" as "Fst" Change-Id: I16726fbc8bf4f67fe1018d54437d59b715738bfe diff --git a/oox/source/drawingml/table/tableproperties.cxx b/oox/source/drawingml/table/tableproperties.cxx index cee8df58dc5b..a20191e05633 100644 --- a/oox/source/drawingml/table/tableproperties.cxx +++ b/oox/source/drawingml/table/tableproperties.cxx @@ -148,65 +148,65 @@ TableStyle* CreateTableStyle(const OUString& styleId) pTableStyle = new TableStyle(); //first row style //fill color and type -oox::drawingml::FillPropertiesPtr pFstRowFillProperties( new oox::drawingml::FillProperties ); -pFstRowFillProperties->moFillType.set(XML_solidFill); -pFstRowFillProperties->maFillColor.setSchemeClr(XML_accent1); -pTableStyle->getFirstRow().getFillProperties() = pFstRowFillProperties; +oox::drawingml::FillPropertiesPtr pFirstRowFillProperties( new oox::drawingml::FillProperties ); +pFirstRowFillProperties->moFillType.set(XML_solidFill); +pFirstRowFillProperties->maFillColor.setSchemeClr(XML_accent1); +pTableStyle->getFirstRow().getFillProperties() = pFirstRowFillProperties; //text color -::oox::drawingml::Color fstRowTextColor; -fstRowTextColor.setSchemeClr(XML_lt1); -pTableStyle->getFirstRow().getTextColor() = fstRowTextColor; +::oox::drawingml::Color firstRowTextColor; +firstRowTextColor.setSchemeClr(XML_lt1); +pTableStyle->getFirstRow().getTextColor() = firstRowTextColor; //bottom line border -oox::drawingml::LinePropertiesPtr pFstBottomBorder( new oox::drawingml::LineProperties); -pFstBottomBorder->moLineWidth = 38100; -pFstBottomBorder->moPresetDash = XML_sng; -pFstBottomBorder->maLineFill.moFillType.set(XML_solidFill); -pFstBottomBorder->maLineFill.maFillColor.setSchemeClr(XML_lt1); - pTableStyle->getFirstRow().getLineBorders().insert(std::pair (XML_bottom,pFstBottomBorder)); +oox::drawingml::LinePropertiesPtr pFirstBottomBorder( new oox::drawingml::LineProperties); +pFirstBottomBorder->moLineWidth = 38100; +pFirstBottomBorder->moPresetDash = XML_sng; +pFirstBottomBorder->maLineFill.moFillType.set(XML_solidFill); +pFirstBottomBorder->maLineFill.maFillColor.setSchemeClr(XML_lt1); + pTableStyle->getFirstRow().getLineBorders().insert(std::pair (XML_bottom,pFirstBottomBorder)); //last row style -
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-29'
Tag 'cp-5.3-29' created by Andras Timarat 2017-10-26 20:37 + cp-5.3-29 Changes since cp-5.3-10: Christian Lohmaier (1): update translations for 5.3.3 rc2 --- source/am/cui/source/options.po|8 source/am/cui/source/tabpages.po |8 source/am/cui/uiconfig/ui.po |8 source/am/fpicker/source/office.po | 10 source/am/officecfg/registry/data/org/openoffice/Office.po |6 source/am/sc/source/ui/src.po |8 source/am/sfx2/source/dialog.po| 12 source/am/svtools/source/dialogs.po|8 source/am/svtools/source/misc.po |8 source/am/svx/source/stbctrls.po |8 source/am/svx/uiconfig/ui.po | 10 source/bg/sc/uiconfig/scalc/ui.po | 20 source/bg/sfx2/source/dialog.po| 12 source/bg/svx/source/dialog.po | 30 source/bg/svx/source/form.po | 10 source/bg/svx/source/stbctrls.po |8 source/bg/svx/source/tbxctrls.po |6 source/bg/svx/uiconfig/ui.po | 289 source/bg/sw/source/ui/utlui.po| 21 source/bg/sw/source/uibase/utlui.po|6 source/bg/sw/uiconfig/swriter/ui.po|5 source/br/cui/uiconfig/ui.po | 70 - source/br/extensions/source/bibliography.po| 12 source/br/extensions/source/propctrlr.po | 152 ++-- source/br/sc/source/ui/src.po | 12 source/ca/helpcontent2/source/text/scalc/00.po | 20 source/ca/helpcontent2/source/text/scalc/01.po |8 source/ca/helpcontent2/source/text/scalc/guide.po | 10 source/ca/helpcontent2/source/text/shared/01.po|6 source/ca/helpcontent2/source/text/shared/guide.po |5 source/ca/helpcontent2/source/text/shared/optionen.po |8 source/ca/helpcontent2/source/text/simpress/guide.po | 10 source/ca/helpcontent2/source/text/swriter/01.po | 13 source/ca/helpcontent2/source/text/swriter/guide.po| 25 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po |8 source/ca/sc/uiconfig/scalc/ui.po |6 source/ca/svx/uiconfig/ui.po | 12 source/cy/cui/uiconfig/ui.po |8 source/cy/sfx2/source/dialog.po| 12 source/cy/sfx2/uiconfig/ui.po | 15 source/cy/svtools/source/dialogs.po|8 source/cy/svtools/source/misc.po |8 source/cy/svx/source/stbctrls.po | 10 source/cy/svx/uiconfig/ui.po | 10 source/da/cui/uiconfig/ui.po |8 source/da/helpcontent2/source/text/scalc/01.po | 12 source/da/sfx2/source/dialog.po| 14 source/da/sfx2/uiconfig/ui.po | 17 source/da/svtools/source/dialogs.po| 10 source/da/svtools/source/java.po | 12 source/da/svtools/source/misc.po | 10 source/da/svx/source/stbctrls.po |8 source/da/svx/uiconfig/ui.po | 12 source/de/editeng/source/items.po | 10 source/de/formula/source/core/resource.po |8 source/de/helpcontent2/source/auxiliary.po |6 source/de/helpcontent2/source/text/sbasic/shared/01.po | 10 source/de/helpcontent2/source/text/scalc.po|6 source/de/helpcontent2/source/text/scalc/00.po |6 source/de/helpcontent2/source/text/scalc/01.po | 100 +- source/de/helpcontent2/source/text/scalc/guide.po | 34 source/de/helpcontent2/source/text/schart/01.po|6 source/de/helpcontent2/source/text/shared/00.po| 10 source/de/helpcontent2/source/text/shared/01.po| 12 source/de/helpcontent2/source/text/shared/explorer/database.po |8 source/de/helpcontent2/source/text/shared/guide.po | 16
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-29'
Tag 'cp-5.3-29' created by Andras Timarat 2017-10-26 20:37 + cp-5.3-29 Changes since cp-5.3-28-25: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-29'
Tag 'cp-5.3-29' created by Andras Timarat 2017-10-26 20:37 + cp-5.3-29 Changes since libreoffice-5-3-branch-point-28: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-29'
Tag 'cp-5.3-29' created by Andras Timarat 2017-10-26 20:37 + cp-5.3-29 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: drawinglayer/source
drawinglayer/source/tools/emfphelperdata.cxx | 15 +++ 1 file changed, 15 insertions(+) New commits: commit cb0eb72ec40210ea7bade415ab3e78824e705c29 Author: David TardonDate: Thu Oct 26 22:24:55 2017 +0200 blind attempt to fix build on big endian Change-Id: I4dc2d5a5fbbded5f4c7a1417c150fe6b1a73a69d diff --git a/drawinglayer/source/tools/emfphelperdata.cxx b/drawinglayer/source/tools/emfphelperdata.cxx index be8f17acc02f..75f1c3c8f3f3 100644 --- a/drawinglayer/source/tools/emfphelperdata.cxx +++ b/drawinglayer/source/tools/emfphelperdata.cxx @@ -42,6 +42,21 @@ namespace emfplushelper { + +#ifdef OSL_BIGENDIAN +// little endian <-> big endian switch +static float GetSwapFloat(SvStream& rStream) +{ +float fTmp; +sal_Int8* pPtr = (sal_Int8*) +rStream.ReadSChar(pPtr[3]); +rStream.ReadSChar(pPtr[2]); +rStream.ReadSChar(pPtr[1]); +rStream.ReadSChar(pPtr[0]); +return fTmp; +} +#endif + const char* emfTypeToName(sal_uInt16 type) { switch (type) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3d454b7496d256140ab16a6e5c93f2c10aed3c1a Author: Andras TimarDate: Thu Oct 26 22:30:27 2017 +0200 Bump version to 5.3-29 Change-Id: Id5688cd2f94f913ca7bb28202e640b9ca04990a1 diff --git a/configure.ac b/configure.ac index a8a09c4ba77a..f19a6c139f96 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[5.3.10.28],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[5.3.10.29],[],[],[https://collaboraoffice.com/]) AC_PREREQ([2.59]) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113421] Better usage of wide-screen monitors in the top bar
https://bugs.documentfoundation.org/show_bug.cgi?id=113421 zyklo...@web.de changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WORKSFORME |--- --- Comment #3 from zyklo...@web.de --- Yes, I know I can do manually. But then it doesn’t change dynamically, so if I scale down the window, I can’t see the second bar anymore… No HiDPI by the way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113469] Font display corruption with freeze rows and right or center align
https://bugs.documentfoundation.org/show_bug.cgi?id=113469 --- Comment #1 from IanB--- Created attachment 137310 --> https://bugs.documentfoundation.org/attachment.cgi?id=137310=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113469] New: Font display corruption with freeze rows and right or center align
https://bugs.documentfoundation.org/show_bug.cgi?id=113469 Bug ID: 113469 Summary: Font display corruption with freeze rows and right or center align Product: LibreOffice Version: 5.1.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@broster.co.uk Description: With the following combination of features set: - Freeze Rows/Columns on - right or centre align of a cell When you enter text, it is not rendered) correctly while typing - the area is not cleared as the text is repositioned at each character. Steps to Reproduce: 1. New calc sheet 2. Select a cell B2 for example 3. Click Freeze Rows and Columns 4. Select Align Right 5. Type something into a cell, don't press enter Actual Results: Characters appear on top of each other Expected Results: Clear text Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - extensions.lst
extensions.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6d5609b9fb4ba222bbe06437e7f597c9d9014569 Author: Matthias SeidelDate: Thu Oct 26 19:03:28 2017 + Updated English dictionary diff --git a/extensions.lst b/extensions.lst index 1342b5c6aa04..c31217233aa1 100644 --- a/extensions.lst +++ b/extensions.lst @@ -39,7 +39,7 @@ # English dictionary [ language=en.* || language=de || language=it ] -78c5505c04bcd5a315b6dbd7ed91e8ec https://sourceforge.net/projects/aoo-extensions/files/17102/36/dict-en-20170901.oxt/download "dict-en-20170901.oxt" +f4cb089a1101cc06e49d8bbb2886e5cf https://sourceforge.net/projects/aoo-extensions/files/17102/38/dict-en-20171101.oxt/download "dict-en-20171101.oxt" # English (USA, en_US) dictionary [ language==nl || language==ru ] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113468] New: Sudden High CPU Usage by "Idle" LO
https://bugs.documentfoundation.org/show_bug.cgi?id=113468 Bug ID: 113468 Summary: Sudden High CPU Usage by "Idle" LO Product: LibreOffice Version: 5.4.2.2 release Hardware: IA64 (Itanium) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jrk1231...@nym.hush.com Note: This may (?) be related to bug 113467 in which I'm having a different performance issue. Three or four times recently, I will be working in another app and suddenly hear the fans on my MBP start to rev up. Checking Activity Monitor, I find the LibreOffice is using anywhere from 110% to 180% of the CPU. This has only happened with LibreOffice has been open but idle. One time, I had started the app and it was sitting on StartCenter when I got interrupted by a text and switched to my message app (LO was on a different Mac desktop space). Other times, I have had open writer documents, but had not been editing them for some time. I have not had a problem switched from whatever I am doing back to LO (although it may be a slow switch) and closing all the documents and exiting LO. I have noticed on Activity Monitor, that closing documents has no effect on CPU and it does not lower CPU usage until I quit LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113391] Opening the “save as” dialog unsets the setting “place folders before files“ in Nautilus
https://bugs.documentfoundation.org/show_bug.cgi?id=113391 --- Comment #2 from zyklo...@web.de --- https://gitlab.gnome.org/GNOME/nautilus/issues/72#note_7167 Philip could. I assume he also uses Fedora 27 beta (as I do). This happens solely in LO – there are no issues with other Flatpak programs (and I have ~20 installed). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113467] New: Random hangs -- multiple situations
https://bugs.documentfoundation.org/show_bug.cgi?id=113467 Bug ID: 113467 Summary: Random hangs -- multiple situations Product: LibreOffice Version: 5.4.2.2 release Hardware: IA64 (Itanium) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jrk1231...@nym.hush.com Writer has been hanging anywhere from a few seconds to over a minute under a lot of seemingly unrelated circumstances, such as: 1) Creating a new writer document a) New document simply takes "forever" to open, and/or b) Once new document is open, you cannot click in the document to start typing, etc. 2) Opening an existing document (usually opens immediately, but hangs before allowing you to even select the document) 3) Click in the document to start a selection point, then shift-click to mark the end of the selection (usually selects text immediately, but someones can take as long as 30 or more seconds to select as short as a single sentence) 4) Changing fonts via toolbar a) Sometimes it takes "forever" for the dropdown to appear b) Sometimes it will not react when selecting a font (dropdown just freezes, then returns to original selection in tool bar) c) Most of the time it works okay, but doesn't just enough to be annoying 5) When typing (this is the really annoying one, as I touch-type, and it isn't until the keyboard buffer fills and I start getting audio alerts I realize the LO has frozen -- the buffered typing eventually shows up, but it is hurry-up-and-wait) 6) When switching between already open documents, either via Windows menu or CMD+` shortcut. a) When using menu, it simply freezes on selection and nothing happens until LO unfreezes and switches to selected document b) When using shortcut, LO simply freezes I have checked Activity Monitor when these freezes occur, and LO is using essentially no resources, then has a big spike when it unfreezes. No other processes are running that would eat up CPU or memory, either. I always have plenty of free memory. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92235] Font STYLES for Table Headers are not copied when defining auto table format
https://bugs.documentfoundation.org/show_bug.cgi?id=92235 --- Comment #10 from Axel Bock--- set version field to "inherited from ooo" cause I already tested with 3.3.4.1, as per the instructions. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92235] Font STYLES for Table Headers are not copied when defining auto table format
https://bugs.documentfoundation.org/show_bug.cgi?id=92235 Axel Bockchanged: What|Removed |Added Version|4.4.4.2 rc |Inherited From OOo --- Comment #9 from Axel Bock --- Bug still present. LIBREOFFICE INFORMATION: Version: 5.4.2.2 Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4 CPU threads: 8; OS: Mac OS X 10.13; UI render: default; Locale: de-DE (de_DE.UTF-8); Calc: group STEPS TO REPRODUCE: * add table * format table header with PARAGRAPH STYLE "Table heading" * format table contents with PARAGRAPH STYLE "Table contents" * create a table auto-format from that * Table auto-format dialog * Use "Add" when table is marked to add new format type * Create NEW table * format table with table auto-format style. RESULT: * The PARAGRAPH STYLES are *NOT* applied * ... just the formatting is. EXPECTED RESULT: * the formatting is not applied, * but the PARAGRAPH STYLE is. That is a real PITA if you format a lot of tables and want to change all headings / contents at once. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: offapi/com offapi/UnoApi_offapi.mk
offapi/UnoApi_offapi.mk |3 + offapi/com/sun/star/i18n/LocaleData2.idl | 29 +++ offapi/com/sun/star/i18n/LocaleDataItem2.idl | 40 ++ offapi/com/sun/star/i18n/XLocaleData5.idl| 41 +++ 4 files changed, 113 insertions(+) New commits: commit 4ef04974882ba53daef3977e84c1844077b77e9b Author: Eike RathkeDate: Thu Oct 26 21:03:26 2017 +0200 New decimalSeparatorAlternative, LocaleDataItem2, XLocaleData5, tdf#81671 ... and LocaleData2 service, which is necessary with new-style services because optional interface at published service is not possible. Change-Id: I77703243a961b5385eaea146e4c9c42d5f30e1ad diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk index f6f95a50f6fa..c32c3265d091 100644 --- a/offapi/UnoApi_offapi.mk +++ b/offapi/UnoApi_offapi.mk @@ -228,6 +228,7 @@ $(eval $(call gb_UnoApi_add_idlfiles_nohdl,offapi,com/sun/star/i18n,\ LocaleCalendar \ LocaleCalendar2 \ LocaleData \ + LocaleData2 \ NativeNumberSupplier \ NumberFormatMapper \ OrdinalSuffix \ @@ -2738,6 +2739,7 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/i18n,\ LineBreakResults \ LineBreakUserOptions \ LocaleDataItem \ + LocaleDataItem2 \ LocaleItem \ Months \ MultipleCharsOutputException \ @@ -2777,6 +2779,7 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/i18n,\ XLocaleData2 \ XLocaleData3 \ XLocaleData4 \ + XLocaleData5 \ XNativeNumberSupplier \ XNumberFormatCode \ XOrdinalSuffix \ diff --git a/offapi/com/sun/star/i18n/LocaleData2.idl b/offapi/com/sun/star/i18n/LocaleData2.idl new file mode 100644 index ..7fe53bb096fe --- /dev/null +++ b/offapi/com/sun/star/i18n/LocaleData2.idl @@ -0,0 +1,29 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef __com_sun_star_i18n_LocaleData2_idl__ +#define __com_sun_star_i18n_LocaleData2_idl__ + +#include + +module com { module sun { module star { module i18n { + +/** Access locale specific data. + +Supersedes service com::sun::star::i18n::LocaleData + +@since LibreOffice 6.0 + */ +service LocaleData2 : XLocaleData5; + +}; }; }; }; + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/offapi/com/sun/star/i18n/LocaleDataItem2.idl b/offapi/com/sun/star/i18n/LocaleDataItem2.idl new file mode 100644 index ..f2565213facf --- /dev/null +++ b/offapi/com/sun/star/i18n/LocaleDataItem2.idl @@ -0,0 +1,40 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef __com_sun_star_i18n_LocaleDataItem2_idl__ +#define __com_sun_star_i18n_LocaleDataItem2_idl__ + +#include + +module com { module sun { module star { module i18n { + +/** +Locale specific data, derived from LocaleDataItem adding an +alternative input decimal separator. + +@since LibreOffice 6.0 + */ + +struct LocaleDataItem2 : LocaleDataItem +{ +/** Alternative input decimal separator, for example, "." if +the regular locale dependent separator usually is not present on +keyboards used with that locale. + + This separator is optional, an empty string denotes no +alternative decimal separator shall be used. + */ +string decimalSeparatorAlternative; +}; + +}; }; }; }; + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/offapi/com/sun/star/i18n/XLocaleData5.idl b/offapi/com/sun/star/i18n/XLocaleData5.idl new file mode 100644 index ..5a1eeb9bc22e --- /dev/null +++ b/offapi/com/sun/star/i18n/XLocaleData5.idl @@ -0,0 +1,41 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef __com_sun_star_i18n_XLocaleData5_idl__ +#define __com_sun_star_i18n_XLocaleData5_idl__ + +#include + + +module com { module sun { module star { module i18n { + + +/** +
[Libreoffice-commits] core.git: o3tl/CppunitTest_o3tl_tests.mk o3tl/qa
o3tl/CppunitTest_o3tl_tests.mk |1 o3tl/qa/test-safeint.cxx | 119 + 2 files changed, 120 insertions(+) New commits: commit 7cc8b8254feeda7f26ee0b0a187f34c5d8e52b34 Author: Stephan BergmannDate: Thu Oct 26 21:30:08 2017 +0200 Add test for o3tl::saturating_add Change-Id: I19bb1d566bd80f859810b4023d965c8fd80b98f2 diff --git a/o3tl/CppunitTest_o3tl_tests.mk b/o3tl/CppunitTest_o3tl_tests.mk index e8fd27095b06..9d802b98e167 100644 --- a/o3tl/CppunitTest_o3tl_tests.mk +++ b/o3tl/CppunitTest_o3tl_tests.mk @@ -31,6 +31,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,o3tl_tests,\ o3tl/qa/test-cow_wrapper \ o3tl/qa/test-enumarray \ o3tl/qa/test-lru_map \ + o3tl/qa/test-safeint \ o3tl/qa/test-sorted_vector \ o3tl/qa/test-string_view \ o3tl/qa/test-typed_flags \ diff --git a/o3tl/qa/test-safeint.cxx b/o3tl/qa/test-safeint.cxx new file mode 100644 index ..19269d4b05b3 --- /dev/null +++ b/o3tl/qa/test-safeint.cxx @@ -0,0 +1,119 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include + +#include + +#include +#include +#include + +#include + +namespace { + +class Test: public CppUnit::TestFixture { +private: +CPPUNIT_TEST_SUITE(Test); +CPPUNIT_TEST(testSignedSaturatingAdd); +CPPUNIT_TEST(testUnsignedSaturatingAdd); +CPPUNIT_TEST_SUITE_END(); + +void testSignedSaturatingAdd() { +auto const min = std::numeric_limits::min(); +auto const max = std::numeric_limits::max(); + +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min, min)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min, min + 1)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min, -1)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min, 0)); +CPPUNIT_ASSERT_EQUAL(min + 1, o3tl::saturating_add(min, 1)); +CPPUNIT_ASSERT_EQUAL(min + max - 1, o3tl::saturating_add(min, max - 1)); +CPPUNIT_ASSERT_EQUAL(min + max, o3tl::saturating_add(min, max)); + +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min + 1, min)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min + 1, min + 1)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(min + 1, -1)); +CPPUNIT_ASSERT_EQUAL(min + 1, o3tl::saturating_add(min + 1, 0)); +CPPUNIT_ASSERT_EQUAL(min + 2, o3tl::saturating_add(min + 1, 1)); +CPPUNIT_ASSERT_EQUAL(min + max, o3tl::saturating_add(min + 1, max - 1)); +CPPUNIT_ASSERT_EQUAL(min + max + 1, o3tl::saturating_add(min + 1, max)); + +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(-1, min)); +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(-1, min + 1)); +CPPUNIT_ASSERT_EQUAL(-2, o3tl::saturating_add(-1, -1)); +CPPUNIT_ASSERT_EQUAL(-1, o3tl::saturating_add(-1, 0)); +CPPUNIT_ASSERT_EQUAL(0, o3tl::saturating_add(-1, 1)); +CPPUNIT_ASSERT_EQUAL(max - 2, o3tl::saturating_add(-1, max - 1)); +CPPUNIT_ASSERT_EQUAL(max - 1, o3tl::saturating_add(-1, max)); + +CPPUNIT_ASSERT_EQUAL(min, o3tl::saturating_add(0, min)); +CPPUNIT_ASSERT_EQUAL(min + 1, o3tl::saturating_add(0, min + 1)); +CPPUNIT_ASSERT_EQUAL(-1, o3tl::saturating_add(0, -1)); +CPPUNIT_ASSERT_EQUAL(0, o3tl::saturating_add(0, 0)); +CPPUNIT_ASSERT_EQUAL(1, o3tl::saturating_add(0, 1)); +CPPUNIT_ASSERT_EQUAL(max - 1, o3tl::saturating_add(0, max - 1)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(0, max)); + +CPPUNIT_ASSERT_EQUAL(min + 1, o3tl::saturating_add(1, min)); +CPPUNIT_ASSERT_EQUAL(min + 2, o3tl::saturating_add(1, min + 1)); +CPPUNIT_ASSERT_EQUAL(0, o3tl::saturating_add(1, -1)); +CPPUNIT_ASSERT_EQUAL(1, o3tl::saturating_add(1, 0)); +CPPUNIT_ASSERT_EQUAL(2, o3tl::saturating_add(1, 1)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(1, max - 1)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(1, max)); + +CPPUNIT_ASSERT_EQUAL(min + max - 1, o3tl::saturating_add(max - 1, min)); +CPPUNIT_ASSERT_EQUAL(min + max, o3tl::saturating_add(max - 1, min + 1)); +CPPUNIT_ASSERT_EQUAL(max - 2, o3tl::saturating_add(max - 1, -1)); +CPPUNIT_ASSERT_EQUAL(max - 1, o3tl::saturating_add(max - 1, 0)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(max - 1, 1)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(max - 1, max - 1)); +CPPUNIT_ASSERT_EQUAL(max, o3tl::saturating_add(max - 1, max)); + +CPPUNIT_ASSERT_EQUAL(min + max, o3tl::saturating_add(max, min)); +
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src
loleaflet/src/control/Control.Menubar.js |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 703b1a147197551ae7def10968ab84dc208e2bc7 Author: Henry CastroDate: Tue Oct 24 14:57:57 2017 -0400 loleaflet: check if languages are an array type Change-Id: I580ea3c6fe70d1aa3204d2c743fb0a978dda185e Reviewed-on: https://gerrit.libreoffice.org/43789 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 6e9de55b..515e9bc0 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -364,7 +364,7 @@ L.Control.Menubar = L.Control.extend({ }, _onInitMenu: function (e) { - if (e.commandName === '.uno:LanguageStatus') { + if (e.commandName === '.uno:LanguageStatus' && L.Util.isArray(e.commandValues)) { var resetLang = _('Reset to Default Language'); $menuSelection = $('#menu-noneselection').parent(); $menuParagraph = $('#menu-noneparagraph').parent(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106154] Extremely slow basic operations on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=106154 --- Comment #25 from Ivan--- I confirm a similar bug (too slow) with draw. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/dist
loleaflet/dist/toolbar/toolbar.js | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) New commits: commit 09e997f583e8a38134519e3f8423e7dd936c679e Author: Henry CastroDate: Wed Oct 4 09:39:50 2017 -0400 loleaflet: fix statusbar items when refreshed when the statusbar is refreshed the items are restored to according to html property Change-Id: I79f77c5ab4932c10d10dd9780cbd6e6a9b132a38 Reviewed-on: https://gerrit.libreoffice.org/43391 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index 66a4b064..2f2eb146 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -701,6 +701,13 @@ function toLocalePattern (pattern, regex, text, sub1, sub2) { return text; } +function updateToolbarItem(toolbar, id, html) { + var item = toolbar.get(id); + if (item) { + item.html = html; + } +} + function unoCmdToToolbarId(commandname) { var id = commandname.toLowerCase().substr(5); @@ -736,6 +743,7 @@ function selectItem(item, func) item.current = index; } } + function onSearch(e) { var toolbar = w2ui['toolbar-down']; // conditionally disabling until, we find a solution for tdf#108577 @@ -1004,7 +1012,7 @@ map.on('doclayerinit', function () { toolbarUp.remove('wraptextseparator', 'wraptext', 'togglemergecells', 'break-toggle', 'numberformatcurrency', 'numberformatpercent', 'numberformatdecimal', 'numberformatdate', 'numberformatincdecimals', 'numberformatdecdecimals', 'break-number', 'sortascending', 'sortdescending'); toolbarUpMore.remove('wraptextseparator', 'wraptext', 'togglemergecells', 'break-toggle', 'numberformatcurrency', 'numberformatpercent', 'numberformatdecimal', 'numberformatdate', 'numberformatincdecimals', 'numberformatdecdecimals', 'break-number', 'sortascending', 'sortdescending'); statusbar.insert('left', [ - {type: 'break', id:'break1'}, + {type: 'break', id: 'break1'}, {type: 'html', id: 'StatePageNumber', html: '' }, {type: 'break', id:'break2'}, @@ -1014,7 +1022,7 @@ map.on('doclayerinit', function () { {type: 'html', id: 'InsertMode', html: '' }, {type: 'break', id:'break6'}, - {type: 'html', id: 'SelectionMode', + {type: 'html', id: 'StatusSelectionMode', html: '' }, {type: 'break', id:'break7'}, {type: 'html', id: 'LanguageStatus', @@ -1179,34 +1187,36 @@ map.on('commandstatechanged', function (e) { } } else if (commandName === '.uno:LanguageStatus') { - $('#LanguageStatus').html(_(state)); + updateToolbarItem(statusbar, 'LanguageStatus', $('#LanguageStatus').html(_(state)).html()); } else if (commandName === '.uno:ModifiedStatus') { var modifiedStatus = e.state === 'true'; + var html; if (modifiedStatus) { - $('#modifiedstatuslabel').html(''); + html = $('#modifiedstatuslabel').html('').html(); } else { - $('#modifiedstatuslabel').html(_('Document saved')); + html = $('#modifiedstatuslabel').html(_('Document saved')).html(); } + updateToolbarItem(statusbar, 'modifiedstatuslabel', html); } else if (commandName === '.uno:StatusDocPos') { state = toLocalePattern('Sheet %1 of %2', 'Sheet (\\d+) of (\\d+)', state, '%1', '%2'); - $('#StatusDocPos').html(state ? state : ''); + updateToolbarItem(statusbar, 'StatusDocPos', $('#StatusDocPos').html(state ? state : '').html()); } else if (commandName === '.uno:RowColSelCount') { state = toLocalePattern('$1 rows, $2 columns selected', '(\\d+) rows, (\\d+) columns selected', state, '$1', '$2'); - $('#RowColSelCount').html(state ? state : ''); + updateToolbarItem(statusbar, 'RowColSelCount', $('#RowColSelCount').html(state ? state : '').html()); } else if (commandName === '.uno:InsertMode') { - $('#InsertMode').html(state ? L.Styles.insertMode[state].toLocaleString() : ''); + updateToolbarItem(statusbar, 'InsertMode', $('#InsertMode').html(state ? L.Styles.insertMode[state].toLocaleString() : '').html()); } else if (commandName === '.uno:StatusSelectionMode' ||
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/dist loleaflet/src
loleaflet/dist/toolbar/toolbar.js|3 +++ loleaflet/src/control/Control.Menubar.js |4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit b330106bec0b60f3cdd119ba6153816858043961 Author: Henry CastroDate: Sat Oct 21 13:42:35 2017 -0400 loleaflet: enable Calc spell checking Change-Id: I9293335e1da7a3ad35d6ed03caf8289e2f26d066 Reviewed-on: https://gerrit.libreoffice.org/43702 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index 2f2eb146..ea7e567b 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -986,6 +986,9 @@ map.on('doclayerinit', function () { {type: 'break', id:'break3'}, {type: 'html', id: 'InsertMode', html: '' }, + {type: 'break', id:'break4'}, + {type: 'html', id: 'LanguageStatus', + html: '' }, {type: 'break', id:'break5'}, {type: 'html', id: 'StatusSelectionMode', html: '' }, diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index c14cd1fa..6e9de55b 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -300,7 +300,9 @@ L.Control.Menubar = L.Control.extend({ {name: _('Delete column'), type: 'unocommand', uno: '.uno:DeleteColumns'}] }, {name: _('Tools'), id: 'tools', type: 'menu', menu: [ - {name: _('Automatic spell checking'), type: 'unocommand', uno: '.uno:SpellOnline'} + {name: _('Automatic spell checking'), type: 'unocommand', uno: '.uno:SpellOnline'}, + {name: _('Language for entire document'), type: 'menu', menu: [ + {name: _('None (Do not check spelling)'), id: 'nonelanguage', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Default_LANGUAGE_NONE'}]} ]}, {name: _('Help'), id: 'help', type: 'menu', menu: [ {name: _('Keyboard shortcuts'), id: 'keyboard-shortcuts', type: 'action'}, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/src
loleaflet/src/control/Control.Menubar.js | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) New commits: commit 934da691850fd39ca07c89e4fa44ef889894cea0 Author: Henry CastroDate: Fri Oct 6 17:33:26 2017 -0400 loleaflet: add "None (Do not check spelling)" option Change-Id: Iae5176cf5b6b87b5c9540e392e6e81db7193e83f Reviewed-on: https://gerrit.libreoffice.org/43390 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index ef895d1f..c14cd1fa 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -175,11 +175,11 @@ L.Control.Menubar = L.Control.extend({ {name: _('Tools'), id: 'tools', type: 'menu', menu: [ {name: _('Automatic spell checking'), type: 'unocommand', uno: '.uno:SpellOnline'}, {name: _('Language for selection'), type: 'menu', menu: [ - {name: _('Reset to Default Language'), id: 'resetselection', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Current_RESET_LANGUAGES'}]}, + {name: _('None (Do not check spelling)'), id: 'noneselection', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Current_LANGUAGE_NONE'}]}, {name: _('Language for paragraph'), type: 'menu', menu: [ - {name: _('Reset to Default Language'), id: 'resetparagraph', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Paragraph_RESET_LANGUAGES'}]}, + {name: _('None (Do not check spelling)'), id: 'noneparagraph', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Paragraph_LANGUAGE_NONE'}]}, {name: _('Language for entire document'), type: 'menu', menu: [ - {name: _('Reset to Default Language'), id: 'resetlanguage', type: 'unocommand', uno:'.uno:LanguageStatus?Language:string=Default_RESET_LANGUAGES'}]} + {name: _('None (Do not check spelling)'), id: 'nonelanguage', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Default_LANGUAGE_NONE'}]} ]}, {name: _('Help'), id: 'help', type: 'menu', menu: [ {name: _('Keyboard shortcuts'), id: 'keyboard-shortcuts', type: 'action'}, @@ -363,14 +363,21 @@ L.Control.Menubar = L.Control.extend({ _onInitMenu: function (e) { if (e.commandName === '.uno:LanguageStatus') { - $menuSelection = $('#menu-resetselection').parent(); - $menuParagraph = $('#menu-resetparagraph').parent(); - $menuDefault = $('#menu-resetlanguage').parent(); + var resetLang = _('Reset to Default Language'); + $menuSelection = $('#menu-noneselection').parent(); + $menuParagraph = $('#menu-noneparagraph').parent(); + $menuDefault = $('#menu-nonelanguage').parent(); for (var lang in e.commandValues) { $menuSelection.append(this._createLangMenuItem(_(e.commandValues[lang]), encodeURIComponent('Current_' + e.commandValues[lang]))); $menuParagraph.append(this._createLangMenuItem(_(e.commandValues[lang]), encodeURIComponent('Paragraph_' + e.commandValues[lang]))); $menuDefault.append(this._createLangMenuItem(_(e.commandValues[lang]), encodeURIComponent('Default_' + e.commandValues[lang]))); } + $menuSelection.append(this._createMenu([{type: 'separator'}])); + $menuParagraph.append(this._createMenu[{type: 'separator'}]); + $menuDefault.append(this._createMenu([{type: 'separator'}])); + $menuSelection.append(this._createLangMenuItem(resetLang, 'Current_RESET_LANGUAGES')); + $menuParagraph.append(this._createLangMenuItem(resetLang, 'Paragraph_RESET_LANGUAGES')); + $menuDefault.append(this._createLangMenuItem(resetLang, 'Default_RESET_LANGUAGES')); } }, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-2-1' - loleaflet/dist loleaflet/src
loleaflet/dist/toolbar/toolbar.js|3 +++ loleaflet/src/control/Control.Menubar.js |4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit ef7aa17eb7677fe19033a3bd5f21b01f546f72b0 Author: Henry CastroDate: Fri Oct 13 20:59:19 2017 -0400 loleaflet: enable Impress spell checking Change-Id: Ie4ae3f683bc55f7ca67b01e65dafea9746784b5a Reviewed-on: https://gerrit.libreoffice.org/43389 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index 5faa4fa6..66a4b064 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -1039,6 +1039,9 @@ map.on('doclayerinit', function () { {type: 'break', id:'break1'}, {type: 'html', id: 'PageStatus', html: '' }, + {type: 'break', id:'break2'}, + {type: 'html', id: 'LanguageStatus', + html: '' } ]); // Remove irrelevant toolbars diff --git a/loleaflet/src/control/Control.Menubar.js b/loleaflet/src/control/Control.Menubar.js index 7576b524..ef895d1f 100644 --- a/loleaflet/src/control/Control.Menubar.js +++ b/loleaflet/src/control/Control.Menubar.js @@ -245,7 +245,9 @@ L.Control.Menubar = L.Control.extend({ {name: _('Fullscreen presentation'), id: 'fullscreen-presentation', type: 'action'}] }, {name: _('Tools'), id: 'tools', type: 'menu', menu: [ - {name: _('Automatic spell checking'), type: 'unocommand', uno: '.uno:SpellOnline'} + {name: _('Automatic spell checking'), type: 'unocommand', uno: '.uno:SpellOnline'}, + {name: _('Language for entire document'), type: 'menu', menu: [ + {name: _('None (Do not check spelling)'), id: 'nonelanguage', type: 'unocommand', uno: '.uno:LanguageStatus?Language:string=Default_LANGUAGE_NONE'}]} ]}, {name: _('Help'), id: 'help', type: 'menu', menu: [ {name: _('Keyboard shortcuts'), id: 'keyboard-shortcuts', type: 'action'}, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - include/svl sc/qa sc/sdi sc/source sc/uiconfig sfx2/source
include/svl/hint.hxx |1 sc/qa/unit/tiledrendering/tiledrendering.cxx | 51 ++ sc/sdi/docsh.sdi |1 sc/source/ui/docshell/docsh4.cxx | 94 +++ sc/source/ui/view/gridwin4.cxx |1 sc/source/ui/view/tabvwsh5.cxx |8 ++ sc/uiconfig/scalc/menubar/menubar.xml|2 sc/uiconfig/scalc/statusbar/statusbar.xml|1 sfx2/source/control/unoctitm.cxx | 13 +++ 9 files changed, 170 insertions(+), 2 deletions(-) New commits: commit 804038a4c05f5296fa34722650bc393ac01c02dd Author: Henry CastroDate: Thu Oct 19 22:47:17 2017 -0400 sc lok: fix spell checking languages in Calc Change-Id: Iadcc3b55a30ce2a2c785366fb3807ff6e4bda1fe Reviewed-on: https://gerrit.libreoffice.org/43581 Tested-by: Jenkins Reviewed-by: Henry Castro Reviewed-on: https://gerrit.libreoffice.org/43701 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx index 8de965d73af5..70f5fc74e8d6 100644 --- a/include/svl/hint.hxx +++ b/include/svl/hint.hxx @@ -30,6 +30,7 @@ #define SFX_HINT_UPDATEDONE 0x0020 #define SFX_HINT_DEINITIALIZING 0x0040 #define SFX_HINT_MODECHANGED0x0080 +#define SFX_HINT_LANGUAGECHANGED0x0100 // unused, formerly SFX_HINT_CANCELLABLE // unused, formerly SFX_HINT_DATAAVAILABLE // unused, formerly SFX_HINT_SAVECOMPLETED diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx b/sc/qa/unit/tiledrendering/tiledrendering.cxx index 8eaf06f7483d..32ccf698e872 100644 --- a/sc/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx @@ -77,6 +77,7 @@ public: void testInsertGraphicInvalidations(); void testDocumentSizeWithTwoViews(); void testDisableUndoRepair(); +void testLanguageStatus(); CPPUNIT_TEST_SUITE(ScTiledRenderingTest); CPPUNIT_TEST(testRowColumnSelections); @@ -104,6 +105,7 @@ public: CPPUNIT_TEST(testInsertGraphicInvalidations); CPPUNIT_TEST(testDocumentSizeWithTwoViews); CPPUNIT_TEST(testDisableUndoRepair); +CPPUNIT_TEST(testLanguageStatus); CPPUNIT_TEST_SUITE_END(); private: @@ -1414,6 +1416,55 @@ void ScTiledRenderingTest::testDisableUndoRepair() CPPUNIT_ASSERT(SfxItemState::SET == aSet2.GetItemState(SID_UNDO)); CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(aSet2.GetItem(SID_UNDO))); } + +comphelper::LibreOfficeKit::setActive(false); +} + +void ScTiledRenderingTest::testLanguageStatus() +{ +comphelper::LibreOfficeKit::setActive(); +ScModelObj* pModelObj = createDoc("small.ods"); +CPPUNIT_ASSERT(pModelObj); +ScDocShell* pDocSh = dynamic_cast< ScDocShell* >( pModelObj->GetEmbeddedObject() ); +CPPUNIT_ASSERT(pDocSh); + +// view #1 +SfxViewShell* pView1 = SfxViewShell::Current(); + +// view #2 +SfxLokHelper::createView(); +SfxViewShell* pView2 = SfxViewShell::Current(); +CPPUNIT_ASSERT(pView1 != pView2); +const OUString aLangBolivia("Spanish (Bolivia)"); +{ +std::unique_ptr pItem1; +std::unique_ptr pItem2; +pView1->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem1); +pView2->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem2); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(pItem1.get())); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(pItem2.get())); +CPPUNIT_ASSERT(!dynamic_cast< const SfxStringItem* >(pItem1.get())->GetValue().isEmpty()); +CPPUNIT_ASSERT(!dynamic_cast< const SfxStringItem* >(pItem1.get())->GetValue().isEmpty()); +} + +{ +SfxStringItem aLangString(SID_LANGUAGE_STATUS, "Default_Spanish (Bolivia)"); + pView1->GetViewFrame()->GetDispatcher()->ExecuteList(SID_LANGUAGE_STATUS, +SfxCallMode::SYNCHRON, { }); +} + +{ +std::unique_ptr pItem1; +std::unique_ptr pItem2; +pView1->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem1); +pView2->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem2); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(pItem1.get())); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringItem* >(pItem2.get())); +CPPUNIT_ASSERT_EQUAL(aLangBolivia, dynamic_cast< const SfxStringItem* >(pItem1.get())->GetValue()); +CPPUNIT_ASSERT_EQUAL(aLangBolivia, dynamic_cast< const SfxStringItem* >(pItem1.get())->GetValue()); +} + +comphelper::LibreOfficeKit::setActive(false); } } diff --git a/sc/sdi/docsh.sdi b/sc/sdi/docsh.sdi index 852af49223da..019465d8420c 100644 --- a/sc/sdi/docsh.sdi +++ b/sc/sdi/docsh.sdi @@ -88,6 +88,7 @@
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/implicitboolconversion.cxx | 26 +++ 1 file changed, 26 insertions(+) New commits: commit 1061875d6747f3cb89466aa6df568620a7ddfa05 Author: Stephan BergmannDate: Thu Oct 26 21:04:40 2017 +0200 Make loplugin:implicitboolconversion find the same in C++17 and pre-C++17 ...see a2d814ac1d7beb6fbe4b9cb7b75814f4b08b8e59 "loplugin:implicitboolconversion" and 24eeb4d286471e4a2103c15efc624a565112ca32 "loplugin:implicitboolconversion" for things previously only found in C++17. As expected, no further occurrences were found. Change-Id: Id0ab621b82dc3c40c8b5801413fceb73ade1408a diff --git a/compilerplugins/clang/implicitboolconversion.cxx b/compilerplugins/clang/implicitboolconversion.cxx index bc18e87cf366..058e042dbcf2 100644 --- a/compilerplugins/clang/implicitboolconversion.cxx +++ b/compilerplugins/clang/implicitboolconversion.cxx @@ -284,6 +284,8 @@ public: bool VisitImplicitCastExpr(ImplicitCastExpr const * expr); +bool VisitMaterializeTemporaryExpr(MaterializeTemporaryExpr const * expr); + private: bool isExternCFunctionCall( CallExpr const * expr, FunctionProtoType const ** functionType); @@ -905,6 +907,30 @@ bool ImplicitBoolConversion::VisitImplicitCastExpr( return true; } +bool ImplicitBoolConversion::VisitMaterializeTemporaryExpr( +MaterializeTemporaryExpr const * expr) +{ +if (ignoreLocation(expr)) { +return true; +} +if (auto const sub = dyn_cast(expr->GetTemporaryExpr())) { +auto const subsub = compat::getSubExprAsWritten(sub); +if (subsub->getType().IgnoreParens() == expr->getType().IgnoreParens() +&& isBool(subsub)) +{ +report( +DiagnosticsEngine::Warning, +("explicit conversion (%0) from %1 to %2 implicitly converted" + " back to %3"), +expr->getLocStart()) +<< sub->getCastKindName() << subsub->getType() << sub->getType() +<< expr->getType() << expr->getSourceRange(); +return true; +} +} +return true; +} + bool ImplicitBoolConversion::isExternCFunctionCall( CallExpr const * expr, FunctionProtoType const ** functionType) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - editeng/source sd/qa sd/source
editeng/source/editeng/impedit5.cxx | 10 + sd/qa/unit/tiledrendering/tiledrendering.cxx | 21 +++ sd/source/ui/docshell/docshel3.cxx | 17 +++-- sd/source/ui/docshell/docshell.cxx | 49 +-- 4 files changed, 91 insertions(+), 6 deletions(-) New commits: commit 514c93d9741ce4bc12edf38eadb0e268aae80a90 Author: Henry CastroDate: Fri Oct 13 20:47:29 2017 -0400 sd lok: fix spell checking languages in Impress Change-Id: I133c9b91521fa7f2b5f7e3a47396f7efa31e1a86 Reviewed-on: https://gerrit.libreoffice.org/43382 Tested-by: Jenkins Reviewed-by: Henry Castro Reviewed-on: https://gerrit.libreoffice.org/43388 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/editeng/source/editeng/impedit5.cxx b/editeng/source/editeng/impedit5.cxx index e091a142cec2..826dbd7dc6be 100644 --- a/editeng/source/editeng/impedit5.cxx +++ b/editeng/source/editeng/impedit5.cxx @@ -681,6 +681,7 @@ void ImpEditEngine::RemoveCharAttribs( sal_Int32 nPara, sal_uInt16 nWhich, bool void ImpEditEngine::SetParaAttribs( sal_Int32 nPara, const SfxItemSet& rSet ) { +bool bCheckLanguage = false; ContentNode* pNode = aEditDoc.GetObject( nPara ); if ( !pNode ) @@ -701,7 +702,16 @@ void ImpEditEngine::SetParaAttribs( sal_Int32 nPara, const SfxItemSet& rSet ) InsertUndo(new EditUndoSetParaAttribs(pEditEngine, nPara, pNode->GetContentAttribs().GetItems(), rSet)); } } + +bCheckLanguage = ( rSet.GetItemState( EE_CHAR_LANGUAGE ) == SfxItemState::SET ) || + ( rSet.GetItemState( EE_CHAR_LANGUAGE_CJK ) == SfxItemState::SET ) || + ( rSet.GetItemState( EE_CHAR_LANGUAGE_CTL ) == SfxItemState::SET ); + pNode->GetContentAttribs().GetItems().Set( rSet ); + +if ( bCheckLanguage && pNode->GetWrongList() ) +pNode->GetWrongList()->ResetInvalidRange(0, pNode->Len()); + if ( aStatus.UseCharAttribs() ) pNode->CreateDefFont(); diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx index 46dc5acf7c7c..55d5712fe632 100644 --- a/sd/qa/unit/tiledrendering/tiledrendering.cxx +++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -96,6 +97,7 @@ public: void testCommentCallbacks(); void testMultiViewInsertDeletePage(); void testDisableUndoRepair(); +void testLanguageStatus(); CPPUNIT_TEST_SUITE(SdTiledRenderingTest); CPPUNIT_TEST(testRegisterCallback); @@ -133,6 +135,7 @@ public: CPPUNIT_TEST(testCommentCallbacks); CPPUNIT_TEST(testMultiViewInsertDeletePage); CPPUNIT_TEST(testDisableUndoRepair); +CPPUNIT_TEST(testLanguageStatus); CPPUNIT_TEST_SUITE_END(); @@ -1817,6 +1820,24 @@ void SdTiledRenderingTest::testDisableUndoRepair() } } +void SdTiledRenderingTest::testLanguageStatus() +{ +// Load the document. +comphelper::LibreOfficeKit::setActive(); +createDoc("dummy.odp"); +SfxViewShell* pView1 = SfxViewShell::Current(); +SfxLokHelper::createView(); +SfxViewShell* pView2 = SfxViewShell::Current(); +{ +std::unique_ptr pItem1; +std::unique_ptr pItem2; +pView1->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem1); +pView2->GetViewFrame()->GetBindings().QueryState(SID_LANGUAGE_STATUS, pItem2); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringListItem* >(pItem1.get())); +CPPUNIT_ASSERT(dynamic_cast< const SfxStringListItem* >(pItem2.get())); +} +} + CPPUNIT_TEST_SUITE_REGISTRATION(SdTiledRenderingTest); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sd/source/ui/docshell/docshel3.cxx b/sd/source/ui/docshell/docshel3.cxx index 35f8a38ebe0d..f9c5eb47b5ee 100644 --- a/sd/source/ui/docshell/docshel3.cxx +++ b/sd/source/ui/docshell/docshel3.cxx @@ -121,7 +121,8 @@ static void lcl_setLanguage( const SdDrawDocument *pDoc, const OUString for( size_t nObj = 0; nObj < nObjCount; ++nObj ) { SdrObject *pObj = pPage->GetObj( nObj ); -lcl_setLanguageForObj( pObj, nLang, bLanguageNone ); +if (pObj->GetObjIdentifier() != OBJ_PAGE) +lcl_setLanguageForObj( pObj, nLang, bLanguageNone ); } } } @@ -297,6 +298,7 @@ void DrawDocShell::Execute( SfxRequest& rReq ) const OUString aDocumentLangPrefix("Default_"); const OUString aStrNone("LANGUAGE_NONE"); const OUString aStrResetLangs("RESET_LANGUAGES"); +SdDrawDocument* pDoc = mpViewShell->GetDoc(); sal_Int32 nPos = -1;
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/implicitboolconversion.cxx | 39 +++ 1 file changed, 20 insertions(+), 19 deletions(-) New commits: commit e02e0f4081c0807fa65548159292585c680abff3 Author: Stephan BergmannDate: Thu Oct 26 21:04:03 2017 +0200 Use compat::getSubExprAsWritten; clean up Change-Id: I8f984c3b3833437f6b4d65ab99da608a6868ff74 diff --git a/compilerplugins/clang/implicitboolconversion.cxx b/compilerplugins/clang/implicitboolconversion.cxx index 1151a78f4384..bc18e87cf366 100644 --- a/compilerplugins/clang/implicitboolconversion.cxx +++ b/compilerplugins/clang/implicitboolconversion.cxx @@ -859,29 +859,30 @@ bool ImplicitBoolConversion::VisitImplicitCastExpr( } return true; } -ExplicitCastExpr const * sub = dyn_cast( -expr->getSubExpr()->IgnoreParenImpCasts()); -if (sub != nullptr -&& (sub->getSubExpr()->IgnoreParenImpCasts()->getType().IgnoreParens() -== expr->getType().IgnoreParens()) -&& isBool(sub->getSubExpr()->IgnoreParenImpCasts())) +if (auto const sub = dyn_cast( +compat::getSubExprAsWritten(expr))) { -// Ignore "normalizing cast" bool(b) from sal_Bool b to bool, then -// implicitly cast back again to sal_Bool: -if (dyn_cast(sub) != nullptr -&& sub->getType()->isBooleanType() && isSalBool(expr->getType()) -&& isSalBool(sub->getSubExpr()->IgnoreParenImpCasts()->getType())) +auto const subsub = compat::getSubExprAsWritten(sub); +if (subsub->getType().IgnoreParens() == expr->getType().IgnoreParens() +&& isBool(subsub)) { +// Ignore "normalizing cast" bool(b) from sal_Bool b to bool, then +// implicitly cast back again to sal_Bool: +if (dyn_cast(sub) != nullptr +&& sub->getType()->isBooleanType() && isSalBool(expr->getType()) +&& isSalBool(subsub->getType())) +{ +return true; +} +report( +DiagnosticsEngine::Warning, +("explicit conversion (%0) from %1 to %2 implicitly cast back" + " to %3"), +expr->getLocStart()) +<< sub->getCastKindName() << subsub->getType() << sub->getType() +<< expr->getType() << expr->getSourceRange(); return true; } -report( -DiagnosticsEngine::Warning, -"explicit conversion (%0) from %1 to %2 implicitly cast back to %3", -expr->getLocStart()) -<< sub->getCastKindName() -<< sub->getSubExpr()->IgnoreParenImpCasts()->getType() -<< sub->getType() << expr->getType() << expr->getSourceRange(); -return true; } if (expr->getType()->isBooleanType() && !isBoolExpr(expr->getSubExpr()) && !calls.empty()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8scan.cxx | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) New commits: commit 4c1bfd35ae05aca4c71c17d41ebe10634526edac Author: Caolán McNamaraDate: Thu Oct 26 10:20:45 2017 +0100 ofz#3816 Integer-overflow Change-Id: I899df8d0609d6a3c55d130cffc5b1b23eebece13 diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx index c3adbf485d8f..f296eb91af04 100644 --- a/sw/source/filter/ww8/ww8scan.cxx +++ b/sw/source/filter/ww8/ww8scan.cxx @@ -3391,10 +3391,17 @@ void WW8PLCFx_Cp_FKP::GetSprms(WW8PLCFxDesc* p) nFcStart,bIsUnicode ); } -WW8_CP nCpLen = (nCpEnd - nCpStart); +WW8_CP nCpLen; +bool bFail = o3tl::checked_sub(nCpEnd, nCpStart, nCpLen); +if (bFail) +{ +SAL_WARN("sw.ww8", "broken offset, ignoring"); +continue; +} + if (bIsUnicode) { -const bool bFail = o3tl::checked_multiply(nCpLen, 2, nCpLen); +bFail = o3tl::checked_multiply(nCpLen, 2, nCpLen); if (bFail) { SAL_WARN("sw.ww8", "broken offset, ignoring"); @@ -3402,7 +3409,7 @@ void WW8PLCFx_Cp_FKP::GetSprms(WW8PLCFxDesc* p) } } -const bool bFail = o3tl::checked_add(nFcStart, nCpLen, nLimitFC); +bFail = o3tl::checked_add(nFcStart, nCpLen, nLimitFC); if (bFail) { SAL_WARN("sw.ww8", "broken offset, ignoring"); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svtools/source
svtools/source/misc/acceleratorexecute.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 91f11350eda817add24948ce7a4145eff58d8743 Author: Noel GrandinDate: Thu Oct 26 10:41:32 2017 +0200 rename createOnShotInstance->createOneShotInstance Change-Id: I8848784cd867714019f90bb7fc57ca7289e51f81 Reviewed-on: https://gerrit.libreoffice.org/43873 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/svtools/source/misc/acceleratorexecute.cxx b/svtools/source/misc/acceleratorexecute.cxx index 3d2bca6a156c..d30e2393032d 100644 --- a/svtools/source/misc/acceleratorexecute.cxx +++ b/svtools/source/misc/acceleratorexecute.cxx @@ -58,7 +58,7 @@ class AsyncAccelExec : public cppu::WeakImplHelper This instance can be forced to execute it's internal set request asynchronous. After that it deletes itself ! */ -static AsyncAccelExec* createOnShotInstance(const css::uno::Reference& xFrame, +static AsyncAccelExec* createOneShotInstance(const css::uno::Reference& xFrame, const css::uno::Reference& xDispatch, const css::util::URL& rURL); @@ -203,7 +203,7 @@ bool AcceleratorExecute::execute(const css::awt::KeyEvent& aAWTKey) { // Note: Such instance can be used one times only and destroy itself afterwards .-) css::uno::Reference xFrame(xProvider, css::uno::UNO_QUERY); -AsyncAccelExec* pExec = AsyncAccelExec::createOnShotInstance(xFrame, xDispatch, aURL); +AsyncAccelExec* pExec = AsyncAccelExec::createOneShotInstance(xFrame, xDispatch, aURL); pExec->execAsync(); } @@ -440,7 +440,7 @@ AsyncAccelExec::AsyncAccelExec(const css::uno::Reference& { } -AsyncAccelExec* AsyncAccelExec::createOnShotInstance(const css::uno::Reference , +AsyncAccelExec* AsyncAccelExec::createOneShotInstance(const css::uno::Reference , const css::uno::Reference< css::frame::XDispatch >& xDispatch, const css::util::URL& rURL) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: emfio/inc emfio/source
emfio/inc/emfreader.hxx |1 + emfio/source/reader/emfreader.cxx | 18 ++ 2 files changed, 19 insertions(+) New commits: commit e06807f51d157844b357dab1bbf960cc55162330 Author: Patrick JaapDate: Mon Oct 2 16:21:04 2017 +0200 tdf#31814 EMF/EMF+ implement dual mode There can be a dual mode flag set in the EMF+ data. If set, we should process either EMF or EMF+ data, because the contained information should be equal (says the documentation). The more advanced EMF+ renderer is chosen here. The flag is read in the EMFPlusReader and blocks the reading of other EMF records than HEADER, EOF and COMMENT. Thanks to Chris, for pointing out the dual mode! Change-Id: I8522930cebbb9e9ecc732397cbb3deea9e8c9127 Reviewed-on: https://gerrit.libreoffice.org/43122 Reviewed-by: Patrick Jaap Reviewed-by: Bartosz Kosiorek Tested-by: Bartosz Kosiorek diff --git a/emfio/inc/emfreader.hxx b/emfio/inc/emfreader.hxx index 8ee533c24068..4b2855cf54f6 100644 --- a/emfio/inc/emfreader.hxx +++ b/emfio/inc/emfreader.hxx @@ -31,6 +31,7 @@ namespace emfio boolmbRecordPath : 1; boolmbEMFPlus : 1; +boolmbEMFPlusDualMode : 1; boolReadHeader(); // reads and converts the rectangle diff --git a/emfio/source/reader/emfreader.cxx b/emfio/source/reader/emfreader.cxx index 859c3510b759..8ff413b79033 100644 --- a/emfio/source/reader/emfreader.cxx +++ b/emfio/source/reader/emfreader.cxx @@ -384,6 +384,7 @@ namespace emfio , mnRecordCount(0) , mbRecordPath(false) , mbEMFPlus(false) +,mbEMFPlusDualMode(false) { } @@ -443,6 +444,15 @@ namespace emfio SAL_INFO ("vcl.emf", "\t\tEMF+ lock DC (device context)"); } +// look for the "dual mode" in header +// it indicates that either EMF or EMF+ records should be processed +// 0x4001= EMF+ header +// flags & 1 = dual mode active +if ( type == 0x4001 && flags & 1 ) +{ +mbEMFPlusDualMode = true; +} + // Get the length of the remaining data of this record based // on the alleged size sal_uInt32 nRemainingRecordData = size >= nRequiredHeaderSize ? @@ -697,6 +707,14 @@ namespace emfio } } } +else if ( !bHaveDC && mbEMFPlusDualMode && nRecType != EMR_HEADER && nRecType != EMR_EOF ) +{ +// skip content (EMF record) in dual mode +// we process only EMR_COMMENT (see above) to access EMF+ data +// with 2 exceptions, according to EMF+ specification: +// EMR_HEADER and EMR_EOF +// if a device context is given (bHaveDC) process the following EMF record, too. +} else if( !mbEMFPlus || bHaveDC || nRecType == EMR_EOF ) { switch( nRecType ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 83688] FILEOPEN/EDITING Libre Office Drawing stick at 100% CPU load, when opening large drawing documents
https://bugs.documentfoundation.org/show_bug.cgi?id=83688 --- Comment #11 from Telesto--- (In reply to Buovjaga from comment #10) I'm not seeing any CPU stress with: Version: 6.0.0.0.alpha1+ Build ID: b17294826830e278d060c876cf4f94a9b4ec16cc CPU threads: 4; OS: Windows 6.3; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-10-23_06:32:42 Locale: nl-NL (nl_NL); Calc: CL nor with Ubuntu 14.04 GTK2 with 5.4.1.2 or 6.0.0.0Alpha1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113466] Addresses of cells/ cell ranges in input line are not coloured and corresponding cells/ cell ranges are not highlighted with coloured borders
https://bugs.documentfoundation.org/show_bug.cgi?id=113466 raalchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |DUPLICATE --- Comment #2 from raal --- *** This bug has been marked as a duplicate of bug 113179 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/ieps/ieps.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 334cc99139f59fffba214c821707c35270a6b0ee Author: Caolán McNamaraDate: Thu Oct 26 10:50:39 2017 +0100 ofz#3820 Integer-overflow Change-Id: I620b0278273e285100fe44d252389e6393a2022c Reviewed-on: https://gerrit.libreoffice.org/43877 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/filter/source/graphicfilter/ieps/ieps.cxx b/filter/source/graphicfilter/ieps/ieps.cxx index 27ccf4bac5db..65414afe6a82 100644 --- a/filter/source/graphicfilter/ieps/ieps.cxx +++ b/filter/source/graphicfilter/ieps/ieps.cxx @@ -97,10 +97,10 @@ static long ImplGetNumber(sal_uInt8* , sal_uInt32& nSecurityCount) nSecurityCount = 1; // error parsing the bounding box values else if ( bValid ) { -const bool bFail = o3tl::checked_multiply(nRetValue, 10L, nRetValue); +const bool bFail = o3tl::checked_multiply(nRetValue, 10, nRetValue) || + o3tl::checked_add(nRetValue, *rBuf - '0', nRetValue); if (bFail) return 0; -nRetValue += *rBuf - '0'; } break; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/icgm/bitmap.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit d97f0ceb437af5d05e9be220968033a2e5ed7001 Author: Caolán McNamaraDate: Thu Oct 26 10:59:45 2017 +0100 ofz#3793 Divide-by-zero Change-Id: Ica00209bc6679edaa0c83fc7d31bd5d4653b5e96 Reviewed-on: https://gerrit.libreoffice.org/43879 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/filter/source/graphicfilter/icgm/bitmap.cxx b/filter/source/graphicfilter/icgm/bitmap.cxx index da83096126a7..72099a3eb076 100644 --- a/filter/source/graphicfilter/icgm/bitmap.cxx +++ b/filter/source/graphicfilter/icgm/bitmap.cxx @@ -179,7 +179,7 @@ void CGMBitmap::ImplGetBitmap( CGMBitmapDescriptor& rDesc ) nX = rDesc.mnR.X - rDesc.mnP.X; nY = rDesc.mnR.Y - rDesc.mnP.Y; -const double fSqrt = sqrt(nX * nX + nY * nY); +double fSqrt = sqrt(nX * nX + nY * nY); rDesc.mnOrientation = fSqrt != 0.0 ? (acos(nX / fSqrt) * 57.29577951308) : 0.0; if ( nY > 0 ) rDesc.mnOrientation = 360 - rDesc.mnOrientation; @@ -193,7 +193,8 @@ void CGMBitmap::ImplGetBitmap( CGMBitmapDescriptor& rDesc ) nX = fCos * nX + fSin * nY; nY = -( fSin * nX - fCos * nY ); -fAngle = acos( nX / sqrt( nX * nX + nY * nY ) ) * 57.29577951308; +fSqrt = sqrt(nX * nX + nY * nY); +fAngle = fSqrt != 0.0 ? (acos(nX / fSqrt) * 57.29577951308) : 0.0; if ( nY > 0 ) fAngle = 360 - fAngle; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86371] FILESAVE: Setting line spacing to "Single" not preserved in DOCX (it falls back to 120%)
https://bugs.documentfoundation.org/show_bug.cgi?id=86371 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu --- Comment #10 from Aron Budea --- My bibisect results with repo bibisect-42max are quite different, and point to the following range (saving the file crashes LO with the commits in between): https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=09d381adbfba893331a07918c9ec9b3c58939dfb..b8a4abdda4e6a95535992c26a906226ede7f050a The most likely candidate seems to be: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b00c73f9338a1bc0d4698f14383c4a5f9dbd78b6 author PriyankaGaikwad 2013-11-15 09:57:54 (GMT) committer Miklos Vajna 2013-11-15 16:47:25 (GMT) Fixed for spacing between lines having lineRule "auto" is getting preserved -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/file.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit b1fa5e7a2c9d5fedaf07fc990d71707e6cf1ddf7 Author: Stephan BergmannDate: Thu Oct 26 19:06:41 2017 +0200 cid#1420316: Try silence CONSTANT_EXPRESSION_RESULT (or does the comment need to go exactly at the line before the one containing the "return" token?) Change-Id: I5f92e59ee05d0b5ba3d6bda775e6ca02f185dbe8 diff --git a/sal/osl/unx/file.cxx b/sal/osl/unx/file.cxx index b1383c2d0f9c..b97e157c29be 100644 --- a/sal/osl/unx/file.cxx +++ b/sal/osl/unx/file.cxx @@ -1151,6 +1151,7 @@ namespace { //coverity[result_independent_of_operands] template bool exceedsMaxOffT(T n) { return n > MAX_OFF_T; } +//coverity[result_independent_of_operands] template bool exceedsMinOffT(T n) { return n < std::numeric_limits::min(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 113466] Addresses of cells/ cell ranges in input line are not coloured and corresponding cells/ cell ranges are not highlighted with coloured borders
https://bugs.documentfoundation.org/show_bug.cgi?id=113466 --- Comment #1 from bla...@engineer.com --- Created attachment 137309 --> https://bugs.documentfoundation.org/attachment.cgi?id=137309=edit Example of cell address not coloured and cell border not highlighted -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93156] Middle-of-connector anchor doesn' t update its targets when moved
https://bugs.documentfoundation.org/show_bug.cgi?id=93156 --- Comment #9 from kompilainenn <79045_79...@mail.ru> --- bug is still repro in 6.0 alpha 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - ios/LibreOfficeLight
ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj | 14 ios/LibreOfficeLight/LibreOfficeLight/AppDelegate.swift |6 ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iCloudDrive.imageset/Contents.json | 23 + ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iCloudDrive.imageset/iCloudDrive.png |binary ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iCloudDrive.imageset/iclouddr...@2x.png |binary ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iCloudDrive.imageset/iclouddr...@3x.png |binary ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iPhone.imageset/Contents.json | 23 + ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iPhone.imageset/iPhone.png |binary ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iPhone.imageset/iph...@2x.png |binary ios/LibreOfficeLight/LibreOfficeLight/Assets.xcassets/iPhone.imageset/iph...@3x.png |binary ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift | 44 +- ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard | 173 +++--- 12 files changed, 209 insertions(+), 74 deletions(-) New commits: commit fb62c2c5252a0b25d22ceccbb07747048923a44a Author: jan IversenDate: Thu Oct 26 18:54:25 2017 +0200 iOS added menu entries Added Copy/Move/Delete since this is the only way to access the local storage. Change-Id: I9b054a4f23d32d5220ae500a37b52cb7e7a8587c diff --git a/ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift b/ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift index b28a3620d4c6..1d02c01bb364 100755 --- a/ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift +++ b/ios/LibreOfficeLight/LibreOfficeLight/DocumentController.swift @@ -35,7 +35,7 @@ class DocumentController: UIViewController, MenuDelegate, UIDocumentPickerDelega // Show sidemenu (part of documentcontroller) @IBAction func doMenu(_ sender: UIBarButtonItem) { -if (sender.tag == 10) { +if (sender.tag == 99) { sender.tag = 0; let viewMenuBack : UIView = view.subviews.last! @@ -53,7 +53,7 @@ class DocumentController: UIViewController, MenuDelegate, UIDocumentPickerDelega } sender.isEnabled = false -sender.tag = 10 +sender.tag = 99 let sidebar : SidebarController = self.storyboard!.instantiateViewController(withIdentifier: "SidebarController") as! SidebarController view.addSubview(sidebar.view) @@ -129,14 +129,23 @@ class DocumentController: UIViewController, MenuDelegate, UIDocumentPickerDelega popover.sourceView = janTest popover.sourceRect = janTest.bounds present(vc, animated: true, completion: nil) - print("menu Save as... to be done") + case 5: // Save as PDF... print("menu Save as PDF... to be done") case 6: // Print... print("menu Print... to be done") +case 7: // Copy... +print("menu Copy... to be done") + +case 8: // Move... +print("menu Move... to be done") + +case 9: // Delete... +print("menu Delete... to be done") + default: // should not happen print("unknown menu" + String(tag)) } @@ -180,21 +189,21 @@ class DocumentActions: UITableViewController var isDocActive : Bool = false // Calling class might enable/disable each button -@IBOutlet weak var buttonNew: UIButton! -@IBOutlet weak var buttonOpen: UIButton! -@IBOutlet weak var buttonSave: UIButton! -@IBOutlet weak var buttonSaveAs: UIButton! -@IBOutlet weak var buttonSaveAsPDF: UIButton! -@IBOutlet weak var buttonPrint: UIButton! - - - @IBAction func actionMenuSelect(_ sender: UIButton) { dismiss(animated: false) delegate?.actionMenuSelected(sender.tag) } +@IBOutlet weak var buttonNew: UIButton! +@IBOutlet weak var buttonOpen: UIButton! +@IBOutlet weak var buttonSave: UIButton! +@IBOutlet weak var buttonSaveAs: UIButton! +@IBOutlet weak var buttonSaveAsPDF: UIButton! +@IBOutlet weak var buttonPrint: UIButton! +@IBOutlet weak var buttonCopy: UIButton! +@IBOutlet weak var buttonMove: UIButton! +@IBOutlet weak var buttonDelete: UIButton! override func viewDidLoad() { diff --git a/ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard b/ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard index 918081f812fe..299547157e8c 100755 --- a/ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard +++ b/ios/LibreOfficeLight/LibreOfficeLight/en.lproj/Main.storyboard @@ -354,7
[Libreoffice-bugs] [Bug 38643] UI: AutoInput stops proposing after 1 letter if input starts with "+" or "-"
https://bugs.documentfoundation.org/show_bug.cgi?id=38643 Buovjagachanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #10 from Buovjaga --- (In reply to pierre-yves samyn from comment #9) > However, as indicated in comment 6, Calc completes the input by a function > name. > This is normal since formula input beginning with + is accepted. > > So I'm not sure, after thinking, that it's a bug? I asked Eike for a comment: yeah, the dreaded + and - start a formula feature.. invented for data typists who type only on numeric keyboards, which nowadays ~noone has anymore or German keyboards where one has to press Shift as well what a dreaded key combination.. So I guess we should close.. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113425] Convert-to goes into infinite loop if the image's "wrap test" is "square"
https://bugs.documentfoundation.org/show_bug.cgi?id=113425 --- Comment #5 from Buovjaga--- Created attachment 137308 --> https://bugs.documentfoundation.org/attachment.cgi?id=137308=edit GDB trace Trace was requested, I hope this has something useful.. I just Ctrl-C'd out of the looping. Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha1+ Build ID: 02a3abcceeb9be7f101b0bcaf55accc7fb6bfcf7 CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on October 26th 2017 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112825] Errors related to the creation of an HTML document from an .odt source file.
https://bugs.documentfoundation.org/show_bug.cgi?id=112825 Buovjagachanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Buovjaga --- Confirmed with my own .odt (so not tied to the particular document) when system lang is Finnish. Arch Linux 64-bit, KDE Plasma 5 Version: 6.0.0.0.alpha1+ Build ID: 02a3abcceeb9be7f101b0bcaf55accc7fb6bfcf7 CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; Locale: fi-FI (fi_FI.UTF-8); Calc: group Built on October 26th 2017 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113466] Addresses of cells/ cell ranges in input line are not coloured and corresponding cells/ cell ranges are not highlighted with coloured borders
https://bugs.documentfoundation.org/show_bug.cgi?id=113466 bla...@engineer.com changed: What|Removed |Added Summary|Addresses of cells and cell |Addresses of cells/cell |ranges in the input line|ranges in input line are |are not highlighted with|not coloured and |coloured border |corresponding cells/cell ||ranges are not highlighted ||with coloured borders -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113466] New: Addresses of cells and cell ranges in the input line are not highlighted with coloured border
https://bugs.documentfoundation.org/show_bug.cgi?id=113466 Bug ID: 113466 Summary: Addresses of cells and cell ranges in the input line are not highlighted with coloured border Product: LibreOffice Version: 5.4.2.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bla...@engineer.com After entering a formula in the input line, if you go back to that cell and click again on the input line to change the formula, the addresses of cells/cell ranges in the input line are not coloured and the corresponding cells/cell ranges are not highlighted with coloured borders. This makes it impossible to drag cells/cell ranges, in addition to making evaluating formulas very difficult. This bug was not present in 5.3.6. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs