date:20171128

Re: Moztrap question

2017-11-28 Thread Muhammet Kara


Hi Pau,

As far as I know, Mozilla no longer uses Moztrap for testing their 
products. They use Testrail instead: 
https://wiki.mozilla.org/TestEngineering/Testrail


Best,
Muhammet

On 11/28/2017 12:40 PM, Campaña Soler Pau wrote:


Hello.
We are students of Aalto University, and we have to make an study of 
Thunderbird.  We have seen that for the tests cases they use moztrap, 
but all the links of that webite are not working. We have also found in:


https://wiki.documentfoundation.org/MozTrap/User_Guide

that they also use manual test libreoffice, but we do not know how to 
register (https://manual-test.libreoffice.org/login.php?viewer=). Can 
you provide us a link to register or a username and passwoord just to 
see how it inside (we will not make any modification).


If it is not posible, can you tell us if it is used by Thunderbird?

Thanks, Pau.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 103080] A new default set of bundled fonts

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103080

--- Comment #31 from Yannick.D  ---
(In reply to Michael Meeks from comment #30)
> If by default we create documents that hard-code fonts that are not
> available (or have no metrically compatible version) on the majority
> platform - we really hurt our users' ability to save in eg.

I really didn‘t know that - Liberation/C-fonts are correctly replaced by their
counterparts when opened in Word. Cool! (I always thought of compatibility the
other way round.)

(In reply to Yousuf Philips (jay) from comment #29)
> The removal isnt about the size, its about its completeness as a font
> family, its limited unicode coverage, how popular the font is and its future
> potential.

Thank you very much for explaining the thought process, Yousuf!

Still seems a bit half hearted to me. But obviously priorities are a bit
different here (see bug 35538, bug 98596): Source family - despite sorely
missing the still wip italics – is even now much more complete in terms of
OpenType features, font weights, coverage, thought and polish than many of the
other fonts. I rather see it has most "future potential" as a third family
(DejaVu – legacy, Noto - universal language/unicode support, Source – modern).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113169] The vertical layout of double-byte characters and half-width characters is NG

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113169

--- Comment #10 from Junichi Matsukawa  ---
Hi Volga.

Thank you for the information.
I'd like to fix and backport.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source compilerplugins/clang connectivity/source cui/source desktop/source editeng/source i18npool/source include/editeng include/sfx2 include/svx include/tools i

2017-11-28 Thread Noel Grandin

 basic/source/comp/exprnode.cxx  |   12 
 basic/source/inc/expr.hxx   |1 
 compilerplugins/clang/unusedmethods.results |  634 ++--
 compilerplugins/clang/unusedmethods.unused-returns.results  |  174 ---
 connectivity/source/drivers/evoab2/NResultSet.hxx   |5 
 cui/source/customize/cfg.cxx|   39 
 cui/source/inc/cfg.hxx  |2 
 desktop/source/migration/services/oo3extensionmigration.cxx |   12 
 desktop/source/migration/services/oo3extensionmigration.hxx |1 
 editeng/source/rtf/svxrtf.cxx   |   28 
 i18npool/source/localedata/LocaleNode.cxx   |8 
 i18npool/source/localedata/LocaleNode.hxx   |1 
 include/editeng/svxrtf.hxx  |3 
 include/sfx2/objface.hxx|1 
 include/svx/obj3d.hxx   |3 
 include/svx/svdpage.hxx |3 
 include/tools/globname.hxx  |1 
 include/vcl/gdimtf.hxx  |1 
 include/vcl/menu.hxx|1 
 include/vcl/window.hxx  |3 
 lotuswordpro/source/filter/lwpdoc.cxx   |   17 
 lotuswordpro/source/filter/lwpdoc.hxx   |1 
 lotuswordpro/source/filter/lwplayout.cxx|   32 
 lotuswordpro/source/filter/lwplayout.hxx|3 
 lotuswordpro/source/filter/lwppara.hxx  |1 
 lotuswordpro/source/filter/lwppara1.cxx |   11 
 reportdesign/inc/UndoEnv.hxx|2 
 reportdesign/source/core/sdr/UndoEnv.cxx|   26 
 reportdesign/source/ui/inc/ReportControllerObserver.hxx |5 
 reportdesign/source/ui/report/ReportControllerObserver.cxx  |   38 
 sc/inc/attrib.hxx   |   37 
 sc/inc/chartarr.hxx |   17 
 sc/inc/document.hxx |2 
 sc/inc/olinetab.hxx |1 
 sc/source/core/data/attrib.cxx  |   48 
 sc/source/core/data/documen2.cxx|2 
 sc/source/core/data/olinetab.cxx|   54 -
 sc/source/core/tool/chartarr.cxx|   38 
 sc/source/ui/cctrl/checklistmenu.cxx|   13 
 sc/source/ui/inc/checklistmenu.hxx  |1 
 sfx2/source/appl/workwin.cxx|   22 
 sfx2/source/control/objface.cxx |   18 
 sfx2/source/inc/splitwin.hxx|1 
 sfx2/source/inc/workwin.hxx |1 
 sot/source/sdstor/stgdir.cxx|   21 
 sot/source/sdstor/stgdir.hxx|1 
 svx/source/engine3d/obj3d.cxx   |   17 
 svx/source/form/navigatortreemodel.cxx  |   42 
 svx/source/inc/fmexpl.hxx   |2 
 svx/source/svdraw/svdpage.cxx   |   13 
 sw/inc/SwNumberTree.hxx |7 
 sw/inc/pagedesc.hxx |2 
 sw/inc/view.hxx |1 
 sw/source/core/SwNumberTree/SwNumberTree.cxx|   26 
 sw/source/core/access/acctable.cxx  |   91 -
 sw/source/uibase/uiview/viewdraw.cxx|   22 
 tools/source/ref/globname.cxx   |   13 
 vbahelper/source/msforms/vbacontrols.cxx|   13 
 vcl/source/gdi/gdimtf.cxx   |   15 
 vcl/source/window/menu.cxx  |   18 
 vcl/source/window/paint.cxx |   18 
 vcl/source/window/window.cxx|   16 
 62 files changed, 598 insertions(+), 1064 deletions(-)

New commits:
commit a566fd1c1a50f9bcb4c69a19bdf4fb1955285d93
Author: Noel Grandin 
Date:   Tue Nov 28 10:10:40 2017 +0200

loplugin:unusedmethods

Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1
Reviewed-on: https://gerrit.libreoffice.org/45386
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basic/source/comp/exprnode.cxx b/basic/source/comp/exprnode.cxx
index a1ae40a4eacc..ffe7509fe31b 100644
--- a/basic/source/comp/exprnode.cxx
+++ b/basic/source/comp/exprnode.cxx
@@ -177,18 +177,6 @@ bool SbiExprNode::IsLvalue()

[Libreoffice-commits] core.git: filter/source

2017-11-28 Thread Julien Nabet

 filter/source/svg/svgfilter.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 411260d836e7bf6c693b9b7d16af1b36184133af
Author: Julien Nabet 
Date:   Tue Nov 28 21:33:49 2017 +0100

Remove unused typedef B2DPolyPolygonList (filter/svg)

Change-Id: I9bd4fecabdd1cfa90648b285d659d6b491e544c8
Reviewed-on: https://gerrit.libreoffice.org/45439
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/filter/source/svg/svgfilter.hxx b/filter/source/svg/svgfilter.hxx
index e9e8fad10a85..11ae4dea86cc 100644
--- a/filter/source/svg/svgfilter.hxx
+++ b/filter/source/svg/svgfilter.hxx
@@ -70,8 +70,6 @@ static const OUString sPlaceholderTag( "<[:isPlaceholder:]>" 
);
 
 class SVGExport : public SvXMLExport
 {
-typedef ::std::list< ::basegfx::B2DPolyPolygon > B2DPolyPolygonList;
-
 boolmbIsUseTinyProfile;
 boolmbIsEmbedFonts;
 boolmbIsUseOpacity;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - Module_ooo.mk rdbmaker/Executable_rdbmaker.mk rdbmaker/Makefile rdbmaker/Module_rdbmaker.mk rdbmaker/prj RepositoryFixes.mk Repository.mk sane/Make

2017-11-28 Thread Damjan Jovanovic

 Module_ooo.mk   |3 ++
 Repository.mk   |2 +
 RepositoryFixes.mk  |2 +
 rdbmaker/Executable_rdbmaker.mk |   58 
 rdbmaker/Makefile   |   32 ++
 rdbmaker/Module_rdbmaker.mk |   30 
 rdbmaker/prj/build.lst  |6 
 rdbmaker/prj/d.lst  |4 --
 rdbmaker/prj/makefile.mk|   44 ++
 sane/Makefile   |   32 ++
 sane/Module_sane.mk |   30 
 sane/Package_inc.mk |   26 +
 sane/prj/build.lst  |3 --
 sane/prj/d.lst  |3 --
 sane/prj/makefile.mk|   44 ++
 15 files changed, 305 insertions(+), 14 deletions(-)

New commits:
commit aace36ef4f70f9275be9a8143f0c7a0cbebfe5c7
Author: Damjan Jovanovic 
Date:   Wed Nov 29 04:38:04 2017 +

Port main/sane and main/rdbmaker to gbuild.

Add reg to our known libraries (Windows implementation guessed).
Update Module_ooo.mk with unixODBC too.

Patch by: me

diff --git a/Module_ooo.mk b/Module_ooo.mk
index dce43be0f3a1..a0b3b1b65de0 100644
--- a/Module_ooo.mk
+++ b/Module_ooo.mk
@@ -59,8 +59,10 @@ $(eval $(call gb_Module_add_moduledirs,ooo,\
 oox \
 padmin \
 package \
+rdbmaker \
 reportdesign \
 remotebridges \
+sane \
 sax \
 sc \
 sccomp \
@@ -84,6 +86,7 @@ $(eval $(call gb_Module_add_moduledirs,ooo,\
 vbahelper \
 vcl \
 udm \
+unixODBC \
 wizards \
 writerfilter \
 x11_extensions \
diff --git a/Repository.mk b/Repository.mk
index c3242729a65e..a485eb47ffca 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -29,6 +29,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 bmpsum \
 g2g \
 mkunroll \
+rdbmaker \
 rscdep \
 so_checksum \
 srvdepy \
@@ -100,6 +101,7 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
 oox \
 package2 \
 qstart_gtk \
+reg \
 rpt \
 rptui \
 rptxml \
diff --git a/RepositoryFixes.mk b/RepositoryFixes.mk
index 70195f30f003..3b2295e133cc 100644
--- a/RepositoryFixes.mk
+++ b/RepositoryFixes.mk
@@ -83,6 +83,7 @@ gb_Library_FILENAMES := $(patsubst 
ssl:issl%,ssl:ssl%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xml2:ixml2%,xml2:libxml2$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xslt:ixslt%,xslt:libxslt.dll$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
rdf:irdf%,rdf:librdf.dll$(gb_Library_IARCEXT),$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst reg:reg%,reg:reg3%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst z:iz%,z:zlib%,$(gb_Library_FILENAMES))
 
 gb_Library_FILENAMES := $(patsubst 
stl:istl%,stl:msvcprt%,$(gb_Library_FILENAMES))
@@ -141,6 +142,7 @@ gb_Library_FILENAMES := $(patsubst 
ssl:issl%,ssl:ssleay32%,$(gb_Library_FILENAME
 gb_Library_FILENAMES := $(patsubst 
xml2:ixml2%,xml2:libxml2%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
xslt:ixslt%,xslt:libxslt%,$(gb_Library_FILENAMES))
 gb_Library_FILENAMES := $(patsubst 
rdf:irdf%,rdf:librdf%,$(gb_Library_FILENAMES))
+gb_Library_FILENAMES := $(patsubst reg:reg%,reg:reg3%,$(gb_Library_FILENAMES))
 gb_StaticLibrary_FILENAMES := $(patsubst 
graphite:graphite%,graphite:graphite_dll%,$(gb_StaticLibrary_FILENAMES))
 
 gb_Library_FILENAMES := $(patsubst 
stl:istl%,stl:msvcprt%,$(gb_Library_FILENAMES))
diff --git a/rdbmaker/Executable_rdbmaker.mk b/rdbmaker/Executable_rdbmaker.mk
new file mode 100644
index ..c461ef0f4b14
--- /dev/null
+++ b/rdbmaker/Executable_rdbmaker.mk
@@ -0,0 +1,58 @@
+###
+#  
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#  
+#http://www.apache.org/licenses/LICENSE-2.0
+#  
+#  Unless required by applicable law or agreed to in writing,
+#  software distributed under the License is distributed on an
+#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#  KIND, either express or implied.  See the License for the
+#  specific language governing permissions and limitations
+#  under the License.
+#  
+###
+
+
+
+$(eval $(call gb_Executable_Executable,rdbmaker))
+
+$(eval $(call gb_Executable_add_api,rdbmaker,\
+   udkapi \
+))
+
+$(eval $(call gb_Executable_set_include,rdbmaker,\
+

[Libreoffice-bugs] [Bug 79803] Open file dialog should list files relevant to the open module

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79803

--- Comment #26 from cson...@halmai.hu ---
What about introducing a new option into the File Type field of the File ->
Open dialog?

Now we have:
- All files
- Text Documents
- Spreadsheets
- ...
- Database Documents

I think an extra option right at the second place would solve the problem of
many use cases:

- All files
- All LibreOffice files <--- this is the new option here
- Text Documents
- ...
- Spreadsheets
- Database Documents

If the user picks the "All LibreOffice files" option then they can see all the
text documents, spreadsheets, ..., database documents, everything LO can open
but would not see *.zip, *.dll, etc. files. 

In each LO application the "All LibreOffice files" should be the default right
after the installation and later on, when the user changes it in any of the LO
applications then all of the applications whould keep the option the user used
last time _in_that_application_.

This means if you open solely drawings from Draw then you see only drawings in
the dialog of Draw but you still can see "All LO files" in Writer and Calc if
you frequently open texts from Calc and spreadsheets from Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 79803] Open file dialog should list files relevant to the open module

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=79803

--- Comment #26 from cson...@halmai.hu ---
What about introducing a new option into the File Type field of the File ->
Open dialog?

Now we have:
- All files
- Text Documents
- Spreadsheets
- ...
- Database Documents

I think an extra option right at the second place would solve the problem of
many use cases:

- All files
- All LibreOffice files <--- this is the new option here
- Text Documents
- ...
- Spreadsheets
- Database Documents

If the user picks the "All LibreOffice files" option then they can see all the
text documents, spreadsheets, ..., database documents, everything LO can open
but would not see *.zip, *.dll, etc. files. 

In each LO application the "All LibreOffice files" should be the default right
after the installation and later on, when the user changes it in any of the LO
applications then all of the applications whould keep the option the user used
last time _in_that_application_.

This means if you open solely drawings from Draw then you see only drawings in
the dialog of Draw but you still can see "All LO files" in Writer and Calc if
you frequently open texts from Calc and spreadsheets from Writer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 114080] FILESAVE: "Save as Text" doesn' t put end-of-line after each line shown on screen

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114080

tommy27  changed:

   What|Removed |Added

 CC||ba...@quipo.it
Summary|[FILESAVE] Save as Text |FILESAVE: "Save as Text"
   |does not put end-of-line|doesn't put end-of-line
   |after each line shown on|after each line shown on
   |screen  |screen

--- Comment #4 from tommy27  ---
tested under Win8.1 x64 using LibO 5.3.6.1

I opened a blank new Writer document and I typed 4 lines like:

The cat is
on the table.
The dog is 
under the chair.

then I saved as .txt and opened the output which is exactly in 4 lines like the
original text shown on screen.

I tried pasting your dummy text in Writer and then save it as .txt and again
the output is like it appears on screen... I don't reproduce your issue since
my results are different than those in your attached .txt file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104839] [META] Saved XLSX files that MS Excel can't open

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104839

Aron Budea  changed:

   What|Removed |Added

 Depends on||90484


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90484
[Bug 90484] FILEOPEN: Name Conflict - Name cannot be the same as a built-in
name.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90484] FILEOPEN: Name Conflict - Name cannot be the same as a built-in name.

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90484

Aron Budea  changed:

   What|Removed |Added

 Blocks||104839


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104839
[Bug 104839] [META] Saved XLSX files that MS Excel can't open
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114080] [FILESAVE] Save as Text does not put end-of-line after each line shown on screen

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114080

Jay Michael  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Jay Michael  ---
 LibreOffice 5.4.3 behaves the same way as already described:  one line for
each paragraph, rather than one line for each line that appeared on the screen
in Writer.

 I uninstalled LibreOffice 4.2 and installed LibreOffice 5.4.3.  I opened a
new Text Document, set the margins to 3 and 3.5 inches, changed the font to
Courier New, 12 points, and pasted the sample text into the new document.  On
screen, it looks as it did, and as I want:  lots of short lines.  When I Save
as Text, I get what I got before:  one long line for each paragraph.

 There is an option "Save as Text - choose encoding".  It includes the
options of specifying whether I want lines terminated with CR/LF, CR, or LF. 
It makes no mention of manifesting soft returns.  It produces the same output
as "Save as Text".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 2 commits - common/Util.hpp net/Socket.cpp tools/map.cpp

2017-11-28 Thread Michael Meeks

 common/Util.hpp |   51 +
 net/Socket.cpp  |   44 +
 tools/map.cpp   |  114 +---
 3 files changed, 154 insertions(+), 55 deletions(-)

New commits:
commit 0778b726978fffd83f6cc1e75e4f3291ef2b69a4
Author: Michael Meeks 
Date:   Wed Nov 29 03:23:45 2017 +

Dump hex contents of un-shared memory.

Change-Id: I47dfa8a0b48d0ba34b7462301b83e2721617814d

diff --git a/common/Util.hpp b/common/Util.hpp
index e97d1808..c2495a11 100644
--- a/common/Util.hpp
+++ b/common/Util.hpp
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -131,6 +132,56 @@ namespace Util
 // Extract all json entries into a map.
 std::map JsonToMap(const std::string& 
jsonString);
 
+/// Dump data as hex and chars to stream
+inline void dumpHex (std::ostream , const char *legend, const char 
*prefix,
+ const std::vector , const unsigned int 
width = 32)
+{
+unsigned int i, j;
+char scratch[64];
+
+os << legend;
+for (j = 0; j < buffer.size() + width - 1; j += width)
+{
+int skip = 0;
+while (j >= width && j < buffer.size() - width &&
+   !memcmp([j], [j-width], width))
+{
+skip++;
+j += width;
+}
+if (skip > 1)
+{
+j -= width;
+os << "... dup " << skip - 1 << "...\n";
+}
+
+sprintf (scratch, "%s0x%.4x  ", prefix, j);
+os << scratch;
+for (i = 0; i < width; i++)
+{
+if (i && (i % 8) == 0)
+os << " ";
+if ((j + i) < buffer.size())
+sprintf (scratch, "%.2x ", (unsigned char)buffer[j+i]);
+else
+sprintf (scratch, "   ");
+os << scratch;
+}
+os << " | ";
+
+for (i = 0; i < width; i++)
+{
+if ((j + i) < buffer.size() && ::isprint(buffer[j+i]))
+sprintf (scratch, "%c", buffer[j+i]);
+else
+sprintf (scratch, ".");
+os << scratch;
+}
+os << "\n";
+}
+os.flush();
+}
+
 /// Trim spaces from the left. Just spaces.
 inline std::string& ltrim(std::string& s)
 {
diff --git a/net/Socket.cpp b/net/Socket.cpp
index 13424cd3..475649ac 100644
--- a/net/Socket.cpp
+++ b/net/Socket.cpp
@@ -137,50 +137,12 @@ void SocketDisposition::execute()
 _socketMove = nullptr;
 }
 
-namespace {
-
-void dump_hex (std::ostream , const char *legend, const char *prefix, 
std::vector buffer)
-{
-unsigned int i, j;
-char scratch[64];
-
-os << legend;
-for (j = 0; j < buffer.size() + 15; j += 16)
-{
-sprintf (scratch, "%s0x%.4x  ", prefix, j);
-os << scratch;
-for (i = 0; i < 16; i++)
-{
-if ((j + i) < buffer.size())
-sprintf (scratch, "%.2x ", (unsigned char)buffer[j+i]);
-else
-sprintf (scratch, "   ");
-os << scratch;
-if (i == 8)
-os << " ";
-}
-os << " | ";
-
-for (i = 0; i < 16; i++)
-{
-if ((j + i) < buffer.size() && ::isprint(buffer[j+i]))
-sprintf (scratch, "%c", buffer[j+i]);
-else
-sprintf (scratch, ".");
-os << scratch;
-}
-os << "\n";
-}
-}
-
-} // namespace
-
 void WebSocketHandler::dumpState(std::ostream& os)
 {
 os << (_shuttingDown ? "shutd " : "alive ")
<< std::setw(5) << 1.0*_pingTimeUs/1000 << "ms ";
 if (_wsPayload.size() > 0)
-dump_hex(os, "\t\tws queued payload:\n", "\t\t", _wsPayload);
+Util::dumpHex(os, "\t\tws queued payload:\n", "\t\t", _wsPayload);
 os << "\n";
 }
 
@@ -193,9 +155,9 @@ void StreamSocket::dumpState(std::ostream& os)
<< " r: " << _bytesRecvd << "\t w: " << _bytesSent << "\t";
 _socketHandler->dumpState(os);
 if (_inBuffer.size() > 0)
-dump_hex(os, "\t\tinBuffer:\n", "\t\t", _inBuffer);
+Util::dumpHex(os, "\t\tinBuffer:\n", "\t\t", _inBuffer);
 if (_outBuffer.size() > 0)
-dump_hex(os, "\t\toutBuffer:\n", "\t\t", _inBuffer);
+Util::dumpHex(os, "\t\toutBuffer:\n", "\t\t", _inBuffer);
 }
 
 void StreamSocket::send(Poco::Net::HTTPResponse& response)
diff --git a/tools/map.cpp b/tools/map.cpp
index 09cec706..6a1aaefa 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -10,6 +10,7 @@
 #include "config.h"
 
 #include 
+#include 
 
 #include 
 #include 
@@ -23,8 +24,12 @@
 #include 
 #include 
 
+#include 
+
 typedef unsigned long long addr_t;
 
+bool DumpHex = false;
+
 #define MAP_SIZE 20
 #define

[Libreoffice-commits] core.git: sw/source

2017-11-28 Thread Michael Meeks

 sw/source/core/layout/paintfrm.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit b819131347ddb5cdde6cbbc89e93bff95701f3d8
Author: Michael Meeks 
Date:   Wed Nov 29 04:00:05 2017 +

Remove stray SAL_DEBUG.

Change-Id: I5961f5fec6fa757e21184ee15e8ef78eeb2ed459

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 134f79501b0f..776a5b492883 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -5908,7 +5908,6 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 for (tools::Rectangle aTile = tools::Rectangle(aPoint, aTileSize); true; 
aTile.Move(iterX, iterY))
 {
 tools::Rectangle aRender = aComplete.GetIntersection(aTile);
-SAL_DEBUG("Intersect " << aComplete << " with " << aTile << " to " << 
aRender << "bitmap is " << rBitmapEx.GetSizePixel());
 if (aRender.IsEmpty())
 break;
 pOut->DrawBitmapEx(pOut->PixelToLogic(aRender.TopLeft()),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cd-5.3' - sw/source

2017-11-28 Thread Ashod Nakashian

 sw/source/core/layout/paintfrm.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 85a47e76ea80c6a0676ac3b44032361733d44af3
Author: Ashod Nakashian 
Date:   Tue Nov 28 23:00:43 2017 -0500

Axe debug logging

Change-Id: I21a636d6ae1b824d44dc8d30499fcd6948834153
Reviewed-on: https://gerrit.libreoffice.org/45459
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index bee3cd75d2ed..ed716a4c20bd 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -6089,7 +6089,6 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 for (Rectangle aTile = Rectangle(aPoint, aTileSize); true; 
aTile.Move(iterX, iterY))
 {
 Rectangle aRender = aComplete.GetIntersection(aTile);
-SAL_DEBUG("Intersect " << aComplete << " with " << aTile << " to " << 
aRender << "bitmap is " << rBitmapEx.GetSizePixel());
 if (aRender.IsEmpty())
 break;
 pOut->DrawBitmapEx(pOut->PixelToLogic(aRender.TopLeft()),
@@ -6097,7 +6096,6 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
Point(0, 0), aRender.GetSize(),
rBitmapEx);
 }
-
 }
 
 /**
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/source

2017-11-28 Thread Michael Meeks

 sw/source/core/layout/paintfrm.cxx |   39 +
 1 file changed, 27 insertions(+), 12 deletions(-)

New commits:
commit 3f4f6771e939fbe2fd12be6897ca0e27aaa4d55e
Author: Michael Meeks 
Date:   Mon Nov 27 20:53:48 2017 +

Tile the writer surround rendering to avoid large image scaling.

This also fixes a potentially large memory leak depending on zoom,
and particularly with non-paginated rendering.

Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95
Reviewed-on: https://gerrit.libreoffice.org/45426
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit badd7363df0cdd95ddd9ab7f2008edd54dc0cbc9)
Reviewed-on: https://gerrit.libreoffice.org/45427

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 0572d4cf5b7a..7a764e73b6dc 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -6057,6 +6057,7 @@ bool SwPageFrame::IsLeftShadowNeeded() const
 }
 
 enum PaintArea {LEFT, RIGHT, TOP, BOTTOM};
+#define BORDER_TILE_SIZE 512
 
 /// Wrapper around pOut->DrawBitmapEx.
 static void lcl_paintBitmapExToRect(vcl::RenderContext *pOut, const Point& 
aPoint, const Size& aSize, const BitmapEx& rBitmapEx, PaintArea eArea)
@@ -6074,13 +6075,27 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 case BOTTOM: aRect.Bottom() = aRect.Top() + 1; break;
 }
 
-pOut->SetFillColor( SwViewOption::GetAppBackgroundColor());
+pOut->SetFillColor(SwViewOption::GetAppBackgroundColor());
 pOut->SetLineColor();
 pOut->DrawRect(pOut->PixelToLogic(aRect));
 
-pOut->DrawBitmapEx(pOut->PixelToLogic(aPoint), pOut->PixelToLogic(aSize),
-Point(0, 0), aSize,
-rBitmapEx);
+// Tiled render if necessary
+Rectangle aComplete(aPoint, aSize);
+Size aTileSize(BORDER_TILE_SIZE, BORDER_TILE_SIZE);
+
+long iterX = eArea != RIGHT && eArea != LEFT ? BORDER_TILE_SIZE : 0;
+long iterY = eArea == RIGHT || eArea == LEFT ? BORDER_TILE_SIZE : 0;
+
+for (Rectangle aTile = Rectangle(aPoint, aTileSize); true; 
aTile.Move(iterX, iterY))
+{
+Rectangle aRender = aComplete.GetIntersection(aTile);
+if (aRender.IsEmpty())
+break;
+pOut->DrawBitmapEx(pOut->PixelToLogic(aRender.TopLeft()),
+   pOut->PixelToLogic(aRender.GetSize()),
+   Point(0, 0), aRender.GetSize(),
+   rBitmapEx);
+}
 }
 
 /**
@@ -6192,8 +6207,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageRightShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageRightShadow.GetSizePixel().Height() < nHeight)
-aPageRightShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageRightShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageRightShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Right() + mnShadowPxWidth, 
aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6213,8 +6228,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageLeftShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageLeftShadow.GetSizePixel().Height() < nHeight)
-aPageLeftShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageLeftShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageLeftShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(lLeft, aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6225,8 +6240,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Bottom shadow
 const long nBottomHeight = aPageBottomShadow.GetSizePixel().Height();
-if (aPageBottomShadow.GetSizePixel().Width() < aPaintRect.Width())
-aPageBottomShadow.Scale(Size(aPaintRect.Width(), nBottomHeight), 
BmpScaleFlag::Fast);
+if (aPageBottomShadow.GetSizePixel().Width() < BORDER_TILE_SIZE)
+aPageBottomShadow.Scale(Size(BORDER_TILE_SIZE, nBottomHeight), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Left(), aPagePxRect.Bottom() + 2),
@@ -6235,8 +6250,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Top shadow
 const long nTopHeight = aPageTopShadow.GetSizePixel().Height();
-if (aPageTopShadow.GetSizePixel().Width() <

[Libreoffice-commits] core.git: Branch 'distro/collabora/cd-5.3' - sw/source

2017-11-28 Thread Michael Meeks

 sw/source/core/layout/paintfrm.cxx |   41 ++---
 1 file changed, 29 insertions(+), 12 deletions(-)

New commits:
commit badd7363df0cdd95ddd9ab7f2008edd54dc0cbc9
Author: Michael Meeks 
Date:   Mon Nov 27 20:53:48 2017 +

Tile the writer surround rendering to avoid large image scaling.

This also fixes a potentially large memory leak depending on zoom,
and particularly with non-paginated rendering.

Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95
Reviewed-on: https://gerrit.libreoffice.org/45426
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 7626f1cbee60..bee3cd75d2ed 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -6057,6 +6057,7 @@ bool SwPageFrame::IsLeftShadowNeeded() const
 }
 
 enum PaintArea {LEFT, RIGHT, TOP, BOTTOM};
+#define BORDER_TILE_SIZE 512
 
 /// Wrapper around pOut->DrawBitmapEx.
 static void lcl_paintBitmapExToRect(vcl::RenderContext *pOut, const Point& 
aPoint, const Size& aSize, const BitmapEx& rBitmapEx, PaintArea eArea)
@@ -6074,13 +6075,29 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 case BOTTOM: aRect.Bottom() = aRect.Top() + 1; break;
 }
 
-pOut->SetFillColor( SwViewOption::GetAppBackgroundColor());
+pOut->SetFillColor(SwViewOption::GetAppBackgroundColor());
 pOut->SetLineColor();
 pOut->DrawRect(pOut->PixelToLogic(aRect));
 
-pOut->DrawBitmapEx(pOut->PixelToLogic(aPoint), pOut->PixelToLogic(aSize),
-Point(0, 0), aSize,
-rBitmapEx);
+// Tiled render if necessary
+Rectangle aComplete(aPoint, aSize);
+Size aTileSize(BORDER_TILE_SIZE, BORDER_TILE_SIZE);
+
+long iterX = eArea != RIGHT && eArea != LEFT ? BORDER_TILE_SIZE : 0;
+long iterY = eArea == RIGHT || eArea == LEFT ? BORDER_TILE_SIZE : 0;
+
+for (Rectangle aTile = Rectangle(aPoint, aTileSize); true; 
aTile.Move(iterX, iterY))
+{
+Rectangle aRender = aComplete.GetIntersection(aTile);
+SAL_DEBUG("Intersect " << aComplete << " with " << aTile << " to " << 
aRender << "bitmap is " << rBitmapEx.GetSizePixel());
+if (aRender.IsEmpty())
+break;
+pOut->DrawBitmapEx(pOut->PixelToLogic(aRender.TopLeft()),
+   pOut->PixelToLogic(aRender.GetSize()),
+   Point(0, 0), aRender.GetSize(),
+   rBitmapEx);
+}
+
 }
 
 /**
@@ -6192,8 +6209,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageRightShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageRightShadow.GetSizePixel().Height() < nHeight)
-aPageRightShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageRightShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageRightShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Right() + mnShadowPxWidth, 
aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6213,8 +6230,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageLeftShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageLeftShadow.GetSizePixel().Height() < nHeight)
-aPageLeftShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageLeftShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageLeftShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(lLeft, aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6225,8 +6242,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Bottom shadow
 const long nBottomHeight = aPageBottomShadow.GetSizePixel().Height();
-if (aPageBottomShadow.GetSizePixel().Width() < aPaintRect.Width())
-aPageBottomShadow.Scale(Size(aPaintRect.Width(), nBottomHeight), 
BmpScaleFlag::Fast);
+if (aPageBottomShadow.GetSizePixel().Width() < BORDER_TILE_SIZE)
+aPageBottomShadow.Scale(Size(BORDER_TILE_SIZE, nBottomHeight), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Left(), aPagePxRect.Bottom() + 2),
@@ -6235,8 +6252,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Top shadow
 const long nTopHeight = aPageTopShadow.GetSizePixel().Height();
-if

[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83066
Bug 83066 depends on bug 76255, which changed state.

Bug 76255 Summary: Styles not imported correctly when using CJK UI (zh_CN and 
JA at least)
https://bugs.documentfoundation.org/show_bug.cgi?id=76255

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 76255] Styles not imported correctly when using CJK UI ( zh_CN and JA at least)

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=76255

Kevin Suo  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #13 from Kevin Suo  ---
This may not be an issue in most recent versions.

Version: 6.0.0.0.beta1
Build ID：97471ab4eb4db4c487195658631696bb3238656c
CPU 线程：2; 操作系统：Linux 4.13; UI 渲染：默认; VCL: gtk2; 
Locale: zh-CN (zh_CN.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2017-11-28 Thread Michael Meeks

 sw/source/core/layout/paintfrm.cxx |   41 ++---
 1 file changed, 29 insertions(+), 12 deletions(-)

New commits:
commit 91e283e42a5a9bad87e849bce8230eaf65d5ce6e
Author: Michael Meeks 
Date:   Mon Nov 27 20:53:48 2017 +

Tile the writer surround rendering to avoid large image scaling.

This also fixes a potentially large memory leak depending on zoom,
and particularly with non-paginated rendering.

Change-Id: Ia24e0b7baea725020f000a369708b0be3fc20c95
Reviewed-on: https://gerrit.libreoffice.org/45414
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/sw/source/core/layout/paintfrm.cxx 
b/sw/source/core/layout/paintfrm.cxx
index 8d41f27b870b..134f79501b0f 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -5876,6 +5876,7 @@ bool SwPageFrame::IsLeftShadowNeeded() const
 }
 
 enum PaintArea {LEFT, RIGHT, TOP, BOTTOM};
+#define BORDER_TILE_SIZE 512
 
 /// Wrapper around pOut->DrawBitmapEx.
 static void lcl_paintBitmapExToRect(vcl::RenderContext *pOut, const Point& 
aPoint, const Size& aSize, const BitmapEx& rBitmapEx, PaintArea eArea)
@@ -5893,13 +5894,29 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 case BOTTOM: aRect.Bottom() = aRect.Top() + 1; break;
 }
 
-pOut->SetFillColor( SwViewOption::GetAppBackgroundColor());
+pOut->SetFillColor(SwViewOption::GetAppBackgroundColor());
 pOut->SetLineColor();
 pOut->DrawRect(pOut->PixelToLogic(aRect));
 
-pOut->DrawBitmapEx(pOut->PixelToLogic(aPoint), pOut->PixelToLogic(aSize),
-Point(0, 0), aSize,
-rBitmapEx);
+// Tiled render if necessary
+tools::Rectangle aComplete(aPoint, aSize);
+Size aTileSize(BORDER_TILE_SIZE, BORDER_TILE_SIZE);
+
+long iterX = eArea != RIGHT && eArea != LEFT ? BORDER_TILE_SIZE : 0;
+long iterY = eArea == RIGHT || eArea == LEFT ? BORDER_TILE_SIZE : 0;
+
+for (tools::Rectangle aTile = tools::Rectangle(aPoint, aTileSize); true; 
aTile.Move(iterX, iterY))
+{
+tools::Rectangle aRender = aComplete.GetIntersection(aTile);
+SAL_DEBUG("Intersect " << aComplete << " with " << aTile << " to " << 
aRender << "bitmap is " << rBitmapEx.GetSizePixel());
+if (aRender.IsEmpty())
+break;
+pOut->DrawBitmapEx(pOut->PixelToLogic(aRender.TopLeft()),
+   pOut->PixelToLogic(aRender.GetSize()),
+   Point(0, 0), aRender.GetSize(),
+   rBitmapEx);
+}
+
 }
 
 /**
@@ -6011,8 +6028,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageRightShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageRightShadow.GetSizePixel().Height() < nHeight)
-aPageRightShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageRightShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageRightShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Right() + mnShadowPxWidth, 
aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6032,8 +6049,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 {
 const long nWidth = aPageLeftShadow.GetSizePixel().Width();
 const long nHeight = aPagePxRect.Height() - 2 * (mnShadowPxWidth - 
1);
-if (aPageLeftShadow.GetSizePixel().Height() < nHeight)
-aPageLeftShadow.Scale(Size(nWidth, nHeight), 
BmpScaleFlag::Fast);
+if (aPageLeftShadow.GetSizePixel().Height() < BORDER_TILE_SIZE)
+aPageLeftShadow.Scale(Size(nWidth, BORDER_TILE_SIZE), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(lLeft, aPagePxRect.Top() + mnShadowPxWidth - 1),
@@ -6044,8 +6061,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Bottom shadow
 const long nBottomHeight = aPageBottomShadow.GetSizePixel().Height();
-if (aPageBottomShadow.GetSizePixel().Width() < aPaintRect.Width())
-aPageBottomShadow.Scale(Size(aPaintRect.Width(), nBottomHeight), 
BmpScaleFlag::Fast);
+if (aPageBottomShadow.GetSizePixel().Width() < BORDER_TILE_SIZE)
+aPageBottomShadow.Scale(Size(BORDER_TILE_SIZE, nBottomHeight), 
BmpScaleFlag::Fast);
 
 lcl_paintBitmapExToRect(pOut,
 Point(aPaintRect.Left(), aPagePxRect.Bottom() + 2),
@@ -6054,8 +6071,8 @@ static void lcl_paintBitmapExToRect(vcl::RenderContext 
*pOut, const Point& aPoin
 
 // Top shadow
 const long nTopHeight = aPageTopShadow.GetSizePixel().Height();
-if

[Libreoffice-bugs] [Bug 35243] Paste not working, paste special first row is empty

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=35243

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #13 from Kevin Suo  ---
Is this the same issue as in bug 65606? If yes, I suggest we close this one as
a duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65606] Paste special not available

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=65606

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com

--- Comment #12 from Kevin Suo  ---
Bug still exists in most recent 6.0  beta1, Fedora 27 x64.
It is hard to find a pattern how to reliably reproduce, but it happens randomly
in most cases.

As discussed above, a workaround is to save all your work, close all the
libreoffice windows and reopen your work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-cd' - 9 commits - loleaflet/dist loleaflet/main.js loleaflet/src wsd/LOOLWSD.cpp

2017-11-28 Thread Henry Castro

 loleaflet/dist/menubar.css   |2 -
 loleaflet/dist/toolbar/toolbar.js|   50 +++
 loleaflet/main.js|1 
 loleaflet/src/control/Control.Menubar.js |   14 
 loleaflet/src/core/Socket.js |   10 +-
 loleaflet/src/map/Map.js |6 +++
 wsd/LOOLWSD.cpp  |4 ++
 7 files changed, 58 insertions(+), 29 deletions(-)

New commits:
commit 8f8662b57673ea67e1527c8feff90c2ed81a07cb
Author: Henry Castro 
Date:   Tue Sep 19 21:46:09 2017 -0400

loleaflet: fix background color of the top level menu items

Change-Id: I548c700a16664e8acfc6010c1be549e6176f2383
(cherry picked from commit 0d870d444cbbcd1141319f60834bacb80e8d233f)

diff --git a/loleaflet/dist/menubar.css b/loleaflet/dist/menubar.css
index 67279234..de3bb94e 100644
--- a/loleaflet/dist/menubar.css
+++ b/loleaflet/dist/menubar.css
@@ -40,7 +40,6 @@
 }
 
 .lo-menu a.disabled {
-background: #efefef;
 cursor: default;
 }
 .lo-menu > li > a.has-submenu {
@@ -70,7 +69,7 @@
 background: #538ecd;
 color: #fff;
 }
-.lo-menu > li {
+.lo-menu > li, .lo-menu > li > a.disabled {
 background: #efefef; /* top-level menus remain greyish */
 }
 .lo-menu > li > a:hover, .lo-menu > li > a:focus, .lo-menu > li > a:active, 
.lo-menu > li > a.highlighted {
commit a409184f15a0e53e3eae48b012fdaf830f8ad720
Author: Henry Castro 
Date:   Sun Sep 17 11:09:02 2017 -0400

loleaflet: show error when the document is disconnected

Change-Id: I43f8d48002ccb2fc3b6ac9807b72ba6b618d72d2
(cherry picked from commit 1a493880a496b805c6c577262715cc09b1e3cab2)

diff --git a/loleaflet/src/core/Socket.js b/loleaflet/src/core/Socket.js
index 4c09c7f9..f8f0eba1 100644
--- a/loleaflet/src/core/Socket.js
+++ b/loleaflet/src/core/Socket.js
@@ -250,6 +250,10 @@ L.Socket = L.Class.extend({
msg = _('Server is shutting down for 
maintenance (auto-saving)');
postMsgData['Reason'] = 'ShuttingDown';
}
+   else if (textMsg === 'docdisconnected') {
+   msg = _('Oops, there is a problem connecting 
the document');
+   postMsgData['Reason'] = 'DocumentDisconnected';
+   }
else if (textMsg === 'recycling') {
msg = _('Server is recycling and will be 
available shortly');
this._map._active = false;
commit 45c6cd6df53812c7f15f082a0be8f2c10e4840ff
Author: Henry Castro 
Date:   Sun Sep 17 10:33:06 2017 -0400

wsd: notify when the document is disconnected

Change-Id: I36e6df3c576ff0f02d3b059c2f1db4226d527b49
(cherry picked from commit bccdd8d4d7c84e4992c16f75bc3be70c7143b7a0)

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 381c881a..f9c5edc8 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1395,6 +1395,7 @@ private:
 {
 auto lock = docBroker->getLock();
 docBroker->assertCorrectThread();
+docBroker->setCloseReason("docdisconnected");
 docBroker->stop();
 }
 }
commit 71ebd94219ae7903c53782f04528f28ec9e2bd6c
Author: Henry Castro 
Date:   Thu Sep 14 17:36:45 2017 -0400

loleaflet: ignore events before the document is loaded

Change-Id: Icd28854f4430786e1383a7fe6a694f3c7ce9a188
(cherry picked from commit 105eeddae1f058572cf3b6d13edb5ec7ee61473f)

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 1d198c58..787d0f8a 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -1028,7 +1028,7 @@ L.Map = L.Evented.extend({
},
 
_handleDOMEvent: function (e) {
-   if (!this._loaded || !this._enabled || L.DomEvent._skipped(e)) 
{ return; }
+   if (!this._docLayer || !this._loaded || !this._enabled || 
L.DomEvent._skipped(e)) { return; }
 
this.lastActiveTime = Date.now();
 
commit 61bbfaefddcd03dc4d578e62f30f05488d58e605
Author: Henry Castro 
Date:   Wed Sep 13 17:02:26 2017 -0400

wsd: debug: log when the wsd is ready to accept connections

Change-Id: I56ea17af47bc85f30e74f5e93b94e0f3f3d95be4
(cherry picked from commit 2556c2b4418de502a69fac4a2b3267eae91a4c41)

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 9aa3f986..381c881a 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2536,6 +2536,9 @@ int LOOLWSD::innerMain()
 
 /// The main-poll does next to nothing:
 SocketPoll mainWait("main");
+#if ENABLE_DEBUG
+std::cerr << "Ready to accept connections.\n" << std::endl;
+#endif
 
 const auto startStamp = std::chrono::steady_clock::now();
 
commit 80cb49582d19f53a45e47d5b72731ca2973e532d
Author: Henry Castro

[Libreoffice-bugs] [Bug 103080] A new default set of bundled fonts

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103080

--- Comment #30 from Michael Meeks  ---
Hi Yannik:
> Interoperability is of course very valuable to most users so bundling
> those fonts is probably a good idea. My point was more towards that there's
> no need have metrically identical to anything fonts as LOs own default.

If by default we create documents that hard-code fonts that are not available
(or have no metrically compatible version) on the majority platform - we really
hurt our users' ability to save in eg. PPTX and be reasonably sure that the
slides look at least similar on the other side of the divide. That would be a
problem (to me). We could of course use the newer Google C* compatible fonts
Carlito and/or Caladea - but I see these as the only other option for default
fonts in our bundled templates etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114126] New: Alphabet characters not showing, not only the menu bar but also a word processing document

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114126

Bug ID: 114126
   Summary: Alphabet characters not showing, not only the menu bar
but also a word processing document
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: burlington...@gmail.com

Description:
Opening libreoffice to read a document and the menu's only showed under scores.
The word processing document did not show any character. There were a few red
squiggly lines shown.

Using Win10 64 bit. Dell Vostro

Checked that this seems to be an existing problem from time to time so I tried
the following, none were successful

1. Unchecked the OpenGL rendering option.
2. Open Libreoffice in Safe Mode, did not work from normal opening. Opened
using the command line in Safe mode. Display was still showing nothing. 
3. Renamed the User profile  and reopened LO to recreate a new User profile
4. Uninstalled LO, removed user profiles, removed all registry entries related
to LO.
Reinstalled LO. 

I can't recall what happened between Sunday evening and Monday evening. Sunday
evening all was working, Monday evening the problem started. I did not install
any software on Sunday evening, that I'm aware of.



Steps to Reproduce:
1. Just open LO. 
2.
3.

Actual Results:  
the selection page will show underscored in the menu. Opening a writer document
shows a blank page

Expected Results:
All text should be shown, not just in the menu but also the document itself


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109240] FILESAVE XLSX: Use of Data > AutoFilter provoke auto-creation of multiple defined Name ranges over multiple consecutive save in XLSX format of the same file causing com

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=109240

--- Comment #4 from Aron Budea  ---
I can reproduce the multiplication of named ranges, but not the corruption. Can
you or anyone share a simple file that was created with these steps in Calc (or
similar steps involving autofilter), and Excel complains about it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114125] New: Lockup when saving files

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114125

Bug ID: 114125
   Summary: Lockup when saving files
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: itc...@compuserve.com

In OpenMnadriva Lx3.03 all office applications with the exception of impress
fail to save files in the LO native format. Files may be saved in other formats
without issue. A backtrace and more information may be found here
https://issues.openmandriva.org/show_bug.cgi?id=2259
Exporting the variable VCL_NO_THREAD_SCALE=1 fixes the issue.
Thanks to vmiklos for the workaround

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112571] FILESAVE XLSX New named range is created every time an Excel made spreadsheet that contains print ranges is saved as XLSX

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112571

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |ba...@caesar.elte.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114088] Names of new templates not localized

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114088

Gabor Kelemen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113670] UI Undocking the main toolbars and clicking insert textbox crashes the app

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113670

--- Comment #7 from Xisco Faulí  ---
After the changes done by Caolán, is this issue still reproducible in master?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114105] Crash on closing Data source window

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114105

--- Comment #6 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 2618e4a13d719122e6358d9d96864d1691e56a02
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: th-TH (ca_ES.UTF-8); Calc: group threaded

Do you drag any column in particular?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114123] LO.Calc.Graph is illegible

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114123

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #2 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114079] Application window is higher then the screen and minimize/ maximize functions stop to work, starting from the moment when an edited file is closed.

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114079

Kevin Suo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #6 from Kevin Suo  ---
(In reply to Nimrod from comment #5)
Please  upgrade  to a most recent Libreoffice version to see if the  bug  is
still there. The most recent Still version is 5.3.7.2, and the most  recent
Fresh version is 5.4.3.2.

If the bug is still reproducible in the newest version, please set the Status
field of this bug back to UNCONFIRMED.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114124] "PNG Bitmap" string not translatable in Standard Toolbar - Paste dropdown list

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114124

Gabor Kelemen  changed:

   What|Removed |Added

 Blocks||114068


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114068
[Bug 114068] [META] Text strings that are not yet possible to localize
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114068] [META] Text strings that are not yet possible to localize

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114068

Gabor Kelemen  changed:

   What|Removed |Added

 Depends on||114124


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114124
[Bug 114124] "PNG Bitmap" string not translatable in Standard Toolbar - Paste
dropdown list
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114124] New: "PNG Bitmap" string not translatable in Standard Toolbar - Paste dropdown list

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114124

Bug ID: 114124
   Summary: "PNG Bitmap" string not translatable in Standard
Toolbar - Paste dropdown list
   Product: LibreOffice
   Version: 6.0.0.0.beta1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 138051
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138051=edit
Screenshot of the submenu in Calc wiht KeyID localization

In Calc, enter some text in a cell, then copy the cell.
Open the Standard toolbars Paste dropdown list.
Among other options with translated names there is a "PNG Bitmap" option that
is not translatable unlike the others.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - extensions/source

2017-11-28 Thread Matthias Seidel

 extensions/source/config/ldap/ldapaccess.hxx|2 +-
 extensions/source/config/ldap/ldapuserprofilebe.hxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7ff777edb7e373243f6e66720df1886dea6f7141
Author: Matthias Seidel 
Date:   Tue Nov 28 22:44:54 2017 +

Fixed typos

diff --git a/extensions/source/config/ldap/ldapuserprofilebe.hxx 
b/extensions/source/config/ldap/ldapuserprofilebe.hxx
index 38a68f17b0c0..84cac1b6e0c4 100644
--- a/extensions/source/config/ldap/ldapuserprofilebe.hxx
+++ b/extensions/source/config/ldap/ldapuserprofilebe.hxx
@@ -50,8 +50,8 @@ typedef 
cppu::WeakComponentImplHelper2
Date:   Tue Nov 28 22:07:39 2017 +

Fixed typo

diff --git a/extensions/source/config/ldap/ldapaccess.hxx 
b/extensions/source/config/ldap/ldapaccess.hxx
index 9d0856d95166..851d71eb5320 100644
--- a/extensions/source/config/ldap/ldapaccess.hxx
+++ b/extensions/source/config/ldap/ldapaccess.hxx
@@ -82,7 +82,7 @@ struct LdapDefinition
 
 typedef std::map< rtl::OUString, rtl::OUString > LdapData; // key/value pairs
 
-/** Class encapulating all LDAP functionality */
+/** Class encapsulating all LDAP functionality */
 class LdapConnection
 {
 friend struct LdapMessageHolder;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

2017-11-28 Thread Tor Lillqvist

 sc/inc/tokenarray.hxx|3 +++
 sc/source/core/data/conditio.cxx |   17 +
 sc/source/core/tool/token.cxx|   17 +
 3 files changed, 21 insertions(+), 16 deletions(-)

New commits:
commit aa28b54ab568fb7160095bb4a2fec338b1398b43
Author: Tor Lillqvist 
Date:   Tue Nov 28 12:38:03 2017 +0200

Do as the FIXME suggested

Not exactly, though. The FIXME said "Make this a comparison operator
at the TokenArray?" but I think that would be misleading as the code
in question specifically does not check the TokenArrays for being
completely identical; it intentionally ignores the RPN part. So make
it a member function 'EqualTokens' instead.

Change-Id: I15d840c422844fa144415a76c1f8fcbd6cae3c83
Reviewed-on: https://gerrit.libreoffice.org/45404
Reviewed-by: Bartosz Kosiorek 
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx
index 8b352b447f09..927b77bc5ffd 100644
--- a/sc/inc/tokenarray.hxx
+++ b/sc/inc/tokenarray.hxx
@@ -59,6 +59,9 @@ public:
 (not copied!) */
 ScTokenArray( const ScTokenArray& );
 virtual ~ScTokenArray() override;
+
+bool EqualTokens( const ScTokenArray* pArr2 ) const;
+
 virtual void Clear() override;
 ScTokenArray* Clone() const;/// True copy!
 
diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index 940181582b22..ca6b49f20a75 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -619,26 +619,11 @@ void ScConditionEntry::UpdateMoveTab( 
sc::RefUpdateMoveTabContext& rCxt )
 StartListening();
 }
 
-//FIXME: Make this a comparison operator at the TokenArray?
 static bool lcl_IsEqual( const ScTokenArray* pArr1, const ScTokenArray* pArr2 )
 {
 // We only compare the non-RPN array
 if ( pArr1 && pArr2 )
-{
-sal_uInt16 nLen = pArr1->GetLen();
-if ( pArr2->GetLen() != nLen )
-return false;
-
-FormulaToken** ppToken1 = pArr1->GetArray();
-FormulaToken** ppToken2 = pArr2->GetArray();
-for (sal_uInt16 i=0; iEqualTokens( pArr2 );
 else
 return !pArr1 && !pArr2; // Both 0? -> the same
 }
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index a849e034e176..55cbb9f1a7fc 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1852,6 +1852,23 @@ ScTokenArray& ScTokenArray::operator=( const 
ScTokenArray& rArr )
 return *this;
 }
 
+bool ScTokenArray::EqualTokens( const ScTokenArray* pArr2) const
+{
+// We only compare the non-RPN array
+if ( pArr2->nLen != nLen )
+return false;
+
+FormulaToken** ppToken1 = GetArray();
+FormulaToken** ppToken2 = pArr2->GetArray();
+for (sal_uInt16 i=0; i

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.3-32'

2017-11-28 Thread Christian Lohmaier

Tag 'cp-5.3-32' created by Andras Timar  at 
2017-11-28 22:49 +

cp-5.3-32

Changes since cp-5.3-10:
Christian Lohmaier (1):
  update translations for 5.3.3 rc2

---
 source/am/cui/source/options.po|8 
 source/am/cui/source/tabpages.po   |8 
 source/am/cui/uiconfig/ui.po   |8 
 source/am/fpicker/source/office.po |   10 
 source/am/officecfg/registry/data/org/openoffice/Office.po |6 
 source/am/sc/source/ui/src.po  |8 
 source/am/sfx2/source/dialog.po|   12 
 source/am/svtools/source/dialogs.po|8 
 source/am/svtools/source/misc.po   |8 
 source/am/svx/source/stbctrls.po   |8 
 source/am/svx/uiconfig/ui.po   |   10 
 source/bg/sc/uiconfig/scalc/ui.po  |   20 
 source/bg/sfx2/source/dialog.po|   12 
 source/bg/svx/source/dialog.po |   30 
 source/bg/svx/source/form.po   |   10 
 source/bg/svx/source/stbctrls.po   |8 
 source/bg/svx/source/tbxctrls.po   |6 
 source/bg/svx/uiconfig/ui.po   |  289 
 source/bg/sw/source/ui/utlui.po|   21 
 source/bg/sw/source/uibase/utlui.po|6 
 source/bg/sw/uiconfig/swriter/ui.po|5 
 source/br/cui/uiconfig/ui.po   |   70 -
 source/br/extensions/source/bibliography.po|   12 
 source/br/extensions/source/propctrlr.po   |  152 ++--
 source/br/sc/source/ui/src.po  |   12 
 source/ca/helpcontent2/source/text/scalc/00.po |   20 
 source/ca/helpcontent2/source/text/scalc/01.po |8 
 source/ca/helpcontent2/source/text/scalc/guide.po  |   10 
 source/ca/helpcontent2/source/text/shared/01.po|6 
 source/ca/helpcontent2/source/text/shared/guide.po |5 
 source/ca/helpcontent2/source/text/shared/optionen.po  |8 
 source/ca/helpcontent2/source/text/simpress/guide.po   |   10 
 source/ca/helpcontent2/source/text/swriter/01.po   |   13 
 source/ca/helpcontent2/source/text/swriter/guide.po|   25 
 source/ca/officecfg/registry/data/org/openoffice/Office/UI.po  |8 
 source/ca/sc/uiconfig/scalc/ui.po  |6 
 source/ca/svx/uiconfig/ui.po   |   12 
 source/cy/cui/uiconfig/ui.po   |8 
 source/cy/sfx2/source/dialog.po|   12 
 source/cy/sfx2/uiconfig/ui.po  |   15 
 source/cy/svtools/source/dialogs.po|8 
 source/cy/svtools/source/misc.po   |8 
 source/cy/svx/source/stbctrls.po   |   10 
 source/cy/svx/uiconfig/ui.po   |   10 
 source/da/cui/uiconfig/ui.po   |8 
 source/da/helpcontent2/source/text/scalc/01.po |   12 
 source/da/sfx2/source/dialog.po|   14 
 source/da/sfx2/uiconfig/ui.po  |   17 
 source/da/svtools/source/dialogs.po|   10 
 source/da/svtools/source/java.po   |   12 
 source/da/svtools/source/misc.po   |   10 
 source/da/svx/source/stbctrls.po   |8 
 source/da/svx/uiconfig/ui.po   |   12 
 source/de/editeng/source/items.po  |   10 
 source/de/formula/source/core/resource.po  |8 
 source/de/helpcontent2/source/auxiliary.po |6 
 source/de/helpcontent2/source/text/sbasic/shared/01.po |   10 
 source/de/helpcontent2/source/text/scalc.po|6 
 source/de/helpcontent2/source/text/scalc/00.po |6 
 source/de/helpcontent2/source/text/scalc/01.po |  100 +-
 source/de/helpcontent2/source/text/scalc/guide.po  |   34 
 source/de/helpcontent2/source/text/schart/01.po|6 
 source/de/helpcontent2/source/text/shared/00.po|   10 
 source/de/helpcontent2/source/text/shared/01.po|   12 
 source/de/helpcontent2/source/text/shared/explorer/database.po |8 
 source/de/helpcontent2/source/text/shared/guide.po |   16

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.3-32'

2017-11-28 Thread Andras Timar

Tag 'cp-5.3-32' created by Andras Timar  at 
2017-11-28 22:49 +

cp-5.3-32

Changes since libreoffice-5-3-branch-point-28:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.3-32'

2017-11-28 Thread Olivier R

Tag 'cp-5.3-32' created by Andras Timar  at 
2017-11-28 22:49 +

cp-5.3-32

Changes since cp-5.3-10:
Olivier R (1):
  tdf#107558 French spelling dictionary (6.0.3) and thesaurus

---
 fr_FR/README_fr.txt   |4 
 fr_FR/description.xml |2 
 fr_FR/fr.aff  |17751 ++--
 fr_FR/fr.dic  |155369 
+-
 fr_FR/package-description.txt |2 
 fr_FR/thes_fr.dat |  206 
 6 files changed, 88495 insertions(+), 84839 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.3-32'

2017-11-28 Thread Andras Timar

Tag 'cp-5.3-32' created by Andras Timar  at 
2017-11-28 22:49 +

cp-5.3-32

Changes since cp-5.3-31-55:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 2 commits - configure.ac sc/source

2017-11-28 Thread Andras Timar

 configure.ac   |2 +-
 sc/source/filter/excel/xltools.cxx |6 +-
 sc/source/filter/inc/xltools.hxx   |4 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit b1da09649d96dbef2a989a9b1a02054bd7c65ba5
Author: Andras Timar 
Date:   Tue Nov 28 23:48:30 2017 +0100

Bump version to 5.3-32

Change-Id: Ia81627cb441158edd1e24d4cfb4b9c3f95853ec6

diff --git a/configure.ac b/configure.ac
index 069cee6af162..8b8bc3bf26b9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[5.3.10.31],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.3.10.32],[],[],[https://collaboraoffice.com/])
 
 AC_PREREQ([2.59])
 
commit bba57a7eb9dd118df5772068b3a70aedb3602003
Author: Aron Budea 
Date:   Tue Nov 28 07:23:12 2017 +0100

tdf#109240, tdf#112571: don't export dupe built-in named ranges

XclTools::GetBuiltInDefNameIndex(...) only checked for prefix used in
binary Excel format, and didn't recognize OOXML built-in names, which
resulted in saving them twice in OOXML files.

Adapt to check both binary and OOXML prefixes, similarly to
XclTools::IsBuiltInStyleName(...).

Saving "bad" files after the fix will purge bad "_0", "_0_0" etc.
suffixed built-in names due to how GetBuiltInDefNameIndex(...) works.

Change-Id: I1bbe11f9c654a142a4626003df4cb0fd2a0f9c71

diff --git a/sc/source/filter/excel/xltools.cxx 
b/sc/source/filter/excel/xltools.cxx
index f2e33cff9539..f8a670d3f477 100644
--- a/sc/source/filter/excel/xltools.cxx
+++ b/sc/source/filter/excel/xltools.cxx
@@ -482,8 +482,12 @@ OUString XclTools::GetBuiltInDefNameXml( sal_Unicode 
cBuiltIn )
 
 sal_Unicode XclTools::GetBuiltInDefNameIndex( const OUString& rDefName )
 {
-sal_Int32 nPrefixLen = strlen(maDefNamePrefix);
+sal_Int32 nPrefixLen = 0;
 if( rDefName.startsWithIgnoreAsciiCase( maDefNamePrefix ) )
+nPrefixLen = strlen(maDefNamePrefix);
+else if( rDefName.startsWithIgnoreAsciiCase( maDefNamePrefixXml ) )
+nPrefixLen = strlen(maDefNamePrefixXml);
+if( nPrefixLen > 0 )
 {
 for( sal_Unicode cBuiltIn = 0; cBuiltIn < EXC_BUILTIN_UNKNOWN; 
++cBuiltIn )
 {
diff --git a/sc/source/filter/inc/xltools.hxx b/sc/source/filter/inc/xltools.hxx
index 2a202c3800b4..0939cddd6947 100644
--- a/sc/source/filter/inc/xltools.hxx
+++ b/sc/source/filter/inc/xltools.hxx
@@ -189,8 +189,8 @@ public:
 static OUString GetBuiltInDefNameXml( sal_Unicode cBuiltIn );
 /** Returns the Excel built-in name index of the passed defined name from 
Calc.
 @descr  Ignores any characters following a valid representation of a 
built-in name.
-@param pcBuiltIn  (out-param) If not 0, the index of the built-in name 
will be returned here.
-@return  true = passed string is a built-in name; false = user-defined 
name. */
+@param rDefName  raw English UI representation of a built-in defined 
name used in NAME records.
+@return  the index of the built-in name, or EXC_BUILTIN_UNKNOWN if it 
is not a built-in name. */
 static sal_Unicode  GetBuiltInDefNameIndex( const OUString& rDefName );
 
 // built-in style names ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114118] Add a ditto key to copy the above cell content

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114118

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Regina Henschel  ---
Already requested.

*** This bug has been marked as a duplicate of bug 53602 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 53602] Copy value from cell above by one button click

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=53602

Regina Henschel  changed:

   What|Removed |Added

 CC||dcmo...@yahoo.com

--- Comment #4 from Regina Henschel  ---
*** Bug 114118 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

BUILD FAIL WITH LIBREOFFICE ANDROID

2017-11-28 Thread Mert Tümer

Hello,

I am getting this error while building libreoffice with the android viewer:


[build MAK] CustomTarget/android/source/done
make[2]: Warning: File '/home/mert/libreoffice/config_build.mk' has 
modification time 5720 s in the future
creating liboSettings.gradle
Linking obj/local/armeabi-v7a/liblo-native-code.so
/home/mert/libreoffice/workdir/UnpackedTarball/icu/source/lib/libicuuc.a(udata.ao):udata.cpp:function
 openCommonData(char const*, int, UErrorCode*): error: undefined reference to 
'icudt60_dat'
/home/mert/libreoffice/workdir/UnpackedTarball/icu/source/lib/libicuuc.a(udata.ao):udata.cpp:function
 openCommonData(char const*, int, UErrorCode*): error: undefined reference to 
'icudt60_dat'
clang++: error: linker command failed with exit code 1 (use -v to see 
invocation)
../Bootstrap/Makefile.shared:61: recipe for target 
'obj/local/armeabi-v7a/liblo-native-code.so' failed
make[2]: *** [obj/local/armeabi-v7a/liblo-native-code.so] Error 1
/home/mert/libreoffice/android/CustomTarget_lo_android.mk:17: recipe for target 
'/home/mert/libreoffice/workdir/CustomTarget/android/source/done' failed
make[1]: *** [/home/mert/libreoffice/workdir/CustomTarget/android/source/done] 
Error 2
Makefile:268: recipe for target 'build' failed
make: *** [build] Error 2

Why am i getting this and is there anything i can do to fix this?


Regards,

Mert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114110] Sifr icon for .uno:Open command with black inner part

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114110

Papamatti  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |matti...@mailbox.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114110] Sifr icon for .uno:Open command with black inner part

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114110

--- Comment #1 from Papamatti  ---
It's the iconset for a dark window theme, you have to chose sifr instead of
sifr dark. Yes it is intended.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Need code pointer for import of attributes

2017-11-28 Thread Michael Stahl

On 26.11.2017 23:01, Regina Henschel wrote:
> Hi Michael,
> 
> Michael Stahl schrieb am 23.11.2017 um 21:37:
>> On 22.11.2017 17:32, Regina Henschel wrote:
>>> Hi all,
>>>
>>> I've started on
>>> https://bugs.documentfoundation.org/show_bug.cgi?id=101242. My current
>>> work is in the attachment.
>>>
>>> Problem: Although I remove the config-items IsVisible, IsPrintable,
>>> IsLocked from the settings.xml of a file, the values from draw:display
>>> and draw:locked of the  element are not used. It seems to
>>> me, that somewhere the read values are overwritten with a default.
>>>
>>> Where and when are the values from settings.xml transformed to
>>> properties of the layers of a newly opened draw document?
>>
>> probably in sd/source/ui/view/frmview.cxx,
>> FrameView::ReadUserDataSequence(), around line 858
> 
> There the values from settings.xml are indeed read, but it sets no 
> defaults. If the node does not exists, nothing is changed.
> 
>>
>>> Any other hint, where to look?
>>
>> there are SetVisibleLayers functions on 3 different classes, maybe
>> setting breakpoints on those would be helpful.
> 
> "setting breakpoints" was a good tip.
> 
> I use VS2017 and there is no "vs2017-ide-integration" yet. But I have 
> tried the "vs2015-ide-integration" and it seems to work :)
> 
> I looked a little bit around for SetVisibleLayers and SdrLayerIDSet 
> without success.
> 
> Then I started from the other end and looked what happens with my not 
> working
> xLayer->setPropertyValue("IsLocked",(msbProtected == "true") ? Any(true) 
> : Any(false) );
> compared to the working
> xLayer->setPropertyValue("Title", Any( sTitleBuffer.makeStringAndClear() 
> ) );
> 
> I found this:
> setPropertyValue is a method of class SdLayer [in 
> sd\source\ui\unoidl\unolayer.hxx]
> 
> The SdLayer itself has no members to store the information. In case of 
> "Title" the SdrLayer is used, for which the SdLayer has a pointer. This 
> SdrLayer has the member maTitle to take the information. It has no 
> members to take IsLocked, IsVisible or IsPrintable.
> 
> In case of "IsLocked" the SdLayer uses its member mxLayerManager to get 
> a View of a page or a FrameView of the DocShell. But both doesn't exists 
> at this stage, when loading a document. So the call of set(...) returns 
> false; the source has the comment "//TODO: uno::Exception?"
> 
> The result is, that the information is not overwritten as I first 
> thought, but is simple lost.

the properties can only be initialised once the View is created, after
the document has been imported.

well that is unfortunate.

> A  can have its own . But the 
>  to be used for the page can also be inherited from a 
> master page via  or . Therefore 
> a solution is needed, which can be extended to support all three places.

looking at xmloff, there is exactly one draw:layer-set per document, in
office:master-styles, and it's written by a call to
SdXMLayerExporter::exportLayer().

the other 2 parents of draw:layer-set in ODF, we currently don't support.

> As you know, currently the IsLocked/IsVisible/IsPrintable is not stored 
> in the document itself, but in the settings.xml, despite the fact, that 
> ODF can express the information. [Remember ODF TC discussion on 
> OFFICE-3693 to not use settings.xml in those cases.]

looking at the structure of an ODG settings.xml, it's clear that there
can be multiple "View"s, each with a different "VisibleLayers" etc.

such a document can be created in Draw with Window->New and
right-clicking on the layer tabs, you can set the visibilities so that
one window shows a shape and the other not.

however it appears this is currently quite broken: the settings.xml
contains 2 config-item-map-entry elements; the first one looks correct
and the second one has the wrong ViewId "view1" identical to the first
one, and also all of the config-items of the first one are duplicated
inside it (it has twice as many items).

if i manually fix these problems and load the document, still only a
single window is created.

OOo 3.3 already has all of these problems.

> New members mbIsLocked, mbIsVisible and mbIsPrintable for the SdrLayer 
> would likely work [not worked out yet] as long as the layer settings are 
> unique throughout the document, but they need not be unique in ODF.

this would store the properties in the document model, while
(apparently) they currently exist only in the view?

... i think there's an argument to be made that we need to retain these
as view properties: while that cannot be persisted to files currently
due to all the bugs, it's still useful to have purely at run-time.

on the other hand, as view properties they obviously can't support the
currently missing feature of layers inside draw:page or style:master-page.

guess one way to handle it is to set the styles.xml attributes on the
one and only view that is created after loading - but because the view
is created so late, the attributes need to be stored temporarily in some
place and then

[Libreoffice-bugs] [Bug 114123] LO.Calc.Graph is illegible

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114123

--- Comment #1 from Mark C  ---
Created attachment 138050
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138050=edit
graph legible when it is selected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114123] New: LO.Calc.Graph is illegible

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114123

Bug ID: 114123
   Summary: LO.Calc.Graph is illegible
   Product: LibreOffice
   Version: 5.2.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: anicest...@gmail.com

Created attachment 138049
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138049=edit
illegible graph when not selected

Version: 5.2.7.2 Build ID: Gentoo official package CPU Threads: 8; OS Version:
Linux 4.11; UI Render: default; VCL: kde4; Locale: en-US (C); Calc: group

When not open, the graph is so small that it is illegible. If I select the
chart (single click), I can see the handles of the graph but the graph only
takes up a small part of that area.

If I double click the graph, it takes up all the space of the handles, but as
soon as I click outside of the graph, then the graph shrinks back to the
illegible size.

I have screen shots but don't know how to include them in this bug report. I
hope this works

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113937] Forms and reports hang

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113937

--- Comment #25 from Ralph Peters  ---
(In reply to Buovjaga from comment #24)
> (In reply to Ralph Peters from comment #23)
> > I suppose that a set of "dbgsym" deb files are available for 5.4.2?  I
> > looked, but was unable to find them.
> 
> They are supposed to be in your distribution's package repository. Ubuntu
> has them, but I am not sure about Linux Mint.
> 
> If you are unable to find them, the 6.0 debug build should do (if the
> problem still happens).

Ubuntu should work just fine.

OK, I spent some time looking at Ubuntu and did not see what you are talking
about.  Would it be possible for you to provide a link to what you think is the
BEST download (.tgz file) for me to use?

Thanks,
Ralph Peters

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103080] A new default set of bundled fonts

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103080

--- Comment #29 from Yousuf Philips (jay)  ---
(In reply to Yannick.D from comment #21)
> I‘m not against removing fonts in general. But why is Source Sans/Code now
> being removed?

We didn't add the entire font family in LO 4.0 and its unlikely that we will
add the serif variant any time soon, as it doesnt come in italics (bug 79022).

> They have only been mentioned in the context of Ubuntu
> packaging. How is that an argument?

So debian also doesnt package the Source font family. It is available in fedora
and opensuse repos though. The argument is about how wide spread the open
source font is in the linux/foss world.

> Its one of the most sophisticated open
> source fonts projects. Why remove it without discussion? For a gain of 2MB?!

Discussions were had about its removal in the design and ESC meetings last
week. The removal isnt about the size, its about its completeness as a font
family, its limited unicode coverage, how popular the font is and its future
potential.

> - Why keep Gentium Book? (Or even Gentium if others are removed?)
> - Why don't replace Libertine/Biolinum Graphite versions with OTF? What
> about its display cut?
> - Why keep all those DejaVu fonts? (Which are also rather similar to Noto…)

During the ESC meeting on October 26th, the decision was made not to remove
Libertine/Biolinum and DejaVu fonts as it would effect alot of documents that
were created with these fonts, which have been shipping with LO since 3.3, as
well as OOo.

(In reply to sommerluk from comment #22)
> I would rather think about Noto Sans Arabic instead of Noto Kufi…

We also plan to include Noto Sans Arabic. See bug 113532 for more details.

(In reply to Francisco from comment #24)
> just remember to remove/update all the templates based on the specific font
> you are deleting. Specially the ones based on Source Sans.

Yes those are being updated (bug 113795).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - cui/inc

2017-11-28 Thread László Németh

 cui/inc/strings.hrc |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit f0a2fee5006f27b8ebf2b2e583964818986caec5
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Tue Nov 28 14:05:45 2017 +0100

Add comment to translators of "Grammar By" text entry box

Change-Id: Ifea74df8f113967c9df9703cf6582360ffdfa78d
Reviewed-on: https://gerrit.libreoffice.org/45410
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 
(cherry picked from commit 217b1e8e94859e06af66023f042c53cf329f5232)
Reviewed-on: https://gerrit.libreoffice.org/45442
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index f60f504bd451..dca50c2cd57a 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -268,6 +268,20 @@
 #define RID_SVXSTR_CHG_SMARTART 
NC_("RID_SVXSTR_CHG_SMARTART", "SmartArt to %PRODUCTNAME shapes or reverse")
 
 #define RID_SVXSTR_OPT_DOUBLE_DICTS 
NC_("RID_SVXSTR_OPT_DOUBLE_DICTS", "The specified name already exists.\nPlease 
enter a new name.")
+/* To translators:
+   Please, try to find a similar *short* translation to avoid
+   to get narrow "New" field in the "Edit custom dictionary" window,
+   for example, "Model word for optional affixation and compounding"
+   is too long, but "Grammar By" is a good name here (help page of
+   the window contains the details).
+
+   "Grammar By" text entry box of the "Edit custom dictionary" window
+   contains an optional model word associated to the new user word,
+   allowing its affixation or compounding during spell checking.
+   For example, adding "Grammar By" word "fund" to the new user
+   word "crowdfund", the spell checker will recogize "crowdfund"
+   with suffixes of "fund": "crowdfunding", "crowdfund's" etc.
+*/
 #define RID_SVXSTR_OPT_GRAMMAR_BY   
NC_("RID_SVXSTR_OPT_GRAMMAR_BY", "~Grammar By")
 #define STR_MODIFY  NC_("STR_MODIFY", 
"~Replace")
 #define RID_SVXSTR_CONFIRM_SET_LANGUAGE 
NC_("RID_SVXSTR_CONFIRM_SET_LANGUAGE", "Do you want to change the '%1' 
dictionary language?")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sd/qa sd/source

2017-11-28 Thread Henry Castro

 sd/qa/unit/tiledrendering/data/notes-view.odp |binary
 sd/qa/unit/tiledrendering/tiledrendering.cxx  |   29 ++
 sd/source/ui/unoidl/unomodel.cxx  |4 ---
 sd/source/ui/view/ImpressViewShellBase.cxx|   18 
 4 files changed, 39 insertions(+), 12 deletions(-)

New commits:
commit 394506840a6bfc8684e89292cefff7088557a915
Author: Henry Castro 
Date:   Tue Nov 14 16:15:52 2017 -0400

sd lok: ensure default view

In Tiled rendering case, the only default view is supported

Change-Id: Ia6df85dba28f8ebb41bdc20ae48916b0437ea185
Reviewed-on: https://gerrit.libreoffice.org/44737
Tested-by: Jenkins 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/44744
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/sd/qa/unit/tiledrendering/data/notes-view.odp 
b/sd/qa/unit/tiledrendering/data/notes-view.odp
new file mode 100644
index ..d41bdf9599a4
Binary files /dev/null and b/sd/qa/unit/tiledrendering/data/notes-view.odp 
differ
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 55d5712fe632..6b27320bc0d0 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -8,6 +8,7 @@
  */
 
 #include "../sdmodeltestbase.hxx"
+#include 
 #include 
 #include 
 #include 
@@ -98,6 +99,7 @@ public:
 void testMultiViewInsertDeletePage();
 void testDisableUndoRepair();
 void testLanguageStatus();
+void testDefaultView();
 
 CPPUNIT_TEST_SUITE(SdTiledRenderingTest);
 CPPUNIT_TEST(testRegisterCallback);
@@ -136,6 +138,7 @@ public:
 CPPUNIT_TEST(testMultiViewInsertDeletePage);
 CPPUNIT_TEST(testDisableUndoRepair);
 CPPUNIT_TEST(testLanguageStatus);
+CPPUNIT_TEST(testDefaultView);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -1818,6 +1821,8 @@ void SdTiledRenderingTest::testDisableUndoRepair()
 CPPUNIT_ASSERT(dynamic_cast< const SfxUInt32Item* >(pItem1.get()));
 CPPUNIT_ASSERT_EQUAL(static_cast(SID_REPAIRPACKAGE), 
dynamic_cast< const SfxUInt32Item * >(pItem1.get())->GetValue());
 }
+
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testLanguageStatus()
@@ -1836,6 +1841,30 @@ void SdTiledRenderingTest::testLanguageStatus()
 CPPUNIT_ASSERT(dynamic_cast< const SfxStringListItem* >(pItem1.get()));
 CPPUNIT_ASSERT(dynamic_cast< const SfxStringListItem* >(pItem2.get()));
 }
+
+comphelper::LibreOfficeKit::setActive(false);
+}
+
+void SdTiledRenderingTest::testDefaultView()
+{
+// Load the document with notes view.
+comphelper::LibreOfficeKit::setActive();
+
+SdXImpressDocument* pXImpressDocument = createDoc("notes-view.odp");
+sd::ViewShell* pView = pXImpressDocument->GetDocShell()->GetViewShell();
+{
+std::unique_ptr pItem1;
+std::unique_ptr pItem2;
+
pView->GetViewFrame()->GetBindings().QueryState(SID_NORMAL_MULTI_PANE_GUI, 
pItem1);
+pView->GetViewFrame()->GetBindings().QueryState(SID_NOTES_MODE, 
pItem2);
+const SfxBoolItem* pImpressView = dynamic_cast< const SfxBoolItem* 
>(pItem1.get());
+const SfxBoolItem* pNotesView = dynamic_cast< const SfxBoolItem* 
>(pItem2.get());
+CPPUNIT_ASSERT(pImpressView);
+CPPUNIT_ASSERT(pNotesView);
+CPPUNIT_ASSERT_EQUAL(true, pImpressView->GetValue());
+CPPUNIT_ASSERT_EQUAL(false, pNotesView->GetValue());
+}
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(SdTiledRenderingTest);
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 6b852e2cb5bb..c844c559a642 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -2445,10 +2445,6 @@ void 
SdXImpressDocument::initializeForTiledRendering(const css::uno::SequenceGetViewShell()->GetViewFrame()->GetDispatcher()->Execute(SID_VIEWSHELL0,
 SfxCallMode::SYNCHRON | SfxCallMode::RECORD);
-
 if (DrawViewShell* pViewShell = GetViewShell())
 {
 DrawView* pDrawView = pViewShell->GetDrawView();
diff --git a/sd/source/ui/view/ImpressViewShellBase.cxx 
b/sd/source/ui/view/ImpressViewShellBase.cxx
index e74440f08010..12dcfd949e32 100644
--- a/sd/source/ui/view/ImpressViewShellBase.cxx
+++ b/sd/source/ui/view/ImpressViewShellBase.cxx
@@ -19,16 +19,18 @@
 
 #include "ImpressViewShellBase.hxx"
 
-#include "DrawDocShell.hxx"
-#include "sdresid.hxx"
-#include "strings.hrc"
-#include "app.hrc"
-#include "framework/FrameworkHelper.hxx"
-#include "framework/ImpressModule.hxx"
-#include "MasterPageObserver.hxx"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 #include 
+#include 
 
 namespace sd {
 
@@ -41,7 +43,7 @@

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - desktop/source include/svl officecfg/registry sfx2/source sw/inc sw/qa sw/sdi sw/source sw/uiconfig

2017-11-28 Thread Henry Castro

 desktop/source/lib/init.cxx |4 
 include/svl/hint.hxx|1 
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |   28 +++
 sfx2/source/control/unoctitm.cxx|5 
 sw/inc/IDocumentRedlineAccess.hxx   |2 
 sw/inc/cmdid.h  |2 
 sw/qa/extras/tiledrendering/tiledrendering.cxx  |   74 
++
 sw/sdi/docsh.sdi|   10 +
 sw/sdi/swriter.sdi  |   36 
 sw/source/core/doc/DocumentRedlineManager.cxx   |   32 
 sw/source/core/inc/DocumentRedlineManager.hxx   |2 
 sw/source/uibase/app/docsh.cxx  |7 
 sw/source/uibase/app/docsh2.cxx |   27 +++
 sw/source/uibase/uiview/view.cxx|   16 ++
 sw/uiconfig/swriter/menubar/menubar.xml |2 
 15 files changed, 246 insertions(+), 2 deletions(-)

New commits:
commit af44e1547121f0292cd43fb8db6545e44594020d
Author: Henry Castro 
Date:   Sat Nov 4 12:18:53 2017 -0400

sw lok: add Accept/Reject All tracked changes, tdf#101977

Change-Id: I04d747343e24cb498a621c965d034d0791411d83
Reviewed-on: https://gerrit.libreoffice.org/44311
Tested-by: Jenkins 
Reviewed-by: Henry Castro 
Reviewed-on: https://gerrit.libreoffice.org/44486
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index fe046459751f..515e148c1f04 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1761,7 +1761,9 @@ static void doc_iniUnoCommands ()
 OUString(".uno:TrackChanges"),
 OUString(".uno:ShowTrackedChanges"),
 OUString(".uno:NextTrackedChange"),
-OUString(".uno:PreviousTrackedChange")
+OUString(".uno:PreviousTrackedChange"),
+OUString(".uno:AcceptAllTrackedChanges"),
+OUString(".uno:RejectAllTrackedChanges")
 };
 
 util::URL aCommandURL;
diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx
index 70f5fc74e8d6..31404cf31748 100644
--- a/include/svl/hint.hxx
+++ b/include/svl/hint.hxx
@@ -31,6 +31,7 @@
 #define SFX_HINT_DEINITIALIZING 0x0040
 #define SFX_HINT_MODECHANGED0x0080
 #define SFX_HINT_LANGUAGECHANGED0x0100
+#define SFX_HINT_REDLINECHANGED 0x0200
 // unused, formerly SFX_HINT_CANCELLABLE
 // unused, formerly SFX_HINT_DATAAVAILABLE
 // unused, formerly SFX_HINT_SAVECOMPLETED
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index a93ed1e2318a..3e127c10d1ee 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -236,6 +236,20 @@
   1
 
   
+  
+
+  Reject All
+
+
+  Reject All Tracked Changes
+
+
+  Reject All Changes
+
+
+  1
+
+  
   
 
   Accept
@@ -250,6 +264,20 @@
   1
 
   
+  
+
+  Accept All
+
+
+  Accept All Tracked Changes
+
+
+  Accept All Changes
+
+
+  1
+
+  
   
 
   Next
diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx
index 394653cd582f..c55005d8433d 100644
--- a/sfx2/source/control/unoctitm.cxx
+++ b/sfx2/source/control/unoctitm.cxx
@@ -1070,7 +1070,10 @@ static void InterceptLOKStateChangeEvent(const 
SfxViewFrame* pViewFrame, const c
  aEvent.FeatureURL.Path == "EntireColumn" ||
  aEvent.FeatureURL.Path == "EntireCell" ||
  aEvent.FeatureURL.Path == "SortAscending" ||
- aEvent.FeatureURL.Path == "SortDescending")
+ aEvent.FeatureURL.Path == "SortDescending" ||
+ aEvent.FeatureURL.Path == "AcceptAllTrackedChanges" ||
+ aEvent.FeatureURL.Path == "RejectAllTrackedChanges")
+
 {
 aBuffer.append(aEvent.IsEnabled ? OUString("enabled") : 
OUString("disabled"));
 }
diff --git a/sw/inc/IDocumentRedlineAccess.hxx 
b/sw/inc/IDocumentRedlineAccess.hxx
index 5488f7fcd66d..647f0980e631 100644
--- a/sw/inc/IDocumentRedlineAccess.hxx
+++ b/sw/inc/IDocumentRedlineAccess.hxx
@@ -204,6 +204,8 @@ public:
 
 virtual const SwRangeRedline* SelPrevRedline(/*[in]*/SwPaM& rPam) const = 
0;
 
+

[Libreoffice-bugs] [Bug 107326] [META] Writer style bugs and enhancements

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107326
Bug 107326 depends on bug 112977, which changed state.

Bug 112977 Summary: Different terms for the same styles in the menu and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=112977

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112473] [META] Styles menu bugs and enhancements

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112473
Bug 112473 depends on bug 112977, which changed state.

Bug 112977 Summary: Different terms for the same styles in the menu and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=112977

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112977] Different terms for the same styles in the menu and sidebar

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112977

Harald Koester  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

--- Comment #3 from Harald Koester  ---
(In reply to Yousuf Philips (jay) from comment #2)
> (In reply to Harald Koester from comment #0)
> > In Writer for the following styles different terms are used in the menu
> > Styles:
> > (1) Paragraph style “Default Style”, menu: “Default Paragraph”
> > (2) Character style “Default Style”, menu: “Default Character”
> 
> They have the same name in the sidebar, as they are not on a single tab of
> the styles deck, so its easy to differentiate them there, but in a single
> menu, its important for them have different names to easily know the
> paragraph styles from the character styles.

I'm sorry Jay, I don't agree. Using different terms for the same thing is
always confusing. Particulary if we promote the use of styles, it is necessary
that a user is able to recognize at first glance, that the same styles are
meant in these cases. For me it was hindering and I think for other users it's
still hindering if they have to check this first. 

> 
> > (3) List style “List 1”, menu: “Bullet List”
> > (4) List style “Numbering 1”, menu: “Number List”
> > (5) List style “Numbering 4”, menu: “Roman List”
> 
> Styles menu will have more descriptive names which would be easier to
> understand, specially for beginners, while the sidebar will be having names
> like Numbering 123, and Numbering IVX (bug 106988).

Of course more descriptive names are a good thing, but these names should be
used everywhere in the user interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103427] [META] Styles and Formatting sidebar deck and floating window

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103427
Bug 103427 depends on bug 112977, which changed state.

Bug 112977 Summary: Different terms for the same styles in the menu and sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=112977

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|WONTFIX |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - desktop/source include/vcl sc/inc sc/source

2017-11-28 Thread Marco Cecchetti

 desktop/source/lib/init.cxx|   18 +++
 include/vcl/ITiledRenderable.hxx   |   13 ++
 sc/inc/docuno.hxx  |3 
 sc/source/ui/docshell/olinefun.cxx |   30 -
 sc/source/ui/inc/dbfunc.hxx|3 
 sc/source/ui/inc/tabvwsh.hxx   |   10 +
 sc/source/ui/undo/undoblk.cxx  |9 -
 sc/source/ui/undo/undoblk2.cxx |6 -
 sc/source/ui/undo/undodat.cxx  |   10 +
 sc/source/ui/unoobj/docuno.cxx |   13 ++
 sc/source/ui/view/cellsh1.cxx  |5 
 sc/source/ui/view/dbfunc3.cxx  |   53 +
 sc/source/ui/view/gridwin.cxx  |   12 +-
 sc/source/ui/view/tabview.cxx  |  208 -
 sc/source/ui/view/tabvwshc.cxx |   38 +-
 sc/source/ui/view/viewfunc.cxx |   14 --
 16 files changed, 408 insertions(+), 37 deletions(-)

New commits:
commit 6964953c5a86ef02fa9320e1db4d6bd81cee5001
Author: Marco Cecchetti 
Date:   Mon Nov 27 17:50:26 2017 +0100

lok - calc: outline and group handling

Change-Id: Ibb287468653bc381acf034dcb8531c5faf61aef3
Reviewed-on: https://gerrit.libreoffice.org/45416
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 307418fcd55c..fe046459751f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3009,6 +3009,10 @@ static char* 
doc_getCommandValues(LibreOfficeKitDocument* pThis, const char* pCo
 int nY = 0;
 int nWidth = 0;
 int nHeight = 0;
+bool bColumn = false;
+int nLevel = -1;
+int nGroupIndex = -2;
+bool bHidden = false;
 OString aArguments = 
aCommand.copy(aViewRowColumnHeaders.getLength() + 1);
 sal_Int32 nParamIndex = 0;
 do
@@ -3034,9 +3038,23 @@ static char* 
doc_getCommandValues(LibreOfficeKitDocument* pThis, const char* pCo
 nWidth = aValue.toInt32();
 else if (aKey == "height")
 nHeight = aValue.toInt32();
+else if (aKey == "columnOutline")
+bColumn = aValue.toBoolean();
+else if (aKey == "groupLevel")
+nLevel = aValue.toInt32();
+else if (aKey == "groupIndex")
+nGroupIndex = aValue.toInt32();
+else if (aKey == "groupHidden")
+bHidden = aValue.toBoolean();
 }
 while (nParamIndex >= 0);
+
 aRectangle = Rectangle(nX, nY, nX + nWidth, nY + nHeight);
+
+if (nGroupIndex != -2)
+{
+pDoc->setOutlineState(bColumn, nLevel, nGroupIndex, bHidden);
+}
 }
 
 OUString aHeaders = pDoc->getRowColumnHeaders(aRectangle);
diff --git a/include/vcl/ITiledRenderable.hxx b/include/vcl/ITiledRenderable.hxx
index ae3ba9e76c3c..95676d751244 100644
--- a/include/vcl/ITiledRenderable.hxx
+++ b/include/vcl/ITiledRenderable.hxx
@@ -151,6 +151,19 @@ public:
 }
 
 /**
+ * Show/Hide a single row/column header outline for Calc dosuments.
+ *
+ * @param bColumn - if we are dealing with a column or row group
+ * @param nLevel - the level to which the group belongs
+ * @param nIndex - the group entry index
+ * @param bHidden - the new group state (collapsed/expanded)
+ */
+virtual void setOutlineState(bool /*bColumn*/, int /*nLevel*/, int 
/*nIndex*/, bool /*bHidden*/)
+{
+return;
+}
+
+/**
  * Get position and content of row/column headers of Calc documents.
  *
  * @param rRectangle - if not empty, then limit the output only to the 
area of this rectangle
diff --git a/sc/inc/docuno.hxx b/sc/inc/docuno.hxx
index 917b211a82a1..e37f11a9ba49 100644
--- a/sc/inc/docuno.hxx
+++ b/sc/inc/docuno.hxx
@@ -409,6 +409,9 @@ public:
 /// @see vcl::ITiledRenderable::setClientZoom().
 virtual void setClientZoom(int nTilePixelWidth, int nTilePixelHeight, int 
nTileTwipWidth, int nTileTwipHeight) override;
 
+/// @see vcl::ITiledRenderable::setOutlineState().
+virtual void setOutlineState(bool bColumn, int nLevel, int nIndex, bool 
bHidden) override;
+
 /// @see vcl::ITiledRenderable::getRowColumnHeaders().
 virtual OUString getRowColumnHeaders(const Rectangle& rRectangle) override;
 
diff --git a/sc/source/ui/docshell/olinefun.cxx 
b/sc/source/ui/docshell/olinefun.cxx
index a96eadf2d964..c2e56231cc74 100644
--- a/sc/source/ui/docshell/olinefun.cxx
+++ b/sc/source/ui/docshell/olinefun.cxx
@@ -27,6 +27,10 @@
 #include "globstr.hrc"
 #include "sc.hrc"
 
+#include 
+#include 
+#include 
+
 static void lcl_InvalidateOutliner( SfxBindings* pBindings )
 {
 if ( pBindings )
@@ -402,6 +406,10 @@ bool ScOutlineDocFunc::SelectLevel( SCTAB nTab, bool 
bColumns, sal_uInt16 nLevel
 rDocShell.SetDocumentModified();

[Libreoffice-commits] core.git: cui/inc

2017-11-28 Thread László Németh

 cui/inc/strings.hrc |   14 ++
 1 file changed, 14 insertions(+)

New commits:
commit 217b1e8e94859e06af66023f042c53cf329f5232
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Tue Nov 28 14:05:45 2017 +0100

Add comment to translators of "Grammar By" text entry box

Change-Id: Ifea74df8f113967c9df9703cf6582360ffdfa78d
Reviewed-on: https://gerrit.libreoffice.org/45410
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index f60f504bd451..dca50c2cd57a 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -268,6 +268,20 @@
 #define RID_SVXSTR_CHG_SMARTART 
NC_("RID_SVXSTR_CHG_SMARTART", "SmartArt to %PRODUCTNAME shapes or reverse")
 
 #define RID_SVXSTR_OPT_DOUBLE_DICTS 
NC_("RID_SVXSTR_OPT_DOUBLE_DICTS", "The specified name already exists.\nPlease 
enter a new name.")
+/* To translators:
+   Please, try to find a similar *short* translation to avoid
+   to get narrow "New" field in the "Edit custom dictionary" window,
+   for example, "Model word for optional affixation and compounding"
+   is too long, but "Grammar By" is a good name here (help page of
+   the window contains the details).
+
+   "Grammar By" text entry box of the "Edit custom dictionary" window
+   contains an optional model word associated to the new user word,
+   allowing its affixation or compounding during spell checking.
+   For example, adding "Grammar By" word "fund" to the new user
+   word "crowdfund", the spell checker will recogize "crowdfund"
+   with suffixes of "fund": "crowdfunding", "crowdfund's" etc.
+*/
 #define RID_SVXSTR_OPT_GRAMMAR_BY   
NC_("RID_SVXSTR_OPT_GRAMMAR_BY", "~Grammar By")
 #define STR_MODIFY  NC_("STR_MODIFY", 
"~Replace")
 #define RID_SVXSTR_CONFIRM_SET_LANGUAGE 
NC_("RID_SVXSTR_CONFIRM_SET_LANGUAGE", "Do you want to change the '%1' 
dictionary language?")
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac distro-configs/LibreOfficeCoverity.conf

2017-11-28 Thread Stephan Bergmann

 configure.ac|   12 +++-
 distro-configs/LibreOfficeCoverity.conf |1 +
 2 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 0f3b0ec973f06a98c75ef8acfa720a9973e4d2b5
Author: Stephan Bergmann 
Date:   Tue Nov 28 12:25:32 2017 +0100

Avoid C++17 mode for Coverity Scan

...see mail sub-thread starting at


"Re: New Defects reported by Coverity Scan for LibreOffice" about 
cid#1424266 et
al; lets see if this makes Coverity happy again...

Change-Id: If488b9f61f084f2286b35326917741051ec8d5ce
Reviewed-on: https://gerrit.libreoffice.org/45403
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/configure.ac b/configure.ac
index 3543d5874771..23b1ff84ed5a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5983,6 +5983,12 @@ dnl 
===
 dnl C++11
 dnl ===
 
+my_cxx17switches=
+libo_FUZZ_ARG_ENABLE(c++17,
+AS_HELP_STRING([--disable-c++17],
+[Do not attempt to run GCC/Clang in C++17 mode (needed for Coverity).])
+)
+
 CXXFLAGS_CXX11=
 if test "$COM" = MSC; then
 AC_MSG_CHECKING([whether $CXX supports C++11])
@@ -5994,7 +6000,11 @@ elif test "$GCC" = "yes"; then
 dnl But only use C++17 if the gperf that is being used knows not to emit
 dnl "register" in C++ output:
 printf 'foo\n' | $GPERF -L C++ > conftest.inc
-for flag in -std=gnu++17 -std=gnu++1z -std=c++17 -std=c++1z -std=gnu++14 
-std=gnu++1y -std=c++14 -std=c++1y -std=gnu++11 -std=gnu++0x -std=c++11 
-std=c++0x ; do
+my_flags='-std=gnu++14 -std=gnu++1y -std=c++14 -std=c++1y -std=gnu++11 
-std=gnu++0x -std=c++11 -std=c++0x'
+if test "$enable_c__17" != no; then
+my_flags="-std=gnu++17 -std=gnu++1z -std=c++17 -std=c++1z $my_flags"
+fi
+for flag in $my_flags; do
 save_CXXFLAGS=$CXXFLAGS
 CXXFLAGS="$CXXFLAGS $flag -Werror"
 AC_LANG_PUSH([C++])
diff --git a/distro-configs/LibreOfficeCoverity.conf 
b/distro-configs/LibreOfficeCoverity.conf
index e387254a6405..9d55f6811732 100644
--- a/distro-configs/LibreOfficeCoverity.conf
+++ b/distro-configs/LibreOfficeCoverity.conf
@@ -1,3 +1,4 @@
+--disable-c++17
 --enable-assert-always-abort
 --without-help
 --enable-gio
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108230] [META] OOXML document theme issues

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108230
Bug 108230 depends on bug 113271, which changed state.

Bug 113271 Summary: FILEOPEN: XLSX: Incorrect font colour
https://bugs.documentfoundation.org/show_bug.cgi?id=113271

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/qa sw/source

2017-11-28 Thread Miklos Vajna

 sw/qa/extras/rtfexport/data/tdf104035.rtf   |   14 ++
 sw/qa/extras/rtfexport/rtfexport3.cxx   |8 
 sw/source/filter/ww8/rtfattributeoutput.cxx |9 +++--
 3 files changed, 29 insertions(+), 2 deletions(-)

New commits:
commit 822e9af8ec8018fed098c16a50136fb9f0fa5b0e
Author: Miklos Vajna 
Date:   Tue Nov 28 09:08:12 2017 +0100

tdf#104035 RTF export: fix handling of absolute tab positions

RtfAttributeOutput::ParaTabStop() assumed that they are always absolute,
but WW8AttributeOutput::ParaTabStop() points out what compat setting
decides if they are absolute or relative.

(cherry picked from commit b5e871deb8ce390b9fa694e21b0272c7462da703)

Change-Id: Iafe8f6bb8733cae38a89f6c407763b0327e894e8
Reviewed-on: https://gerrit.libreoffice.org/45412
Tested-by: Jenkins 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sw/qa/extras/rtfexport/data/tdf104035.rtf 
b/sw/qa/extras/rtfexport/data/tdf104035.rtf
new file mode 100644
index ..730238eb0c63
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf104035.rtf
@@ -0,0 +1,14 @@
+{\rtf1\ansi\ansicpg1252\uc1 \deff0\deflang1033\deflangfe1033
+{\fonttbl
+{\f5\fswiss\fcharset0\fprq2 Helvetica;}
+}
+{\colortbl;\red0\green0\blue0;\red0\green0\blue255;
+\red0\green255\blue255;\red0\green255\blue0;\red255\green0\blue255;\red255\green0\blue0;\red255\green255\blue0;\red255\green255\blue255;\red0\green0\blue128;\red0\green128\blue128;\red0\green128\blue0;\red128\green0\blue128;\red128\green0\blue0;
+\red128\green128\blue0;\red128\green128\blue128;\red192\green192\blue192;}
+\margl1440\margr1440
+\facingp\widowctrl\ftnbj\aenddoc\lytprtmet\hyphcaps0\formshade\viewkind1\viewscale100\pgbrdrhead\pgbrdrfoot
 \fet0\sectd 
\psz1\sbkodd\pgnrestart\linex0\headery1440\footery1080\endnhere\titlepg\sectdefaultcl
+\pard\plain 
\fi-2880\li2880\widctlpar\tx450\tx2880\tx3427\tx3787\tx4147\adjustright
+{\b\f5 1.0\tab FACILITY}
+{\f0\fs26 \tab Navy Golf operation physical/service environment is clean, safe 
and friendly for employees and customers, and creates a
+\par }
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport3.cxx 
b/sw/qa/extras/rtfexport/rtfexport3.cxx
index 9c174450c95f..0c63f23972e0 100644
--- a/sw/qa/extras/rtfexport/rtfexport3.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport3.cxx
@@ -60,6 +60,14 @@ DECLARE_RTFEXPORT_TEST(testTdf108949_footnote, 
"tdf108949_footnote.rtf")
  
getProperty(xFootnote->getAnchor(), "CharColor"));
 }
 
+DECLARE_RTFEXPORT_TEST(testTdf104035, "tdf104035.rtf")
+{
+auto aTabStops = 
getProperty(getParagraph(1), "ParaTabStops");
+CPPUNIT_ASSERT(aTabStops.hasElements());
+// This was 3330 twips instead, as tabs were assumed to be relative.
+CPPUNIT_ASSERT_EQUAL(static_cast(convertTwipToMm100(450)), 
aTabStops[0].Position);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx 
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index 8b5ba978104d..6c8bb3390979 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -78,6 +78,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2838,8 +2839,12 @@ void RtfAttributeOutput::ParaWidows(const SvxWidowsItem& 
rWidows)
 
 void RtfAttributeOutput::ParaTabStop(const SvxTabStopItem& rTabStop)
 {
-long nOffset
-= static_cast(m_rExport.GetItem(RES_LR_SPACE)).GetTextLeft();
+long nOffset = 0;
+// Tabs are absolute by default.
+if (m_rExport.m_pDoc->getIDocumentSettingAccess().get(
+DocumentSettingId::TABS_RELATIVE_TO_INDENT))
+nOffset = static_cast(m_rExport.GetItem(RES_LR_SPACE)).GetTextLeft();
+
 for (sal_uInt16 n = 0; n < rTabStop.Count(); n++)
 {
 const SvxTabStop& rTS = rTabStop[n];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

About Textbody class

2017-11-28 Thread serdar tunc

I am working on that bug
https://bugs.documentfoundation.org/show_bug.cgi?id=104290

I cant get emails from mail list i subscribed 2 times,i send licence mail
and still i cant get mails.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Moztrap question

2017-11-28 Thread Campaña Soler Pau

Hello.
We are students of Aalto University, and we have to make an study of 
Thunderbird.  We have seen that for the tests cases they use moztrap, but all 
the links of that webite are not working. We have also found in:
https://wiki.documentfoundation.org/MozTrap/User_Guide
that they also use manual test libreoffice, but we do not know how to register 
(https://manual-test.libreoffice.org/login.php?viewer=). Can you provide us a 
link to register or a username and passwoord just to see how it inside (we will 
not make any modification).
If it is not posible, can you tell us if it is used by Thunderbird?
Thanks, Pau.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sc/source

2017-11-28 Thread Marco Cecchetti

 sc/source/ui/view/tabview.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit f4c6426d28aea11743881906d8179c220fa73b9f
Author: Marco Cecchetti 
Date:   Thu Nov 9 18:56:27 2017 +0100

lok: sc: subdivide headers data in range

Change-Id: I984b5da5774f97172de7659ecab84675060f8301
Reviewed-on: https://gerrit.libreoffice.org/45415
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index 96f10d6729de..4aef7be67b16 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -2674,11 +2674,15 @@ OUString ScTabView::getRowColumnHeaders(const 
Rectangle& rRectangle)
 aBuffer.append("\"size\": \"").append(OUString::number(nTotalPixels * 
TWIPS_PER_PIXEL)).append("\" }");
 }
 
+long nPrevSizePx = -1;
 for (SCROW nRow = nStartRow + 1; nRow < nEndRow; ++nRow)
 {
 // nSize will be 0 for hidden rows.
 const long nSizePx = lcl_GetRowHeightPx(pDoc, nRow, nTab);
 nTotalPixels += nSizePx;
+if (nRow < nEndRow - 1 && nSizePx == nPrevSizePx)
+continue;
+nPrevSizePx = nSizePx;
 
 OUString aText = pRowBar[SC_SPLIT_BOTTOM]->GetEntryText(nRow);
 aBuffer.append(", ");
@@ -2781,13 +2785,18 @@ OUString ScTabView::getRowColumnHeaders(const 
Rectangle& rRectangle)
 aBuffer.append("\"size\": \"").append(OUString::number(nTotalPixels * 
TWIPS_PER_PIXEL)).append("\" }");
 }
 
+nPrevSizePx = -1;
 for (SCCOL nCol = nStartCol + 1; nCol < nEndCol; ++nCol)
 {
 // nSize will be 0 for hidden columns.
 const long nSizePx = lcl_GetColWidthPx(pDoc, nCol, nTab);
 nTotalPixels += nSizePx;
+if (nCol < nEndCol - 1 && nSizePx == nPrevSizePx)
+continue;
+nPrevSizePx = nSizePx;
+
 
-OUString aText = pColBar[SC_SPLIT_LEFT]->GetEntryText(nCol);
+OUString aText = OUString::number(nCol + 1);
 aBuffer.append(", ");
 aBuffer.append("{ \"text\": \"").append(aText).append("\", ");
 aBuffer.append("\"size\": \"").append(OUString::number(nTotalPixels * 
TWIPS_PER_PIXEL)).append("\" }");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - libreofficekit/Executable_tilebench.mk libreofficekit/Module_libreofficekit.mk libreofficekit/qa Repository.mk

2017-11-28 Thread Ashod Nakashian

 Repository.mk |2 
 libreofficekit/Executable_tilebench.mk|1 
 libreofficekit/Module_libreofficekit.mk   |5 +
 libreofficekit/qa/tilebench/tilebench.cxx |  102 --
 4 files changed, 74 insertions(+), 36 deletions(-)

New commits:
commit 7db98521548de9eab955ee25a5aacaaef42df323
Author: Ashod Nakashian 
Date:   Sun Nov 19 20:38:43 2017 -0500

LOK: tilebench improvements

* Arguments for max number of parts and tiles to render (optional).
  + Automatic estimation of maximum tiles to render based on max parts
for Writer docs, since there is only 1 part, this caps the number
of pages to render, similar to other doc types.
* Fixed rendering of Writer documents over and over (as many times as 
pages).
  + Writer has a single part, unlike other doc types.
  + No point in rendering the whole document in writer to a single tile,
since that's completely unrealistic and impractical (it takes
forever for large docs and artificially spikes the memory).
* Rendering starts at the current part and not the first.
  + This gives the spreadsheet of interest priority (if saved as visible).
* The tile size is now more realistic as we use the same dimensions
  as the Online client does.
* When rendering tiles at scale, we use the same dimensions as the
  Online client rather than splitting the width by 4, for realism.
* Rendering of tiles is done rows-first, rather than columns-first,
  which is similar to what the Online client does, which is more
  cache friendly, therefore more realistic.
* Enabled compiling of tilebench when GTK3 is disabled, which
  was erroneous, since tilebench doesn't have any dependency on GTK.
  + Now it's possible to compile with local Cairo/Pixman libs.

Change-Id: Ib78d030ead387748914119f95fe49ddc1ce64498
Reviewed-on: https://gerrit.libreoffice.org/44936
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/Repository.mk b/Repository.mk
index 3635ccfadada..1c72fc1abb61 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -70,7 +70,7 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 svptest \
 svpclient \
 pixelctl ) \
-   $(if $(and $(ENABLE_GTK3), $(filter LINUX %BSD SOLARIS,$(OS))), 
tilebench) \
+   $(if $(filter LINUX %BSD SOLARIS,$(OS)), tilebench) \
$(if $(filter LINUX MACOSX SOLARIS WNT %BSD,$(OS)),icontest \
outdevgrind) \
vcldemo \
diff --git a/libreofficekit/Executable_tilebench.mk 
b/libreofficekit/Executable_tilebench.mk
index 4da51d3ca686..9d8b2a134f99 100644
--- a/libreofficekit/Executable_tilebench.mk
+++ b/libreofficekit/Executable_tilebench.mk
@@ -15,7 +15,6 @@ $(eval $(call gb_Executable_set_include,tilebench,\
 ))
 
 $(eval $(call gb_Executable_use_libraries,tilebench,\
-libreofficekitgtk \
sal \
 ))
 
diff --git a/libreofficekit/Module_libreofficekit.mk 
b/libreofficekit/Module_libreofficekit.mk
index cc842b2f3f2c..079e4e15e5b4 100644
--- a/libreofficekit/Module_libreofficekit.mk
+++ b/libreofficekit/Module_libreofficekit.mk
@@ -23,10 +23,13 @@ ifneq ($(ENABLE_GTK3),)
 $(eval $(call gb_Module_add_targets,libreofficekit,\
 Library_libreofficekitgtk \
 Executable_gtktiledviewer \
+))
+endif # ($(ENABLE_GTK3),)
+
+$(eval $(call gb_Module_add_targets,libreofficekit,\
 Executable_tilebench \
 Package_selectionhandles \
 ))
-endif # ($(ENABLE_GTK3),)
 
 endif
 
diff --git a/libreofficekit/qa/tilebench/tilebench.cxx 
b/libreofficekit/qa/tilebench/tilebench.cxx
index b4912b1611ef..08cf8abff6ab 100644
--- a/libreofficekit/qa/tilebench/tilebench.cxx
+++ b/libreofficekit/qa/tilebench/tilebench.cxx
@@ -10,10 +10,12 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -21,7 +23,7 @@ using namespace lok;
 
 static int help()
 {
-fprintf( stderr, "Usage: tilebench  
[path to document]\n" );
+fprintf( stderr, "Usage: tilebench  
[path to document] [max parts|-1] [max tiles|-1]\n" );
 fprintf( stderr, "renders a selection of small tiles from the document, 
checksums them and times the process\n" );
 return 1;
 }
@@ -36,13 +38,17 @@ static double getTimeNow()
 
 int main( int argc, char* argv[] )
 {
+static const double origin = getTimeNow();
 struct TimeRecord {
 const char *mpName;
 double mfTime;
 
 TimeRecord() : mpName(nullptr), mfTime(getTimeNow()) { }
 explicit TimeRecord(const char *pName) :
-   mpName(pName ), mfTime(getTimeNow()) { }
+   mpName(pName), mfTime(getTimeNow())
+{
+fprintf(stderr, "%3.3fs - %s\n", (mfTime - origin), mpName);
+}
 };
 std::vector< TimeRecord > aTimes;
 if( argc < 2 ||
@@ -55,11 +61,20 @@ int

[Libreoffice-bugs] [Bug 97455] Copied text appears with big delay in the clipboard

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97455

--- Comment #9 from Dmitry  ---
The problem is still there in v5.2.1.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cppuhelper/source

2017-11-28 Thread Caolán McNamara

 cppuhelper/source/servicemanager.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 34a7e1b8712bab8dc731a1b7ffe283009752959d
Author: CaolÃ¡n McNamara 
Date:   Tue Nov 28 17:06:08 2017 +

not used with disable-dynloading

Change-Id: Idad8a7b9b984147b7a64caf7527d8ad21bdd55a2
Reviewed-on: https://gerrit.libreoffice.org/45433
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/cppuhelper/source/servicemanager.cxx 
b/cppuhelper/source/servicemanager.cxx
index 09e555a4ff43..42a0e7e3145a 100644
--- a/cppuhelper/source/servicemanager.cxx
+++ b/cppuhelper/source/servicemanager.cxx
@@ -1809,7 +1809,7 @@ cppuhelper::ServiceManager::findServiceImplementation(
 }
 
 /// Make a simpler unique name for preload / progress reporting.
-#ifndef IOS
+#ifndef DISABLE_DYNLOADING
 static rtl::OUString simplifyModule(const rtl::OUString )
 {
 sal_Int32 nIdx;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114111] FILEOPEN: Hang/Crash loading .doc file

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114111

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

However, I'm not sure it's hanging at the same location since I use
enable-dbgutil and gdb shows I'm stuck (or I didn't have the patience to wait
for the end of outer loop) here:
See
https://opengrok.libreoffice.org/xref/core/sw/source/core/bastyp/swcache.cxx#40

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-11-28 Thread Caolán McNamara

 sc/source/filter/inc/formel.hxx |2 ++
 sc/source/filter/lotus/lotimpop.cxx |2 ++
 sc/source/filter/lotus/op.cxx   |4 ++--
 3 files changed, 6 insertions(+), 2 deletions(-)

New commits:
commit c97d4caf43d8f8c5d26ccddc92896c4a42633d0e
Author: CaolÃ¡n McNamara 
Date:   Tue Nov 28 15:52:09 2017 +

ofz#4412 bail on failure in Formulacell too

Change-Id: Ie7f9e4309ae8468947dce12355201d038e7e63fa
Reviewed-on: https://gerrit.libreoffice.org/45428
Reviewed-by: Eike Rathke 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/sc/source/filter/inc/formel.hxx b/sc/source/filter/inc/formel.hxx
index aa7944161439..da1ba8ae1a3d 100644
--- a/sc/source/filter/inc/formel.hxx
+++ b/sc/source/filter/inc/formel.hxx
@@ -130,6 +130,8 @@ public:
 
 virtual voidConvert( const ScTokenArray*& rpErg, sal_Int32& nRest 
) = 0;
 
+bool good() const { return aIn.good(); }
+
 protected:
 using   ConverterBase::Reset;
 };
diff --git a/sc/source/filter/lotus/lotimpop.cxx 
b/sc/source/filter/lotus/lotimpop.cxx
index 62fe76b8774e..00ccefab0ee3 100644
--- a/sc/source/filter/lotus/lotimpop.cxx
+++ b/sc/source/filter/lotus/lotimpop.cxx
@@ -275,6 +275,8 @@ void ImportLotus::Formulacell( sal_uInt16 n )
 aConv.Reset( aAddr );
 aConv.SetWK3();
 aConv.Convert( pErg, nRest );
+if (!aConv.good())
+return;
 
 ScFormulaCell* pCell = pErg ? new ScFormulaCell(pD, aAddr, *pErg) : new 
ScFormulaCell(pD, aAddr);
 pCell->AddRecalcMode( ScRecalcMode::ONLOAD_ONCE );
diff --git a/sc/source/filter/lotus/op.cxx b/sc/source/filter/lotus/op.cxx
index 6491b0c08ae1..295cd2804da0 100644
--- a/sc/source/filter/lotus/op.cxx
+++ b/sc/source/filter/lotus/op.cxx
@@ -151,7 +151,7 @@ void OP_Formula(LotusContext , SvStream& r, 
sal_uInt16 /*n*/)
 LotusToSc aConv(rContext, r, rSPool, rContext.pLotusRoot->eCharsetQ, 
false);
 aConv.Reset( aAddress );
 aConv.Convert( pErg, nBytesLeft );
-if (!r.good())
+if (!aConv.good())
 return;
 
 if (ValidColRow(nCol, nRow))
@@ -401,7 +401,7 @@ void OP_Formula123(LotusContext& rContext, SvStream& r, 
sal_uInt16 n)
 LotusToSc aConv(rContext, r, rSPool, rContext.pLotusRoot->eCharsetQ, true);
 aConv.Reset( aAddress );
 aConv.Convert( pErg, nBytesLeft );
-if (!r.good())
+if (!aConv.good())
 return;
 
 if (ValidColRow(nCol, nRow) && nTab <= rContext.pDoc->GetMaxTableNumber())
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - 22 commits - cui/source desktop/source include/LibreOfficeKit include/sfx2 include/tools include/vcl libreofficekit/qa sc/source sfx2

2017-11-28 Thread Jan Holesovsky

 cui/source/dialogs/iconcdlg.cxx |2 
 cui/source/inc/iconcdlg.hxx |3 
 desktop/source/lib/init.cxx |  167 

 include/LibreOfficeKit/LibreOfficeKit.h |   15 
 include/LibreOfficeKit/LibreOfficeKit.hxx   |   47 --
 include/sfx2/basedlgs.hxx   |2 
 include/sfx2/lokhelper.hxx  |6 
 include/sfx2/viewsh.hxx |8 
 include/tools/gen.hxx   |1 
 include/vcl/IDialogRenderable.hxx   |   40 --
 include/vcl/dialog.hxx  |   20 -
 include/vcl/window.hxx  |   30 +
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx |   87 ++--
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.hxx |2 
 libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx |   81 +++-
 libreofficekit/qa/gtktiledviewer/gtv-main-toolbar.cxx   |   24 -
 libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx|   34 -
 libreofficekit/qa/gtktiledviewer/gtv.ui |   17 
 sc/source/ui/view/gridwin.cxx   |1 
 sfx2/source/dialog/basedlgs.cxx |   43 ++
 sfx2/source/dialog/tabdlg.cxx   |   27 +
 sfx2/source/view/lokhelper.cxx  |   26 -
 sfx2/source/view/viewsh.cxx |   10 
 sw/inc/unotxdoc.hxx |   20 -
 sw/source/uibase/uno/unotxdoc.cxx   |  194 
--
 tools/source/generic/gen.cxx|   10 
 vcl/Library_vcl.mk  |1 
 vcl/inc/window.h|3 
 vcl/source/app/IDialogRenderable.cxx|   22 -
 vcl/source/window/dialog.cxx|  170 
+---
 vcl/source/window/floatwin.cxx  |8 
 vcl/source/window/paint.cxx |   16 
 vcl/source/window/window.cxx|  172 

 vcl/source/window/winproc.cxx   |4 
 34 files changed, 618 insertions(+), 695 deletions(-)

New commits:
commit b97fa81cac972c729cd843a689fb76342b4ac19d
Author: Jan Holesovsky 
Date:   Tue Nov 28 11:52:16 2017 +0100

Fix 'unused parameter' warnings.

Change-Id: I8478e907a66ca918eddc7a543cbcf23e17d9ee5a

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 4810f9b59039..307418fcd55c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2267,7 +2267,7 @@ static void doc_postKeyEvent(LibreOfficeKitDocument* 
pThis, int nType, int nChar
 pDoc->postKeyEvent(nType, nCharCode, nKeyCode);
 }
 
-static void doc_postDialogKeyEvent(LibreOfficeKitDocument* pThis, unsigned 
nLOKWindowId, int nType, int nCharCode, int nKeyCode)
+static void doc_postDialogKeyEvent(LibreOfficeKitDocument* /*pThis*/, unsigned 
nLOKWindowId, int nType, int nCharCode, int nKeyCode)
 {
 SolarMutexGuard aGuard;
 
@@ -2445,7 +2445,7 @@ static void doc_postMouseEvent(LibreOfficeKitDocument* 
pThis, int nType, int nX,
 }
 }
 
-static void doc_postDialogMouseEvent(LibreOfficeKitDocument* pThis, unsigned 
nLOKWindowId, int nType, int nX, int nY, int nCount, int nButtons, int 
nModifier)
+static void doc_postDialogMouseEvent(LibreOfficeKitDocument* /*pThis*/, 
unsigned nLOKWindowId, int nType, int nX, int nY, int nCount, int nButtons, int 
nModifier)
 {
 SolarMutexGuard aGuard;
 
@@ -2476,7 +2476,7 @@ static void 
doc_postDialogMouseEvent(LibreOfficeKitDocument* pThis, unsigned nLO
 }
 }
 
-static void doc_postDialogChildMouseEvent(LibreOfficeKitDocument* pThis, 
unsigned nLOKWindowId, int nType, int nX, int nY, int nCount, int nButtons, int 
nModifier)
+static void doc_postDialogChildMouseEvent(LibreOfficeKitDocument* /*pThis*/, 
unsigned nLOKWindowId, int nType, int nX, int nY, int nCount, int nButtons, int 
nModifier)
 {
 SolarMutexGuard aGuard;
 
@@ -3283,7 +3283,7 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* 
/*pThis*/,
 return nullptr;
 }
 
-static void doc_paintDialog(LibreOfficeKitDocument* pThis, unsigned 
nLOKWindowId,
+static void doc_paintDialog(LibreOfficeKitDocument* /*pThis*/, unsigned 
nLOKWindowId,
 unsigned char* pBuffer,
 const int nX, const int nY,

[Libreoffice-bugs] [Bug 103080] A new default set of bundled fonts

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103080

--- Comment #28 from Yannick.D  ---
Interoperability is of course very valuable to most users so bundling those
fonts is probably a good idea. My point was more towards that there's no need
have metrically identical to anything fonts as LOs own default. I'd go for
something more appealing here. But thats OT anyway.

Thanks for pointing to those posts, Heiko! I missed the one on additions.
Still, with such things in planning I even less get why there's a need to mess
with fonts now for so little gain.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114105] Crash on closing Data source window

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114105

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
I don't understand well how to reproduce this.

Indeed, you tell:
"drag field (column header) to document"
Here i got a grey field on my brand writer doc.

Then in parentheses, you indicate:
"(Select row, click "Data to fields" on tool bar Table Data)"

Why to put this in parenthesis, it's just another step not the detail of "drag
field..." step since it's different.

Then, "close data source window". I don't see a specific window with a cross to
close. I tried "disconnect" option after right click on "namen_test.ods"

I suppose I missed something but don't know what.

BTW, I tried with master sources updated today with gtk rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114104] Crash on opening docx files

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114104

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Could you provide version info of libxmlsec1-nss?
Indeed, you'll need 1.2.24 at minimum (see
https://cgit.freedesktop.org/libreoffice/core/diff/configure.ac?id=ab50f0b08b22af1e60a0b6ce5e7e8e7d1f665216)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114080] [FILESAVE] Save as Text does not put end-of-line after each line shown on screen

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114080

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #2 from Dieter Praas  ---
Dear reporter,
could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114013] Compound strings in Writer: "Text Format " + "(Search)" or "( Replace)"

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114013

Gabor Kelemen  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |

--- Comment #3 from Gabor Kelemen  ---
Proposed patch is in gerrit, but UX might come up with better wording: 

https://gerrit.libreoffice.org/45438

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114122] Double click in special character dialog inserts a character into the document , even when the dialog is only opened to select a single character

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114122

Tamás Zolnai  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp, topicUI
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Tamás Zolnai  ---
Let's turn this into a easy hack. The code is here:
cui/source/dialogs/cuicharmap.cxx
sfx2/source/control/charwin.cxx

Check InsertCharToDoc() method in both file, this is a good debug point to see
how this insertion works.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114122] New: Double click in special character dialog inserts a character into the document , even when the dialog is only opened to select a single character

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114122

Bug ID: 114122
   Summary: Double click in special character dialog inserts a
character into the document, even when the dialog is
only opened to select a single character
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: zolnaitamas2...@gmail.com

Description:
Special character dialog has two useages. First one when you open it directly
(conext menu -> Special Character or Insert -> Special character). In this case
its functional to insert character by double click in the character list, so
you can insert more character before you close the dialog. The second usage
when the dialog is opened from an other dialog and is opened for selecting one
single character which is used by the other dialog and not actually inserted
into the docuemnt (e.g. Bullets and Numbering -> Customize -> Select... (select
custom bullet)). In this case the dialog should not insert any character into
the document.

Steps to Reproduce:
1. Open Impress
2. Open Bullets and numbering -> Customize tab
3. Push Select... button to open Special character dialog
4. Select a character from favorite or recent character by double click

Actual Results:  
The character is inserted into the document by double click.

Expected Results:
No character should be inserted into the document. See how it works if you
select a character from the main character selector item.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/61.0.3163.100 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113980] Insert Row and Insert Column in Standard Toolbar not available after ( Auto-) Filter has been applied

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113980

--- Comment #6 from Rainer Bielefeld Retired  
---
Created attachment 138048
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138048=edit
Sampe Document

The document contains a test area and an additional table with STR and test
results. I steps 12,13 you see a difference to Bug 57351

We should try to find out with which Version this one started.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48927] PDF export of a vector drawing replaces text by tiny curves and lines

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48927

--- Comment #8 from paulyste...@web.de ---
but is not pixelated.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

2017-11-28 Thread Bartosz Kosiorek

 sc/source/filter/oox/stylesbuffer.cxx |   10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 3278c8f9bb040cddd15d9e7eb4991d0447cbc964
Author: Bartosz Kosiorek 
Date:   Sat Nov 25 09:51:58 2017 +0100

tdf#113271 Fix order of color's attributes import.

The order of import color is very important in case of more than one color 
attributes was provided.
This order (theme -> rgb -> indexed -> auto) is not documented
and was gathered experimentally based on MS Excel 2013.

Information about :

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.fonts(v=office.14).aspx

Information about font:
https://msdn.microsoft.com/en-us/library/ff531892(v=office.12).aspx

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.font(v=office.14).aspx

More information about color class:

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.color(v=office.14).aspx
https://msdn.microsoft.com/en-us/library/ff532831(v=office.12).aspx

Example:
With indexed auto, colour, rgb and them,


The priority is as follows:
1. theme
2. rgb
3. indexed
4. auto

Change-Id: I7bb5ab7d7b7a52091f0130fd6f21bac44eca7408
Reviewed-on: https://gerrit.libreoffice.org/45278
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/filter/oox/stylesbuffer.cxx 
b/sc/source/filter/oox/stylesbuffer.cxx
index 25fca16c643e..2711df0ad34f 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -266,14 +266,16 @@ void Color::setIndexed( sal_Int32 nPaletteIdx, double 
fTint )
 
 void Color::importColor( const AttributeList& rAttribs )
 {
-if( rAttribs.getBool( XML_auto, false ) )
-setAuto();
+// tdf#113271 The order of import color is very important in case of more 
than one color attributes was provided.
+// This order (theme -> rgb -> indexed -> auto) is not documented and was 
gathered experimentally based on MS Excel 2013.
+if( rAttribs.hasAttribute( XML_theme ) )
+setTheme( rAttribs.getInteger( XML_theme, -1 ), rAttribs.getDouble( 
XML_tint, 0.0 ) );
 else if( rAttribs.hasAttribute( XML_rgb ) )
 setRgb( rAttribs.getIntegerHex( XML_rgb, API_RGB_TRANSPARENT ), 
rAttribs.getDouble( XML_tint, 0.0 ) );
-else if( rAttribs.hasAttribute( XML_theme ) )
-setTheme( rAttribs.getInteger( XML_theme, -1 ), rAttribs.getDouble( 
XML_tint, 0.0 ) );
 else if( rAttribs.hasAttribute( XML_indexed ) )
 setIndexed( rAttribs.getInteger( XML_indexed, -1 ), 
rAttribs.getDouble( XML_tint, 0.0 ) );
+else if( rAttribs.getBool( XML_auto, false ) )
+setAuto();
 else
 {
 OSL_FAIL( "Color::importColor - unknown color type" );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2017-11-28 Thread Bartosz Kosiorek

 sc/source/filter/oox/stylesbuffer.cxx |   10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 51a1fb0beb813624b5bc3255a889f9d630ccb0d4
Author: Bartosz Kosiorek 
Date:   Sat Nov 25 09:51:58 2017 +0100

tdf#113271 Fix order of color's attributes import.

The order of import color is very important in case of more than one color 
attributes was provided.
This order (theme -> rgb -> indexed -> auto) is not documented
and was gathered experimentally based on MS Excel 2013.

Information about :

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.fonts(v=office.14).aspx

Information about font:
https://msdn.microsoft.com/en-us/library/ff531892(v=office.12).aspx

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.font(v=office.14).aspx

More information about color class:

https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.color(v=office.14).aspx
https://msdn.microsoft.com/en-us/library/ff532831(v=office.12).aspx

Example:
With indexed auto, colour, rgb and them,


The priority is as follows:
1. theme
2. rgb
3. indexed
4. auto

Change-Id: I7bb5ab7d7b7a52091f0130fd6f21bac44eca7408
Reviewed-on: https://gerrit.libreoffice.org/45266
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/filter/oox/stylesbuffer.cxx 
b/sc/source/filter/oox/stylesbuffer.cxx
index 7a33511ee449..15f1093b03a6 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -266,14 +266,16 @@ void Color::setIndexed( sal_Int32 nPaletteIdx, double 
fTint )
 
 void Color::importColor( const AttributeList& rAttribs )
 {
-if( rAttribs.getBool( XML_auto, false ) )
-setAuto();
+// tdf#113271 The order of import color is very important in case of more 
than one color attributes was provided.
+// This order (theme -> rgb -> indexed -> auto) is not documented and was 
gathered experimentally based on MS Excel 2013.
+if( rAttribs.hasAttribute( XML_theme ) )
+setTheme( rAttribs.getInteger( XML_theme, -1 ), rAttribs.getDouble( 
XML_tint, 0.0 ) );
 else if( rAttribs.hasAttribute( XML_rgb ) )
 setRgb( rAttribs.getIntegerHex( XML_rgb, API_RGB_TRANSPARENT ), 
rAttribs.getDouble( XML_tint, 0.0 ) );
-else if( rAttribs.hasAttribute( XML_theme ) )
-setTheme( rAttribs.getInteger( XML_theme, -1 ), rAttribs.getDouble( 
XML_tint, 0.0 ) );
 else if( rAttribs.hasAttribute( XML_indexed ) )
 setIndexed( rAttribs.getInteger( XML_indexed, -1 ), 
rAttribs.getDouble( XML_tint, 0.0 ) );
+else if( rAttribs.getBool( XML_auto, false ) )
+setAuto();
 else
 {
 OSL_FAIL( "Color::importColor - unknown color type" );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 48927] PDF export of a vector drawing replaces text by tiny curves and lines

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48927

--- Comment #7 from paulyste...@web.de ---
also in 5.4.3.2 x64 win 10

fonts problem, some bezier curves not good?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: tools/map.cpp

2017-11-28 Thread Michael Meeks

 tools/map.cpp |   24 ++--
 1 file changed, 18 insertions(+), 6 deletions(-)

New commits:
commit 65f3d658cb77978276d5b8f1c99dea51eec71c37
Author: Michael Meeks 
Date:   Tue Nov 28 18:44:04 2017 +

Collect anonymous and file backed mappings too.

Change-Id: I7bf23917436bdffb483b288414409ccc53ed540c

diff --git a/tools/map.cpp b/tools/map.cpp
index cd7fd788..f3fb76b5 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -81,7 +81,7 @@ static int read_buffer(char *buffer, unsigned size,
 }
 
 
-static void dump_unshared(unsigned proc_id, const std::vector 
)
+static void dump_unshared(unsigned proc_id, const std::vector )
 {
 char path_proc[PATH_SIZE];
 snprintf(path_proc, sizeof(path_proc), "/proc/%d/pagemap", proc_id);
@@ -91,7 +91,7 @@ static void dump_unshared(unsigned proc_id, const 
std::vector 
 
 printf("Sharing map:\n");
 addr_t numShared = 0, numOwn = 0;
-for (auto p : heapVAddresses)
+for (auto p : vaddrs)
 {
 if (lseek(fd, (p / 0x1000 * 8), SEEK_SET) < 0)
 error(EXIT_FAILURE, errno, "Failed to seek in pagemap");
@@ -133,7 +133,8 @@ static void total_smaps(unsigned proc_id, const char *file, 
const char *cmdline)
 addr_t smap_value;
 char smap_key[MAP_SIZE];
 
-std::vector heapVAddresses;
+std::vector heapVAddrs, anonVAddrs, fileVAddrs;
+std::vector *pushTo = nullptr;
 
 if ((file_pointer = fopen(file, "r")) == nullptr)
 error(EXIT_FAILURE, errno, "%s", file);
@@ -142,13 +143,20 @@ static void total_smaps(unsigned proc_id, const char 
*file, const char *cmdline)
 {
 // collect heap page details
 if (strstr(buffer, "[heap]"))
+pushTo = 
+else if (strstr(buffer, "/"))
+pushTo = 
+else
+pushTo = 
+
+if (strstr(buffer, " rw-p "))
 {
 addr_t start, end;
 // 012d-0372f000 rw-p  00:00 0  [heap]
 if (sscanf(buffer, "%llx-%llx rw-p", , ) == 2)
 {
 for (addr_t p = start; p < end; p += 0x1000)
-heapVAddresses.push_back(p);
+pushTo->push_back(p);
 }
 else
 fprintf (stderr, "malformed heap line '%s'\n", buffer);
@@ -193,9 +201,13 @@ static void total_smaps(unsigned proc_id, const char 
*file, const char *cmdline)
 printf("Shared:%20lld kB\n", total_shared_clean + 
total_shared_dirty);
 printf("Private   :%20lld kB\n", total_private_clean + 
total_private_dirty);
 printf("--\n");
-printf("Heap page cnt :%20lld\n", (addr_t)heapVAddresses.size());
+printf("Heap page cnt :%20lld\n", (addr_t)heapVAddrs.size());
+printf("Anon page cnt :%20lld\n", (addr_t)anonVAddrs.size());
+printf("File page cnt :%20lld\n", (addr_t)fileVAddrs.size());
 printf("\n");
-dump_unshared(proc_id, heapVAddresses);
+dump_unshared(proc_id, heapVAddrs);
+dump_unshared(proc_id, anonVAddrs);
+dump_unshared(proc_id, fileVAddrs);
 }
 
 int main(int argc, char **argv)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114121] New: After a calc file with a chart opens, it asks you to save it when you close it, although no changes have been made.

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114121

Bug ID: 114121
   Summary: After a calc file with a chart opens, it asks you to
save it when you close it, although no changes have
been made.
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cban...@yahoo.com

Description:
After a calc file with a chart opens, it asks you to save it, when you close
it, although no changes have been made. The star on the save button appears as
soon as the file opens.

Steps to Reproduce:
1.Enter some numerical data in a calc sheet
2.Create a chart
3.save and close the file
4.open the file
5.close the file (the save prompt appears although no changes have been made)

Actual Results:  
After a calc file with a chart opens, it asks you to save it, when you close
it, although no changes have been made. The star on the save button appears as
soon as the file opens.

Expected Results:
The file should close without asking you to save it.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47730] Editing pdf in Draw corrupts text justification

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47730

--- Comment #12 from paulyste...@web.de ---
also in 5.4.3.2 x64 win10

page 1 fonts are too great in size 

false fonts and/or false size

conversion problem or fonts nearer to original not in LOO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35154] export to PDF with notes : slides are printed twice

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=35154

--- Comment #14 from paulyste...@web.de ---
also solved in 5.4.3.2 x64 win10

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: tools/map.cpp

2017-11-28 Thread Michael Meeks

 tools/map.cpp |   44 +++-
 1 file changed, 43 insertions(+), 1 deletion(-)

New commits:
commit 2fb4521a9cd296163c87c7f24e3b3d9bd9966dd8
Author: Michael Meeks 
Date:   Tue Nov 28 18:08:26 2017 +

Dump unshared heap memory ascii-art map by page..

Change-Id: I21ef386958e651b53b4d8eef434958a20adcbe68

diff --git a/tools/map.cpp b/tools/map.cpp
index 7bab3f17..cd7fd788 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -23,6 +23,7 @@
 #include 
 #include 
 
+typedef unsigned long long addr_t;
 
 #define MAP_SIZE 20
 #define PATH_SIZE 1000 // No harm in having it much larger than strictly 
necessary. Avoids compiler warning.
@@ -79,12 +80,52 @@ static int read_buffer(char *buffer, unsigned size,
 return total_bytes;
 }
 
+
+static void dump_unshared(unsigned proc_id, const std::vector 
)
+{
+char path_proc[PATH_SIZE];
+snprintf(path_proc, sizeof(path_proc), "/proc/%d/pagemap", proc_id);
+int fd = open(path_proc, 0);
+if (fd < 0)
+error(EXIT_FAILURE, errno, "Failed to open %s", path_proc);
+
+printf("Sharing map:\n");
+addr_t numShared = 0, numOwn = 0;
+for (auto p : heapVAddresses)
+{
+if (lseek(fd, (p / 0x1000 * 8), SEEK_SET) < 0)
+error(EXIT_FAILURE, errno, "Failed to seek in pagemap");
+addr_t vaddrData;
+if (read(fd, , 8) < 0)
+error(EXIT_FAILURE, errno, "Failed to read vaddrdata");
+{
+// https://patchwork.kernel.org/patch/6787921/
+//fprintf(stderr, "addr: 0x%8llx bits: 0x%8llx : %s\n", p, 
vaddrData,
+//(vaddrData & ((addr_t)1 << 56)) ? "unshared" : "shared");
+if (vaddrData & ((addr_t)1 << 56))
+{
+numOwn++;
+printf("*");
+}
+else
+{
+numShared++;
+printf(".");
+}
+}
+if (!((numShared + numOwn) % 128))
+printf("\n");
+}
+printf ("\nTotals:\n");
+printf ("\tshared   %5lld (%lldkB)\n", numShared, numShared * 4);
+printf ("\tunshared %5lld (%lldkB)\n", numOwn, numOwn * 4);
+}
+
 static void total_smaps(unsigned proc_id, const char *file, const char 
*cmdline)
 {
 FILE *file_pointer;
 char buffer[BUFFER_SIZE];
 
-typedef unsigned long long addr_t;
 addr_t total_private_dirty = 0ull;
 addr_t total_private_clean = 0ull;
 addr_t total_shared_dirty = 0ull;
@@ -154,6 +195,7 @@ static void total_smaps(unsigned proc_id, const char *file, 
const char *cmdline)
 printf("--\n");
 printf("Heap page cnt :%20lld\n", (addr_t)heapVAddresses.size());
 printf("\n");
+dump_unshared(proc_id, heapVAddresses);
 }
 
 int main(int argc, char **argv)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 35154] export to PDF with notes : slides are printed twice

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=35154

paulyste...@web.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #13 from paulyste...@web.de ---
solved in 5.3.7.2 

optional 

printing notes pages option is available in 5.3.7.2

now all three possible: 

only slides
notes pages also
notes pages only

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

2017-11-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
Bug 103378 depends on bug 35154, which changed state.

Bug 35154 Summary: export to PDF with notes : slides are printed twice
https://bugs.documentfoundation.org/show_bug.cgi?id=35154

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/libcmis

2017-11-28 Thread Stephan Bergmann

 external/libcmis/StaticLibrary_libcmis.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c8e37ef268cae23a92c298721f1493daeda323c2
Author: Stephan Bergmann 
Date:   Tue Nov 28 13:45:00 2017 +0100

external/libcmis: Falling back to C++03 is too drastic

e.g. when compiling against system libxml2, which in turn includes system
ICU include files, which may use C++11 chart16_t.  So assume that 
-std=gnu++14
is acceptable for any GCC version for which at least on of -std=gnu++17,
-std=gnu++1z, -std=c++17, -std=c++1z is acceptable, and just fall back to 
C++14.

Change-Id: Id9f07ab4f419e5683f4fb9c9b2d3bdda251cdd1b
Reviewed-on: https://gerrit.libreoffice.org/45409
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/external/libcmis/StaticLibrary_libcmis.mk 
b/external/libcmis/StaticLibrary_libcmis.mk
index b3940b7a749a..39b9545d5345 100644
--- a/external/libcmis/StaticLibrary_libcmis.mk
+++ b/external/libcmis/StaticLibrary_libcmis.mk
@@ -23,14 +23,14 @@ $(eval $(call gb_StaticLibrary_add_cxxflags,libcmis,\
 ))
 endif
 
-# Build as C++03 if necessary to avoid GCC C++17 "error: ISO C++1z does not
+# Build as C++14 if necessary to avoid GCC C++17 "error: ISO C++1z does not
 # allow dynamic exception specifications", until upstream libcmis is ported to
 # C++17:
 ifeq ($(COM)-$(COM_IS_CLANG),GCC-)
 $(eval $(call gb_StaticLibrary_add_cxxflags,libcmis, \
 $(if $(filter -std=gnu++17 -std=gnu++1z -std=c++17 -std=c++1z, \
 $(CXXFLAGS_CXX11)), \
-$(gb_CXX03FLAGS)) \
+-std=gnu++14) \
 ))
 endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: hwpfilter/source

2017-11-28 Thread Andrea Gelmini

 hwpfilter/source/hwpeq.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 46f091f714f3f29a88c801b1903e229b4a0a79b2
Author: Andrea Gelmini 
Date:   Tue Nov 28 17:21:16 2017 +0100

Fix typo

Change-Id: I4de461692ac261600c1b0b760ffb94156893fa0d
Reviewed-on: https://gerrit.libreoffice.org/45429
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/hwpfilter/source/hwpeq.cxx b/hwpfilter/source/hwpeq.cxx
index 5be9ad7c2603..979a1b1d4673 100644
--- a/hwpfilter/source/hwpeq.cxx
+++ b/hwpfilter/source/hwpeq.cxx
@@ -481,7 +481,7 @@ void push_token(MzString const , MzString const 
, istream *strm)
  * It returns the length of the read tokens.
  *
  * control char, control sequence, binary sequence,
- * alphabet string, sigle character */
+ * alphabet string, single character */
 static int next_token(MzString , MzString , istream *strm)
 {
   std::istream::int_type ch = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: tools/map.cpp

2017-11-28 Thread Michael Meeks

 tools/map.cpp |   61 +++---
 1 file changed, 42 insertions(+), 19 deletions(-)

New commits:
commit 5540fc0b7f6fda918430724a6523c685d1876b9d
Author: Michael Meeks 
Date:   Tue Nov 28 17:27:08 2017 +

Cleanup, memory map dumper, add  mode, and collect heap pages.

Change-Id: I14e428b96c591e84ec9f50f0a75782c97660944b

diff --git a/tools/map.cpp b/tools/map.cpp
index e5e16777..7bab3f17 100644
--- a/tools/map.cpp
+++ b/tools/map.cpp
@@ -9,6 +9,9 @@
 
 #include "config.h"
 
+#include 
+
+#include 
 #include 
 #include 
 #include 
@@ -20,6 +23,7 @@
 #include 
 #include 
 
+
 #define MAP_SIZE 20
 #define PATH_SIZE 1000 // No harm in having it much larger than strictly 
necessary. Avoids compiler warning.
 #define BUFFER_SIZE 9600
@@ -80,18 +84,35 @@ static void total_smaps(unsigned proc_id, const char *file, 
const char *cmdline)
 FILE *file_pointer;
 char buffer[BUFFER_SIZE];
 
-unsigned long long total_private_dirty = 0ull;
-unsigned long long total_private_clean = 0ull;
-unsigned long long total_shared_dirty = 0ull;
-unsigned long long total_shared_clean = 0ull;
-unsigned long long smap_value;
+typedef unsigned long long addr_t;
+addr_t total_private_dirty = 0ull;
+addr_t total_private_clean = 0ull;
+addr_t total_shared_dirty = 0ull;
+addr_t total_shared_clean = 0ull;
+addr_t smap_value;
 char smap_key[MAP_SIZE];
 
+std::vector heapVAddresses;
+
 if ((file_pointer = fopen(file, "r")) == nullptr)
 error(EXIT_FAILURE, errno, "%s", file);
 
 while (fgets(buffer, sizeof(buffer), file_pointer))
 {
+// collect heap page details
+if (strstr(buffer, "[heap]"))
+{
+addr_t start, end;
+// 012d-0372f000 rw-p  00:00 0  [heap]
+if (sscanf(buffer, "%llx-%llx rw-p", , ) == 2)
+{
+for (addr_t p = start; p < end; p += 0x1000)
+heapVAddresses.push_back(p);
+}
+else
+fprintf (stderr, "malformed heap line '%s'\n", buffer);
+}
+
 if (buffer[0] >= 'A' && buffer[0] <= 'Z')
 {
 if (sscanf(buffer, "%20[^:]: %llu", smap_key, _value) == 2)
@@ -120,9 +141,6 @@ static void total_smaps(unsigned proc_id, const char *file, 
const char *cmdline)
 }
 }
 
-if (errno)
-error(EXIT_FAILURE, errno, "%s\n", cmdline);
-
 printf("%s\n", cmdline);
 printf("Process ID:%20d\n", proc_id);
 printf("--\n");
@@ -132,7 +150,10 @@ static void total_smaps(unsigned proc_id, const char 
*file, const char *cmdline)
 printf("Private Dirty :%20lld kB\n", total_private_dirty);
 printf("--\n");
 printf("Shared:%20lld kB\n", total_shared_clean + 
total_shared_dirty);
-printf("Private   :%20lld kB\n\n", total_private_clean + 
total_private_dirty);
+printf("Private   :%20lld kB\n", total_private_clean + 
total_private_dirty);
+printf("--\n");
+printf("Heap page cnt :%20lld\n", (addr_t)heapVAddresses.size());
+printf("\n");
 }
 
 int main(int argc, char **argv)
@@ -140,15 +161,21 @@ int main(int argc, char **argv)
 DIR *root_proc;
 struct dirent *dir_proc;
 
-unsigned pid_proc;
 char path_proc[PATH_SIZE];
 char cmdline[BUFFER_SIZE];
+unsigned forPid = 0;
 
 setlocale (LC_ALL, "");
 getopt(argc, argv, "");
 
-if (argc != 2)
-error(EXIT_FAILURE, EINVAL, "incorrect arguments");
+if (argc < 1 || strstr(argv[1], "--help"))
+{
+fprintf(stderr, "Usage: loolmap \n");
+fprintf(stderr, "Dump memory map information for a given process\n");
+return 0;
+}
+
+forPid = atoi(argv[1]);
 
 root_proc = opendir("/proc");
 if (!root_proc)
@@ -161,11 +188,10 @@ int main(int argc, char **argv)
 
 if (*dir_proc->d_name > '0' && *dir_proc->d_name <= '9')
 {
-pid_proc = strtoul(dir_proc->d_name, nullptr, 10);
+unsigned pid_proc = strtoul(dir_proc->d_name, nullptr, 10);
 snprintf(path_proc, sizeof(path_proc), "/proc/%s/%s", 
dir_proc->d_name, "cmdline");
 if (read_buffer(cmdline, sizeof(cmdline), path_proc, ' ') &&
-strstr(cmdline, argv[1]) &&
-!strstr(cmdline, argv[0]))
+(forPid == pid_proc || (forPid == 0 && strstr(cmdline, 
argv[1]) && !strstr(cmdline, argv[0]
 {
 snprintf(path_proc, sizeof(path_proc), "/proc/%s/%s", 
dir_proc->d_name, "smaps");
 total_smaps(pid_proc, path_proc, cmdline);
@@ -173,10 +199,7 @@ int main(int argc, char **argv)
 }
 }
 
-if (errno)
-error(EXIT_FAILURE, errno, "fail");
-
-  return EXIT_SUCCESS;
+return EXIT_SUCCESS;
 }
 
 /* vim:set

[Libreoffice-qa] QA Meeting Minutes (2017-11-28)

2017-11-28 Thread Xisco Fauli

Meeting started by x1sc0 at 16:00:36 UTC.  The full logs are available
at
http://dev-downloads.libreoffice.org/meetbot/libreoffice-qa/2017/libreoffice-qa.2017-11-28-16.00.log.html
.



Meeting summary
---

* roll call  (x1sc0, 16:01:28)

* uitests/testlink  (x1sc0, 16:06:39)

* how to improve the BHSs  (x1sc0, 16:20:03)
  * LINK: https://ibb.co/nBUH3R  (x1sc0, 16:21:16)
  * LINK: https://quality.mozilla.org/  (buovjaga, 16:27:16)



Meeting ended at 16:58:45 UTC.



People present (lines said)
---

* x1sc0 (60)
* sophi (20)
* buovjaga (14)
* IZBot (2)
* cloph (1)

-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sw/source

2017-11-28 Thread Caolán McNamara

 sw/source/filter/ww8/ww8par6.cxx |   13 +++--
 sw/source/filter/ww8/ww8scan.cxx |9 -
 2 files changed, 15 insertions(+), 7 deletions(-)

New commits:
commit 0541dd30d3c8a650531d2ff7dd3a6d52aa66a633
Author: CaolÃ¡n McNamara 
Date:   Tue Nov 28 10:55:39 2017 +

ofz: check sprm bounds

and don't reuse results of previous search

Change-Id: I15d55aba260377f2f43627d775adf1a01370ae3e
Reviewed-on: https://gerrit.libreoffice.org/45408
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 81efda11a8e2..e65aa9af86a7 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -1269,24 +1269,25 @@ static sal_uInt8 lcl_ReadBorders(bool bVer67, 
WW8_BRCVer9* brc, WW8PLCFx_Cp_FKP*
 {
 if( !bVer67 )
 {
-SprmResult aSprm[4];
-
+SprmResult a8Sprm[4];
 if (pSep->Find4Sprms(
 NS_sprm::sprmSBrcTop80, NS_sprm::sprmSBrcLeft80,
 NS_sprm::sprmSBrcBottom80, NS_sprm::sprmSBrcRight80,
-aSprm[0], aSprm[1], aSprm[2], aSprm[3]))
+a8Sprm[0], a8Sprm[1], a8Sprm[2], a8Sprm[3]))
 {
 for( int i = 0; i < 4; ++i )
-nBorder |= int(SetWW8_BRC(8, brc[i], aSprm[i].pSprm, 
aSprm[i].nRemainingData))<Find4Sprms(
 NS_sprm::sprmSBrcTop, NS_sprm::sprmSBrcLeft,
 NS_sprm::sprmSBrcBottom, NS_sprm::sprmSBrcRight,
-aSprm[0], aSprm[1], aSprm[2], aSprm[3]))
+a9Sprm[0], a9Sprm[1], a9Sprm[2], a9Sprm[3]))
 {
 for( int i = 0; i < 4; ++i )
-nBorder |= int(SetWW8_BRC(9, brc[i], aSprm[i].pSprm, 
aSprm[i].nRemainingData))<

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - package/source

2017-11-28 Thread Caolán McNamara

 package/source/zipapi/MemoryByteGrabber.hxx |2 ++
 package/source/zipapi/ZipFile.cxx   |3 +++
 2 files changed, 5 insertions(+)

New commits:
commit 2867c32c99b85e42b018266988dc8f7796c1fc77
Author: CaolÃ¡n McNamara 
Date:   Mon Nov 27 16:29:37 2017 +

keep track of available data

Change-Id: Idc54cdef0f3a4355a7e26f25cdc5b50d65d9d583
Reviewed-on: https://gerrit.libreoffice.org/45353
Reviewed-by: Michael Stahl 
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/package/source/zipapi/MemoryByteGrabber.hxx 
b/package/source/zipapi/MemoryByteGrabber.hxx
index 1366eea478b0..5417406db379 100644
--- a/package/source/zipapi/MemoryByteGrabber.hxx
+++ b/package/source/zipapi/MemoryByteGrabber.hxx
@@ -36,6 +36,8 @@ public:
 }
 const sal_Int8 * getCurrentPos () { return mpBuffer + mnCurrent; }
 
+sal_Int32 remainingSize() const { return mnEnd - mnCurrent; }
+
 // XInputStream chained
 
 /// @throws css::io::NotConnectedException
diff --git a/package/source/zipapi/ZipFile.cxx 
b/package/source/zipapi/ZipFile.cxx
index b7cdf7289d4c..61f7ea1dacc1 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -934,6 +934,9 @@ sal_Int32 ZipFile::readCEN()
 if ( aEntry.nExtraLen < 0 )
 throw ZipException("unexpected extra header info length" );
 
+if (aEntry.nPathLen > aMemGrabber.remainingSize())
+throw ZipException("name too long");
+
 // read always in UTF8, some tools seem not to set UTF8 bit
 aEntry.sPath = OUString::intern ( reinterpret_cast(aMemGrabber.getCurrentPos()),
aEntry.nPathLen,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/source

2017-11-28 Thread Caolán McNamara

 sw/source/filter/ww8/ww8par6.cxx |   13 +++--
 sw/source/filter/ww8/ww8scan.cxx |9 -
 2 files changed, 15 insertions(+), 7 deletions(-)

New commits:
commit f3c4dd743c026d9e987656d0abd4979df6f11b30
Author: CaolÃ¡n McNamara 
Date:   Tue Nov 28 10:55:39 2017 +

ofz: check sprm bounds

and don't reuse results of previous search

Change-Id: I15d55aba260377f2f43627d775adf1a01370ae3e
Reviewed-on: https://gerrit.libreoffice.org/45407
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index f6bf8446ecbc..3678807b542f 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -1266,24 +1266,25 @@ static sal_uInt8 lcl_ReadBorders(bool bVer67, 
WW8_BRCVer9* brc, WW8PLCFx_Cp_FKP*
 {
 if( !bVer67 )
 {
-SprmResult aSprm[4];
-
+SprmResult a8Sprm[4];
 if (pSep->Find4Sprms(
 NS_sprm::sprmSBrcTop80, NS_sprm::sprmSBrcLeft80,
 NS_sprm::sprmSBrcBottom80, NS_sprm::sprmSBrcRight80,
-aSprm[0], aSprm[1], aSprm[2], aSprm[3]))
+a8Sprm[0], a8Sprm[1], a8Sprm[2], a8Sprm[3]))
 {
 for( int i = 0; i < 4; ++i )
-nBorder |= int(SetWW8_BRC(8, brc[i], aSprm[i].pSprm, 
aSprm[i].nRemainingData))<Find4Sprms(
 NS_sprm::sprmSBrcTop, NS_sprm::sprmSBrcLeft,
 NS_sprm::sprmSBrcBottom, NS_sprm::sprmSBrcRight,
-aSprm[0], aSprm[1], aSprm[2], aSprm[3]))
+a9Sprm[0], a9Sprm[1], a9Sprm[2], a9Sprm[3]))
 {
 for( int i = 0; i < 4; ++i )
-nBorder |= int(SetWW8_BRC(9, brc[i], aSprm[i].pSprm, 
aSprm[i].nRemainingData))<

1 2 3 4 >

1 - 100 of 313 matches

Mail list logo