date:20171219

[Libreoffice-bugs] [Bug 103759] [META] 3D model bugs and enhancements

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103759
Bug 103759 depends on bug 103670, which changed state.

Bug 103670 Summary: EDITING: inserting 3D models doesn't work, *.gltf files are 
not recognized and can only view 3D models created with earlier versions of LO
https://bugs.documentfoundation.org/show_bug.cgi?id=103670

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103670] EDITING: inserting 3D models doesn't work, *.gltf files are not recognized and can only view 3D models created with earlier versions of LO

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103670

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #10 from Tamás Zolnai  ---
3D model feature is removed:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103761] Show 3D model fallback image when OpenGL capability not available

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103761

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Tamás Zolnai  ---
3D model feature is removed:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103759] [META] 3D model bugs and enhancements

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103759
Bug 103759 depends on bug 103761, which changed state.

Bug 103761 Summary: Show 3D model fallback image when OpenGL capability not 
available
https://bugs.documentfoundation.org/show_bug.cgi?id=103761

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104730] Import of 3D models missing

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104730

Tamás Zolnai  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Tamás Zolnai  ---
3D model feature is removed:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry

2017-12-19 Thread andreas kainz

 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |6 
++
 1 file changed, 6 insertions(+)

New commits:
commit 2dfd6c4f6e5c379facf4ae9c1956dea11455f034
Author: andreas kainz 
Date:   Tue Dec 19 23:32:49 2017 +0100

add icons to Reply and Delete Comment

Change-Id: Ie593a8cad4d0cbd663901fcabe07e5efb98f78be
Reviewed-on: https://gerrit.libreoffice.org/46827
Tested-by: Jenkins 
Reviewed-by: andreas_kainz 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 57fadcf37f38..e814b4f64fd3 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -6020,6 +6020,9 @@
 
   Delete All Comments by This Author
 
+
+  1
+
   
   
 
@@ -6030,6 +6033,9 @@
 
   Delete Comment
 
+
+  1
+
   
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: bin/gen-boost-headers external/boost

2017-12-19 Thread Stephan Bergmann

 bin/gen-boost-headers  |5 
++---
 external/boost/include/boost/algorithm/string.hpp  |5 
++---
 external/boost/include/boost/algorithm/string/case_conv.hpp|5 
++---
 external/boost/include/boost/algorithm/string/classification.hpp   |5 
++---
 external/boost/include/boost/algorithm/string/predicate.hpp|5 
++---
 external/boost/include/boost/algorithm/string/split.hpp|5 
++---
 external/boost/include/boost/any.hpp   |5 
++---
 external/boost/include/boost/archive/iterators/base64_from_binary.hpp  |5 
++---
 external/boost/include/boost/archive/iterators/binary_from_base64.hpp  |5 
++---
 external/boost/include/boost/archive/iterators/remove_whitespace.hpp   |5 
++---
 external/boost/include/boost/archive/iterators/transform_width.hpp |5 
++---
 external/boost/include/boost/asio.hpp  |5 
++---
 external/boost/include/boost/assign.hpp|5 
++---
 external/boost/include/boost/bind.hpp  |5 
++---
 external/boost/include/boost/cast.hpp  |5 
++---
 external/boost/include/boost/circular_buffer.hpp   |5 
++---
 external/boost/include/boost/config.hpp|5 
++---
 external/boost/include/boost/container/deque.hpp   |5 
++---
 external/boost/include/boost/cstdint.hpp   |5 
++---
 external/boost/include/boost/current_function.hpp  |5 
++---
 external/boost/include/boost/date_time.hpp |5 
++---
 external/boost/include/boost/date_time/posix_time/posix_time.hpp   |5 
++---
 external/boost/include/boost/enable_shared_from_this.hpp   |5 
++---
 external/boost/include/boost/exception/diagnostic_information.hpp  |5 
++---
 external/boost/include/boost/filesystem.hpp|5 
++---
 external/boost/include/boost/filesystem/path.hpp   |5 
++---
 external/boost/include/boost/foreach.hpp   |5 
++---
 external/boost/include/boost/format.hpp|5 
++---
 external/boost/include/boost/function.hpp  |5 
++---
 external/boost/include/boost/functional/hash.hpp   |5 
++---
 external/boost/include/boost/fusion/adapted/std_pair.hpp   |5 
++---
 external/boost/include/boost/fusion/include/adapt_struct.hpp   |5 
++---
 external/boost/include/boost/intrusive/circular_list_algorithms.hpp|5 
++---
 external/boost/include/boost/intrusive_ptr.hpp |5 
++---
 external/boost/include/boost/io/ios_state.hpp  |5 
++---
 external/boost/include/boost/iostreams/device/file_descriptor.hpp  |5 
++---
 external/boost/include/boost/iostreams/filter/gzip.hpp |5 
++---
 external/boost/include/boost/iostreams/filtering_stream.hpp|5 
++---
 external/boost/include/boost/iterator/iterator_facade.hpp  |5 
++---
 external/boost/include/boost/lexical_cast.hpp  |5 
++---
 external/boost/include/boost/locale.hpp|5 
++---
 external/boost/include/boost/locale/gnu_gettext.hpp|5 
++---
 external/boost/include/boost/logic/tribool.hpp |5 
++---
 external/boost/include/boost/make_shared.hpp   |5 
++---
 external/boost/include/boost/math/common_factor_rt.hpp |5 
++---
 external/boost/include/boost/math/constants/constants.hpp  |5 
++---
 external/boost/include/boost/math/special_functions/expm1.hpp  |5 
++---
 external/boost/include/boost/math/special_functions/log1p.hpp  |5 
++---
 external/boost/include/boost/math/special_functions/sinc.hpp   |5 
++---
 external/boost/include/boost/multi_array.hpp   |5 
++---
 external/boost/include/boost/multi_index/composite_key.hpp |5 
++---
 external/boost/include/boost/multi_index/identity.hpp  |5 
++---
 external/boost/include/boost/multi_index/mem_fun.hpp   |5 
++---
 external/boost/include/boost/multi_index/ordered_index.hpp |5 
++---
 external/boost/include/boost/multi_index/random_access_index.hpp   |5 
++---
 external/boost/include/boost/multi_index_container.hpp |5 
++---
 external/boost/include/boost/noncopyable.hpp   |5 
++---
 external/boost/include/boost/none.hpp  |5 
++---

[Libreoffice-commits] core.git: include/comphelper

2017-12-19 Thread Mike Kaganski

 include/comphelper/basicio.hxx |   22 ++
 1 file changed, 6 insertions(+), 16 deletions(-)

New commits:
commit a784ac2daf55f9e620d7c8da1b880ee539d9218a
Author: Mike Kaganski 
Date:   Wed Dec 20 05:51:54 2017 +0200

loplugin:unusedindex

Change-Id: I80c0a8dbfda14e54fcfaf33a241c83bad8495db1
Reviewed-on: https://gerrit.libreoffice.org/46833
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/include/comphelper/basicio.hxx b/include/comphelper/basicio.hxx
index 3dd8aea727ae..de444e0c12a1 100644
--- a/include/comphelper/basicio.hxx
+++ b/include/comphelper/basicio.hxx
@@ -63,28 +63,18 @@ COMPHELPER_DLLPUBLIC const 
css::uno::Reference& op
 template 
 const css::uno::Reference& operator >> (const 
css::uno::Reference& _rxInStream, 
css::uno::Sequence& _rSeq)
 {
-sal_Int32 nLen = _rxInStream->readLong();
-_rSeq.realloc(nLen);
-if (nLen)
-{
-ELEMENT* pElement = _rSeq.getArray();
-for (sal_Int32 i=0; i> *pElement;
-}
+_rSeq.realloc(_rxInStream->readLong());
+for (ELEMENT& rElement : _rSeq)
+_rxInStream >> rElement;
 return _rxInStream;
 }
 
 template 
 const css::uno::Reference& operator << (const 
css::uno::Reference& _rxOutStream, const 
css::uno::Sequence& _rSeq)
 {
-sal_Int32 nLen = _rSeq.getLength();
-_rxOutStream->writeLong(nLen);
-if (nLen)
-{
-const ELEMENT* pElement = _rSeq.getConstArray();
-for (sal_Int32 i = 0; i < nLen; ++i, ++pElement)
-_rxOutStream << *pElement;
-}
+_rxOutStream->writeLong(_rSeq.getLength());
+for (const ELEMENT& rElement : _rSeq)
+_rxOutStream << rElement;
 return _rxOutStream;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114523] Make inline tooltip for track changes optional

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114523

--- Comment #14 from JIM7  ---
I hope it is easy, and that I see it fairly soon.
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - extras/source

2017-12-19 Thread László Németh

 extras/source/autocorr/emoji/emoji.ulf | 1766 +++--
 1 file changed, 1707 insertions(+), 59 deletions(-)

New commits:
commit 9fc91e7a2d851790f68d11dc37d2b4dce1e8144b
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Mon Dec 18 13:48:38 2017 +0100

Add emojis of Unicode 7, 8, 9 and 10

for translation of the new shortcodes,
(also fixing a few older ones).

Note: only translations are added to the autocorrection,
so there won't be untranslated strings in a non-en-US
autocorrection table.

(cherry-picked from master from the commit 87ada8f,
also removing the empty line added by mistake)

Change-Id: Iff1c6f1d693b8e877a699c79fc3cf81d60dc6318
Reviewed-on: https://gerrit.libreoffice.org/46753
Tested-by: Jenkins 
Reviewed-by: LÃ¡szlÃ³ NÃ©meth 
Reviewed-on: https://gerrit.libreoffice.org/46780
Reviewed-by: Christian Lohmaier 

diff --git a/extras/source/autocorr/emoji/emoji.ulf 
b/extras/source/autocorr/emoji/emoji.ulf
index f06b2e0a9fb1..d2b8b4e6696d 100644
--- a/extras/source/autocorr/emoji/emoji.ulf
+++ b/extras/source/autocorr/emoji/emoji.ulf
@@ -757,11 +757,11 @@ en-US = "star2"
 
 [LIGHTNING]
 x-comment = "â (U+02607), see http://wiki.documentfoundation.org/Emoji;
-en-US = "lighting"
+en-US = "lightning3"
 
 [THUNDERSTORM]
 x-comment = "â (U+02608), see http://wiki.documentfoundation.org/Emoji;
-en-US = "storm"
+en-US = "storm2"
 
 [SUN]
 x-comment = "â (U+02609), see http://wiki.documentfoundation.org/Emoji;
@@ -913,7 +913,7 @@ en-US = "Moon2"
 
 [MERCURY]
 x-comment = "â¿ (U+0263F), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Mercury"
+en-US = "mercury"
 
 [FEMALE_SIGN]
 x-comment = "â (U+02640), see http://wiki.documentfoundation.org/Emoji;
@@ -921,7 +921,7 @@ en-US = "female"
 
 [EARTH]
 x-comment = "â (U+02641), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Earth"
+en-US = "earth"
 
 [MALE_SIGN]
 x-comment = "â (U+02642), see http://wiki.documentfoundation.org/Emoji;
@@ -929,71 +929,71 @@ en-US = "male"
 
 [JUPITER]
 x-comment = "â (U+02643), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Jupiter"
+en-US = "jupiter"
 
 [SATURN]
 x-comment = "â (U+02644), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Saturn"
+en-US = "saturn"
 
 [URANUS]
 x-comment = "â (U+02645), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Uranus"
+en-US = "uranus"
 
 [NEPTUNE]
 x-comment = "â (U+02646), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Neptune"
+en-US = "neptune"
 
 [PLUTO]
 x-comment = "â (U+02647), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Pluto"
+en-US = "pluto"
 
 [ARIES]
 x-comment = "â (U+02648), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Aries"
+en-US = "aries"
 
 [TAURUS]
 x-comment = "â (U+02649), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Taurus"
+en-US = "taurus"
 
 [GEMINI]
 x-comment = "â (U+0264A), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Gemini"
+en-US = "gemini"
 
 [CANCER]
 x-comment = "â (U+0264B), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Cancer"
+en-US = "cancer"
 
 [LEO]
 x-comment = "â (U+0264C), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Leo"
+en-US = "leo"
 
 [VIRGO]
 x-comment = "â (U+0264D), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Virgo"
+en-US = "virgo"
 
 [LIBRA]
 x-comment = "â (U+0264E), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Libra"
+en-US = "libra"
 
 [SCORPIUS]
 x-comment = "â (U+0264F), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Scorpius"
+en-US = "scorpius"
 
 [SAGITTARIUS]
 x-comment = "â (U+02650), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Sagittarius"
+en-US = "sagittarius"
 
 [CAPRICORN]
 x-comment = "â (U+02651), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Capricorn"
+en-US = "capricorn"
 
 [AQUARIUS]
 x-comment = "â (U+02652), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Aquarius"
+en-US = "aquarius"
 
 [PISCES]
 x-comment = "â (U+02653), see http://wiki.documentfoundation.org/Emoji;
-en-US = "Pisces"
+en-US = "pisces"
 
 [WHITE_CHESS_KING]
 x-comment = "â (U+02654), see http://wiki.documentfoundation.org/Emoji;
@@ -1153,11 +1153,11 @@ en-US = "dice6"
 
 [WHITE_FLAG]
 x-comment = "â (U+02690), see http://wiki.documentfoundation.org/Emoji;
-en-US = "flag"
+en-US = "flag4"
 
 [BLACK_FLAG]
 x-comment = "â (U+02691), see http://wiki.documentfoundation.org/Emoji;
-en-US = "flag2"
+en-US = "flag3"
 
 [HAMMER_AND_PICK]
 x-comment = "â (U+02692), see http://wiki.documentfoundation.org/Emoji;
@@ -1293,7 +1293,7 @@ en-US = "pentagram"
 
 [BLACK_CROSS_ON_SHIELD]
 x-comment = "â¨ (U+026E8), see http://wiki.documentfoundation.org/Emoji;
-en-US = "shield"
+en-US = "shield2"
 
 [CHURCH]
 x-comment = "âª (U+026EA), see

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - 2 commits - download.lst external/more_fonts Makefile.fetch Repository.mk sw/uiconfig

2017-12-19 Thread Yousuf Philips

 Makefile.fetch  |3 +
 Repository.mk   |3 +
 download.lst|6 +++
 external/more_fonts/ExternalPackage_alef.mk |   17 ++
 external/more_fonts/ExternalPackage_culmus.mk   |   33 
 external/more_fonts/ExternalPackage_libre_hebrew.mk |   25 +++
 external/more_fonts/Module_more_fonts.mk|6 +++
 external/more_fonts/UnpackedTarball_alef.mk |   14 
 external/more_fonts/UnpackedTarball_culmus.mk   |   14 
 external/more_fonts/UnpackedTarball_libre_hebrew.mk |   14 
 sw/uiconfig/swriter/menubar/menubar.xml |8 ++--
 11 files changed, 139 insertions(+), 4 deletions(-)

New commits:
commit 85e2a27409f184c8504e61163dc741a31ccc5186
Author: Yousuf Philips 
Date:   Sat Dec 16 16:55:46 2017 +0400

tdf#113538 Add Hebrew fonts into default installation

Includes these fonts
* Alef
* David CLM
* David Libre
* Frank Ruehl CLM
* Frank Ruhl Hofshi
* Miriam CLM
* Miriam Libre
* Miriam Mono CLM
* Nachlieli CLM
* Rubik

Change-Id: Ib16a30c1f5b8fae372b3f9fc3f6de8a3be55bc85
Reviewed-on: https://gerrit.libreoffice.org/45101
Reviewed-by: Yousuf Philips 
Tested-by: Yousuf Philips 
Tested-by: Jenkins 
(cherry picked from commit 4099b7628405e0ad16844eb59a916aa56ffa76ad)
Reviewed-on: https://gerrit.libreoffice.org/46752
Reviewed-by: Christian Lohmaier 

diff --git a/Makefile.fetch b/Makefile.fetch
index e3095eee699f..33558239eeb8 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -177,6 +177,9 @@ $(WORKDIR)/download: $(BUILDDIR)/config_$(gb_Side).mk 
$(SRCDIR)/download.lst $(S
$(call fetch_Optional,MORE_FONTS,FONT_SOURCESANS_TARBALL) \
$(call fetch_Optional,MORE_FONTS,FONT_EMOJIONE_COLOR_TARBALL) \
$(call fetch_Optional,MORE_FONTS,FONT_NOTO_TARBALL) \
+   $(call fetch_Optional,MORE_FONTS,FONT_CULMUS_TARBALL) \
+   $(call fetch_Optional,MORE_FONTS,FONT_LIBRE_HEBREW_TARBALL) \
+   $(call fetch_Optional,MORE_FONTS,FONT_ALEF_TARBALL) \
$(call fetch_Optional,MSPUB,MSPUB_TARBALL) \
$(call fetch_Optional,MWAW,MWAW_TARBALL) \
$(call 
fetch_Optional,MYSQL_CONNECTOR_CPP,MYSQL_CONNECTOR_CPP_TARBALL) \
diff --git a/Repository.mk b/Repository.mk
index 4bc9a34d87dc..c3ccf4c16142 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -946,14 +946,17 @@ $(eval $(call 
gb_Helper_register_packages_for_install,ooo_fonts,\
$(if $(USING_X11)$(ENABLE_HEADLESS)$(filter ANDROID,$(OS)), \
postprocess_fontconfig) \
$(call gb_Helper_optional,MORE_FONTS,\
+   fonts_alef \
fonts_caladea \
fonts_carlito \
+   fonts_culmus \
fonts_dejavu \
fonts_emojione_color \
fonts_gentium \
fonts_liberation \
fonts_liberation_narrow \
fonts_libertineg \
+   fonts_libre_hebrew \
fonts_noto \
fonts_sourcecode \
fonts_sourcesans \
diff --git a/download.lst b/download.lst
index 89f458c015e1..23ba942aa3bf 100644
--- a/download.lst
+++ b/download.lst
@@ -70,6 +70,12 @@ export FONT_EMOJIONE_COLOR_SHA256SUM := 
d1a08f7c10589f22740231017694af0a7a270760
 export FONT_EMOJIONE_COLOR_TARBALL := EmojiOneColor-SVGinOT-1.3.tar.gz
 export FONT_NOTO_SHA256SUM := 
8a269926a3c88dd14b124b19138b54408938a45ea6e60db65073469f45ae6ac8
 export FONT_NOTO_TARBALL := noto-fonts-20170306.tar.gz
+export FONT_CULMUS_SHA256SUM := 
dcf112cfcccb76328dcfc095f4d7c7f4d2f7e48d0eed5e78b100d1d77ce2ed1b
+export FONT_CULMUS_TARBALL := culmus-0.131.tar.gz
+export FONT_LIBRE_HEBREW_SHA256SUM := 
f596257c1db706ce35795b18d7f66a4db99d427725f20e9384914b534142579a
+export FONT_LIBRE_HEBREW_TARBALL := libre-hebrew-1.0.tar.gz
+export FONT_ALEF_SHA256SUM := 
b98b67602a2c8880a1770f0b9e37c190f29a7e2ade5616784f0b89fbdb75bf52
+export FONT_ALEF_TARBALL := alef-1.001.tar.gz
 export FREEHAND_SHA256SUM := 
0e422d1564a6dbf22a9af598535425271e583514c0f7ba7d9091676420de34ac
 export FREEHAND_TARBALL := libfreehand-0.1.2.tar.xz
 export FREETYPE_SHA256SUM := 
e5435f02e02d2b87bb8e4efdcaa14b1f78c9cf3ab1ed80f94b6382fb6acc7d78
diff --git a/external/more_fonts/ExternalPackage_alef.mk 
b/external/more_fonts/ExternalPackage_alef.mk
new file mode 100644
index ..f41aca483ef3
--- /dev/null
+++ b/external/more_fonts/ExternalPackage_alef.mk
@@ -0,0 +1,17 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the

unit test for COL_DEFAULT_SHAPE_FILLING

2017-12-19 Thread Heiko Tietze

Trying solve tdf#112541 I modified the values for COL_DEFAULT_SHAPE_FILLING and 
COL_DEFAULT_SHAPE_STROKE in include/svx/xdef.hxx. That works as expected but 
only when I not run the unit tests. The color value is hard-coded everywhere, 
and now I wonder if there is any good way to change the defaults.

Thanks in advance,
heiko




signature.asc
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: i18npool/source

2017-12-19 Thread Mike Kaganski

 i18npool/source/localedata/localedata.cxx|   35 ++-
 i18npool/source/nativenumber/nativenumbersupplier.cxx|4 -
 i18npool/source/transliteration/ignoreDiacritics_CTL.cxx |5 +-
 3 files changed, 19 insertions(+), 25 deletions(-)

New commits:
commit 4e124b17a71d24079f43da68fb239b2e2a29dc4e
Author: Mike Kaganski 
Date:   Wed Dec 20 05:43:19 2017 +0200

loplugin:unusedindex

Change-Id: Id6e17d00c87d79f899cf691d00e600dfc102cab0
Reviewed-on: https://gerrit.libreoffice.org/46832
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/i18npool/source/localedata/localedata.cxx 
b/i18npool/source/localedata/localedata.cxx
index 9d67a151fed2..6347b9a54353 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -352,12 +352,10 @@ namespace i18npool {
 // static
 Sequence< CalendarItem > LocaleDataImpl::downcastCalendarItems( const 
Sequence< CalendarItem2 > & rCi )
 {
-sal_Int32 nSize = rCi.getLength();
-Sequence< CalendarItem > aCi( nSize);
+Sequence< CalendarItem > aCi(rCi.getLength());
 CalendarItem* p1 = aCi.getArray();
-const CalendarItem2* p2 = rCi.getConstArray();
-for (sal_Int32 i=0; i < nSize; ++i, ++p1, ++p2)
-*p1 = *p2;
+for (const CalendarItem2& r2 : rCi)
+*p1++ = r2;
 return aCi;
 }
 
@@ -712,30 +710,29 @@ Sequence< CalendarItem2 > 
LocaleDataImpl::getCalendarItems(
 }
 else
 {
-sal_Int32 nSize = allCalendars[nWhichItem][nCalendar];
+const sal_Int32 nSize = allCalendars[nWhichItem][nCalendar];
 aItems.realloc( nSize);
-CalendarItem2* pItem = aItems.getArray();
 switch (nWhichItem)
 {
 case REF_DAYS:
 case REF_MONTHS:
 case REF_GMONTHS:
 case REF_PMONTHS:
-for (sal_Int32 j = 0; j < nSize; ++j, ++pItem)
+for (CalendarItem2& rItem : aItems)
 {
 CalendarItem2 item( allCalendars[rnOffset], 
allCalendars[rnOffset+1],
 allCalendars[rnOffset+2], 
allCalendars[rnOffset+3]);
-*pItem = item;
+rItem = item;
 rnOffset += 4;
 }
 break;
 case REF_ERAS:
 // Absent narrow name.
-for (sal_Int32 j = 0; j < nSize; ++j, ++pItem)
+for (CalendarItem2& rItem : aItems)
 {
 CalendarItem2 item( allCalendars[rnOffset], 
allCalendars[rnOffset+1],
 allCalendars[rnOffset+2], OUString());
-*pItem = item;
+rItem = item;
 rnOffset += 3;
 }
 break;
@@ -796,13 +793,11 @@ Sequence< Calendar > SAL_CALL
 LocaleDataImpl::getAllCalendars( const Locale& rLocale )
 {
 const Sequence< Calendar2 > aCal2( getAllCalendars2( rLocale));
-sal_Int32 nLen = aCal2.getLength();
-Sequence< Calendar > aCal1( nLen);
-const Calendar2* p2 = aCal2.getConstArray();
+Sequence< Calendar > aCal1( aCal2.getLength());
 Calendar* p1 = aCal1.getArray();
-for (sal_Int32 i=0; i < nLen; ++i, ++p1, ++p2)
+for (const Calendar2& r2 : aCal2)
 {
-*p1 = downcastCalendar( *p2);
+*p1++ = downcastCalendar( r2);
 }
 return aCal1;
 }
@@ -844,13 +839,11 @@ Sequence< Currency > SAL_CALL
 LocaleDataImpl::getAllCurrencies( const Locale& rLocale )
 {
 Sequence< Currency2 > aCur2( getAllCurrencies2( rLocale));
-sal_Int32 nLen = aCur2.getLength();
-Sequence< Currency > aCur1( nLen);
-const Currency2* p2 = aCur2.getArray();
+Sequence< Currency > aCur1( aCur2.getLength());
 Currency* p1 = aCur1.getArray();
-for (sal_Int32 i=0; i < nLen; ++i, ++p1, ++p2)
+for (const Currency2& r2 : aCur2)
 {
-*p1 = *p2;
+*p1 = r2;
 }
 return aCur1;
 }
diff --git a/i18npool/source/nativenumber/nativenumbersupplier.cxx 
b/i18npool/source/nativenumber/nativenumbersupplier.cxx
index 3c528e2f895e..cd8bfa25c905 100644
--- a/i18npool/source/nativenumber/nativenumbersupplier.cxx
+++ b/i18npool/source/nativenumber/nativenumbersupplier.cxx
@@ -99,7 +99,7 @@ bool AsciiToNative_numberMaker(const sal_Unicode *str, 
sal_Int32 begin, sal_Int3
 if ( len <= number->multiplierExponent[number->exponentCount-1] ) {
 if (number->multiplierExponent[number->exponentCount-1] > 1) {
 bool bNotZero = false;
-for (sal_Int32 i = 0; i < len; i++, begin++) {
+for (const sal_Int32 end = begin+len; begin < end; begin++) {
 if (bNotZero || str[begin] != NUMBER_ZERO) {
 dst[count] = numberChar[str[begin] - NUMBER_ZERO];
 if (useOffset)
@@ -278,7 +278,7 @@ static void

[Libreoffice-bugs] [Bug 114457] MacOS: OfaTreeOptionsDialog::LoadNodes(Module*, rtl:: OUString const&) is leaking a bit

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114457

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114455] SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114455

Julien Nabet  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114523] Make inline tooltip for track changes optional

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114523

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |difficultyInteresting,
   ||easyHack, skillCpp
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
Summary|TRACK CHANGES: Undesired|Make inline tooltip for
   |popup   |track changes optional
 Ever confirmed|0   |1
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 114523] Make inline tooltip for track changes optional

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114523

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |difficultyInteresting,
   ||easyHack, skillCpp
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
Summary|TRACK CHANGES: Undesired|Make inline tooltip for
   |popup   |track changes optional
 Ever confirmed|0   |1
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 114523] TRACK CHANGES: Undesired popup

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114523

--- Comment #13 from Heiko Tietze  ---
Created attachment 138543
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138543=edit
Tooltip for changes

Attaching an illustration of the issue

Normally it makes not much sense to modify standard behavior, and many users
may benefit from this function. But in this particular case we should introduce
an option to disable tooltips in the document. The worse thing is that the
tooltip also pops-up when show track changes is off, also when tracking has
ended.

So I suggest to add an option "[x] Show tooltips" under Tools > Options >
Writer > Changes, enabled by default, and make SwCursorShell::GetContentAtPos()
at sw/source/core/crsr/crstrvl.cxx dependent to this option and whether or not
track changes are shown at all.

Sounds like an interesting easyhack.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 114523] TRACK CHANGES: Undesired popup

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114523

--- Comment #13 from Heiko Tietze  ---
Created attachment 138543
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138543=edit
Tooltip for changes

Attaching an illustration of the issue

Normally it makes not much sense to modify standard behavior, and many users
may benefit from this function. But in this particular case we should introduce
an option to disable tooltips in the document. The worse thing is that the
tooltip also pops-up when show track changes is off, also when tracking has
ended.

So I suggest to add an option "[x] Show tooltips" under Tools > Options >
Writer > Changes, enabled by default, and make SwCursorShell::GetContentAtPos()
at sw/source/core/crsr/crstrvl.cxx dependent to this option and whether or not
track changes are shown at all.

Sounds like an interesting easyhack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 114431] FILEOPEN Cannot view table data in any ".odb" files following Windows update

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114431

--- Comment #8 from Julien Nabet  ---
Thank you for your feedback.
Sorry I can't help here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107804] Character and Paragraph sidebar content panels not expanded for some files (where missing fonts are substituted?)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107804

Aron Budea  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #16 from Aron Budea  ---
Fixed by the same commit as the one that fixed bug 99537:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ce2e94a98f5fc85bef7623a0227b3a95d8093288

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: formula/source

2017-12-19 Thread Mike Kaganski

 formula/source/core/api/FormulaCompiler.cxx |   12 +---
 1 file changed, 5 insertions(+), 7 deletions(-)

New commits:
commit 9c50b0ed877c4179b5820a32be742b2190d927ee
Author: Mike Kaganski 
Date:   Wed Dec 20 05:29:58 2017 +0200

loplugin:unusedindex

Change-Id: Id69dcfde5c8b5d39c272916e7c1bcc649f720888
Reviewed-on: https://gerrit.libreoffice.org/46829
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index da9ac30cc136..b0dca4d0864f 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -817,18 +817,16 @@ FormulaCompiler::OpCodeMapPtr 
FormulaCompiler::CreateOpCodeMap(
 FormulaGrammar::GRAM_EXTERNAL, bEnglish), 
FormulaGrammar::CONV_UNSPECIFIED)));
 SvtSysLocale aSysLocale;
 const CharClass* pCharClass = (xMap->isEnglish() ? nullptr : 
aSysLocale.GetCharClassPtr());
-FormulaOpCodeMapEntry const * pArr2 = rMapping.getConstArray();
-FormulaOpCodeMapEntry const * const pStop = pArr2 + rMapping.getLength();
-for ( ; pArr2 < pStop; ++pArr2)
+for (auto const& rMapEntry : rMapping)
 {
-OpCode eOp = OpCode(pArr2->Token.OpCode);
+OpCode eOp = OpCode(rMapEntry.Token.OpCode);
 if (eOp != ocExternal)
-xMap->putOpCode( pArr2->Name, eOp, pCharClass);
+xMap->putOpCode( rMapEntry.Name, eOp, pCharClass);
 else
 {
 OUString aExternalName;
-if (pArr2->Token.Data >>= aExternalName)
-xMap->putExternal( pArr2->Name, aExternalName);
+if (rMapEntry.Token.Data >>= aExternalName)
+xMap->putExternal( rMapEntry.Name, aExternalName);
 else
 {
 SAL_WARN( "formula.core", "FormulaCompiler::CreateOpCodeMap: 
no Token.Data external name");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svx svx/source

2017-12-19 Thread Noel Grandin

 include/svx/DescriptionGenerator.hxx  |6 +++---
 include/svx/unoapi.hxx|4 ++--
 include/svx/unoshape.hxx  |6 +++---
 svx/source/accessibility/DescriptionGenerator.cxx |   11 +--
 svx/source/unodraw/unoprov.cxx|6 +++---
 svx/source/unodraw/unoshape.cxx   |   16 
 6 files changed, 24 insertions(+), 25 deletions(-)

New commits:
commit 495bb32c23be5acec3783240eb03ccfc5aca44cd
Author: Noel Grandin 
Date:   Tue Dec 19 15:05:23 2017 +0200

long->sal_uInt16 in SvxShape

Change-Id: I28a54497b1a4c236d9d3bdb0f44d3e46f3e55de7
Reviewed-on: https://gerrit.libreoffice.org/46810
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/svx/DescriptionGenerator.hxx 
b/include/svx/DescriptionGenerator.hxx
index ecbe8cc51093..fd1b1e2a39ad 100644
--- a/include/svx/DescriptionGenerator.hxx
+++ b/include/svx/DescriptionGenerator.hxx
@@ -101,7 +101,7 @@ public:
 void AddProperty (const OUString& sPropertyName,
 PropertyType aType,
 const OUString& sLocalizedName=OUString(),
-long nWhichId=-1);
+sal_uInt16 nWhichId = 0x);
 
 /** Add the given property name and its associated value to the
 description string.  If the property value does not differ from the
@@ -123,7 +123,7 @@ public:
 void AddProperty (const OUString& sPropertyName,
 PropertyType aType,
 const char* pResourceId,
-long nWhichId=-1);
+sal_uInt16 nWhichId = 0x);
 
 /** Append the given string as is to the current description.
 @param sString
@@ -178,7 +178,7 @@ private:
 Name of the property.
 */
 SVX_DLLPRIVATE void AddString (const OUString& sPropertyName,
-const OUString& sLocalizedName, long nWhichId);
+const OUString& sLocalizedName, sal_uInt16 nWhichId);
 
 /** Add a property value formatted as fill style to the description
 string.  If the fill style is HATCH,
diff --git a/include/svx/unoapi.hxx b/include/svx/unoapi.hxx
index a2df06bf2341..8000220b2940 100644
--- a/include/svx/unoapi.hxx
+++ b/include/svx/unoapi.hxx
@@ -80,7 +80,7 @@ SVX_DLLPUBLIC bool SvxFieldUnitToMeasureUnit( const FieldUnit 
nVcl, short& eApi
  * @throws std::exception
 */
 SVX_DLLPUBLIC SAL_WARN_UNUSED_RESULT OUString
-SvxUnogetApiNameForItem(const sal_Int16 nWhich, const OUString& 
rInternalName);
+SvxUnogetApiNameForItem(const sal_uInt16 nWhich, const OUString& 
rInternalName);
 
 /**
  * If the given name is a predefined API name it is replaced by the predefined 
name
@@ -89,7 +89,7 @@ SVX_DLLPUBLIC SAL_WARN_UNUSED_RESULT OUString
  * @throws std::exception
 */
 SVX_DLLPUBLIC SAL_WARN_UNUSED_RESULT OUString
-SvxUnogetInternalNameForItem(const sal_Int16 nWhich, const OUString& 
rApiName);
+SvxUnogetInternalNameForItem(const sal_uInt16 nWhich, const OUString& 
rApiName);
 
 #endif // INCLUDED_SVX_UNOAPI_HXX
 
diff --git a/include/svx/unoshape.hxx b/include/svx/unoshape.hxx
index ba28d311dd5d..678ee0abeffc 100644
--- a/include/svx/unoshape.hxx
+++ b/include/svx/unoshape.hxx
@@ -148,7 +148,7 @@ protected:
 
 css::uno::Any GetAnyForItem( SfxItemSet const & aSet, const 
SfxItemPropertySimpleEntry* pMap ) const;
 
-bool SetFillAttribute( sal_Int32 nWID, const OUString& rName );
+bool SetFillAttribute( sal_uInt16 nWID, const OUString& rName );
 
 /** called from the XActionLockable interface methods on initial locking */
 virtual void lock();
@@ -216,8 +216,8 @@ public:
 sal_uInt32 getShapeKind() const;
 
 // styles need this
-static bool SetFillAttribute( sal_Int32 nWID, const OUString& rName, 
SfxItemSet& rSet, SdrModel const * pModel );
-static bool SetFillAttribute( sal_Int32 nWID, const OUString& rName, 
SfxItemSet& rSet );
+static bool SetFillAttribute( sal_uInt16 nWID, const OUString& rName, 
SfxItemSet& rSet, SdrModel const * pModel );
+static bool SetFillAttribute( sal_uInt16 nWID, const OUString& rName, 
SfxItemSet& rSet );
 
 /** same as SetFillAttribute but for property names instead of which ids,
 and the property found is returned instead of set at the object
diff --git a/svx/source/accessibility/DescriptionGenerator.cxx 
b/svx/source/accessibility/DescriptionGenerator.cxx
index 460ac069be5c..72f95751b478 100644
--- a/svx/source/accessibility/DescriptionGenerator.cxx
+++ b/svx/source/accessibility/DescriptionGenerator.cxx
@@ -126,7 +126,7 @@ void DescriptionGenerator::AddProperty (
 const OUString& sPropertyName,
 PropertyType aType,
 const char* pLocalizedNameId,
-long nWhichId)
+sal_uInt16 nWhichId)
 {
 OUString sLocalizedName;
 {
@@ -138,7 +138,7 @@ void DescriptionGenerator::AddProperty (
 
 
 void DescriptionGenerator::AddProperty (const OUString& sPropertyName,
-

[Libreoffice-commits] core.git: 2 commits - connectivity/inc connectivity/source dbaccess/source include/connectivity solenv/clang-format svx/source

2017-12-19 Thread Noel Grandin

 connectivity/inc/pch/precompiled_mysql.hxx  |1 
 connectivity/source/commontools/TColumnsHelper.cxx  |2 
 connectivity/source/commontools/TKeys.cxx   |2 
 connectivity/source/commontools/TSkipDeletedSet.cxx |   16 -
 connectivity/source/commontools/TTableHelper.cxx|   12 -
 connectivity/source/drivers/ado/ACatalog.cxx|8 
 connectivity/source/drivers/ado/ADatabaseMetaDataResultSet.cxx  |   18 -
 connectivity/source/drivers/ado/AGroup.cxx  |2 
 connectivity/source/drivers/ado/AIndex.cxx  |2 
 connectivity/source/drivers/ado/AKey.cxx|2 
 connectivity/source/drivers/ado/ATable.cxx  |6 
 connectivity/source/drivers/ado/AUser.cxx   |2 
 connectivity/source/drivers/calc/CCatalog.cxx   |2 
 connectivity/source/drivers/component/CTable.cxx|2 
 connectivity/source/drivers/dbase/DCatalog.cxx  |2 
 connectivity/source/drivers/dbase/DIndex.cxx|2 
 connectivity/source/drivers/dbase/DTable.cxx|4 
 connectivity/source/drivers/evoab2/NCatalog.cxx |2 
 connectivity/source/drivers/evoab2/NColumns.hxx |2 
 connectivity/source/drivers/evoab2/NTable.cxx   |2 
 connectivity/source/drivers/evoab2/NTables.hxx  |2 
 connectivity/source/drivers/file/FCatalog.cxx   |2 
 connectivity/source/drivers/file/FTable.cxx |2 
 connectivity/source/drivers/firebird/Catalog.cxx|4 
 connectivity/source/drivers/firebird/Columns.cxx|2 
 connectivity/source/drivers/firebird/Columns.hxx|2 
 connectivity/source/drivers/firebird/Keys.cxx   |2 
 connectivity/source/drivers/firebird/Keys.hxx   |2 
 connectivity/source/drivers/firebird/Table.cxx  |6 
 connectivity/source/drivers/firebird/Table.hxx  |6 
 connectivity/source/drivers/firebird/Tables.hxx |2 
 connectivity/source/drivers/firebird/Users.cxx  |2 
 connectivity/source/drivers/firebird/Users.hxx  |2 
 connectivity/source/drivers/flat/ECatalog.cxx   |2 
 connectivity/source/drivers/flat/ETable.cxx |2 
 connectivity/source/drivers/hsqldb/HCatalog.cxx |8 
 connectivity/source/drivers/hsqldb/HColumns.cxx |2 
 connectivity/source/drivers/hsqldb/HTable.cxx   |6 
 connectivity/source/drivers/hsqldb/HUsers.cxx   |2 
 connectivity/source/drivers/hsqldb/HViews.cxx   |2 
 connectivity/source/drivers/macab/MacabCatalog.cxx  |2 
 connectivity/source/drivers/macab/MacabColumns.cxx  |2 
 connectivity/source/drivers/macab/MacabColumns.hxx  |2 
 connectivity/source/drivers/macab/MacabTable.cxx|2 
 connectivity/source/drivers/macab/MacabTables.hxx   |2 
 connectivity/source/drivers/mork/MCatalog.cxx   |2 
 connectivity/source/drivers/mork/MColumns.hxx   |2 
 connectivity/source/drivers/mork/MTable.cxx |6 
 connectivity/source/drivers/mork/MTable.hxx |6 
 connectivity/source/drivers/mork/MTables.hxx|2 
 connectivity/source/drivers/mysql/YCatalog.cxx  |8 
 connectivity/source/drivers/mysql/YColumns.cxx  |2 
 connectivity/source/drivers/mysql/YTable.cxx|8 
 connectivity/source/drivers/mysql/YUsers.cxx|2 
 connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx |6 
 connectivity/source/drivers/writer/WCatalog.cxx |2 
 connectivity/source/drivers/writer/WTable.cxx   |1 
 connectivity/source/inc/FDatabaseMetaDataResultSetMetaData.hxx  |1 
 connectivity/source/inc/ado/AColumns.hxx|2 
 connectivity/source/inc/ado/ADatabaseMetaDataResultSet.hxx  |5 
 connectivity/source/inc/ado/AGroups.hxx |2 
 connectivity/source/inc/ado/AIndexes.hxx|2 
 connectivity/source/inc/ado/AKeys.hxx   |2 
 connectivity/source/inc/ado/ATables.hxx |2 
 connectivity/source/inc/ado/AUsers.hxx  |2 
 connectivity/source/inc/ado/AViews.hxx  |2 
 connectivity/source/inc/ado/Aolewrap.hxx|3 
 connectivity/source/inc/calc/CTables.hxx|2

[Libreoffice-commits] core.git: 2 commits - include/sot include/vcl

2017-12-19 Thread Noel Grandin

 include/sot/formats.hxx |4 ++--
 include/sot/stg.hxx |2 +-
 include/sot/storage.hxx |2 +-
 include/vcl/outdev.hxx  |2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e6ea3bbef30a0b6e04236ecb52cba4ac39f6332f
Author: Noel Grandin 
Date:   Tue Dec 19 08:50:52 2017 +0200

sal_uLong->sal_uInt32 in DrawModeFlags

Change-Id: I99f703c487b87926bfd9cab5c8ace4c7509a72bf
Reviewed-on: https://gerrit.libreoffice.org/46807
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 51d296fa8da0..a22f8a12a811 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -206,7 +206,7 @@ namespace o3tl
 }
 
 // DrawModes
-enum class DrawModeFlags : sal_uLong
+enum class DrawModeFlags : sal_uInt32
 {
 Default= 0x,
 BlackLine  = 0x0001,
commit 214804d132ad134a65cdbc60fc136230fedcd325
Author: Noel Grandin 
Date:   Mon Dec 18 15:39:29 2017 +0200

sal_uLong->sal_uInt32 in SotClipboardFormatId

Change-Id: Ibe48a6ae3cdb91a5eed2cf6d572b19df87a51d84
Reviewed-on: https://gerrit.libreoffice.org/46806
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/sot/formats.hxx b/include/sot/formats.hxx
index 4e36686203a8..a1f5f8858335 100644
--- a/include/sot/formats.hxx
+++ b/include/sot/formats.hxx
@@ -24,7 +24,7 @@
 
 // - predefined formats -
 // Do NOT change the order of these values as the implementation depends on 
them!
-enum class SotClipboardFormatId : sal_uLong
+enum class SotClipboardFormatId : sal_uInt32
 {
 // standard formats for that Copy/Paste methods exist
 STRING = 1,
@@ -181,7 +181,7 @@ enum class SotClipboardFormatId : sal_uLong
 /** Make it easier to iterate over format IDs */
 inline SotClipboardFormatId& operator++(SotClipboardFormatId& v)
 {
-v = static_cast(static_cast(v) + 1);
+v = static_cast(static_cast(v) + 1);
 return v;
 }
 
diff --git a/include/sot/stg.hxx b/include/sot/stg.hxx
index 4f2b19c0255e..b932f9139b09 100644
--- a/include/sot/stg.hxx
+++ b/include/sot/stg.hxx
@@ -79,7 +79,7 @@ public:
 virtual boolEquals( const BaseStorageStream& rStream ) const = 0;
 };
 
-enum class SotClipboardFormatId : sal_uLong;
+enum class SotClipboardFormatId : sal_uInt32;
 
 class SAL_DLLPUBLIC_RTTI BaseStorage : public StorageBase
 {
diff --git a/include/sot/storage.hxx b/include/sot/storage.hxx
index 4ca0bc9d9387..b8cbe947557a 100644
--- a/include/sot/storage.hxx
+++ b/include/sot/storage.hxx
@@ -29,7 +29,7 @@
 #include 
 #include 
 
-enum class SotClipboardFormatId : sal_uLong;
+enum class SotClipboardFormatId : sal_uInt32;
 
 class SotStorage;
 class BaseStorageStream;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114457] MacOS: OfaTreeOptionsDialog::LoadNodes(Module*, rtl:: OUString const&) is leaking a bit

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114457

--- Comment #7 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf4228fa0aaea82858f05848fe5a6a96b34405a0

Revert "Related tdf#114457: fix leak in treeopt (cui)"

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

2017-12-19 Thread Julien Nabet

 cui/source/inc/treeopt.hxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit cf4228fa0aaea82858f05848fe5a6a96b34405a0
Author: Julien Nabet 
Date:   Tue Dec 19 20:53:29 2017 +0100

Revert "Related tdf#114457: fix leak in treeopt (cui)"

According to Telesto's test, it's worse than before, so let's revert

This reverts commit 41981d4cb48e66b6fdb32cdc3ae65632af9593dc.

Change-Id: Iba2a364160816fe981de91e51487a78bd6ebe15c
Reviewed-on: https://gerrit.libreoffice.org/46817
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index 6bb74abb86eb..274076d9d99f 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -101,12 +101,6 @@ struct OptionsNode
 for ( size_t i = 0; i < m_aLeaves.size(); ++i )
 delete m_aLeaves[i];
 m_aLeaves.clear();
-for (auto & oneGroupLeaves : m_aGroupedLeaves)
-{
-for (auto const& leaf : oneGroupLeaves)
-delete leaf;
-oneGroupLeaves.clear();
-}
 m_aGroupedLeaves.clear();
 }
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114457] MacOS: OfaTreeOptionsDialog::LoadNodes(Module*, rtl:: OUString const&) is leaking a bit

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114457

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114455] SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114455

--- Comment #7 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a38ae7bb491df71bfc1678811d89c3064fd8408

Revert "Related tdf#114455: fix mem leak on olmenu (sw)"

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114455] SfxVoidItem::Clone(SfxItemPool*) leaks memory with multiple invocations

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114455

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2017-12-19 Thread Julien Nabet

 sw/source/uibase/lingu/olmenu.cxx |7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 5a38ae7bb491df71bfc1678811d89c3064fd8408
Author: Julien Nabet 
Date:   Tue Dec 19 20:48:43 2017 +0100

Revert "Related tdf#114455: fix mem leak on olmenu (sw)"

After having tested it on MacOs, it seems it doesn't help

This reverts commit 2f9360b58a358fefb86f474464e53f1ea5ffb52b.

Change-Id: I6de52c9ae5a43a659d28d72bfc742ed4b5cec5b0
Reviewed-on: https://gerrit.libreoffice.org/46816
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sw/source/uibase/lingu/olmenu.cxx 
b/sw/source/uibase/lingu/olmenu.cxx
index f13b5f1e8247..879a2c93f5c2 100644
--- a/sw/source/uibase/lingu/olmenu.cxx
+++ b/sw/source/uibase/lingu/olmenu.cxx
@@ -600,7 +600,6 @@ void SwSpellPopup::checkRedline()
 {
 aSet.Put(SfxVoidItem(nWhich));
 }
-
 m_pSh->GetView().GetState(aSet);
 
 // Enable/disable items based on if the which id of the void items are
@@ -616,11 +615,7 @@ void SwSpellPopup::checkRedline()
 nId = m_nRedlineNextId;
 else if (nWhich == FN_REDLINE_PREV_CHANGE)
 nId = m_nRedlinePrevId;
-auto valueWhich = aSet.Get(nWhich).Which();
-m_xPopupMenu->EnableItem(nId, valueWhich);
-// Remove the value when we disable item to avoid mem leak
-if (!valueWhich)
-aSet.ClearItem(nWhich);
+m_xPopupMenu->EnableItem(nId, aSet.Get(nWhich).Which());
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94169] Open split button recent document list should show icons next to entries

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94169

--- Comment #10 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) from comment #9)
> (In reply to Heiko Tietze from comment #8)
> > While I think it would be good to have an indicator...
> Both Maxim and Stuart agreed with the enhancement...

So we all agree :-).

Actually I was reading this as an enhancement request for the open recent
document toolbar button / menu (.uno:RecentFileList) rather than the start
center. Would be my preference at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114577] since 12-14-17 Win 10 update, cannot print files from Libre Office 5.4

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114577

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
What happens exactly when you try to print?
Does it work if you export to PDF, and print the PDF?
Which LO version are you using exactly? 5.4.4 will be out in a few days, it
should be worth a try (currently it's available as a prerelease version).
Which Windows 10 update broke printing actually?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: minutes of ESC call ...

2017-12-19 Thread Tommy


Michael Meeks wrote:

.
+ 5.4.4 RC2 status
.

no bugfix list has been published yet about RC1 and RC2 in the wiki

https://wiki.documentfoundation.org/ReleasePlan/5.4#5.4.4_release

---
Questa email è stata esaminata alla ricerca di virus da AVG.
http://www.avg.com


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114403] deleting URL inconsistent (cell vs text input field)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114403

--- Comment #2 from Pierre Fortin  ---
Created attachment 138542
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138542=edit
Spreadsheet to illustrate the problem

Sorry; yes, Backspace.

Here's a spreadsheet reduced to several cells copy/pasted from a browser page.

Select a cell (only a portion will be visible in the Input Line); then click at
the end of the Input Line, and watch what happens each time you hit
Backspace...

Examples (each BS deletes 1 character; but not where expected):
 cell A2: it deleted "cor" of "Host Record" so that it reads "Host Red"
 cell A4: same as A2
 cell A8: it deleted "ut" of "Email Routing:..." => "Email Roing"
 cell A8: same as A2
 cell A10: it deleted "ce" of "Service" => "Servi"
 cell A12: same as A2

Cells A8 and A10 don't follow the same deletion pattern as the others. Weird!

This is with:
Version: 5.3.4.2
Build ID: 5.3.4.2-3.mga6
CPU Threads: 8; OS Version: Linux 4.9; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114579] EDITING:scrolling up in spreadsheet is slow/inconsistent; other scrolling ok

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114579

--- Comment #1 from lenorehor...@sbcglobal.net ---
Created attachment 138541
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138541=edit
spreadsheet showing bad scrolling

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114579] New: EDITING:scrolling up in spreadsheet is slow/inconsistent ; other scrolling ok

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114579

Bug ID: 114579
   Summary: EDITING:scrolling up in spreadsheet is
slow/inconsistent; other scrolling ok
   Product: LibreOffice
   Version: 5.3.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lenorehor...@sbcglobal.net

Description:
When I open a large spreadsheet with much conditional formatting and try to
scroll up using two fingers on the trackpad, often nothing happens.  Sometimes
a few lines scroll.  It takes several strokes to accomplish anything and I
cannot predict how far the sheet will scroll for any given motion.  Scrolling
down on the other hand is consistent, always responds immediately and I can
predictably scroll the amount I intend to.  Left-right scrolling also behaves
smoothly and predictably.

Steps to Reproduce:
1.Open LibreOffice on MacBook Air running 10.12.16
2.Open attached file.
3.Stroke down on trackpad with two fingers (this works fine).
4.Stroke up on trackpad with two fingers (scrolling probably won't happen, but
eventually will a little)

Actual Results:  
scrolling happens sometimes, for part of the motion; up and down behave very
differently

Expected Results:
scrolling happens smoothly every time from start of motion to end of motion; up
and down should behave symmetrically


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 5.3.7.2
Build ID: 6b8ed514a9f8b44d37a1b96673cbbdd077e24059
CPU Threads: 4; OS Version: Mac OS X 10.12.6; UI Render: default; Layout
Engine: new; 
Locale: en-US (en_US.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0)
Gecko/20100101 Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: canvas/source

2017-12-19 Thread Mike Kaganski

 canvas/source/cairo/cairo_canvashelper.cxx |2 +-
 canvas/source/tools/canvastools.cxx|2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0545c1ad981a3dcb8264da3215bc069b03f4d988
Author: Mike Kaganski 
Date:   Fri Dec 15 14:42:06 2017 +0200

Properly skip ignored value

Change-Id: I1ac75cde58a52f87ef6825baa2e689dbc449c8f0
Reviewed-on: https://gerrit.libreoffice.org/46547
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/canvas/source/cairo/cairo_canvashelper.cxx 
b/canvas/source/cairo/cairo_canvashelper.cxx
index 06c07665a831..74b612928ffd 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -2097,7 +2097,7 @@ namespace cairocanvas
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
-*pOut++ = 1.0; // the value does not matter
+*pOut++ = 1.0; pIn++; // the value does not matter
 }
 return aRes;
 }
diff --git a/canvas/source/tools/canvastools.cxx 
b/canvas/source/tools/canvastools.cxx
index a80f23b3f2f4..d1155243275c 100644
--- a/canvas/source/tools/canvastools.cxx
+++ b/canvas/source/tools/canvastools.cxx
@@ -678,7 +678,7 @@ namespace canvas
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
 *pOut++ = vcl::unotools::toDoubleColor(*pIn++);
-*pOut++ = 1.0;
+*pOut++ = 1.0; pIn++;
 }
 return aRes;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 104631] UI: Gridlines in Writer visibile through an image ( instead hidden behind)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104631

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 104631] UI: Gridlines in Writer visibile through an image ( instead hidden behind)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104631

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93348] Base crashes when entering login information for jdbc connection to MariaDB database (Windows 64bit)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93348

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47179] performance depends on /etc/hosts (svt::DocumentLockFile:: CreateOwnLockFile calls gethostbyname_r)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47179

--- Comment #14 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98064] Copying rich text HTTP Link does not Ampersand character in URL properly

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98064

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51264] Validation of signed documents against CRL takes too long when in Linux behind a proxy

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51264

--- Comment #12 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104760] High CPU load scrolling an empty page horizontally

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=104760

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66819] Setting additional spacing between characters does not prevent automatic ligature substitution.

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=66819

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

2017-12-19 Thread tagezi

 sc/source/ui/condformat/condformatdlg.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit fe31edb29e5e77bb60e3aa73ec6a0380314acc61
Author: tagezi 
Date:   Tue Dec 19 13:32:26 2017 +0200

tdf#114545 Enabling/Disabling Ok button depending on correct format

Change-Id: Iab3c4363dda0260d16c7167946044c39c21b863a
Reviewed-on: https://gerrit.libreoffice.org/46790
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins 
(cherry picked from commit 7504af39686171ffb16e70f798d9ecf4ea98f1d3)
Reviewed-on: https://gerrit.libreoffice.org/46823
Reviewed-by: Christian Lohmaier 

diff --git a/sc/source/ui/condformat/condformatdlg.cxx 
b/sc/source/ui/condformat/condformatdlg.cxx
index b7b0c40a73d8..0409efd5dda6 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -772,9 +772,15 @@ IMPL_LINK( ScCondFormatDlg, EdRangeModifyHdl, Edit&, 
rEdit, void )
 ScRefFlags nFlags = aRange.Parse(aRangeStr, mpViewData->GetDocument(),
 mpViewData->GetDocument()->GetAddressConvention());
 if(nFlags & ScRefFlags::VALID)
+{
 
rEdit.SetControlBackground(GetSettings().GetStyleSettings().GetWindowColor());
+mpBtnOk->Enable(true);
+}
 else
+{
 rEdit.SetControlBackground(COL_LIGHTRED);
+mpBtnOk->Enable(false);
+}
 
 updateTitle();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114526] Saving to PDF creates what looks like a thumbnail

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114526

--- Comment #6 from Alexander Clark  ---
We see that this is fixed with the latest commits, so we're good.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114578] New: Incomplete Mail Merge Features

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114578

Bug ID: 114578
   Summary: Incomplete Mail Merge Features
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bigninty...@gmail.com

Description:
In Mail Merge, users are given the option to create labels. These labels are
all the same. It would be a boon to be able to have the labels be different in
the case of printing address labels for Christmas card lists or what have you.

It would be a big plus to make it simpler in general, and maybe the notebookbar
will fix that issue.

Steps to Reproduce:
1. Tools > Mail Merge Wizard
2. Select Address List
3. [Finish]

Actual Results:  
All present labels were filled with the same name

Expected Results:
All present labels be filled with different names per the given list


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 5.4.3.2 (x64)


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114569] Filesave issue

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114569

--- Comment #2 from lonelydad58  ---
This is all done with version 5.4.3.2 under Windows 10 version 1709 (16299.125)

Directory structure:

Book Name

First Pass

Second Pass

Steps:

Opened LibreOffice
Selected create new Writer document
Typed text into document
Saved it in directory First Pass
Exited LibreOffice

Started LibreOffice again
Selected Open File
Selected previously created file in 'First Pass'
Made changes
Selected Save As
Saved modified file in 'Second Pass'
Clicked outermost 'X' box to completely leave LibreOffice
Received error message

If I duplicate all of the second steps except that after I do the Save As into
directory Second Pass I select 'Exit LibreOffice' from the File menu, then it
closes without the error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: About the kikongo speller (kituba)

2017-12-19 Thread Cyrille

Thank you Eike, I would look at the side of debian.

Le 19/12/2017 à 12:37, Eike Rathke a écrit :
> Hi Cyrille,
>
> On Tuesday, 2017-12-12 14:43:05 +0100, Cyrille wrote:
>
>> I come back to you because I think the dictionary is now mature. I would
>> like to know if it is possible to propose it to the github hunspell repo
>>  or
>> better as a new package for Debian/Ubuntu.
> It looks like that github page lists dictionaries that are available as
> Debian and Ubuntu packages, so probably trying to add it as a Debian
> package would be best.
>
>> Currently I did already a
>> plugin for firefox and an extension for Libreoffice (even if it is not
>> necessary on Ubuntu if you have the hunspell installed). I did it first
>> for Windows. But I would like to know if it is possible to install it
>> for all applications on Windows too (But maybe I'm not in the right
>> place to ask my question?).
> I don't know details, but I think Windows doesn't have a concept of
> central dictionaries.
>
> Maybe best ask László Németh who might know, also other details, see
> https://hunspell.github.io/
>
>   Eike
>

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114577] New: since 12-14-17 Win 10 update, cannot print files from Libre Office 5.4

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114577

Bug ID: 114577
   Summary: since 12-14-17 Win 10 update, cannot print files from
Libre Office 5.4
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Printing and PDF export
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jlshul...@nc.rr.com

Please advise what I need to do to get files to print again. Have not been able
to print them since Win 10 updated December 14, 2017.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114522] Writer hyperlink to the bookmark in filename with # (sharp) character.

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114522

--- Comment #7 from Harry  ---
Created attachment 138540
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138540=edit
hyperlink dialogbox

Regina Henschel,

Thank you for your kind advise.

Please see the attached screen shot I made. 

I found out that when I click the recent files icon (the read arrow is pointing
in the attached image) and choose the target file the '#' character remains as
it is so that Libreoffice confuses '#' in filename with '#' as a hyperlink
separator, but if I click the browser icon (the green arrow is pointing) and
choose the target file '#' is converted to '%23' and everything goes OK. 

This is a very strange thing because I hardly click the file browser icon in
this job and I got the problem as soon as I upgraded to Ubuntu 16.04 from 14.
(though don't know the change of Libreoffice versions)

PS. It turned out there's nothing to do with this problem between 'libreoffice
dialogs' and 'ubunto file browser dialog'.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - chart2/qa oox/source

2017-12-19 Thread Aron Budea

 chart2/qa/extras/chart2import.cxx |   30 ++
 chart2/qa/extras/data/pptx/tdf105517.pptx |binary
 oox/source/drawingml/clrscheme.cxx|6 +-
 3 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit 6bf0a1c61ef7b0df2c5c116d6a0f05ec6565d262
Author: Aron Budea 
Date:   Fri Nov 3 02:08:00 2017 +0100

tdf#105517: overwrite existing scheme colors in vector

Theme overrides stopped working once ClrScheme::maClrScheme was
changed to vector, and colors were always appended to it.

Regression from f3121049828596b369e3ea844355d61666e49795.

Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963
Reviewed-on: https://gerrit.libreoffice.org/44242
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 
(cherry picked from commit 021081823aeebcfa395662d0c04535a243977c2e)
Reviewed-on: https://gerrit.libreoffice.org/46828

diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index 9b95105640f8..a49e80e1b867 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -62,6 +62,7 @@ public:
 void testFdo54361();
 void testFdo54361_1();
 void testTdf86624(); // manually placed legends
+void testTdf105517();
 void testTdf106217();
 void testAutoBackgroundXLSX();
 void testChartAreaStyleBackgroundXLSX();
@@ -129,6 +130,7 @@ public:
 CPPUNIT_TEST(testFdo54361);
 CPPUNIT_TEST(testFdo54361_1);
 CPPUNIT_TEST(testTdf86624);
+CPPUNIT_TEST(testTdf105517);
 CPPUNIT_TEST(testTdf106217);
 CPPUNIT_TEST(testAutoBackgroundXLSX);
 CPPUNIT_TEST(testChartAreaStyleBackgroundXLSX);
@@ -747,6 +749,34 @@ void Chart2ImportTest::testTdf86624()
 CPPUNIT_ASSERT(aPos.Y > 4000); // real value for ms is above 7000
 }
 
+void Chart2ImportTest::testTdf105517()
+{
+load("/chart2/qa/extras/data/pptx/", "tdf105517.pptx");
+Reference xChartDoc(getChartDocFromDrawImpress(0, 
0), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartDoc.is());
+
+Reference 
xCoordContainer(xChartDoc->getFirstDiagram(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xCoordContainer.is());
+Reference 
xChartTypeContainer(xCoordContainer->getCoordinateSystems()[0], uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartTypeContainer.is());
+Reference 
xDSContainer(xChartTypeContainer->getChartTypes()[0], uno::UNO_QUERY);
+CPPUNIT_ASSERT(xDSContainer.is());
+Reference xPropSet1(xDSContainer->getDataSeries()[0], 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet1.is());
+
+long lineColor;
+xPropSet1->getPropertyValue("Color") >>= lineColor;
+// incorrect line color was 0x4a7ebb due to not handling themeOverride
+CPPUNIT_ASSERT_EQUAL(lineColor, long(0xeaa700));
+
+Reference xPropSet2(xDSContainer->getDataSeries()[1], 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet2.is());
+
+xPropSet2->getPropertyValue("Color") >>= lineColor;
+// incorrect line color was 0x98b855
+CPPUNIT_ASSERT_EQUAL(lineColor, long(0x1e69a8));
+}
+
 void Chart2ImportTest::testTdf106217()
 {
 load("/chart2/qa/extras/data/pptx/", "tdf106217.pptx");
diff --git a/chart2/qa/extras/data/pptx/tdf105517.pptx 
b/chart2/qa/extras/data/pptx/tdf105517.pptx
new file mode 100644
index ..ff9d747f0349
Binary files /dev/null and b/chart2/qa/extras/data/pptx/tdf105517.pptx differ
diff --git a/oox/source/drawingml/clrscheme.cxx 
b/oox/source/drawingml/clrscheme.cxx
index 7a99f3685a07..0c6517abfbc3 100644
--- a/oox/source/drawingml/clrscheme.cxx
+++ b/oox/source/drawingml/clrscheme.cxx
@@ -82,7 +82,11 @@ bool ClrScheme::getColor( sal_Int32 nSchemeClrToken, 
sal_Int32& rColor ) const
 
 void ClrScheme::setColor( sal_Int32 nSchemeClrToken, sal_Int32 nColor )
 {
-maClrScheme.emplace_back(nSchemeClrToken, nColor);
+const auto aIter = std::find_if(maClrScheme.begin(), maClrScheme.end(), 
find_by_token(nSchemeClrToken) );
+if ( aIter != maClrScheme.end() )
+aIter->second = nColor;
+else
+maClrScheme.emplace_back(nSchemeClrToken, nColor);
 }
 
 bool ClrScheme::getColorByIndex(size_t nIndex, sal_Int32& rColor) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114431] FILEOPEN Cannot view table data in any ".odb" files following Windows update

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114431

--- Comment #7 from Bob Evans  ---
(In reply to Julien Nabet from comment #3)
> On menu tools/options, go to LibreOffice Base, then databases.
> 
> In addition of by default "Bibliography", you should have another entry
> "addresses_new".
> If it's not the case, you must add this source with the exact name and
> indicate the location of the file.
> 
> Now I don't know why you should lose your registered databases when updating.
> Is it expected or not, I'd say no but not sure.

Julien
In tools/options/LibreOffice Base/databases I already have an entry for
"addresses_new" and its location is registered correctly.
Bob

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114431] FILEOPEN Cannot view table data in any ".odb" files following Windows update

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114431

--- Comment #6 from Bob Evans  ---
(In reply to Alex Thurgood from comment #2)
> Your report sounds like a DUPLICATE of bug 114361

Alex

I agree that my problem is very similar to bug 114361, with the exception that
in my case the problem appeared without me changing the version of LibreOffice
(or JRE for that matter). I have followed very similar paths to Chris Grove
with similar results.

Bob Evans

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114431] FILEOPEN Cannot view table data in any ".odb" files following Windows update

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114431

Bob Evans  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #5 from Bob Evans  ---
(In reply to Alex Thurgood from comment #1)
> @Bob : Unfortunately, we don't have enough information to go on.
> 
> What bit version of LibreOffice were you using before you upgraded to 5422
> where you first encountered the problem ? If the previous version of
> LibreOffice that you were using, and which presumably worked, was 32bit,
> then you would have had a 32bit JRE/JDK environment. As you mention that the
> 5422 was 64bit, it could be that although you have a JDK/JRE installed, they
> might not be recogized by LO5422 (this seems likely given the error message).
> 
> Also note that Oracle 64bit JDK 9.0.1 doesn't seem to come with a JRE and
> that you might have to download and install this separately. If you upgraded
> to JRE9.0.1 from JRE8.0.151 via the automatic update mechanism, then it
> could be that this isn't recognized by LO.
> 
> I don't really know what to suggest other than that.

Alex

In response to your question

What bit version of LibreOffice were you using before you upgraded to 5422
where you first encountered the problem ?

I had been using LibreOffice 5.4.2.2 Win X64  quite successfully since I
installed it on 23/10/2017.
Then on 11/12/2017 I installed the Windows 10 version 1709 update, immediately
after which I encountered the problem loading any of my LibreOffice .odb files
(still using version 5.4.2.2 Win X64). I then upgraded to LO v5.4.3 Win X64,
but with the same result.

BoB

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114576] New: Manually editing formulas should highlight any cells used

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114576

Bug ID: 114576
   Summary: Manually editing formulas should highlight any cells
used
   Product: LibreOffice
   Version: 5.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: docuemntfoundat...@multiwebinc.com

Description:
This bug appeared upon upgrading from Ubuntu 17.04 to 17.10. In previous
versions, when any cells that contained a formula that referenced other cells
(or ranges) were selected and then you clicked on the formula editor, the
referenced cells/ranges were highlighted in various colors. The highlights were
also draggable and re-sizable. This is not the case anymore. No cells or ranges
are highlighted.

Note, this appears to be fixed in the latest beta (6.0.0.0.beta2), but not the
latest stable (5.4.3.2). Perhaps it could be backported.

Steps to Reproduce:
See description

Actual Results:  
See description

Expected Results:
See description


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/62.0.3202.94 Safari/537.36 OPR/49.0.2725.56

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114575] Autocorrect replacement mixes up Hebrew opening and closing quotes

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114575

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||112812


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112812
[Bug 112812] [META] Hebrew language-specific RTL issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112812] [META] Hebrew language-specific RTL issues

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112812

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||114575


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114575
[Bug 114575] Autocorrect replacement mixes up Hebrew opening and closing quotes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114575] New: Autocorrect replacement mixes up Hebrew opening and closing quotes

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114575

Bug ID: 114575
   Summary: Autocorrect replacement mixes up Hebrew opening and
closing quotes
   Product: LibreOffice
   Version: 6.0.0.0.beta2
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyal...@technion.ac.il

Created attachment 138539
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138539=edit
Without AC, with incorrect AC, with "corrected" AC

When you apply autocorrect replacement of simple quotes with "smart" quotes on
Hebrew text (within two simple ASCII double-quote characters), what you get is
that the first double-quote (i.e. the right double-quote, as Hebrew is written
in RTL) gets replaced with a Hebrew closing-quote character, and the second
double-quote (i.e. the left one) gets replaced with a Hebrew
upper-opening-quote character. That's the wrong order:

Instead of this (added RLMs to the beginning and end of the line to get the
direction right):
‏
‏הבית של פיסטוק מלא “הפתעות”.‏

we should be getting this:

‏הבית של פיסטוק מלא ”הפתעות“.‏

if you can't see the difference, open the example.

Also, for good measure, if the paragraph's style was LTR, and you only manually
set it to LTR, the autocorrect resets the direction to LTR. This is a different
issue, but I'm mentioning it so that when you try to reproduce, you'll want to
double-check the direction after the autocorrect has been applied. Finally, if
autocorrect does not, well, autocorrect (which happens to me sometime),
manually Apply it using the menus.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/qa oox/source

2017-12-19 Thread Aron Budea

 chart2/qa/extras/chart2import.cxx |   30 ++
 chart2/qa/extras/data/pptx/tdf105517.pptx |binary
 oox/source/drawingml/clrscheme.cxx|6 +-
 3 files changed, 35 insertions(+), 1 deletion(-)

New commits:
commit 021081823aeebcfa395662d0c04535a243977c2e
Author: Aron Budea 
Date:   Fri Nov 3 02:08:00 2017 +0100

tdf#105517: overwrite existing scheme colors in vector

Theme overrides stopped working once ClrScheme::maClrScheme was
changed to vector, and colors were always appended to it.

Regression from f3121049828596b369e3ea844355d61666e49795.

Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963
Reviewed-on: https://gerrit.libreoffice.org/44242
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index 9b95105640f8..a49e80e1b867 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -62,6 +62,7 @@ public:
 void testFdo54361();
 void testFdo54361_1();
 void testTdf86624(); // manually placed legends
+void testTdf105517();
 void testTdf106217();
 void testAutoBackgroundXLSX();
 void testChartAreaStyleBackgroundXLSX();
@@ -129,6 +130,7 @@ public:
 CPPUNIT_TEST(testFdo54361);
 CPPUNIT_TEST(testFdo54361_1);
 CPPUNIT_TEST(testTdf86624);
+CPPUNIT_TEST(testTdf105517);
 CPPUNIT_TEST(testTdf106217);
 CPPUNIT_TEST(testAutoBackgroundXLSX);
 CPPUNIT_TEST(testChartAreaStyleBackgroundXLSX);
@@ -747,6 +749,34 @@ void Chart2ImportTest::testTdf86624()
 CPPUNIT_ASSERT(aPos.Y > 4000); // real value for ms is above 7000
 }
 
+void Chart2ImportTest::testTdf105517()
+{
+load("/chart2/qa/extras/data/pptx/", "tdf105517.pptx");
+Reference xChartDoc(getChartDocFromDrawImpress(0, 
0), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartDoc.is());
+
+Reference 
xCoordContainer(xChartDoc->getFirstDiagram(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xCoordContainer.is());
+Reference 
xChartTypeContainer(xCoordContainer->getCoordinateSystems()[0], uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartTypeContainer.is());
+Reference 
xDSContainer(xChartTypeContainer->getChartTypes()[0], uno::UNO_QUERY);
+CPPUNIT_ASSERT(xDSContainer.is());
+Reference xPropSet1(xDSContainer->getDataSeries()[0], 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet1.is());
+
+long lineColor;
+xPropSet1->getPropertyValue("Color") >>= lineColor;
+// incorrect line color was 0x4a7ebb due to not handling themeOverride
+CPPUNIT_ASSERT_EQUAL(lineColor, long(0xeaa700));
+
+Reference xPropSet2(xDSContainer->getDataSeries()[1], 
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xPropSet2.is());
+
+xPropSet2->getPropertyValue("Color") >>= lineColor;
+// incorrect line color was 0x98b855
+CPPUNIT_ASSERT_EQUAL(lineColor, long(0x1e69a8));
+}
+
 void Chart2ImportTest::testTdf106217()
 {
 load("/chart2/qa/extras/data/pptx/", "tdf106217.pptx");
diff --git a/chart2/qa/extras/data/pptx/tdf105517.pptx 
b/chart2/qa/extras/data/pptx/tdf105517.pptx
new file mode 100644
index ..ff9d747f0349
Binary files /dev/null and b/chart2/qa/extras/data/pptx/tdf105517.pptx differ
diff --git a/oox/source/drawingml/clrscheme.cxx 
b/oox/source/drawingml/clrscheme.cxx
index 7a99f3685a07..0c6517abfbc3 100644
--- a/oox/source/drawingml/clrscheme.cxx
+++ b/oox/source/drawingml/clrscheme.cxx
@@ -82,7 +82,11 @@ bool ClrScheme::getColor( sal_Int32 nSchemeClrToken, 
sal_Int32& rColor ) const
 
 void ClrScheme::setColor( sal_Int32 nSchemeClrToken, sal_Int32 nColor )
 {
-maClrScheme.emplace_back(nSchemeClrToken, nColor);
+const auto aIter = std::find_if(maClrScheme.begin(), maClrScheme.end(), 
find_by_token(nSchemeClrToken) );
+if ( aIter != maClrScheme.end() )
+aIter->second = nColor;
+else
+maClrScheme.emplace_back(nSchemeClrToken, nColor);
 }
 
 bool ClrScheme::getColorByIndex(size_t nIndex, sal_Int32& rColor) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

2017-12-19 Thread Jim Raykowski

 sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit e68184f712b151c03c2282bacd662ae103f3d3f2
Author: Jim Raykowski 
Date:   Sun Dec 17 09:42:54 2017 -0900

Uncheck Engineering notation checkbox on Scientific selection

In Calc, the Engineering notation checkbox in the Sidebar Properties
deck Number Format panel can show checked when the cell number format
does not contain engineering notation.

Change-Id: Ia26fc430aecd7af2e0f614bf9314d99f8408e690
Reviewed-on: https://gerrit.libreoffice.org/46650
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit 9e7caee0173c5ec2d8b5cfa6aedfd1c9674d442b)
Reviewed-on: https://gerrit.libreoffice.org/46826

diff --git a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx 
b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
index 54c3975c9b08..a0c9eb940f8f 100644
--- a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
+++ b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
@@ -214,6 +214,7 @@ void NumberFormatPropertyPanel::NotifyItemUpdate(
 mpBtnThousand->Check(false);
 mpBtnEngineering->Show(bIsScientific);
 mpBtnEngineering->Enable(bIsScientific);
+mpBtnEngineering->Check(false);
 mpBtnNegRed->Enable();
 mpFtDenominator->Show(bIsFraction);
 mpEdDenominator->Show(bIsFraction);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sw/qa writerfilter/source

2017-12-19 Thread Miklos Vajna

 sw/qa/extras/ooxmlexport/data/tdf113547.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx   |   11 +++
 writerfilter/source/dmapper/NumberingManager.cxx |   10 --
 writerfilter/source/dmapper/NumberingManager.hxx |3 +++
 4 files changed, 22 insertions(+), 2 deletions(-)

New commits:
commit feb043331207ae66e1ac6cce613ff052f96d4f02
Author: Miklos Vajna 
Date:   Mon Dec 18 22:29:04 2017 +0100

tdf#113547 DOCX import: fix handling of stub numbering overrides

Regression from commit c72a1a74b5b1064fc9cdf9994b11fce26d866e26
(Related: tdf#112211 DOCX import: fix handling of missing first ind in
, 2017-09-19), now that a numbering level can have default
properties, we need to differentiate between the case when the level has
real properties or it has only default properties.

Merging of properties is not necessary when the abstract numbering has
properties, but the "override" has default properties only.

(cherry picked from commit a0bf35f7c0eedbe04783285a4a7071e68baeb7fe)

Change-Id: Idbcbd0f66932514612e11fe82377f2b68ac9e403
Reviewed-on: https://gerrit.libreoffice.org/46777
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf113547.docx 
b/sw/qa/extras/ooxmlexport/data/tdf113547.docx
new file mode 100644
index ..7b35ad72ba44
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf113547.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index 6aca7e81b2cd..e2af3250cb07 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -109,6 +109,17 @@ DECLARE_OOXMLEXPORT_TEST(testTdf113183, "tdf113183.docx")
 "HoriOrientPosition"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf113547, "tdf113547.docx")
+{
+uno::Reference xPropertySet(
+getStyles("NumberingStyles")->getByName("WWNum1"), uno::UNO_QUERY);
+uno::Reference xLevels(
+xPropertySet->getPropertyValue("NumberingRules"), uno::UNO_QUERY);
+comphelper::SequenceAsHashMap aProps(xLevels->getByIndex(0)); // 1st level
+// This was 0, first-line left margin of the numbering was lost.
+CPPUNIT_ASSERT_EQUAL(static_cast(-635), 
aProps["FirstLineIndent"].get());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/NumberingManager.cxx 
b/writerfilter/source/dmapper/NumberingManager.cxx
index 8754b489a9ec..809717e62659 100644
--- a/writerfilter/source/dmapper/NumberingManager.cxx
+++ b/writerfilter/source/dmapper/NumberingManager.cxx
@@ -119,6 +119,12 @@ void ListLevel::SetValue( Id nId, sal_Int32 nValue )
 default:
 OSL_FAIL( "this line should never be reached");
 }
+m_bHasValues = true;
+}
+
+bool ListLevel::HasValues() const
+{
+return m_bHasValues;
 }
 
 void ListLevel::SetParaStyle( const std::shared_ptr< StyleSheetEntry >& pStyle 
)
@@ -467,9 +473,9 @@ uno::Sequence< uno::Sequence< beans::PropertyValue > > 
ListDef::GetPropertyValue
 for ( sal_Int32 i = 0; i < nThisCount && i < nAbstractCount; i++ )
 {
 uno::Sequence< beans::PropertyValue > level = aThis[i];
-if ( level.hasElements() )
+if (level.hasElements() && GetLevel(i)->HasValues())
 {
-// If the element contains something, merge it
+// If the element contains something, merge it, but ignore stub 
overrides.
 lcl_mergeProperties( level, aAbstract[i] );
 }
 }
diff --git a/writerfilter/source/dmapper/NumberingManager.hxx 
b/writerfilter/source/dmapper/NumberingManager.hxx
index 026164122e85..eabf4a0276c6 100644
--- a/writerfilter/source/dmapper/NumberingManager.hxx
+++ b/writerfilter/source/dmapper/NumberingManager.hxx
@@ -52,6 +52,7 @@ class ListLevel : public PropertyMap
 sal_Int32 m_nTabstop;
 std::shared_ptr< StyleSheetEntry >  m_pParaStyle;
 bool  m_outline;
+bool m_bHasValues = false;
 
 public:
 
@@ -80,6 +81,8 @@ public:
 const OUString& GetBulletChar( ) { return m_sBulletChar; };
 const std::shared_ptr< StyleSheetEntry >& GetParaStyle( ) { return 
m_pParaStyle; };
 bool isOutlineNumbering() const { return m_outline; }
+/// Determines if SetValue() was called at least once.
+bool HasValues() const;
 
 // UNO mapping functions
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - lotuswordpro/source

2017-12-19 Thread Caolán McNamara

 lotuswordpro/source/filter/lwplayout.cxx |   16 +++-
 lotuswordpro/source/filter/lwplayout.hxx |1 +
 2 files changed, 12 insertions(+), 5 deletions(-)

New commits:
commit aea7d5682ccfa886812baece60ece4ee296e8a69
Author: CaolÃ¡n McNamara 
Date:   Tue Dec 19 09:18:54 2017 +

ofz#4689 avoid recurse to death

Change-Id: Ie578a767cd8646c4e67c302a67b46ce1f1637122
Reviewed-on: https://gerrit.libreoffice.org/46773
Tested-by: Jenkins 
Reviewed-by: Christian Lohmaier 

diff --git a/lotuswordpro/source/filter/lwplayout.cxx 
b/lotuswordpro/source/filter/lwplayout.cxx
index cb9a170159b3..7fd1060afaf2 100644
--- a/lotuswordpro/source/filter/lwplayout.cxx
+++ b/lotuswordpro/source/filter/lwplayout.cxx
@@ -1948,6 +1948,7 @@ rtl::Reference 
LwpLayout::GetContainerLayout()
 LwpPlacableLayout::LwpPlacableLayout( LwpObjectHeader const , 
LwpSvStream* pStrm )
 : LwpLayout(objHdr, pStrm)
 , m_bGettingWrapType(false)
+, m_bGettingLayoutRelativity(false)
 , m_nWrapType(0)
 , m_nBuoyancy(0)
 , m_nBaseLineOffset(0)
@@ -2027,11 +2028,15 @@ sal_uInt8 LwpPlacableLayout::GetWrapType()
 */
 LwpLayoutRelativity* LwpPlacableLayout::GetRelativityPiece()
 {
-if(!m_LayRelativity.IsNull())
+if (m_bGettingLayoutRelativity)
+throw std::runtime_error("recursion in layout");
+m_bGettingLayoutRelativity = true;
+LwpLayoutRelativity* pRet = nullptr;
+if (!m_LayRelativity.IsNull())
 {
-if(m_nOverrideFlag & OVER_PLACEMENT)
+if (m_nOverrideFlag & OVER_PLACEMENT)
 {
-return 
dynamic_cast(m_LayRelativity.obj().get());
+pRet = 
dynamic_cast(m_LayRelativity.obj().get());
 }
 }
 else
@@ -2039,10 +2044,11 @@ LwpLayoutRelativity* 
LwpPlacableLayout::GetRelativityPiece()
 rtl::Reference xBase(GetBasedOnStyle());
 if (LwpPlacableLayout* pLay = 
dynamic_cast(xBase.get()))
 {
-return pLay->GetRelativityPiece();
+pRet = pLay->GetRelativityPiece();
 }
 }
-return nullptr;
+m_bGettingLayoutRelativity = false;
+return pRet;
 }
 /**
 * @descr:   Get relative type
diff --git a/lotuswordpro/source/filter/lwplayout.hxx 
b/lotuswordpro/source/filter/lwplayout.hxx
index 1c10f59f3feb..aba59615360b 100644
--- a/lotuswordpro/source/filter/lwplayout.hxx
+++ b/lotuswordpro/source/filter/lwplayout.hxx
@@ -497,6 +497,7 @@ protected:
 void Read() override;
 protected:
 bool m_bGettingWrapType;
+bool m_bGettingLayoutRelativity;
 sal_uInt8 m_nWrapType;
 sal_uInt8 m_nBuoyancy;
 sal_Int32 m_nBaseLineOffset;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 47230] "Fonts > Apply replacement table" does not adjust width of characters

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=47230

--- Comment #6 from Harald Koester  ---
Checked with version 5.4.3 (64 bit, Win 10).

With the procedure of the original description it works for me now, but if you
go on with:

[4] Remove the font replacement: ... Options > Fonts > uncheck "Apply
replacement table", then OK. Nothing changed. The replacement is not removed.
Expected: Removal of replacement.

[5] Insert one character into the text. Now the replacement is removed, but the
distance between the characters is not adapted to the changed font. Expected:
Correct distance between characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

--- Comment #4 from Robert Pollak  ---
Sorry for not being able to find out whether this is a duplicate of any of the
other PDF import bugs.

I was testing with LibreOfficeDev_6.0.0.0.beta2_Win_x64.msi, by the way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

--- Comment #3 from Robert Pollak  ---
Created attachment 138538
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138538=edit
How Firefox renders the first page (seemingly correct)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

--- Comment #2 from Robert Pollak  ---
Created attachment 138537
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138537=edit
Screenshot of LO Draw with the broken import

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114563] ~@@~!!Kindle phone number +++++1844-781-0555+++Amazon 184478l0555 Kindle Support Number

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114563

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|libfreehand |deletionrequest
 Resolution|--- |INVALID
Product|Document Liberation Project |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114562] KIndle Phone Number 1/844/781/055 KIndle Phne NUmber ?? DHDGHD0555 OPTIONS

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114562

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
 Resolution|--- |INVALID
Product|cppunit |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

Robert Pollak  changed:

   What|Removed |Added

 Whiteboard||https://www.helbling.at/med
   ||ia/catalog/products/C7505/d
   ||oc/C7505_Silent%20Night_O%2
   ||0jesulein%20zart.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114564] ~@@~!!Kindle number +++++1844-781-0555+++Amazon 184478l0555 Kindle Support Number OPTIONS

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114564

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|Documentation   |deletionrequest
Version|2.2.0   |unspecified
 Resolution|--- |INVALID
Product|Impress Remote  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114570] ~@@~!!Kindle support number +++++1844-78l-0555+++ Kindle Phone Number @!@ … – The Spotify …

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114570

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|General |deletionrequest
Version|1.13|unspecified
 Resolution|--- |INVALID
Product|cppunit |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114568

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|Impress |deletionrequest
 Resolution|--- |INVALID
Product|LibreOffice Online  |LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

Robert Pollak  changed:

   What|Removed |Added

URL||https://www.helbling.at/med
   ||ia/catalog/products/C7505/d
   ||oc/C7505_Silent%20Night_O%2
   ||0jesulein%20zart.pdf
 Whiteboard|https://www.helbling.at/med |
   |ia/catalog/products/C7505/d |
   |oc/C7505_Silent%20Night_O%2 |
   |0jesulein%20zart.pdf|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

--- Comment #1 from Robert Pollak  ---
Created attachment 138536
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138536=edit
The problematic sheet music file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114574] New: FILEOPEN PDF Import: Sheet music breaks

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114574

Bug ID: 114574
   Summary: FILEOPEN PDF Import: Sheet music breaks
   Product: LibreOffice
   Version: 6.0.0.0.beta2
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: robert.pol...@posteo.net

Description:
Importing the attached file C7505_Silent Night_O jesulein zart.pdf into LO Draw
gives strange symbols, see the screenshot.

Steps to Reproduce:
1. Open the attached C7505_Silent Night_O jesulein zart.pdf with LO Draw.


Actual Results:  
I see strange symbols instead of the musical symbols, see the screenshot.

Expected Results:
I see pages of sheet music, as e.g. rendered by Firefox.


Reproducible: Always


User Profile Reset: No



Additional Info:
The file is from https://www.helbling.at/?pagename=product=C7505#toc .


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Crash test update

2017-12-19 Thread Crashtest VM

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/ecac94f3a6872538c19827603b52f1ed7e671a4c/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114573] New: Freeze Rows and Columns info is lost after a Recovery

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114573

Bug ID: 114573
   Summary: Freeze Rows and Columns info is lost after a Recovery
   Product: LibreOffice
   Version: 5.3.1.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nos...@ppmt.org

Description:
I have noticed that after a recovery the Rows that I were previously frozen are
no longer frozen,

If I save the document with the Frozen row and close Calc then reopens it, it
is present.

If for some reason I have to do a recovery then after the recovery the frozen
row is no longer frozen.

Strange thing is that if I close the recovered file and reopen it then the
frozen cell is back...as long as I didn't save the file in between

Steps to Reproduce:
1.Freeze a row
2.Save document
3.Force a recovery by killing the Calc process
4.Restart Calc

Actual Results:  
After the recovery the Frozen row is no longer frozen

Expected Results:
The row should still be frozen after the recovery


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 5.3.1.2
Build ID: 1:5.3.1-0ubuntu2
CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: gtk3; Layout
Engine: new; 
Locale: en-GB (en_GB.UTF-8); Calc: group


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113532] Bundle and use open source Arabic fonts by default

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113532

--- Comment #17 from Khaled Hosny  ---
(In reply to Yousuf Philips (jay) from comment #16)
> Patch is in - https://gerrit.libreoffice.org/#/c/46624/
> 
> The archives can be found here
> 
> https://drive.google.com/open?id=1pvCiOthbbpjnPyuh9dyHubAkBSbXLaqa
> 
> I pulled the fonts from these sources and trimmed/reorganized some of the
> archives.
> 
> Amiri - https://github.com/alif-type/amiri/releases
> KACST - https://packages.debian.org/stable/fonts-kacst
> Scheherazade - https://software.sil.org/scheherazade/
> Reem Kufi - https://github.com/alif-type/reem-kufi/releases
> Thabit - https://packages.debian.org/stable/fonts-hosny-thabit

I don’t recommend including Thabit, it is an abandoned font.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114572] UI: Backspace/ delete isn' t working as expect for the table column width fields ( persistently add a size)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114572

Telesto  changed:

   What|Removed |Added

   Keywords||bibisected, bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114557] 'Match Case' checkbox in Find toolbar cannot be renamed and icon cannot be set

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114557

--- Comment #5 from Maxim Monastirsky  ---
(In reply to Dieter Praas from comment #4)
> (In reply to Maxim Monastirsky from comment #3)
> > If we really want to allow renaming it(why?)
> 
> If the dialog allows you to rename it, I would expect, that it is possible
> to rename it.
Technically, the dialog operates on toolbar items. It has no idea that the code
of one of those items will suddenly at runtime decide to display a custom
control instead of a button. This might improve a bit after implementing Bug
112651, so we will be (mostly) aware of items that use controls, and can e.g.
disable renaming them. But problems don't end with controls, as there are
several ordinary toolbar buttons, that change their text at runtime. How should
we handle them?

Also, note that the title will actually appear if you dock the find toolbar
vertically (although the button won't work in such configuration, until Bug
55846 is fixed).

> But pershaps it's a litte more tricky:
> 
> 1. Open document in writer
> 2. Tools => Customise => Toolbars
> 3. Select Toolbar "Find"
> 4. Select "Find & Replace" => Change Icon => O. K.
> 5. Icon is not changed in the toolbar, but if you open the edit menu, you
> can see the new icon
This is Bug 106784. Let's not mix it here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs and enhancements

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Telesto  changed:

   What|Removed |Added

 Depends on||97073


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97073
[Bug 97073] FORMATTING: Adjusting table row height when cursor outside of table
is ignored
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97073] FORMATTING: Adjusting table row height when cursor outside of table is ignored

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97073

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
 Blocks||103100

--- Comment #4 from Telesto  ---
Repro with
Version: 6.1.0.0.alpha0+
Build ID: aad9c6da5154a89c6ef02214d1122d4b444eea23
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-12-15_22:56:44
Locale: nl-NL (nl_NL); Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56564] ADAPT ROW HEIGHT: Excessive resources consumption

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=56564

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
 OS|Linux (All) |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56564] ADAPT ROW HEIGHT: Excessive resources consumption

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=56564

--- Comment #6 from Telesto  ---
(In reply to Buovjaga from comment #3)
> Well my LibreOffice chokes already in the "copy formula of column C"!
> 
> Win 7 Pro 64-bit, LibO Version: 4.4.1.2
> Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432
> Locale: fi_FI

Repro with: 
Version: 6.1.0.0.alpha0+
Build ID: aad9c6da5154a89c6ef02214d1122d4b444eea23
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-12-15_22:56:44
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114558] Crash when clicking on Mail Merge button on Data Source tool bar

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114558

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
I can't reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 3af500580b1c82eabd60335c9ebc458a3f68850c
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded

Using biblio database.
@Cor, can you reproduce it with this database as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2017-12-19 Thread Jim Raykowski

 sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 9e7caee0173c5ec2d8b5cfa6aedfd1c9674d442b
Author: Jim Raykowski 
Date:   Sun Dec 17 09:42:54 2017 -0900

Uncheck Engineering notation checkbox on Scientific selection

In Calc, the Engineering notation checkbox in the Sidebar Properties
deck Number Format panel can show checked when the cell number format
does not contain engineering notation.

Change-Id: Ia26fc430aecd7af2e0f614bf9314d99f8408e690
Reviewed-on: https://gerrit.libreoffice.org/46650
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx 
b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
index 54c3975c9b08..a0c9eb940f8f 100644
--- a/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
+++ b/sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx
@@ -214,6 +214,7 @@ void NumberFormatPropertyPanel::NotifyItemUpdate(
 mpBtnThousand->Check(false);
 mpBtnEngineering->Show(bIsScientific);
 mpBtnEngineering->Enable(bIsScientific);
+mpBtnEngineering->Check(false);
 mpBtnNegRed->Enable();
 mpFtDenominator->Show(bIsFraction);
 mpEdDenominator->Show(bIsFraction);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/osl sal/osl

2017-12-19 Thread Stephan Bergmann

 include/osl/diagnose.hxx  |3 ---
 sal/osl/all/debugbase.cxx |3 ---
 2 files changed, 6 deletions(-)

New commits:
commit 4f0a97a81dc9aa93dd6579590110a1ea71154351
Author: Stephan Bergmann 
Date:   Tue Dec 19 12:24:07 2017 +0100

Clang 3.5 has -Wreturn-type-c-linkage

Change-Id: I9d4b8aef3877f46c537937f7cb04c7654f057fa2
Reviewed-on: https://gerrit.libreoffice.org/46789
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/osl/diagnose.hxx b/include/osl/diagnose.hxx
index 0dc140faef83..7cd0c106a584 100644
--- a/include/osl/diagnose.hxx
+++ b/include/osl/diagnose.hxx
@@ -65,9 +65,6 @@ SAL_DLLPUBLIC void SAL_CALL 
osl_detail_ObjectRegistry_revokeObject(
 // that would break binary compatibility.
 #ifdef __clang__
 #pragma clang diagnostic push
-// Guard against slightly older clang versions that don't have
-// -Wreturn-type-c-linkage...
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
 #pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
 #endif
 
diff --git a/sal/osl/all/debugbase.cxx b/sal/osl/all/debugbase.cxx
index 3c2f6c67b1e7..3534b9a828c4 100644
--- a/sal/osl/all/debugbase.cxx
+++ b/sal/osl/all/debugbase.cxx
@@ -68,9 +68,6 @@ extern "C" {
 // that would break binary compatibility.
 #ifdef __clang__
 #pragma clang diagnostic push
-// Guard against slightly older clang versions that don't have
-// -Wreturn-type-c-linkage...
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
 #pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - include/vcl vcl/source

2017-12-19 Thread Tomaž Vajngerl

 include/vcl/menu.hxx|1 
 vcl/source/window/menu.cxx  |   90 +++-
 vcl/source/window/menubarwindow.cxx |   41 +++-
 vcl/source/window/menubarwindow.hxx |1 
 vcl/source/window/menuitemlist.hxx  |3 +
 5 files changed, 132 insertions(+), 4 deletions(-)

New commits:
commit b5d400d689e5b0e29cd4fb34d407f356421aa39b
Author: TomaÅ¾ Vajngerl 
Date:   Mon Dec 18 19:30:06 2017 +0900

show rest of the menu bar in a pop-up if the are is too small

In case when the window is to small to show the whole menu then
the use couldn't access the rest of the items in the menu. This
change adds a button in the end (using the ">>" marker as in
toolbar) which on click adds a pop-up that shows the rest of the
menu items.

Reviewed-on: https://gerrit.libreoffice.org/46711
Tested-by: Jenkins 
Reviewed-by: TomaÅ¾ Vajngerl 
(cherry picked from commit 9f3b61e51f7f9de11436b0e4eaec164f2656fbdd)

Change-Id: I9218dba504464bdd44d61ebb383f7674f3df760f
Reviewed-on: https://gerrit.libreoffice.org/46795
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index 992d7b849b98..26328ff989df 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -171,6 +171,7 @@ protected:
 SAL_DLLPRIVATE Menu* ImplFindMenu( sal_uInt16 nId );
 SAL_DLLPRIVATE Size  ImplCalcSize( vcl::Window* pWin );
 SAL_DLLPRIVATE bool  ImplIsVisible( sal_uInt16 nPos ) const;
+SAL_DLLPRIVATE bool  ImplCurrentlyHiddenOnGUI(sal_uInt16 nPos) const;
 SAL_DLLPRIVATE bool  ImplIsSelectable( sal_uInt16 nPos ) const;
 SAL_DLLPRIVATE sal_uInt16 ImplGetVisibleItemCount() const;
 SAL_DLLPRIVATE sal_uInt16 ImplGetFirstVisible() const;
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 5b7906ad8383..305c83c86668 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -113,6 +113,51 @@ static void ImplSetMenuItemData( MenuItemData* pData )
 pData->eType = MenuItemType::STRINGIMAGE;
 }
 
+namespace {
+
+// TODO: Move to common code with the same function in toolbox
+// Draw the ">>" - more indictor at the coordinates
+void lclDrawMoreIndicator(vcl::RenderContext& rRenderContext, const Rectangle& 
rRect)
+{
+rRenderContext.Push(PushFlags::FILLCOLOR | PushFlags::LINECOLOR);
+rRenderContext.SetLineColor();
+
+if 
(rRenderContext.GetSettings().GetStyleSettings().GetFaceColor().IsDark())
+rRenderContext.SetFillColor(Color(COL_WHITE));
+else
+rRenderContext.SetFillColor(Color(COL_BLACK));
+float fScaleFactor = rRenderContext.GetDPIScaleFactor();
+
+int linewidth = 1 * fScaleFactor;
+int space = 4 * fScaleFactor;
+
+long width = 8 * fScaleFactor;
+long height = 5 * fScaleFactor;
+
+//Keep odd b/c drawing code works better
+if ( height % 2 == 0 )
+height--;
+
+long heightOrig = height;
+
+long x = rRect.Left() + (rRect.getWidth() - width)/2 + 1;
+long y = rRect.Top() + (rRect.getHeight() - height)/2 + 1;
+while( height >= 1)
+{
+rRenderContext.DrawRect( Rectangle( x, y, x + linewidth, y ) );
+x += space;
+rRenderContext.DrawRect( Rectangle( x, y, x + linewidth, y ) );
+x -= space;
+y++;
+if( height <= heightOrig / 2 + 1) x--;
+elsex++;
+height--;
+}
+rRenderContext.Pop();
+}
+
+} // end anonymouse namespace
+
 Menu::Menu()
 : mpFirstDel(nullptr),
   pItemList(new MenuItemList),
@@ -1221,6 +1266,22 @@ Menu& Menu::operator=( const Menu& rMenu )
 return *this;
 }
 
+// Returns true if the item is completely hidden on the GUI and shouldn't
+// be possible to interact with
+bool Menu::ImplCurrentlyHiddenOnGUI(sal_uInt16 nPos) const
+{
+MenuItemData* pData = pItemList->GetDataFromPos(nPos);
+if (pData)
+{
+MenuItemData* pPreviousData = pItemList->GetDataFromPos( nPos - 1 );
+if (pPreviousData && pPreviousData->bHiddenOnGUI)
+{
+return true;
+}
+}
+return false;
+}
+
 bool Menu::ImplIsVisible( sal_uInt16 nPos ) const
 {
 bool bVisible = true;
@@ -1792,6 +1853,8 @@ void Menu::ImplPaint(vcl::RenderContext& rRenderContext, 
Size const & rSize,
 if (!pThisItemOnly && !IsMenuBar() && nTitleHeight > 0)
 ImplPaintMenuTitle(rRenderContext, Rectangle(aTopLeft, aOutSz));
 
+bool bHiddenItems = false; // are any items on the GUI hidden
+
 for (size_t n = 0; n < nCount; n++)
 {
 MenuItemData* pData = pItemList->GetDataFromPos( n );
@@ -2014,7 +2077,25 @@ void Menu::ImplPaint(vcl::RenderContext& rRenderContext, 
Size const & rSize,
 {
 nMaxItemTextWidth -= nFontHeight - nExtra;

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - include/vcl vcl/source

2017-12-19 Thread Tomaž Vajngerl

 include/vcl/menu.hxx |2 +-
 vcl/source/window/menu.cxx   |9 +
 vcl/source/window/menubarwindow.cxx  |   24 +---
 vcl/source/window/menufloatingwindow.cxx |4 ++--
 4 files changed, 25 insertions(+), 14 deletions(-)

New commits:
commit 7b36595ae2b59a8c4c41d6aedfd634aed8390851
Author: TomaÅ¾ Vajngerl 
Date:   Mon Dec 18 17:42:00 2017 +0900

menu: pass paint size to ImplPaint and account for buttons

When a menu bar is painted it needs to take into account that
the buttons (close) is positioned at the right side of the paint
area. To do this we need to pass what the output size is when
painting (ImplPaint) on the common menu code, instead of assuming
the whole area can be used.

Reviewed-on: https://gerrit.libreoffice.org/46710
Tested-by: Jenkins 
Reviewed-by: TomaÅ¾ Vajngerl 
(cherry picked from commit e11234d8d8d8ff2744b77a128f845dbe8e6faa1e)

Change-Id: I2e9d6c686929fe1cd7e28368a8055c1e2df13c49
Reviewed-on: https://gerrit.libreoffice.org/46794
Reviewed-by: Thorsten Behrens 
Tested-by: Thorsten Behrens 

diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx
index 8c1b94788791..992d7b849b98 100644
--- a/include/vcl/menu.hxx
+++ b/include/vcl/menu.hxx
@@ -176,7 +176,7 @@ protected:
 SAL_DLLPRIVATE sal_uInt16 ImplGetFirstVisible() const;
 SAL_DLLPRIVATE sal_uInt16 ImplGetPrevVisible( sal_uInt16 nPos ) const;
 SAL_DLLPRIVATE sal_uInt16 ImplGetNextVisible( sal_uInt16 nPos ) const;
-SAL_DLLPRIVATE void ImplPaint(vcl::RenderContext& rRenderContext,
+SAL_DLLPRIVATE void ImplPaint(vcl::RenderContext& rRenderContext, Size 
const & rSize,
   sal_uInt16 nBorder, long nOffY = 0, 
MenuItemData* pThisDataOnly = nullptr,
   bool bHighlighted = false, bool bLayout = 
false, bool bRollover = false ) const;
 SAL_DLLPRIVATE void ImplPaintMenuTitle(vcl::RenderContext&, const 
Rectangle& rRect) const;
diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index 24743fb2723a..5b7906ad8383 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -1754,7 +1754,7 @@ void Menu::ImplPaintMenuTitle(vcl::RenderContext& 
rRenderContext, const Rectangl
 rRenderContext.SetBackground(aOldBackground);
 }
 
-void Menu::ImplPaint(vcl::RenderContext& rRenderContext,
+void Menu::ImplPaint(vcl::RenderContext& rRenderContext, Size const & rSize,
  sal_uInt16 nBorder, long nStartY, MenuItemData* 
pThisItemOnly,
  bool bHighlighted, bool bLayout, bool bRollover) const
 {
@@ -1782,7 +1782,7 @@ void Menu::ImplPaint(vcl::RenderContext& rRenderContext,
 }
 
 // for the computations, use size of the underlying window, not of 
RenderContext
-Size aOutSz = pWindow->GetOutputSizePixel();
+Size aOutSz(rSize);
 
 size_t nCount = pItemList->size();
 if (bLayout)
@@ -2271,12 +2271,13 @@ void Menu::ImplFillLayoutData() const
 mpLayoutData = new MenuLayoutData();
 if (IsMenuBar())
 {
-ImplPaint(*pWindow, 0, 0, nullptr, false, true); // FIXME
+ImplPaint(*pWindow, pWindow->GetOutputSizePixel(), 0, 0, nullptr, 
false, true); // FIXME
 }
 else
 {
 MenuFloatingWindow* pFloat = 
static_cast(pWindow.get());
-ImplPaint(*pWindow, pFloat->nScrollerHeight, 
pFloat->ImplGetStartY(), nullptr, false, true); //FIXME
+ImplPaint(*pWindow, pWindow->GetOutputSizePixel(), 
pFloat->nScrollerHeight, pFloat->ImplGetStartY(),
+  nullptr, false, true); //FIXME
 }
 }
 }
diff --git a/vcl/source/window/menubarwindow.cxx 
b/vcl/source/window/menubarwindow.cxx
index 867da80b3f27..8eb2fb67a81d 100644
--- a/vcl/source/window/menubarwindow.cxx
+++ b/vcl/source/window/menubarwindow.cxx
@@ -589,6 +589,10 @@ void MenuBarWindow::HighlightItem(vcl::RenderContext& 
rRenderContext, sal_uInt16
 
 long nX = 0;
 size_t nCount = pMenu->pItemList->size();
+
+Size aOutputSize = GetOutputSizePixel();
+aOutputSize.Width() -= aCloseBtn->GetSizePixel().Width();
+
 for (size_t n = 0; n < nCount; n++)
 {
 MenuItemData* pData = pMenu->pItemList->GetDataFromPos( n );
@@ -597,7 +601,7 @@ void MenuBarWindow::HighlightItem(vcl::RenderContext& 
rRenderContext, sal_uInt16
 if (pData->eType != MenuItemType::SEPARATOR)
 {
 // #107747# give menuitems the height of the menubar
-Rectangle aRect = Rectangle(Point(nX, 1), 
Size(pData->aSz.Width(), GetOutputSizePixel().Height() - 2));
+Rectangle aRect = Rectangle(Point(nX, 1), 
Size(pData->aSz.Width(), aOutputSize.Height() - 2));

[Libreoffice-bugs] [Bug 107511] Performance regression in hunspell

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107511

--- Comment #14 from Telesto  ---
I'm not noticing any lag with:
Version: 6.1.0.0.alpha0+
Build ID: aad9c6da5154a89c6ef02214d1122d4b444eea23
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-12-15_22:56:44
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114526] Saving to PDF creates what looks like a thumbnail

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114526

--- Comment #5 from Chavdar  ---
Exported as intended. No problems found.

Tested with version:
- 5.4.3.2 (x64)
- 6.0.0.0.beta2 (x64)
Windows 10 64
Locale: bg-BG (bg_BG)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - basic/source chart2/source compilerplugins/clang configure.ac cui/source dbaccess/source editeng/source extensions/source formula/source include/formula inc

2017-12-19 Thread Stephan Bergmann

 README.md  |2 
 basic/source/comp/scanner.cxx  |4 
 basic/source/runtime/methods.cxx   |   12 
 basic/source/runtime/runtime.cxx   |5 
 basic/source/sbx/sbxdate.cxx   |   11 
 basic/source/sbx/sbxscan.cxx   |2 
 chart2/source/controller/dialogs/DataBrowser.cxx   |4 
 chart2/source/controller/dialogs/tp_Scale.cxx  |   20 -
 chart2/source/tools/DiagramHelper.cxx  |4 
 compilerplugins/clang/check.cxx|   17 -
 compilerplugins/clang/checkconfigmacros.cxx|   20 -
 compilerplugins/clang/compat.hxx   |  191 ---
 compilerplugins/clang/constantparam.cxx|9 
 compilerplugins/clang/countusersofdefaultparams.cxx|   11 
 compilerplugins/clang/datamembershadow.cxx |3 
 compilerplugins/clang/expandablemethods.cxx|5 
 compilerplugins/clang/getimplementationname.cxx|2 
 compilerplugins/clang/implicitboolconversion.cxx   |   36 --
 compilerplugins/clang/includeform.cxx  |4 
 compilerplugins/clang/inlinesimplememberfunctions.cxx  |   10 
 compilerplugins/clang/oslendian.cxx|   12 
 compilerplugins/clang/passstuffbyref.cxx   |3 
 compilerplugins/clang/pluginhandler.cxx|   21 -
 compilerplugins/clang/pluginhandler.hxx|4 
 compilerplugins/clang/redundantcast.cxx|   16 
 compilerplugins/clang/refcounting.cxx  |   12 
 compilerplugins/clang/reservedid.cxx   |2 
 compilerplugins/clang/salbool.cxx  |8 
 compilerplugins/clang/sfxpoolitem.cxx  |   21 -
 compilerplugins/clang/singlevalfields.cxx  |7 
 compilerplugins/clang/staticmethods.cxx|   11 
 compilerplugins/clang/store/removevirtuals.cxx |3 
 compilerplugins/clang/store/returnbyref.cxx|3 
 compilerplugins/clang/test/datamembershadow.cxx|5 
 compilerplugins/clang/unnecessaryoverride.cxx  |   22 -
 compilerplugins/clang/unnecessaryvirtual.cxx   |2 
 compilerplugins/clang/unusedmethods.cxx|7 
 compilerplugins/clang/unusedmethodsremove.cxx  |2 
 compilerplugins/clang/vclwidgets.cxx   |   11 
 configure.ac   |   10 
 cui/source/options/optupdt.cxx |4 
 dbaccess/source/ui/misc/UITools.cxx|2 
 editeng/source/items/flditem.cxx   |6 
 extensions/source/propctrlr/standardcontrol.cxx|2 
 extensions/source/propctrlr/usercontrol.cxx|8 
 formula/source/core/api/FormulaCompiler.cxx|   30 -
 formula/source/core/api/token.cxx  |   10 
 include/formula/FormulaCompiler.hxx|5 
 include/formula/token.hxx  |   16 
 include/svl/zforlist.hxx   |   80 +++-
 include/svl/zformat.hxx|   21 -
 include/svx/numfmtsh.hxx   |6 
 oox/source/drawingml/chart/datasourcecontext.cxx   |2 
 sc/inc/column.hxx  |2 
 sc/inc/dociter.hxx |7 
 sc/inc/document.hxx|4 
 sc/inc/dpcache.hxx |3 
 sc/inc/externalrefmgr.hxx  |2 
 sc/inc/formulacell.hxx |7 
 sc/inc/global.hxx  |9 
 sc/inc/simpleformulacalc.hxx   |4 
 sc/inc/stringutil.hxx  |3 
 sc/inc/table.hxx   |2 
 sc/qa/unit/ucalc.cxx   |2 
 sc/source/core/data/clipcontext.cxx|4 
 sc/source/core/data/column.cxx |8 
 sc/source/core/data/column3.cxx|   22 -
 sc/source/core/data/dbdocutl.cxx   |   10 
 sc/source/core/data/dociter.cxx|   10 
 sc/source/core/data/documen4.cxx   |   17 -
 sc/source/core/data/document.cxx   |   10 
 sc/source/core/data/dpcache.cxx|   12 
 sc/source/core/data/dpobject.cxx   |   14 
 sc/source/core/data/dputil.cxx |4 
 sc/source/core/data/formulacell.cxx|   43 +-
 sc/source/core/data/global.cxx |2 
 sc/source/core/data/global2.cxx|6

[Libreoffice-bugs] [Bug 93084] Incorrect displaying docx document

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=93084

--- Comment #10 from Chavdar  ---
Confirmed the bug is still present.

Tested with version:
- 5.4.3.2 (x64)
- 6.0.0.0.beta2 (x64)
Windows 10 64
Locale: bg-BG (bg_BG)

There is some problem with the attached docx file. I had to rename it to be
able to open it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114571] Inserted images vanish after a while form document

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114571

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I launched Writer, then
clicked on Menu "Insert"/"Image", then selected the image.
After more than a minute, the image hasn't disappear.

I know there are lots of problem with image management but could you give a
precise step by step process?
Also, what's your LO version? FYI, 5.4.3 is last stable one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114572] UI: Backspace/ delete isn' t working as expect for the table column width fields ( persistently add a size)

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114572

--- Comment #1 from Telesto  ---
Created attachment 138535
  --> https://bugs.documentfoundation.org/attachment.cgi?id=138535=edit
Bibisect log

Bisected to:

author  Caolán McNamara 2017-09-13 21:02:32 +0100
committer   Caolán McNamara 2017-09-14 14:40:25
+0200
commit  44bfe8fad4f7c263dc713a65fb2ab0e2f9afcf99 (patch)
tree1a75093344dc2ee8e6d5bd7c21e3dd8dd4451596
parent  34ac0f9a0376b43bcff78a49ccaf4caa34c8c990 (diff)
connect to modified instead of up/down/focus-lost

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - configure.ac include/unotools sfx2/source unotools/source

2017-12-19 Thread Stephan Bergmann

 configure.ac   |2 
 include/unotools/saveopt.hxx   |6 --
 sfx2/source/doc/objstor.cxx|6 +-
 unotools/source/config/saveopt.cxx |   94 +++--
 4 files changed, 14 insertions(+), 94 deletions(-)

New commits:
commit b74da08e556b7b001943f0288a61da53791d4dcf
Author: Stephan Bergmann 
Date:   Tue Dec 19 16:16:36 2017 +0100

Read some configuration items directly

...removing them from SvtSaveOptions

Change-Id: I922ec0f88872b1f2d99c6a55faad00143d944473
Reviewed-on: https://gerrit.libreoffice.org/46797
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/unotools/saveopt.hxx b/include/unotools/saveopt.hxx
index 9b8a361b8f04..865ec73835cc 100644
--- a/include/unotools/saveopt.hxx
+++ b/include/unotools/saveopt.hxx
@@ -121,8 +121,6 @@ public:
 voidSetSaveRelFSys( bool b );
 boolIsSaveRelFSys() const;
 
-boolIsSaveUnpacked() const;
-
 voidSetLoadUserSettings(bool b);
 boolIsLoadUserSettings() const;
 
@@ -139,10 +137,6 @@ public:
 ODFDefaultVersion   GetODFDefaultVersion() const;
 ODFSaneDefaultVersion   GetODFSaneDefaultVersion() const;
 
-boolIsUseSHA1InODF12() const;
-
-boolIsUseBlowfishInODF12() const;
-
 boolIsReadOnly( EOption eOption ) const;
 };
 
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 5547c7ac51cc..68730d317740 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -368,8 +368,8 @@ void SfxObjectShell::SetupStorage( const uno::Reference< 
embed::XStorage >& xSto
 {
 SvtSaveOptions aSaveOpt;
 nDefVersion = aSaveOpt.GetODFDefaultVersion();
-bUseSHA1InODF12 = aSaveOpt.IsUseSHA1InODF12();
-bUseBlowfishInODF12 = aSaveOpt.IsUseBlowfishInODF12();
+bUseSHA1InODF12 = 
officecfg::Office::Common::Save::ODF::UseSHA1InODF12::get();
+bUseBlowfishInODF12 = 
officecfg::Office::Common::Save::ODF::UseBlowfishInODF12::get();
 }
 
 // the default values, that should be used for ODF1.1 and 
older formats
@@ -2631,7 +2631,7 @@ bool SfxObjectShell::CommonSaveAs_Impl(const 
INetURLObject& aURL, const OUString
 return false;
 }
 
-if (SfxItemState::SET != rItemSet.GetItemState(SID_UNPACK) && 
SvtSaveOptions().IsSaveUnpacked())
+if (SfxItemState::SET != rItemSet.GetItemState(SID_UNPACK) && 
officecfg::Office::Common::Save::Document::Unpacked::get())
 rItemSet.Put(SfxBoolItem(SID_UNPACK, false));
 
 OUString aTempFileURL;
diff --git a/unotools/source/config/saveopt.cxx 
b/unotools/source/config/saveopt.cxx
index 657eb6563488..26608c5b0f04 100644
--- a/unotools/source/config/saveopt.cxx
+++ b/unotools/source/config/saveopt.cxx
@@ -64,12 +64,9 @@ class SvtSaveOptions_Impl : public utl::ConfigItem
 bSaveDocView,
 bSaveRelINet,
 bSaveRelFSys,
-bSaveUnpacked,
 bDoPrettyPrinting,
 bWarnAlienFormat,
-bLoadDocPrinter,
-bUseSHA1InODF12,
-bUseBlowfishInODF12;
+bLoadDocPrinter;
 
 SvtSaveOptions::ODFDefaultVersion   eODFDefaultVersion;
 
@@ -84,13 +81,10 @@ class SvtSaveOptions_Impl : public utl::ConfigItem
 bROSaveDocView,
 bROSaveRelINet,
 bROSaveRelFSys,
-bROSaveUnpacked,
 bROWarnAlienFormat,
 bRODoPrettyPrinting,
 bROLoadDocPrinter,
-bROODFDefaultVersion,
-bROUseSHA1InODF12,
-bROUseBlowfishInODF12;
+bROODFDefaultVersion;
 
 virtual voidImplCommit() override;
 
@@ -110,12 +104,9 @@ public:
 boolIsSaveDocView() const   { return 
bSaveDocView; }
 boolIsSaveRelINet() const   { return 
bSaveRelINet; }
 boolIsSaveRelFSys() const   { return 
bSaveRelFSys; }
-boolIsSaveUnpacked() const  { return 
bSaveUnpacked; }
 bool

[Libreoffice-bugs] [Bug 114513] adding ability "Copy selection as Image (PNG or JPG)" for selecting in Calc

2017-12-19 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114513

--- Comment #4 from Eike Rathke  ---
Shouldn't the context menu entries be reserved for rather often used
functionality? In my decades of spreadsheet usage I may have needed that once,
if at all, I don't remember..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 4 5 >

1 - 100 of 400 matches

Mail list logo