[Libreoffice-bugs] [Bug 114817] New bitmap presets for Area Fill

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114817

--- Comment #6 from andreas_k  ---
Created attachment 139287
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139287=edit
source files

attached the source files I optimize them and we talk about 1,7 mb for 43
bitmaps. In master we have 20 bitmaps so we have to remove nearly 50%.
suggestions are welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 114817] New bitmap presets for Area Fill

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114817

--- Comment #6 from andreas_k  ---
Created attachment 139287
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139287=edit
source files

attached the source files I optimize them and we talk about 1,7 mb for 43
bitmaps. In master we have 20 bitmaps so we have to remove nearly 50%.
suggestions are welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 106780] FILESAVE, ODF: attribute text:style-name is invalid in table: table-template

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106780

abstatic  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |x.abhishek.flyh...@gmail.co
   |desktop.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106780] FILESAVE, ODF: attribute text:style-name is invalid in table: table-template

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106780

--- Comment #5 from abstatic  ---
Hi,

I have submitted a patch for this at https://gerrit.libreoffice.org/#/c/48373/

Now the name for attribute in table-template is table:name.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: instsetoo_native/inc_openoffice

[Samuel Mehrbrodt]

 instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 75f5d70d5d9f58a76e42d151f187c50bad50378c
Author: Samuel Mehrbrodt 
Date:   Tue Jan 23 08:09:23 2018 +0100

Revert "Windows installer: Use blank phone # instead of x-xxx-xxx-xxx"

Breaks windows installer

This reverts commit 7b129f55b4da9a20581fe805b7dacadcb6386252.

Change-Id: I21a5a6790eac1704da4bda41fb0969dc10b19d1c
Reviewed-on: https://gerrit.libreoffice.org/48369
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
index 4109c906b648..a8764b0745e9 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
@@ -23,7 +23,7 @@ en-US = "LibreOffice Community"
 en-US = "http://www.libreoffice.org/get-help;
 
 [OOO_ARPHELPTELEPHONETEMPLATE]
-en-US = ""
+en-US = "x-xxx-xxx-xxx"
 
 [OOO_ARPURLINFOABOUTTEMPLATE]
 en-US = "http://www.documentfoundation.org;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

[Stephan Bergmann]

 svx/source/gallery2/galctrl.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c28c1be1715d63ec4cff940ef270fb13c0c6db9a
Author: Stephan Bergmann 
Date:   Mon Jan 22 22:31:08 2018 +0100

USHRT_MAX -> SAL_MAX_UINT16

...as BrowseBox::GetColumnId (into which _nColumnPos is passed) takes a
sal_uInt16 argument

Change-Id: I4b890bf0fcbc91f2f07b3614a2e07aabf3345f7e
Reviewed-on: https://gerrit.libreoffice.org/48363
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/svx/source/gallery2/galctrl.cxx b/svx/source/gallery2/galctrl.cxx
index 4a9799c4a087..b8971286cb26 100644
--- a/svx/source/gallery2/galctrl.cxx
+++ b/svx/source/gallery2/galctrl.cxx
@@ -455,7 +455,7 @@ OUString GalleryListView::GetCellText(long _nRow, 
sal_uInt16 /*nColumnId*/) cons
 
 tools::Rectangle GalleryListView::GetFieldCharacterBounds(sal_Int32 
_nRow,sal_Int32 _nColumnPos,sal_Int32 nIndex)
 {
-DBG_ASSERT(_nColumnPos >= 0 && _nColumnPos <= USHRT_MAX, 
"GalleryListView::GetFieldCharacterBounds: _nColumnId overflow");
+DBG_ASSERT(_nColumnPos >= 0 && _nColumnPos <= SAL_MAX_UINT16, 
"GalleryListView::GetFieldCharacterBounds: _nColumnId overflow");
 tools::Rectangle aRect;
 if ( SeekRow(_nRow) )
 {
@@ -472,7 +472,7 @@ tools::Rectangle 
GalleryListView::GetFieldCharacterBounds(sal_Int32 _nRow,sal_In
 
 sal_Int32 GalleryListView::GetFieldIndexAtPoint(sal_Int32 _nRow,sal_Int32 
_nColumnPos,const Point& _rPoint)
 {
-DBG_ASSERT(_nColumnPos >= 0 && _nColumnPos <= USHRT_MAX, 
"GalleryListView::GetFieldIndexAtPoint: _nColumnId overflow");
+DBG_ASSERT(_nColumnPos >= 0 && _nColumnPos <= SAL_MAX_UINT16, 
"GalleryListView::GetFieldIndexAtPoint: _nColumnId overflow");
 sal_Int32 nRet = -1;
 if ( SeekRow(_nRow) )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source

[Stephan Bergmann]

 editeng/source/accessibility/AccessibleStringWrap.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d93813d8e448395ff9b6ac7b755d8fad68ec61b6
Author: Stephan Bergmann 
Date:   Mon Jan 22 22:42:25 2018 +0100

OutputDevice::GetCaretPositions takes sal_Int32 nIndex parameter

...since 16b446937e026ff5edd097e99b8d9be6ba314562 "Use OUString / sal_Int32 
in
vcl(outdev3.cxx,textlayout.cxx)"

Change-Id: I9e77bf801c6d79e1993ac6ddecf740b3362aeafe
Reviewed-on: https://gerrit.libreoffice.org/48364
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/editeng/source/accessibility/AccessibleStringWrap.cxx 
b/editeng/source/accessibility/AccessibleStringWrap.cxx
index af55049458f0..64ea287dc9ff 100644
--- a/editeng/source/accessibility/AccessibleStringWrap.cxx
+++ b/editeng/source/accessibility/AccessibleStringWrap.cxx
@@ -38,7 +38,7 @@ AccessibleStringWrap::AccessibleStringWrap( OutputDevice& 
rDev, SvxFont& rFont,
 
 void AccessibleStringWrap::GetCharacterBounds( sal_Int32 nIndex, 
tools::Rectangle& rRect )
 {
-DBG_ASSERT(nIndex >= 0 && nIndex <= USHRT_MAX,
+DBG_ASSERT(nIndex >= 0,
"SvxAccessibleStringWrap::GetCharacterBounds: index value 
overflow");
 
 mrFont.SetPhysFont(  );
@@ -55,7 +55,7 @@ void AccessibleStringWrap::GetCharacterBounds( sal_Int32 
nIndex, tools::Rectangl
 else
 {
 long aXArray[2];
-mrDev.GetCaretPositions( maText, aXArray, static_cast< sal_uInt16 
>(nIndex), 1 );
+mrDev.GetCaretPositions( maText, aXArray, nIndex, 1 );
 rRect.Left() = 0;
 rRect.Top() = 0;
 rRect.SetSize( Size(mrDev.GetTextHeight(), labs(aXArray[0] - 
aXArray[1])) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svl/source

[Stephan Bergmann]

 svl/source/items/cintitem.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ce84922f7b08ad431a6cca1cac32df0ba78f7915
Author: Stephan Bergmann 
Date:   Mon Jan 22 16:34:49 2018 +0100

Assume this wants to SAL_WARN for the sal_uInt16 range, actually

Change-Id: Icdda5cbc39fc2878c869ec01349135fd56a15363
Reviewed-on: https://gerrit.libreoffice.org/48349
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/svl/source/items/cintitem.cxx b/svl/source/items/cintitem.cxx
index f38fa524175f..7254d0be75d6 100644
--- a/svl/source/items/cintitem.cxx
+++ b/svl/source/items/cintitem.cxx
@@ -122,7 +122,7 @@ bool CntUInt16Item::PutValue(const css::uno::Any& rVal, 
sal_uInt8)
 sal_Int32 nValue = 0;
 if (rVal >>= nValue)
 {
-SAL_WARN_IF(nValue > USHRT_MAX, "svl.items", "Overflow in UInt16 
value!");
+SAL_WARN_IF(nValue < 0 || nValue > SAL_MAX_UINT16, "svl.items", 
"Overflow in UInt16 value!");
 m_nValue = static_cast(nValue);
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: forms/source

[Stephan Bergmann]

 forms/source/component/Edit.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 280cc198296b6728d990ee40f92b7f842c4959b1
Author: Stephan Bergmann 
Date:   Mon Jan 22 16:09:37 2018 +0100

Fix odd check for nFieldLen range, assuming typos

The code used the odd combination of checking signed nFieldLen for != 0 and
<= USHRT_MAX, and then converting to sal_Int16 (not sal_uInt16) ever since
bf4154eb5307ec8c35f000fd1df39ef3abb2eb6d "initial import".  But there are 
indeed
various MaxTextLen properties in offapi of type short, not unsigned short, 
so
for one assume that checking for <= SAL_MAX_INT16 (not SAL_MAX_UINT16) was
actually intended.  And, for another, also assume that checking nFieldLen 
for
> 0 instead of != 0 was intended.

Change-Id: I119ef3ce71ee397cb6cbca714bca154e29e6599d
Reviewed-on: https://gerrit.libreoffice.org/48348
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/forms/source/component/Edit.cxx b/forms/source/component/Edit.cxx
index 5c845a01866e..0454af30f4ba 100644
--- a/forms/source/component/Edit.cxx
+++ b/forms/source/component/Edit.cxx
@@ -576,7 +576,7 @@ void OEditModel::onConnectedDbColumn( const Reference< 
XInterface >& _rxForm )
 sal_Int32 nFieldLen = 0;
 xField->getPropertyValue("Precision") >>= nFieldLen;
 
-if (nFieldLen && nFieldLen <= USHRT_MAX)
+if (nFieldLen > 0 && nFieldLen <= SAL_MAX_INT16)
 {
 Any aVal;
 aVal <<= static_cast(nFieldLen);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/source

[Stephan Bergmann]

 xmloff/source/text/txtparai.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 859b91cb8ad29ff416e10da85ad493d05b10b83d
Author: Stephan Bergmann 
Date:   Mon Jan 22 16:05:51 2018 +0100

USHRT_MAX -> SAL_MAX_UINT16 for XMLCharContext::m_nCount

...which is of type sal_uInt16 ever since the class got introduced with
0e3ff5db960cdf907c03445220f1e29d37fc367f "INTEGRATION: CWS oj14: #i77059# 
export
char content helper for example line break"

Change-Id: I1dcb2894861ea5b6104932d896b7166c5c0b4689
Reviewed-on: https://gerrit.libreoffice.org/48347
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/xmloff/source/text/txtparai.cxx b/xmloff/source/text/txtparai.cxx
index 67fb156aff9a..534ec5df005a 100644
--- a/xmloff/source/text/txtparai.cxx
+++ b/xmloff/source/text/txtparai.cxx
@@ -119,8 +119,8 @@ XMLCharContext::XMLCharContext(
 sal_Int32 nTmp = xAttrList->getValueByIndex(i).toInt32();
 if( nTmp > 0 )
 {
-if( nTmp > USHRT_MAX )
-m_nCount = USHRT_MAX;
+if( nTmp > SAL_MAX_UINT16 )
+m_nCount = SAL_MAX_UINT16;
 else
 m_nCount = static_cast(nTmp);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: avmedia/source basic/source bridges/source canvas/source comphelper/source connectivity/source desktop/win32 drawinglayer/source dtrans/source embeddedobj/source embeds

[Stephan Bergmann]

 avmedia/source/win/window.cxx |8 
 basic/source/runtime/methods.cxx  |2 
 basic/source/sbx/sbxdec.cxx   |   12 
 bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx  |2 
 bridges/source/cpp_uno/msvc_win32_x86-64/except.cxx   |2 
 canvas/source/directx/dx_bitmapcanvashelper.cxx   |2 
 canvas/source/directx/dx_canvashelper.cxx |2 
 canvas/source/directx/dx_textlayout_drawhelper.cxx|   12 
 canvas/source/directx/dx_vcltools.cxx |6 
 comphelper/source/misc/mimeconfighelper.cxx   |2 
 connectivity/source/drivers/ado/ACallableStatement.cxx|4 
 connectivity/source/drivers/ado/AColumn.cxx   |2 
 connectivity/source/drivers/ado/AConnection.cxx   |4 
 connectivity/source/drivers/ado/ADatabaseMetaDataImpl.cxx |2 
 connectivity/source/drivers/ado/ADatabaseMetaDataResultSet.cxx|8 
 connectivity/source/drivers/ado/AResultSet.cxx|   16 -
 connectivity/source/drivers/ado/AStatement.cxx|2 
 connectivity/source/drivers/ado/Aolevariant.cxx   |   14 
 desktop/win32/source/guiloader/genericloader.cxx  |2 
 desktop/win32/source/officeloader/officeloader.cxx|4 
 drawinglayer/source/primitive2d/textlayoutdevice.cxx  |6 
 dtrans/source/win32/dnd/source.cxx|2 
 dtrans/source/win32/dtobj/FmtFilter.cxx   |2 
 embeddedobj/source/msole/olecomponent.cxx |   46 +-
 embeddedobj/source/msole/xdialogcreator.cxx   |   10 
 embedserv/source/embed/docholder.cxx  |8 
 embedserv/source/embed/ed_idataobj.cxx|   16 -
 embedserv/source/embed/ed_ipersiststr.cxx |8 
 embedserv/source/embed/tracker.cxx|   20 -
 extensions/source/activex/SOActiveX.cxx   |6 
 extensions/source/ole/oleobjw.cxx |   16 -
 extensions/source/ole/unoconversionutilities.hxx  |   10 
 extensions/source/ole/unoobjw.cxx |6 
 extensions/source/scanner/scanwin.cxx |4 
 fpicker/source/win32/filepicker/VistaFilePickerEventHandler.cxx   |2 
 fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx   |8 
 fpicker/source/win32/folderpicker/MtaFop.cxx  |2 
 hwpfilter/source/hwpreader.cxx|2 
 jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx   |4 
 sal/osl/w32/backtrace.cxx |8 
 sal/osl/w32/dllentry.cxx  |2 
 sal/osl/w32/file.cxx  |6 
 sal/osl/w32/file_dirvol.cxx   |   10 
 sal/osl/w32/file_error.cxx|2 
 sal/osl/w32/file_url.cxx  |4 
 sal/osl/w32/nlsupport.cxx |6 
 sal/osl/w32/pipe.cxx  |4 
 sal/osl/w32/process.cxx   |   12 
 sal/osl/w32/profile.cxx   |2 
 sal/osl/w32/security.cxx  |   20 -
 sal/osl/w32/socket.cxx|   22 -
 sal/osl/w32/thread.cxx|   16 -
 sal/osl/w32/time.cxx  |   16 -
 sal/qa/osl/security/osl_Security.cxx  |   22 -
 sal/rtl/alloc_arena.cxx   |6 
 sal/rtl/alloc_cache.cxx   |2 
 sdext/source/pdfimport/pdfparse/pdfparse.cxx  |4 
 setup_native/source/win32/customactions/sellang/sellang.cxx   |2 
 sfx2/source/appl/shutdowniconw32.cxx  |4 
 shell/source/win32/SysShExec.cxx  |2 
 shell/source/win32/shlxthandler/infotips/infotips.cxx |2 
 shell/source/win32/shlxthandler/ooofilt/propspec.cxx  |2 
 shell/source/win32/shlxthandler/ooofilt/stream_helper.cxx |6 
 

[Libreoffice-commits] core.git: sfx2/source

[Stephan Bergmann]

 sfx2/source/bastyp/bitset.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9602e63c818722c3910343b7af53917d031861c8
Author: Stephan Bergmann 
Date:   Mon Jan 22 15:49:30 2018 +0100

USHRT_MAX -> SAL_MAX_UINT16 in IndexBitSet

...which is based on sal_uInt16 instead of USHORT since
c5b727675460581258489d3bd569a61184ad69cd "removetooltypes: #i112600# remove
tooltypes"

Change-Id: I6b937961a69cc904226b05fe9679ac62e2f01c0a
Reviewed-on: https://gerrit.libreoffice.org/48333
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sfx2/source/bastyp/bitset.cxx b/sfx2/source/bastyp/bitset.cxx
index 8a49a02661c9..f13461c32de1 100644
--- a/sfx2/source/bastyp/bitset.cxx
+++ b/sfx2/source/bastyp/bitset.cxx
@@ -18,11 +18,11 @@
  */
 
 #include 
+#include 
 
 #include 
 
 #include 
-#include 
 
 // creates the asymmetric difference with another bitset
 
@@ -97,13 +97,13 @@ IndexBitSet::~IndexBitSet()
 
 sal_uInt16 IndexBitSet::GetFreeIndex()
 {
-  for(int i=0;i

[Libreoffice-commits] core.git: sfx2/source

[Noel Grandin]

 sfx2/source/appl/helpinterceptor.cxx |   20 +---
 sfx2/source/appl/helpinterceptor.hxx |5 ++---
 2 files changed, 7 insertions(+), 18 deletions(-)

New commits:
commit 1f75cda1d842717248c6dc926a9d2cd06f39d85b
Author: Noel Grandin 
Date:   Tue Jan 16 15:28:46 2018 +0200

loplugin:useuniqueptr in HelpInterceptor_Impl

Change-Id: I75c1ca2d6b0e03604bb6c96d2613261a1a05b988
Reviewed-on: https://gerrit.libreoffice.org/48297
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/sfx2/source/appl/helpinterceptor.cxx 
b/sfx2/source/appl/helpinterceptor.cxx
index 03f81a25e358..a41fc472a02b 100644
--- a/sfx2/source/appl/helpinterceptor.cxx
+++ b/sfx2/source/appl/helpinterceptor.cxx
@@ -47,29 +47,20 @@ HelpInterceptor_Impl::HelpInterceptor_Impl() :
 
 HelpInterceptor_Impl::~HelpInterceptor_Impl()
 {
-if ( m_pHistory )
-{
-for (HelpHistoryEntry_Impl* p : *m_pHistory)
-delete p;
-delete m_pHistory;
-}
 }
 
 
 void HelpInterceptor_Impl::addURL( const OUString& rURL )
 {
   if ( !m_pHistory )
-m_pHistory = new HelpHistoryList_Impl;
+m_pHistory.reset( new 
std::vector );
 
 size_t nCount = m_pHistory->size();
 if ( nCount && m_nCurPos < ( nCount - 1 ) )
 {
 for ( size_t i = nCount - 1; i > m_nCurPos; i-- )
 {
-delete m_pHistory->at( i );
-HelpHistoryList_Impl::iterator it = m_pHistory->begin();
-::std::advance( it, i );
-m_pHistory->erase( it );
+m_pHistory->erase( m_pHistory->begin() + i );
 }
 }
 Reference xFrame(m_xIntercepted, UNO_QUERY);
@@ -83,7 +74,7 @@ void HelpInterceptor_Impl::addURL( const OUString& rURL )
 
 m_aCurrentURL = rURL;
 Any aEmptyViewData;
-m_pHistory->push_back( new HelpHistoryEntry_Impl( rURL, aEmptyViewData ) );
+m_pHistory->emplace_back( new HelpHistoryEntry_Impl( rURL, aEmptyViewData 
) );
 m_nCurPos = m_pHistory->size() - 1;
 // TODO ?
 if ( m_xListener.is() )
@@ -229,9 +220,8 @@ void SAL_CALL HelpInterceptor_Impl::dispatch(
 
 if ( nPos < ULONG_MAX )
 {
-HelpHistoryEntry_Impl* pEntry = m_pHistory->at( nPos );
-if ( pEntry )
-m_pWindow->loadHelpContent(pEntry->aURL, false); // false 
=> don't add item to history again!
+HelpHistoryEntry_Impl* pEntry = m_pHistory->at( nPos ).get();
+m_pWindow->loadHelpContent(pEntry->aURL, false); // false => 
don't add item to history again!
 }
 
 m_pWindow->UpdateToolbox();
diff --git a/sfx2/source/appl/helpinterceptor.hxx 
b/sfx2/source/appl/helpinterceptor.hxx
index 41d9665f264b..92897d892343 100644
--- a/sfx2/source/appl/helpinterceptor.hxx
+++ b/sfx2/source/appl/helpinterceptor.hxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 
 struct HelpHistoryEntry_Impl
 {
@@ -39,8 +40,6 @@ struct HelpHistoryEntry_Impl
 aURL( rURL ), aViewData(rViewData) {}
 };
 
-typedef ::std::vector< HelpHistoryEntry_Impl* > HelpHistoryList_Impl;
-
 class SfxHelpWindow_Impl;
 class HelpInterceptor_Impl : public ::cppu::WeakImplHelper<
 css::frame::XDispatchProviderInterceptor,
@@ -61,7 +60,7 @@ friend class SfxHelpWindow_Impl;
 
 css::uno::Reference< css::frame::XStatusListener > m_xListener;
 
-HelpHistoryList_Impl*   m_pHistory;
+std::unique_ptr> 
m_pHistory;
 VclPtr  m_pWindow;
 sal_uIntPtr m_nCurPos;
 OUStringm_aCurrentURL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sfx2/source

[Noel Grandin]

 sfx2/source/control/itemdel.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6ada5c93080b4a377ba4f7bb4f8677949cfa2e94
Author: Noel Grandin 
Date:   Tue Jan 16 15:22:36 2018 +0200

loplugin:useuniqueptr in SfxItemDisruptor_Impl

Change-Id: Ie85c1a8fd699f68ffcc8853be4bf8a86cfec06e7
Reviewed-on: https://gerrit.libreoffice.org/48295
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sfx2/source/control/itemdel.cxx b/sfx2/source/control/itemdel.cxx
index 9ee76fd6a2bb..c6d53ef45936 100644
--- a/sfx2/source/control/itemdel.cxx
+++ b/sfx2/source/control/itemdel.cxx
@@ -26,7 +26,7 @@
 
 class SfxItemDisruptor_Impl
 {
-SfxPoolItem *   pItem;
+std::unique_ptr pItem;
 Idle m_Idle;
 
 private:
@@ -64,7 +64,7 @@ SfxItemDisruptor_Impl::~SfxItemDisruptor_Impl()
 // reset RefCount (was set to SFX_ITEMS_SPECIAL before!)
 pItem->SetRefCount( 0 );
 
-delete pItem;
+pItem.reset();
 }
 
 IMPL_LINK_NOARG(SfxItemDisruptor_Impl, Delete, Timer*, void)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114988] Hang on startup of every component due to OpenCL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114988

--- Comment #8 from Simon  ---
(In reply to Michael Meeks from comment #7)
>Sounds like the black-list is doing its job then =) Thanks for attaching
> the log - can you report your version of Windows too ?

Sorry for not replying earlier, I run Windows 8.1 pro, 64 bit, build 9600. 

Thanks for your support and an awesome product in general! I really appreciate
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115101] Form Editing, Table Control, Add Field, adds wrong items

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115101

--- Comment #6 from Howard Johnson  ---
I have noticed that in some LO user interfaces elements, hover (over, as in CSS
mouse hover) produces a highlighting as elements come under the mouse pointer. 
Also there is an observed temporary change of focus behavior when this occurs.  

In other elements this does not occur with a hover.  

I suspect that the wrong behavior is involved in this control at the moment it
is dragged, in other words it's still using hover over & change focus mode, but
after being down clicked it should turn that off so the drag does not cause
focus motion.


Create any database.  Open the Tables.  Move the mouse around and observe that
most things light up when the mouse is over them.  But notice that the pull
down box to select a component at the top left does not have this behavior.

Another example is the Form Navigator when editing a form.  The elements do not
light up when hovered over.


@Alex, 

>> this might be a GTK2 UI-specific bug, as the version you tested was built 
>> with the GTK2 UI framework. 

Interesting idea.  I confirmed that 6.0.0.0.beta2 and 6.0.0.2 downloaded from
LO web site both use GTK2.  Someday perhaps I might have the ability to dry
what you suggest, but have too many fires to fight right now to get into that. 
But given that we ALL are using GTK2 (at least anyone who is installing from LO
download page), then we all should be seeing roughly the same thing.  But you
know all that lare

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Brian Houston Morrow license statement

[brian houston morrow]

All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115163] New: Hardcoded Listen Address

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115163

Bug ID: 115163
   Summary: Hardcoded Listen Address
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: n...@kousu.ca

loolwsd is hardcoded to bind to 0.0.0.0. If you run it by default it opens two
ports

# netstat -p -t tcp -l -n
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address   Foreign Address State  
PID/Program name
...
tcp0  0 0.0.0.0:99800.0.0.0:*   LISTEN 
1739/loolwsd
tcp0  0 127.0.0.1:9981  0.0.0.0:*   LISTEN 
1739/loolwsd

Why is this? Most web daemons let  me pick a listen address, so that I can, if
I want, put it behind nginx/apache/whatever. Is this just an oversight because
your default supported config assumes everyone will wrap loolwsd inside docker
and use `docker port 127.0.0.1:9980:9980` to wrap it.

The code that causes this is because the 9980 websocket port is hardcoded to
"Type::Public", and that causes:

https://cgit.freedesktop.org/libreoffice/online/tree/wsd/LOOLWSD.cpp#n2605
```
std::shared_ptr socket = getServerSocket(
ServerSocket::Type::Public, port, WebServerPoll, factory);
```

https://cgit.freedesktop.org/libreoffice/online/tree/wsd/LOOLWSD.cpp#n2555

```
if (!serverSocket->bind(type, port))
return nullptr;
```


https://cgit.freedesktop.org/libreoffice/online/tree/net/Socket.cpp#n210

```
if (type == Type::Public)
addrv4.sin_addr.s_addr = type == htonl(INADDR_ANY);
else
addrv4.sin_addr.s_addr = type == htonl(INADDR_LOOPBACK);
```


Instead of this trying to be helpful, can there please be a  config
option? I just want to be able to tell loolwsd "listen here, I promise I know
what I'm doing"

In practice this doesn't seem to hurt me; I have nginx fronting loolwsd so no
one actually speaks unencrypted to loolwsd, but there's the potential that
someone might misconfigure a client somewhere and that worries me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106022] MailMerge: when running e-mail using a macro the MailMergeEventListener is monitoring wrong events

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106022

Aron Budea  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

--- Comment #5 from Aron Budea  ---
Thanks for the update! Let's change status to WORKSFORME, as the fixing commit
is unknown.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111837] Navigator: Lag in navigator selection update when clicking on next slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111837

Omer Zak  changed:

   What|Removed |Added

   Assignee|w...@zak.co.il|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #6 from Omer Zak  ---
Sorry, I found that I do not have free time for this. I am removing myself from
assignment to the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100967] libreoffice opens .doc file slow specially protected document is extremely opened slow.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100967

--- Comment #7 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105449] Data Explorer: Standardfilter view strange Input-Field?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105449

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104294] Truncation of the image position within a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104294

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 61037] VIEWING: Selection is not visible while scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=61037

--- Comment #3 from Plavozont  ---
I have a faster PC now with intel i5 proc and windows 10 (tested in LO 6.0.0.2
and LO 5.4.4). The selection is blinking while scrolling but frequently enough
to not get lost at all. On slower PCs it would be the same as before.


Another bug I noticed:

Start LO calc, make window size half screen(not maximized). Select all.
Maximize window.

Selection will stay same size as it was when window was not maximized. However
column's letters and row's numbers are highlighted correctly(Same both in LO
6.0.0.2 and LO 5.4.4).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115158] "Title, 6 Content" Layout lost with roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115158

Kevin Suo  changed:

   What|Removed |Added

 CC||suokunl...@126.com
Summary|Lost 6 content layout   |"Title, 6 Content" Layout
   ||lost with roundtrip

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98171] Impress Remote in Tamil on Android OS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98171

அருண் குமார் - Arun Kumar  changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

--- Comment #6 from அருண் குமார் - Arun Kumar  ---
Hi,

When I filed this bug, my phone was not running Tamil version of Android OS. at
the same time I could open VLC, Firefox apps in Tamil in such a way that you
can add your language in App's settings. 

My Question, why do not you allow user to add  Language in preference as per
their wish, if it is translated then, it should be supported in UI regardless
of Android OS UI support.

But currently my phone is having support in Tamil and I could see Impress
Remote in Tamil.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

--- Comment #5 from MM  ---
It looks like a dup from bug 114820, only with different functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/inc sc/source

[Samuel Mehrbrodt]

 sc/inc/column.hxx  |   11 +-
 sc/inc/document.hxx|5 ++-
 sc/inc/drwlayer.hxx|3 +
 sc/inc/table.hxx   |6 ++-
 sc/source/core/data/column.cxx |   59 +
 sc/source/core/data/column2.cxx|   18 ++-
 sc/source/core/data/column4.cxx|   16 ++
 sc/source/core/data/document.cxx   |5 +--
 sc/source/core/data/drwlayer.cxx   |   23 ++
 sc/source/core/data/table1.cxx |   22 ++---
 sc/source/core/data/table3.cxx |   29 --
 sc/source/ui/docshell/dbdocfun.cxx |2 -
 12 files changed, 180 insertions(+), 19 deletions(-)

New commits:
commit 3a2a430ae8e2c1647c18d8904477949f6e2e7941
Author: Samuel Mehrbrodt 
Date:   Wed Dec 20 11:30:36 2017 +0100

tdf#98931 Consider cell-anchored images when sorting

This makes images/draw objects anchored to cells move as any
other content when sorting cells.

Works for sorting rows and columns.

Also fixes a bug where notes attached to cells were not sorted
when sorting columns.

Change-Id: Id9a56a15f776d5adbe382a9bca167bff48b69a0c
Reviewed-on: https://gerrit.libreoffice.org/46838
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index ff65fbc3b3a0..67dbda8dc8dd 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -29,6 +29,7 @@
 #include "mtvelements.hxx"
 #include 
 #include 
+#include 
 #include "attarray.hxx"
 
 #include 
@@ -226,11 +227,13 @@ public:
 // data only:
 boolIsEmptyBlock(SCROW nStartRow, SCROW nEndRow) const;
 SCSIZE  GetEmptyLinesInBlock( SCROW nStartRow, SCROW nEndRow, 
ScDirection eDir ) const;
-boolHasDataAt(SCROW nRow) const;
+boolHasDataAt(SCROW nRow, bool bConsiderCellNotes=false,
+  bool bConsiderCellDrawObjects=false) const;
 boolHasVisibleDataAt(SCROW nRow) const;
 SCROW   GetFirstDataPos() const;
 SCROW   GetLastDataPos() const;
-SCROW   GetLastDataPos( SCROW nLastRow ) const;
+SCROW   GetLastDataPos( SCROW nLastRow, bool bConsiderCellNotes=false,
+bool bConsiderCellDrawObjects=false ) const;
 boolGetPrevDataPos(SCROW& rRow) const;
 boolGetNextDataPos(SCROW& rRow) const;
 voidFindDataAreaPos(SCROW& rRow, bool bDown) const; // (without 
Broadcaster)
@@ -626,6 +629,10 @@ public:
 
 void UpdateNoteCaptions( SCROW nRow1, SCROW nRow2 );
 
+void UpdateDrawObjects( std::vector>& pObjects, 
SCROW nRowStart, SCROW nRowEnd );
+void UpdateDrawObjectsForRow( std::vector& pObjects, SCCOL 
nTargetCol, SCROW nTargetRow );
+bool IsDrawObjectsEmptyBlock(SCROW nStartRow, SCROW nEndRow) const;
+
 void InterpretDirtyCells( SCROW nRow1, SCROW nRow2 );
 
 static void JoinNewFormulaCell( const sc::CellStoreType::position_type& 
aPos, ScFormulaCell& rCell );
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index d8dfb21dc05b..d8a47d600e19 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -1311,6 +1311,8 @@ public:
 If TRUE, do not adjust the left column.
 @param  bConsiderCellNotes
 If TRUE, consider the presence of cell notes 
besides data.
+@param  bConsiderCellDrawObjects
+If TRUE, consider the presence of draw objects 
anchored to the cell.
 
 @returns true if there is any data, false if not.
  */
@@ -1318,7 +1320,8 @@ public:
   SCTAB nTab, SCCOL& rStartCol, SCROW& 
rStartRow,
   SCCOL& rEndCol, SCROW& rEndRow, bool 
bColumnsOnly,
   bool bStickyTopRow = false, bool 
bStickyLeftCol = false,
-  bool bConsiderCellNotes = false ) 
const;
+  bool bConsiderCellNotes = false,
+  bool bConsiderCellDrawObjects = 
false ) const;
 
 /**
  * Return the last non-empty row position in given columns that's no
diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx
index 3da85abe939a..8f33dbebf721 100644
--- a/sc/inc/drwlayer.hxx
+++ b/sc/inc/drwlayer.hxx
@@ -104,7 +104,6 @@ private:
 voidMoveCells( SCTAB nTab, SCCOL nCol1,SCROW nRow1, SCCOL 
nCol2,SCROW nRow2,
 SCCOL nDx,SCROW nDy, bool 
bUpdateNoteCaptionPos );
 
-voidRecalcPos( SdrObject* pObj, ScDrawObjData& rData, 

[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

--- Comment #4 from Gabor Kelemen  ---
Created attachment 139286
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139286=edit
Example file with function references to the external data source file - saved
by LO 5.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

--- Comment #3 from Gabor Kelemen  ---
Created attachment 139285
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139285=edit
The example xlsx file to use as external data source - saved by LO 5.3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

--- Comment #2 from Gabor Kelemen  ---
Created attachment 139284
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139284=edit
The two files side by side. Referring to the data source gives error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115162] FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139283
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139283=edit
Example file with function references to the external data source file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115162] New: FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions give Error:504, with reference to external xlsx files cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115162

Bug ID: 115162
   Summary: FILESAVE XLSX SUMIFS, AVERAGEIFS, COUNTIFS functions
give Error:504, with reference to external xlsx files
cells
   Product: LibreOffice
   Version: 6.0.0.2 rc
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:xlsx
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 139282
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139282=edit
Example xlsx file to use as external data source

Attached spreadsheets were created with LibreOffice 6.0.0.2 and LibreOffice
5.3.3. The main problem here is that functions with complex conditions do not
work correctly if we refer to an external file, and we get an Error (504)
message in the cell. If we use the ‘SUMIFS’ or ‘AVERAGEIFS’ or ‘COUNTIFS’
function in the local (source.xlsx) file, they work perfectly.

Steps to reproduce:
1. Create a new spreadsheet with LibreOffice Calc
2. Click on Tools then choose Options.
3. In the Options set the LibreOffice Calc Formula options just like as you can
see at the attached Formula_syntax_setting.PNG file.
4. Fill at least three columns with some simple data. If you want, you could
try these functions in the local file, just to make sure they work correctly.
5. Save the file as “Source.xlsx”. This will be the source file which contains
the queried data.
6. Create a new spreadsheet with LibreOffice Calc and save as
“Function-Error-504.xlsx”. (This will be the reference file)
7. In the “Function-Error-504.xlsx” file create a correct SUMIFS or AVAREGEIFS
or COUNTIFS function which refers to the “Source file” data.
Here is an example code for a SUMIFS function: 
=SUMIFS('file:///E:/Functions-Error-504/Function-Error-504-Source.xlsx'#$Munkalap1.C1:C5;'file:///E:/Functions-Error-504/Function-Error-504-Source.xlsx'#$Munkalap1.B1:B5;'file:///E:/Functions-Error-504/Function-Error-504-Source.xlsx'#$Munkalap1.B1;'file:///E:/Functions-Error-504/Function-Error-504-Source.xlsx'#$Munkalap1.A1:A5;'file:///E:/Functions-Error-504/Function-Error-504-Source.xlsx'#$Munkalap1.A1)

8. Click Ok in the Function Wizard.
9. Save and reload the file.

Actual results:
We get an Error (504) message in the cell for these functions. Even if we set
only one condition in the “more conditional” functions, we got the same error.
Other similar functions (SUMIF, AVERAGEIF or COUNTIF) work well if we use these
steps.
These problems may (or may not) be the same as the VLOOKUP/HLOOKUP function bug
#114820.

Expected results:
We shouldn't receive an error code in the cell, because the function is correct
and works perfectly in the local files.

Verzió: 5.3.3.2
Build az.: 3d9a8b4b4e538a85e0782bd6c2d430bafe583448
CPU szálak: 4; Rendszer verziója: Windows 6.2; Felületmegjelenítés: GL;
Elrendezésmotor:új; 
Területi beállítások: hu-HU (hu_HU); Calc: group

Verzió: 6.0.0.2
Build az.: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU szálak: 4; OS: Windows 6.1; Felületmegjelenítés: alapértelmezett; 
Területi beállítások: hu-HU (hu_HU); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114820] FILESAVE XLSX Vlookup/Hlookup gives Error:504, with a reference to an external xlsx file cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114820

Gabor Kelemen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5162

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105116] VIEWING: zoom in garbles display with particular .odt

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105116

Terrence Enger  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from Terrence Enger  ---
Thank you for the reminder, Xisco.

I see that the bug is gone in daily Linux dbgutil bibisect repository
version 2018-01-22 running on debian-buster.  I am setting status
RESOLVED WORKSFORME.

Reverse bibisect in that repository shows that the fix happened in
version 2017-11-30.  Among the 96 or so source commits since version
2017-11-29, I notice:

commit ba4a124b0c0c66fd275f5147d55eeec27ce78da9
Author: Caolán McNamara 
Date:   Wed Nov 29 15:32:39 2017 +

Resolves: tdf#114117 draw page shadow mangled

when cairo had to stretch the 1 pixel dimension to fit the area.

When its this 1 pixel case set the same settings we use for the stipple
effect
to get the expected interpolation

Change-Id: I42d87d6d01ebdb44083351a9632860f5f0a3bf63
Reviewed-on: https://gerrit.libreoffice.org/45511
Reviewed-by: Michael Meeks 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

Caolán, do you think this bug deserves to be RESOLVED FIXED?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109240] FILESAVE XLSX: Use of Data > AutoFilter provoke auto-creation of multiple defined Name ranges over multiple consecutive save in XLSX format of the same file causing com

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109240

Aron Budea  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.0.0.1 |target:6.1.0 target:6.0.0.1
   |target:5.4.5 target:5.4.4   |target:5.4.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115161

--- Comment #3 from Gabor Kelemen  ---
Created attachment 139281
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139281=edit
The example file in Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115161

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139279
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139279=edit
The example file saved as docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115161] FILESAVE DOCX Overlapping Shape and Field disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115161

--- Comment #2 from Gabor Kelemen  ---
Created attachment 139280
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139280=edit
The example file in LO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115161] New: FILESAVE DOCX Overlapping Shape and Field disappear

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115161

Bug ID: 115161
   Summary: FILESAVE DOCX Overlapping Shape and Field disappear
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:docx
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 139278
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139278=edit
Example file saved by LO

Both the shape on top of the field and the field together disappear in
Microsoft Word

Steps to reproduce:
1. Create a new document with LibreOffice.
2. Insert a predefined field (for instance page number).
3. Insert a shape on the top of the field.
4. Remove the area of the shape or send the shape into the background.
5. Save the file as .docx.
6. Compare the document in Word and Writer.

Actual results:
Both shape and field do not appear in Microsoft Word.

Expected results:
Both shape and field appear even in Microsoft Word.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114251

--- Comment #34 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=811b40327c15e197b0967393e4071f48a60af42a=libreoffice-5-4

Related: tdf#114251 disable vectorization of svDoubleRef

It will be available in 5.4.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

[Eike Rathke]

 sc/source/core/data/grouptokenconverter.cxx |   13 +
 sc/source/core/tool/token.cxx   |3 ++-
 2 files changed, 15 insertions(+), 1 deletion(-)

New commits:
commit 811b40327c15e197b0967393e4071f48a60af42a
Author: Eike Rathke 
Date:   Sun Dec 17 17:34:15 2017 +0100

Related: tdf#114251 disable vectorization of svDoubleRef

It doesn't work, not knowing how to handle implicit intersections
not only produces huge unnecessary matrix operations but also
delivers wrong results.

Unit test will follow as a separate commit.

Change-Id: I14982d4a53d6af57196da998e53d426502c22fec
Reviewed-on: https://gerrit.libreoffice.org/46647
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 
(cherry picked from commit 67444cbe5dae6e24db776ab712017ad063319276)
Reviewed-on: https://gerrit.libreoffice.org/46670
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/core/data/grouptokenconverter.cxx 
b/sc/source/core/data/grouptokenconverter.cxx
index 410e3662ae78..ee93866cc2e7 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -165,6 +165,18 @@ bool ScGroupTokenConverter::convert( ScTokenArray& rCode, 
sc::FormulaLogger::Gro
 break;
 case svDoubleRef:
 {
+/* FIXME: this simply does not work, it doesn't know
+ * a) the context of implicit intersection, for which creating
+  two arrays dows not only result in huge unnecessary 
matrix
+  operations but also produces wrong results, e.g. =B:B/C:C
+ * b) when to keep a reference as a reference depending on the
+  expected parameter type, e.g. INDEX(), OFFSET() and
+  others (though that *may* be disabled by OpCode already).
+ * Until both are solved keep the reference. */
+mrGroupTokens.AddToken(*p);
+break;
+
+#if 0
 ScComplexRefData aRef = *p->GetDoubleRef();
 ScRange aAbs = aRef.toAbs(mrPos);
 
@@ -237,6 +249,7 @@ bool ScGroupTokenConverter::convert( ScTokenArray& rCode, 
sc::FormulaLogger::Gro
 //ensure that backing storage exists for our lifetime
 mxFormulaGroupContext = mrDoc.GetFormulaGroupContext();
 }
+#endif
 }
 break;
 case svIndex:
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 562d03f62394..f73c431d3316 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1549,10 +1549,11 @@ void ScTokenArray::CheckToken( const FormulaToken& r )
 // Don't change the state.
 break;
 case svSingleRef:
-case svDoubleRef:
 // Depends on the reference state.
 meVectorState = FormulaVectorCheckReference;
 break;
+case svDoubleRef:
+// Does not work yet, see ScGroupTokenConverter::convert()
 case svError:
 case svEmptyCell:
 case svExternal:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114251] Hang loading spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114251

--- Comment #33 from Commit Notification 
 ---
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0443eb8bf5ed79d13ec1aa49ac83ed2b2e8eea54=libreoffice-5-4

Type svIndex does not necessarily mean range name, tdf#114251 related

It will be available in 5.4.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

[Eike Rathke]

 sc/source/core/data/grouptokenconverter.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 0443eb8bf5ed79d13ec1aa49ac83ed2b2e8eea54
Author: Eike Rathke 
Date:   Sat Dec 16 22:52:09 2017 +0100

Type svIndex does not necessarily mean range name, tdf#114251 related

Change-Id: I5e7930b7f93ee44fb0d6b4c86f261afde8ed2ccc
Reviewed-on: https://gerrit.libreoffice.org/46615
Reviewed-by: Eike Rathke 
Tested-by: Jenkins 
(cherry picked from commit ecac94f3a6872538c19827603b52f1ed7e671a4c)
Reviewed-on: https://gerrit.libreoffice.org/46668
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/core/data/grouptokenconverter.cxx 
b/sc/source/core/data/grouptokenconverter.cxx
index 8132c1c400f1..410e3662ae78 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -241,6 +241,13 @@ bool ScGroupTokenConverter::convert( ScTokenArray& rCode, 
sc::FormulaLogger::Gro
 break;
 case svIndex:
 {
+if (p->GetOpCode() != ocName)
+{
+// May be DB-range or TableRef
+mrGroupTokens.AddToken(*p);
+break;
+}
+
 // Named range.
 ScRangeName* pNames = mrDoc.GetRangeName();
 if (!pNames)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115093] FORMATTING: Copying date formats in cells changes date for all cells in column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115093

Laurent BP  changed:

   What|Removed |Added

   Keywords||regression
 OS|Mac OS X (All)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115093] FORMATTING: Copying date formats in cells changes date for all cells in column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115093

Laurent BP  changed:

   What|Removed |Added

 CC||jumbo4...@yahoo.fr

--- Comment #4 from Laurent BP  ---
There is no need to use any specific format. It does not seem to be a format
problem.
I reproduce with 100 and more values in column A. I do not reproduce 99 values.
My procedure:
1. Enter a value in A1
2. In B1: =A1
3. Extend values in column A with sequential dates to line 'n'
4. Double click on the handle of B1

If n=99, values are the same in column A and B as expected.
If n>99, all displayed values in column B are equal to the nth value of column
A.

Shift+Ctrl+F9 has no effect of displayed value.
If in C1: =B1, then C1 contains the displayed value of B1, not A1 as expected.
Changing format of B1:B100 displays same value.
Changing value in Ai (i != n) has no effect (even with Shift+Ctrl+F9).
Changing value in An requires Shift+Ctrl+F9 to update all values in column B.

If formula in column B is extended with more values than in column A, then
contents in this extra cells are as expected: 0 or 30th December 1899

Changing start cell to H7 instead of A1 has no modification of the bug.

Cells A1 and B1 do not need to be contiguous.



Version: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
Threads CPU : 8; OS : Linux 4.13; UI Render : par défaut; VCL: gtk2; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: New Volounteer for Testing

[Markus Mohrhard]

Hello Driss,

On Mon, Jan 22, 2018 at 10:06 AM, Driss Ben Zoubeir  wrote:

> Hi libre office community,
>
> my name is Driss from Munich. I started before 3 years as Volounteer in
> Open Office  community and successfully solved some bugs. Now I want to
> contribute to libre office, but in Testing. I know this is the developer
> mailing list, but according to the website of libre Office I have to
> contact the devoloper list, if I want to help in programming automated
> tests.
>
> I have about 3 to 6 hours or even more per Week to Help with Testing. I
> already have some basic knowledge on Testing: Google Test, Unity, Google
> Mock, CMock, Tessy, jenkins...
>
> I would appreciate if you can Help me to start contributing on Testing.
>

I see that you already have some experience with testing frameworks so I
wanted to add a few more options to Xisco's answer. LibreOffice has a large
automated testing framework based on cppunit that is run during the build.
Most of these tests are unit and integration tests but many of them require
quite some understanding of how the corresponding code works to be able to
add a test. However if you have some area that you are especially
interested we might be able to find ways that you can contribute to these
tests without deep knowledge of the corresponding code.

Additionally, we have as Xisco managed a new UI testing framework that is
written in python and is built on top of the python unittest module. One of
our volunteers has been quite active adding writer UI tests in the last few
weeks (
https://gerrit.libreoffice.org/#/q/owner:zcrhonek%2540gmail.com+status:open).
If you are interested we can give you some more background how these tests
work, how to extend the test framework and how to add additional useful
tests. As an example many of the test case in TestLink could be converted
from manual tests to automated UI tests or integration tests.

If you are still interested in a more coding related testing effort but
none of the two above look that interesting to you I still have one or two
ideas for automated testing that have not been started or not yet been
ready. These mostly are python based testing concepts for problems that can
not be tested with the existing frameworks.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115137] The cell border list from the main tool palette is NOT displayed properly on UHD resolution

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115137

--- Comment #6 from Pedro I. Hernandez  ---
(In reply to Pedro I. Hernandez from comment #5)
> (In reply to m.a.riosv from comment #4)
> > Please test with Menu/Help/Restart in Safe Mode
> 
> The same issue...
> https://i.imgur.com/Iyl6fY1.png

Same problem goes with Writer... :-(
https://i.imgur.com/Mnz9TGb.png

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35538] Handling of fonts with more that 4 styles (R/B/I/BI) is suboptimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35538

--- Comment #46 from Thomas Linard  ---
But the documents are already "breaking horribly" because of platform-specific
handling…

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115160] New: Improve the download/install experience, default OS is not working correctly, and other issues.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115160

Bug ID: 115160
   Summary: Improve the download/install experience, default OS is
not working correctly, and other issues.
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bridgeportcontrac...@gmail.com

Created attachment 139277
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139277=edit
screenshot

Preamble: When a new visitor arrives to download LO from
https://www.libreoffice.org/download/download/  I think the big question on
their mind concerns how to quickly get the right download.  While the LO
download page has gotten better over time, considering how much of a first
impression it makes I think it's still lacking.  Yes, it's functional.

Consider this:  If a new user gets messed up on this page (as I did when I was
first starting out with LO) it leaves a bad taste in their mouth about the
whole LO thing.  [Remember, at this point in time, a person knows nothing about
LO, except what they see at this page.]


There are two important questions to quickly and accurately (i.e. without any
assumptions) get answers to from the newbie:

  1) What OS or platform are you using?
  2) What LO version do you desire?


SPECIFIC DOWNLOAD PAGE ISSUES AND ==> SUGGESTIONS

A) I think having a default OS is misleading.  (Currently it's RPM.)  

Did the this page look at my OS (my HTTP browser information) and somehow
determine that that RPM was what was required for me?  

That would be my first guess, as that's how many web pages work today.  But no,
I have Debian, and it came up with RPM!  So that's misleading and problematic
if the button is clicked.  

  (When I was new at this I had no idea what RPM was.  I only knew that I had
Debian, I had too many things to learn that day, and quickly needed a  download
that would work with my system.  So I clicked the download button only to end
up in much more frustration.)


==> If you can't correctly determine the OS needed, then don't start out with
any default.  Force the user to select OS, like this:


Select from the following supported architectures and operating systems:

   Apple:
   Mac OS X x86_64 (10.8 or newer required)

   Linux:
 For Intel and AMD 64 bit wide CPUs and operating systems:
   Linux x64 (deb)   - for Debian derived installers (apt, synaptic, etc.)
   Linux x64 (rpm)   - for Red Hat derived installers (rpm)

 For Intel and AMD 32 bit wide CPUs and operating systems:
   Linux x86 (deb)   - for Debian derived installers (apt, synaptic, etc.)
   Linux x86 (rpm)   - for Red Hat derived installers (rpm)

   Windows:
   Windows x86_64 - use with 64 bit OS and Vista or newer
   Windows- other (i.e. 32 bit and older windows)


Notice that I revised this list so that it consistently has the newer 64 before
the older 32.  Also it's alphabetical.  (If we support all of these, then we
should not be giving deferential preference to any of these here.  In other
words, I prefer Linux, but I'm not going to try and push that on a user who has
a different OS.)

Get rid of the line that says, "Selected: ...".  Replace it with selectors and
buttons that say what you download when you press them.


==> So at the very top of the page put a clearly marked LO version selector and
an OS selector.  

(The "change?" link is unclear.  Change what?  At a minimum say "change
selected OS", but please read on...)

!! ALSO, it is not clear as it is now, that the downloads listed further down
this page are also modified by the (below) selected version.  

The whole page is upside down, with the selectors at the bottom but being used
at the top.

Put the selectors at the top, and then use the below.  If you went to a car
parts site and they showed you a muffler to buy, would that make any sense.  No
first you want to select the car you drive.


==> Make each clickable download thingy on this page look the same.  In other
words when you see a green button you know that it's something to download. 
(It's ok to have the main download bigger, but all downloads should look like
buttons, because they are actions rather than links.  As it is, it looks like
they might be links to where you might download those other things.)


==> In this OS selector, provide some tool tips for new users who might be
confused by the x32 vs x64, and Deb vs RPM versions.  For Windows say what the
plain version of Windows is for.  In other words: HELP the visitor make these
selections.  Assume they are new to all of this!  (If we are to grow the LO
user base, we must start with new users who know virtually nothing about any of
this.)


B) Furthermore I haven't been given the choice of 

[Libreoffice-bugs] [Bug 107575] [META] Number format bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107575

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115093


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115093
[Bug 115093] FORMATTING: Copying date formats in cells changes date for all
cells in column
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115093] FORMATTING: Copying date formats in cells changes date for all cells in column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115093

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||107575


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107575
[Bug 107575] [META] Number format bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100023] [META] Enhance Draw's user experience

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100023

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115070


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115070
[Bug 115070] UI: wrong syncing of measurement units in Options and the ones set
in an existing document
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115070] UI: wrong syncing of measurement units in Options and the ones set in an existing document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115070

Thomas Lendo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||100023
 Ever confirmed|0   |1

--- Comment #3 from Thomas Lendo  ---
Sorry, I CAN reproduce the issue.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=100023
[Bug 100023] [META] Enhance Draw's user experience
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100023] [META] Enhance Draw's user experience

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=100023

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115070


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115070
[Bug 115070] UI: wrong syncing of measurement units in Options and the ones set
in an existing document
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 115070] UI: wrong syncing of measurement units in Options and the ones set in an existing document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115070

Thomas Lendo  changed:

   What|Removed |Added

 CC||thomas.le...@gmail.com

--- Comment #2 from Thomas Lendo  ---
Can't reproduce with

Version: 6.1.0.0.alpha0+
Build ID: acb43c0b8efbfb841e7b40603d75a8432eb21f21
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-01-09_01:20:44
Locale: de-DE (de_DE.UTF-8); Calc: group threaded

and with

Version: 6.1.0.0.alpha0+
Build-ID: ff8826d438a9fd080e8e61f8e66b3d3b2c8d752b
CPU-Threads: 4; Betriebssystem:Linux 4.13; UI-Render: Standard; VCL: gtk3; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded
with moggi's updater build from today

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35538] Handling of fonts with more that 4 styles (R/B/I/BI) is suboptimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35538

--- Comment #45 from Tor Lillqvist  ---
The font enumeration and UI aspect is just one part of the issue. What
apparently hasn't been taken into consideration at all in the comments above is
how to handle the "extra" styles in the document formats, in a
backward-compatible way, so that the document wouldn't break horribly if opened
in another application reading the same format, or in an older version of
LibreOffice. Far from trivial.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara]

 vcl/source/filter/igif/gifread.cxx |   27 ++-
 1 file changed, 14 insertions(+), 13 deletions(-)

New commits:
commit 3d30a39ee92678f6a4e71bd450fc044636adedab
Author: Caolán McNamara 
Date:   Mon Jan 22 13:02:24 2018 +

ofz#5573 Out of memory

Change-Id: Ifb5cfdd87d7b26d18fcb66279afa7ef06beea9e3
Reviewed-on: https://gerrit.libreoffice.org/48323
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/source/filter/igif/gifread.cxx 
b/vcl/source/filter/igif/gifread.cxx
index ea92b3ee1a0c..5667960c5766 100644
--- a/vcl/source/filter/igif/gifread.cxx
+++ b/vcl/source/filter/igif/gifread.cxx
@@ -157,19 +157,7 @@ void GIFReader::CreateBitmaps( long nWidth, long nHeight, 
BitmapPalette* pPal,
 {
 const Size aSize( nWidth, nHeight );
 
-#if SAL_TYPES_SIZEOFPOINTER == 8
-// Don't bother allocating a bitmap of a size that would fail on a
-// 32-bit system. We have at least one unit tests that is expected
-// to fail (loading a 65535*65535 size GIF
-// svtools/qa/cppunit/data/gif/fail/CVE-2008-5937-1.gif), but
-// which doesn't fail on 64-bit Mac OS X at least. Why the loading
-// fails on 64-bit Linux, no idea.
-if (nWidth >= 64000 && nHeight >= 64000)
-{
-bStatus = false;
-return;
-}
-#endif
+sal_uInt64 nCombinedPixSize = nWidth * nHeight;
 
 // "Overall data compression asymptotically approaches 3839 × 8 / 12 = 
2559 1/3"
 // so assume compression of 1:2560 is possible
@@ -181,6 +169,7 @@ void GIFReader::CreateBitmaps( long nWidth, long nHeight, 
BitmapPalette* pPal,
 {
 const Size& rSize = aAnimation.Get(i).aSizePix;
 nMinFileData += rSize.Width() * rSize.Height() / 2560;
+nCombinedPixSize += rSize.Width() * rSize.Height();
 }
 
 if (nMaxStreamData < nMinFileData)
@@ -192,6 +181,18 @@ void GIFReader::CreateBitmaps( long nWidth, long nHeight, 
BitmapPalette* pPal,
 return;
 }
 
+// Don't bother allocating a bitmap of a size that would fail on a
+// 32-bit system. We have at least one unit tests that is expected
+// to fail (loading a 65535*65535 size GIF
+// svtools/qa/cppunit/data/gif/fail/CVE-2008-5937-1.gif), but
+// which doesn't fail on 64-bit Mac OS X at least. Why the loading
+// fails on 64-bit Linux, no idea.
+if (nCombinedPixSize >= 64000U * 64000U)
+{
+bStatus = false;
+return;
+}
+
 if( bGCTransparent )
 {
 const Color aWhite( COL_WHITE );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sal/osl

[Stephan Bergmann]

 sal/osl/all/log.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5dd62512f520bbccfa864c6454c2c7c4b1462504
Author: Stephan Bergmann 
Date:   Mon Jan 22 13:02:42 2018 +0100

loplugin:nullptr (clang-cl)

Change-Id: Ie60f2cc7c3b0bcba7ddf2e7a0f6837c821b33dcc
Reviewed-on: https://gerrit.libreoffice.org/48313
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index e25136f2002d..1eae31ab7c3f 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -106,7 +106,7 @@ char const * getEnvironmentVariable(const char* env) {
 
 bool getValueFromLoggingIniFile(const char* key, char* value) {
 char buffer[MAX_PATH];
-GetModuleFileName(NULL, buffer, MAX_PATH);
+GetModuleFileName(nullptr, buffer, MAX_PATH);
 std::string sProgramDirectory = std::string(buffer);
 std::string::size_type pos = sProgramDirectory.find_last_of( "\\/" );
 sProgramDirectory = sProgramDirectory.substr(0, pos+1);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115123] Copying text from PDF gives corrupt text in new file depending on font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115123

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #10 from Jean-Baptiste Faure  ---
Confirmed under Ubuntu 16.04 with LO 5.4.4, LO 6.0.1.0.0+ and the current
master.
No problem if the font used is Caladea but same problem with Ubuntu font.
The problem is also seen when importing the pdf with LibreOffice Draw.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

spam in our bugzilla

[Lionel Elie Mamane]

Where are we supposed to report spam in our bugzilla?

see
https://bugs.documentfoundation.org/show_bug.cgi?id=104905#c14
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 115158] Lost 6 content layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115158

--- Comment #2 from Christophe Combelles  ---
I can reproduce not only with centering the title, but also by changing
anything else, such as the font, vertical centering, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: CppunitTest_xmlsecurity_signing Unit Test Failure on 32-bit Linux

[Luke Benes]

This is not a 32/64 bit issue, as I'm seeing this on my 64 bit Ubuntu 17.10 
system. The full, unedited log built with 
SAL_LOG="+WARN.+INFO.xmlsecurity+INFO.comphelper.crypto" 

Can be found here:

https://pastebin.com/inwx0Hu0


The previous log was heavily trimmed to reduce size.  While the OS is different 
both builds share the same external drive. Could the path length be a problem? 
(I trimmed the full path in the previous log) Or could this be like the "Unit 
test PythonTest_solenv_python failing on est_gbuildtojson" issue where a make 
clean isn't enough and I have to manually remove some file from the source 
tree? 

-Luke
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

[Stephan Bergmann]

 vcl/source/gdi/pdfwriter_impl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c664f790e697278382d739cb2c81039abde4253e
Author: Stephan Bergmann 
Date:   Mon Jan 22 13:04:20 2018 +0100

loplugin:redundantcast (clang-cl)

Change-Id: If1a5289ce346fa94f7aa8080a50572d6f9cade53
Reviewed-on: https://gerrit.libreoffice.org/48314
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 2c8cb52bfc14..fc3ef412cb34 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6040,7 +6040,7 @@ void PDFWriterImpl::sortWidgets()
 {
 SAL_WARN( "vcl.pdfwriter", "wrong number of sorted annotations" );
 SAL_INFO("vcl.pdfwriter", "PDFWriterImpl::sortWidgets(): wrong 
number of sorted assertions "
- "on page nr " << static_cast(item.first) << ", 
" <<
+ "on page nr " << item.first << ", " <<
  static_cast(item.second.aSortedAnnots.size()) 
<< " sorted and " <<
  static_cast(nAnnots) << " unsorted");
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: shell/source

[Stephan Bergmann]

 shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit d4b7c6fabb4973e71ac2ce6b456b03d3d54c759a
Author: Stephan Bergmann 
Date:   Mon Jan 22 13:08:01 2018 +0100

loplugin:cstylecast (clang-cl)

manual fix in macro code too difficult for current rewriting plugin

Change-Id: I4a2221d0cfb64dc0a0c6619cd9bc776e283da499
Reviewed-on: https://gerrit.libreoffice.org/48316
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx 
b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
old mode 100644
new mode 100755
index a3143f966ae6..87a8f591f393
--- a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
+++ b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
@@ -33,17 +33,17 @@
 // Unicode-only defines to break dependence on UNICODE define
 #if !defined ListView_InsertColumnW
 #define ListView_InsertColumnW(hwnd, iCol, pcol) \
-(int)SNDMSG((hwnd), LVM_INSERTCOLUMNW, (WPARAM)(int)(iCol), 
reinterpret_cast(pcol))
+static_cast(SNDMSG((hwnd), LVM_INSERTCOLUMNW, WPARAM(int(iCol)), 
reinterpret_cast(pcol)))
 #endif
 
 #if !defined ListView_InsertItemW
 #define ListView_InsertItemW(hwnd, pitem)   \
-(int)SNDMSG((hwnd), LVM_INSERTITEMW, 0, reinterpret_cast(pitem))
+static_cast(SNDMSG((hwnd), LVM_INSERTITEMW, 0, 
reinterpret_cast(pitem)))
 #endif
 
 #if !defined ListView_SetItemW
 #define ListView_SetItemW(hwnd, pitem) \
-(BOOL)SNDMSG((hwnd), LVM_SETITEMW, 0, reinterpret_cast(pitem))
+static_cast(SNDMSG((hwnd), LVM_SETITEMW, 0, 
reinterpret_cast(pitem)))
 #endif
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/rtl

[Stephan Bergmann]

 include/rtl/byteseq.h |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 9a188a0a04ce71f088e585a1b6583994f1b80992
Author: Stephan Bergmann 
Date:   Mon Jan 22 13:06:51 2018 +0100

loplugin:cstylecast (clang-cl, manual fix of conditional code)

Change-Id: I7d9c935897107fd0c8471f472234d789e9b8c2da
Reviewed-on: https://gerrit.libreoffice.org/48315
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/include/rtl/byteseq.h b/include/rtl/byteseq.h
index 064f91ca201a..640a4e06253a 100644
--- a/include/rtl/byteseq.h
+++ b/include/rtl/byteseq.h
@@ -152,9 +152,10 @@ enum __ByteSequence_NoAcquire
 */
 BYTESEQ_NOACQUIRE =
 #if defined _MSC_VER
-(int)
-#endif
+int(0xcafebabe)
+#else
 0xcafebabe
+#endif
 };
 
 /** C++ class representing a SAL byte sequence.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #6 from Gabor Kelemen  ---
Created attachment 139276
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139276=edit
The example file saved again by LO 6 RC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #5 from Gabor Kelemen  ---
Created attachment 139275
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139275=edit
The example file saved by LO 6 RC

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #3 from Gabor Kelemen  ---
Created attachment 139273
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139273=edit
Print titles after first save

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #4 from Gabor Kelemen  ---
Created attachment 139274
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139274=edit
Print titles after second save

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source

[Caolán McNamara]

 starmath/source/mathmlimport.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 69886ca4073bbe9f812a850ffc46b2da5858703c
Author: Caolán McNamara 
Date:   Mon Jan 22 12:29:29 2018 +

ofz#5575 call cleanup while its still a SmXMLImport

Change-Id: Ib80010410bd729e2356fe63f96809dd35fb26a73
Reviewed-on: https://gerrit.libreoffice.org/48320
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index b22cb0c5387b..f549cda0ad88 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -3034,6 +3034,7 @@ SvXMLImportContext 
*SmXMLImport::CreateActionContext(sal_uInt16 nPrefix,
 
 SmXMLImport::~SmXMLImport() throw ()
 {
+cleanup();
 }
 
 void SmXMLImport::SetViewSettings(const Sequence& aViewProps)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #2 from Gabor Kelemen  ---
Created attachment 139272
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139272=edit
The example file saved again by LO 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

--- Comment #1 from Gabor Kelemen  ---
Created attachment 139271
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139271=edit
The example file saved by LO 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115159] New: FILESAVE XLSX Print Titles are duplicated every time we export an XLSX file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115159

Bug ID: 115159
   Summary: FILESAVE XLSX Print Titles are duplicated every time
we export an XLSX file
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: filter:xlsx
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

Created attachment 139270
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139270=edit
Example file made with Excel 2013

If we create simple Print Titles with Microsoft Excel 2010/2013/2016 and export
the file with LibreOffice Calc, the Print Titles are duplicated.

Steps to reproduce:
1. Create a new spreadsheet with Microsoft Excel 2010/2013/2016.
2. Fill the first row with some data.
3. Select the worksheet range that you want to include titles when print.
4. Go to Page Layout tab, click Print Titles. 
5. Click on the select button in Rows to repeat at top area and select a title
row (the first row you fill with data.)
6. Press OK to finish setting.
7. Check the new Print titles which you have set, at the Formulas, Name Manager
tab.
8. Save the file as *.xlsx.
9. Open the file with LibreOffice Calc 5.4.4 and save as Print_Title_LO-54.xlsx
and reload it.
10. Check the Print Titles at the Sheet-→Named Ranges and Expressions-→Manager
tab. (There will be a duplicated Print Titles)


Actual results:
After we reload the file there will be a duplicated Print Titles
(_xlnm.Print_Tiles_0). If we open the exported file with Microsoft Excel and
check the Name Manager, there will be only the original Print Titles, but the
duplicated will not be there.
If we export the Print_Title_LO-54.xlsx file with LibreOffice Calc again (this
is the second time), at the Sheet-→Named Ranges and Expressions-→Manager will
be two duplicated Print Titles (_xlnm.Print_Tiles_0 and _xlnm.Print_Tiles_0_0).
If we open this file with Microsoft Excel and check the Name Manager, we will
see one duplicated Print Titles (Print_Tiles_0). And so it goes on.
Comment: This bug can be produced only with these settings and steps. In the
same way you can set column(s) to repeat at the left of each page, but in this
case the Print Titles will not be duplicated. The Print Areas not duplicated at
LibreOffice 5.4.4.


Expected results:
The Print Titles should not be duplicated after we export the *.xlsx file with
LibreOffice Calc.


Version: 5.4.4.2
Build az.: 2524958677847fb3bb44820e40380acbe820f960
CPU szálak: 4; OS: Windows 6.1; Felületmegjelenítés: alapértelmezett; 
Területi beállítások: hu-HU (hu_HU); Calc: group

Version: 6.0.0.1.0+
Build ID: c678dc5309741097d9b0265f03dd279a8794d256
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:libreoffice-6-0, Time: 2017-12-28_04:21:33
Locale: hu-HU (hu_HU); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115158] Lost 6 content layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115158

--- Comment #1 from Christophe Combelles  ---
I could not reproduce with the other layouts, only with the "6 Content" layout.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115158] New: Lost 6 content layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115158

Bug ID: 115158
   Summary: Lost 6 content layout
   Product: LibreOffice
   Version: 6.0.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cc...@free.fr

Description:
When using a 6 Content Layout, I lose the layout on file reopen or on resizing
container on Master View

Steps to Reproduce:
1. create a new empty impress presentation
2. in the Properties, click on the "Title, 6 Content" Layout
3. in the Properties, click on the Master View button
4. In the Object Area, click on the first line (outline 1)
5. Hit Ctrl-E to center the text of the object Area
6. Click on the "Close Master View" button
7. Save the file as an .odp document
8. Close the file with Ctrl-W
9. Reopen the file

Actual Results:  
The layout with 6 content boxes is lost : the first two boxes have the size of
the content area.

Expected Results:
The layout should be the same after reopening the file.


Reproducible: Always


User Profile Reset: No



Additional Info:
I could reproduce on 5.4.4 and 6.0.0 rc2 on Debian

Version: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU threads: 4; OS: Linux 4.14; UI render: GL; VCL: gtk2; 
Locale: en-US (C); Calc: group


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101
Firefox/57.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara]

 sd/source/ui/unoidl/unomodel.cxx |   35 ---
 1 file changed, 16 insertions(+), 19 deletions(-)

New commits:
commit 28ff54f9bb0d3f96d7a6fd3cbf3fa590c9ef45d6
Author: Caolán McNamara 
Date:   Mon Jan 22 12:17:56 2018 +

ofz optimize this unique name generator a tad

Change-Id: Ie18f71febbfc5e1ed4300782919bbd92d76ea51b
Reviewed-on: https://gerrit.libreoffice.org/48318
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 8e85f989b376..0c6d1fd7b877 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -3130,27 +3130,24 @@ uno::Reference< drawing::XDrawPage > SAL_CALL 
SdMasterPagesAccess::insertNewByIn
 OUString aPrefix( aStdPrefix );
 
 bool bUnique = true;
-sal_Int32 i = 0;
-do
-{
-bUnique = true;
-for( sal_Int32 nMaster = 1; nMaster < nMPageCount; nMaster++ )
-{
-SdPage* pPage = 
static_cast(pDoc->GetMasterPage(static_cast(nMaster)));
-if( pPage && pPage->GetName() == aPrefix )
-{
-bUnique = false;
-break;
-}
-}
 
-if( !bUnique )
-{
-i++;
-aPrefix = aStdPrefix + " " + OUString::number( i );
-}
+std::vector aPageNames;
+for (sal_Int32 nMaster = 1; nMaster < nMPageCount; ++nMaster)
+{
+const SdPage* pPage = static_cast(pDoc->GetMasterPage(static_cast(nMaster)));
+if (!pPage)
+continue;
+aPageNames.push_back(pPage->GetName());
+if (aPageNames.back() == aPrefix)
+bUnique = false;
+}
 
-} while( !bUnique );
+sal_Int32 i = 0;
+while (!bUnique)
+{
+aPrefix = aStdPrefix + " " + OUString::number(++i);
+bUnique = std::find(aPageNames.begin(), aPageNames.end(), aPrefix) 
== aPageNames.end();
+}
 
 OUString aLayoutName( aPrefix );
 aLayoutName += SD_LT_SEPARATOR;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/html/svxcss1.cxx |  107 +++---
 1 file changed, 67 insertions(+), 40 deletions(-)

New commits:
commit c3272ca47439464eee5501605e7282ecd0d6313a
Author: Caolán McNamara 
Date:   Mon Jan 22 12:00:12 2018 +

limit the rest of CSS1_PIXLENGTH users

Change-Id: I59487bb337bc8821cb995fd258602ff7fb580d54
Reviewed-on: https://gerrit.libreoffice.org/48311
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/html/svxcss1.cxx 
b/sw/source/filter/html/svxcss1.cxx
index 773bfc3607d5..aa537a3edbce 100644
--- a/sw/source/filter/html/svxcss1.cxx
+++ b/sw/source/filter/html/svxcss1.cxx
@@ -1852,10 +1852,14 @@ static void ParseCSS1_letter_spacing( const 
CSS1Expression *pExpr,
 
 case CSS1_PIXLENGTH:
 {
-long nPWidth = static_cast(pExpr->GetNumber());
-long nPHeight = 0;
-SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
-rItemSet.Put( SvxKerningItem( static_cast(nPWidth), 
aItemIds.nKerning ) );
+double fHeight = pExpr->GetNumber();
+if (fHeight < SAL_MAX_INT32/2.0 && fHeight > SAL_MIN_INT32/2.0)
+{
+long nPWidth = static_cast(fHeight);
+long nPHeight = 0;
+SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
+rItemSet.Put( SvxKerningItem( static_cast(nPWidth), 
aItemIds.nKerning ) );
+}
 }
 break;
 
@@ -2143,10 +2147,14 @@ static void ParseCSS1_margin_right( const 
CSS1Expression *pExpr,
 break;
 case CSS1_PIXLENGTH:
 {
-nRight = static_cast(pExpr->GetNumber());
-long nPHeight = 0;
-SvxCSS1Parser::PixelToTwip( nRight, nPHeight );
-bSet = true;
+double fRight = pExpr->GetNumber();
+if (fRight < SAL_MAX_INT32/2.0 && fRight > SAL_MIN_INT32/2.0)
+{
+nRight = static_cast(fRight);
+long nPHeight = 0;
+SvxCSS1Parser::PixelToTwip( nRight, nPHeight );
+bSet = true;
+}
 }
 break;
 case CSS1_PERCENTAGE:
@@ -2201,13 +2209,17 @@ static void ParseCSS1_margin_top( const CSS1Expression 
*pExpr,
 break;
 case CSS1_PIXLENGTH:
 {
-long nPWidth = 0;
-long nPHeight =  static_cast(pExpr->GetNumber());
-if( nPHeight < 0 )
-nPHeight = 0;
-SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
-nUpper = static_cast(nPHeight);
-bSet = true;
+double fHeight = pExpr->GetNumber();
+if (fHeight < SAL_MAX_INT32/2.0 && fHeight > SAL_MIN_INT32/2.0)
+{
+long nPWidth = 0;
+long nPHeight =  static_cast(fHeight);
+if( nPHeight < 0 )
+nPHeight = 0;
+SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
+nUpper = static_cast(nPHeight);
+bSet = true;
+}
 }
 break;
 case CSS1_PERCENTAGE:
@@ -2259,13 +2271,17 @@ static void ParseCSS1_margin_bottom( const 
CSS1Expression *pExpr,
 break;
 case CSS1_PIXLENGTH:
 {
-long nPWidth = 0;
-long nPHeight =  static_cast(pExpr->GetNumber());
-if( nPHeight < 0 )
-nPHeight = 0;
-SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
-nLower = static_cast(nPHeight);
-bSet = true;
+double fHeight = pExpr->GetNumber();
+if (fHeight < SAL_MAX_INT32/2.0 && fHeight > SAL_MIN_INT32/2.0)
+{
+long nPWidth = 0;
+long nPHeight =  static_cast(fHeight);
+if( nPHeight < 0 )
+nPHeight = 0;
+SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
+nLower = static_cast(nPHeight);
+bSet = true;
+}
 }
 break;
 case CSS1_PERCENTAGE:
@@ -2467,15 +2483,19 @@ static bool ParseCSS1_padding_xxx( const CSS1Expression 
*pExpr,
 break;
 case CSS1_PIXLENGTH:
 {
-long nPWidth = static_cast(pExpr->GetNumber());
-long nPHeight = 0;
-if( nPWidth < 0 )
-nPWidth = 0;
-SvxCSS1Parser::PixelToTwip( nPWidth, nPHeight );
-if( nPWidth > USHRT_MAX-1 )
-nPWidth = USHRT_MAX-1;
-nDist = static_cast(nPWidth);
-bSet = true;
+double fWidth = pExpr->GetNumber();
+if (fWidth < SAL_MAX_INT32/2.0 && fWidth > SAL_MIN_INT32/2.0)
+{
+long nPWidth = static_cast(fWidth);
+long nPHeight = 0;
+if( nPWidth < 0 )
+  

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8scan.cxx |   12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 42878f5459ac405f1938d3174e1aef1a2228c8fa
Author: Caolán McNamara 
Date:   Mon Jan 22 09:04:05 2018 +

ofz#5561 Integer-overflow

Change-Id: I57660848190efff8e6354670eb68b60ed57f0094
Reviewed-on: https://gerrit.libreoffice.org/48308
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 57a94783e239..dd8d2479233a 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1464,7 +1464,17 @@ WW8_CP WW8ScannerBase::WW8Fc2Cp( WW8_FC nFcPos ) const
 {
 bIsUnicode = m_pWw8Fib->m_fExtChar;
 }
-sal_Int32 nLen = (nCpEnd - nCpStart) * (bIsUnicode ? 2 : 1);
+
+sal_Int32 nLen = nCpEnd - nCpStart;
+if (bIsUnicode)
+{
+bool bFail = o3tl::checked_multiply(nLen, 2, nLen);
+if (bFail)
+{
+SAL_WARN("sw.ww8", "broken offset, ignoring");
+return WW8_CP_MAX;
+}
+}
 
 /*
 If this cp is inside this piece, or it's the last piece and we are
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 46520] [FILEOPEN] "Incorrect file version" when opening a PPT v 4.0 file--pre 97-2003 binary format-- ( error message need to be improved)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46520

--- Comment #17 from Antonio Vinicius Menezes Medeiros  
---
I can reproduce that bug using

- LibreOffice 4.1.5.3 on Windows 7 64-bit with SP1
- LibreOffice 5.3.5.2 on openSUSE 42.3 x64

But I was able to open sdsi20-maryland.ppt using LibreOffice 5.4.4 Portable
MultilingualStandard I downloaded from:

https://www.libreoffice.org/download/portable-versions/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos]

 source/text/shared/01/0506.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d8623712ce8523cd6d29116a5bd903e1d7edbd62
Author: Adolfo Jayme Barrientos 
Date:   Mon Jan 22 14:16:08 2018 -0600

tdf#35301 Tiny text tweak for newly available ruby position

Ruby text can not only be above base text, but also beside it.

Change-Id: Ic9a11a1f7912c50d092f13c6d3d52d83713cd305

diff --git a/source/text/shared/01/0506.xhp 
b/source/text/shared/01/0506.xhp
index ede5b49ba..a3d712ec7 100644
--- a/source/text/shared/01/0506.xhp
+++ b/source/text/shared/01/0506.xhp
@@ -35,7 +35,7 @@
 
 
 Asian Phonetic Guide
-Allows you to add comments above Asian characters to 
serve as a pronunciation guide.
+Allows you to add comments next to Asian characters to 
serve as a pronunciation guide.
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4b65de810eace19ee301e0dc9f9895a487b5798e
Author: Adolfo Jayme Barrientos 
Date:   Mon Jan 22 14:16:08 2018 -0600

Updated core
Project: help  d8623712ce8523cd6d29116a5bd903e1d7edbd62

tdf#35301 Tiny text tweak for newly available ruby position

Ruby text can not only be above base text, but also beside it.

Change-Id: Ic9a11a1f7912c50d092f13c6d3d52d83713cd305

diff --git a/helpcontent2 b/helpcontent2
index 237f881e17ef..d8623712ce85 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 237f881e17efb3091d93430fa287eab9b9d6b915
+Subproject commit d8623712ce8523cd6d29116a5bd903e1d7edbd62
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115157] New: Typo in this bug submission form: Under Component: Installation; change '..installed of if ' to '..installed or if '

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115157

Bug ID: 115157
   Summary: Typo in this bug submission form: Under Component:
Installation; change '..installed of if ' to
'..installed or if '
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bridgeportcontrac...@gmail.com

Created attachment 139269
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139269=edit
snapshot of issue

When submitting a bug here in
https://bugs.documentfoundation.org/enter_bug.cgi?product=LibreOffice

There is a minor typo when selecting "Component: Installation".  

The green tool tip reads:

  "... Use it if LibreOffice can't be installed of if Your office suite ..."

"of", should be replaced with "or", as follows:

  "... Use it if LibreOffice can't be installed or if Your office suite ..."


See attachment screen shot.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115156] Downloaded the new version on 1/21/ 2018 and cannot retrieve any of my files.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115156

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from MM  ---
Could you supply some more info about the bug ?
What exactly doesn't work ? Is the program not starting (which version did work
before) or is it not loading anything ?!
If it is the latter, could you supply a document which doesn't contain private
data.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115139] after copy/paste of text from webpage, then font change, all menus are blank

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115139

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from MM  ---
Could you try a newer version? The 5.1 branch is quite old and outdated and
won't be supported any more. https://www.libreoffice.org/download/download/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115001] TOC: Recreating ToC produces unwanted page-breaks in text flow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115001

--- Comment #2 from edwin.gersb...@email.ch ---
Many thanks for your reply.

I didn't realize that there are still leftovers from MS-Word which is some 20
years ago. In between the document was even processed with OpenOffice.

Well then, I created a new document from scratch and start defining all the
styles of the Pages, Paragraphs, Titles and the like.

What I would like to know is what I can copy/paste from the existing document
without possibly taking unwanted MS-Word stuff with it.

Mainly

> recreating all the tables from scratch would would be extremely time consuming
  - can I copy them at least one by one?

> recreating the item list with all the cross references would be even worse
  - do I have to copy the plain text and reformat everything?

> also, what I did not manage so far is to create a 2 column page with a
  chapter title on the top spanning over both columns
  I keep trying to find a solution for this but would greatly appreciate a
hint.

regards Edwin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115142] When an image is bigger than the slide impress shrinks it to the size of the slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115142

--- Comment #3 from Chavdar  ---
Confirmed

Version: 5.4.4.2 (x64)
Build ID: 2524958677847fb3bb44820e40380acbe820f960
CPU threads: 4; OS: Windows 6.19; UI render: default; 
Locale: bg-BG (bg_BG); Calc: group

Version: 6.1.0.0.alpha0+
Build ID: d28e10b095b4ee0986fbe86170928bf077da04b9
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2018-01-13_22:59:50
Locale: bg-BG (bg_BG); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa

[Zdeněk Crhonek]

 sw/qa/uitest/writer_tests/data/tdf108124.odt |binary
 sw/qa/uitest/writer_tests/tdf108124.py   |   37 +++
 2 files changed, 37 insertions(+)

New commits:
commit 5df0c80b8dc1106a8c28967226526b05b047bc09
Author: Zdeněk Crhonek 
Date:   Sat Dec 23 17:10:05 2017 +0100

uitest for tdf#108124

Change-Id: If500712e1fddc2a65b5c2df1649231ff3b46a45b
Reviewed-on: https://gerrit.libreoffice.org/47019
Reviewed-by: Markus Mohrhard 
Tested-by: Jenkins 

diff --git a/sw/qa/uitest/writer_tests/data/tdf108124.odt 
b/sw/qa/uitest/writer_tests/data/tdf108124.odt
new file mode 100644
index ..af0260928b40
Binary files /dev/null and b/sw/qa/uitest/writer_tests/data/tdf108124.odt differ
diff --git a/sw/qa/uitest/writer_tests/tdf108124.py 
b/sw/qa/uitest/writer_tests/tdf108124.py
new file mode 100644
index ..3dae7080bc11
--- /dev/null
+++ b/sw/qa/uitest/writer_tests/tdf108124.py
@@ -0,0 +1,37 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from uitest.framework import UITestCase
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.common import get_state_as_dict
+import time
+from uitest.debug import sleep
+from uitest.path import get_srcdir_url
+
+def get_url_for_data_file(file_name):
+return get_srcdir_url() + "/sw/qa/uitest/writer_tests/data/" + file_name
+
+class tdf108124(UITestCase):
+
+   def test_tdf108124(self):
+writer_doc = self.ui_test.load_file(get_url_for_data_file("tdf108124.odt"))
+xWriterDoc = self.xUITest.getTopFocusWindow()
+xWriterEdit = xWriterDoc.getChild("writer_edit")
+document = self.ui_test.get_component()
+
+self.assertEqual(document.GraphicObjects.getCount(), 2)  #nr. of images
+
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+a"})) 
# select all
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+c"})) 
# copy
+xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+v"})) 
# paste
+self.assertEqual(document.GraphicObjects.getCount(), 4)
+self.xUITest.executeCommand(".uno:Undo")  #Undo
+self.assertEqual(document.GraphicObjects.getCount(), 2)
+self.xUITest.executeCommand(".uno:Redo")  #Redo
+self.assertEqual(document.GraphicObjects.getCount(), 4)
+
+self.ui_test.close_doc()
+# vim: set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115156] New: Downloaded the new version on 1/21/ 2018 and cannot retrieve any of my files.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115156

Bug ID: 115156
   Summary: Downloaded the new version on 1/21/2018 and cannot
retrieve any of my files.
   Product: LibreOffice
   Version: 5.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fladerj...@gmail.com

Description:
I can't retrieve any of my existing documents not can I start to compose
anything else. I guess it has crashed!

Actual Results:  
I can't do anything.

Expected Results:
I would like to be able to use the program as intended.


Reproducible: Always


User Profile Reset: No



Additional Info:
WORK!!


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: embeddedobj/source

[Stephan Bergmann]

 embeddedobj/source/msole/olecomponent.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 587b6906d5b9ae1ac9368f1e48d84285cebaece3
Author: Stephan Bergmann 
Date:   Mon Jan 22 13:01:39 2018 +0100

loplugin:unnecessaryparen (clang-cl)

Change-Id: Iff2b28120e0c43f13d4fb21a75746f2a289214c7
Reviewed-on: https://gerrit.libreoffice.org/48312
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/embeddedobj/source/msole/olecomponent.cxx 
b/embeddedobj/source/msole/olecomponent.cxx
index 738d87fa6452..290318a4d109 100644
--- a/embeddedobj/source/msole/olecomponent.cxx
+++ b/embeddedobj/source/msole/olecomponent.cxx
@@ -466,7 +466,7 @@ OleComponent::~OleComponent()
   aIter != m_pNativeImpl->m_aFormatsList.end();
   ++aIter )
 {
-delete (*aIter);
+delete *aIter;
 (*aIter) = nullptr;
 }
 m_pNativeImpl->m_aFormatsList.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 38994] EDITING: improve single cell selection for Drag and Drop ( by click on cell border?)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38994

Thomas Lendo  changed:

   What|Removed |Added

 CC||m...@michaelbmast.com

--- Comment #12 from Thomas Lendo  ---
*** Bug 115114 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115114] Calc: Dragging a selected cell, or range of cells, is too difficult.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115114

Thomas Lendo  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||thomas.le...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Thomas Lendo  ---
Thanks for your report, Michael.
Your bug seems to be a duplicate of bug 38994 from 2011. This is a very old
issue back to the early days of OpenOffice.org.

Jeffrey in bug 38994 comment 1 cites an old workaround:
1) Click on the cell to give them a black border.
2) Drag the blue background to another cell.
3) Hold the click and drag back to the single cell.

*** This bug has been marked as a duplicate of bug 38994 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108440] [META] Database form bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108440

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115096


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115096
[Bug 115096] For a Pattern Field please reverse the order of the mask related
properties
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115096] For a Pattern Field please reverse the order of the mask related properties

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115096

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108440, 102019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108440
[Bug 108440] [META] Database form bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115096


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115096
[Bug 115096] For a Pattern Field please reverse the order of the mask related
properties
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source filter/Library_svgfilter.mk sc/Library_sc.mk sdext/Library_pdfimport.mk solenv/gbuild

[Michael Stahl]

 desktop/source/app/sofficemain.cxx |3 +++
 filter/Library_svgfilter.mk|7 +++
 sc/Library_sc.mk   |7 +++
 sdext/Library_pdfimport.mk |6 ++
 solenv/gbuild/platform/com_MSC_defs.mk |3 +++
 5 files changed, 26 insertions(+)

New commits:
commit 61c88ae6945c241f5f2aeb844eeca0776b487132
Author: Michael Stahl 
Date:   Fri Jan 19 21:23:51 2018 +0100

gbuild: always compile as C++17 with MSVC 2017

The current update MSVC 2017.5 supports fancy new C++ features, but
unfortunately in its default C++14 mode it falls over and dies with
an internal compiler error as soon as it sees the WeakImplHelper
variadic template.

In order to work around the ICE, build everything as C++17,
which somehow doesn't crash.

This causes loads of deprecation warnings about obsolete std::this
and badly designed std::that, almost all of them from boost headers,
which are well known for following every best practice in the C++ book.

Liberally sprinkle macros around to suppress the warnings for now,
like we already do with the other million warnings from boost headers.

Change-Id: Ia6b6ef5e457b5fe3c8cfe361ba5da39376bb7c4c
Reviewed-on: https://gerrit.libreoffice.org/48225
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/desktop/source/app/sofficemain.cxx 
b/desktop/source/app/sofficemain.cxx
index 657614962489..e27b48d8b93a 100644
--- a/desktop/source/app/sofficemain.cxx
+++ b/desktop/source/app/sofficemain.cxx
@@ -92,6 +92,9 @@ static bool dumpCallback(const wchar_t* path, const wchar_t* 
id,
 std::string ini_path = CrashReporter::getIniFileName();
 std::ofstream minidump_file(ini_path, std::ios_base::app);
 // TODO: moggi: can we avoid this conversion
+#ifdef _MSC_VER
+#pragma warning (disable: 4996)
+#endif
 std::wstring_convert conv1;
 std::string aPath = conv1.to_bytes(std::wstring(path)) + 
conv1.to_bytes(std::wstring(id)) + ".dmp";
 minidump_file << "DumpFile=" << aPath << "\n";
diff --git a/filter/Library_svgfilter.mk b/filter/Library_svgfilter.mk
index b8e52c73d9fe..e0d8ff37ccce 100644
--- a/filter/Library_svgfilter.mk
+++ b/filter/Library_svgfilter.mk
@@ -29,6 +29,13 @@ $(eval $(call gb_Library_add_defs,svgfilter,\
-DFILTER_DLLIMPLEMENTATION \
 ))
 
+ifeq ($(COM),MSC)
+$(eval $(call gb_Library_add_defs,svgfilter,\
+   -D_SILENCE_CXX17_ALLOCATOR_VOID_DEPRECATION_WARNING \
+   -D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING \
+))
+endif
+
 $(eval $(call gb_Library_set_include,svgfilter,\
 $$(INCLUDE) \
 -I$(SRCDIR)/filter/inc \
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 9e1432c0a8c3..9d04c29f0d3f 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -29,6 +29,13 @@ $(eval $(call gb_Library_add_defs,sc,\
 -DSC_INFO_OSVERSION=\"$(OS)\" \
 ))
 
+# there is an odd case of this about std::function in dataproviderdlg.cxx that 
resists more localised suppression
+ifeq ($(COM),MSC)
+$(eval $(call gb_Library_add_cxxflags,sc,\
+   -wd4121 \
+))
+endif
+
 $(eval $(call gb_Library_use_custom_headers,sc,\
 officecfg/registry \
 ))
diff --git a/sdext/Library_pdfimport.mk b/sdext/Library_pdfimport.mk
index 854f00c49248..7c11d36e42ba 100644
--- a/sdext/Library_pdfimport.mk
+++ b/sdext/Library_pdfimport.mk
@@ -35,6 +35,12 @@ $(eval $(call gb_Library_use_externals,pdfimport,\
 $(if $(filter-out WNT MACOSX,$(OS)),fontconfig) \
 ))
 
+ifeq ($(COM),MSC)
+$(eval $(call gb_Library_add_defs,pdfimport, \
+-D_SILENCE_CXX17_ALLOCATOR_VOID_DEPRECATION_WARNING \
+))
+endif
+
 $(eval $(call gb_Library_add_defs,pdfimport, \
 -DBOOST_SPIRIT_USE_OLD_NAMESPACE \
 -DBOOST_ALL_NO_LIB \
diff --git a/solenv/gbuild/platform/com_MSC_defs.mk 
b/solenv/gbuild/platform/com_MSC_defs.mk
index 507264e1db89..b276f2d5329e 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -47,6 +47,8 @@ gb_COMPILERDEFS := \
-DBOOST_ERROR_CODE_HEADER_ONLY \
-DBOOST_OPTIONAL_USE_OLD_DEFINITION_OF_NONE \
-DBOOST_SYSTEM_NO_DEPRECATED \
+   -D_HAS_AUTO_PTR_ETC \
+   -D_SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING \
-D_CRT_NON_CONFORMING_SWPRINTFS \
-D_CRT_NONSTDC_NO_DEPRECATE \
-D_CRT_SECURE_NO_DEPRECATE \
@@ -163,6 +165,7 @@ endif
 
 gb_CXXFLAGS := \
-utf-8 \
+   $(if $(filter-out 140,$(VCVER)),-std:c++17) \
-Gd \
-GR \
-Gs \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 108440] [META] Database form bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108440

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115099


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115099
[Bug 115099] Pattern Field: Improve property names related to the masking
operation.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115099] Pattern Field: Improve property names related to the masking operation.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115099

Thomas Lendo  changed:

   What|Removed |Added

 Blocks||108440, 102019


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
[Bug 102019] [META] Dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108440
[Bug 108440] [META] Database form bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019

Thomas Lendo  changed:

   What|Removed |Added

 Depends on||115099


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115099
[Bug 115099] Pattern Field: Improve property names related to the masking
operation.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Michael Stahl]

 sw/source/filter/html/htmlctxt.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 0b1f8cb4a7eca3ab5b55c1866ef2761398d1ae95
Author: Michael Stahl 
Date:   Mon Jan 22 19:54:03 2018 +0100

sw: add an assert wrt. recent bug in SwHTMLParser::SplitAttrTab()

Change-Id: I1fa64beb4724675c2e23bd5d4f0766f6d4cf7873

diff --git a/sw/source/filter/html/htmlctxt.cxx 
b/sw/source/filter/html/htmlctxt.cxx
index f166177fcabb..2ba75527b43b 100644
--- a/sw/source/filter/html/htmlctxt.cxx
+++ b/sw/source/filter/html/htmlctxt.cxx
@@ -131,6 +131,9 @@ void SwHTMLParser::SplitAttrTab( const SwPosition& rNewPos )
 m_aParaAttrs.clear();
 
 const SwNodeIndex* pOldEndPara = _pPam->GetPoint()->nNode;
+#ifndef NDEBUG
+auto const nOld(pOldEndPara->GetIndex());
+#endif
 sal_Int32 nOldEndCnt = m_pPam->GetPoint()->nContent.GetIndex();
 
 const SwNodeIndex& rNewSttPara = rNewPos.nNode;
@@ -215,6 +218,7 @@ void SwHTMLParser::SplitAttrTab( const SwPosition& rNewPos )
 if( bMoveBack )
 m_pPam->Move( fnMoveForward );
 
+assert(m_pPam->GetPoint()->nNode.GetIndex() == nOld);
 }
 
 void SwHTMLParser::SaveDocContext( HTMLAttrContext *pCntxt,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits