[Libreoffice-commits] core.git: ios/CustomTarget_iOS_link.mk ios/LibreOfficeLight ios/source

[Jon Nermut]

 ios/CustomTarget_iOS_link.mk|1 
 ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj |   49 
--
 ios/LibreOfficeLight/LibreOfficeLight/LOKit/LibreOfficeKitWrapper.swift |5 
-
 ios/source/LibreOfficeKit.c |7 
-
 ios/source/LibreOfficeKit.h |2 
 5 files changed, 49 insertions(+), 15 deletions(-)

New commits:
commit 671e67dfc24205a133dbbaf87bc7be9f3af56b3a
Author: Jon Nermut 
Date:   Wed Jan 24 22:00:52 2018 +1100

iOS: linker changes for on device

[ae490dd] iOS: add script to sym link the dylib to the right spot

Adds a shell script to symlink the right dylib into the build products 
folder,
which means we can reference libKit.dylib relative to that, rather than 
absolutely

[ba4c072] iOS: pass in user path

On device using appPath/user as the user directory causes a crash, as an 
app cannot write inside it's bundle. Instead, add a new param to pass the 
documents dir into the init.

[088ad49] iOS: linker changes to run on device

Change-Id: I16f5d85f3ca483df11b82108ee39c4ec461214f4
Reviewed-on: https://gerrit.libreoffice.org/48866
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/ios/CustomTarget_iOS_link.mk b/ios/CustomTarget_iOS_link.mk
index ab5ad721d8d7..ef6303a217d8 100644
--- a/ios/CustomTarget_iOS_link.mk
+++ b/ios/CustomTarget_iOS_link.mk
@@ -51,6 +51,7 @@ $(IOSKIT): $(IOSOBJ) $(IOSLIBS)
$(gb_CC) -dynamiclib \
-Xlinker -rpath -Xlinker @executable_path/Frameworks \
-Xlinker -rpath -Xlinker @loader_path/Frameworks \
+-install_name @rpath/libKit.dylib \
-dead_strip \
-Xlinker -export_dynamic \
-Xlinker -no_deduplicate \
diff --git a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj 
b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
index 856d8b353bfb..4310b7862e3b 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
+++ b/ios/LibreOfficeLight/LibreOfficeLight.xcodeproj/project.pbxproj
@@ -13,7 +13,6 @@
39022C211EDC2D0800100066 /* icudt60l.dat in Resources */ = {isa 
= PBXBuildFile; fileRef = 39022C201EDC2D0800100066 /* icudt60l.dat */; };
39284DB31FA5F207006F43E4 /* DocumentActions.swift in Sources */ 
= {isa = PBXBuildFile; fileRef = 39284DB21FA5F207006F43E4 /* 
DocumentActions.swift */; };
392ED9B31E5E4B03005C8435 /* ViewPrintManager.swift in Sources 
*/ = {isa = PBXBuildFile; fileRef = 392ED9B21E5E4B03005C8435 /* 
ViewPrintManager.swift */; };
-   396C833F1FC9D89E008E662A /* libKit.dylib in Frameworks */ = 
{isa = PBXBuildFile; fileRef = 396C833E1FC9D89D008E662A /* libKit.dylib */; };
396F92F71E7AE62400A28C82 /* Settings.bundle in Resources */ = 
{isa = PBXBuildFile; fileRef = 396F92F61E7AE62400A28C82 /* Settings.bundle */; 
};
397868D61E59A3EA007F9248 /* LaunchScreen.xib in Resources */ = 
{isa = PBXBuildFile; fileRef = 397868D81E59A3EA007F9248 /* LaunchScreen.xib */; 
};
397E08FE1E597BD8001374E0 /* AppDelegate.swift in Sources */ = 
{isa = PBXBuildFile; fileRef = 397E08FD1E597BD8001374E0 /* AppDelegate.swift 
*/; };
@@ -42,8 +41,24 @@
FCC2E4012004B65E00CEB504 /* example.odt in Resources */ = {isa 
= PBXBuildFile; fileRef = FCC2E4002004B65E00CEB504 /* example.odt */; };
FCC2E4032004B72700CEB504 /* Util.swift in Sources */ = {isa = 
PBXBuildFile; fileRef = FCC2E4022004B72700CEB504 /* Util.swift */; };
FCC2E4052004B74000CEB504 /* AsyncUtil.swift in Sources */ = 
{isa = PBXBuildFile; fileRef = FCC2E4042004B74000CEB504 /* AsyncUtil.swift */; 
};
+   FCC7651D201C7F8A007D190C /* libKit.dylib in Frameworks */ = 
{isa = PBXBuildFile; fileRef = FCC7651C201C7F8A007D190C /* libKit.dylib */; };
+   FCC7651E201C80A5007D190C /* libKit.dylib in Embed Libraries */ 
= {isa = PBXBuildFile; fileRef = FCC7651C201C7F8A007D190C /* libKit.dylib */; 
settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
 /* End PBXBuildFile section */
 
+/* Begin PBXCopyFilesBuildPhase section */
+   FC148CE420187F7800C349CA /* Embed Libraries */ = {
+   isa = PBXCopyFilesBuildPhase;
+   buildActionMask = 2147483647;
+   dstPath = "";
+   dstSubfolderSpec = 10;
+   files = (
+   FCC7651E201C80A5007D190C /* libKit.dylib in 
Embed Libraries */,
+   );
+   name = "Embed Libraries";
+   runOnlyForDeploymentPostprocessing = 0;
+   };
+/* End PBXCopyFilesBuildPhase section */
+
 /* Begin PBXFileReference section 

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - loolwsd.spec.in

[Andras Timar]

 loolwsd.spec.in |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 25ad77f4b728729572f30ef21a95e9220970f258
Author: Andras Timar 
Date:   Mon May 29 16:25:13 2017 +0200

package loolconfig to rpm

Change-Id: I04b8204fde23bd3c674ec622c959ff5ab7714d98
Reviewed-on: https://gerrit.libreoffice.org/38152
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 
(cherry picked from commit cbafebc58ac6f27696917ad7ee264ef6113614b8)
Reviewed-on: https://gerrit.libreoffice.org/48668
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/loolwsd.spec.in b/loolwsd.spec.in
index 4559930b..1c7b68db 100644
--- a/loolwsd.spec.in
+++ b/loolwsd.spec.in
@@ -96,6 +96,7 @@ echo "0 0 */1 * * root find /var/cache/loolwsd -name 
\"*.png\" -a -atime +10 -ex
 /usr/bin/loolmount
 /usr/bin/loolstress
 /usr/bin/looltool
+/usr/bin/loolconfig
 /usr/share/loolwsd/discovery.xml
 /usr/share/loolwsd/favicon.ico
 /usr/share/loolwsd/robots.txt
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - loleaflet/src

[Henry Castro]

 loleaflet/src/layer/marker/DivIcon.js |1 +
 1 file changed, 1 insertion(+)

New commits:
commit ed8214d92733754728721fc1f91e9e64f5dc7624
Author: Henry Castro 
Date:   Mon May 22 21:08:30 2017 -0400

loleaflet: prevent default context menu of the grab handles

Change-Id: I12ede87cb8207257470720c130913e3ab7e967dd
(cherry picked from commit 41c561233d60bbb32b084c8ced9345c82737f305)
Reviewed-on: https://gerrit.libreoffice.org/48667
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/loleaflet/src/layer/marker/DivIcon.js 
b/loleaflet/src/layer/marker/DivIcon.js
index c1e1cdd3..c2c7cb74 100644
--- a/loleaflet/src/layer/marker/DivIcon.js
+++ b/loleaflet/src/layer/marker/DivIcon.js
@@ -20,6 +20,7 @@ L.DivIcon = L.Icon.extend({
var div = (oldIcon && oldIcon.tagName === 'DIV') ? oldIcon : 
document.createElement('div'),
options = this.options;
 
+   L.DomEvent.on(div, 'contextmenu', L.DomEvent.preventDefault);
div.innerHTML = options.html !== false ? options.html : '';
 
if (options.bgPos) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - loleaflet/src

[Henry Castro]

 loleaflet/src/control/Control.ColumnHeader.js |1 +
 loleaflet/src/control/Control.RowHeader.js|1 +
 2 files changed, 2 insertions(+)

New commits:
commit 94954bf8ec5c7be581024f9c2b0f31677c456635
Author: Henry Castro 
Date:   Mon May 22 20:36:31 2017 -0400

loleaflet: prevent default context menu of the row/column resize area

Change-Id: I184a698fd63a0b3e83efb8c315ccca730d56112a
(cherry picked from commit 0ebedb7efac0ea311c0683cb918ce90ba31d096f)
Reviewed-on: https://gerrit.libreoffice.org/48666
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/loleaflet/src/control/Control.ColumnHeader.js 
b/loleaflet/src/control/Control.ColumnHeader.js
index d700742c..b79678fc 100644
--- a/loleaflet/src/control/Control.ColumnHeader.js
+++ b/loleaflet/src/control/Control.ColumnHeader.js
@@ -171,6 +171,7 @@ L.Control.ColumnHeader = L.Control.Header.extend({
column = L.DomUtil.create('div', 
'spreadsheet-header-column', this._columns);
text = L.DomUtil.create('div', 
'spreadsheet-header-column-text', column);
resize = L.DomUtil.create('div', 
'spreadsheet-header-column-resize', column);
+   L.DomEvent.on(resize, 'contextmenu', 
L.DomEvent.preventDefault);
column.size = columns[iterator].size;
var content = columns[iterator].text;
text.setAttribute('rel', 'spreadsheet-column-' + 
content); // for easy addressing
diff --git a/loleaflet/src/control/Control.RowHeader.js 
b/loleaflet/src/control/Control.RowHeader.js
index d5f702a1..c582117e 100644
--- a/loleaflet/src/control/Control.RowHeader.js
+++ b/loleaflet/src/control/Control.RowHeader.js
@@ -162,6 +162,7 @@ L.Control.RowHeader = L.Control.Header.extend({
row = L.DomUtil.create('div', 'spreadsheet-header-row', 
this._rows);
text = L.DomUtil.create('div', 
'spreadsheet-header-row-text', row);
resize = L.DomUtil.create('div', 
'spreadsheet-header-row-resize', row);
+   L.DomEvent.on(resize, 'contextmenu', 
L.DomEvent.preventDefault);
row.size = rows[iterator].size;
var content = rows[iterator].text;
text.setAttribute('rel', 'spreadsheet-row-' + content); 
// for easy addressing
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - wsd/LOOLWSD.cpp

[Ashod Nakashian]

 wsd/LOOLWSD.cpp |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5307fa09a686c5337efcc937113c37a898d434ab
Author: Ashod Nakashian 
Date:   Sun Jul 2 22:15:29 2017 -0400

wsd: don't resurrect forkit when shutting down

Change-Id: I88ebe5e07a5a9f6c0f52cb12e6acb688de763192
Reviewed-on: https://gerrit.libreoffice.org/39466
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 3582012333eceb7a9f5fceca28692ef086842fec)
Reviewed-on: https://gerrit.libreoffice.org/48676
Tested-by: Samuel Mehrbrodt 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index e6ebfac2..04309102 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -1023,7 +1023,7 @@ bool LOOLWSD::checkAndRestoreForKit()
 if (ForKitProcId == -1)
 {
 // Fire the ForKit process for the first time.
-if (!createForKit())
+if (!ShutdownRequestFlag && !TerminationFlag && !createForKit())
 {
 // Should never fail.
 LOG_FTL("Failed to spawn loolforkit.");
@@ -1052,7 +1052,7 @@ bool LOOLWSD::checkAndRestoreForKit()
 }
 
 // Spawn a new forkit and try to dust it off and resume.
-if (!createForKit())
+if (!ShutdownRequestFlag && !TerminationFlag && 
!createForKit())
 {
 LOG_FTL("Failed to spawn forkit instance. Shutting down.");
 SigUtil::requestShutdown();
@@ -1086,7 +1086,7 @@ bool LOOLWSD::checkAndRestoreForKit()
 {
 // No child processes.
 // Spawn a new forkit and try to dust it off and resume.
-if (!createForKit())
+if (!ShutdownRequestFlag && !TerminationFlag && !createForKit())
 {
 LOG_FTL("Failed to spawn forkit instance. Shutting down.");
 SigUtil::requestShutdown();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/core/doc/htmltbl.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit fd7ca0db5c2d5d1580d76c9536828a024543ea53
Author: Stephan Bergmann 
Date:   Mon Jan 29 16:02:44 2018 +0100

Clean up conversion to sal_uInt16

Change-Id: I95ecb0f68e737a25ff90437e82411d1e6eb42675
Reviewed-on: https://gerrit.libreoffice.org/48846
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/core/doc/htmltbl.cxx b/sw/source/core/doc/htmltbl.cxx
index 05b2cb1d192f..70e025869a74 100644
--- a/sw/source/core/doc/htmltbl.cxx
+++ b/sw/source/core/doc/htmltbl.cxx
@@ -17,6 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
 #include 
 #include 
 
@@ -365,7 +368,7 @@ sal_uInt16 SwHTMLTableLayout::GetBrowseWidthByTabFrame(
 rTabFrame.CalcFlyOffsets( nUpperDummy, nLeftOffset, nRightOffset );
 nWidth -= (nLeftOffset + nRightOffset);
 
-return nWidth < USHRT_MAX ? static_cast(nWidth) : USHRT_MAX;
+return static_cast(std::min(nWidth, SwTwips(SAL_MAX_UINT16)));
 }
 
 sal_uInt16 SwHTMLTableLayout::GetBrowseWidthByTable( const SwDoc& rDoc ) const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - 2 commits - loleaflet/dist wsd/ClientSession.cpp wsd/DocumentBroker.cpp

[Ashod Nakashian]

 loleaflet/dist/toolbar/toolbar.js |   10 +++---
 wsd/ClientSession.cpp |1 +
 wsd/DocumentBroker.cpp|2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)

New commits:
commit 256938351609d49fefa98118919f1eb048b9e215
Author: Ashod Nakashian 
Date:   Sun Jun 4 23:40:18 2017 -0400

Set EverModified on saving the document

When saving while editing a cell, the
document is saved with the new cell contents
(as the cell editing is interrupted and applied),
but the modified status is not published to the
client (loleaflet).

This has the unfortunate side-effect that the
EverModified flag is not set in this scenario.

To avoid this, this patch sets the EverModified
upon successful saving. This is easier than
forcing LO Core to emit ModifiedStatus=true
in the scenario above. Though it suffers from
the false-positive result when the user forces
a save. Although this is probably defensible,
since technically the document changes upon
saving (though not the content if there was
nothing new to save). On the other hand,
it's less harmful to signal modification
due to save than to ignore genuine
modification to the document.

Change-Id: I7ccba62731f534b69819f7924eeb9231d874c111
Reviewed-on: https://gerrit.libreoffice.org/38398
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 80b6e9782421223f7abf84f4eb7e4c824804f67f)
Reviewed-on: https://gerrit.libreoffice.org/48671
Tested-by: Samuel Mehrbrodt 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index 7c9c56a0..9e505e9a 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -1413,10 +1413,14 @@ map.on('commandresult', function (e) {
var commandName = e.commandName;
 
if (commandName === '.uno:Save' && e.success === true) {
+   // Saved a new version; the document is modified.
+   map._everModified = true;
+
// owncloud integration
-   if (typeof window.parent.documentsMain !== 'undefined') {
-   window.parent.documentsMain.saveDocumentBack();
-   }
+   //FIXME: CSP Violation.
+   //if (typeof window.parent.documentsMain !== 'undefined') {
+   // window.parent.documentsMain.saveDocumentBack();
+   // }
}
else if ((commandName === '.uno:Undo' || commandName === '.uno:Redo') &&
e.success === true && e.result.value && !isNaN(e.result.value)) 
{ /*UNDO_CONFLICT*/
diff --git a/wsd/ClientSession.cpp b/wsd/ClientSession.cpp
index 1f454a69..ed044b56 100644
--- a/wsd/ClientSession.cpp
+++ b/wsd/ClientSession.cpp
@@ -536,6 +536,7 @@ bool ClientSession::handleKitToClientMessage(const char* 
buffer, const int lengt
 // Save to Storage and log result.
 std::string id = getId();
 docBroker->saveToStorage(id, success, result);
+forwardToClient(payload);
 return true;
 }
 }
commit 915465c5a2aba7a5f63b8b0d888f21c4bff85c83
Author: Ashod Nakashian 
Date:   Sun May 21 19:13:55 2017 -0400

Correctly send termination reason to clients

Fixes the case when the client reconnects on idle
disconnection (because it never got the 'close: idle'
message).

Also, show informative message to users in this case
instead of grey screen.

Change-Id: Ia2e1f2ffefe6d35dd1552e7cc44e490aab86c600
Reviewed-on: https://gerrit.libreoffice.org/37891
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 407c538f046f9245661a77e2452779c465b75087)
Reviewed-on: https://gerrit.libreoffice.org/48623
Tested-by: Samuel Mehrbrodt 

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index c0067334..6dd12f1c 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -246,7 +246,7 @@ void DocumentBroker::pollThread()
 if (ShutdownRequestFlag)
 {
 closeReason = "recycling";
-_stop = true;
+shutdownClients(closeReason);
 }
 else if (AutoSaveEnabled && !_stop &&
  std::chrono::duration_cast(now - 
last30SecCheckTime).count() >= 30)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 46892] Provide stacktraces for crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46892

Ekansh Jha  changed:

   What|Removed |Added

 CC||jhaekans...@gmail.com

--- Comment #12 from Ekansh Jha  ---
Created attachment 139446
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139446=edit
Backtrace on linux

Hi, as suggested in
https://bugs.documentfoundation.org/show_bug.cgi?id=46892#c7 i tried to produce
the backtrace on linux. Please let me know if this can be of any use. 
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92222] FILESAVE: Shapes Line Weigh(Width) changed on round trip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=9

Luke  changed:

   What|Removed |Added

 CC|tima...@gmail.com   |
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||1786

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 55956] FILESAVE: Circular Arrow broken after save as PPT & reopening

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=55956

--- Comment #12 from Pierre Martineau  ---
The bug is still present in the last libreoffice version. Of note, export in
pptx is a bit better but the arrow is still not identical to the original

Tested in 

Version: 5.4.4.2
Build ID: 2524958677847fb3bb44820e40380acbe820f960
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: GL; 
Locale: fr-FR (fr.UTF-8); Calc: group

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: GL; 
Locale: fr-FR (fr.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63388] MAILMERGE: LibreOffice freezes when clicking Test Settings button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63388

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   Hardware|Other   |All

--- Comment #39 from Justin L  ---
Thanks to Jurassic Pork (comment 21) and prrychr (tdf#99363) for the 2016
patch. 

A few related changes have resulted in this situation for LO 6.1
-secure SMTP is now default with port 587 (StartTLS).
-POP3/IMAP also default to secure ports.
-Port 465 uses smtp_ssl (regardless of the setting labeled SSL, but which
actually implements StartTLS in the case of SMTP). SO, PORT 465 IS THE ONLY
PORT THAT LIBREOFFICE CAN USE FOR SSL SMTP.

So, I think this will take care of most of the concerns mentioned in this
report. I'm not going to mark this one as resolved since there are so many
different angles in this bug.

Todo:
1) The term "SSL" is correct for POP3/IMAP settings in the authentication
portion (right?), but for SMTP, "SSL" is different (and incompatible) with
"StartTLS". Consider the three-way logic of comment 18.

2) test smtp_ssl works on the shipping version of python (comment 32, 33, 34).
It works for me in Ubuntu 16.04 / 18.04.

3) LibreOffice freezes when clicking Test Settings button. That is the title of
this bug, although there was very little in the discussion about this specific
aspect.

If, after testing 6.1, there are still concerns about any of these topics, I
recommend opening a new bug about that one particular topic, and linking it
back to this report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

[Noel Grandin]

 sw/inc/EnhancedPDFExportHelper.hxx  |2 
 sw/inc/IDocumentContentOperations.hxx   |4 -
 sw/inc/IDocumentFieldsAccess.hxx|2 
 sw/inc/authfld.hxx  |6 -
 sw/inc/crsrsh.hxx   |   16 ++--
 sw/inc/dbfld.hxx|4 -
 sw/inc/dbmgr.hxx|2 
 sw/inc/ddefld.hxx   |4 -
 sw/inc/doc.hxx  |   16 ++--
 sw/inc/docary.hxx   |4 -
 sw/inc/editsh.hxx   |   29 +++-
 sw/inc/expfld.hxx   |4 -
 sw/inc/fesh.hxx |   22 +++---
 sw/inc/fldbas.hxx   |4 -
 sw/inc/flddropdown.hxx  |5 -
 sw/inc/fmtcol.hxx   |2 
 sw/inc/hhcwrp.hxx   |2 
 sw/inc/ndtxt.hxx|2 
 sw/inc/pagepreviewlayout.hxx|   16 +---
 sw/inc/swabstdlg.hxx|2 
 sw/inc/swbaslnk.hxx |2 
 sw/inc/swtable.hxx  |2 
 sw/inc/tblafmt.hxx  |4 -
 sw/inc/txatritr.hxx |2 
 sw/inc/unochart.hxx |2 
 sw/inc/usrfld.hxx   |4 -
 sw/source/core/crsr/crsrsh.cxx  |9 +-
 sw/source/core/crsr/crstrvl.cxx |   13 +--
 sw/source/core/crsr/crstrvl1.cxx|4 -
 sw/source/core/crsr/trvlcol.cxx |5 -
 sw/source/core/crsr/trvlfnfl.cxx|5 -
 sw/source/core/doc/DocumentContentOperationsManager.cxx |7 --
 sw/source/core/doc/DocumentFieldsManager.cxx|4 -
 sw/source/core/doc/docbasic.cxx |4 -
 sw/source/core/doc/docfmt.cxx   |7 --
 sw/source/core/doc/docredln.cxx |8 --
 sw/source/core/doc/fmtcol.cxx   |6 -
 sw/source/core/doc/tblafmt.cxx  |   14 +---
 sw/source/core/doc/tblrwcl.cxx  |6 -
 sw/source/core/docnode/ndtbl.cxx|   42 
 sw/source/core/edit/autofmt.cxx |3 
 sw/source/core/edit/edattr.cxx  |4 -
 sw/source/core/edit/edglbldc.cxx|   16 +---
 sw/source/core/edit/editsh.cxx  |3 
 sw/source/core/edit/ednumber.cxx|   11 +--
 sw/source/core/edit/edsect.cxx  |8 --
 sw/source/core/edit/edtab.cxx   |6 -
 sw/source/core/edit/edundo.cxx  |   15 +---
 sw/source/core/fields/authfld.cxx   |   11 +--
 sw/source/core/fields/dbfld.cxx |6 -
 sw/source/core/fields/ddefld.cxx|6 -
 sw/source/core/fields/expfld.cxx|6 -
 sw/source/core/fields/fldbas.cxx|6 -
 sw/source/core/fields/flddropdown.cxx   |4 -
 sw/source/core/fields/usrfld.cxx|6 -
 sw/source/core/frmedt/fecopy.cxx|   19 +
 sw/source/core/frmedt/fefly1.cxx|   11 ---
 sw/source/core/frmedt/feshview.cxx  |5 -
 sw/source/core/frmedt/fetab.cxx |   54 ++--
 sw/source/core/inc/DocumentContentOperationsManager.hxx |4 -
 sw/source/core/inc/DocumentFieldsManager.hxx|2 
 sw/source/core/inc/cntfrm.hxx   |2 
 sw/source/core/inc/frame.hxx|2 
 sw/source/core/inc/layact.hxx   |4 -
 sw/source/core/inc/scriptinfo.hxx   |2 
 sw/source/core/inc/sortedobjs.hxx   |4 -
 sw/source/core/inc/txtfly.hxx   |2 
 sw/source/core/layout/calcmove.cxx  |6 -
 sw/source/core/layout/dbg_lay.cxx   |   15 ++--
 sw/source/core/layout/layact.cxx|   17 +
 sw/source/core/layout/laycache.cxx  |9 --
 sw/source/core/layout/layhelp.hxx   |4 -
 sw/source/core/layout/sortedobjs.cxx|   15 +---
 sw/source/core/ole/ndole.cxx|2 
 sw/source/core/text/EnhancedPDFExportHelper.cxx  

[Libreoffice-bugs] [Bug 114466] Certain Document in Use dialog does not get focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114466

--- Comment #16 from V Stuart Foote  ---
With Mike K's commits of comment 14 and comment 15 none of the STR, including
via command line launch of comment 3, fail. All seems correct now on Windows...

Aron?

=-testing-=
Windows 10 Pro 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 3deac9691011711a3b9e50d19499c588af074d7f
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-01-30_03:11:54
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49134] On opening a password-protected file, the LibreOffice dialog is not raised/given focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49134

--- Comment #27 from V Stuart Foote  ---
(In reply to Commit Notification from comment #25)
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=3b57cb72ec8b47f033be5a516617ed8c752517b0
> 
> tdf#32935 tdf#49134 tdf#114466 Activate newly opened modal dialogs
> 

And for Windows with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d1d82dd63eada8faa2f6eb43ef900764a5fda62

tdf#49134 tdf#114466 Transfer privilege to become foreground process

Seems correct on Windows builds...

=-testing-=
Windows 10 Pro 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 3deac9691011711a3b9e50d19499c588af074d7f
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-01-30_03:11:54
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 32935] CSV import dialog doesn' t get focus if libreoffice is already running

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=32935

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #50 from V Stuart Foote  ---
(In reply to Commit Notification from comment #49)
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=3b57cb72ec8b47f033be5a516617ed8c752517b0
> 
> tdf#32935 tdf#49134 tdf#114466 Activate newly opened modal dialogs
> 

Functions correctly in Windows builds...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105222] TIMEVALUE (ORARIO.VALORE in IT) Calc function incorrect/ lack of help documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105222

Buovjaga  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #5 from Buovjaga  ---
Yep, let's keep as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105221] TIME (ORARIO in IT) Calc function incorrect help documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105221

Buovjaga  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #5 from Buovjaga  ---
Yep, let's keep as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114864] Changing the Image angle with the angle rotation tool is sometimes a bit laggy and causes high CPU utilization

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114864

Buovjaga  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com

--- Comment #5 from Buovjaga  ---
(In reply to Telesto from comment #4)
> (In reply to Buovjaga from comment #3)
> > (In reply to Telesto from comment #2)
> > > Hmm, probably not a bug in hindsight. The rotation is mostly directly
> > > applied to the image, for example when doing this using the toolbar 
> > > instead.
> 
> The dialog could (speculation) be using the same code as the real-time
> preview is the new Sidebar rotation tool. Which would mean that a real-time
> preview is generated somewhere in the background..

Your speculation turned out to be correct as the rotation tool is not in the
dialog yet in 5.4.

Adding Armin to CC: I wonder why there is not a real-time preview when using
the image properties dialog yet it still hammers the CPU?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Mike Kaganski  changed:

   What|Removed |Added

 Depends on||115278


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115278
[Bug 115278] RTF import: auto color is imported as black
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81234] [META] RTF filter issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=81234

Mike Kaganski  changed:

   What|Removed |Added

 Depends on||115276


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=115276
[Bug 115276] RTF import: \expnd control word imports 25 times smaller than
ought to
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88611] LENB & co. wrong value for Cyrillic text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88611

Urmas  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|INSUFFICIENTDATA|---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46633] FILESAVE RTF exporter saves corrupted ANSI data

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46633

Urmas  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115306] Insert digitalized image fail

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115306

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 114635 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115297] FILESAVE: PDF: Images are displayed as black boxes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115297

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 OS|All |Linux (All)

--- Comment #3 from V Stuart Foote  ---
Not reproducible on Windows builds. To PDF exports the bitmaps cleanly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95843] Headless mode leaves zombie process

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95843

--- Comment #15 from ufa...@gmail.com ---
My command is:

/opt/libreoffice4.4/program/soffice.bin --nofirststartwizard --invisible
--headless --norestore --nologo --nodefault
--accept=socket,host=localhost,port=8100;urp;

The enviroment is indeed X-less

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: scripting/source

[Justin Luth]

 scripting/source/pyprov/mailmerge.py |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 036b51dbc49b533d1db773d8627d56ab86bca487
Author: Justin Luth 
Date:   Thu Jan 18 12:30:58 2018 +0300

tdf#63388: use SMTP_SSL for port 465

Thanks to Jurassic Pork and prrychr (tdf#99363) for the 2016 patch.
I used smtp.gmail.com as my testing server.

Port 587 is the "official" port to use for encrypted email.
I confirmed that 587 CANNOT use SMTP_SSL [SSL: UNKNOWN_PROTOCOL],
so I limited SMTP_SSL use to common TLS port 465 only.

Port 465 was temporarily recommended, but OFFICIALLY has long
since been abandoned. However, LOTS of documentation and ISPs still
recommend it as the port to use. I confirmed that 465 DOES NOT
support STARTTLS, so it is specifically excluded.

So, technically the button should say use STARTTLS instead of SSL,
but only for SMTP. IMAP/POP do use SSL, so terminology gets
rather confusing. This patch forces SSL without STARTTLS for port 465
regardless of the "use SSL" setting due to all the confusion.

Currently we don't support ANY SSL/TLS connections. With this patch
we now at least support the extremely common use case of port 465.

Change-Id: I210cc307491157c1121cfffd70cbb94347ee2856
Reviewed-on: https://gerrit.libreoffice.org/48210
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/scripting/source/pyprov/mailmerge.py 
b/scripting/source/pyprov/mailmerge.py
index ca18c7b17227..079744007816 100644
--- a/scripting/source/pyprov/mailmerge.py
+++ b/scripting/source/pyprov/mailmerge.py
@@ -104,7 +104,10 @@ class PyMailSMTPService(unohelper.Base, XSmtpService):
tout = _GLOBAL_DEFAULT_TIMEOUT
if dbg:
print("Timeout: " + str(tout), file=dbgout)
-   self.server = smtplib.SMTP(server, port,timeout=tout)
+   if port == 465:
+   self.server = smtplib.SMTP_SSL(server, 
port,timeout=tout)
+   else:
+   self.server = smtplib.SMTP(server, port,timeout=tout)
 
#stderr not available for us under windows, but
#set_debuglevel outputs there, and so throw
@@ -116,7 +119,7 @@ class PyMailSMTPService(unohelper.Base, XSmtpService):
connectiontype = 
xConnectionContext.getValueByName("ConnectionType")
if dbg:
print("ConnectionType: " + connectiontype, file=dbgout)
-   if connectiontype.upper() == 'SSL':
+   if connectiontype.upper() == 'SSL' and port != 465:
self.server.ehlo()
self.server.starttls()
self.server.ehlo()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 63388] MAILMERGE: LibreOffice freezes when clicking Test Settings button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63388

--- Comment #38 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=036b51dbc49b533d1db773d8627d56ab86bca487

tdf#63388: use SMTP_SSL for port 465

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63388] MAILMERGE: LibreOffice freezes when clicking Test Settings button

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63388

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|BSA |BSA target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105586] Do not remove end point of closed Bézier =?UTF-8?Q?=20curve?=, if start point = end point

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105586

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92091] Renders some Persian texts wrongly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92091

--- Comment #6 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67473] UI: wrong help text displayed in function wizard list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67473

--- Comment #10 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114402] Some ruled lines in the cell adjacent to the merged cell are not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114402

--- Comment #15 from Junichi Matsukawa  ---
Hi. Xisco Faulí.

Thanks for your information.

I tested LBO6.1.0.0alpha0+.

reproduced on
master~2018-01-26_01.35.37_LibreOfficeDev_6.1.0.0.alpha0_Win_x86_en-US_de_ar_ja_ru_vec_qtz.


Do not reproduced on
libo-master~2018-01-29_23.50.45_LibreOfficeDev_6.1.0.0.alpha0_Win_x86.

Version: 6.1.0.0.alpha0+
Build ID: 25399354e327f09360766f16d446b6c02c92d045
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-01-29_23:50:45
Locale: ja-JP (ja_JP); Calc: threaded


I confirmed the bug has been solved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115306] New: Insert digitalized image fail

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115306

Bug ID: 115306
   Summary: Insert digitalized image fail
   Product: LibreOffice
   Version: 5.4.4.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: psoste...@yahoo.com.br

Description:
When we try to insert a scan image, nothing happens.


Steps to Reproduce:
1.Menu
2.Inserir
3.Multmidia
4.Solicitar

Actual Results:  
Nothing

Expected Results:
Open dialog from Scan Epson L375


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106326] Android: Change font / background color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106326

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106326] Android: Change font / background color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106326

--- Comment #4 from Commit Notification 
 ---
Mert Tümer committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3deac9691011711a3b9e50d19499c588af074d7f

[Pardus] tdf#106326 ability to change font background color

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: android/source

[Mert Tümer]

 android/source/res/layout/activity_main.xml  |3 
 android/source/res/layout/toolbar_bottom.xml |   28 ++
 android/source/res/layout/toolbar_color_picker.xml   |1 
 android/source/src/java/org/libreoffice/FontController.java  |  138 
+-
 android/source/src/java/org/libreoffice/InvalidationHandler.java |2 
 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java |6 
 6 files changed, 166 insertions(+), 12 deletions(-)

New commits:
commit 3deac9691011711a3b9e50d19499c588af074d7f
Author: Mert Tümer 
Date:   Sun Jan 21 19:10:10 2018 +0300

[Pardus] tdf#106326 ability to change font background color

This patch is sponsored by ULAKBIM/PARDUS project.
Signed-off-by: Mert Tümer 

Change-Id: I4dfbb9e35214e4d4a9aa6dca1ce3d5d2604218a9
Reviewed-on: https://gerrit.libreoffice.org/48270
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/android/source/res/layout/activity_main.xml 
b/android/source/res/layout/activity_main.xml
index 9f53b4f5d3dd..c2528023d0f8 100644
--- a/android/source/res/layout/activity_main.xml
+++ b/android/source/res/layout/activity_main.xml
@@ -110,7 +110,8 @@
 
 
 
-
+
+
 
 
 
 
+
+
+
+
+
 
 
 
diff --git a/android/source/res/layout/toolbar_color_picker.xml 
b/android/source/res/layout/toolbar_color_picker.xml
index e34b6c6a5d72..9393259123be 100644
--- a/android/source/res/layout/toolbar_color_picker.xml
+++ b/android/source/res/layout/toolbar_color_picker.xml
@@ -3,7 +3,6 @@
 http://schemas.android.com/apk/res/android;
 xmlns:app="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
-android:id="@+id/toolbar_color_picker"
 android:layout_width="match_parent"
 android:layout_height="wrap_content"
 android:layout_alignParentBottom="true"
diff --git a/android/source/src/java/org/libreoffice/FontController.java 
b/android/source/src/java/org/libreoffice/FontController.java
index db87302cbd4a..04fc6ccaa234 100644
--- a/android/source/src/java/org/libreoffice/FontController.java
+++ b/android/source/src/java/org/libreoffice/FontController.java
@@ -28,7 +28,7 @@ public class FontController implements 
AdapterView.OnItemSelectedListener {
 
 private boolean mFontNameSpinnerSet = false;
 private boolean mFontSizeSpinnerSet = false;
-private Activity mActivity;
+private LibreOfficeMainActivity mActivity;
 private List mFontList = null;
 private List mFontSizes = new ArrayList();
 private Map mAllFontSizes = null;
@@ -36,12 +36,14 @@ public class FontController implements 
AdapterView.OnItemSelectedListener {
 private String mCurrentFontSelected = null;
 private String mCurrentFontSizeSelected = null;
 
-public FontController(Activity activity) {
+public FontController(LibreOfficeMainActivity activity) {
 mActivity = activity;
 }
 private BottomSheetBehavior colorPickerBehavior;
+private BottomSheetBehavior backColorPickerBehavior;
 private BottomSheetBehavior toolBarBottomBehavior;
 private ColorPickerAdapter colorPickerAdapter;
+private ColorPickerAdapter backColorPickerAdapter;
 
 ColorPaletteListener colorPaletteListener = new ColorPaletteListener() {
 @Override
@@ -52,8 +54,22 @@ public class FontController implements 
AdapterView.OnItemSelectedListener {
 @Override
 public void updateColorPickerPosition(int color) {
 if (null == colorPickerAdapter) return;
-colorPickerAdapter.findSelectedTextColor(color);
-changeFontColorBoxColor(color);
+colorPickerAdapter.findSelectedTextColor(color + 0xFF00);
+changeFontColorBoxColor(color + 0xFF00);
+}
+};
+
+ColorPaletteListener backColorPaletteListener = new ColorPaletteListener() 
{
+@Override
+public void applyColor(int color) {
+sendFontBackColorChange(color);
+}
+
+@Override
+public void updateColorPickerPosition(int color) {
+backColorPickerAdapter.findSelectedTextColor(color + 0xFF00);
+changeFontBackColorBoxColor(color + 0xFF00);
+
 }
 };
 
@@ -67,11 +83,27 @@ public class FontController implements 
AdapterView.OnItemSelectedListener {
 fontColorPickerButton.setBackgroundColor(Color.BLACK);
 }else{
 fontColorPickerButton.setBackgroundColor(color);
+}
+}
+});
+}
+
+private void 

[Libreoffice-commits] core.git: android/source

[Mert Tümer]

 android/source/res/menu/main.xml |5 +++
 android/source/res/values/strings.xml|1 
 android/source/src/java/org/libreoffice/LOKitTileProvider.java   |   14 
++
 android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java |6 

 android/source/src/java/org/libreoffice/ToolbarController.java   |3 ++
 5 files changed, 29 insertions(+)

New commits:
commit 976b48e9ee03e7bd36e0f99a8752aa06a337
Author: Mert Tümer 
Date:   Wed Jan 24 15:22:22 2018 +0300

[Pardus] tdf#112482 ability to add slides to impress

This patch is sponsored by ULAKBIM/PARDUS project.
Signed-off-by: Mert Tümer 

Change-Id: I3c8b55d032604b30117573ac447776a1a0e5205f
Reviewed-on: https://gerrit.libreoffice.org/48500
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/android/source/res/menu/main.xml b/android/source/res/menu/main.xml
index 9a4384af6fd5..432c374b3997 100644
--- a/android/source/res/menu/main.xml
+++ b/android/source/res/menu/main.xml
@@ -35,6 +35,11 @@
 
+
+
 
 
 
diff --git a/android/source/res/values/strings.xml 
b/android/source/res/values/strings.xml
index 5d7eca869a39..052389847f7c 100644
--- a/android/source/res/values/strings.xml
+++ b/android/source/res/values/strings.xml
@@ -136,6 +136,7 @@
 
 
 Slide show
+Add Slide
 Your Android device 
doesn\'t support in-app svg slideshow. We copied the slideshow link to 
clipboard. Please press home button, open a modern web browser, paste in the 
address bar, and go.
 OK
 Back
diff --git a/android/source/src/java/org/libreoffice/LOKitTileProvider.java 
b/android/source/src/java/org/libreoffice/LOKitTileProvider.java
index a68f65221795..e7b80782f0b8 100644
--- a/android/source/src/java/org/libreoffice/LOKitTileProvider.java
+++ b/android/source/src/java/org/libreoffice/LOKitTileProvider.java
@@ -114,6 +114,7 @@ class LOKitTileProvider implements TileProvider {
 
 if (mDocument.getDocumentType() == Document.DOCTYPE_PRESENTATION) {
 
mContext.getToolbarController().disableMenuItem(R.id.action_presentation, 
false);
+
mContext.getToolbarController().disableMenuItem(R.id.action_add_slide, false);
 }
 
 // Writer documents always have one part, so hide the navigation 
drawer.
@@ -160,6 +161,19 @@ class LOKitTileProvider implements TileProvider {
 });
 }
 
+public void addPart(){
+int parts = mDocument.getParts();
+LOKitShell.sendEvent(new LOEvent(LOEvent.UNO_COMMAND, 
".uno:InsertPage"));
+String partName = mDocument.getPartName(parts);
+if (partName.isEmpty()) {
+partName = getGenericPartName(parts);
+}
+mDocument.setPart(parts);
+resetDocumentSize();
+final DocumentPartView partView = new DocumentPartView(parts, 
partName);
+mContext.getDocumentPartView().add(partView);
+}
+
 @Override
 public void saveDocumentAs(String filePath, String format) {
 final String newFilePath = "file://" + filePath;
diff --git 
a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java 
b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
index 0b3f8b8e0e06..91722fa98d35 100644
--- a/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
+++ b/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java
@@ -685,6 +685,12 @@ public class LibreOfficeMainActivity extends 
AppCompatActivity implements Settin
 aboutDialogFragment.show(getSupportFragmentManager(), 
"AboutDialogFragment");
 }
 
+public void addSlide(){
+mTileProvider.addPart();
+mDocumentPartViewListAdapter.notifyDataSetChanged();
+setDocumentChanged(true);
+}
+
 public void showSettings() {
 startActivity(new Intent(getApplicationContext(), 
SettingsActivity.class));
 }
diff --git a/android/source/src/java/org/libreoffice/ToolbarController.java 
b/android/source/src/java/org/libreoffice/ToolbarController.java
index 9ef994d271a9..b8faae379f83 100644
--- a/android/source/src/java/org/libreoffice/ToolbarController.java
+++ b/android/source/src/java/org/libreoffice/ToolbarController.java
@@ -135,6 +135,9 @@ public class ToolbarController implements 
Toolbar.OnMenuItemClickListener {
 case R.id.action_presentation:
 mContext.preparePresentation();
 return true;
+case R.id.action_add_slide:
+mContext.addSlide();
+return true;
 }
 return false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112482] Ability to add slides on Impress on Android Viewer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112482

--- Comment #2 from Commit Notification 
 ---
Mert Tümer committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=976b48e9ee03e7bd36e0f99a8752aa06a337

[Pardus] tdf#112482 ability to add slides to impress

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112482] Ability to add slides on Impress on Android Viewer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112482

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Google Summer of Code 2018

[Markus Mohrhard]

Hey,

On Mon, Jan 29, 2018 at 9:52 PM, Rushabh Kapadia 
wrote:

> Hi,
>  I am a computer science student at VJTI, Mumbai and I am interested
> in applying for GSOC 2018.
>  I went through the organisations and the projects that were submitted
> last year and found the projects submitted by your organisation appealing.
>  Just wanted to enquire whether you would be participating this year
> as well and if yes, then what would be the projects for this year.
>   Thank you for your time and please let me know if LibreOffice is
> planning to participate this year.
>

First note that GSoC organization selection has not been completed and that
organization announcement is only in mid of February. However this should
not stop you getting involved as starting early usually leads to better
proposals and better chances of showing your skills through Easy Hacks.

Our project ideas list can be found at
https://wiki.documentfoundation.org/Development/GSoC/Ideas and some general
information about GSoC at LibreOffice at
https://wiki.documentfoundation.org/Development/GSoC. (Note that only the
organization application info have been updated for 2018 yet).

You should start by cloning LibreOffice and building the first time. After
that start with an Easy Hack in an area that looks interesting to you.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 114402] Some ruled lines in the cell adjacent to the merged cell are not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114402

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #14 from Xisco Faulí  ---


*** This bug has been marked as a duplicate of bug 113751 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115166] LO does not honour the "stealth mode" for an HTML document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115166

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5044

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSoC ideas page needing updates

[Markus Mohrhard]

Hello fellow hackers,

please update the GSoC ideas page as soon as possible. Here is a quote from
a GSoC email that was sent to the GSoC admins yesterday:

"It seems quite a few veteran orgs have 0, or very few, projects listed on
their Ideas List for their GSoC Org apps. Some have something like "coming
soon" with no actual ideas on their page - *this will result in an
automatic rejection* - please don't let that be you!

Our team has been reviewing hundreds of applications this week and taking
notes and we have noticed MANY orgs that have not completed their lists
(have 1-2 ideas or ideas with 1 sentence describing the problem) or say
'coming in March', 'coming soon', etc. That's a 'Reject in our book."


This is a strong reminder that without a good ideas list we are always
risking not being selected. So please check your project ideas and update
them, remove old items and add new ideas with details.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

[Vasily Melenchuk]

 sc/source/ui/docshell/externalrefmgr.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 8b98991a66197a71953dbb900dc3aece6b4f9e3a
Author: Vasily Melenchuk 
Date:   Tue Jan 23 13:59:01 2018 +0300

tdf#115044: do not load external documents if it is not allowed

Referenced external document data can be loaded after user
permission from dialog or corresponding settings.

Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592
Reviewed-on: https://gerrit.libreoffice.org/48398
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/docshell/externalrefmgr.cxx 
b/sc/source/ui/docshell/externalrefmgr.cxx
index 561d1c6fc60b..9af84ece7e3d 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -2365,6 +2365,15 @@ ScDocument* 
ScExternalRefManager::getInMemorySrcDocument(sal_uInt16 nFileId)
 if (!pFileName)
 return nullptr;
 
+// Do not load document until it was allowed
+SfxObjectShell* pDocShell = mpDoc->GetDocumentShell();
+if ( pDocShell )
+{
+const comphelper::EmbeddedObjectContainer& rContainer = 
pDocShell->GetEmbeddedObjectContainer();
+if ( !rContainer.getUserAllowsLinkUpdate() )
+return nullptr;
+}
+
 ScDocument* pSrcDoc = nullptr;
 ScDocShell* pShell = 
static_cast(SfxObjectShell::GetFirst(checkSfxObjectShell,
 false));
 while (pShell)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114402] Some ruled lines in the cell adjacent to the merged cell are not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114402

Junichi Matsukawa  changed:

   What|Removed |Added

Version|6.0.0.2 rc  |6.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114402] Some ruled lines in the cell adjacent to the merged cell are not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114402

--- Comment #13 from Junichi Matsukawa  ---
Created attachment 139445
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139445=edit
LBO6.0.0.3 Calc reproduced

I tested LBO6.0.0.3 Calc.
I installed 6.0.0.3 on Separate install GUI. 
I reproduced the bug at the sample001.ods.

Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: ja-JP (ja_JP); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Next QA meeting: Jan 30 at 16:00 UTC

[Xisco Fauli]

Hello,

Kindly Reminder: Next QA meeting will take place tomorrow Tue, Jan 30
at 16:00 UTC in the IRC channel #libreoffice-qa. More information:
https://wiki.documentfoundation.org/QA/IRC

If you have any topic you want to discuss during the meeting,
please reply to this email or mention it at the beginning of the meeting.

Regards 

-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 104742] [META] Network-involved bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104742
Bug 104742 depends on bug 114412, which changed state.

Bug 114412 Summary: LibreOffice won't open files on a network drive with just a 
click in file explorer from a cold start
https://bugs.documentfoundation.org/show_bug.cgi?id=114412

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114412] LibreOffice won' t open files on a network drive with just a click in file explorer from a cold start

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114412

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Xisco Faulí  ---
Closing as RESOLVED WORKSFORME then.
Thanks for retesting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114229] Basic -timeserial function minutes outside the range 0-59

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114229

--- Comment #9 from Mike Kaganski  ---
This should be NEW - but clear spec is required.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115304] EDITING: Calc Hide Columns, cannot Show Columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115304

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #4 from Regina Henschel  ---
It is not intuitive, that you need to select something in the hidden columns.
So may be it is an enhancement request for a better UI. Because there exist
already a similar enhancement request in bug 81480, closing this bug is OK. If
you have a nice idea for improving the UI, add it to bug 81480.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

[Andrea Gelmini]

 svx/source/dialog/framelinkarray.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 25399354e327f09360766f16d446b6c02c92d045
Author: Andrea Gelmini 
Date:   Mon Jan 29 23:18:27 2018 +0100

Fix typo

Change-Id: I8204875e480356cdb5ce7bc26996884eb1f4c131
Reviewed-on: https://gerrit.libreoffice.org/48859
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/svx/source/dialog/framelinkarray.cxx 
b/svx/source/dialog/framelinkarray.cxx
index 3367fd9dac54..e795710ae31d 100644
--- a/svx/source/dialog/framelinkarray.cxx
+++ b/svx/source/dialog/framelinkarray.cxx
@@ -862,7 +862,7 @@ basegfx::B2DRange Array::GetCellRange( size_t nCol, size_t 
nRow, bool bExpandMer
 // probably *should* be included in the above extended
 // GetColPosition/GetColWidth already. This might be
 // added due to GetColPosition/GetColWidth not working
-// correcly over PageChanges (if used), but not sure.
+// correctly over PageChanges (if used), but not sure.
 aRect.Left() -= rCell.mnAddLeft;
 aRect.Right() += rCell.mnAddRight;
 aRect.Top() -= rCell.mnAddTop;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115304] EDITING: Calc Hide Columns, cannot Show Columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115304

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #3 from m.a.riosv  ---
Also it possible to enter any address of the columns(s) to show in the address
box (at the left of the formula bar) and use Menu/Format/Columns-Show.

For me not a bug, please if you are not agree, reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115234] Suggest - Implement indent a text on the right - LibreOffice Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115234

--- Comment #2 from Leandro Battista  ---
Thank you very much Miguel! I thought LibreOffice could not do the same thing
that Microsoft Excel, but I was wrong. Sorry!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/core/data/documen8.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit e29565272c57c6cd09cb015c2e66bfe8a1f4d7d2
Author: Eike Rathke 
Date:   Mon Jan 29 23:51:46 2018 +0100

Revert "Let CheckLinkFormulaNeedingCheck() return early if found"

This reverts commit b124ce5d4dbaaba66e4f347964e97ebe788af4f5.

Short circuit in author's brain.

Change-Id: Iecd1d4f6a9f5ddb1251551e873f2c381973fc25b

diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 172d127cc517..eb58eb080213 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -1186,18 +1186,12 @@ void ScDocument::CheckLinkFormulaNeedingCheck( const 
ScTokenArray& rCode )
 if (rCode.GetCodeLen())
 {
 if (rCode.HasOpCodeRPN(ocDde) || rCode.HasOpCodeRPN(ocWebservice))
-{
 SetLinkFormulaNeedingCheck(true);
-return;
-}
 }
 else if (rCode.GetLen())
 {
 if (rCode.HasOpCode(ocDde) || rCode.HasOpCode(ocWebservice))
-{
 SetLinkFormulaNeedingCheck(true);
-return;
-}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/qa oox/source

[Szymon Kłos]

 chart2/qa/extras/chart2export.cxx |  159 ++
 oox/source/export/chartexport.cxx |  107 -
 2 files changed, 262 insertions(+), 4 deletions(-)

New commits:
commit bad41c8fe40e88e416631d61437e6abe5d00131d
Author: Szymon Kłos 
Date:   Sat Jan 27 20:29:38 2018 +0100

tdf#114821 export complex data labels in charts

Change-Id: I9b0893dfde4efc10bb05e6e17b7128b016efeb71
Reviewed-on: https://gerrit.libreoffice.org/48788
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index deedbc0bee7f..618a5b877af7 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -13,6 +13,8 @@
 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -102,6 +104,8 @@ public:
 void testAxisTitleRotationXLSX();
 void testAxisCrossBetweenXSLX();
 void testPieChartDataPointExplosionXLSX();
+void testCustomDataLabel();
+void testCustomDataLabelMultipleSeries();
 
 CPPUNIT_TEST_SUITE(Chart2ExportTest);
 CPPUNIT_TEST(testErrorBarXLSX);
@@ -168,6 +172,8 @@ public:
 CPPUNIT_TEST(testAxisTitleRotationXLSX);
 CPPUNIT_TEST(testAxisCrossBetweenXSLX);
 CPPUNIT_TEST(testPieChartDataPointExplosionXLSX);
+CPPUNIT_TEST(testCustomDataLabel);
+CPPUNIT_TEST(testCustomDataLabelMultipleSeries);
 CPPUNIT_TEST_SUITE_END();
 
 protected:
@@ -1572,6 +1578,159 @@ void 
Chart2ExportTest::testPieChartDataPointExplosionXLSX()
 assertXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:pieChart/c:ser/c:dPt/c:explosion", "val", 
"28");
 }
 
+void Chart2ExportTest::testCustomDataLabel()
+{
+load("/chart2/qa/extras/data/pptx/", "tdf115107.pptx");
+xmlDocPtr pXmlDoc = parseExport("ppt/charts/chart1", "Impress MS 
PowerPoint 2007 XML");
+CPPUNIT_ASSERT(pXmlDoc);
+
+Reference xChartDoc(getChartDocFromDrawImpress(0, 
0), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartDoc.is());
+
+uno::Reference 
xDataSeries(getDataSeriesFromDoc(xChartDoc, 0));
+CPPUNIT_ASSERT(xDataSeries.is());
+float nFontSize;
+sal_Int64 nFontColor;
+sal_Int32 nCharUnderline;
+uno::Reference xPropertySet;
+uno::Sequence aFields;
+
+// 1
+xPropertySet.set(xDataSeries->getDataPointByIndex(0), 
uno::UNO_QUERY_THROW);
+xPropertySet->getPropertyValue("CustomLabelFields") >>= aFields;
+CPPUNIT_ASSERT_EQUAL(static_cast(2), aFields.getLength());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 aFields[0]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString("90.0 = "), aFields[0]->getString());
+aFields[0]->getPropertyValue("CharHeight") >>= nFontSize;
+aFields[0]->getPropertyValue("CharColor") >>= nFontColor;
+CPPUNIT_ASSERT_EQUAL(static_cast(18), nFontSize);
+CPPUNIT_ASSERT_EQUAL(static_cast(0xed7d31), nFontColor);
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_VALUE,
 aFields[1]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString("90"), aFields[1]->getString());
+CPPUNIT_ASSERT_EQUAL(OUString("{0C576297-5A9F-4B4E-A675-B6BA406B7D87}"), 
aFields[1]->getGuid());
+
+// 2
+xPropertySet.set(xDataSeries->getDataPointByIndex(1), 
uno::UNO_QUERY_THROW);
+xPropertySet->getPropertyValue("CustomLabelFields") >>= aFields;
+CPPUNIT_ASSERT_EQUAL(static_cast(8), aFields.getLength());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 aFields[0]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString("Text"), aFields[0]->getString());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 aFields[1]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString(" : "), aFields[1]->getString());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_CATEGORYNAME,
 aFields[2]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString("B"), aFields[2]->getString());
+CPPUNIT_ASSERT_EQUAL(OUString("{0CCAAACD-B393-42CE-8DBD-82F9F9ADC852}"), 
aFields[2]->getGuid());
+aFields[2]->getPropertyValue("CharHeight") >>= nFontSize;
+aFields[2]->getPropertyValue("CharColor") >>= nFontColor;
+CPPUNIT_ASSERT_EQUAL(static_cast(16), nFontSize);
+CPPUNIT_ASSERT_EQUAL(static_cast(0xed7d31), nFontColor);
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_NEWLINE,
 aFields[3]->getFieldType());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 aFields[4]->getFieldType());
+CPPUNIT_ASSERT_EQUAL(OUString("Multi"), aFields[4]->getString());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 

[Libreoffice-commits] core.git: chart2/inc chart2/qa chart2/source offapi/com offapi/UnoApi_offapi.mk oox/inc oox/source

[Szymon Kłos]

 chart2/inc/unonames.hxx  |1 
 chart2/qa/extras/chart2import.cxx|  154 +++
 chart2/qa/extras/data/pptx/tdf115107-2.pptx  |binary
 chart2/qa/extras/data/pptx/tdf115107.pptx|binary
 chart2/source/chartcore.component|1 
 chart2/source/model/main/DataPointProperties.cxx |   11 
 chart2/source/model/main/DataPointProperties.hxx |3 
 chart2/source/model/main/FormattedString.cxx |   40 ++
 chart2/source/model/main/FormattedString.hxx |   16 +
 chart2/source/view/charttypes/VSeriesPlotter.cxx |  126 +++--
 chart2/source/view/inc/AbstractShapeFactory.hxx  |7 
 chart2/source/view/inc/OpenglShapeFactory.hxx|7 
 chart2/source/view/inc/ShapeFactory.hxx  |7 
 chart2/source/view/inc/VSeriesPlotter.hxx|2 
 chart2/source/view/main/OpenglShapeFactory.cxx   |   12 
 chart2/source/view/main/ShapeFactory.cxx |   94 ++
 offapi/UnoApi_offapi.mk  |3 
 offapi/com/sun/star/chart2/DataPointCustomLabelField.idl |   26 +
 offapi/com/sun/star/chart2/DataPointCustomLabelFieldType.idl |   33 ++
 offapi/com/sun/star/chart2/DataPointProperties.idl   |8 
 offapi/com/sun/star/chart2/XDataPointCustomLabelField.idl|   43 +++
 oox/inc/drawingml/textfield.hxx  |2 
 oox/source/drawingml/chart/seriesconverter.cxx   |   78 +
 oox/source/token/properties.txt  |1 
 24 files changed, 657 insertions(+), 18 deletions(-)

New commits:
commit 790f9abeb1a1167ad5ab84c5fb855b36669c125b
Author: Szymon Kłos 
Date:   Thu Jan 4 22:15:32 2018 +0100

tdf#114821 import complex data labels in bar chart

* import static text & fields:
   VALUE, SERIESNAME, COLUMNNAME
* text is formatted
* DataPointCustomLabelField with field type
  (DataPointCustomLabelFieldType) was introduced.
* text can have many portions & multiple lines
* unit tests for import data labels with formatting

Not implemented: CELLREF field support which needs
importing some additional data from extLst

Shows custom text as a label for data points.

Change-Id: Iba8fd508eb16356b05586b93d7b8da32240d2b91
Reviewed-on: https://gerrit.libreoffice.org/48243
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 

diff --git a/chart2/inc/unonames.hxx b/chart2/inc/unonames.hxx
index 867a155e14aa..44c3bf67d3cb 100644
--- a/chart2/inc/unonames.hxx
+++ b/chart2/inc/unonames.hxx
@@ -29,6 +29,7 @@
 #define CHART_UNONAME_LABEL_BORDER_DASH "LabelBorderDash"
 #define CHART_UNONAME_LABEL_BORDER_DASHNAME "LabelBorderDashName"
 #define CHART_UNONAME_LABEL_BORDER_TRANS"LabelBorderTransparency"
+#define CHART_UNONAME_CUSTOM_LABEL_FIELDS   "CustomLabelFields"
 
 #endif
 
diff --git a/chart2/qa/extras/chart2import.cxx 
b/chart2/qa/extras/chart2import.cxx
index b7e1bb79faec..dee428264d69 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -11,6 +11,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -101,6 +103,9 @@ public:
 
 void testInternalDataProvider();
 
+void testTdf115107(); // import complex data point labels
+void testTdf115107_2(); // import complex data point labels in cobo charts 
with multiple data series
+
 CPPUNIT_TEST_SUITE(Chart2ImportTest);
 CPPUNIT_TEST(Fdo60083);
 CPPUNIT_TEST(testSteppedLines);
@@ -160,6 +165,9 @@ public:
 
 CPPUNIT_TEST(testInternalDataProvider);
 
+CPPUNIT_TEST(testTdf115107);
+CPPUNIT_TEST(testTdf115107_2);
+
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -1317,6 +1325,152 @@ void Chart2ImportTest::testTdf73()
 CPPUNIT_ASSERT_MESSAGE( "failed to load chart", xChart1Doc.is() );
 }
 
+void Chart2ImportTest::testTdf115107()
+{
+load("/chart2/qa/extras/data/pptx/", "tdf115107.pptx");
+
+Reference xChartDoc(getChartDocFromDrawImpress(0, 
0), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xChartDoc.is());
+
+uno::Reference 
xDataSeries(getDataSeriesFromDoc(xChartDoc, 0));
+CPPUNIT_ASSERT(xDataSeries.is());
+float nFontSize;
+sal_Int64 nFontColor;
+sal_Int32 nCharUnderline;
+uno::Reference xPropertySet;
+uno::Sequence aFields;
+
+// 1
+xPropertySet.set(xDataSeries->getDataPointByIndex(0), 
uno::UNO_QUERY_THROW);
+xPropertySet->getPropertyValue("CustomLabelFields") >>= aFields;
+CPPUNIT_ASSERT_EQUAL(static_cast(2), aFields.getLength());
+
+
CPPUNIT_ASSERT_EQUAL(chart2::DataPointCustomLabelFieldType::DataPointCustomLabelFieldType_TEXT,
 aFields[0]->getFieldType());
+

Crash test update

[Crashtest VM]

New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/b74750a9d8bbbd290832d2750a3e0174fe983530/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 109008] Crash in: atio6axx.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109008

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105222] TIMEVALUE (ORARIO.VALORE in IT) Calc function incorrect/ lack of help documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105222

--- Comment #4 from gmarco  ---
(In reply to Xisco Faulí from comment #3)
> Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
> identified.

the bug had connections with the # 105226 (resolved fixed target: 6.0.1
assignee:
Winfried Donkers) then automatically resolved and fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105221] TIME (ORARIO in IT) Calc function incorrect help documentation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105221

--- Comment #4 from gmarco  ---
(In reply to Xisco Faulí from comment #3)
> Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
> identified.

the bug had connections with the # 105226 (resolved fixed target: 6.0.1
assignee:
Winfried Donkers) then automatically resolved and fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115305] New: [Nightly 6.0] IMPRESS should have track changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115305

Bug ID: 115305
   Summary: [Nightly 6.0] IMPRESS should have track changes
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bun...@gmail.com

Description:
Impress should have a "Track Changes" just like Writer and Calc so that editing
changes (individually or by multiple users) can be tracked, accepted and
integrated.

Steps to Reproduce:
Impress should have a "Track Changes" just like Writer and Calc.

There is no menu for "Track Changes" in the Edit Menu as in Writer and Calc.

Actual Results:  
There is no way to track changes to a presentation if multiple people review.

Expected Results:
Impress should have a "Track Changes" just like Writer and Calc so that editing
changes can be tracked, accepted and integrated.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0)
Gecko/20100101 Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115304] EDITING: Calc Hide Columns, cannot Show Columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115304

--- Comment #2 from Telesto  ---
Not an expert, this seems to work:
1. Select Column A and D. 
2. Selected Show Columns.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115304] EDITING: Calc Hide Columns, cannot Show Columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115304

--- Comment #1 from Brian Clark  ---
Bugzilla would not accept Version 5.4.3.2 (x64) so I had to use unspecified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - configure.ac

[Andras Timar]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c8af37defb835827c127c4dab732fca351cd74d2
Author: Andras Timar 
Date:   Mon Jan 29 13:21:52 2018 -0800

Bump version to 5.3-39

Change-Id: Ieb45318ce204ebde81de20f6824324cf437923be

diff --git a/configure.ac b/configure.ac
index 8b8bc3bf26b9..e87804ac1b03 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[5.3.10.32],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[5.3.10.39],[],[],[https://collaboraoffice.com/])
 
 AC_PREREQ([2.59])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115304] New: EDITING: Calc Hide Columns, cannot Show Columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115304

Bug ID: 115304
   Summary: EDITING: Calc Hide Columns, cannot Show Columns
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: classicalcan...@yahoo.ca

Description:
Selected Columns B,C header. Right-click, selected Hide Columns. Columns B,C
were no longer visible as expected. Went to bring them back by selecting Column
D header, right-click, selected Show Columns. Columns B,C remained invisible.
By repeatedly using Edit Undo I was able to bring them back. So I lost no work.

The online documentation for Hide Columns reads as follows:
Hides the selected column(s). To display hidden columns, right-click any column
header, and then choose Show Columns.

I did discover if I dragged an adjacent column over, the hidden column would
reappear, so it seems Hide Columns just makes the columns have a width of zero.

Steps to Reproduce:
1.Right-click on a column header
2.Select Hide Columns
3.Right-clock on a visible column header
4. Select Show Columns

Actual Results:  
Selected columns became hidden. Unable to make them visible again with Show
Columns.

Expected Results:
All hidden columns should have reappeared


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 5.4.3.2 (x64)
Build ID: 92a7159f7e4af62137622921e809f8546db437e5
CPU threads: 4; OS: Windows 6.1; UI render: default; 
Locale: en-CA (en_CA); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/63.0.3239.132 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/filter/oox/defnamesbuffer.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit a1f933ee2b9e23a505d937035821e9571cf4119c
Author: Eike Rathke 
Date:   Mon Jan 29 22:17:40 2018 +0100

CheckLinkFormulaNeedingCheck() for .xlsx named expressions

Change-Id: I217c89822ab477a6c383d170ae739e44efd10fa3

diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index d7fb59ff934a..6f761b2c9b7c 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace oox {
 namespace xls {
@@ -332,6 +333,7 @@ std::unique_ptr DefinedName::getScTokens(
 // after, a resulting error must be reset.
 FormulaError nErr = pArray->GetCodeError();
 aCompiler.CompileTokenArray();
+getScDocument().CheckLinkFormulaNeedingCheck( *pArray);
 pArray->DelRPN();
 pArray->SetCodeError(nErr);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/filter/html/swhtml.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit e089258f6d7a270c574783c40808e18fb2d3b202
Author: Stephan Bergmann 
Date:   Mon Jan 29 16:43:35 2018 +0100

Clean up conversion to sal_uInt16

Change-Id: I980197dd893dce9800607842f30cdbb4f9893d66
Reviewed-on: https://gerrit.libreoffice.org/48847
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index c24502019fe1..a02448657dd5 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -17,6 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include 
+
+#include 
 #include 
 #include 
 
@@ -4992,7 +4995,7 @@ sal_uInt16 SwHTMLParser::ToTwips( sal_uInt16 nPixel )
 {
 long nTwips = Application::GetDefaultDevice()->PixelToLogic(
 Size( nPixel, nPixel ), MapMode( MapUnit::MapTwip ) 
).Width();
-return nTwips <= USHRT_MAX ? static_cast(nTwips) : 
USHRT_MAX;
+return static_cast(std::min(nTwips, 
SwTwips(SAL_MAX_UINT16)));
 }
 else
 return nPixel;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann]

 sc/source/ui/inc/output.hxx   |1 -
 sc/source/ui/view/output2.cxx |   39 ---
 2 files changed, 40 deletions(-)

New commits:
commit 7a22e8a726a7cbae007326a3af5f6c0c20945cc8
Author: Stephan Bergmann 
Date:   Mon Jan 29 15:59:42 2018 +0100

No more need to restrict paper width to USHRT_MAX

...after 288d694ff695ef83cbe4224db87dd65281c75a8f "LOK - Calc: Text is not
visible in cell when entering numerical input" changed EditLine::nStartPosX 
from
sal_uInt16 to long

Change-Id: Ib1d364015c7ab0b5f81fb740659110c66aed002a
Reviewed-on: https://gerrit.libreoffice.org/48845
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index c41433609b9e..dfe973897760 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -137,7 +137,6 @@ private:
 
 void setAlignmentToEngine();
 bool adjustHorAlignment(ScFieldEditEngine* pEngine);
-void adjustForRTL();
 void adjustForHyperlinkInPDF(Point aURLStart, const OutputDevice* 
pDev);
 };
 
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 9105c30870ac..f1e1fbd3eccf 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -2682,23 +2682,6 @@ bool 
ScOutputData::DrawEditParam::adjustHorAlignment(ScFieldEditEngine* pEngine)
 return false;
 }
 
-void ScOutputData::DrawEditParam::adjustForRTL()
-{
-if (!mpEngine->IsRightToLeft(0))
-// No RTL mode.
-return;
-
-//  For right-to-left, EditEngine always calculates its lines
-//  beginning from the right edge, but EditLine::nStartPosX is
-//  of sal_uInt16 type, so the PaperSize must be limited to USHRT_MAX.
-Size aLogicPaper = mpEngine->GetPaperSize();
-if ( aLogicPaper.Width() > USHRT_MAX )
-{
-aLogicPaper.Width() = USHRT_MAX;
-mpEngine->SetPaperSize(aLogicPaper);
-}
-}
-
 void ScOutputData::DrawEditParam::adjustForHyperlinkInPDF(Point aURLStart, 
const OutputDevice* pDev)
 {
 // PDF: whole-cell hyperlink from formula?
@@ -3141,8 +3124,6 @@ void ScOutputData::DrawEditStandard(DrawEditParam& rParam)
 
 aURLStart = aLogicStart;  // copy before modifying for orientation
 
-rParam.adjustForRTL();
-
 // bMoveClipped handling has been replaced by complete alignment
 // handling (also extending to the left).
 
@@ -3465,7 +3446,6 @@ void ScOutputData::DrawEditBottomTop(DrawEditParam& 
rParam)
 }
 }
 
-rParam.adjustForRTL();
 rParam.mpEngine->Draw(mpDev, aLogicStart, 900);
 }
 
@@ -3700,8 +3680,6 @@ void ScOutputData::DrawEditTopBottom(DrawEditParam& 
rParam)
 }
 }
 
-rParam.adjustForRTL();
-
 // bMoveClipped handling has been replaced by complete alignment
 // handling (also extending to the left).
 
@@ -3975,8 +3953,6 @@ void ScOutputData::DrawEditStacked(DrawEditParam& rParam)
 aPaperLogic.Width() = nEngineWidth;
 rParam.mpEngine->SetPaperSize(aPaperLogic);
 
-rParam.adjustForRTL();
-
 // bMoveClipped handling has been replaced by complete alignment
 // handling (also extending to the left).
 
@@ -4247,8 +4223,6 @@ void ScOutputData::DrawEditAsianVertical(DrawEditParam& 
rParam)
 
 aURLStart = aLogicStart;  // copy before modifying for orientation
 
-rParam.adjustForRTL();
-
 // bMoveClipped handling has been replaced by complete alignment
 // handling (also extending to the left).
 
@@ -5076,19 +5050,6 @@ void ScOutputData::DrawRotated(bool bPixelToLogic)
 
 //  bSimClip is not used here (because nOriVal 
is set)
 
-if ( pEngine->IsRightToLeft( 0 ) )
-{
-//  For right-to-left, EditEngine always 
calculates its lines
-//  beginning from the right edge, but 
EditLine::nStartPosX is
-//  of sal_uInt16 type, so the PaperSize 
must be limited to USHRT_MAX.
-Size aLogicPaper = pEngine->GetPaperSize();
-if ( aLogicPaper.Width() > USHRT_MAX )
-{
-aLogicPaper.Width() = USHRT_MAX;
-pEngine->SetPaperSize(aLogicPaper);
-}
-}
-
 pEngine->Draw( mpDev, aLogicStart, 
static_cast(nOriVal) );
 
 if (bMetaFile)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 109008] Crash in: atio6axx.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109008

--- Comment #5 from Jay  ---
Please close this bug report. I do not recall whether I have downloaded and
installed updated drivers as suggested in the response, nor do I recall having 
attempted to use your product since the time that I reported this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109008] Crash in: atio6axx.dll

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109008

Jay  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #4 from Jay  ---
Please close this bug report. I do not recall weather I have downloaded and
installed updated drivers as suggested in the response, nor do I recall having 
attempted to use your product since the time that I reported this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115303] New: FILESAVE CALC Freeze Cells fails when window frame abuts frozen pane

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115303

Bug ID: 115303
   Summary: FILESAVE CALC Freeze Cells fails when window frame
abuts frozen pane
   Product: LibreOffice
   Version: 5.4.1.2 release
  Hardware: All
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: duncan...@gmail.com

Saving after setting 'Freeze Rows and Columns' works only so long as the bottom
edge of the window is clear of the row immediately below the frozen pane. Rows
become unfrozen if the bottom of window encroaches into the row next to the
frozen pane at time of saving. Further, if at any time the bottom or right
window frames are dragged into the frozen pane they immediately unfreeze the
rows or columns, respectively. This occurs in xlsx and ods formats, in 5.4.1.2
and 5.3.0.3 releases (haven't tried other releases), running under MacOS
10.12.6.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - sal/osl

[Mike Kaganski]

 sal/osl/w32/pipe.c |8 
 1 file changed, 8 insertions(+)

New commits:
commit 461ef62f514a5e7c88e5087cffda88d9535cef16
Author: Mike Kaganski 
Date:   Mon Jan 29 16:24:24 2018 +0300

tdf#49134 tdf#114466 Transfer privilege to become foreground process

... to already open soffice process from newly spawned one on Windows.

When an application takes user input, a timeout is started during
which other processes cannot create foreground windows that might
steal focus, and thus interrupt user input. The timeout is defined
by SPI_SETFOREGROUNDLOCKTIMEOUT (see SystemParametersInfo) and
ForegroundLockTimeout registry setting (see
https://technet.microsoft.com/en-us/library/cc957208). If an
application that currently doesn't have right to become foreground
tries to show popups in this interval, the popup will stay on
background, and only flash in taskbar.

The application that has the right to steal focus (see the list in
https://msdn.microsoft.com/en-us/library/ms632668) may transfer its
right to another process using AllowSetForegroundWindow function.
So, the intended effect is this:

1. User interacts with some foreground process (e.g., Explorer);
   a timeout is started to prevent non-privileged processes from
   stealing focus;
2. As the result, the process launches a new soffice process, which
   has privilege to create foreground windows (as it is started by
   foreground process);
3. It communicates with already started soffice process, which is
   currently in background, and so doesn't have privilege to create
   foreground windows until timeout expires;
4. It transfers its right to the already started soffice process,
   and then issues the required commands that might lead to need to
   show popup windows.

Change-Id: I4208665c2ae4106fa06e72269f4c3804af40d582
Reviewed-on: https://gerrit.libreoffice.org/48852
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/sal/osl/w32/pipe.c b/sal/osl/w32/pipe.c
index 7693a25b6196..4f5e7c9a10ac 100644
--- a/sal/osl/w32/pipe.c
+++ b/sal/osl/w32/pipe.c
@@ -234,6 +234,14 @@ oslPipe SAL_CALL osl_createPipe(rtl_uString *strPipeName, 
oslPipeOptions Options
 rtl_uString_release( name );
 rtl_uString_release( path );
 
+// We should try to transfer our privilege to become 
foreground process
+// to the other process, so that it may show popups 
(otherwise, they might
+// be blocked by SPI_GETFOREGROUNDLOCKTIMEOUT setting -
+// see SystemParametersInfo function at MSDN
+ULONG ServerProcessId = 0;
+if (GetNamedPipeServerProcessId(pPipe->m_File, 
))
+AllowSetForegroundWindow(ServerProcessId);
+
 return pPipe;
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Google Summer of Code 2018

[Rushabh Kapadia]

Hi,
 I am a computer science student at VJTI, Mumbai and I am interested in
applying for GSOC 2018.
 I went through the organisations and the projects that were submitted
last year and found the projects submitted by your organisation appealing.
 Just wanted to enquire whether you would be participating this year as
well and if yes, then what would be the projects for this year.
  Thank you for your time and please let me know if LibreOffice is
planning to participate this year.

Warm regards,
Rushabh Kapadia
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source

[Miklos Vajna]

 sw/qa/extras/ooxmlexport/data/graphic-object-fliph.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport11.cxx  |6 +
 sw/source/filter/ww8/docxattributeoutput.cxx|   18 ++--
 writerfilter/source/dmapper/GraphicImport.cxx   |   11 +
 4 files changed, 33 insertions(+), 2 deletions(-)

New commits:
commit 4bdbb5502f5995727017e22bb8a74b9f45552067
Author: Miklos Vajna 
Date:   Mon Jan 29 16:20:46 2018 +0100

DOCX import: handle horizontal flip of bitmaps

Horizontal mirror on the UNO API level, mirror on the vertical axis
internally.

Change-Id: If142274a8f81a6875059a2651af6d8470870a36a
Reviewed-on: https://gerrit.libreoffice.org/48843
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/qa/extras/ooxmlexport/data/graphic-object-fliph.docx 
b/sw/qa/extras/ooxmlexport/data/graphic-object-fliph.docx
new file mode 100644
index ..2f95a2b8583b
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/graphic-object-fliph.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index fcb662e93286..5a6cfd48cf13 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -170,6 +170,12 @@ DECLARE_OOXMLEXPORT_TEST(testTdf113183, "tdf113183.docx")
 "HoriOrientPosition"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testGraphicObjectFliph, "graphic-object-fliph.docx")
+{
+CPPUNIT_ASSERT(getProperty(getShape(1), "HoriMirroredOnEvenPages"));
+CPPUNIT_ASSERT(getProperty(getShape(1), "HoriMirroredOnOddPages"));
+}
+
 DECLARE_OOXMLEXPORT_TEST(testTdf113547, "tdf113547.docx")
 {
 uno::Reference xPropertySet(
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index b0d3060ea8a9..e24b02e9dd55 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -125,6 +125,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -4713,8 +4714,21 @@ void DocxAttributeOutput::FlyFrameGraphic( const 
SwGrfNode* pGrfNode, const Size
 m_pSerializer->startElementNS( XML_pic, XML_spPr,
 XML_bwMode, "auto",
 FSEND );
-m_pSerializer->startElementNS( XML_a, XML_xfrm,
-FSEND );
+
+rtl::Reference xFrameAttributes(
+FastSerializerHelper::createAttrList());
+
+if (pGrfNode)
+{
+MirrorGraph eMirror = 
pGrfNode->GetSwAttrSet().Get(RES_GRFATR_MIRRORGRF).GetValue();
+if (eMirror == MirrorGraph::Vertical || eMirror == MirrorGraph::Both)
+// Mirror on the vertical axis is a horizontal flip.
+xFrameAttributes->add(XML_flipH, "1");
+}
+
+m_pSerializer->startElementNS(
+XML_a, XML_xfrm, 
uno::Reference(xFrameAttributes.get()));
+
 m_pSerializer->singleElementNS( XML_a, XML_off,
 XML_x, "0", XML_y, "0",
 FSEND );
diff --git a/writerfilter/source/dmapper/GraphicImport.cxx 
b/writerfilter/source/dmapper/GraphicImport.cxx
index 295e3f1a8164..a6452c3d1a7a 100644
--- a/writerfilter/source/dmapper/GraphicImport.cxx
+++ b/writerfilter/source/dmapper/GraphicImport.cxx
@@ -1334,6 +1334,17 @@ uno::Reference< text::XTextContent > 
GraphicImport::createGraphicObject( const b
 m_pImpl->applyMargins(xGraphicObjectProperties);
 m_pImpl->applyName(xGraphicObjectProperties);
 }
+
+// Handle horizontal flip.
+bool bMirrored = false;
+xShapeProps->getPropertyValue("IsMirrored") >>= bMirrored;
+if (bMirrored)
+{
+
xGraphicObjectProperties->setPropertyValue("HoriMirroredOnEvenPages",
+   uno::makeAny(true));
+
xGraphicObjectProperties->setPropertyValue("HoriMirroredOnOddPages",
+   uno::makeAny(true));
+}
 }
 }
 catch( const uno::Exception& e )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

[Caolán McNamara]

 filter/source/graphicfilter/iras/iras.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit f06d75ae96a1b54207cb2cf9aecf35b4d29c2e59
Author: Caolán McNamara 
Date:   Mon Jan 29 14:12:57 2018 +

ofz: optimize ras filter a titch

Change-Id: Iabfbfa8d6beddb04ab26c4f8f05996b5e2daa24a
Reviewed-on: https://gerrit.libreoffice.org/48840
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/filter/source/graphicfilter/iras/iras.cxx 
b/filter/source/graphicfilter/iras/iras.cxx
index 78670d0f3287..810915dc09a7 100644
--- a/filter/source/graphicfilter/iras/iras.cxx
+++ b/filter/source/graphicfilter/iras/iras.cxx
@@ -239,6 +239,7 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 sal_uInt8 nDat = 0;
 for (y = 0; y < mnHeight && mbStatus; ++y)
 {
+Scanline pScanline = pAcc->GetScanline(y);
 for (x = 0; x < mnWidth && mbStatus; ++x)
 {
 if (!(x & 7))
@@ -247,9 +248,9 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 if (!m_rRAS.good())
 mbStatus = false;
 }
-pAcc->SetPixelIndex( y, x,
+pAcc->SetPixelOnData(pScanline, x, BitmapColor(
 sal::static_int_cast< sal_uInt8 >(
-nDat >> ( ( x & 7 ) ^ 7 )) );
+nDat >> ( ( x & 7 ) ^ 7 )) ));
 }
 if (!( ( x - 1 ) & 0x8 ) )
 {
@@ -264,10 +265,11 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 case 8 :
 for (y = 0; y < mnHeight && mbStatus; ++y)
 {
+Scanline pScanline = pAcc->GetScanline(y);
 for (x = 0; x < mnWidth && mbStatus; ++x)
 {
 sal_uInt8 nDat = ImplGetByte();
-pAcc->SetPixelIndex( y, x, nDat );
+pAcc->SetPixelOnData(pScanline, x, BitmapColor(nDat));
 if (!m_rRAS.good())
 mbStatus = false;
 }
@@ -287,6 +289,7 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 case 24 :
 for (y = 0; y < mnHeight && mbStatus; ++y)
 {
+Scanline pScanline = pAcc->GetScanline(y);
 for (x = 0; x < mnWidth && mbStatus; ++x)
 {
 if ( mnType == RAS_TYPE_RGB_FORMAT )
@@ -301,7 +304,7 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nGreen = ImplGetByte();
 nRed = ImplGetByte();
 }
-pAcc->SetPixel ( y, x, BitmapColor( nRed, nGreen, 
nBlue ) );
+pAcc->SetPixelOnData(pScanline, x, 
BitmapColor(nRed, nGreen, nBlue));
 if (!m_rRAS.good())
 mbStatus = false;
 }
@@ -317,6 +320,7 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 case 32 :
 for (y = 0; y < mnHeight && mbStatus; ++y)
 {
+Scanline pScanline = pAcc->GetScanline(y);
 for (x = 0; x < mnWidth && mbStatus; ++x)
 {
 ImplGetByte();   // pad byte > nil
@@ -332,7 +336,7 @@ bool RASReader::ImplReadBody(BitmapWriteAccess * pAcc)
 nGreen = ImplGetByte();
 nRed = ImplGetByte();
 }
-pAcc->SetPixel ( y, x, BitmapColor( nRed, nGreen, 
nBlue ) );
+pAcc->SetPixelOnData(pScanline, x, 
BitmapColor(nRed, nGreen, nBlue));
 if (!m_rRAS.good())
 mbStatus = false;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 49134] On opening a password-protected file, the LibreOffice dialog is not raised/given focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49134

--- Comment #26 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d1d82dd63eada8faa2f6eb43ef900764a5fda62

tdf#49134 tdf#114466 Transfer privilege to become foreground process

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114466] Certain Document in Use dialog does not get focus

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114466

--- Comment #15 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d1d82dd63eada8faa2f6eb43ef900764a5fda62

tdf#49134 tdf#114466 Transfer privilege to become foreground process

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sal/osl

[Mike Kaganski]

 sal/osl/w32/pipe.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 8d1d82dd63eada8faa2f6eb43ef900764a5fda62
Author: Mike Kaganski 
Date:   Mon Jan 29 16:24:24 2018 +0300

tdf#49134 tdf#114466 Transfer privilege to become foreground process

... to already open soffice process from newly spawned one on Windows.

When an application takes user input, a timeout is started during
which other processes cannot create foreground windows that might
steal focus, and thus interrupt user input. The timeout is defined
by SPI_SETFOREGROUNDLOCKTIMEOUT (see SystemParametersInfo) and
ForegroundLockTimeout registry setting (see
https://technet.microsoft.com/en-us/library/cc957208). If an
application that currently doesn't have right to become foreground
tries to show popups in this interval, the popup will stay on
background, and only flash in taskbar.

The application that has the right to steal focus (see the list in
https://msdn.microsoft.com/en-us/library/ms632668) may transfer its
right to another process using AllowSetForegroundWindow function.
So, the intended effect is this:

1. User interacts with some foreground process (e.g., Explorer);
   a timeout is started to prevent non-privileged processes from
   stealing focus;
2. As the result, the process launches a new soffice process, which
   has privilege to create foreground windows (as it is started by
   foreground process);
3. It communicates with already started soffice process, which is
   currently in background, and so doesn't have privilege to create
   foreground windows until timeout expires;
4. It transfers its right to the already started soffice process,
   and then issues the required commands that might lead to need to
   show popup windows.

Change-Id: I4208665c2ae4106fa06e72269f4c3804af40d582
Reviewed-on: https://gerrit.libreoffice.org/48839
Reviewed-by: Michael Meeks 
Tested-by: Mike Kaganski 

diff --git a/sal/osl/w32/pipe.cxx b/sal/osl/w32/pipe.cxx
index b61526f3edf6..116bdd3d6817 100644
--- a/sal/osl/w32/pipe.cxx
+++ b/sal/osl/w32/pipe.cxx
@@ -229,6 +229,14 @@ oslPipe SAL_CALL osl_createPipe(rtl_uString *strPipeName, 
oslPipeOptions Options
 rtl_uString_release(name);
 rtl_uString_release(path);
 
+// We should try to transfer our privilege to become 
foreground process
+// to the other process, so that it may show popups 
(otherwise, they might
+// be blocked by SPI_GETFOREGROUNDLOCKTIMEOUT setting -
+// see SystemParametersInfo function at MSDN
+ULONG ServerProcessId = 0;
+if (GetNamedPipeServerProcessId(pPipe->m_File, 
))
+AllowSetForegroundWindow(ServerProcessId);
+
 return pPipe;
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'libreoffice-5-4' - net/Socket.hpp net/Ssl.cpp wsd/FileServer.hpp wsd/LOOLWSD.cpp

[Ashod Nakashian]

 net/Socket.hpp |4 
 net/Ssl.cpp|1 +
 wsd/FileServer.hpp |3 +++
 wsd/LOOLWSD.cpp|2 ++
 4 files changed, 10 insertions(+)

New commits:
commit 90bb229f4dd23353ccce642456f2de471954807f
Author: Ashod Nakashian 
Date:   Sun Jul 2 22:10:23 2017 -0400

wsd: free leaking memory

With help from Valgrind to find and verify
these leaks.

Change-Id: I3afeed89dc4bcd714a222f81822144477a346fb0
Reviewed-on: https://gerrit.libreoffice.org/39464
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 4f8ebca0cb3612ddbdcfbee6ea5a462b04689738)
Reviewed-on: https://gerrit.libreoffice.org/48675
Tested-by: Samuel Mehrbrodt 

diff --git a/net/Socket.hpp b/net/Socket.hpp
index 7c7b55ab..3997c645 100644
--- a/net/Socket.hpp
+++ b/net/Socket.hpp
@@ -613,6 +613,10 @@ private:
 
 // Invoke the virtual implementation.
 pollingThread();
+
+// Release sockets.
+_pollSockets.clear();
+_newSockets.clear();
 }
 catch (const std::exception& exc)
 {
diff --git a/net/Ssl.cpp b/net/Ssl.cpp
index 64f279d4..5a9f8280 100644
--- a/net/Ssl.cpp
+++ b/net/Ssl.cpp
@@ -128,6 +128,7 @@ SslContext::SslContext(const std::string& certFilePath,
 
 SslContext::~SslContext()
 {
+SSL_CTX_free(_ctx);
 EVP_cleanup();
 ERR_free_strings();
 CRYPTO_set_locking_callback(0);
diff --git a/wsd/FileServer.hpp b/wsd/FileServer.hpp
index 01d5918c..c3ff59b7 100644
--- a/wsd/FileServer.hpp
+++ b/wsd/FileServer.hpp
@@ -31,6 +31,9 @@ public:
 /// Read all files that we can serve into memory and compress them.
 static void initialize();
 
+/// Clean cached files.
+static void uninitialize() { FileHash.clear(); }
+
 static void readDirToHash(const std::string , const std::string 
);
 
 static const std::string *getCompressedFile(const std::string );
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 0dccb5d4..e6ebfac2 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2609,6 +2609,8 @@ int LOOLWSD::innerMain()
 
 void LOOLWSD::cleanup()
 {
+FileServerRequestHandler::uninitialize();
+
 // Finally, we no longer need SSL.
 if (LOOLWSD::isSSLEnabled())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115286] Cannot change the default language (English US) for the Spell checker - Spell Checker does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115286

Bruce Fleming  changed:

   What|Removed |Added

Version|5.2.5.1 release |6.0.0.2 rc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115286] Cannot change the default language (English US) for the Spell checker - Spell Checker does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115286

Bruce Fleming  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Bruce Fleming  ---
Please read the Description contents Carefully

LIBREOFFICE SPELL CHECKER, IT'S PANELS, AND FUNCTION IS FLAWED.

WITHOUT THE SPELL CHECKER, LIBREOFFICE DOES NOT DESERVE SPACE ON ANY MACHINE.

THE PROBLEM CAN BE EASILY DUPLICATED. IT IS NOT AM END USER ERROR. 

THE SPELL CHECKER DOES NOT FUNCTION CORRECTLY.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115286] Cannot change the default language (English US) for the Spell checker - Spell Checker does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115286

--- Comment #2 from Bruce Fleming  ---
Created attachment 139444
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139444=edit
Example of problem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115296] FILEOPEN: frame's borders have empty gaps

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115296

Telesto  changed:

   What|Removed |Added

 CC||tele...@surfxs.nl
 Blocks||114934


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=114934
[Bug 114934] [META] borderline regressions
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Peter  changed:

   What|Removed |Added

 CC||pbak...@iccontrols.com

--- Comment #10 from Peter  ---
I found this bug report while searching for possible solutions to images
disappearing in multiple documents (Draw, Writer) in recent months. Currently I
am using LibreOffice 5.3.7.2 (x64) on Windows 10. It is very discouraging to
open up a document and find broken links to images. On multiple occasions it
has taken an hour or more of work re-inserting and re-creating images to get
back to where the document is usable again. An inspection of the document
renamed as a zip file shows images still existing inside the document in the
Pictures directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115295] Page separator line is slowing down the page scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115295

Telesto  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #1 from Telesto  ---
Setting it back to unconfirmed.. Someone else should confirm this, before
setting it to NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114803] 'Scan lines' are showing up in a image when scrolling if the image is anchored As Character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114803

Telesto  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||armin.le.gr...@me.com
Version|6.1.0.0.alpha0+ Master  |6.0.0.0.alpha1+

--- Comment #5 from Telesto  ---
Adding CC to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114803] 'Scan lines' are showing up in a image when scrolling if the image is anchored As Character

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114803

--- Comment #4 from Telesto  ---
Created attachment 139443
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139443=edit
Bibisect log

Bisected to
uthor   Armin Le Grand   2017-11-16 12:54:21 +0100
committer   Armin Le Grand   2017-11-18 13:07:47
+0100
commit  059469926e359153b9b291790ef2df84fa63fda9 (patch)
tree0afc7da1aa97c22250823ae43acdfdfd3fdd77b0
parent  d74b26b41bfea3ba7a1834953b2bfe9b7ff0d70f (diff)
RotateFlyFrame3: Corrected Contour when rotated
When rotated, the contour has to be adapted to that state
and also needs to be calculated in untransformed state,
added needed code. Also need to add a ClipRegion set at
the target OutputDevice (e.g. from Contour) to the prepared
GraphicPrimitive. It was sometimes used due to a VCL_Based
PrimitiveRenderer being used, but that is just a coincidence.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114864] Changing the Image angle with the angle rotation tool is sometimes a bit laggy and causes high CPU utilization

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114864

--- Comment #4 from Telesto  ---
(In reply to Buovjaga from comment #3)
> (In reply to Telesto from comment #2)
> > Hmm, probably not a bug in hindsight. The rotation is mostly directly
> > applied to the image, for example when doing this using the toolbar instead.

The dialog could (speculation) be using the same code as the real-time preview
is the new Sidebar rotation tool. Which would mean that a real-time preview is
generated somewhere in the background..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99572] ODS sheet with many external links from other calc files crashes when updating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99572

--- Comment #14 from Telesto  ---
I can't reproduce a crash when updating links
Version: 6.1.0.0.alpha0+
Build ID: ea89dabf8b6363972190a6b50c527c418d51c2c7
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-01-27_22:55:15
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115301] textbox text shifted relative to graphic objects when updated from Fedora 25 to Fedora 26.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115301

--- Comment #3 from Bill  ---
Created attachment 139442
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139442=edit
shows the slide after the upgrade to Fedora 26, but zoomed in 250%

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115301] textbox text shifted relative to graphic objects when updated from Fedora 25 to Fedora 26.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115301

--- Comment #2 from Bill  ---
Created attachment 139441
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139441=edit
shows the slide after the upgrade to Fedora 26.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115301] textbox text shifted relative to graphic objects when updated from Fedora 25 to Fedora 26.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115301

--- Comment #1 from Bill  ---
Created attachment 139440
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139440=edit
shows the slide before the upgrade to Fedora 26.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #11 from Tobias Burnus  ---
Testing with master looks good - except that I observe bug 115302.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115291] Text highlight color changes when .odt document saved as a .doc document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115291

Telesto  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Telesto  ---
Quote from: https://bugs.documentfoundation.org/show_bug.cgi?id=97865#c9

This thing happens because MS highlighting has only 15 highlighting color and
when you save Writer text background \ highlighting to an MS format it is
converted to this color palette.
It's the default behavior, but you can change this at Tools -> Option ->
Load/Save -> Microsoft Office, to save Writer text background as MS Shading and
so colors won't change. Nut in this case when you open that *.doc file in MS
Word you could not change the text background with highlighting tool, but with
the shading tool:
https://blogs.technet.microsoft.com/hub/2011/04/05/how-to-select-more-highlight-colors-in-word/

Before the 5.0 version sometimes we saved Writer text background as shading
(doc, docx), sometimes as highlighting (rtf). From that version an option is
added, so the user can select the preferred behavior. Highlighting became the
default, because on LO UI text background is called highlighting. This option
can be set also via user profile.
https://wiki.documentfoundation.org/ReleaseNotes/5.0

So, probably not a bug..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115302] New: PRINTING: Preview in print dialog is empty if print is invoked from print preview and comment-in-margin mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115302

Bug ID: 115302
   Summary: PRINTING: Preview in print dialog is empty if print is
invoked from print preview and comment-in-margin mode
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tobias.bur...@physik.fu-berlin.de

Description:
Follow up to bug 115221

1. Create a new document
2. Type a word or so (e.g. "Test")
2. Choose Insert -> Comment

(a.1) Choose File|Print and
(a.2) select under "General" > "Comment" the item "Place in margins"

RESULT: The preview shows the document with the comment in the margin

(b.1) Choose File | Print preview
(b.2) Choose File|Print and
(b.3) select under "General" > "Comment" the item "Place in margins"

RESULT: The preview shows a blank page

Expected: Same result as with (a).

Steps to Reproduce:
.

Actual Results:  
.

Expected Results:
.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:59.0) Gecko/20100101 Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108526] Calc not Win10 DPI aware, display elements missing on 4K screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108526

cr...@arno.com  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #10 from cr...@arno.com  ---
Missing lines still persist in 6.0.0.3:

Version: 6.0.0.3 (x64)
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113872] Highlight colors change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113872

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=64
   ||490

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Justin Luth]

 sw/source/ui/config/mailconfigpage.cxx  |8 
 sw/source/uibase/inc/mailconfigpage.hxx |1 +
 2 files changed, 9 insertions(+)

New commits:
commit 8ee4911d572764c0e15ded8142d8c9be2ea3e875
Author: Justin Luth 
Date:   Thu Jan 18 16:51:28 2018 +0300

mailconfig UI: SSL CB toggles secure port 587 and unsecure 25

If the default value is in the SMTP port field, switching
SSL on and off will toggle between SECURE_PORT and DEFAULT_PORT

Change-Id: Ie4bdd55a3d8bbe64ce6b8761ba30971464c1db4e
Reviewed-on: https://gerrit.libreoffice.org/48211
Tested-by: Jenkins 
Reviewed-by: Justin Luth 

diff --git a/sw/source/ui/config/mailconfigpage.cxx 
b/sw/source/ui/config/mailconfigpage.cxx
index c3928d35eccb..ec2ad5db503a 100644
--- a/sw/source/ui/config/mailconfigpage.cxx
+++ b/sw/source/ui/config/mailconfigpage.cxx
@@ -134,6 +134,7 @@ SwMailConfigPage::SwMailConfigPage( vcl::Window* pParent, 
const SfxItemSet& rSet
 m_pReplyToCB->SetClickHdl(LINK(this, SwMailConfigPage, ReplyToHdl));
 m_pServerAuthenticationPB->SetClickHdl(LINK(this, SwMailConfigPage, 
AuthenticationHdl));
 m_pTestPB->SetClickHdl(LINK(this, SwMailConfigPage, TestHdl));
+m_pSecureCB->SetClickHdl(LINK(this, SwMailConfigPage, SecureHdl));
 }
 
 SwMailConfigPage::~SwMailConfigPage()
@@ -227,6 +228,13 @@ IMPL_LINK_NOARG(SwMailConfigPage, TestHdl, Button*, void)
 ScopedVclPtrInstance(this)->Execute();
 }
 
+IMPL_LINK(SwMailConfigPage, SecureHdl, Button*, pBox, void)
+{
+bool bEnable = static_cast(pBox)->IsChecked();
+m_pConfigItem->SetSecureConnection(bEnable);
+m_pPortNF->SetValue(m_pConfigItem->GetMailPort());
+}
+
 SwTestAccountSettingsDialog::SwTestAccountSettingsDialog(SwMailConfigPage* 
pParent)
 : SfxModalDialog(pParent, "TestMailSettings", 
"modules/swriter/ui/testmailsettings.ui")
 , m_aCompletedImg(BitmapEx(RID_BMP_FORMULA_APPLY))
diff --git a/sw/source/uibase/inc/mailconfigpage.hxx 
b/sw/source/uibase/inc/mailconfigpage.hxx
index 063712110d89..616c4f409987 100644
--- a/sw/source/uibase/inc/mailconfigpage.hxx
+++ b/sw/source/uibase/inc/mailconfigpage.hxx
@@ -53,6 +53,7 @@ class SwMailConfigPage : public SfxTabPage
 DECL_LINK(ReplyToHdl, Button*, void);
 DECL_LINK(AuthenticationHdl, Button*, void);
 DECL_LINK(TestHdl, Button*, void);
+DECL_LINK(SecureHdl, Button*, void);
 
 public:
 SwMailConfigPage( vcl::Window* pParent, const SfxItemSet& rSet );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

[Michael Stahl]

 sw/source/core/txtnode/ndhints.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 61535f9b8a58f93e5f856284a007f96f4a905621
Author: Michael Stahl 
Date:   Mon Jan 29 20:01:25 2018 +0100

sw: speed up SwpHints::Check() by 2x

It's only necessary to compare each pair of nesting hints once.

Change-Id: I221bb0d63ffaf3d748b934788f93afe0f65ed961

diff --git a/sw/source/core/txtnode/ndhints.cxx 
b/sw/source/core/txtnode/ndhints.cxx
index fb360de42e62..5b5ebc7b123a 100644
--- a/sw/source/core/txtnode/ndhints.cxx
+++ b/sw/source/core/txtnode/ndhints.cxx
@@ -328,10 +328,10 @@ bool SwpHints::Check(bool bPortionsMerged) const
 // 9) nesting portion check
 if (pHtThis->IsNesting())
 {
-for ( size_t j = 0; j < Count(); ++j )
+for (size_t j = 0; j < i; ++j)
 {
 SwTextAttr const * const pOther( m_HintsByStart[j] );
-if ( pOther->IsNesting() &&  (i != j) )
+if (pOther->IsNesting())
 {
 SwComparePosition cmp = ComparePosition(
 pHtThis->GetStart(), *pHtThis->End(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits