[Libreoffice-bugs] [Bug 115362] New: LibreOffice 6.0 - libobasis6.0-fr-help-6.0.0.3-3.x86_64.rpm - Missing dependency
https://bugs.documentfoundation.org/show_bug.cgi?id=115362 Bug ID: 115362 Summary: LibreOffice 6.0 - libobasis6.0-fr-help-6.0.0.3-3.x86_64.rpm - Missing dependency Product: LibreOffice Version: 6.0.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sebastien.guiz...@gmail.com Description: After LibreOffice 6.0 installation, the installation of the french help (libobasis6.0-fr-help-6.0.0.3-3.x86_64.rpm) send the following error : rpm -i libobasis6.0-fr-help-6.0.0.3-3.x86_64.rpm error : Dépendances requises: libobasis6.0-fr >= 6.0.0.3 est nécessaire pour libobasis6.0-fr-help-6.0.0.3-3.x86_64 libobasis6.0-fr <= 6.0.0.3-3 est nécessaire pour libobasis6.0-fr-help-6.0.0.3-3.x86_64 Steps to Reproduce: 1. Install LibreOffice 6.0 rpms 2. Try install LibreOffice 6.0 french help Actual Results: UI not translated in French Expected Results: UI translated in French Reproducible: Always User Profile Reset: No Additional Info: OS = Fedora 27 User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109353] Listbox doesn't show value (background) if value is just selected (Linux/KDE)
https://bugs.documentfoundation.org/show_bug.cgi?id=109353 --- Comment #6 from Alex Kempshall--- I have my own application that reproduces this List Box problem. Reproduced this List Box problem with Kubuntu 17:10 which has LO 5.4.2.2 pre-installed. Reproduced this List Box problem on Slackware 14.2 with LO 5.4.2.2 running on kde4 when LO compiled with --enable-kde4. Same compiled version works correctly on Slackware 14.2 xfce. If compiled without --enable-kde4 List Box works successfully on Slackware 14.2 running kde4 Also noticed that If I click on a blank space on the form that the List Box repaints itself correctly. Also noticed that if I move the file libvclplug_kde4lo.so out of the path then logged out and back in the List Box works correctly. No idea what libvclplug_kde4lo.so offers kde users. Alex -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/itrform2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3171066a959b52cd483bb22a0d1046e633f092f6 Author: Stephan BergmannDate: Wed Jan 31 23:02:34 2018 +0100 USHRT_MAX -> SAL_MAX_UINT16 ...as nH needs to fit into the following SwPosSize::Height call's parameter of type sal_uInt16. And whatever the reason to check for < instead of <= USHRT_MAX... Change-Id: I0377d51e7411eef7913d951eb972214a8d8d5768 Reviewed-on: https://gerrit.libreoffice.org/49065 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx index e1ab681d6679..d29110519974 100644 --- a/sw/source/core/text/itrform2.cxx +++ b/sw/source/core/text/itrform2.cxx @@ -2388,7 +2388,7 @@ void SwTextFormatter::CalcFlyWidth( SwTextFormatInfo ) if( nNextTop > aInter.Bottom() ) { SwTwips nH = nNextTop - aInter.Top(); -if( nH < USHRT_MAX ) +if( nH < SAL_MAX_UINT16 ) pFly->Height( sal_uInt16( nH ) ); } if( nAscent < pFly->Height() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115325] Regression: Calc v6 opens .ODS file slower than v5
https://bugs.documentfoundation.org/show_bug.cgi?id=115325 --- Comment #7 from Mike Kaganski--- (In reply to Dan Dascalescu from comment #6) > Does my comparison make sense now? Absolutely. > What extra debugging information can I > provide to help track this issue? Well, now it's others' turn - to reproduce and confirm (I assume). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112743] Undo toolbar button not active after modifying page style
https://bugs.documentfoundation.org/show_bug.cgi?id=112743 cle...@gmail.com changed: What|Removed |Added Version|Inherited From OOo |5.4.3.2 release --- Comment #3 from cle...@gmail.com --- can reproduce with earlier version: Version: 5.4.3.2 (x64) Build-ID: 92a7159f7e4af62137622921e809f8546db437e5 CPU-Threads: 4; Betriebssystem:Windows 6.1; UI-Render: Standard; Gebietsschema: de-AT (de_AT); Calc: group changing "earliest affected" from "6.0.0.3 release" to "5.4.3.2 release" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94682] VIEWING: OpenGL text rendering performance.
https://bugs.documentfoundation.org/show_bug.cgi?id=94682 --- Comment #28 from kunzj...@yahoo.fr --- Tested again with version 6.0.0.3 windows x64. Testing config is as before: windows 10, 4K screen, NVidia GTX 970. The bug is still present. Excerpt from comment #12 is still applicable with updated approximate performance figures: If I display 5 x 2 pages on screen [with test file], and I try to scroll using the down arrow, the screen refreshes less than [1-2] time per second in openGL mode, vs. [5-10] times per second without openGL. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 Aron Budeachanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 --- Comment #4 from C Hemingway--- Created attachment 139489 --> https://bugs.documentfoundation.org/attachment.cgi?id=139489=edit Spreadsheet as XLSX; Conditional Formatting partial corruption (ODS to XLSX) Also note! There is a Bug in LO that - when a spreadsheet is saved to XLS/XLSX, the column format of the BOOLEAN VALUE column to custom format TRUE;TRUE;FALSE As noted in my other bug, this breaks the ISLOGICAL function, which factors heavily in my conditional formatting functions. Workaround - select all of Column S2 and convert back to BOOLEAN type. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 --- Comment #3 from C Hemingway--- Created attachment 139488 --> https://bugs.documentfoundation.org/attachment.cgi?id=139488=edit Spreadsheet as XLS; Conditional Formatting as beenlost (just used save-as to XLS) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 --- Comment #2 from C Hemingway--- Created attachment 139487 --> https://bugs.documentfoundation.org/attachment.cgi?id=139487=edit Spreadsheet as ODS with Conditional Formatting (prior to save as XLS) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102012] FILEOPEN DOCX Frame with table inside it positioned wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=102012 --- Comment #14 from Paolo Devoti--- Still true with libreoffice Version: 5.4.3.2 (x64) Build ID: 92a7159f7e4af62137622921e809f8546db437e5 CPU threads: 8; OS: Windows 6.1; UI render: default; Locale: it-IT (it_IT); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113142] Add "insert sheet" to the sheet list in LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=113142 Commit Notificationchanged: What|Removed |Added Whiteboard||target:6.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113142] Add "insert sheet" to the sheet list in LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=113142 --- Comment #6 from Commit Notification--- ozturkemre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/online/commit/?id=1c8d8107b2db41ee058c23542cd803e981b07317 tdf#113142 added insert sheet to the sheet list -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/dist
loleaflet/dist/spreadsheet.css|2 +- loleaflet/dist/toolbar/toolbar.js | 11 --- 2 files changed, 9 insertions(+), 4 deletions(-) New commits: commit 1c8d8107b2db41ee058c23542cd803e981b07317 Author: ozturkemreDate: Thu Feb 1 02:43:15 2018 +0300 tdf#113142 added insert sheet to the sheet list Change-Id: I7ec6a45bf7bc4e2daf545ab4f234c3a0c9fcbded Reviewed-on: https://gerrit.libreoffice.org/49070 Reviewed-by: pranavk Tested-by: pranavk diff --git a/loleaflet/dist/spreadsheet.css b/loleaflet/dist/spreadsheet.css index e97f6041..ed508632 100644 --- a/loleaflet/dist/spreadsheet.css +++ b/loleaflet/dist/spreadsheet.css @@ -12,7 +12,7 @@ .spreadsheet-tabs-container { margin: 0; padding: 0; - left: 132px; + left: 162px; right: 0; bottom: 33px; position: absolute; diff --git a/loleaflet/dist/toolbar/toolbar.js b/loleaflet/dist/toolbar/toolbar.js index 1bd8bb3d..aa9034e4 100644 --- a/loleaflet/dist/toolbar/toolbar.js +++ b/loleaflet/dist/toolbar/toolbar.js @@ -283,9 +283,12 @@ function onClick(id, item, subItem) { $('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft() + 60); } else if (id === 'prevrecord') { - $('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft() - 60); + $('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft() - 30); } else if (id === 'lastrecord') { + $('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').scrollLeft() + 120); + } + else if (id === 'insertpage') { $('#spreadsheet-tab-scroll').scrollLeft($('#spreadsheet-tab-scroll').prop('scrollWidth')); } else if (id.startsWith('menu:wrap:wrap-')) @@ -638,7 +641,8 @@ $(function () { {type: 'button', id: 'firstrecord', img: 'firstrecord', hidden: true, hint: _('First sheet')}, {type: 'button', id: 'prevrecord', img: 'prevrecord', hidden: true, hint: _('Previous sheet')}, {type: 'button', id: 'nextrecord', img: 'nextrecord', hidden: true, hint: _('Next sheet')}, - {type: 'button', id: 'lastrecord', img: 'lastrecord', hidden: true, hint: _('Last sheet')} + {type: 'button', id: 'lastrecord', img: 'lastrecord', hidden: true, hint: _('Last sheet')}, + {type: 'button', id: 'insertpage', img: 'insertpage', hidden:true, hint: _('Insert sheet')} ], onClick: function (e) { onClick(e.target); @@ -1537,6 +1541,7 @@ map.on('updateparts pagenumberchanged', function (e) { toolbar.show('nextrecord'); toolbar.show('prevrecord'); toolbar.show('lastrecord'); + toolbar.show('insertpage'); } }); @@ -1609,7 +1614,7 @@ map.on('updatepermission', function (e) { } } - var spreadsheetButtons = ['firstrecord', 'prevrecord', 'nextrecord', 'lastrecord']; + var spreadsheetButtons = ['firstrecord', 'prevrecord', 'nextrecord', 'lastrecord', 'insertpage']; var formulaBarButtons = ['sum', 'function']; var presentationButtons = ['insertpage', 'duplicatepage', 'deletepage']; var toolbarDownButtons = ['next', 'prev']; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/appl/module.cxx | 36 sfx2/source/control/msgpool.cxx |5 - sfx2/source/control/objface.cxx |6 +- 3 files changed, 25 insertions(+), 22 deletions(-) New commits: commit a0c2d1be6a5ce1edb2e8b64a96d7d4d0d92f310c Author: Noel GrandinDate: Tue Jan 16 15:43:05 2018 +0200 loplugin:useuniqueptr in SfxModule_Impl Change-Id: I218cd34aefcf8bfbc8a52379fb1e15ec2ef3ac31 Reviewed-on: https://gerrit.libreoffice.org/48700 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sfx2/source/appl/module.cxx b/sfx2/source/appl/module.cxx index 202a4391f5ad..38e9db653104 100644 --- a/sfx2/source/appl/module.cxx +++ b/sfx2/source/appl/module.cxx @@ -44,10 +44,10 @@ class SfxModule_Impl { public: -SfxSlotPool*pSlotPool; -SfxTbxCtrlFactArr_Impl* pTbxCtrlFac; -SfxStbCtrlFactArr_Impl* pStbCtrlFac; -SfxChildWinFactArr_Impl*pFactArr; +std::unique_ptr pSlotPool; +std::unique_ptr pTbxCtrlFac; +std::unique_ptr pStbCtrlFac; +std::unique_ptr pFactArr; OString maResName; SfxModule_Impl(); @@ -61,10 +61,10 @@ SfxModule_Impl::SfxModule_Impl() SfxModule_Impl::~SfxModule_Impl() { -delete pSlotPool; -delete pTbxCtrlFac; -delete pStbCtrlFac; -delete pFactArr; +pSlotPool.reset(); +pTbxCtrlFac.reset(); +pStbCtrlFac.reset(); +pFactArr.reset(); } SFX_IMPL_SUPERCLASS_INTERFACE(SfxModule, SfxShell) @@ -84,11 +84,7 @@ void SfxModule::Construct_Impl(const OString& rResName) { SfxApplication *pApp = SfxApplication::GetOrCreate(); pImpl = new SfxModule_Impl; -pImpl->pSlotPool = new SfxSlotPool(>GetAppSlotPool_Impl()); - -pImpl->pTbxCtrlFac=nullptr; -pImpl->pStbCtrlFac=nullptr; -pImpl->pFactArr=nullptr; +pImpl->pSlotPool.reset( new SfxSlotPool(>GetAppSlotPool_Impl()) ); pImpl->maResName = rResName; SetPool( >GetPool() ); @@ -110,7 +106,7 @@ std::locale SfxModule::GetResLocale() const SfxSlotPool* SfxModule::GetSlotPool() const { -return pImpl->pSlotPool; +return pImpl->pSlotPool.get(); } @@ -119,7 +115,7 @@ void SfxModule::RegisterChildWindow(SfxChildWinFactory *pFact) DBG_ASSERT( pImpl, "No real Module!" ); if (!pImpl->pFactArr) -pImpl->pFactArr = new SfxChildWinFactArr_Impl; +pImpl->pFactArr.reset( new SfxChildWinFactArr_Impl ); for (size_t nFactory=0; nFactorypFactArr->size(); ++nFactory) { @@ -138,7 +134,7 @@ void SfxModule::RegisterChildWindow(SfxChildWinFactory *pFact) void SfxModule::RegisterToolBoxControl( const SfxTbxCtrlFactory& rFact ) { if (!pImpl->pTbxCtrlFac) -pImpl->pTbxCtrlFac = new SfxTbxCtrlFactArr_Impl; +pImpl->pTbxCtrlFac.reset( new SfxTbxCtrlFactArr_Impl ); #ifdef DBG_UTIL for ( size_t n=0; npTbxCtrlFac->size(); n++ ) @@ -159,7 +155,7 @@ void SfxModule::RegisterToolBoxControl( const SfxTbxCtrlFactory& rFact ) void SfxModule::RegisterStatusBarControl( const SfxStbCtrlFactory& rFact ) { if (!pImpl->pStbCtrlFac) -pImpl->pStbCtrlFac = new SfxStbCtrlFactArr_Impl; +pImpl->pStbCtrlFac.reset( new SfxStbCtrlFactArr_Impl ); #ifdef DBG_UTIL for ( size_t n=0; npStbCtrlFac->size(); n++ ) @@ -179,18 +175,18 @@ void SfxModule::RegisterStatusBarControl( const SfxStbCtrlFactory& rFact ) SfxTbxCtrlFactArr_Impl* SfxModule::GetTbxCtrlFactories_Impl() const { -return pImpl->pTbxCtrlFac; +return pImpl->pTbxCtrlFac.get(); } SfxStbCtrlFactArr_Impl* SfxModule::GetStbCtrlFactories_Impl() const { -return pImpl->pStbCtrlFac; +return pImpl->pStbCtrlFac.get(); } SfxChildWinFactArr_Impl* SfxModule::GetChildWinFactories_Impl() const { -return pImpl->pFactArr; +return pImpl->pFactArr.get(); } VclPtr SfxModule::CreateTabPage( sal_uInt16, vcl::Window*, const SfxItemSet& ) diff --git a/sfx2/source/control/msgpool.cxx b/sfx2/source/control/msgpool.cxx index f9290e1ebc80..683c00ae98b4 100644 --- a/sfx2/source/control/msgpool.cxx +++ b/sfx2/source/control/msgpool.cxx @@ -44,7 +44,10 @@ SfxSlotPool::SfxSlotPool(SfxSlotPool *pParent) SfxSlotPool::~SfxSlotPool() { _pParentPool = nullptr; -for ( SfxInterface *pIF = FirstInterface(); pIF; pIF = FirstInterface() ) +// swap out _vInterfaces because ~SfxInterface() might call ReleaseInterface() +std::vector tmpInterfaces; +tmpInterfaces.swap(_vInterfaces); +for ( SfxInterface *pIF : tmpInterfaces ) delete pIF; } diff --git a/sfx2/source/control/objface.cxx b/sfx2/source/control/objface.cxx index aa063e1fd07a..d6af5c21d0b7 100644 --- a/sfx2/source/control/objface.cxx +++ b/sfx2/source/control/objface.cxx @@ -201,7 +201,11 @@ SfxInterface::~SfxInterface() if ( bRegistered ) { if ( pMod
[Libreoffice-commits] core.git: compilerplugins/clang lotuswordpro/inc lotuswordpro/source
compilerplugins/clang/datamembershadow.cxx |2 -- lotuswordpro/inc/xfilter/xfcellstyle.hxx |1 - lotuswordpro/source/filter/xfilter/xfparastyle.cxx |2 -- 3 files changed, 5 deletions(-) New commits: commit 0913b2af7d2443099626f65f6105fc67e5fccb56 Author: Noel GrandinDate: Wed Jan 31 16:13:48 2018 +0200 loplugin:datamembershadow in XFCellStyle looks like the subclass member is never written to, so I'm going to assume this was a bug Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514 Reviewed-on: https://gerrit.libreoffice.org/49001 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx index 5843085b43c0..210ee1c9a0d1 100644 --- a/compilerplugins/clang/datamembershadow.cxx +++ b/compilerplugins/clang/datamembershadow.cxx @@ -63,8 +63,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl) return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/framework/source/uielement/popuptoolbarcontroller.cxx")) return true; -if (loplugin::isSamePathname(aFileName, SRCDIR "/lotuswordpro/inc/xfilter/xfcellstyle.hxx")) -return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/sc/source/ui/vba/vbastyles.hxx")) return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/sd/inc/Outliner.hxx")) diff --git a/lotuswordpro/inc/xfilter/xfcellstyle.hxx b/lotuswordpro/inc/xfilter/xfcellstyle.hxx index ee3a2c6a8b4a..6dc5724e7784 100644 --- a/lotuswordpro/inc/xfilter/xfcellstyle.hxx +++ b/lotuswordpro/inc/xfilter/xfcellstyle.hxx @@ -134,7 +134,6 @@ public: private: OUString m_strDataStyle; -OUString m_strParentStyleName; enumXFAlignType m_eHoriAlign; enumXFAlignType m_eVertAlign; diff --git a/lotuswordpro/source/filter/xfilter/xfparastyle.cxx b/lotuswordpro/source/filter/xfilter/xfparastyle.cxx index 04de9138e488..97ac01022f80 100644 --- a/lotuswordpro/source/filter/xfilter/xfparastyle.cxx +++ b/lotuswordpro/source/filter/xfilter/xfparastyle.cxx @@ -103,8 +103,6 @@ XFParaStyle::XFParaStyle(const XFParaStyle& other) , m_nFlag(other.m_nFlag) , m_bNumberRight(other.m_bNumberRight) { -m_strParentStyleName = other.m_strParentStyleName; - if( other.m_pBorders ) m_pBorders = new XFBorders(*other.m_pBorders); else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 5 commits - canvas/source cppuhelper/source desktop/source desktop/win32 dtrans/source embeddedobj/source include/cppuhelper
canvas/source/directx/dx_winstuff.hxx |5 - cppuhelper/source/interfacecontainer.cxx |4 desktop/source/app/app.cxx |7 --- desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx |7 --- desktop/source/lib/init.cxx|7 --- desktop/win32/source/QuickStart/QuickStart.cxx |6 -- desktop/win32/source/guistdio/guistdio.inc |6 -- desktop/win32/source/unoinfo.cxx |6 -- dtrans/source/win32/clipb/MtaOleClipb.cxx |5 - dtrans/source/win32/clipb/MtaOleClipb.hxx |6 -- dtrans/source/win32/clipb/WinClipbImpl.cxx |6 -- dtrans/source/win32/clipb/WinClipbImpl.hxx |6 -- dtrans/source/win32/dnd/globals.hxx|6 -- dtrans/source/win32/dnd/target.hxx |6 -- dtrans/source/win32/dtobj/DTransHelper.hxx |6 -- dtrans/source/win32/dtobj/DataFmtTransl.cxx|7 --- dtrans/source/win32/dtobj/DataFmtTransl.hxx|6 -- dtrans/source/win32/dtobj/Fetc.hxx |6 -- dtrans/source/win32/dtobj/FetcList.hxx |7 +-- dtrans/source/win32/dtobj/FmtFilter.cxx|7 --- dtrans/source/win32/dtobj/FmtFilter.hxx|6 -- dtrans/source/win32/dtobj/TxtCnvtHlp.hxx |6 -- dtrans/source/win32/dtobj/XNotifyingDataObject.hxx |6 -- dtrans/source/win32/dtobj/XTDataObject.cxx |7 --- dtrans/source/win32/dtobj/XTDataObject.hxx |6 -- dtrans/source/win32/ftransl/ftransl.cxx|7 --- dtrans/source/win32/misc/ImplHelper.cxx|6 -- dtrans/source/win32/misc/ImplHelper.hxx|6 -- embeddedobj/source/msole/platform.h|9 - include/cppuhelper/propertysetmixin.hxx| 10 -- include/cppuhelper/propshlp.hxx|3 --- 31 files changed, 1 insertion(+), 193 deletions(-) New commits: commit dad539c0ddeb7bd721c04450138ef2acb934809e Author: Mike KaganskiDate: Wed Jan 31 12:43:50 2018 +0300 embeddedobj: MSVC: pragma warning: make more specific, remove obsolete Change-Id: Iefcaf1f5ae73050300879fff0855f709c5f8a30d Reviewed-on: https://gerrit.libreoffice.org/48975 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/embeddedobj/source/msole/platform.h b/embeddedobj/source/msole/platform.h index 59557a7cf5c0..b93afd79030c 100644 --- a/embeddedobj/source/msole/platform.h +++ b/embeddedobj/source/msole/platform.h @@ -23,21 +23,12 @@ #define STRICT #define _ATL_APARTMENT_THREADED -#if defined _MSC_VER -#pragma warning(push, 1) -#pragma warning(disable: 4548 4555 4917) -#endif - #if !defined WIN32_LEAN_AND_MEAN # define WIN32_LEAN_AND_MEAN #endif #include #include -#if defined _MSC_VER -#pragma warning(pop) -#endif - #endif /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit f901bc5ac0d5812e7f2ec3fd68a266297cb41255 Author: Mike Kaganski Date: Wed Jan 31 12:41:45 2018 +0300 dtrans: MSVC: pragma warning: make more specific, remove obsolete Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958 Reviewed-on: https://gerrit.libreoffice.org/48974 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/dtrans/source/win32/clipb/MtaOleClipb.cxx b/dtrans/source/win32/clipb/MtaOleClipb.cxx index 145ae4e739c0..36afcbe99a49 100644 --- a/dtrans/source/win32/clipb/MtaOleClipb.cxx +++ b/dtrans/source/win32/clipb/MtaOleClipb.cxx @@ -30,11 +30,6 @@ hidden window and forward these requests via window messages. */ -#ifdef _MSC_VER -#pragma warning( disable : 4786 ) // identifier was truncated to 'number' - // characters in the debug information -#endif - #if !defined WINVER #define WINVER 0x0400 #endif diff --git a/dtrans/source/win32/clipb/MtaOleClipb.hxx b/dtrans/source/win32/clipb/MtaOleClipb.hxx index 5c7dbfa5c6f5..abab29bf9717 100644 --- a/dtrans/source/win32/clipb/MtaOleClipb.hxx +++ b/dtrans/source/win32/clipb/MtaOleClipb.hxx @@ -23,13 +23,7 @@ #include #include -#if defined _MSC_VER -#pragma warning(push,1) -#endif #include -#if defined _MSC_VER -#pragma warning(pop) -#endif // the Mta-Ole clipboard class is for internal use only! // only one instance of this class should be created, the diff --git a/dtrans/source/win32/clipb/WinClipbImpl.cxx
[Libreoffice-commits] core.git: 3 commits - cli_ure/source configmgr/source dbaccess/source dbaccess/win32 include/dbaccess
cli_ure/source/climaker/climaker_emit.cxx|2 - cli_ure/source/uno_bridge/cli_bridge.cxx |3 -- cli_ure/source/uno_bridge/cli_data.cxx |2 - cli_ure/source/uno_bridge/cli_proxy.h|2 - configmgr/source/winreg.cxx |6 dbaccess/source/ui/browser/genericcontroller.cxx | 29 --- dbaccess/source/ui/dlg/adodatalinks.cxx |7 - dbaccess/win32/source/odbcconfig/odbcconfig.cxx |9 --- include/dbaccess/genericcontroller.hxx |6 9 files changed, 2 insertions(+), 64 deletions(-) New commits: commit 6b33a41fcce8e045e4dc9a6775084f8555afaf41 Author: Mike KaganskiDate: Wed Jan 31 12:34:32 2018 +0300 dbaccess: MSVC: pragma warning: make more specific, remove obsolete Change-Id: I0066b2de769a412cb04bcec7cdd8401f42b9dcf3 Reviewed-on: https://gerrit.libreoffice.org/48972 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/dbaccess/source/ui/browser/genericcontroller.cxx b/dbaccess/source/ui/browser/genericcontroller.cxx index dc66cd102eb0..0c3ebaf937e3 100644 --- a/dbaccess/source/ui/browser/genericcontroller.cxx +++ b/dbaccess/source/ui/browser/genericcontroller.cxx @@ -176,35 +176,6 @@ OGenericUnoController::OGenericUnoController(const Reference< XComponentContext } } -#ifdef _MSC_VER - -#pragma warning(push) -#pragma warning(disable:4702) - -OGenericUnoController::OGenericUnoController() -:OGenericUnoController_Base( getMutex() ) -,m_pView(nullptr) -#ifdef DBG_UTIL -,m_bDescribingSupportedFeatures( false ) -#endif -,m_aAsyncInvalidateAll(LINK(this, OGenericUnoController, OnAsyncInvalidateAll)) -,m_aAsyncCloseTask(LINK(this, OGenericUnoController, OnAsyncCloseTask)) -,m_aCurrentFrame( *this ) -,m_bPreview(false) -,m_bReadOnly(false) -,m_bCurrentlyModified(false) -{ -SAL_WARN("dbaccess.ui", "OGenericUnoController::OGenericUnoController: illegal call!" ); -// This ctor only exists because the MSVC compiler complained about an unresolved external -// symbol. It should not be used at all. Since using it yields strange runtime problems, -// we simply abort here. -abort(); -} - -#pragma warning(pop) - -#endif - OGenericUnoController::~OGenericUnoController() { diff --git a/dbaccess/source/ui/dlg/adodatalinks.cxx b/dbaccess/source/ui/dlg/adodatalinks.cxx index 4e0db429b773..72fd0beb0e6d 100644 --- a/dbaccess/source/ui/dlg/adodatalinks.cxx +++ b/dbaccess/source/ui/dlg/adodatalinks.cxx @@ -19,17 +19,10 @@ #if defined(_WIN32) -#if defined _MSC_VER -#pragma warning(push, 1) -#pragma warning(disable: 4917) -#endif // LO/windows.h conflict #undef WB_LEFT #undef WB_RIGHT #include -#if defined _MSC_VER -#pragma warning(push, 1) -#endif #include diff --git a/dbaccess/win32/source/odbcconfig/odbcconfig.cxx b/dbaccess/win32/source/odbcconfig/odbcconfig.cxx index 73eb04a74d57..f9add1bef2f1 100644 --- a/dbaccess/win32/source/odbcconfig/odbcconfig.cxx +++ b/dbaccess/win32/source/odbcconfig/odbcconfig.cxx @@ -18,21 +18,12 @@ */ -#ifdef _MSC_VER -#pragma warning(push, 1) -#pragma warning(disable:4005) -#endif - #if !defined WIN32_LEAN_AND_MEAN # define WIN32_LEAN_AND_MEAN #endif #include #include -#ifdef _MSC_VER -#pragma warning(pop) -#endif - // the name of the library which contains the SQLManageDataSources function #define ODBC_UI_LIB_NAMEL"ODBCCP32.DLL" diff --git a/include/dbaccess/genericcontroller.hxx b/include/dbaccess/genericcontroller.hxx index de8a586c7b6e..52fc8bcbd994 100644 --- a/include/dbaccess/genericcontroller.hxx +++ b/include/dbaccess/genericcontroller.hxx @@ -294,6 +294,7 @@ namespace dbaui // methods OGenericUnoController( const css::uno::Reference< css::uno::XComponentContext >& _rM ); +OGenericUnoController() = delete; const ::comphelper::NamedValueCollection& getInitParams() const { return m_aInitParameters; } @@ -530,11 +531,6 @@ namespace dbaui virtual void SAL_CALL removeKeyHandler( const css::uno::Reference< css::awt::XKeyHandler >& xHandler ) override; virtual void SAL_CALL addMouseClickHandler( const css::uno::Reference< css::awt::XMouseClickHandler >& xHandler ) override; virtual void SAL_CALL removeMouseClickHandler( const css::uno::Reference< css::awt::XMouseClickHandler >& xHandler ) override; - -protected: -#ifdef _MSC_VER -OGenericUnoController();// never implemented -#endif }; } commit 8f43170f121443e8320d42c21b3dba8ffe8112b3 Author: Mike Kaganski Date: Wed Jan 31 12:26:39 2018 +0300 configmgr: MSVC: pragma warning: make more specific, remove obsolete Change-Id: I7f98fa855ff521db42bf9b379bfac3d430791ae0 Reviewed-on:
[Libreoffice-bugs] [Bug 115361] strange keyboard short-cut keys in the Japanese version
https://bugs.documentfoundation.org/show_bug.cgi?id=115361 --- Comment #1 from h.horik...@aist.go.jp --- Created attachment 139486 --> https://bugs.documentfoundation.org/attachment.cgi?id=139486=edit screen shot of the "strange" menu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115361] New: strange keyboard short-cut keys in the Japanese version
https://bugs.documentfoundation.org/show_bug.cgi?id=115361 Bug ID: 115361 Summary: strange keyboard short-cut keys in the Japanese version Product: LibreOffice Version: 6.0.0.3 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Localization Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: h.horik...@aist.go.jp Description: procedure: 1. start LibreOffice 2. close "start center" window 3. click "File" on the menu bar that appera on the top of screen The menu that appears after clicking the "File" contains strange keyboard short cuts, almost all of which are impossible to type. NOTE: this bug appears after installing the Japanese language pack to the LibreOffice Steps to Reproduce: 1. start LibreOffice 2. close "start center" window 3. click "File" on the menu bar that appera on the top of screen The menu that appears after clicking the "File" contains strange keyboard short cuts, almost all of which are impossible to type. NOTE: this bug appears after installing the Japanese language pack to the LibreOffice Actual Results: The menu that appears after clicking the "File" contains strange keyboard short cuts, almost all of which are impossible to type. Expected Results: The menu that appears after clicking the "File" should show appropriate keyboard short cuts all of which can be typed. Reproducible: Always User Profile Reset: No Additional Info: バージョン: 6.0.0.3 Build ID: 64a0f66915f38c6217de274f0aa8e15618924765 CPU threads: 24; OS:Mac OS X 10.13.3; UI render: default; ロケール: ja-JP (ja_JP.UTF-8); Calc: group User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.119 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115303] FILESAVE CALC Freeze Cells fails when window frame abuts frozen pane
https://bugs.documentfoundation.org/show_bug.cgi?id=115303 --- Comment #3 from duncan...@gmail.com --- Alex, apologies for my slow response. Glad you were able to duplicate the problem in the absence of a file from me. Good luck with a fix. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115360] New: FILESAVE: Don't use GIF for objects when saving as HTML
https://bugs.documentfoundation.org/show_bug.cgi?id=115360 Bug ID: 115360 Summary: FILESAVE: Don't use GIF for objects when saving as HTML Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vovik-...@bk.ru Description: Currently when saving documents as HTML, graphical objects are rendered as GIFs with poor quality and dithering artifacts. This format is extremely outdated. Please use PNG or SVG instead. Steps to Reproduce: Add some drawing object to the document, save as HTML. Actual Results: Object is rendered into GIF Expected Results: Object is rendered into some less obsolete format. Like PNG, or SVG if object is vector in nature. Preferably with GUI option to choose before saving. Reproducible: Always User Profile Reset: Yes Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115343] No way to toggle mbEmbedImages true to write HTML with embedded images
https://bugs.documentfoundation.org/show_bug.cgi?id=115343 Vladimirchanged: What|Removed |Added CC||vovik-...@bk.ru --- Comment #1 from Vladimir --- I agree, there seems to be no [obvious] way to toggle image embedding when saving document as HTML. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 94682] VIEWING: OpenGL text rendering performance.
https://bugs.documentfoundation.org/show_bug.cgi?id=94682 --- Comment #27 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102012] FILEOPEN DOCX Frame with table inside it positioned wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=102012 --- Comment #13 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99510] Page inner and outer margins reversed when printing in Brochure mode
https://bugs.documentfoundation.org/show_bug.cgi?id=99510 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105521] Content gets pasted in two table cells when one cell is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=105521 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105301] sort options not remembered thoroughly in saved document
https://bugs.documentfoundation.org/show_bug.cgi?id=105301 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83248] PRINTING: "Single-line" text box always printed in black
https://bugs.documentfoundation.org/show_bug.cgi?id=83248 --- Comment #23 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105588] SVG exported from Impress or Draw cannot be correctly inserted as an image into another document
https://bugs.documentfoundation.org/show_bug.cgi?id=105588 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80796] EDITING: Pasting Draw8 drawing object from Draw into Writer creates an extra new line
https://bugs.documentfoundation.org/show_bug.cgi?id=80796 --- Comment #14 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69515] FILEOPEN: Table in DOCX floating frame wrongly positioned ( framePr ignored, regression)
https://bugs.documentfoundation.org/show_bug.cgi?id=69515 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42316] Creating a new document from a template removes the signature from all Macros
https://bugs.documentfoundation.org/show_bug.cgi?id=42316 --- Comment #9 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115325] Regression: Calc v6 opens .ODS file slower than v5
https://bugs.documentfoundation.org/show_bug.cgi?id=115325 --- Comment #6 from Dan Dascalescu--- To make absolutely sure I'm using the TDF build for v5, I've run `apt remove libreoffice5.4; apt autoremove`, then downloaded http://mirror.clarkson.edu/tdf/libreoffice/stable/5.4.4/deb/x86_64/LibreOffice_5.4.4_Linux_x86-64_deb.tar.gz and installed it. I'm still seeing the same speed difference from the original screencast. Does my comparison make sense now? What extra debugging information can I provide to help track this issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115358] LibreOffice 6.0 language pack missing dependencies
https://bugs.documentfoundation.org/show_bug.cgi?id=115358 Kevin Suochanged: What|Removed |Added Summary|LibreOffice 6.0 |LibreOffice 6.0 language ||pack missing dependencies --- Comment #1 from Kevin Suo --- Updated summary to reflect the real issue of the bug. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa test/source
sc/qa/extras/scdatapilottableobj.cxx | 64 - test/source/sheet/xdatapilotdescriptor.cxx |7 --- 2 files changed, 28 insertions(+), 43 deletions(-) New commits: commit e587def20d1735474857f56dd3d2c06cf7673db3 Author: Jens CarlDate: Wed Jan 31 21:10:56 2018 + Remove shared mxComponent in scdatapilottableobj Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331 Reviewed-on: https://gerrit.libreoffice.org/49061 Tested-by: Jenkins Reviewed-by: Jens Carl diff --git a/sc/qa/extras/scdatapilottableobj.cxx b/sc/qa/extras/scdatapilottableobj.cxx index b7919b6890c6..ebc14b04191b 100644 --- a/sc/qa/extras/scdatapilottableobj.cxx +++ b/sc/qa/extras/scdatapilottableobj.cxx @@ -8,11 +8,12 @@ */ #include +#include +#include #include #include -#include -#include +#include #include #include #include @@ -24,10 +25,11 @@ using namespace css::uno; namespace sc_apitest { -#define NUMBER_OF_TESTS 16 - -class ScDataPilotTableObj : public CalcUnoApiTest, public apitest::XDataPilotDescriptor, public apitest::XDataPilotTable, -public apitest::XNamed, public apitest::XDataPilotTable2 +class ScDataPilotTableObj : public CalcUnoApiTest, +public apitest::XDataPilotDescriptor, +public apitest::XDataPilotTable, +public apitest::XDataPilotTable2, +public apitest::XNamed { public: ScDataPilotTableObj(); @@ -39,9 +41,8 @@ public: virtual uno::Reference< uno::XInterface > getSheets() override; CPPUNIT_TEST_SUITE(ScDataPilotTableObj); -CPPUNIT_TEST(testRefresh); -//CPPUNIT_TEST(testGetHiddenFields); -CPPUNIT_TEST(testGetOutputRange); + +// XDataPilotDescriptor CPPUNIT_TEST(testSourceRange); CPPUNIT_TEST(testTag); CPPUNIT_TEST(testGetFilterDescriptor); @@ -50,22 +51,28 @@ public: CPPUNIT_TEST(testGetRowFields); CPPUNIT_TEST(testGetPageFields); CPPUNIT_TEST(testGetDataFields); -CPPUNIT_TEST(testGetName); -CPPUNIT_TEST(testSetName); +//CPPUNIT_TEST(testGetHiddenFields); + +// XDataPilotTable +CPPUNIT_TEST(testGetOutputRange); +CPPUNIT_TEST(testRefresh); + +// XDataPilotTable2 CPPUNIT_TEST(testGetDrillDownData); CPPUNIT_TEST(testInsertDrillDownSheet); CPPUNIT_TEST(testGetPositionData); CPPUNIT_TEST(testGetOutputRangeByType); + +// XNamed +CPPUNIT_TEST(testGetName); +CPPUNIT_TEST(testSetName); + CPPUNIT_TEST_SUITE_END(); private: -static sal_Int32 nTest; -static uno::Reference< lang::XComponent > mxComponent; +uno::Reference< lang::XComponent > mxComponent; }; -sal_Int32 ScDataPilotTableObj::nTest = 0; -uno::Reference< lang::XComponent > ScDataPilotTableObj::mxComponent; - ScDataPilotTableObj::ScDataPilotTableObj() : CalcUnoApiTest("/sc/qa/extras/testdocuments"), apitest::XNamed("DataPilotTable") @@ -74,12 +81,6 @@ ScDataPilotTableObj::ScDataPilotTableObj() uno::Reference< uno::XInterface > ScDataPilotTableObj::init() { -OUString aFileURL; -createFileURL("ScDataPilotTableObj.ods", aFileURL); -if(!mxComponent.is()) -mxComponent = loadFromDesktop(aFileURL, "com.sun.star.sheet.SpreadsheetDocument"); -CPPUNIT_ASSERT(mxComponent.is()); - uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, UNO_QUERY_THROW); CPPUNIT_ASSERT_MESSAGE("no calc document", xDoc.is()); @@ -113,12 +114,6 @@ uno::Reference< uno::XInterface > ScDataPilotTableObj::getSheets() uno::Reference< uno::XInterface > ScDataPilotTableObj::initDP2() { -OUString aFileURL; -createFileURL("ScDataPilotTableObj.ods", aFileURL); -if(!mxComponent.is()) -mxComponent = loadFromDesktop(aFileURL, "com.sun.star.sheet.SpreadsheetDocument"); -CPPUNIT_ASSERT(mxComponent.is()); - uno::Reference< sheet::XSpreadsheetDocument > xDoc(mxComponent, UNO_QUERY_THROW); uno::Reference< container::XIndexAccess > xIndex (xDoc->getSheets(), UNO_QUERY_THROW); uno::Reference< sheet::XSpreadsheet > xSheet( xIndex->getByIndex(0), UNO_QUERY_THROW); @@ -143,19 +138,16 @@ uno::Reference< uno::XInterface > ScDataPilotTableObj::initDP2() void ScDataPilotTableObj::setUp() { -nTest++; -CPPUNIT_ASSERT(nTest <= NUMBER_OF_TESTS); CalcUnoApiTest::setUp(); +// create a calc document +OUString aFileURL; +createFileURL("ScDataPilotTableObj.ods", aFileURL); +mxComponent = loadFromDesktop(aFileURL, "com.sun.star.sheet.SpreadsheetDocument"); } void ScDataPilotTableObj::tearDown() { -if (nTest == NUMBER_OF_TESTS) -{ -closeDocument(mxComponent); -mxComponent.clear(); -} - +closeDocument(mxComponent); CalcUnoApiTest::tearDown(); } diff --git a/test/source/sheet/xdatapilotdescriptor.cxx
[Libreoffice-bugs] [Bug 78326] Can't delete a table in Impress/Draw if cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=78326 Regina Henschelchanged: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #12 from Regina Henschel --- Workaround for deleting: Click into the table, then nothing is selected. Move the mouse to the edge of the table till the cursor becomes a cross. Click. Now only the frame is selected and you can press Del-key to delete the table. This does not resolve this bug report, because deleting without mouse is missing and "delete table" command similar to Writer is missing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115359] New: Table easily falls off slide when inserting additional rows/ columns in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=115359 Bug ID: 115359 Summary: Table easily falls off slide when inserting additional rows/columns in Impress Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: libreoffice-ux-adv...@lists.freedesktop.org Blocks: 100366 Created attachment 139484 --> https://bugs.documentfoundation.org/attachment.cgi?id=139484=edit Screenshot - Create a 2x2 table in Impress. - Insert 4 extra columns. => Table badly falls off to the right of the slide. If a 2x6 (row x column) table is created right away, it fits much better. Basically, the table should never extend outside a slide when the size is increased indirectly. However, I'm not sure what kind of algorithm the increase/repositioning follow. Should it be extended in the direction where the new rows/columns are added? Or should it stay centered over the original position? Or maybe resize in both directions proportionally? Dear UX team, are there any usability practices to follow here? Observed using LO 6.0.0.3 & 3.3.0 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Aron Budeachanged: What|Removed |Added Depends on||115359 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115359 [Bug 115359] Table easily falls off slide when inserting additional rows/columns in Impress -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 115359] New: Table easily falls off slide when inserting additional rows/ columns in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=115359 Bug ID: 115359 Summary: Table easily falls off slide when inserting additional rows/columns in Impress Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Impress Assignee: libreoffice-b...@lists.freedesktop.org Reporter: ba...@caesar.elte.hu CC: libreoffice-ux-advise@lists.freedesktop.org Blocks: 100366 Created attachment 139484 --> https://bugs.documentfoundation.org/attachment.cgi?id=139484=edit Screenshot - Create a 2x2 table in Impress. - Insert 4 extra columns. => Table badly falls off to the right of the slide. If a 2x6 (row x column) table is created right away, it fits much better. Basically, the table should never extend outside a slide when the size is increased indirectly. However, I'm not sure what kind of algorithm the increase/repositioning follow. Should it be extended in the direction where the new rows/columns are added? Or should it stay centered over the original position? Or maybe resize in both directions proportionally? Dear UX team, are there any usability practices to follow here? Observed using LO 6.0.0.3 & 3.3.0 / Windows 7. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 83538] Formatting table in Impress doesn't works correctly (impress)
https://bugs.documentfoundation.org/show_bug.cgi?id=83538 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98692] EDITING Cannot insert image in table cell (Draw and Impress)
https://bugs.documentfoundation.org/show_bug.cgi?id=98692 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74142] FORMATTING: Impress default table design options are not ' Impressive'
https://bugs.documentfoundation.org/show_bug.cgi?id=74142 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113955] EDITING: embedded table changes the style after editing it
https://bugs.documentfoundation.org/show_bug.cgi?id=113955 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85436] Table Insertion bordering inconsistency
https://bugs.documentfoundation.org/show_bug.cgi?id=85436 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112068] EDITING: Undo won't work as expected after (trying to) insert a nested table (and undoing it)
https://bugs.documentfoundation.org/show_bug.cgi?id=112068 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72412] Tables in Impress: when the background is changed, the font size changes
https://bugs.documentfoundation.org/show_bug.cgi?id=72412 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72203] EDITING: in a table: moving upwards should go to the last line of the cell, not to the first
https://bugs.documentfoundation.org/show_bug.cgi?id=72203 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100366] [META] Impress/Draw table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=100366 Aron Budeachanged: What|Removed |Added Depends on||83538, 72412, 46917, 72203, ||85436, 72113, 98692, 74142, ||112068, 113955 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=46917 [Bug 46917] FORMATTING: Inserted 'Tables' in presentation respond poorly for configuration changes https://bugs.documentfoundation.org/show_bug.cgi?id=72113 [Bug 72113] FORMATTING: Impress/Presentation table default font size (18pt) and (?) font name (Arial) not editable https://bugs.documentfoundation.org/show_bug.cgi?id=72203 [Bug 72203] EDITING: in a table: moving upwards should go to the last line of the cell, not to the first https://bugs.documentfoundation.org/show_bug.cgi?id=72412 [Bug 72412] Tables in Impress: when the background is changed, the font size changes https://bugs.documentfoundation.org/show_bug.cgi?id=74142 [Bug 74142] FORMATTING: Impress default table design options are not 'Impressive' https://bugs.documentfoundation.org/show_bug.cgi?id=83538 [Bug 83538] Formatting table in Impress doesn't works correctly (impress) https://bugs.documentfoundation.org/show_bug.cgi?id=85436 [Bug 85436] Table Insertion bordering inconsistency https://bugs.documentfoundation.org/show_bug.cgi?id=98692 [Bug 98692] EDITING Cannot insert image in table cell (Draw and Impress) https://bugs.documentfoundation.org/show_bug.cgi?id=112068 [Bug 112068] EDITING: Undo won't work as expected after (trying to) insert a nested table (and undoing it) https://bugs.documentfoundation.org/show_bug.cgi?id=113955 [Bug 113955] EDITING: embedded table changes the style after editing it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72113] FORMATTING: Impress/Presentation table default font size (18pt ) and (?) font name (Arial) not editable
https://bugs.documentfoundation.org/show_bug.cgi?id=72113 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46917] FORMATTING: Inserted 'Tables' in presentation respond poorly for configuration changes
https://bugs.documentfoundation.org/show_bug.cgi?id=46917 Aron Budeachanged: What|Removed |Added Blocks||100366 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100366 [Bug 100366] [META] Impress/Draw table bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78326] Can't delete a table in Impress/Draw if cells are selected
https://bugs.documentfoundation.org/show_bug.cgi?id=78326 Aron Budeachanged: What|Removed |Added CC||johnny.heik...@yahoo.com --- Comment #11 from Aron Budea --- *** Bug 90518 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90518] EDITING: Cannot delete tables
https://bugs.documentfoundation.org/show_bug.cgi?id=90518 Aron Budeachanged: What|Removed |Added Status|NEW |RESOLVED CC||ba...@caesar.elte.hu Resolution|--- |DUPLICATE --- Comment #10 from Aron Budea --- *** This bug has been marked as a duplicate of bug 78326 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=108226 Aron Budeachanged: What|Removed |Added Depends on||115209 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115209 [Bug 115209] Impress: Table rendering incorrect - blue background of the cells -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115209] Impress: Table rendering incorrect - blue background of the cells
https://bugs.documentfoundation.org/show_bug.cgi?id=115209 Aron Budeachanged: What|Removed |Added Blocks||108226 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108226 [Bug 108226] [META] PPTX (OOXML) bug tracker -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115209] Impress: Table rendering incorrect - blue background of the cells
https://bugs.documentfoundation.org/show_bug.cgi?id=115209 Aron Budeachanged: What|Removed |Added CC||ba...@caesar.elte.hu Attachment #139337|application/zip |application/vnd.openxmlform mime type||ats-officedocument.presenta ||tionml.presentation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/format.hxx |2 - starmath/source/cfgitem.cxx | 71 +++- starmath/source/format.cxx | 64 --- 3 files changed, 70 insertions(+), 67 deletions(-) New commits: commit 1056f14525c5f2cf2e73d461b1aa5e7d763cd1d0 Author: Takeshi AbeDate: Thu Feb 1 00:00:06 2018 +0900 starmath: Put GetDefaultFontName() in an unnamed namespace Change-Id: I877e1c9b33ae240a2e8ac9972a6bc45e0848ee28 Reviewed-on: https://gerrit.libreoffice.org/49027 Tested-by: Jenkins Reviewed-by: Takeshi Abe diff --git a/starmath/inc/format.hxx b/starmath/inc/format.hxx index 362069900414..7b342a41195d 100644 --- a/starmath/inc/format.hxx +++ b/starmath/inc/format.hxx @@ -88,8 +88,6 @@ enum class SmHorAlign { Right }; -OUString GetDefaultFontName( LanguageType nLang, sal_uInt16 nIdent ); - class SmFormat : public SfxBroadcaster { SmFace vFont[FNT_END + 1]; diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx index 170bfe84b796..883f6f6d120b 100644 --- a/starmath/source/cfgitem.cxx +++ b/starmath/source/cfgitem.cxx @@ -17,6 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include #include #include @@ -24,6 +25,8 @@ #include #include #include +#include +#include #include #include @@ -796,6 +799,72 @@ void SmMathConfig::SaveOther() SetOtherModified( false ); } +namespace { + +// Latin default-fonts +const DefaultFontType aLatinDefFnts[FNT_END] = +{ +DefaultFontType::SERIF, // FNT_VARIABLE +DefaultFontType::SERIF, // FNT_FUNCTION +DefaultFontType::SERIF, // FNT_NUMBER +DefaultFontType::SERIF, // FNT_TEXT +DefaultFontType::SERIF, // FNT_SERIF +DefaultFontType::SANS, // FNT_SANS +DefaultFontType::FIXED // FNT_FIXED +//OpenSymbol,// FNT_MATH +}; + +// CJK default-fonts +//! we use non-asian fonts for variables, functions and numbers since they +//! look better and even in asia only latin letters will be used for those. +//! At least that's what I was told... +const DefaultFontType aCJKDefFnts[FNT_END] = +{ +DefaultFontType::SERIF, // FNT_VARIABLE +DefaultFontType::SERIF, // FNT_FUNCTION +DefaultFontType::SERIF, // FNT_NUMBER +DefaultFontType::CJK_TEXT, // FNT_TEXT +DefaultFontType::CJK_TEXT, // FNT_SERIF +DefaultFontType::CJK_DISPLAY,// FNT_SANS +DefaultFontType::CJK_TEXT// FNT_FIXED +//OpenSymbol,// FNT_MATH +}; + +// CTL default-fonts +const DefaultFontType aCTLDefFnts[FNT_END] = +{ +DefaultFontType::CTL_TEXT,// FNT_VARIABLE +DefaultFontType::CTL_TEXT,// FNT_FUNCTION +DefaultFontType::CTL_TEXT,// FNT_NUMBER +DefaultFontType::CTL_TEXT,// FNT_TEXT +DefaultFontType::CTL_TEXT,// FNT_SERIF +DefaultFontType::CTL_TEXT,// FNT_SANS +DefaultFontType::CTL_TEXT // FNT_FIXED +//OpenSymbol,// FNT_MATH +}; + + +OUString lcl_GetDefaultFontName( LanguageType nLang, sal_uInt16 nIdent ) +{ +assert(nIdent < FNT_END); +const DefaultFontType *pTable; +switch ( SvtLanguageOptions::GetScriptTypeOfLanguage( nLang ) ) +{ +case SvtScriptType::LATIN : pTable = aLatinDefFnts; break; +case SvtScriptType::ASIAN : pTable = aCJKDefFnts; break; +case SvtScriptType::COMPLEX : pTable = aCTLDefFnts; break; +default : +pTable = aLatinDefFnts; +SAL_WARN("starmath", "unknown script-type"); +} + +return OutputDevice::GetDefaultFont(pTable[ nIdent ], nLang, +GetDefaultFontFlags::OnlyOne ).GetFamilyName(); +} + +} + + void SmMathConfig::LoadFormat() { if (!pFormat) @@ -863,7 +932,7 @@ void SmMathConfig::LoadFormat() if (bUseDefaultFont) { aFnt = pFormat->GetFont( i ); -aFnt.SetFamilyName( GetDefaultFontName( nLang, i ) ); +aFnt.SetFamilyName( lcl_GetDefaultFontName( nLang, i ) ); } else { diff --git a/starmath/source/format.cxx b/starmath/source/format.cxx index 0d0713f611dc..a4bf960fd583 100644 --- a/starmath/source/format.cxx +++ b/starmath/source/format.cxx @@ -17,71 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include -#include - - -// Latin default-fonts -static const DefaultFontType aLatinDefFnts[FNT_END] = -{ -DefaultFontType::SERIF, // FNT_VARIABLE -DefaultFontType::SERIF, // FNT_FUNCTION -DefaultFontType::SERIF, // FNT_NUMBER -DefaultFontType::SERIF, // FNT_TEXT -DefaultFontType::SERIF, // FNT_SERIF -DefaultFontType::SANS, // FNT_SANS -DefaultFontType::FIXED // FNT_FIXED -//OpenSymbol,// FNT_MATH -}; - -// CJK default-fonts -//!
[Libreoffice-bugs] [Bug 115358] New: LibreOffice 6.0
https://bugs.documentfoundation.org/show_bug.cgi?id=115358 Bug ID: 115358 Summary: LibreOffice 6.0 Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: carondaniel1...@gmail.com Description: language pack extraction - missing dependencies - Opensuse 42.3 Leap Steps to Reproduce: 1.extract and install main core ok 2.Extract and install Helppack ok 3.extract and install langpack error Actual Results: danielcaron@linux-sh90:~/LibreOffice_6.0.0_Linux_x86-64_rpm/LibreOffice_6.0.0.3_Linux_x86-64_rpm_langpack_fr/RPMS> rpm -Uvh *.rpm erreur : Dépendances requises: libobasis6.0-core >= 6.0.0.3 est nécessaire pour libobasis6.0-fr-6.0.0.3-3.x86_6 libobasis6.0-core <= 6.0.0.3-3 est nécessaire pour libobasis6.0-fr-6.0.0.3-3.x86_64 libreoffice6.0-ure >= 6.0.0.3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libreoffice6.0-ure <= 6.0.0.3-3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libobasis6.0-core >= 6.0.0.3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libobasis6.0-core <= 6.0.0.3-3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libreoffice6.0 >= 6.0.0.3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libreoffice6.0 <= 6.0.0.3-3 est nécessaire pour libreoffice6.0-dict-fr-6.0.0.3-3.x86_64 libreoffice6.0 >= 6.0.0.3 est nécessaire pour libreoffice6.0-fr-6.0.0.3-3.x86_64 libreoffice6.0 <= 6.0.0.3-3 est nécessaire pour libreoffice6.0-fr-6.0.0.3-3.x86_64 danielcaron@linux-sh90:~/LibreOffice_6.0.0_Linux_x86-64_rpm/LibreOffice_6.0.0.3_Linux_x86-64_rpm_langpack_fr/RPMS> Expected Results: Nothing in menu Office Reproducible: Always User Profile Reset: No Additional Info: flawless installation and creating menu entries in Office. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115357] New: Enhancement request: Set Start Menu folder under Windows to \LibreOffice\
https://bugs.documentfoundation.org/show_bug.cgi?id=115357 Bug ID: 115357 Summary: Enhancement request: Set Start Menu folder under Windows to \LibreOffice\ Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: trivial Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t6zm3v62fkp7...@yandex.ru Description: In LibreOffice 6.0, installation folder has been changed from "LibreOffice 6.0" to "LibreOffice" (https://bugs.documentfoundation.org/show_bug.cgi?id=62303). Wouldn't it be good to change Start Menu folder (C:/Windows7/ProgramData/Microsoft/Windows/Start Menu/Programs/LibreOffice 6.0) too for unification? Actual Results: Start Menu folder: C:/Windows7/ProgramData/Microsoft/Windows/Start Menu/Programs/LibreOffice 6.0 Expected Results: Start Menu folder: C:/Windows7/ProgramData/Microsoft/Windows/Start Menu/Programs/LibreOffice Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.119 Chrome/64.0.3282.119 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113142] Add "insert sheet" to the sheet list in LibreOffice Online
https://bugs.documentfoundation.org/show_bug.cgi?id=113142 --- Comment #5 from Emre Öztürk--- https://gerrit.libreoffice.org/#/c/49070/ I think this is enough to fix this. :) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/attributeoutputbase.hxx | 16 ++ sw/source/filter/ww8/rtfattributeoutput.cxx | 91 +- sw/source/filter/ww8/wrtw8nds.cxx| 174 ++- 3 files changed, 115 insertions(+), 166 deletions(-) New commits: commit 21a53c857830414968a7acea4dc1f9b95676a6b1 Author: Mark HungDate: Sat Jan 27 19:27:30 2018 +0800 sw: refactor StartRuby in ww8 filter. Refactor the copy-pasted code in StartRuby of WW8AttributeOutput, RtfAttributeOutput, so that it can be used it in DocxAttributeOutput later. Change-Id: I63631be7604a62899c5630f3e57985993f128728 Reviewed-on: https://gerrit.libreoffice.org/48764 Tested-by: Jenkins Reviewed-by: Mark Hung diff --git a/sw/source/filter/ww8/attributeoutputbase.hxx b/sw/source/filter/ww8/attributeoutputbase.hxx index 028961cd1d8b..fc1648e77031 100644 --- a/sw/source/filter/ww8/attributeoutputbase.hxx +++ b/sw/source/filter/ww8/attributeoutputbase.hxx @@ -668,6 +668,22 @@ public: const SwRedlineData* GetParagraphMarkerRedline( const SwTextNode& rNode, RedlineType_t aRedlineType ); }; +class WW8Ruby +{ +sal_Int32 m_nJC; +sal_Char m_cDirective; +sal_uInt32 m_nRubyHeight; +sal_uInt32 m_nBaseHeight; +OUString m_sFontFamily; + +public: +WW8Ruby(const SwTextNode& rNode, const SwFormatRuby& rRuby, const MSWordExportBase& rExport ); +sal_Int32 GetJC() { return m_nJC; } +sal_CharGetDirective() { return m_cDirective; } +sal_uInt32 GetRubyHeight() { return m_nRubyHeight; } +sal_uInt32 GetBaseHeight() { return m_nBaseHeight; } +OUStringGetFontFamily() { return m_sFontFamily; } +}; #endif // INCLUDED_SW_SOURCE_FILTER_WW8_ATTRIBUTEOUTPUTBASE_HXX /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx b/sw/source/filter/ww8/rtfattributeoutput.cxx index 8e15fe6c9aed..959881aed103 100644 --- a/sw/source/filter/ww8/rtfattributeoutput.cxx +++ b/sw/source/filter/ww8/rtfattributeoutput.cxx @@ -450,100 +450,23 @@ void RtfAttributeOutput::RawText(const OUString& rText, rtl_TextEncoding eCharSe void RtfAttributeOutput::StartRuby(const SwTextNode& rNode, sal_Int32 nPos, const SwFormatRuby& rRuby) { +WW8Ruby aWW8Ruby(rNode, rRuby, GetExport()); OUString aStr(FieldString(ww::eEQ)); aStr += "\\* jc"; -sal_Int32 nJC = 0; -sal_Char cDirective = 0; -switch (rRuby.GetAdjustment()) -{ -case css::text::RubyAdjust_LEFT: -nJC = 3; -cDirective = 'l'; -break; -case css::text::RubyAdjust_CENTER: -//defaults to 0 -break; -case css::text::RubyAdjust_RIGHT: -nJC = 4; -cDirective = 'r'; -break; -case css::text::RubyAdjust_BLOCK: -nJC = 1; -cDirective = 'd'; -break; -case css::text::RubyAdjust_INDENT_BLOCK: -nJC = 2; -cDirective = 'd'; -break; -default: -OSL_ENSURE(false, "Unhandled Ruby justication code"); -break; -} -aStr += OUString::number(nJC); - -/* - MS needs to know the name and size of the font used in the ruby item, - but we could have written it in a mixture of asian and western - scripts, and each of these can be a different font and size than the - other, so we make a guess based upon the first character of the text, - defaulting to asian. - */ -assert(g_pBreakIt && g_pBreakIt->GetBreakIter().is()); -sal_uInt16 nRubyScript = g_pBreakIt->GetBreakIter()->getScriptType(rRuby.GetText(), 0); - -const SwTextRuby* pRubyText = rRuby.GetTextRuby(); -const SwCharFormat* pFormat = pRubyText ? pRubyText->GetCharFormat() : nullptr; -OUString sFamilyName; -long nHeight; -if (pFormat) -{ -const auto& rFont -= ItemGet(*pFormat, GetWhichOfScript(RES_CHRATR_FONT, nRubyScript)); -sFamilyName = rFont.GetFamilyName(); - -const auto& rHeight = ItemGet( -*pFormat, GetWhichOfScript(RES_CHRATR_FONTSIZE, nRubyScript)); -nHeight = rHeight.GetHeight(); -} -else -{ -/*Get defaults if no formatting on ruby text*/ - -const SfxItemPool* pPool = rNode.GetSwAttrSet().GetPool(); -pPool = pPool ? pPool : _rExport.m_pDoc->GetAttrPool(); - -const auto& rFont -= DefaultItemGet(*pPool, GetWhichOfScript(RES_CHRATR_FONT, nRubyScript)); -sFamilyName = rFont.GetFamilyName(); - -const auto& rHeight = DefaultItemGet( -*pPool, GetWhichOfScript(RES_CHRATR_FONTSIZE, nRubyScript)); -nHeight = rHeight.GetHeight(); -} -nHeight = (nHeight + 5) / 10; +aStr += OUString::number(aWW8Ruby.GetJC()); aStr += " \\* \"Font:"; -aStr +=
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/unomid.h |1 + sw/source/core/inc/unoport.hxx |1 + sw/source/core/txtnode/fmtatr2.cxx | 16 sw/source/core/unocore/unomap.cxx |1 + sw/source/core/unocore/unomapproperties.hxx |1 + sw/source/core/unocore/unoport.cxx |3 +++ 6 files changed, 23 insertions(+) New commits: commit 8ed0b54763581ba1f5ff295a59b5b040e7cd8f0f Author: Mark HungDate: Sun Jan 21 16:41:26 2018 +0800 tdf#35301 sw: RubyPosition text property support. Allow RubyPosition property to be set via UNO interface. Change-Id: I506312b1b5b27f016d0ee1c66231ff90747e5538 Reviewed-on: https://gerrit.libreoffice.org/48327 Tested-by: Jenkins Reviewed-by: Mark Hung diff --git a/sw/inc/unomid.h b/sw/inc/unomid.h index db8ba9335565..020da9d7e08e 100644 --- a/sw/inc/unomid.h +++ b/sw/inc/unomid.h @@ -114,6 +114,7 @@ #define MID_RUBY_ADJUST 1 #define MID_RUBY_CHARSTYLE 2 #define MID_RUBY_ABOVE 3 +#define MID_RUBY_POSITION 4 //SwTextGridItem #define MID_GRID_COLOR 0 diff --git a/sw/source/core/inc/unoport.hxx b/sw/source/core/inc/unoport.hxx index 25239840851f..8f772760dada 100644 --- a/sw/source/core/inc/unoport.hxx +++ b/sw/source/core/inc/unoport.hxx @@ -111,6 +111,7 @@ private: std::unique_ptr< css::uno::Any > m_pRubyStyle; std::unique_ptr< css::uno::Any > m_pRubyAdjust; std::unique_ptr< css::uno::Any > m_pRubyIsAbove; +std::unique_ptr< css::uno::Any > m_pRubyPosition; sw::UnoCursorPointer m_pUnoCursor; const SwDepend m_FrameDepend; diff --git a/sw/source/core/txtnode/fmtatr2.cxx b/sw/source/core/txtnode/fmtatr2.cxx index 9217779ee7b0..374326f40eb6 100644 --- a/sw/source/core/txtnode/fmtatr2.cxx +++ b/sw/source/core/txtnode/fmtatr2.cxx @@ -37,6 +37,7 @@ #include #include #include +#include #include #include @@ -456,6 +457,11 @@ bool SwFormatRuby::QueryValue( uno::Any& rVal, rVal <<= static_cast(!m_nPosition); } break; +case MID_RUBY_POSITION: +{ +rVal <<= static_cast(m_nPosition); +} +break; default: bRet = false; } @@ -491,6 +497,16 @@ bool SwFormatRuby::PutValue( const uno::Any& rVal, } } break; +case MID_RUBY_POSITION: +{ +sal_Int16 nSet = 0; +rVal >>= nSet; +if(nSet >= sal_Int16(text::RubyPosition::ABOVE) && nSet <= sal_Int16(text::RubyPosition::INTER_CHARACTER)) +m_nPosition = nSet; +else +bRet = false; +} +break; case MID_RUBY_CHARSTYLE: { OUString sTmp; diff --git a/sw/source/core/unocore/unomap.cxx b/sw/source/core/unocore/unomap.cxx index 8a18ddd379f6..c179042102ec 100644 --- a/sw/source/core/unocore/unomap.cxx +++ b/sw/source/core/unocore/unomap.cxx @@ -156,6 +156,7 @@ const SfxItemPropertyMapEntry* SwUnoPropertyMapProvider::GetPropertyMapEntries(s { { OUString(UNO_NAME_RUBY_ADJUST), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_ADJUST }, { OUString(UNO_NAME_RUBY_IS_ABOVE), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_ABOVE }, +{ OUString(UNO_NAME_RUBY_POSITION), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_POSITION }, { OUString(), 0, css::uno::Type(), 0, 0 } }; m_aMapEntriesArr[nPropertyId] = aAutoRubyStyleMap; diff --git a/sw/source/core/unocore/unomapproperties.hxx b/sw/source/core/unocore/unomapproperties.hxx index b9825ff4a8d2..3881ef17767c 100644 --- a/sw/source/core/unocore/unomapproperties.hxx +++ b/sw/source/core/unocore/unomapproperties.hxx @@ -204,6 +204,7 @@ { OUString(UNO_NAME_RUBY_TEXT), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_TEXT }, \ { OUString(UNO_NAME_RUBY_ADJUST), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_ADJUST}, \ { OUString(UNO_NAME_RUBY_CHAR_STYLE_NAME), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_CHARSTYLE }, \ +{ OUString(UNO_NAME_RUBY_POSITION), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(), PropertyAttribute::MAYBEVOID, MID_RUBY_POSITION}, \ { OUString(UNO_NAME_RUBY_IS_ABOVE), RES_TXTATR_CJK_RUBY, cppu::UnoType::get(),
[Libreoffice-bugs] [Bug 115356] Missed commas in Russian translation of installer
https://bugs.documentfoundation.org/show_bug.cgi?id=115356 --- Comment #2 from John Felton--- Created attachment 139482 --> https://bugs.documentfoundation.org/attachment.cgi?id=139482=edit Missed comma when installing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115356] Missed commas in Russian translation of installer
https://bugs.documentfoundation.org/show_bug.cgi?id=115356 --- Comment #1 from John Felton--- Created attachment 139481 --> https://bugs.documentfoundation.org/attachment.cgi?id=139481=edit Missed comma when removing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115356] New: Missed commas in Russian translation of installer
https://bugs.documentfoundation.org/show_bug.cgi?id=115356 Bug ID: 115356 Summary: Missed commas in Russian translation of installer Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Localization Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t6zm3v62fkp7...@yandex.ru Description: There are 2 missed commas in Russian translation of installer. Actual Results: Now: "Подождите пока мастер установит LibreOffice 6.0.0.3." "Подождите пока Windows настраивает LibreOffice 5.4.4.2" Expected Results: Fixed: "Подождите, пока мастер установит LibreOffice 6.0.0.3." "Подождите, пока Windows настраивает LibreOffice 5.4.4.2" Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.119 Chrome/64.0.3282.119 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107836] [META] Page and section column bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107836 Bug 107836 depends on bug 115344, which changed state. Bug 115344 Summary: FORMATTING - Format -> Columns... dialog missing https://bugs.documentfoundation.org/show_bug.cgi?id=115344 What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115344] FORMATTING - Format -> Columns... dialog missing
https://bugs.documentfoundation.org/show_bug.cgi?id=115344 Kyle Whitechanged: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115344] FORMATTING - Format -> Columns... dialog missing
https://bugs.documentfoundation.org/show_bug.cgi?id=115344 --- Comment #3 from Kyle White--- The functionality of 'Columns' the the Page dialog and in the 'Sections' dialog is totally different from the missing 'Format -> Columns...' dialog. In the original 'Format -> Columns...' dialog is is possible to convert a pre-selected section of text into columns with one dialog box. The Page dialog affects the entire document, and the Sections dialog gives you empty columns which you then populate. In neither case can you pre-select a section of text in the document and convert it directly into columns without affecting anything else. Please re-visit but 115344 Thank you! Kyle -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115355] New: calc can' t find number of cell that result of formula not correct
https://bugs.documentfoundation.org/show_bug.cgi?id=115355 Bug ID: 115355 Summary: calc can't find number of cell that result of formula not correct Product: LibreOffice Version: Inherited From OOo Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pig...@yahoo.co.th Description: cell result cell a1=2 , cell a2=4 , cell a3 =a1*a2 = 8 i can't find 8 Actual Results: cell result cell a1=2 , cell a2=4 , cell a3 =a1*a2 = 8 i can't find 8 Expected Results: cell result cell a1=2 , cell a2=4 , cell a3 =a1*a2 = 8 i can't find number 8 Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Render differences of DOCX between Word and LO/AOO
Thank you Jonathon for the char/word count explanation. However, I’m more concerned about the differences in rendering (which in turn accounts for the large difference in page count) and the loss of font use (see the heading). If need be I can provide a test document that demonstrates these issues. -- Sent from: http://nabble.documentfoundation.org/Dev-f1639786.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 76456] FILEOPEN custom shape itself and text in custom shape have wrong rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=76456 Serdar Oktay TUNÇchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |serdar...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106831] Can't print #10 envelopes properly and w proper orientation.
https://bugs.documentfoundation.org/show_bug.cgi?id=106831 --- Comment #6 from Per Nystrom--- (In reply to Buovjaga from comment #5) > Same as some of these? > https://bugs.documentfoundation.org/buglist. > cgi?list_id=771043_format=advanced=--- > _desc=envelope%2010_desc_type=allwordssubstr Each of the bugs listed has somewhat different symptoms, and arose in different releases of LO. The particular behavior I reported in this bug didn't start until sometime after version 4.3.7.2-12. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115354] New: I cannot install LanguageTool-4.0.oxt on macOS 10.13.3 with LibreOffice Vanilla 5.4.4 , Extension Manager hangs...
https://bugs.documentfoundation.org/show_bug.cgi?id=115354 Bug ID: 115354 Summary: I cannot install LanguageTool-4.0.oxt on macOS 10.13.3 with LibreOffice Vanilla 5.4.4, Extension Manager hangs... Product: LibreOffice Version: 5.4.4.1 rc Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Extensions Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: miche...@gmx.com Description: After downloading the anguageTool-4.0.oxt on macOS 10.13.3 with LibreOffice Vanilla 5.4.4, Extension Manager hangs when I try to install it. CPU utilization goes up but nothing else happens and LibreOffice Vanilla hangs. I had to ForceQuit LibreOffice after several hours. I tried downloading a second time, to eliminate possible download error but to no avail, trying to installing causes a hang. Extension Manager now shows a lot of languages but a check for updates on e.g. Dutch causes a simular hang. Steps to Reproduce: Download the LanguageTool-4.o.oxt extension and save it anywhere on your computer. In LibreOffice, select Tools --> Extension Manager from the menu bar. In the Extension Manager dialog click Add. A file browser window opens. Navigate to the folder where you saved the LibreOffice extension file(s) on your system. The extension's files have the file extension 'OXT'. Find and select the extension you want to install and click Open. Actual Results: Nothing seems to happen except that teh CPU utilization goes up to-around 13 % from an idle load of around 3% and LibreOffice hangs until ForceQuit. Expected Results: Installation of LanguageTools-4.0 Reproducible: Always User Profile Reset: No Additional Info: Fresh installation of maxOS High Sierra on a mac Pro (late 2013, with only a few apps besides the standard Apple office suite. User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104798] Autocorrect cannot be set to two (or more) languages in one document (Options and Localized options)
https://bugs.documentfoundation.org/show_bug.cgi?id=104798 --- Comment #3 from Milan--- The problem was solved partly. The English/Czech quotes now work properly simply by putting a cursor in the particular text. Nevertheless, a language different from Locale Settings still cannot be set in AutoCorrect Options. LibreOffice 5.4.4.2 (x64) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: common/Util.cpp
common/Util.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f269a9321c81bf0b2193661935b9231206e3a44b Author: Henry CastroDate: Wed Jan 31 17:51:47 2018 -0400 follow up, avoid logging when closing file descriptors Change-Id: I38432ae1d042094551d22c2512a416c3b345556b diff --git a/common/Util.cpp b/common/Util.cpp index 9069d054..3c3c7897 100644 --- a/common/Util.cpp +++ b/common/Util.cpp @@ -153,7 +153,7 @@ namespace Util { if (!closeFdsFromProc()) { -LOG_WRN("Couldn't close fds efficiently from /proc"); +std::cerr << "Couldn't close fds efficiently from /proc" << std::endl; for (int fd = 3; fd < sysconf(_SC_OPEN_MAX); ++fd) close(fd); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - common/Util.cpp
common/Util.cpp |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit b91d38ad501c80cf06537b77cec5738b7adee88a Author: Henry CastroDate: Wed Jan 31 15:31:44 2018 -0400 util: avoid logging when closing file descriptors eventually the log file descriptor will be closed and unhandled exception it will throw it "terminate called after throwing an instance of 'Poco::WriteFileException' what(): Cannot write file" Change-Id: I1d6ae3a4d4d4910f2ed2cdc80b162c27f93d55d9 Reviewed-on: https://gerrit.libreoffice.org/49055 Reviewed-by: Michael Meeks Tested-by: Michael Meeks Reviewed-on: https://gerrit.libreoffice.org/49064 diff --git a/common/Util.cpp b/common/Util.cpp index a82c54ea..357f6da8 100644 --- a/common/Util.cpp +++ b/common/Util.cpp @@ -142,9 +142,7 @@ namespace Util continue; if (close(fd) < 0) - LOG_WRN("Unexpected failure to close fd " << fd); - else - LOG_TRC("Closed fd " << fd); + std::cerr << "Unexpected failure to close fd " << fd << std::endl; } closedir(fdDir); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - common/Util.cpp common/Util.hpp wsd/DocumentBroker.cpp wsd/LOOLWSD.cpp
common/Util.cpp| 92 + common/Util.hpp|5 ++ wsd/DocumentBroker.cpp |8 +++- wsd/LOOLWSD.cpp| 15 ++- 4 files changed, 108 insertions(+), 12 deletions(-) New commits: commit 44e9fe62e13a4316ddc7d620be8ccb8a92174aba Author: Michael MeeksDate: Mon Jan 29 15:13:54 2018 + Implement an improved fork/exec wrapper. * logs helpful messages for various error corner-cases. * optimized file descriptor closing for large fd counts. Change-Id: I8cba9ecb3d71ddc6e22e20d89368d8c6b9b5097f Reviewed-on: https://gerrit.libreoffice.org/49063 Reviewed-by: Henry Castro Reviewed-by: Michael Meeks Tested-by: Michael Meeks diff --git a/common/Util.cpp b/common/Util.cpp index 51c15b74..a82c54ea 100644 --- a/common/Util.cpp +++ b/common/Util.cpp @@ -18,7 +18,9 @@ #include #include #include +#include #include +#include #include #include @@ -114,6 +116,96 @@ namespace Util } } +// close what we have - far faster than going up to a 1m open_max eg. +static bool closeFdsFromProc() +{ + DIR *fdDir = opendir("/proc/self/fd"); + if (!fdDir) + return false; + + struct dirent *i; + + while ((i = readdir(fdDir))) { + if (i->d_name[0] == '.') + continue; + + char *e = NULL; + errno = 0; + long fd = strtol(i->d_name, , 10); + if (errno != 0 || !e || *e) + continue; + + if (fd == dirfd(fdDir)) + continue; + + if (fd < 3) + continue; + + if (close(fd) < 0) + LOG_WRN("Unexpected failure to close fd " << fd); + else + LOG_TRC("Closed fd " << fd); + } + + closedir(fdDir); + return true; +} + +static void closeFds() +{ +if (!closeFdsFromProc()) +{ +LOG_WRN("Couldn't close fds efficiently from /proc"); +for (int fd = 3; fd < sysconf(_SC_OPEN_MAX); ++fd) +close(fd); +} +} + +int spawnProcess(const std::string , const std::vector , int *stdInput) +{ +int pipeFds[2] = { -1, -1 }; +if (stdInput) +{ +if (pipe(pipeFds) < 0) +{ +LOG_ERR("Out of file descriptors spawning " << cmd); +throw Poco::SystemException("Out of file descriptors"); +} +} + +std::vector params; +params.push_back(const_cast(cmd.c_str())); +for (auto i : args) +params.push_back(const_cast(i.c_str())); +params.push_back(nullptr); + +int pid = fork(); +if (pid < 0) +{ +LOG_ERR("Failed to fork for command '" << cmd); +throw Poco::SystemException("Failed to fork for command ", cmd); +} +else if (pid == 0) // child +{ +if (stdInput) +dup2(pipeFds[0], STDIN_FILENO); + +closeFds(); + +int ret = execvp(params[0], [0]); +if (ret < 0) +std::cerr << "Failed to exec command '" << cmd << "' with error '" << strerror(errno) << "'\n"; +_exit(42); +} +// else spawning process still +if (stdInput) +{ +close(pipeFds[0]); +*stdInput = pipeFds[1]; +} +return pid; +} + bool dataFromHexString(const std::string& hexString, std::vector& data) { if (hexString.length() % 2 != 0) diff --git a/common/Util.hpp b/common/Util.hpp index e97d1808..b4c59f98 100644 --- a/common/Util.hpp +++ b/common/Util.hpp @@ -42,6 +42,11 @@ namespace Util std::string getFilename(const size_t length); } +/// Spawn a process if stdInput is non-NULL it contains a writable descriptor +/// to send data to the child. +int spawnProcess(const std::string , const std::vector , + int *stdInput = nullptr); + /// Hex to unsigned char bool dataFromHexString(const std::string& hexString, std::vector& data); /// Encode an integral ID into a string, with padding support. diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index f76ed62d..c0d33348 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -38,6 +38,9 @@ #include "common/Protocol.hpp" #include "common/Unit.hpp" +#include +#include + using namespace LOOLProtocol; using Poco::JSON::Object; @@ -621,8 +624,9 @@ bool DocumentBroker::load(const std::shared_ptr& session, const s for (std::size_t i = 1; i < tokenizer.count(); ++i) args.emplace_back(tokenizer[i]); -
[Libreoffice-bugs] [Bug 115349] Conditional Formatting is completely lost on save to XLS format FILESAVE FILEOPEN FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=115349 Aron Budeachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@caesar.elte.hu Ever confirmed|0 |1 --- Comment #1 from Aron Budea --- Can you please upload a sample ODT which loses conditional formatting when saved as XLS? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107836] [META] Page and section column bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107836 Yousuf Philips (jay)changed: What|Removed |Added Depends on||115344 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115344 [Bug 115344] FORMATTING - Format -> Columns... dialog missing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107836] [META] Page and section column bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107836 Bug 107836 depends on bug 115344, which changed state. Bug 115344 Summary: FORMATTING - Format -> Columns... dialog missing https://bugs.documentfoundation.org/show_bug.cgi?id=115344 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=85811 Yousuf Philips (jay)changed: What|Removed |Added Depends on|115344 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115344 [Bug 115344] FORMATTING - Format -> Columns... dialog missing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115344] FORMATTING - Format -> Columns... dialog missing
https://bugs.documentfoundation.org/show_bug.cgi?id=115344 Yousuf Philips (jay)changed: What|Removed |Added Status|NEW |RESOLVED CC||philip...@hotmail.com Blocks|85811 |91781, 107836 Resolution|--- |INVALID --- Comment #2 from Yousuf Philips (jay) --- Was intentionally moved, as the column tab is available in the page and section dialogs. https://gerrit.libreoffice.org/#/c/39017/ Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=85811 [Bug 85811] [META] Main menu bar bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=91781 [Bug 91781] [META] Reorganization of the menu bar for Writer https://bugs.documentfoundation.org/show_bug.cgi?id=107836 [Bug 107836] [META] Page and section column bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=114736 Aron Budeachanged: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #18 from Aron Budea --- Crash is gone in LO 6.1 daily build (2018-01-30_03:11:54, 3deac9691011711a3b9e50d19499c588af074d7f). Thanks for the fix, Tamás! There is a leftover display issue, bug 115353 has been opened on that. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115353] Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 Aron Budeachanged: What|Removed |Added Keywords|haveBacktrace | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115353] Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 Aron Budeachanged: What|Removed |Added CC||btom...@gmail.com, ||xiscofa...@libreoffice.org --- Comment #2 from Aron Budea --- Oh, and OS is Windows 7, not sure if other OSes are affected. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115353] Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 --- Comment #1 from Aron Budea--- Created attachment 139479 --> https://bugs.documentfoundation.org/attachment.cgi?id=139479=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114736] Crash with CJK characters in status bar (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=114736 Aron Budeachanged: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5353 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115353] New: Status bar displays wrong characters upon load (OpenGL)
https://bugs.documentfoundation.org/show_bug.cgi?id=115353 Bug ID: 115353 Summary: Status bar displays wrong characters upon load (OpenGL) Product: LibreOffice Version: 6.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, haveBacktrace, regression Severity: normal Priority: high Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@caesar.elte.hu Blocks: 83066, 93529 This is a follow-up to bug 114736. With OpenGL rendering enabled, open attachment 138711 [details] from bug 114732. Note how the status bar doesn't display the Chinese characters as it would be expected (see screenshot). After any action that redraws status bar, the characters display correctly. Chinese/Japanese/Korean UIs might also be affected (couldn't test that). Observed using LO 6.1 daily build (2018-01-30_03:11:54, 3deac9691011711a3b9e50d19499c588af074d7f). I'm assuming the responsible commit is the same that fixed the crash of bug 114736: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9b5730f92967b6a8f4fce349bcd951f388b940df author Tamas Bunth2018-01-28 00:14:55 +0100 committer Tamás Bunth 2018-01-28 15:58:46 +0100 tdf#114736 no need to call AdjustLayout here Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=83066 [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues https://bugs.documentfoundation.org/show_bug.cgi?id=93529 [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93529] [META] VCL/OpenGL rendering tracker bug for 5.0+
https://bugs.documentfoundation.org/show_bug.cgi?id=93529 Aron Budeachanged: What|Removed |Added Depends on||115353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115353 [Bug 115353] Status bar displays wrong characters upon load (OpenGL) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Aron Budeachanged: What|Removed |Added Depends on||115353 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115353 [Bug 115353] Status bar displays wrong characters upon load (OpenGL) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106759] Not all linked spreadsheets are shown in 'Edit Links...' dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=106759 Xisco Faulíchanged: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #8 from Xisco Faulí --- (In reply to Jos van den Oever from comment #7) > There is indeed one external link in this file. The link that is shown in > the screenshot is correct. > > On my machine with LO 5.4 I can confirm that this is fixed. > > The link to > "/Users/VelthuisR/gemeentefonds/verdeling%20sociaal%20domein/uitkeringen, > %20bijstand/gef_2016_bm_2016-05%20RV.xls" that is listed in > xl/externalLinks/_rels/externalLink1.xml.rels is shown correctly. Thanks for testing it again on the latest version. Setting to RESOLVED WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115268] FILEOPEN - Writer 6 crash opening MS office files if app not already open
https://bugs.documentfoundation.org/show_bug.cgi?id=115268 Xisco Faulíchanged: What|Removed |Added CC||blmorg...@gmail.com --- Comment #17 from Xisco Faulí --- *** Bug 115352 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115352] Crash if I open a Writer Document by double-clicking the file
https://bugs.documentfoundation.org/show_bug.cgi?id=115352 Xisco Faulíchanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||xiscofa...@libreoffice.org Resolution|--- |DUPLICATE --- Comment #1 from Xisco Faulí --- Hi, Thanks for reporting the issue. It seems to be a duplicate of bug 115268 *** This bug has been marked as a duplicate of bug 115268 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87239] Inconsistent look and operation of drop-down buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=87239 --- Comment #8 from Maxim Monastirsky--- (In reply to Yousuf Philips (jay) from comment #7) > A changing title label like this might be the only exception that might be > worth keeping a title label for, but really how useful is it to know the > number of undo or redo steps that you are going to make. That changing label > could easily be placed below the undo/redo listbox as that information is > secondary to the listbox details. Yes, that in fact how it was in OOo (and still in AOO). Just for a reference, here are kendy's commits which introduced those titles - https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep=toolbar-decorations > I'm assuming you are for disabling dragging here as well. True. > So for me this would be the guidelines: > > 1. Never have title label bar as icon and tooltip already cover this. > > 2. If it is to be dragged have draggable grip. > > 3. If the contextual/changing label is needed in the widget, have it below > the primary control as users eyes will be looking downwards when using the > primary control and not upwards where the current title label bar is. OK, I can agree with that. As long as the color pickers are draggable I'm happy. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 87239] Inconsistent look and operation of drop-down buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=87239 --- Comment #8 from Maxim Monastirsky--- (In reply to Yousuf Philips (jay) from comment #7) > A changing title label like this might be the only exception that might be > worth keeping a title label for, but really how useful is it to know the > number of undo or redo steps that you are going to make. That changing label > could easily be placed below the undo/redo listbox as that information is > secondary to the listbox details. Yes, that in fact how it was in OOo (and still in AOO). Just for a reference, here are kendy's commits which introduced those titles - https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep=toolbar-decorations > I'm assuming you are for disabling dragging here as well. True. > So for me this would be the guidelines: > > 1. Never have title label bar as icon and tooltip already cover this. > > 2. If it is to be dragged have draggable grip. > > 3. If the contextual/changing label is needed in the widget, have it below > the primary control as users eyes will be looking downwards when using the > primary control and not upwards where the current title label bar is. OK, I can agree with that. As long as the color pickers are draggable I'm happy. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 115352] New: Crash if I open a Writer Document by double-clicking the file
https://bugs.documentfoundation.org/show_bug.cgi?id=115352 Bug ID: 115352 Summary: Crash if I open a Writer Document by double-clicking the file Product: LibreOffice Version: 6.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: blmorg...@gmail.com Description: When opening a file by finding it w/in file system and double-clicking, LibreOffice crashes w/ a report similar to: http://crashreport.libreoffice.org/stats/crash_details/d7493e69-adaa-46e9-95ef-eb80fdbef7c7 Steps to Reproduce: 1. Find LibreOffice writer file (*.odt) and double-click to open (LibreOffice must not be open on PC) 2. LibreOffice will start, file will open, then program crashes Actual Results: Program crash like report: http://crashreport.libreoffice.org/stats/crash_details/d7493e69-adaa-46e9-95ef-eb80fdbef7c7 Expected Results: Allow me to edit the document. Reproducible: Always User Profile Reset: Yes Additional Info: Workaround is to open LibreOffice Writer first, then use file > open to open file. Double-click also works if LibreOffice is already open. Help/About info: Version: 6.0.0.3 (x64) Build ID: 64a0f66915f38c6217de274f0aa8e15618924765 CPU threads: 4; OS: Windows 10.0; UI render: default; Locale: en-US (en_US); Calc: group User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: common/Util.cpp
common/Util.cpp |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit b1f1500b564a03438a4cb215e433ced555de43d8 Author: Henry CastroDate: Wed Jan 31 15:31:44 2018 -0400 util: avoid logging when closing file descriptors eventually the log file descriptor will be closed and unhandled exception it will throw it "terminate called after throwing an instance of 'Poco::WriteFileException' what(): Cannot write file" Change-Id: I1d6ae3a4d4d4910f2ed2cdc80b162c27f93d55d9 Reviewed-on: https://gerrit.libreoffice.org/49055 Reviewed-by: Michael Meeks Tested-by: Michael Meeks diff --git a/common/Util.cpp b/common/Util.cpp index a26b829b..9069d054 100644 --- a/common/Util.cpp +++ b/common/Util.cpp @@ -142,9 +142,7 @@ namespace Util continue; if (close(fd) < 0) - LOG_WRN("Unexpected failure to close fd " << fd); - else - LOG_TRC("Closed fd " << fd); + std::cerr << "Unexpected failure to close fd " << fd << std::endl; } closedir(fdDir); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 115351] New: ISLOGICAL function depends on column formatting EDITING
https://bugs.documentfoundation.org/show_bug.cgi?id=115351 Bug ID: 115351 Summary: ISLOGICAL function depends on column formatting EDITING Product: LibreOffice Version: 6.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cheming...@semissourian.com Description: ISLOGICAL function does not always return TRUE when the column is not set to precisely BOOLEAN For instance, Setting a Custom format of T;;F will always return false. Also, ISLOGICAL does not change after the column format changes until the document is reloaded or the formula in the target cell is modified. Steps to Reproduce: 1. Create spreadsheet in LO 6 2. Set column A to custom format T;;F 3. Set Column B to Logical 3a. Set Column C to Number/Generic 4. Set the value =TRUE() in A1, B1 and C1 5. Set the value =FALSE() in A2, B2, and C2 6. Reference 6 cells with ISLOGICAL to the cells A1, B1, C1, A2, B2, C2. 7. Note items in column A are considered "False" 8. Note items in column B are considered "True" (Truthy?) 9. Note items in column C are considered "False" Actual Results: Functions with custom T/F header are always considered FALSE() by ISLOGICAL(). ISLOGICAL should evaluate the function and not the header. Expected Results: ISLOGICAL should evaluate the function in the cell, not the cell format (okay, a TEXT cell I *might* understand) Reproducible: Always User Profile Reset: Yes Additional Info: XLS/XLSX bug! When saving a spreadsheet to XLS/XLSX format BOOLEAN is converted to TRUE;TRUE;FALSE, and all conditional formatting the references that column & ISLOGICAL are broken. (Assuming that the CF is not stripped away altogether). Oldest version that this still applies to v4.4.7.2 User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - lotuswordpro/source sw/qa sw/source
lotuswordpro/source/filter/lwplayout.cxx | 16 sw/qa/core/data/html/pass/ofz5855-1.html |1 + sw/source/filter/html/htmltab.cxx| 13 +++-- 3 files changed, 12 insertions(+), 18 deletions(-) New commits: commit d9efa12addb8fbedbc900081bdcaf9db7fd4cd66 Author: Caolán McNamaraDate: Wed Jan 31 20:57:37 2018 + ofz: Infinite loop Change-Id: I9f7170023dd31c11ef6e02a6901bb5ea18f5fa81 diff --git a/lotuswordpro/source/filter/lwplayout.cxx b/lotuswordpro/source/filter/lwplayout.cxx index 73f0c3114640..c3aae4ee1369 100644 --- a/lotuswordpro/source/filter/lwplayout.cxx +++ b/lotuswordpro/source/filter/lwplayout.cxx @@ -484,25 +484,17 @@ void LwpHeadLayout::RegisterStyle() { //Register all children styles rtl::Reference xLayout(dynamic_cast (GetChildHead().obj().get())); +std::set aSeen; while (xLayout.is()) { +aSeen.insert(xLayout.get()); xLayout->SetFoundry(m_pFoundry); //if the layout is relative to para, the layout will be registered in para if (!xLayout->IsRelativeAnchored()) -{ -if (xLayout.get() == this) -{ -OSL_FAIL("Layout points to itself"); -break; -} xLayout->DoRegisterStyle(); -} rtl::Reference xNext(dynamic_cast (xLayout->GetNext().obj().get())); -if (xNext.get() == xLayout.get()) -{ -OSL_FAIL("Layout points to itself"); -break; -} +if (aSeen.find(xNext.get()) != aSeen.end()) +throw std::runtime_error("loop in conversion"); xLayout = xNext; } } commit 888973850c7bf476de0b4c9b171d5b19583e8056 Author: Caolán McNamara Date: Wed Jan 31 20:41:57 2018 + ofz#5855 revert fix mem leak commit 5ceea51947b99f27eb3401bd3c9b8a7cf6ee9c96 Author: Caolán McNamara Date: Fri Dec 8 14:13:22 2017 + ofz: fix mem leak Change-Id: I295e52723297b257dcfe532108471702631ca5f5 Reviewed-on: https://gerrit.libreoffice.org/46093 Change-Id: I98c2dc7e32c6dfc725a5763077bceb527cb31db2 diff --git a/sw/qa/core/data/html/pass/ofz5855-1.html b/sw/qa/core/data/html/pass/ofz5855-1.html new file mode 100644 index ..a24f6cff0431 --- /dev/null +++ b/sw/qa/core/data/html/pass/ofz5855-1.html @@ -0,0 +1 @@ +�@page:first diff --git a/sw/source/filter/html/htmltab.cxx b/sw/source/filter/html/htmltab.cxx index b80020e80e8a..680f8c98c95b 100644 --- a/sw/source/filter/html/htmltab.cxx +++ b/sw/source/filter/html/htmltab.cxx @@ -401,7 +401,7 @@ class HTMLTable const SwStartNode *m_pPrevStartNode; // the Table-Node or the Start-Node of the section before const SwTable *m_pSwTable;// SW-Table (only on Top-Level) -std::unique_ptr m_xBox1;// TableBox, generated when the Top-Level-Table was build +SwTableBox* m_pBox1;// TableBox, generated when the Top-Level-Table was build SwTableBoxFormat *m_pBoxFormat; // frame::Frame-Format from SwTableBox SwTableLineFormat *m_pLineFormat; // frame::Frame-Format from SwTableLine SwTableLineFormat *m_pLineFrameFormatNoHeight; @@ -909,7 +909,7 @@ void HTMLTable::InitCtor(const HTMLTableOptions& rOptions) m_nRows = 0; m_nCurrentRow = 0; m_nCurrentColumn = 0; -m_xBox1.reset(); +m_pBox1 = nullptr; m_pBoxFormat = nullptr; m_pLineFormat = nullptr; m_pLineFrameFormatNoHeight = nullptr; m_xInheritedBackgroundBrush.reset(); @@ -1465,11 +1465,12 @@ SwTableBox *HTMLTable::NewTableBox( const SwStartNode *pStNd, { SwTableBox *pBox; -if (m_xBox1 && m_xBox1->GetSttNd() == pStNd) +if (m_pBox1 && m_pBox1->GetSttNd() == pStNd) { // If the StartNode is the StartNode of the initially created box, we take that box -pBox = const_cast (this)->m_xBox1.release(); +pBox = const_cast (this)->m_pBox1; pBox->SetUpper(pUpper); +const_cast (this)->m_pBox1 = nullptr; } else pBox = new SwTableBox( m_pBoxFormat, *pStNd, pUpper ); @@ -2315,11 +2316,11 @@ void HTMLTable::MakeTable( SwTableBox *pBox, sal_uInt16 nAbsAvail, // get the default line and box format // remember the first box and unlist it from the first row SwTableLine *pLine1 = (m_pSwTable->GetTabLines())[0]; -m_xBox1.reset((pLine1->GetTabBoxes())[0]); +m_pBox1 = (pLine1->GetTabBoxes())[0]; pLine1->GetTabBoxes().erase(pLine1->GetTabBoxes().begin()); m_pLineFormat = static_cast (pLine1->GetFrameFormat()); -m_pBoxFormat = static_cast (m_xBox1->GetFrameFormat()); +m_pBoxFormat = static_cast (m_pBox1->GetFrameFormat()); MakeTable_( pBox );
[Libreoffice-bugs] [Bug 115350] UI: Tools > Options for Math always should be visible
https://bugs.documentfoundation.org/show_bug.cgi?id=115350 Heiko Tietzechanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Severity|enhancement |normal --- Comment #1 from Heiko Tietze --- Would treat it as a bug when you haven't access from Writer, for instance. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs