date:20180208

[Libreoffice-commits] core.git: sw/source

2018-02-08 Thread Muhammet Kara

 sw/source/filter/xml/xmltbli.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7731b86a12811b6903d29e29bb867a316c94bccc
Author: Muhammet Kara 
Date:   Thu Feb 8 16:44:16 2018 +0300

Workaround for broken GCC

There appears to be broken GCC out there,
at least some "gcc (Debian 6.3.0-18) 6.3.0 20170516",
even with -std=gnu++17, reportedly does not treat
the in-class declaration of MAX_WIDTH as a definition,
and needs this old-style out-of-class definition, too.

See also bc2ae79f81c8aa081d6340348c70c0440f6e895e

Change-Id: Iaeb85e244d5963c01a86806f481c9d667b1f26a1
Reviewed-on: https://gerrit.libreoffice.org/49431
Reviewed-by: Jim Raykowski 
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx
index 068080373199..5159cc92b6dd 100644
--- a/sw/source/filter/xml/xmltbli.cxx
+++ b/sw/source/filter/xml/xmltbli.cxx
@@ -1228,7 +1228,7 @@ public:
 }
 };
 
-#if __cplusplus <= 201402 || (defined __GNUC__ && __GNUC__ == 5 && 
__GNUC_MINOR__ <= 4)
+#if __cplusplus <= 201402 || (defined __GNUC__ && __GNUC__ <= 6)
 constexpr sal_Int32 SwXMLTableContext::MAX_WIDTH;
 #endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry

2018-02-08 Thread Stephan Bergmann

 officecfg/registry/schema/org/openoffice/Office/Writer.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 552bebc85d907748dcd72b7978a00a3eee7c4f34
Author: Stephan Bergmann 
Date:   Thu Feb 8 09:49:12 2018 +0100

/org...Writer/Insert/Caption/CaptionOrderNumberingFirst should be localized

...as f6281ec4112479b5bdd750be351f4437ecf8a65a "#i110273# caption order 
changed
for locale hu" added a special value for xml:lang="hu", but failed to take 
into
account that the property is not localized.

Until now, every installation that had the hu localization installed (but
regardless of whether or not it was actually using it) would always have
reported the special hu value (true), while any other installation would 
always
have reported the default value (nil, mapped to false in the else branch at 
the
end of SwInsertConfig::Load, sw/source/uibase/config/modcfg.cxx).

Unless the value was overwritten in registrymodifications.xcu (by changing 
the
Options dialog "LibreOffice Writer - AutoCaption - Caption Order" setting). 
 In
which case the hu localization will now start to use its default again 
(true),
while all other localizations will continue to use whatever value had been
stored (without an xml:lang attribute) in registrymodifications.xcu.  This 
is a
bit unfortunate for the hu-localization case.  It should probably be 
mentioned
in the release notes.

(Strictly speaking, changing a property from non-localized to localized, as 
is
done here as well as in e.g. ffd8369b909c86653ef30593fddf67c9f5308583
"rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an
incompatible change which 3rd-party code can observe through the
css.configuration UNO API.  But chances are extremely low that this will 
have
any impact, as access to any property's value is normally done in a way that
makes it transparent whether or not the property is localizied.)

Change-Id: Ia840e28e10d0fa388bff6eaf8aadf0e8e6b25a19
Reviewed-on: https://gerrit.libreoffice.org/49414
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
index 1ec6ec0e..b64a41f734ed 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
@@ -2700,7 +2700,7 @@
 
   Specifies the settings for inserting captions for various 
object types.
 
-
+
   
 Specifies the order of the captions. If true, the number 
appears in front of the category.
 Caption order: Numbering first
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115241] CALC, UI: There is no easy way to see the cells with conditional formatting

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115241

--- Comment #4 from Timur  ---
What we agree is that there is no easy way to see the cells with conditional
formatting and we should be able to see cells with conditional formatting set.

I suggested 1. for permanent highlighting, to add an option "Preview Condition"
in Tools - Options - LibreOffice Calc - View and also in View menu (like Value
Highlighting). 
I stay with my option 1. for this bug, to see those cells if needed. 

Cor suggested (let's call 4.) temporary selection with Edit > Select > Cells
with conditional formatting.
Cor's suggestion is useful maybe to clear them all and can be another bug. Why
not have both.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: officecfg/registry

2018-02-08 Thread Stephan Bergmann

 officecfg/registry/schema/org/openoffice/Office/Writer.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c7ab472b47023c94c06de9e3479a2e0271084dfc
Author: Stephan Bergmann 
Date:   Thu Feb 8 09:17:18 2018 +0100

/org.openoffice.Office.Writer/Layout/Other/TabStop should be localized

...as b1b3251478926251d4d1c3e9ef864171548d85b5 "INTEGRATION: CWS os103: 
#i81308#
default tab stop in local zh-CN changed to 0.74 cm" added a special value 
for
xml:lang="zh-CN", but failed to take into account that the property is not
localized.

Until now, every installation that had the zh-CN localization installed (but
regardless of whether or not it was actually using it) would always have
reported the special zh-CN value (740), while any other installation would
always have reported the default value (1250).

Unless the value was overwritten in registrymodifications.xcu (which, it 
turns
out, it always was, see 35140501779622194337e630b274e74abeedca4d "Add 
missing
no-modify mode for SwMasterUsrPref::Set* functions"; but could also have 
been
done explicitly by the user by changing the Options dialog "LibreOffice 
Writer -
General - Settings - Tab stops" setting).  In which case the zh-CN 
localization
will now use its default value (740), while all other localizations will use
whatever value had been stored (without an xml:lang attribute) in
registrymodifications.xcu.  This is unfortunate (as the zh-CN localization 
may
lose any value explicitly set by the user, while non-zh-CN localizations may
continue to use a wrong default value, if the zh-CN localization is or ever 
had
been installed).  It should probably be mentioned in the release notes.

(Strictly speaking, changing a property from non-localized to localized, as 
is
done here as well as in e.g. ffd8369b909c86653ef30593fddf67c9f5308583
"rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props" is an
incompatible change which 3rd-party code can observe through the
css.configuration UNO API.  But chances are extremely low that this will 
have
any impact, as access to any property's value is normally done in a way that
makes it transparent whether or not the property is localizied.)

Change-Id: I6f49ecd9ac145dfe6825e727e72fffea515490ea
Reviewed-on: https://gerrit.libreoffice.org/49433
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
index 2b6465cdee93..1ec6ec0e 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
@@ -1506,7 +1506,7 @@
 
   
 
-
+
   
   
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 115241] CALC, UI: There is no easy way to see the cells with conditional formatting

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115241

--- Comment #4 from Timur  ---
What we agree is that there is no easy way to see the cells with conditional
formatting and we should be able to see cells with conditional formatting set.

I suggested 1. for permanent highlighting, to add an option "Preview Condition"
in Tools - Options - LibreOffice Calc - View and also in View menu (like Value
Highlighting). 
I stay with my option 1. for this bug, to see those cells if needed. 

Cor suggested (let's call 4.) temporary selection with Edit > Select > Cells
with conditional formatting.
Cor's suggestion is useful maybe to clear them all and can be another bug. Why
not have both.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: l10ntools/Executable_genlang.mk l10ntools/inc l10ntools/source Repository.mk solenv/clang-format

2018-02-08 Thread Stephan Bergmann

 Repository.mk   |1 
 l10ntools/Executable_genlang.mk |   52 --
 l10ntools/inc/gConv.hxx |   71 --
 l10ntools/inc/gConvPo.hxx   |   71 --
 l10ntools/inc/gConvProp.hxx |   34 -
 l10ntools/inc/gConvSrc.hxx  |   75 ---
 l10ntools/inc/gConvTree.hxx |   65 --
 l10ntools/inc/gConvUi.hxx   |   39 -
 l10ntools/inc/gConvUlf.hxx  |   44 -
 l10ntools/inc/gConvXcs.hxx  |   46 -
 l10ntools/inc/gConvXcu.hxx  |   57 --
 l10ntools/inc/gConvXhp.hxx  |   69 --
 l10ntools/inc/gConvXml.hxx  |   39 -
 l10ntools/inc/gConvXrm.hxx  |   50 --
 l10ntools/inc/gL10nMem.hxx  |  139 -
 l10ntools/source/gConv.cxx  |  272 ---
 l10ntools/source/gConvPo.cxx|  269 ---
 l10ntools/source/gConvProp.cxx  |   31 -
 l10ntools/source/gConvSrc.cxx   |  330 -
 l10ntools/source/gConvTree.cxx  |  200 
 l10ntools/source/gConvUi.cxx|   40 -
 l10ntools/source/gConvUlf.cxx   |   76 ---
 l10ntools/source/gConvXcs.cxx   |  128 -
 l10ntools/source/gConvXcu.cxx   |  181 ---
 l10ntools/source/gConvXhp.cxx   |  391 
 l10ntools/source/gConvXml.cxx   |   40 -
 l10ntools/source/gConvXrm.cxx   |  135 -
 l10ntools/source/gDiff.sh   |   20 
 l10ntools/source/gL10nMem.cxx   |  969 
 l10ntools/source/gLang.cxx  |  418 -
 l10ntools/source/gLexPo.l   |  125 -
 l10ntools/source/gLexSrc.l  |  351 --
 l10ntools/source/gLexTree.l |  127 -
 l10ntools/source/gLexUi.l   |   90 ---
 l10ntools/source/gLexUlf.l  |  107 
 l10ntools/source/gLexXcs.l  |   76 ---
 l10ntools/source/gLexXcu.l  |  127 -
 l10ntools/source/gLexXhp.l  |  157 --
 l10ntools/source/gLexXml.l  |   90 ---
 l10ntools/source/gLexXrm.l  |   97 
 l10ntools/source/gRun.sh|  500 
 l10ntools/source/gTest.sh   |6 
 solenv/clang-format/blacklist   |   27 -
 43 files changed, 6232 deletions(-)

New commits:
commit bcbb3c4f5b23acd4fe73c7d8b080d20c49d664f8
Author: Stephan Bergmann 
Date:   Wed Feb 7 20:56:29 2018 +0100

Remove dead Executable_genlang

...originally introduce with 999c68f12f1d95b16a97294949a0e6ba6d3ba259 
"genLang
project (awareness)", but apparently never took off.

Change-Id: I6f61271a75d96750dea63de596b7745c2f589b83
Reviewed-on: https://gerrit.libreoffice.org/49389
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/Repository.mk b/Repository.mk
index 17dab1319038..2f34509f4f4c 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -34,7 +34,6 @@ $(eval $(call gb_Helper_register_executables,NONE, \
genconv_dict \
gendict \
genindex_data \
-   genlang \
helpex \
idxdict \
langsupport \
diff --git a/l10ntools/Executable_genlang.mk b/l10ntools/Executable_genlang.mk
deleted file mode 100644
index 0299493abb57..
--- a/l10ntools/Executable_genlang.mk
+++ /dev/null
@@ -1,52 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-
-$(eval $(call gb_Executable_Executable,genlang))
-
-$(eval $(call gb_Executable_set_include,genlang,\
--I$(SRCDIR)/l10ntools/inc \
-$$(INCLUDE) \
-))
-
-$(eval $(call gb_Executable_use_externals,genlang,\
-boost_headers \
-))
-
-
-$(eval $(call gb_Executable_add_scanners,genlang,\
-l10ntools/source/gLexPo   \
-l10ntools/source/gLexUi   \
-l10ntools/source/gLexSrc  \
-l10ntools/source/gLexXcu  \
-l10ntools/source/gLexXcs  \
-l10ntools/source/gLexXrm  \
-l10ntools/source/gLexXml  \
-l10ntools/source/gLexXhp  \
-l10ntools/source/gLexUlf  \
-l10ntools/source/gLexTree \
-))
-
-$(eval $(call gb_Executable_add_exception_objects,genlang,\
-l10ntools/source/gLang  \
-l10ntools/source/gL10nMem   \
-l10ntools/source/gConvProp  \
-l10ntools/source/gConv  \
-l10ntools/source/gConvPo\
-l10ntools/source/gConvSrc   \
-l10ntools/source/gConvUi\
-l10ntools/source/gConvXrm   \
-l10ntools/source/gConvXml   \
-l10ntools/source/gConvXhp   \
-l10ntools/source/gConvXcs   \
-l10ntools/source/gConvXcu   \
-l10ntools/source/gConvUlf   \
-l10ntools/source/gConvTree  \
-))
-
-# vim:set noet sw=4 ts=4:
diff --git a/l10ntools/inc/gConv.hxx b/l10ntools/inc/gConv.hxx
deleted file mode 100644
index a32291272278..
--- a/l10ntools/inc/gConv.hxx
+++ /dev/null
@@ -1,71 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- *

[Libreoffice-bugs] [Bug 41316] Page styles should support hierarchical parent-child relationships ( like paragraph or character styles)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41316

--- Comment #13 from Elmar  ---
Is there a definitive simple user guide to the creation and use of style in LO?

I have been sold on the concept of styles since I first used Wordstar and have
always been frustrated by poor implementation in Word.

Every now and then (at least once a year) I take down my templates and try to
fix them up, but get stymied by the priority and the complexities. Especially
when it comes to headings and number lists.

I am prepared to attempt such a help document if it does not exist (and I ahve
nto found one in my googling), but could you point me to any material (other
than the standard help) - especially which can be used to create a precedence
map, and rules?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115571] Enhance Writer and Calc with Convert SVG / image to Polygon ( as supported in Draw and Impress)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115571

Gerry  changed:

   What|Removed |Added

Summary|Add support for Convert SVG |Enhance Writer and Calc
   |to polygon also in Writer   |with Convert SVG / image to
   |and Calc|Polygon (as supported in
   ||Draw and Impress)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115571] New: Add support for Convert SVG to polygon also in Writer and Calc

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115571

Bug ID: 115571
   Summary: Add support for Convert SVG to polygon also in Writer
and Calc
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gerry.trep...@googlemail.com

Description:
LO Draw and Impress have the excellent feature to convert images and inserted
svg files to polygons. This allows to edit the image as vector shapes.


Actual Results:  
See: https://help.libreoffice.org/Impress/To_Polygon

Expected Results:
Enhancement request:
Please add this feature also to Writer and Calc. These two applications
currently do not support "convert to polygon".

Competitive analysis:
MS Office 365 (Word, Excel, Powerpoint) supports "Convert an SVG image to an
Office shape"
(https://support.office.com/en-us/article/edit-svg-images-in-microsoft-office-2016-69f29d39-194a-4072-8c35-dbe5e7ea528c?ui=en-US=en-US=US)


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13) AppleWebKit/603.1.13
(KHTML, like Gecko) Version/10.1 Safari/603.1.13

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #6 from rob...@familiegrosskopf.de ---
Did it really work for you with two slashes, not three slashes? Please attach a
database-file (no data inside needed) where it will work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115570] New: Impress Print settings not retained between prints

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115570

Bug ID: 115570
   Summary: Impress Print settings not retained between prints
   Product: LibreOffice
   Version: 5.4.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: enhancement
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

In Impress, select File - Print - LibreOffice Impress tab.
Select any option in the Contents, Color or Size section other than the
defaults. 
Start the printing.
On the next run of the Print dialog, these settings are back on their defaults. 

I think it would be nice to have configuration keys for these and save these
settings automatically.

As comparison, in Writer such settings are saved under Writer/Print/Content :

https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Writer.xcs#1950

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #5 from rob...@familiegrosskopf.de ---
Created attachment 139717
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139717=edit
Firebird external database file for testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #4 from rob...@familiegrosskopf.de ---
I could only test with OpenSUSE 42.2 rpm Linux.
I have tried to connect to a Firebird-file. It gives an error:
---
firebird_sdbc error:
*unsupported on-disk structure for file
/home/user/Dokumente/LibreOffice/Firebird/libretest.fdb; found 11.2, support
12.0
caused by
'isc_attach_database'
---
The path is this:
file:///home/user/Dokumente/LibreOffice/Firebird/libretest.fdb
If I will remove one slash after file:/ the whole LO crashes immediately when
trying to connect to the database.

I don't get any working connection to a Firebird-file directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 80320] EDITING: Pictures in Reports blow up *.odb-File

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=80320

--- Comment #9 from rob...@familiegrosskopf.de ---
Tested again with
Version: 6.0.0.3
Build-ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: kde4; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

Bug hasn't changed in OpenSUSE 42.2 64 bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41316] Page styles should support hierarchical parent-child relationships ( like paragraph or character styles)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=41316

--- Comment #12 from ajlittoz  ---
I fully support this enhancement request and hope for it implemented soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92936] FILESAVE: Inserting big image in a form destroys all input since last opening of *.odb-file

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92936

--- Comment #17 from rob...@familiegrosskopf.de ---
Tested again with
Version: 6.0.0.3
Build-ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU-Threads: 4; BS: Linux 4.4; UI-Render: Standard; VCL: kde4; 
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group

Bug hasn't changed in OpenSUSE 42.2 64 bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang include/tools

2018-02-08 Thread Noel Grandin

 compilerplugins/clang/changerectanglegetref.cxx |  268 
 include/tools/gen.hxx   |5 
 2 files changed, 273 insertions(+)

New commits:
commit c07b913cc6f2ad29863c0c9a50bd3b6bdd849569
Author: Noel Grandin 
Date:   Thu Feb 8 15:51:39 2018 +0200

add setter methods to tools::Rectangle

intended to replace the existing methods that return mutable ref

And add the clang rewriter I will use to do most of the work.

Change-Id: If00be13da5c16c07671cedbcfea21528bac33c8a
Reviewed-on: https://gerrit.libreoffice.org/49430
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/changerectanglegetref.cxx 
b/compilerplugins/clang/changerectanglegetref.cxx
new file mode 100644
index ..b943e9f4516c
--- /dev/null
+++ b/compilerplugins/clang/changerectanglegetref.cxx
@@ -0,0 +1,268 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * Based on LLVM/Clang.
+ *
+ * This file is distributed under the University of Illinois Open Source
+ * License. See LICENSE.TXT for details.
+ *
+ */
+
+#include "plugin.hxx"
+#include "check.hxx"
+#include 
+
+/**
+ * Changes calls to tools::Rectangle methods that return a ref to instead call 
the setter methods.
+ *
+ * run as:
+ *   make COMPILER_PLUGIN_TOOL=changerectanglegetref UPDATE_FILES=all 
FORCE_COMPILE_ALL=1
+ * or
+ *   make  COMPILER_PLUGIN_TOOL=changerectanglegetref 
FORCE_COMPILE_ALL=1
+ */
+
+namespace
+{
+class ChangeRectangleGetRef : public 
RecursiveASTVisitor,
+  public loplugin::RewritePlugin
+{
+public:
+explicit ChangeRectangleGetRef(loplugin::InstantiationData const& data)
+: RewritePlugin(data)
+{
+}
+virtual void run() override;
+bool VisitCXXMemberCallExpr(CXXMemberCallExpr const* call);
+
+private:
+bool ChangeAssignment(Stmt const* parent, std::string const& methodName);
+bool ChangeBinaryOperator(BinaryOperator const* parent, CXXMemberCallExpr 
const* call,
+  std::string const& methodName);
+bool ChangeUnaryOperator(UnaryOperator const* parent, CXXMemberCallExpr 
const* call,
+ std::string const& methodName);
+std::string extractCode(SourceLocation startLoc, SourceLocation endLoc);
+};
+
+void ChangeRectangleGetRef::run()
+{
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+}
+
+bool ChangeRectangleGetRef::VisitCXXMemberCallExpr(CXXMemberCallExpr const* 
call)
+{
+if (ignoreLocation(call))
+return true;
+const CXXMethodDecl* func = call->getMethodDecl();
+if (!func)
+return true;
+if (func->isConst())
+return true;
+auto dc = loplugin::DeclCheck(func);
+std::string methodName;
+if 
(dc.Function("Top").Class("Rectangle").Namespace("tools").GlobalNamespace())
+methodName = "Top";
+else if 
(dc.Function("Bottom").Class("Rectangle").Namespace("tools").GlobalNamespace())
+methodName = "Bottom";
+else if 
(dc.Function("Left").Class("Rectangle").Namespace("tools").GlobalNamespace())
+methodName = "Left";
+else if 
(dc.Function("Right").Class("Rectangle").Namespace("tools").GlobalNamespace())
+methodName = "Right";
+else
+return true;
+if (!loplugin::TypeCheck(func->getReturnType()).LvalueReference())
+return true;
+
+auto parent = getParentStmt(call);
+if (!parent)
+return true;
+if (auto unaryOp = dyn_cast(parent))
+{
+if (!ChangeUnaryOperator(unaryOp, call, methodName))
+report(DiagnosticsEngine::Warning, "Could not fix this one1", 
call->getLocStart());
+return true;
+}
+auto binaryOp = dyn_cast(parent);
+if (!binaryOp)
+{
+//parent->dump();
+//report(DiagnosticsEngine::Warning, "Could not fix this 
one3", call->getLocStart());
+return true;
+}
+auto opcode = binaryOp->getOpcode();
+if (opcode == BO_Assign)
+{
+if (!ChangeAssignment(parent, methodName))
+report(DiagnosticsEngine::Warning, "Could not fix this one4", 
call->getLocStart());
+return true;
+}
+if (opcode == BO_RemAssign || opcode == BO_AddAssign || opcode == 
BO_SubAssign
+|| opcode == BO_MulAssign || opcode == BO_DivAssign)
+{
+if (!ChangeBinaryOperator(binaryOp, call, methodName))
+report(DiagnosticsEngine::Warning, "Could not fix this one5", 
call->getLocStart());
+return true;
+}
+return true;
+}
+
+bool ChangeRectangleGetRef::ChangeAssignment(Stmt const* parent, std::string 
const& methodName)
+{
+// Look for expressions like
+//aRect.Left() = ...;
+// and replace with
+//aRect.SetLeft( ... );
+

[Libreoffice-bugs] [Bug 115480] SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115480

Xavier Van Wijmeersch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Xavier Van Wijmeersch  ---
I think it can be closed as WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115569] Trying to convert a table row to a text

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115569

--- Comment #1 from Carlos Fernando Castaneda Olano  
---
Created attachment 139716
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139716=edit
The wordfile that i try to convert a row of a little long table to text in the
middle of the document

The wordfile that I was working when LibreOffice Writer crash when I try to
convert a row of a little long table to text.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115569] Trying to convert a table row to a text

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115569

Carlos Fernando Castaneda Olano  changed:

   What|Removed |Added

   Keywords||dataLoss, filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115569] Trying to convert a table row to a text

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115569

Carlos Fernando Castaneda Olano  changed:

   What|Removed |Added

Crash report or||http://crashreport.libreoff
crash signature||ice.org/stats/crash_details
   ||/c3d8e425-629f-4fd4-9150-08
   ||7a3d92a18a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115569] New: Trying to convert a table row to a text

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115569

Bug ID: 115569
   Summary: Trying to convert a table row to a text
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fernando_c...@outlook.com

Description:
I loaded a wordfile and trying to convert a row of a little long table to a
text the program crash.

Steps to Reproduce:
1. Loading a wordfile 
2. Try to convert a row in a little long table
3. LibreOffice Crash

Actual Results:  
LibreOffice Crash so the software restart and it tries to recover the file.

Expected Results:
Convert a row of a little long table in a text to separate it and get two
tables with an space in the middle.


Reproducible: Didn't try


User Profile Reset: No



Additional Info:
The software have done crash

Please check:

http://crashreport.libreoffice.org/stats/crash_details/c3d8e425-629f-4fd4-9150-087a3d92a18a

Thank you.


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101
Firefox/58.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2018-02-08 Thread Markus Mohrhard

 sc/source/core/data/document.cxx |   14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit cdc44358a5a2530eb2c8bb6beb90b00cc8c1b6cb
Author: Markus Mohrhard 
Date:   Thu Feb 8 01:13:56 2018 +0100

always check whether pChartListenerCollection is not a nullptr

Change-Id: Ibe3ade28884b4e1264cd5a5a68a8e428ee3d9a48
Reviewed-on: https://gerrit.libreoffice.org/49454
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 7d1f821de849..7ebdb404d7e8 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -764,7 +764,8 @@ bool ScDocument::DeleteTab( SCTAB nTab )
 SetAllFormulasDirty(aFormulaDirtyCxt);
 }
 // sheet names of references are not valid until sheet is 
deleted
-pChartListenerCollection->UpdateScheduledSeriesRanges();
+if (pChartListenerCollection)
+pChartListenerCollection->UpdateScheduledSeriesRanges();
 
 if (comphelper::LibreOfficeKit::isActive())
 {
@@ -864,7 +865,8 @@ bool ScDocument::DeleteTabs( SCTAB nTab, SCTAB nSheets )
 SetAllFormulasDirty(aFormulaDirtyCxt);
 }
 // sheet names of references are not valid until sheet is 
deleted
-pChartListenerCollection->UpdateScheduledSeriesRanges();
+if (pChartListenerCollection)
+pChartListenerCollection->UpdateScheduledSeriesRanges();
 
 if (comphelper::LibreOfficeKit::isActive())
 {
@@ -1367,7 +1369,7 @@ bool ScDocument::InsertRow( SCCOL nStartCol, SCTAB 
nStartTab,
 bRet = true;
 }
 SetAutoCalc( bOldAutoCalc );
-if ( bRet )
+if ( bRet && pChartListenerCollection )
 pChartListenerCollection->UpdateDirtyCharts();
 return bRet;
 }
@@ -1475,7 +1477,8 @@ void ScDocument::DeleteRow( SCCOL nStartCol, SCTAB 
nStartTab,
 std::for_each(maTabs.begin(), maTabs.end(), 
BroadcastRecalcOnRefMoveHandler( this));
 }
 
-pChartListenerCollection->UpdateDirtyCharts();
+if (pChartListenerCollection)
+pChartListenerCollection->UpdateDirtyCharts();
 }
 
 void ScDocument::DeleteRow( const ScRange& rRange )
@@ -1676,7 +1679,8 @@ void ScDocument::DeleteCol(SCROW nStartRow, SCTAB 
nStartTab, SCROW nEndRow, SCTA
 std::for_each(maTabs.begin(), maTabs.end(), 
BroadcastRecalcOnRefMoveHandler( this));
 }
 
-pChartListenerCollection->UpdateDirtyCharts();
+if (pChartListenerCollection)
+pChartListenerCollection->UpdateDirtyCharts();
 }
 
 void ScDocument::DeleteCol( const ScRange& rRange )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/oox oox/source sd/qa sd/source

2018-02-08 Thread Szymon Kłos

 include/oox/ppt/slidetransitioncontext.hxx |1 +
 oox/source/ppt/slidetransitioncontext.cxx  |9 -
 sd/qa/unit/data/pptx/tdf115394-zero.pptx   |binary
 sd/qa/unit/export-tests-ooxml2.cxx |   16 
 sd/source/filter/eppt/pptx-epptooxml.cxx   |8 
 5 files changed, 29 insertions(+), 5 deletions(-)

New commits:
commit df835773fa8d66a1bd534c5b374ac27552751941
Author: Szymon Kłos 
Date:   Thu Feb 8 23:21:38 2018 +0100

tdf#115394 correct transition in case of 0s

Change-Id: I23d18acef0bd5db4a4ad6fc67d409e7ed5c93949
Reviewed-on: https://gerrit.libreoffice.org/49462
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 

diff --git a/include/oox/ppt/slidetransitioncontext.hxx 
b/include/oox/ppt/slidetransitioncontext.hxx
index 3361fd07a5a5..f6b2e7a91d56 100644
--- a/include/oox/ppt/slidetransitioncontext.hxx
+++ b/include/oox/ppt/slidetransitioncontext.hxx
@@ -47,6 +47,7 @@ namespace oox { namespace ppt {
 private:
 PropertyMap&maSlideProperties;
 boolmbHasTransition;
+boolmbHasTransitionDuration;
 SlideTransition maTransition;
 };
 
diff --git a/oox/source/ppt/slidetransitioncontext.cxx 
b/oox/source/ppt/slidetransitioncontext.cxx
index 7639df7c023b..94fc1c3862ae 100644
--- a/oox/source/ppt/slidetransitioncontext.cxx
+++ b/oox/source/ppt/slidetransitioncontext.cxx
@@ -47,6 +47,7 @@ SlideTransitionContext::SlideTransitionContext( 
FragmentHandler2 const & rParent
 : FragmentHandler2( rParent )
 , maSlideProperties( aProperties )
 , mbHasTransition( false )
+, mbHasTransitionDuration( false )
 {
 // ST_TransitionSpeed
 maTransition.setOoxTransitionSpeed( rAttribs.getToken( XML_spd, XML_fast ) 
);
@@ -54,7 +55,13 @@ SlideTransitionContext::SlideTransitionContext( 
FragmentHandler2 const & rParent
 // p14:dur
 sal_Int32 nDurationInMs = rAttribs.getInteger( P14_TOKEN( dur ), -1 );
 if( nDurationInMs > -1 )
+{
+// In MSO 0 is visible as 0.01s
+if( nDurationInMs == 0.0 )
+nDurationInMs = 10;
 maTransition.setOoxTransitionSpeed( nDurationInMs / 1000.0 );
+mbHasTransitionDuration = true;
+}
 
 // TODO
 rAttribs.getBool( XML_advClick, true );
@@ -182,7 +189,7 @@ void SlideTransitionContext::onEndElement()
 {
 if( isCurrentElement(PPT_TOKEN( transition )) )
 {
-if( mbHasTransition )
+if( mbHasTransition || mbHasTransitionDuration )
 {
 maTransition.setSlideProperties( maSlideProperties );
 mbHasTransition = false;
diff --git a/sd/qa/unit/data/pptx/tdf115394-zero.pptx 
b/sd/qa/unit/data/pptx/tdf115394-zero.pptx
new file mode 100644
index ..e8fb0cfa240c
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf115394-zero.pptx differ
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx 
b/sd/qa/unit/export-tests-ooxml2.cxx
index 6b2f34f49a05..062dab0c4cd0 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -129,6 +129,7 @@ public:
 void testTdf107608();
 void testTdf111786();
 void testTdf115394();
+void testTdf115394Zero();
 
 CPPUNIT_TEST_SUITE(SdOOXMLExportTest2);
 
@@ -183,6 +184,7 @@ public:
 CPPUNIT_TEST(testTdf107608);
 CPPUNIT_TEST(testTdf111786);
 CPPUNIT_TEST(testTdf115394);
+CPPUNIT_TEST(testTdf115394Zero);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -1438,6 +1440,20 @@ void SdOOXMLExportTest2::testTdf115394()
 xDocShRef->DoClose();
 }
 
+void SdOOXMLExportTest2::testTdf115394Zero()
+{
+sd::DrawDocShellRef xDocShRef = 
loadURL(m_directories.getURLFromSrc("/sd/qa/unit/data/pptx/tdf115394-zero.pptx"),
 PPTX);
+utl::TempFile tempFile;
+xDocShRef = saveAndReload(xDocShRef.get(), PPTX, );
+double fTransitionDuration;
+
+SdPage* pPage = xDocShRef->GetDoc()->GetSdPage(0, PageKind::Standard);
+fTransitionDuration = pPage->getTransitionDuration();
+CPPUNIT_ASSERT_EQUAL(0.01, fTransitionDuration);
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdOOXMLExportTest2);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx 
b/sd/source/filter/eppt/pptx-epptooxml.cxx
index bcf9b0e145ea..6bc8bd0416e5 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -641,10 +641,6 @@ void PowerPointExport::WriteTransition(const FSHelperPtr& 
pFS)
 }
 }
 
-// check if we resolved what transition to export
-if (!nPPTTransitionType && !bOOXmlSpecificTransition)
-return;
-
 AnimationSpeed animationSpeed = AnimationSpeed_MEDIUM;
 const char* speed = nullptr;
 sal_Int32 advanceTiming = -1;
@@ -703,6 +699,10 @@ void PowerPointExport::WriteTransition(const FSHelperPtr& 
pFS)
 }
 }
 
+// check if

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #3 from s...@imail.ru ---
I selected a connection to an existing database in the Wizard. Type in
drop-down list the Firebird file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115268] FILEOPEN - Writer 6 crash opening MS office files if app not already open

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115268

--- Comment #34 from Rodney  ---
32 bit windows build appears to be working fine as well.  Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115547] Firebird: Link is formed to an external file with file:///C: (three slash)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115547

--- Comment #2 from s...@imail.ru ---
It is worth trying to create an odb with an external Firebird file.
I have tried on Windows 7 (installed version Libreoffice) and Windows 10
(portable version).
An error occurs when I create a new database. LO can't find the file.
If I remove unnecessary slash when you select a file creation passes without
error.
Maybe you should try?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106880] PPT/ PPTX files with slide transitions having specific duration are imported with wrong duration

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=106880

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Aron Budea  ---
Szymon's taken care of the PPT part as well, let's close this as duplicate.

*** This bug has been marked as a duplicate of bug 115394 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103704
Bug 103704 depends on bug 106880, which changed state.

Bug 106880 Summary: PPT/PPTX files with slide transitions having specific 
duration are imported with wrong duration
https://bugs.documentfoundation.org/show_bug.cgi?id=106880

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113331] [META] PPT (binary) format bug tracker

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=113331
Bug 113331 depends on bug 106880, which changed state.

Bug 106880 Summary: PPT/PPTX files with slide transitions having specific 
duration are imported with wrong duration
https://bugs.documentfoundation.org/show_bug.cgi?id=106880

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108226] [META] PPTX (OOXML) bug tracker

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108226
Bug 108226 depends on bug 106880, which changed state.

Bug 106880 Summary: PPT/PPTX files with slide transitions having specific 
duration are imported with wrong duration
https://bugs.documentfoundation.org/show_bug.cgi?id=106880

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Mike Kaganski  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114300] [META] Bugs and enhancements involving lock files or file locking

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114300
Bug 114300 depends on bug 108210, which changed state.

Bug 108210 Summary: Can't open file for editing if there is a lingering lock 
file from a different user
https://bugs.documentfoundation.org/show_bug.cgi?id=108210

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115568] New: The "=?UTF-8?Q?=D9=94=20?=" did not use font character in the text when use up of " ه "

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115568

Bug ID: 115568
   Summary: The "ٔ " did not use font character in the text when
use up of "ه"
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h66...@gmail.com

Created attachment 139715
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139715=edit
correct character in special character

The "ٔ " did not use font character in the text when use up of "ه".
and when I use correct character from special character, it can't be match to
text.
i sent 2 screenshot from problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103238] [META] Customize dialog bugs and enhancements

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103238
Bug 103238 depends on bug 115470, which changed state.

Bug 115470 Summary: Name of the "Cycle Case" is too long
https://bugs.documentfoundation.org/show_bug.cgi?id=115470

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108210] Can' t open file for editing if there is a lingering lock file from a different user

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108210

--- Comment #4 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a7057250c8f73fdfb4c65a7525d17e9770459df

tdf#108210: Allow to ignore a lock file if there's no filesystem lock

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/sfx2 sfx2/source uui/inc uui/source

2018-02-08 Thread Mike Kaganski

 include/sfx2/docfile.hxx  |   19 -
 include/sfx2/strings.hrc  |3 
 sfx2/source/doc/docfile.cxx   |   71 +++---
 sfx2/source/view/viewfrm.cxx  |  134 +++---
 uui/inc/strings.hrc   |3 
 uui/source/iahndl-locking.cxx |   12 +++
 uui/source/iahndl.cxx |9 +-
 uui/source/openlocked.cxx |   14 +++-
 uui/source/openlocked.hxx |2 
 9 files changed, 194 insertions(+), 73 deletions(-)

New commits:
commit 2a7057250c8f73fdfb4c65a7525d17e9770459df
Author: Mike Kaganski 
Date:   Thu Feb 8 18:06:06 2018 +0300

tdf#108210: Allow to ignore a lock file if there's no filesystem lock

Two cases are handled: when a file is being opened, and when it was
opened read-only already, and one tries to reopen it in edit mode.
The option to ignore locking and open the file anyway is only offered
when there is no filesystem lock present on the file.

Change-Id: I377d3cae4c949ae64d449634acea8fb3f68a5700
Reviewed-on: https://gerrit.libreoffice.org/49448
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/include/sfx2/docfile.hxx b/include/sfx2/docfile.hxx
index 822c69b1da4f..06a7f9623764 100644
--- a/include/sfx2/docfile.hxx
+++ b/include/sfx2/docfile.hxx
@@ -162,11 +162,13 @@ public:
 boolCommit();
 boolIsStorage();
 
-enum class ShowLockResult { NoLock, Succeeded,Try };
-ShowLockResult  ShowLockedDocumentDialog( const LockFileEntry& aData, 
bool bIsLoading, bool bOwnLock, bool bHandleSysLocked);
-voidLockOrigFileOnDemand( bool bLoading, bool bNoUI );
-enum class MessageDlg{ LockFileIgnore, LockFileCorrupt };
-boolShowLockFileProblemDialog(MessageDlg nWhichDlg);
+enum class  LockFileResult
+{
+Failed,
+FailedLockFile, // there was only lock file that prevented success - 
no syslock or IO error
+Succeeded,
+};
+LockFileResult  LockOrigFileOnDemand( bool bLoading, bool bNoUI, bool 
bTryIgnoreLockFile = false );
 voidDisableUnlockWebDAV( bool bDisableUnlockWebDAV = true 
);
 voidUnlockFile( bool bReleaseLockStream );
 /// Lets Transfer_Impl() not fsync the output file.
@@ -275,6 +277,13 @@ public:
 
 static bool SetWritableForUserOnly( const OUString& aURL );
 static sal_uInt32   CreatePasswordToModifyHash( const OUString& aPasswd, 
bool bWriter );
+
+private:
+enum class ShowLockResult { NoLock, Succeeded, Try };
+ShowLockResult  ShowLockedDocumentDialog(const LockFileEntry& aData, 
bool bIsLoading, bool bOwnLock, bool bHandleSysLocked);
+enum class MessageDlg { LockFileIgnore, LockFileCorrupt };
+boolShowLockFileProblemDialog(MessageDlg nWhichDlg);
+
 };
 
 #endif
diff --git a/include/sfx2/strings.hrc b/include/sfx2/strings.hrc
index 889ccf8ab22b..c36a37b4893a 100644
--- a/include/sfx2/strings.hrc
+++ b/include/sfx2/strings.hrc
@@ -235,6 +235,9 @@
 #define STR_CANT_CLOSE  NC_("STR_CANT_CLOSE", "The 
document cannot be closed because a\n print job is being carried out.")
 #define STR_ERROR_SEND_MAIL NC_("STR_ERROR_SEND_MAIL", "An 
error occurred in sending the message. Possible errors could be a missing user 
account or a defective setup.\nPlease check the %PRODUCTNAME settings or your 
e-mail program settings.")
 #define STR_QUERY_OPENASTEMPLATE
NC_("STR_QUERY_OPENASTEMPLATE", "This document cannot be edited, possibly due 
to missing access rights. Do you want to edit a copy of the document?")
+#define STR_QUERY_OPENASTEMPLATE_ALLOW_IGNORE   
NC_("STR_QUERY_OPENASTEMPLATE_ALLOW_IGNORE", "This document cannot be edited, 
because it is locked in another session. Do you want to edit a copy of the 
document?\n\nYou can also try to ignore the lock and open the file for 
editing.")
+#define STR_QUERY_OPENASTEMPLATE_OPENCOPY_BTN   
NC_("STR_QUERY_OPENASTEMPLATE_OPENCOPY_BTN", "Open ~Copy")
+#define STR_QUERY_OPENASTEMPLATE_OPEN_BTN   
NC_("STR_QUERY_OPENASTEMPLATE_OPEN_BTN", "~Open")
 #define STR_REPAIREDDOCUMENTNC_("STR_REPAIREDDOCUMENT", " 
(repaired document)")
 #define STR_NONCHECKEDOUT_DOCUMENT  
NC_("STR_NONCHECKEDOUT_DOCUMENT", "This document is not checked out on the 
server.")
 #define STR_READONLY_DOCUMENT   NC_("STR_READONLY_DOCUMENT", 
"This document is open in read-only mode.")
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 055cfa41859d..175ab138c5af 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -846,6 +846,8 @@ SfxMedium::ShowLockResult 
SfxMedium::ShowLockedDocumentDialog( const LockFileEnt
 OUString aInfo;
 ::rtl::Reference< ::ucbhelper::InteractionRequest >

[Libreoffice-bugs] [Bug 103919] Mailmerge e-mail does not send all merged documents

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103919

Aron Budea  changed:

   What|Removed |Added

 CC||wor...@ntymail.com

--- Comment #46 from Aron Budea  ---
*** Bug 115561 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115561] MAILMERGE WIZARD don't send all the mails

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115561

Aron Budea  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |DUPLICATE

--- Comment #1 from Aron Budea  ---
Opening a new bug report won't get the issue fixed faster I'm afraid. Let's
keep discussing them in their respective tickets.

*** This bug has been marked as a duplicate of bug 103919 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115476] LibreOffice Crash after login if quickstarter is enabled

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115476

--- Comment #12 from Kevin W. Gagel  ---
I checked the "Use Open GL..." setting. It was off (unchecked). I added check
to it and restarted LibreOffice.

Oddly the error message did not show up today after I turned the computer on
and logged in. I'll see how this goes and if it makes a difference or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105837] Wrong quotation marks entered

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=105837

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115567] LibreOffice-l10n-zh-tw 6.0.0.3 Packages from ppa seems incomplete

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115567

--- Comment #1 from Franklin Weng  ---
Created attachment 139714
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139714=edit
The options settings should be in Traditional Chinese not English

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115567] New: LibreOffice-l10n-zh-tw 6.0.0.3 Packages from ppa seems incomplete

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115567

Bug ID: 115567
   Summary: LibreOffice-l10n-zh-tw 6.0.0.3 Packages from ppa seems
incomplete
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: frank...@goodhorse.idv.tw

Description:
I upgraded my LibreOffice to 6.0.0.3 from ppa
(ppa:libreoffice/libreoffice-6-0).  After upgrading, the UI becomes half
Traditional Chinese and half English.  As attached images (later).

Steps to Reproduce:
1. add-apt-repository ppa:libreoffice/libreoffice-6-0
2. apt update; apt dist-upgrade
3. After upgrading LibreOffice to 6.0.0.3 the content of zh-tw language pack is
incomplete.

Actual Results:  
As attached images.

Expected Results:
The translation ratio is nearly 100%.  They should be in Traditional Chinese.


Reproducible: Always


User Profile Reset: No



Additional Info:
This should be a ubuntu packaging problem, but I didn't find out how to report
such issues in launchpad.


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/64.0.3282.140 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115566] New: Custom bullet (-) not shown during slideshow in Online

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115566

Bug ID: 115566
   Summary: Custom bullet (-) not shown during slideshow in Online
   Product: LibreOffice Online
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ba...@caesar.elte.hu

Created attachment 139713
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139713=edit
Sample ODP

In the attached slide the bullet is substituted with "-" (hyphen-minus)
character.
In online LO, during slideshow the "-" isn't shown, only the entries.
In desktop LO the minus is shown fine during slideshow.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115566] Custom bullet (-) not shown during slideshow in Online

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115566

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115565] New: Unable to use keyboard to move to previous or next toolbox item when Sidebar Navigator deck GotoPage control has focus

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115565

Bug ID: 115565
   Summary: Unable to use keyboard to move to previous or next
toolbox item when Sidebar Navigator deck GotoPage
control has focus
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

When the GotoPage edit spinbox control has the keyboard focus the Esc and Tab
key move focus to the deck title. The only way to access items that follow this
control using the keyboard is to Tab into the toolbox and use the left arrow
key to move backwards through the list of items up to the GotoPage control.

Here are steps to reproduce:

1) open sidebar Navigator deck
2) click on Headings
3) press ESC key
focus rectangle should be around deck title
4) press TAB TAB to enter helper items toolbox
5) use right arrow key to navigate to the GotoPage edit spinbox
cursor blinking in edit spinbox
6) press TAB
focus moves to deck title

I believe better behavior would be for TAB to move to the next item in the
toolbox and SHIFT TAB move to the previous item in the toolbox.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-2' - 6 commits - sc/inc sc/Library_sc.mk sc/source

2018-02-08 Thread Eike Rathke

 sc/Library_sc.mk  |1 
 sc/inc/document.hxx   |8 +-
 sc/inc/documentlinkmgr.hxx|6 -
 sc/source/core/data/conditio.cxx  |6 +
 sc/source/core/data/documen2.cxx  |2 
 sc/source/core/data/documen8.cxx  |   23 ++
 sc/source/core/data/formulacell.cxx   |7 -
 sc/source/core/inc/webservicelink.hxx |   49 +
 sc/source/core/tool/interpr2.cxx  |8 +-
 sc/source/core/tool/interpr7.cxx  |  102 +---
 sc/source/core/tool/rangenam.cxx  |8 +-
 sc/source/core/tool/webservicelink.cxx|  106 ++
 sc/source/filter/excel/excform.cxx|1 
 sc/source/filter/excel/excform8.cxx   |1 
 sc/source/filter/excel/impop.cxx  |1 
 sc/source/filter/excel/xicontent.cxx  |6 +
 sc/source/filter/excel/xiname.cxx |3 
 sc/source/filter/oox/condformatbuffer.cxx |2 
 sc/source/filter/oox/defnamesbuffer.cxx   |2 
 sc/source/filter/oox/formulabuffer.cxx|4 +
 sc/source/ui/docshell/docsh4.cxx  |4 -
 sc/source/ui/docshell/documentlinkmgr.cxx |   20 -
 sc/source/ui/view/tabvwsh4.cxx|2 
 23 files changed, 326 insertions(+), 46 deletions(-)

New commits:
commit feb6f545261ad6b420469f3b7d4e8660dd83898a
Author: Eike Rathke 
Date:   Mon Jan 29 18:19:33 2018 +0100

CheckLinkFormulaNeedingCheck() for named expressions

 This is a combination of 3 commits.

CheckLinkFormulaNeedingCheck() for .ods named expressions

This is specifically necessary for named expressions that are used
in conditional format formulas, for which RPN is generated at a
later stage, not during import.

(cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2)

CheckLinkFormulaNeedingCheck() for .xls named expressions

(cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616)

CheckLinkFormulaNeedingCheck() for .xlsx named expressions

(cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c)

 Conflicts:
sc/source/filter/oox/defnamesbuffer.cxx

e03cb5767c34f8157a492a6d6c3b0700d065052d
217c89822ab477a6c383d170ae739e44efd10fa3

Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc
Reviewed-on: https://gerrit.libreoffice.org/48858
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/rangenam.cxx b/sc/source/core/tool/rangenam.cxx
index 7626e16ae5f6..d147b101de61 100644
--- a/sc/source/core/tool/rangenam.cxx
+++ b/sc/source/core/tool/rangenam.cxx
@@ -64,9 +64,14 @@ ScRangeData::ScRangeData( ScDocument* pDok,
 mnMaxCol(-1)
 {
 if (!rSymbol.isEmpty())
-CompileRangeData( rSymbol, pDoc->IsImportingXML());
+{
 // Let the compiler set an error on unknown names for a subsequent
 // CompileUnresolvedXML().
+const bool bImporting = pDoc->IsImportingXML();
+CompileRangeData( rSymbol, bImporting);
+if (bImporting)
+pDoc->CheckLinkFormulaNeedingCheck( *pCode);
+}
 else
 {
 // #i63513#/#i65690# don't leave pCode as NULL.
@@ -199,6 +204,7 @@ void ScRangeData::CompileUnresolvedXML( 
sc::CompileFormulaContext& rCxt )
 // Don't let the compiler set an error for unknown names on final
 // compile, errors are handled by the interpreter thereafter.
 CompileRangeData( aSymbol, false);
+rCxt.getDoc()->CheckLinkFormulaNeedingCheck( *pCode);
 }
 }
 
diff --git a/sc/source/filter/excel/xiname.cxx 
b/sc/source/filter/excel/xiname.cxx
index d09661503c6b..8decfc00e8e0 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -265,7 +265,10 @@ void XclImpName::InsertName(const ScTokenArray* pArray)
 }
 }
 if (pData)
+{
+GetDoc().CheckLinkFormulaNeedingCheck( *pData->GetCode());
 mpScData = pData;   // cache for later use
+}
 }
 
 XclImpNameManager::XclImpNameManager( const XclImpRoot& rRoot ) :
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index 9de5851e3978..586511d1d25a 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -39,6 +39,7 @@
 #include "tokenarray.hxx"
 #include "tokenuno.hxx"
 #include "compiler.hxx"
+#include "document.hxx"
 
 namespace oox {
 namespace xls {
@@ -339,6 +340,7 @@ std::unique_ptr DefinedName::getScTokens(
 // after, a resulting error must be reset.
 sal_uInt16 nErr = pArray->GetCodeError();
 aCompiler.CompileTokenArray();
+getScDocument().CheckLinkFormulaNeedingCheck( *pArray);
 pArray->DelRPN();
 pArray->SetCodeError(nErr);
 
commit

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-3' - 6 commits - sc/inc sc/Library_sc.mk sc/qa sc/source

2018-02-08 Thread Eike Rathke

 sc/Library_sc.mk  |1 
 sc/inc/document.hxx   |8 +-
 sc/inc/documentlinkmgr.hxx|6 -
 sc/qa/unit/ucalc.cxx  |2 
 sc/source/core/data/conditio.cxx  |6 +
 sc/source/core/data/documen2.cxx  |2 
 sc/source/core/data/documen8.cxx  |   23 ++
 sc/source/core/data/formulacell.cxx   |7 -
 sc/source/core/inc/webservicelink.hxx |   49 +
 sc/source/core/tool/interpr2.cxx  |8 +-
 sc/source/core/tool/interpr7.cxx  |  106 ++
 sc/source/core/tool/rangenam.cxx  |8 +-
 sc/source/core/tool/webservicelink.cxx|  106 ++
 sc/source/filter/excel/excform.cxx|1 
 sc/source/filter/excel/excform8.cxx   |1 
 sc/source/filter/excel/impop.cxx  |1 
 sc/source/filter/excel/xicontent.cxx  |6 +
 sc/source/filter/excel/xiname.cxx |3 
 sc/source/filter/oox/condformatbuffer.cxx |2 
 sc/source/filter/oox/defnamesbuffer.cxx   |2 
 sc/source/filter/oox/formulabuffer.cxx|4 +
 sc/source/ui/docshell/docsh4.cxx  |4 -
 sc/source/ui/docshell/documentlinkmgr.cxx |   20 -
 sc/source/ui/view/tabvwsh4.cxx|2 
 24 files changed, 329 insertions(+), 49 deletions(-)

New commits:
commit e8fd1f19bb2662b36e21ec5cb4d87550a255cedd
Author: Eike Rathke 
Date:   Mon Jan 29 18:19:33 2018 +0100

CheckLinkFormulaNeedingCheck() for named expressions

 This is a combination of 3 commits.

CheckLinkFormulaNeedingCheck() for .ods named expressions

This is specifically necessary for named expressions that are used
in conditional format formulas, for which RPN is generated at a
later stage, not during import.

(cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2)

CheckLinkFormulaNeedingCheck() for .xls named expressions

(cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616)

CheckLinkFormulaNeedingCheck() for .xlsx named expressions

(cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c)

 Conflicts:
sc/source/filter/oox/defnamesbuffer.cxx

e03cb5767c34f8157a492a6d6c3b0700d065052d
217c89822ab477a6c383d170ae739e44efd10fa3

Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc
Reviewed-on: https://gerrit.libreoffice.org/48858
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 908854a7b281454332af434be9468ec45d420030)

diff --git a/sc/source/core/tool/rangenam.cxx b/sc/source/core/tool/rangenam.cxx
index eae117c08434..18cbabb1cd93 100644
--- a/sc/source/core/tool/rangenam.cxx
+++ b/sc/source/core/tool/rangenam.cxx
@@ -64,9 +64,14 @@ ScRangeData::ScRangeData( ScDocument* pDok,
 mnMaxCol(-1)
 {
 if (!rSymbol.isEmpty())
-CompileRangeData( rSymbol, pDoc->IsImportingXML());
+{
 // Let the compiler set an error on unknown names for a subsequent
 // CompileUnresolvedXML().
+const bool bImporting = pDoc->IsImportingXML();
+CompileRangeData( rSymbol, bImporting);
+if (bImporting)
+pDoc->CheckLinkFormulaNeedingCheck( *pCode);
+}
 else
 {
 // #i63513#/#i65690# don't leave pCode as NULL.
@@ -199,6 +204,7 @@ void ScRangeData::CompileUnresolvedXML( 
sc::CompileFormulaContext& rCxt )
 // Don't let the compiler set an error for unknown names on final
 // compile, errors are handled by the interpreter thereafter.
 CompileRangeData( aSymbol, false);
+rCxt.getDoc()->CheckLinkFormulaNeedingCheck( *pCode);
 }
 }
 
diff --git a/sc/source/filter/excel/xiname.cxx 
b/sc/source/filter/excel/xiname.cxx
index 7189c2a0a2f2..efc181921091 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -265,7 +265,10 @@ void XclImpName::InsertName(const ScTokenArray* pArray)
 }
 }
 if (pData)
+{
+GetDoc().CheckLinkFormulaNeedingCheck( *pData->GetCode());
 mpScData = pData;   // cache for later use
+}
 }
 
 XclImpNameManager::XclImpNameManager( const XclImpRoot& rRoot ) :
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index 79457ab57e5f..a1d10906c687 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -38,6 +38,7 @@
 #include "tokenarray.hxx"
 #include "tokenuno.hxx"
 #include "compiler.hxx"
+#include "document.hxx"
 
 namespace oox {
 namespace xls {
@@ -334,6 +335,7 @@ std::unique_ptr DefinedName::getScTokens(
 // after, a resulting error must be reset.
 FormulaError nErr = pArray->GetCodeError();
 aCompiler.CompileTokenArray();
+

[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-4' - 28 commits - compilerplugins/clang cui/source dbaccess/source icon-themes/galaxy instsetoo_native/inc_common instsetoo_native/util

2018-02-08 Thread Katarina Behrens

Rebased ref, commits from common ancestor:
commit b53c154e64306749525359e8dde5861aabc91399
Author: Katarina Behrens 
Date:   Wed Feb 10 14:42:18 2016 +0100

Branded images for msi installer

The sizes are 122 x 234, 374 x 44 installed units respectively, according to

http://msdn.microsoft.com/de-de/library/windows/desktop/aa369490%28v=vs.85%29.aspx

it is 163x312, 499x58 pixels at 96 dpi. I bumped dpi to 120 and it still 
looks pixelated,
but it's as good as it gets.

For better results, we need different graphics, with less fine details 
given the very limited
space

Change-Id: I4a7eafed16fd79f377d27afa8151cfab614b464b

diff --git 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
index e267d49ab73e..471eea4c22e6 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp differ
diff --git a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
index b824ddf35d9d..2703670952bd 100644
Binary files 
a/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp and 
b/instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp differ
commit 16499723d69c9ab7cada60aec61e0e2b174b0b75
Author: Katarina Behrens 
Date:   Tue Feb 9 11:09:30 2016 +0100

Branded application icons

sadly, this doesn't replace Windows taskbar icon, that must be living 
somewhere
else. It works on Linux though.

 Conflicts:
icon-themes/galaxy/res/main128.png
icon-themes/galaxy/res/mainapp_16.png
icon-themes/galaxy/res/mainapp_16_8.png
icon-themes/galaxy/res/mainapp_32.png
icon-themes/galaxy/res/mainapp_32_8.png
icon-themes/galaxy/res/mainapp_48_8.png

Change-Id: I028fc68d96f02113622c5e1ec3ed830ac797be0b

diff --git a/icon-themes/galaxy/res/main128.png 
b/icon-themes/galaxy/res/main128.png
index 2779337e7b0a..818b7330c25b 100644
Binary files a/icon-themes/galaxy/res/main128.png and 
b/icon-themes/galaxy/res/main128.png differ
diff --git a/icon-themes/galaxy/res/mainapp_16.png 
b/icon-themes/galaxy/res/mainapp_16.png
old mode 100755
new mode 100644
index 4a96735b6bb6..13945eeadfd4
Binary files a/icon-themes/galaxy/res/mainapp_16.png and 
b/icon-themes/galaxy/res/mainapp_16.png differ
diff --git a/icon-themes/galaxy/res/mainapp_16_8.png 
b/icon-themes/galaxy/res/mainapp_16_8.png
index 94abb952996b..13945eeadfd4 100644
Binary files a/icon-themes/galaxy/res/mainapp_16_8.png and 
b/icon-themes/galaxy/res/mainapp_16_8.png differ
diff --git a/icon-themes/galaxy/res/mainapp_32.png 
b/icon-themes/galaxy/res/mainapp_32.png
index 88e4e1c8f18f..c653935c0c6b 100755
Binary files a/icon-themes/galaxy/res/mainapp_32.png and 
b/icon-themes/galaxy/res/mainapp_32.png differ
diff --git a/icon-themes/galaxy/res/mainapp_32_8.png 
b/icon-themes/galaxy/res/mainapp_32_8.png
index 2c8a21fbcf3b..c653935c0c6b 100644
Binary files a/icon-themes/galaxy/res/mainapp_32_8.png and 
b/icon-themes/galaxy/res/mainapp_32_8.png differ
diff --git a/icon-themes/galaxy/res/mainapp_48_8.png 
b/icon-themes/galaxy/res/mainapp_48_8.png
index cdebedf6a051..562ea23e89c2 100644
Binary files a/icon-themes/galaxy/res/mainapp_48_8.png and 
b/icon-themes/galaxy/res/mainapp_48_8.png differ
commit 39dbed1b4e185b5d631c7f3cec5ca3fc92388abc
Author: Katarina Behrens 
Date:   Tue Feb 9 10:38:29 2016 +0100

Point to CIB helpdesk

it's pretty mean, b/c German translation (which I can't change) says the 
site
is in English, while CIB site is in German only and can't be switched to 
other
lang

 Conflicts:
sfx2/source/appl/appserv.cxx

Change-Id: Ifbbb9e9d2bbee40998c07d1c68b61cd20d77dbc3

diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index d6424c2d06ef..9d2ff11b0b4f 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -498,8 +498,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
 case SID_SEND_FEEDBACK:
 {
 OUString module = SfxHelp::GetCurrentModuleIdentifier();
-OUString 
sURL("http://hub.libreoffice.org/send-feedback/?LOversion=; + 
utl::ConfigManager::getAboutBoxProductVersion() +
-"=" + utl::ConfigManager::getLocale() + "=" 
+ module.copy(module.lastIndexOf('.') + 1 )  );
+OUString sURL("http://libreoffice.cib.de/support;);
 sfx2::openUriExternally(sURL, false);
 break;
 }
commit ee4c28eb96248810f4fd9fb38802471f13633875
Author: Katarina Behrens 
Date:   Tue Feb 9 10:00:30 2016 +0100

Point to CIB website

this idiotic postprocess script

[Libreoffice-commits] core.git: Branch 'feature/cib_contract57b' - 6 commits - sc/inc sc/Library_sc.mk sc/source

2018-02-08 Thread Eike Rathke

 sc/Library_sc.mk  |1 
 sc/inc/document.hxx   |8 +-
 sc/inc/documentlinkmgr.hxx|6 -
 sc/source/core/data/conditio.cxx  |6 +
 sc/source/core/data/documen2.cxx  |2 
 sc/source/core/data/documen8.cxx  |   23 ++
 sc/source/core/data/formulacell.cxx   |7 -
 sc/source/core/inc/webservicelink.hxx |   49 +
 sc/source/core/tool/interpr2.cxx  |8 +-
 sc/source/core/tool/interpr7.cxx  |  102 +---
 sc/source/core/tool/rangenam.cxx  |8 +-
 sc/source/core/tool/webservicelink.cxx|  106 ++
 sc/source/filter/excel/excform.cxx|1 
 sc/source/filter/excel/excform8.cxx   |1 
 sc/source/filter/excel/impop.cxx  |1 
 sc/source/filter/excel/xicontent.cxx  |6 +
 sc/source/filter/excel/xiname.cxx |3 
 sc/source/filter/oox/condformatbuffer.cxx |2 
 sc/source/filter/oox/defnamesbuffer.cxx   |2 
 sc/source/filter/oox/formulabuffer.cxx|4 +
 sc/source/ui/docshell/docsh4.cxx  |4 -
 sc/source/ui/docshell/documentlinkmgr.cxx |   20 -
 sc/source/ui/view/tabvwsh4.cxx|2 
 23 files changed, 326 insertions(+), 46 deletions(-)

New commits:
commit b52a2ef18c5999599af29bd989cac4477e2b736d
Author: Eike Rathke 
Date:   Mon Jan 29 18:19:33 2018 +0100

CheckLinkFormulaNeedingCheck() for named expressions

 This is a combination of 3 commits.

CheckLinkFormulaNeedingCheck() for .ods named expressions

This is specifically necessary for named expressions that are used
in conditional format formulas, for which RPN is generated at a
later stage, not during import.

(cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2)

CheckLinkFormulaNeedingCheck() for .xls named expressions

(cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616)

CheckLinkFormulaNeedingCheck() for .xlsx named expressions

(cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c)

 Conflicts:
sc/source/filter/oox/defnamesbuffer.cxx

e03cb5767c34f8157a492a6d6c3b0700d065052d
217c89822ab477a6c383d170ae739e44efd10fa3

Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc
Reviewed-on: https://gerrit.libreoffice.org/48858
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/rangenam.cxx b/sc/source/core/tool/rangenam.cxx
index 7626e16ae5f6..d147b101de61 100644
--- a/sc/source/core/tool/rangenam.cxx
+++ b/sc/source/core/tool/rangenam.cxx
@@ -64,9 +64,14 @@ ScRangeData::ScRangeData( ScDocument* pDok,
 mnMaxCol(-1)
 {
 if (!rSymbol.isEmpty())
-CompileRangeData( rSymbol, pDoc->IsImportingXML());
+{
 // Let the compiler set an error on unknown names for a subsequent
 // CompileUnresolvedXML().
+const bool bImporting = pDoc->IsImportingXML();
+CompileRangeData( rSymbol, bImporting);
+if (bImporting)
+pDoc->CheckLinkFormulaNeedingCheck( *pCode);
+}
 else
 {
 // #i63513#/#i65690# don't leave pCode as NULL.
@@ -199,6 +204,7 @@ void ScRangeData::CompileUnresolvedXML( 
sc::CompileFormulaContext& rCxt )
 // Don't let the compiler set an error for unknown names on final
 // compile, errors are handled by the interpreter thereafter.
 CompileRangeData( aSymbol, false);
+rCxt.getDoc()->CheckLinkFormulaNeedingCheck( *pCode);
 }
 }
 
diff --git a/sc/source/filter/excel/xiname.cxx 
b/sc/source/filter/excel/xiname.cxx
index d09661503c6b..8decfc00e8e0 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -265,7 +265,10 @@ void XclImpName::InsertName(const ScTokenArray* pArray)
 }
 }
 if (pData)
+{
+GetDoc().CheckLinkFormulaNeedingCheck( *pData->GetCode());
 mpScData = pData;   // cache for later use
+}
 }
 
 XclImpNameManager::XclImpNameManager( const XclImpRoot& rRoot ) :
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index 9de5851e3978..586511d1d25a 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -39,6 +39,7 @@
 #include "tokenarray.hxx"
 #include "tokenuno.hxx"
 #include "compiler.hxx"
+#include "document.hxx"
 
 namespace oox {
 namespace xls {
@@ -339,6 +340,7 @@ std::unique_ptr DefinedName::getScTokens(
 // after, a resulting error must be reset.
 sal_uInt16 nErr = pArray->GetCodeError();
 aCompiler.CompileTokenArray();
+getScDocument().CheckLinkFormulaNeedingCheck( *pArray);
 pArray->DelRPN();
 pArray->SetCodeError(nErr);
 
commit

[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 6 commits - sc/inc sc/Library_sc.mk sc/source

2018-02-08 Thread Eike Rathke

 sc/Library_sc.mk  |1 
 sc/inc/document.hxx   |8 +-
 sc/inc/documentlinkmgr.hxx|6 -
 sc/source/core/data/conditio.cxx  |6 +
 sc/source/core/data/documen2.cxx  |2 
 sc/source/core/data/documen8.cxx  |   23 ++
 sc/source/core/data/formulacell.cxx   |7 -
 sc/source/core/inc/webservicelink.hxx |   49 +
 sc/source/core/tool/interpr2.cxx  |8 +-
 sc/source/core/tool/interpr7.cxx  |  102 +---
 sc/source/core/tool/rangenam.cxx  |8 +-
 sc/source/core/tool/webservicelink.cxx|  106 ++
 sc/source/filter/excel/excform.cxx|1 
 sc/source/filter/excel/excform8.cxx   |1 
 sc/source/filter/excel/impop.cxx  |1 
 sc/source/filter/excel/xicontent.cxx  |6 +
 sc/source/filter/excel/xiname.cxx |3 
 sc/source/filter/oox/condformatbuffer.cxx |2 
 sc/source/filter/oox/defnamesbuffer.cxx   |2 
 sc/source/filter/oox/formulabuffer.cxx|4 +
 sc/source/ui/docshell/docsh4.cxx  |4 -
 sc/source/ui/docshell/documentlinkmgr.cxx |   20 -
 sc/source/ui/view/tabvwsh4.cxx|2 
 23 files changed, 326 insertions(+), 46 deletions(-)

New commits:
commit 74eb6ea470a5889e1d932c6d80d4cbde9ad700e1
Author: Eike Rathke 
Date:   Mon Jan 29 18:19:33 2018 +0100

CheckLinkFormulaNeedingCheck() for named expressions

 This is a combination of 3 commits.

CheckLinkFormulaNeedingCheck() for .ods named expressions

This is specifically necessary for named expressions that are used
in conditional format formulas, for which RPN is generated at a
later stage, not during import.

(cherry picked from commit eae9648e99be53ba441d9d8207aac6f3ce211ef2)

CheckLinkFormulaNeedingCheck() for .xls named expressions

(cherry picked from commit 8512f13c42ae3fbb287a555616fe10ff04295616)

CheckLinkFormulaNeedingCheck() for .xlsx named expressions

(cherry picked from commit a1f933ee2b9e23a505d937035821e9571cf4119c)

 Conflicts:
sc/source/filter/oox/defnamesbuffer.cxx

e03cb5767c34f8157a492a6d6c3b0700d065052d
217c89822ab477a6c383d170ae739e44efd10fa3

Change-Id: I54ab8dc14f81d6b18b0d17f448187d19d8e396fc
Reviewed-on: https://gerrit.libreoffice.org/48858
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/core/tool/rangenam.cxx b/sc/source/core/tool/rangenam.cxx
index 7626e16ae5f6..d147b101de61 100644
--- a/sc/source/core/tool/rangenam.cxx
+++ b/sc/source/core/tool/rangenam.cxx
@@ -64,9 +64,14 @@ ScRangeData::ScRangeData( ScDocument* pDok,
 mnMaxCol(-1)
 {
 if (!rSymbol.isEmpty())
-CompileRangeData( rSymbol, pDoc->IsImportingXML());
+{
 // Let the compiler set an error on unknown names for a subsequent
 // CompileUnresolvedXML().
+const bool bImporting = pDoc->IsImportingXML();
+CompileRangeData( rSymbol, bImporting);
+if (bImporting)
+pDoc->CheckLinkFormulaNeedingCheck( *pCode);
+}
 else
 {
 // #i63513#/#i65690# don't leave pCode as NULL.
@@ -199,6 +204,7 @@ void ScRangeData::CompileUnresolvedXML( 
sc::CompileFormulaContext& rCxt )
 // Don't let the compiler set an error for unknown names on final
 // compile, errors are handled by the interpreter thereafter.
 CompileRangeData( aSymbol, false);
+rCxt.getDoc()->CheckLinkFormulaNeedingCheck( *pCode);
 }
 }
 
diff --git a/sc/source/filter/excel/xiname.cxx 
b/sc/source/filter/excel/xiname.cxx
index d09661503c6b..8decfc00e8e0 100644
--- a/sc/source/filter/excel/xiname.cxx
+++ b/sc/source/filter/excel/xiname.cxx
@@ -265,7 +265,10 @@ void XclImpName::InsertName(const ScTokenArray* pArray)
 }
 }
 if (pData)
+{
+GetDoc().CheckLinkFormulaNeedingCheck( *pData->GetCode());
 mpScData = pData;   // cache for later use
+}
 }
 
 XclImpNameManager::XclImpNameManager( const XclImpRoot& rRoot ) :
diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index 9de5851e3978..586511d1d25a 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -39,6 +39,7 @@
 #include "tokenarray.hxx"
 #include "tokenuno.hxx"
 #include "compiler.hxx"
+#include "document.hxx"
 
 namespace oox {
 namespace xls {
@@ -339,6 +340,7 @@ std::unique_ptr DefinedName::getScTokens(
 // after, a resulting error must be reset.
 sal_uInt16 nErr = pArray->GetCodeError();
 aCompiler.CompileTokenArray();
+getScDocument().CheckLinkFormulaNeedingCheck( *pArray);
 pArray->DelRPN();
 pArray->SetCodeError(nErr);
 
commit

[Libreoffice-bugs] [Bug 81484] Draw pdf import: bold font shown as "outline", if Chinese (CJK ?) font is applied

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81484

--- Comment #17 from Franklin Weng  ---
Created attachment 139712
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139712=edit
Sample pdf file with the same problem

1. The problem still exists in 6.0.0.2.

版本：6.0.0.2
組建 ID：06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU 執行緒：4; OS：Linux 4.11; UI 算繪：預設; VCL: kde4; 
語言地區：zh-TW (zh_TW.UTF-8); Calc: group

2. The problem exists in 4.0.0.1, which is the earliest version I can test.
版本 4.0.0.1 (組建 ID：527dba6f6e0cfbbc71bd6e7b88a52699bb48799)

3. If I open it with Draw, save as ODG, and use zip to extract this ODG file
into a folder, then use a text editor to modify *all* the 

style:text-outline="true"

to

style:text-outline="false"

and zip back to become odg file, the problem would be resolved.

It should be misjudged some fonts as text-outline=true.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: stoc/source

2018-02-08 Thread Tor Lillqvist

 stoc/source/invocation/invocation.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7d56128654457bfc859217c23a957d1712fd6e1c
Author: Tor Lillqvist 
Date:   Thu Feb 8 21:36:07 2018 +0200

Fix exception message: add colon between function name and the word 
"expected"

Change-Id: I80eadaa097afdbe4394aceca9f40b9753792f30b

diff --git a/stoc/source/invocation/invocation.cxx 
b/stoc/source/invocation/invocation.cxx
index f564425c4202..82dfbac5a417 100644
--- a/stoc/source/invocation/invocation.cxx
+++ b/stoc/source/invocation/invocation.cxx
@@ -590,7 +590,7 @@ Any Invocation_Impl::invoke( const OUString& FunctionName, 
const Sequence&
 {
 throw IllegalArgumentException(
 "incorrect number of parameters passed invoking function " + 
FunctionName +
-"expected " + OUString::number(nFParamsLen) + ", got " + 
OUString::number(InParams.getLength()),
+": expected " + OUString::number(nFParamsLen) + ", got " + 
OUString::number(InParams.getLength()),
 static_cast(this), sal_Int16(1) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115562] Page anchored rotated image has wrong movement for arrow keys

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115562

V Stuart Foote  changed:

   What|Removed |Added

Summary|Rotated image has wrong |Page anchored rotated image
   |movement for arrow keys |has wrong movement for
   ||arrow keys

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115562] Rotated image has wrong movement for arrow keys

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115562

--- Comment #4 from V Stuart Foote  ---
(In reply to Regina Henschel from comment #3)

I am sorry I misread things. But now I follow. It is the _movement_ of the Page
anchored image, not its rotation that is wonky.

But yes, when anchored to Page (not with defaults anchored to Paragraph)
movement of the "rotated" image does not track with the
+[UP,DONW,LEFT,RIGHT] or +[UP,DONW,LEFT,RIGHT] or
[UP,DONW,LEFT,RIGHT] movment commands.

Anchored to Paragraph movement seems correct.

=-testing-=
Windows 10 Ent 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 609888f3c8d6c0fe72c41ac26de431a12ad3fdd0
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-08_02:03:29
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny

 vcl/inc/sft.hxx   |   16 
 vcl/source/fontsubset/sft.cxx |   79 --
 2 files changed, 95 deletions(-)

New commits:
commit cf3c1bd0b91fe68682a7a3c3cb34066e1fb8d17c
Author: Khaled Hosny 
Date:   Thu Feb 8 14:31:34 2018 +0200

Removed unused code for reading kern table

Change-Id: I66b17dbee0a04e61b99e23933a7fed4be30f3a93
Reviewed-on: https://gerrit.libreoffice.org/49426
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 
(cherry picked from commit e3caecb5a33288dd46a80b2ffcc47a2288305052)
Reviewed-on: https://gerrit.libreoffice.org/49451
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index 3dc6cb77b21f..2577166cc3f1 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -102,13 +102,6 @@ namespace vcl
 FWIDTH_ULTRA_EXPANDED = 9   /**< 200% of normal
 */
 };
 
-/** Type of the 'kern' table, stored in TrueTypeFont::kerntype */
-enum KernType {
-KT_NONE = 0,/**< no kern table 
 */
-KT_APPLE_NEW= 1,/**< new Apple kern table  
 */
-KT_MICROSOFT= 2 /**< Microsoft table   
 */
-};
-
 /** Composite glyph flags definition */
 enum CompositeFlags {
 ARG_1_AND_2_ARE_WORDS = 1,
@@ -190,12 +183,6 @@ namespace vcl
 #define TYPEFLAG_COPYRIGHT_MASK 0x00E
 #define TYPEFLAG_PS_OPENTYPE0x001
 
-/** Structure used by KernGlyphs()  */
-typedef struct {
-int x;/**< positive: right, negative: left 
   */
-int y;/**< positive: up, negative: down
   */
-} KernData;
-
 /** ControlPoint structure used by GetTTGlyphPoints() */
 typedef struct {
 sal_uInt32 flags; /**<   e000  
*/
@@ -486,8 +473,6 @@ namespace vcl
 sal_uInt32 (*mapper)(const sal_uInt8 *, sal_uInt32, sal_uInt32); /* 
character to glyphID translation function  */
 const sal_uInt8   **tables;/* array of 
pointers to raw subtables in SFNT file*/
 sal_uInt32  *tlens;/* array of table 
lengths */
-sal_uInt32  nkern; /* number of kern 
subtables   */
-const sal_uInt8** kerntables;  /* array of 
pointers to kern subtables*/
 };
 
 /* indexes into TrueTypeFont::tables[] and TrueTypeFont::tlens[] */
@@ -503,7 +488,6 @@ namespace vcl
 #define O_vmtx 9 /* 'vmtx' */
 #define O_OS2  10/* 'OS/2' */
 #define O_post 11/* 'post' */
-#define O_kern 12/* 'kern' */
 #define O_cvt  13/* 'cvt_' - only used in TT->TT generation */
 #define O_prep 14/* 'prep' - only used in TT->TT generation */
 #define O_fpgm 15/* 'fpgm' - only used in TT->TT generation */
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 7c35d3207e0d..1bf9b9003de5 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -119,7 +119,6 @@ static const sal_uInt32 T_otto = 0x4f54544f;/* 
'OTTO' */
 #define T_vmtx 0x766D7478
 #define T_OS2  0x4F532F32
 #define T_post 0x706F7374
-#define T_kern 0x6B65726E
 #define T_cvt  0x63767420
 #define T_prep 0x70726570
 #define T_fpgm 0x6670676D
@@ -1339,81 +1338,6 @@ static void FindCmap(TrueTypeFont *ttf)
 }
 }
 
-static void GetKern(TrueTypeFont *ttf)
-{
-const sal_uInt8* table = getTable(ttf, O_kern);
-int nTableSize = getTableSize(ttf, O_kern);
-const sal_uInt8 *ptr;
-
-if( !table )
-goto badtable;
-
-if (nTableSize >= 4 && GetUInt16(table, 0) == 0) { /* Traditional 
Microsoft style table with sal_uInt16 version and nTables fields */
-ttf->nkern = GetUInt16(table, 2);
-ptr = table + 4;
-
-const sal_uInt32 remaining_table_size = nTableSize-4;
-const sal_uInt32 nMinRecordSize = 2;
-const sal_uInt32 nMaxRecords = remaining_table_size / nMinRecordSize;
-if (ttf->nkern > nMaxRecords)
-{
-SAL_WARN("vcl.fonts", "Parsing error in " << 
OUString::createFromAscii(ttf->fname) <<
- ": " << nMaxRecords << " max possible entries, but " <<
- ttf->nkern << " claimed, truncating");
-ttf->nkern = nMaxRecords;
-}
-
-ttf->kerntables = static_cast(calloc(ttf->nkern, 
sizeof(sal_uInt8 *)));
-assert(ttf->kerntables != nullptr);
-
-for( unsigned i = 0; i < ttf->nkern; ++i) {
-ttf->kerntables[i] =

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny

 vcl/inc/sft.hxx   |   18 
 vcl/source/fontsubset/sft.cxx |   85 --
 2 files changed, 103 deletions(-)

New commits:
commit f0416352ba0290087ad20f4e3a84c34fe7212a21
Author: Khaled Hosny 
Date:   Thu Feb 8 14:31:34 2018 +0200

Removed unused code for reading kern table

Reviewed-on: https://gerrit.libreoffice.org/49426
Tested-by: Jenkins 
Reviewed-by: Khaled Hosny 
(cherry picked from commit e3caecb5a33288dd46a80b2ffcc47a2288305052)

Change-Id: I66b17dbee0a04e61b99e23933a7fed4be30f3a93
Reviewed-on: https://gerrit.libreoffice.org/49452
Reviewed-by: Khaled Hosny 
Tested-by: Jenkins 

diff --git a/vcl/inc/sft.hxx b/vcl/inc/sft.hxx
index 17efc970fa9b..bca8054b6875 100644
--- a/vcl/inc/sft.hxx
+++ b/vcl/inc/sft.hxx
@@ -102,13 +102,6 @@ namespace vcl
 FWIDTH_ULTRA_EXPANDED = 9   /**< 200% of normal
 */
 };
 
-/** Type of the 'kern' table, stored in TrueTypeFont::kerntype */
-enum KernType {
-KT_NONE = 0,/**< no kern table 
 */
-KT_APPLE_NEW= 1,/**< new Apple kern table  
 */
-KT_MICROSOFT= 2 /**< Microsoft table   
 */
-};
-
 /** Composite glyph flags definition */
 enum CompositeFlags {
 ARG_1_AND_2_ARE_WORDS = 1,
@@ -197,12 +190,6 @@ namespace vcl
 #define TYPEFLAG_COPYRIGHT_MASK 0x00E
 #define TYPEFLAG_PS_OPENTYPE0x001
 
-/** Structure used by KernGlyphs()  */
-typedef struct {
-int x;/**< positive: right, negative: left 
   */
-int y;/**< positive: up, negative: down
   */
-} KernData;
-
 /** ControlPoint structure used by GetTTGlyphPoints() */
 typedef struct {
 sal_uInt32 flags; /**<   e000  
*/
@@ -495,10 +482,6 @@ namespace vcl
 sal_uInt32 (*mapper)(const sal_uInt8 *, sal_uInt32, sal_uInt32); /* 
character to glyphID translation function  */
 const sal_uInt8   **tables;/* array of 
pointers to raw subtables in SFNT file*/
 sal_uInt32  *tlens;/* array of table 
lengths */
-int kerntype;  /* Defined in the 
KernType enum   */
-sal_uInt32  nkern; /* number of kern 
subtables   */
-const sal_uInt8** kerntables;  /* array of 
pointers to kern subtables*/
-void*pGSubstitution;   /* info provided by 
GSUB for UseGSUB()*/
 };
 
 /* indexes into TrueTypeFont::tables[] and TrueTypeFont::tlens[] */
@@ -514,7 +497,6 @@ namespace vcl
 #define O_vmtx 9 /* 'vmtx' */
 #define O_OS2  10/* 'OS/2' */
 #define O_post 11/* 'post' */
-#define O_kern 12/* 'kern' */
 #define O_cvt  13/* 'cvt_' - only used in TT->TT generation */
 #define O_prep 14/* 'prep' - only used in TT->TT generation */
 #define O_fpgm 15/* 'fpgm' - only used in TT->TT generation */
diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index 966393fa4fe3..f968c9c092d9 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -123,7 +123,6 @@ static const sal_uInt32 T_otto = 0x4f54544f;/* 
'OTTO' */
 #define T_vmtx 0x766D7478
 #define T_OS2  0x4F532F32
 #define T_post 0x706F7374
-#define T_kern 0x6B65726E
 #define T_cvt  0x63767420
 #define T_prep 0x70726570
 #define T_fpgm 0x6670676D
@@ -1345,86 +1344,6 @@ static void FindCmap(TrueTypeFont *ttf)
 }
 }
 
-static void GetKern(TrueTypeFont *ttf)
-{
-const sal_uInt8* table = getTable(ttf, O_kern);
-int nTableSize = getTableSize(ttf, O_kern);
-const sal_uInt8 *ptr;
-
-if( !table )
-goto badtable;
-
-if (nTableSize >= 4 && GetUInt16(table, 0) == 0) { /* Traditional 
Microsoft style table with sal_uInt16 version and nTables fields */
-ttf->nkern = GetUInt16(table, 2);
-ttf->kerntype = KT_MICROSOFT;
-ptr = table + 4;
-
-const sal_uInt32 remaining_table_size = nTableSize-4;
-const sal_uInt32 nMinRecordSize = 2;
-const sal_uInt32 nMaxRecords = remaining_table_size / nMinRecordSize;
-if (ttf->nkern > nMaxRecords)
-{
-SAL_WARN("vcl.fonts", "Parsing error in " << 
OUString::createFromAscii(ttf->fname) <<
- ": " << nMaxRecords << " max possible entries, but " <<
-

[Libreoffice-bugs] [Bug 114508] Confusing dialog about discarding recovery data can lead to data loss

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114508

--- Comment #17 from mattreecebent...@gmail.com ---
Also present for Writer. Individual files should not be selectable if the only
option is to recover all. That's just plain ridiculous...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basic/source vbahelper/source

2018-02-08 Thread Tor Lillqvist

 basic/source/classes/sbxmod.cxx   |5 -
 vbahelper/source/vbahelper/vbaapplicationbase.cxx |8 ++--
 vbahelper/source/vbahelper/vbahelper.cxx  |8 +++-
 3 files changed, 17 insertions(+), 4 deletions(-)

New commits:
commit 73256b918119e378c762f6a3d79d04f311a075cc
Author: Tor Lillqvist 
Date:   Thu Feb 8 19:31:20 2018 +0200

Decrease fragility in odd use cases with no current document

Change-Id: I9966166561d4c6e577f3f7e8e04572f97a0b295e
Reviewed-on: https://gerrit.libreoffice.org/49450
Tested-by: Jenkins 
Reviewed-by: Tor Lillqvist 

diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index f0ee0f7f7f56..97fe73dbface 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -409,7 +409,10 @@ uno::Reference< vba::XVBACompatibility > 
getVBACompatibility( const uno::Referen
 
 bool getDefaultVBAMode( StarBASIC* pb )
 {
-uno::Reference< vba::XVBACompatibility > xVBACompat = getVBACompatibility( 
getDocumentModel( pb ) );
+uno::Reference< frame::XModel > xModel( getDocumentModel( pb ) );
+if (!xModel.is())
+return false;
+uno::Reference< vba::XVBACompatibility > xVBACompat = getVBACompatibility( 
xModel );
 return xVBACompat.is() && xVBACompat->getVBACompatibilityMode();
 }
 
diff --git a/vbahelper/source/vbahelper/vbaapplicationbase.cxx 
b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
index 753a389e5bb6..25e91647694b 100644
--- a/vbahelper/source/vbahelper/vbaapplicationbase.cxx
+++ b/vbahelper/source/vbahelper/vbaapplicationbase.cxx
@@ -184,7 +184,9 @@ VbaApplicationBase::~VbaApplicationBase()
 sal_Bool SAL_CALL
 VbaApplicationBase::getScreenUpdating()
 {
-uno::Reference< frame::XModel > xModel( getCurrentDocument(), 
uno::UNO_QUERY_THROW );
+uno::Reference< frame::XModel > xModel = getCurrentDocument();
+if (!xModel.is())
+return false;
 return !xModel->hasControllersLocked();
 }
 
@@ -238,7 +240,9 @@ VbaApplicationBase::setDisplayStatusBar(sal_Bool 
bDisplayStatusBar)
 
 sal_Bool SAL_CALL VbaApplicationBase::getInteractive()
 {
-uno::Reference< frame::XModel > xModel( getCurrentDocument(), 
uno::UNO_QUERY_THROW );
+uno::Reference< frame::XModel > xModel = getCurrentDocument();
+if (!xModel.is())
+return false;
 uno::Reference< frame::XFrame > xFrame( 
xModel->getCurrentController()->getFrame(), uno::UNO_QUERY_THROW );
 uno::Reference< awt::XWindow2 > xWindow( xFrame->getContainerWindow(), 
uno::UNO_QUERY_THROW );
 
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx 
b/vbahelper/source/vbahelper/vbahelper.cxx
index 2471add85ce5..b7432c59935c 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -277,7 +277,13 @@ getCurrentWordDoc( const uno::Reference< 
uno::XComponentContext >& xContext )
 }
 catch (const uno::Exception&)
 {
-xModel = getThisWordDoc( xContext );
+try
+{
+xModel = getThisWordDoc( xContext );
+}
+catch (const uno::Exception&)
+{
+}
 }
 return xModel;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 114508] Confusing dialog about discarding recovery data can lead to data loss

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114508

mattreecebent...@gmail.com changed:

   What|Removed |Added

 CC||mattreecebent...@gmail.com

--- Comment #16 from mattreecebent...@gmail.com ---
*** Bug 115564 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115564] Recovery dialog confusing

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115564

mattreecebent...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from mattreecebent...@gmail.com ---


*** This bug has been marked as a duplicate of bug 114508 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115564] New: Recovery dialog confusing

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115564

Bug ID: 115564
   Summary: Recovery dialog confusing
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mattreecebent...@gmail.com

5.3.7 crashed so tried opening document in 6.
Tried to discard the temporary data for one file, because the files are
selectable for some reason in the dialog. Unfortunately this discarded the
temporary recovery data for all files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107403] Icons wrongly scaled in hidpi screen for the borders toolbar control

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107403

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com
Summary|Icons wrongly scaled in |Icons wrongly scaled in
   |hidpi sceen for dropdown|hidpi screen for the
   |boxes   |borders toolbar control

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107403] Icons wrongly scaled in hidpi sceen for dropdown boxes

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107403

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||sigurd...@gmail.com

--- Comment #4 from Maxim Monastirsky  ---
*** Bug 114535 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114535] tool bar BORDERS ICON broke

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114535

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #16 from Maxim Monastirsky  ---
Looks like the same problem as in Bug 107403.

*** This bug has been marked as a duplicate of bug 107403 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107403] Icons wrongly scaled in hidpi sceen for dropdown boxes

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107403

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||hvba...@gmail.com

--- Comment #3 from Maxim Monastirsky  ---
*** Bug 115563 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115563] Borders toolbar menu items do not display properly on hidpi screens

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115563

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Maxim Monastirsky  ---
Looks like the same problem as in Bug 107403.

*** This bug has been marked as a duplicate of bug 107403 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115562] Rotated image has wrong movement for arrow keys

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115562

--- Comment #3 from Regina Henschel  ---
(In reply to V Stuart Foote from comment #2)
> Where in the GUI? Which Arrow keys?

The UP, RIGHT, DOWN, LEFT keys on the keyboard. If a shape is selected, they
allow movement of the shape. That works with unrotated images the same, but not
for rotated images.

> 
> Aren't +[UP,DONW,LEFT,RIGHT] controls to rotate Draw objects?

No. It is fine move by pixel.

 And, are
> they still working at 6.0--they seem to now be fine positioning controls
> (even in Rotation mode).

As it always has been.

 With +[UP,DOWN,LEFT,RIGHT] acting as coarse
> movement controls.

That has not changed too for shapes and unrotated images, but does not work for
rotated images.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108827
Bug 108827 depends on bug 58874, which changed state.

Bug 58874 Summary: OFFSET function in array context compatibility with Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=58874

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 81643] Borders are drawn as rectangles and so they are not joined well at the corners

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=81643

Xisco Faulí  changed:

   What|Removed |Added

 CC||armin.le.gr...@me.com

--- Comment #22 from Xisco Faulí  ---
Hi Armin,
I guess this can be close now, isn't it ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115563] Borders toolbar menu items do not display properly on hidpi screens

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115563

--- Comment #1 from hvba...@gmail.com ---
Created attachment 139711
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139711=edit
Screenshot of the borders menu on a hidpi screen

Attachment showing the defective border menu on a hidpi screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2018-02-08 Thread Eike Rathke

 sc/source/core/inc/jumpmatrix.hxx  |4 +++-
 sc/source/core/tool/interpr1.cxx   |   16 +++-
 sc/source/core/tool/interpr4.cxx   |2 +-
 sc/source/core/tool/jumpmatrix.cxx |3 ++-
 4 files changed, 17 insertions(+), 8 deletions(-)

New commits:
commit e0a94ded5d1635fa2a2d9e222bfcfa0a2289a01f
Author: Eike Rathke 
Date:   Thu Feb 8 22:48:56 2018 +0100

Resolves: tdf#115493 use matrix as result of jump command, tdf#58874 related


{=SUM(IF(EXACT(OFFSET(A7,0,0):OFFSET(A7,2,0),A$1),OFFSET(A7,0,1):OFFSET(A7,2,1),0))}
shall be the same as
{=SUM(IF(EXACT(A7:A9,A$1),B7:B9,0))}

Change-Id: Id503ef41140d1e9c4aeabbec08d1199dd6dd8593

diff --git a/sc/source/core/inc/jumpmatrix.hxx 
b/sc/source/core/inc/jumpmatrix.hxx
index cbc1a1d0671c..084f5a91f4bb 100644
--- a/sc/source/core/inc/jumpmatrix.hxx
+++ b/sc/source/core/inc/jumpmatrix.hxx
@@ -67,6 +67,7 @@ class ScJumpMatrix
 SCSIZE  nCurRow;
 SCSIZE  nResMatCols;
 SCSIZE  nResMatRows;
+OpCode  meOp;
 boolbStarted;
 
 // Buffer result ranges to be able to set a range of identically typed
@@ -96,7 +97,7 @@ class ScJumpMatrix
 ScJumpMatrix& operator=( const ScJumpMatrix& ) = delete;
 
 public:
-ScJumpMatrix( SCSIZE nColsP, SCSIZE nRowsP );
+ScJumpMatrix( OpCode eOp, SCSIZE nColsP, SCSIZE nRowsP );
 ~ScJumpMatrix();
 void GetDimensions( SCSIZE& rCols, SCSIZE& rRows ) const;
 void SetJump( SCSIZE nCol, SCSIZE nRow, double fBool, short nStart, short 
nNext );
@@ -111,6 +112,7 @@ public:
 void GetResMatDimensions( SCSIZE& rCols, SCSIZE& rRows );
 void SetNewResMat( SCSIZE nNewCols, SCSIZE nNewRows );
 ScRefList& GetRefList();
+OpCode GetOpCode() const { return meOp; }
 
 void PutResultDouble( double fVal, SCSIZE nC, SCSIZE nR );
 void PutResultString( const svl::SharedString& rStr, SCSIZE nC, SCSIZE nR 
);
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 70f2ae8c1805..89823f7eb352 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -110,7 +110,8 @@ void ScInterpreter::ScIfJump()
 xNew = (*aMapIter).second;
 else
 {
-std::shared_ptr pJumpMat( 
std::make_shared( nCols, nRows ) );
+std::shared_ptr pJumpMat( 
std::make_shared(
+pCur->GetOpCode(), nCols, nRows));
 for ( SCSIZE nC=0; nC < nCols; ++nC )
 {
 for ( SCSIZE nR=0; nR < nRows; ++nR )
@@ -339,7 +340,8 @@ void ScInterpreter::ScIfError( bool bNAonly )
 else
 {
 const ScMatrix* pMatPtr = pMat.get();
-std::shared_ptr pJumpMat( 
std::make_shared( nCols, nRows ) );
+std::shared_ptr pJumpMat( 
std::make_shared(
+pCur->GetOpCode(), nCols, nRows));
 // Init all jumps to no error to save single calls. Error
 // is the exceptional condition.
 const double fFlagResult = CreateDoubleError( 
FormulaError::JumpMatHasResult);
@@ -430,7 +432,8 @@ void ScInterpreter::ScChooseJump()
 xNew = (*aMapIter).second;
 else
 {
-std::shared_ptr pJumpMat( 
std::make_shared( nCols, nRows ) );
+std::shared_ptr pJumpMat( 
std::make_shared(
+pCur->GetOpCode(), nCols, nRows));
 for ( SCSIZE nC=0; nC < nCols; ++nC )
 {
 for ( SCSIZE nR=0; nR < nRows; ++nR )
@@ -799,8 +802,11 @@ bool ScInterpreter::JumpMatrix( short nStackLevel )
 {   // We're done with it, throw away jump matrix, keep result.
 // For an intermediate result of Reference use the array of references,
 // else (also for a final result of Reference) use the matrix.
-formula::ParamClass eReturnType = 
ScParameterClassification::GetParameterType( pCur, SAL_MAX_UINT16);
-if (eReturnType == ParamClass::Reference && aCode.PeekNextOperator())
+// Treat the result of a jump command as final and use the matrix (see
+// tdf#115493 for why).
+if (!FormulaCompiler::IsOpCodeJumpCommand( pJumpMatrix->GetOpCode()) &&
+ScParameterClassification::GetParameterType( pCur, 
SAL_MAX_UINT16) == ParamClass::Reference &&
+aCode.PeekNextOperator())
 {
 FormulaTokenRef xRef = new ScRefListToken(true);
 *(xRef->GetRefList()) = pJumpMatrix->GetRefList();
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index f08c09ce69eb..942911d29ff2 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1574,7 +1574,7 @@ bool

[Libreoffice-commits] core.git: officecfg/registry

2018-02-08 Thread heiko tietze

 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |6 
+++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7f8936e7db018664d6074caa9bd6a82972cb4923
Author: heiko tietze 
Date:   Thu Feb 8 10:28:45 2018 +0100

tdf#115470 - Name of the "Cycle Case" is too long

Long text moved into a tooltip

Change-Id: I981970c6e1fa16397264ea852fcd9bc480a41980
Reviewed-on: https://gerrit.libreoffice.org/49413
Tested-by: Jenkins 
Reviewed-by: Maxim Monastirsky 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index 09e73efd9241..b6bb6b9108eb 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -2638,11 +2638,11 @@
   
   
 
-  Cycle Case (Title Case, UPPERCASE, 
lowercase)
-
-
   Cycle Case
 
+
+  Cycle Case (Title Case, UPPERCASE, 
lowercase)
+
   
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 101842] LO freezes while unsuccessfully searching for Firefox Themes

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101842

Kevin Suo  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115563] New: Borders toolbar menu items do not display properly on hidpi screens

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115563

Bug ID: 115563
   Summary: Borders toolbar menu items do not display properly on
hidpi screens
   Product: LibreOffice
   Version: 5.3 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hvba...@gmail.com

Description:
When using libreoffice on a hidpi screen (e.g. 3840x2160) with scaling set to
2x, the items in the borders toolbar menu are all clipped. This means it is not
possible to differentiate between e.g. selecting top or bottom borders. This
problem occurs for any component that uses the borders toolbar, such as cells
in calc or tables in writer.

Steps to Reproduce:
1.Start libreoffice calc or writer on a hidpi display with scaling set to 2x
2.Create a table in writer and go to a cell, or select a cell in calc
3.Click on the 'borders' button in the toolbar

Actual Results:  
The popup with the different border configurations shows the exact same image
(a blank square) for all outer-border options. Only the bottom row with inner
border options provides some information.

Expected Results:
Each square in the borders popup should show a different border selection
option.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
The scaling issue is apparent regardless of the icon theme that is selected.


User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like
Gecko) Chrome/64.0.3282.140 Safari/537.36

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

2018-02-08 Thread Maxim Monastirsky

 vcl/unx/gtk/gtksalframe.cxx |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 9c8f2511e3b07427f1d13ac198adf46f073c9685
Author: Maxim Monastirsky 
Date:   Thu Feb 8 23:37:18 2018 +0200

Sync the fix with Muffin upstream changes

See:

https://github.com/linuxmint/muffin/commit/f3fce7898ba8aa82c4c82a50af2bb44c0ff79ddf

Change-Id: Ic569bb7139fcb12e9549fa136c269f1a7ed10cb3
Reviewed-on: https://gerrit.libreoffice.org/49453
Reviewed-by: Maxim Monastirsky 
Tested-by: Maxim Monastirsky 

diff --git a/vcl/unx/gtk/gtksalframe.cxx b/vcl/unx/gtk/gtksalframe.cxx
index 81e8eecb9a2d..c376bb03eb18 100644
--- a/vcl/unx/gtk/gtksalframe.cxx
+++ b/vcl/unx/gtk/gtksalframe.cxx
@@ -1051,8 +1051,7 @@ void GtkSalFrame::InitCommon()
 
 static void lcl_set_accept_focus( GtkWindow* pWindow )
 {
-if 
(GetGtkSalData()->GetGtkDisplay()->getWMAdaptor()->getWindowManagerName().startsWith("Metacity")
 ||
-
GetGtkSalData()->GetGtkDisplay()->getWMAdaptor()->getWindowManagerName().endsWith("Muffin)")
 )
+if 
(GetGtkSalData()->GetGtkDisplay()->getWMAdaptor()->getWindowManagerName().startsWith("Metacity"))
 {
/*  Metacity considers a toolbar type window as should not
 *  have focus on mapping, yet it believes it should unfocus
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115430] Crash in: BindDispatch_Impl::statusChanged(com::sun::star:: frame::FeatureStateEvent const&)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115430

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

--- Comment #8 from Maxim Monastirsky  ---
Backport to 6-0 in gerrit.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115430] Crash in: BindDispatch_Impl::statusChanged(com::sun::star:: frame::FeatureStateEvent const&)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115430

--- Comment #7 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d09bdaaa660c40df241e6e1c0b8a3e905db85420

tdf#115430 BindDispatch_Impl needs a disposal method

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115430] Crash in: BindDispatch_Impl::statusChanged(com::sun::star:: frame::FeatureStateEvent const&)

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115430

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2018-02-08 Thread Maxim Monastirsky

 sfx2/source/control/bindings.cxx |1 +
 sfx2/source/control/statcach.cxx |7 ++-
 sfx2/source/inc/statcach.hxx |2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit d09bdaaa660c40df241e6e1c0b8a3e905db85420
Author: Maxim Monastirsky 
Date:   Thu Feb 8 13:04:27 2018 +0200

tdf#115430 BindDispatch_Impl needs a disposal method

The dtor will never be called otherwise, because the
dispatcher is holding a reference to us, so
removeStatusListener is needed first.

Regression of a5dbe5a8a9e98f2d79f2c535182fc557b561ed0f
("use rtl::Reference in svl,sfx2")

Change-Id: I52da6152f0ddb0030d7354f7201e969d5a1f11cf
Reviewed-on: https://gerrit.libreoffice.org/49423
Reviewed-by: Noel Grandin 
Tested-by: Jenkins 
Reviewed-by: Maxim Monastirsky 

diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index 87197d045ea5..ea900d2f6145 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -1604,6 +1604,7 @@ SfxItemState SfxBindings::QueryState( sal_uInt16 nSlot, 
std::unique_ptrremoveStatusListener( xBind.get(), aURL );
+xBind->Release();
 xBind.clear();
 if ( bDeleteCache )
 DELETEZ( pCache );
diff --git a/sfx2/source/control/statcach.cxx b/sfx2/source/control/statcach.cxx
index 1ec54f2fd1c3..0d6d5b6b08fa 100644
--- a/sfx2/source/control/statcach.cxx
+++ b/sfx2/source/control/statcach.cxx
@@ -145,13 +145,14 @@ void SAL_CALL  BindDispatch_Impl::statusChanged( const 
css::frame::FeatureStateE
 }
 }
 
-BindDispatch_Impl::~BindDispatch_Impl()
+void BindDispatch_Impl::Release()
 {
 if ( xDisp.is() )
 {
 xDisp->removeStatusListener( 
static_cast(this), aURL );
 xDisp.clear();
 }
+pCache = nullptr;
 }
 
 
@@ -197,6 +198,8 @@ SfxStateCache::~SfxStateCache()
 DBG_ASSERT( pController == nullptr && pInternalController == nullptr, 
"there are still Controllers registered" );
 if ( !IsInvalidItem(pLastItem) )
 delete pLastItem;
+if ( mxDispatch.is() )
+mxDispatch->Release();
 }
 
 
@@ -208,6 +211,8 @@ void SfxStateCache::Invalidate( bool bWithMsg )
 {
 bSlotDirty = true;
 aSlotServ.SetSlot( nullptr );
+if ( mxDispatch.is() )
+mxDispatch->Release();
 mxDispatch.clear();
 }
 }
diff --git a/sfx2/source/inc/statcach.hxx b/sfx2/source/inc/statcach.hxx
index ef09b5dd51c4..58ddc1766889 100644
--- a/sfx2/source/inc/statcach.hxx
+++ b/sfx2/source/inc/statcach.hxx
@@ -46,13 +46,13 @@ public:
 const css::uno::Reference< 
css::frame::XDispatch > & rDisp,
 const css::util::URL& rURL,
 SfxStateCache* pStateCache, const SfxSlot* 
pSlot );
-~BindDispatch_Impl() override;
 
 virtual void SAL_CALL   statusChanged( const 
css::frame::FeatureStateEvent& Event ) override;
 virtual void SAL_CALL   disposing( const css::lang::EventObject& Source ) 
override;
 
 const css::frame::FeatureStateEvent& GetStatus() const { return aStatus;}
 sal_Int16   Dispatch( const css::uno::Sequence < 
css::beans::PropertyValue >& aProps, bool bForceSynchron );
+voidRelease();
 };
 
 class SfxStateCache
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 107996] FORMATTING: Watermark feature in page style dialog

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107996

--- Comment #14 from Cor Nouws  ---
(In reply to Thomas Lendo from comment #13)

> Must the watermark feature be changed to only have an effect on the
> dedicated page style if it's moved to the page dialog?

Hi Thomas,

Since we only have a dialog Page Style, the settings there can only effect the
style in question.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87916] FORMATTING: Shape text options not enabled

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87916

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #21 from Cor Nouws  ---
Hi Mike,

(In reply to Mike Sapsard from comment #20)
> Cor, I think we are doing the same things.

 :)

> I expect both Write and Draw to work in the same way, especially as they
> have very similar dialogs.

However, Draw and Writer still differ in the drawing layer.
I know devs are working on this, but for the moment, what you see, is is what
it is.
Closing again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115480] SVG export good in LO Draw 5.3.1.2 distorted in LO 5.4.4.2

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115480

--- Comment #5 from daviding  ---
Okay, I'm now unable to reproduce the error under LO 6.

Version: 6.0.0.3
Build ID: 6.0.0-1
CPU threads: 2; OS: Linux 4.9; UI render: default; VCL: gtk3; 
Locale: en-CA (en_CA.UTF-8); Calc: group

That's frustrating!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115545] Writer crashes when opening the image properties dialog

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115545

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |WORKSFORME

--- Comment #6 from V Stuart Foote  ---
I also saw this crash on Windows 10 Ent 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: b1069ea6f25daa268eb4358d5ea20094b46ef347
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-06_23:49:25
Locale: en-US (en_US); Calc: group

But seems fine with the following build
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 609888f3c8d6c0fe72c41ac26de431a12ad3fdd0
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-02-08_02:03:29
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115562] Rotated image has wrong movement for arrow keys

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115562

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
Where in the GUI? Which Arrow keys?

Rotation on the Sidebar Properties Deck -> Position and Size content panel's
drop list box moves up or down the list rotating image to match.  The 360 deg
rotation medallion there controls the image.

Rotation on the Image -> Properties dialog Image tab? In the Rotation Angle
area, arrows on the spin box control rotates the image (if slowly 1/100 deg
steps) when applied. While clicking on a 15 deg index mark (or dragging) the
360 deg rotation medallion works when applied.

Aren't +[UP,DONW,LEFT,RIGHT] controls to rotate Draw objects? And, are
they still working at 6.0--they seem to now be fine positioning controls (even
in Rotation mode). With +[UP,DOWN,LEFT,RIGHT] acting as coarse movement
controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115548] Base locks up

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115548

--- Comment #3 from t...@tim-passingham.co.uk ---
Created attachment 139710
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139710=edit
A sample database

This database demonstrates the problem.  With previous versions of LO Base the
document opens and asks for the user name and password.  With version 6 it
locks up.

The fact that the underlying mysql database doesn't exist on your systems
shouldn't matter for the purpose of showing that Base now locks up on the
connect statement in the DBOpen macro.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sfx2/source

2018-02-08 Thread Justin Luth

 sfx2/source/doc/objstor.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit df30a561499305a1da6c5fb578315feefe873881
Author: Justin Luth 
Date:   Fri Feb 2 14:53:40 2018 +0300

init known ExtraLanguages before document loads

Extensions can add RegisterOnTheFly languages for spell checkers.
A late initialization of the LanguageTable resulted in the inability
to recognize the available spell checker.

So, if a .doc file had an onTheFly language inside, and it was
the first document that LibreOffice opened, then the spell checking
extension was disabled for any other document opened while LibreOffice
was living, including docx and odt files.  (Starting with a blank
document, or a .docx or .odt file seems to initialize OK - and
then subsequent .doc files are also ok in those sessions.)

Ensuring that the static LanguageTable is intialized early in the process
avoids this headache.

In my case, .doc was failing with:
LanguageTag::registerOnTheFly: not cross-inserted
0x7e0 for 'kbo' have 'en-US'

but with this patch now matches .odt/docx with:

LanguageTag::registerOnTheFly: cross-inserted
0x7e0 for 'kbo' [have 'kbo']

This fixes .ods .odg, odp,
   .xls .xlsx .ppt, pptx
   .doc and likely many others

Change-Id: Ie6dcbfd73e063eef4573016c3c62d29cf8ad43ca
Reviewed-on: https://gerrit.libreoffice.org/49142
Reviewed-by: Martin Hosken 
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit 427c0804cd4aecde1cadb7cb3c4f3487991bd573)
Reviewed-on: https://gerrit.libreoffice.org/49171
Reviewed-by: Justin Luth 
(cherry picked from commit d51c01846afb9bea5a39fd48fbb30b9fd02c2870)
Reviewed-on: https://gerrit.libreoffice.org/49449
Reviewed-by: Markus Mohrhard 

diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 759cc16b987c..b295345ca46e 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -73,6 +73,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -655,6 +656,9 @@ bool SfxObjectShell::DoLoad( SfxMedium *pMed )
 pImpl->nLoadedFlags = SfxLoadedFlags::NONE;
 pImpl->bModelInitialized = false;
 
+// initialize static language table so language-related extensions are 
learned before the document loads
+(void)SvtLanguageTable::GetLanguageEntryCount();
+
 //TODO/LATER: make a clear strategy how to handle "UsesStorage" etc.
 bool bOwnStorageFormat = IsOwnStorageFormat( *pMedium );
 bool bHasStorage = IsPackageStorageFormat_Impl( *pMedium );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-5' - pyuno/source

2018-02-08 Thread Michael Stahl

 pyuno/source/loader/pyuno_loader.cxx |   25 +
 1 file changed, 21 insertions(+), 4 deletions(-)

New commits:
commit 42e2c4af310deb7660b07c6307459c9d2a42bb8b
Author: Michael Stahl 
Date:   Thu Feb 1 13:52:00 2018 +0100

tdf#114815 pyuno: avoid 2 threads initing python in parallel

According to the crash reports, it's possible for the grammar checking
thread to call GetGrammarChecker, instantiating lightproof, at the same
time as the main thread instantiates LngSvcMgr, which also instantiates
(some?) (all?) grammar checkers.

Ensure that pyuno_loader::CreateInstance() initialises Python only
once with a C++11 thread safe static.

For the backport, use rtl::Static instead, because on the 5.4 branch
MSVC does not have HAVE_THREADSAFE_STATICS enabled.

Change-Id: I5b1faba9107355c508831a078366e4a29fdbfadf
(cherry picked from commit 5357ca82846ea7147ad61e9340f25647a5934eb0)
Reviewed-on: https://gerrit.libreoffice.org/49116
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 362b0c521c1c58dc8ea5e87ecbb482d5bdc073f4)
Reviewed-on: https://gerrit.libreoffice.org/49298
Reviewed-by: Michael Meeks 
Tested-by: Markus Mohrhard 
Reviewed-by: Markus Mohrhard 

diff --git a/pyuno/source/loader/pyuno_loader.cxx 
b/pyuno/source/loader/pyuno_loader.cxx
index adbf6c88e098..0408af0f4043 100644
--- a/pyuno/source/loader/pyuno_loader.cxx
+++ b/pyuno/source/loader/pyuno_loader.cxx
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -176,11 +177,10 @@ static void prependPythonPath( const OUString & 
pythonPathBootstrap )
 osl_setEnvironment(envVar.pData, envValue.pData);
 }
 
-Reference< XInterface > CreateInstance( const Reference< XComponentContext > & 
ctx )
+struct PythonInit
 {
-Reference< XInterface > ret;
-
-if( ! Py_IsInitialized() )
+PythonInit() {
+if (! Py_IsInitialized()) // may be inited by getComponentContext() already
 {
 OUString pythonPath;
 OUString pythonHome;
@@ -236,9 +236,26 @@ Reference< XInterface > CreateInstance( const Reference< 
XComponentContext > & c
 // PyThreadAttach below.
 PyThreadState_Delete(tstate);
 }
+}
+};
+
+namespace {
+struct thePythonInit : public rtl::Static {};
+}
+
+Reference CreateInstance(const Reference & ctx)
+{
+// tdf#114815 thread-safe static to init python only once
+thePythonInit::get();
+
+Reference< XInterface > ret;
 
 PyThreadAttach attach( PyInterpreterState_Head() );
 {
+// note: this can't race against getComponentContext() because
+// either (in soffice.bin) CreateInstance() must be called before
+// getComponentContext() can be called, or (in python.bin) the other
+// way around
 if( ! Runtime::isInitialized() )
 {
 Runtime::initialize( ctx );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 112990] LO60master on macOS: crashing at start with OpenGL enabled

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112990

--- Comment #49 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=392206f0449f9baa987d28cf509eccfa33700330=libreoffice-6-0

tdf#112990: Hack-around: Do not crash on mac with opengl enabled

It will be available in 6.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112990] LO60master on macOS: crashing at start with OpenGL enabled

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112990

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101842] LO freezes while unsuccessfully searching for Firefox Themes

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101842

Jean-Baptiste Faure  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4731

--- Comment #12 from Jean-Baptiste Faure  ---
Please try a more recent build of the master, one that contains the commit
fixing bug 114731.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/source

2018-02-08 Thread Xisco Fauli

 vcl/source/outdev/text.cxx |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 392206f0449f9baa987d28cf509eccfa33700330
Author: Xisco Fauli 
Date:   Mon Feb 5 16:51:59 2018 +0100

tdf#112990: Hack-around: Do not crash on mac with opengl enabled

Change-Id: Id8d1ffe593fa42b7e37e26e8d66ffad87d6685c1
Reviewed-on: https://gerrit.libreoffice.org/49251
Tested-by: Jenkins 
Reviewed-by: Tamás Bunth 
(cherry picked from commit c83d2ac99dc3da4ef85b193543a93e02e3858844)
Reviewed-on: https://gerrit.libreoffice.org/49442
Reviewed-by: Markus Mohrhard 

diff --git a/vcl/source/outdev/text.cxx b/vcl/source/outdev/text.cxx
index 1d93f7730aae..5694a8165b58 100644
--- a/vcl/source/outdev/text.cxx
+++ b/vcl/source/outdev/text.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -861,6 +862,14 @@ void OutputDevice::DrawText( const Point& rStartPt, const 
OUString& rStr,
 if(mpFontInstance->mpConversion)
 pLayoutCache = nullptr;
 
+#ifdef MACOSX
+// FIXME: tdf#112990
+// Cache text layout crashes on mac with OpenGL enabled
+// Force it to not use the cache
+if(OpenGLHelper::isVCLOpenGLEnabled())
+pLayoutCache = nullptr;
+#endif
+
 // without cache
 if(!pLayoutCache)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry

2018-02-08 Thread Gabriele Ponzo

 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit badbdb41acf69e3eba4ca7253ec0218dc1e63d0a
Author: Gabriele Ponzo 
Date:   Tue Feb 6 11:12:57 2018 +0100

tdf#108224: rename insert author menu entry

The Insert Author menu entry does not insert the author field but the
"DocInformation:Created" field.

Change-Id: I6dadbf17d5cd3cd2c7b652c1b1c28996c1148a8c
Reviewed-on: https://gerrit.libreoffice.org/49281
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
index 1f4fe350ce11..d1f08c272834 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
@@ -828,7 +828,7 @@
   
   
 
-  ~Author
+  First ~Author
 
 
   1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115192] FILESAVE XLSX Hyperlinks do not work from shapes after saving the file as XLSX

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115192

Bartosz  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115192] FILESAVE XLSX Hyperlinks do not work from shapes after saving the file as XLSX

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115192

--- Comment #5 from Bartosz  ---
The root cause of problem is in file:
   drawing1.xml.rels

After saving by LO, TargetMode="External" is added:

http://schemas.openxmlformats.org/package/2006/relationships;>
http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink;
Target="#Munka2!A1" TargetMode="External"/>


after deleting TargetMode="External", everything works as espected:

http://schemas.openxmlformats.org/package/2006/relationships;>
http://schemas.openxmlformats.org/officeDocument/2006/relationships/hyperlink;
Target="#Munka2!A1"/>


-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115192] FILESAVE XLSX Hyperlinks do not work from shapes after saving the file as XLSX

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115192

--- Comment #4 from Bartosz  ---
Confirmed with LibreOffice 6.0.0.3 Ubuntu 16.04

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115192] FILESAVE XLSX Hyperlinks do not work from shapes after saving the file as XLSX

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115192

Bartosz  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115562] Rotated image has wrong movement for arrow keys

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115562

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
I can confirm with Version: 6.1.0.0.alpha0+
Build ID: 30083601334279f33a3021dfe7d22970d02c8e9e
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk3;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114129] Manually set set scale factors are not persistent after system account logout.

2018-02-08 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=114129

--- Comment #3 from ricky.t...@gmail.com ---
Tested stand-alone version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 2; OS: Linux 4.14; UI render: default; VCL: gtk2; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group

User interface only available as English (US).

Manually set scale factors were at last persistent after system account logout
and system reboot. 

In the context of installation in terminal, folowing information was advertised
'Total size: 207 M
Installed size: 579 M'.

Obviously, from the current disk size unit 'M', it cannot be guessed either it
is assumed byte (B) or bit (b). May it be that specifications related to
Libreoffice package are involved in that aspect? In document README_en-US,
mentioned URLs that actually use protocol HTTPS are all mentionned as HTTP URLs
except one correct mention 'https://bugs.libreoffice.org/'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

1 2 3 4 5 >

1 - 100 of 402 matches

Mail list logo