[Libreoffice-bugs] [Bug 116130] PPTX File OPEN - Rendering of text overlap each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116130

--- Comment #2 from Jacques Guilleron  ---
Hi Stuart,

I don't reproduce with
LO 6.1.0.0.alpha0+
Build ID: 3c913c3844acae8ee0d80ab174133bdc7677efea
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-14_00:19:27
Locale: en-US (fr_FR); Calc: CL
Perhaps a Windows 10 only issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115573] EDITING: Table loses formatting when inserting a new row in a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115573

--- Comment #40 from Jim Raykowski  ---
Here is a patch that keeps direct formatting after rows/cols are
inserted/deleted or table style is changed for cells with character attribute
direct formatting. 

https://gerrit.libreoffice.org/#/c/50612/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101630] Google Drive two-factor authentication (2FA) not working again

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101630

--- Comment #28 from Robert Cabane  ---
The bug is still there on LO 6.0.4 (Linux). I tried opening Google drive giving
my account either as (my Gmail address) or (the first part of my Gmail
address), without success : my phone didn't receive any SMS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116135] Issue on Writer table layout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116135

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Jacques Guilleron  ---
Hi,

Thank you to report it.
However, this issue was previously reported in
Bug 115573 - EDITING: Table loses formatting when inserting a new row in a
table

*** This bug has been marked as a duplicate of bug 115573 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115573] EDITING: Table loses formatting when inserting a new row in a table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115573

Jacques Guilleron  changed:

   What|Removed |Added

 CC||perie_...@hotmail.com

--- Comment #39 from Jacques Guilleron  ---
*** Bug 116135 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116137] New: fileopen odt loadcomponentfromurl error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116137

Bug ID: 116137
   Summary: fileopen odt loadcomponentfromurl error
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kris...@grrlz.net

Description:
fileopen odt loadcomponentfromurl error

Steps to Reproduce:
open attachment 135937 on Bug #112164

Actual Results:  
loadcomponentfromurl

Expected Results:
display content


Reproducible: Always


User Profile Reset: No



Additional Info:
endless loop on
Version: 6.1.0.0.alpha0+
tinderbox: buildname: Android-ARM@24-Bytemark-Hosting
tinderbox: tree: MASTER
tinderbox: pull time 2018-02-27 23:38:0
tinderbox: git sha1s core:dc8d8cbf30ca3429236eca16b8f447ef5d4e61d3

lo viewer v14 error, loadcomponentfromurl returned an empty response
Version: 6.1.0.0.alpha0+
Build ID: 484d0ea842da


User-Agent: Mozilla/5.0 (Android 5.1; Mobile; rv:60.0) Gecko/60.0 Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vbahelper sc/source

[Noel Grandin]

 include/vbahelper/vbahelper.hxx  |2 ++
 sc/source/ui/vba/vbainterior.cxx |3 +--
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 82d42fa2c05e8d53ec2c21733a2a9f53412dd2d1
Author: Noel Grandin 
Date:   Thu Mar 1 16:49:55 2018 +0200

add Color method version of OORGBToXLRGB

Change-Id: I769ff8aed3caa74679e1b4d03e8fbc3cd5d22b1a
Reviewed-on: https://gerrit.libreoffice.org/50587
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vbahelper/vbahelper.hxx b/include/vbahelper/vbahelper.hxx
index 3643874ef5d5..ff9eca3f232f 100644
--- a/include/vbahelper/vbahelper.hxx
+++ b/include/vbahelper/vbahelper.hxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -97,6 +98,7 @@ namespace ooo
 VBAHELPER_DLLPUBLIC void dispatchRequests (const css::uno::Reference< 
css::frame::XModel>& xModel, const OUString & aUrl, const css::uno::Sequence< 
css::beans::PropertyValue >& sProps );
 VBAHELPER_DLLPUBLIC void dispatchExecute(SfxViewShell const * pView, 
sal_uInt16 nSlot );
 VBAHELPER_DLLPUBLIC sal_Int32 OORGBToXLRGB( sal_Int32 );
+inline sal_Int32 OORGBToXLRGB( ::Color n ) { return 
OORGBToXLRGB(sal_Int32(n)); }
 VBAHELPER_DLLPUBLIC sal_Int32 XLRGBToOORGB( sal_Int32 );
 VBAHELPER_DLLPUBLIC css::uno::Any OORGBToXLRGB( const css::uno::Any& );
 VBAHELPER_DLLPUBLIC css::uno::Any XLRGBToOORGB( const css::uno::Any& );
diff --git a/sc/source/ui/vba/vbainterior.cxx b/sc/source/ui/vba/vbainterior.cxx
index b413b385a801..c40224a04f04 100644
--- a/sc/source/ui/vba/vbainterior.cxx
+++ b/sc/source/ui/vba/vbainterior.cxx
@@ -91,8 +91,7 @@ ScVbaInterior::ScVbaInterior( const uno::Reference< 
XHelperInterface >& xParent,
 uno::Any
 ScVbaInterior::getColor()
 {
-Color aBackColor( GetBackColor() );
-return uno::makeAny( OORGBToXLRGB( aBackColor.GetColor() ) );
+return uno::makeAny( OORGBToXLRGB( GetBackColor() ) );
 }
 
 void
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Resources on writing import/export file filters for Writer

[Jens Tröger]

Thank you Miklos!

Fridrich's blog was interesting, and mentions export filters on occasion. It
hasn't given much detail though on how to actually write a XFilter based
implementation which is what seems most sensible.

Perhaps somebody can point me at the source code of existing (simple) export
filters?

The blog also suggests to use ODF flat XML as an intermediary file format
but without giving a reference. Is this the one:
https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=office#technical
?

Thanks!
Jens



--
Sent from: http://nabble.documentfoundation.org/Dev-f1639786.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 116100] MATCH applied to a search array introduced by an OFFSET subexpression results in Err :504.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116100

Jacques Guilleron  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
Version|6.0.2.1 release |6.0.0.0.alpha0+
 Ever confirmed|0   |1

--- Comment #1 from Jacques Guilleron  ---
Hi Wolfgang,

I reproduce with
LO 6.1.0.0.alpha0+ Build ID: 3c913c3844acae8ee0d80ab174133bdc7677efea
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-02-14_00:19:27
Locale: en-US (fr_FR); Calc: CL
LO 6.0.0.0.alpha0+ Build ID: 9e4502f0e393d2bc2810488b3ebb0a5c23038436
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-16_08:52:00
Locale: fr-FR (fr_FR); Calc: CL
but not with
LO 5.4.4.2 Build ID: 2524958677847fb3bb44820e40380acbe820f960
Threads CPU : 2; OS : Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL

Thank you to have reported it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - avmedia/Library_avmediagst.mk avmedia/source

[Damjan Jovanovic]

 avmedia/Library_avmediagst.mk|8 ++
 avmedia/source/gstreamer/gstframegrabber.cxx |4 +--
 avmedia/source/gstreamer/gstplayer.cxx   |   33 ---
 3 files changed, 25 insertions(+), 20 deletions(-)

New commits:
commit 378713d7be8867784f3c7a448898f12e485aa984
Author: Damjan Jovanovic 
Date:   Fri Mar 2 06:14:01 2018 +

Use gstreamer 1.0 instead of the long obsolete

version 0.1.

Embed the window into the document properly,
by setting the window id on the GstVideoOverlay
using gst_video_overlay_set_window_handle()
after window creation in Player::createPlayerWindow().

Add better logging.

Patch by: me

diff --git a/avmedia/Library_avmediagst.mk b/avmedia/Library_avmediagst.mk
index d583e7398d6b..212adde3279c 100644
--- a/avmedia/Library_avmediagst.mk
+++ b/avmedia/Library_avmediagst.mk
@@ -31,12 +31,11 @@ $(eval $(call gb_Library_set_include,avmediagst,\
 $$(INCLUDE) \
-I$(SRCDIR)/avmedia/inc \
-I$(SRCDIR)/avmedia/source/inc \
-   $(filter -I%,$(GTK_CFLAGS)) \
-   $(shell pkg-config --cflags-only-I gstreamer-0.10 
gstreamer-interfaces-0.10) \
+   $(filter -I%,$(GSTREAMER_CFLAGS)) \
 ))
 
 $(eval $(call gb_Library_add_cflags,avmediagst,\
-   $(filter-out -I%,$(GTK_CFLAGS)) \
+   $(filter-out -I%,$(GSTREAMER_CFLAGS)) \
 ))
 
 ifeq ($(OS),MACOSX)
@@ -62,8 +61,7 @@ $(eval $(call gb_Library_add_linked_libs,avmediagst,\
 ))
 
 $(eval $(call gb_Library_add_libs,avmediagst,\
-   $(GTK_LIBS) \
-   $(shell pkg-config --libs gstreamer-0.10 gstreamer-interfaces-0.10) \
+   $(GSTREAMER_LIBS) \
 ))
 
 $(eval $(call gb_Library_add_exception_objects,avmediagst,\
diff --git a/avmedia/source/gstreamer/gstframegrabber.cxx 
b/avmedia/source/gstreamer/gstframegrabber.cxx
index 6467aa0e007c..1f23680ba1dd 100644
--- a/avmedia/source/gstreamer/gstframegrabber.cxx
+++ b/avmedia/source/gstreamer/gstframegrabber.cxx
@@ -130,9 +130,9 @@ gboolean FrameGrabber::busCallback( GstBus* pBus, 
GstMessage* pMsg )
 {
 bool bDone = false;
 
-if( pMsg && pMsg->structure )
+if( pMsg && gst_message_get_structure( pMsg ) )
 {
-GstStructure* pStruct = pMsg->structure;
+const GstStructure* pStruct = gst_message_get_structure( pMsg );
 const gchar* pStructName = gst_structure_get_name( pStruct );
 
 if( ( ::std::string( pStructName ).find( "pixbuf" ) != 
::std::string::npos ) &&
diff --git a/avmedia/source/gstreamer/gstplayer.cxx 
b/avmedia/source/gstreamer/gstplayer.cxx
index 63003de836c0..6741146e6ac7 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -29,7 +29,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 
 // maximum timeout time in nanoseconds
@@ -312,10 +312,7 @@ double SAL_CALL Player::getDuration()
 
 if( implInitPlayer() )
 {
-GstFormat aFormat = GST_FORMAT_TIME;
-
-if( !gst_element_query_duration( mpPlayer, ,  ) ||
-   ( GST_FORMAT_TIME != aFormat ) ||
+if( !gst_element_query_duration( mpPlayer, GST_FORMAT_TIME,  
) ||
( nDuration < 0 ) )
 {
 nDuration = 0;
@@ -348,11 +345,9 @@ double SAL_CALL Player::getMediaTime()
 ::osl::MutexGuard aGuard(m_aMutex);
 if( implInitPlayer() )
 {
-GstFormat aFormat = GST_FORMAT_TIME;
 gint64 nCurTime = 0;
 
-if( gst_element_query_position( mpPlayer, ,  ) &&
-   ( GST_FORMAT_TIME == aFormat ) &&
+if( gst_element_query_position( mpPlayer, GST_FORMAT_TIME,  ) 
&&
( nCurTime >= 0 ) )
 {
 fRet = static_cast< double >( nCurTime ) / NANO_TIME_FACTOR;
@@ -539,6 +534,7 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL 
Player::createPlayerWindow(
 
 if( !pPlayerWindow->create( rArguments ) )
 {
+OSL_ENSURE( false, "could not create player window\n" );
 xRet.clear();
 }
 else
@@ -557,8 +553,12 @@ uno::Reference< ::media::XPlayerWindow > SAL_CALL 
Player::createPlayerWindow(
 gst_element_get_state( mpPlayer, , NULL, 
GST_MAX_TIMEOUT );
 gst_element_set_state( mpPlayer, GST_STATE_READY );
 g_object_set( mpPlayer, "video-sink", pVideoSink, NULL );
+gst_video_overlay_set_window_handle( GST_VIDEO_OVERLAY( 
mpPlayer ),
+pPlayerWindow->getXWindowHandle() );
 gst_element_set_state( mpPlayer, aOldState );
 }
+else
+OSL_ENSURE( false, "no video sink available\n" );
 }
 }
 
@@ -756,7 +756,7 @@ void Player::implHandleNewPadFunc( GstElement* pElement,
 g_free( pElementName );
 #endif
 
-GstCaps* pCaps = gst_pad_get_caps( pPad );
+GstCaps* pCaps = gst_pad_get_current_caps( pPad );
 
 // we are interested only in getting video properties
 // 

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna]

 sw/qa/extras/htmlexport/data/reqif-p.xhtml |1 +
 sw/qa/extras/htmlexport/htmlexport.cxx |4 
 sw/source/filter/html/htmltabw.cxx |   11 ++-
 3 files changed, 11 insertions(+), 5 deletions(-)

New commits:
commit 12c3ab8c341ff6482ce380ca4010bb7b97e35bf7
Author: Miklos Vajna 
Date:   Thu Mar 1 17:50:52 2018 +0100

sw HTML export: XHTML ns alias for table markup

This was forgotten from the previous mass-conversion of adding namespace
aliases to written elements.

Change-Id: Id9b7e961c941ec3b3614e3694963c3f9ef9e46eb
Reviewed-on: https://gerrit.libreoffice.org/50595
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/sw/qa/extras/htmlexport/data/reqif-p.xhtml 
b/sw/qa/extras/htmlexport/data/reqif-p.xhtml
index 36f5aa11768b..2f069d78e0eb 100644
--- a/sw/qa/extras/htmlexport/data/reqif-p.xhtml
+++ b/sw/qa/extras/htmlexport/data/reqif-p.xhtml
@@ -1 +1,2 @@
 aaabbb
+in 
table
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx 
b/sw/qa/extras/htmlexport/htmlexport.cxx
index e1b7313195e3..f329c3d4a79f 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -337,6 +337,10 @@ DECLARE_HTMLEXPORT_TEST(testReqIfParagraph, 
"reqif-p.xhtml")
 CPPUNIT_ASSERT(pStream);
 
 OString 
aExpected("aaa\nbbb" 
SAL_NEWLINE_STRING);
+
+// This was '1 )
@@ -483,7 +484,7 @@ void SwHTMLWrtTable::OutTableCell( SwHTMLWriter& rWrt,
 
 if( rWrt.m_bLFPossible )
 rWrt.OutNewLine();
-OString aTag = bHead ? OOO_STRING_SVTOOLS_HTML_tableheader : 
OOO_STRING_SVTOOLS_HTML_tabledata;
+aTag = bHead ? OOO_STRING_SVTOOLS_HTML_tableheader : 
OOO_STRING_SVTOOLS_HTML_tabledata;
 HTMLOutFuncs::Out_AsciiTag(rWrt.Strm(), rWrt.GetNamespace() + aTag, false);
 rWrt.m_bLFPossible = true;
 }
@@ -514,7 +515,7 @@ void SwHTMLWrtTable::OutTableCells( SwHTMLWriter& rWrt,
 }
 
 rWrt.OutNewLine();  //  in new line
-rWrt.Strm().WriteChar( '<' ).WriteCharPtr( 
OOO_STRING_SVTOOLS_HTML_tablerow );
+rWrt.Strm().WriteChar( '<' ).WriteOString( rWrt.GetNamespace() + 
OOO_STRING_SVTOOLS_HTML_tablerow );
 if( pBrushItem )
 {
 rWrt.OutBackground( pBrushItem, false );
@@ -598,7 +599,7 @@ void SwHTMLWrtTable::Write( SwHTMLWriter& rWrt, sal_Int16 
eAlign,
 if( rWrt.m_bLFPossible )
 rWrt.OutNewLine();  //  in new line
 OStringBuffer sOut;
-sOut.append('<').append(OOO_STRING_SVTOOLS_HTML_table);
+sOut.append('<').append(rWrt.GetNamespace() + 
OOO_STRING_SVTOOLS_HTML_table);
 
 const SvxFrameDirection nOldDirection = rWrt.m_nDirection;
 if( pFrameFormat )
@@ -732,7 +733,7 @@ void SwHTMLWrtTable::Write( SwHTMLWriter& rWrt, sal_Int16 
eAlign,
 const SwWriteTableCol *pColumn = m_aCols[nCol];
 
 OStringBuffer sOutStr;
-sOutStr.append('<').append(OOO_STRING_SVTOOLS_HTML_col);
+sOutStr.append('<').append(rWrt.GetNamespace() + 
OOO_STRING_SVTOOLS_HTML_col);
 
 sal_uInt32 nWidth;
 bool bRel;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/clang-format xmlsecurity/inc xmlsecurity/source xmlsecurity/util

[Miklos Vajna]

 solenv/clang-format/blacklist  |2 
 xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx|2 
 xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx |2 
 xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx |2 
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx|2 
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx |   46 
+++---
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx |   11 --
 xmlsecurity/source/xmlsec/xsec_xmlsec.cxx  |   10 --
 xmlsecurity/util/xsec_xmlsec.component |3 
 xmlsecurity/util/xsec_xmlsec.windows.component |3 
 10 files changed, 26 insertions(+), 57 deletions(-)

New commits:
commit 4bb67227c142b7a549d3aa2024e398049e8e3222
Author: Miklos Vajna 
Date:   Thu Mar 1 21:17:08 2018 +0100

xmlsecurity: create XMLElementWrapper instances with a constructor

Change-Id: I0fe7d0a21b0ea35b537466316a637a0a46c52fe5
Reviewed-on: https://gerrit.libreoffice.org/50601
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 9ab96f7e1473..41e3a7a55169 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -19676,7 +19676,6 @@ xmlsecurity/inc/xmlsec-wrapper.h
 xmlsecurity/inc/xmlsec/errorcallback.hxx
 xmlsecurity/inc/xmlsec/saxhelper.hxx
 xmlsecurity/inc/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx
-xmlsecurity/inc/xmlsec/xmlelementwrapper_xmlsecimpl.hxx
 xmlsecurity/inc/xmlsec/xmlsec_init.hxx
 xmlsecurity/inc/xmlsec/xmlstreamio.hxx
 xmlsecurity/inc/xmlsecuritydllapi.h
@@ -19786,6 +19785,7 @@ xmlsecurity/source/xmlsec/nss/xsec_nss.cxx
 xmlsecurity/source/xmlsec/saxhelper.cxx
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
+xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx
 xmlsecurity/source/xmlsec/xmlsec_init.cxx
 xmlsecurity/source/xmlsec/xmlstreamio.cxx
 xmlsecurity/source/xmlsec/xsec_xmlsec.cxx
diff --git a/xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx 
b/xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx
index 82016b8871bd..896970d4b40f 100644
--- a/xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx
+++ b/xmlsecurity/source/gpg/xmlsignature_gpgimpl.cxx
@@ -39,7 +39,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx 
b/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
index f7ade4e54161..0a35533ccd54 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
@@ -26,7 +26,7 @@
 #include "securityenvironment_mscryptimpl.hxx"
 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
index bc8d3ca2517f..f4b1364f52dd 100644
--- a/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/xmlsignature_nssimpl.cxx
@@ -21,7 +21,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 
diff --git a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx 
b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
index 1e75168e014d..a03f62cb3379 100644
--- a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
+++ b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
@@ -23,7 +23,7 @@
 #include 
 #include 
 #include 
-#include 
+#include "xmlelementwrapper_xmlsecimpl.hxx"
 
 #include 
 
diff --git a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx 
b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
index 76f9bd16d2c4..4f9e8c8047e6 100644
--- a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
+++ b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
@@ -19,32 +19,27 @@
 
 #include 
 
-#include 
+#include "xmlelementwrapper_xmlsecimpl.hxx"
 #include 
 #include 
 #include 
 
-namespace cssu = com::sun::star::uno;
-
-#define IMPLEMENTATION_NAME 
"com.sun.star.xml.security.bridge.xmlsec.XMLElementWrapper_XmlSecImpl"
+using namespace com::sun::star;
 
 XMLElementWrapper_XmlSecImpl::XMLElementWrapper_XmlSecImpl(const xmlNodePtr 
pNode)
 : m_pElement( pNode )
 {
 }
 
-/* XXMLElementWrapper */
-
-
 /* XUnoTunnel */
-cssu::Sequence< sal_Int8 > 
XMLElementWrapper_XmlSecImpl::getUnoTunnelImplementationId()
+uno::Sequence< sal_Int8 > 
XMLElementWrapper_XmlSecImpl::getUnoTunnelImplementationId()
 {
 static ::cppu::OImplementationId implId;
 
 return implId.getImplementationId();
 }
 
-sal_Int64 SAL_CALL XMLElementWrapper_XmlSecImpl::getSomething( const 
cssu::Sequence< sal_Int8 >& aIdentifier )
+sal_Int64 SAL_CALL 

[Libreoffice-bugs] [Bug 38370] [FILEOPEN] LibreOffice Impress do not allow open password-protected PowerPoint presentations in "read-only" mode

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38370

--- Comment #58 from Sebastian  ---
I had LO open those password protected from edition pps files with Impress
around mid march 2017 to the end of may 2017. It was exactly when this feature
appeared in release notes for LO 5.3 around march/april/may 2017:
"The contemporary Microsoft Office default Binary Document encryption "RC4
CryptoAPI Encryption" is now supported (Caolán McNamara, Red Hat, Inc.)"

I did not memorize the exact version, 'cause I was not expecting the feature
will get broken.
Some version from that time was opening those pps file without problem in
read-only mode. I was testing versions from 5.3.1.2 to 5.3.5.2 from download
archive but none will open pps, just display mentioned error window. But than
not all versions of LO are in download archive. All I can remember I was able
to open those pps files with LO 5.3.3 or 5.3.4 and then the feature got broken
with 5.3.5 or 5.3.6 because LO started to display error window about not
supporting password protected Powerpoint documents. Maybe Caolán McNamara can
check the code for errors?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc vcl/osx vcl/qa vcl/source vcl/unx vcl/win

[Noel Grandin]

 vcl/inc/osx/salprn.h  |4 ++--
 vcl/inc/salgdi.hxx|3 +++
 vcl/inc/salprn.hxx|4 ++--
 vcl/inc/unx/genprn.h  |4 ++--
 vcl/inc/win/salprn.h  |4 ++--
 vcl/osx/salframe.cxx  |8 
 vcl/osx/salnativewidgets.cxx  |   26 +-
 vcl/osx/salprn.cxx|   26 --
 vcl/qa/cppunit/complextext.cxx|3 +--
 vcl/source/control/scrbar.cxx |   12 ++--
 vcl/source/edit/texteng.cxx   |3 ++-
 vcl/source/edit/textview.cxx  |3 ++-
 vcl/source/gdi/pdfwriter_impl.cxx |3 ++-
 vcl/source/gdi/print.cxx  |4 ++--
 vcl/source/gdi/salgdilayout.cxx   |8 +++-
 vcl/source/outdev/font.cxx|2 +-
 vcl/source/outdev/outdev.cxx  |3 ++-
 vcl/source/outdev/text.cxx|   16 
 vcl/source/window/mouse.cxx   |2 +-
 vcl/source/window/toolbox.cxx |6 +-
 vcl/source/window/window.cxx  |2 +-
 vcl/unx/generic/print/genprnpsp.cxx   |   12 ++--
 vcl/win/gdi/DWriteTextRenderer.cxx|8 
 vcl/win/gdi/salfont.cxx   |6 +++---
 vcl/win/gdi/salnativewidgets-luna.cxx |   30 +++---
 vcl/win/gdi/salprn.cxx|   12 ++--
 vcl/win/gdi/winlayout.cxx |   16 
 vcl/win/window/salframe.cxx   |8 
 28 files changed, 130 insertions(+), 108 deletions(-)

New commits:
commit 312c0abcff23a5bc7cf4442359ec48187ec06d48
Author: Noel Grandin 
Date:   Tue Feb 27 17:07:24 2018 +0200

drop old tools/gen methods in vcl

Change-Id: I863ce5ae46ae90f06780261fa17b087a7153c807
Reviewed-on: https://gerrit.libreoffice.org/50445
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/vcl/inc/osx/salprn.h b/vcl/inc/osx/salprn.h
index b82095c7559f..8f9c04017a66 100644
--- a/vcl/inc/osx/salprn.h
+++ b/vcl/inc/osx/salprn.h
@@ -73,8 +73,8 @@ class AquaSalInfoPrinter : public SalInfoPrinter
 virtual boolSetData( JobSetFlags i_nFlags, ImplJobSetup* 
i_pSetupData ) override;
 virtual voidGetPageInfo( const ImplJobSetup* i_pSetupData,
  long& o_rOutWidth, long& 
o_rOutHeight,
- long& o_rPageOffX, long& 
o_rPageOffY,
- long& o_rPageWidth, long& 
o_rPageHeight ) override;
+ Point& rPageOffset,
+ Size& rPaperSize ) override;
 virtual sal_uInt32  GetCapabilities( const ImplJobSetup* 
i_pSetupData, PrinterCapType i_nType ) override;
 virtual sal_uInt16  GetPaperBinCount( const ImplJobSetup* 
i_pSetupData ) override;
 virtual OUStringGetPaperBinName( const ImplJobSetup* 
i_pSetupData, sal_uInt16 i_nPaperBin ) override;
diff --git a/vcl/inc/salgdi.hxx b/vcl/inc/salgdi.hxx
index 32b51f6630d9..655c3ea17aa1 100644
--- a/vcl/inc/salgdi.hxx
+++ b/vcl/inc/salgdi.hxx
@@ -203,6 +203,9 @@ public:
 voidSetLayout( SalLayoutFlags aLayout ) { 
m_nLayout = aLayout;}
 
 voidmirror( long& nX, const OutputDevice *pOutDev 
) const;
+// only called mirror2 to avoid ambiguity
+SAL_WARN_UNUSED_RESULT
+longmirror2( long nX, const OutputDevice *pOutDev 
) const;
 voidmirror( long& nX, long nWidth, const 
OutputDevice *pOutDev, bool bBack = false ) const;
 boolmirror( sal_uInt32 nPoints, const SalPoint 
*pPtAry, SalPoint *pPtAry2, const OutputDevice *pOutDev ) const;
 voidmirror( tools::Rectangle& rRect, const 
OutputDevice*, bool bBack = false ) const;
diff --git a/vcl/inc/salprn.hxx b/vcl/inc/salprn.hxx
index d8b4182f4fee..d9da1a6d80ed 100644
--- a/vcl/inc/salprn.hxx
+++ b/vcl/inc/salprn.hxx
@@ -72,8 +72,8 @@ public:
 
 virtual voidGetPageInfo( const ImplJobSetup* 
pSetupData,
  long& rOutWidth, long& 
rOutHeight,
- long& rPageOffX, long& 
rPageOffY,
- long& rPageWidth, long& 
rPageHeight ) = 0;
+ Point& rPageOffset,
+ Size& rPaperSize ) = 0;
 virtual sal_uInt32  GetCapabilities( const ImplJobSetup* 
pSetupData, PrinterCapType nType ) = 0;
 virtual sal_uInt16  GetPaperBinCount( const ImplJobSetup* 
pSetupData ) = 0;
 virtual OUString

[Libreoffice-bugs] [Bug 103459] [META] Sidebar UI and UX bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103459
Bug 103459 depends on bug 115981, which changed state.

Bug 115981 Summary: SIDEBAR: Panel's  minimum width can be circumvented making 
the panel unusable.
https://bugs.documentfoundation.org/show_bug.cgi?id=115981

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115981] SIDEBAR: Panel' s minimum width can be circumvented making the panel unusable.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115981

Luke  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|DUPLICATE   |---

--- Comment #7 from Luke  ---
No, this is not a dupes of bug 90374. That is an enhancement about having "a
fixed width across ALL tabs". This is about tabs that already have a defined
MINIMUM width. The minimum width can be circumvented by following the steps
above. This is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116117] No Longer Honoring Umask

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116117

--- Comment #2 from Aron Budea  ---
Note that no actual changing of umask is needed for repro, eg. by default files
on my system are saves as 644 (umask is 0022), but after the commit in LO
they're saved as 600.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/gbuild

[Mike Kaganski]

 solenv/gbuild/extensions/post_GbuildToJson.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 451ed3d595c5e2a32d820e1751e890f894832a9c
Author: Mike Kaganski 
Date:   Thu Mar 1 20:37:16 2018 +0100

gbuild-to-json: unblacklist shell

Change-Id: I42f8a69c5deba1f83f6203f19e5f2fcfad837dea
Reviewed-on: https://gerrit.libreoffice.org/50597
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/solenv/gbuild/extensions/post_GbuildToJson.mk 
b/solenv/gbuild/extensions/post_GbuildToJson.mk
index d856bd8837eb..28502b9ff8dc 100644
--- a/solenv/gbuild/extensions/post_GbuildToJson.mk
+++ b/solenv/gbuild/extensions/post_GbuildToJson.mk
@@ -186,7 +186,7 @@ endef
 
 gb_Module_add_l10n_target =
 
-gb_GbuildToJson_BLACKLISTEDMODULES := connectivity compilerplugins cli_ure 
dictionaries bridges helpcompiler helpcontent2 icon-themes jurt sal shell cppu 
cppuhelper cpputools external i18npool javaunohelper lingucomponent odk 
scaddins solenv stoc tools translations udkapi unoidl
+gb_GbuildToJson_BLACKLISTEDMODULES := connectivity compilerplugins cli_ure 
dictionaries bridges helpcompiler helpcontent2 icon-themes jurt sal cppu 
cppuhelper cpputools external i18npool javaunohelper lingucomponent odk 
scaddins solenv stoc tools translations udkapi unoidl
 
 define gb_Module__add_moduledir_impl
 include $(patsubst $(1):%,%,$(filter 
$(1):%,$(gb_Module_MODULELOCATIONS)))/$(2)/Module_$(2).mk
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116117] No Longer Honoring Umask

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116117

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Reproduced and bibisected using repo bibisect-linux-64-6.1 to the commit
referenced below. Adding Cc: to Miklos Vajna, please take a look.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2157a3536f97ff5ae7c82611a801fef7e3708983
author  Miklos Vajna   2018-01-08 16:49:25
+0100
committer   Miklos Vajna   2018-01-09 09:09:27
+0100

sfx2 store: try rename before copying

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106260] EDITING: Cannot copy URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106260

--- Comment #2 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106107] Vertically joined cells in table header don' t keep its height when repeated on the next page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106107

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62366] SLIDESHOW: Pen on the presenter console

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62366

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116136] New: STATUSBAR: Word and Character Count tool tip shows in print preview

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116136

Bug ID: 116136
   Summary: STATUSBAR: Word and Character Count tool tip shows in
print preview
   Product: LibreOffice
   Version: 6.1.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rayk...@gmail.com

To reproduce:

1. Menu > File > Print Preview or Shift+Ctrl+O
2. Hover mouse over 2nd box in the status bar

results : shows tooltip "Word and Character Count. Click to open..." 

expected results : no tooltip

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Kohei Yoshida]

 sc/qa/unit/data/xml/hidden-rows-columns.xml |  115 
 sc/qa/unit/subsequent_filters-test.cxx  |   54 +
 2 files changed, 169 insertions(+)

New commits:
commit 86978ae2471d8a4678b78679540db52a71b2571a
Author: Kohei Yoshida 
Date:   Thu Mar 1 20:12:13 2018 -0500

Add a new test case for Excel 2003 XML import.

Change-Id: I1ba74f35e44b9cea3e3770d513ae520da02b3406
Reviewed-on: https://gerrit.libreoffice.org/50610
Tested-by: Jenkins 
Reviewed-by: Kohei Yoshida 

diff --git a/sc/qa/unit/data/xml/hidden-rows-columns.xml 
b/sc/qa/unit/data/xml/hidden-rows-columns.xml
new file mode 100644
index ..6b4b597bf1d3
--- /dev/null
+++ b/sc/qa/unit/data/xml/hidden-rows-columns.xml
@@ -0,0 +1,115 @@
+
+
+http://www.w3.org/TR/REC-html40;>
+ 
+  Kohei Yoshida
+  Kohei Yoshida
+  2018-02-14T01:31:11Z
+  2018-02-14T01:35:31Z
+  16.00
+ 
+ 
+  
+ 
+ 
+  9105
+  13800
+  0
+  0
+  1
+  False
+  False
+ 
+ 
+  
+   
+   
+   
+   
+   
+   
+  
+ 
+ 
+  
+   
+visible
+   
+   
+hidden
+   
+   
+hidden
+   
+   
+visible
+   
+   
+hidden
+   
+   
+visible
+   
+   
+visible
+   
+   
+visible
+   
+   
+hidden
+   
+  
+  
+   
+
+
+
+   
+   
+
+ 3
+ 14
+ 3
+
+   
+   False
+   False
+  
+ 
+ 
+  
+   
+   
+   
+hidden -
+- hidden
+hidden -
+- hidden
+   
+  
+  
+   
+
+
+
+   
+   
+   
+
+ 3
+ 10
+ 1
+
+   
+   False
+   False
+  
+ 
+
diff --git a/sc/qa/unit/subsequent_filters-test.cxx 
b/sc/qa/unit/subsequent_filters-test.cxx
index be17f2ad3f50..5332bc77722e 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -243,6 +243,7 @@ public:
 void testEmptyRowsXLSXML();
 void testBorderDirectionsXLSXML();
 void testBorderColorsXLSXML();
+void testHiddenRowsColumnsXLSXML();
 
 CPPUNIT_TEST_SUITE(ScFiltersTest);
 CPPUNIT_TEST(testBooleanFormatXLSX);
@@ -371,6 +372,7 @@ public:
 CPPUNIT_TEST(testEmptyRowsXLSXML);
 CPPUNIT_TEST(testBorderDirectionsXLSXML);
 CPPUNIT_TEST(testBorderColorsXLSXML);
+CPPUNIT_TEST(testHiddenRowsColumnsXLSXML);
 CPPUNIT_TEST(testCondFormatFormulaListenerXLSX);
 
 CPPUNIT_TEST_SUITE_END();
@@ -3832,6 +3834,58 @@ void ScFiltersTest::testBorderColorsXLSXML()
 xDocSh->DoClose();
 }
 
+void ScFiltersTest::testHiddenRowsColumnsXLSXML()
+{
+ScDocShellRef xDocSh = loadDoc("hidden-rows-columns.", FORMAT_XLS_XML);
+CPPUNIT_ASSERT_MESSAGE("Failed to load hidden-rows-columns.xml", 
xDocSh.is());
+ScDocument& rDoc = xDocSh->GetDocument();
+
+struct Check
+{
+SCCOLROW nPos1;
+SCCOLROW nPos2;
+bool bVisible;
+};
+
+std::vector aRowChecks = {
+{ 0, 0, true  },
+{ 1, 2, false },
+{ 3, 3, true  },
+{ 4, 4, false },
+{ 5, 7, true  },
+{ 8, 8, false },
+{ 9, MAXROW, true },
+};
+
+for (const Check& c : aRowChecks)
+{
+SCROW nRow1 = -1, nRow2 = -1;
+bool bVisible = !rDoc.RowHidden(c.nPos1, 0, , );
+CPPUNIT_ASSERT_EQUAL(bVisible, c.bVisible);
+CPPUNIT_ASSERT_EQUAL(c.nPos1, nRow1);
+CPPUNIT_ASSERT_EQUAL(c.nPos2, nRow2);
+}
+
+std::vector aColChecks = {
+{ 0, 1, true  },
+{ 2, 5, false },
+{ 6, 9, true  },
+{ 10, 10, false },
+{ 11, MAXCOL, true },
+};
+
+for (const Check& c : aColChecks)
+{
+SCCOL nCol1 = -1, nCol2 = -1;
+bool bVisible = !rDoc.ColHidden(c.nPos1, 1, , );
+CPPUNIT_ASSERT_EQUAL(bVisible, c.bVisible);
+CPPUNIT_ASSERT_EQUAL(c.nPos1, SCCOLROW(nCol1));
+CPPUNIT_ASSERT_EQUAL(c.nPos2, SCCOLROW(nCol2));
+}
+
+xDocSh->DoClose();
+}
+
 void ScFiltersTest::testCondFormatXLSB()
 {
 ScDocShellRef xDocSh = loadDoc("cond_format.", FORMAT_XLSB);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits