[Libreoffice-commits] website.git: Branch 'update' - check.php

[Christian Lohmaier]

 check.php |   10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit aa5dff596f7c42e71f65b88da85839db132069d2
Author: Christian Lohmaier 
Date:   Fri Mar 16 17:23:25 2018 +0100

enable update to 6.0.2

diff --git a/check.php b/check.php
index 51ef67d..7ef1f58 100644
--- a/check.php
+++ b/check.php
@@ -529,6 +529,8 @@ $build_hash_to_version = array(
 # 6.0.1
 '1a915a3f2906b005770de982c78bfccb21913273' => '6.0.1.0.0+', # unreleased, 
testbuild for crashfix
 '60bfb1526849283ce2491346ed2aa51c465abfe6' => '6.0.1.1', # unscheduled, 
due to  unresponsible secfix
+# 6.0.2
+'f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89' => '6.0.2.1', # shortened cylce 
to to early 6.0.1
 );
 
 # Descriptions of the target versions
@@ -547,11 +549,11 @@ $update_map = array(
   'update_type' => 'text/html',
   'update_src'  => 
'https://www.libreoffice.org/download/download/?lang=version=5.4.5',
   'substitute'  => true ),
-'latest' => array('gitid'   => 
'60bfb1526849283ce2491346ed2aa51c465abfe6',
-  'id'  => 'LibreOffice 6.0.1',
-  'version' => '6.0.1',
+'latest' => array('gitid'   => 
'f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89',
+  'id'  => 'LibreOffice 6.0.2',
+  'version' => '6.0.2',
   'update_type' => 'text/html',
-  'update_src'  => 
'https://www.libreoffice.org/download/download/?lang=version=6.0.1',
+  'update_src'  => 
'https://www.libreoffice.org/download/download/?lang=version=6.0.2',
   'substitute'  => true ),
 );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115964] Document password prompt not centered to window with GTK3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115964

Caolán McNamara  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #9 from Caolán McNamara  ---
caolanm->Buovjaga: I can't reproduce this, but from comment #8 it sounds like
you can so I'll convert this password prompt to a native gtk3 dialog and see if
that makes a difference in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116432] New: Make copyright information at bottom of page translatable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116432

Bug ID: 116432
   Summary: Make copyright information at bottom of page
translatable
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: scootergri...@gmail.com

At the bottom of https://da.libreoffice.org/ and other pages i see the
following:

Privacy Policy | Impressum (Legal Info) | Statutes (non-binding English
translation) - Satzung (binding German version) | Copyright information: Unless
otherwise specified, all text and images on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License. This does not include the
source code of LibreOffice, which is licensed under the Mozilla Public License
v2.0.
"LibreOffice" and "The Document Foundation" are registered trademarks of their
corresponding registered owners or are in actual use as trademarks in one or
more countries. Their respective logos and icons are also subject to
international copyright laws. Use thereof is explained in our trademark policy.
LibreOffice was based on OpenOffice.org.



I would like this to be translatable so the translation can be more complete.
Perhaps move this information into other pages and just have links there
instead of all this text. I think its to much text that people are not going to
read anyway.
If we just have links like "Privacy Policy|License|Trademark policy|..." then
people can visit the links if they want to read more instead of putting so much
text at the bottom of pages.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115923] Clicking the fill handle triggers automatic horizontal scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115923

--- Comment #6 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d47a28723ee5b8df2f9e34449b15fac7970a1c69=libreoffice-6-0

Resolves: tdf#115923 try a different approach to solving tdf#46637

It will be available in 6.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115923] Clicking the fill handle triggers automatic horizontal scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115923

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

[Caolán McNamara]

 sc/source/ui/view/select.cxx |   25 -
 1 file changed, 20 insertions(+), 5 deletions(-)

New commits:
commit d47a28723ee5b8df2f9e34449b15fac7970a1c69
Author: Caolán McNamara 
Date:   Thu Mar 15 16:54:44 2018 +

Resolves: tdf#115923 try a different approach to solving tdf#46637

Try scrolling to the cell the mouse is over if its not fully visible already
and this is not autofill selection. To avoid the mouse over the autofill 
handle
which overflows into neighbours scrolling the neighbour cell into view 
before
its truly desired to be selected when the mouse passes the center point

in other words, for autofill go back to how it always was

Change-Id: I6f67ad0f49c2d4087949f71f38322f06ced13c79
Reviewed-on: https://gerrit.libreoffice.org/51392
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/view/select.cxx b/sc/source/ui/view/select.cxx
index f06043c79276..fcfe6eddf1c5 100644
--- a/sc/source/ui/view/select.cxx
+++ b/sc/source/ui/view/select.cxx
@@ -321,13 +321,28 @@ bool ScViewFunctionSet::SetCursorAtPoint( const Point& 
rPointPixel, bool /* bDon
  pEngine->GetWindow(),
  nullptr, false);
 
-bool bBottomScroll = ( aEditArea.Bottom() >= aWinSize.Height() );
-bool bRightScroll  = ( aEditArea.Right() >= aWinSize.Width() );
+bool bFillingSelection = pViewData->IsFillMode() || 
pViewData->GetFillMode() == ScFillMode::MATRIX;
+bool bBottomScroll;
+bool bRightScroll;
+// for Autofill don't yet assume we want to auto-scroll to the cell under 
the mouse
+// because the autofill handle extends into a cells neighbours so initial 
click is usually
+// above a neighbour cell
+if (bFillingSelection)
+{
+bBottomScroll = aEffPos.X() >= aWinSize.Height();
+bRightScroll  = aEffPos.Y() >= aWinSize.Width();
+}
+else
+{
+//in the normal case make the full selected cell visible
+bBottomScroll = aEditArea.Bottom() >= aWinSize.Height();
+bRightScroll  = aEditArea.Right() >= aWinSize.Width();
+}
+
 bool bScroll = bRightScroll || bBottomScroll || bLeftScroll || bTopScroll;
 
-// for Autofill switch in the center of cell
-// thereby don't prevent scrolling to bottom/right
-if ( pViewData->IsFillMode() || pViewData->GetFillMode() == 
ScFillMode::MATRIX )
+// for Autofill switch in the center of cell thereby don't prevent 
scrolling to bottom/right
+if (bFillingSelection)
 {
 bool bLeft, bTop;
 pViewData->GetMouseQuadrant( aEffPos, GetWhich(), nPosX, nPosY, bLeft, 
bTop );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116431] New: Make the string "LibreOffice (Safe Mode)" translatable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116431

Bug ID: 116431
   Summary: Make the string "LibreOffice (Safe Mode)" translatable
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: scootergri...@gmail.com

In Windows 7 i see the string "LibreOffice (Safe Mode)" used for the short cut
to start LibreOffice from the Start menu.

I would like to translate this string.
At least the "Safe Mode" part.

The comment for the short cut is translated. Here is the source string:
"LibreOffice, the office productivity suite provided by The Document
Foundation. See http://www.documentfoundation.org;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sdext/source

[Noel Grandin]

 sdext/source/pdfimport/tree/drawtreevisiting.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit b0967c69d3e08efbc8e3dec807601ac52870792a
Author: Noel Grandin 
Date:   Fri Mar 16 13:16:23 2018 +0200

fix crash on pdf import of tdf59883-2

after
commit a9ef943769b06e6bdffe7326f288b27e08a95698
Date:   Wed Feb 28 11:09:43 2018 +0200
loplugin:useuniqueptr in sdext

Change-Id: I3f54002764ee42162279bade49a3e3b21e136917
Reviewed-on: https://gerrit.libreoffice.org/51402
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx 
b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
index 81c2a945366e..d1cbab6fb215 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
@@ -458,7 +458,6 @@ void DrawXmlOptimizer::visit( PolyPolyElement& elem, const 
std::list< std::uniqu
 #else
 elem.Parent->Children.erase(next_it);
 #endif
-delete pNext;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: unoidl/source

[Stephan Bergmann]

 unoidl/source/sourceprovider-parser.y |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba2166ab40b58279da2aeb700c23d49515eb640f
Author: Stephan Bergmann 
Date:   Fri Mar 16 16:18:45 2018 +0100

Typo in error message

Change-Id: Ia56a47b46989027588afc291bf8f82299903cdaa

diff --git a/unoidl/source/sourceprovider-parser.y 
b/unoidl/source/sourceprovider-parser.y
index b558a4ccfc29..529d2045a273 100644
--- a/unoidl/source/sourceprovider-parser.y
+++ b/unoidl/source/sourceprovider-parser.y
@@ -1699,7 +1699,7 @@ interfaceAttribute:
   error(
   @2, yyscanner,
   ("interface attribute can only be flagged as [attribute,"
-   " optional]"));
+   " bound, readonly]"));
   YYERROR;
   }
   switch (t.type) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/OperationSmiley' - include/svx svx/source

[Armin Le Grand]

 include/svx/svdopath.hxx   |2 +-
 svx/source/svdraw/svdopath.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a27e59fac897937f914976a5a563a1c572ccbe44
Author: Armin Le Grand 
Date:   Fri Mar 16 16:16:54 2018 +0100

OperationSmiley: Removed unused param from SdrPathObj constructor

Change-Id: Ia69e822c698ea13650d868472ba63744727ff886

diff --git a/include/svx/svdopath.hxx b/include/svx/svdopath.hxx
index fac63b375fb8..e32ccf5116df 100644
--- a/include/svx/svdopath.hxx
+++ b/include/svx/svdopath.hxx
@@ -63,7 +63,7 @@ private:
 
 public:
 SdrPathObj(SdrObjKind eNewKind);
-SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& rPathPoly, 
double dBrightness = 0.0);
+SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& rPathPoly);
 virtual ~SdrPathObj() override;
 
 virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
diff --git a/svx/source/svdraw/svdopath.cxx b/svx/source/svdraw/svdopath.cxx
index 2935164da771..5cf8dd58c115 100644
--- a/svx/source/svdraw/svdopath.cxx
+++ b/svx/source/svdraw/svdopath.cxx
@@ -1634,7 +1634,7 @@ SdrPathObj::SdrPathObj(SdrObjKind eNewKind)
 bClosedObj = IsClosed();
 }
 
-SdrPathObj::SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& 
rPathPoly, double dBrightness)
+SdrPathObj::SdrPathObj(SdrObjKind eNewKind, const basegfx::B2DPolyPolygon& 
rPathPoly)
 :   maPathPolygon(rPathPoly),
 meKind(eNewKind)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

settings.xml config items

[Michael Stahl]

in case anybody wonders what all the config items in settings.xml do, i
just remembered i had this spreadsheet laying around (this isn't news to
anybody who reads the office tc list).

https://people.freedesktop.org/~mst/LibreOffice_settings.xml_config-items.ods

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Are we interested in bugs in Tools > Customize... ?

[Ted Lee]

On 3/16/18 3:10 AM, Ilmari Lauhakangas wrote:


The reset thing is a known bug from OOo era: 
https://bugs.documentfoundation.org/show_bug.cgi?id=35030


Here is a collection of bugs & enhancements related to the dialog: 
https://bugs.documentfoundation.org/showdependencytree.cgi?id=103238_resolved=1 



Do go through them and report any missing ones, including those related 
to help files.


Thanks.  I have to admit I hadn't yet searched the buglist regarding 
this -- had I done so I probably would have answered my own question.


--
Ted
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: https://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-commits] core.git: sw/source

[Caolán McNamara]

 sw/source/filter/ww8/ww8scan.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 5b71268f33af179c241f2c9d76d69f25e97a05f7
Author: Caolán McNamara 
Date:   Fri Mar 16 10:09:21 2018 +

ofz#6950 Integer-overflow

Change-Id: I56d8da7d6f376744803153b29d1dfe638e10b001
Reviewed-on: https://gerrit.libreoffice.org/51398
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 380c2c8f1fba..f6b4a84a3a8f 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1501,12 +1501,18 @@ WW8_CP WW8ScannerBase::WW8Fc2Cp( WW8_FC nFcPos ) const
 SAL_WARN("sw.ww8", "broken offset, ignoring");
 return WW8_CP_MAX;
 }
-if (nFcPos < nFcStart + nLen)
+WW8_FC nFcEnd;
+if (o3tl::checked_add(nFcStart, nLen, nFcEnd))
+{
+SAL_WARN("sw.ww8", "broken offset, ignoring");
+return WW8_CP_MAX;
+}
+if (nFcPos < nFcEnd)
 {
 m_pPieceIter->SetIdx( nOldPos );
 return nTempCp;
 }
-else if (nFcPos == nFcStart + nLen)
+else if (nFcPos == nFcEnd)
 {
 //Keep this cp as its on a piece boundary because we might
 //need it if tests fail
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa writerfilter/source

[Serge Krot]

 sw/qa/extras/ooxmlimport/data/tdf113182.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |8 
 writerfilter/source/dmapper/DomainMapper.cxx |7 ++-
 3 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit be02ce71f2ee694fa2609a7a630853c24acfbfff
Author: Serge Krot 
Date:   Fri Mar 16 10:42:50 2018 +0100

tdf#113182: DOCX filter: new values of wrap property in text box

Added support of "none" and "through" values of the w:wrap
poroperty in the text box.

Change-Id: I83f0c9e8162e93bf457f228d49d3b426050d4dc6
Reviewed-on: https://gerrit.libreoffice.org/51396
Tested-by: Jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlimport/data/tdf113182.docx 
b/sw/qa/extras/ooxmlimport/data/tdf113182.docx
new file mode 100755
index ..9f35ec3d4ebc
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf113182.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 6e181a87a9b9..5563ce56dc1f 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -1558,6 +1558,14 @@ DECLARE_OOXMLIMPORT_TEST(testTdf112443, "tdf112443.docx")
 
 }
 
+// DOCX: Textbox wrap differs in MSO and LO
+// Both should layout text regardless of existing text box
+// and as result only one page should be generated.
+DECLARE_OOXMLIMPORT_TEST(testTdf113182, "tdf113182.docx")
+{
+CPPUNIT_ASSERT_EQUAL(getPages(), 1);
+}
+
 DECLARE_OOXMLIMPORT_TEST(testTdf113946, "tdf113946.docx")
 {
 OUString aTop = 
parseDump("/root/page/body/txt/anchored/SwAnchoredDrawObject/bounds", "top");
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 310bf761f3b7..6219b7c672e1 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -868,11 +868,16 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 //should be either LN_Value_doc_ST_Wrap_notBeside or 
LN_Value_doc_ST_Wrap_around or LN_Value_doc_ST_Wrap_auto
 OSL_ENSURE( sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_around ||
 sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_notBeside ||
+sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_through ||
+sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_none ||
 sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_auto,
-"wrap not around, not_Beside or auto?");
+"wrap not around, not_Beside, through, none or 
auto?");
 if( sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_around ||
+sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_through ||
 sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_auto )
 pParaProperties->SetWrap ( 
text::WrapTextMode_DYNAMIC ) ;
+else if (sal::static_int_cast(nIntValue) == 
NS_ooxml::LN_Value_doc_ST_Wrap_none)
+pParaProperties->SetWrap ( 
text::WrapTextMode_THROUGH ) ;
 else
 pParaProperties->SetWrap ( text::WrapTextMode_NONE 
) ;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116429] Undoing after adding a shape only undoes " Change object name of Shape to 'Shape 1'"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116429

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
Version|6.0.1.1 release |5.3.0.3 release
   Keywords||bibisectRequest, regression
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
Summary|You can cancel renaming an  |Undoing after adding a
   |object after adding it  |shape only undoes "Change
   ||object name of Shape to
   ||'Shape 1'"
   Severity|normal  |minor
 OS|Windows (All)   |All

--- Comment #1 from Buovjaga  ---
Repro, but not yet in 5.0.2.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 15th 2018

5.3.0 and 5.0.2 on Win 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116430] when opening print dialog, Orca gets bogus indexes from accessibility stack

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116430

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
NEW per Joanmarie being involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36549] [META] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK and GNOME Orca screen reader support

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36549

Alex ARNAUD  changed:

   What|Removed |Added

 Depends on||116430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116430
[Bug 116430] when opening print dialog, Orca gets bogus indexes from
accessibility stack
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116430] when opening print dialog, Orca gets bogus indexes from accessibility stack

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116430

Alex ARNAUD  changed:

   What|Removed |Added

   Keywords||accessibility
 Blocks||36549


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=36549
[Bug 36549] [META] ACCESSIBILITY: Tracking bug for issues affecting a11y ATK
and GNOME Orca screen reader support
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116427] Microsoft Word document doc file not showing correctly in Write Formatting Table Viewing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116427

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest,
   ||filter:doc, regression
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
Version|6.0.2.1 release |4.4.7.2 release
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #3 from Buovjaga  ---
I get 6 pages even in read-only mode. Page 2 is (nearly) blank. The blank page
is already in 4.4.7.2.

3.6.7 does not show the blank page. There is a little pagination glitch as when
you open it, the page count shows 9 very briefly. This is better seen in 3.6.7.

Please also attach a PDF from Microsoft Office.

Adding bibisectrequest so we will know when the extra page 2 appeared.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 15th 2018

Arch Linux 64-bit
Version 3.6.7.2 (Build ID: e183d5b)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: framework/source

[Noel Grandin]

 framework/source/uiconfiguration/ImageList.cxx |9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

New commits:
commit 1a4fcb7feac223e9384a2b91fc6db8a16a5dbe78
Author: Noel Grandin 
Date:   Fri Mar 16 12:57:57 2018 +0200

simplify ImageList::GetAsHorizontalStrip

no need to repeat logic the BitmapEx constructor already implements

Change-Id: Ic958b3a3baafe9911b8461e1fc512e36616db89c
Reviewed-on: https://gerrit.libreoffice.org/51401
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 

diff --git a/framework/source/uiconfiguration/ImageList.cxx 
b/framework/source/uiconfiguration/ImageList.cxx
index 3e39b08f45f8..575cfd8de6c6 100644
--- a/framework/source/uiconfiguration/ImageList.cxx
+++ b/framework/source/uiconfiguration/ImageList.cxx
@@ -74,14 +74,7 @@ BitmapEx ImageList::GetAsHorizontalStrip() const
 }
 
 BitmapEx aTempl = mpImplData->maImages[ 0 ]->maBitmapEx;
-BitmapEx aResult;
-Bitmap aPixels( aSize, aTempl.GetBitmap().GetBitCount() );
-if( aTempl.IsAlpha() )
-aResult = BitmapEx( aPixels, AlphaMask( aSize ) );
-else if( aTempl.IsTransparent() )
-aResult = BitmapEx( aPixels, Bitmap( aSize, 
aTempl.GetMask().GetBitCount() ) );
-else
-aResult = BitmapEx( aPixels );
+BitmapEx aResult( aTempl, Point(), aSize );
 
 tools::Rectangle aSrcRect( Point( 0, 0 ), mpImplData->maImageSize );
 for (sal_uInt16 nIdx = 0; nIdx < nCount; nIdx++)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116422] Index lexical

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116422

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Please attach an example document.
This kind of sounds like a user support question better suited for
http://ask.libreoffice.org/ but let's see.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116418] FILEOPEN: PPT: Incorrect text size when using TextFitToSize

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116418

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

GSOC

[Shubham Verma]

Hi everyone,
I am Shubham Verma , pursuing Bachelors of Technology at Delhi
Technological University. I am currently in junior year and very much
interested in software development . Particularly I am a C++ enthusiast and
have done many projects using it and also use it as my primary language in
competitive programming.

I have been using Libreoffice for a long time and started to contribute to
it more than a month ago. I am very much interested in contributing to "100
paper cuts" and now I am working on some of the problems mentioned in that
list . Besides I have successfully submitted 3 patches and working on the
fourth one.

Any help or insight would be appreciated.

Thanks
Shubham Verma
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 116420] Error when I try to open an Document in a Sharepoint WebDAV directory ( # is not allowed in a filename)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116420

Buovjaga  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com,
   ||todven...@suomi24.fi
Summary|Error when I try to open an |Error when I try to open an
   |Document in a Sharepoint|Document in a Sharepoint
   |WebDAV directory|WebDAV directory (# is not
   ||allowed in a filename)

--- Comment #1 from Buovjaga  ---
Gábor: can you confirm this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src loleaflet/unocommands.js

[Pranav Kant]

 loleaflet/src/control/Control.Menubar.js |3 +++
 loleaflet/unocommands.js |1 +
 2 files changed, 4 insertions(+)

New commits:
commit 18fa0d7a7853c7131aef4db80376d07fe1862b10
Author: Pranav Kant 
Date:   Tue Mar 13 15:30:37 2018 +0530

Insert Charts menu items

Change-Id: Ic542210477ab0a401be25b35e91cc9deefec75a9

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index d72e6f999..90da54a95 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -65,6 +65,7 @@ L.Control.Menubar = L.Control.extend({
{name: _UNO('.uno:InsertMenu', 'text'), type: 'menu', 
menu: [
{name: _UNO('.uno:InsertGraphic', 'text'), id: 
'insertgraphic', type: 'action'},
{name: _UNO('.uno:InsertAnnotation', 'text'), 
id: 'insertcomment', type: 'action'},
+   {uno: '.uno:InsertObjectChart'},
{type: 'separator'},
{name: _UNO('.uno:InsertField', 'text'), type: 
'menu', menu: [
{uno: '.uno:InsertPageNumberField'},
@@ -256,6 +257,7 @@ L.Control.Menubar = L.Control.extend({
{name: _UNO('.uno:InsertMenu', 'presentation'), type: 
'menu', menu: [
{name: _UNO('.uno:InsertGraphic', 
'presentation'), id: 'insertgraphic', type: 'action'},
{name: _UNO('.uno:InsertAnnotation', 
'presentation'), id: 'insertcomment', type: 'action'},
+   {uno: '.uno:InsertObjectChart'},
{type: 'separator'},
{uno: '.uno:HyperlinkDialog'},
{type: 'separator'},
@@ -330,6 +332,7 @@ L.Control.Menubar = L.Control.extend({
]},
{name: _UNO('.uno:InsertMenu', 'spreadsheet'), type: 
'menu', menu: [
{name: _UNO('.uno:InsertGraphic', 
'spreadsheet'), id: 'insertgraphic', type: 'action'},
+   {uno: '.uno:InsertObjectChart'},
{name: _UNO('.uno:InsertAnnotation', 
'spreadsheet'), id: 'insertcomment', type: 'action'},
{type: 'separator'},
{uno: '.uno:InsertSymbol'}
diff --git a/loleaflet/unocommands.js b/loleaflet/unocommands.js
index 2a41c046e..65fe8ca00 100644
--- a/loleaflet/unocommands.js
+++ b/loleaflet/unocommands.js
@@ -103,6 +103,7 @@ var unoCommandsArray = {
InsertMenu:{global:{menu:_('~Insert'),},},
InsertNeutralParagraph:{text:{menu:_('Insert Unnumbered Entry'),},},
InsertNonBreakingSpace:{global:{menu:_('~Non-breaking space'),},},
+   InsertObjectChart:{global:{menu:_('~Chart...')}},
InsertPageCountField:{text:{menu:_('Page ~Count'),},},
InsertPageFooter:{text:{menu:_('Foote~r'),},},
InsertPageHeader:{text:{menu:_('He~ader'),},},
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116412] Bundled python fails to import bz2 on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116412

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #1 from Buovjaga  ---
Repro.

Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116411] Navigator's Page Next randomly stops paging; Navigator' s Previous Page always pages correctly.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116411

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|6.0.2.1 release |3.5.0 release
   Keywords||preBibisect, regression
 CC||todven...@suomi24.fi
 Blocks||103030
 Ever confirmed|0   |1
   Severity|normal  |minor
 OS|Linux (All) |All

--- Comment #1 from Buovjaga  ---
(In reply to russell from comment #0)
> Actual Results:  
> Test 1: Problem: Page Next - starting on Page 1

I tried with a blank document from scratch, 7 pages with Ctrl-enter.
Latest version stops at page 4.
3.3 has no problem.
3.5.0 already has the problem (stops at page 2).

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on March 15th 2018

Arch Linux 64-bit
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Win 10
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Buovjaga  changed:

   What|Removed |Added

 Depends on||116411


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116411
[Bug 116411] Navigator's Page Next randomly stops paging; Navigator's Previous
Page always pages correctly.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116325] Crash when typing a non existent directory in installer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116325

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Buovjaga  ---
No crash for me, also runs fine:
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 2537d6897ae516d3b4d50f0e2885dc24949841bf
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-16_02:34:17
Locale: fi-FI (fi_FI); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116264] UI: No buttons shown in dialogs like " Error saving the document" (with a locked file)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116264

--- Comment #12 from Caolán McNamara  ---
The error string itself has trailing newlines which is where the space is
coming from

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #6 from Daniel Grigoras  ---
(In reply to Buovjaga from comment #5)

6.1 alpha generates the PDF faster than 6.0 alpha.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/bin

[Stephan Bergmann]

 solenv/bin/modules/installer.pm |   31 +---
 solenv/bin/modules/installer/scriptitems.pm |9 +---
 2 files changed, 21 insertions(+), 19 deletions(-)

New commits:
commit f07e2496963baf8f7c0fecc79e7a420544075d98
Author: Stephan Bergmann 
Date:   Fri Mar 16 14:21:01 2018 +0100

sdk/lib dir missing from Linux installation sets

...after cfd2691e5bf398304d7816227b933e53907b6204 "[API CHANGE] Remove 
salcpprt
static library" had removed the sole regular File item from gid_Dir_Lib_Sdk,
leaving only Unixlink items.  But the solenv/bin/modules/installer.pm code 
used
to only auto-create any directories that contain regular Files.  Changed 
that to
also consider Unixlinks in addition to regular Files.

And to add insult to injury, the code in
solenv/bin/modules/installer/simplepackage.pm creating the actual symlinks
represented by the Unixlink items silently does nothing when a symlink 
cannot be
created (because the partent dir is missing).  To be fixed in another 
follow-up
commit.

Change-Id: Ic7a682a17ac59c789c85c56c825dd623bc59428c

diff --git a/solenv/bin/modules/installer.pm b/solenv/bin/modules/installer.pm
index cd72284c5bc8..b11e55b09077 100644
--- a/solenv/bin/modules/installer.pm
+++ b/solenv/bin/modules/installer.pm
@@ -632,6 +632,18 @@ sub run {
 
 
installer::scpzipfiles::resolving_scpzip_replace_flag($filesinproductlanguageresolvedarrayref,
 $allvariableshashref, "File", $languagestringref);
 
+#
+# language dependent unix links part
+#
+
+installer::logger::print_message( "... analyzing unix links ...\n" );
+
+my $unixlinksinproductlanguageresolvedarrayref = 
installer::scriptitems::resolving_all_languages_in_productlists($unixlinksinproductarrayref,
 $languagesarrayref);
+
+
installer::scriptitems::changing_name_of_language_dependent_keys($unixlinksinproductlanguageresolvedarrayref);
+
+
installer::scriptitems::get_Destination_Directory_For_Item_From_Directorylist($unixlinksinproductlanguageresolvedarrayref,
 $dirsinproductarrayref);
+
 
 # Collecting directories for epm list file
 
@@ -645,8 +657,7 @@ sub run {
 # It will be possible, that in the setup script only those directoies 
have to be defined,
 # that have a CREATE flag. All other directories are created, if they 
contain at least one file.
 
-my ($directoriesforepmarrayref, $alldirectoryhash) = 
installer::scriptitems::collect_directories_from_filesarray($filesinproductlanguageresolvedarrayref);
-
+my ($directoriesforepmarrayref, $alldirectoryhash) = 
installer::scriptitems::collect_directories_from_filesarray($filesinproductlanguageresolvedarrayref,
 $unixlinksinproductlanguageresolvedarrayref);
 ($directoriesforepmarrayref, $alldirectoryhash) = 
installer::scriptitems::collect_directories_with_create_flag_from_directoryarray($dirsinproductlanguageresolvedarrayref,
 $alldirectoryhash);
 
 #
@@ -686,18 +697,6 @@ sub run {
 
installer::scriptitems::resolve_links_with_flag_relative($linksinproductlanguageresolvedarrayref);
 
 #
-# language dependent unix links part
-#
-
-installer::logger::print_message( "... analyzing unix links ...\n" );
-
-my $unixlinksinproductlanguageresolvedarrayref = 
installer::scriptitems::resolving_all_languages_in_productlists($unixlinksinproductarrayref,
 $languagesarrayref);
-
-
installer::scriptitems::changing_name_of_language_dependent_keys($unixlinksinproductlanguageresolvedarrayref);
-
-
installer::scriptitems::get_Destination_Directory_For_Item_From_Directorylist($unixlinksinproductlanguageresolvedarrayref,
 $dirsinproductarrayref);
-
-#
 # language dependent part for profiles and profileitems
 #
 
@@ -810,7 +809,7 @@ sub run {
 @{$folderitemsinproductlanguageresolvedarrayref} = (); # no 
folderitems in languagepacks
 
 # Collecting the directories again, to include only the language 
specific directories
-($directoriesforepmarrayref, $alldirectoryhash) = 
installer::scriptitems::collect_directories_from_filesarray($filesinproductlanguageresolvedarrayref);
+($directoriesforepmarrayref, $alldirectoryhash) = 
installer::scriptitems::collect_directories_from_filesarray($filesinproductlanguageresolvedarrayref,
 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sd/qa

[Pranav Kant]

 sd/qa/unit/tiledrendering/tiledrendering.cxx |   16 
 1 file changed, 16 insertions(+)

New commits:
commit b8f1795a9136b4ab8e5fa6e62d86a2b113699a46
Author: Pranav Kant 
Date:   Fri Mar 16 18:07:52 2018 +0530

sd lok: guard all tests with lok flag

This was also the cause of one of the test failure in sd
after 263790b806794a69d8f13f470e6a1933a9ebe53c

Change-Id: I2a85faf416dad19c8aa8f544b54c7b84e49a8f96
Reviewed-on: https://gerrit.libreoffice.org/51418
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 73e1e2e629bc..2e879f56cf4f 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -326,6 +326,7 @@ xmlDocPtr SdTiledRenderingTest::parseXmlDump()
 
 void SdTiledRenderingTest::testRegisterCallback()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 
pViewShell->GetViewShellBase().registerLibreOfficeKitViewCallback(::callback,
 this);
@@ -341,6 +342,7 @@ void SdTiledRenderingTest::testRegisterCallback()
 CPPUNIT_ASSERT(!m_aInvalidation.IsEmpty());
 Rectangle aTopLeft(0, 0, 256*15, 256*15); // 1 px = 15 twips, assuming 96 
DPI.
 CPPUNIT_ASSERT(m_aInvalidation.IsOver(aTopLeft));
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testPostKeyEvent()
@@ -410,6 +412,7 @@ void SdTiledRenderingTest::testPostMouseEvent()
 
 void SdTiledRenderingTest::testSetTextSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 
xDrawPage(pXImpressDocument->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
 uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
@@ -434,10 +437,12 @@ void SdTiledRenderingTest::testSetTextSelection()
 pXImpressDocument->setTextSelection(LOK_SETTEXTSELECTION_END, aEnd.getX(), 
aEnd.getY());
 // The new selection must include the ending dot, too -- but not the first 
word.
 CPPUNIT_ASSERT_EQUAL(OUString("bbb."), rEditView.GetSelected());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testGetTextSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 
xDrawPage(pXImpressDocument->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
 uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
@@ -458,10 +463,12 @@ void SdTiledRenderingTest::testGetTextSelection()
 
 // Make sure returned RTF is not empty.
 CPPUNIT_ASSERT(!OString(pXImpressDocument->getTextSelection("text/rtf", 
aUsedFormat)).isEmpty());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testSetGraphicSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("shape.odp");
 sd::ViewShell* pViewShell = 
pXImpressDocument->GetDocShell()->GetViewShell();
 SdPage* pPage = pViewShell->GetActualPage();
@@ -491,10 +498,13 @@ void SdTiledRenderingTest::testSetGraphicSelection()
 // Check that a resize happened, but aspect ratio is not kept.
 CPPUNIT_ASSERT_EQUAL(aShapeBefore.getWidth(), aShapeAfter.getWidth());
 CPPUNIT_ASSERT(aShapeBefore.getHeight() < aShapeAfter.getHeight());
+
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testUndoShells()
 {
+comphelper::LibreOfficeKit::setActive();
 // Load a document and set the page size.
 SdXImpressDocument* pXImpressDocument = createDoc("shape.odp");
 uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence(
@@ -512,10 +522,12 @@ void SdTiledRenderingTest::testUndoShells()
 sal_Int32 nView1 = SfxLokHelper::getView();
 // This was -1, SdUndoGroup did not track what view shell created it.
 CPPUNIT_ASSERT_EQUAL(nView1, 
pUndoManager->GetUndoAction()->GetViewShellId());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 void SdTiledRenderingTest::testResetSelection()
 {
+comphelper::LibreOfficeKit::setActive();
 SdXImpressDocument* pXImpressDocument = createDoc("dummy.odp");
 uno::Reference 
xDrawPage(pXImpressDocument->getDrawPages()->getByIndex(0), uno::UNO_QUERY);
 uno::Reference xShape(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
@@ -536,6 +548,7 @@ void SdTiledRenderingTest::testResetSelection()
 // Now use resetSelection() to reset the selection.
 pXImpressDocument->resetSelection();
 CPPUNIT_ASSERT(!pView->GetTextEditObject());
+comphelper::LibreOfficeKit::setActive(false);
 }
 
 static void lcl_search(const OUString& rKey, bool bFindAll 

[Libreoffice-bugs] [Bug 116430] New: when opening print dialog, Orca gets bogus indexes from accessibility stack

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116430

Bug ID: 116430
   Summary: when opening print dialog, Orca gets bogus indexes
from accessibility stack
   Product: LibreOffice
   Version: 6.0.2.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: samuel.thiba...@ens-lyon.org

Description:
Libreoffice reports bogus indexes to the accessibility stack when the print
dialog gets opened, making Orca lost in the dialog box.

Steps to Reproduce:
1) Open LibreOffice Writer
2) Press ctrl+p to open the Print dialog


Actual Results:  
Orca announces only "print frame"


Expected Results:
Orca should announce where it is precisely (Range and Copies panel, Number of
copies Text), which would happen fine if indexes were right.



Reproducible: Always


User Profile Reset: No



Additional Info:
What Joanmarie found is that when Orca looks a the newly-opened print dialog,
the activated field ("number of copies") returns a bogus -1 as index in parent.
Looking at it a bit later, the index is correct (1). So I guess there is some
kind of race between the notification of the new dialog and widgets, and the
actual complete construction of the dialog box.

I tried to remove in vcl/source/window/printdlg.cxx's PrintDialog::PrintDialog
the following lines:

maJobPage.mpCopyCountField->GrabFocus();
maJobPage.mpCopyCountField->SetSelection( Selection(0, 0x) );

and replace with True in
vcl/uiconfig/ui/printdialog.ui to keep the "focus on open" behavior, but the
issue in Orca remains the same, so I guess the problem is deeper than just
that.


User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116425] FILEOPEN XLSX Excel spreadsheet takes forever and a lot of CPU time to open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116425

clogged.drainp...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1

--- Comment #3 from clogged.drainp...@gmail.com ---
(In reply to m.a.riosv from comment #2)
> Created attachment 140661 [details]
> Cleaned spreadsheet
> 
> There is a lot of unused cell with direct format, cleaning it the
> spreadsheet opens fine.
> 
> btw the sheet it's protected.
> 
> Resolved as works for me, please if you are not agree, reopen it.

I have no idea how to clean unused cells with direct format, could you write
down how you did it please? (or link a tutorial/guide?)

I also disagree that this is not a bug.
LibreOffice should be fully compatible with MS Office, and thus not being able
to open some files that MS Office can open without problems is a huge issue.
Ordinary users should never be forced to file a bug report. My mother run into
this problem (she has no MS Office on her computer), and she was in complete
despair, because she had no idea what went wrong and how to fix it or get
information. Issues like this one completely ruin the usability of LO for
noobs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Pranav Kant]

 chart2/source/controller/main/ChartController_Window.cxx |9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

New commits:
commit eb76e16abba16d88acd342779a8216dd64d60955
Author: Pranav Kant 
Date:   Thu Mar 15 16:48:18 2018 +0530

chart2 lok: tunnel context menu of the chart edit view

Change-Id: I0c8b3cfe1666ad81f808871a87e4b0fa64ef593c
Reviewed-on: https://gerrit.libreoffice.org/51345
Tested-by: Jenkins 
Reviewed-by: pranavk 

diff --git a/chart2/source/controller/main/ChartController_Window.cxx 
b/chart2/source/controller/main/ChartController_Window.cxx
index e3df574732de..83dfc4a1a0c0 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -58,15 +58,16 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
 
 #include 
 
+#include 
 #include 
 #include 
-
 #include 
 #include 
 #include 
@@ -1253,6 +1254,12 @@ void ChartController::execute_Command( const 
CommandEvent& rCEvt )
 if ( !xPopupController.is() || !xPopupMenu.is() )
 return;
 
+if (comphelper::LibreOfficeKit::isActive())
+{
+PopupMenu* pPopupMenu = 
static_cast(VCLXMenu::GetImplementation(xPopupMenu)->GetMenu());
+pPopupMenu->SetLOKNotifier(SfxViewShell::Current());
+}
+
 xPopupController->setPopupMenu( xPopupMenu );
 xPopupMenu->execute( css::uno::Reference< css::awt::XWindowPeer >( 
m_xFrame->getContainerWindow(), css::uno::UNO_QUERY ),
  css::awt::Rectangle( aPos.X(), aPos.Y(), 0, 0 ),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Buovjaga  ---
I tried with the upcoming 6.0.3 on Windows and it was fairly quick. I was
actually going to bisect the issue as you said it was fast in 6.0.0.0 alpha0.
Let's close.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113397] Global menu does not work with KDE Plasma 5.9 +

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113397

Heiko Tietze  changed:

   What|Removed |Added

 CC||tietze.he...@gmail.com

--- Comment #9 from Heiko Tietze  ---
@Xisco: I think we should raise the importance (and set it as bug) because the
global app menu is a primary feature for KDE users and the issue is reported
several times.

https://bugs.kde.org/show_bug.cgi?id=391868 (more info in the referenced forum
post)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source cui/source cui/uiconfig include/svx sc/source sd/source sw/source vcl/unx

[Caolán McNamara]

 chart2/source/controller/main/ShapeController.cxx |3 -
 cui/source/dialogs/dlgname.cxx|   33 +++---
 cui/source/factory/dlgfact.cxx|   13 +++--
 cui/source/factory/dlgfact.hxx|   11 +++-
 cui/source/inc/dlgname.hxx|   14 ++
 cui/uiconfig/ui/objecttitledescdialog.ui  |   15 --
 include/svx/svxdlg.hxx|2 
 sc/source/ui/drawfunc/drawsh5.cxx |4 +
 sd/source/ui/view/DocumentRenderer.cxx|3 -
 sd/source/ui/view/drawview.cxx|3 -
 sd/source/ui/view/drviews2.cxx|   51 +++---
 sd/source/ui/view/drviews4.cxx|3 -
 sd/source/ui/view/drviewse.cxx|   19 +++-
 sd/source/ui/view/sdview4.cxx |3 -
 sd/source/ui/view/viewshe2.cxx|3 -
 sw/source/uibase/dochdl/gloshdl.cxx   |5 --
 sw/source/uibase/shells/drwbassh.cxx  |6 +-
 sw/source/uibase/shells/frmsh.cxx |7 +--
 sw/source/uibase/shells/grfsh.cxx |4 -
 sw/source/uibase/shells/tabsh.cxx |   14 ++
 sw/source/uibase/uiview/view2.cxx |   21 +++--
 vcl/unx/gtk3/gtk3gtkinst.cxx  |9 +++
 22 files changed, 111 insertions(+), 135 deletions(-)

New commits:
commit fc86c38e4424f1e098c4422ee28fb0f106ce8558
Author: Caolán McNamara 
Date:   Fri Mar 16 09:29:50 2018 +

weld SvxObjectTitleDescDialog

Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160
Reviewed-on: https://gerrit.libreoffice.org/51395
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/chart2/source/controller/main/ShapeController.cxx 
b/chart2/source/controller/main/ShapeController.cxx
index fd4c8a6fb488..0fbb314ace5e 100644
--- a/chart2/source/controller/main/ShapeController.cxx
+++ b/chart2/source/controller/main/ShapeController.cxx
@@ -426,8 +426,9 @@ void 
ShapeController::executeDispatch_ObjectTitleDescription()
 SvxAbstractDialogFactory* pFact = 
SvxAbstractDialogFactory::Create();
 if ( pFact )
 {
+VclPtr pChartWindow( 
m_pChartController->GetChartWindow() );
 ScopedVclPtr< AbstractSvxObjectTitleDescDialog > pDlg(
-pFact->CreateSvxObjectTitleDescDialog( aTitle, 
aDescription ) );
+pFact->CreateSvxObjectTitleDescDialog(pChartWindow ? 
pChartWindow->GetFrameWeld() : nullptr, aTitle, aDescription ) );
 if ( pDlg.get() && ( pDlg->Execute() == RET_OK ) )
 {
 pDlg->GetTitle( aTitle );
diff --git a/cui/source/dialogs/dlgname.cxx b/cui/source/dialogs/dlgname.cxx
index 3e9eb3d0d78b..148c7374df95 100644
--- a/cui/source/dialogs/dlgname.cxx
+++ b/cui/source/dialogs/dlgname.cxx
@@ -79,37 +79,22 @@ IMPL_LINK_NOARG(SvxObjectNameDialog, ModifyHdl, 
weld::Entry&, void)
 // #i68101#
 // Dialog for editing Object Title and Description
 
-SvxObjectTitleDescDialog::SvxObjectTitleDescDialog(
-vcl::Window* pWindow,
-const OUString& rTitle,
-const OUString& rDescription) :
-ModalDialog ( pWindow, "ObjectTitleDescDialog", 
"cui/ui/objecttitledescdialog.ui" )
+SvxObjectTitleDescDialog::SvxObjectTitleDescDialog(weld::Window* pParent, 
const OUString& rTitle,
+const OUString& rDescription)
+: GenericDialogController(pParent, "cui/ui/objecttitledescdialog.ui", 
"ObjectTitleDescDialog")
+, m_xEdtTitle(m_xBuilder->weld_entry("object_title_entry"))
+, m_xEdtDescription(m_xBuilder->weld_text_view("desc_entry"))
 {
-get(pEdtTitle, "object_title_entry");
-get(pEdtDescription, "desc_entry");
 //lock height to initial height
-
pEdtDescription->set_height_request(pEdtDescription->get_preferred_size().Height());
+m_xEdtDescription->set_size_request(-1, 
m_xEdtDescription->get_text_height() * 5);
 // set title & desc
-pEdtTitle->SetText(rTitle);
-pEdtDescription->SetText(rDescription);
+m_xEdtTitle->set_text(rTitle);
+m_xEdtDescription->set_text(rDescription);
 
 // activate title
-pEdtTitle->SetSelection(Selection(SELECTION_MIN, SELECTION_MAX));
+m_xEdtTitle->select_region(0, -1);
 }
 
-SvxObjectTitleDescDialog::~SvxObjectTitleDescDialog()
-{
-disposeOnce();
-}
-
-void SvxObjectTitleDescDialog::dispose()
-{
-pEdtTitle.clear();
-pEdtDescription.clear();
-ModalDialog::dispose();
-}
-
-
 /*
 |*
 |* dialog for cancelling, saving or adding
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 33abcf354fea..2683c93264b3 100644
--- 

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0-3' - chart2/qa chart2/source include/oox oox/source

[Szymon Kłos]

 chart2/qa/extras/chart2export.cxx  |   11 +++
 chart2/qa/extras/data/pptx/tdf116163.pptx  |binary
 chart2/source/view/axes/VAxisProperties.hxx|2 
 chart2/source/view/axes/VCartesianAxis.cxx |   50 +
 chart2/source/view/axes/VCartesianCoordinateSystem.cxx |2 
 chart2/source/view/axes/VCartesianCoordinateSystem.hxx |3 -
 chart2/source/view/axes/VCoordinateSystem.cxx  |1 
 chart2/source/view/axes/VPolarCoordinateSystem.cxx |1 
 chart2/source/view/axes/VPolarCoordinateSystem.hxx |3 -
 chart2/source/view/inc/VCoordinateSystem.hxx   |3 -
 chart2/source/view/main/ChartView.cxx  |2 
 include/oox/export/chartexport.hxx |2 
 oox/source/export/chartexport.cxx  |   20 +-
 13 files changed, 92 insertions(+), 8 deletions(-)

New commits:
commit 1032bf3925f4e51ab65c083d2bd921448bebe5e2
Author: Szymon Kłos 
Date:   Fri Mar 2 10:39:33 2018 +0100

tdf#116163: Limit label height in chart if needed

Change-Id: Ia84fd0c3b76886bc6124dc3b59035465aa31b020
Reviewed-on: https://gerrit.libreoffice.org/50700
Tested-by: Jenkins 
Reviewed-by: Szymon Kłos 
(cherry picked from commit 35d062f7879d5414334643cb90bff411726b2168)
Reviewed-on: https://gerrit.libreoffice.org/51409
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/chart2/qa/extras/chart2export.cxx 
b/chart2/qa/extras/chart2export.cxx
index 4b21f18f7248..9b9e75c868c2 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -102,6 +102,7 @@ public:
 void testAxisTitleRotationXLSX();
 void testAxisCrossBetweenXSLX();
 void testNumberFormatExportPPTX();
+void testTdf116163();
 
 CPPUNIT_TEST_SUITE(Chart2ExportTest);
 CPPUNIT_TEST(testErrorBarXLSX);
@@ -168,6 +169,7 @@ public:
 CPPUNIT_TEST(testAxisTitleRotationXLSX);
 CPPUNIT_TEST(testAxisCrossBetweenXSLX);
 CPPUNIT_TEST(testNumberFormatExportPPTX);
+CPPUNIT_TEST(testTdf116163);
 CPPUNIT_TEST_SUITE_END();
 
 protected:
@@ -1573,6 +1575,15 @@ void Chart2ExportTest::testNumberFormatExportPPTX()
 assertXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:barChart/c:ser/c:dLbls/c:numFmt", 
"sourceLinked", "0");
 }
 
+void Chart2ExportTest::testTdf116163()
+{
+load("/chart2/qa/extras/data/pptx/", "tdf116163.pptx");
+xmlDocPtr pXmlDoc = parseExport("ppt/charts/chart", "Impress MS PowerPoint 
2007 XML");
+CPPUNIT_ASSERT(pXmlDoc);
+
+assertXPath(pXmlDoc, 
"/c:chartSpace/c:chart/c:plotArea/c:catAx/c:txPr/a:bodyPr", "rot", "-540");
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Chart2ExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/chart2/qa/extras/data/pptx/tdf116163.pptx 
b/chart2/qa/extras/data/pptx/tdf116163.pptx
new file mode 100644
index ..5fbee8304a52
Binary files /dev/null and b/chart2/qa/extras/data/pptx/tdf116163.pptx differ
diff --git a/chart2/source/view/axes/VAxisProperties.hxx 
b/chart2/source/view/axes/VAxisProperties.hxx
index 20f648d4fe8d..9a10c94f4719 100644
--- a/chart2/source/view/axes/VAxisProperties.hxx
+++ b/chart2/source/view/axes/VAxisProperties.hxx
@@ -137,6 +137,8 @@ struct AxisProperties final
 css::uno::Reference 
m_xAxisTextProvider; //for categories or series names
 //<- category axes
 
+boolm_bLimitSpaceForLabels;
+
 //methods:
 
 AxisProperties( const css::uno::Reference< css::chart2::XAxis >& xAxisModel
diff --git a/chart2/source/view/axes/VCartesianAxis.cxx 
b/chart2/source/view/axes/VCartesianAxis.cxx
index 9493102a93c4..5e702f85dbed 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -74,6 +74,53 @@ VCartesianAxis::~VCartesianAxis()
 m_pPosHelper = nullptr;
 }
 
+void lcl_ResizeTextShapeToFitAvailableSpace( Reference< drawing::XShape >& 
xShape2DText,
+ const AxisLabelProperties& 
rAxisLabelProperties,
+ const OUString& rLabel,
+ const tNameSequence& rPropNames,
+ const tAnySequence& rPropValues )
+{
+uno::Reference< text::XTextRange > xTextRange( xShape2DText, 
uno::UNO_QUERY );
+
+if( !xTextRange.is() )
+return;
+
+const sal_Int32 nFullHeight = 
rAxisLabelProperties.m_aFontReferenceSize.Height;
+
+if( !nFullHeight || !rLabel.getLength() )
+return;
+
+sal_Int32 nMaxLabelsHeight = nFullHeight - 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Height - 
rAxisLabelProperties.m_aMaximumSpaceForLabels.Y;
+const sal_Int32 nAvgCharWidth = xShape2DText->getSize().Width / 

[Libreoffice-commits] core.git: sc/inc sc/source

[Noel Grandin]

 sc/inc/dpsave.hxx |   23 -
 sc/source/core/data/dpsave.cxx|   96 ++
 sc/source/filter/xml/xmldpimp.cxx |   13 ++---
 sc/source/filter/xml/xmldpimp.hxx |2 
 sc/source/ui/view/dbfunc3.cxx |   11 +---
 5 files changed, 60 insertions(+), 85 deletions(-)

New commits:
commit 04caeef4fdb84d792f967e661073c8ba81d931b2
Author: Noel Grandin 
Date:   Thu Mar 15 16:56:51 2018 +0200

loplugin:useuniqueptr in ScDPSaveDimension

Change-Id: I169a8eff540c866958da37c25a03550542433f16
Reviewed-on: https://gerrit.libreoffice.org/51372
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/dpsave.hxx b/sc/inc/dpsave.hxx
index b88b08161495..4ba46fc0f1b5 100644
--- a/sc/inc/dpsave.hxx
+++ b/sc/inc/dpsave.hxx
@@ -105,18 +105,17 @@ private:
 bool bRepeatItemLabels; //! at level
 bool bSubTotalDefault; //! at level
 std::vector maSubTotalFuncs;
-css::sheet::DataPilotFieldReference* pReferenceValue;
-css::sheet::DataPilotFieldSortInfo* pSortInfo; // (level)
-css::sheet::DataPilotFieldAutoShowInfo* pAutoShowInfo; // (level)
-css::sheet::DataPilotFieldLayoutInfo* pLayoutInfo; // (level)
+std::unique_ptr pReferenceValue;
+std::unique_ptr pSortInfo; // (level)
+std::unique_ptr pAutoShowInfo; // 
(level)
+std::unique_ptr pLayoutInfo; // 
(level)
 
 public:
 typedef std::unordered_set MemberSetType;
-typedef std::unordered_map  MemberHash;
-typedef std::list  MemberList;
+typedef std::vector MemberList;
 
 private:
-MemberHash maMemberHash;
+std::unordered_map maMemberHash;
 MemberList maMemberList;
 
 public:
@@ -129,7 +128,7 @@ public:
 const MemberList& GetMembers() const
 { return maMemberList; }
 
-void AddMember(ScDPSaveMember* pMember);
+void AddMember(std::unique_ptr pMember);
 
 void SetDupFlag(bool bSet)
 { bDupFlag = bSet; }
@@ -180,20 +179,20 @@ public:
 bool IsMemberNameInUse(const OUString& rName) const;
 
 const css::sheet::DataPilotFieldReference* GetReferenceValue() const
-{ return pReferenceValue; }
+{ return pReferenceValue.get(); }
 
 void SetReferenceValue(const css::sheet::DataPilotFieldReference* pNew);
 
 const css::sheet::DataPilotFieldSortInfo* GetSortInfo() const
-{ return pSortInfo; }
+{ return pSortInfo.get(); }
 
 void SetSortInfo(const css::sheet::DataPilotFieldSortInfo* pNew);
 const css::sheet::DataPilotFieldAutoShowInfo* GetAutoShowInfo() const
-{ return pAutoShowInfo; }
+{ return pAutoShowInfo.get(); }
 
 void SetAutoShowInfo(const css::sheet::DataPilotFieldAutoShowInfo* pNew);
 const css::sheet::DataPilotFieldLayoutInfo* GetLayoutInfo() const
-{ return pLayoutInfo; }
+{ return pLayoutInfo.get(); }
 
 void SetLayoutInfo(const css::sheet::DataPilotFieldLayoutInfo* pNew);
 
diff --git a/sc/source/core/data/dpsave.cxx b/sc/source/core/data/dpsave.cxx
index 834c1e7df3e4..a07908a223c6 100644
--- a/sc/source/core/data/dpsave.cxx
+++ b/sc/source/core/data/dpsave.cxx
@@ -223,26 +223,18 @@ ScDPSaveDimension::ScDPSaveDimension(const 
ScDPSaveDimension& r) :
 for (MemberList::const_iterator i=r.maMemberList.begin(); i != 
r.maMemberList.end() ; ++i)
 {
 const OUString& rName =  (*i)->GetName();
-ScDPSaveMember* pNew = new ScDPSaveMember( **i );
-maMemberHash[rName] = pNew;
-maMemberList.push_back( pNew );
+std::unique_ptr pNew(new ScDPSaveMember( **i ));
+maMemberList.push_back( pNew.get() );
+maMemberHash[rName] = std::move(pNew);
 }
 if (r.pReferenceValue)
-pReferenceValue = new sheet::DataPilotFieldReference( 
*(r.pReferenceValue) );
-else
-pReferenceValue = nullptr;
+pReferenceValue.reset( new sheet::DataPilotFieldReference( 
*(r.pReferenceValue) ) );
 if (r.pSortInfo)
-pSortInfo = new sheet::DataPilotFieldSortInfo( *(r.pSortInfo) );
-else
-pSortInfo = nullptr;
+pSortInfo.reset( new sheet::DataPilotFieldSortInfo( *(r.pSortInfo) ) );
 if (r.pAutoShowInfo)
-pAutoShowInfo = new sheet::DataPilotFieldAutoShowInfo( 
*(r.pAutoShowInfo) );
-else
-pAutoShowInfo = nullptr;
+pAutoShowInfo.reset( new sheet::DataPilotFieldAutoShowInfo( 
*(r.pAutoShowInfo) ) );
 if (r.pLayoutInfo)
-pLayoutInfo = new sheet::DataPilotFieldLayoutInfo( *(r.pLayoutInfo) );
-else
-pLayoutInfo = nullptr;
+pLayoutInfo.reset(new sheet::DataPilotFieldLayoutInfo( 
*(r.pLayoutInfo) ));
 if (r.mpLayoutName)
 mpLayoutName.reset(new OUString(*r.mpLayoutName));
 if (r.mpSubtotalName)
@@ -251,12 +243,11 @@ ScDPSaveDimension::ScDPSaveDimension(const 
ScDPSaveDimension& r) :
 

[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-6.0.3.1-buildfix1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.3.1-buildfix1' created by Christian Lohmaier 
 at 2018-03-16 12:03 +

Tag libreoffice-6.0.3.1-buildfix1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaq7KbAAoJEPQ0oe+v7q6jZc4P/1wwIrwnH26IAkEYZiCL4lAV
ntayL6yL+MCz2Y3HQMmk6QgasXmoLOIQXWzSZ/1rTU8mO12s21c+OpMz6+OliEd6
w3u2nL7RiA+s2aWu2jSAste4jpl+Ly/av+5Jq7sea4FKHAHoSDtpS+t/P0JcBgdn
ze4ptrt2n530EqsIqHqhMiArdqIFFE9jnyRVFfgFMziYmIMqdS0K0E0XmlhSgym7
G79kI3npN7aHy7pt4B2OpIc+oUlH1Ro+BgeZDbrpP4JWsKVFNR36UxK2ltpG/aRY
P4/68sQmaiLXK/KGrvw4flIALfejR8J+4vz3njA2WQSLzYXhCek7S3StzDYoAGy8
BEE8nbDG0RKOgQPgzWRXIa6VuO3EZvSB36Z+IifsTe/s5J1HPegx2kBC/KF1kiv+
bcNr1wkOWAcbWbdTHKmdKyD6A0hpTtINZ1iAVoNCELLdHgaXDutFECqhRI+uXSLv
O8yyu1bJXp+yOjFNPM+q5THMrQyhu/fxxFUYNzN2DiS15b76FxWvnvYAHzV4qqJZ
3QmnawhttEzqTqVy4WzXqfTJLMTXzaAXN99TIveo+qe0hC4rF5YoTxIAkpcVnvG+
S7gZYGZhEzB+9CLYK//GCT1QH+spzwQTiTiksJIxYj4I+Q83y6hT3G9aX6LL9SZH
mW69ZcY25xu0rNHNGs8M
=U99w
-END PGP SIGNATURE-

Changes since libreoffice-6.0.3.1:
Christian Lohmaier (1):
  Version 6.0.3.1, tag libreoffice-6.0.3.1-buildfix1

---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-6.0.3.1-buildfix1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.3.1-buildfix1' created by Christian Lohmaier 
 at 2018-03-16 12:03 +

Tag libreoffice-6.0.3.1-buildfix1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaq7KfAAoJEPQ0oe+v7q6jwXQP/A/Nu/w0rrHqcvdgb/kGolse
9Vy1VC4sDOUt3tAhZZoYMhFq8OcKtb9PcxmiIVMN3B2tYBRhQs5f5+pAwa1/YMGP
VRxoQtLNeM186eY7ZvS8A30PUq/jFUGb+lQ9Km7Z+FO3egClme7IF3VRDOJcwdF8
4CXyapunct7oD32B82MLA6DKn8NmOmjJy76V+bpPYSqr1lw1Y3+v3p/tniAAA1//
Cp5at4+1gmj7f8b/DidnCt91Jah4huc1vTd3PO9ZGRNCP5fpRm5Prfh8PqPS6Or1
xELmfi646cHDTC2xxZrQHeRrjV0xOPk11wqQJqWCcbdS9Exp/+bcVAtALkqsjPE8
JVrO0HwSrqIyr6NQXGWBmtm02NP8Q8Juy+QdduZeAIddE9MFxJAAmutMNKyTcWRC
nv7kvcctH0pf3p81ZLCcPzjc0bpYchzUzlfdERHGPUBeOkmisyegfQu9HpJtWCV9
6cFRWlQTMY07Weyp3L6tpYfYbhpOgdi7UZEH0RakXmvpwOb4RphzKdi8xQFflF38
7iK60R+IYteoo+GuhEiTnq/8dS212HPpaodoFE8lCbvaSasA5Y1tUMarzyu3bzl3
KfbOMhZQX4zeGT8rElBq4pkIoxRyEVvKCrgeV0QKNZyIFLibfX3pnC0rXI8YaMMn
UnXVjcP0sHBHHfYECx5S
=3nfB
-END PGP SIGNATURE-

Changes since libreoffice-6.0.3.1-1:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-6.0.3.1-buildfix1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.3.1-buildfix1' created by Christian Lohmaier 
 at 2018-03-16 12:03 +

Tag libreoffice-6.0.3.1-buildfix1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaq7KWAAoJEPQ0oe+v7q6jsEQQAIzVvgVj6MTmnT4NrpK+fAqb
DmIeIFjrF+nadIiK9fzolB3LhOE1edCNqS1aOYgCRxDE3fWQ1NMAJnOWL4aO4Q/k
/nH9VwobG3PpyDHyvsEjs5oAhw2d17FGoiOyOGCukwIeuMo7Bb9f4idUMBC69Re2
Db9507z1QwU7acIvPrZz7RR/4r6dxI3yQiMX9g6Xk8BN2HJeIE9M+gBJhIOvXGtZ
xlaDgnx9N7xk8ovdRqmvVYhR17PSy6P8CK2E4ztSGxUAmgNoP2mMRF2xxlH0Ll6d
Xu7FjG4GRjCYg5lVLEJv1yakb9m3KU6nuz/LR+OSYVtIiDPQL6UakmhPh4Rk8+Mo
TDLmuDOVJT1oRjv0+0wUkWgOQghit6FGQGaIjT8h6z9NDsQQKvY9jAZ6LFDniCFv
BIUlAmA5H2rpwPrx+2e0AWsJJGrMDN1nTSdUr6EGcG+zBQ9Yn8IwUF96dJ+DQrFp
1EAkPHCfslkevKc7qXAnODqdsIK6iCylNpe3jty0+V3UGAffEpD2mI8NNUqzZNhl
g76Z8WUPpamWZ3lsgAZZhK9ygU1ivNcAN6gXJ6Yc8BpVIejSZz/IP4mRuWkGM0dd
7dJzfp5FZEn31n1+M4mdQaEuHgoxFdjlRVA3tvJTolPbgR5QfCG4HqZh0r2rqRbY
WiUxkoAtsfNCCB3bPavt
=RmNP
-END PGP SIGNATURE-

Changes since libreoffice-6.0.3.1:
Christian Lohmaier (1):
  Version 6.0.3.1, tag libreoffice-6.0.3.1-buildfix1

---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-6.0.3.1-buildfix1'

[Christian Lohmaier]

Tag 'libreoffice-6.0.3.1-buildfix1' created by Christian Lohmaier 
 at 2018-03-16 12:03 +

Tag libreoffice-6.0.3.1-buildfix1
-BEGIN PGP SIGNATURE-

iQIcBAABAgAGBQJaq7KZAAoJEPQ0oe+v7q6jOfsP/jUnUUP3VYj+ytcDkTIU+j0T
0MbR4hdgMGhej39/AqZbMe8lW3PwSDEFZMaHDsa7DGA8YbIg2hNK+iKTeJZ3wgzr
FWEPw3zM8LQiQ4PXAQfjpxY38zX3gTb7pa7TXQ0icvUKM8QCCHCIMjA0E+5CVD2U
xbERJBvKloCwLkY6ey9jxhkVOOXgql3jQVdS82wEVkx+x/xNRbLcqLgpFoBsdOBY
jcX5mn6o4BUixj57DV6Aoc+5LjdI0GjZBN510Xo8CN5opGFKp9WKsvWnNKet7O8B
/hAnCqzsbQlX2bJKt7DNIICKD7qisY+yAyHELcZjpI79y9zojaIys/jjpcgsGPj/
dy8c281DbwIdVn1NsGVhuAK5O4ZgLbifj8pjDG64f1teLv96jeT+Eue6v198XhIP
Hp8+NkVcbOewq+Mq+ycQ65jbgr8pik1VOj0HuI9gq+0skyW2Wj40aXEawAM6Okxj
ye26GjDfipAm2haIGScbAYExQHciDTw4Kyn3h3wjRFcw/lT/jb0e5GaaICC20GTa
ITWy6JdKrt7M8Ttda0oKRcjjGgjg2yEyaiP+cl0gMWHgoCS9crfseelY8M1QgV0J
wfIBlGY/BcM26uY54Rt2PMiXULkNRAgALFd6TfgecX2OKvaWEkNNyWsJnDe/cPif
yoFLos5leiIEF3ITEaCF
=XNcU
-END PGP SIGNATURE-

Changes since libreoffice-6.0.3.1:
Christian Lohmaier (1):
  Version 6.0.3.1, tag libreoffice-6.0.3.1-buildfix1

---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 71843] Missing "Surround header" and "Surround footer" Page Border options in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=71843

--- Comment #14 from Luis Felipe Marzagao  ---
This issue is still present in LibreOffice version 6.0.2.1

Versão: 6.0.2.1
ID de compilação: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
Threads da CPU:1; SO:Windows 10.0; Realizador da interface: padrão; 
Local: pt-BR (pt_BR); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/osx

[Stephan Bergmann]

 vcl/osx/salmenu.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f7069aaa2aac8e120a21cba3905a513b194364ca
Author: Stephan Bergmann 
Date:   Fri Mar 16 12:27:36 2018 +0100

Simplify code

...avoiding loplugin:salunicodeliteral and loplugin:stringconstant

Change-Id: I560682ac87b24f47fc16a6ef17232c7fbc8c9099

diff --git a/vcl/osx/salmenu.cxx b/vcl/osx/salmenu.cxx
index 922a6035d37b..9122f54c456c 100644
--- a/vcl/osx/salmenu.cxx
+++ b/vcl/osx/salmenu.cxx
@@ -653,8 +653,8 @@ void AquaSalMenu::SetItemText( unsigned /*i_nPos*/, 
SalMenuItem* i_pSalMenuItem,
 }
 }
 
-if (aText.endsWith("..."))
-aText = aText.copy(0, aText.getLength()-3) + 
OUString(sal_Unicode(0x2026));
+if (aText.endsWith("...", ))
+aText += u"\u2026";
 
 NSString* pString = CreateNSString( aText );
 if (pString)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 9 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

--- Comment #11 from Xisco Faulí  ---
Previous commit reverted in https://gerrit.libreoffice.org/#/c/51403/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 9 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3660

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 9 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #10 from Xisco Faulí  ---
OMG, it points back to me :D

Regression introduced by:

author  Xisco Fauli    2017-11-16 00:47:09 +0100
committer   Tamás Zolnai    2017-11-17
15:01:54 +0100
commit  605b01dc591eaa72788be255baf1f9b9dde76414 (patch)
tree146d1aac2dbe932f16ecaa1d3fce3f5c9e452c8c
parent  328cdfd4a75f5e29c3a1b3ba4ee0ed9475603442 (diff)
tdf#113660: show Master Slide label in handout view

Bisected with: bibisect-linux64-6.0

Adding Cc: to Xisco Fauli

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104311] Scroll works on touch pad but not on mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104311

tommy27  changed:

   What|Removed |Added

Summary|Scroll works on touch pad   |Scroll works on touch pad
   |but not on mouse.   |but not on mouse

--- Comment #9 from tommy27  ---
@zweifel

please retest with 6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 9 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

Xisco Faulí  changed:

   What|Removed |Added

Summary|Hang under specific |Hang under specific
   |circumstances ( steps in|circumstances ( steps in
   |comment 6 ) |comment 9 )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 6 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

--- Comment #9 from Xisco Faulí  ---
Actually, I've found a reliable way of reproducing it...

1. Launch Impress
2. Ignore the Wizard
3. Select Master Slides Deck in the sidebar
4. Switch View: View -> Master Handout
5. Click on the Date Area on the document
6. Select the Properties deck in the sidebar
7. Click somewhere else on the document...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/svx include/vcl svx/source sw/source vcl/source

[Noel Grandin]

 include/svx/xoutbmp.hxx |2 --
 include/vcl/outdev.hxx  |3 ---
 svx/source/dialog/graphctl.cxx  |   20 +---
 svx/source/xoutdev/_xoutbmp.cxx |   12 
 sw/source/core/view/viewsh.cxx  |8 
 vcl/source/filter/graphicfilter.cxx |   10 ++
 vcl/source/outdev/outdev.cxx|7 ---
 7 files changed, 7 insertions(+), 55 deletions(-)

New commits:
commit 494f565506013015d9ce4a3010eb3b211557d70f
Author: Noel Grandin 
Date:   Fri Mar 16 10:37:12 2018 +0200

don't bother dithering for 256bit displays

which surely are a minority by now

Also drop the GetColorCount() method on OutputDevice and clean up the
remaining call sites to use GetBitCount()

Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40
Reviewed-on: https://gerrit.libreoffice.org/51389
Reviewed-by: Michael Meeks 
Tested-by: Jenkins 

diff --git a/include/svx/xoutbmp.hxx b/include/svx/xoutbmp.hxx
index 23249ffb94a1..0f7ae80d95b2 100644
--- a/include/svx/xoutbmp.hxx
+++ b/include/svx/xoutbmp.hxx
@@ -75,8 +75,6 @@ public:
const tools::Rectangle* pWorkRect );
 };
 
-SVX_DLLPUBLIC bool DitherBitmap( Bitmap& rBitmap );
-
 #endif // INCLUDED_SVX_XOUTBMP_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index ff90e3fb40da..e2cec1c195dd 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -464,9 +464,6 @@ public:
 SizeGetOutputSize() const
 { return PixelToLogic( 
GetOutputSizePixel() ); }
 
-sal_uLong   GetColorCount() const;
-
-
 css::uno::Reference< css::awt::XGraphics >
 CreateUnoGraphics();
 std::vector< VCLXGraphics* > *GetUnoGraphicsList() const  { return 
mpUnoGraphicsList; }
diff --git a/svx/source/dialog/graphctl.cxx b/svx/source/dialog/graphctl.cxx
index 30a856a2780a..ac285f0d8305 100644
--- a/svx/source/dialog/graphctl.cxx
+++ b/svx/source/dialog/graphctl.cxx
@@ -163,25 +163,7 @@ void GraphCtrl::InitSdrModel()
 
 void GraphCtrl::SetGraphic( const Graphic& rGraphic, bool bNewModel )
 {
-// If possible we dither bitmaps for the display
-if ( rGraphic.GetType() == GraphicType::Bitmap  )
-{
-if ( rGraphic.IsTransparent() )
-{
-Bitmap  aBmp( rGraphic.GetBitmap() );
-
-DitherBitmap( aBmp );
-aGraphic = Graphic( BitmapEx( aBmp, 
rGraphic.GetBitmapEx().GetMask() ) );
-}
-else
-{
-Bitmap aBmp( rGraphic.GetBitmap() );
-DitherBitmap( aBmp );
-aGraphic = aBmp;
-}
-}
-else
-aGraphic = rGraphic;
+aGraphic = rGraphic;
 
 if ( aGraphic.GetPrefMapMode().GetMapUnit() == MapUnit::MapPixel )
 aGraphSize = Application::GetDefaultDevice()->PixelToLogic( 
aGraphic.GetPrefSize(), aMap100 );
diff --git a/svx/source/xoutdev/_xoutbmp.cxx b/svx/source/xoutdev/_xoutbmp.cxx
index a6e072197e8c..edc9e0a228f2 100644
--- a/svx/source/xoutdev/_xoutbmp.cxx
+++ b/svx/source/xoutdev/_xoutbmp.cxx
@@ -666,16 +666,4 @@ tools::Polygon XOutBitmap::GetContour( const Bitmap& rBmp, 
const XOutFlags nFlag
 return aRetPoly;
 }
 
-bool DitherBitmap( Bitmap& rBitmap )
-{
-bool bRet = false;
-
-if( ( rBitmap.GetBitCount() >= 8 ) && ( 
Application::GetDefaultDevice()->GetColorCount() < 257 ) )
-bRet = rBitmap.Dither( BmpDitherFlags::Floyd );
-else
-bRet = false;
-
-return bRet;
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index 533e20d26a78..7c536e86117f 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -1223,19 +1223,19 @@ bool SwViewShell::SmoothScroll( long lXDiff, long 
lYDiff, const tools::Rectangle
 #if !defined(MACOSX) && !defined(ANDROID) && !defined(IOS)
 // #i98766# - disable smooth scrolling for Mac
 
-const sal_uLong nColCnt = mpOut->GetColorCount();
+const sal_uLong nBitCnt = mpOut->GetBitCount();
 long lMult = 1, lMax = LONG_MAX;
-if ( nColCnt == 65536 )
+if ( nBitCnt == 16 )
 {
 lMax = 7000;
 lMult = 2;
 }
-if ( nColCnt == 16777216 )
+if ( nBitCnt == 24 )
 {
 lMax = 5000;
 lMult = 6;
 }
-else if ( nColCnt == 1 )
+else if ( nBitCnt == 1 )
 {
 lMax = 3000;
 lMult = 12;
diff --git a/vcl/source/filter/graphicfilter.cxx 
b/vcl/source/filter/graphicfilter.cxx
index 115bc476782d..273e500a0806 100644
--- a/vcl/source/filter/graphicfilter.cxx
+++ b/vcl/source/filter/graphicfilter.cxx
@@ -1936,7 +1936,7 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& 
rGraphic, const OUString& r
 if( eType != 

[Libreoffice-bugs] [Bug 114363] TOC: Index update causes entries to duplicate if ToC created from Outline and Additional heading styles (in a specific document)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114363

--- Comment #16 from Jens Troeger  ---
Is there any progress update on this problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - desktop/inc desktop/source

[Michael Meeks]

 desktop/inc/app.hxx |2 ++
 desktop/source/lib/init.cxx |8 
 2 files changed, 10 insertions(+)

New commits:
commit 8ddd878ed3f00e0bc7455f40baa120d303560341
Author: Michael Meeks 
Date:   Wed Mar 14 17:12:57 2018 +

Allow lok to re-set temporary paths on second init.

Change-Id: I40cd0538b573c2d090f56424e1110b938981a878
Reviewed-on: https://gerrit.libreoffice.org/51292
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 
(cherry picked from commit 005abf983d34042a7ced46d886f8ef2250cb3fce)
Reviewed-on: https://gerrit.libreoffice.org/51296
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx
index 91dde49439ab..9ea716fc3e3f 100644
--- a/desktop/inc/app.hxx
+++ b/desktop/inc/app.hxx
@@ -130,9 +130,11 @@ class Desktop : public Application
 css::uno::Reference< 
css::uno::XComponentContext > const & context);
 static void DeregisterServices();
 
+public:
 static void CreateTemporaryDirectory();
 static void RemoveTemporaryDirectory();
 
+private:
 static bool InitializeConfiguration();
 static void FlushConfiguration();
 static bool InitializeQuickstartMode( const 
css::uno::Reference< css::uno::XComponentContext >& rxContext );
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 45cd0a0c18b2..25b66ab08480 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -92,6 +92,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -3746,6 +3747,13 @@ static int lo_initialize(LibreOfficeKit* pThis, const 
char* pAppPath, const char
 
 if (eStage != PRE_INIT)
 {
+SAL_INFO("lok", "Re-initialize temp paths");
+SvtPathOptions aOptions;
+OUString aNewTemp;
+osl::FileBase::getTempDirURL(aNewTemp);
+aOptions.SetTempPath(aNewTemp);
+desktop::Desktop::CreateTemporaryDirectory();
+
 SAL_INFO("lok", "Enabling RequestHandler");
 RequestHandler::Enable(false);
 SAL_INFO("lok", "Starting soffice_main");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/source include/vcl toolkit/source vcl/source

[Noel Grandin]

 framework/source/fwe/classes/imagewrapper.cxx |   19 +++
 include/vcl/BitmapTools.hxx   |2 ++
 toolkit/source/awt/vclxbitmap.cxx |5 ++---
 vcl/source/bitmap/BitmapTools.cxx |   20 
 4 files changed, 27 insertions(+), 19 deletions(-)

New commits:
commit e568d233a3f9cbc926bfa12dac3fbc6d29a4b6c7
Author: Noel Grandin 
Date:   Fri Mar 16 09:51:44 2018 +0200

move framework/toolkit use of BitmapEx::GetMask inside vcl

Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943
Reviewed-on: https://gerrit.libreoffice.org/51387
Reviewed-by: Michael Meeks 
Tested-by: Noel Grandin 

diff --git a/framework/source/fwe/classes/imagewrapper.cxx 
b/framework/source/fwe/classes/imagewrapper.cxx
index f916d7a4e607..bb7b65a622fa 100644
--- a/framework/source/fwe/classes/imagewrapper.cxx
+++ b/framework/source/fwe/classes/imagewrapper.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -74,22 +75,8 @@ Sequence< sal_Int8 > SAL_CALL ImageWrapper::getDIB()
 Sequence< sal_Int8 > SAL_CALL ImageWrapper::getMaskDIB()
 {
 SolarMutexGuard aGuard;
-BitmapExaBmpEx( m_aImage.GetBitmapEx() );
-
-if ( aBmpEx.IsAlpha() )
-{
-SvMemoryStream aMem;
-WriteDIB(aBmpEx.GetAlpha().GetBitmap(), aMem, false, true);
-return Sequence< sal_Int8 >( static_cast(aMem.GetData()), aMem.Tell() );
-}
-else if ( aBmpEx.IsTransparent() )
-{
-SvMemoryStream aMem;
-WriteDIB(aBmpEx.GetMask(), aMem, false, true);
-return Sequence< sal_Int8 >( static_cast(aMem.GetData()), aMem.Tell() );
-}
-
-return Sequence< sal_Int8 >();
+
+return vcl::bitmap::GetMaskDIB(m_aImage.GetBitmapEx());
 }
 
 // XUnoTunnel
diff --git a/include/vcl/BitmapTools.hxx b/include/vcl/BitmapTools.hxx
index 6ff484a82d9c..3a1692730393 100644
--- a/include/vcl/BitmapTools.hxx
+++ b/include/vcl/BitmapTools.hxx
@@ -96,6 +96,8 @@ VCL_DLLPUBLIC void DrawAlphaBitmapAndAlphaGradient(BitmapEx & 
rBitmapEx, bool bF
 
 VCL_DLLPUBLIC void DrawAndClipBitmap(const Point& rPos, const Size& rSize, 
const BitmapEx& rBitmap, BitmapEx & aBmpEx, basegfx::B2DPolyPolygon const & 
rClipPath);
 
+VCL_DLLPUBLIC css::uno::Sequence< sal_Int8 > GetMaskDIB(BitmapEx const & 
aBmpEx);
+
 }} // end vcl::bitmap
 
 #endif // INCLUDED_VCL_BITMAP_TOOLS_HXX
diff --git a/toolkit/source/awt/vclxbitmap.cxx 
b/toolkit/source/awt/vclxbitmap.cxx
index da0f08382a36..c8f531df3951 100644
--- a/toolkit/source/awt/vclxbitmap.cxx
+++ b/toolkit/source/awt/vclxbitmap.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 //  class VCLXBitmap
@@ -72,9 +73,7 @@ css::uno::Sequence< sal_Int8 > VCLXBitmap::getMaskDIB()
 {
 ::osl::Guard< ::osl::Mutex > aGuard( GetMutex() );
 
-SvMemoryStream aMem;
-WriteDIB(maBitmap.GetMask(), aMem, false, true);
-return css::uno::Sequence( static_cast(aMem.GetData()), aMem.Tell() );
+return vcl::bitmap::GetMaskDIB(maBitmap);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/bitmap/BitmapTools.cxx 
b/vcl/source/bitmap/BitmapTools.cxx
index 366c6be37af0..3abd1ca537b9 100644
--- a/vcl/source/bitmap/BitmapTools.cxx
+++ b/vcl/source/bitmap/BitmapTools.cxx
@@ -22,6 +22,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -628,6 +629,25 @@ void DrawAndClipBitmap(const Point& rPos, const Size& 
rSize, const BitmapEx& rBi
 }
 }
 
+
+css::uno::Sequence< sal_Int8 > GetMaskDIB(BitmapEx const & aBmpEx)
+{
+if ( aBmpEx.IsAlpha() )
+{
+SvMemoryStream aMem;
+WriteDIB(aBmpEx.GetAlpha().GetBitmap(), aMem, false, true);
+return css::uno::Sequence< sal_Int8 >( static_cast(aMem.GetData()), aMem.Tell() );
+}
+else if ( aBmpEx.IsTransparent() )
+{
+SvMemoryStream aMem;
+WriteDIB(aBmpEx.GetMask(), aMem, false, true);
+return css::uno::Sequence< sal_Int8 >( static_cast(aMem.GetData()), aMem.Tell() );
+}
+
+return css::uno::Sequence< sal_Int8 >();
+}
+
 }} // end vcl::bitmap
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - wsd/LOOLWSD.cpp

[Michael Meeks]

 wsd/LOOLWSD.cpp |8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 3bb885ab369f6850c4fb9baf155b0bd0dc566126
Author: Michael Meeks 
Date:   Thu Mar 15 19:17:17 2018 +

Help OSL's nlsupport with a UTF-8 locale for everyone.

Change-Id: I98557e3134b436b6360129dfd6d16bba811cd864
Reviewed-on: https://gerrit.libreoffice.org/51394
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 89f698db9..2118a0dd2 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2703,11 +2703,9 @@ int LOOLWSD::innerMain()
 
 initializeSSL();
 
-char* locale = setlocale(LC_ALL, nullptr);
-if (locale == nullptr || std::strcmp(locale, "C") == 0)
-{
-setlocale(LC_ALL, "en_US.utf8");
-}
+// Force a uniform UTF-8 locale for ourselves & our children.
+::setenv("LC_ALL", "en_US.UTF-8", 1);
+setlocale(LC_ALL, "en_US.UTF-8");
 
 if (access(Cache.c_str(), R_OK | W_OK | X_OK) != 0)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3' - common/Util.cpp common/Util.hpp kit/Kit.cpp

[Michael Meeks]

 common/Util.cpp |   24 
 common/Util.hpp |3 +++
 kit/Kit.cpp |4 
 3 files changed, 31 insertions(+)

New commits:
commit 582b16170deda857247de44f14c1d70a3f4112d6
Author: Michael Meeks 
Date:   Wed Mar 14 15:46:52 2018 +

Use a hard random /tmp directory for document intermediates.

Requires a lok tweak to reset the tmpdir globals on init.

Change-Id: I602705f20fa016ef415088be8d1ada6d465d2a8d
Reviewed-on: https://gerrit.libreoffice.org/51378
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/common/Util.cpp b/common/Util.cpp
index b9ca5951c..b0d87b7d3 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -116,6 +116,30 @@ namespace Util
 }
 }
 
+static std::string getDefaultTmpDir()
+{
+const char *tmp = getenv("TMPDIR");
+if (!tmp)
+tmp = getenv("TEMP");
+if (!tmp)
+tmp = getenv("TMP");
+if (!tmp)
+tmp = "/tmp";
+return tmp;
+}
+
+std::string createRandomTmpDir()
+{
+std::string defaultTmp = getDefaultTmpDir();
+std::string newTmp =
+defaultTmp + "/lool-" + rng::getFilename(16);
+if (::mkdir(newTmp.c_str(), S_IRWXU) < 0) {
+LOG_ERR("Failed to create random temp directory");
+return defaultTmp;
+}
+return newTmp;
+}
+
 // close what we have - far faster than going up to a 1m open_max eg.
 static bool closeFdsFromProc()
 {
diff --git a/common/Util.hpp b/common/Util.hpp
index b4c59f981..64aa8bf57 100644
--- a/common/Util.hpp
+++ b/common/Util.hpp
@@ -42,6 +42,9 @@ namespace Util
 std::string getFilename(const size_t length);
 }
 
+/// Create randomized temporary directory
+std::string createRandomTmpDir();
+
 /// Spawn a process if stdInput is non-NULL it contains a writable 
descriptor
 /// to send data to the child.
 int spawnProcess(const std::string , const std::vector 
,
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index d1bbdbedf..b99d7e413 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2075,6 +2075,10 @@ void lokit_main(const std::string& childRoot,
 instdir_path = "/" + loTemplate + "/program";
 }
 
+// hard-random tmpdir inside the jail / root
+std::string tmpSubdir = Util::createRandomTmpDir();
+::setenv("TMPDIR", tmpSubdir.c_str(), 1);
+
 {
 const char *instdir = instdir_path.c_str();
 const char *userdir = userdir_url.c_str();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 6 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

--- Comment #8 from Xisco Faulí  ---
I can reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

but not in

Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

bisecting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116364] Hang under specific circumstances ( steps in comment 6 )

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116364

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|Hang under specific |Hang under specific
   |circumstances   |circumstances ( steps in
   ||comment 6 )

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116400] Very time lengthy PDF-generation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116400

--- Comment #4 from Daniel Grigoras  ---
(In reply to Buovjaga from comment #3)

Indeed, PDF-generation is very fast in LibreOfficeDev 6.1.
Looking forward to having this improvement integrated in the official release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - chart2/source

[Pranav Kant]

 chart2/source/controller/main/ChartController_Window.cxx |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 60edca8d8a9f00d3220255324d30ae41464a4e82
Author: Pranav Kant 
Date:   Thu Mar 15 16:48:18 2018 +0530

chart2 lok: tunnel context menu of the chart edit view

Change-Id: I0c8b3cfe1666ad81f808871a87e4b0fa64ef593c
Reviewed-on: https://gerrit.libreoffice.org/51355
Reviewed-by: Jan Holesovsky 
Tested-by: Jan Holesovsky 

diff --git a/chart2/source/controller/main/ChartController_Window.cxx 
b/chart2/source/controller/main/ChartController_Window.cxx
index 2989e32d4faa..58f7206554ec 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -55,14 +55,16 @@
 #include 
 #include 
 #include 
+
+#include 
 #include 
 #include 
 
 #include 
 
+#include 
 #include 
 #include 
-
 #include 
 #include 
 #include 
@@ -1232,6 +1234,12 @@ void ChartController::execute_Command( const 
CommandEvent& rCEvt )
 if ( !xPopupController.is() || !xPopupMenu.is() )
 return;
 
+if (comphelper::LibreOfficeKit::isActive())
+{
+PopupMenu* pPopupMenu = 
static_cast(VCLXMenu::GetImplementation(xPopupMenu)->GetMenu());
+pPopupMenu->SetLOKNotifier(SfxViewShell::Current());
+}
+
 xPopupController->setPopupMenu( xPopupMenu );
 xPopupMenu->execute( css::uno::Reference< css::awt::XWindowPeer >( 
m_xFrame->getContainerWindow(), css::uno::UNO_QUERY ),
  css::awt::Rectangle( aPos.X(), aPos.Y(), 0, 0 ),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115643] Problems connecting to OneDrive and Google Drive

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115643

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116429] New: You can cancel renaming an object after adding it

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116429

Bug ID: 116429
   Summary: You can cancel renaming an object after adding it
   Product: LibreOffice
   Version: 6.0.1.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lyubimov-ma...@yandex.ru

Description:
If, for example, add a shape is one action. However, two actions appear in the
undo action list
1. Insert figure "Figure 1"
2. To change the name of the object figure "Figure 1"


Steps to Reproduce:
1. Add shape
2. Cancel adding a shape (cntr + Z)


Actual Results:  
The figure remained, instead of deleting it cancels the renaming of the figures


Expected Results:
Deleting a shape



Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:59.0) Gecko/20100101 Firefox/59.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 114227] Proxy settings disregarded for reporting crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114227

Xisco Faulí  changed:

   What|Removed |Added

Version|5.4.3.2 release |5.3 all versions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116414] Linux templates of LibreOffice5 stored in 4

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116414

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #3 from Xisco Faulí  ---
I guess we can close this one as a duplicate of bug 93057 as we have done with
other bugs.
I guess we don't need to create a bug if we need to change the folder name in
the future

*** This bug has been marked as a duplicate of bug 93057 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93057] LO 5 does use the existing user profile LibreOffice/4/user, but this is not mentioned in the release notes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93057

Xisco Faulí  changed:

   What|Removed |Added

 CC||li...@waldbewertungen.de

--- Comment #15 from Xisco Faulí  ---
*** Bug 116414 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Xisco Faulí  changed:

   What|Removed |Added

Version|6.1.0.0.alpha0+ Master  |Inherited From OOo

--- Comment #1 from Xisco Faulí  ---
I guess the option has been there since the beginning...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 116407] option "Border" for new table redundant

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116407

Xisco Faulí  changed:

   What|Removed |Added

Version|6.1.0.0.alpha0+ Master  |Inherited From OOo

--- Comment #1 from Xisco Faulí  ---
I guess the option has been there since the beginning...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 116390] FILESAVE: Unable to open an ODG file saved from a VSD file saved as ODG

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116390

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 CC||xiscofa...@libreoffice.org
 Resolution|--- |WORKSFORME

--- Comment #6 from Xisco Faulí  ---
I can no longer reproduce it in

Version: 6.1.0.0.alpha0+
Build ID: 28e8c3e28bf4944ecad23961602b9b1f72613d39
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: en-GB (ca_ES.UTF-8); Calc: group

Closing as RESOLVED WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115597] updates have been turned off in prefs, but still LibreOffice keeps downloading updates

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115597

--- Comment #1 from Alex Thurgood  ---
@Chris :

- In LO6011, I see 2 tick boxes :

- check automatically for updates (and a choice of frequency)

- download automatically the updates (to a given folder).

Both of these are unticked on my system, and I don't get constant downloads or
slowdowns due to update verification.

No repro for me with:

Version: 6.0.1.1
Build ID: 60bfb1526849283ce2491346ed2aa51c465abfe6
Threads CPU : 4; OS : Mac OS X 10.13.3; UI Render : par défaut; 
Locale : fr-FR (fr_FR.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116402] code-scalability missing on webpage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116402

Xisco Faulí  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 CC||xiscofa...@libreoffice.org
 Ever confirmed|1   |0
   Severity|normal  |enhancement

--- Comment #3 from Xisco Faulí  ---
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113182] FILEOPEN: DOCX: Textbox wrap differs in MSO and LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113182

Serge Krot (CIB)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serge.k...@cib.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - framework/source

[Caolán McNamara]

 framework/source/loadenv/loadenv.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit be83e928279bf3c6ae3fd316571d02dc452b45e8
Author: Caolán McNamara 
Date:   Mon Mar 12 15:25:32 2018 +

tdf#116277 blank frame into which document will load shown too early

normally we want this to be the window that is the parent for any
warning or password dialog. But for these (weird, see also 
impl_findSlotParam)
frames dispatched with slotid arguments, they are opened before the dialog
which will fill them is launched.

Presumably in sane land the dialog would be dispatched from the menu entry,
then on its create the frame opened with the desired contents.

Change-Id: I1234b648ca1bd7fd2109cb4d3c70d5bfed9ab563
Reviewed-on: https://gerrit.libreoffice.org/51152
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/framework/source/loadenv/loadenv.cxx 
b/framework/source/loadenv/loadenv.cxx
index 6ad9498f776f..a2cfb5e2b9f7 100644
--- a/framework/source/loadenv/loadenv.cxx
+++ b/framework/source/loadenv/loadenv.cxx
@@ -1074,7 +1074,9 @@ bool LoadEnv::impl_loadContent()
 {"Parent", uno::Any(xWindow)}
 }));
 xHandler->initialize(aArguments);
-impl_makeFrameWindowVisible(xWindow, false);
+//show the frame now, unless (tdf#116277) its the labels/business 
cards slave frame
+if (m_aURL.Arguments.indexOf("slot=") == -1)
+impl_makeFrameWindowVisible(xWindow, false);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 115201] Editing region of text and picture on separate pages into 2 columns loses picture

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115201

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #5 from Xisco Faulí  ---
I can't reproduce it in

Versió: 6.0.2.1
ID de la construcció: 1:6.0.2~rc1-0ubuntu0.16.04.1~lo1
Fils de CPU: 4; SO: Linux 4.13; Renderitzador de la IU: per defecte; VCL: gtk3; 
Configuració local: ca-ES (ca_ES.UTF-8); Calc: group

Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116408] LibreOffice not associated with pdf docs in "open with" contextual menu in MacOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116408

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Alex Thurgood  ---
Confirming on MacOSX 10.13.3.

Ironically, Microsoft Word appears in the context menu of apps in which one can
load a PDF, but LibreOffice does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/qa sw/source

[Mike Kaganski]

 sw/qa/extras/uiwriter/data/tdf116403-considerborders.odt |binary
 sw/qa/extras/uiwriter/uiwriter.cxx   |   26 +++
 sw/source/core/tox/ToxTabStopTokenHandler.cxx|5 ++
 3 files changed, 31 insertions(+)

New commits:
commit 1f3630e2fb35389835cb326a46bd539660942632
Author: Mike Kaganski 
Date:   Fri Mar 16 11:22:41 2018 +0300

tdf#116403: consider borders when updating right-aligned tab in index

Change-Id: I415d8fcfdd75e6d608ec2e3ba228146cf8139278
Reviewed-on: https://gerrit.libreoffice.org/51388
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/extras/uiwriter/data/tdf116403-considerborders.odt 
b/sw/qa/extras/uiwriter/data/tdf116403-considerborders.odt
new file mode 100644
index ..c0fb91ad7eb3
Binary files /dev/null and 
b/sw/qa/extras/uiwriter/data/tdf116403-considerborders.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 63f02288c8f4..9ef300b9bac0 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -306,6 +306,7 @@ public:
 void testTdf115065();
 void testTdf115132();
 void testXDrawPagesSupplier();
+void testTdf116403();
 
 CPPUNIT_TEST_SUITE(SwUiWriterTest);
 CPPUNIT_TEST(testReplaceForward);
@@ -489,6 +490,7 @@ public:
 CPPUNIT_TEST(testTdf115065);
 CPPUNIT_TEST(testTdf115132);
 CPPUNIT_TEST(testXDrawPagesSupplier);
+CPPUNIT_TEST(testTdf116403);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -6020,6 +6022,30 @@ void SwUiWriterTest::testXDrawPagesSupplier()
 xDrawPage.get(), xDrawPageFromXDrawPages.get());
 }
 
+void SwUiWriterTest::testTdf116403()
+{
+createDoc("tdf116403-considerborders.odt");
+// Check that before ToX update, the tab stop position is the old one
+uno::Reference xParagraph = getParagraph(2, "1\t1");
+auto aTabs = getProperty(xParagraph, 
"ParaTabStops");
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aTabs.getLength());
+CPPUNIT_ASSERT_EQUAL(static_cast(17000), aTabs[0].Position);
+
+SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
+CPPUNIT_ASSERT(pTextDoc);
+SwWrtShell* pWrtShell = pTextDoc->GetDocShell()->GetWrtShell();
+const SwTOXBase* pTOX = pWrtShell->GetTOX(0);
+CPPUNIT_ASSERT(pTOX);
+pWrtShell->UpdateTableOf(*pTOX);
+
+xParagraph = getParagraph(2, "1\t1");
+aTabs = getProperty(xParagraph, 
"ParaTabStops");
+CPPUNIT_ASSERT_EQUAL(static_cast(1), aTabs.getLength());
+// This was still 17000, refreshing ToX didn't take borders spacings and 
widths into account
+CPPUNIT_ASSERT_EQUAL_MESSAGE("Page borders must be considered for 
right-aligned tabstop",
+static_cast(17000 - 2 * 500 - 2 * 1), aTabs[0].Position);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SwUiWriterTest);
 CPPUNIT_PLUGIN_IMPLEMENT();
 
diff --git a/sw/source/core/tox/ToxTabStopTokenHandler.cxx 
b/sw/source/core/tox/ToxTabStopTokenHandler.cxx
index 6de76cb4f2c7..3fd3abb8abb1 100644
--- a/sw/source/core/tox/ToxTabStopTokenHandler.cxx
+++ b/sw/source/core/tox/ToxTabStopTokenHandler.cxx
@@ -93,6 +93,11 @@ 
DefaultToxTabStopTokenHandler::CalculatePageMarginFromPageDescription(const SwTe
 const SwFrameFormat& rPgDscFormat = pPageDesc->GetMaster();
 long result = rPgDscFormat.GetFrameSize().GetWidth() - 
rPgDscFormat.GetLRSpace().GetLeft()
 - rPgDscFormat.GetLRSpace().GetRight();
+// Also consider borders
+const SvxBoxItem& rBox = rPgDscFormat.GetBox();
+for (SvxBoxItemLine eLine : { SvxBoxItemLine::LEFT, SvxBoxItemLine::RIGHT 
})
+if (const editeng::SvxBorderLine* pBorder = rBox.GetLine(eLine))
+result -= pBorder->GetWidth() + rBox.GetDistance(eLine);
 return result;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 43492] Watch function of user defined type displays only first child variable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43492

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Resolution|FIXED   |WORKSFORME

--- Comment #9 from Xisco Faulí  ---
Setting to RESOLVED WORKSFORME as the commit fixing this issue hasn't been
identified.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115643] Problems connecting to OneDrive and Google Drive

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115643

--- Comment #4 from Eduardo  ---
Its difficult to say. This bugs are all related to mine with different web
cloud services and different Libreoffice versions. My bug is related to Gmail (
google drive WITHOUT double authentication) and One Drive. I need to say that
this is a major bug as a lot of people want to use libreoffice with Drive or
One, as Office does.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115923] Clicking the fill handle triggers automatic horizontal scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115923

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Caolán McNamara  ---
so, for that autofill case we're now back to the historical scroll leaving the
"new" scroll in place for anything that isn't autofill. Backport to 6-0 in
gerrit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113499] [META] AutoFill bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113499
Bug 113499 depends on bug 115923, which changed state.

Bug 115923 Summary: Clicking the fill handle triggers automatic horizontal 
scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=115923

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104787] [META] Saved PPTX files that MS Powerpoint can't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104787
Bug 104787 depends on bug 104789, which changed state.

Bug 104789 Summary: FILESAVE: PPTX: Corrupted File after RT (The attribute 
'val' is not declared)
https://bugs.documentfoundation.org/show_bug.cgi?id=104789

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104787] [META] Saved PPTX files that MS Powerpoint can't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104787
Bug 104787 depends on bug 104786, which changed state.

Bug 104786 Summary: FILESAVE: PPTX: Corrupted File after RT (The element has 
invalid child element)
https://bugs.documentfoundation.org/show_bug.cgi?id=104786

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 109362] [META] Custom/object animation bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109362
Bug 109362 depends on bug 104786, which changed state.

Bug 104786 Summary: FILESAVE: PPTX: Corrupted File after RT (The element has 
invalid child element)
https://bugs.documentfoundation.org/show_bug.cgi?id=104786

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 104787] [META] Saved PPTX files that MS Powerpoint can't open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=104787
Bug 104787 depends on bug 90627, which changed state.

Bug 90627 Summary: Saving presentation results in invalid PPTX file
https://bugs.documentfoundation.org/show_bug.cgi?id=90627

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56363] Using Graphite features prevents Special Character dialog from preselecting the Graphite font

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56363

RGB  changed:

   What|Removed |Added

 CC||rgb.m...@gmail.com

--- Comment #17 from RGB  ---
Created attachment 140663
  --> https://bugs.documentfoundation.org/attachment.cgi?id=140663=edit
Example with OpenType font

This also happens with OpenType fonts. On the attached document there are two
paragraph styles, style1 and style2, both using Libertinus Serif font, but the
second paragraph style add the "onum" (old style numerals) OpenType tag. The
result when you click on "insert special character" is shown on the
screenshots: on the first paragraph (using style1 and hence "Libertinus Serif")
the insert special character dialogue offers the right font, but on the second
paragraph (using style2 and hence "Libertinus Serif:onum") offers a different
font.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108741

Dieter Praas  changed:

   What|Removed |Added

 Depends on||116419


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116419
[Bug 116419] Wrong calculation of coordinates when adding a text box to a shape
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116419] Wrong calculation of coordinates when adding a text box to a shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116419

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||108741
 Ever confirmed|0   |1

--- Comment #4 from Dieter Praas  ---
I could reproduce it:

1. Open new document
2. Insert => Frame => Frame
3. Ad a shape to the frame
4. right click in the shape => add text box
5. Text box is outside the shape

I also noticed, that if you create a shape without a frame, the textbox is also
only partially in the shape.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108741
[Bug 108741] [META] Shapes bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115923] Clicking the fill handle triggers automatic horizontal scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115923

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7619390bd15fa26fc8f74d75f187cf8bf2fca58b

Resolves: tdf#115923 try a different approach to solving tdf#46637

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115923] Clicking the fill handle triggers automatic horizontal scrolling

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115923

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Caolán McNamara]

 sc/source/ui/view/select.cxx |   25 -
 1 file changed, 20 insertions(+), 5 deletions(-)

New commits:
commit 7619390bd15fa26fc8f74d75f187cf8bf2fca58b
Author: Caolán McNamara 
Date:   Thu Mar 15 16:54:44 2018 +

Resolves: tdf#115923 try a different approach to solving tdf#46637

Try scrolling to the cell the mouse is over if its not fully visible already
and this is not autofill selection. To avoid the mouse over the autofill 
handle
which overflows into neighbours scrolling the neighbour cell into view 
before
its truly desired to be selected when the mouse passes the center point

in other words, for autofill go back to how it always was

Change-Id: I6f67ad0f49c2d4087949f71f38322f06ced13c79
Reviewed-on: https://gerrit.libreoffice.org/51361
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/view/select.cxx b/sc/source/ui/view/select.cxx
index 3783027f4052..781843bffeae 100644
--- a/sc/source/ui/view/select.cxx
+++ b/sc/source/ui/view/select.cxx
@@ -321,13 +321,28 @@ void ScViewFunctionSet::SetCursorAtPoint( const Point& 
rPointPixel, bool /* bDon
  pEngine->GetWindow(),
  nullptr, false);
 
-bool bBottomScroll = ( aEditArea.Bottom() >= aWinSize.Height() );
-bool bRightScroll  = ( aEditArea.Right() >= aWinSize.Width() );
+bool bFillingSelection = pViewData->IsFillMode() || 
pViewData->GetFillMode() == ScFillMode::MATRIX;
+bool bBottomScroll;
+bool bRightScroll;
+// for Autofill don't yet assume we want to auto-scroll to the cell under 
the mouse
+// because the autofill handle extends into a cells neighbours so initial 
click is usually
+// above a neighbour cell
+if (bFillingSelection)
+{
+bBottomScroll = aEffPos.X() >= aWinSize.Height();
+bRightScroll  = aEffPos.Y() >= aWinSize.Width();
+}
+else
+{
+//in the normal case make the full selected cell visible
+bBottomScroll = aEditArea.Bottom() >= aWinSize.Height();
+bRightScroll  = aEditArea.Right() >= aWinSize.Width();
+}
+
 bool bScroll = bRightScroll || bBottomScroll || bLeftScroll || bTopScroll;
 
-// for Autofill switch in the center of cell
-// thereby don't prevent scrolling to bottom/right
-if ( pViewData->IsFillMode() || pViewData->GetFillMode() == 
ScFillMode::MATRIX )
+// for Autofill switch in the center of cell thereby don't prevent 
scrolling to bottom/right
+if (bFillingSelection)
 {
 bool bLeft, bTop;
 pViewData->GetMouseQuadrant( aEffPos, GetWhich(), nPosX, nPosY, bLeft, 
bTop );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116419] Wrong calculation of coordinates when adding a text box to a shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116419

--- Comment #3 from Maxim  ---
(In reply to Dieter Praas from comment #2)
> I can't find anything named "incut" in the UI. Where is it?

It is a text frame
Translation error

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116419] Wrong calculation of coordinates when adding a text box to a shape

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116419

Dieter Praas  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter Praas  ---
I can't find anything named "incut" in the UI. Where is it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/source

[Tomaž Vajngerl]

 vcl/source/graphic/UnoGraphicProvider.cxx |   28 
 1 file changed, 28 deletions(-)

New commits:
commit f4facca39726c7a8d43ced8f4d88d58aa116c443
Author: Tomaž Vajngerl 
Date:   Thu Mar 15 20:26:58 2018 +0900

Remove XGraphic creation with Grap.Obj. URL in GraphicProvider

Change-Id: Ie51be332df88791cb13c3835582acc0a4e7250f9
Reviewed-on: https://gerrit.libreoffice.org/51332
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/graphic/UnoGraphicProvider.cxx 
b/vcl/source/graphic/UnoGraphicProvider.cxx
index 1c4595e7aeda..abb85ac6aac0 100644
--- a/vcl/source/graphic/UnoGraphicProvider.cxx
+++ b/vcl/source/graphic/UnoGraphicProvider.cxx
@@ -54,8 +54,6 @@ using namespace com::sun::star;
 
 namespace {
 
-#define UNO_NAME_GRAPHOBJ_URLPREFIX 
"vnd.sun.star.GraphicObject:"
-
 class GraphicProvider : public ::cppu::WeakImplHelper< 
css::graphic::XGraphicProvider2,
 
css::lang::XServiceInfo >
 {
@@ -85,7 +83,6 @@ protected:
 private:
 
 static css::uno::Reference< css::graphic::XGraphic > implLoadMemory( const 
OUString& rResourceURL );
-static css::uno::Reference< css::graphic::XGraphic > 
implLoadGraphicObject( const OUString& rResourceURL );
 static css::uno::Reference< css::graphic::XGraphic > 
implLoadRepositoryImage( const OUString& rResourceURL );
 static css::uno::Reference< css::graphic::XGraphic > implLoadBitmap( const 
css::uno::Reference< css::awt::XBitmap >& rBitmap );
 static css::uno::Reference< css::graphic::XGraphic > 
implLoadStandardImage( const OUString& rResourceURL );
@@ -128,26 +125,6 @@ uno::Sequence< sal_Int8 > SAL_CALL 
GraphicProvider::getImplementationId()
 return css::uno::Sequence();
 }
 
-
-uno::Reference< ::graphic::XGraphic > GraphicProvider::implLoadGraphicObject( 
const OUString& rResourceURL )
-{
-uno::Reference< ::graphic::XGraphic >   xRet;
-if( rResourceURL.startsWith( UNO_NAME_GRAPHOBJ_URLPREFIX ) )
-{
-// graphic manager url
-OUString aTmpStr( rResourceURL.copy( sizeof( 
UNO_NAME_GRAPHOBJ_URLPREFIX ) - 1 ) );
-OString aUniqueID(OUStringToOString(aTmpStr,
-RTL_TEXTENCODING_UTF8));
-GraphicObject aGrafObj(aUniqueID);
-// I don't call aGrafObj.GetXGraphic because it will call us back
-// into implLoadMemory ( with "private:memorygraphic" test )
-::unographic::Graphic* pUnoGraphic = new ::unographic::Graphic;
-pUnoGraphic->init( aGrafObj.GetGraphic() );
-xRet = pUnoGraphic;
-}
-return xRet;
-}
-
 uno::Reference< ::graphic::XGraphic > GraphicProvider::implLoadMemory( const 
OUString& rResourceURL )
 {
 uno::Reference< ::graphic::XGraphic >   xRet;
@@ -287,8 +264,6 @@ uno::Reference< beans::XPropertySet > SAL_CALL 
GraphicProvider::queryGraphicDesc
 else if( !aURL.isEmpty() )
 {
 uno::Reference< ::graphic::XGraphic > xGraphic( implLoadMemory( aURL ) 
);
-if( !xGraphic.is() )
-xGraphic = implLoadGraphicObject( aURL );
 
 if ( !xGraphic.is() )
 xGraphic = implLoadRepositoryImage( aURL );
@@ -387,9 +362,6 @@ uno::Reference< ::graphic::XGraphic > SAL_CALL 
GraphicProvider::queryGraphic( co
 {
 xRet = implLoadMemory( aPath );
 
-if( !xRet.is() )
-xRet = implLoadGraphicObject( aPath );
-
 if ( !xRet.is() )
 xRet = implLoadRepositoryImage( aPath );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/source

[Tomaž Vajngerl]

 include/vcl/GraphicObject.hxx|1 -
 vcl/source/graphic/GraphicObject.cxx |   16 
 2 files changed, 17 deletions(-)

New commits:
commit 24546ac5ea1d58d7cbd07d093b99c9ab07406b00
Author: Tomaž Vajngerl 
Date:   Thu Mar 15 20:31:37 2018 +0900

remove constructor with UniqueID from GraphicObject

Change-Id: I03924c993a95adaf6e19589779546fce2b38c745
Reviewed-on: https://gerrit.libreoffice.org/51333
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/include/vcl/GraphicObject.hxx b/include/vcl/GraphicObject.hxx
index 877df26f9289..fbd063687e34 100644
--- a/include/vcl/GraphicObject.hxx
+++ b/include/vcl/GraphicObject.hxx
@@ -317,7 +317,6 @@ public:
 GraphicObject();
 GraphicObject( const Graphic& rGraphic );
 GraphicObject( const GraphicObject& rCacheObj );
-explicit GraphicObject( const OString& rUniqueID );
 ~GraphicObject();
 
 GraphicObject&  operator=( const GraphicObject& rCacheObj );
diff --git a/vcl/source/graphic/GraphicObject.cxx 
b/vcl/source/graphic/GraphicObject.cxx
index aa8465c76b26..b67ad659e8e1 100644
--- a/vcl/source/graphic/GraphicObject.cxx
+++ b/vcl/source/graphic/GraphicObject.cxx
@@ -157,22 +157,6 @@ GraphicObject::GraphicObject(const GraphicObject& 
rGraphicObj)
 SetSwapState();
 }
 
-GraphicObject::GraphicObject(const OString& rUniqueID)
-: mbAutoSwapped(false)
-, mbIsInSwapIn(false)
-, mbIsInSwapOut(false)
-{
-ImplEnsureGraphicManager();
-
-// assign default properties
-ImplAssignGraphicData();
-
-mpGlobalMgr->ImplRegisterObj(*this, maGraphic, , nullptr);
-
-// update properties
-ImplAssignGraphicData();
-}
-
 GraphicObject::~GraphicObject()
 {
 mpGlobalMgr->ImplUnregisterObj( *this );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/opengl vcl/qa vcl/quartz

[Chris Sherlock]

 vcl/opengl/salbmp.cxx |   19 +++
 vcl/qa/cppunit/BitmapTest.cxx |   27 +++
 vcl/quartz/salbmp.cxx |   15 +++
 3 files changed, 13 insertions(+), 48 deletions(-)

New commits:
commit 460f39e687393b3a8906d2adc3e8f7a0c749851a
Author: Chris Sherlock 
Date:   Wed Mar 14 01:07:07 2018 +1100

tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned

Change-Id: I92b43ae2f034bf63cc3f212ec8728c5c6b5e8934
Reviewed-on: https://gerrit.libreoffice.org/51222
Tested-by: Jenkins 
Reviewed-by: Michael Meeks 

diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index 4127c46a509b..fab0f6d724d4 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -81,18 +81,13 @@ inline bool isValidBitCount( sal_uInt16 nBitCount )
 
 sal_uInt16 lclBytesPerRow(sal_uInt16 nBits, int nWidth)
 {
-switch(nBits)
-{
-case 1:  return (nWidth + 7) >> 3;
-case 4:  return (nWidth + 1) >> 1;
-case 8:  return  nWidth;
-case 16: return  nWidth * 2;
-case 24: return  nWidth * 3;
-case 32: return  nWidth * 4;
-default:
-OSL_FAIL("vcl::OpenGLSalBitmap::AllocateUserData(), illegal 
bitcount!");
-}
-return 0;
+assert ((nBits == 1 || nBits == 4 || nBits == 8 || nBits == 16 || nBits == 
24 || nBits == 32)
+&& "vcl::OpenGLSalBitmap::AllocateUserData(), illegal bitcount!");
+
+if (!isValidBitCount(nBits))
+return 0;
+
+return AlignedWidth4Bytes(nBits * nWidth);
 }
 
 typedef std::vector > 
TextureAtlasVector;
diff --git a/vcl/qa/cppunit/BitmapTest.cxx b/vcl/qa/cppunit/BitmapTest.cxx
index f835c7b78bc3..0bbe6d294882 100644
--- a/vcl/qa/cppunit/BitmapTest.cxx
+++ b/vcl/qa/cppunit/BitmapTest.cxx
@@ -342,15 +342,8 @@ void BitmapTest::testConvert()
 {
 Bitmap::ScopedReadAccess pReadAccess(aBitmap);
 CPPUNIT_ASSERT_EQUAL(static_cast(8), 
pReadAccess->GetBitCount());
-#if defined MACOSX || defined IOS
-//it would be nice to find and change the stride for quartz to be the 
same as everyone else
-CPPUNIT_ASSERT_EQUAL(static_cast(10), 
pReadAccess->GetScanlineSize());
-#else
-#if HAVE_FEATURE_OPENGL
-if (!OpenGLHelper::isVCLOpenGLEnabled())
-CPPUNIT_ASSERT_EQUAL(static_cast(12), 
pReadAccess->GetScanlineSize());
-#endif
-#endif
+// scanline should pad to 32-bit multiples
+CPPUNIT_ASSERT_EQUAL(static_cast(12), 
pReadAccess->GetScanlineSize());
 CPPUNIT_ASSERT(pReadAccess->HasPalette());
 const BitmapColor& rColor = 
pReadAccess->GetPaletteColor(pReadAccess->GetPixelIndex(1, 1));
 CPPUNIT_ASSERT_EQUAL(sal_Int32(204), sal_Int32(rColor.GetRed()));
@@ -365,22 +358,8 @@ void BitmapTest::testConvert()
 Bitmap::ScopedReadAccess pReadAccess(aBitmap);
 // 24 bit Bitmap on SVP backend can now use 24bit RGB everywhere.
 CPPUNIT_ASSERT_EQUAL(static_cast(24), 
pReadAccess->GetBitCount());
-
-#if defined LINUX || defined FREEBSD
+// scanline should pad to 32-bit multiples
 CPPUNIT_ASSERT_EQUAL(sal_uLong(32), pReadAccess->GetScanlineSize());
-#else
-#if defined(_WIN32)
-if (!OpenGLHelper::isVCLOpenGLEnabled())
-{
-// GDI Scanlines padded to DWORD multiples, it seems
-CPPUNIT_ASSERT_EQUAL(sal_uLong(32), 
pReadAccess->GetScanlineSize());
-}
-else
-#endif
-{
-CPPUNIT_ASSERT_EQUAL(sal_uLong(30), 
pReadAccess->GetScanlineSize());
-}
-#endif
 
 CPPUNIT_ASSERT(!pReadAccess->HasPalette());
 Color aColor = pReadAccess->GetPixel(0, 0).GetColor();
diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx
index f9a10a44020b..04fb820b08a3 100644
--- a/vcl/quartz/salbmp.cxx
+++ b/vcl/quartz/salbmp.cxx
@@ -310,19 +310,10 @@ bool QuartzSalBitmap::AllocateUserData()
 
 if( mnWidth && mnHeight )
 {
-mnBytesPerRow =  0;
+assert((mnBits == 1 || mnBits == 4 || mnBits == 8 || mnBits == 16 || 
mnBits == 24 || mnBits == 32)
+&& "vcl::QuartzSalBitmap::AllocateUserData(), illegal 
bitcount!");
 
-switch( mnBits )
-{
-case 1: mnBytesPerRow = (mnWidth + 7) >> 3; break;
-case 4: mnBytesPerRow = (mnWidth + 1) >> 1; break;
-case 8: mnBytesPerRow = mnWidth; break;
-case 16:mnBytesPerRow = mnWidth << 1; break;
-case 24:mnBytesPerRow = (mnWidth << 1) + mnWidth; break;
-case 32:mnBytesPerRow = mnWidth << 2; break;
-default:
-OSL_FAIL("vcl::QuartzSalBitmap::AllocateUserData(), illegal 
bitcount!");
-}
+mnBytesPerRow = AlignedWidth4Bytes(mnBits * mnWidth);
 }
 
 bool alloc = false;
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: svx/source

[Tomaž Vajngerl]

 svx/source/xml/xmlgrhlp.cxx |  460 
 1 file changed, 5 insertions(+), 455 deletions(-)

New commits:
commit cd5def4d12c38eac039fce66b8d0c8e9a954ce8a
Author: Tomaž Vajngerl 
Date:   Thu Mar 15 21:23:40 2018 +0900

remove some GraphicObject URL funct. from GraphicImportHelper

GraphicImportHelper is an implementation of XGraphicObjectResolver
which is mostly used to "resolve" a GraphicObject URL to the
internal storage URL (and save the graphic to the storage in the
process). Most of the GraphicObject URL functionality was removed
so the required overrides from XGraphicObjectResolver interface
now return an empty result or do nothing.

Change-Id: Iee6bb71b15411d03ef82ab4d20d234ff0e834425
Reviewed-on: https://gerrit.libreoffice.org/51331
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx
index 62aa1bb6dd1b..8861ce4db830 100644
--- a/svx/source/xml/xmlgrhlp.cxx
+++ b/svx/source/xml/xmlgrhlp.cxx
@@ -74,140 +74,6 @@ const MetaCommentAction* ImplCheckForEPS( GDIMetaFile const 
& rMtf )
 return pComment;
 }
 
-class SvXMLGraphicInputStream:
-public cppu::WeakImplHelper
-{
-private:
-
-virtual sal_Int32   SAL_CALLreadBytes( Sequence< sal_Int8 >& aData, 
sal_Int32 nBytesToRead) override;
-virtual sal_Int32   SAL_CALLreadSomeBytes(Sequence< sal_Int8 >& aData, 
sal_Int32 nMaxBytesToRead) override;
-virtual voidSAL_CALLskipBytes(sal_Int32 nBytesToSkip) override;
-virtual sal_Int32   SAL_CALLavailable() override;
-virtual voidSAL_CALLcloseInput() override;
-
-private:
-
-::utl::TempFile maTmp;
-Reference< XInputStream >   mxStmWrapper;
-
-public:
-
-explicitSvXMLGraphicInputStream( const OUString& 
rGraphicId, const OUString& rMimeType );
-SvXMLGraphicInputStream(const 
SvXMLGraphicInputStream&) = delete;
-SvXMLGraphicInputStream&operator=(const SvXMLGraphicInputStream&) 
= delete;
-
-boolExists() const { return mxStmWrapper.is(); 
}
-};
-
-
-SvXMLGraphicInputStream::SvXMLGraphicInputStream( const OUString& rGraphicId, 
const OUString& rMimeType )
-{
-GraphicObject   aGrfObject( OUStringToOString(rGraphicId, 
RTL_TEXTENCODING_ASCII_US) );
-
-maTmp.EnableKillingFile();
-
-if( aGrfObject.GetType() != GraphicType::NONE )
-{
-SvStream* pStm = ::utl::UcbStreamHelper::CreateStream( maTmp.GetURL(), 
StreamMode::WRITE | StreamMode::TRUNC );
-
-if( pStm )
-{
-Graphic aGraphic( aGrfObject.GetGraphic() );
-const GfxLink   aGfxLink( aGraphic.GetLink() );
-boolbRet = false;
-
-if( aGfxLink.GetDataSize() && aGfxLink.GetData() )
-{
-if ( rMimeType.isEmpty() )
-{
-pStm->WriteBytes(aGfxLink.GetData(), 
aGfxLink.GetDataSize());
-bRet = ( pStm->GetError() == ERRCODE_NONE );
-}
-else
-{
-GraphicFilter  = GraphicFilter::GetGraphicFilter();
-bRet = ( rFilter.ExportGraphic( aGraphic, "", *pStm, 
rFilter.GetExportFormatNumberForMediaType( rMimeType ) ) == ERRCODE_NONE );
-}
-}
-else
-{
-if( aGraphic.GetType() == GraphicType::Bitmap )
-{
-GraphicFilter  = GraphicFilter::GetGraphicFilter();
-OUString  aFormat=rMimeType;
-
-if( aGraphic.IsAnimated() )
-aFormat = "image/gif";
-else if( aFormat.isEmpty() )
-aFormat = "image/png";
-
-bRet = ( rFilter.ExportGraphic( aGraphic, "", *pStm, 
rFilter.GetExportFormatNumberForMediaType( aFormat ) ) == ERRCODE_NONE );
-}
-else if( rMimeType.isEmpty() && aGraphic.GetType() == 
GraphicType::GdiMetafile )
-{
-pStm->SetVersion( SOFFICE_FILEFORMAT_8 );
-pStm->SetCompressMode( SvStreamCompressFlags::ZBITMAP );
-const_cast( aGraphic.GetGDIMetaFile() 
).Write( *pStm );
-bRet = ( pStm->GetError() == ERRCODE_NONE );
-}
-else if( !rMimeType.isEmpty() )
-{
-GraphicFilter  = GraphicFilter::GetGraphicFilter();
-bRet = ( rFilter.ExportGraphic( aGraphic, "", *pStm, 
rFilter.GetExportFormatNumberForMediaType( rMimeType ) ) == ERRCODE_NONE );
-}
-}
-
-if( bRet )
-{
-pStm->Seek( 0 );
- 

[Libreoffice-bugs] [Bug 116403] DOC(X): Adding borders to a document with TOC doesn' t correct TOC tabbing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116403

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #4 from Mike Kaganski  ---
https://gerrit.libreoffice.org/51388

The problem is not in DOC/DOCX, or in the compatibility mode mentioned in
comment 0.

When an index is (re)generated, every right-aligned tab in its tokens generates
a (manually-applied) tabstop position in relevant paragraph, which position is
calculated at the right text margin based on the layout. Further layout changes
don't update the tabstop, unless user updates the index (right-click->Update
index). The first problem (the real bug) is, that calculation of the position
does not take borders into account, regardless of compatibility mode.

Still, when the text area is/becomes narrower than the tabstop position (like
when right margin increases, or when borders exist), *without* the
compatibility mode, the problem is not apparent, since the out-of-textarea
tabstop is overriden by the textarea margin, so the number position gets to the
expected position dynamically (even no index update necessary). But with the
mode active, this becomes immediately visible.

One can check the problem with a new text document: add a heading and a ToC
with default settings; then decrease right page margin and see that page number
doesn't follow the margin (until index update).

So, to fix this first problem, the patch mentioned above simply considers
margins when calculating tabstop position, thus correctly setting it on index
creation/update.

The other thing is if we should also update the position dynamically after
changing margins/borders (or relayouting that could move the index to another
page with different margins/borders). This would be an enhancement, and should
be tracked separately; also, we should consider that user can manually change
the tabstops (when disabled the index protection; after modifications, the
protection could be restored). So, how would we go when the positions were
manually tweaked? dynamic update would destroy the overriden values.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116399] Sending a print job for a 400 paged document is rather slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116399

--- Comment #2 from Telesto  ---
Might be a dupe (again, great!) of bug 112989.. A the dupes are mine already
(keep forgetting about it)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs