[Libreoffice-bugs] [Bug 117124] Item of notebook toolbar has no KeyID.

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117124

baffclan  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from baffclan  ---
Cannot reproduce with LibO 6.1 master(x64) on Windows10 pro

Version: 6.1.0.0.alpha1+ (x64)
Build ID: ea33ae5ef0a9d6b03fdef6503066100d0ae12729
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2018-05-03_14:09:58
Locale: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101263] Insert Cross-reference points to wrong endnote entry.

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101263

jimrussell98...@gmail.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #14 from jimrussell98...@gmail.com ---
Third time trying to input this information.
At your request I tried to replicate the problem with 5.4.7.2. The problem
remains. If I can manage to figure out how to attach a document again, I'll
give you a test document that probes a bit further. This document
Bug101263.odt, was created in .odt format and has not ever been in .docx format
(in re: an earlier question).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101263] Insert Cross-reference points to wrong endnote entry.

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101263

--- Comment #15 from jimrussell98...@gmail.com ---
Created attachment 142221
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142221=edit
test of Bug 101263

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101263] Insert Cross-reference points to wrong endnote entry.

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101263

jimrussell98...@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #13 from jimrussell98...@gmail.com ---
You requested that I check whether this has been fixed. I checked with 5.4.7.2,
and it has not been fixed. I am trying to attach a test document that explores
the problem a little further. This document was created in .odt format, and has
never been in .docx format.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101263] Insert Cross-reference points to wrong endnote entry.

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=101263

--- Comment #12 from jimrussell98...@gmail.com ---
At your request, I tested the latest offered stable version (5.4.7.2) to see
whether this has been fixed. No, the problem remains. I will try to attach my
test document. It explores the problem a bit further. The test document was
originally created in 5.4.7.2 as a .odt - it has never been a .docx.

Not sure what status to assign. Default is NEW, and it seems as good as any at
this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116803] Crash on third file opening

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=116803

--- Comment #7 from Tomaz Vajngerl  ---
the EMF file has 4747 bitmaps and all of them need to be loaded to render the
file (at elast this is how we do it now). Changing that would need to involve
quite some thinking..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68459] EDITING: frames are jumping and impossible to position correctly with arrow keys

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=68459

--- Comment #18 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107969] FILESAVE: 'SAXParseException: '[word/document.xml line 2]: Extra content at the end of the document' error after roundtrip

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107969

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115718] Can't erase text in watch text box macro IDE (KDE4)

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=115718

--- Comment #8 from Donald  ---
I can confirm this happens for me in -
"Version: 5.4.6.2
Build ID: 5.4.6-2
CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: en-NZ (en_NZ.UTF-8); Calc: group"
(copied from Help about.)

I tried safe mode as well but I still have the same problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117714] Libreoffice Calc issues with function (named "procv" in portuguese) that returns wrong values

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117714

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #2 from m.a.riosv  ---
You are missing the fourth parameter of the function, what is needed if the
searched list it is not sorted.

B9 =VLOOKUP(A9;$'Prices database'.$A$4:$'Prices database'.$C$33;2;0)

works fine.

Resolved as not a bug, please if you are not agree, reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116803] Crash on third file opening

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=116803

--- Comment #6 from Tomaz Vajngerl  ---
OK so.. the exact scenario doesn't happen with LO 6.0 but by third opening it
alos crashes because of 1 open GDI handles. So this is not directly a
problem with the image handling rework, it just made the behaviour of the crash
a bit different. 

In LO 6.0 the GDI handles also aren't cleared when the document is closed, so
it clearly is a GDI handle leak we have in EMF/WMF code somewhere (or somewhere
else but triggered by EMF/WMF import code). I'll try to find the source of the
leak but it is clear that the bug is miscategorized.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

2018-05-20 Thread Bjoern Michaelsen 
 sw/source/core/unocore/unobkm.cxx |   62 ++
 1 file changed, 30 insertions(+), 32 deletions(-)

New commits:
commit 6e7e4d9f02f286ccb817cb2c1f54a951dcebffad
Author: Bjoern Michaelsen 
Date:   Thu May 10 10:51:42 2018 +0200

dont use SwClient/SwModify in unocore: Bookmark

Change-Id: Iea03642c6b1de1160b98e3b61e831588bb6207b7
Reviewed-on: https://gerrit.libreoffice.org/54609
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/source/core/unocore/unobkm.cxx 
b/sw/source/core/unocore/unobkm.cxx
index e113645bc4aa..2149ba0614f6 100644
--- a/sw/source/core/unocore/unobkm.cxx
+++ b/sw/source/core/unocore/unobkm.cxx
@@ -18,10 +18,16 @@
  */
 
 #include 
-#include 
+
 #include 
+#include 
+#include 
 #include 
+#include 
+#include 
+#include 
 #include 
+#include 
 
 #include 
 #include 
@@ -34,30 +40,25 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
-#include 
 
 using namespace ::sw::mark;
 using namespace ::com::sun::star;
 
 class SwXBookmark::Impl
-: public SwClient
+: public SvtListener
 {
 private:
 ::osl::Mutex m_Mutex; // just for OInterfaceContainerHelper2
 
 public:
 uno::WeakReference m_wThis;
-::comphelper::OInterfaceContainerHelper2  m_EventListeners;
-SwDoc * m_pDoc;
-::sw::mark::IMark * m_pRegisteredBookmark;
-OUStringm_sMarkName;
+::comphelper::OInterfaceContainerHelper2 m_EventListeners;
+SwDoc* m_pDoc;
+::sw::mark::IMark* m_pRegisteredBookmark;
+OUString m_sMarkName;
 
 Impl( SwDoc *const pDoc )
-: SwClient()
-, m_EventListeners(m_Mutex)
+: m_EventListeners(m_Mutex)
 , m_pDoc(pDoc)
 , m_pRegisteredBookmark(nullptr)
 {
@@ -66,37 +67,34 @@ public:
 
 void registerInMark(SwXBookmark & rThis, ::sw::mark::IMark *const pBkmk);
 protected:
-// SwClient
-virtual void Modify( const SfxPoolItem *pOld, const SfxPoolItem *pNew) 
override;
+virtual void Notify(const SfxHint&) override;
 
 };
 
-void SwXBookmark::Impl::Modify(const SfxPoolItem *pOld, const SfxPoolItem 
*pNew)
+void SwXBookmark::Impl::Notify(const SfxHint& rHint)
 {
-ClientModify(this, pOld, pNew);
-if (GetRegisteredIn())
+if(rHint.GetId() == SfxHintId::Dying)
 {
-return; // core object still alive
-}
-
-m_pRegisteredBookmark = nullptr;
-m_pDoc = nullptr;
-uno::Reference const xThis(m_wThis);
-if (!xThis.is())
-{   // fdo#72695: if UNO object is already dead, don't revive it with event
-return;
+m_pRegisteredBookmark = nullptr;
+m_pDoc = nullptr;
+uno::Reference const xThis(m_wThis);
+if (!xThis.is())
+{   // fdo#72695: if UNO object is already dead, don't revive it with 
event
+return;
+}
+lang::EventObject const ev(xThis);
+m_EventListeners.disposeAndClear(ev);
 }
-lang::EventObject const ev(xThis);
-m_EventListeners.disposeAndClear(ev);
 }
 
-void SwXBookmark::Impl::registerInMark(SwXBookmark & rThis,
-::sw::mark::IMark *const pBkmk)
+void SwXBookmark::Impl::registerInMark(SwXBookmark& rThis,
+::sw::mark::IMark* const pBkmk)
 {
-const uno::Reference xBookmark(& rThis);
+const uno::Reference xBookmark();
 if (pBkmk)
 {
-pBkmk->Add(this);
+EndListeningAll();
+StartListening(pBkmk->GetNotifier());
 ::sw::mark::MarkBase *const pMarkBase(dynamic_cast< 
::sw::mark::MarkBase * >(pBkmk));
 OSL_ENSURE(pMarkBase, "registerInMark: no MarkBase?");
 if (pMarkBase)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 117708] Expose exporting as SVG slideshow as a separate menu option ( or similar)

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117708

--- Comment #2 from Tomaz Vajngerl  ---
Or maybe we should just add a dialog (like some picture export formats already
have) when SVG is chosen, where the user selects what kind of export should
actually be performed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 117708] Expose exporting as SVG slideshow as a separate menu option ( or similar)

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117708

--- Comment #2 from Tomaz Vajngerl  ---
Or maybe we should just add a dialog (like some picture export formats already
have) when SVG is chosen, where the user selects what kind of export should
actually be performed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs on Debian 9

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117601

Samuel  changed:

   What|Removed |Added

Summary|Crash in:   |Crash in:
   |libstdc++.so.6.0.22 on  |libstdc++.so.6.0.22 on
   |merge cells in writer with  |merge cells in writer with
   |TDF .debs   |TDF .debs on Debian 9

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117601

--- Comment #11 from Samuel  ---
Thanks for feedback.
Since the most (if not all) crash reports on a Debian kernel it must a problem
between Debian 9, .debs from TDF and LibreOffice 6.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107576] Undocked sidebar has two scroll bar for Shapes deck/tab

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107576

--- Comment #6 from baffclan  ---
Reproduce with LibO 6.1 master(x64) on Windows10 pro

Version: 6.1.0.0.alpha1+ (x64)
Build ID: ea33ae5ef0a9d6b03fdef6503066100d0ae12729
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2018-05-03_14:09:58
Locale: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107750] Previews of drawing & presentation styles not rendered in Styles and Formatting deck in Impress /Draw

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107750

--- Comment #4 from baffclan  ---
Reproduce with LibO 6.1 master(x64) on Windows10 pro

Version: 6.1.0.0.alpha1+ (x64)
Build ID: ea33ae5ef0a9d6b03fdef6503066100d0ae12729
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2018-05-03_14:09:58
Locale: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: help3xsl/online_transform.xsl

2018-05-20 Thread Olivier Hallot 
 help3xsl/online_transform.xsl |   76 ++
 1 file changed, 70 insertions(+), 6 deletions(-)

New commits:
commit a9cecd08312f8115c657a640a05bb91f21248f0a
Author: Olivier Hallot 
Date:   Sun May 20 09:43:01 2018 -0300

Add support for localized collateral files

Fix src

Change-Id: I4997884f087b625c8ac8dbf923363d97f88f7922
Reviewed-on: https://gerrit.libreoffice.org/54599
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl
index 1e59921ec..9839891ba 100644
--- a/help3xsl/online_transform.xsl
+++ b/help3xsl/online_transform.xsl
@@ -1125,39 +1125,69 @@
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
+
+
+
+
+
 
 
-
+
 
 
 
@@ -1293,4 +1323,38 @@
 
 
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2018-05-20 Thread Olivier Hallot 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1e9304e2b0a7f28254831ca47f108de28f6999c9
Author: Olivier Hallot 
Date:   Sun May 20 09:43:01 2018 -0300

Updated core
Project: help  a9cecd08312f8115c657a640a05bb91f21248f0a

Add support for localized collateral files

Fix src

Change-Id: I4997884f087b625c8ac8dbf923363d97f88f7922
Reviewed-on: https://gerrit.libreoffice.org/54599
Tested-by: Jenkins 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 4efd1d34c0c0..a9cecd08312f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 4efd1d34c0c0575f167e06589f24f8bd255c49ba
+Subproject commit a9cecd08312f8115c657a640a05bb91f21248f0a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Tinderbox@42 test failures

2018-05-20 Thread Thorsten Behrens 
Khaled Hosny wrote:
> Here is a revert of the only commit that looks relevant
> https://gerrit.libreoffice.org/#/c/54567/, no idea if it will fix it.
> 
Yep, a local cherry-pick of that one solves the issue. I'm running a
3rd build now to be extra-sure & then merge the patch.

Cheers,

-- Thorsten
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - include/xmloff xmloff/source

2018-05-20 Thread Caolán McNamara 
 include/xmloff/xmlimp.hxx   |2 +-
 xmloff/source/core/xmlictxt.cxx |6 +++---
 xmloff/source/core/xmlimp.cxx   |   10 +-
 3 files changed, 13 insertions(+), 5 deletions(-)

New commits:
commit 3e50044ba41410b9f6a6879f71cdb8314a6d56c3
Author: Caolán McNamara 
Date:   Wed Apr 11 12:31:36 2018 +0100

crashtesting: assert on fdo62508-1.odt

document, with meta:generator of "opxml2odf - Version KO 0.1" has
a styles.xml xmlns of...

xmlns:ofo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0"

instead of the usual xmlns:fo=...

use the importer namespace map to get the importers namespace prefix
for the fastparser namespace uri for the token

Change-Id: Ib633009f6c2b7dae5a3ceb1c921adfff84e21150
Reviewed-on: https://gerrit.libreoffice.org/52720
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/54548
Tested-by: Jenkins 
Reviewed-by: Michael Stahl 

diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index b6552a297843..642c5b2e652b 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -376,7 +376,7 @@ public:
 XMLEventImportHelper& GetEventImport();
 
 static const OUString getNameFromToken( sal_Int32 nToken );
-static const OUString getNamespacePrefixFromToken( sal_Int32 nToken );
+static const OUString getNamespacePrefixFromToken(sal_Int32 nToken, const 
SvXMLNamespaceMap* pMap);
 
 SvXMLNamespaceMap& GetNamespaceMap() { return *mpNamespaceMap; }
 const SvXMLNamespaceMap& GetNamespaceMap() const { return *mpNamespaceMap; 
}
diff --git a/xmloff/source/core/xmlictxt.cxx b/xmloff/source/core/xmlictxt.cxx
index cc5f46ce0c48..832cd5a2c7bf 100644
--- a/xmloff/source/core/xmlictxt.cxx
+++ b/xmloff/source/core/xmlictxt.cxx
@@ -70,7 +70,7 @@ void SvXMLImportContext::Characters( const OUString& )
 void SAL_CALL SvXMLImportContext::startFastElement(sal_Int32 nElement, const 
uno::Reference< xml::sax::XFastAttributeList > & Attribs)
 {
 mrImport.isFastContext = false;
-startUnknownElement( SvXMLImport::getNamespacePrefixFromToken( nElement ),
+startUnknownElement( SvXMLImport::getNamespacePrefixFromToken(nElement, 
().GetNamespaceMap()),
  SvXMLImport::getNameFromToken( nElement ), Attribs );
 }
 
@@ -99,7 +99,7 @@ void SAL_CALL SvXMLImportContext::startUnknownElement(const 
OUString & rPrefix,
 for( auto  : *pAttribList )
 {
 sal_Int32 nToken = it.getToken();
-const OUString& rAttrNamespacePrefix = 
SvXMLImport::getNamespacePrefixFromToken( nToken );
+const OUString& rAttrNamespacePrefix = 
SvXMLImport::getNamespacePrefixFromToken(nToken, 
().GetNamespaceMap());
 OUString sAttrName = SvXMLImport::getNameFromToken( nToken );
 if ( !rAttrNamespacePrefix.isEmpty() )
 sAttrName = rAttrNamespacePrefix + ":" + sAttrName;
@@ -129,7 +129,7 @@ void SAL_CALL SvXMLImportContext::startUnknownElement(const 
OUString & rPrefix,
 void SAL_CALL SvXMLImportContext::endFastElement(sal_Int32 nElement)
 {
 mrImport.isFastContext = false;
-endUnknownElement( SvXMLImport::getNamespacePrefixFromToken( nElement ),
+endUnknownElement( SvXMLImport::getNamespacePrefixFromToken(nElement, 
().GetNamespaceMap()),
SvXMLImport::getNameFromToken( nElement ) );
 }
 
diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx
index af7a0788bf02..310fae5fc9bb 100644
--- a/xmloff/source/core/xmlimp.cxx
+++ b/xmloff/source/core/xmlimp.cxx
@@ -2038,12 +2038,20 @@ const OUString SvXMLImport::getNameFromToken( sal_Int32 
nToken )
 aSeq.getConstArray() ), aSeq.getLength(), 
RTL_TEXTENCODING_UTF8 );
 }
 
-const OUString SvXMLImport::getNamespacePrefixFromToken( sal_Int32 nToken )
+const OUString SvXMLImport::getNamespacePrefixFromToken(sal_Int32 nToken, 
const SvXMLNamespaceMap* pMap)
 {
 sal_Int32 nNamespaceToken = ( nToken & NMSP_MASK ) >> NMSP_SHIFT;
 auto aIter( aNamespaceMap.find( nNamespaceToken ) );
 if( aIter != aNamespaceMap.end() )
+{
+if (pMap)
+{
+OUString sRet = 
pMap->GetPrefixByKey(pMap->GetKeyByName((*aIter).second.second));
+if (!sRet.isEmpty())
+return sRet;
+}
 return (*aIter).second.first;
+}
 else
 return OUString();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 113973] linux mouse copy does not work correctly

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113973

Michael Lashkevich  changed:

   What|Removed |Added

 Status|NEEDINFO|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113973] linux mouse copy does not work correctly

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113973

--- Comment #11 from Michael Lashkevich  ---
Recently, I installed 6.0.4.2. The problem has not yet been solved.

It is really possible to copy by left-button - middle-button within a document
or between different LibreOffice windows, but the copied text does not go the
the system clipboard (either an empty string or the first letter goes their),
so that you cannot copy it to any other application (editor, browser, mail
client etc.) without makin Ctrl-C in the LibreOffice window.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75260] double line border styles wrongly displayed

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75260

--- Comment #43 from Robert Cabane  ---
Using LO 6.0.3 I discovered this bug, apparently still not solved. The PDF
output appears flawed in the same manner.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75260] double line border styles wrongly displayed

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=75260

--- Comment #42 from Robert Cabane  ---
Created attachment 142220
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142220=edit
Paragraphs with double line borders

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

2018-05-20 Thread Bjoern Michaelsen 
 sw/inc/IMark.hxx   |1 
 sw/source/core/unocore/unoobj2.cxx |   76 ++---
 2 files changed, 38 insertions(+), 39 deletions(-)

New commits:
commit db608e8e5e27cce8eeda26918bcab71222d342df
Author: Bjoern Michaelsen 
Date:   Thu May 10 10:51:42 2018 +0200

dont use SwClient/SwModify in unocore: TextRange

Change-Id: Ib87647671776e9c6ef5a9c5a7b75a638452b4555
Reviewed-on: https://gerrit.libreoffice.org/54605
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/IMark.hxx b/sw/inc/IMark.hxx
index dfb73b8f9e0c..39ff1d7108eb 100644
--- a/sw/inc/IMark.hxx
+++ b/sw/inc/IMark.hxx
@@ -38,6 +38,7 @@ namespace sw { namespace mark
 class SW_DLLPUBLIC IMark
 : virtual public SwModify // inherited as interface
 , public ::boost::totally_ordered
+, virtual public sw::BroadcasterMixin
 {
 protected:
 IMark() = default;
diff --git a/sw/source/core/unocore/unoobj2.cxx 
b/sw/source/core/unocore/unoobj2.cxx
index 05854b1faf0f..193b400cb0e2 100644
--- a/sw/source/core/unocore/unoobj2.cxx
+++ b/sw/source/core/unocore/unoobj2.cxx
@@ -21,7 +21,20 @@
 
 #include 
 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
@@ -41,7 +54,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -61,9 +73,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -81,9 +90,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
 #include 
 #include 
@@ -97,9 +103,7 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -109,8 +113,6 @@
 #include 
 #include 
 #include 
-#include 
-#include 
 
 using namespace ::com::sun::star;
 
@@ -679,30 +681,27 @@ uno::Any SAL_CALL 
SwXParagraphEnumerationImpl::nextElement()
 }
 
 class SwXTextRange::Impl
-: public SwClient
+: public SvtListener
 {
 public:
 const SfxItemPropertySet& m_rPropSet;
 const enum RangePosition m_eRangePosition;
 SwDoc& m_rDoc;
 uno::Reference m_xParentText;
-sw::WriterMultiListener m_aMultiListener;
-const ::sw::mark::IMark* m_pMark;
 const SwFrameFormat* m_pTableFormat;
+const ::sw::mark::IMark* m_pMark;
 
-Impl(SwDoc & rDoc, const enum RangePosition eRange,
+Impl(SwDoc& rDoc, const enum RangePosition eRange,
 SwFrameFormat* const pTableFormat,
 const uno::Reference& xParent = nullptr)
-: SwClient()
-, m_rPropSet(*aSwMapProvider.GetPropertySet(PROPERTY_MAP_TEXT_CURSOR))
+: m_rPropSet(*aSwMapProvider.GetPropertySet(PROPERTY_MAP_TEXT_CURSOR))
 , m_eRangePosition(eRange)
 , m_rDoc(rDoc)
 , m_xParentText(xParent)
-, m_aMultiListener(*this)
-, m_pMark(nullptr)
 , m_pTableFormat(pTableFormat)
+, m_pMark(nullptr)
 {
-m_aMultiListener.StartListening(pTableFormat);
+m_pTableFormat && StartListening(pTableFormat->GetNotifier());
 }
 
 virtual ~Impl() override
@@ -718,30 +717,30 @@ public:
 m_rDoc.getIDocumentMarkAccess()->deleteMark(m_pMark);
 m_pMark = nullptr;
 }
+m_pTableFormat = nullptr;
+EndListeningAll();
 }
 
-const ::sw::mark::IMark * GetBookmark() const { return m_pMark; }
+const ::sw::mark::IMark* GetBookmark() const { return m_pMark; }
+void SetMark(::sw::mark::IMark& rMark)
+{
+EndListeningAll();
+m_pTableFormat = nullptr;
+m_pMark = 
+StartListening(rMark.GetNotifier());
+}
 
 protected:
-// SwClient
-virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
+virtual void Notify(const SfxHint&) override;
 };
 
-void SwXTextRange::Impl::SwClientNotify(const SwModify& rModify, const 
SfxHint& rHint)
+void SwXTextRange::Impl::Notify(const SfxHint& rHint)
 {
-assert(!GetRegisteredIn()); // we should only listen with the 
WriterMultiListener from now on
-if(auto pModifyChangedHint = dynamic_cast())
+if(rHint.GetId() == SfxHintId::Dying)
 {
-if(pModifyChangedHint->m_pNew == nullptr)
-{
-m_aMultiListener.EndListeningAll();
-m_pMark = nullptr;
-m_pTableFormat = nullptr;
-}
-else if( == m_pMark)
-m_pMark = dynamic_cast(pModifyChangedHint->m_pNew);
-else if( == m_pTableFormat)
-m_pTableFormat = dynamic_cast(pModifyChangedHint->m_pNew);
+EndListeningAll();
+m_pTableFormat = nullptr;
+m_pMark = nullptr;
 }
 }
 
@@ -788,9 +787,8 @@ void SwXTextRange::SetPositions(const SwPaM& rPam)
 {
 m_pImpl->Invalidate();
 IDocumentMarkAccess*

Crash test update

2018-05-20 Thread Crashtest VM 
New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/b91d31861418a6b60ea55f5ae8e709d56be323ff/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: basegfx/test

2018-05-20 Thread Caolán McNamara 
 basegfx/test/boxclipper.cxx |2 +-
 basegfx/test/clipstate.cxx  |2 +-
 basegfx/test/genericclipper.cxx |4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit b0a5d36c12ce4ba6f1d280e00062302c9bf1fba0
Author: Caolán McNamara 
Date:   Sat May 19 21:40:24 2018 +0100

coverity#1435682 Unchecked return value

and

coverity#1435683 Unchecked return value
coverity#1435685 Unchecked return value

Change-Id: I089d6bdfc80f18c38402b61177d85505fc4c4b36
Reviewed-on: https://gerrit.libreoffice.org/54589
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/basegfx/test/boxclipper.cxx b/basegfx/test/boxclipper.cxx
index 90dbad7d5066..f155c6a73b34 100644
--- a/basegfx/test/boxclipper.cxx
+++ b/basegfx/test/boxclipper.cxx
@@ -161,7 +161,7 @@ public:
 #else
 const char randomSvg[]="m394 
783h404v57h-404zm-197-505h571v576h-571zm356-634h75v200h-75zm-40-113h403v588h-403zm93-811h111v494h-111zm-364-619h562v121h-562zm-134-8h292v27h-292zm110
 
356h621v486h-621zm78-386h228v25h-228zm475-345h201v201h-201zm-2-93h122v126h-122zm-417-243h567v524h-567zm-266-738h863v456h-863zm262-333h315v698h-315zm-328-826h43v393h-43zm830-219h120v664h-120zm-311-636h221v109h-221zm-500
 
137h628v19h-628zm681-94h211v493h-211zm-366-646h384v355h-384zm-189-199h715v247h-715zm165-459h563v601h-563zm258-479h98v606h-98zm270-517h65v218h-65zm-44-259h96v286h-96zm-599-202h705v468h-705zm216-803h450v494h-450zm-150-22h26v167h-26zm-55-599h50v260h-50zm190-278h490v387h-490zm-290-453h634v392h-634zm257
 
189h552v300h-552zm-151-690h136v455h-136zm12-597h488v432h-488zm501-459h48v39h-48zm-224-112h429v22h-429zm-281
 
102h492v621h-492zm519-158h208v17h-208zm-681-563h56v427h-56zm126-451h615v392h-615zm-47-410h598v522h-598zm-32
 316h79v110h-79zm-71-129h18v127h-18zm126-993h743v589h-743zm211-430h428v750h-
 
428zm61-554h100v220h-100zm-353-49h658v157h-658zm778-383h115v272h-115zm-249-541h119v712h-119zm203
 86h94v40h-94z";
 B2DPolyPolygon randomPoly;
-utils::importFromSvgD(randomPoly, randomSvg, false, nullptr);
+CPPUNIT_ASSERT(utils::importFromSvgD(randomPoly, randomSvg, false, 
nullptr));
 for (auto const& aPolygon : randomPoly)
 aRandomIntersections.appendElement(aPolygon.getB2DRange(), 
B2VectorOrientation::Negative);
 #endif
diff --git a/basegfx/test/clipstate.cxx b/basegfx/test/clipstate.cxx
index 5a8409bf39d5..4c64891c16aa 100644
--- a/basegfx/test/clipstate.cxx
+++ b/basegfx/test/clipstate.cxx
@@ -135,7 +135,7 @@ public:
 const char unionSvg[]="m100 
10v90h-90v10h-20v-10h-90v-90h-10v-20h10v-90h90v-10h20v10h90v90h10v20z";
 
 B2DPolyPolygon aTmp1;
-utils::importFromSvgD(aTmp1, unionSvg, false, nullptr);
+CPPUNIT_ASSERT(utils::importFromSvgD(aTmp1, unionSvg, false, nullptr));
 
 aMixedClip.intersectPolyPolygon(aTmp1);
 aMixedClip.subtractRange(B2DRange(-20,-150,20,0));
diff --git a/basegfx/test/genericclipper.cxx b/basegfx/test/genericclipper.cxx
index dcd912f5dd5c..551eaac1f8a0 100644
--- a/basegfx/test/genericclipper.cxx
+++ b/basegfx/test/genericclipper.cxx
@@ -133,8 +133,8 @@ public:
 OUString aValid=OUString::createFromAscii(pValidSvgD);
 B2DPolyPolygon aInputPoly, aValidPoly;
 
-utils::importFromSvgD(aInputPoly, aInput, false, nullptr);
-utils::importFromSvgD(aValidPoly, aValid, false, nullptr);
+CPPUNIT_ASSERT(utils::importFromSvgD(aInputPoly, aInput, false, 
nullptr));
+CPPUNIT_ASSERT(utils::importFromSvgD(aValidPoly, aValid, false, 
nullptr));
 
 CPPUNIT_ASSERT_EQUAL_MESSAGE(
 pName,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - editeng/source sd/source

2018-05-20 Thread Caolán McNamara 
 editeng/source/misc/svxacorr.cxx |2 +-
 sd/source/ui/view/viewshe2.cxx   |   13 -
 2 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit ca11699dbb5c721d527d68e4b68b4eac0d1a7a74
Author: Caolán McNamara 
Date:   Sat May 19 21:37:37 2018 +0100

coverity#1435678 Resource leak

Change-Id: I994508d0d88fa6727c49d568956887ca1d22ce7e
Reviewed-on: https://gerrit.libreoffice.org/54588
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sd/source/ui/view/viewshe2.cxx b/sd/source/ui/view/viewshe2.cxx
index 6c1ad846131c..2b45314c419a 100644
--- a/sd/source/ui/view/viewshe2.cxx
+++ b/sd/source/ui/view/viewshe2.cxx
@@ -478,8 +478,13 @@ void ViewShell::SetPageSizeAndBorder(PageKind ePageKind, 
const Size& rNewSize,
 return;
 }
 
-SdUndoGroup* pUndoGroup(new SdUndoGroup(GetDoc()));
-pUndoGroup->SetComment(SdResId(STR_UNDO_CHANGE_PAGEFORMAT));
+SdUndoGroup* pUndoGroup(nullptr);
+SfxViewShell* pViewShell(GetViewShell());
+if (pViewShell)
+{
+pUndoGroup = new SdUndoGroup(GetDoc());
+pUndoGroup->SetComment(SdResId(STR_UNDO_CHANGE_PAGEFORMAT));
+}
 Broadcast (ViewShellHint(ViewShellHint::HINT_PAGE_RESIZE_START));
 
 // use Model-based method at SdDrawDocument
@@ -503,9 +508,7 @@ void ViewShell::SetPageSizeAndBorder(PageKind ePageKind, 
const Size& rNewSize,
 }
 
 // handed over undo group to undo manager
-SfxViewShell* pViewShell(GetViewShell());
-
-if(nullptr != pViewShell)
+if (pViewShell)
 {
 
pViewShell->GetViewFrame()->GetObjectShell()->GetUndoManager()->AddUndoAction(pUndoGroup);
 }
commit d437650712ff05475e1f3e8b2b4dd8fc47b1d8aa
Author: Caolán McNamara 
Date:   Sat May 19 21:32:37 2018 +0100

coverity#1435680 silence Unchecked return value

Change-Id: Ie7e7f234d32a42ec4747f20172e92c6edc637faf
Reviewed-on: https://gerrit.libreoffice.org/54587
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 70daa82e3a88..556f60b9c426 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -2649,7 +2649,7 @@ bool 
SvxAutocorrWordList::Insert(std::unique_ptr pWord) const
 void SvxAutocorrWordList::LoadEntry(const OUString& sWrong, const OUString& 
sRight, bool bOnlyTxt)
 {
 std::unique_ptr pNew(new SvxAutocorrWord( sWrong, sRight, 
bOnlyTxt ));
-Insert( std::move(pNew) );
+(void)Insert(std::move(pNew));
 }
 
 bool SvxAutocorrWordList::empty() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svx/source

2018-05-20 Thread Caolán McNamara 
 svx/source/xoutdev/_xoutbmp.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 89e54a995e19e1be46e666800a9b99a9cd1b3fd0
Author: Caolán McNamara 
Date:   Sat May 19 21:30:08 2018 +0100

coverity#1435686 silence Copy-paste error

Change-Id: I017307e9b125dd0fe970736c6ebe482f08d54e90
Reviewed-on: https://gerrit.libreoffice.org/54586
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/svx/source/xoutdev/_xoutbmp.cxx b/svx/source/xoutdev/_xoutbmp.cxx
index d2437cbfc25c..1e57b09bfe3c 100644
--- a/svx/source/xoutdev/_xoutbmp.cxx
+++ b/svx/source/xoutdev/_xoutbmp.cxx
@@ -591,6 +591,7 @@ tools::Polygon XOutBitmap::GetContour( const Bitmap& rBmp, 
const XOutFlags nFlag
 // this loop always breaks eventually as there is 
at least one pixel
 while( true )
 {
+// coverity[copy_paste_error] - this is 
correct nX, not nY
 if( aBlack == pAcc->GetPixelFromData( 
pScanline, nX ) )
 {
 pPoints2[ nPolyPos ] = Point( nX, nY );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: cui/source

2018-05-20 Thread Caolán McNamara 
 cui/source/dialogs/SignSignatureLineDialog.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0abc99de2c98f57ee3846b0e689aed08b7c626af
Author: Caolán McNamara 
Date:   Sat May 19 21:28:25 2018 +0100

coverity#1435684 deliberate 'Constant' variable guards dead code

Change-Id: I0a5b36ad781bfc76295e91131bdc073dac0d6ea2
Reviewed-on: https://gerrit.libreoffice.org/54585
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx 
b/cui/source/dialogs/SignSignatureLineDialog.cxx
index a9fd2a506110..9f793884862e 100644
--- a/cui/source/dialogs/SignSignatureLineDialog.cxx
+++ b/cui/source/dialogs/SignSignatureLineDialog.cxx
@@ -147,7 +147,7 @@ void SignSignatureLineDialog::Apply()
 SfxObjectShell* pShell = SfxObjectShell::Current();
 pShell->SignSignatureLine(m_aSignatureLineId, m_xSelectedCertifate);
 
-bool bSuccess = false; // TODO
+const bool bSuccess = false; // TODO
 
 if (bSuccess)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source sc/uiconfig

2018-05-20 Thread Caolán McNamara 
 sc/inc/scabstdlg.hxx |2 -
 sc/qa/unit/screenshots/screenshots.cxx   |2 -
 sc/source/ui/attrdlg/scdlgfact.cxx   |   13 +---
 sc/source/ui/attrdlg/scdlgfact.hxx   |   10 +-
 sc/source/ui/dbgui/dapidata.cxx  |   49 ---
 sc/source/ui/inc/dapidata.hxx|   18 ---
 sc/source/ui/view/cellsh1.cxx|9 +
 sc/uiconfig/scalc/ui/selectdatasource.ui |   26 ++--
 8 files changed, 57 insertions(+), 72 deletions(-)

New commits:
commit 7b4a3cefdd1137ce2e42616b2fb1dcf77d01db7b
Author: Caolán McNamara 
Date:   Sat May 19 21:21:11 2018 +0100

weld ScDataPilotDatabaseDlg

Change-Id: Ie8e9914bb8042e33a2ab2a1e07bb0203a54d5422
Reviewed-on: https://gerrit.libreoffice.org/54584
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 7032ab97c8c7..b1b33b94b162 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -414,7 +414,7 @@ public:
 
 virtual VclPtr 
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const 
ScConditionalFormatList* pFormatList ) = 0;
 
-virtual VclPtr 
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) = 0;
+virtual VclPtr 
CreateScDataPilotDatabaseDlg(weld::Window* pParent) = 0;
 
 virtual VclPtr 
CreateScDataPilotSourceTypeDlg(weld::Window* pParent,
 bool bEnableExternal) = 0;
diff --git a/sc/qa/unit/screenshots/screenshots.cxx 
b/sc/qa/unit/screenshots/screenshots.cxx
index 5438f738db7b..59a10ef21dd9 100644
--- a/sc/qa/unit/screenshots/screenshots.cxx
+++ b/sc/qa/unit/screenshots/screenshots.cxx
@@ -178,7 +178,7 @@ VclPtr 
ScScreenshotTest::createDialogByID(sal_uInt32 nID)
 
 case 4: // "modules/scalc/ui/selectdatasource.ui"
 {
-pReturnDialog = 
mpFact->CreateScDataPilotDatabaseDlg(mpViewShell->GetDialogParent());
+pReturnDialog = 
mpFact->CreateScDataPilotDatabaseDlg(mpViewShell->GetFrameWeld());
 break;
 }
 case 5: // "modules/scalc/ui/selectsource.ui"
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx 
b/sc/source/ui/attrdlg/scdlgfact.cxx
index dfedd10a54a2..2d00bc0ed0a7 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -84,7 +84,11 @@ short AbstractScColRowLabelDlg_Impl::Execute()
 }
 
 IMPL_ABSTDLG_BASE(AbstractScCondFormatManagerDlg_Impl);
-IMPL_ABSTDLG_BASE(AbstractScDataPilotDatabaseDlg_Impl);
+
+short AbstractScDataPilotDatabaseDlg_Impl::Execute()
+{
+return m_xDlg->run();
+}
 
 short AbstractScDataPilotSourceTypeDlg_Impl::Execute()
 {
@@ -255,7 +259,7 @@ bool AbstractScColRowLabelDlg_Impl::IsRow()
 
 void AbstractScDataPilotDatabaseDlg_Impl::GetValues( ScImportSourceDesc& rDesc 
)
 {
-pDlg->GetValues(rDesc);
+m_xDlg->GetValues(rDesc);
 }
 
 bool AbstractScDataPilotSourceTypeDlg_Impl::IsDatabase() const
@@ -719,10 +723,9 @@ VclPtr 
ScAbstractDialogFactory_Impl::CreateScCon
 return VclPtr::Create( pDlg );
 }
 
-VclPtr 
ScAbstractDialogFactory_Impl::CreateScDataPilotDatabaseDlg(vcl::Window* pParent)
+VclPtr 
ScAbstractDialogFactory_Impl::CreateScDataPilotDatabaseDlg(weld::Window* 
pParent)
 {
-VclPtr pDlg = 
VclPtr::Create( pParent );
-return VclPtr::Create( pDlg );
+return VclPtr::Create(new 
ScDataPilotDatabaseDlg(pParent));
 }
 
 VclPtr 
ScAbstractDialogFactory_Impl::CreateScDataPilotSourceTypeDlg(
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx 
b/sc/source/ui/attrdlg/scdlgfact.hxx
index a27a52ab26d7..50f206cb5ac6 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -142,7 +142,13 @@ class AbstractScCondFormatManagerDlg_Impl : public 
AbstractScCondFormatManagerDl
 
 class AbstractScDataPilotDatabaseDlg_Impl  :public 
AbstractScDataPilotDatabaseDlg
 {
-DECL_ABSTDLG_BASE(AbstractScDataPilotDatabaseDlg_Impl, 
ScDataPilotDatabaseDlg)
+std::unique_ptr m_xDlg;
+public:
+explicit AbstractScDataPilotDatabaseDlg_Impl(ScDataPilotDatabaseDlg* p)
+: m_xDlg(p)
+{
+}
+virtual short Execute() override;
 virtual voidGetValues( ScImportSourceDesc& rDesc ) override;
 };
 
@@ -526,7 +532,7 @@ public:
 
 virtual VclPtr 
CreateScCondFormatMgrDlg(vcl::Window* pParent, ScDocument* pDoc, const 
ScConditionalFormatList* pFormatList ) override;
 
-virtual VclPtr 
CreateScDataPilotDatabaseDlg(vcl::Window* pParent) override;
+virtual VclPtr 
CreateScDataPilotDatabaseDlg(weld::Window* pParent) override;
 
 virtual VclPtr 
CreateScDataPilotSourceTypeDlg(weld::Window* pParent,
 bool bEnableExternal) override;
diff --git a/sc/source/ui/dbgui/dapidata.cxx b/sc/source/ui/dbgui/dapidata.cxx
index 4e6e36e5eee8..b75b19609916 100644
--- a/sc/source/ui/dbgui/dapidata.cxx
+++ b/sc/source/ui/dbgui/dapidata.cxx
@@ -42,15 +42,13 @@ using

[Libreoffice-commits] core.git: 2 commits - include/sfx2 sfx2/source

2018-05-20 Thread Caolán McNamara 
 include/sfx2/objsh.hxx  |1 -
 sfx2/source/doc/objxtor.cxx |1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ef200af8976087216d6c8ddeac7b2fcaba7ebaa1
Author: Caolán McNamara 
Date:   Sat May 19 21:25:57 2018 +0100

coverity#1435679 Uninitialized scalar field

Change-Id: I5941e14ad36020363a55b4e3d3aa89eba4d7b3c3
Reviewed-on: https://gerrit.libreoffice.org/54583
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index 97d570c7876c..680b1ed8597f 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -207,7 +207,6 @@ private:
   // sal_False := new object
 boolbIsInGenerateThumbnail; //optimize thumbnail 
generate and store procedure to improve odt saving performance, i120030
 boolmbAvoidRecentDocs; ///< Avoid adding to the 
recent documents list, if not necessary.
-bool m_bAllowModifiedBackAfterSigning;
 
 enum TriState   {undefined, yes, no};
 TriStatembContinueImportOnFilterExceptions = 
undefined; // try to import as much as possible
commit 892306b5b73f22f887a512ab75ccee22e1985fa8
Author: Caolán McNamara 
Date:   Sat May 19 21:23:48 2018 +0100

coverity#1338604 Uninitialized scalar field

Change-Id: I4c4c07db527ea2517ed809f693bde4af519e503e
Reviewed-on: https://gerrit.libreoffice.org/54582
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sfx2/source/doc/objxtor.cxx b/sfx2/source/doc/objxtor.cxx
index 3eacd44ab701..a71748111969 100644
--- a/sfx2/source/doc/objxtor.cxx
+++ b/sfx2/source/doc/objxtor.cxx
@@ -249,6 +249,7 @@ SfxObjectShell_Impl::SfxObjectShell_Impl( SfxObjectShell& 
_rDocShell )
 ,m_nModifyPasswordHash( 0 )
 ,m_bModifyPasswordEntered( false )
 ,m_bSavingForSigning( false )
+,m_bAllowModifiedBackAfterSigning( false )
 {
 SfxObjectShell* pDoc = &_rDocShell;
 SfxObjectShellArr_Impl  = SfxGetpApp()->GetObjectShells_Impl();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source sc/uiconfig

2018-05-20 Thread Caolán McNamara 
 sc/inc/scabstdlg.hxx  |2 
 sc/source/ui/attrdlg/scdlgfact.cxx|   13 +-
 sc/source/ui/attrdlg/scdlgfact.hxx|   13 +-
 sc/source/ui/dbgui/pvfundlg.cxx   |   37 ++
 sc/source/ui/inc/pvfundlg.hxx |   20 +--
 sc/source/ui/optdlg/calcoptionsdlg.cxx|   67 ---
 sc/source/ui/optdlg/calcoptionsdlg.hxx|   38 ++
 sc/source/ui/optdlg/tpformula.cxx |9 -
 sc/source/ui/view/cellsh1.cxx |7 -
 sc/uiconfig/scalc/ui/formulacalculationoptions.ui |  130 +++---
 sc/uiconfig/scalc/ui/showdetaildialog.ui  |   51 +++-
 11 files changed, 200 insertions(+), 187 deletions(-)

New commits:
commit 56c9746f294639583ce5422bf909ad9e4a746f70
Author: Caolán McNamara 
Date:   Sat May 19 20:44:59 2018 +0100

weld ScCalcOptionsDialog

Change-Id: I391e26bd95cb3dc6cfa983502aa960a5c54cc800
Reviewed-on: https://gerrit.libreoffice.org/54580
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx 
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index 74e7904249d7..e931a180e8bc 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -72,43 +72,32 @@ sal_Int32 toSelectedItem( 
formula::FormulaGrammar::AddressConvention eConv )
 
 }
 
-ScCalcOptionsDialog::ScCalcOptionsDialog(vcl::Window* pParent, const 
ScCalcConfig& rConfig, bool bWriteConfig)
-: ModalDialog(pParent, "FormulaCalculationOptions",
-"modules/scalc/ui/formulacalculationoptions.ui")
+ScCalcOptionsDialog::ScCalcOptionsDialog(weld::Window* pParent, const 
ScCalcConfig& rConfig, bool bWriteConfig)
+: GenericDialogController(pParent, 
"modules/scalc/ui/formulacalculationoptions.ui", "FormulaCalculationOptions")
 , maConfig(rConfig)
 , mbSelectedEmptyStringAsZero(rConfig.mbEmptyStringAsZero)
 , mbWriteConfig(bWriteConfig)
+, mxEmptyAsZero(m_xBuilder->weld_check_button("checkEmptyAsZero"))
+, mxConversion(m_xBuilder->weld_combo_box_text("comboConversion"))
+, mxCurrentDocOnly(m_xBuilder->weld_check_button("current_doc"))
+, mxSyntax(m_xBuilder->weld_combo_box_text("comboSyntaxRef"))
 {
-get(mpConversion,"comboConversion");
-
mpConversion->SelectEntryPos(static_cast(rConfig.meStringConversion));
-mpConversion->SetSelectHdl(LINK(this, ScCalcOptionsDialog, 
ConversionModifiedHdl));
+mxConversion->set_active(static_cast(rConfig.meStringConversion));
+mxConversion->connect_changed(LINK(this, ScCalcOptionsDialog, 
ConversionModifiedHdl));
 
-get(mpEmptyAsZero,"checkEmptyAsZero");
-mpEmptyAsZero->Check(rConfig.mbEmptyStringAsZero);
-mpEmptyAsZero->SetClickHdl(LINK(this, ScCalcOptionsDialog, 
AsZeroModifiedHdl));
+mxEmptyAsZero->set_active(rConfig.mbEmptyStringAsZero);
+mxEmptyAsZero->connect_toggled(LINK(this, ScCalcOptionsDialog, 
AsZeroModifiedHdl));
 CoupleEmptyAsZeroToStringConversion();
 
-get(mpSyntax,"comboSyntaxRef");
-mpSyntax->SelectEntryPos( toSelectedItem(rConfig.meStringRefAddressSyntax) 
);
-mpSyntax->SetSelectHdl(LINK(this, ScCalcOptionsDialog, SyntaxModifiedHdl));
+mxSyntax->set_active(toSelectedItem(rConfig.meStringRefAddressSyntax));
+mxSyntax->connect_changed(LINK(this, ScCalcOptionsDialog, 
SyntaxModifiedHdl));
 
-get(mpCurrentDocOnly,"current_doc");
-mpCurrentDocOnly->Check(!mbWriteConfig);
-mpCurrentDocOnly->SetClickHdl(LINK(this, ScCalcOptionsDialog, 
CurrentDocOnlyHdl));
+mxCurrentDocOnly->set_active(!mbWriteConfig);
+mxCurrentDocOnly->connect_toggled(LINK(this, ScCalcOptionsDialog, 
CurrentDocOnlyHdl));
 }
 
 ScCalcOptionsDialog::~ScCalcOptionsDialog()
 {
-disposeOnce();
-}
-
-void ScCalcOptionsDialog::dispose()
-{
-mpEmptyAsZero.clear();
-mpConversion.clear();
-mpSyntax.clear();
-mpCurrentDocOnly.clear();
-ModalDialog::dispose();
 }
 
 void ScCalcOptionsDialog::CoupleEmptyAsZeroToStringConversion()
@@ -117,43 +106,43 @@ void 
ScCalcOptionsDialog::CoupleEmptyAsZeroToStringConversion()
 {
 case ScCalcConfig::StringConversion::ILLEGAL:
 maConfig.mbEmptyStringAsZero = false;
-mpEmptyAsZero->Check(false);
-mpEmptyAsZero->Enable(false);
+mxEmptyAsZero->set_active(false);
+mxEmptyAsZero->set_sensitive(false);
 break;
 case ScCalcConfig::StringConversion::ZERO:
 maConfig.mbEmptyStringAsZero = true;
-mpEmptyAsZero->Check();
-mpEmptyAsZero->Enable(false);
+mxEmptyAsZero->set_active(true);
+mxEmptyAsZero->set_sensitive(false);
 break;
 case ScCalcConfig::StringConversion::UNAMBIGUOUS:
 case ScCalcConfig::StringConversion::LOCALE:

[Libreoffice-bugs] [Bug 117365] Decimal separator is not updated on language change

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117365

--- Comment #6 from nurcan...@gmail.com ---
1 Open the example_document
2 Set Default Languages of Documents to English(USA) under the menu Tools>
Language> For All Text> More
3 Save and close the document.
4 Open up the document again. You can see the wrong calculations. 

Changing the Language of locale setting is worked correctly. Only changing the
Default Language of Document is cause that miss calculation.



(In reply to Laurent BP from comment #5)
> I cannot reproduce with Version: 6.0.4.2
> Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
> Threads CPU : 8; OS : Linux 4.13; UI Render : par défaut; VCL: gtk2; 
> Locale : fr-FR (fr_FR.UTF-8); Calc: group
> 
> Could you give a step by step procedure?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117601

--- Comment #10 from raal  ---
(In reply to Samuel from comment #9)
> @ raal,
> 
> on which system do you test this?

Ubuntu 64-bit and I can not reproduce it with 6.1-Master.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117715

kompilainenn <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

For contribution to Libre office Android app.

2018-05-20 Thread ISHU DOHARE 4-Yr B.Tech. Electronics Engg. 
Hello, I wanted to start contributing to Libre office. I am big fan of
Libre on Ubuntu. Pls help how to get started. I have decent experience in
Android
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Need Help to write extension

2018-05-20 Thread Rallavagu 

Hello All,

Need a tutorial/help to get started on writing Libreoffice 
plugin/extension. Essentially, I would like to do the following in my 
plugin.


1. Open a file
2. Verify and convert the file from a format (for instance, decode a 
custom encoded file). If needed prompt the user for decode key with a 
dialog screen.

3. After editing, save with custom encoding.

I intend to use Java as programming language. I have referred to 
https://github.com/smehrbrodt/libreoffice-starter-extension



But, I have no clue where to start. Any help would be appreciated.

Thanks in advance.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 117716] Ubuntu 16.04 didn' t install libreoffice-gnome or libreoffice-kde

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117716

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTOURBUG

--- Comment #1 from Jean-Baptiste Faure  ---
If that is a bug, the bug is on the Ubuntu side. Please file a bug report on
Ubuntu bugtracker: https://bugs.launchpad.net

Closing as NotOurBug.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/js

2018-05-20 Thread Henry Castro 
 loleaflet/js/main.js |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit f364c4a60414348c95514d5efc4bdf9845b739b8
Author: Henry Castro 
Date:   Sun May 20 12:40:25 2018 -0400

loleaflet: finally, remove "map" global variable

Change-Id: I70c2603189e2194b8c9b60f2709f89c7fdf8cbfd

diff --git a/loleaflet/js/main.js b/loleaflet/js/main.js
index 89d99263c..1d0047c3e 100644
--- a/loleaflet/js/main.js
+++ b/loleaflet/js/main.js
@@ -61,9 +61,6 @@ var map = L.map('map', {
idleTimeoutSecs: idleTimeoutSecs,  // Dim when user is idle.
outOfFocusTimeoutSecs: outOfFocusTimeoutSecs // Dim after switching 
tabs.
 });
-// toolbar.js (loaded in

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/control/Control.Menubar.js |   70 +++
 1 file changed, 35 insertions(+), 35 deletions(-)

New commits:
commit 3afaa7ca485643371e601fcd4cedaaa2f58abd35
Author: Henry Castro 
Date:   Sun May 20 12:35:13 2018 -0400

loleaflet: avoid unnecessary "map" global variable in Control.Menubar.js

Change-Id: I7ccea35132e83a594e8ff76693131e259ae41c28

diff --git a/loleaflet/src/control/Control.Menubar.js 
b/loleaflet/src/control/Control.Menubar.js
index d6ec74ca8..8e4d4d120 100644
--- a/loleaflet/src/control/Control.Menubar.js
+++ b/loleaflet/src/control/Control.Menubar.js
@@ -2,7 +2,7 @@
 * Control.Menubar
 */
 
-/* global $ _ _UNO map vex revHistoryEnabled closebutton L */
+/* global $ _ _UNO vex revHistoryEnabled closebutton L */
 L.Control.Menubar = L.Control.extend({
// TODO: Some mechanism to stop the need to copy duplicate menus (eg. 
Help)
options: {
@@ -427,7 +427,7 @@ L.Control.Menubar = L.Control.extend({
 
var liItem = L.DomUtil.create('li', '');
liItem.id = 'menu-' + e.id;
-   if (map._permission === 'readonly') {
+   if (this._map._permission === 'readonly') {
L.DomUtil.addClass(liItem, 'readonly');
}
var aItem = L.DomUtil.create('a', '', liItem);
@@ -575,7 +575,7 @@ L.Control.Menubar = L.Control.extend({
 
_checkedMenu: function(uno, item) {
var constChecked = 'lo-menu-item-checked';
-   var state = map['stateChangeHandler'].getItemValue(uno);
+   var state = this._map['stateChangeHandler'].getItemValue(uno);
var data = $(item).data('tag');
state = state[data] || false;
if (state) {
@@ -592,7 +592,7 @@ L.Control.Menubar = L.Control.extend({
var aItem = this;
var type = $(aItem).data('type');
var id = $(aItem).data('id');
-   if (map._permission === 'edit') {
+   if (self._map._permission === 'edit') {
if (type === 'unocommand') { // enable all 
depending on stored commandStates
var data, lang;
var constUno = 'uno';
@@ -602,7 +602,7 @@ L.Control.Menubar = L.Control.extend({
var constPageHeader = 
'.uno:InsertPageHeader';
var constPageFooter = 
'.uno:InsertPageFooter';
var unoCommand = 
$(aItem).data(constUno);
-   var itemState = 
map[constState].getItemValue(unoCommand);
+   var itemState = 
self._map[constState].getItemValue(unoCommand);
if (itemState === 'disabled') {
$(aItem).addClass('disabled');
} else {
@@ -610,7 +610,7 @@ L.Control.Menubar = L.Control.extend({
}
if 
(unoCommand.startsWith(constLanguage)) {
unoCommand = constLanguage;
-   lang = 
map[constState].getItemValue(unoCommand);
+   lang = 
self._map[constState].getItemValue(unoCommand);
data = 
decodeURIComponent($(aItem).data(constUno));
if (data.indexOf(lang) !== -1) {

$(aItem).addClass(constChecked);
@@ -668,27 +668,27 @@ L.Control.Menubar = L.Control.extend({
_executeAction: function(item) {
var id = $(item).data('id');
if (id === 'save') {
-   map.save(true, true);
+   this._map.save(true, true);
} else if (id === 'saveas') {
-   map.fire('postMessage', {msgId: 'UI_SaveAs'});
+   this._map.fire('postMessage', {msgId: 'UI_SaveAs'});
} else if (id === 'print') {
-   map.print();
+   this._map.print();
} else if (id.startsWith('downloadas-')) {
var format = id.substring('downloadas-'.length);
-   var fileName = map['wopi'].BaseFileName;
+   var fileName = this._map['wopi'].BaseFileName;
fileName = fileName.substr(0, 
fileName.lastIndexOf('.'));
fileName = fileName === '' ? 'document' : fileName;
-   map.downloadAs(fileName + '.' + format, format);
+   this._map.downloadAs(fileName + '.' +

[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117715

Xavier Van Wijmeersch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Xavier Van Wijmeersch  ---
no repro

Version: 6.0.5.0.0+
Build ID: efd59fd1d7fc9d955a2b924f247709201f2281c5
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

Version: 6.1.0.0.alpha1+
Build ID: 8eb15f031003f6431d41853ff70e307b617d1a5a
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: nl-BE (en_US.UTF-8); Calc: group

works for me, if not agree you can reopen as unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117601

--- Comment #9 from Samuel  ---
@ raal,

on which system do you test this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117428] add an option to PDF export dialog to do ActualText per word

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117428

--- Comment #14 from Shree Devi Kumar  ---
(In reply to Khaled Hosny from comment #12)
> (In reply to Shree Devi Kumar from comment #10)
> > (In reply to Khaled Hosny from comment #9)
> > > They keyword for the
> > > proposed changes is “per word”, the new option would skip the algorithm 
> > > and
> > > tags the glyphs if each word with it's text, as a complete unit. 
> > 
> > @Khaled Any update on this? Can you create a patch for this option so that
> > it can be tested?
> 
> I don’t currently have time to work on this, unfortunately.

Ok. Thank you for your work on \Actualtext, it is step in the right direction
to getting fully copyable text from pdfs.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117428] add an option to PDF export dialog to do ActualText per word

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117428

--- Comment #14 from Shree Devi Kumar  ---
(In reply to Khaled Hosny from comment #12)
> (In reply to Shree Devi Kumar from comment #10)
> > (In reply to Khaled Hosny from comment #9)
> > > They keyword for the
> > > proposed changes is “per word”, the new option would skip the algorithm 
> > > and
> > > tags the glyphs if each word with it's text, as a complete unit. 
> > 
> > @Khaled Any update on this? Can you create a patch for this option so that
> > it can be tested?
> 
> I don’t currently have time to work on this, unfortunately.

Ok. Thank you for your work on \Actualtext, it is step in the right direction
to getting fully copyable text from pdfs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 117428] add an option to PDF export dialog to do ActualText per word

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117428

--- Comment #13 from Shree Devi Kumar  ---
(In reply to V Stuart Foote from comment #11)
> I don't believe Khaled has volunteered to tackle the needed refactoring to
> the PDF export filter and GUI.  Check History--clearly not assigned as
> Khaled removed himself, back to NEW

OK. Since he had suggested about opening a new bug for this, I had incorrectly
assumed that he was planning to work on it. 

> 
> Otherwise, is there any objection that implementing an /ActualText flag "per
> word" will mean string selection to copy from PDF will be limited to word
> bounds? Personally I think we need the tagging more than the partial string
> copy. 
> 
> Assuring correct handling combining glyphs and Unicode script--and
> presumably OTF font features when implemented (as for bug 58941)--is the
> desired outcome.
> 
> Justified from a11y perspective, and needed for accuracy supporting CTL
> scripts. 
> 
> Is that the UX consensus?

As a user the ability to copy text from pdf is important. Currently, except for
xelatex, I am not aware of any other method of doing so for Devanagari and
other Indic scripts.

Please see
https://www.wikihow.com/index.php?title=Create-a-Searchable-Hindi-PDF-Using-Lyx-with-Xetex
which is a workaround for users who are not comfortable with XeLatex to create
these searchable/copyable pdfs.

It will be a great benefit to users if this option can be implemented in Libre
Office.

Thank You!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117428] add an option to PDF export dialog to do ActualText per word

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117428

--- Comment #13 from Shree Devi Kumar  ---
(In reply to V Stuart Foote from comment #11)
> I don't believe Khaled has volunteered to tackle the needed refactoring to
> the PDF export filter and GUI.  Check History--clearly not assigned as
> Khaled removed himself, back to NEW

OK. Since he had suggested about opening a new bug for this, I had incorrectly
assumed that he was planning to work on it. 

> 
> Otherwise, is there any objection that implementing an /ActualText flag "per
> word" will mean string selection to copy from PDF will be limited to word
> bounds? Personally I think we need the tagging more than the partial string
> copy. 
> 
> Assuring correct handling combining glyphs and Unicode script--and
> presumably OTF font features when implemented (as for bug 58941)--is the
> desired outcome.
> 
> Justified from a11y perspective, and needed for accuracy supporting CTL
> scripts. 
> 
> Is that the UX consensus?

As a user the ability to copy text from pdf is important. Currently, except for
xelatex, I am not aware of any other method of doing so for Devanagari and
other Indic scripts.

Please see
https://www.wikihow.com/index.php?title=Create-a-Searchable-Hindi-PDF-Using-Lyx-with-Xetex
which is a workaround for users who are not comfortable with XeLatex to create
these searchable/copyable pdfs.

It will be a great benefit to users if this option can be implemented in Libre
Office.

Thank You!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/control/Control.Tabs.js |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 6233a9b4b88ac05369645a46caf3a034128ea3ac
Author: Henry Castro 
Date:   Sun May 20 12:04:24 2018 -0400

loleaflet: avoid unnecessary "map" global variable in Control.Tabs.js

Change-Id: I699f3e9c99c82e4f7765c2870c956fa1d4b90bef

diff --git a/loleaflet/src/control/Control.Tabs.js 
b/loleaflet/src/control/Control.Tabs.js
index 8295f2fd6..4ede783ad 100644
--- a/loleaflet/src/control/Control.Tabs.js
+++ b/loleaflet/src/control/Control.Tabs.js
@@ -2,7 +2,7 @@
  * L.Control.Tabs is used to switch sheets in Calc
  */
 
-/* global $ vex _ _UNO map */
+/* global $ vex _ _UNO */
 L.Control.Tabs = L.Control.extend({
onAdd: function(map) {
map.on('updatepermission', this._onUpdatePermission, this);
@@ -26,6 +26,7 @@ L.Control.Tabs = L.Control.extend({
this._initialized = true;
this._tabsInitialized = false;
this._spreadsheetTabs = {};
+   var map = this._map;
var docContainer = map.options.documentContainer;
this._tabsCont = L.DomUtil.create('div', 
'spreadsheet-tabs-container', docContainer.parentElement);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117716] New: Ubuntu 16.04 didn' t install libreoffice-gnome or libreoffice-kde

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117716

Bug ID: 117716
   Summary: Ubuntu 16.04 didn't install libreoffice-gnome or
libreoffice-kde
   Product: LibreOffice
   Version: 5.4.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kain...@gmail.com

Created attachment 142219
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142219=edit
LibreOffice after fresh installation in KDE Neon User Edition

KDE Neon User edition use Ubuntu 16.04 as base. When I'd like to install
LibreOffice via discover the GUI app installer the different LibreOffice app's
didn't install libreoffice-kde or libreoffice-gnome so after the installation
you see the fallback vcl module.

Please make add libreoffice-kde or libreoffice-gnome as dependency of
LibreOffice installation. I don't know if it's the same in Ubuntu 18.04 when
use the gnome / ubuntu software center as all software centers use the same
base it should be the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/map/handler/Map.Keyboard.js |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 5cd2e2369fe7ea17fcd260734f6cfc9ecc700893
Author: Henry Castro 
Date:   Sun May 20 11:56:15 2018 -0400

loleaflet: avoid unnecessary "map" global variable in Map.Keyboard.js

Change-Id: I2e566157d468699e901c24ad0c23de501297bf2c

diff --git a/loleaflet/src/map/handler/Map.Keyboard.js 
b/loleaflet/src/map/handler/Map.Keyboard.js
index 42d264ce7..9fe846711 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -2,8 +2,6 @@
  * L.Map.Keyboard is handling keyboard interaction with the map, enabled by 
default.
  */
 
-/* global map */
-
 L.Map.mergeOptions({
keyboard: true,
keyboardPanOffset: 20,
@@ -451,7 +449,7 @@ L.Map.Keyboard = L.Handler.extend({
}
 
if (e.originalEvent.ctrlKey && e.originalEvent.shiftKey && 
e.originalEvent.key === '?') {
-   map.showLOKeyboardHelp();
+   this._map.showLOKeyboardHelp();
e.originalEvent.preventDefault();
return true;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/control/Control.ContextMenu.js |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 6e6b56ad1bab68f1beeae97afe40a8667f92d324
Author: Henry Castro 
Date:   Sun May 20 11:51:16 2018 -0400

loleaflet: avoid unnecessary "map" global variable in Control.ContextMenu.js

Change-Id: I9c1a7b6f05537d68306bfb6c4275ca096a4c6c6b

diff --git a/loleaflet/src/control/Control.ContextMenu.js 
b/loleaflet/src/control/Control.ContextMenu.js
index f49e924e4..9a6e53280 100644
--- a/loleaflet/src/control/Control.ContextMenu.js
+++ b/loleaflet/src/control/Control.ContextMenu.js
@@ -2,7 +2,7 @@
 * Control.ContextMenu
 */
 
-/* global $ map _ _UNO */
+/* global $ _ _UNO */
 L.Control.ContextMenu = L.Control.extend({
options: {
SEPARATOR: '-',
@@ -68,6 +68,7 @@ L.Control.ContextMenu = L.Control.extend({
},
 
_onContextMenu: function(obj) {
+   var map = this._map;
if (map._permission !== 'edit') {
return;
}
@@ -93,7 +94,7 @@ L.Control.ContextMenu = L.Control.extend({
},
 
_createContextMenuStructure: function(obj) {
-   var docType = map.getDocType();
+   var docType = this._map.getDocType();
var contextMenu = {};
var sepIdx = 1, itemName;
var isLastItemText = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117672] Make default column type 'Text' when importing CSVs, or warn of data modification

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117672

--- Comment #3 from totalmassret...@gmail.com ---
I'm sure you've researched how your program is used, and so I respect your
views on the most common use cases. There are, however, reasons why one might
try to edit a CSV in Calc and not a simple text editor, such as re-ordering
columns. Or even the simple fact that a user knows Calc can import CSVs and may
prefer to work in that program. While it may not be intended to be a CSV
editor, if it can open and save CSVs (via open/save dialogues, no less -- not
import/export dialogues), then the CSV editor use case exists.

I acknowledge that this use case isn't really concerned with spreadsheet
functionality, and may not line up with how developers might expect users to
use the program.

With that in mind, I'll forget the request to change the default and re-iterate
the later part of the request - that silently modifying the data is not good
practice, and that a warning dialogue be displayed when the user clicks the OK
button in the Text Import dialogue. Such a dialogue would inform the user that
their import settings will modify their data, and perhaps it could even tell
them what to do if they don't want their data modified (change all columns to
'Text'.) That way, if someone imports a CSV with serial numbers in some
off-screen column, they won't unwittingly blow them away.

I feel that default toggles and templates would not address the issue of
unexpected data modification, as they would require prior knowledge of this
issue. Those with prior knowledge of the issue could just do what we currently
do and change all the columns types to 'Text'. Such features may be relevant to
other use cases, however.

Thank you for your consideration.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117672] Make default column type 'Text' when importing CSVs, or warn of data modification

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117672

--- Comment #3 from totalmassret...@gmail.com ---
I'm sure you've researched how your program is used, and so I respect your
views on the most common use cases. There are, however, reasons why one might
try to edit a CSV in Calc and not a simple text editor, such as re-ordering
columns. Or even the simple fact that a user knows Calc can import CSVs and may
prefer to work in that program. While it may not be intended to be a CSV
editor, if it can open and save CSVs (via open/save dialogues, no less -- not
import/export dialogues), then the CSV editor use case exists.

I acknowledge that this use case isn't really concerned with spreadsheet
functionality, and may not line up with how developers might expect users to
use the program.

With that in mind, I'll forget the request to change the default and re-iterate
the later part of the request - that silently modifying the data is not good
practice, and that a warning dialogue be displayed when the user clicks the OK
button in the Text Import dialogue. Such a dialogue would inform the user that
their import settings will modify their data, and perhaps it could even tell
them what to do if they don't want their data modified (change all columns to
'Text'.) That way, if someone imports a CSV with serial numbers in some
off-screen column, they won't unwittingly blow them away.

I feel that default toggles and templates would not address the issue of
unexpected data modification, as they would require prior knowledge of this
issue. Those with prior knowledge of the issue could just do what we currently
do and change all the columns types to 'Text'. Such features may be relevant to
other use cases, however.

Thank you for your consideration.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 117708] Expose exporting as SVG slideshow as a separate menu option ( or similar)

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117708

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Agree the current Export to SVG is not really obvious for rendering a full
Impress presentation to a SVG (SMIL2.0) based presentation.

An "Export to SVG slide presentation" or similar entry seems reasonable. 

Maybe could be done with an "Export As" split menu,  much as was done adding
EPUB export from Writer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 117708] Expose exporting as SVG slideshow as a separate menu option ( or similar)

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117708

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Agree the current Export to SVG is not really obvious for rendering a full
Impress presentation to a SVG (SMIL2.0) based presentation.

An "Export to SVG slide presentation" or similar entry seems reasonable. 

Maybe could be done with an "Export As" split menu,  much as was done adding
EPUB export from Writer?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117712] [OLH] Closing installed help with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #4 from Regina Henschel  ---
It does not crash for me with Version: 6.1.0.0.alpha1+ (x64)
Build-ID: 8337f98270a306ae098976c382b37d3747649e6e
CPU-Threads: 8; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/control/Control.LokDialog.js |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit ca87ac8bd5ff67c38ee08698db469dd6723520a0
Author: Henry Castro 
Date:   Sun May 20 11:30:13 2018 -0400

loleaflet: avoid unnecessary "map" global variable in LokDialog.js

Change-Id: I9172bf0ab2aa5178524b7bb5106cc7bb4cdc243d

diff --git a/loleaflet/src/control/Control.LokDialog.js 
b/loleaflet/src/control/Control.LokDialog.js
index 48dacd53d..4dfb1ed4f 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -2,7 +2,7 @@
  * L.Control.LokDialog used for displaying LOK dialogs
  */
 
-/* global $ map L */
+/* global $ L */
 L.Control.LokDialog = L.Control.extend({
 
dialogIdPrefix: 'lokdialog-',
@@ -298,9 +298,9 @@ L.Control.LokDialog = L.Control.extend({
L.DomEvent.on(dialogCanvas, 'mousedown mouseup', function(e) {
L.DomEvent.stopPropagation(e);
var buttons = 0;
-   buttons |= e.button === map['mouse'].JSButtons.left ? 
map['mouse'].LOButtons.left : 0;
-   buttons |= e.button === map['mouse'].JSButtons.middle ? 
map['mouse'].LOButtons.middle : 0;
-   buttons |= e.button === map['mouse'].JSButtons.right ? 
map['mouse'].LOButtons.right : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.left ? this._map['mouse'].LOButtons.left : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.middle ? this._map['mouse'].LOButtons.middle : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.right ? this._map['mouse'].LOButtons.right : 0;
// 'mousedown' -> 'buttondown'
var lokEventType = e.type.replace('mouse', 'button');
this._postWindowMouseEvent(lokEventType, 
this._toRawDlgId(strDlgId), e.offsetX, e.offsetY, 1, buttons, 0);
@@ -310,7 +310,7 @@ L.Control.LokDialog = L.Control.extend({
  'keyup keypress keydown compositionstart 
compositionupdate compositionend textInput',
  function(e) {
  e.originalEvent = e; // _onKeyDown fn 
below requires real event in e.originalEvent
- map['keyboard']._onKeyDown(e,
+ this._map['keyboard']._onKeyDown(e,
 
L.bind(this._postWindowKeyboardEvent,
this,

this._toRawDlgId(strDlgId)),
@@ -445,9 +445,9 @@ L.Control.LokDialog = L.Control.extend({
// attach events
L.DomEvent.on(floatingCanvas, 'mousedown mouseup', function(e) {
var buttons = 0;
-   buttons |= e.button === map['mouse'].JSButtons.left ? 
map['mouse'].LOButtons.left : 0;
-   buttons |= e.button === map['mouse'].JSButtons.middle ? 
map['mouse'].LOButtons.middle : 0;
-   buttons |= e.button === map['mouse'].JSButtons.right ? 
map['mouse'].LOButtons.right : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.left ? this._map['mouse'].LOButtons.left : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.middle ? this._map['mouse'].LOButtons.middle : 0;
+   buttons |= e.button === 
this._map['mouse'].JSButtons.right ? this._map['mouse'].LOButtons.right : 0;
var lokEventType = e.type.replace('mouse', 'button');
this._postWindowMouseEvent(lokEventType, childId, 
e.offsetX, e.offsetY, 1, buttons, 0);
}, this);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/control/Toolbar.js |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 76cc23c86d755917565ab6447a647e35b2a92760
Author: Henry Castro 
Date:   Sun May 20 11:20:09 2018 -0400

loleaflet: avoid unnecessary "map" global variable in Toolbar.js

Change-Id: Ib1da71a67ee7390efda68ff87b998543ca2fde95

diff --git a/loleaflet/src/control/Toolbar.js b/loleaflet/src/control/Toolbar.js
index 29c89e97a..8d1cebcf5 100644
--- a/loleaflet/src/control/Toolbar.js
+++ b/loleaflet/src/control/Toolbar.js
@@ -2,7 +2,7 @@
  * Toolbar handler
  */
 
-/* global $ window vex brandProductName _ map */
+/* global $ window vex brandProductName _ */
 L.Map.include({
 
// a mapping of uno commands to more readable toolbar items
@@ -176,6 +176,7 @@ L.Map.include({
 
showLOKeyboardHelp: function() {
var w = window.innerWidth / 2;
+   var map = this;
$.get('loleaflet-help.html', function(data) {
vex.open({
content: data,
@@ -238,6 +239,7 @@ L.Map.include({
var productString = _('This version of %productName is powered 
by');

content.find('#product-string').text(productString.replace('%productName', 
productName));
var w = window.innerWidth / 2;
+   var map = this;
vex.open({
content: content,
showCloseButton: true,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Tinderbox@42 test failures

2018-05-20 Thread Luke Benes 
The SdOOXMLExportTest2::testFontScale issue is hard to track down because it's 
an intermittent failure. I first thought it was related to Windows display 
scaling settings as I saw some correlation in my testing.  However, now I think 
it's related to the build type.  At first, I could only reproduce this issue on 
1/3 of my Win 10 boxes. However, after I changed the release type from DEBUG to 
RELEASE, I could reproduce it  on all 3.

Thorsten,
Is @42 also a release build?

Khaled,
It takes 5-10 builds to reproduce this failure, so it will take some time to 
see if your patch helped.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/src/layer/tile/TileLayer.js |   34 +-
 1 file changed, 17 insertions(+), 17 deletions(-)

New commits:
commit 5fddb0a9462bf7e17ce44808c6d07a87b6e1ccb6
Author: Henry Castro 
Date:   Sun May 20 10:43:03 2018 -0400

loleaflet: avoid unnecessary "map" global variable in TileLayer.js

Change-Id: Ib3ee891b47aa742ce4a698875f613d6a500a65af

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 1deb1425a..4b04d1ebf 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -2,7 +2,7 @@
 /*
  * L.TileLayer is used for standard xyz-numbered tile layers.
  */
-/* global $ _ map Uint8ClampedArray Uint8Array */
+/* global $ _ Uint8ClampedArray Uint8Array */
 // Implement String::startsWith which is non-portable (Firefox only, it seems)
 // See 
http://stackoverflow.com/questions/646628/how-to-check-if-a-string-startswith-another-string#4579228
 
@@ -495,13 +495,13 @@ L.TileLayer = L.GridLayer.extend({
this._invalidateClientVisibleArea();
this._debug = !this._debug;
if (!this._debug) {
-   map.removeLayer(this._debugInfo);
-   map.removeLayer(this._debugInfo2);
+   this._map.removeLayer(this._debugInfo);
+   this._map.removeLayer(this._debugInfo2);
$('.leaflet-control-layers-expanded').css('display', 
'none');
} else {
if (this._debugInfo) {
-   map.addLayer(this._debugInfo);
-   map.addLayer(this._debugInfo2);
+   this._map.addLayer(this._debugInfo);
+   this._map.addLayer(this._debugInfo2);

$('.leaflet-control-layers-expanded').css('display', 'block');
}
this._debugInit();
@@ -562,8 +562,8 @@ L.TileLayer = L.GridLayer.extend({
parser.href = this._map.options.server;
 
var wopiSrc = '';
-   if (map.options.wopiSrc != '') {
-   wopiSrc = '?WOPISrc=' + map.options.wopiSrc;
+   if (this._map.options.wopiSrc != '') {
+   wopiSrc = '?WOPISrc=' + this._map.options.wopiSrc;
}
var url = this._map.options.webserver + '/' + 
this._map.options.urlPrefix + '/' +
encodeURIComponent(this._map.options.doc) + '/' + 
command.jail + '/' + command.dir + '/' + command.name + wopiSrc;
@@ -2300,36 +2300,36 @@ L.TileLayer = L.GridLayer.extend({
this._debugData = {};
this._debugDataNames = ['tileCombine', 
'fromKeyInputToInvalidate', 'ping', 'loadCount'];
for (var i = 0; i < this._debugDataNames.length; i++) {
-   this._debugData[this._debugDataNames[i]] = 
L.control.attribution({prefix: '', position: 'bottomleft'}).addTo(map);
+   this._debugData[this._debugDataNames[i]] = 
L.control.attribution({prefix: '', position: 'bottomleft'}).addTo(this._map);
}
this._debugInfo = new L.LayerGroup();
this._debugInfo2 = new L.LayerGroup();
this._debugAlwaysActive = new L.LayerGroup();
this._debugTyper = new L.LayerGroup();
-   map.addLayer(this._debugInfo);
-   map.addLayer(this._debugInfo2);
+   this._map.addLayer(this._debugInfo);
+   this._map.addLayer(this._debugInfo2);
var overlayMaps = {
'Tile overlays': this._debugInfo,
'Screen overlays': this._debugInfo2,
'Always active': this._debugAlwaysActive,
'Typing': this._debugTyper
};
-   L.control.layers({}, overlayMaps, {collapsed: 
false}).addTo(map);
+   L.control.layers({}, overlayMaps, {collapsed: 
false}).addTo(this._map);
 
this._map.on('layeradd', function(e) {
if (e.layer === this._debugAlwaysActive) {
-   map._debugAlwaysActive = true;
+   this._map._debugAlwaysActive = true;
} else if (e.layer === this._debugTyper) {
this._debugTypeTimeout();
} else if (e.layer === this._debugInfo2) {
for (var i = 0; i < 
this._debugDataNames.length; i++) {
-

[Libreoffice-bugs] [Bug 86297] Wrong Field reference when heading is in a frame

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=86297

RGB  changed:

   What|Removed |Added

 CC||rgb.m...@gmail.com

--- Comment #6 from RGB  ---
Created attachment 142218
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142218=edit
Example of wrong numbering when heading is in a frame

Problem is still present on 6.0.4. In addition to the original description,
there is also a big problem if you use outline numbering.

For example, consider a document where you have

Heading 1 → numbered as #
Heading 2 → numbered as #.#
Heading 3 → numbered as #.#.#

And the content of your document is

1. First heading 1 (normal text)
2. Second heading 1 (normal text)
2.1 A heading 2 as normal text
2.1.1 A heading 3 as normal text
[1.1.1 A heading 3 inside a frame] ← wrong numbering!

See attached file.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 106463] Data Records Not Saved to External Firebird Database File

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=106463

--- Comment #12 from Drew Jensen  ---
Created attachment 142217
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142217=edit
ScreenShot_processOpenFiles

Some more information here:

What I did was in Libo6.1 Alpha 1 (build from the 18th) on 64 bit Linux.

First I opened a firebird external file ODB (106463_example.odb).

I added a table, Table1. Closed the file.

Open an HSQLdb embedded file (Students_1.odb).

Connected to the datastore by listing the tables, but no changes to anything
otherwise, closed the file.

Opened a Writer file (getting started chapter). Then closed it.

The screen shot shows the system monitor view of what files the soffice process
still has open, and that the LibreOffice UI shows no open files.

NOTE that both odb files are still listed as is a collection of ancillary files
from the respective SDBC drivers. The writer files is not still open.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmloff/source

2018-05-20 Thread Andrea Gelmini 
 xmloff/source/forms/formattributes.hxx |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 99343e6305eeeceb40a8e7ff551cb6cb1d2901af
Author: Andrea Gelmini 
Date:   Sat May 19 21:27:05 2018 +0200

Fix typos

Change-Id: Ia2c768f519a4131b26f38243a64179a39771eb00
Reviewed-on: https://gerrit.libreoffice.org/54576
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/xmloff/source/forms/formattributes.hxx 
b/xmloff/source/forms/formattributes.hxx
index e16e3abc37ce..898fe669730e 100644
--- a/xmloff/source/forms/formattributes.hxx
+++ b/xmloff/source/forms/formattributes.hxx
@@ -299,7 +299,7 @@ namespace xmloff
 /** return the AttributeAssignment which corresponds to the given 
attribute
 
 @param _rAttribName
-the name of the attrribute
+the name of the attribute
 @return
 a pointer to the AttributeAssignment structure as 
requested, NULL if the attribute
 does not represent a property.
@@ -309,7 +309,7 @@ namespace xmloff
 
 /** add a attribute assignment referring to a string property to the 
map
 @param _pAttributeName
-the name of the attrribute
+the name of the attribute
 @param _rPropertyName
 the name of the property assigned to the attribute
 */
@@ -319,7 +319,7 @@ namespace xmloff
 /** add a attribute assignment referring to a boolean property to the 
map
 
 @param _pAttributeName
-the name of the attrribute
+the name of the attribute
 @param _rPropertyName
 the name of the property assigned to the attribute
 @param _bAttributeDefault
@@ -335,7 +335,7 @@ namespace xmloff
 /** add a attribute assignment referring to an int16 property to the 
map
 
 @param _pAttributeName
-the name of the attrribute
+the name of the attribute
 @param _rPropertyName
 the name of the property assigned to the attribute
 */
@@ -345,7 +345,7 @@ namespace xmloff
 /** add a attribute assignment referring to an int32 property to the 
map
 
 @param _pAttributeName
-the name of the attrribute
+the name of the attribute
 @param _rPropertyName
 the name of the property assigned to the attribute
 */
@@ -355,7 +355,7 @@ namespace xmloff
 /** add a attribute assignment referring to an enum property to the map
 
 @param _pAttributeName
-the name of the attrribute
+the name of the attribute
 @param _rPropertyName
 the name of the property assigned to the attribute
 @param _pValueMap
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source svx/source sw/source

2018-05-20 Thread Andrea Gelmini 
 filter/source/xslt/import/wordml/wordml2ooo_table.xsl |2 +-
 svx/source/sdr/properties/attributeproperties.cxx |2 +-
 sw/source/ui/frmdlg/frmpage.cxx   |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 281c609532985ec2713463d313c35e67184f5ed3
Author: Andrea Gelmini 
Date:   Sat May 19 21:06:17 2018 +0200

Fix typos

Change-Id: Id225be0ecc357d6864a32d59291e402d98592d81
Reviewed-on: https://gerrit.libreoffice.org/54575
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/filter/source/xslt/import/wordml/wordml2ooo_table.xsl 
b/filter/source/xslt/import/wordml/wordml2ooo_table.xsl
index 6948469c4020..0f9525cb0b9c 100644
--- a/filter/source/xslt/import/wordml/wordml2ooo_table.xsl
+++ b/filter/source/xslt/import/wordml/wordml2ooo_table.xsl
@@ -281,7 +281,7 @@
 
 
 
-
+
 
 
 
diff --git a/svx/source/sdr/properties/attributeproperties.cxx 
b/svx/source/sdr/properties/attributeproperties.cxx
index 424f4b49291d..07987534b19b 100644
--- a/svx/source/sdr/properties/attributeproperties.cxx
+++ b/svx/source/sdr/properties/attributeproperties.cxx
@@ -191,7 +191,7 @@ namespace sdr
 // all layers. The StyleSheet-problem was solved in
 // AttributeProperties::MoveToItemPool at the end. There, a 
StyleSheet with the
 // same name was searched for in the target-SdrModel.
-// Start by retetting the current TargetStyleSheet so that 
nothing goes wrong
+// Start by resetting the current TargetStyleSheet so that 
nothing goes wrong
 // when we do not find a fitting TargetStyleSheet.
 // Note: The test for SdrModelChange above was wrong (compared 
the already set
 // new SdrObject), so this never triggered and 
pTargetStyleSheet was never set to
diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 4f39fc5ba416..a0d58c8a34d9 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -1993,7 +1993,7 @@ IMPL_LINK( SwFramePage, PosHdl, ListBox&, rLB, void )
 else
 m_bAtVertPosModified = true;
 
-// special treatment for HTML-Mode with horizonal-vertical-dependencies
+// special treatment for HTML-Mode with horizontal-vertical-dependencies
 if(m_bHtmlMode && (RndStdIds::FLY_AT_CHAR == GetAnchor()))
 {
 bool bSet = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - helpcontent2

2018-05-20 Thread Andrea Gelmini 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 996cd07f0911b75b19dff57cc8aedeb9bc654dfe
Author: Andrea Gelmini 
Date:   Sun May 20 16:27:56 2018 +0200

Updated core
Project: help  4efd1d34c0c0575f167e06589f24f8bd255c49ba

Fix typo

Change-Id: Ic13a127e145497c947abe2bf5dcef1bccf92d9f2
Reviewed-on: https://gerrit.libreoffice.org/54602
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/helpcontent2 b/helpcontent2
index d2ea6c70ee3b..4efd1d34c0c0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d2ea6c70ee3bb8b8dab9a155e50182fcbb763e66
+Subproject commit 4efd1d34c0c0575f167e06589f24f8bd255c49ba
commit 0d2974921f29c1ed9308d39055a1b8b44e372898
Author: Andrea Gelmini 
Date:   Sun May 20 16:27:03 2018 +0200

Updated core
Project: help  d2ea6c70ee3bb8b8dab9a155e50182fcbb763e66

Fix typo

Change-Id: If20b3166f7eebfa56edc068137d9485b27a9db9b
Reviewed-on: https://gerrit.libreoffice.org/54601
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/helpcontent2 b/helpcontent2
index 492c80dc564c..d2ea6c70ee3b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 492c80dc564c9f2a3fa45a6d80cbf9325082087c
+Subproject commit d2ea6c70ee3bb8b8dab9a155e50182fcbb763e66
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 2 commits - source/text

2018-05-20 Thread Andrea Gelmini 
 source/text/shared/01/signexistingpdf.xhp   |2 +-
 source/text/swriter/01/addsignatureline.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4efd1d34c0c0575f167e06589f24f8bd255c49ba
Author: Andrea Gelmini 
Date:   Sun May 20 16:27:56 2018 +0200

Fix typo

Change-Id: Ic13a127e145497c947abe2bf5dcef1bccf92d9f2
Reviewed-on: https://gerrit.libreoffice.org/54602
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/source/text/swriter/01/addsignatureline.xhp 
b/source/text/swriter/01/addsignatureline.xhp
index 9f460672e..7da5d22dc 100644
--- a/source/text/swriter/01/addsignatureline.xhp
+++ b/source/text/swriter/01/addsignatureline.xhp
@@ -10,7 +10,7 @@
 -->
 
 
-
+
 Adding Signature Line in Text 
Documents
 /text/swriter/01/addsignatureline.xhp
 
commit d2ea6c70ee3bb8b8dab9a155e50182fcbb763e66
Author: Andrea Gelmini 
Date:   Sun May 20 16:27:03 2018 +0200

Fix typo

Change-Id: If20b3166f7eebfa56edc068137d9485b27a9db9b
Reviewed-on: https://gerrit.libreoffice.org/54601
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/source/text/shared/01/signexistingpdf.xhp 
b/source/text/shared/01/signexistingpdf.xhp
index 1fff9fa4a..894682d69 100644
--- a/source/text/shared/01/signexistingpdf.xhp
+++ b/source/text/shared/01/signexistingpdf.xhp
@@ -19,7 +19,7 @@
 
 digital signature;signing existing PDF
 
-Signing Exisiting PDF files
+Signing Existing PDF files
 %PRODUCTNAME can digitally sign an existing PDF 
document.
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/js loleaflet/Makefile.am loleaflet/src

2018-05-20 Thread Henry Castro 
 loleaflet/Makefile.am|   24 ++--
 loleaflet/js/main.js |7 -
 loleaflet/js/toolbar.js  |  255 +++
 loleaflet/src/map/Map.js |3 
 4 files changed, 146 insertions(+), 143 deletions(-)

New commits:
commit 7b17fc3a3f4cbd913ff5db51c5ba5faa7729d371
Author: Henry Castro 
Date:   Sat May 19 17:28:39 2018 -0400

loleaflet: modularize toolbar.js file

Change-Id: Ic09d97b7f19aebec80a48161ff3f2a8c7db61328

diff --git a/loleaflet/Makefile.am b/loleaflet/Makefile.am
index 86ea96089..26f4a85cb 100644
--- a/loleaflet/Makefile.am
+++ b/loleaflet/Makefile.am
@@ -105,8 +105,8 @@ LOLEAFLET_JS = $(strip $(shell 
NODE_PATH=$(abs_builddir)/node_modules $(NODE) -e
 
 PLUGINS_JS =\
w2ui-1.5.rc1.js \
-   main.js \
-   toolbar.js
+   toolbar.js \
+   main.js
 
 LOLEAFLET_JS_SRC = $(shell find $(srcdir)/src -name '*.js')
 LOLEAFLET_JS_DST = $(patsubst 
$(srcdir)/src/%.js,$(builddir)/dist/src/%.js,$(LOLEAFLET_JS_SRC))
@@ -137,7 +137,7 @@ $(builddir)/dist/admin-bundle.js: $(LOLEAFLET_ADMIN_DST) 
$(BOOTSTRAP_DST) $(CURS
 if ENABLE_DEBUG
 $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_DST) 
$(LOLEAFLET_DRAW_JS_DST)
@echo "Checking loleaflet for JS errors..."
-   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
+   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/eslint/bin/eslint.js $(srcdir)/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@cp -a $(srcdir)/plugins/draw-$(DRAW_VERSION)/dist/images/* 
$(builddir)/dist/images/
 #  @$(NODE) node_modules/eslint/bin/eslint.js 
$(srcdir)/plugins/draw-$(DRAW_VERSION)/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@touch $@
@@ -147,14 +147,16 @@ $(builddir)/dist/bundle.css: $(LOLEAFLET_CSS_DST)
 
 $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_DST) \
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
-   $(builddir)/dist/global.js $(builddir)/dist/w2ui-1.5.rc1.js \
-   $(builddir)/dist/main.js $(builddir)/dist/toolbar.js
+   $(builddir)/dist/global.js \
+   $(builddir)/dist/w2ui-1.5.rc1.js \
+   $(builddir)/dist/toolbar.js \
+   $(builddir)/dist/main.js
@touch $@
 else
 $(LOLEAFLET_PREFIX)/dist/loleaflet-src.js: $(LOLEAFLET_JS_SRC)
@mkdir -p $(dir $@)
@echo "Checking loleaflet for JS errors..."
-   @$(NODE) node_modules/eslint/bin/eslint.js $(srcdir)/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
+   @NODE_PATH=$(abs_builddir)/node_modules $(NODE) 
node_modules/eslint/bin/eslint.js $(srcdir)/src --ignore-path 
$(srcdir)/.eslintignore --config $(srcdir)/.eslintrc
@echo "Concatenating loleaflet files..."
@(cat $(srcdir)/src/copyright.js | sed 
's/{VERSION}/$(LOLEAFLET_VERSION)/' - \
&& echo "(function (window, document, undefined) {" \
@@ -169,16 +171,18 @@ $(builddir)/dist/bundle.css: $(LOLEAFLET_CSS)
 
 $(builddir)/dist/bundle.js: $(NODE_MODULES_JS_SRC) \
$(LOLEAFLET_PREFIX)/dist/loleaflet-src.js \
-   $(srcdir)/js/global.js $(srcdir)/js/w2ui-1.5.rc1.js \
-   $(srcdir)/js/main.js $(srcdir)/js/toolbar.js
+   $(srcdir)/js/global.js \
+   $(srcdir)/js/w2ui-1.5.rc1.js \
+   $(srcdir)/js/toolbar.js \
+   $(srcdir)/js/main.js
@echo "Uglify loleaflet js files..."
@$(NODE) node_modules/uglify-js/bin/uglifyjs \
$(srcdir)/js/global.js \
$(NODE_MODULES_JS) \
-   $(builddir)/build/dist/loleaflet-src.js \
$(srcdir)/js/w2ui-1.5.rc1.js \
-   $(srcdir)/js/main.js \
+   $(builddir)/build/dist/loleaflet-src.js \
$(srcdir)/js/toolbar.js \
+   $(srcdir)/js/main.js \
--source-map --output $@
 endif
 
diff --git a/loleaflet/js/main.js b/loleaflet/js/main.js
index b8668234b..89d99263c 100644
--- a/loleaflet/js/main.js
+++ b/loleaflet/js/main.js
@@ -66,6 +66,8 @@ var map = L.map('map', {
 global.map = map;
 
 // Controls /
+map.addControl(L.control.menubar());
+setupToolbar(map);
 map.addControl(L.control.scroll());
 map.addControl(L.control.alertDialog());
 map.addControl(L.control.lokDialog());
@@ -74,13 +76,12 @@ map.addControl(L.control.tabs());
 map.addControl(L.control.columnHeader());
 map.addControl(L.control.rowHeader());
 map.addControl(L.control.contextMenu());
-map.addControl(L.control.menubar());
 map.addControl(L.control.infobar());
 map.loadDocument();
 
 window.addEventListener('beforeunload', function () {
-   if (global.map && global.map._socket) {
-   global.map._socket.close();
+   if (map && map._socket) {
+   map._socket.close();
}
 });
 
diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 7683145df..277d923e6 100644
--- a/loleaflet/js/toolbar.js
+++

[Libreoffice-bugs] [Bug 117615] Defaulting to Elementary for gtk isnt a good idea

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117615

--- Comment #3 from andreas_k  ---
Hi

First it's no mistake there was another bug report about the change.

>From my point of view it was less a design decision than a pragmatic one.

Tango/Galaxy lack of maintenance and svg support for the future.

>From the design point of view you are right for the default layout tango icons
are available.

>From the maintenance point of view I would prefer colibre for everyone but
libreoffice stands for good integration into the desktop and elementary was a
compromise and it's not really a bad one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117615] Defaulting to Elementary for gtk isnt a good idea

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117615

--- Comment #3 from andreas_k  ---
Hi

First it's no mistake there was another bug report about the change.

From my point of view it was less a design decision than a pragmatic one.

Tango/Galaxy lack of maintenance and svg support for the future.

From the design point of view you are right for the default layout tango icons
are available.

From the maintenance point of view I would prefer colibre for everyone but
libreoffice stands for good integration into the desktop and elementary was a
compromise and it's not really a bad one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: offapi/com sw/qa sw/source

2018-05-20 Thread Tomaž Vajngerl 
 offapi/com/sun/star/style/NumberingLevel.idl |8 
 sw/qa/extras/ooxmlexport/ooxmlexport2.cxx|8 
 sw/qa/extras/rtfexport/rtfexport.cxx |9 +
 sw/source/core/unocore/unosett.cxx   |3 ---
 4 files changed, 13 insertions(+), 15 deletions(-)

New commits:
commit 84f30b34bf63dba8d5b478edac684bee5a841100
Author: Tomaž Vajngerl 
Date:   Thu May 17 20:17:53 2018 +0900

[API-CHANGE] change to GraphicBitmap prop. for NumberingLevel

To make it consistent, change "Graphic" property (added during
image handling rework) to "GraphicBitmap" in style::NumberingLevel,
which is already used in text::NumberingLevel. Both of them are
accessors for the graphic of bitmap bullets.

Change-Id: I70f7bccd80fa9949778c49e23de583c6fb32a796
Reviewed-on: https://gerrit.libreoffice.org/54492
Tested-by: Jenkins 
Reviewed-by: Tomaž Vajngerl 

diff --git a/offapi/com/sun/star/style/NumberingLevel.idl 
b/offapi/com/sun/star/style/NumberingLevel.idl
index c7e700cc63d1..eb3cb92add03 100644
--- a/offapi/com/sun/star/style/NumberingLevel.idl
+++ b/offapi/com/sun/star/style/NumberingLevel.idl
@@ -67,8 +67,8 @@ published service NumberingLevel
 Note the new behaviour since it this was deprecated:
 This property can only be set and only external URLs are
 supported (no more vnd.sun.star.GraphicObject scheme). When an
-URL is set, then it will load the graphic and set the Graphic
-property.
+URL is set, then it will load the graphic and set the
+GraphicBitmap property.
  */
 [property] string GraphicURL;
 
@@ -76,11 +76,11 @@ published service NumberingLevel
  */
 [property] short StartWith;
 
-/** This is the graphic file to use as a symbol.
+/** This is the graphic bitmap to use as a symbol.
 
 @since LibreOffice 6.1
  */
-[optional, property] com::sun::star::graphic::XGraphic Graphic;
+[optional, property] com::sun::star::awt::XBitmap GraphicBitmap;
 };
 
 
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
index a4b4bfec4b9a..95218dae815f 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
@@ -603,7 +603,7 @@ DECLARE_OOXMLEXPORT_TEST(testI120928, "i120928.docx")
 uno::Sequence aProps;
 xLevels->getByIndex(0) >>= aProps; // 1st level
 
-uno::Reference xGraphic;
+uno::Reference xBitmap;
 sal_Int16 nNumberingType = -1;
 
 for (int i = 0; i < aProps.getLength(); ++i)
@@ -612,11 +612,11 @@ DECLARE_OOXMLEXPORT_TEST(testI120928, "i120928.docx")
 
 if (rProp.Name == "NumberingType")
 nNumberingType = rProp.Value.get();
-else if (rProp.Name == "Graphic")
-xGraphic = rProp.Value.get();
+else if (rProp.Name == "GraphicBitmap")
+xBitmap = rProp.Value.get();
 }
 CPPUNIT_ASSERT_EQUAL(style::NumberingType::BITMAP, nNumberingType);
-CPPUNIT_ASSERT(xGraphic.is());
+CPPUNIT_ASSERT(xBitmap.is());
 }
 
 DECLARE_OOXMLEXPORT_TEST(testFdo64826, "fdo64826.docx")
diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx 
b/sw/qa/extras/rtfexport/rtfexport.cxx
index 5f1b96b01ebb..c69529438e30 100644
--- a/sw/qa/extras/rtfexport/rtfexport.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport.cxx
@@ -10,6 +10,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -552,7 +553,7 @@ DECLARE_RTFEXPORT_TEST(testI120928, "i120928.rtf")
 uno::Sequence aProps;
 xLevels->getByIndex(0) >>= aProps; // 1st level
 
-uno::Reference xGraphic;
+uno::Reference xBitmap;
 sal_Int16 nNumberingType = -1;
 
 for (int i = 0; i < aProps.getLength(); ++i)
@@ -561,11 +562,11 @@ DECLARE_RTFEXPORT_TEST(testI120928, "i120928.rtf")
 
 if (rProp.Name == "NumberingType")
 nNumberingType = rProp.Value.get();
-else if (rProp.Name == "Graphic")
-xGraphic = rProp.Value.get();
+else if (rProp.Name == "GraphicBitmap")
+xBitmap = rProp.Value.get();
 }
 CPPUNIT_ASSERT_EQUAL(style::NumberingType::BITMAP, nNumberingType);
-CPPUNIT_ASSERT(xGraphic.is());
+CPPUNIT_ASSERT(xBitmap.is());
 }
 
 DECLARE_RTFEXPORT_TEST(testBookmark, "bookmark.rtf")
diff --git a/sw/source/core/unocore/unosett.cxx 
b/sw/source/core/unocore/unosett.cxx
index c0894cef4ccc..e27cc31c0780 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -1431,9 +1431,6 @@ uno::Sequence 
SwXNumberingRules::GetPropertiesForNumFormat
 const Graphic* pGraphic = pBrush ? pBrush->GetGraphic() : nullptr;
 if (pGraphic)
 {
-uno::Reference 
xGraphic(pGraphic->GetXGraphic());
-//GraphicURL
-

[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117715

--- Comment #2 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 142216
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142216=edit
File-example with different results after conditional formatting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96469] FILESAVE: Data Point Color in Charts lost on DOCX/XLSX export

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=96469

Luke  changed:

   What|Removed |Added

 CC||gan...@poczta.onet.pl
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||8066,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4173

--- Comment #8 from Luke  ---
Still repo in Version: 6.1.0.0.alpha1+
Build ID: 8010f473c77b9f384a7067f487bc24469f8c0cd3

Bartosz,
You've made similar fixes in this area. Is this something you could take a look
at?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117715

--- Comment #1 from kompilainenn <79045_79...@mail.ru> ---
Created attachment 142215
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142215=edit
Screenshot with different results after conditional formatting

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117715] New: Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117715

Bug ID: 117715
   Summary: Unlike other settings, Number Format in a conditional
formatting style doesn't apply if a cell has a number
format applied by direct formatting
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

Description:
Unlike other settings, Number Format in a conditional formatting style doesn't
apply if a cell has a number format applied by direct formatting

Version: 6.0.3.2
Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; 
Locale: ru-RU (ru_RU.UTF-8); Calc: group

Steps to Reproduce:
1. Create a new Calc doc
2. In cell A1 enter number 200, in cell B1 enter number 200
3. Set for A1 Format as Number (Ctrl+Shift+1)
4. Create a new style "Good_Currency" from existing style "Good", with format
number Currency
4. Create for A1 Condition (Format-Conditional Formatting-Condition) with Cell
value is - greater than - 199 and in drop-down list Apply style select our
Good_Currency
5. Create for B1 Condition (Format-Conditional Formatting-Condition) with Cell
value is - greater than - 199 and in drop-down list Apply style select our
Good_Currency
6. Look at A1 and B1. In B1 there is currency, in A1 there isn't!

Actual Results:  
Number Format in a conditional formatting style doesn't apply if a cell has a
number format applied by direct formatting

Expected Results:
Number Format in a conditional formatting style always apply


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101
Firefox/60.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2018-05-20 Thread Sophia Schröder 
 source/text/scalc/guide/pivotchart_filter.xhp |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 492c80dc564c9f2a3fa45a6d80cbf9325082087c
Author: Sophia Schröder 
Date:   Fri May 18 15:44:28 2018 +0100

More punctuation fixes

Change-Id: Ia38e862e5a1dc2f225f8c6f8928f35aeba440683
Reviewed-on: https://gerrit.libreoffice.org/54549
Tested-by: Jenkins 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/scalc/guide/pivotchart_filter.xhp 
b/source/text/scalc/guide/pivotchart_filter.xhp
index db769233d..7327a4dcc 100644
--- a/source/text/scalc/guide/pivotchart_filter.xhp
+++ b/source/text/scalc/guide/pivotchart_filter.xhp
@@ -24,15 +24,13 @@
 Pivot chart buttons are unique to pivot charts, normal charts 
don't have them. The buttons shows the layout of the pivot table, which are the 
pivot table fields. If present, page fields are displayed in the top. Row 
fields are displayed on the bottom of the chart next to each other and the 
legend shows the buttons from column fields stacked.
 
 
-
-Pivot chart 
buttons
-
+Pivot chart buttons
 
 
 The buttons have a pop-up action attached to them. If there is 
some filtering applied, then the arrow turns blue (similar to the pivot table), 
so it is easier to see when a field has any filter applied.
 
 Existing page fields shows what is filtered: when nothing is 
filtered "- all -" is shown, when some data is filtered, then "- multiple -" is 
shown and when only one value is not filtered, the value is shown.
-
+
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2018-05-20 Thread Sophia Schröder 
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3a1f7ba6e55e372a3048312bd8b23daac08c3727
Author: Sophia Schröder 
Date:   Fri May 18 15:44:28 2018 +0100

Updated core
Project: help  492c80dc564c9f2a3fa45a6d80cbf9325082087c

More punctuation fixes

Change-Id: Ia38e862e5a1dc2f225f8c6f8928f35aeba440683
Reviewed-on: https://gerrit.libreoffice.org/54549
Tested-by: Jenkins 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 5907a3bca40c..492c80dc564c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 5907a3bca40c1947ad43e176f619bbdcc90d14fa
+Subproject commit 492c80dc564c9f2a3fa45a6d80cbf9325082087c
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117714] Libreoffice Calc issues with function (named "procv" in portuguese) that returns wrong values

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117714

--- Comment #1 from relaxqenca...@sapo.pt  ---
Created attachment 142214
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142214=edit
test the function vlookup

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117714] New: Libreoffice Calc issues with function (named "procv" in portuguese) that returns wrong values

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117714

Bug ID: 117714
   Summary: Libreoffice Calc issues with function (named "procv"
in portuguese) that returns wrong values
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: relaxqenca...@sapo.pt

Description:
the function "Procv" (in english named vlookup?) returns corrects values but
sometimes returns wrong values

Steps to Reproduce:
1.I create a database spreasheet
2.Then create a new spreadsheet where I want to return values by using a
vlookup (procv) function.
3.On the first line I start by introduce the function in to two cells, taking
care to enter $ in the cells that define the array, from were I want to obtain
the values.
4. Then I block copy the line to create new lines.


Actual Results:  
Eges1,101,00
Flour   1,202,00
Butter Brand 1  1,303,00
Butter Brand 2  #N/D#N/D  Wrong value
Flour 9 3,8028,00 Wrong value
Flour 101,404,00  Wrong value
Flour 111,707,00
Flour 121,808,00
Flour 131,909,00
Flour 142,0010,00
Flour 152,1011,00
Flour 162,2012,00
Flour 172,3013,00
Flour 182,4014,00
Flour 192,5015,00
Butter Brand 3  #N/D#N/DWrong value
Flour 212,7017,00
Flour 222,8018,00
Flour 232,9019,00
Flour 243,0020,00
Flour 253,1021,00
Flour 263,2022,00
Flour 273,3023,00
Flour 283,4024,00
Flour 293,5025,00
Flour 303,6026,00
Flour 313,7027,00


Expected Results:
Eges1,101,00
Flour   1,202,00
Butter Brand 1  1,303,00
Butter Brand 2  1,404,00
Flour 9 1,505,00
Flour 101,606,00
Flour 111,707,00
Flour 121,808,00
Flour 131,909,00
Flour 142,0010,00
Flour 152,1011,00
Flour 162,2012,00
Flour 172,3013,00
Flour 182,4014,00
Flour 192,5015,00
Butter Brand 3  2,6016,00
Flour 212,7017,00
Flour 222,8018,00
Flour 232,9019,00
Flour 243,0020,00
Flour 253,1021,00
Flour 263,2022,00
Flour 273,3023,00
Flour 283,4024,00
Flour 293,5025,00
Flour 303,6026,00
Flour 313,7027,00
Flour 323,8028,00



Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
I not sure what option to choose in "Hardware" so I´m using a i7-920 with
Windows 10 64 bits.



User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117713] New: UnoControlDialog is displayed in the wrong size

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117713

Bug ID: 117713
   Summary: UnoControlDialog is displayed in the wrong size
   Product: LibreOffice
   Version: 6.0.3.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: joesc...@web.de

Description:
If the height and width of a UnoControlDialog are too small, the dialog is
displayed in a fixed, too large size. 

I could observe the following Bug for LO 6.0.3/6.0.4 under Ubuntu 18.04 (Ubuntu
is installed in VMWare), but not under MS Windows


Example 1:


The following works:

Sub fortschrittsanzeige()
wv_fortschritt_model =
CreateUnoService("com.sun.star.awt.UnoControlDialogModel")

With wv_fortschritt_model
.setPropertyValue("Width",  400)
.setPropertyValue("Height", 400)
.SetPropertyValue("Title","only testing")
End With

oWin2 = CreateUnoService("com.sun.star.awt.Toolkit")
wv_fortschritt = CreateUnoService("com.sun.star.awt.UnoControlDialog")

With wv_fortschritt
.setModel(wv_fortschritt_model)
.createPeer(oWin2, null)
.setVisible(True)
End With

'keep dialog visible for testing:   
Msgbox ""
wv_fortschritt.setVisible(False)
End Sub


but now reduce the values for height and width and the dialog is displayed too
large:

Sub fortschrittsanzeige()
wv_fortschritt_model =
CreateUnoService("com.sun.star.awt.UnoControlDialogModel")

With wv_fortschritt_model
.setPropertyValue("Width",  40)
.setPropertyValue("Height", 20)
.SetPropertyValue("Title","only testing")
End With

oWin2 = CreateUnoService("com.sun.star.awt.Toolkit")
wv_fortschritt = CreateUnoService("com.sun.star.awt.UnoControlDialog")

With wv_fortschritt
.setModel(wv_fortschritt_model)
.createPeer(oWin2, null)
.setVisible(True)
End With

'keep dialog visible for testing:   
Msgbox ""
wv_fortschritt.setVisible(False)
End Sub


Example 2:

-open the basic IDE 
-insert a basic dialog
-set in the properties of the basic dialog for the height 20 and for the width
40
-start the dialog

You can see that the dialog is displayed too large.


Steps to Reproduce:
-open the basic IDE 
-insert a basic dialog
-set in the properties of the basic dialog for the height 20 and for the width
40
-start the dialog


Actual Results:  
You can see that the dialog is displayed too large.

Expected Results:
Show the dialog in the correct size


Reproducible: Always


User Profile Reset: Yes



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 6.1; Trident/7.0; rv:11.0) like Gecko

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117546] Crash when closing Calc

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117546

himajin100...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from himajin100...@gmail.com ---
reproducible.

typo: 
Copy column A1
=> Copy column A

Version: 6.1.0.0.alpha1+ (x64)
Build ID: e1a8338876bd161de4e9d9a4b22d4bc5335f7cee
CPU threads: 4; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-05-18_23:55:37
Locale: ja-JP (ja_JP); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116803] Crash on third file opening

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=116803

--- Comment #5 from Tomaz Vajngerl  ---
Oh crazy.. a EMF/WMF image takes 9600 GDI handles and the limit per process in
1 handles. After the document is closed, the GDI handles aren't released,
which is what I'm trying to track why exactly, but this won't fix the issue
with the image itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117593] [NEWHELP] Translations of collateral file pivot.ods for help pages

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117593

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org
 Attachment #142206|imtrigon.fr.ods (French |pivot.fr.ods (French
description|locale) |locale)

--- Comment #2 from Jean-Baptiste Faure  ---
Comment on attachment 142206
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142206
pivot.fr.ods (French locale)

corrected the description imtrigon -> pivot

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117712] [OLH] Closing installed help with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

--- Comment #3 from thack...@nexgo.de ---
Hello @ll,
I found out that this crash seems to be a general problem, not only Math
related. I was translating Math's help when the first crash appeared, but has
tried it from LO's StartCenter now, where it also crashed ... :( So a slightly
different description to reproduce it:

1. install LO following the instructions from
https://wiki.documentfoundation.org/Installing_in_parallel/Linux with de-DE
lang- as well as helppack
2. start LO
3. press 
4. press +

LO crashes reproducible ... :(
Sorry for the inconvenience
Thomas.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117712] [OLH] Closing installed help with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

thack...@nexgo.de changed:

   What|Removed |Added

Summary|[OLH] Closing installed |[OLH] Closing installed
   |help in Math with   |help with +
   |+ crashes LO   |crashes LO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: filter/source include/sal include/unotools officecfg/registry sw/CppunitTest_sw_mailmerge.mk sw/inc sw/qa sw/source sw/uiconfig unotools/source

2018-05-20 Thread Mike Kaganski 
 filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx   |   13 
 include/sal/log-areas.dox |1 
 include/unotools/compatibility.hxx|1 
 officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs |6 
 sw/CppunitTest_sw_mailmerge.mk|4 
 sw/inc/IDocumentSettingAccess.hxx |1 
 sw/inc/doc.hxx|3 
 sw/inc/ndhints.hxx|   26 +
 sw/inc/ndtxt.hxx  |   12 
 sw/inc/viewsh.hxx |2 
 sw/qa/extras/mailmerge/data/5-with-blanks.ods |binary
 sw/qa/extras/mailmerge/data/tdf35798-legacy.fodt  |   37 ++
 sw/qa/extras/mailmerge/data/tdf35798-legacy.odt   |binary
 sw/qa/extras/mailmerge/data/tdf35798-new.fodt |   38 ++
 sw/qa/extras/mailmerge/data/tdf35798-new.odt  |binary
 sw/qa/extras/mailmerge/mailmerge.cxx  |  140 
++
 sw/source/core/doc/DocumentSettingManager.cxx |8 
 sw/source/core/doc/doc.cxx|  128 
+
 sw/source/core/doc/doctxm.cxx |4 
 sw/source/core/inc/DocumentSettingManager.hxx |1 
 sw/source/core/text/txtfrm.cxx|9 
 sw/source/core/txtnode/atrfld.cxx |   26 +
 sw/source/core/txtnode/ndtxt.cxx  |2 
 sw/source/core/txtnode/thints.cxx |   65 ++--
 sw/source/core/view/viewsh.cxx|   20 +
 sw/source/filter/xml/xmlimp.cxx   |   26 +
 sw/source/ui/config/optcomp.cxx   |   16 -
 sw/source/uibase/app/docshini.cxx |   22 +
 sw/source/uibase/uno/SwXDocumentSettings.cxx  |   18 +
 sw/uiconfig/swriter/ui/optcompatpage.ui   |1 
 unotools/source/config/compatibility.cxx  |4 
 31 files changed, 513 insertions(+), 121 deletions(-)

New commits:
commit db04be037b611e296ef9f2542322c52ed82d7a2b
Author: Mike Kaganski 
Date:   Fri May 18 18:48:38 2018 +0300

tdf#35798: Hide empty Database fields' paragraphs (+ compat option)

With this change, Database fields that expand to empty values behave
as if they are "Hidden Paragraph" fields.

A compatibility option to enable this behaviour is added. The option is
enabled by default, and for any non-native documents (for compatibility
with other office suites). For existing (F)ODT documents, the option is
disabled for those documents that don't have this setting set, to keep
the layout of legacy documents.

Change-Id: Ic5e8cb15a3a7d1a765a984eef4b0d97666df7dfd
Reviewed-on: https://gerrit.libreoffice.org/54552
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx 
b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx
index dad36ee2922b..ea97c7ad3fba 100644
--- a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx
+++ b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx
@@ -90,12 +90,25 @@ bool XmlFilterAdaptor::importImpl( const Sequence< 
css::beans::PropertyValue >&
 PropertyMapEntry aImportInfoMap[] =
 {
 { OUString("BaseURI"), 0, ::cppu::UnoType::get(), 
PropertyAttribute::MAYBEVOID, 0},
+{ OUString("DefaultDocumentSettings"), 0,
+  ::cppu::UnoType::get(), 
PropertyAttribute::MAYBEVOID, 0 },
 { OUString(), 0, css::uno::Type(), 0, 0 }
 };
 
 Reference< XPropertySet > xInfoSet(
 GenericPropertySet_CreateInstance( new PropertySetInfo( 
aImportInfoMap ) ) );
 xInfoSet->setPropertyValue( "BaseURI", makeAny( aBaseURI ));
+
+OUString aFilterName;
+auto It = aMediaMap.find(OUString("FilterName"));
+if (It != aMediaMap.end() && (It->second >>= aFilterName)
+&& aFilterName == "OpenDocument Text Flat XML")
+{
+PropertyValue EmptyDbFieldHidesPara("EmptyDbFieldHidesPara", 0, 
Any(false),
+
PropertyState::PropertyState_DIRECT_VALUE);
+Sequence aSettings{ EmptyDbFieldHidesPara };
+xInfoSet->setPropertyValue("DefaultDocumentSettings", 
makeAny(aSettings));
+}
 aAnys[0] <<= xInfoSet;
 
 
diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 488f4d6c0232..860e23040141 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -519,6 +519,7

[Libreoffice-commits] core.git: officecfg/registry

2018-05-20 Thread Mike Kaganski 
 officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d3122433616d4da2c6ee82f73bd8f591ea498fc0
Author: Mike Kaganski 
Date:   Fri May 18 10:20:40 2018 +0100

Also change Expert Configuration option's description wording

.. after the changed string in Compatibility options done in commit
ae0edc4740ea95cd456eb7157bd048615de9212e.

Change-Id: I6708ef76207a02915c6ec883cc3c7c5d0245ae40
Reviewed-on: https://gerrit.libreoffice.org/54524
Tested-by: Jenkins 
Reviewed-by: Mike Kaganski 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
index f71c66205871..03921814dcb1 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs
@@ -118,7 +118,7 @@
   
   
 
-  Use LibreOffice 4.3 anchoring paint order
+  Tolerate white lines of PDF page backgrounds for compatibility 
with old documents (Use LibreOffice 4.3 anchoring paint order)
 
 false
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basegfx/source officecfg/registry sd/source svx/source sw/source

2018-05-20 Thread Andrea Gelmini 
 basegfx/source/workbench/bezierclip.cxx   |2 +-
 officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu |2 +-
 sd/source/ui/slidesorter/inc/view/SlsInsertionIndicatorOverlay.hxx|2 +-
 svx/source/dialog/frmsel.cxx  |2 +-
 sw/source/core/objectpositioning/anchoredobjectposition.cxx   |2 +-
 sw/source/ui/frmdlg/frmpage.cxx   |4 
++--
 6 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit c5081b324118cefb3bce04f7bf817963e24b1c68
Author: Andrea Gelmini 
Date:   Sat May 19 19:46:29 2018 +0200

Fix typos

Change-Id: I65300af850f5c6f6795fa88e9e33616e38c7657c
Reviewed-on: https://gerrit.libreoffice.org/54571
Reviewed-by: Julien Nabet 
Tested-by: Jenkins 

diff --git a/basegfx/source/workbench/bezierclip.cxx 
b/basegfx/source/workbench/bezierclip.cxx
index bdc924113fab..2e6439a71463 100644
--- a/basegfx/source/workbench/bezierclip.cxx
+++ b/basegfx/source/workbench/bezierclip.cxx
@@ -215,7 +215,7 @@ bool Impl_calcSafeParams( double&   t1,
 {
 // r_y is virtually zero, thus we've got a horizontal
 // line. Now check whether we maybe coincide with lower or
-// upper horizonal bound line.
+// upper horizontal bound line.
 if( tolEqual(p0.y, lowerYBound) ||
 tolEqual(p0.y, upperYBound) )
 {
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu
index 4cd6034331da..739ad7bc1921 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/BasicIDECommands.xcu
@@ -60,7 +60,7 @@
   
   
 
-  Form Horizonal Scroll Bar
+  Form Horizontal Scroll Bar
 
 
   1
diff --git a/sd/source/ui/slidesorter/inc/view/SlsInsertionIndicatorOverlay.hxx 
b/sd/source/ui/slidesorter/inc/view/SlsInsertionIndicatorOverlay.hxx
index e025459adb8e..9dcbd754e04c 100644
--- a/sd/source/ui/slidesorter/inc/view/SlsInsertionIndicatorOverlay.hxx
+++ b/sd/source/ui/slidesorter/inc/view/SlsInsertionIndicatorOverlay.hxx
@@ -44,7 +44,7 @@ namespace sd { namespace slidesorter { namespace view {
 
 class FramePainter;
 
-/** The insertion indicator is painted as a vertical or horizonal bar
+/** The insertion indicator is painted as a vertical or horizontal bar
 in the space between slides.
 */
 class InsertionIndicatorOverlay
diff --git a/svx/source/dialog/frmsel.cxx b/svx/source/dialog/frmsel.cxx
index 233ed2f098dd..d18462934d09 100644
--- a/svx/source/dialog/frmsel.cxx
+++ b/svx/source/dialog/frmsel.cxx
@@ -466,7 +466,7 @@ void FrameSelectorImpl::InitBorderGeometry()
 {
 for( nRow = 0, nRows = maArray.GetRowCount(); nRow < nRows; ++nRow 
)
 {
-// the usable area between horizonal/vertical frame borders of 
current quadrant
+// the usable area between horizontal/vertical frame borders 
of current quadrant
 const basegfx::B2DRange aCellRange(maArray.GetCellRange( nCol, 
nRow, true ));
 const tools::Rectangle aRect(
 basegfx::fround(aCellRange.getMinX()) + nClV + 1, 
basegfx::fround(aCellRange.getMinY()) + nClH + 1,
diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
index e0d58f0b01e3..0bae1d1c8ade 100644
--- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
@@ -831,7 +831,7 @@ SwTwips SwAnchoredObjectPosition::CalcRelPosX(
 SwTwips nRelPosX = nOffset;
 if ( _rHoriOrient.GetHoriOrient() == text::HoriOrientation::NONE )
 {
-// 'manual' horizonal position
+// 'manual' horizontal position
 const bool bR2L = rAnchorFrame.IsRightToLeft();
 if( IsAnchoredToChar() && text::RelOrientation::CHAR == eRelOrient )
 {
diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 255bf7eb4260..4f39fc5ba416 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -1261,7 +1261,7 @@ bool SwFramePage::FillItemSet(SfxItemSet *rSet)
 return bRet;
 }
 
-// initialise horizonal and vertical Pos
+// initialise horizontal and vertical Pos
 void SwFramePage::InitPos(RndStdIds eId,
 sal_Int16 nH,
 sal_Int16 nHRel,
@@ -1822,7 +1822,7 @@ void SwFramePage::RangeModifyHdl()
 
 if ( m_pHMap )
 {
-// alignment horizonal
+// alignment horizontal
 const sal_Int32 nMapPos = GetMapPos(m_pHMap,

[Libreoffice-bugs] [Bug 117712] [OLH] Closing installed help in Math with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

--- Comment #2 from thack...@nexgo.de ---
Created attachment 142213
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142213=edit
bzip'd "soffice --strace" log

"bzipped" strace log, produced with "soffice --strace"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117712] [OLH] Closing installed help in Math with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

--- Comment #1 from thack...@nexgo.de ---
Created attachment 142212
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142212=edit
"soffice --backtrace" output

Backtrace produced with "soffice --backtrace"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117712] New: [OLH] Closing installed help in Math with + crashes LO

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117712

Bug ID: 117712
   Summary: [OLH] Closing installed help in Math with +
crashes LO
   Product: LibreOffice
   Version: 6.1.0.0.alpha1+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thack...@nexgo.de
CC: olivier.hal...@documentfoundation.org

Hello @ll,
I hope I have chosen the right component. If not, feel free to change it ... ;)

Steps to reproduce:

1. Install LO Master in parallel (I have used
https://wiki.documentfoundation.org/Installing_in_parallel/Linux to do it) with
de-DE lang- as well as helppack (may crash with other lang- and helppack as
well, but have not tried it, sorry ... :( ).
2. start LO
3. press + to start Math
4. press  to open the installed help
5. press + to close it

LO crashes reproducible with the steps above ... :( And it also crashes, if you
opens the help somewhere (say "Format - Fonts" or "Format - Font size") ... :(

OS: Debian Testing AMD64
LO: Version: 6.1.0.0.alpha1+
Build-ID: 3dea0e08e9b5331d6e34384977c98d0782c7746d
CPU-Threads: 4; BS: Linux 4.16; UI-Render: Standard; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-05-20_00:10:55
Gebietsschema: de-DE (de_DE.UTF-8); Calc: group
(installed in parallel, following the instructions from the link above)

Sorry for the inconvenience
Thomas.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117650] UI Impress: Overlapping Items in Animation Object List

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117650

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #5 from raal  ---
please answer comment 3 and 4. Please attach file for test. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 117615] Defaulting to Elementary for gtk isnt a good idea

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117615

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
  Component|Chart   |UI
 Ever confirmed|0   |1

--- Comment #2 from Heiko Tietze  ---
Would like to get more opinions on that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 117615] Defaulting to Elementary for gtk isnt a good idea

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117615

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
  Component|Chart   |UI
 Ever confirmed|0   |1

--- Comment #2 from Heiko Tietze  ---
Would like to get more opinions on that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117546] Crash when closing Calc

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117546

gera...@libreoffice.org changed:

   What|Removed |Added

 CC||gera...@libreoffice.org

--- Comment #2 from gera...@libreoffice.org ---
Works fine in the linux-version 6.1 alpha 1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/inc sw/source

2018-05-20 Thread Bjoern Michaelsen 
 sw/inc/fmtftn.hxx |1 
 sw/source/core/unocore/unoftn.cxx |   51 +-
 2 files changed, 25 insertions(+), 27 deletions(-)

New commits:
commit e73e726ab5afc418a5be70408c71afd08a3c15a4
Author: Bjoern Michaelsen 
Date:   Thu May 10 10:51:42 2018 +0200

dont use SwClient/SwModify in unocore: Footnotes

Change-Id: I12000118f34b8b4e37fcc0b7d1b50a32784cc893
Reviewed-on: https://gerrit.libreoffice.org/54578
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/sw/inc/fmtftn.hxx b/sw/inc/fmtftn.hxx
index ee22d3b8bc52..1aa2e6f315d9 100644
--- a/sw/inc/fmtftn.hxx
+++ b/sw/inc/fmtftn.hxx
@@ -38,6 +38,7 @@ class SwTextFootnote;
 class SW_DLLPUBLIC SwFormatFootnote
 : public SfxPoolItem
 , public SwModify
+, public sw::BroadcasterMixin
 {
 friend class SwTextFootnote;
 SwTextFootnote* m_pTextAttr;   ///< My TextAttribute.
diff --git a/sw/source/core/unocore/unoftn.cxx 
b/sw/source/core/unocore/unoftn.cxx
index 601314ffc99a..da5f24e9a46c 100644
--- a/sw/source/core/unocore/unoftn.cxx
+++ b/sw/source/core/unocore/unoftn.cxx
@@ -21,12 +21,13 @@
 
 #include 
 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
 
 #include 
 #include 
@@ -47,31 +48,31 @@
 using namespace ::com::sun::star;
 
 class SwXFootnote::Impl
-: public SwClient
+: public SvtListener
 {
 private:
 ::osl::Mutex m_Mutex; // just for OInterfaceContainerHelper2
 
 public:
 
-SwXFootnote &   m_rThis;
+SwXFootnote& m_rThis;
 uno::WeakReference m_wThis;
-const bool  m_bIsEndnote;
-::comphelper::OInterfaceContainerHelper2  m_EventListeners;
-boolm_bIsDescriptor;
-const SwFormatFootnote *m_pFormatFootnote;
-OUString m_sLabel;
-
-Impl(   SwXFootnote & rThis,
-SwFormatFootnote *const pFootnote,
+const bool m_bIsEndnote;
+::comphelper::OInterfaceContainerHelper2 m_EventListeners;
+bool m_bIsDescriptor;
+SwFormatFootnote* m_pFormatFootnote;
+OUString m_sLabel;
+
+Impl(SwXFootnote& rThis,
+SwFormatFootnote* const pFootnote,
 const bool bIsEndnote)
-: SwClient(pFootnote)
-, m_rThis(rThis)
+: m_rThis(rThis)
 , m_bIsEndnote(bIsEndnote)
 , m_EventListeners(m_Mutex)
 , m_bIsDescriptor(nullptr == pFootnote)
 , m_pFormatFootnote(pFootnote)
 {
+m_pFormatFootnote && StartListening(m_pFormatFootnote->GetNotifier());
 }
 
 const SwFormatFootnote* GetFootnoteFormat() const {
@@ -86,10 +87,9 @@ public:
 return *pFootnote;
 }
 
-voidInvalidate();
+void Invalidate();
 protected:
-// SwClient
-virtual void Modify( const SfxPoolItem *pOld, const SfxPoolItem *pNew) 
override;
+void Notify(const SfxHint& rHint) override;
 
 };
 
@@ -107,14 +107,10 @@ void SwXFootnote::Impl::Invalidate()
 m_EventListeners.disposeAndClear(ev);
 }
 
-void SwXFootnote::Impl::Modify(const SfxPoolItem *pOld, const SfxPoolItem 
*pNew)
+void SwXFootnote::Impl::Notify(const SfxHint& rHint)
 {
-ClientModify(this, pOld, pNew);
-
-if (!GetRegisteredIn()) // removed => dispose
-{
+if(rHint.GetId() == SfxHintId::Dying)
 Invalidate();
-}
 }
 
 SwXFootnote::SwXFootnote(const bool bEndnote)
@@ -332,9 +328,10 @@ SwXFootnote::attach(const uno::Reference< text::XTextRange 
> & xTextRange)
 
 if (pTextAttr)
 {
-const SwFormatFootnote& rFootnote = pTextAttr->GetFootnote();
-m_pImpl->m_pFormatFootnote = 
-
const_cast(m_pImpl->m_pFormatFootnote)->Add(m_pImpl.get());
+m_pImpl->EndListeningAll();
+SwFormatFootnote* pFootnote = 
const_cast(>GetFootnote());
+m_pImpl->m_pFormatFootnote = pFootnote;
+m_pImpl->StartListening(pFootnote->GetNotifier());
 // force creation of sequence id - is used for references
 if (pNewDoc->IsInReading())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=116968
Bug 116968 depends on bug 117298, which changed state.

Bug 117298 Summary: Firebird: Migration: For an hsqldb column with type Time 
and data generates an error during import of the data
https://bugs.documentfoundation.org/show_bug.cgi?id=117298

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: dbaccess/source

2018-05-20 Thread Julien Nabet 
 dbaccess/source/filter/hsqldb/hsqlimport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cb4e2aea81b85a134d35bc54b7c49081f899bd78
Author: Julien Nabet 
Date:   Sat May 19 22:11:01 2018 +0200

tdf#117298: migration Firebird, fix time data

by just adjusting nColIndex like other datatypes

Change-Id: Ia7947b3498818bac2f033eac81ac3835f98bbab3
Reviewed-on: https://gerrit.libreoffice.org/54581
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx 
b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index b6f2dbc660c6..83b291ccf745 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -138,7 +138,7 @@ void lcl_setParams(const RowVector& row, 
Reference const& xParam,
 css::util::Time time;
 if (row.at(i) >>= time)
 {
-xParam->setTime(nColIndex, time);
+xParam->setTime(nColIndex + 1, time);
 }
 }
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 117643] Word search does not work in LibreOffice Writer if search term contains an apostrophe

2018-05-20 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=117643

--- Comment #5 from mwtjunkm...@gmail.com ---
Hm... I just tested this in MS Word 365, which I'm trying to stay away from by
using LibreOffice. 

Word doesn't have this issue.  Type and replace turned on for apostrophes
doesn't kill the application's ability to find apostrophes in word search
terms.

Why should Writer require gymnastics to type in alt codes to achieve the same
thing?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

  1   2   >