[Libreoffice-bugs] [Bug 45162] TABLES paste table in a number section causes all cells in table to be numbered
https://bugs.documentfoundation.org/show_bug.cgi?id=45162 --- Comment #11 from Winfried Donkers--- Problem still present in version 5.4.7.2 on Windows -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83700] VIEWING: title bar should be graphically merged into top menu bar on OS X ( all components)
https://bugs.documentfoundation.org/show_bug.cgi?id=83700 --- Comment #11 from Tor Lillqvist--- So is this bug then about making the title bar blend into the rest of the window, or makining the Firefox theme thing (that I have never, ever, heard anybody else mention, at least not for the Mac) spread into the title bar? Two entirely different things. And as the initial reporter calls himself "retired", I guess we will never know his/her opinion. Matthew, please file a new bug about the Firefox thing. This bug should be about what the initial bug reporter intended. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117790] Caption order, caption positions for Lithuanian language
https://bugs.documentfoundation.org/show_bug.cgi?id=117790 --- Comment #3 from opensuse.lietuviu.ka...@gmail.com --- Created attachment 142271 --> https://bugs.documentfoundation.org/attachment.cgi?id=142271=edit Screenshot of document with default/wrong and good caption order/place/name -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extensions/source
extensions/source/ole/servprov.cxx |8 extensions/source/ole/servprov.hxx | 35 ++- 2 files changed, 10 insertions(+), 33 deletions(-) New commits: commit e7cefdfc83ce17f11ea6277f579a4d8434a97ce4 Author: Tor LillqvistDate: Tue Feb 13 00:34:30 2018 +0200 IClassFactoryWrapper can go away now Change-Id: I7633648dc0398d2c1b6f04e6db9b18638a7451f5 Reviewed-on: https://gerrit.libreoffice.org/54781 Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist diff --git a/extensions/source/ole/servprov.cxx b/extensions/source/ole/servprov.cxx index e7fcbb9823ef..72e5944fb5ba 100644 --- a/extensions/source/ole/servprov.cxx +++ b/extensions/source/ole/servprov.cxx @@ -488,12 +488,12 @@ css::uno::Sequence OleServer::getSupportedServiceNames() bool OleServer::provideInstance(const Reference& xInst, GUID const * guid) { -IClassFactoryWrapper* pFac = new OneInstanceOleWrapper( m_smgr, xInst ); +OneInstanceOleWrapper* pWrapper = new OneInstanceOleWrapper( m_smgr, xInst ); -pFac->AddRef(); -m_wrapperList.push_back(pFac); +pWrapper->AddRef(); +m_wrapperList.push_back(pWrapper); -return pFac->registerClass(guid); +return pWrapper->registerClass(guid); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/extensions/source/ole/servprov.hxx b/extensions/source/ole/servprov.hxx index 2f4b8446f815..8d128b4c48e3 100644 --- a/extensions/source/ole/servprov.hxx +++ b/extensions/source/ole/servprov.hxx @@ -39,41 +39,19 @@ Reference< XInterface> ConverterProvider_CreateInstanceVar1( const Reference OleClient_CreateInstance( const Reference & xSMgr); /// @throws Exception Reference OleServer_CreateInstance( const Reference & xSMgr); -/* - -IClassFactoryWrapper - -Specify abstract helper methods on class factories, which provide -UNO objects. These methods are used by objects of class OleServer, -to handle the OLE registration of different class factories. - -*/ - -class IClassFactoryWrapper : public IClassFactory -{ -public: - -virtual bool registerClass(GUID const * pGuid) = 0; -virtual bool deregisterClass() = 0; - -protected: -~IClassFactoryWrapper() {} -}; /* OneInstanceOleWrapper -Provides an single UNO object as OLE object. Handle the -OLE registration by overriding the abstract methods from -IClassFactoryWrapper. +Provides an single UNO object as OLE object. - Acts as a COM class factory. When IClassFactory::CreateInstance is being called +Acts as a COM class factory. When IClassFactory::CreateInstance is being called then it maps the XInstance member it to a COM object. */ -class OneInstanceOleWrapper : public IClassFactoryWrapper +class OneInstanceOleWrapper : public IClassFactory { public: @@ -81,8 +59,8 @@ public: const Reference& xInst ); virtual ~OneInstanceOleWrapper(); -bool registerClass(GUID const * pGuid) override; -bool deregisterClass() override; +bool registerClass(GUID const * pGuid); +bool deregisterClass(); /* IUnknown methods */ STDMETHOD(QueryInterface)(REFIID riid, LPVOID FAR * ppvObj) override; @@ -94,7 +72,6 @@ public: STDMETHOD(LockServer)(int fLock) override; protected: - oslInterlockedCount m_refCount; Reference m_xInst; DWORD m_factoryHandle; @@ -198,7 +175,7 @@ public: protected: bool provideInstance(const Reference& xInst, GUID const * guid); -list< IClassFactoryWrapper* > m_wrapperList; +list< OneInstanceOleWrapper* > m_wrapperList; Reference< XBridgeSupplier2 > m_bridgeSupplier; Reference m_smgr; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117790] Caption order, caption positions for Lithuanian language
https://bugs.documentfoundation.org/show_bug.cgi?id=117790 --- Comment #2 from opensuse.lietuviu.ka...@gmail.com --- Created attachment 142270 --> https://bugs.documentfoundation.org/attachment.cgi?id=142270=edit wrong and good caption order in same document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117790] Caption order, caption positions for Lithuanian language
https://bugs.documentfoundation.org/show_bug.cgi?id=117790 --- Comment #1 from opensuse.lietuviu.ka...@gmail.com --- Created attachment 142269 --> https://bugs.documentfoundation.org/attachment.cgi?id=142269=edit Example document with default wrong order -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117790] New: Caption order, caption positions for Lithuanian language
https://bugs.documentfoundation.org/show_bug.cgi?id=117790 Bug ID: 117790 Summary: Caption order, caption positions for Lithuanian language Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: opensuse.lietuviu.ka...@gmail.com Description: Caption order should default to “Numbering first” for Lithuanian language. After number, word should be lower case. Table's caption should be by default before table, not below table. Steps to Reproduce: 1. In Lithuanian environment in LibreOffice Writer add a) table b) image 2. Insert caption Actual Results: Now if I add caption, I get by default: Lentelė 1: Title. Paveikslas 1: Title. Expected Results: But caption order should be: "1 lentelė. Title." (and first letter L in "lentelė" is lower case) "1 paveikslas. Title." OR "1 pav. Title." (we much more often use abrevation, not full word) Reproducible: Always User Profile Reset: Yes Additional Info: Versija: 6.0.4.2 Darinio identifikatorius: 00m0(Build:2) Procesoriaus gijos: 4; OS:Linux 4.4; Sąsajos pateikimas: numatytasis; VCL: kde4; Lokalė: lt-LT (lt_LT.UTF-8); Calc: group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 117755] selecting text changes the current search target
https://bugs.documentfoundation.org/show_bug.cgi?id=117755 l...@royal.net changed: What|Removed |Added Summary|copying text to clipboard |selecting text changes the |changes the current search |current search target |target | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 117755] selecting text changes the current search target
https://bugs.documentfoundation.org/show_bug.cgi?id=117755 l...@royal.net changed: What|Removed |Added Summary|copying text to clipboard |selecting text changes the |changes the current search |current search target |target | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b32fee83141a0eb227194a3cb1dcda99bda6f4a1 Author: Andrea GelminiDate: Fri May 25 01:23:07 2018 +0200 Updated core Project: help e35e77e62e90d709633304a45bdc0d430595a01a Fix typos Change-Id: I50e06c9bc42c1e5529074e944b9f1ed37f0a7385 Reviewed-on: https://gerrit.libreoffice.org/54784 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/helpcontent2 b/helpcontent2 index 31d3025c0610..e35e77e62e90 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 31d3025c0610319fd545b52f41211f86530eedec +Subproject commit e35e77e62e90d709633304a45bdc0d430595a01a ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangPackage_html_media_lang.mk source/text
AllLangPackage_html_media_lang.mk |2 +- source/text/shared/00/00040502.xhp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit e35e77e62e90d709633304a45bdc0d430595a01a Author: Andrea GelminiDate: Fri May 25 01:23:07 2018 +0200 Fix typos Change-Id: I50e06c9bc42c1e5529074e944b9f1ed37f0a7385 Reviewed-on: https://gerrit.libreoffice.org/54784 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/AllLangPackage_html_media_lang.mk b/AllLangPackage_html_media_lang.mk index 45e983a43..7482ec997 100644 --- a/AllLangPackage_html_media_lang.mk +++ b/AllLangPackage_html_media_lang.mk @@ -10,7 +10,7 @@ # Language-specific parts of the help/media/ sub-tree. All language-specific content from # $(SRCDIR)/helpcontent2/source/media/ must be listed here. Content that is present in $(SRCDIR) # for all languages in some set of languages can be handled with a foreach (like the screenshots -# present for all languages in $(completelangiso) below). More irregular conent that is present in +# present for all languages in $(completelangiso) below). More irregular content that is present in # $(SRCDIR) only for some languages is handled with the individual per-language blocks. $(eval $(call gb_AllLangPackage_AllLangPackage,helpcontent2_html_media_lang,$(SRCDIR)/helpcontent2/source/media)) diff --git a/source/text/shared/00/00040502.xhp b/source/text/shared/00/00040502.xhp index 734671ccb..f63017e05 100644 --- a/source/text/shared/00/00040502.xhp +++ b/source/text/shared/00/00040502.xhp @@ -104,7 +104,7 @@ Choose Format - Chart Area - Area tab (chart documents). Choose Slide - Properties - Background tab (in $[officename] Impress). Choose Page - Properties - Background tab (in $[officename] Draw). - Choose Table - Propeties - Background tab. + Choose Table - Properties - Background tab. Choose Format - Area - Transparency tab (drawing documents) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 83700] VIEWING: title bar should be graphically merged into top menu bar on OS X ( all components)
https://bugs.documentfoundation.org/show_bug.cgi?id=83700 Matthew Francischanged: What|Removed |Added Status|NEEDINFO|NEW --- Comment #10 from Matthew Francis --- @Tor Respectfully, I think we're more in agreement than disagreement. I agree that LO should indeed look like an application that belongs on MacOS when on MacOS - not a purely "neutral cross platform" app. The problem is it currently doesn't entirely look like it belongs. In most modern MacOS apps, the very top of the window is visually unified with what is immediately beneath, be it tabs, toolbars, buttons, search boxes or whatever else. However, LO windows still have a clearly delineated title bar, complete with mostly unused space except for window buttons and centred title text, and a sharp border at the bottom of the title bar like all apps used to have in the old days. My point in addition to this in comment#1 meant that, if the visuals of the title bar are in fact updated to look like a modern MacOS app, the only viable and indeed reasonable thing to then do with the "Persona/Firefox" theming mechanism (which LO still supports natively, even though it may not be much used - it is in Options - LibreOffice - Personalisation - Own Theme) is for whatever background image it specifies to spread fully across the "area formerly known as the title bar", including the topmost part of the window - I had no other meaning than that in terms of cross-platform UI. Either that, or not to support it at all any longer, which I think would be a shame. Setting this back to NEW as I believe this should sufficiently clarify the meaning of the bug - but I will also butt out at this point -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96495] Header And Footer Settings Ignored on imported ODT files
https://bugs.documentfoundation.org/show_bug.cgi?id=96495 --- Comment #6 from Luke--- Version: 6.1.0.0.alpha1+ Build ID: e4d95fa557179d787fd78211b76dd7c311940762 Same content on first page does not work - the content of the first page header remains unique. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112587] Slideshow Animation Timings Ignored on Slower PC
https://bugs.documentfoundation.org/show_bug.cgi?id=112587 --- Comment #13 from Luke--- After the animation plays, if you press: 1) left arrow 2) space to replay the animation, the 2nd and all subsequent times it will render properly even on a slow PC. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'refs/tags/co-5.3-49'
Tag 'co-5.3-49' created by Andras Timarat 2018-05-25 03:59 + co-5.3-49 Changes since co-5.3-48-23: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/tags/gov-5.3-49'
Tag 'gov-5.3-49' created by Andras Timarat 2018-05-25 04:00 + gov-5.3-49 Changes since co-5.3-48-23: --- 0 files changed --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/gov-5.3-49'
Tag 'gov-5.3-49' created by Andras Timarat 2018-05-25 04:00 + gov-5.3-49 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/co-5.3-49'
Tag 'co-5.3-49' created by Andras Timarat 2018-05-25 03:59 + co-5.3-49 Changes since cp-5.3-10: Olivier R (1): tdf#107558 French spelling dictionary (6.0.3) and thesaurus --- fr_FR/README_fr.txt |4 fr_FR/description.xml |2 fr_FR/fr.aff |17751 ++-- fr_FR/fr.dic |155369 +- fr_FR/package-description.txt |2 fr_FR/thes_fr.dat | 206 6 files changed, 88495 insertions(+), 84839 deletions(-) --- ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/unocrsrhelper.hxx |3 ++- sw/source/core/unocore/unoobj.cxx |5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit f7f2d03bd6f5aa5dcd0f7976b4a7f2db278c2f03 Author: Justin LuthDate: Fri May 18 06:59:26 2018 +0300 NFC SwUnoCursorHelper: add SetModeAttr option to setPropertyValue The other function, setPropertyValues already has this variable, so for consistency and flexibility, add it here as well. Plus, this is prep work for another patch. Change-Id: I16c5b1cbb9fd99a11be99a59005bd856d787a6ca Reviewed-on: https://gerrit.libreoffice.org/54510 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/inc/unocrsrhelper.hxx b/sw/inc/unocrsrhelper.hxx index 56e0d48e1331..7624c59afaf3 100644 --- a/sw/inc/unocrsrhelper.hxx +++ b/sw/inc/unocrsrhelper.hxx @@ -156,7 +156,8 @@ namespace SwUnoCursorHelper SwPaM& rPaM, const SfxItemPropertySet & rPropSet, const OUString & rPropertyName, -const css::uno::Any & rValue); +const css::uno::Any & rValue, +const SetAttrMode nAttrMode = SetAttrMode::DEFAULT); /// @throws css::beans::UnknownPropertyException /// @throws css::beans::PropertyVetoException /// @throws css::lang::IllegalArgumentException diff --git a/sw/source/core/unocore/unoobj.cxx b/sw/source/core/unocore/unoobj.cxx index 5505597bab0d..862f9635d70c 100644 --- a/sw/source/core/unocore/unoobj.cxx +++ b/sw/source/core/unocore/unoobj.cxx @@ -1752,12 +1752,13 @@ uno::Any SwUnoCursorHelper::GetPropertyValue( void SwUnoCursorHelper::SetPropertyValue( SwPaM& rPaM, const SfxItemPropertySet& rPropSet, const OUString& rPropertyName, -const uno::Any& rValue) +const uno::Any& rValue, +const SetAttrMode nAttrMode) { uno::Sequence< beans::PropertyValue > aValues(1); aValues[0].Name = rPropertyName; aValues[0].Value = rValue; -SetPropertyValues(rPaM, rPropSet, aValues, SetAttrMode::DEFAULT); +SetPropertyValues(rPaM, rPropSet, aValues, nAttrMode); } // FN_UNO_PARA_STYLE is known to set attributes for nodes, inside ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90064] Top and bottom selection border shown while scrolling even when selection started earlier
https://bugs.documentfoundation.org/show_bug.cgi?id=90064 --- Comment #6 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45162] TABLES paste table in a number section causes all cells in table to be numbered
https://bugs.documentfoundation.org/show_bug.cgi?id=45162 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104241] Not possible to scroll past page 1 in GS51-GettingStartedLO.odt ( large image on page 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=104241 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108065] [FILESAVE DOCX] Gradient property of the data series not preserved when saved as DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=108065 --- Comment #4 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104475] FILESAVE DOCX: Lines lost after RT
https://bugs.documentfoundation.org/show_bug.cgi?id=104475 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107928] DOCX table with Arabic text imported from left to right instead from right to left
https://bugs.documentfoundation.org/show_bug.cgi?id=107928 --- Comment #10 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96495] Header And Footer Settings Ignored on imported ODT files
https://bugs.documentfoundation.org/show_bug.cgi?id=96495 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108067] [FILESAVE DOCX] Exploded Donut charts do not "explode" if more than 1 column of data
https://bugs.documentfoundation.org/show_bug.cgi?id=108067 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 97106] FORMATTING: Calc wrap text setting in Cell Formatting not persisted
https://bugs.documentfoundation.org/show_bug.cgi?id=97106 --- Comment #5 from QA Administrators--- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/swe/libreoffice-5-2+backports' - 2 commits - sw/qa sw/source
sw/qa/extras/rtfimport/rtfimport.cxx |3 --- sw/source/filter/xml/xmltexti.cxx| 11 --- 2 files changed, 8 insertions(+), 6 deletions(-) New commits: commit d7b0063c32502f01fcec72492d131760f4fda990 Author: Caolán McNamaraDate: Tue May 1 12:57:02 2018 +0100 set Referer on link mediadescriptor to allow determining if the source document is from a trusted/untrusted location Reviewed-on: https://gerrit.libreoffice.org/53693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit cd25a97bbadc0a5c1fd6b0e8603c8b6ebd051926) Reviewed-on: https://gerrit.libreoffice.org/53803 Reviewed-by: Miklos Vajna Reviewed-by: Mike Kaganski Tested-by: Mike Kaganski (cherry picked from commit 2d87c267267530077a94c894bc619831b01d1c04) Conflicts: sw/source/filter/xml/xmltexti.cxx Change-Id: I780568652d2ef0cc8543c27ba26289277b5d9d0c diff --git a/sw/source/filter/xml/xmltexti.cxx b/sw/source/filter/xml/xmltexti.cxx index 710f010b1cdc..943db05c75bf 100644 --- a/sw/source/filter/xml/xmltexti.cxx +++ b/sw/source/filter/xml/xmltexti.cxx @@ -577,16 +577,21 @@ uno::Reference< XPropertySet > SwXMLTextImportHelper::createAndInsertOOoLink( uno::Sequence< beans::PropertyValue > aMediaDescriptor( 1 ); aMediaDescriptor[0].Name = "URL"; aMediaDescriptor[0].Value <<= OUString( aURLObj.GetMainURL( INetURLObject::NO_DECODE ) ); -if ( pDoc->GetDocShell() && pDoc->GetDocShell()->GetMedium() ) + +if (SfxMedium* pMedium = pDoc->GetDocShell() ? pDoc->GetDocShell()->GetMedium() : nullptr) { -uno::Reference< task::XInteractionHandler > xInteraction = - pDoc->GetDocShell()->GetMedium()->GetInteractionHandler(); +uno::Reference< task::XInteractionHandler > xInteraction = pMedium->GetInteractionHandler(); if ( xInteraction.is() ) { aMediaDescriptor.realloc( 2 ); aMediaDescriptor[1].Name = "InteractionHandler"; aMediaDescriptor[1].Value <<= xInteraction; } + +const auto nLen = aMediaDescriptor.getLength() + 1; +aMediaDescriptor.realloc(nLen); +aMediaDescriptor[nLen - 1].Name = "Referer"; +aMediaDescriptor[nLen - 1].Value <<= pMedium->GetName(); } uno::Reference < embed::XEmbeddedObject > xObj( commit c8278b68b398b3c2b8556821958e977750409b28 Author: Luboš Luňák Date: Tue Apr 24 13:01:22 2018 +0200 remove page count check in a test (irrelevant and fragile) If I load this document in LO, either my build or distro build, it has only one page, so the test fails for me only because of the 2-page check. The commit causing this, b904d639a8, has been in for quite a while, so it's apparently something special about my setup, but a) the test doesn't actually require 2 pages for anything, b) the commit mentions that the test is fragile, c) if I manually inspect the .rtf, there's an extra page that I do not see even in Word2013, so the document is possibly a bit broken. One way or another, the page check seems pointless. Change-Id: I18bdf25f71e8eb9225acd667e60f426fca008ee4 Reviewed-on: https://gerrit.libreoffice.org/53380 Tested-by: Jenkins Reviewed-by: Luboš Luňák (cherry picked from commit 6154d04d90b7b4f68e6c3629bf0c6306ef64a937) diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index ded9c987929a..bafe8ed3cea5 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -2757,9 +2757,6 @@ DECLARE_RTFIMPORT_TEST(testImportHeaderFooter, "tdf108055.rtf") DECLARE_RTFIMPORT_TEST(testTdf108947, "tdf108947.rtf") { -//Check page count -CPPUNIT_ASSERT_EQUAL(2, getPages()); - //Check if Headers/Footers contain what they should in this document uno::Reference xHeaderTextRight = getProperty< uno::Reference >(getStyles("PageStyles")->getByName("Default Style"), "HeaderTextRight"); OUString aActual = xHeaderTextRight->getString(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117247] External link images are shifted to the right when updated
https://bugs.documentfoundation.org/show_bug.cgi?id=117247 Tomaz Vajngerlchanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Bug 116280 depends on bug 117247, which changed state. Bug 117247 Summary: External link images are shifted to the right when updated https://bugs.documentfoundation.org/show_bug.cgi?id=117247 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117785] Pivot Table Sorts inoperative
https://bugs.documentfoundation.org/show_bug.cgi?id=117785 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- I think data on pivot table are always sorted by columns/rows order. It's possible to edit the row/columns field to sort on ascending/descending order and choose to sort by data fields. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117601] Crash in: libstdc++.so.6.0.22 on merge cells in writer with TDF .debs on Debian 9
https://bugs.documentfoundation.org/show_bug.cgi?id=117601 --- Comment #12 from Anass Ahmed--- I'm not sure if it's related, but the same issue happens on Fedora 28 (both system package, and flatpak package from Flathub: 6.0.x). See downstream bug for sample document and coredump: https://bugzilla.redhat.com/show_bug.cgi?id=1582324 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - external/curl
external/curl/curl-msvc.patch.1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 331e325b8229976312129daa1bc94a584104cb07 Author: Mike KaganskiDate: Thu May 24 14:20:08 2018 -0700 Fix build with SDK 7.1A Change-Id: I2031b8c162d6fdb666d6f6d0daec205b88190370 Reviewed-on: https://gerrit.libreoffice.org/54782 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/external/curl/curl-msvc.patch.1 b/external/curl/curl-msvc.patch.1 index 80160958c99d..8ea8530454ad 100644 --- a/external/curl/curl-msvc.patch.1 +++ b/external/curl/curl-msvc.patch.1 @@ -7,7 +7,7 @@ MSVC: using SOLARINC CC_NODEBUG = $(CC) /O2 /DNDEBUG CC_DEBUG= $(CC) /Od /D_DEBUG /RTC1 /Z7 /LDd -CFLAGS = /I. /I ../lib /I../include /nologo /W4 /wd4127 /EHsc /DWIN32 /FD /c /DBUILDING_LIBCURL -+CFLAGS = /I. /I ../lib /I../include /nologo /W4 /wd4127 /EHsc /DWIN32 /FD /c /DBUILDING_LIBCURL $(SOLARINC) ++CFLAGS = /I. /I ../lib /I../include /nologo /W4 /wd4127 /EHsc /DWIN32 /FD /c /DBUILDING_LIBCURL $(SOLARINC) /D_USING_V110_SDK71_ !ENDIF LFLAGS = /nologo /machine:$(MACHINE) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117778] UI: Spreadsheet cell comment window doesn' t enlarge to hold added text
https://bugs.documentfoundation.org/show_bug.cgi?id=117778 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||99825 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99825 [Bug 99825] [META] SVG bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99825] [META] SVG bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=99825 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Depends on||117778 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117778 [Bug 117778] UI: Spreadsheet cell comment window doesn't enlarge to hold added text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117788] New: use library resvg for work with SVG file
https://bugs.documentfoundation.org/show_bug.cgi?id=117788 Bug ID: 117788 Summary: use library resvg for work with SVG file Product: LibreOffice Version: 6.1.0.0.alpha1+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: filters and storage Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: use library resvg for work with SVG file instead existing module svgio. GitHUB - https://github.com/RazrFalcon/resvg Steps to Reproduce: 1. May be anybody will be interested with integration resvg instead svgio 2. 3. Actual Results: we use svgio Expected Results: we use resvg Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn' t apply if a cell has a number format applied by direct formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=117715 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=117719 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal
https://bugs.documentfoundation.org/show_bug.cgi?id=117787 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=117719 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117720] Delete item Maximum from drop-down list Minimum and delete item Minimum from drop-down list Maximum in dialogue Conditional Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=117720 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117647] change names of some conditions for "Cell value is" in dialogue "Conditional Formatting"
https://bugs.documentfoundation.org/show_bug.cgi?id=117647 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added Blocks||87351 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87351] [META] Conditional formatting bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87351 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Depends on||117647, 117715, 117719, ||117720, 117787 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=117647 [Bug 117647] change names of some conditions for "Cell value is" in dialogue "Conditional Formatting" https://bugs.documentfoundation.org/show_bug.cgi?id=117715 [Bug 117715] Unlike other settings, Number Format in a conditional formatting style doesn't apply if a cell has a number format applied by direct formatting https://bugs.documentfoundation.org/show_bug.cgi?id=117719 [Bug 117719] add labels Minimum and Maximum for drop-down lists in dialogue Conditional Formatting https://bugs.documentfoundation.org/show_bug.cgi?id=117720 [Bug 117720] Delete item Maximum from drop-down list Minimum and delete item Minimum from drop-down list Maximum in dialogue Conditional Formatting https://bugs.documentfoundation.org/show_bug.cgi?id=117787 [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal
https://bugs.documentfoundation.org/show_bug.cgi?id=117787 --- Comment #3 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142268 --> https://bugs.documentfoundation.org/attachment.cgi?id=142268=edit File-example -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal
https://bugs.documentfoundation.org/show_bug.cgi?id=117787 --- Comment #1 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142266 --> https://bugs.documentfoundation.org/attachment.cgi?id=142266=edit Screenshot 1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117787] strips of data bar merge into one block if values in adjacent cells are equal
https://bugs.documentfoundation.org/show_bug.cgi?id=117787 --- Comment #2 from kompilainenn <79045_79...@mail.ru> --- Created attachment 142267 --> https://bugs.documentfoundation.org/attachment.cgi?id=142267=edit Screenshot 2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117787] New: strips of data bar merge into one block if values in adjacent cells are equal
https://bugs.documentfoundation.org/show_bug.cgi?id=117787 Bug ID: 117787 Summary: strips of data bar merge into one block if values in adjacent cells are equal Product: LibreOffice Version: 6.0.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 79045_79...@mail.ru Description: strips of data bar merge into one block if values in adjacent cells are equal (see screenshot) if double click on cells in block, then strips will be divided (see screenshot 2). but if scroll sheet down and then scroll up -> strips again merge Steps to Reproduce: 1. Open file from attach 2. Look at range A1:A19 3. Double click on cells from big blocks 4. Look at divide strips 5. scroll sheet down/up 6. look at blocks again Actual Results: strips of data bar merge into one block if values in adjacent cells are equal Expected Results: strips of data bar always divide for any values in cells Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117786] New: lost 5 pages of work :/
https://bugs.documentfoundation.org/show_bug.cgi?id=117786 Bug ID: 117786 Summary: lost 5 pages of work :/ Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: angelodalcors...@hotmail.com Description: hello i always try to support inovation projects but on saturday i wrote 5 pages of an article for the university i study but when was going to save the program suddenly close. i know i should have saved and have other programs saving it and you don't have profissional support but if you can help anyhow i would be pleased :(:(:( Steps to Reproduce: 1.write a very good article by own 2.write a very good article by own 3.write a very good article by own Actual Results: write a very good article by own write a very good article by own write a very good article by own write a very good article by own write a very good article by own Expected Results: write a very good article by own write a very good article by own write a very good article by own Reproducible: Couldn't Reproduce User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: wsd/FileServer.cpp
wsd/FileServer.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 14bda5897e9007091263dfd8c02712a4d598ecbc Author: Andras TimarDate: Thu May 24 13:33:45 2018 +0200 more tweaks to supported/unsupported branding Change-Id: I6df2047ace23a2613bb1a314284c8aa2cc2a5c8d Reviewed-on: https://gerrit.libreoffice.org/54759 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp index 669f57c4b..3f7080ecd 100644 --- a/wsd/FileServer.cpp +++ b/wsd/FileServer.cpp @@ -564,7 +564,7 @@ std::string FileServerRequestHandler::getRequestPathname(const HTTPRequest& requ constexpr char BRANDING[] = "branding"; #if ENABLE_SUPPORT_KEY -constexpr char BRANDING_SUPPORTED[] = "branding-supported"; +constexpr char BRANDING_UNSUPPORTED[] = "branding-unsupported"; #endif void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco::MemoryInputStream& message, const std::shared_ptr& socket) @@ -627,10 +627,10 @@ void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco:: #if ENABLE_SUPPORT_KEY const std::string keyString = config.getString("support_key", ""); SupportKey key(keyString); -if (key.verify() && key.validDaysRemaining() > 0) +if (!key.verify() || key.validDaysRemaining() <= 0) { -brandCSS = Poco::format(linkCSS, std::string(BRANDING_SUPPORTED)); -brandJS = Poco::format(scriptJS, std::string(BRANDING_SUPPORTED)); +brandCSS = Poco::format(linkCSS, std::string(BRANDING_UNSUPPORTED)); +brandJS = Poco::format(scriptJS, std::string(BRANDING_UNSUPPORTED)); } #elif ENABLE_DEBUG brandCSS = ""; @@ -807,9 +807,9 @@ void FileServerRequestHandler::preprocessAdminFile(const HTTPRequest& request,co const std::string keyString = config.getString("support_key", ""); SupportKey key(keyString); -if (key.verify() && key.validDaysRemaining() > 0) +if (!key.verify() || key.validDaysRemaining() <= 0) { -brandJS = Poco::format(scriptJS, std::string(BRANDING_SUPPORTED)); +brandJS = Poco::format(scriptJS, std::string(BRANDING_UNSUPPORTED)); brandFooter = Poco::format(footerPage, key.data(), Poco::DateTimeFormatter::format(key.expiry(), Poco::DateTimeFormat::RFC822_FORMAT)); } #elif ENABLE_DEBUG ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/locale.dtd |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit c0fbf99e5601da27c59d131bcca24fafd259e508 Author: Eike RathkeDate: Thu May 24 21:27:06 2018 +0200 ... or not present Change-Id: I56658a7f6eb277fabf8ff4782c86fabac5f14e81 diff --git a/i18npool/source/localedata/data/locale.dtd b/i18npool/source/localedata/data/locale.dtd index ed50ff8c5539..8ea44d2f0a4a 100644 --- a/i18npool/source/localedata/data/locale.dtd +++ b/i18npool/source/localedata/data/locale.dtd @@ -148,7 +148,8 @@ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/data/locale.dtd | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit 7c0c35b468be215d6d7b450f2c621d792d201413 Author: Eike RathkeDate: Thu May 24 21:23:33 2018 +0200 Document locale data's use of the Variant element as BCP 47 language tag Change-Id: I8d2c4bb95ae50e7d23a89db1dd6bb197d3af65c0 diff --git a/i18npool/source/localedata/data/locale.dtd b/i18npool/source/localedata/data/locale.dtd index fd4a523f12c8..ed50ff8c5539 100644 --- a/i18npool/source/localedata/data/locale.dtd +++ b/i18npool/source/localedata/data/locale.dtd @@ -127,6 +127,12 @@ @@ -140,7 +146,10 @@ --> - +
[Libreoffice-commits] online.git: wsd/FileServer.cpp
wsd/FileServer.cpp | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) New commits: commit 49b3957086165891d8a1683e75d6d862f9ddca7e Author: Jan HolesovskyDate: Thu May 24 11:54:45 2018 +0200 Throw if admin console is not enabled. And few other smaller tweaks around different branding with support key enabled. Change-Id: I9a751374c9384d9535a208c9bd912e2041fd5879 Reviewed-on: https://gerrit.libreoffice.org/54753 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp index 17531623f..669f57c4b 100644 --- a/wsd/FileServer.cpp +++ b/wsd/FileServer.cpp @@ -47,9 +47,6 @@ #include #include -#define BRAND_SUPPORTED "branding" -#define BRAND_UNSUPPORTED "branding-CODE" - using Poco::Net::HTMLForm; using Poco::Net::HTTPBasicCredentials; using Poco::Net::HTTPRequest; @@ -565,10 +562,13 @@ std::string FileServerRequestHandler::getRequestPathname(const HTTPRequest& requ return path; } +constexpr char BRANDING[] = "branding"; +#if ENABLE_SUPPORT_KEY +constexpr char BRANDING_SUPPORTED[] = "branding-supported"; +#endif + void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco::MemoryInputStream& message, const std::shared_ptr& socket) { -static const std::string linkCSS = ""; -static const std::string scriptJS = ""; const auto host = ((LOOLWSD::isSSLEnabled() || LOOLWSD::isSSLTermination()) ? "wss://" : "ws://") + (LOOLWSD::ServerName.empty() ? request.getHost() : LOOLWSD::ServerName); const Poco::URI::QueryParameters params = Poco::URI(request.getURI()).getQueryParameters(); @@ -617,8 +617,11 @@ void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco:: Poco::replaceInPlace(preprocess, std::string("%HOST%"), host); Poco::replaceInPlace(preprocess, std::string("%VERSION%"), std::string(LOOLWSD_VERSION_HASH)); -std::string brandCSS(Poco::format(linkCSS, std::string(BRAND_UNSUPPORTED))); -std::string brandJS(Poco::format(scriptJS, std::string(BRAND_UNSUPPORTED))); +static const std::string linkCSS(""); +static const std::string scriptJS(""); + +std::string brandCSS(Poco::format(linkCSS, std::string(BRANDING))); +std::string brandJS(Poco::format(scriptJS, std::string(BRANDING))); const auto& config = Application::instance().config(); #if ENABLE_SUPPORT_KEY @@ -626,8 +629,8 @@ void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco:: SupportKey key(keyString); if (key.verify() && key.validDaysRemaining() > 0) { -brandCSS = Poco::format(linkCSS, std::string(BRAND_SUPPORTED)); -brandJS = Poco::format(scriptJS, std::string(BRAND_SUPPORTED)); +brandCSS = Poco::format(linkCSS, std::string(BRANDING_SUPPORTED)); +brandJS = Poco::format(scriptJS, std::string(BRANDING_SUPPORTED)); } #elif ENABLE_DEBUG brandCSS = ""; @@ -783,16 +786,20 @@ void FileServerRequestHandler::preprocessFile(const HTTPRequest& request, Poco:: void FileServerRequestHandler::preprocessAdminFile(const HTTPRequest& request,const std::shared_ptr& socket) { Poco::Net::HTTPResponse response; -static const std::string scriptJS(""); -static const std::string footerPage("Key: %s Expiry Date: %s"); + +if (!LOOLWSD::AdminEnabled) +throw Poco::FileAccessDeniedException("Admin console disabled"); if (!FileServerRequestHandler::isAdminLoggedIn(request, response)) throw Poco::Net::NotAuthenticatedException("Invalid admin login"); +static const std::string scriptJS(""); +static const std::string footerPage("Key: %s Expiry Date: %s"); + const std::string relPath = getRequestPathname(request); LOG_DBG("Preprocessing file: " << relPath); std::string adminFile = *getUncompressedFile(relPath); -std::string brandJS(Poco::format(scriptJS, std::string(BRAND_UNSUPPORTED))); +std::string brandJS(Poco::format(scriptJS, std::string(BRANDING))); std::string brandFooter; #if ENABLE_SUPPORT_KEY @@ -802,7 +809,7 @@ void FileServerRequestHandler::preprocessAdminFile(const HTTPRequest& request,co if (key.verify() && key.validDaysRemaining() > 0) { -brandJS = Poco::format(scriptJS, std::string(BRAND_SUPPORTED)); +brandJS = Poco::format(scriptJS, std::string(BRANDING_SUPPORTED)); brandFooter = Poco::format(footerPage, key.data(), Poco::DateTimeFormatter::format(key.expiry(), Poco::DateTimeFormat::RFC822_FORMAT)); } #elif ENABLE_DEBUG ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 117785] Pivot Table Sorts inoperative
https://bugs.documentfoundation.org/show_bug.cgi?id=117785 Jim Davischanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jim Davis --- This appears to be corrected in v 6.0.4.2 (x64), but sorting on other than first column and/or row do not appear to work. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 117711] select all moves cursor to the end of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=117711 --- Comment #7 from l...@royal.net --- ^ means ctrl, sorry for being too old school -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 117711] select all moves cursor to the end of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=117711 --- Comment #7 from l...@royal.net --- ^ means ctrl, sorry for being too old school -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3-desktop' - external/curl RepositoryExternal.mk
RepositoryExternal.mk |2 +- external/curl/ExternalProject_curl.mk |5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) New commits: commit cce2149365fbf8599de18b277451aca0d0ce5f73 Author: Mike KaganskiDate: Thu May 24 06:45:27 2018 -0700 Fix curl build on MSVC2013 Change-Id: Ie2e85d5c9945d4204f69135bc59e1d668294a83f Reviewed-on: https://gerrit.libreoffice.org/54770 Reviewed-by: Andras Timar Tested-by: Andras Timar diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index b7eb499504d3..8f0bf9f83d06 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -2684,7 +2684,7 @@ $(call gb_LinkTarget_set_include,$(1),\ ifeq ($(COM),MSC) $(call gb_LinkTarget_add_libs,$(1),\ - $(call gb_UnpackedTarball_get_dir,curl)/lib/$(if $(MSVC_USE_DEBUG_RUNTIME),debug-dll,release-dll)/libcurl$(if $(MSVC_USE_DEBUG_RUNTIME),d)_imp.lib \ + $(call gb_UnpackedTarball_get_dir,curl)/builds/libcurl-vc12-$(if $(filter X86_64,$(CPUNAME)),x64,x86)-$(if $(MSVC_USE_DEBUG_RUNTIME),debug,release)-dll-ipv6-sspi-winssl/lib/libcurl$(if $(MSVC_USE_DEBUG_RUNTIME),_debug).lib \ ) else $(call gb_LinkTarget_add_libs,$(1),\ diff --git a/external/curl/ExternalProject_curl.mk b/external/curl/ExternalProject_curl.mk index 136e50f3a81c..4a0b4d50a608 100644 --- a/external/curl/ExternalProject_curl.mk +++ b/external/curl/ExternalProject_curl.mk @@ -70,11 +70,10 @@ $(call gb_ExternalProject_get_state_target,curl,build): else ifeq ($(COM),MSC) -$(eval $(call gb_ExternalProject_use_nmake,curl,build)) - $(call gb_ExternalProject_get_state_target,curl,build): $(call gb_ExternalProject_run,build,\ - nmake -f Makefile.vc \ + CC="$(shell cygpath -w $(filter-out -%,$(CC))) $(filter -%,$(CC))" \ + MAKEFLAGS= LIB="$(ILIB)" nmake -f Makefile.vc \ mode=dll \ VC=12 \ $(if $(filter X86_64,$(CPUNAME)),MACHINE=x64,MACHINE=x86) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: common/Crypto.cpp common/Crypto.hpp loleaflet/admin loleaflet/loleaflet.html.m4 wsd/FileServer.cpp wsd/FileServer.hpp
common/Crypto.cpp | 10 common/Crypto.hpp |7 ++ loleaflet/admin/admin.html |3 - loleaflet/admin/adminAnalytics.html |3 - loleaflet/admin/adminHistory.html |4 - loleaflet/admin/adminSettings.html |3 - loleaflet/loleaflet.html.m4 |4 - wsd/FileServer.cpp | 86 ++-- wsd/FileServer.hpp |2 9 files changed, 111 insertions(+), 11 deletions(-) New commits: commit 6ff069db62dc38fa9f37d84789266ac4fdf02ba2 Author: Henry CastroDate: Wed Apr 25 15:53:38 2018 -0400 respond different logo brands when it has support Change-Id: Icddc8b67a20fd829c90c3c5d8eb6942da9c5e74d Reviewed-on: https://gerrit.libreoffice.org/53583 Reviewed-by: Jan Holesovsky Tested-by: Jan Holesovsky diff --git a/common/Crypto.cpp b/common/Crypto.cpp index 46ba05c0f..7c1d00052 100644 --- a/common/Crypto.cpp +++ b/common/Crypto.cpp @@ -127,6 +127,16 @@ int SupportKey::validDaysRemaining() return days; } +DateTime SupportKey::expiry() const +{ +return _impl->_expiry; +} + +std::string SupportKey::data() const +{ +return _impl->_data; +} + #endif // ENABLE_SUPPORT_KEY /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/common/Crypto.hpp b/common/Crypto.hpp index 94b194cc2..079a4f742 100644 --- a/common/Crypto.hpp +++ b/common/Crypto.hpp @@ -15,6 +15,9 @@ #include struct SupportKeyImpl; +namespace Poco { +class DateTime; +} class SupportKey { std::unique_ptr _impl; @@ -28,6 +31,10 @@ public: /// How many days until key expires int validDaysRemaining(); + +Poco::DateTime expiry() const; + +std::string data() const; }; #endif diff --git a/loleaflet/admin/admin.html b/loleaflet/admin/admin.html index 0439ac16f..f23d510ca 100644 --- a/loleaflet/admin/admin.html +++ b/loleaflet/admin/admin.html @@ -19,7 +19,7 @@ - + if (typeof brandProductName !== 'undefined') {l10nstrings.strProductName = brandProductName} document.title = l10nstrings.strProductName + ' - ' + l10nstrings.strAdminConsole @@ -141,5 +141,6 @@