[Libreoffice-commits] core.git: mysqlc/source
mysqlc/source/mysqlc_general.cxx |1 + mysqlc/source/mysqlc_preparedstatement.cxx |2 ++ 2 files changed, 3 insertions(+) New commits: commit 22828c32d1ae379782631a351aac34d0b1df95f4 Author: Rene Engelhard AuthorDate: Mon Aug 13 07:30:13 2018 +0200 Commit: Rene Engelhard CommitDate: Mon Aug 13 07:30:45 2018 +0200 fix build (missing #include 's) Change-Id: Idf0b21d41fa0bac0a49c1b28724c487edd336353 diff --git a/mysqlc/source/mysqlc_general.cxx b/mysqlc/source/mysqlc_general.cxx index 8f3d0ed619d2..22e771275328 100644 --- a/mysqlc/source/mysqlc_general.cxx +++ b/mysqlc/source/mysqlc_general.cxx @@ -19,6 +19,7 @@ #include "mysqlc_general.hxx" #include "mysqlc_resultsetmetadata.hxx" +#include #include using com::sun::star::sdbc::SQLException; diff --git a/mysqlc/source/mysqlc_preparedstatement.cxx b/mysqlc/source/mysqlc_preparedstatement.cxx index 9c6da76913e6..40e2ef172d8f 100644 --- a/mysqlc/source/mysqlc_preparedstatement.cxx +++ b/mysqlc/source/mysqlc_preparedstatement.cxx @@ -23,6 +23,8 @@ #include "mysqlc_propertyids.hxx" #include "mysqlc_resultsetmetadata.hxx" +#include + #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 111448] libreoffice calc does not save(or load) position, size and orientation of embedded pictures correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=111448 Jean-Baptiste Faure changed: What|Removed |Added CC||jbfa...@libreoffice.org Summary|libreoffice calc is too |libreoffice calc does not |stupid to save(or load) |save(or load) position, |position, size and |size and orientation of |orientation of embedded |embedded pictures correctly |pictures correctly | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119220] Long CPU spike when adding a new bullet
https://bugs.documentfoundation.org/show_bug.cgi?id=119220 Jean-Baptiste Faure changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||jbfa...@libreoffice.org --- Comment #2 from Jean-Baptiste Faure --- What do you mean with "Long CPU bump"? How long. With all version I tested, it is longer in this case (but not very long from my point of view), probably linked to the size of the last list item. Status set to NEEDINFO, please set it back to UNCONFIRMED once requested informations are provided. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Justin L changed: What|Removed |Added Whiteboard|target:6.2.0| --- Comment #7 from Justin L --- (In reply to Commit Notification from comment #6) Temporary patch - this issue is not yet fixed because that patch will be reverted in a month. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 --- Comment #6 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4 tdf#117994 ww8export: extend Chp over CR It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117994] Font size is too large in attached DOC in Word after roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=117994 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ww8export/ww8export.cxx |3 ++-
sw/source/filter/ww8/wrtww8.cxx |4 ++--
sw/source/filter/ww8/wrtww8.hxx |2 +-
sw/source/filter/ww8/ww8atr.cxx |2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 091aedc63de2f6c8f0f4c60dd1fa93fe4c6ddde4
Author: Justin Luth
AuthorDate: Sat Aug 4 13:55:47 2018 +0300
Commit: Justin Luth
CommitDate: Mon Aug 13 06:07:35 2018 +0200
tdf#117994 ww8export: extend Chp over CR
Plan to revert this within a month - just a test and see.
MS Word has a placeholder that can receive chacter formatting
for the carriage return, but LO doesn't really. So normally
when LO exports, the CR is "unformated", which really
can affect things like paragraph size, or numbering.
So, extend the current character formatting to cover
the CR, so that what we see in Writer is what we get in Word.
This will cause regressions as Writer round-trips documents
that it incorrectly reads. (In other words, even though they
don't look right in Writer, they still used toround-tripped
OK, but now they will be saved with LO's distortions.)
Since normally if we *save* in writer, that implies that
changes have been made, and theoretically the document
looks the way the user wants to re-preserve it, it
is better to now have the document look as Writer
sees it than to preserve some prior formatting.
This really breaks unit test tdf102334.doc, but that
round-tripped document is already *really* broken in Word.
With this patch, it looks like the original again.
(tdf102334.doc looks bad in LO no matter what, it just looks
worse in this case.)
Change-Id: I04d3fdc7dbc66f8732456d7ac5b309c454992d8b
Reviewed-on: https://gerrit.libreoffice.org/58594
Tested-by: Justin Luth
Reviewed-by: Justin Luth
diff --git a/sw/qa/extras/ww8export/ww8export.cxx
b/sw/qa/extras/ww8export/ww8export.cxx
index a53525a5ece7..25af135a35f7 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -675,7 +675,8 @@ DECLARE_WW8EXPORT_TEST(testTdf59896, "tdf59896.doc")
DECLARE_WW8EXPORT_TEST(testTdf102334, "tdf102334.doc")
{
// This was false, i.e. the first run wasn't hidden, when it should have
been
-CPPUNIT_ASSERT_EQUAL(true, getProperty(getRun(getParagraph(7), 1),
"CharHidden"));
+// But this looks different (less hidden) in MSWord
+// CPPUNIT_ASSERT_EQUAL(true, getProperty(getRun(getParagraph(7),
1), "CharHidden"));
}
DECLARE_WW8EXPORT_TEST(testTdf38778,
"tdf38778_properties_in_run_for_field.doc")
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index 10f53ab15b05..6274a3acfca9 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -995,7 +995,7 @@ sal_uInt8 *WW8_WrPlcPn::CopyLastSprms(sal_uInt8 )
return rF.CopyLastSprms(rLen);
}
-void WW8_WrPlcPn::AppendFkpEntry(WW8_FC nEndFc,short nVarLen,const sal_uInt8*
pSprms)
+void WW8_WrPlcPn::AppendFkpEntry(WW8_FC nEndFc,short nVarLen,const sal_uInt8*
pSprms, const bool bExpandEmpty)
{
WW8_WrFkp* pF = m_Fkps.back().get();
@@ -1024,7 +1024,7 @@ void WW8_WrPlcPn::AppendFkpEntry(WW8_FC nEndFc,short
nVarLen,const sal_uInt8* pS
pF->MergeToNew( nVarLen, pNewSprms );
// has the prev EndFC an empty sprm and the current is empty too, then
// expand only the old EndFc to the new EndFc
-else if( !nVarLen && pF->IsEmptySprm() )
+else if( !nVarLen && (bExpandEmpty || pF->IsEmptySprm()) )
{
pF->SetNewEnd( nEndFc );
return ;
diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx
index dde8717443c6..d7854815bae9 100644
--- a/sw/source/filter/ww8/wrtww8.hxx
+++ b/sw/source/filter/ww8/wrtww8.hxx
@@ -1287,7 +1287,7 @@ private:
public:
WW8_WrPlcPn( WW8Export& rWrt, ePLCFT ePl, WW8_FC nStartFc );
~WW8_WrPlcPn();
-void AppendFkpEntry(WW8_FC nEndFc,short nVarLen = 0,const sal_uInt8*
pSprms = nullptr);
+void AppendFkpEntry(WW8_FC nEndFc,short nVarLen = 0,const sal_uInt8*
pSprms = nullptr, const bool bExpandEmpty=false);
void WriteFkps();
void WritePlc();
sal_uInt8 *CopyLastSprms(sal_uInt8 );
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 3f82fa3963dc..774684ee91b6 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -1070,7 +1070,7 @@ void WW8AttributeOutput::OutputFKP(bool bForce)
if (!m_rWW8Export.pO->empty() || bForce)
{
m_rWW8Export.m_pChpPlc->AppendFkpEntry( m_rWW8Export.Strm().Tell(),
-m_rWW8Export.pO->size(), m_rWW8Export.pO->data() );
+m_rWW8Export.pO->size(), m_rWW8Export.pO->data(),
m_rWW8Export.pO->empty() );
m_rWW8Export.pO->clear();
}
}
___
Libreoffice-commits mailing list
[Libreoffice-bugs] [Bug 119239] Personalization with Firefox themes does not bring results
https://bugs.documentfoundation.org/show_bug.cgi?id=119239 --- Comment #3 from Leandro Martín Drudi --- Created attachment 144136 --> https://bugs.documentfoundation.org/attachment.cgi?id=144136=edit Error when search an URL With an URL only show an error messege. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119239] Personalization with Firefox themes does not bring results
https://bugs.documentfoundation.org/show_bug.cgi?id=119239 --- Comment #2 from Leandro Martín Drudi --- Created attachment 144135 --> https://bugs.documentfoundation.org/attachment.cgi?id=144135=edit No results are shown After a few seconds, the search stops without showing results. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119239] Personalization with Firefox themes does not bring results
https://bugs.documentfoundation.org/show_bug.cgi?id=119239 Leandro Martín Drudi changed: What|Removed |Added CC||sanipache...@outlook.com.ar --- Comment #1 from Leandro Martín Drudi --- Created attachment 144134 --> https://bugs.documentfoundation.org/attachment.cgi?id=144134=edit Searching keyword 1) Write a keyword o a Theme name. 2) Clic "Ir a" 3) The messege appears. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119239] New: Personalization with Firefox themes does not bring results
https://bugs.documentfoundation.org/show_bug.cgi?id=119239 Bug ID: 119239 Summary: Personalization with Firefox themes does not bring results Product: LibreOffice Version: 6.1.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sanipache...@outlook.com.ar Description: [ES] Buscar palabras clave, usar los botones rápidos o pegar una URL no trae resultados. Al usar URL, arroja un error. [EN] Searching for keywords, using quick buttons or pasting a URL does not bring results. When using URL, it throws an error. Steps to Reproduce: 1. Open LibreOffice 2. Tools -> Options -> Personalization -> Select Theme 2.1.1 Write a word. 2.1.2 Clic Search 2.1.3 A message appears indicating that the search is being performed 2.1.4 The message disappears and no result is shown. -OR- 2.2.1 Paste a URL with a theme (eg. https://addons.mozilla.org/es/firefox/addon/running-foxes-by-madonna) -> Clic Search 2.2.2 An error occurs and shows the message: "No se puede abrir «https://addons.mozilla.org/en-US/firefox/addon/running-foxes-by-madonna». Inténtelo de nuevo más tarde." Actual Results: No results are shown. -OR- An error occurs and shows the message: "No se puede abrir «https://addons.mozilla.org/en-US/firefox/addon/running-foxes-by-madonna». Inténtelo de nuevo más tarde." Expected Results: Show results in a 9 fields with miniature. -OR- Display the thumbnail of the searched topic through the URL Reproducible: Always User Profile Reset: Yes Additional Info: This happens from previous versions. It has been tested in 5.4.4 and later and the same thing always happened. In the installation 6.1 was made from scratch, previous to delete all the folders. It was also tested in a clean installation, as the first installation in a computer with the recently installed Operating System. It was tested with "Acceleration with hardware" and with OpenGL and in both cases the same thing happens. It was tried starting in "Safe Mode" with identical result. Versión: 6.1.0.3 (x64) Id. de compilación: efb621ed25068d70781dc026f7e9c5187a4decd1 Subprocs. CPU: 4; SO: Windows 10.0; Repres. IU: predet.; Configuración regional: es-AR (es_AR); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119233] Trackpad click handling very slow on MacOS, leads to randomly moving objects in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=119233 --- Comment #2 from Ken Shirriff --- I updated, but I'm still seeing this with 6.0.6 and 6.1.0.3, both with the sidebar opened and closed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109205] Text box created on wrong position with large image in multipage doc
https://bugs.documentfoundation.org/show_bug.cgi?id=109205 --- Comment #10 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45540] Changing between Documents not Possible if Dialog Boxes are Displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=45540 --- Comment #8 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111745] Corner radius is not inherited from master slide shape
https://bugs.documentfoundation.org/show_bug.cgi?id=111745 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53156] PRINTING: a thin line appearing on top end of the thick inner line(border)
https://bugs.documentfoundation.org/show_bug.cgi?id=53156 --- Comment #6 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111730] EDITING Reset Filter works not properly
https://bugs.documentfoundation.org/show_bug.cgi?id=111730 --- Comment #3 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/js
loleaflet/js/toolbar.js | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
New commits:
commit 1018589d44315ce96ea1e4d1ef7acd7e7c31da98
Author: Henry Castro
AuthorDate: Sun Aug 12 21:06:10 2018 -0400
Commit: Henry Castro
CommitDate: Sun Aug 12 21:20:19 2018 -0400
loleaflet: fix the number of users label from the status bar
Change-Id: I0b7e66c73a335295e5e61510bc0b68fc5c08ca58
diff --git a/loleaflet/js/toolbar.js b/loleaflet/js/toolbar.js
index 98e7d6f5b..a08e81598 100644
--- a/loleaflet/js/toolbar.js
+++ b/loleaflet/js/toolbar.js
@@ -32,13 +32,6 @@ function _mobilify() {
statusbar.hide(item.id);
}
});
-
- nUsers = '%n';
- oneUser = '1';
- noUser = '0';
- updateUserListCount();
-
- $('#document-name-input').hide();
}
function resizeToolbar() {
@@ -1240,11 +1233,23 @@ function onDocLayerInit() {
break;
}
- toolbarUp.refresh();
- statusbar.refresh();
+
if (L.Browser.mobile) {
_mobilify();
+ nUsers = '%n';
+ oneUser = '1';
+ noUser = '0';
+ $('#document-name-input').hide();
+ } else {
+ nUsers = _('%n users');
+ oneUser = _('1 user');
+ noUser = _('0 users');
+ $('#document-name-input').show();
}
+
+ updateUserListCount();
+ toolbarUp.refresh();
+ statusbar.refresh();
}
function onCommandStateChanged(e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119234] filter import of OOXML Shapes from Word fail to render in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=119234 --- Comment #3 from V Stuart Foote --- Created attachment 144133 --> https://bugs.documentfoundation.org/attachment.cgi?id=144133=edit flat ODF text file of test file converted in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119234] filter import of OOXML Shapes from Word fail to render in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=119234 V Stuart Foote changed: What|Removed |Added OS|Mac OS X (All) |All --- Comment #2 from V Stuart Foote --- Same filter issues on Windows builds. While the Word 2016 conversion to ODF opens cleanly on import to LibreOffice. Attached is the Word 2016 ODF save converted to Flat ODF Text in LibreOffice =-testing-= Windows 10 Home 64-bit (1803) en-US with Version: 6.1.0.3 (x64) Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: en-US (en_US); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88173] [META] DOCX (OOXML) format limitations
https://bugs.documentfoundation.org/show_bug.cgi?id=88173 V Stuart Foote changed: What|Removed |Added Depends on||119234 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119234 [Bug 119234] filter import of OOXML Shapes from Word fail to render in LibreOffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119234] filter import of OOXML Shapes from Word fail to render in LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=119234 V Stuart Foote changed: What|Removed |Added Ever confirmed|0 |1 CC||vstuart.fo...@utsa.edu Summary|Shapes fail to render |filter import of OOXML ||Shapes from Word fail to ||render in LibreOffice Status|UNCONFIRMED |NEW Keywords||filter:docx Blocks||88173 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=88173 [Bug 88173] [META] DOCX (OOXML) format limitations -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103342] [META] Font substitution bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103342 Bug 103342 depends on bug 115944, which changed state. Bug 115944 Summary: Render differences of DOCX between Word and LibreOffice with Palatino and Tekton fonts https://bugs.documentfoundation.org/show_bug.cgi?id=115944 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 115944] Render differences of DOCX between Word and LibreOffice with Palatino and Tekton fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=115944 V Stuart Foote changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED --- Comment #26 from V Stuart Foote --- Coretext (Word) vs Harfbuzz (LO)-- will never render the same. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119237] Color Issues in Menubar / Toolbars in High Contrast Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=119237 --- Comment #3 from Justin --- Created attachment 144132 --> https://bugs.documentfoundation.org/attachment.cgi?id=144132=edit Screenshot showing current color settings in Libreoffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119237] Color Issues in Menubar / Toolbars in High Contrast Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=119237 --- Comment #2 from Justin --- Created attachment 144131 --> https://bugs.documentfoundation.org/attachment.cgi?id=144131=edit Screenshot showing my current accessability settings in Libreoffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119237] Color Issues in Menubar / Toolbars in High Contrast Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=119237 --- Comment #1 from Justin --- Created attachment 144130 --> https://bugs.documentfoundation.org/attachment.cgi?id=144130=edit Screenshot of the issue -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119238] New: Documents opened from desktop are not later saved to the same spot on desktop
https://bugs.documentfoundation.org/show_bug.cgi?id=119238 Bug ID: 119238 Summary: Documents opened from desktop are not later saved to the same spot on desktop Product: LibreOffice Version: 6.1.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: damonele...@gmail.com Description: Any LibreOffice document opened from its icon on my desktop, then edited and saved will be saved to the first available spot on the desktop instead of the spot where from it was originally opened. Steps to Reproduce: 1. Open document from anywhere on the desktop and edit. 2. Save edit and close LibreOffice. (observe that document has been saved to first available space a left of desktop and the original icon is now gone) Actual Results: Document icon moves from original location to first available spot on desktop Expected Results: The document should have been saved to its original location on the desktop. Reproducible: Always User Profile Reset: No Additional Info: Version: 6.1.0.3 Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 2; OS: Windows 10.0; UI render: default; Locale: en-US (en_US); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119237] New: Color Issues in Menubar / Toolbars in High Contrast Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=119237 Bug ID: 119237 Summary: Color Issues in Menubar / Toolbars in High Contrast Mode Product: LibreOffice Version: 6.0.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: justhodg...@gmail.com Description: I use a high-contrast theme on Windows 10 since I am visually impaired. Up through Version 5.4.7 of Libreoffice, when I selected the "Automatically detect high-contrast mode" option in the Options dialogue the entire interface reflected the high-contrast mode of my system (black background, yellow test). However, since Libreoffice 6.0 (including Libreoffice 6.1), when I have this option selected the top toolbars and menubar have a white background and no text is visible on the menubar (which suggests that the text is yellow, as it should be, and thus is not visible against the white background). I have gone into the "Application Colors" menu and the Application Background color is displayed as black (labeled as "Automatic"). I can provide screenshots of the issue if this would help. Steps to Reproduce: 1. Enable high-contrast mode in Windows 10 2. Open Libreoffice and go to Tools -> Options -> Accessability and enable "Automatically detect high contrast mode of operating system". 3. Restart Libreoffice and open any application (i.e. Writer or Calc). 4. You shold encounter the issue. Actual Results: Menubar and toolbars have white background and (apparently) yellow text Expected Results: Menubar and toolbars should have black background & hellow text to match the system's high contrast mode. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82317] Shortcut for Pasting Unformatted Text Within Cells
https://bugs.documentfoundation.org/show_bug.cgi?id=82317 --- Comment #11 from Tom Colley --- I just tested as per Comment 3 using: - Linux Ubuntu 18.04 - LibreOffice 6.06.2 In Calc, I still get the same result when I press Ctrl+Shift+Alt+V: the letter “V” is pasted, not the unformatted text. Pressing Ctrl+Shift+V provides a dialog box with the standard "Unformatted text" option. This delivers the required functionality in a two-step process which is fine. We've all got "bigger fish to fry", so leaving this as "Resolved - WorksForMe" seems appropriate. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/print_revamp' - include/vcl vcl/inc vcl/source
include/vcl/print.hxx |3 +++
vcl/inc/printdlg.hxx |1 +
vcl/source/gdi/print3.cxx | 15 +++
vcl/source/window/printdlg.cxx | 36
4 files changed, 51 insertions(+), 4 deletions(-)
New commits:
commit e14d9102a62bc3b3af17123d4307cda09f403351
Author: Daniel
AuthorDate: Sun Aug 12 17:32:30 2018 -0300
Commit: Daniel Silva
CommitDate: Mon Aug 13 01:29:14 2018 +0200
Resolves the mismatching behavior between page size and orientatin selection
Change-Id: I8482fa062441aac59fac7324b0987eb20face077
Reviewed-on: https://gerrit.libreoffice.org/58907
Tested-by: Jenkins
Reviewed-by: Daniel Silva
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index d4ec3219af3d..2e3cc1a79db7 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -557,7 +557,10 @@ public:
SAL_DLLPRIVATEbool getReversePrint() const;
SAL_DLLPRIVATEvoid setPapersizeFromSetup( bool
i_bPapersizeFromSetup );
SAL_DLLPRIVATEbool getPapersizeFromSetup() const;
+SAL_DLLPRIVATESize& getPaperSizeSetup() const;
SAL_DLLPRIVATEvoid setPaperSizeFromUser( Size i_aUserSize
);
+SAL_DLLPRIVATESize& getPaperSizeFromUser() const;
+SAL_DLLPRIVATEbool isPaperSizeFromUser() const;
VCL_PLUGIN_PUBLIC void setPrinterModified( bool
i_bPapersizeFromSetup );
VCL_PLUGIN_PUBLIC bool getPrinterModified() const;
SAL_DLLPRIVATEvoid pushPropertiesToPrinter();
diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index 3b6ad1827fa3..cbf91436f565 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -233,6 +233,7 @@ namespace vcl
void setPaperOrientation( Orientation eOrientation );
void updateOrientationBox( bool bAutomatic = true );
bool hasOrientationChanged() const;
+void checkPaperSize( Size& rPaperSize );
void setPreviewText();
void updatePrinterText();
void checkControlDependencies();
diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx
index b56a5740a5fd..1fb481471180 100644
--- a/vcl/source/gdi/print3.cxx
+++ b/vcl/source/gdi/print3.cxx
@@ -1382,6 +1382,11 @@ bool PrinterController::getPapersizeFromSetup() const
return mpImplData->mbPapersizeFromSetup;
}
+Size& PrinterController::getPaperSizeSetup() const
+{
+return mpImplData->maDefaultPageSize;
+}
+
void PrinterController::setPaperSizeFromUser( Size i_aUserSize )
{
mpImplData->mbPapersizeFromUser = true;
@@ -1391,6 +1396,16 @@ void PrinterController::setPaperSizeFromUser( Size
i_aUserSize )
mpImplData->maUserPageSize = i_aUserSize;
}
+Size& PrinterController::getPaperSizeFromUser() const
+{
+return mpImplData->maUserPageSize;
+}
+
+bool PrinterController::isPaperSizeFromUser() const
+{
+return mpImplData->mbPapersizeFromUser;
+}
+
void PrinterController::setPrinterModified( bool i_bPrinterModified )
{
mpImplData->mbPrinterModified = i_bPrinterModified;
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 8308f11f7272..c62142d6cba4 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1037,11 +1037,36 @@ bool PrintDialog::hasOrientationChanged() const
|| (nOrientation == ORIENTATION_PORTRAIT && eOrientation ==
Orientation::Landscape);
}
-// Always use this function to set paper orientation in
-// order to update document orientation as well
+// make sure paper size matches paper orientation
+void PrintDialog::checkPaperSize( Size& rPaperSize )
+{
+Orientation eOrientation = maPController->getPrinter()->GetOrientation();
+if ( (eOrientation == Orientation::Portrait && rPaperSize.Width() >
rPaperSize.Height()) ||
+ (eOrientation == Orientation::Landscape && rPaperSize.Width() <
rPaperSize.Height()) )
+{
+rPaperSize = Size( rPaperSize.Height(), rPaperSize.Width() );
+}
+}
+
+// Always use this function to set paper orientation to make sure everything
behaves well
void PrintDialog::setPaperOrientation( Orientation eOrientation )
{
-maPController->getPrinter()->SetOrientation( eOrientation );
+VclPtr aPrt( maPController->getPrinter() );
+aPrt->SetOrientation( eOrientation );
+
+// check if it's necessary to swap width and height of paper
+if ( maPController->isPaperSizeFromUser() )
+{
+Size& aPaperSize = maPController->getPaperSizeFromUser();
+checkPaperSize( aPaperSize );
+}
+else if ( maPController->getPapersizeFromSetup() )
+{
+Size& aPaperSize = maPController->getPaperSizeSetup();
+checkPaperSize( aPaperSize );
+}
+
+// used to sync printer paper orientation with document orientation
maPController->setValue( "IsLandscape",
makeAny(
[Libreoffice-bugs] [Bug 118304] Preview glyph and charmap of selected Unicodepoint does not behave when changing to a font without coverage of the codepoint
https://bugs.documentfoundation.org/show_bug.cgi?id=118304 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:6.2.0 target:6.1.1 |target:6.2.0 target:6.1.0 |target:6.1.0| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119236] New: UI: Dimension dialog for measure line is missing
https://bugs.documentfoundation.org/show_bug.cgi?id=119236 Bug ID: 119236 Summary: UI: Dimension dialog for measure line is missing Product: LibreOffice Version: 6.0.0.0.alpha1+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Draw a measure line in Writer or copy one from Draw. Try to alter dimension properties like guide overhang, guide distance, dimension line placement. That is not possible, because the Dimension dialog does not exists in Writer. In Draw you get the dialog in the graphic style or as direct formatting in the context menu. In Draw it is the command .uno:MeasureAttributes. Because of unwanted changes in unit and size, when copying from Draw to Writer, the dialog is sorely needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - sfx2/sdi
sfx2/sdi/sfx.sdi |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 789d2791c7c0f32f23dd96af44c1421a9c13a753 Author: Maxim Monastirsky AuthorDate: Sun Aug 12 15:40:50 2018 +0300 Commit: Adolfo Jayme Barrientos CommitDate: Mon Aug 13 00:30:29 2018 +0200 Don't show ShowImeStatusWindow in the customization dialog Change-Id: I5aeac6cf6ec9fae56c0dba3c176e0d6c52a28a5e Reviewed-on: https://gerrit.libreoffice.org/58899 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky (cherry picked from commit d42d937e6edb85bb8c2795cd54dc237e0da49bd6) Reviewed-on: https://gerrit.libreoffice.org/58902 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sfx2/sdi/sfx.sdi b/sfx2/sdi/sfx.sdi index 9031982badb5..383817ab54a5 100644 --- a/sfx2/sdi/sfx.sdi +++ b/sfx2/sdi/sfx.sdi @@ -4844,9 +4844,9 @@ SfxBoolItem ShowImeStatusWindow SID_SHOW_IME_STATUS_WINDOW RecordPerSet; -AccelConfig = TRUE, -MenuConfig = TRUE, -ToolBoxConfig = TRUE, +AccelConfig = FALSE, +MenuConfig = FALSE, +ToolBoxConfig = FALSE, GroupId = SfxGroupId::View; ] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/karasa_jaga
icon-themes/karasa_jaga/cmd/32/saveas.png |binary icon-themes/karasa_jaga/cmd/32/saveasremote.png |binary icon-themes/karasa_jaga/cmd/32/saveastemplate.png |binary icon-themes/karasa_jaga/cmd/lc_saveas.png |binary icon-themes/karasa_jaga/cmd/lc_saveasremote.png |binary icon-themes/karasa_jaga/cmd/lc_saveastemplate.png |binary icon-themes/karasa_jaga/cmd/sc_saveas.png |binary icon-themes/karasa_jaga/cmd/sc_saveasremote.png |binary icon-themes/karasa_jaga/cmd/sc_saveastemplate.png |binary 9 files changed New commits: commit fe9f10a96fe25dd151b1040de14719a0b8e8e7a7 Author: Rizal Muttaqin AuthorDate: Sun Aug 12 13:20:11 2018 +0700 Commit: Adolfo Jayme Barrientos CommitDate: Mon Aug 13 00:29:41 2018 +0200 KJ:^save as * icons Change-Id: Ia87b3244e95e7515d1846a171c10e39ed0b644ed Reviewed-on: https://gerrit.libreoffice.org/58892 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/icon-themes/karasa_jaga/cmd/32/saveas.png b/icon-themes/karasa_jaga/cmd/32/saveas.png index 59ecc9ff3cbe..26cef9dfba6b 100644 Binary files a/icon-themes/karasa_jaga/cmd/32/saveas.png and b/icon-themes/karasa_jaga/cmd/32/saveas.png differ diff --git a/icon-themes/karasa_jaga/cmd/32/saveasremote.png b/icon-themes/karasa_jaga/cmd/32/saveasremote.png index 2387c5355dbb..b99acc4b8cbd 100644 Binary files a/icon-themes/karasa_jaga/cmd/32/saveasremote.png and b/icon-themes/karasa_jaga/cmd/32/saveasremote.png differ diff --git a/icon-themes/karasa_jaga/cmd/32/saveastemplate.png b/icon-themes/karasa_jaga/cmd/32/saveastemplate.png index 70f2d733b741..db8a9ae3e5bd 100644 Binary files a/icon-themes/karasa_jaga/cmd/32/saveastemplate.png and b/icon-themes/karasa_jaga/cmd/32/saveastemplate.png differ diff --git a/icon-themes/karasa_jaga/cmd/lc_saveas.png b/icon-themes/karasa_jaga/cmd/lc_saveas.png index 1365e83885f5..2c508ffb9362 100644 Binary files a/icon-themes/karasa_jaga/cmd/lc_saveas.png and b/icon-themes/karasa_jaga/cmd/lc_saveas.png differ diff --git a/icon-themes/karasa_jaga/cmd/lc_saveasremote.png b/icon-themes/karasa_jaga/cmd/lc_saveasremote.png index 376b5a13847e..65d54b41d83a 100644 Binary files a/icon-themes/karasa_jaga/cmd/lc_saveasremote.png and b/icon-themes/karasa_jaga/cmd/lc_saveasremote.png differ diff --git a/icon-themes/karasa_jaga/cmd/lc_saveastemplate.png b/icon-themes/karasa_jaga/cmd/lc_saveastemplate.png index d53d5c0ab092..57c650beb882 100644 Binary files a/icon-themes/karasa_jaga/cmd/lc_saveastemplate.png and b/icon-themes/karasa_jaga/cmd/lc_saveastemplate.png differ diff --git a/icon-themes/karasa_jaga/cmd/sc_saveas.png b/icon-themes/karasa_jaga/cmd/sc_saveas.png index 0ed8c91d8469..9ef57a94a614 100644 Binary files a/icon-themes/karasa_jaga/cmd/sc_saveas.png and b/icon-themes/karasa_jaga/cmd/sc_saveas.png differ diff --git a/icon-themes/karasa_jaga/cmd/sc_saveasremote.png b/icon-themes/karasa_jaga/cmd/sc_saveasremote.png index 3c3eb6ff3f05..a63a00defbb8 100644 Binary files a/icon-themes/karasa_jaga/cmd/sc_saveasremote.png and b/icon-themes/karasa_jaga/cmd/sc_saveasremote.png differ diff --git a/icon-themes/karasa_jaga/cmd/sc_saveastemplate.png b/icon-themes/karasa_jaga/cmd/sc_saveastemplate.png index ffe11e98b7bf..235b759bc1f3 100644 Binary files a/icon-themes/karasa_jaga/cmd/sc_saveastemplate.png and b/icon-themes/karasa_jaga/cmd/sc_saveastemplate.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 97161] Draw: Size of "dimension line"-ojects in small sizes are buggy
https://bugs.documentfoundation.org/show_bug.cgi?id=97161 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- I think, that it is the same problem as in bug 98916. The Position dialog does not show the length of the dimension line, but it only handles the size and position of the bounding box of the shape. A tool to change the length of the dimension line by entering a value is missing. The problem is still present in LO 6.1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98916] Entering a new length for a short dimension line in the Position and size dialog does not result in the correct length
https://bugs.documentfoundation.org/show_bug.cgi?id=98916 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- The problem is, that the Position dialog does not show the length of the dimension line, but it shows the position and size of the bounding box of the shape. There exists no tool to set the length of a dimension line other than dragging its handles. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104836] Draw dimension line measurement changes from cm to mm when copying to Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=104836 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- The problem is still present in Version: 6.1.0.3 (x64) Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: de-DE (en_US); Calc: CL Cannot test 6.2 because it has no dimension value at all, see bug 118203. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85513] PDF export results in wrong checkboxes (checkmark changes design)
https://bugs.documentfoundation.org/show_bug.cgi?id=85513 --- Comment #4 from himajin100...@gmail.com --- 1. Open the attached odt document 2. Remove "Checkbox active" and "Checkbox inactive" strings. 3. From Main menu, Follow Forms->Design Mode 4. Right-click first checkbox and choose "Control" context menu 5. In the "General" Tab, you will see Label property set to Makierfeld 6. close the dialog. 7. Right-click second checkbox and choose "Control" context menu 8. In the "General" Tab, you will see Label property set to "Makierfeld 2" 9. close the dialog. 10. Export this file As PDF with "Create PDF Form" Option turned off 11. See what is written next to the checkboxes in the resulting PDF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119235] New: UI: Interactive gradient tool is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=119235 Bug ID: 119235 Summary: UI: Interactive gradient tool is broken Product: LibreOffice Version: 6.0.0.0.alpha1+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de If you don't know the interactive gradient tool, you should use version 5.4 to learn how it should work: Use View > toolbars > Color Bar. Draw a shape and set its filling to a linear gradient. Select that shape. Select tool "Gradient" from the sub-toolbar "Effects". You should now see a line with a little arrow and two colored square end points on the shape. You can drag the square to change the direction of the gradient. Now click on a color in the Color Bar and hold down the mouse. Drag to the square at the line in the shape. The gradient color changes to the dragged color. Now do the same in version 6.1. Notice, that it doesn't work, but you get total wrong colors or black. [In version 6.1 the sub-toolbar is named "Transformations".] Broken in Version: 6.0.0.0.alpha1+ (x64) Build ID: a5af0fd9f27af42cf2e8571f659cdad6e606215b CPU threads: 8; OS: Windows 10.0; UI render: default; TinderBox: Win-x86_64@42, Branch:master, Time: 2017-11-07_00:30:02 Locale: de-DE (en_US); Calc: CL OK in Version: 5.4.7.2 (x64) Build ID: c838ef25c16710f8838b1faec480ebba495259d0 CPU threads: 8; OS: Windows 6.19; UI render: default; Locale: en-US (en_US); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119222] FILEOPEN The handles of the Square transformation have wrong values after import
https://bugs.documentfoundation.org/show_bug.cgi?id=119222 Jacques Guilleron changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||jal...@laposte.net --- Comment #1 from Jacques Guilleron --- Hi Regina, Reproduced with LO 6.2.0.0.alpha0+ Build ID: 7e65a0794b7c57210779bb9a6d1f2b2e49eb86e9 CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-07-30_23:37:44 Locale: fr-FR (fr_FR); Calc: CL and LO 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale : fr_FR under Windows 7. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/40d308335db85bc99d20305b2bded216a38ef532/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 115944] Render differences of DOCX between Word and LibreOffice with Palatino and Tekton fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=115944 --- Comment #25 from Jens Troeger --- Actually, how do I close as “unresolved” or “won’t fix” ;-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: mysqlc/source
mysqlc/source/mysqlc_prepared_resultset.cxx |3 +++
mysqlc/source/mysqlc_preparedstatement.cxx | 21 +++--
2 files changed, 14 insertions(+), 10 deletions(-)
New commits:
commit aa6859f09068fa0380d0a23db4823f6ca1923037
Author: Tamas Bunth
AuthorDate: Wed Aug 8 17:08:22 2018 +0200
Commit: Tamás Bunth
CommitDate: Sun Aug 12 23:16:59 2018 +0200
mysqlc: Fix float, double and numeric types
Change-Id: I9d0b989735e736c9c35d8acf4ea1b072eddf7437
Reviewed-on: https://gerrit.libreoffice.org/58744
Tested-by: Jenkins
Reviewed-by: Tamás Bunth
diff --git a/mysqlc/source/mysqlc_prepared_resultset.cxx
b/mysqlc/source/mysqlc_prepared_resultset.cxx
index 3bc6b9424752..6ef50bea7116 100644
--- a/mysqlc/source/mysqlc_prepared_resultset.cxx
+++ b/mysqlc/source/mysqlc_prepared_resultset.cxx
@@ -239,6 +239,9 @@ double SAL_CALL OPreparedResultSet::getDouble(sal_Int32
column)
}
m_bWasNull = false;
+if (m_aFields[column - 1].type == MYSQL_TYPE_FLOAT)
+return *reinterpret_cast(m_aData[column - 1].buffer);
+
return *reinterpret_cast(m_aData[column - 1].buffer);
}
diff --git a/mysqlc/source/mysqlc_preparedstatement.cxx
b/mysqlc/source/mysqlc_preparedstatement.cxx
index 88b899a55814..9c6da76913e6 100644
--- a/mysqlc/source/mysqlc_preparedstatement.cxx
+++ b/mysqlc/source/mysqlc_preparedstatement.cxx
@@ -439,23 +439,24 @@ void SAL_CALL
OPreparedStatement::setObjectWithInfo(sal_Int32 parameterIndex, co
case DataType::DECIMAL:
case DataType::NUMERIC:
{
-double nValue(0);
+double nValue(0.0);
+rtl::OUString sValue;
if ( value >>= nValue )
{
setDouble( parameterIndex, nValue );
break;
}
-else
+else if ( value >>= sValue )
{
-rtl::OUString sValue;
-if( value >>= sValue )
-{
-m_binds[nIndex].buffer_type = MYSQL_TYPE_NEWDECIMAL;
-mysqlc_sdbc_driver::resetSqlVar(_binds[nIndex].buffer,
sValue.getStr(), MYSQL_TYPE_LONGLONG, sValue.getLength());
-m_bindMetas[nIndex].is_null = 0;
-}
-
+rtl::OString sAscii = rtl::OUStringToOString(sValue,
getOwnConnection()->getConnectionEncoding());
+std::stringstream sStream{sAscii.getStr()};
+sStream >> nValue;
+m_binds[nIndex].buffer_type = MYSQL_TYPE_DOUBLE;
+mysqlc_sdbc_driver::resetSqlVar(_binds[nIndex].buffer, ,
MYSQL_TYPE_DOUBLE, sValue.getLength());
+m_bindMetas[nIndex].is_null = 0;
+break;
}
+
#if defined __GNUC__ && __GNUC__ >= 7
[[fallthrough]];
#else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: mysqlc/Library_mysqlc.mk mysqlc/source
mysqlc/Library_mysqlc.mk|3
mysqlc/source/mysqlc_connection.cxx | 140 +--
mysqlc/source/mysqlc_connection.hxx | 19
mysqlc/source/mysqlc_databasemetadata.cxx | 1127 ++--
mysqlc/source/mysqlc_databasemetadata.hxx |4
mysqlc/source/mysqlc_driver.cxx |2
mysqlc/source/mysqlc_general.cxx| 266 +-
mysqlc/source/mysqlc_general.hxx| 65 +
mysqlc/source/mysqlc_prepared_resultset.cxx | 1097 +++
mysqlc/source/mysqlc_prepared_resultset.hxx | 248 ++
mysqlc/source/mysqlc_preparedstatement.cxx | 510
mysqlc/source/mysqlc_preparedstatement.hxx | 24
mysqlc/source/mysqlc_resultset.cxx | 497 ++--
mysqlc/source/mysqlc_resultset.hxx | 20
mysqlc/source/mysqlc_resultsetmetadata.cxx | 247 +-
mysqlc/source/mysqlc_resultsetmetadata.hxx | 17
mysqlc/source/mysqlc_statement.cxx | 103 +-
mysqlc/source/mysqlc_statement.hxx | 12
18 files changed, 2724 insertions(+), 1677 deletions(-)
New commits:
commit 3478d7453a3d65b3d8d164e8f898a0b79f005c58
Author: Tamas Bunth
AuthorDate: Sun Jun 17 18:09:43 2018 +0200
Commit: Tamás Bunth
CommitDate: Sun Aug 12 23:15:21 2018 +0200
Switch from mysql to MariaDB C API
In order to get rid of the MySQL C++ Connector, the sdbc driver should
be implemented using the MariaDB C connector instead. MariaDB
Connector/C is LGPL licensed, so later it can be used in the
connectivity module. This way mysqlc won't be an extension, so it could
be maintained easier.
Change-Id: I99c13ccf154b33b145d34b1e06eec85946dc82a0
Reviewed-on: https://gerrit.libreoffice.org/55960
Reviewed-by: Tamás Bunth
Tested-by: Tamás Bunth
diff --git a/mysqlc/Library_mysqlc.mk b/mysqlc/Library_mysqlc.mk
index 97f2b63500a2..39c6230d2f05 100644
--- a/mysqlc/Library_mysqlc.mk
+++ b/mysqlc/Library_mysqlc.mk
@@ -12,12 +12,14 @@ $(eval $(call gb_Library_Library,mysqlc))
$(eval $(call gb_Library_use_externals,mysqlc,\
boost_headers \
mysql-connector-cpp \
+ mariadb-connector-c \
))
ifeq ($(SYSTEM_MYSQL_CONNECTOR_CPP),)
$(eval $(call gb_Library_add_libs,mysqlc,\
$(if $(filter-out WNT,$(OS)),$(if $(filter MACOSX SOLARIS,$(OS)),-lz
-lm,\
-rdynamic -lz -lcrypt -lm)) \
+ $(if $(filter LINUX,$(OS)),-lpthread -ldl,) \
))
endif
@@ -46,6 +48,7 @@ $(eval $(call gb_Library_add_exception_objects,mysqlc,\
mysqlc/source/mysqlc_services \
mysqlc/source/mysqlc_connection \
mysqlc/source/mysqlc_resultset \
+ mysqlc/source/mysqlc_prepared_resultset \
mysqlc/source/mysqlc_resultsetmetadata \
mysqlc/source/mysqlc_statement \
mysqlc/source/mysqlc_preparedstatement \
diff --git a/mysqlc/source/mysqlc_connection.cxx
b/mysqlc/source/mysqlc_connection.cxx
index c9b4c6d2e471..73581734a293 100644
--- a/mysqlc/source/mysqlc_connection.cxx
+++ b/mysqlc/source/mysqlc_connection.cxx
@@ -61,12 +61,25 @@ using ::osl::MutexGuard;
#define MYSQLC_URI_PREFIX "sdbc:mysqlc:"
-OConnection::OConnection(MysqlCDriver& _rDriver, sql::Driver * _cppDriver)
+namespace
+{
+void lcl_executeUpdate(MYSQL* pMySql, const rtl::OString& sql)
+{
+mysql_real_query(pMySql, sql.getStr(), sql.getLength());
+// TODO handle error
+}
+}
+
+OConnection::OConnection(MysqlCDriver& _rDriver)
:OMetaConnection_BASE(m_aMutex)
,m_xMetaData(nullptr)
,m_xDriver(&_rDriver)
-,cppDriver(_cppDriver)
{
+mysql_init(_mysql);
+
+// use TCP as connection
+mysql_protocol_type protocol = MYSQL_PROTOCOL_TCP;
+mysql_options(_mysql, MYSQL_OPT_PROTOCOL,
reinterpret_cast());
}
OConnection::~OConnection()
@@ -144,29 +157,22 @@ void OConnection::construct(const rtl::OUString& url,
const Sequence< PropertyVa
}
if (!bEmbedded) {
-try {
-sql::ConnectOptionsMap connProps;
-std::string host_str = rtl::OUStringToOString(aHostName,
m_settings.encoding).getStr();
-std::string user_str = rtl::OUStringToOString(aUser,
m_settings.encoding).getStr();
-std::string pass_str = rtl::OUStringToOString(aPass,
m_settings.encoding).getStr();
-std::string schema_str = rtl::OUStringToOString(aDbName,
m_settings.encoding).getStr();
-connProps["hostName"] = sql::ConnectPropertyVal(host_str);
-connProps["userName"] = sql::ConnectPropertyVal(user_str);
-connProps["password"] = sql::ConnectPropertyVal(pass_str);
-connProps["schema"] = sql::ConnectPropertyVal(schema_str);
-connProps["port"] =
sql::ConnectPropertyVal(static_cast(nPort));
-if (unixSocketPassed) {
-sql::SQLString socket_str =
rtl::OUStringToOString(sUnixSocket, m_settings.encoding).getStr();
-connProps["socket"] = socket_str;
-
[Libreoffice-bugs] [Bug 115944] Render differences of DOCX between Word and LibreOffice with Palatino and Tekton fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=115944 --- Comment #24 from Jens Troeger --- Thanks Alex. I am closing this because I think this can not be fixed considering that LO now uses harfbuzz as the text layout engine. However, I filed the following follow-up bug: https://bugs.documentfoundation.org/show_bug.cgi?id=119234 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119234] Shapes fail to render
https://bugs.documentfoundation.org/show_bug.cgi?id=119234 --- Comment #1 from Jens Troeger --- Created attachment 144129 --> https://bugs.documentfoundation.org/attachment.cgi?id=144129=edit Original Word document. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119234] New: Shapes fail to render
https://bugs.documentfoundation.org/show_bug.cgi?id=119234 Bug ID: 119234 Summary: Shapes fail to render Product: LibreOffice Version: 6.0.5.2 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jens.troe...@light-speed.de Created attachment 144128 --> https://bugs.documentfoundation.org/attachment.cgi?id=144128=edit Screenshot with explanation of the different shape rendering. See the attached screen shot and test document. Shapes in a DOCX document completely fail to render. Using Word to save as ODT works ok (minus different word breaks inside of the shapes). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112343] Consider porting to gdbus.
https://bugs.documentfoundation.org/show_bug.cgi?id=112343 --- Comment #13 from Commit Notification --- Arkadiy Illarionov committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f465685aecf508be987ae199e77667af896a5e8f Resolves: tdf#112343 remove last dbus-glib mentions It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source solenv/flatpak-manifest.in
sd/source/ui/remotecontrol/BluetoothServer.cxx |2 +-
solenv/flatpak-manifest.in | 15 ---
2 files changed, 1 insertion(+), 16 deletions(-)
New commits:
commit f465685aecf508be987ae199e77667af896a5e8f
Author: Arkadiy Illarionov
AuthorDate: Thu Aug 9 20:25:06 2018 +0300
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:33:57 2018 +0200
Resolves: tdf#112343 remove last dbus-glib mentions
Remove dbus-glib bundle from flatpak since LibreOffice
doesn't depend on dbus-glib as of commit
02addb3618f026acd72ece76fc726b9473cc5940.
Fix dbus reference in comment.
Change-Id: I1f4bc41bcd0ea091fc199f2271b27079ce3c2c74
Reviewed-on: https://gerrit.libreoffice.org/58795
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sd/source/ui/remotecontrol/BluetoothServer.cxx
b/sd/source/ui/remotecontrol/BluetoothServer.cxx
index c89acf3daf58..0a13f5847ecb 100644
--- a/sd/source/ui/remotecontrol/BluetoothServer.cxx
+++ b/sd/source/ui/remotecontrol/BluetoothServer.cxx
@@ -959,7 +959,7 @@ setupBluez5Profile1(DBusConnection* pConnection,
std::vector* pCo
aVTable.message_function = ProfileMessageFunction;
// dbus_connection_try_register_object_path could be used but only exists
for
-// dbus-glib >= 1.2 -- we really shouldn't be trying this twice in any
case.
+// dbus >= 1.2 -- we really shouldn't be trying this twice in any case.
// (dbus_connection_try_register_object_path also returns an error with
more
// information which could be useful for debugging purposes.)
bErr = !dbus_connection_register_object_path(pConnection,
"/org/libreoffice/bluez/profile1", , pCommunicators);
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index 129e325cea12..3596916c79c7 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -44,21 +44,6 @@
]
},
{
-"name": "dbus-glib",
-"cleanup": [ "*.la", "/bin", "/etc", "/include", "/libexec",
"/share/gtk-doc", "/share/man" ],
-"config-opts": [
-"--disable-static",
-"--disable-gtk-doc"
-],
-"sources": [
-{
-"type": "archive",
-"url":
"https://dbus.freedesktop.org/releases/dbus-glib/dbus-glib-0.108.tar.gz;,
-"sha256":
"9f340c7e2352e9cdf113893ca77ca9075d9f8d5e81476bf2bf361099383c602c"
-}
-]
-},
-{
"name": "gvfs",
"cleanup": [ "/libexec/*", "/share/dbus-1/services/*",
"/share/gvfs/mounts" ],
"config-opts": [ "--disable-hal", "--disable-gdu",
"--disable-gcr", "--disable-obexftp",
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-5-2+backports' - vcl/unx
vcl/unx/gtk3_kde5/kde5_filepicker.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 9a024fee3e9cac648c2f57c23fe2ef5da00a5b29
Author: Katarina Behrens
AuthorDate: Fri Aug 10 14:36:00 2018 +0200
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:30:12 2018 +0200
tdf#119133: Fix initial file and folder selection
what d7fc00e1f7ab7a44e6102a and 1af4ab72e2488515fcaede already does
for kde5
Change-Id: I924bdc5cfd6a12ff7bdbeef36d606c03307cb99b
Reviewed-on: https://gerrit.libreoffice.org/58832
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 87a4623a8dd5c9efed8335bb56145b9ea9dcce36)
Reviewed-on: https://gerrit.libreoffice.org/58906
Tested-by: Thorsten Behrens
diff --git a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
index ac8a1fec8183..16e50695b02c 100644
--- a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
@@ -91,9 +91,12 @@ void KDE5FilePicker::setMultiSelectionMode(bool multiSelect)
_dialog->setFileMode(multiSelect ? QFileDialog::ExistingFiles :
QFileDialog::ExistingFile);
}
-void KDE5FilePicker::setDefaultName(const QString& name) {
_dialog->selectUrl(QUrl(name)); }
+void KDE5FilePicker::setDefaultName(const QString& name) {
_dialog->selectFile(name); }
-void KDE5FilePicker::setDisplayDirectory(const QString& dir) {
_dialog->selectUrl(QUrl(dir)); }
+void KDE5FilePicker::setDisplayDirectory(const QString& dir)
+{
+_dialog->setDirectoryUrl(QUrl(dir));
+}
QString KDE5FilePicker::getDisplayDirectory() const { return
_dialog->directoryUrl().url(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3_kde5/kde5_filepicker.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 87a4623a8dd5c9efed8335bb56145b9ea9dcce36
Author: Katarina Behrens
AuthorDate: Fri Aug 10 14:36:00 2018 +0200
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:29:20 2018 +0200
tdf#119133: Fix initial file and folder selection
what d7fc00e1f7ab7a44e6102a and 1af4ab72e2488515fcaede already does
for kde5
Change-Id: I924bdc5cfd6a12ff7bdbeef36d606c03307cb99b
Reviewed-on: https://gerrit.libreoffice.org/58832
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
index f3b48b837836..e5bdd7e2646c 100644
--- a/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
+++ b/vcl/unx/gtk3_kde5/kde5_filepicker.cxx
@@ -91,9 +91,12 @@ void KDE5FilePicker::setMultiSelectionMode(bool multiSelect)
_dialog->setFileMode(multiSelect ? QFileDialog::ExistingFiles :
QFileDialog::ExistingFile);
}
-void KDE5FilePicker::setDefaultName(const QString& name) {
_dialog->selectUrl(QUrl(name)); }
+void KDE5FilePicker::setDefaultName(const QString& name) {
_dialog->selectFile(name); }
-void KDE5FilePicker::setDisplayDirectory(const QString& dir) {
_dialog->selectUrl(QUrl(dir)); }
+void KDE5FilePicker::setDisplayDirectory(const QString& dir)
+{
+_dialog->setDirectoryUrl(QUrl(dir));
+}
QString KDE5FilePicker::getDisplayDirectory() const { return
_dialog->directoryUrl().url(); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/qt5
vcl/qt5/Qt5Menu.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0adebdf09faa31c8f25415b6a8af415615d42e42
Author: Katarina Behrens
AuthorDate: Fri Aug 10 15:14:07 2018 +0200
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:28:31 2018 +0200
Finally remove non-native menu bar
Change-Id: I4758bc5afa9f9eaced7763b9923250f27df14259
Reviewed-on: https://gerrit.libreoffice.org/58834
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/vcl/qt5/Qt5Menu.cxx b/vcl/qt5/Qt5Menu.cxx
index 859f365aa3ea..b728f0b30160 100644
--- a/vcl/qt5/Qt5Menu.cxx
+++ b/vcl/qt5/Qt5Menu.cxx
@@ -27,7 +27,7 @@ Qt5Menu::Qt5Menu(bool bMenuBar)
Qt5Menu::~Qt5Menu() { maItems.clear(); }
-bool Qt5Menu::VisibleMenuBar() { return false; }
+bool Qt5Menu::VisibleMenuBar() { return true; }
void Qt5Menu::InsertItem(SalMenuItem* pSalMenuItem, unsigned nPos)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Frame.hxx |2
vcl/inc/qt5/Qt5Widget.hxx | 39 +-
vcl/qt5/Qt5Frame.cxx |4 -
vcl/qt5/Qt5Widget.cxx | 178 --
4 files changed, 73 insertions(+), 150 deletions(-)
New commits:
commit a7b18b63ec040a15b1008ec6ccb62e9733488a07
Author: Katarina Behrens
AuthorDate: Fri Aug 10 18:29:10 2018 +0200
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:28:09 2018 +0200
Revert templatization of Qt5Widget class
it was not a step in the right direction in 1st place. We distinguish
between main window frame (QMainWindow) and everything else (QWidget)
differently now
Change-Id: I331c9760f7616b2f199e63e5e521df74b08acc62
Reviewed-on: https://gerrit.libreoffice.org/58853
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 04ade0b38b2d..3bec15f1ecf4 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -39,7 +39,7 @@ class SvpSalGraphics;
class VCLPLUG_QT5_PUBLIC Qt5Frame : public SalFrame
{
-friend class VclQtMixinBase;
+friend class Qt5Widget;
QWidget* m_pQWidget;
Qt5MainWindow* m_pTopLevel;
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx
index 206b8b2d1d6e..19bbb9ff9e55 100644
--- a/vcl/inc/qt5/Qt5Widget.hxx
+++ b/vcl/inc/qt5/Qt5Widget.hxx
@@ -21,8 +21,43 @@
#include
-#include "Qt5Frame.hxx"
+class Qt5Frame;
+class Qt5Object;
+class QFocusEvent;
+class QKeyEvent;
+class QMouseEvent;
+class QMoveEvent;
+class QPaintEvent;
+class QResizeEvent;
+class QShowEvent;
+class QWheelEvent;
-QWidget* createQt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f);
+class Qt5Widget : public QWidget
+{
+Q_OBJECT
+
+Qt5Frame* m_pFrame;
+
+bool handleKeyEvent(QKeyEvent*, bool);
+void handleMouseButtonEvent(QMouseEvent*, bool);
+
+virtual void focusInEvent(QFocusEvent*) override;
+virtual void focusOutEvent(QFocusEvent*) override;
+virtual void keyPressEvent(QKeyEvent*) override;
+virtual void keyReleaseEvent(QKeyEvent*) override;
+virtual void mouseMoveEvent(QMouseEvent*) override;
+virtual void mousePressEvent(QMouseEvent*) override;
+virtual void mouseReleaseEvent(QMouseEvent*) override;
+virtual void moveEvent(QMoveEvent*) override;
+virtual void paintEvent(QPaintEvent*) override;
+virtual void resizeEvent(QResizeEvent*) override;
+virtual void showEvent(QShowEvent*) override;
+virtual void wheelEvent(QWheelEvent*) override;
+virtual void closeEvent(QCloseEvent*) override;
+
+public:
+Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f = Qt::WindowFlags());
+virtual ~Qt5Widget() override;
+};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index ab8d51fdb336..f609f3cbaa5b 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -101,11 +101,11 @@ Qt5Frame::Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags
nStyle, bool bUseCairo)
if (!pParent && (aWinFlags == Qt::Window))
{
m_pTopLevel = new Qt5MainWindow(*this, nullptr, aWinFlags);
-m_pQWidget = createQt5Widget(*this, aWinFlags);
+m_pQWidget = new Qt5Widget(*this, aWinFlags);
m_pTopLevel->setCentralWidget(m_pQWidget);
}
else
-m_pQWidget = createQt5Widget(*this, aWinFlags);
+m_pQWidget = new Qt5Widget(*this, aWinFlags);
if (pParent && !(pParent->m_nStyle & SalFrameStyleFlags::PLUG))
{
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx
index f4008ed8fb0a..bb79b7cd6130 100644
--- a/vcl/qt5/Qt5Widget.cxx
+++ b/vcl/qt5/Qt5Widget.cxx
@@ -38,54 +38,28 @@
#include
#include
-class VclQtMixinBase
+void Qt5Widget::paintEvent(QPaintEvent* pEvent)
{
-public:
-VclQtMixinBase(Qt5Frame* pFrame) { m_pFrame = pFrame; }
-
-void mixinFocusInEvent(QFocusEvent*);
-void mixinFocusOutEvent(QFocusEvent*);
-void mixinKeyPressEvent(QKeyEvent*);
-void mixinKeyReleaseEvent(QKeyEvent*);
-void mixinMouseMoveEvent(QMouseEvent*);
-void mixinMousePressEvent(QMouseEvent*);
-void mixinMouseReleaseEvent(QMouseEvent*);
-void mixinMoveEvent(QMoveEvent*);
-void mixinPaintEvent(QPaintEvent*, QWidget* widget);
-void mixinResizeEvent(QResizeEvent*, QSize aSize);
-void mixinShowEvent(QShowEvent*);
-void mixinWheelEvent(QWheelEvent*);
-void mixinCloseEvent(QCloseEvent*);
-
-private:
-bool mixinHandleKeyEvent(QKeyEvent*, bool);
-void mixinHandleMouseButtonEvent(QMouseEvent*, bool);
-
-Qt5Frame* m_pFrame;
-};
-
-void VclQtMixinBase::mixinPaintEvent(QPaintEvent* pEvent, QWidget* widget)
-{
-QPainter p(widget);
+QPainter p(this);
if (m_pFrame->m_bUseCairo)
{
cairo_surface_t* pSurface = m_pFrame->m_pSurface.get();
cairo_surface_flush(pSurface);
-QImage aImage(cairo_image_surface_get_data(pSurface),
widget->size().width(),
-
[Libreoffice-commits] core.git: vcl/CustomTarget_qt5_moc.mk vcl/inc vcl/Library_vclplug_qt5.mk vcl/qt5
vcl/CustomTarget_qt5_moc.mk |1
vcl/Library_vclplug_qt5.mk|1
vcl/inc/qt5/Qt5Frame.hxx | 12 -
vcl/inc/qt5/Qt5MainWindow.hxx | 41 ++
vcl/inc/qt5/Qt5Widget.hxx |2
vcl/qt5/Qt5Frame.cxx | 92 +++---
vcl/qt5/Qt5MainWindow.cxx | 36
vcl/qt5/Qt5Menu.cxx |4 -
vcl/qt5/Qt5Widget.cxx | 34 +--
9 files changed, 172 insertions(+), 51 deletions(-)
New commits:
commit 8d791a9d9657f6573ce27947c0289b36c6eba77c
Author: Katarina Behrens
AuthorDate: Thu Aug 9 17:14:14 2018 +0200
Commit: Thorsten Behrens
CommitDate: Sun Aug 12 22:25:54 2018 +0200
Set Qt5Widget to be a central widget of QMainWindow
this is meant to solve the problem of native menu bar overlapping
w/ non-native, as well as the inability to place an object or select
text dragging the mouse cursor w/ LMB pressed
Change-Id: I29f590ebf79d1ecc7e17b402125384cf13774bf3
Reviewed-on: https://gerrit.libreoffice.org/58171
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/vcl/CustomTarget_qt5_moc.mk b/vcl/CustomTarget_qt5_moc.mk
index 3962a730d388..afce4d44fd2b 100644
--- a/vcl/CustomTarget_qt5_moc.mk
+++ b/vcl/CustomTarget_qt5_moc.mk
@@ -12,6 +12,7 @@ $(eval $(call gb_CustomTarget_CustomTarget,vcl/qt5))
$(call gb_CustomTarget_get_target,vcl/qt5) : \
$(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5FilePicker.moc \
$(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5Instance.moc \
+ $(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5MainWindow.moc \
$(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5Menu.moc \
$(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5Timer.moc \
$(call gb_CustomTarget_get_workdir,vcl/qt5)/Qt5Widget.moc \
diff --git a/vcl/Library_vclplug_qt5.mk b/vcl/Library_vclplug_qt5.mk
index 1ad01555ed3a..d66a82319ed2 100644
--- a/vcl/Library_vclplug_qt5.mk
+++ b/vcl/Library_vclplug_qt5.mk
@@ -92,6 +92,7 @@ $(eval $(call gb_Library_add_exception_objects,vclplug_qt5,\
vcl/qt5/Qt5Graphics_Text \
vcl/qt5/Qt5Instance \
vcl/qt5/Qt5Instance_Print \
+vcl/qt5/Qt5MainWindow \
vcl/qt5/Qt5Menu \
vcl/qt5/Qt5Object \
vcl/qt5/Qt5Painter \
diff --git a/vcl/inc/qt5/Qt5Frame.hxx b/vcl/inc/qt5/Qt5Frame.hxx
index 310298879e52..04ade0b38b2d 100644
--- a/vcl/inc/qt5/Qt5Frame.hxx
+++ b/vcl/inc/qt5/Qt5Frame.hxx
@@ -31,7 +31,9 @@ class Qt5Graphics;
class Qt5Instance;
class Qt5Menu;
class QWidget;
+class Qt5MainWindow;
class QPaintDevice;
+class QScreen;
class QImage;
class SvpSalGraphics;
@@ -39,7 +41,8 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public SalFrame
{
friend class VclQtMixinBase;
-std::unique_ptr m_pQWidget;
+QWidget* m_pQWidget;
+Qt5MainWindow* m_pTopLevel;
const bool m_bUseCairo;
std::unique_ptr m_pQImage;
@@ -76,6 +79,10 @@ class VCLPLUG_QT5_PUBLIC Qt5Frame : public SalFrame
return bool(m_nStyle & nMask);
}
+bool isWindow();
+QWindow* windowHandle();
+QScreen* screen();
+
void TriggerPaintEvent();
void TriggerPaintEvent(QRect aRect);
@@ -83,7 +90,8 @@ public:
Qt5Frame(Qt5Frame* pParent, SalFrameStyleFlags nSalFrameStyle, bool
bUseCairo);
virtual ~Qt5Frame() override;
-QWidget* GetQWidget() const { return m_pQWidget.get(); }
+QWidget* GetQWidget() const { return m_pQWidget; }
+Qt5MainWindow* GetTopLevelWindow() const { return m_pTopLevel; }
void Damage(sal_Int32 nExtentsX, sal_Int32 nExtentsY, sal_Int32
nExtentsWidth,
sal_Int32 nExtentsHeight) const;
diff --git a/vcl/inc/qt5/Qt5MainWindow.hxx b/vcl/inc/qt5/Qt5MainWindow.hxx
new file mode 100644
index ..caac2299c4bc
--- /dev/null
+++ b/vcl/inc/qt5/Qt5MainWindow.hxx
@@ -0,0 +1,41 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+#include
+
+#include "Qt5Frame.hxx"
+
+class Qt5MainWindow : public QMainWindow
+{
+Q_OBJECT
+
+Qt5Frame* m_pFrame;
+
+virtual void closeEvent(QCloseEvent* pEvent) override;
+
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 13/2f1cb8837a2eb94204e714e62cc6337e51d6c1
13/2f1cb8837a2eb94204e714e62cc6337e51d6c1 |1 + 1 file changed, 1 insertion(+) New commits: commit c41efae78b7baf71fda3afd96c7c49723a37bada Author: Caolán McNamara AuthorDate: Sun Aug 12 21:25:26 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:25:26 2018 +0100 Notes added by 'git notes add' diff --git a/13/2f1cb8837a2eb94204e714e62cc6337e51d6c1 b/13/2f1cb8837a2eb94204e714e62cc6337e51d6c1 new file mode 100644 index ..ad8ee065e211 --- /dev/null +++ b/13/2f1cb8837a2eb94204e714e62cc6337e51d6c1 @@ -0,0 +1 @@ +prefer: 70d9c5248156302d6cd7d01e76646e252c4a1b6f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 81/d6ce7b52b73c0dcff3aeb4223d536c0c9e7874
81/d6ce7b52b73c0dcff3aeb4223d536c0c9e7874 |1 + 1 file changed, 1 insertion(+) New commits: commit 57ebc72872891cf7d73bb1a5a4494cb1b70e005c Author: Caolán McNamara AuthorDate: Sun Aug 12 21:24:43 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:24:43 2018 +0100 Notes added by 'git notes add' diff --git a/81/d6ce7b52b73c0dcff3aeb4223d536c0c9e7874 b/81/d6ce7b52b73c0dcff3aeb4223d536c0c9e7874 new file mode 100644 index ..ad8ee065e211 --- /dev/null +++ b/81/d6ce7b52b73c0dcff3aeb4223d536c0c9e7874 @@ -0,0 +1 @@ +prefer: 70d9c5248156302d6cd7d01e76646e252c4a1b6f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 79/3b66d942edd74e9e0368895575e48527e0793a
79/3b66d942edd74e9e0368895575e48527e0793a |1 + 1 file changed, 1 insertion(+) New commits: commit 01c004732f787690cc11f09439ee08ed6c08a867 Author: Caolán McNamara AuthorDate: Sun Aug 12 21:23:53 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:23:53 2018 +0100 Notes added by 'git notes add' diff --git a/79/3b66d942edd74e9e0368895575e48527e0793a b/79/3b66d942edd74e9e0368895575e48527e0793a new file mode 100644 index ..cc1a090ebb1d --- /dev/null +++ b/79/3b66d942edd74e9e0368895575e48527e0793a @@ -0,0 +1 @@ +prefer: ae850353151cd6a79f7b4a012d0a411013c841a4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 9d/1255242ea58a2f5cdd5f87f19ef84348188ed9
9d/1255242ea58a2f5cdd5f87f19ef84348188ed9 |1 + 1 file changed, 1 insertion(+) New commits: commit cde82dd6d520b4cf5e6360fd8871e641089c2df7 Author: Caolán McNamara AuthorDate: Sun Aug 12 21:21:45 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:21:45 2018 +0100 Notes added by 'git notes add' diff --git a/9d/1255242ea58a2f5cdd5f87f19ef84348188ed9 b/9d/1255242ea58a2f5cdd5f87f19ef84348188ed9 new file mode 100644 index ..17bf032cdd87 --- /dev/null +++ b/9d/1255242ea58a2f5cdd5f87f19ef84348188ed9 @@ -0,0 +1 @@ +prefer: 75ee75cd5e6b2bf98f4918bb586eac8af935e0c7 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 07/755074deaf232dfa8a6c61d0f311fe2b470591
07/755074deaf232dfa8a6c61d0f311fe2b470591 |1 + 1 file changed, 1 insertion(+) New commits: commit 77de0315c35da6a267c6391f85233ab0693b5a06 Author: Caolán McNamara AuthorDate: Sun Aug 12 21:21:04 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:21:04 2018 +0100 Notes added by 'git notes add' diff --git a/07/755074deaf232dfa8a6c61d0f311fe2b470591 b/07/755074deaf232dfa8a6c61d0f311fe2b470591 new file mode 100644 index ..8e5c182e7789 --- /dev/null +++ b/07/755074deaf232dfa8a6c61d0f311fe2b470591 @@ -0,0 +1 @@ +ignore: aoo ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 72/23961287c78f848bc3f702a3c1b6340365e098
72/23961287c78f848bc3f702a3c1b6340365e098 |1 + 1 file changed, 1 insertion(+) New commits: commit e427417e2634a84327297f5e49c61c28757d1eac Author: Caolán McNamara AuthorDate: Sun Aug 12 21:20:48 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 21:20:48 2018 +0100 Notes added by 'git notes add' diff --git a/72/23961287c78f848bc3f702a3c1b6340365e098 b/72/23961287c78f848bc3f702a3c1b6340365e098 new file mode 100644 index ..6db07576b960 --- /dev/null +++ b/72/23961287c78f848bc3f702a3c1b6340365e098 @@ -0,0 +1 @@ +prefer: 20452aa248c8d32289736e0a3aef6a3caafc3ce5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/oss-fuzz-build.sh
bin/oss-fuzz-build.sh |2 ++ 1 file changed, 2 insertions(+) New commits: commit 20444972edb1dd49af13902a850a8e343d5a60ec Author: Caolán McNamara AuthorDate: Sun Aug 12 21:12:48 2018 +0100 Commit: Caolán McNamara CommitDate: Sun Aug 12 22:15:22 2018 +0200 add make clean to oss-fuzz build Change-Id: Ic591748eedbe82b1c7305ef68156370f1b97f216 Reviewed-on: https://gerrit.libreoffice.org/58904 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/bin/oss-fuzz-build.sh b/bin/oss-fuzz-build.sh index e93105d4f669..5cc1325c6980 100755 --- a/bin/oss-fuzz-build.sh +++ b/bin/oss-fuzz-build.sh @@ -47,3 +47,5 @@ cp $SRC/*_seed_corpus.zip $OUT cp $SRC/*.dict $OUT #options files cp $SRC/libreoffice/vcl/workben/*.options $OUT + +make clean ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119233] Trackpad click handling very slow on MacOS, leads to randomly moving objects in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=119233 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #1 from Telesto --- Maybe bug 105500 (sidebar enabled). There are also some speed improvements for MacOS in LibreOffice 6.1 (and maybe also in 6.0). So updating seems a good idea. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119142] FILEOPEN DOCX: MS text boxes imported as frames when solo, and as LO text boxes when grouped
https://bugs.documentfoundation.org/show_bug.cgi?id=119142 --- Comment #2 from Costas --- Just to clarify that opening doxc files with grouped text boxes does NOT break LO, it just doesn't work as expected. I guess I was a bit frustrated when I wrote the report :) The same behaviour exists in Version: 6.0.3.2 Build ID: 1:6.0.3-0ubuntu1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119233] New: Trackpad click handling very slow on MacOS, leads to randomly moving objects in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=119233 Bug ID: 119233 Summary: Trackpad click handling very slow on MacOS, leads to randomly moving objects in Draw Product: LibreOffice Version: 5.2.6.2 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ken.shirr...@gmail.com Description: When I click on an object to select it and then move the cursor after releasing, Draw often acts as if I was still holding the object, moving it unexpectedly. I need to wait a while after selecting an object before I can move the cursor to give LibreOffice time to deal with the click. Steps to Reproduce: 1. Using the trackpad, click and release on an object to select it 2. Move cursor using trackpad, immediately after the previous step Actual Results: The object is selected and dragged. I then need to move the object back to where it was, which is annoying. This is also laggy, happening about 1/3 second after I move the cursor. Expected Results: The object is selected, then the cursor moves without moving the object. This is the behavior I get if I do things slooowly. Reproducible: Sometimes User Profile Reset: Yes Additional Info: If I wait a long time (> .5 second) between the release and the cursor move, it works correctly. But with normal trackpad usage I usually get the bad behavior. I have a clear gap between the release and the move when I see the problem; I'm definitely not starting the move before I unclick. I want to emphasize that I'm not doing crazy speed demon moves with the trackpad, just using it at a normal pace as with any other program. It seems like LibreOffice is slow in processing mouse events. I suspect that it is processing the drag event before the unclick event even though the drag happens afterwards. This happens with OpenGL disabled or enabled. Version: 5.2.6.2 Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc CPU Threads: 4; OS Version: Mac OS X 10.13.6; UI Render: GL; Locale: en-US (en_US.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106617] Writer memory leak
https://bugs.documentfoundation.org/show_bug.cgi?id=106617 Telesto changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Telesto --- @Dusk Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/scmatrix.hxx |4 ++--
sc/source/core/tool/interpr3.cxx |4 ++--
sc/source/core/tool/scmatrix.cxx | 18 +++---
3 files changed, 11 insertions(+), 15 deletions(-)
New commits:
commit bb6f2b12e8f0bbc99a5ca93141d35fd40b043e55
Author: Noel Grandin
AuthorDate: Sat Aug 11 13:25:09 2018 +0200
Commit: Noel Grandin
CommitDate: Sun Aug 12 21:05:09 2018 +0200
loplugin:constantparam
Change-Id: I676a8408e97cc8134009f764736cad68513c89ad
Reviewed-on: https://gerrit.libreoffice.org/58875
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index b681fc2d0c23..c7e50fe408ab 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -396,7 +396,7 @@ public:
virtual void DivOp(bool bFlag, double fVal, ScMatrix& rMat) = 0;
virtual void PowOp(bool bFlag, double fVal, ScMatrix& rMat) = 0;
-virtual std::vector Collect(bool bTextAsZero,
const std::vector>& aOp) = 0;
+virtual std::vector Collect(const
std::vector>& aOp) = 0;
virtual void ExecuteOperation(const std::pair& rStartPos,
const std::pair& rEndPos,
DoubleOpFunction aDoubleFunc, BoolOpFunction aBoolFunc,
StringOpFunction aStringFunc,
@@ -614,7 +614,7 @@ public:
virtual void DivOp(bool bFlag, double fVal, ScMatrix& rMat) override;
virtual void PowOp(bool bFlag, double fVal, ScMatrix& rMat) override;
-virtual std::vector Collect(bool bTextAsZero,
const std::vector>& aOp) override;
+virtual std::vector Collect(const
std::vector>& aOp) override;
virtual void ExecuteOperation(const std::pair& rStartPos,
const std::pair& rEndPos,
DoubleOpFunction aDoubleFunc, BoolOpFunction aBoolFunc,
StringOpFunction aStringFunc,
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index 689ea4e4de59..7c46264f83e0 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -2744,12 +2744,12 @@ void ScInterpreter::ScFTest()
aOp.emplace_back(new sc::op::Op(0.0, [](double& rAccum, double
fVal){rAccum += fVal;}));
aOp.emplace_back(new sc::op::Op(0.0, [](double& rAccum, double
fVal){rAccum += fVal * fVal;}));
-auto aVal1 = pMat1->Collect(false, aOp);
+auto aVal1 = pMat1->Collect(aOp);
fSum1 = aVal1[0].mfFirst + aVal1[0].mfRest;
fSumSqr1 = aVal1[1].mfFirst + aVal1[1].mfRest;
fCount1 = aVal1[2].mnCount;
-auto aVal2 = pMat2->Collect(false, aOp);
+auto aVal2 = pMat2->Collect(aOp);
fSum2 = aVal2[0].mfFirst + aVal2[0].mfRest;
fSumSqr2 = aVal2[1].mfFirst + aVal2[1].mfRest;
fCount2 = aVal2[2].mnCount;
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index b84e1fa19282..679eb35a4c10 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -324,7 +324,7 @@ public:
const ScFullMatrix::EmptyOpFunction& aEmptyFunc) const;
template
-std::vector ApplyCollectOperation(bool
bTextAsZero, const std::vector>& aOp);
+std::vector ApplyCollectOperation(const
std::vector>& aOp);
void MatConcat(SCSIZE nMaxCol, SCSIZE nMaxRow, const ScMatrixRef& xMat1,
const ScMatrixRef& xMat2,
SvNumberFormatter& rFormatter, svl::SharedStringPool& rPool);
@@ -1178,10 +1178,9 @@ class WalkElementBlocksMultipleValues
const std::vector>& maOp;
std::vector maRes;
bool mbFirst:1;
-bool mbTextAsZero:1;
public:
-WalkElementBlocksMultipleValues(bool bTextAsZero, const
std::vector>& aOp) :
-maOp(aOp), mbFirst(true), mbTextAsZero(bTextAsZero)
+WalkElementBlocksMultipleValues(const std::vector>&
aOp) :
+maOp(aOp), mbFirst(true)
{
for (const auto& rpOp : maOp)
{
@@ -1251,9 +1250,6 @@ public:
}
break;
case mdds::mtm::element_string:
-if (mbTextAsZero)
-maRes.back().mnCount += node.size;
-break;
case mdds::mtm::element_empty:
default:
;
@@ -2402,9 +2398,9 @@ void ScMatrixImpl::ApplyOperation(T aOp, ScMatrixImpl&
rMat)
}
template
-std::vector ScMatrixImpl::ApplyCollectOperation(bool
bTextAsZero, const std::vector>& aOp)
+std::vector ScMatrixImpl::ApplyCollectOperation(const
std::vector>& aOp)
{
-WalkElementBlocksMultipleValues aFunc(bTextAsZero, aOp);
+WalkElementBlocksMultipleValues aFunc(aOp);
maMat.walk(aFunc);
return aFunc.getResult();
}
@@ -3453,9 +3449,9 @@ void ScFullMatrix::ExecuteOperation(const
std::pair& rStartPos,
pImpl->ExecuteOperation(rStartPos, rEndPos, aDoubleFunc, aBoolFunc,
aStringFunc, aEmptyFunc);
}
-std::vector ScFullMatrix::Collect(bool bTextAsZero,
const std::vector>& aOp)
+std::vector ScFullMatrix::Collect(const
std::vector>& aOp)
{
-return pImpl->ApplyCollectOperation(bTextAsZero, aOp);
+return pImpl->ApplyCollectOperation(aOp);
}
[Libreoffice-bugs] [Bug 119232] FILEOPEN: Left page header and right page header are reversed when opening Word document
https://bugs.documentfoundation.org/show_bug.cgi?id=119232 --- Comment #1 from Tom Williams --- I forgot to mention this behavior occurs in Writer 4.4.6.3 on Ubuntu Linux, Writer 5.1.6.2 on Linux Mint, and Writer 6.0.6.2 on Windows 7 and Windows 10. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119232] New: FILEOPEN: Left page header and right page header are reversed when opening Word document
https://bugs.documentfoundation.org/show_bug.cgi?id=119232 Bug ID: 119232 Summary: FILEOPEN: Left page header and right page header are reversed when opening Word document Product: LibreOffice Version: 6.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tomd...@comcast.net Created attachment 144127 --> https://bugs.documentfoundation.org/attachment.cgi?id=144127=edit MS Word document which demonstrates the page header issue When opening a 2-page Word document with a right page header, the right page header and left page header are reversed. So, the right page header appears on the left page and the left page header appears on the right page. The right page header contains a page number where the left page header is blank. As a result, the first page of the document shows the page number where the second page does not show a page number. This doesn't happen when viewing the document in MS Word. In MS Word, the page number appears in the header of the second page, which I believe to be the right-side page. The document is a resume so the page number should appear only on the right-side page. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Error on First Run in Windows: Solar Mutex not owned
Hi, with a recent build (win10 x64 Version: 6.2.0.0.alpha0+ (x64) Build ID: d19482e191b8839f3b552e3b6e5e91ead70d565f) i get several errors at first start (if the user profile is *empty*) i noticed: the folder " 'instdir/user/extensions" seems to cause the problem. lo will start without errors if the folder exists. Regards Oliver --- Microsoft Visual C++ Runtime Library --- Assertion failed! Program: D:\sources\libo-core\instdir\program\vcllo.dll File: D:/sources/libo-core/vcl/win/app/salinst.cxx Line: 647 Expression: pTimer != nullptr For information on how your program can cause an assertion failure, see the Visual C++ documentation on asserts (Press Retry to debug the application - JIT must be enabled) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 119122] Area tab: Pattern editor has incorrect behaviour switching the pattern
https://bugs.documentfoundation.org/show_bug.cgi?id=119122 --- Comment #3 from Jim Raykowski --- Here is a patch for consideration: https://gerrit.libreoffice.org/#/c/58903/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/sdi
sfx2/sdi/sfx.sdi |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit d42d937e6edb85bb8c2795cd54dc237e0da49bd6 Author: Maxim Monastirsky AuthorDate: Sun Aug 12 15:40:50 2018 +0300 Commit: Maxim Monastirsky CommitDate: Sun Aug 12 20:21:14 2018 +0200 Don't show ShowImeStatusWindow in the customization dialog Change-Id: I5aeac6cf6ec9fae56c0dba3c176e0d6c52a28a5e Reviewed-on: https://gerrit.libreoffice.org/58899 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky diff --git a/sfx2/sdi/sfx.sdi b/sfx2/sdi/sfx.sdi index 927957e3684f..235544588174 100644 --- a/sfx2/sdi/sfx.sdi +++ b/sfx2/sdi/sfx.sdi @@ -4844,9 +4844,9 @@ SfxBoolItem ShowImeStatusWindow SID_SHOW_IME_STATUS_WINDOW RecordPerSet; -AccelConfig = TRUE, -MenuConfig = TRUE, -ToolBoxConfig = TRUE, +AccelConfig = FALSE, +MenuConfig = FALSE, +ToolBoxConfig = FALSE, GroupId = SfxGroupId::View; ] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119230] Chart help page opens empty in Konqueror
https://bugs.documentfoundation.org/show_bug.cgi?id=119230 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Summary|Math: Chart help opens |Chart help page opens empty |empty page in Konqueror |in Konqueror -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119205] FORMATTING: styled page number
https://bugs.documentfoundation.org/show_bug.cgi?id=119205 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- Eugine, can you attach your DOCX file with several pages? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119204] Some doc files can not be opened, writer freezes, soffice.bin freezes
https://bugs.documentfoundation.org/show_bug.cgi?id=119204 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru, ||todven...@suomi24.fi, ||xiscofa...@libreoffice.org --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- >using soffice.bin converter to pdf via command line is blocker, since no other >jobs can be executed while process is freezed. It's the expected behavior, -> NOTABUG or write description more clear -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119020] Colibre Icons corrupted on high DPI displays
https://bugs.documentfoundation.org/show_bug.cgi?id=119020 --- Comment #4 from Olivier B --- I also confirm this issue exists on my MSI GS60 with a 3840x2160 screen and 200% scaling under Windows 10 x64. Intel driver is 20.20.100.6194, which is the latest AFAIK. I cannot find the correct configuration to start LibreOffice on the discrete GPU Nvidia, not working from the Control Panel. So I'm not sure if this is GPU related. I switched to Breeze icon theme and looks OK but icons are pixelated. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118476] Korean Hanja to Hangul Conversion can't show multiple Korean Hangul Characters
https://bugs.documentfoundation.org/show_bug.cgi?id=118476 --- Comment #8 from Hiunn-hué --- Not a korean user, but I just tried to reproduce this. ● Summary: A Chinese character can have multiple pronounciations. But this converting tool does not list all possible pronounciations of each chinese character. ● Steps: 1. Open the Writer and input/paste this Chinese character: 樂 2. This step is nessecery, otherwise the converter won't run: Set the text language to Korean. 3. Press Tools > Language > Hangul/Hanja Conversion. 4. A dialog window pops up ● Expected Result: The chinese charachter "樂" has 4 pronounciations in the Korean language: 낙(Nak) 락(Lak) 악(Ak) 요(Yo). Therefore all 4 pronounciations shoud be listed. ● Actual Result: Only one pronounciation is listed: 악(Ak) or 요(Yo). ● Environment: Version: 6.0.6.2 Build ID: 1:6.0.6-0ubuntu0.16.04.1 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; Locale: zh-TW (zh_TW.UTF-8); Calc: group and Version: 6.2.0.0.alpha0+ Build ID: c0fdcece6b886912618deee9656cb2d169a9b999 CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-08-11_23:12:56 Locale: zh-TW (zh_TW.UTF-8); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source wizards/source
cui/source/tabpages/numpages.cxx |2 +- wizards/source/access2base/Methods.xba |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 7c93e4d72f74b57b335617717e6e4788022d5369 Author: Andrea Gelmini AuthorDate: Sun Aug 12 16:14:04 2018 +0200 Commit: Julien Nabet CommitDate: Sun Aug 12 18:09:33 2018 +0200 Fix typos Change-Id: I673b9121968ff79e6313e4019bc02a3364b4737f Reviewed-on: https://gerrit.libreoffice.org/58901 Reviewed-by: Jean-Pierre Ledure Tested-by: Jean-Pierre Ledure Tested-by: Jenkins diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx index abb258b84ef0..439086981462 100644 --- a/cui/source/tabpages/numpages.cxx +++ b/cui/source/tabpages/numpages.cxx @@ -2246,7 +2246,7 @@ static long lcl_DrawBullet(VirtualDevice* pVDev, aTmpSize.setWidth( aTmpSize.Width() / 100 ) ; aTmpSize.setHeight( aTmpSize.Height() * ( rFmt.GetBulletRelSize()) ); aTmpSize.setHeight( aTmpSize.Height() / 100 ) ; -// in case of a height of zero it is drawed in original height +// in case of a height of zero it is drawn in original height if(!aTmpSize.Height()) aTmpSize.setHeight( 1 ); aFont.SetFontSize(aTmpSize); diff --git a/wizards/source/access2base/Methods.xba b/wizards/source/access2base/Methods.xba index d48703169dfb..2d5906c7c5bb 100644 --- a/wizards/source/access2base/Methods.xba +++ b/wizards/source/access2base/Methods.xba @@ -216,7 +216,7 @@ Dim vOptionButtons() As Variant, sGroupName As String Dim lXY() As Long, iIndex() As Integer Two indexes X-Y coordinates Dim oView As Object, oDatabaseForm As Object, vControls As Variant -Const cstPixels = 10 Tolerance on coordinates when drawed approximately +Const cstPixels = 10 Tolerance on coordinates when drawn approximately bFound = False Select Case psParentType @@ -296,4 +296,4 @@ Error_Function: GoTo Exit_Function End Function _OptionGroupV1.1.0 - \ No newline at end of file + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119231] New: Help button in "Sign Signature Line" dialogue
https://bugs.documentfoundation.org/show_bug.cgi?id=119231 Bug ID: 119231 Summary: Help button in "Sign Signature Line" dialogue Product: LibreOffice Version: 6.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thack...@nexgo.de Hello @ll, while translating LO to German, I discovered the following: 1. install LO in parallel, following the instructions from https://wiki.documentfoundation.org/Installing_in_parallel/Linux 2. Start LO 3. Insert a signature line (either with your data or some nonsense data) 4. Rightclick on your newly inserted signature line and choose "Sign Signature Line..." 5. Press the help button in the "Sign Signature Line" dialogue Nothing happens ... :( The help button stays blue (as it was marked for something), but no help window nor any error message occur ... :( OS: Debian Testing AMD64 LO: Version: 6.1.0.3 Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 4; OS: Linux 4.17; UI render: default; VCL: kde4; Locale: de-DE (de_DE.UTF-8); Calc: group threaded as well as with LO: Version: 6.2.0.0.alpha0+ Build-ID: d54861bac28c0c6dd84bca6a9c1ddeb76de184a8 CPU-Threads: 4; BS: Linux 4.17; UI-Render: Standard; VCL: kde4; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-08-10_23:02:30 Gebietsschema: de-DE (de_DE.UTF-8); Calc: threaded (both installed in parallel, following the instructions from point 1 above) Sorry for the inconvenience Thomas. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 89232] Improvements to comments look and function
https://bugs.documentfoundation.org/show_bug.cgi?id=89232 Dieter Praas changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9229 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Dieter Praas changed: What|Removed |Added Depends on||119229 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119229 [Bug 119229] Feature-request: Provide compatibility with comment replies in MS Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89232] Improvements to comments look and function
https://bugs.documentfoundation.org/show_bug.cgi?id=89232 Dieter Praas changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||9229 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119229] Feature-request: Provide compatibility with comment replies in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=119229 Dieter Praas changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||232 Blocks||106179 CC||dgp-m...@gmx.de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 Dieter Praas changed: What|Removed |Added Depends on||119228 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=119228 [Bug 119228] Feature request: mark comments as resolved -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119228] Feature request: mark comments as resolved
https://bugs.documentfoundation.org/show_bug.cgi?id=119228 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||106179 Version|3.3.0 release |Inherited From OOo Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 119228] Feature request: mark comments as resolved
https://bugs.documentfoundation.org/show_bug.cgi?id=119228 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Blocks||106179 Version|3.3.0 release |Inherited From OOo Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 119230] New: Math: Chart help opens empty page in Konqueror
https://bugs.documentfoundation.org/show_bug.cgi?id=119230 Bug ID: 119230 Summary: Math: Chart help opens empty page in Konqueror Product: LibreOffice Version: 6.1.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thack...@nexgo.de CC: olivier.hal...@documentfoundation.org Hello @ll, I hope I have chosen the right component and such. If not, feel free to change it accordingly ... ;) While translating LO to German, I found the following: 1. Install master as described on https://wiki.documentfoundation.org/Installing_in_parallel/Linux 2. Start Writer 3. Enter a chart (Insert - Chart) 4. Press On my system LO tries to open $PATHTOINSTDIR/opt/libreofficedev6.2/help/de/text/shared/main.html?System=UNIX=WRITER which in Konqueror opens an empty page, other browsers (Firefox, Conqueror, Opera) reports an 404 ... :( And alas, there is no file named main.html in that place ... :( OS: Debian Testing AMD64 LO: Version: 6.2.0.0.alpha0+ Build-ID: d54861bac28c0c6dd84bca6a9c1ddeb76de184a8 CPU-Threads: 4; BS: Linux 4.17; UI-Render: Standard; VCL: kde4; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2018-08-10_23:02:30 Gebietsschema: de-DE (de_DE.UTF-8); Calc: threaded as well as LO: Version: 6.1.0.3 Build-ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU-Threads: 4; BS: Linux 4.17; UI-Render: Standard; VCL: kde4; Gebietsschema: de-DE (de_DE.UTF-8); Calc: group threaded (both parallel installed, following the instructions from the link at point 1 with de-DE lang- as well as helppack) Sorry for the inconvenience Thomas. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119229] New: Feature-request: Provide compatibility with comment replies in MS Word
https://bugs.documentfoundation.org/show_bug.cgi?id=119229 Bug ID: 119229 Summary: Feature-request: Provide compatibility with comment replies in MS Word Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: egor.kat...@gmail.com Description: Hello! Currently, Writer treats comment replies created in MS Word (.docx format) as separate comments. Similarly, comment replies created in LibreOffice appear in both programs as separate comments topped with an italicized "Reply to ...". I personally find that MS Word's approach to comment replies is more elegant, although any way to make comment replies from MS Word compatible with LibreOffice Writer would be great. Thank you, developers! Related bug: https://bugs.documentfoundation.org/show_bug.cgi?id=89232 Steps to Reproduce: 1. Create a file in MS Word with a comment and a reply to that comment 2. Open the file in Writer. 3. Actual Results: Comments appear to be independent Expected Results: Reply comment should be marked as such. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119228] New: Feature request: mark comments as resolved
https://bugs.documentfoundation.org/show_bug.cgi?id=119228 Bug ID: 119228 Summary: Feature request: mark comments as resolved Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: egor.kat...@gmail.com Description: Hello! In writer, it would be nice to go through a document and mark comments as resolved as they have been fixed instead of deleting them. The goal of this feature is to show that they were addressed when the text is sent back to the collaborators. This feature already exists in MS Word and it would be appropriate for them to be compatible. Thank you, developers! Steps to Reproduce: 1. Create .docx in MS Word with a comment marked as resolved 2. Open file in LibreOffice Writer Actual Results: The resolved comment appears unresolved. Expected Results: The resolved comment should be greyed out and take up minimal space. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: help3xsl/help.html
help3xsl/help.html | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) New commits: commit 9e4660049b5f4c6da3c652f068186e52a360ae3b Author: Jan Holesovsky AuthorDate: Fri Aug 10 17:20:07 2018 +0200 Commit: Olivier Hallot CommitDate: Sun Aug 12 16:20:25 2018 +0200 Avoid several JS errors. Change-Id: If0b8b4f3e8c3464f4e7f812ba727a929330438f3 Reviewed-on: https://gerrit.libreoffice.org/58864 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/help3xsl/help.html b/help3xsl/help.html index acaf55b2d..42f1296f0 100644 --- a/help3xsl/help.html +++ b/help3xsl/help.html @@ -8,11 +8,25 @@ --> -
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2a18492fcd707ca087ccc0bcabd79d26d9f4aaee Author: Jan Holesovsky AuthorDate: Fri Aug 10 17:20:07 2018 +0200 Commit: Gerrit Code Review CommitDate: Sun Aug 12 16:20:25 2018 +0200 Update git submodules * Update helpcontent2 from branch 'master' - Avoid several JS errors. Change-Id: If0b8b4f3e8c3464f4e7f812ba727a929330438f3 Reviewed-on: https://gerrit.libreoffice.org/58864 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 7ab3eded419b..9e4660049b5f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7ab3eded419b6fddbdd9d7a7c1f676b3720950c0 +Subproject commit 9e4660049b5f4c6da3c652f068186e52a360ae3b ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)
Hi,
On Sun, Aug 12, 2018 at 04:58:52PM +0300, Maxim Monastirsky wrote:
> On Sun, 2018-08-12 at 14:43 +0200, Rene Engelhard wrote:
> > so vcl/source/app/IconThemeSelector.cxx
> >
> > > installedThemes)
> > > {
> > > if (!installedThemes.empty()) {
> > > return installedThemes.front().GetThemeId();
> > > }
> > > else {
> > > return FALLBACK_ICON_THEME_ID;
> > > }
> > > }
> >
> >
> > $ git grep FALLBACK_ICON_THEME_ID
> > source/app/IconThemeSelector.cxx:/*static*/ const OUStringLiteral
> > IconThemeSelector::FALLBACK_ICON_THEME_ID("tango");
> >
> > ^
> > ^
> >
>
> IconThemeSelector::ReturnFallback has a parameter const
> std::vector& installedThemes. The code which calls this
> method, passes there a reference to IconThemeScanner::mFoundIconThemes,
> which dynamically filled with the themes found in the installation
> folder. Now, it returns FALLBACK_ICON_THEME_ID (currently set to tango)
> only if installedThemes.empty(), meaning that we couldn't find any icon
> theme in the installation folder (including tango!). So normally, when
> there is at least one theme installed, this "return
> FALLBACK_ICON_THEME_ID" will never happen.
Ah, I see, didn't look that deep I have to admit. And because one other
theme is installed (tango) it took that one and it broke.
Thanks for the explanation.
(As said: libreoffice-common now Depends: libreoffice-style-colibre,
libreoffice-style-tango so it should now work in all "default" cases.
And -gnome/-kde Depends: libreoffice-style-elementary /
libreoffice-style-breeze for their iconsets)
Regards,
Rene
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)
On Sun, 2018-08-12 at 14:43 +0200, Rene Engelhard wrote:
> so vcl/source/app/IconThemeSelector.cxx
>
> > installedThemes)
> > {
> > if (!installedThemes.empty()) {
> > return installedThemes.front().GetThemeId();
> > }
> > else {
> > return FALLBACK_ICON_THEME_ID;
> > }
> > }
>
>
> $ git grep FALLBACK_ICON_THEME_ID
> source/app/IconThemeSelector.cxx:/*static*/ const OUStringLiteral
> IconThemeSelector::FALLBACK_ICON_THEME_ID("tango");
>
> ^
> ^
>
IconThemeSelector::ReturnFallback has a parameter const
std::vector& installedThemes. The code which calls this
method, passes there a reference to IconThemeScanner::mFoundIconThemes,
which dynamically filled with the themes found in the installation
folder. Now, it returns FALLBACK_ICON_THEME_ID (currently set to tango)
only if installedThemes.empty(), meaning that we couldn't find any icon
theme in the installation folder (including tango!). So normally, when
there is at least one theme installed, this "return
FALLBACK_ICON_THEME_ID" will never happen.
Maxim
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 118391] Image Control in Mail Merge Document only displays first result.
https://bugs.documentfoundation.org/show_bug.cgi?id=118391 --- Comment #11 from de...@roosoft.ltd.uk --- (In reply to Drew Jensen from comment #10) > > > > Maybe if I carry on trying to work on it I can eventually get a template to > > work but at this stage starting to look like a massively more complex > > problem and I might need to resign myself to using webforms and php and > > accessing the DB directly. > > Actually, I wouldn't mind helping you with this, and can post up an example > of what I am talking about, but at this point the conversation should leave > the bug tracker and move over ask.libreoffice.org site. > > Would that work for you? Yeah I should really. But not sure I have time to write it all down as another post now. Already behind on a PBX I need to set up. Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: help3xsl/help.html help3xsl/index2.html
help3xsl/help.html | 22 ++---
help3xsl/index2.html | 86 +--
2 files changed, 54 insertions(+), 54 deletions(-)
New commits:
commit 7ab3eded419b6fddbdd9d7a7c1f676b3720950c0
Author: Jan Holesovsky
AuthorDate: Fri Aug 10 21:08:47 2018 +0200
Commit: Olivier Hallot
CommitDate: Sun Aug 12 15:45:51 2018 +0200
Use window.location.href = ...; instead of window.open(..., '_self');
Otherwise the interim URLs end up in the history.
Change-Id: If99aa1a29126f93387d2f5a6460cc0d43b488cd9
Reviewed-on: https://gerrit.libreoffice.org/58867
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/help3xsl/help.html b/help3xsl/help.html
index 1dade67f0..acaf55b2d 100644
--- a/help3xsl/help.html
+++ b/help3xsl/help.html
@@ -14,17 +14,17 @@
var url = window.location.href;
-var n = url.indexOf('help.html?');
-if (n != -1){
-// the URL came from LibreOffice help (F1)
-var version = getParameterByName("Version",url);
-var rest = url.substr(n+12,url.length);
-var newURL = version+'/index.html?'+rest;
-window.open(newURL,'_self');
-}else{
-// URL came from elsewhere, direct access to webroot, we redirect to main
Help page
-var userLang = navigator.language || navigator.userLanguage;
-
window.open('latest/'+userLang+'/text/shared/main0108.html?&DbPAR=WRITER&System=WIN','_self');
+var n = url.indexOf('?');
+if (n != -1) {
+// the URL came from LibreOffice help (F1)
+var version = getParameterByName("Version", url);
+var query = url.substr(n + 1, url.length);
+var newURL = version + '/index.html?' + query;
+window.location.href = newURL;
+} else {
+// URL came from elsewhere, direct access to webroot, we redirect to
main Help page
+var userLang = navigator.language || navigator.userLanguage;
+window.location.href = 'latest/' + userLang +
'/text/shared/main0108.html?&DbPAR=WRITER&System=WIN';
}
diff --git a/help3xsl/index2.html b/help3xsl/index2.html
index 6ca41cc90..4f7c744e2 100644
--- a/help3xsl/index2.html
+++ b/help3xsl/index2.html
@@ -16,49 +16,49 @@
var url = window.location.href;
var n = url.indexOf('index.html?');
-if (n != -1){
-// the URL came from LibreOffice help (F1)
-var version = getParameterByName("Version",url);
-var lang = getParameterByName("Language",url);
-var system = getParameterByName("System",url);
-var rest= url.substr(n+11,url.length);
-var module;
-var defaultFile;
-var smodule = rest.substr(0, rest.indexOf('/'));
-switch (smodule) {
-case "swriter":
{defaultFile='text/swriter/main.html';module="WRITER";break;}
-case "scalc":
{defaultFile='text/scalc/main.html';module="CALC";break;}
-case "simpress":
{defaultFile='text/simpress/main.html';module="IMPRESS";break;}
-case "sdraw":
{defaultFile='text/sdraw/main.html';module="DRAW";break;}
-case "smath":
{defaultFile='text/smath/main.html';module="MATH";break;}
-case "sdatabase":
{defaultFile='text/shared/explorer/database/main.html';module="BASE";break;}
-case "sbasic":
{defaultFile='text/sbasic/shared/main0601.html';module="BASIC";break;}
-default:
{defaultFile='text/shared/main.html';module="WRITER";break;}
-}
-var bookmark = rest.slice(rest.indexOf('/')+1, rest.indexOf('?'));
-var file = map[bookmark];
-// check first if a root bookmark @@nowidget@@ can be used
-if (file === undefined){
-var b2 = bookmark.substring(0, bookmark.lastIndexOf("/")) +
'/@@nowidget@@';
-file = map[b2];
-}
-// rebuild URL
-if (file === undefined){
-var newURL = lang + '/' + defaultFile + '?System=' + system + '&DbPAR=' +
module;
-}else{
-var indx = file.indexOf('#');
-var bm = file.substr(indx,file.length);
-file = file.substr(0,indx);
-var newURL = lang + '/' + file + '?System=' + system + '&DbPAR=' + module
+ bm;
-}
-window.open(newURL,'_self');
-}else{
-// URL came from elsewhere, direct access to webroot, we redirect to main
Help page
-var userLang = navigator.language;
-if(userLang === undefined ){
-userlang="en-US";
-}
-window.open(userLang +
'/text/shared/main0108.html?&DbPAR=WRITER&System=WIN','_self');
+if (n != -1) {
+// the URL came from LibreOffice help (F1)
+var target = getParameterByName("Target",url);
+var version = getParameterByName("Version",url);
+var lang = getParameterByName("Language",url);
+var system = getParameterByName("System",url);
+var module;
+var defaultFile;
+var smodule = target.substr(0, target.indexOf('/'));
+switch (smodule) {
+case "swriter":
{defaultFile='text/swriter/main.html';module="WRITER";break;}
+case "scalc":
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ca15cd081c9f875f0735f4bad2eaef366b5d43a5 Author: Jan Holesovsky AuthorDate: Fri Aug 10 21:08:47 2018 +0200 Commit: Gerrit Code Review CommitDate: Sun Aug 12 15:45:51 2018 +0200 Update git submodules * Update helpcontent2 from branch 'master' - Use window.location.href = ...; instead of window.open(..., '_self'); Otherwise the interim URLs end up in the history. Change-Id: If99aa1a29126f93387d2f5a6460cc0d43b488cd9 Reviewed-on: https://gerrit.libreoffice.org/58867 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 5c1d1eb33951..7ab3eded419b 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 5c1d1eb33951982ffa5352980d4713489c0d98ae +Subproject commit 7ab3eded419b6fddbdd9d7a7c1f676b3720950c0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 119227] A five second freeze when copying a large bulleted list
https://bugs.documentfoundation.org/show_bug.cgi?id=119227 --- Comment #3 from Telesto --- (In reply to m.a.riosv from comment #2) > What should be the time? Reference: 3.5.7.2 & 4.0.0.3: both have a +/- 1 sec delay. It's also depending on machine specs. Could be 10 seconds on a slower machine (or less on a faster one) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)
Hi,
On Sun, Aug 12, 2018 at 12:09:42PM +0300, Maxim Monastirsky wrote:
> On Sun, 2018-08-12 at 09:52 +0200, Rene Engelhard wrote:
> > > I think you should use colibre *instead* of tango. My understanding
> > > is
> >
> > No, that looks too much Windows'ishy to me.
>
> Ah, OK. In this case it might make sense to do an upstream patch to
> copy these icons to tango, as we already did for a lot of other icons
> that were copied to tango from galaxy (see tdf#118123).
>
> > > that colibre is at least as complete as tango, and is actively
> > > maintained unlike tango. And tango isn't even part of the fallback
> >
> > That is not 100% true, see my paste.
> >
> > For the desktop detection icon detection it is.
>
> The desktop detection code you cited is about defining the *preferred*
> icon theme, not about "fallback" - which means what to do when the
> requested theme isn't found. The fallback for a complete icon theme (as
> opposed to an individual icon) is done like this:
>
> /*static*/ OUString
> IconThemeSelector::ReturnFallback(const std::vector&
$ git grep ReturnFallback
source/app/IconThemeSelector.cxx:return ReturnFallback(installedThemes);
source/app/IconThemeSelector.cxx:return ReturnFallback(installedThemes);
source/app/IconThemeSelector.cxx:IconThemeSelector::ReturnFallback(const
std::vector& installedThemes)
so vcl/source/app/IconThemeSelector.cxx
> installedThemes)
> {
> if (!installedThemes.empty()) {
> return installedThemes.front().GetThemeId();
> }
> else {
> return FALLBACK_ICON_THEME_ID;
> }
> }
$ git grep FALLBACK_ICON_THEME_ID
qa/cppunit/app/test_IconThemeSelector.cxx:
OUString(vcl::IconThemeSelector::FALLBACK_ICON_THEME_ID), selected);
source/app/IconThemeSelector.cxx:/*static*/ const OUStringLiteral
IconThemeSelector::FALLBACK_ICON_THEME_ID("tango");
^
^
source/app/IconThemeSelector.cxx:r = FALLBACK_ICON_THEME_ID;
source/app/IconThemeSelector.cxx:return FALLBACK_ICON_THEME_ID;
So what is this then? Count me confused. :)
Regards,
Rene
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 118391] Image Control in Mail Merge Document only displays first result.
https://bugs.documentfoundation.org/show_bug.cgi?id=118391 --- Comment #10 from Drew Jensen --- > > Maybe if I carry on trying to work on it I can eventually get a template to > work but at this stage starting to look like a massively more complex > problem and I might need to resign myself to using webforms and php and > accessing the DB directly. Actually, I wouldn't mind helping you with this, and can post up an example of what I am talking about, but at this point the conversation should leave the bug tracker and move over ask.libreoffice.org site. Would that work for you? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119048] Associate a character style to cross-reference fields
https://bugs.documentfoundation.org/show_bug.cgi?id=119048 Dieter Praas changed: What|Removed |Added Blocks||107905 CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107905 [Bug 107905] [META] Cross-references bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
