[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Olivier Hallot changed: What|Removed |Added Depends on||120179 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120179 [Bug 120179] [LOCALHELP] rewrite SUMIF Help page -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80430] [META] LOCALHELP: Features x Documentation gap
https://bugs.documentfoundation.org/show_bug.cgi?id=80430 Bug 80430 depends on bug 120179, which changed state. Bug 120179 Summary: [LOCALHELP] rewrite SUMIF Help page https://bugs.documentfoundation.org/show_bug.cgi?id=120179 What|Removed |Added Status|RESOLVED|NEW Resolution|NOTABUG |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120179] [LOCALHELP] rewrite SUMIF Help page
https://bugs.documentfoundation.org/show_bug.cgi?id=120179 Olivier Hallot changed: What|Removed |Added Resolution|NOTABUG |--- Summary|sumif works wrong if Range |[LOCALHELP] rewrite SUMIF |has different row index |Help page |than SumRange | Status|RESOLVED|NEW Component|Calc|Documentation Blocks||80430 Ever confirmed|0 |1 --- Comment #5 from Olivier Hallot --- The Help page of SUMIF is too amateur-ish, and even wrong. It deserves a much more precise definition, more/better examples, and corner case situations. Re-qualifying the bug as doc bug Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=80430 [Bug 80430] [META] LOCALHELP: Features x Documentation gap -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx |5 - sw/qa/extras/ooxmlexport/ooxmlexport5.cxx| 11 --- sw/source/filter/ww8/docxattributeoutput.cxx | 27 +++ 3 files changed, 7 insertions(+), 36 deletions(-) New commits: commit 5d4c6ee89ef6302db08c23bbe2d3fb4d7de3b1a3 Author: Justin Luth AuthorDate: Wed Sep 26 10:23:20 2018 +0300 Commit: Justin Luth CommitDate: Sat Sep 29 07:16:34 2018 +0200 tdf#92026 docxexport: eliminate fake tblBorders This patch depends on tdf#119760. The border was based on whatever cell A1 had, but that fake default was never passed to the cell's functions, so the table border definition served no purpose whatsoever. Cells had no idea whether they needed to override those default borders, and this was bad for non-borders, because then the default borders were assigned instead of none. The other option would be to properly fill m_aTableStyleConf, but that didn't seem valuable. Better, and less code churn, to just eliminate the function altogether. (Well, the empty function kept in place as a placeholder for someone who decides it could be useful to reduce the number of borders written out per cell.) Unit test fdo80097.docx's fix was just trying to prevent an invalid table border. Since that is still obviously true when no table border is defined, it is valid to just eliminate this part of the test. (Having a table definition wouldn't be invalid in the future, so I'm not testing for zero instances.) Change-Id: I983dbe120bfc3354fefd14bc95ac01abccea7ea8 Reviewed-on: https://gerrit.libreoffice.org/60989 Tested-by: Jenkins Reviewed-by: Justin Luth diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx index 933bd58b1071..db52d019439b 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx @@ -532,7 +532,10 @@ DECLARE_OOXMLEXPORT_TEST(testTdf82177_tblBorders, "tdf82177_tblBorders.docx") uno::Reference xTablesSupplier(mxComponent, uno::UNO_QUERY); uno::Reference xTables(xTablesSupplier->getTextTables(), uno::UNO_QUERY); uno::Reference< text::XTextTable > xTable( xTables->getByIndex(0), uno::UNO_QUERY ); -uno::Reference< table::XCell > xCell = xTable->getCellByName( "E5" ); +uno::Reference< table::XCell > xCell = xTable->getCellByName( "A5" ); +CPPUNIT_ASSERT_EQUAL(static_cast(0), getProperty(xCell, "BottomBorder").LineWidth); +CPPUNIT_ASSERT_EQUAL(static_cast(0), getProperty(xCell, "LeftBorder").LineWidth); +xCell.set(xTable->getCellByName( "E5" )); CPPUNIT_ASSERT_EQUAL(static_cast(0), getProperty(xCell, "TopBorder").LineWidth); CPPUNIT_ASSERT_EQUAL(static_cast(0), getProperty(xCell, "LeftBorder").LineWidth); } diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx index 858f20d0e3b9..401af06a6533 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx @@ -669,17 +669,6 @@ DECLARE_OOXMLEXPORT_TEST(testfdo80097, "fdo80097.docx") if (!pXmlDocument) return; -//Table Borders -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:top[@w:val = 'single']",1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:top[@w:sz = 4]", 1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:top[@w:space = 0]", 1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:top[@w:color = '00']", 1); - -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:bottom[@w:val = 'single']",1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:bottom[@w:sz = 4]", 1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:bottom[@w:space = 0]", 1); -assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tblPr/w:tblBorders/w:bottom[@w:color = '00']", 1); - //Table Cell Borders assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tr[1]/w:tc[1]/w:tcPr/w:tcBorders/w:top[@w:val = 'single']",1); assertXPath(pXmlDocument, "/w:document/w:body/w:tbl/w:tr[1]/w:tc[1]/w:tbl/w:tr[1]/w:tc[1]/w:tcPr/w:tcBorders/w:top[@w:sz = 4]", 1); diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index b3e4df7a5f1a..a39ba872cf04 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -3032,18 +3032,6 @@ static void impl_borderLine( FSHelperPtr const & pSerializer, sal_Int32
[Libreoffice-bugs] [Bug 120154] High RAM usage ( around 300mb for 10 mins and drop to 150-200 mb)
https://bugs.documentfoundation.org/show_bug.cgi?id=120154 --- Comment #7 from perie_...@hotmail.com --- (In reply to m.a.riosv from comment #6) > Calculation time it's because in sheet 'Actual' you have the whole columns > of external file to do a conditional sum. Reducing the end of range, reduce > drastically the time calculation. The point of raising this issue is the weird memory consumption of LO in a spreadsheet with quite number of linkages and formulas. My take on this is that if a LO spreadsheet will consume 300MB of memory, until the file is closed or saved, it will retain the 300MB. However in the current setup, after 10 - 15 mins of opening the file, the memory consumption went down and even if we hard recalculate all formulas, consumption is still lower compared to the first 10/15 minutes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number in column view
https://bugs.documentfoundation.org/show_bug.cgi?id=120153 --- Comment #7 from Jan-Marek Glogowski --- >From "Technical Note TN2420: Version Numbers and Build Numbers" https://developer.apple.com/library/archive/technotes/tn2420/_index.html "The value for a version number or build number must consist only of '.'s and numbers and must begin and end with a number. Each integer value separated by a period is a component of the version. Version numbers and build numbers may have up to three components separated by periods. The total number of characters in your version number or in your build number cannot exceed eighteen characters." The internet doesn't agree with this document for the CFBundleVersion, but it does for CFBundleShortVersionString, which is displayed everywhere, I guess. Now quoting the configure.ac build configuration script from the source: # The CFBundleShortVersionString in Info.plist consists of three integers, so encode the third # as the micro version times 1000 plus the patch number. Unfortunately the LIBO_VERSION_SUFFIX can be anything so # no way to encode that into an integer in general. MACOSX_BUNDLE_SHORTVERSION=$LIBO_VERSION_MAJOR.$LIBO_VERSION_MINOR.`expr $LIBO_VERSION_MICRO '*' 1000 + $LIBO_VERSION_PATCH` So '6.1.2.1' becomes '6.1.2001' for Apple. This is a limit on Apples side, so IMHO NOTOURBUG. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/templatedialog1.ui |1 - sw/uiconfig/swriter/ui/templatedialog16.ui |2 -- sw/uiconfig/swriter/ui/templatedialog2.ui |1 - sw/uiconfig/swriter/ui/templatedialog4.ui |1 - sw/uiconfig/swriter/ui/templatedialog8.ui |2 -- 5 files changed, 7 deletions(-) New commits: commit 79761d6b64d31efdac61172ec4d9bf71197e462e Author: Caolán McNamara AuthorDate: Fri Sep 28 15:46:19 2018 +0100 Commit: Caolán McNamara CommitDate: Sat Sep 29 06:27:56 2018 +0200 just *one* button to have has_default set Change-Id: I7c4253a5c1a2c838b832c430bb3d28fee6bdf27a Reviewed-on: https://gerrit.libreoffice.org/61093 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/templatedialog1.ui b/sw/uiconfig/swriter/ui/templatedialog1.ui index fa348adf1ac2..0f9062ac9b57 100644 --- a/sw/uiconfig/swriter/ui/templatedialog1.ui +++ b/sw/uiconfig/swriter/ui/templatedialog1.ui @@ -41,7 +41,6 @@ True True True -True True True diff --git a/sw/uiconfig/swriter/ui/templatedialog16.ui b/sw/uiconfig/swriter/ui/templatedialog16.ui index c615624563b3..e4592cde7c98 100644 --- a/sw/uiconfig/swriter/ui/templatedialog16.ui +++ b/sw/uiconfig/swriter/ui/templatedialog16.ui @@ -57,7 +57,6 @@ True True True -True True True @@ -73,7 +72,6 @@ True True True -True True diff --git a/sw/uiconfig/swriter/ui/templatedialog2.ui b/sw/uiconfig/swriter/ui/templatedialog2.ui index 6959e31c2e65..3ec382a6b22c 100644 --- a/sw/uiconfig/swriter/ui/templatedialog2.ui +++ b/sw/uiconfig/swriter/ui/templatedialog2.ui @@ -41,7 +41,6 @@ True True True -True True True diff --git a/sw/uiconfig/swriter/ui/templatedialog4.ui b/sw/uiconfig/swriter/ui/templatedialog4.ui index 860eaef7104e..4c0f41f44d28 100644 --- a/sw/uiconfig/swriter/ui/templatedialog4.ui +++ b/sw/uiconfig/swriter/ui/templatedialog4.ui @@ -41,7 +41,6 @@ True True True -True True True diff --git a/sw/uiconfig/swriter/ui/templatedialog8.ui b/sw/uiconfig/swriter/ui/templatedialog8.ui index 73c134f67e35..ac203ceca1dc 100644 --- a/sw/uiconfig/swriter/ui/templatedialog8.ui +++ b/sw/uiconfig/swriter/ui/templatedialog8.ui @@ -57,7 +57,6 @@ True True True -True True True @@ -73,7 +72,6 @@ True True True -True True ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/uiconfig sw/inc sw/source
cui/uiconfig/ui/formatnumberdialog.ui |8 +++-
sw/inc/swabstdlg.hxx |3 +--
sw/source/ui/chrdlg/tblnumfm.cxx | 17 -
sw/source/ui/dialog/swdlgfact.cxx |6 ++
sw/source/ui/dialog/swdlgfact.hxx |2 +-
sw/source/uibase/inc/tblnumfm.hxx |6 +++---
sw/source/uibase/shells/tabsh.cxx |2 +-
sw/source/uibase/utlui/numfmtlb.cxx |2 +-
8 files changed, 24 insertions(+), 22 deletions(-)
New commits:
commit bbeeedbbfa0b7a0d1461c5ff703721bce1b7f80a
Author: Caolán McNamara
AuthorDate: Fri Sep 28 14:54:44 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Sep 29 06:27:33 2018 +0200
weld SwNumFormatDlg
Change-Id: I8f7acf1b662d2357f810ff3c103670df2e58757f
Reviewed-on: https://gerrit.libreoffice.org/61089
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/uiconfig/ui/formatnumberdialog.ui
b/cui/uiconfig/ui/formatnumberdialog.ui
index fd01522e1800..13be59a2c0b6 100644
--- a/cui/uiconfig/ui/formatnumberdialog.ui
+++ b/cui/uiconfig/ui/formatnumberdialog.ui
@@ -1,5 +1,5 @@
-
+
@@ -7,7 +7,13 @@
6
Format Number
False
+True
+0
+0
dialog
+
+
+
False
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index e9f201a35ffb..da2486e48b71 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -359,8 +359,7 @@ class SwAbstractDialogFactory
public:
static SwAbstractDialogFactory* Create();
-virtual VclPtr CreateNumFormatDialog( vcl::Window*
pParent,
- const SfxItemSet& rAttr) = 0;
+virtual VclPtr CreateNumFormatDialog(weld::Window*
pParent, const SfxItemSet& rAttr) = 0;
virtual VclPtr CreateSwDropCapsDialog(weld::Window*
pParent, const SfxItemSet& rSet) = 0;
virtual VclPtr CreateSwBackgroundDialog(weld::Window*
pParent, const SfxItemSet& rSet) = 0;
diff --git a/sw/source/ui/chrdlg/tblnumfm.cxx b/sw/source/ui/chrdlg/tblnumfm.cxx
index ddcad7961029..46fe5c8455e4 100644
--- a/sw/source/ui/chrdlg/tblnumfm.cxx
+++ b/sw/source/ui/chrdlg/tblnumfm.cxx
@@ -27,21 +27,20 @@
#include
#include
-SwNumFormatDlg::SwNumFormatDlg(vcl::Window* pParent, const SfxItemSet& rSet)
-: SfxSingleTabDialog(pParent, rSet, "FormatNumberDialog",
-"cui/ui/formatnumberdialog.ui")
+SwNumFormatDlg::SwNumFormatDlg(weld::Window* pParent, const SfxItemSet& rSet)
+: SfxSingleTabDialogController(pParent, rSet,
"cui/ui/formatnumberdialog.ui", "FormatNumberDialog")
{
// Create TabPage
SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create();
-::CreateTabPage fnCreatePage = pFact->GetTabPageCreatorFunc(
RID_SVXPAGE_NUMBERFORMAT );
-
+::CreateTabPage fnCreatePage =
pFact->GetTabPageCreatorFunc(RID_SVXPAGE_NUMBERFORMAT);
if ( fnCreatePage )
{
-VclPtr pNewPage = (*fnCreatePage)(
TabPageParent(get_content_area()), );
+TabPageParent pPageParent(get_content_area(), this);
+VclPtr xNewPage = (*fnCreatePage)(pPageParent, );
SfxAllItemSet aSet(*(rSet.GetPool()));
-aSet.Put ( SvxNumberInfoItem( pNewPage->GetItemSet().Get(
SID_ATTR_NUMBERFORMAT_INFO ) ));
-pNewPage->PageCreated(aSet);
-SetTabPage(pNewPage);
+aSet.Put(SvxNumberInfoItem(xNewPage->GetItemSet().Get(
SID_ATTR_NUMBERFORMAT_INFO)));
+xNewPage->PageCreated(aSet);
+SetTabPage(xNewPage);
}
}
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index 2a5849a1753e..5e1c01acdacc 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -770,11 +770,9 @@ VclPtr
SwAbstractDialogFactory_Impl::CreateSwBackgroundDialog
return
VclPtr::Create(o3tl::make_unique(pParent,
rSet));
}
-VclPtr SwAbstractDialogFactory_Impl::CreateNumFormatDialog(
vcl::Window* pParent,
- const
SfxItemSet& rSet)
+VclPtr
SwAbstractDialogFactory_Impl::CreateNumFormatDialog(weld::Window* pParent,
const SfxItemSet& rSet)
{
-VclPtr pDlg = VclPtr::Create( pParent,
rSet );
-return VclPtr::Create( pDlg );
+return
VclPtr::Create(o3tl::make_unique(pParent,
rSet));
}
VclPtr
SwAbstractDialogFactory_Impl::CreateSwAsciiFilterDlg(weld::Window* pParent,
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 7cbb22347371..2ad87e1986dc 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -573,7 +573,7 @@ class SwAbstractDialogFactory_Impl : public
SwAbstractDialogFactory
public:
virtual ~SwAbstractDialogFactory_Impl() {}
-virtual VclPtr CreateNumFormatDialog(vcl::Window*
pParent, const SfxItemSet& rAttr) override;
+virtual VclPtr CreateNumFormatDialog(weld::Window*
pParent, const SfxItemSet& rAttr) override;
virtual VclPtr
[Libreoffice-commits] core.git: vcl/source
vcl/source/control/combobox.cxx | 12
vcl/source/control/listbox.cxx | 12
2 files changed, 24 insertions(+)
New commits:
commit 6f070fb228d0c6f05c48386d0f3538c89cfbc878
Author: Caolán McNamara
AuthorDate: Fri Sep 28 11:47:42 2018 +0100
Commit: Caolán McNamara
CommitDate: Sat Sep 29 06:26:53 2018 +0200
tdf#120169 handle [combo|list]box can-focus specially
Change-Id: I93fec026079ac37993e48fac48d937a0a20e5b0f
Reviewed-on: https://gerrit.libreoffice.org/61081
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 3e16f2c46ef5..f114df9deaa7 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -1530,6 +1530,18 @@ bool ComboBox::set_property(const OString , const
OUString )
SetWidthInChars(rValue.toInt32());
else if (rKey == "max-width-chars")
setMaxWidthChars(rValue.toInt32());
+else if (rKey == "can-focus")
+{
+// as far as I can see in Gtk, setting a ComboBox as can.focus means
+// the focus gets stuck in it, so try here to behave like gtk does
+// with the settings that work, i.e. can.focus of false doesn't
+// set the hard WB_NOTABSTOP
+WinBits nBits = GetStyle();
+nBits &= ~(WB_TABSTOP|WB_NOTABSTOP);
+if (toBool(rValue))
+nBits |= WB_TABSTOP;
+SetStyle(nBits);
+}
else
return Control::set_property(rKey, rValue);
return true;
diff --git a/vcl/source/control/listbox.cxx b/vcl/source/control/listbox.cxx
index de64575534e2..88a53fc350eb 100644
--- a/vcl/source/control/listbox.cxx
+++ b/vcl/source/control/listbox.cxx
@@ -1428,6 +1428,18 @@ bool ListBox::set_property(const OString , const
OUString )
SelectEntryPos(rValue.toInt32());
else if (rKey == "max-width-chars")
setMaxWidthChars(rValue.toInt32());
+else if (rKey == "can-focus")
+{
+// as far as I can see in Gtk, setting a ComboBox as can.focus means
+// the focus gets stuck in it, so try here to behave like gtk does
+// with the settings that work, i.e. can.focus of false doesn't
+// set the hard WB_NOTABSTOP
+WinBits nBits = GetStyle();
+nBits &= ~(WB_TABSTOP|WB_NOTABSTOP);
+if (toBool(rValue))
+nBits |= WB_TABSTOP;
+SetStyle(nBits);
+}
else
return Control::set_property(rKey, rValue);
return true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120169] LibreOffice dialog FileOpen opens with focus on path control and file type control doesn't take focus at all
https://bugs.documentfoundation.org/show_bug.cgi?id=120169 Commit Notification changed: What|Removed |Added Whiteboard||target:6.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120169] LibreOffice dialog FileOpen opens with focus on path control and file type control doesn't take focus at all
https://bugs.documentfoundation.org/show_bug.cgi?id=120169 --- Comment #4 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f070fb228d0c6f05c48386d0f3538c89cfbc878 tdf#120169 handle [combo|list]box can-focus specially It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112657] SfxUndoManager_Data::SfxUndoManager_Data leaks memory with multiple invocations
https://bugs.documentfoundation.org/show_bug.cgi?id=112657 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112728] FILEOPEN: DOC - Command "INCLUDEPICTURE" shown to the user
https://bugs.documentfoundation.org/show_bug.cgi?id=112728 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54768] Asking to restore image to original size gets wrong size when the image is clipped
https://bugs.documentfoundation.org/show_bug.cgi?id=54768 --- Comment #7 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102337] Data > XML Source ... does not read XML if the version number and encoding are specified with single quotes
https://bugs.documentfoundation.org/show_bug.cgi?id=102337 --- Comment #4 from QA Administrators --- ** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120152] REPORTBUILDER: Unable to add fields to report using the ADD FIELDS dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120152
Terrence Enger changed:
What|Removed |Added
CC||lo_b...@iseries-guru.com
--- Comment #2 from Terrence Enger ---
Created attachment 145261
--> https://bugs.documentfoundation.org/attachment.cgi?id=145261=edit
bibisect in linux-64-6.2 repo : tail of terminal output
Working on debian-buster in the linux-64.6.2 bibisect repository, I
trace the bug to the range:
commits-h date
---
good f224ffcd f8edef39 2018-05-25 10:10:00
bad 34b63425 726d7e7b 2018-05-25 10:59:48
I am setting keyword bibisected.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120152] REPORTBUILDER: Unable to add fields to report using the ADD FIELDS dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120152 Terrence Enger changed: What|Removed |Added Keywords||bibisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/tools
include/tools/wintypes.hxx | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
New commits:
commit ad6adb1bfadf49af3187a0bb3ceffbf355e9eed1
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 28 20:58:32 2018 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 02:35:43 2018 +0200
Add number comments to WindowType
Change-Id: Icc8bddb00a26f3844d8b264acd5535951ac64f1c
Reviewed-on: https://gerrit.libreoffice.org/61099
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/include/tools/wintypes.hxx b/include/tools/wintypes.hxx
index 9f5229806e3f..baa8119e785d 100644
--- a/include/tools/wintypes.hxx
+++ b/include/tools/wintypes.hxx
@@ -26,8 +26,8 @@
enum class WindowType : sal_uInt16
{
NONE = 0,
-FIRST= 0x0130,
-MESSBOX = FIRST,
+FIRST= 0x0130, // 304
+MESSBOX = FIRST, // 0
INFOBOX ,
WARNINGBOX ,
ERRORBOX ,
@@ -37,7 +37,7 @@ enum class WindowType : sal_uInt16
CONTAINER,
FLOATINGWINDOW ,
DIALOG ,
-MODELESSDIALOG ,
+MODELESSDIALOG , // 10 (314)
MODALDIALOG ,
CONTROL ,
PUSHBUTTON ,
@@ -47,7 +47,7 @@ enum class WindowType : sal_uInt16
IMAGEBUTTON ,
MENUBUTTON ,
MOREBUTTON ,
-SPINBUTTON ,
+SPINBUTTON , // 20 (324)
RADIOBUTTON ,
CHECKBOX ,
TRISTATEBOX ,
@@ -57,7 +57,7 @@ enum class WindowType : sal_uInt16
LISTBOX ,
MULTILISTBOX ,
FIXEDTEXT,
-FIXEDLINE,
+FIXEDLINE, // 30 (334)
FIXEDBITMAP ,
FIXEDIMAGE ,
GROUPBOX ,
@@ -67,7 +67,7 @@ enum class WindowType : sal_uInt16
SPLITWINDOW ,
SPINFIELD,
PATTERNFIELD ,
-NUMERICFIELD ,
+NUMERICFIELD , // 40 (344)
METRICFIELD ,
CURRENCYFIELD,
DATEFIELD,
@@ -77,7 +77,7 @@ enum class WindowType : sal_uInt16
METRICBOX,
CURRENCYBOX ,
DATEBOX ,
-TIMEBOX ,
+TIMEBOX , // 50 (354)
LONGCURRENCYFIELD,
LONGCURRENCYBOX ,
SCROLLWINDOW ,
@@ -87,7 +87,7 @@ enum class WindowType : sal_uInt16
TABPAGE ,
TABCONTROL ,
TABDIALOG,
-BORDERWINDOW ,
+BORDERWINDOW , // 60 (364)
BUTTONDIALOG ,
SYSTEMCHILDWINDOW,
SLIDER ,
@@ -97,7 +97,7 @@ enum class WindowType : sal_uInt16
INTROWINDOW ,
LISTBOXWINDOW,
DOCKINGAREA ,
-RULER,
+RULER, // 70 (374)
CALCINPUTLINE,
LAST = CALCINPUTLINE,
// only used in vclxtoolkit.cxx
@@ -163,6 +163,7 @@ WinBits const WB_AUTOHSCROLL =
SAL_CONST_INT64(0x1000);
WinBits const WB_DOCKABLE = SAL_CONST_INT64(0x2000);
WinBits const WB_AUTOVSCROLL = SAL_CONST_INT64(0x4000);
WinBits const WB_HYPHENATION = SAL_CONST_INT64(0x8) |
WB_WORDBREAK;
+// #i93011# style bit for some child windows, that want their children checked
for accelerators
WinBits const WB_CHILDDLGCTRL = SAL_CONST_INT64(0x1000);
// system floating window
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/layout.hxx|7 +
vcl/source/window/dialog.cxx |8 ++
vcl/source/window/dlgctrl.cxx | 56 +-
3 files changed, 44 insertions(+), 27 deletions(-)
New commits:
commit 9ff4232c365c19c9402fce80e26ccbf739d0b82e
Author: Jan-Marek Glogowski
AuthorDate: Wed Sep 26 14:09:59 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 02:33:23 2018 +0200
Handle initial TabControl and border window
ImplGetSubChildWindow has special code to handle a TabControl and
its pages. If the function finds a TabControl as a child it'll
return its window and then recurse into the current page.
This currently breaks in the case where the initial parent is a
TabControl. where the function will walk all of the tab pages.
The function also ignores border windows, but not if the initial
parent is a border window.
This patch correctly handles both cases and as a bonus drops all
the special page handling during child iteration.
Change-Id: Ie8699dae8d08628b66b33e0704237b9e219874bc
Reviewed-on: https://gerrit.libreoffice.org/61037
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 0f8818989268..22d494dfa6e2 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -769,6 +769,13 @@ public:
//of children
VCL_DLLPUBLIC vcl::Window* firstLogicalChildOfParent(const vcl::Window
*pTopLevel);
+//Get last window of a pTopLevel window as
+//if any intermediate layout widgets didn't exist
+//i.e. acts like pChild = pChild->GetWindow(GetWindowType::LastChild);
+//in a flat hierarchy where dialogs only have one layer
+//of children
+VCL_DLLPUBLIC vcl::Window* lastLogicalChildOfParent(const vcl::Window
*pTopLevel);
+
//Get next window after pChild of a pTopLevel window as
//if any intermediate layout widgets didn't exist
//i.e. acts like pChild = pChild->GetWindow(GetWindowType::Next);
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index 99b1cede0a8b..f3e977e42c63 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -186,6 +186,14 @@ vcl::Window * firstLogicalChildOfParent(const vcl::Window
*pTopLevel)
return const_cast(pChild);
}
+vcl::Window * lastLogicalChildOfParent(const vcl::Window *pTopLevel)
+{
+const vcl::Window *pChild = pTopLevel->GetWindow(GetWindowType::LastChild);
+if (pChild && isContainerWindow(*pChild))
+pChild = prevLogicalChildOfParent(pTopLevel, pChild);
+return const_cast(pChild);
+}
+
void Accelerator::GenerateAutoMnemonicsOnHierarchy(vcl::Window* pWindow)
{
MnemonicGenerator aMnemonicGenerator;
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index 4479291b6f24..36dcf861c566 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -94,49 +94,51 @@ static vcl::Window* ImplGetCurTabWindow(const vcl::Window*
pWindow)
static vcl::Window* ImplGetSubChildWindow( vcl::Window* pParent, sal_uInt16 n,
sal_uInt16& nIndex )
{
-vcl::Window* pTabPage = nullptr;
-vcl::Window* pFoundWindow = nullptr;
+// ignore border window
+pParent = pParent->ImplGetWindow();
+assert(pParent == pParent->ImplGetWindow());
-vcl::Window* pWindow = firstLogicalChildOfParent(pParent);
-vcl::Window* pNextWindow = pWindow;
-while ( pWindow )
+vcl::Window* pFoundWindow = nullptr;
+vcl::Window* pWindow = firstLogicalChildOfParent(pParent);
+vcl::Window* pNextWindow = pWindow;
+
+// process just the current page of a tab control
+if (pWindow && pParent->GetType() == WindowType::TABCONTROL)
+{
+pWindow = ImplGetCurTabWindow(pParent);
+pNextWindow = lastLogicalChildOfParent(pParent);
+}
+
+while (pWindow)
{
pWindow = pWindow->ImplGetWindow();
// skip invisible and disabled windows
-if ( pTabPage || isVisibleInLayout(pWindow) )
+if (isVisibleInLayout(pWindow))
{
-// if the last control was a TabControl, take its TabPage
-if ( pTabPage )
+// return the TabControl itself, before handling its page
+if (pWindow->GetType() == WindowType::TABCONTROL)
{
-pFoundWindow = ImplGetSubChildWindow( pTabPage, n, nIndex );
-pTabPage = nullptr;
+if (n == nIndex)
+return pWindow;
+++nIndex;
}
+if (pWindow->GetStyle() & (WB_DIALOGCONTROL | WB_CHILDDLGCTRL))
+pFoundWindow = ImplGetSubChildWindow(pWindow, n, nIndex);
else
-{
pFoundWindow = pWindow;
-// for a TabControl, remember the current TabPage for later use
-if ( pWindow->GetType() == WindowType::TABCONTROL )
-pTabPage =
[Libreoffice-commits] core.git: Branch 'feature/qt5-win+mac' - 201 commits - accessibility/source avmedia/source basctl/source basctl/uiconfig basegfx/source basic/source bin/find-unneeded-includes bi
Rebased ref, commits from common ancestor:
commit c478ac5cc1311e7cf67289d67d273db514ec06a9
Author: Jan-Marek Glogowski
AuthorDate: Mon Sep 17 11:01:59 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 01:57:12 2018 +0200
Qt5 use LO provided native file pickers
This uses the native file pickers on Windows and MacOSX.
Change-Id: Ic836d3ed8de0760c6c94c68d61f6eaa96f773000
diff --git a/vcl/Library_vclplug_qt5.mk b/vcl/Library_vclplug_qt5.mk
index 33b45bd8becb..4dc743f28b74 100644
--- a/vcl/Library_vclplug_qt5.mk
+++ b/vcl/Library_vclplug_qt5.mk
@@ -86,7 +86,7 @@ $(eval $(call gb_Library_add_exception_objects,vclplug_qt5,\
vcl/qt5/Qt5AccessibleWidget \
vcl/qt5/Qt5Bitmap \
vcl/qt5/Qt5Data \
-vcl/qt5/Qt5FilePicker \
+$(if $(USING_X11),vcl/qt5/Qt5FilePicker) \
vcl/qt5/Qt5Font \
vcl/qt5/Qt5FontFace \
vcl/qt5/Qt5Frame \
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index 8557834064d8..334aba4fbdea 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -211,17 +211,27 @@ void Qt5Instance::ProcessEvent(SalUserEvent aEvent)
}
css::uno::Reference
-Qt5Instance::createFilePicker(const
css::uno::Reference&)
+Qt5Instance::createFilePicker(const
css::uno::Reference& cntxt)
{
+#if (defined _WIN32 || defined MACOSX)
+return SalInstance::createFilePicker(cntxt);
+#else
+(void)cntxt;
return css::uno::Reference(
new Qt5FilePicker(QFileDialog::ExistingFile));
+#endif
}
css::uno::Reference
-Qt5Instance::createFolderPicker(const
css::uno::Reference&)
+Qt5Instance::createFolderPicker(const
css::uno::Reference& cntxt)
{
+#if (defined _WIN32 || defined MACOSX)
+return SalInstance::createFolderPicker(cntxt);
+#else
+(void)cntxt;
return css::uno::Reference(
new Qt5FilePicker(QFileDialog::Directory));
+#endif
}
extern "C" {
commit 949fa1a81be65bc1b9590d3d65f36e2d6bdf17db
Author: Jan-Marek Glogowski
AuthorDate: Thu Sep 13 11:32:12 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 01:57:11 2018 +0200
Qt5 build VCL plugin on MacOSX
Change-Id: I6ddec483703c95faf69b7b146363376765d5d6f8
diff --git a/Repository.mk b/Repository.mk
index b2c806307083..d1aa2540d266 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -482,6 +482,7 @@ $(eval $(call
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
AppleRemote \
) \
fps_aqua \
+ $(if $(ENABLE_QT5),vclplug_qt5) \
vclplug_osx \
MacOSXSpell \
) \
diff --git a/configure.ac b/configure.ac
index f88f9a4ae1f7..24c2bb2f04b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -672,6 +672,7 @@ darwin*) # Mac OS X or iOS
host=x86_64-apple-darwin
fi
else
+test_qt5=yes
_os=Darwin
INSTROOTBASESUFFIX=/$PRODUCTNAME_WITHOUT_SPACES.app
INSTROOTCONTENTSUFFIX=/Contents
@@ -11163,13 +11164,7 @@ if test \( "$test_kde5" = "yes" -a "$ENABLE_KDE5" =
"TRUE" \) -o \
\( "$test_qt5" = "yes" -a "$ENABLE_QT5" = "TRUE" \) -o \
\( "$test_gtk3_kde5" = "yes" -a "$ENABLE_GTK3_KDE5" = "TRUE" \)
then
-qt5_incdirs="$QT5INC /usr/include/qt5 /usr/include $x_includes"
-qt5_libdirs="$QT5LIB /usr/lib/qt5 /usr/lib $x_libraries"
-
-if test -n "$supports_multilib"; then
-qt5_libdirs="$qt5_libdirs /usr/lib64/qt5 /usr/lib64/qt /usr/lib64"
-fi
-
+qt5_fwk_search="QtCore QtGui QtWidgets QtNetwork"
qt5_test_include="QtWidgets/qapplication.h"
if test $_os == "WINNT"; then
qt5_test_library="Qt5Widgets.lib"
@@ -11177,12 +11172,25 @@ then
qt5_test_library="libQt5Widgets.so"
fi
+qt5_incdirs=""
+qt5_libdirs=""
+if test "$USING_X11" = TRUE; then
+qt5_incdirs="$QT5INC /usr/include/qt5 /usr/include $x_includes"
+qt5_libdirs="$QT5LIB /usr/lib/qt5 /usr/lib $x_libraries"
+if test -n "$supports_multilib"; then
+qt5_libdirs="$qt5_libdirs /usr/lib64/qt5 /usr/lib64/qt /usr/lib64"
+fi
+fi
+
dnl Check for qmake5
AC_PATH_PROGS( QMAKE5, [qmake-qt5 qmake], no, [$QT5DIR/bin:$PATH] )
if test "$QMAKE5" = "no"; then
AC_MSG_ERROR([Qmake not found. Please specify the root of your Qt5
installation by exporting QT5DIR before running "configure".])
else
-qmake5_test_ver="`$QMAKE5 -v 2>&1 | $SED -n -e 's/^Using Qt version
\(5\.[[0-9.]]\+\).*$/\1/p'`"
+case "$host_os" in
+darwin*) qmake5_test_ver="`$QMAKE5 -v 2>&1 | $SED -n -e 's/^Using Qt
version \(5\.[[0-9.]]\{0,\}\).*$/\1/p'`" ;;
+*) qmake5_test_ver="`$QMAKE5 -v 2>&1 | $SED -n -e 's/^Using Qt version
\(5\.[[0-9.]]\+\).*$/\1/p'`" ;;
+esac
if test -z "$qmake5_test_ver"; then
AC_MSG_ERROR([Wrong qmake for Qt5 found. Please specify the root
of your Qt5 installation by exporting QT5DIR before running "configure".])
[Libreoffice-commits] core.git: Branch 'feature/window-iter' - 51 commits - bin/gla11y bin/lo-all-static-libs comphelper/source compilerplugins/clang configure.ac cui/source cui/uiconfig dbaccess/inc
Rebased ref, commits from common ancestor:
commit 359a32c8e00b6a3e913a63864e60485f3068cc28
Author: Jan-Marek Glogowski
AuthorDate: Fri Sep 28 23:17:03 2018 +
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 01:25:49 2018 +0200
Window Iterator without parent vector
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index 81f1d128774d..674c8ac01261 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -111,7 +111,7 @@ class WindowIterator
const value_type m_pParent, m_pRealParent, m_pWindow;
const bool m_bTestEnabled;
value_type m_pCurrentWindow;
-std::vector m_aWindowStack;
+value_type m_pCurrentParent;
bool m_bCurrentWindowMayHaveChildren;
bool m_bIsTabControl;
@@ -127,7 +127,7 @@ public:
, m_pWindow(pWindow)
, m_bTestEnabled(bEnabled)
, m_pCurrentWindow(m_pRealParent)
-, m_aWindowStack({nullptr})
+, m_pCurrentParent(nullptr)
, m_bCurrentWindowMayHaveChildren(true)
, m_bIsTabControl(false)
{
@@ -178,16 +178,15 @@ public:
#ifdef DUMP_ITER
SAL_DEBUG("!window " << WT(pNextImplWindow));
#endif
+if (pNextWindow == m_pRealParent)
+break;
+
vcl::Window* pParent = nullptr;
while (true)
{
assert(!pWindow);
-if (nullptr != pParent)
-m_aWindowStack.pop_back();
-pParent = m_aWindowStack.back();
-if (nullptr == pParent)
-break;
+pParent =
getNonLayoutParent(pNextWindow)->GetWindow(GetWindowType::Border);
vcl::Window* pImplParent = pParent->ImplGetWindow();
if (pImplParent->GetType() == WindowType::TABCONTROL)
@@ -204,7 +203,11 @@ public:
SAL_DEBUG("nextLogicalChildOfParent " << pImplParent << "
" << pNextWindow << " >> " << WT(pWindow));
#endif
if (!pWindow)
+{
+if (pImplParent == m_pRealParent)
+break;
pNextWindow = pParent;
+}
else
{
pNextImplWindow = pWindow->ImplGetWindow();
@@ -213,6 +216,7 @@ public:
else
{
pNextWindow = pWindow;
+m_pCurrentParent = pImplParent;
break;
}
}
@@ -225,7 +229,7 @@ public:
}
else if (m_bCurrentWindowMayHaveChildren || m_bIsTabControl)
{
-m_aWindowStack.push_back(pNextWindow);
+m_pCurrentParent = pNextWindow;
pNextWindow = pWindow;
pNextImplWindow = pNextWindow->ImplGetWindow();
}
@@ -249,9 +253,9 @@ public:
m_bIsTabControl = false;
}
-pWindow = nextLogicalChildOfParent(m_aWindowStack.back(),
pNextWindow);
+pWindow = nextLogicalChildOfParent(m_pCurrentParent, pNextWindow);
#ifdef DUMP_ITER
-SAL_DEBUG("nextLogicalChildOfParent " << m_aWindowStack.back() <<
" " << pNextWindow << " => " << WT(pWindow));
+SAL_DEBUG("nextLogicalChildOfParent " << m_pCurrentParent << " "
<< pNextWindow << " => " << WT(pWindow));
#endif
if (pWindow)
{
commit 1331ccdf1d9267aa6dfb3a01033173a48be6289f
Author: Jan-Marek Glogowski
AuthorDate: Wed Sep 26 17:33:22 2018 +0200
Commit: Jan-Marek Glogowski
CommitDate: Sat Sep 29 01:25:48 2018 +0200
Debug infrastructure
Change-Id: Idd09c131240c1372a40c36feb07094e28c2a1581
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index dcb6cde57926..81f1d128774d 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -35,6 +35,17 @@
#include
+// #define ITER_ONLY
+// #define DUMP_ITER
+// #define DUMP_SUBCHILD
+// #define DUMP_IMPL_FIND_DLGCTRL
+// #define DUMP_IMPL_DLGCTL
+// #define DUMP_UPDATE_DEF_BUTTON
+
+#if (defined(DUMP_ITER) || defined(DUMP_SUBCHILD) ||
defined(DUMP_IMPL_FIND_DLGCTRL))
+#define WT(a) " " << a << " (" << (a ? a->ImplGetWindow() : nullptr) << " " <<
(a ? (int) a->GetType() - 0x130 : 0) << ")"
+#endif
+
using namespace ::com::sun::star;
static bool ImplHasIndirectTabParent( vcl::Window* pWindow )
@@ -120,13 +131,22 @@ public:
, m_bCurrentWindowMayHaveChildren(true)
, m_bIsTabControl(false)
{
+#ifdef DUMP_ITER
+SAL_DEBUG("Iter construct start " << m_pRealParent << " " << pWindow
<< " " << m_bTestEnabled);
+#endif
if (m_pRealParent->GetType() == WindowType::TABCONTROL)
m_bIsTabControl = true;
++(*this);
+#ifdef
[Libreoffice-bugs] [Bug 120137] Document won't print if it uses Roboto Slab font
https://bugs.documentfoundation.org/show_bug.cgi?id=120137 --- Comment #10 from LibreTraining --- Created attachment 145260 --> https://bugs.documentfoundation.org/attachment.cgi?id=145260=edit Updated PDF of Roboto Slab LO v2.00 alpha in Use They also added a Medium font - which I forgot to add in the previous PDF. . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91938] Help text stays visible when not relevant
https://bugs.documentfoundation.org/show_bug.cgi?id=91938 --- Comment #11 from Alan Wheeler --- I think it must have been fixed by changes for tdf#112356, which I think were implemented by Adolfo Jayme Barrientos - Many thanks -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120137] Document won't print if it uses Roboto Slab font
https://bugs.documentfoundation.org/show_bug.cgi?id=120137 --- Comment #9 from LibreTraining --- Created attachment 145259 --> https://bugs.documentfoundation.org/attachment.cgi?id=145259=edit PDF of Roboto Slab LO v2.00 alpha in Use Attached is a PDF of the above Roboto Slab LO v2.00 alpha fonts in use. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120137] Document won't print if it uses Roboto Slab font
https://bugs.documentfoundation.org/show_bug.cgi?id=120137 --- Comment #8 from LibreTraining --- Created attachment 145258 --> https://bugs.documentfoundation.org/attachment.cgi?id=145258=edit Roboto Slab LO v2.00 alpha modified for LO on Windows Roboto Slab LO v2.00 alpha modified for LO on Windows Alvaro try these fonts. These are the Roboto Slab Alpha v2.000 fonts from the link above and again modified to work properly in LibreOffice on Windows. They also added a Black font which is nice. The next attachment post is the PDF showing these fonts in use. Please let us know if this solves your printing issue. . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91938] Help text stays visible when not relevant
https://bugs.documentfoundation.org/show_bug.cgi?id=91938 Alan Wheeler changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Alan Wheeler --- This bug seems to no longer be present in LibreOffice Version: 6.1.2.1 (x64) Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 4; OS: Windows 10.0; UI render: GL; Locale: en-GB (en_GB); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - connectivity/registry dbaccess/source
connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu |
2 +-
dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx |
2 +-
dbaccess/source/ui/dlg/generalpage.cxx|
6 +-
3 files changed, 3 insertions(+), 7 deletions(-)
New commits:
commit f3d959aa4b3d5ce46b52617d69ef51f434a061c8
Author: Tamas Bunth
AuthorDate: Sat Sep 22 14:31:23 2018 +0200
Commit: Andras Timar
CommitDate: Sat Sep 29 00:59:34 2018 +0200
tdf#119850 show missing mysql connector options
For MYSQL connections there is an extra window which determines how to
connect to a mysql/mariadb database. This functionality is handled in
OGeneralPageWizard::approveDatasourceType.
Change-Id: Ia3c548103b694731cba47ff5390c34b072a938a0
Reviewed-on: https://gerrit.libreoffice.org/60893
Reviewed-by: Tamás Bunth
Tested-by: Tamás Bunth
(cherry picked from commit 37dba4f25f00ffc1a1a631772eadd50e998966c1)
diff --git
a/connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu
b/connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu
index 65bfdba90858..4998afb3a3e2 100644
--- a/connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu
+++ b/connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu
@@ -18,7 +18,7 @@
-->
http://openoffice.org/2004/installation;
xmlns:oor="http://openoffice.org/2001/registry;
xmlns:xs="http://www.w3.org/2001/XMLSchema;>
-
+
com.sun.star.comp.sdbc.mysqlc.MysqlCDriver
diff --git a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
index 784f0938a560..3c9a18c81db2 100644
--- a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
+++ b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
@@ -281,7 +281,7 @@ using namespace ::com::sun::star;
{
// show the "Connect directly" option only if the driver is installed
const DbuTypeCollectionItem* pCollectionItem = dynamic_cast( _rSet.GetItem(DSID_TYPECOLLECTION) );
-bool bHasMySQLNative = ( pCollectionItem != nullptr ) &&
pCollectionItem->getCollection()->hasDriver( "sdbc:mysqlc:" );
+bool bHasMySQLNative = ( pCollectionItem != nullptr ) &&
pCollectionItem->getCollection()->hasDriver( "sdbc:mysql:mysqlc:" );
if ( bHasMySQLNative )
m_pNATIVEDatabase->Show();
diff --git a/dbaccess/source/ui/dlg/generalpage.cxx
b/dbaccess/source/ui/dlg/generalpage.cxx
index 28a79c048981..adf5e01bde07 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -616,13 +616,9 @@ namespace dbaui
switch ( eType )
{
case ::dbaccess::DST_MYSQL_JDBC:
-_inout_rDisplayName = "MySQL";
-break;
case ::dbaccess::DST_MYSQL_ODBC:
case ::dbaccess::DST_MYSQL_NATIVE:
-// don't display those, the decision whether the user connects via
JDBC/ODBC/C-OOo is made on another
-// page
-_inout_rDisplayName.clear();
+_inout_rDisplayName = "MySQL";
break;
default:
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120189] New: Crash in: SfxBroadcaster::Broadcast(SfxHint const &) NEW
https://bugs.documentfoundation.org/show_bug.cgi?id=120189 Bug ID: 120189 Summary: Crash in: SfxBroadcaster::Broadcast(SfxHint const &) NEW Product: LibreOffice Version: 5.4.7.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cet...@verizon.net This bug was filed from the crash reporting server and is br-e4e0cdb2-71f9-4ade-87b9-17907b9c704b. = I had closed a Writer file earlier today and when I attempted to reopen the file, the bug message appeared asking me to report the bug. I am attempting to do so. There was a Microsoft update between the last closing and the opening of the document that failed. The file is a normal 2 page Writer file, as far as I am concerned, with a list of items, some empty lines, some italicized lines, and some tables created solely by tabs. I just attempted to reopen the file and it has opened normally. I do not know what the bug represents and am just perplexed at this point. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118790] Android 6.1 alpha - document text disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=118790 --- Comment #3 from Batt Smith --- The text is always disappearing and I am not able to make any changes to the source coding project for the site https://applesupportnumber.net/apple-customer-service/ and many other. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120158] It's imposible to paste special in Writer from Calc in Libreoffice 6.1.1 because the dialogue caption inform that's an unknown source
https://bugs.documentfoundation.org/show_bug.cgi?id=120158 sol...@gmail.com changed: What|Removed |Added Attachment #145251|Image with the bug |Image without the bug when description||you choose english language ||in settings for interface -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120158] It's imposible to paste special in Writer from Calc in Libreoffice 6.1.1 because the dialogue caption inform that's an unknown source
https://bugs.documentfoundation.org/show_bug.cgi?id=120158 --- Comment #5 from sol...@gmail.com --- Created attachment 145257 --> https://bugs.documentfoundation.org/attachment.cgi?id=145257=edit In dialog paste speciaal with spanish language appears like unknown source -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120179] sumif works wrong if Range has different row index than SumRange
https://bugs.documentfoundation.org/show_bug.cgi?id=120179 m.a.riosv changed: What|Removed |Added CC||olivier.hallot@documentfoun ||dation.org --- Comment #4 from m.a.riosv --- Hi Olivier what do you think about? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120188] New: In Writer document when a text is highlighted and right click+Character is selected the resulting window is too wide and cannot be resized
https://bugs.documentfoundation.org/show_bug.cgi?id=120188 Bug ID: 120188 Summary: In Writer document when a text is highlighted and right click+Character is selected the resulting window is too wide and cannot be resized Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bostj...@alum.mit.edu Description: Referring to the Summary, one would expect the window to be of "reasonable size" and allow resizing. Steps to Reproduce: 1. open Writer document (.odt file) 2. select some text (e.g. one word) 3. right click -> Character Actual Results: the resulting windows extends over the whole screen, and cannot be resized Expected Results: resizable "reasonably sized" window Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - vcl/AllLangResTarget_vcl.mk vcl/Library_desktop_detector.mk vcl/Library_vcl.mk vcl/Library_vclplug_gen.mk vcl/Library_vclplug_kde4.mk vcl/Library_v
vcl/AllLangResTarget_vcl.mk |1 - vcl/Library_desktop_detector.mk |1 + vcl/Library_vcl.mk |3 ++- vcl/Library_vclplug_gen.mk |3 ++- vcl/Library_vclplug_kde.mk |1 + vcl/Library_vclplug_kde4.mk |1 + vcl/Library_vclplug_svp.mk |1 + vcl/Module_vcl.mk |1 - vcl/Package_inc.mk |1 + vcl/Package_osx.mk |3 ++- vcl/WinResTarget_vcl.mk |2 ++ 11 files changed, 13 insertions(+), 5 deletions(-) New commits: commit e1ee6c6b6fef3293025c524f7f4fc29cfd171113 Author: Matthias Seidel AuthorDate: Fri Sep 28 18:18:47 2018 + Commit: Matthias Seidel CommitDate: Fri Sep 28 18:18:47 2018 + Minor cleanup according to vim modeline diff --git a/vcl/AllLangResTarget_vcl.mk b/vcl/AllLangResTarget_vcl.mk index 467c7a2e3c96..5b37d3ec4fa7 100644 --- a/vcl/AllLangResTarget_vcl.mk +++ b/vcl/AllLangResTarget_vcl.mk @@ -47,5 +47,4 @@ $(eval $(call gb_SrsTarget_add_files,vcl/source/src,\ vcl/source/src/units.src \ )) - # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_desktop_detector.mk b/vcl/Library_desktop_detector.mk index 1afacb7906a3..515e9eceadb9 100644 --- a/vcl/Library_desktop_detector.mk +++ b/vcl/Library_desktop_detector.mk @@ -85,4 +85,5 @@ $(eval $(call gb_Library_add_linked_libs,desktop_detector,\ pthread \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 23c98b7b957f..4cddfd46bc6d 100755 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -57,7 +57,7 @@ endif ifeq ($(GUIBASE),unx) $(eval $(call gb_Library_set_include,vcl,\ $$(INCLUDE) \ - $$(FREETYPE_CFLAGS) \ +$$(FREETYPE_CFLAGS) \ )) endif @@ -538,4 +538,5 @@ $(eval $(call gb_Library_add_linked_libs,vcl,\ $(gb_STDLIBS) \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_vclplug_gen.mk b/vcl/Library_vclplug_gen.mk index 0fa77f09a430..da16fe602977 100755 --- a/vcl/Library_vclplug_gen.mk +++ b/vcl/Library_vclplug_gen.mk @@ -121,7 +121,7 @@ $(eval $(call gb_Library_add_defs,vclplug_gen,\ )) -## handle RandR +## handle RandR ifeq ($(ENABLE_RANDR),TRUE) $(eval $(call gb_Library_add_defs,vclplug_gen,\ -DUSE_RANDR \ @@ -203,4 +203,5 @@ $(eval $(call gb_Library_add_libs,vclplug_gen, \ -lXinerama -lXrandr \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_vclplug_kde.mk b/vcl/Library_vclplug_kde.mk index 0a44cc3ba3c0..9c69bfc7e4c8 100755 --- a/vcl/Library_vclplug_kde.mk +++ b/vcl/Library_vclplug_kde.mk @@ -91,4 +91,5 @@ $(eval $(call gb_Library_add_linked_libs,vclplug_kde,\ pthread \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_vclplug_kde4.mk b/vcl/Library_vclplug_kde4.mk index 0a57e5567dcb..1d41c11b7743 100755 --- a/vcl/Library_vclplug_kde4.mk +++ b/vcl/Library_vclplug_kde4.mk @@ -97,4 +97,5 @@ $(eval $(call gb_Library_add_linked_libs,vclplug_kde4,\ pthread \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Library_vclplug_svp.mk b/vcl/Library_vclplug_svp.mk index d9c2407fe7c5..47a07c2221fc 100755 --- a/vcl/Library_vclplug_svp.mk +++ b/vcl/Library_vclplug_svp.mk @@ -97,4 +97,5 @@ $(eval $(call gb_Library_add_linked_libs,vclplug_svp,\ pthread \ )) endif + # vim: set noet sw=4 ts=4: diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk index 6272197391bb..ceeb011373d5 100644 --- a/vcl/Module_vcl.mk +++ b/vcl/Module_vcl.mk @@ -21,7 +21,6 @@ - $(eval $(call gb_Module_Module,vcl)) $(eval $(call gb_Module_add_targets,vcl,\ diff --git a/vcl/Package_inc.mk b/vcl/Package_inc.mk index 85f3f39dba79..c064f7a5b8ca 100644 --- a/vcl/Package_inc.mk +++ b/vcl/Package_inc.mk @@ -162,3 +162,4 @@ $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/window.hxx,vcl/window.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/wpropset.hxx,vcl/wpropset.hxx)) $(eval $(call gb_Package_add_file,vcl_inc,inc/vcl/wrkwin.hxx,vcl/wrkwin.hxx)) +# vim: set noet sw=4 ts=4: diff --git a/vcl/Package_osx.mk b/vcl/Package_osx.mk index 8c7d11acd879..4bc0db6d85fa 100644 --- a/vcl/Package_osx.mk +++ b/vcl/Package_osx.mk @@ -25,8 +25,9 @@ $(eval $(call gb_Package_Package,vcl_zip,)) $(eval $(call gb_Package_add_file,vcl_zip,bin/osxres.zip,$(WORKDIR)/Misc/osxres.zip)) -/$(WORKDIR)/Misc/osxres.zip: $(SRCDIR)/vcl/aqua/source/res/MainMenu.nib/*.nib $(SRCDIR)/vcl/aqua/source/res/cursors/*.png +/$(WORKDIR)/Misc/osxres.zip: $(SRCDIR)/vcl/aqua/source/res/MainMenu.nib/*.nib $(SRCDIR)/vcl/aqua/source/res/cursors/*.png cd $(SRCDIR)/vcl/aqua/source/res ; \ mkdir -p $(dir $@) ; \ zip $@ MainMenu.nib/*.nib cursors/*.png +# vim: set noet sw=4 ts=4: diff --git a/vcl/WinResTarget_vcl.mk b/vcl/WinResTarget_vcl.mk index f0e7dda5b77f..3f0e4bfcfa21 100755 --- a/vcl/WinResTarget_vcl.mk +++ b/vcl/WinResTarget_vcl.mk @@ -211,3 +211,5 @@ $(eval $(call gb_WinResTarget_set_include,vcl/src,\ )) endif + +# vim: set noet sw=4 ts=4:
[Libreoffice-bugs] [Bug 119067] REPORTBUILDER: Report label display string lost when saved and the actual string 'LABEL' used when the report is run next.
https://bugs.documentfoundation.org/show_bug.cgi?id=119067 --- Comment #11 from moebius20 --- Bonjour, Unfortunately, still present in LO 6.1.2 final cordialement, -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120181] A link error on main feedback page
https://bugs.documentfoundation.org/show_bug.cgi?id=120181 BogdanB changed: What|Removed |Added CC||bogdan...@gmail.com --- Comment #1 from BogdanB --- If I folow your steps I go to the page: https://ask.libreoffice.org/ro/questions/ Because it is my language localisation, so it is correct for Romania. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120185] Calc - the Borders icon and Border tools (lines) are no longer black
https://bugs.documentfoundation.org/show_bug.cgi?id=120185 --- Comment #2 from BogdanB --- Created attachment 145256 --> https://bugs.documentfoundation.org/attachment.cgi?id=145256=edit see the screenshot screenshot of bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120185] Calc - the Borders icon and Border tools (lines) are no longer black
https://bugs.documentfoundation.org/show_bug.cgi?id=120185 BogdanB changed: What|Removed |Added Keywords||bibisected OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120185] Calc - the Borders icon and Border tools (lines) are no longer black
https://bugs.documentfoundation.org/show_bug.cgi?id=120185 BogdanB changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||bogdan...@gmail.com Ever confirmed|0 |1 --- Comment #1 from BogdanB --- Bibisected on linux 6.1 4b88d5ab1112b6780c148dedcbfd75696b369000 is the first bad commit commit 4b88d5ab1112b6780c148dedcbfd75696b369000 Author: Jenkins Build User Date: Wed Mar 28 21:19:16 2018 +0200 source sha:6d4bb4dd4ef425a429c929e7d953cf9b54a74576 source sha:6d4bb4dd4ef425a429c929e7d953cf9b54a74576 :04 04 be7358ac899314d86970984dbeeea9e813442366 6ef33ab8ffd87ec623f9b6eb4819594b06c34e21 M instdir -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 BogdanB changed: What|Removed |Added Keywords||bibisected -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 BogdanB changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 --- Comment #5 from BogdanB --- I bisect 6.1 on linux: there were bad and good commit: bd800e0c22633dc52985d4218bff88edb55ddf39 is the first bad commit commit bd800e0c22633dc52985d4218bff88edb55ddf39 Author: Jenkins Build User Date: Wed Dec 13 01:06:51 2017 +0100 source sha:5217a2a0bf27e496cc429ee45dff7c239b466ae6 source sha:5217a2a0bf27e496cc429ee45dff7c239b466ae6 :04 04 5644483c9cbffe9d488f5c343b429c3cf35fc29f 67166bdeba9fc4e4f8eb5beecea30bdf3143a9c1 M instdir -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120133] Auto filter drop down dialog box in the header will not stay open to be able select fields in calc ver 6.0.6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=120133 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120187] New: Error message handling checkbox criterion building Query in Design View
https://bugs.documentfoundation.org/show_bug.cgi?id=120187 Bug ID: 120187 Summary: Error message handling checkbox criterion building Query in Design View Product: LibreOffice Version: 6.1.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zoom...@gmx.com Description: I want to emphasize that this works in Ubuntu, but not in Windows 8.1 x64. Say I have a checkbox field in my table called Cancelled. I want the query to list all the cancelled items. I put a "1" or "=1" in the criterion in the Cancelled column. I get the following error message: The data content could not be loaded firebird_sdbc error: *Dynamic SQL Error *SQL error code = -104 *Invalid usage of boolean expression caused by 'isc_dsql_prepare' Yet it works in Ubuntu. I have no idea what the error message means. Steps to Reproduce: 1.Set up query in design mode. 2.Put "1" 0r "=1" in Criterion for Cancelled (Boolean) field. 3.Run Query. Actual Results: I got the error message listed above. Expected Results: I expected the query to run and give me a list of cancelled items. It does this in the Ubuntu version. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 6.1.2.1 (x64) Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 8; OS: Windows 6.3; UI render: default; Locale: en-CA (en_CA); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 --- Comment #4 from BogdanB --- I will bibisect now with 6.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103405] L10n: Add additional user interface language Hungarian Rovas [hu-Hung-HU]
https://bugs.documentfoundation.org/show_bug.cgi?id=103405 --- Comment #14 from Kovács Viktor --- There is a language ID: hu-Hung-HU. There is an UNICODE code page called "Old Hungarian". The LibreOffice can use this page as RTL script, named "none". Could any programmer to link this two things? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120133] Auto filter drop down dialog box in the header will not stay open to be able select fields in calc ver 6.0.6.2
https://bugs.documentfoundation.org/show_bug.cgi?id=120133 --- Comment #2 from Bryan --- (In reply to Roman Kuznetsov from comment #1) > please add info from dialogue About > > don't repro for me in > > Version: 6.1.2.1 > Build ID: 65905a128db06ba48db947242809d14d3f9a93fe > CPU threads: 4; OS: Windows 6.1; UI render: default; > Locale: ru-RU (ru_RU); Calc: group threaded Thank you for your prompt response. I think it may well be an issue with this particular laptop. I have tried to do a Timeshift to reset the computer to an previous version of LibreOffice and the drop down arrow works as it should. But as soon as I allow Linux to update libreOffice to 6.0.6.2 the same problem happens again. I have managed to get another computer with Linux Mint with the same version of LibreOffice 6.0.6.2 and the dialog box works correctly?? So it seems it must be the individual laptop that for some reason has a problem. Many thanks once again for your response. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120186] New: Ladino language is not supported as a CTL (complex text layout) language
https://bugs.documentfoundation.org/show_bug.cgi?id=120186 Bug ID: 120186 Summary: Ladino language is not supported as a CTL (complex text layout) language Product: LibreOffice Version: 5.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: io...@users.sourceforge.net Description: In the "Character properties" UI, the CTL font section doesn't allow to specify Ladino language (ISO 639-3 code "lad", OpenType language system tag 'JUD ') Steps to Reproduce: In LibreOffice Writer 1. Type some text in Hebrew characters, or paste this: " סאלבֿאסייון" and select it 2. Go to "Tools->Language->For selection-> More..." Actual Results: 3. In the drop-down box "Font->CTL Font->Language" there is no Ladino entry Expected Results: 3. In the drop-down box "Font->CTL Font->Language" there should be Ladino entry Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/CppunitTest_sc_dataprovider.mk sc/Library_sc.mk sc/qa sc/source test/Package_unittest.mk test/user-template
sc/CppunitTest_sc_dataprovider.mk |9 +
sc/Library_sc.mk |1
sc/qa/unit/dataproviders_test.cxx | 25 ++
sc/source/ui/dataprovider/dataprovider.cxx |4
sc/source/ui/dataprovider/sqldataprovider.cxx | 180 +
sc/source/ui/dataprovider/sqldataprovider.hxx | 42
test/Package_unittest.mk |3
test/user-template/user/database/biblio.odb|binary
test/user-template/user/database/biblio/biblio.dbf |binary
test/user-template/user/database/biblio/biblio.dbt |binary
10 files changed, 264 insertions(+)
New commits:
commit 278b1de21f8395ab2a6c49377cf4aec4c16f05c6
Author: Vikas
AuthorDate: Sat Jul 14 19:35:35 2018 +0530
Commit: Markus Mohrhard
CommitDate: Fri Sep 28 20:34:38 2018 +0200
Added base as a data provider
Change-Id: Iaf23b70f303cd05bcf6450fed1246de894285526
Reviewed-on: https://gerrit.libreoffice.org/57447
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
diff --git a/sc/CppunitTest_sc_dataprovider.mk
b/sc/CppunitTest_sc_dataprovider.mk
index 71fa6ea30fed..8c449084ee8d 100644
--- a/sc/CppunitTest_sc_dataprovider.mk
+++ b/sc/CppunitTest_sc_dataprovider.mk
@@ -82,7 +82,15 @@ $(eval $(call gb_CppunitTest_use_components,sc_dataprovider,\
chart2/source/controller/chartcontroller \
comphelper/util/comphelp \
configmgr/source/configmgr \
+connectivity/source/cpool/dbpool2 \
+connectivity/source/drivers/hsqldb/hsqldb \
+connectivity/source/drivers/dbase/dbase \
+$(if
$(ENABLE_FIREBIRD_SDBC),connectivity/source/drivers/firebird/firebird_sdbc) \
+connectivity/source/drivers/jdbc/jdbc \
+connectivity/source/manager/sdbc2 \
+dbaccess/source/filter/xml/dbaxml \
dbaccess/util/dba \
+dbaccess/util/dbu \
embeddedobj/util/embobj \
eventattacher/source/evtatt \
filter/source/config/cache/filterconfig1 \
@@ -91,6 +99,7 @@ $(eval $(call gb_CppunitTest_use_components,sc_dataprovider,\
i18npool/source/search/i18nsearch \
i18npool/util/i18npool \
linguistic/source/lng \
+extensions/source/logging/log \
oox/util/oox \
package/source/xstor/xstor \
package/util/package2 \
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index dc2a2149f0a1..5695e729ffbe 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -401,6 +401,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/ui/dataprovider/datatransformation \
sc/source/ui/dataprovider/htmldataprovider \
sc/source/ui/dataprovider/xmldataprovider \
+sc/source/ui/dataprovider/sqldataprovider \
sc/source/ui/dbgui/asciiopt \
sc/source/ui/dbgui/consdlg \
sc/source/ui/dbgui/csvcontrol \
diff --git a/sc/qa/unit/dataproviders_test.cxx
b/sc/qa/unit/dataproviders_test.cxx
index aef3ec6abb05..e8da21fa0b2d 100644
--- a/sc/qa/unit/dataproviders_test.cxx
+++ b/sc/qa/unit/dataproviders_test.cxx
@@ -31,12 +31,14 @@ public:
void testDataLargerThanDB();
void testHTMLImport();
void testXMLImport();
+// void testBaseImport();
CPPUNIT_TEST_SUITE(ScDataProvidersTest);
CPPUNIT_TEST(testCSVImport);
CPPUNIT_TEST(testDataLargerThanDB);
CPPUNIT_TEST(testHTMLImport);
CPPUNIT_TEST(testXMLImport);
+// CPPUNIT_TEST(testBaseImport);
CPPUNIT_TEST_SUITE_END();
private:
@@ -180,6 +182,29 @@ void ScDataProvidersTest::testXMLImport()
CPPUNIT_ASSERT_EQUAL(OUString("test4"), m_pDoc->GetString(1, 4, 0));
}
+/*
+void ScDataProvidersTest::testBaseImport()
+{
+ScDBData* pDBData = new ScDBData("testDB", 0, 0, 0, 10, 10);
+bool bInserted = m_pDoc->GetDBCollection()->getNamedDBs().insert(pDBData);
+CPPUNIT_ASSERT(bInserted);
+
+sc::ExternalDataSource aDataSource("~/dummy.file",
"org.libreoffice.calc.sql", m_pDoc);
+aDataSource.setDBData("testDB");
+aDataSource.setID("biblio@Bibliography");
+
+
+m_pDoc->GetExternalDataMapper().insertDataSource(aDataSource);
+auto& rDataSources = m_pDoc->GetExternalDataMapper().getDataSources();
+CPPUNIT_ASSERT(!rDataSources.empty());
+
+rDataSources[0].refresh(m_pDoc, true);
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(OUString("ARJ00"), m_pDoc->GetString(0, 0, 0));
+CPPUNIT_ASSERT_EQUAL(OUString("AVV00"), m_pDoc->GetString(1, 1, 0));
+}
+*/
ScDataProvidersTest::ScDataProvidersTest() :
ScBootstrapFixture( "sc/qa/unit/data/dataprovider" ),
diff --git a/sc/source/ui/dataprovider/dataprovider.cxx
b/sc/source/ui/dataprovider/dataprovider.cxx
index 01408c778fa9..6a7016fd43f6 100644
--- a/sc/source/ui/dataprovider/dataprovider.cxx
+++ b/sc/source/ui/dataprovider/dataprovider.cxx
@@ -17,6 +17,7 @@
#include "htmldataprovider.hxx"
#include "xmldataprovider.hxx"
+#include "sqldataprovider.hxx"
#include
using namespace com::sun::star;
@@ -286,6 +287,8 @@ std::shared_ptr
[Libreoffice-bugs] [Bug 120179] sumif works wrong if Range has different row index than SumRange
https://bugs.documentfoundation.org/show_bug.cgi?id=120179 --- Comment #3 from Pawel --- (In reply to m.a.riosv from comment #2) > Created attachment 145254 [details] > File sample, sumif > > Both ranges should have the same length in rows or columns, or the second > range has only the first cell (not compatible with other file formats). > But if not, only the rows on the second range with the same relative > position than in range of criteria, are summed. > > Take a see to your file sample modified, so what rows are summed it's more > visible. > > IMO there is not a bug, it does what you have formulated. > > BTW SUMIFS it's I think more friendly, because the summed range it's the > first and it's easy to add more criteria at the end of the function. > > Please if you are not agree, reopen it. I see now. Thanks for clarification. I agree now that there is no bug, but would be great to mention about that use case in documentation of sumif formula. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig solenv/sanitizers
cui/source/options/personalization.cxx |9 -- cui/uiconfig/ui/personalization_tab.ui | 118 +++-- solenv/sanitizers/ui/cui.suppr |3 3 files changed, 28 insertions(+), 102 deletions(-) New commits: commit c494273adea0293bbcfc022adc0ea13d5c21e18d Author: Muhammet Kara AuthorDate: Thu Sep 27 20:57:53 2018 +0200 Commit: Muhammet Kara CommitDate: Fri Sep 28 20:01:34 2018 +0200 Revert "Personas: add 6 themes to the selection dialog" This reverts commit 9927a3ab9edec7ae9f41ecaa8025a2a920321997. Change-Id: I7282bb5734c4cad2cf2d375d4a6bfc03a759ce19 Reviewed-on: https://gerrit.libreoffice.org/61055 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx index a398b84592ca..6ac90e7fea3b 100644 --- a/cui/source/options/personalization.cxx +++ b/cui/source/options/personalization.cxx @@ -297,15 +297,6 @@ SvxPersonalizationTabPage::SvxPersonalizationTabPage( vcl::Window *pParent, cons get( m_vDefaultPersonaImages[2], "default3" ); m_vDefaultPersonaImages[2]->SetClickHdl( LINK( this, SvxPersonalizationTabPage, DefaultPersona ) ); -get( m_vDefaultPersonaImages[3], "default4" ); -m_vDefaultPersonaImages[3]->SetClickHdl( LINK( this, SvxPersonalizationTabPage, DefaultPersona ) ); - -get( m_vDefaultPersonaImages[4], "default5" ); -m_vDefaultPersonaImages[4]->SetClickHdl( LINK( this, SvxPersonalizationTabPage, DefaultPersona ) ); - -get( m_vDefaultPersonaImages[5], "default6" ); -m_vDefaultPersonaImages[5]->SetClickHdl( LINK( this, SvxPersonalizationTabPage, DefaultPersona ) ); - get( m_pPersonaList, "installed_personas" ); m_pPersonaList->SetSelectHdl( LINK( this, SvxPersonalizationTabPage, SelectInstalledPersona ) ); diff --git a/cui/uiconfig/ui/personalization_tab.ui b/cui/uiconfig/ui/personalization_tab.ui index 43ef274483b0..588583ab4328 100644 --- a/cui/uiconfig/ui/personalization_tab.ui +++ b/cui/uiconfig/ui/personalization_tab.ui @@ -1,5 +1,5 @@ - + @@ -64,105 +64,43 @@ True False -vertical - -True -False - - -True -True -True -True - - -False -True -0 - - - - -True -True -True -True - - -False -True -1 - - - - -True -True -True -True - - -False -True -2 - - + +True +True +True +True -True +False True 0 - -True -False - - -True -True -True -True - - -False -True -0 - - - - -True -True -True -True - - -False -True -1 - - - - -True -True -True -True
[Libreoffice-bugs] [Bug 120154] High RAM usage ( around 300mb for 10 mins and drop to 150-200 mb)
https://bugs.documentfoundation.org/show_bug.cgi?id=120154 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #6 from m.a.riosv --- Calculation time it's because in sheet 'Actual' you have the whole columns of external file to do a conditional sum. Reducing the end of range, reduce drastically the time calculation. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116920] Bounding box indicators are rendered erroneously on higher-resolution screen
https://bugs.documentfoundation.org/show_bug.cgi?id=116920 --- Comment #8 from Regina Henschel --- I can produce a similar result, if I set the display to 200% (resulting in 192dpi) in the system settings of Window 10, although I have a normal monitor. The markers are contained in the files markers.png and cropmarkers.png in the folder svx/res in the images_???.zip file. Instead of ??? use the theme, you have selected. The needed markers are cut from that images. There is method CountDPIScaleFactor(sal_Int32 nDPI) in windows.cxx which generates a scaling factor. In my case of 192dpi it would generate 200%. I have taken the "cropmarkers" of an image as example. The resulting markers look as if the pixel offset, which is needed to cut the desired marker from the large image, is multiplied with this 200% and therefore the wrong part of the image is taken as "marker". Do you have a display resolution in Windows set, which is different from the normal 100%? Or is such value set by the device driver? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/uiconfig sfx2/uiconfig starmath/uiconfig sw/uiconfig uui/uiconfig
cui/uiconfig/ui/fontfragment.ui |2 +- cui/uiconfig/ui/signsignatureline.ui|2 +- cui/uiconfig/ui/specialcharacters.ui|4 ++-- sfx2/uiconfig/ui/emojicontrol.ui| 18 +- starmath/uiconfig/smath/ui/spacingdialog.ui |8 sw/uiconfig/swriter/ui/optredlinepage.ui|6 +++--- sw/uiconfig/swriter/ui/templatedialog16.ui |2 +- sw/uiconfig/swriter/ui/templatedialog8.ui |2 +- uui/uiconfig/ui/authfallback.ui |2 +- 9 files changed, 23 insertions(+), 23 deletions(-) New commits: commit b6b400396f92f51f76afa0788275ef01b7a11f6b Author: Andras Timar AuthorDate: Fri Sep 28 12:39:09 2018 +0200 Commit: Andras Timar CommitDate: Fri Sep 28 19:39:28 2018 +0200 fix issues found by bin/ui-translatable.sh Change-Id: I443aeea9dd21e34110307e9ef5f9db4b13c50b39 Reviewed-on: https://gerrit.libreoffice.org/61080 Tested-by: Jenkins Reviewed-by: Andras Timar diff --git a/cui/uiconfig/ui/fontfragment.ui b/cui/uiconfig/ui/fontfragment.ui index 18b4ab9be7d4..880208c86b49 100644 --- a/cui/uiconfig/ui/fontfragment.ui +++ b/cui/uiconfig/ui/fontfragment.ui @@ -25,7 +25,7 @@ -placeholder +placeholder True False True diff --git a/cui/uiconfig/ui/signsignatureline.ui b/cui/uiconfig/ui/signsignatureline.ui index 33891a7d343a..c27f42108370 100644 --- a/cui/uiconfig/ui/signsignatureline.ui +++ b/cui/uiconfig/ui/signsignatureline.ui @@ -53,7 +53,7 @@ -Sign +Sign True True True diff --git a/cui/uiconfig/ui/specialcharacters.ui b/cui/uiconfig/ui/specialcharacters.ui index c9c9bd1f44da..c3bc8b7276b2 100644 --- a/cui/uiconfig/ui/specialcharacters.ui +++ b/cui/uiconfig/ui/specialcharacters.ui @@ -236,7 +236,7 @@ True False -U+ +U+ 3 True 3 @@ -253,7 +253,7 @@ True True 8 -A2 +A2 False diff --git a/sfx2/uiconfig/ui/emojicontrol.ui b/sfx2/uiconfig/ui/emojicontrol.ui index 4f9502d52d0c..9474c040533c 100644 --- a/sfx2/uiconfig/ui/emojicontrol.ui +++ b/sfx2/uiconfig/ui/emojicontrol.ui @@ -47,7 +47,7 @@ True False center -1f603 +1f603 False @@ -70,7 +70,7 @@ 40 True False -1f43c +1f43c 1 @@ -94,7 +94,7 @@ 40 True False -1f34f +1f34f 2 @@ -117,7 +117,7 @@ True False -1f3c8 +1f3c8 3 @@ -140,7 +140,7 @@ True False -1f697 +1f697 4 @@ -163,7 +163,7 @@ True False -1f4f1 +1f4f1 5 @@ -186,7 +186,7 @@ True False -1f499 +1f499 6 @@ -209,7 +209,7 @@ True False -1f1ee-1f1f3 +1f1ee-1f1f3 7 @@ -232,7 +232,7 @@ True False -1f939 +1f939 8 diff --git a/starmath/uiconfig/smath/ui/spacingdialog.ui b/starmath/uiconfig/smath/ui/spacingdialog.ui index 0001c6669eff..d3ccd188ffec 100644 --- a/starmath/uiconfig/smath/ui/spacingdialog.ui +++ b/starmath/uiconfig/smath/ui/spacingdialog.ui @@ -302,7 +302,7 @@ True False True -String 1 +String 1 True spinbutton1 0 @@ -317,7 +317,7 @@ True
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #3 from m.a.riosv --- Created attachment 145255 --> https://bugs.documentfoundation.org/attachment.cgi?id=145255=edit File with screenshots It's a regression, works with 6.0.7 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120161] PRINTING: Problem with selected cells which cross pages
https://bugs.documentfoundation.org/show_bug.cgi?id=120161 m.a.riosv changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120179] sumif works wrong if Range has different row index than SumRange
https://bugs.documentfoundation.org/show_bug.cgi?id=120179 m.a.riosv changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120179] sumif works wrong if Range has different row index than SumRange
https://bugs.documentfoundation.org/show_bug.cgi?id=120179 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m.a.riosv --- Created attachment 145254 --> https://bugs.documentfoundation.org/attachment.cgi?id=145254=edit File sample, sumif Both ranges should have the same length in rows or columns, or the second range has only the first cell (not compatible with other file formats). But if not, only the rows on the second range with the same relative position than in range of criteria, are summed. Take a see to your file sample modified, so what rows are summed it's more visible. IMO there is not a bug, it does what you have formulated. BTW SUMIFS it's I think more friendly, because the summed range it's the first and it's easy to add more criteria at the end of the function. Please if you are not agree, reopen it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85127] FILEOPEN: DOCX - Image border not imported when found in
https://bugs.documentfoundation.org/show_bug.cgi?id=85127 --- Comment #20 from Luke --- Created attachment 145253 --> https://bugs.documentfoundation.org/attachment.cgi?id=145253=edit Converted document to remove compat mode Correctly imported when *not* in compatibility mode. Original bug doc still repo in Version: 6.2.0.0.alpha0+ (x64) Build ID: 05b45cc9aa165f895beae0b8f9eb192243812999 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/dialogs/dlg_InsertDataLabel.cxx |2 +-
chart2/source/controller/dialogs/dlg_NumberFormat.cxx| 14 +++---
chart2/source/controller/dialogs/dlg_NumberFormat.hxx|6 +++---
chart2/source/controller/dialogs/res_DataLabel.cxx | 10 +-
chart2/source/controller/dialogs/res_DataLabel.hxx |4 ++--
chart2/source/controller/dialogs/tp_DataLabel.cxx|2 +-
6 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 990ced77a5a8c27d69d40a702b3122850dcb04f0
Author: Caolán McNamara
AuthorDate: Fri Sep 28 15:34:40 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 19:05:09 2018 +0200
weld NumberFormatDialog
Change-Id: I82f3574142bbcdfba5277a7ad5db82e3a33fdbd8
Reviewed-on: https://gerrit.libreoffice.org/61092
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/dlg_InsertDataLabel.cxx
b/chart2/source/controller/dialogs/dlg_InsertDataLabel.cxx
index 646ba40b8699..4bfb943fddc9 100644
--- a/chart2/source/controller/dialogs/dlg_InsertDataLabel.cxx
+++ b/chart2/source/controller/dialogs/dlg_InsertDataLabel.cxx
@@ -27,7 +27,7 @@ DataLabelsDialog::DataLabelsDialog(vcl::Window* pWindow,
const SfxItemSet& rInAt
ModalDialog(pWindow
,"dlg_DataLabels"
,"modules/schart/ui/dlg_DataLabel.ui"),
-m_apDataLabelResources( new DataLabelResources(this, this, rInAttrs) )
+m_apDataLabelResources( new DataLabelResources(this, GetFrameWeld(),
rInAttrs) )
{
m_apDataLabelResources->SetNumberFormatter( pFormatter );
m_apDataLabelResources->Reset(rInAttrs);
diff --git a/chart2/source/controller/dialogs/dlg_NumberFormat.cxx
b/chart2/source/controller/dialogs/dlg_NumberFormat.cxx
index bcffbbdfe7c2..ca9a74146cc9 100644
--- a/chart2/source/controller/dialogs/dlg_NumberFormat.cxx
+++ b/chart2/source/controller/dialogs/dlg_NumberFormat.cxx
@@ -30,17 +30,17 @@ namespace chart
{
using namespace ::com::sun::star;
-NumberFormatDialog::NumberFormatDialog(vcl::Window* pParent, SfxItemSet& rSet)
-: SfxSingleTabDialog(pParent, rSet, "FormatNumberDialog",
-"cui/ui/formatnumberdialog.ui")
+NumberFormatDialog::NumberFormatDialog(weld::Window* pParent, SfxItemSet& rSet)
+: SfxSingleTabDialogController(pParent, rSet,
"cui/ui/formatnumberdialog.ui", "FormatNumberDialog")
{
SfxAbstractDialogFactory* pFact = SfxAbstractDialogFactory::Create();
::CreateTabPage fnCreatePage = pFact->GetTabPageCreatorFunc(
RID_SVXPAGE_NUMBERFORMAT );
-if ( fnCreatePage )
+if (fnCreatePage)
{
-VclPtr pTabPage = (*fnCreatePage)( get_content_area(),
);
-pTabPage->PageCreated(rSet);
-SetTabPage(pTabPage);
+TabPageParent pPageParent(get_content_area(), this);
+VclPtr xTabPage = (*fnCreatePage)(pPageParent, );
+xTabPage->PageCreated(rSet);
+SetTabPage(xTabPage);
}
}
diff --git a/chart2/source/controller/dialogs/dlg_NumberFormat.hxx
b/chart2/source/controller/dialogs/dlg_NumberFormat.hxx
index 1aff53582645..6bd79a00e837 100644
--- a/chart2/source/controller/dialogs/dlg_NumberFormat.hxx
+++ b/chart2/source/controller/dialogs/dlg_NumberFormat.hxx
@@ -21,16 +21,16 @@
#include
-namespace vcl { class Window; }
+namespace weld { class Window; }
class SfxItemSet;
namespace chart
{
-class NumberFormatDialog : public SfxSingleTabDialog
+class NumberFormatDialog : public SfxSingleTabDialogController
{
public:
-NumberFormatDialog(vcl::Window* pParent, SfxItemSet& rSet);
+NumberFormatDialog(weld::Window* pParent, SfxItemSet& rSet);
static SfxItemSet CreateEmptyItemSetForNumberFormatDialog( SfxItemPool&
rItemPool );
};
diff --git a/chart2/source/controller/dialogs/res_DataLabel.cxx
b/chart2/source/controller/dialogs/res_DataLabel.cxx
index 547f081e155c..95094b4b8d8a 100644
--- a/chart2/source/controller/dialogs/res_DataLabel.cxx
+++ b/chart2/source/controller/dialogs/res_DataLabel.cxx
@@ -85,7 +85,7 @@ void lcl_setBoolItemToCheckBox( const SfxItemSet& rInAttrs,
sal_uInt16 nWhichId,
}//end anonymous namespace
-DataLabelResources::DataLabelResources(VclBuilderContainer* pWindow,
vcl::Window* pParent, const SfxItemSet& rInAttrs )
+DataLabelResources::DataLabelResources(VclBuilderContainer* pWindow,
weld::Window* pParent, const SfxItemSet& rInAttrs )
:
m_pNumberFormatter(nullptr),
m_bNumberFormatMixedState(true),
@@ -204,12 +204,12 @@ IMPL_LINK( DataLabelResources, NumberFormatDialogHdl,
Button *, pButton, void )
aNumberSet.Put( SfxUInt32Item( SID_ATTR_NUMBERFORMAT_VALUE,
rnFormatKey ));
aNumberSet.Put( SfxBoolItem( SID_ATTR_NUMBERFORMAT_SOURCE,
rUseSourceFormat ));
-ScopedVclPtrInstance< NumberFormatDialog > aDlg(m_pWindow, aNumberSet);
+NumberFormatDialog aDlg(m_pWindow, aNumberSet);
if( bPercent )
-aDlg->SetText(
[Libreoffice-bugs] [Bug 120185] Calc - the Borders icon and Border tools (lines) are no longer black
https://bugs.documentfoundation.org/show_bug.cgi?id=120185 Ron changed: What|Removed |Added Summary|Calc - the Borders icon and |Calc - the Borders icon and |Border tools (lines) are no |Border tools (lines) are no |longer balck|longer black -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120185] New: Calc - the Borders icon and Border tools (lines) are no longer balck
https://bugs.documentfoundation.org/show_bug.cgi?id=120185 Bug ID: 120185 Summary: Calc - the Borders icon and Border tools (lines) are no longer balck Product: LibreOffice Version: 6.1.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rongraham1...@rogers.com Description: In Calc when you select the Borders icon to add lines to a cell or cells. The options show in a faint orange lines instead of Black. Likewise if you select Format Cells and select Borders. Very difficult to see. LO version 6.1.2 Actual Results: Please read Description above Expected Results: Expected to see Black lines in the Border toobar options Reproducible: Always User Profile Reset: No Additional Info: Version: 6.1.2.1 (x64) Build ID: 65905a128db06ba48db947242809d14d3f9a93fe CPU threads: 8; OS: Windows 10.0; UI render: default; Locale: en-CA (en_CA); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtk3gtkframe.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 7f5cc838f055c0b083cca1d90a5b2d00b5a44ad5 Author: Caolán McNamara AuthorDate: Fri Sep 28 14:27:27 2018 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 28 18:46:11 2018 +0200 listen to [leave|enter]-notify-event at event widget level rather than toplevel. This avoid the problem under wayland where with an initially maximized calc clicking in it will select all cells from 0,0 to the clicked cell until the mouse is released Change-Id: I138fe587c9cb7cfff0293847c00730593e3244e1 Reviewed-on: https://gerrit.libreoffice.org/61087 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx index 1953c055a39a..d957775cfc94 100644 --- a/vcl/unx/gtk3/gtk3gtkframe.cxx +++ b/vcl/unx/gtk3/gtk3gtkframe.cxx @@ -1028,6 +1028,9 @@ void GtkSalFrame::InitCommon() m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), "button-press-event", G_CALLBACK(signalButton), this )); m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), "motion-notify-event", G_CALLBACK(signalMotion), this )); m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), "button-release-event", G_CALLBACK(signalButton), this )); +m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), "leave-notify-event", G_CALLBACK(signalCrossing), this )); +m_aMouseSignalIds.push_back(g_signal_connect( G_OBJECT(pEventWidget), "enter-notify-event", G_CALLBACK(signalCrossing), this )); + //Drop Target Stuff gtk_drag_dest_set(GTK_WIDGET(pEventWidget), GtkDestDefaults(0), nullptr, 0, GdkDragAction(0)); @@ -1067,8 +1070,6 @@ void GtkSalFrame::InitCommon() g_signal_connect( G_OBJECT(m_pWindow), "key-release-event", G_CALLBACK(signalKey), this ); g_signal_connect( G_OBJECT(m_pWindow), "delete-event", G_CALLBACK(signalDelete), this ); g_signal_connect( G_OBJECT(m_pWindow), "window-state-event", G_CALLBACK(signalWindowState), this ); -g_signal_connect( G_OBJECT(m_pWindow), "leave-notify-event", G_CALLBACK(signalCrossing), this ); -g_signal_connect( G_OBJECT(m_pWindow), "enter-notify-event", G_CALLBACK(signalCrossing), this ); g_signal_connect( G_OBJECT(m_pWindow), "visibility-notify-event", G_CALLBACK(signalVisibility), this ); g_signal_connect( G_OBJECT(m_pWindow), "destroy", G_CALLBACK(signalDestroy), this ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/inc/DocumentRedlineManager.hxx |4
sw/source/core/inc/TextFrameIndex.hxx |6 ++
sw/source/core/inc/rootfrm.hxx|4
3 files changed, 14 insertions(+)
New commits:
commit 35aafd712b2c183a25721a3227f527a8fdf4df90
Author: Miklos Vajna
AuthorDate: Fri Sep 28 12:31:09 2018 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 28 18:41:50 2018 +0200
sw layout-level redline hiding: add more doxygen documentation
Thanks Michael Stahl for the conference talk that was the input for
these.
Change-Id: Ia48248f4739218ee7832559353aab06183a934d7
Reviewed-on: https://gerrit.libreoffice.org/61079
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/source/core/inc/DocumentRedlineManager.hxx
b/sw/source/core/inc/DocumentRedlineManager.hxx
index 518c7e601643..c25abf25d394 100644
--- a/sw/source/core/inc/DocumentRedlineManager.hxx
+++ b/sw/source/core/inc/DocumentRedlineManager.hxx
@@ -33,6 +33,10 @@ class DocumentRedlineManager : public IDocumentRedlineAccess
public:
DocumentRedlineManager( SwDoc& i_rSwdoc );
+/**
+ * Replaced by SwRootFrame::IsHideRedlines() (this is model-level redline
+ * hiding).
+ */
virtual RedlineFlags GetRedlineFlags() const override;
virtual void SetRedlineFlags_intern(/*[in]*/RedlineFlags eMode) override;
diff --git a/sw/source/core/inc/TextFrameIndex.hxx
b/sw/source/core/inc/TextFrameIndex.hxx
index 8c660ec80d07..d15fc7bf6691 100644
--- a/sw/source/core/inc/TextFrameIndex.hxx
+++ b/sw/source/core/inc/TextFrameIndex.hxx
@@ -16,6 +16,12 @@
#if 0
typedef o3tl::strong_int TextFrameIndex;
#else
+/**
+ * Denotes a character index in a text frame at a layout level, after extent
+ * mapping from a text node at a document model level.
+ *
+ * @see SwTextFrame::MapViewToModelPos().
+ */
typedef sal_Int32 TextFrameIndex;
#endif
diff --git a/sw/source/core/inc/rootfrm.hxx b/sw/source/core/inc/rootfrm.hxx
index 7824d4ff5eca..aee70da5029f 100644
--- a/sw/source/core/inc/rootfrm.hxx
+++ b/sw/source/core/inc/rootfrm.hxx
@@ -403,6 +403,10 @@ public:
void RemovePage( SwPageFrame **pDel, SwRemoveResult eResult );
+/**
+ * Replacement for sw::DocumentRedlineManager::GetRedlineFlags()
+ * (this is layout-level redline hiding).
+ */
bool IsHideRedlines() const { return mbHideRedlines; }
void SetHideRedlines(bool);
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/null
vcl/null/printerinfomanager.cxx | 20
1 file changed, 20 deletions(-)
New commits:
commit 1a35fd6fb42a02c73050a281fb7b00ac4a3d0379
Author: Caolán McNamara
AuthorDate: Fri Sep 28 15:00:39 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 17:51:41 2018 +0200
fix oss-fuzz build
Change-Id: Id8b33ac7b3988a8fef7bff3b03cfe9c1c167adc3
Reviewed-on: https://gerrit.libreoffice.org/61090
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/vcl/null/printerinfomanager.cxx b/vcl/null/printerinfomanager.cxx
index 3361988d4af5..cfdb6eb67fa2 100644
--- a/vcl/null/printerinfomanager.cxx
+++ b/vcl/null/printerinfomanager.cxx
@@ -90,26 +90,6 @@ const PrinterInfo& PrinterInfoManager::getPrinterInfo( const
OUString& /* rPrint
return aEmptyInfo;
}
-bool PrinterInfoManager::writePrinterConfig()
-{
-return false;
-}
-
-bool PrinterInfoManager::addPrinter( const OUString& /* rPrinterName */, const
OUString& /* rDriverName */ )
-{
-return false;
-}
-
-bool PrinterInfoManager::removePrinter( const OUString& /* rPrinterName */,
bool /* bCheckOnly */ )
-{
-return false;
-}
-
-bool PrinterInfoManager::setDefaultPrinter( const OUString& /* rPrinterName */
)
-{
-return false;
-}
-
bool PrinterInfoManager::checkFeatureToken( const OUString& /* rPrinterName
*/, const char* /* pToken */ ) const
{
(void) this;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120184] EDITING. Compare documents in Writer does not work correctly with changes into tables and some times on everything
https://bugs.documentfoundation.org/show_bug.cgi?id=120184 --- Comment #1 from Ismael Cedillo --- Created attachment 145252 --> https://bugs.documentfoundation.org/attachment.cgi?id=145252=edit documents to execute the bug confirmation -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120175] Breeze Dark icon theme is not detected as the preferred theme
https://bugs.documentfoundation.org/show_bug.cgi?id=120175 V Stuart Foote changed: What|Removed |Added CC||caol...@redhat.com, ||vstuart.fo...@utsa.edu --- Comment #1 from V Stuart Foote --- OK, so "BREEZE_DARK_ID" is set [1] to "breeze_dark" with the underscore. If it benefits the KDE 5 Plasma DE users, should be a 1 character change, why not? But then SIFR_DARK_ID also gets the underscore with our naming, as does the new KARASA_JAGA_ID theme. Any benefit to also change those for consistency of matching external DE when calling IconThemeSelector() going forward? =-ref-= [1] https://opengrok.libreoffice.org/xref/core/vcl/source/app/IconThemeInfo.cxx?a=true=23#23 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120158] It's imposible to paste special in Writer from Calc in Libreoffice 6.1.1 because the dialogue caption inform that's an unknown source
https://bugs.documentfoundation.org/show_bug.cgi?id=120158 --- Comment #4 from sol...@gmail.com --- Created attachment 145251 --> https://bugs.documentfoundation.org/attachment.cgi?id=145251=edit Image with the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120184] New: EDITING. Compare documents in Writer does not work correctly with changes into tables and some times on everything
https://bugs.documentfoundation.org/show_bug.cgi?id=120184 Bug ID: 120184 Summary: EDITING. Compare documents in Writer does not work correctly with changes into tables and some times on everything Product: LibreOffice Version: 6.1.2.1 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ismaelcmail-pa...@yahoo.com.mx Description: When compare documents to find changes into, and the documents have changes into tables, Writer shows as change all the table, but do not shows only the words o characters that changed, even if we have selected the option the changes by word or by character in Tools-->Options-->LibreOfficeDevWriter-->Comparison. This problem happens from 6.1 to 6.1.3 version and 6.2 Steps to Reproduce: 1.Open Writer 2.Open the final.odt file attached (slightly different from de original.odt doc) 3.Change to "By word" the Compare Documents option into Tools-->Options-->LibreofficeDevWriter-->Comparison menu. 4.Select Edit-->Track changes-->Compare Document 5.Select the original.odt file attached See the results for table changes Actual Results: All the text for the table is marked as a change, loosing the detail Expected Results: Mark only the words o characters with changes in the text contained into the table cells. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120158] It's imposible to paste special in Writer from Calc in Libreoffice 6.1.1 because the dialogue caption inform that's an unknown source
https://bugs.documentfoundation.org/show_bug.cgi?id=120158 --- Comment #3 from sol...@gmail.com --- I've found that this behaviour only happens when I put the language of user interface in spanish, when I put it in English the dialog "paste special" works well -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91985] FILEOPEN: Link external data to html file with in table prevent correct table load
https://bugs.documentfoundation.org/show_bug.cgi?id=91985 --- Comment #14 from Buovjaga --- (In reply to Jo Bobit from comment #11) > Created attachment 127678 [details] > screenshot LO 5.2.1.2 > > I tested with LO 5.2.1.2 Portable (see screenshot added) and the bug is > still there. > > I used Sheet->Link to External Data... pointed to the Example of HTML file > and selected automatic language detection, then HTML_all. > > I got the same result (missing Dat11 in the second table). I still repro with attachment 116626 Arch Linux 64-bit Version: 6.1.1.2 Build ID: 6.1.1-1 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded Arch Linux 64-bit Version: 6.2.0.0.alpha0+ Build ID: d357ea1d1ff95cb5ce2ee6b4828afa2484707256 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: threaded Built on 28 September 2018 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/docufld.hxx |2 +-
sw/source/core/fields/docufld.cxx |2 +-
sw/source/core/unocore/unofield.cxx |4 ++--
sw/source/filter/html/htmlfld.cxx |2 +-
sw/source/filter/html/htmlfldw.cxx |2 +-
sw/source/filter/ww8/ww8atr.cxx |2 +-
sw/source/filter/ww8/ww8par5.cxx|2 +-
sw/source/uibase/shells/textfld.cxx |2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit c46dfb8ba633ae79e8dfbedaaa7d4b5e406623f7
Author: Andrea Gelmini
AuthorDate: Sun Sep 23 00:09:51 2018 +0200
Commit: Julien Nabet
CommitDate: Fri Sep 28 17:06:35 2018 +0200
Fix DI_TITEL -> DI_TITLE
It passed "make check" on Linux.
Change-Id: I3239622286c07914f88727ffdbb0be8d2ca724ea
Reviewed-on: https://gerrit.libreoffice.org/61084
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/sw/inc/docufld.hxx b/sw/inc/docufld.hxx
index 5a6545f712b6..043e55d1e5c0 100644
--- a/sw/inc/docufld.hxx
+++ b/sw/inc/docufld.hxx
@@ -62,7 +62,7 @@ namespace nsSwDocInfoSubType
in filter/html/htmlfld.cxx, so make sure that DI_SUBTYPE_END
really is the end, and is at least 4 less than DI_SUB_*! */
const SwDocInfoSubType DI_SUBTYPE_BEGIN = 0;
-const SwDocInfoSubType DI_TITEL = DI_SUBTYPE_BEGIN;
+const SwDocInfoSubType DI_TITLE = DI_SUBTYPE_BEGIN;
const SwDocInfoSubType DI_THEMA = 1;
const SwDocInfoSubType DI_KEYS = 2;
const SwDocInfoSubType DI_COMMENT = 3;
diff --git a/sw/source/core/fields/docufld.cxx
b/sw/source/core/fields/docufld.cxx
index 19a5c71bab24..0281c74a41bd 100644
--- a/sw/source/core/fields/docufld.cxx
+++ b/sw/source/core/fields/docufld.cxx
@@ -876,7 +876,7 @@ OUString SwDocInfoFieldType::Expand( sal_uInt16 nSub,
sal_uInt32 nFormat,
OUString aStr;
switch(nSub)
{
-case DI_TITEL: aStr = xDocProps->getTitle(); break;
+case DI_TITLE: aStr = xDocProps->getTitle(); break;
case DI_THEMA: aStr = xDocProps->getSubject(); break;
case DI_KEYS: aStr = ::comphelper::string::convertCommaSeparated(
xDocProps->getKeywords());
diff --git a/sw/source/core/unocore/unofield.cxx
b/sw/source/core/unocore/unofield.cxx
index b6335a7b6a36..dbebe8c4aaa7 100644
--- a/sw/source/core/unocore/unofield.cxx
+++ b/sw/source/core/unocore/unofield.cxx
@@ -125,7 +125,7 @@ static const sal_uInt16 aDocInfoSubTypeFromService[] =
DI_PRINT | DI_SUB_DATE, //PROPERTY_MAP_FLDTYP_DOCINFO_PRINT_DATE_TIME
DI_KEYS,//PROPERTY_MAP_FLDTYP_DOCINFO_KEY_WORDS
DI_THEMA, //PROPERTY_MAP_FLDTYP_DOCINFO_SUBJECT
-DI_TITEL, //PROPERTY_MAP_FLDTYP_DOCINFO_TITLE
+DI_TITLE, //PROPERTY_MAP_FLDTYP_DOCINFO_TITLE
DI_DOCNO//PROPERTY_MAP_FLDTYP_DOCINFO_REVISION
};
@@ -238,7 +238,7 @@ static SwServiceType lcl_GetServiceForField( const SwField&
rField )
case DI_COMMENT:nSrvId =
SwServiceType::FieldTypeDocInfoDescription;break;
case DI_KEYS: nSrvId =
SwServiceType::FieldTypeDocInfoKeywords;break;
case DI_THEMA: nSrvId = SwServiceType::FieldTypeDocInfoSubject;
break;
-case DI_TITEL: nSrvId = SwServiceType::FieldTypeDocInfoTitle;
break;
+case DI_TITLE: nSrvId = SwServiceType::FieldTypeDocInfoTitle;
break;
case DI_DOCNO: nSrvId = SwServiceType::FieldTypeDocInfoRevision;
break;
case DI_CUSTOM: nSrvId = SwServiceType::FieldTypeDocInfoCustom;
break;
}
diff --git a/sw/source/filter/html/htmlfld.cxx
b/sw/source/filter/html/htmlfld.cxx
index 53a7b1b435ab..c05dfc8bce74 100644
--- a/sw/source/filter/html/htmlfld.cxx
+++ b/sw/source/filter/html/htmlfld.cxx
@@ -147,7 +147,7 @@ static HTMLOptionEnum
aHTMLPageNumFieldSubTable[] =
static HTMLOptionEnum aHTMLDocInfoFieldSubTable[] =
{
-{ OOO_STRING_SW_HTML_FS_title, DI_TITEL },
+{ OOO_STRING_SW_HTML_FS_title, DI_TITLE },
{ OOO_STRING_SW_HTML_FS_theme, DI_THEMA },
{ OOO_STRING_SW_HTML_FS_keys,DI_KEYS },
{ OOO_STRING_SW_HTML_FS_comment, DI_COMMENT },
diff --git a/sw/source/filter/html/htmlfldw.cxx
b/sw/source/filter/html/htmlfldw.cxx
index dd8bd381f762..e9ee2209e15d 100644
--- a/sw/source/filter/html/htmlfldw.cxx
+++ b/sw/source/filter/html/htmlfldw.cxx
@@ -167,7 +167,7 @@ static Writer& OutHTML_SwField( Writer& rWrt, const
SwField* pField,
switch( nSubType )
{
-case DI_TITEL: pSubStr = OOO_STRING_SW_HTML_FS_title;
break;
+case DI_TITLE: pSubStr = OOO_STRING_SW_HTML_FS_title;
break;
case DI_THEMA: pSubStr = OOO_STRING_SW_HTML_FS_theme;
break;
case DI_KEYS: pSubStr = OOO_STRING_SW_HTML_FS_keys;
break;
case DI_COMMENT:pSubStr
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/factory/dlgfact.cxx |4 ++--
cui/source/inc/connect.hxx |6 +++---
cui/source/tabpages/connect.cxx | 16
cui/uiconfig/ui/connectortabpage.ui |2 +-
4 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 64ed833ccad5c692f4d92259c546bc22a9f061e5
Author: Caolán McNamara
AuthorDate: Fri Sep 28 11:27:11 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 16:57:24 2018 +0200
weld SvxConnectionDialog
Change-Id: Id240f3cc62775888d23634a203ae8e2de07f7caf
Reviewed-on: https://gerrit.libreoffice.org/61082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index e48e1f87d11c..125e5cd73d89 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -1370,8 +1370,8 @@ VclPtr
AbstractDialogFactory_Impl::CreateSfxDialog(vcl::Windo
return
VclPtr::Create(o3tl::make_unique(pParent
? pParent->GetFrameWeld() : nullptr, rAttr, pView));
}
case RID_SVXPAGE_CONNECTION :
-pDlg = VclPtr::Create( pParent, rAttr, pView
);
-break;
+return
VclPtr::Create(o3tl::make_unique(pParent
? pParent->GetFrameWeld() : nullptr, rAttr, pView));
+
case RID_SFXPAGE_DBREGISTER :
pDlg = VclPtr::Create( pParent, rAttr
);
break;
diff --git a/cui/source/inc/connect.hxx b/cui/source/inc/connect.hxx
index a7e499743275..50caaf5b370c 100644
--- a/cui/source/inc/connect.hxx
+++ b/cui/source/inc/connect.hxx
@@ -75,11 +75,11 @@ public:
/* Derived from SfxSingleTabDialog, in order to be informed about
virtual methods by the control. */
-class SvxConnectionDialog : public SfxSingleTabDialog
+class SvxConnectionDialog : public SfxSingleTabDialogController
{
public:
-SvxConnectionDialog( vcl::Window* pParent, const SfxItemSet& rAttr,
- const SdrView* pView );
+SvxConnectionDialog(weld::Window* pParent, const SfxItemSet& rAttr,
+const SdrView* pView);
};
#endif // INCLUDED_CUI_SOURCE_INC_CONNECT_HXX
diff --git a/cui/source/tabpages/connect.cxx b/cui/source/tabpages/connect.cxx
index cffd7806beeb..7e9b9385f282 100644
--- a/cui/source/tabpages/connect.cxx
+++ b/cui/source/tabpages/connect.cxx
@@ -49,17 +49,17 @@ const sal_uInt16 SvxConnectionPage::pRanges[] =
|*
\/
-SvxConnectionDialog::SvxConnectionDialog( vcl::Window* pParent, const
SfxItemSet& rInAttrs,
-const SdrView* pSdrView )
-: SfxSingleTabDialog(pParent, rInAttrs)
+SvxConnectionDialog::SvxConnectionDialog(weld::Window* pParent, const
SfxItemSet& rInAttrs, const SdrView* pSdrView)
+: SfxSingleTabDialogController(pParent, rInAttrs)
{
-VclPtrInstance _pPage( get_content_area(), rInAttrs );
+TabPageParent pPageParent(get_content_area(), this);
+VclPtrInstance pPage(pPageParent, rInAttrs);
-_pPage->SetView( pSdrView );
-_pPage->Construct();
+pPage->SetView(pSdrView);
+pPage->Construct();
-SetTabPage( _pPage );
-SetText(CuiResId( RID_SVXSTR_CONNECTOR ));
+SetTabPage(pPage);
+m_xDialog->set_title(CuiResId( RID_SVXSTR_CONNECTOR));
}
/*
diff --git a/cui/uiconfig/ui/connectortabpage.ui
b/cui/uiconfig/ui/connectortabpage.ui
index 7fab7a025659..25b0beb197d8 100644
--- a/cui/uiconfig/ui/connectortabpage.ui
+++ b/cui/uiconfig/ui/connectortabpage.ui
@@ -73,7 +73,7 @@
True
-True
+False
False
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source cui/uiconfig extras/source include/svx svx/source
cui/source/inc/connect.hxx | 43 +--
cui/source/tabpages/connect.cxx| 321 +++--
cui/uiconfig/ui/connectortabpage.ui| 146 +++
extras/source/glade/libreoffice-catalog.xml.in |3
include/svx/connctrl.hxx | 17 -
svx/source/dialog/connctrl.cxx | 61 +---
6 files changed, 293 insertions(+), 298 deletions(-)
New commits:
commit 3120c9722f5c7553c78d638c3fd1f976f76bc9e9
Author: Caolán McNamara
AuthorDate: Fri Sep 28 10:30:11 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 16:57:00 2018 +0200
weld SvxConnectionPage
Change-Id: I155f0c037f0d1879cec4d0b511d60a276466b1bb
Reviewed-on: https://gerrit.libreoffice.org/61077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/inc/connect.hxx b/cui/source/inc/connect.hxx
index 5c034d2104af..a7e499743275 100644
--- a/cui/source/inc/connect.hxx
+++ b/cui/source/inc/connect.hxx
@@ -21,10 +21,8 @@
#include
#include
-#include
-#include
-#include
-#include
+#include
+#include
#include
class SdrView;
@@ -34,36 +32,33 @@ class SvxConnectionPage : public SfxTabPage
{
private:
static const sal_uInt16 pRanges[];
-VclPtr m_pLbType;
-
-VclPtr m_pFtLine1;
-VclPtr m_pMtrFldLine1;
-VclPtr m_pFtLine2;
-VclPtr m_pMtrFldLine2;
-VclPtr m_pFtLine3;
-VclPtr m_pMtrFldLine3;
-
-VclPtr m_pMtrFldHorz1;
-VclPtr m_pMtrFldVert1;
-VclPtr m_pMtrFldHorz2;
-VclPtr m_pMtrFldVert2;
-
-VclPtr m_pCtlPreview;
-
const SfxItemSet& rOutAttrs;
SfxItemSet aAttrSet;
const SdrView* pView;
MapUnit eUnit;
+SvxXConnectionPreview m_aCtlPreview;
+std::unique_ptr m_xLbType;
+std::unique_ptr m_xFtLine1;
+std::unique_ptr m_xMtrFldLine1;
+std::unique_ptr m_xFtLine2;
+std::unique_ptr m_xMtrFldLine2;
+std::unique_ptr m_xFtLine3;
+std::unique_ptr m_xMtrFldLine3;
+std::unique_ptr m_xMtrFldHorz1;
+std::unique_ptr m_xMtrFldVert1;
+std::unique_ptr m_xMtrFldHorz2;
+std::unique_ptr m_xMtrFldVert2;
+std::unique_ptr m_xCtlPreview;
+
voidFillTypeLB();
-DECL_LINK( ChangeAttrEditHdl_Impl, Edit&, void );
-DECL_LINK( ChangeAttrListBoxHdl_Impl, ListBox&, void );
-void ChangeAttrHdl_Impl(void const *);
+DECL_LINK(ChangeAttrEditHdl_Impl, weld::MetricSpinButton&, void);
+DECL_LINK(ChangeAttrListBoxHdl_Impl, weld::ComboBox&, void);
public:
-SvxConnectionPage( vcl::Window* pWindow, const SfxItemSet& rInAttrs );
+SvxConnectionPage(TabPageParent pWindow, const SfxItemSet& rInAttrs);
virtual ~SvxConnectionPage() override;
virtual void dispose() override;
diff --git a/cui/source/tabpages/connect.cxx b/cui/source/tabpages/connect.cxx
index 2820e383434c..cffd7806beeb 100644
--- a/cui/source/tabpages/connect.cxx
+++ b/cui/source/tabpages/connect.cxx
@@ -68,29 +68,24 @@ SvxConnectionDialog::SvxConnectionDialog( vcl::Window*
pParent, const SfxItemSet
|*
\/
-SvxConnectionPage::SvxConnectionPage( vcl::Window* pWindow, const SfxItemSet&
rInAttrs )
-: SfxTabPage(pWindow ,"ConnectorTabPage" ,"cui/ui/connectortabpage.ui"
-,)
+SvxConnectionPage::SvxConnectionPage(TabPageParent pWindow, const SfxItemSet&
rInAttrs)
+: SfxTabPage(pWindow, "cui/ui/connectortabpage.ui", "ConnectorTabPage",
)
, rOutAttrs(rInAttrs)
, aAttrSet(*rInAttrs.GetPool())
, pView(nullptr)
+, m_xLbType(m_xBuilder->weld_combo_box("LB_TYPE"))
+, m_xFtLine1(m_xBuilder->weld_label("FT_LINE_1"))
+, m_xMtrFldLine1(m_xBuilder->weld_metric_spin_button("MTR_FLD_LINE_1",
FUNIT_CM))
+, m_xFtLine2(m_xBuilder->weld_label("FT_LINE_2"))
+, m_xMtrFldLine2(m_xBuilder->weld_metric_spin_button("MTR_FLD_LINE_2",
FUNIT_CM))
+, m_xFtLine3(m_xBuilder->weld_label("FT_LINE_3"))
+, m_xMtrFldLine3(m_xBuilder->weld_metric_spin_button("MTR_FLD_LINE_3",
FUNIT_CM))
+, m_xMtrFldHorz1(m_xBuilder->weld_metric_spin_button("MTR_FLD_HORZ_1",
FUNIT_MM))
+, m_xMtrFldVert1(m_xBuilder->weld_metric_spin_button("MTR_FLD_VERT_1",
FUNIT_MM))
+, m_xMtrFldHorz2(m_xBuilder->weld_metric_spin_button("MTR_FLD_HORZ_2",
FUNIT_MM))
+, m_xMtrFldVert2(m_xBuilder->weld_metric_spin_button("MTR_FLD_VERT_2",
FUNIT_MM))
+, m_xCtlPreview(new weld::CustomWeld(*m_xBuilder, "CTL_PREVIEW",
m_aCtlPreview))
{
-get(m_pLbType,"LB_TYPE");
-
-get(m_pFtLine1,"FT_LINE_1");
-get(m_pMtrFldLine1,"MTR_FLD_LINE_1");
-get(m_pFtLine2,"FT_LINE_2");
-get(m_pMtrFldLine2,"MTR_FLD_LINE_2");
-get(m_pFtLine3,"FT_LINE_3");
-get(m_pMtrFldLine3,"MTR_FLD_LINE_3");
-
-get(m_pMtrFldHorz1,"MTR_FLD_HORZ_1");
-
[Libreoffice-bugs] [Bug 120029] Bold text in dialogues not displaying
https://bugs.documentfoundation.org/show_bug.cgi?id=120029 --- Comment #9 from Alex Thurgood --- @Gerhard : try turning off OpenGL support and restarting LO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdpdf.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 45c753aff6468b9761e68bc0bf48ab161cd0cba6
Author: Miklos Vajna
AuthorDate: Fri Sep 28 12:30:01 2018 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 28 16:21:04 2018 +0200
svx: pdfium's FPDFImageObj_GetBitmapBgra() is not needed after all
Given that we do check for the different formats just below anyway.
Thanks Ashod Nakashian for pointing this out!
Change-Id: Ie481f6f3fa66ee182668bd6ea7171da2a04cca9d
Reviewed-on: https://gerrit.libreoffice.org/61078
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/svx/source/svdraw/svdpdf.cxx b/svx/source/svdraw/svdpdf.cxx
index d80932c92076..8f859672c336 100644
--- a/svx/source/svdraw/svdpdf.cxx
+++ b/svx/source/svdraw/svdpdf.cxx
@@ -986,7 +986,7 @@ void ImpSdrPdfImport::MapScaling()
void ImpSdrPdfImport::ImportImage(FPDF_PAGEOBJECT pPageObject, int
/*nPageObjectIndex*/)
{
std::unique_ptr::type, FPDFBitmapDeleter>
bitmap(
-FPDFImageObj_GetBitmapBgra(pPageObject));
+FPDFImageObj_GetBitmap(pPageObject));
if (!bitmap)
{
SAL_WARN("sd.filter", "Failed to get IMAGE");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120183] Selecting "color" on the background page property in Draw immediately crashes Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=120183 Drew Jensen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Drew Jensen --- *** This bug has been marked as a duplicate of bug 120069 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Mangler info om af afmelde mailingliste
Den 28-09-2018 kl. 11:44 skrev Christian Lohmaier: This is wrong list to deal with unsubscribe problems I assume you want to be unsubscribed from one of the Danish lists? On Thu, Sep 27, 2018 at 3:48 PM scootergrisen wrote: Nu prøvede at jeg sende en e-mail til dansk+unsubscr...@da.libreoffice.org og det ser så ud til at være sådan man afmelder men det står der ikke. If you want to unsubscribe, you need to send mail to the dansk+unsubscr...@da.libreoffice.org address. The list then will send a mail asking you to confirm the request to which you need to reply to. Use the email-address you're subscribed with. If the instructions on https://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ don't work, send a mail to postmas...@documentfoundation.org ciao Christiian Yes i sent it to the wrong e-mail address. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 120182] Modify style (button and combo)not available for last in the current list (writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=120182 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from Dieter Praas --- Set to NEEDINFO. Please change it back to UNCONFIRMED once you're able to reproduce it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number in column view
https://bugs.documentfoundation.org/show_bug.cgi?id=120153
Andy M changed:
What|Removed |Added
Summary|{macOS} Finder shows|{macOS} Finder shows
|incorrect version number in |incorrect version number in
|columnar view |column view
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number in columnar view
https://bugs.documentfoundation.org/show_bug.cgi?id=120153
Alex Thurgood changed:
What|Removed |Added
Summary|{macOS} Finder shows|{macOS} Finder shows
|incorrect version number|incorrect version number in
||columnar view
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number
https://bugs.documentfoundation.org/show_bug.cgi?id=120153 Alex Thurgood changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Alex Thurgood --- I have a vague recollection of this having been brought up before with cloph, but not sure when... @cloph : any opinion ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number
https://bugs.documentfoundation.org/show_bug.cgi?id=120153 --- Comment #5 from Alex Thurgood --- @Andy - thanks. If I switch on column view, I see : Version : 6.1.2001 is that what you mean ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/source sc/uiconfig
sc/inc/scabstdlg.hxx |7
sc/source/ui/attrdlg/scdlgfact.cxx | 22 --
sc/source/ui/attrdlg/scdlgfact.hxx |7
sc/source/ui/docshell/docsh4.cxx |3
sc/source/ui/inc/styledlg.hxx | 21 --
sc/source/ui/inc/tphf.hxx |2
sc/source/ui/pagedlg/tphf.cxx |2
sc/source/ui/styleui/styledlg.cxx | 154 ++---
sc/source/ui/view/formatsh.cxx | 25 --
sc/uiconfig/scalc/ui/pagetemplatedialog.ui | 201 +-
sc/uiconfig/scalc/ui/paratemplatedialog.ui | 259 ++---
11 files changed, 513 insertions(+), 190 deletions(-)
New commits:
commit b2e7956c6ce350eeaa1e4ea79909afd8480ee242
Author: Caolán McNamara
AuthorDate: Thu Sep 27 16:25:51 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 15:36:15 2018 +0200
weld ScStyleDlg
Change-Id: I67e6a6cd1f0b018012c3a373c856494c4fc02979
Reviewed-on: https://gerrit.libreoffice.org/61048
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index b7910d594243..2c0c80c8ee2f 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -523,10 +523,9 @@ public:
const OUString&
rPageStyle,
sal_uInt16 nResId
) = 0;
-virtual VclPtr CreateScStyleDlg( vcl::Window*
pParent,
-SfxStyleSheetBase&
rStyleBase,
-sal_uInt16
nRscId,
-int nId) = 0;
+virtual VclPtr CreateScStyleDlg(weld::Window*
pParent,
+ SfxStyleSheetBase&
rStyleBase,
+ bool bPage /*true :
page, false: para*/) = 0;
virtual VclPtr CreateScSubTotalDlg( vcl::Window*
pParent,
const SfxItemSet*
pArgSet ) = 0;
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx
b/sc/source/ui/attrdlg/scdlgfact.cxx
index 662b78b09c1a..a23634a41d7d 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -1014,25 +1014,11 @@ VclPtr
ScAbstractDialogFactory_Impl::CreateScHFEditDlg( vc
return pDlg ? VclPtr::Create( pDlg ) : nullptr;
}
-VclPtr ScAbstractDialogFactory_Impl::CreateScStyleDlg(
vcl::Window* pParent,
-
SfxStyleSheetBase& rStyleBase,
-
sal_uInt16 nRscId,
-int
nId)
+VclPtr
ScAbstractDialogFactory_Impl::CreateScStyleDlg(weld::Window* pParent,
+
SfxStyleSheetBase& rStyleBase,
+
bool bPage)
{
-VclPtr pDlg;
-switch ( nId )
-{
-case RID_SCDLG_STYLES_PAGE :
-case RID_SCDLG_STYLES_PAR :
-pDlg = VclPtr::Create( pParent, rStyleBase, nRscId );
-break;
-default:
-break;
-}
-
-if ( pDlg )
-return VclPtr::Create( pDlg );
-return nullptr;
+return
VclPtr::Create(o3tl::make_unique(pParent,
rStyleBase, bPage));
}
VclPtr
ScAbstractDialogFactory_Impl::CreateScSubTotalDlg(vcl::Window* pParent, const
SfxItemSet* pArgSet)
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx
b/sc/source/ui/attrdlg/scdlgfact.hxx
index 3ffc5bc6b367..797d6deaf794 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -671,10 +671,9 @@ public:
const OUString&
rPageStyle,
sal_uInt16 nResId
) override;
-virtual VclPtr CreateScStyleDlg( vcl::Window*
pParent,
-SfxStyleSheetBase&
rStyleBase,
-sal_uInt16
nRscId,
-int nId) override;
+virtual VclPtr CreateScStyleDlg(weld::Window*
pParent,
+ SfxStyleSheetBase&
rStyleBase,
+ bool bPage) override;
virtual VclPtr CreateScSubTotalDlg( vcl::Window*
pParent,
const SfxItemSet*
pArgSet ) override;
diff --git a/sc/source/ui/docshell/docsh4.cxx
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/fontlb.hxx | 38 --
svx/source/dialog/fontlb.cxx | 62 ---
2 files changed, 100 deletions(-)
New commits:
commit 3833b8e8fba49b91259cb52ee6181ce7a602c1e7
Author: Caolán McNamara
AuthorDate: Wed Sep 26 10:53:14 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 15:35:46 2018 +0200
drop now unused SvxFontListBox
Change-Id: I1ad6c5b98d7bd75c42e14177c417af6ad4ebbeda
Reviewed-on: https://gerrit.libreoffice.org/61016
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/svx/fontlb.hxx b/include/svx/fontlb.hxx
index d905cb861867..fe9c3b3ce19e 100644
--- a/include/svx/fontlb.hxx
+++ b/include/svx/fontlb.hxx
@@ -51,44 +51,6 @@ public:
const SvViewDataEntry* pView, const SvTreeListEntry&
rEntry) override;
};
-
-/** A list box supporting formatted string entries. */
-class SAL_WARN_UNUSED SVX_DLLPUBLIC SvxFontListBox : public SvTabListBox
-{
-private:
-// The following members are used to store additional parameters for
InitEntry().
-vcl::Font maEntryFont;/// Current entry font used in
InitEntry().
-const Color*mpEntryColor; /// Current entry color used
in InitEntry().
-boolmbUseFont; /// true = Use
maEntryFont/mpEntryColor in InitEntry().
-
-public:
-SvxFontListBox(vcl::Window* pParent, WinBits nStyle);
-
-/** Inserts a list entry and sets the font used for this entry.
-@param pColor The font color. NULL = use default listbox text color.
*/
-voidInsertFontEntry(
-const OUString& rString, const vcl::Font&
rFont, const Color* pColor = nullptr );
-
-/** Selects an entry specified by its position in the list box. */
-voidSelectEntryPos( sal_uLong nPos );
-/** Removes a selection. */
-voidSetNoSelection();
-
-/** Returns the position of the entry currently selected or
TREELIST_APPEND.
-*/
-sal_uLong GetSelectedEntryPos() const;
-
-protected:
-/** Initializes a new SvLBoxFontString entry.
-@descr Uses current value of maEntryFont to set the entry font (if
mbUseFont is true). */
-virtual voidInitEntry(
-SvTreeListEntry* pEntry,
-const OUString& rEntryText,
-const Image& rCollImg,
-const Image& rExpImg,
-SvLBoxButtonKind eButtonKind) override;
-};
-
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/dialog/fontlb.cxx b/svx/source/dialog/fontlb.cxx
index d3aeb9b31b0f..497e2f70f5f4 100644
--- a/svx/source/dialog/fontlb.cxx
+++ b/svx/source/dialog/fontlb.cxx
@@ -76,66 +76,4 @@ void SvLBoxFontString::InitViewData( SvTreeListBox* pView,
SvTreeListEntry* pEnt
pView->Control::SetFont( aOldFont );
}
-
-SvxFontListBox::SvxFontListBox(vcl::Window* pParent, WinBits nStyle)
-: SvTabListBox(pParent, nStyle)
-, mpEntryColor(nullptr)
-, mbUseFont(false)
-{
-vcl::Font aStdFont(GetFont()); // Used for entries without specific font.
-aStdFont.SetTransparent(true);
-maEntryFont = aStdFont;
-}
-
-void SvxFontListBox::InsertFontEntry( const OUString& rString, const
vcl::Font& rFont, const Color* pColor )
-{
-mbUseFont = true; // InitEntry() will use maEntryFont
-maEntryFont = rFont;// font to use in InitEntry() over
InsertEntry()
-mpEntryColor = pColor; // color to use in InitEntry() over
InsertEntry()
-InsertEntry( rString );
-mbUseFont = false;
-}
-
-void SvxFontListBox::SelectEntryPos( sal_uLong nPos )
-{
-SvTreeListEntry* pEntry = GetEntry( nPos );
-if( pEntry )
-{
-Select( pEntry );
-ShowEntry( pEntry );
-}
-}
-
-void SvxFontListBox::SetNoSelection()
-{
-SelectAll( false );
-}
-
-sal_uLong SvxFontListBox::GetSelectedEntryPos() const
-{
-SvTreeListEntry* pSvLBoxEntry = FirstSelected();
-return pSvLBoxEntry ? GetModel()->GetAbsPos( pSvLBoxEntry ) :
TREELIST_ENTRY_NOTFOUND;
-}
-
-void SvxFontListBox::InitEntry(
-SvTreeListEntry* pEntry, const OUString& rEntryText,
-const Image& rCollImg, const Image& rExpImg,
-SvLBoxButtonKind eButtonKind)
-{
-if( mbUseFont )
-{
-if( nTreeFlags & SvTreeFlags::CHKBTN )
-pEntry->AddItem(o3tl::make_unique(
-eButtonKind, pCheckButtonData));
-pEntry->AddItem(o3tl::make_unique(
-rCollImg, rExpImg, true));
-pEntry->AddItem(o3tl::make_unique(
-rEntryText, maEntryFont, mpEntryColor));
-}
-else
-SvTreeListBox::InitEntry( pEntry,
[Libreoffice-commits] core.git: cui/source include/svx sc/inc sc/qa sc/source sc/uiconfig svx/source
cui/source/inc/numfmt.hxx |1
cui/source/tabpages/numfmt.cxx|9 -
include/svx/svxids.hrc|2
sc/inc/scabstdlg.hxx |4
sc/qa/unit/screenshots/screenshots.cxx|4
sc/source/ui/attrdlg/attrdlg.cxx | 29 +--
sc/source/ui/attrdlg/scdlgfact.cxx| 10 -
sc/source/ui/attrdlg/scdlgfact.hxx|7
sc/source/ui/inc/attrdlg.hxx | 17 --
sc/source/ui/view/tabvwsha.cxx| 28 +--
sc/uiconfig/scalc/ui/formatcellsdialog.ui | 229 --
svx/source/dialog/fontlb.cxx |2
12 files changed, 262 insertions(+), 80 deletions(-)
New commits:
commit 3c11aa745cc78f1bde4efacccb22fa818df825c7
Author: Caolán McNamara
AuthorDate: Tue Sep 25 12:30:21 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 15:35:22 2018 +0200
weld ScAttrDlg
Change-Id: I11eb9001604a1997a8bfa80a144306ddcb913d93
Reviewed-on: https://gerrit.libreoffice.org/61011
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/inc/numfmt.hxx b/cui/source/inc/numfmt.hxx
index 6fb600fbc41c..70b2806e5c61 100644
--- a/cui/source/inc/numfmt.hxx
+++ b/cui/source/inc/numfmt.hxx
@@ -84,7 +84,6 @@ private:
std::unique_ptrpNumItem;
std::unique_ptr pNumFmtShell;
sal_uLong nInitFormat;
-Link fnOkHdl;
boolbNumItemFlag; ///< for handling with DocShell
boolbOneAreaFlag;
diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx
index 2dd0e9824301..4257799ae311 100644
--- a/cui/source/tabpages/numfmt.cxx
+++ b/cui/source/tabpages/numfmt.cxx
@@ -1126,10 +1126,8 @@ IMPL_LINK(SvxNumberFormatTabPage, DoubleClickHdl_Impl,
weld::TreeView&, rLb, voi
{
SelFormatHdl_Impl();
-if ( fnOkHdl.IsSet() )
-{ // temporary solution, should be offered by SfxTabPage
-fnOkHdl.Call( nullptr );
-}
+if (SfxTabDialogController* pController = GetDialogController())
+pController->getDialog()->response(RET_OK);
else
{
SfxSingleTabDialog* pParent =
dynamic_cast(GetParentDialog());
@@ -1734,11 +1732,8 @@ void
SvxNumberFormatTabPage::AddAutomaticLanguage_Impl(LanguageType eAutoLang, b
void SvxNumberFormatTabPage::PageCreated(const SfxAllItemSet& aSet)
{
const SvxNumberInfoItem* pNumberInfoItem =
aSet.GetItem(SID_ATTR_NUMBERFORMAT_INFO, false);
-const SfxLinkItem* pLinkItem = aSet.GetItem(SID_LINK_TYPE,
false);
if (pNumberInfoItem && !pNumItem)
pNumItem.reset(
static_cast(pNumberInfoItem->Clone()) );
-if (pLinkItem)
-fnOkHdl = pLinkItem->GetValue();
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/svx/svxids.hrc b/include/svx/svxids.hrc
index e3e857637bed..54cab86e69da 100644
--- a/include/svx/svxids.hrc
+++ b/include/svx/svxids.hrc
@@ -817,7 +817,7 @@ class SfxStringItem;
#define SID_FLAG_TYPE ( SID_SVX_START + 1034
)
#define SID_SWMODE_TYPE ( SID_SVX_START + 1035
)
#define SID_DISABLE_CTL ( SID_SVX_START + 1036
)
-#define SID_LINK_TYPE ( SID_SVX_START + 1037
)
+//FREE
#define SID_ENUM_PAGE_MODE ( SID_SVX_START + 1038
)
#define SID_PAPER_START ( SID_SVX_START + 1039
)
#define SID_PAPER_END ( SID_SVX_START + 1040
)
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 1e9ab755223e..b7910d594243 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -515,8 +515,8 @@ public:
bool
bOnlyDbtoolsEncodings,
bool
bImport = true ) = 0;
-virtual VclPtr CreateScAttrDlg( vcl::Window*
pParent,
-const SfxItemSet*
pCellAttrs ) = 0;
+virtual VclPtr CreateScAttrDlg(weld::Window* pParent,
+const SfxItemSet*
pCellAttrs) = 0;
virtual VclPtr CreateScHFEditDlg(vcl::Window*
pParent,
const SfxItemSet&
rCoreSet,
diff --git a/sc/qa/unit/screenshots/screenshots.cxx
b/sc/qa/unit/screenshots/screenshots.cxx
index 7b9a2d8cc2ff..5b137437c0f2 100644
--- a/sc/qa/unit/screenshots/screenshots.cxx
+++ b/sc/qa/unit/screenshots/screenshots.cxx
@@ -268,11 +268,9 @@ VclPtr
ScScreenshotTest::createDialogByID(sal_uInt32 nID)
mpItemSet->MergeRange(SID_ATTR_NUMBERFORMAT_INFO,
SID_ATTR_NUMBERFORMAT_INFO);
mpItemSet->Put(*pNumberInfoItem);
-pReturnDialog =
[Libreoffice-bugs] [Bug 120183] New: Selecting "color" on the background page property in Draw immediately crashes Draw.
https://bugs.documentfoundation.org/show_bug.cgi?id=120183 Bug ID: 120183 Summary: Selecting "color" on the background page property in Draw immediately crashes Draw. Product: LibreOffice Version: 6.1.2.1 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mwtjunkm...@gmail.com Description: Selecting "color" on the background page property in Draw immediately crashes Draw. Steps to Reproduce: 1.Open Draw 2.Select "Color" for the background page property. Actual Results: Draw crashes. Expected Results: Draw should not crash. Reproducible: Always User Profile Reset: No Additional Info: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: uitest/loginterpreter.py
uitest/loginterpreter.py |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit a98058199410bdb183acd0ec5e7899ea4baf6c5a Author: Markus Mohrhard AuthorDate: Fri Sep 28 15:17:56 2018 +0200 Commit: Markus Mohrhard CommitDate: Fri Sep 28 15:32:44 2018 +0200 make the loginterpreter executable Change-Id: I9dcb562f9309c75a2d1719f1ad4fe6b5a4c23385 diff --git a/uitest/loginterpreter.py b/uitest/loginterpreter.py old mode 100644 new mode 100755 index 770beb966064..e84d9a0ed7e1 --- a/uitest/loginterpreter.py +++ b/uitest/loginterpreter.py @@ -1,3 +1,4 @@ +#!/usr/bin/env python3 # -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*- # # This file is part of the LibreOffice project. @@ -205,4 +206,4 @@ def main(): if __name__ == '__main__': main() -# vim: set shiftwidth=4 softtabstop=4 expandtab: \ No newline at end of file +# vim: set shiftwidth=4 softtabstop=4 expandtab: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: formula/source include/formula
formula/source/core/api/FormulaCompiler.cxx |3 +-- include/formula/compiler.hxx|4 ++-- include/formula/opcode.hxx |4 3 files changed, 3 insertions(+), 8 deletions(-) New commits: commit 14729a8aadd41f4acd47046c2ed5b58a99c473c2 Author: Eike Rathke AuthorDate: Fri Sep 28 11:00:27 2018 +0200 Commit: Eike Rathke CommitDate: Fri Sep 28 15:20:34 2018 +0200 Remove unused ocIndirectXL and ocAddressXL Separated implementation is gone since long. Change-Id: I78279f631c9205202af92ad8e248f9a1226b7a19 Reviewed-on: https://gerrit.libreoffice.org/61075 Reviewed-by: Eike Rathke Tested-by: Jenkins diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index c2a9466ebbb7..59b36b2d3914 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -988,11 +988,10 @@ bool FormulaCompiler::IsOpCodeVolatile( OpCode eOp ) case ocFormula: case ocInfo: // more than one parameters: -// ocIndirect/ocIndirectXL otherwise would have to do +// ocIndirect otherwise would have to do // StopListening and StartListening on a reference for every // interpreted value. case ocIndirect: -case ocIndirectXL: // ocOffset results in indirect references. case ocOffset: // ocDebugVar shows internal value that may change as the internal state changes. diff --git a/include/formula/compiler.hxx b/include/formula/compiler.hxx index 61b054c0d7cc..0d5b1cc8f632 100644 --- a/include/formula/compiler.hxx +++ b/include/formula/compiler.hxx @@ -396,8 +396,8 @@ #define SC_OPCODE_CELL 385 #define SC_OPCODE_ISPMT 386 #define SC_OPCODE_HYPERLINK 387 -#define SC_OPCODE_INDIRECT_XL 388 /* See also INDIRECT for OOO variant */ -#define SC_OPCODE_ADDRESS_XL389 /* See also ADDRESS for OOO variant */ +// free: 388 +// free: 389 #define SC_OPCODE_GET_PIVOT_DATA390 #define SC_OPCODE_EUROCONVERT 391 #define SC_OPCODE_NUMBERVALUE 392 diff --git a/include/formula/opcode.hxx b/include/formula/opcode.hxx index acc52552c00d..437403d919b2 100644 --- a/include/formula/opcode.hxx +++ b/include/formula/opcode.hxx @@ -303,9 +303,7 @@ enum OpCode : sal_uInt16 ocDBVarP= SC_OPCODE_DB_VAR_P, // Management functions ocIndirect = SC_OPCODE_INDIRECT, -ocIndirectXL= SC_OPCODE_INDIRECT_XL, ocAddress = SC_OPCODE_ADDRESS, -ocAddressXL = SC_OPCODE_ADDRESS_XL, ocMatch = SC_OPCODE_MATCH, ocCountEmptyCells = SC_OPCODE_COUNT_EMPTY_CELLS, ocCountIf = SC_OPCODE_COUNT_IF, @@ -782,9 +780,7 @@ inline std::string OpCodeEnumToString(OpCode eCode) case ocDBVar: return "DBVar"; case ocDBVarP: return "DBVarP"; case ocIndirect: return "Indirect"; -case ocIndirectXL: return "IndirectXL"; case ocAddress: return "Address"; -case ocAddressXL: return "AddressXL"; case ocMatch: return "Match"; case ocCountEmptyCells: return "CountEmptyCells"; case ocCountIf: return "CountIf"; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/inc oox/Library_oox.mk oox/source oox/util solenv/bin
oox/Library_oox.mk|1
oox/inc/pch/precompiled_oox.hxx |1
oox/inc/services.hxx | 37 -
oox/source/core/fasttokenhandler.cxx |2 -
oox/source/core/filterdetect.cxx |2 -
oox/source/core/services.cxx | 51 --
oox/source/docprop/ooxmldocpropimport.cxx |1
oox/source/ppt/dgmimport.cxx |2 -
oox/source/ppt/dgmlayout.cxx |2 -
oox/source/ppt/pptimport.cxx |2 -
oox/source/shape/ShapeContextHandler.cxx | 35 +++-
oox/util/oox.component|5 +-
solenv/bin/native-code.py |2 -
13 files changed, 16 insertions(+), 127 deletions(-)
New commits:
commit ff4a319f51fc0ea4eb2baafa22d59f51b6e46a6f
Author: Miklos Vajna
AuthorDate: Fri Sep 28 12:09:58 2018 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 28 15:10:45 2018 +0200
oox: create ShapeContextHandler instances with an uno constructor
Change-Id: Ie780ff9f3a8c61d13ad10cc2dbe24d3ec165470e
Reviewed-on: https://gerrit.libreoffice.org/61063
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/oox/Library_oox.mk b/oox/Library_oox.mk
index e917a9b866d3..941b3a1d270a 100644
--- a/oox/Library_oox.mk
+++ b/oox/Library_oox.mk
@@ -96,7 +96,6 @@ $(eval $(call gb_Library_add_exception_objects,oox,\
oox/source/core/recordparser \
oox/source/core/relations \
oox/source/core/relationshandler \
-oox/source/core/services \
oox/source/core/xmlfilterbase \
oox/source/crypto/AgileEngine \
oox/source/crypto/CryptTools \
diff --git a/oox/inc/pch/precompiled_oox.hxx b/oox/inc/pch/precompiled_oox.hxx
index 2bfc8539945a..222e9663fca5 100644
--- a/oox/inc/pch/precompiled_oox.hxx
+++ b/oox/inc/pch/precompiled_oox.hxx
@@ -187,7 +187,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/oox/inc/services.hxx b/oox/inc/services.hxx
deleted file mode 100644
index f790ce525a6b..
--- a/oox/inc/services.hxx
+++ /dev/null
@@ -1,37 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_OOX_INC_SERVICES_HXX
-#define INCLUDED_OOX_INC_SERVICES_HXX
-
-#include
-
-namespace oox {
-namespace shape {
-extern OUString ShapeContextHandler_getImplementationName();
-extern css::uno::Sequence< OUString >
ShapeContextHandler_getSupportedServiceNames();
-/// @throws css::uno::Exception
-extern css::uno::Reference< css::uno::XInterface >
ShapeContextHandler_createInstance(
-const css::uno::Reference< css::uno::XComponentContext >&
rxContext );
-}
-}
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/core/fasttokenhandler.cxx
b/oox/source/core/fasttokenhandler.cxx
index 9925204fef46..489044bbbd97 100644
--- a/oox/source/core/fasttokenhandler.cxx
+++ b/oox/source/core/fasttokenhandler.cxx
@@ -24,8 +24,6 @@
#include
#include
-#include
-
using namespace ::com::sun::star;
namespace oox {
diff --git a/oox/source/core/filterdetect.cxx b/oox/source/core/filterdetect.cxx
index cbbaae3ed333..a2e34ecd7168 100644
--- a/oox/source/core/filterdetect.cxx
+++ b/oox/source/core/filterdetect.cxx
@@ -36,8 +36,6 @@
#include
-#include
-
using namespace ::com::sun::star;
namespace oox {
diff --git a/oox/source/core/services.cxx b/oox/source/core/services.cxx
deleted file mode 100644
index 5c18b9544767..
--- a/oox/source/core/services.cxx
+++ /dev/null
@@ -1,51 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or
[Libreoffice-bugs] [Bug 91985] FILEOPEN: Link external data to html file with in table prevent correct table load
https://bugs.documentfoundation.org/show_bug.cgi?id=91985 --- Comment #13 from Jo Bobit --- I tested again the problem with the version 6.1.0 and the problem evolved a bit. I simply can't anymore link the file! When I try to link the test file, the dialog let me choose the file but do not detect any table in the file and the "Ok" stay disabled. So it's impossible to tell if the bug due to the PRE is still present. LibreOffice used: Version: 6.1.0.3 Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1 CPU threads: 8; OS: Windows 6.1; UI render: default; Locale: en-US (fr_CH); Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120154] High RAM usage ( around 300mb for 10 mins and drop to 150-200 mb)
https://bugs.documentfoundation.org/show_bug.cgi?id=120154 --- Comment #5 from Oliver Brinzing --- to be more precise: selecting [Enable Content] from "Automatic update of external links has been disabled" bar will increase memory usage (lo 6.2 ~ 330 mb, lo 6.1.2 ~ 500mb) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120154] High RAM usage ( around 300mb for 10 mins and drop to 150-200 mb)
https://bugs.documentfoundation.org/show_bug.cgi?id=120154 Oliver Brinzing changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Oliver Brinzing --- with LO 6.1.2 on my win 10 notebook i can confirm: - ram usage goes up to 500 mb - hard recalc takes a long time (several minutes) - with Tools/Options.../LibreOfffice Calc/Formula "Always recalculate" loading takes a long time too -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120182] Modify style (button and combo)not available for last in the current list (writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=120182 --- Comment #2 from Bernard TREMBLAY --- Sorry, I had closed LO and when I reopen for the same files the list into the combo is full and well displayed : more it shows the "more styles" which was not present previously (confirms an error during the loop on styles). Then I will be aware of the problem which seems to have a link with other conditions which can break the loop on the styles when building the combo. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number
https://bugs.documentfoundation.org/show_bug.cgi?id=120153 --- Comment #4 from Andy M --- Created attachment 145250 --> https://bugs.documentfoundation.org/attachment.cgi?id=145250=edit LibreOffice Finder version -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120153] {macOS} Finder shows incorrect version number
https://bugs.documentfoundation.org/show_bug.cgi?id=120153 --- Comment #3 from Andy M --- Alex: Ah - yes. I forgot not everyone uses the column view in the Finder :-) So add a step: 0) Select "as Columns" from the View menu. If you look on the right it shows the icon with information about the file/app. I'll add an attachment with a snapshot. The problem is the Info.plist is incorrect: CFBundleShortVersionString 6.1.2001 CFBundleVersion 6.1.2001 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source cui/uiconfig include/svx svx/source
cui/source/dialogs/sdrcelldlg.cxx | 17 +--
cui/source/factory/dlgfact.cxx|4
cui/source/factory/dlgfact.hxx|2
cui/source/inc/sdrcelldlg.hxx |9 --
cui/uiconfig/ui/formatcellsdialog.ui | 129 ++
include/svx/sdr/table/tablecontroller.hxx |4
include/svx/svxdlg.hxx|2
svx/source/table/tablecontroller.cxx |9 +-
8 files changed, 138 insertions(+), 38 deletions(-)
New commits:
commit 1e6b6f038af656b475cb87844822287fd4e6c166
Author: Caolán McNamara
AuthorDate: Wed Sep 26 13:38:50 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 14:03:52 2018 +0200
weld SvxFormatCellsDialog
Change-Id: I236ddc4f58b882e648512a99306440fa88a3aeeb
Reviewed-on: https://gerrit.libreoffice.org/61017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/dialogs/sdrcelldlg.cxx
b/cui/source/dialogs/sdrcelldlg.cxx
index 47dd49cbc6a5..e20a3f488209 100644
--- a/cui/source/dialogs/sdrcelldlg.cxx
+++ b/cui/source/dialogs/sdrcelldlg.cxx
@@ -25,25 +25,24 @@
#include
#include
-SvxFormatCellsDialog::SvxFormatCellsDialog( vcl::Window* pParent, const
SfxItemSet* pAttr, const SdrModel& rModel )
-: SfxTabDialog(pParent, "FormatCellsDialog",
"cui/ui/formatcellsdialog.ui", pAttr)
+SvxFormatCellsDialog::SvxFormatCellsDialog(weld::Window* pParent, const
SfxItemSet* pAttr, const SdrModel& rModel)
+: SfxTabDialogController(pParent, "cui/ui/formatcellsdialog.ui",
"FormatCellsDialog", pAttr)
, mrOutAttrs(*pAttr)
, mpColorTab(rModel.GetColorList())
, mpGradientList(rModel.GetGradientList())
, mpHatchingList(rModel.GetHatchList())
, mpBitmapList(rModel.GetBitmapList())
, mpPatternList(rModel.GetPatternList())
-, m_nAreaPageId(0)
{
AddTabPage("name", RID_SVXPAGE_CHAR_NAME);
AddTabPage("effects", RID_SVXPAGE_CHAR_EFFECTS);
-m_nBorderPageId = AddTabPage("border", RID_SVXPAGE_BORDER );
-m_nAreaPageId = AddTabPage("area", RID_SVXPAGE_AREA);
+AddTabPage("border", RID_SVXPAGE_BORDER );
+AddTabPage("area", RID_SVXPAGE_AREA);
}
-void SvxFormatCellsDialog::PageCreated( sal_uInt16 nId, SfxTabPage )
+void SvxFormatCellsDialog::PageCreated(const OString& rId, SfxTabPage )
{
-if (nId == m_nAreaPageId)
+if (rId == "area")
{
SvxAreaTabPage& rAreaPage = static_cast(rPage);
rAreaPage.SetColorList( mpColorTab );
@@ -53,13 +52,13 @@ void SvxFormatCellsDialog::PageCreated( sal_uInt16 nId,
SfxTabPage )
rAreaPage.SetPatternList( mpPatternList );;
rAreaPage.ActivatePage( mrOutAttrs );
}
-else if (nId == m_nBorderPageId)
+else if (rId == "border")
{
SvxBorderTabPage& rBorderPage = static_cast(rPage);
rBorderPage.SetTableMode();
}
else
-SfxTabDialog::PageCreated( nId, rPage );
+SfxTabDialogController::PageCreated(rId, rPage);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index d32d0a817e90..e48e1f87d11c 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -1618,9 +1618,9 @@ VclPtr
AbstractDialogFactory_Impl::CreateLinksDialog( vc
return VclPtr::Create( pLinkDlg );
}
-VclPtr
AbstractDialogFactory_Impl::CreateSvxFormatCellsDialog( const SfxItemSet*
pAttr, const SdrModel& rModel, const SdrObject* /*pObj*/ )
+VclPtr
AbstractDialogFactory_Impl::CreateSvxFormatCellsDialog(weld::Window* pParent,
const SfxItemSet* pAttr, const SdrModel& rModel, const SdrObject* /*pObj*/)
{
-return VclPtr::Create(
VclPtr::Create( nullptr, pAttr, rModel ) );
+return
VclPtr::Create(o3tl::make_unique(pParent,
pAttr, rModel));
}
VclPtr
AbstractDialogFactory_Impl::CreateSvxSplitTableDialog(weld::Window* pParent,
bool bIsTableVertical, long nMaxVertical)
diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx
index 3a1acd506334..2316ff7be199 100644
--- a/cui/source/factory/dlgfact.hxx
+++ b/cui/source/factory/dlgfact.hxx
@@ -824,7 +824,7 @@ public:
const sal_uInt16 _nInitiallySelectedEvent
) override;
-virtual VclPtr CreateSvxFormatCellsDialog( const
SfxItemSet* pAttr, const SdrModel& rModel, const SdrObject* pObj ) override;
+virtual VclPtr
CreateSvxFormatCellsDialog(weld::Window* pParent, const SfxItemSet* pAttr,
const SdrModel& rModel, const SdrObject* pObj) override;
virtual VclPtr
CreateSvxSplitTableDialog(weld::Window* pParent, bool bIsTableVertical, long
nMaxVertical) override;
diff --git a/cui/source/inc/sdrcelldlg.hxx b/cui/source/inc/sdrcelldlg.hxx
index 0a38f759a494..50ab4b39ac70 100644
--- a/cui/source/inc/sdrcelldlg.hxx
+++ b/cui/source/inc/sdrcelldlg.hxx
@@ -25,7 +25,7 @@
#include
class SdrModel;
-class SvxFormatCellsDialog : public SfxTabDialog
+class
[Libreoffice-commits] core.git: cui/source cui/uiconfig extras/source include/svx include/vcl sc/qa svx/source vcl/inc vcl/source vcl/unx
cui/source/inc/numfmt.hxx | 126 +--
cui/source/tabpages/chardlg.cxx|8
cui/source/tabpages/numfmt.cxx | 990 +++--
cui/source/tabpages/tpcolor.cxx|2
cui/uiconfig/ui/numberingformatpage.ui | 188 +++-
extras/source/glade/libreoffice-catalog.xml.in |6
include/svx/langbox.hxx|9
include/vcl/lstbox.hxx |2
include/vcl/weld.hxx | 15
sc/qa/uitest/calc_tests/formatCells.py |2
svx/source/dialog/langbox.cxx | 10
vcl/inc/listbox.hxx|6
vcl/source/app/salvtables.cxx |5
vcl/source/control/imp_listbox.cxx | 15
vcl/source/control/listbox.cxx |5
vcl/unx/gtk3/gtk3gtkinst.cxx |8
16 files changed, 716 insertions(+), 681 deletions(-)
New commits:
commit 0b3ca6a1fa6d2eaaf97254fd1d45e2ac7b3a
Author: Caolán McNamara
AuthorDate: Mon Sep 24 16:39:18 2018 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 28 14:03:24 2018 +0200
weld SvxNumberFormatTabPage
Change-Id: Ia6e6497d5c9b6c47e34e5cb5b3913d25e73c3a69
Reviewed-on: https://gerrit.libreoffice.org/60944
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/inc/numfmt.hxx b/cui/source/inc/numfmt.hxx
index a3ff4a070e40..6fb600fbc41c 100644
--- a/cui/source/inc/numfmt.hxx
+++ b/cui/source/inc/numfmt.hxx
@@ -25,39 +25,37 @@
#include
#include
#include
-#include
-#include
-#include
+#include
#include
-#include
-#include
-
+#include
class SvxNumberFormatShell;
class SvxNumberInfoItem;
class vector;
-class SvxNumberPreview : public vcl::Window
+class SvxNumberPreview : public weld::CustomWidgetController
{
private:
OUStringaPrevStr;
Color aPrevCol;
sal_Int32 mnPos;
sal_Unicode mnChar;
-voidInitSettings( bool bForeground, bool bBackground );
protected:
-virtual voidPaint( vcl::RenderContext& /*rRenderContext*/, const
::tools::Rectangle& rRect ) override;
-virtual voidStateChanged( StateChangedType nStateChange ) override;
-virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
+virtual voidPaint(vcl::RenderContext& rRenderContext, const
::tools::Rectangle& rRect) override;
public:
-SvxNumberPreview(vcl::Window* pParent);
+SvxNumberPreview();
voidNotifyChange( const OUString& rPrevStr, const Color*
pColor = nullptr );
-};
+virtual void SetDrawingArea(weld::DrawingArea* pDrawingArea) override
+{
+CustomWidgetController::SetDrawingArea(pDrawingArea);
+pDrawingArea->set_size_request(-1, pDrawingArea->get_text_height() *
3);
+}
+};
class SvxNumberFormatTabPage : public SfxTabPage
{
@@ -79,41 +77,9 @@ public:
virtual DeactivateRCDeactivatePage ( SfxItemSet* pSet ) override;
voidHideLanguage(bool bFlag=true);
-virtual boolPreNotify( NotifyEvent& rNEvt ) override;
virtual voidPageCreated(const SfxAllItemSet& aSet) override;
private:
-SvxNumberFormatTabPage( vcl::Window* pParent,
-const SfxItemSet& rCoreAttrs );
-VclPtr m_pFtCategory;
-VclPtrm_pLbCategory;
-VclPtr m_pFtFormat;
-VclPtrm_pLbCurrency;
-VclPtr m_pLbFormat;
-VclPtr m_pFtLanguage;
-VclPtr m_pLbLanguage;
-VclPtr m_pCbSourceFormat;
-VclPtr m_pWndPreview;
-VclPtr m_pFtOptions;
-VclPtr m_pFtDecimals;
-VclPtr m_pEdDecimals;
-VclPtr m_pFtDenominator;
-VclPtr m_pEdDenominator;
-VclPtr m_pBtnNegRed;
-VclPtr m_pFtLeadZeroes;
-VclPtr m_pEdLeadZeroes;
-VclPtr m_pBtnThousand;
-VclPtr m_pBtnEngineering;
-
-VclPtr m_pFormatCodeFrame;
-VclPtr m_pEdFormat;
-VclPtr m_pIbAdd;
-VclPtr m_pIbInfo;
-VclPtr m_pIbRemove;
-
-VclPtr m_pFtComment;
-VclPtr m_pEdComment;
-Timer aResetWinTimer;
-
+SvxNumberFormatTabPage(TabPageParent pParent, const SfxItemSet&
rCoreAttrs);
std::unique_ptrpNumItem;
std::unique_ptr pNumFmtShell;
@@ -122,11 +88,39 @@ private:
boolbNumItemFlag; ///< for handling with DocShell
boolbOneAreaFlag;
+boolbLegacyAutomaticCurrency;
short nFixedCategory;
-OUString sAutomaticEntry;
-
-VclPtrpLastActivWindow;
+OUString
[Libreoffice-commits] core.git: ios/CustomTarget_iOS_setup.mk ios/UnitTest libreofficekit/qa
ios/CustomTarget_iOS_setup.mk | 11
ios/UnitTest/UnitTest.xcodeproj/project.pbxproj | 470
ios/UnitTest/UnitTest/AppDelegate.h | 16
ios/UnitTest/UnitTest/AppDelegate.m | 52 ++
ios/UnitTest/UnitTest/Info.plist| 45 ++
ios/UnitTest/UnitTest/ViewController.h | 14
ios/UnitTest/UnitTest/ViewController.mm | 75 +++
ios/UnitTest/UnitTest/main.m| 18
libreofficekit/qa/tilebench/tilebench.cxx | 16
9 files changed, 705 insertions(+), 12 deletions(-)
New commits:
commit 68de1021353902d48ddd712f5e6fedc51c57936d
Author: Tor Lillqvist
AuthorDate: Thu Sep 27 18:08:07 2018 +0200
Commit: Tor Lillqvist
CommitDate: Fri Sep 28 14:03:05 2018 +0200
Start on the iOS unit test app
Change-Id: Idef0b375d5c7d6d4542aee1f8abecaf9f834189c
Reviewed-on: https://gerrit.libreoffice.org/61058
Reviewed-by: Tor Lillqvist
Tested-by: Tor Lillqvist
diff --git a/ios/CustomTarget_iOS_setup.mk b/ios/CustomTarget_iOS_setup.mk
index 3f6f5eac90ac..df94b4ef2688 100644
--- a/ios/CustomTarget_iOS_setup.mk
+++ b/ios/CustomTarget_iOS_setup.mk
@@ -21,8 +21,7 @@ IOSDIRS = $(IOSGEN) \
$(IOSRES)/program \
$(IOSRES)/share \
$(IOSRES)/config \
- $(IOSRES)/filter \
- $(WORKDIR)/ios
+ $(IOSRES)/filter
#- Top level -
@@ -41,13 +40,10 @@ $(IOSDIRS):
$(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk \
$(SRCDIR)/ios/CustomTarget_iOS_setup.mk \
$(SRCDIR)/solenv/bin/native-code.py \
-$(IOSGEN) $(WORKDIR)/ios \
+$(IOSGEN) \
$(IOSDIRS)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),EN2,2)
- # Secure LibreOffice.c get build if there are changes
- rm -rf $(WORKDIR)/ios/*
-
# generate native-code.h (used by LibreOffice.c)
$(SRCDIR)/solenv/bin/native-code.py \
-C -g core -g writer -g calc -g draw -g edit \
@@ -111,7 +107,6 @@ $(IOSGEN)/native-code.h: $(BUILDDIR)/config_host.mk \
#- clean ios -
$(call gb_CustomTarget_get_clean_target,ios/iOS_setup):
$(call gb_Output_announce,$(subst $(WORKDIR)/Clean/,,$@),$(false),ENV,2)
- rm -rf $(IOSRES)/* $(IOSGEN)/native-code.h $(IOSGEN)/build
- rm -rf $(WORKDIR)/ios
+ rm -rf $(IOSRES)/* $(IOSGEN)/native-code.h $(IOSGEN)
# vim: set noet sw=4 ts=4:
diff --git a/ios/UnitTest/UnitTest.xcodeproj/project.pbxproj
b/ios/UnitTest/UnitTest.xcodeproj/project.pbxproj
new file mode 100644
index ..8a49473ded43
--- /dev/null
+++ b/ios/UnitTest/UnitTest.xcodeproj/project.pbxproj
@@ -0,0 +1,470 @@
+// !$*UTF8*$!
+{
+ archiveVersion = 1;
+ classes = {
+ };
+ objectVersion = 50;
+ objects = {
+
+/* Begin PBXBuildFile section */
+ BE39ADD7215D547B0244 /* test.odt in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADD6215D547B0244 /* test.odt */; };
+ BE39ADEF215D5AA4000B0244 /* icudt62l.dat in Resources */ = {isa
= PBXBuildFile; fileRef = BE39ADE0215D5AA3000B0244 /* icudt62l.dat */; };
+ BE39ADF0215D5AA4000B0244 /* fundamentalrc in Resources */ =
{isa = PBXBuildFile; fileRef = BE39ADE1215D5AA3000B0244 /* fundamentalrc */; };
+ BE39ADF1215D5AA4000B0244 /* services in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE2215D5AA3000B0244 /* services */; };
+ BE39ADF2215D5AA4000B0244 /* share in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE3215D5AA3000B0244 /* share */; };
+ BE39ADF3215D5AA4000B0244 /* oovbaapi.rdb in Resources */ = {isa
= PBXBuildFile; fileRef = BE39ADE4215D5AA3000B0244 /* oovbaapi.rdb */; };
+ BE39ADF4215D5AA4000B0244 /* program in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE5215D5AA3000B0244 /* program */; };
+ BE39ADF5215D5AA4000B0244 /* config in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE6215D5AA3000B0244 /* config */; };
+ BE39ADF6215D5AA4000B0244 /* services.rdb in Resources */ = {isa
= PBXBuildFile; fileRef = BE39ADE7215D5AA3000B0244 /* services.rdb */; };
+ BE39ADF7215D5AA4000B0244 /* registry in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE8215D5AA3000B0244 /* registry */; };
+ BE39ADF8215D5AA4000B0244 /* offapi.rdb in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADE9215D5AA3000B0244 /* offapi.rdb */; };
+ BE39ADF9215D5AA4000B0244 /* udkapi.rdb in Resources */ = {isa =
PBXBuildFile; fileRef = BE39ADEA215D5AA3000B0244 /* udkapi.rdb */; };
+ BE39ADFA215D5AA4000B0244 /* rc in Resources */ = {isa =
PBXBuildFile; fileRef =
[Libreoffice-bugs] [Bug 120182] Modify style (button and combo)not available for last in the current list (writer)
https://bugs.documentfoundation.org/show_bug.cgi?id=120182 Dieter Praas changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #1 from Dieter Praas --- Is it possible to add a screenshot, that shows the problem? Thanks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
